1 2007-06-02 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-connection-specific-smtp-window.c: Add an
4 introductory note to the connection specific smtp servers dialog, as
5 section 8.12 of the email UI specification requires. This fixes
6 projects.maemo.org bug NB#59212.
8 2007-06-01 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
11 Check for running mail operations, and offer to cancel them, as per the UI
12 spec. This fixes projects.maemo.org bug NB#59041 .
13 However, I suspect that tinymail may still use the network connection
14 in ways that we cannot detect or cancel. But it should at least adapt to
17 2007-06-01 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-tny-account-store.c: (recreate_all_accounts),
20 (get_cached_accounts), (get_server_accounts): Do more sensible
21 ref-counting of the temporarily-cached outbox accounts list. This seems
22 to fix a crash when entering the password when the password was wrong.
24 2007-06-01 Murray Cumming <murrayc@murrayc.com>
26 * src/gnome/modest-main-window.c: (connect_signals):
27 * src/modest-tny-account-store.c: (get_password),
28 (modest_tny_account_store_alert): Added comments and clues and
29 commented-out code about how we currently fail to deal with connection
30 errors and wrong passwords, and how we should.
32 2007-06-01 Murray Cumming <murrayc@murrayc.com>
34 * src/widgets/modest-retrieve-combo-box.c:
35 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
36 This fixes projects.maemo.org bug NB#58472 .
38 2007-06-01 Murray Cumming <murrayc@murrayc.com>
40 * src/maemo/easysetup/modest-easysetup-wizard.c:
41 (create_page_complete_easysetup):
42 (create_page_complete_custom): Correct the last commit,
43 putting the correct sentences in the correct pages.
45 2007-06-01 Murray Cumming <murrayc@murrayc.com>
47 * src/maemo/easysetup/modest-easysetup-wizard.c:
48 (create_page_complete_custom): Show the second sentence of text
49 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
52 2007-06-01 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
55 Set the leave-on-server conf key by default. This fixes
56 projects.maemo.org bug NB#59258 .
58 2007-06-01 Murray Cumming <murrayc@murrayc.com>
60 * src/maemo/modest-account-view-window.c:
61 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
62 logical ID for the confirmation messages. Fixed projects.maemo.org bug
65 2007-06-01 Murray Cumming <murrayc@murrayc.com>
67 * src/maemo/easysetup/modest-easysetup-wizard.c:
68 (create_caption_new_with_asterisk):
69 * src/maemo/modest-account-settings-dialog.c:
70 (create_caption_new_with_asterisk):
71 Uncomment the code to add the asterisk, because they are no longer in the
72 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
73 (update_incoming_server_title): Add an asterisk here too.
75 2007-06-01 Murray Cumming <murrayc@murrayc.com>
77 * src/maemo/modest-maemo-global-settings-dialog.c:
78 (current_connection): Check that we are even connected before trying to
79 get the current connection name, to prevent a warning.
81 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
82 Change the comments because tny_maemo_conic_device_connect() is now meant to
84 * src/modest-mail-operation.c:
85 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
86 make sure we have a connection and fail if we can't connect.
88 2007-05-31 Murray Cumming <murrayc@murrayc.com>
90 * src/maemo/modest-main-window.c:
91 (on_account_store_connecting_finished): Do not try to get the
92 connection ID if we are not really connected. I am surprised that
93 this signal handler is called when we are not connected.
95 2007-05-31 Murray Cumming <murrayc@murrayc.com>
98 * src/modest-ui-actions.c:
99 (modest_ui_actions_get_msgs_full_error_handler):
100 Renamed an enum, added comments, added an enum
101 for retrieve-limit errors.
103 * src/modest-mail-operation.c: (foreach_add_item),
104 (internal_folder_observer_update), (update_account_thread),
105 (modest_mail_operation_get_msgs_full):
106 (modest_mail_operation_update_account),
107 Added comments about how this works, and some code that should
108 (but does not) check the retrieve-limit. See the TODO comment.
110 2007-05-31 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
113 Initialize help_id to fix the build. Warnings are good.
115 2007-05-31 Murray Cumming <murrayc@murrayc.com>
117 * src/widgets/modest-hbox-cell-renderer.c:
118 (modest_hbox_cell_renderer_append):
119 * src/widgets/modest-vbox-cell-renderer.c:
120 (modest_vbox_cell_renderer_append):
121 Fix the last commit by doing an extra ref.
123 2007-05-31 Murray Cumming <murrayc@murrayc.com>
125 * src/widgets/modest-hbox-cell-renderer.c:
126 (modest_hbox_cell_renderer_append):
127 * src/widgets/modest-vbox-cell-renderer.c:
128 (modest_vbox_cell_renderer_append):
129 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
130 to fix the build with Maemo Bora.
131 However, there seems to be a remaining crash, probably due to reference
134 2007-05-30 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-tny-account.c:
137 (modest_tny_account_new_for_local_folders):
138 Use hildon_file_system_info_async_new() to get a better name for
139 the memory card account, setting it as the account name.
140 The timing seems to work, but this is probably
141 not the best place to do this. See the TODO comment.
142 * src/maemo/modest-main-window.c: (create_details_widget):
143 * src/widgets/modest-folder-view.c: (text_cell_data):
144 Use the tny account name instead of hardcoding a name.
146 2007-05-30 Christian Kellner <ckellner@openismus.com>
148 * src/modest-search.c: (modest_search):
149 Correctly set part_search_func even if we have already parsed
150 the query and thus a valid OgsTextSearcher object.
152 2007-05-30 Christian Kellner <ckellner@openismus.com>
155 Search and check for libogs.
158 Incooparte the ogs build env.
160 * src/modest-mime-part-search-stream.c:
161 * src/modest-mime-part-search-stream.h:
162 Removed since we do the real searching now in modest-search.c.
164 * src/modest-search.c:
165 * src/modest-search.h:
166 Implement support for ogs. We use that if available and requested
167 and fall back to modest_text_utils_utf8_strcmp (). The search logic
168 should now handle the corner case when the search term is spread
169 across multiple reads.
170 Also the logic in modest_search () was corrected to search all
171 requested fields until one is found.
173 2007-05-30 Murray Cumming <murrayc@murrayc.com>
175 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
178 * src/modest-init.c: Made modest_init_local_folders() take a
179 path and be public so we can iniitialize maildir folders on
182 * src/modest-local-folder-info.h:
183 * src/modest-local-folder-info.c:
184 (modest_local_folder_info_get_maildir_path): Add a path parameter.
186 * src/modest-tny-account.c:
187 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
188 still means the standard local-folders path on the local volume.
190 * src/modest-tny-account-store.c:
191 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
192 signal so we can detect mount/unmount of the MMC1 card, and do an update of
193 all accounts when that happens.
194 (get_server_accounts): If the MMC1 card is mounted, create a store account for
195 this too, so it shows up in the treeview.
197 2007-05-28 Murray Cumming <murrayc@murrayc.com>
199 * src/maemo/modest-maemo-global-settings-dialog.c:
200 (current_connection):
201 * src/widgets/modest-global-settings-dialog.c:
202 (current_connection_default):
203 Use the enum values instead of 0, 1 and -1,
204 to make the code clearer.
206 * src/modest-account-mgr-helpers.c:
207 (modest_account_mgr_get_connection_specific_smtp): Make this code
210 * src/modest-runtime.h:
211 * src/modest-runtime.c:
212 Added modest_runtime_remove_all_send_queues().
213 * src/maemo/modest-main-window.c:
214 (on_account_store_connecting_finished): Recreate the send queues,
215 using the appropriate transport accounts for this new connection.
216 Some futher adapting might be needed if the old send queues are not
217 automatically stopped at this point.
219 * src/modest-tny-account-store.c: (get_server_accounts):
220 Create the connection-specific transport accounts, so that they can
221 be found later by their ID.
223 * src/modest-tny-account.h:
224 * src/modest-tny-account.c:
225 Added modest_tny_account_new_from_server_account_name().
226 modest_tny_account_new_from_server_account(): Do not create the
227 send queues here, because they will be
228 recreated anyway when the connection changes for the first time.
230 2007-05-28 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-local-folder-info.h:
233 * src/modest-local-folder-info.c:
234 (modest_per_account_local_outbox_folder_info_get_maildir_path),
235 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
236 tbox_folder): Take a modest account name instead of a server TnyAccount,
237 so we can have per-modest-account rather than per-transport-account
239 We must make sure that we change or recreate the exisitng send queues
240 when the connection changes for connection-specific transport accounts.
242 * src/modest-tny-account-store.c:
243 (create_per_account_local_outbox_folders): Create outboxed per modest
244 account, not per transport account.
246 * src/modest-tny-account.h:
247 * src/modest-tny-account.c:
248 (modest_tny_account_get_special_folder): For outboxes, get the
249 parent modest account name. The account is ignored for other folders.
250 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
251 modest account name rather than a server TnyAccount.
253 2007-05-25 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-tny-account.c:
256 (modest_tny_account_new_from_server_account):
257 Call modest_runtime_get_send_queue() immediately after creating transport
258 accounts, so that they start trying to send email from the outbox as soon
259 as possible at startup. This is probably what we want.
261 * src/modest-mail-operation.c: (update_account_thread):
262 * src/modest-runtime.c: (modest_runtime_get_send_queue):
263 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
264 * src/modest-tny-send-queue.h:
265 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
266 (modest_ui_actions_on_send):
267 Added comments about how sending works, though it needs some more work.
269 2007-05-25 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-tny-account.c:
272 (modest_tny_account_get_special_folder): Add TODO because this fails when
274 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
275 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
276 Do not try to show this window when there is no active account. The UI
277 specs does not tell us what to do in this case.
279 2007-05-24 Murray Cumming <murrayc@murrayc.com>
283 * src/maemo/Makefile.am:
284 * src/widgets/Makefile.am: Some dist fixes.
286 2007-05-24 Murray Cumming <murrayc@murrayc.com>
288 * src/maemo/modest-connection-specific-smtp-window.c:
289 (on_button_edit): Make the code clearer, to prevent a double free.
291 2007-05-24 Murray Cumming <murrayc@murrayc.com>
293 * src/maemo/modest-account-settings-dialog.c:
294 (modest_account_settings_dialog_set_account_name),
295 Check the connection-specific smtp servers checkbox if there are any.
297 * src/maemo/modest-connection-specific-smtp-edit-window.c:
298 (modest_connection_specific_smtp_edit_window_init):
299 Start with a suitable port number.
301 * src/modest-account-mgr-helpers.h:
302 * src/modest-account-mgr-helpers.c: Added
303 modest_account_mgr_get_has_connection_specific_smtp().
305 (modest_account_mgr_set_connection_specific_smtp),
306 (modest_account_mgr_remove_connection_specific_smtp),
307 (modest_account_mgr_get_has_connection_specific_smtp),
308 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
309 connection-specific smtp server accounts in the account, rather than
310 the server account conf dir.
312 This fixes bug projects.maemo.org bug NB#58263 .
314 * src/modest-tny-account-store.c:
315 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
316 if there are no server accounts yet, to prevent an infinite loop when there
317 are no accounts. Document that one must be called before the other.
319 2007-05-24 Murray Cumming <murrayc@murrayc.com>
321 * src/modest-account-mgr-helpers.c:
322 (modest_account_mgr_get_default_account): Make sure that at least
323 one account is always the default, if there are any enabled accounts.
324 This is just a sanity check that shouldn't be necessary.
326 * src/modest-account-mgr-priv.c:
327 (_modest_account_mgr_account_from_key): Unescape the conf key to
328 get the real account name. For instance, this is an issue if a space
329 was in the account name, which can happen because the account name
330 is generated from the display name.
331 (_modest_account_mgr_get_account_keyname): Always escape the
333 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
334 Unescape the conf keys to get the real account names.
336 For instance, previously the is-default radio button in the accounts
337 list was not checked for any accounts at first. This fixes that,
338 and might fix several similar bugs.
340 2007-05-23 Murray Cumming <murrayc@murrayc.com>
342 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
343 Removed some debug printfs.
345 2007-05-23 Murray Cumming <murrayc@murrayc.com>
347 Modest on-disk outbox directories are now here, for instance:
348 $HOME/.modest/outboxes/<account-id-1>/outbox
349 $HOME/.modest/outboxes/<account-id-2>/outbox
351 $HOME/.modest/local-folders/outbox
352 so we can have a separate outbox for each account.
353 But they are shown as one outbox in the GtkTreeView, by using a
354 TnyMergeFolder in a ModestTnySimpleFolderStore.
357 * src/modest-tny-simple-folder-store.c:
358 * src/modest-tny-simple-folder-store.h:
359 Added ModestTnySimpleFolderStore, used to contain folders from
360 other folder stores, such as other accounts.
362 * src/modest-tny-outbox-account.h:
363 * src/modest-tny-outbox-account.c:
364 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
365 used for the per-account local outbox folders.
367 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
368 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
369 only use this (internally) now for the non-outbox local folders.
372 * src/modest-init.c: Added modest_init_one_local_folder(), for
373 setting up the directory structure for each local folder.
375 * src/modest-local-folder-info.c:
376 (modest_per_account_local_outbox_folder_info_get_maildir_path),
377 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
379 * src/modest-local-folder-info.h:
380 * src/modest-tny-account-store.c: (on_account_removed),
381 (on_account_changed), (create_per_account_local_outbox_folders),
382 (get_server_accounts), (modest_tny_account_store_get_accounts),
383 (modest_tny_account_store_get_tny_account_by_account),
384 (modest_tny_folder_store_is_virtual_local_folders):
386 * src/modest-tny-account.h:
387 * src/modest-tny-account.c:
388 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
389 to create an on-disk per-account local outbox folder for each
391 (create_per_account_local_outbox_folders): Create a local outbox folder
392 for each transport account.
393 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
394 for all local folders.
396 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
397 instead of using g_object_get/set() directly. It is clearer.
399 (modest_tny_folder_store_get_message_count),
400 (modest_tny_folder_store_get_local_size
401 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
402 because we now use these with non-acount folder stores.
404 (modest_tny_account_get_special_folder),
405 (modest_tny_account_new_from_server_account),
406 (modest_tny_account_new_from_account):
407 (recurse_folders): Adjust to the new outbox system.
409 * src/modest-tny-folder.h:
410 * src/modest-tny-folder.c:
411 (modest_tny_folder_is_local_folder),
412 (modest_tny_folder_get_local_folder_type),
413 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
415 * src/widgets/modest-main-window.h:
416 * src/maemo/modest-main-window.c: (create_details_widget),
417 (modest_main_window_set_contents_style): Show details for any folder store,
420 (modest_tny_folder_get_rules):
421 Remove the const. C does not support constness enough for this.
423 * src/modest-ui-actions.c:
424 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
425 make all outboxes appear as one, in the usual local-folders tree node.
427 (set_active_account_from_tny_account),
428 (modest_ui_actions_on_folder_selection_changed):
429 * src/widgets/modest-folder-view.c: (text_cell_data),
430 (icon_cell_data), (filter_row),
431 (add_account_folders_to_merged_folder),
432 (add_account_folders_to_simple_folder_store), (),
433 (get_cmp_rows_type_pos), (cmp_rows),
434 (modest_folder_view_set_account_id_of_visible_server_account):
435 Adjust to the new outbox system, using generic folder stores and folders
438 2007-05-23 Christian Kellner <ckellner@openismus.com>
440 * src/modest-mail-operation.c:
441 (modest_mail_operation_update_account):
442 Use info->max_size instead of unintialized local var [small
443 build fix]. (Added TODO to review that change since I don't
446 2007-05-23 Marcus Bauer <marcusb@openismus.com>
448 * libmodest-dbus-client/libmodest-dbus-client.c:
449 (libmodest_dbus_client_compose_mail): function added
450 * src/dbus_api/modest-dbus-api.h:
451 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
452 (on_compose_mail): Implementation of the SendAsMail functionality
454 2007-05-22 Murray Cumming <murrayc@murrayc.com>
456 * src/modest-account-mgr.c:
457 (modest_account_mgr_add_server_account): Set the secure-connection
458 conf key for transport accounts as well as store accounts. I don't know
459 why the if was there. For instance, this makes sure that we use SSL
460 for the gmail preset from the easysetup wizard.
462 2007-05-22 Murray Cumming <murrayc@murrayc.com>
464 * src/gnome/modest-main-window.c:
465 (on_account_store_connecting_finished), (connect_signals):
466 * src/maemo/modest-main-window.c:
467 (on_account_store_connecting_finished), (connect_signals),
468 (modest_main_window_new):
469 Handle TnyAccountStore::connecting-finished instead of
470 TnyDevice::connection-changed, because we cannot actually perform
471 operations on accounts until TnyAccountStore has itself responded to
472 the TnyDevice::connection-changed signal. This prevents a GError from
474 Do not try to update at startup, because we (at least on scratchbox)
475 already do an update at startup when the device goes online.
476 This prevents a GError from tinymail.
477 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
478 Added TODO about stopping simultaneous operations.
480 2007-05-21 Murray Cumming <murrayc@murrayc.com>
482 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
483 * src/modest-mail-operation-queue.c:
484 (modest_mail_operation_queue_remove):
485 * src/modest-tny-account-store.c: When GErrors happen, give more clues
486 about where they happened.
488 2007-05-21 Murray Cumming <murrayc@murrayc.com>
490 * src/modest-ui-actions.c:
491 (modest_ui_actions_on_password_requested): Make sure that the remember
492 output parameter is always TRUE.
494 2007-05-21 Murray Cumming <murrayc@murrayc.com>
496 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
497 Show a OK/Cancel dialog if the error is a question, though we still do not
498 know anything more about what we are asking the user.
499 * src/widgets/modest-folder-view.c: (on_drag_data_received):
500 Fix an uninitialized variable (helper). This is a logic error, however.
502 2007-05-21 Christian Kellner <ckellner@openismus.com>
504 * src/modest-search.h:
505 Correct bit shifting in the ModestSearchFlags enum.
507 2007-05-21 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-tny-account.c:
510 (modest_tny_account_new_from_server_account): Do not use the lsub and
511 check-all hard-coded IMAP options when using POP.
513 2007-05-21 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-tny-account.c:
516 (modest_tny_account_new_from_server_account):
517 Use NULL for the secure-auth method for POP when Password auth has been
518 specified by the user, as we already do for IMAP. "auth=Login" causes
519 an error from camel or the server.
521 2007-05-17 Murray Cumming <murrayc@murrayc.com>
523 * src/maemo/modest-account-settings-dialog.c:
524 (create_page_account_details),
525 (modest_account_settings_dialog_set_account_name):
526 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
527 for the leave-on-server checkbox, rathr than just the checkbox, when
528 the protocol is not POP.
530 2007-05-17 Murray Cumming <murrayc@murrayc.com>
532 * src/widgets/modest-account-view.c:
533 * src/widgets/modest-account-view.h:
534 Added modest_account_view_select_account() which will be useful later
535 to asynchronously re-select the edited account.
537 2007-05-17 Murray Cumming <murrayc@murrayc.com>
539 * src/maemo/modest-account-settings-dialog.c:
540 (modest_account_settings_dialog_set_account_name):
541 Automatically choose the port numbers based on the secure authentication
542 methods, if they have not been chosen before.
543 This fixes projects.maemo.org bug NB#56273 .
545 2007-05-17 Murray Cumming <murrayc@murrayc.com>
547 * src/maemo/modest-main-window-ui.h:
548 * src/modest-ui-actions.c:
549 * src/modest-ui-actions.h:
550 Connect the Tools/SMTP Servers menu item to
551 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
552 SMTP servers dialog, as in the UI specification and saves changes when it
553 is closed. This fixed projects.maemo.org bug NB#56305 .
555 2007-05-17 Murray Cumming <murrayc@murrayc.com>
557 * src/maemo/modest-connection-specific-smtp-window.c:
558 (modest_connection_specific_smtp_window_init):
559 Use gtk_window_set_default_size() to make this window big enough, so
560 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
562 2007-05-17 Murray Cumming <murrayc@murrayc.com>
564 * src/maemo/modest-connection-specific-smtp-edit-window.h:
565 * src/maemo/modest-connection-specific-smtp-edit-window.c:
566 (modest_connection_specific_smtp_edit_window_init),
567 Do not try to connect to a combobox signal before the combobox exists.
568 This fixes the cras in projects.maemo.org bug NB#56288 .
569 (modest_connection_specific_smtp_edit_window_get_settings):
570 Remove the server_account_name parameter which was being checked for NULL
571 though it was not used.
573 * src/maemo/modest-connection-specific-smtp-window.c:
574 (modest_connection_specific_smtp_window_fill_with_connections),
575 (on_button_edit), (modest_connection_specific_smtp_window_init):
576 Correct the number of treemodel columns to prevent a warning.
577 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
578 libconic does not work.
580 2007-05-16 Murray Cumming <murrayc@murrayc.com>
582 * src/modest-tny-account.c:
583 (modest_tny_account_new_from_server_account):
584 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
585 SMTP when "None" was chosen by the user. However, with my SMTP server that
586 does not support ANONYMOUS, the emails do not leave the Outbox and I see
589 2007-05-16 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
592 to explain the memory management issue with the ID in the ModestPair.
594 * src/gnome/modest-account-assistant.c: (add_receiving_page),
595 (add_sending_page), (modest_account_assistant_finalize):
596 * src/gnome/modest-gnome-global-settings-dialog.c:
597 (create_updating_page), (create_composing_page):
598 * src/gnome/modest-msg-edit-window.c: (get_transports),
599 (init_window), (modest_msg_edit_window_finalize),
600 (modest_msg_edit_window_get_msg_data):
601 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
602 * src/gnome/modest-transport-widget.c:
603 (modest_transport_widget_finalize), (smtp_configuration):
604 * src/maemo/modest-maemo-global-settings-dialog.c:
605 (create_updating_page), (create_composing_page):
606 * src/maemo/modest-msg-edit-window.c: (get_transports),
607 (init_window), (modest_msg_edit_window_finalize),
608 (modest_msg_edit_window_get_msg_data),
609 (modest_msg_edit_window_free_msg_data):
610 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
611 (modest_store_widget_finalize):
612 * src/maemo/modest-transport-widget.c:
613 (modest_transport_widget_finalize), (smtp_configuration):
614 * src/modest-main.c: (send_mail):
615 * src/widgets/modest-combo-box.h:
616 * src/widgets/modest-global-settings-dialog-priv.h:
617 * src/widgets/modest-global-settings-dialog.c:
618 (modest_global_settings_dialog_finalize):
619 * src/widgets/modest-msg-edit-window.h:
620 Whenever using modest_combo_box_new(), keep the ModestPairList alive
621 as long as the combo box, to prevent use of freed memory for the ID.
623 2007-05-15 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
626 get_accounts(), to make this clearer. Do not check for the enabled gconf
627 key, because we do not use this for server accounts (at least, not yet).
628 This allows us to send email again.
630 2007-05-15 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/modest-platform.c:
633 (on_modest_conf_update_interval_changed), (modest_platform_init):
634 Only respond to this particular key change. All these strcmp()s cannot be
637 2007-05-15 Murray Cumming <murrayc@murrayc.com>
639 * src/maemo/modest-maemo-global-settings-dialog.c:
640 (current_connection): Prevent a crash in scratchbox when
641 ny_maemo_conic_device_get_current_iap_id() returns NULL.
642 * src/maemo/modest-platform.c:
643 (on_modest_conf_update_interval_changed), (modest_platform_init):
644 Get the update interval from gconf and reset it when the gconf key changes.
646 2007-05-15 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-protocol-info.c:
649 * src/modest-protocol-info.h: Adde enum-specific get functions,
650 instead of using a ModestProtocolType enum parameter.
652 * src/gnome/modest-account-assistant.c:
653 * src/gnome/modest-store-widget.c:
654 * src/gnome/modest-store-widget.h:
655 * src/gnome/modest-transport-widget.c:
656 * src/gnome/modest-transport-widget.h:
657 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
658 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
659 * src/maemo/easysetup/modest-easysetup-wizard.c:
660 * src/maemo/modest-account-settings-dialog.c:
661 * src/maemo/modest-account-settings-dialog.h:
662 * src/maemo/modest-store-widget.c:
663 * src/maemo/modest-store-widget.h:
664 * src/maemo/modest-transport-widget.c:
665 * src/maemo/modest-transport-widget.h:
666 * src/modest-account-mgr-helpers.c:
667 * src/modest-account-mgr-helpers.h:
668 * src/modest-account-mgr.c:
669 * src/modest-account-mgr.h:
670 * src/modest-tny-account.c:
671 * src/modest-tny-folder.c:
672 * src/widgets/modest-account-view.c:
673 * src/widgets/modest-retrieve-combo-box.c:
674 * src/widgets/modest-retrieve-combo-box.h:
675 * src/widgets/modest-secureauth-combo-box.c:
676 * src/widgets/modest-serversecurity-combo-box.c:
677 * src/widgets/modest-serversecurity-combo-box.h:
678 * tests/check_account-mgr.c:
679 Use the specific functions, and use the re-renamed enum values for GNOME too.
681 2007-05-15 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
685 so we can get the second based on the first.
687 * src/maemo/modest-account-settings-dialog.h:
688 * src/maemo/modest-account-settings-dialog.c:
689 Added get_supported_secure_authentication_methods(), though it is mostly
690 commented-out for now until the necessary API is committed to tinymail.
691 (modest_account_settings_dialog_set_account_name),
692 (save_configuration): Request the supported authentication methods from the
693 server, so we can choose a working method.
695 * src/modest-tny-account-store.h:
696 * src/modest-tny-account-store.c:
697 (modest_tny_account_store_get_session): Rename from
698 tny_account_store_get_session().
700 2007-05-14 Murray Cumming <murrayc@murrayc.com>
702 * src/modest-protocol-info.h: Split the ModestProtocol enum
703 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
704 There was no need to have these unrelated values in one enum.
706 * src/: many files: Adapted to changed enum. This makes the code a bit
707 clearer, and the compiler could catch some errors.
709 2007-05-14 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
712 Show the detailed internal camel error message when an error happens
713 during the configuration, so that our testers can give us more clues.
714 For instance, in projects.maemo.org bug NB#56910 .
716 2007-05-14 Murray Cumming <murrayc@murrayc.com>
718 * src/modest-tny-account.c:
719 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
720 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
722 2007-05-14 Murray Cumming <murrayc@murrayc.com>
724 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
725 * src/maemo/modest-account-settings-dialog.c:
726 (modest_account_settings_dialog_set_account_name),
727 (save_configuration): For the incoming secure authentication checkbox,
728 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
729 the UI specification. PLAIN does not seem to be supported for most IMAP
730 servers anyway, and I am not sure what it would mean.
731 However, we probably need to discover which of the secure-authentication
732 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
733 * src/modest-account-mgr-helpers.c:
734 (modest_account_mgr_get_server_account_data):
736 * src/modest-tny-account.c:
737 (modest_tny_account_new_from_server_account):
738 Use tny_account_set_mech() to set secure-authentication methods,
739 with some special-casing for IMAP, based on my observations of how
742 * src/modest-account-mgr-helpers.h:
743 * src/modest-account-mgr.c:
744 * src/modest-defs.h: Comment that the URI is only used for local folders.
746 2007-05-11 Murray Cumming <murrayc@murrayc.com>
748 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
749 parameter const, just to be neat.
750 * src/modest-text-utils.c: (modest_text_utils_inline):
751 End g_strconcat() with NULL, as its documentation says. This is almost
752 certainly the cause of my crash at startup on the device. Interestingly,
753 valgrind doesn't tell us about these errors.
755 2007-05-11 Murray Cumming <murrayc@murrayc.com>
757 * scripts/build-packages: Added more precise comments about how to use
758 this script, though I still get this error:
759 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
760 error building tinymail
762 2007-05-11 Murray Cumming <murrayc@murrayc.com>
764 * src/maemo/modest-main-window.c: (on_account_update):
765 Very slight cleanup, hoping to make it simpler to discover what causes
766 a crash here sometimes.
768 * src/modest-tny-account.c:
769 (modest_tny_account_new_from_server_account): Set the port. Added
770 comments about the options and a TODO comment because I need to find out
771 how to specify the secure authentication method.
773 2007-05-11 Marcus Bauer <marcusb@openismus.com>
775 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
776 changed CFlags paths form modest to libmodest
778 2007-05-10 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-account-mgr-helpers.c:
781 (modest_account_mgr_get_server_account_data),
782 (modest_account_mgr_free_server_account_data):
783 * src/modest-account-mgr-helpers.h:
784 * src/modest-account-mgr.c:
785 (modest_account_mgr_add_server_account):
787 * src/modest-tny-account.c:
788 (modest_tny_account_new_from_server_account):
789 Determine the options for tny_camel_account_add_option() here,
790 based on the settings, rather than storing them directly in gconf.
792 2007-05-10 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
795 Show a more friendly error dialog now that we expect (from the tinymail
796 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
798 2007-05-10 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/modest-main-window.c: (on_account_update): Check that
801 account_name is not NULL, to prevent a crash at startup that I am
802 seeing on the N800. I do wonder why it is NULL.
804 * src/maemo/easysetup/modest-easysetup-wizard.c:
805 (create_page_user_details):
806 * src/maemo/modest-account-settings-dialog.c:
807 (create_page_user_details), (create_page_outgoing):
808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
809 (modest_connection_specific_smtp_edit_window_init):
810 * src/modest-ui-actions.c:
811 (modest_ui_actions_on_password_requested):
812 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
813 might do something useful with the on-screen keyboard.
815 2007-05-10 Murray Cumming <murrayc@murrayc.com>
817 * src/maemo/modest-main-window.c: (on_account_update):
818 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
819 NULL, to avoid lots of warnings. However, it probably should not be NULL.
821 2007-05-09 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-tny-account-store.c: (on_account_changed):
824 Correct the signature of this signal handler.
826 2007-05-09 Murray Cumming <murrayc@murrayc.com>
828 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
829 Show a HildonNote instead of a GtkDialog for Maemo.
831 2007-05-09 Murray Cumming <murrayc@murrayc.com>
833 * src/widgets/modest-account-view.h:
834 * src/widgets/modest-account-view.c: (on_account_changed),
835 (on_account_removed). Added a boolean flag, set/unset by
836 modest_account_view_block_conf_updates(),
837 modest_account_view_unblock_conf_updates() to prevent unnecessary
838 updates, but this is not very useful because the gconf notifications are
839 so delays (maybe only on Maemo Bora).
840 So auto-updating is turned off, and these functions do an explicit
841 update when necessary.
842 However, something else is still doing too much work when adding/removing
843 accounts, probably in another part of the application.
845 * src/maemo/modest-account-view-window.c:
846 (on_delete_button_clicked), (on_edit_button_clicked),
847 (on_new_button_clicked): Use the new functions.
849 2007-05-09 Murray Cumming <murrayc@murrayc.com>
851 * src/modest-account-mgr-helpers.c:
852 (modest_account_mgr_set_first_account_as_default):
853 Sort the list of names alphabetically-by-title, so we choose the first one
855 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
856 alphabetically by the title.
858 This fixes projects.maemo.org bug NB#56418 .
860 * src/modest-account-mgr-priv.c:
861 (_modest_account_mgr_account_from_key):
862 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
863 avoid a valgrind error, and possible random behaviour.
865 2007-05-09 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
868 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
869 tinymail documentation to say that this can be expected.
870 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
871 pretty, and should not happen, but I would prefer to know when it does.
873 2007-05-09 Murray Cumming <murrayc@murrayc.com>
875 * configure.ac: When using the older hildon version, probably on Bora,
876 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
878 * src/widgets/modest-attachment-view.c:
879 (modest_attachment_view_set_part_default): Initialize variables, to fix the
882 2007-05-09 Marcus Bauer <marcusb@openismus.com>
884 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
885 Implemented the prototype. Can be tested with
886 tests/dbus_api/test_open_message:
888 2007-05-08 Murray Cumming <murrayc@murrayc.com>
890 * src/modest-tny-account-store.c:
891 (modest_tny_account_store_instance_init), (get_password):
892 * src/modest-ui-actions.c:
893 (modest_ui_actions_on_password_requested):
894 Do not store the password in gconf, because this function is called
895 for non-remembered passwords. Actually use the cached (in the hash map)
896 password instead of releasing it.
897 The password will now not be remembered if it is asked via the protected
898 password dialog, as per the UI spec.
900 2007-05-08 Murray Cumming <murrayc@murrayc.com>
903 * src/modest-account-mgr-helpers.h:
904 * src/modest-account-mgr-helpers.c:
905 Added modest_server_account_get_username_has_succeeded(),
906 modest_server_account_set_username_has_succeeded().
907 (modest_server_account_set_username),
908 Reset the has-succeeded flag if the username changes.
910 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
911 * src/maemo/modest-connection-specific-smtp-window.c:
912 (modest_connection_specific_smtp_window_save_server_accounts):
913 Use modest_server_account_set_username() instead of using
914 modest_conf_set_string() directly, so that the has-succeeded flag is always
917 * src/modest-ui-actions.c:
918 (modest_ui_actions_on_password_requested): Dim the username entry if
919 the username has ever worked, as per the UI spec.
921 2007-05-08 Murray Cumming <murrayc@murrayc.com>
923 * src/modest-tny-account-store.c: (get_password):
924 * src/modest-ui-actions.c:
925 (modest_ui_actions_on_password_requested):
926 Allow the username to be changed too, though there is more work to
927 be done on exactly how this behaves.
929 2007-05-08 Murray Cumming <murrayc@murrayc.com>
931 * src/modest-account-mgr-helpers.h:
932 * src/modest-account-mgr-helpers.c:
933 Added modest_account_mgr_get_display_name(),
934 modest_server_account_get_username(),
935 modest_server_account_set_username(),
936 modest_server_account_set_password(),
937 modest_server_account_get_hostname() functions so we do not need to
938 use the conf API directly.
940 * src/maemo/modest-main-window.c: (connect_signals):
941 Actually connect ot the ModestAccountStore::request-password signal,
942 so that we show the dialog when the password is requested by Tinymail,
943 for isntance if it is empty.
945 * src/modest-marshal.list:
946 * src/modest-tny-account-store.c:
947 (modest_tny_account_store_class_init), (get_password),
948 (modest_tny_account_store_alert):
949 * src/modest-tny-account-store.h:
950 * src/modest-ui-actions.h:
951 * src/modest-ui-actions.c:
952 (modest_ui_actions_on_password_requested):
953 Change the signal parameters, so it is obvious that we are providing
954 the non human-readable server name, and receiving both the username
955 and password, though changing of the username is not yet implemented.
956 Change the dialog UI to match the Maemo UI specifications, with #idfefing
957 for the GNOME version.
959 This should fix the projects.maemo.org bug NB#56209, though it does not
960 work on Bora, because the gconf_client_get() for the password fails
961 immediately after we save it with gconf_client_set().
963 2007-05-08 Murray Cumming <murrayc@murrayc.com>
966 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
967 caused an undefined symbol error:
968 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
970 2007-05-08 Murray Cumming <murrayc@murrayc.com>
972 * src/modest-tny-account-store.c:
973 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
974 using a GError instead of a string message, so we can translate it in
977 2007-05-08 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/modest-address-book.c:
980 (modest_address_book_check_names):
981 * src/maemo/modest-msg-view-window.c:
982 (modest_msg_view_window_clipboard_owner_change):
983 * src/modest-init.c: (modest_init_init_ui):
984 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
985 (update_folders_cb), (modest_mail_operation_update_account):
986 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
987 (modest_ui_actions_on_msg_attachment_clicked),
988 (modest_ui_actions_on_msg_recpt_activated):
989 * src/widgets/modest-header-view.c: (drag_data_get_cb):
990 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
991 (modest_msg_view_search_next):
992 * src/widgets/modest-recpt-editor.c:
993 (modest_recpt_editor_on_button_release_event),
994 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
995 g_message(). At this point we should only be seeing interesting errors on
996 stdout. Debugging messages could be #ifdefed-out if they are still useful.
998 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1000 (modest_wizard_dialog_force_title_update):
1001 * src/maemo/easysetup/modest-wizard-dialog.h:
1002 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1003 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1004 can update the title when appropriate. Otherwise the title is wrong if the
1005 pages are added after adding the notebook to the dialog.
1006 This must be a problem in HildonWizardDialog too.
1007 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1009 * src/maemo/easysetup/modest-easysetup-wizard.c:
1010 (create_subsequent_customsetup_pages),
1011 (create_subsequent_easysetup_pages):
1012 Call modest_wizard_dialog_force_title_update() so that the title is
1013 correct even with GTK+ < 2.10.
1014 This fixes projects.maemo.org bug NB#56145 .
1016 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1018 * src/maemo/modest-platform.c:
1019 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1020 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1023 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1025 * src/widgets/modest-window.h:
1026 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1027 and modest_window_save_state(), which invokes it.
1029 * src/widgets/modest-window-mgr.h:
1030 * src/widgets/modest-window-mgr.c:
1031 Added modest_window_mgr_save_state_for_all_windows(), which calls
1032 the save_state vfunc on all registered windows, if implemented.
1034 * src/gnome/modest-msg-edit-window.c:
1035 * src/gnome/modest-msg-view-window.c:
1036 * src/maemo/modest-msg-edit-window.c:
1037 * src/maemo/modest-msg-view-window.c:
1038 * src/maemo/modest-main-window.c:
1039 Specify the existing save_settings functions as implementations of
1040 ModestWindow::save_state_func().
1042 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1043 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1044 enabling hibernation, for instance.
1046 We may need to do the same thing for restoring settings.
1049 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1051 * src/widgets/modest-window-mgr.c:
1052 * src/widgets/modest-window-mgr.h:
1053 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1054 modest_window_mgr_get_hibernation_is_prevented().
1056 * src/maemo/modest-main-window.c:
1057 (on_hildon_program_is_topmost_notify): Prevent hibernation
1058 (possible when the application goes to the background in the WM),
1059 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1061 * src/maemo/easysetup/modest-easysetup-wizard.c:
1062 (modest_easysetup_wizard_dialog_init):
1063 * src/maemo/modest-account-settings-dialog.c:
1064 (modest_account_settings_dialog_init):
1065 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1066 (modest_connection_specific_smtp_edit_window_init):
1067 * src/maemo/modest-connection-specific-smtp-window.c:
1068 (modest_connection_specific_smtp_window_init):
1069 * src/maemo/modest-signature-editor-dialog.c:
1070 (modest_signature_editor_dialog_init):
1071 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1072 prevent hibernation while any of these account settings dialogs are open.
1074 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1076 * src/maemo/Makefile.am:
1077 * src/maemo/modest-osso-state-saving.c:
1078 * src/maemo/modest-osso-state-saving.h: Added
1079 modest_osso_load_state() and modest_osso_save_state() though they do
1080 nothing now. They should iterate through all the open windows and load/save
1082 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1083 save state when closing.
1085 * src/maemo/modest-main-window.c:
1086 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1087 Add a notification handler for the HildonProgram::is-topmost property,
1088 so we can allow hibernation when the application goes into the background.
1089 But we still need to detect when the accounts setup windows are open so
1090 we can stop hibernation when they are open.
1091 To do this, I also added the main window the HildonProgram. This might have
1092 other side-effects/benefits, and should maybe be done for other windows.
1094 * src/maemo/modest-osso-autosave-callbacks.h:
1095 * src/maemo/modest-osso-autosave-callbacks.c:
1096 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1097 though it does not do anything yet, and we might never need this to do
1098 anything. For instance, we already save drafts.
1100 * src/maemo/modest-platform.c: (modest_platform_init):
1101 Specify the libosso auto-save callback.
1103 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1105 * src/maemo/modest-platform.c:
1106 (modest_platform_set_update_interval):
1107 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1108 aparently stays valid between application instances, so we can use this
1109 to remove and reset it later. According to a maemo-developers email from
1112 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1114 * configure.ac: Depend on libalarm for Maemo.
1116 * src/dbus_api/modest-dbus-api.h:
1117 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1118 (on_send_receive), (modest_dbus_req_handler):
1119 Handle a SEND_RECEIVE D-Bus method.
1121 * libmodest-dbus-client/libmodest-dbus-client.c:
1122 (libmodest_dbus_client_send_and_receive):
1123 * libmodest-dbus-client/libmodest-dbus-client.h:
1124 Add C convenience functions for calling the new D-Bus method.
1126 * src/modest-platform.h:
1127 * src/gnome/modest-platform.c:
1128 * src/maemo/modest-platform.c:
1129 Added modest_platform_set_update_interval(), which uses the
1130 alarmd API on Maemo.
1131 (modest_platform_init),
1132 Call modest_platform_set_update_interval(), using a hard-coded
1133 interval for now (until the global settings dialog is implemented),
1134 though I am not sure that this makes sense yet.
1136 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1138 * src/dbus_api/modest-dbus-callbacks.c:
1139 (modest_osso_cb_hw_state_handler):
1140 * src/dbus_api/modest-dbus-callbacks.h:
1141 * src/maemo/modest-platform.c: (modest_platform_init):
1142 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1143 in case this has some effect on the ability for Maemo to ping the
1146 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1148 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1149 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1150 warning. It is probably a logic error, but I need to fix the build.
1152 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-account-mgr.h:
1155 * src/modest-account-mgr.c:
1156 (modest_account_mgr_account_names): Add a gboolean enabled_only
1157 parameter, so we can get lists of onlt the enabled accounts.
1159 (modest_account_mgr_add_account),,
1160 (modest_account_mgr_account_with_display_name_exists):
1161 * src/maemo/modest-msg-edit-window.c: (get_transports):
1162 * src/modest-account-mgr-helpers.c:
1163 (modest_account_mgr_set_first_account_as_default):
1164 * src/modest-init.c: (init_default_account_maybe):
1165 * src/modest-tny-account-store.c: (get_accounts):
1166 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1167 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1168 * tests/check_account-mgr.c: (START_TEST):
1169 Provide the extra parameter, as appropriate.
1171 * src/widgets/modest-account-view.c: (update_account_view):
1172 Do not show disabled accounts (meaning that there is no way to
1173 enable/disable accounts in the UI (the feature is not in our UI
1174 specification), so we can use this internally only to mark unfinished
1175 or temporary account data.
1177 * src/maemo/easysetup/modest-easysetup-wizard.c:
1178 (create_account): Add boolean enable parameter, so we can specify FALSE
1179 to create the temporary account.
1180 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1181 (on_before_next): When finishing, when there is a temporary account, just
1183 Also, use a timeout to delay the showing of the dialog until gconf is likely
1184 to return correct information, due to a maemo gconf bug that is fixed in
1185 osso 1.1, but not yet in Bora.
1186 However, the dialog stays on screen after it is destroyed.
1188 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1189 for invalid data when cancelling. Use a hildon note instead of a dialog
1190 to complain about invalid data. Do not show the account-saved note if the
1191 account is disabled (a temporary account that will not really be saved for use
1194 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-account-mgr-helpers.h:
1197 * src/modest-account-mgr-helpers.c:
1198 Added modest_account_mgr_unset_default_account(),
1199 Added modest_account_mgr_set_first_account_as_default().
1201 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1202 If it was the default account, unset the default account name.
1204 * src/maemo/modest-account-view-window.c:
1205 (on_delete_button_clicked): If it was the default account,
1206 set the first remaining account as the default instead.
1208 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1209 a NULL account or a NULL default account, to prevent a crash. This should
1210 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1213 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1215 * src/widgets/modest-recpt-editor.c:
1216 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1217 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1218 TODO comment for this. This fixes the build.
1220 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1221 be the best place for it. This will in future update all auto-update accounts,
1222 rather than just the current/default account, when that gconf key exists.
1223 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1224 if there are no accounts, before calling do_send_receive().
1225 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1227 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1228 * src/maemo/modest-main-window-ui.h:
1229 * src/maemo/modest-main-window.c: (on_connection_changed),
1230 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1231 directly, becaue the signal handler does more.
1233 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-account-mgr-helpers.c:
1236 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1237 for the case that the account does not exist.
1239 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1240 (equivalent to the modest account name) rather than the tinymail account name
1241 (equivalent to the modest account title - human readable) to get the account data.
1242 Check for null account data to prevent the crash, and add a TODO comment saying that
1243 this needs fixing because it is using the server account name instead of the account name.
1245 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1248 * src/maemo/modest-account-settings-dialog.c: (show_error),
1250 Use hildon_note_new_information() for informative and error messages,
1251 which seems to be expected for Maemo applications (no documentation that I know of
1252 says this). I am surprised that there is no distinction between info and error
1255 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1257 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1258 it is easy to find where this is used.
1260 * src/maemo/easysetup/modest-easysetup-wizard.c:
1261 (create_page_welcome), (create_page_account_details),
1262 (create_page_user_details), (create_page_complete_easysetup),
1263 (create_page_custom_incoming), (create_page_custom_outgoing),
1264 (create_page_complete_custom):
1265 * src/maemo/modest-account-settings-dialog.c:
1266 (create_page_account_details), (create_page_user_details),
1267 (create_page_incoming), (create_page_outgoing):
1268 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1269 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1270 (modest_connection_specific_smtp_edit_window_init):
1271 * src/maemo/modest-connection-specific-smtp-window.c:
1272 (modest_connection_specific_smtp_window_init):
1273 * src/maemo/modest-signature-editor-dialog.c:
1274 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1275 and scrolling policy as per the Email Application Layout Guide, if I have
1278 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1280 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1281 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1282 which were empty, because these vfuncs have been removed from TnyAccountStore.
1283 This fixes the build.
1285 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1287 * src/maemo/modest-main-window.c:
1288 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1289 showing/hiding it. Added TODO because it probably should not be NULL.
1290 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1291 because unnecessary g_warnings() make degugging difficult.
1293 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1295 * src/maemo/modest-msg-edit-window.c:
1296 (modest_msg_edit_window_select_color),
1297 (modest_msg_edit_window_select_background_color): 2 const corrections and
1298 moving 2 #endifs before closing brackets, to fix the build.
1300 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1302 * src/maemo/easysetup/modest-easysetup-wizard.h:
1303 * src/maemo/easysetup/modest-easysetup-wizard.c:
1304 (modest_easysetup_wizard_dialog_finalize),
1305 (on_button_edit_advanced_settings), (create_page_complete_custom),
1306 (on_response), (create_account):
1307 Implement the Advanced Settings edit button, by saving the account information,
1308 for the Advanded Settings dialog to use directly from gconf, and removing it
1309 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1310 Bug #5533 in the projects.maemo.org bugzilla.
1312 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1314 * src/maemo/modest-msg-view-window.c:
1315 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1316 when opening a message window.
1318 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/easysetup/modest-easysetup-wizard.c:
1321 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1324 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1325 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1326 gconf settings. I probably added more checks than necessary, but that is safer.
1328 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1329 variable to fix the build, but this seems to be used when it is still NULL.
1331 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-platform.h:
1334 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1335 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1336 * src/modest-main.c: Implement this function so we can avoid using
1337 maemo-specific API from cross-platform code.
1339 * src/modest-tny-account-store.c:
1340 (get_smtp_specific_transport_account_for_open_connection):
1341 * src/modest-ui-actions.c: (check_for_connection),
1342 (modest_ui_actions_on_item_not_found):
1343 Use modest_platform_connect_and_wait() and put #idefs around other
1344 maemo-specific code, because only maemo currently has a way to
1345 identify connection names.
1347 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1349 * src/modest-tny-account-store.h:
1350 * src/modest-tny-account-store.c:
1351 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1352 the connection-specific SMTP server settings in the configuration.
1354 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1356 * src/maemo/modest-main-window.c: (on_connection_changed),
1358 * src/modest-main.c: (main), (start_ui), (send_mail):
1359 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1360 that is what is intended.
1362 * src/modest-ui-actions.c: (action_send), (action_receive),
1363 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1364 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1365 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1366 SMTP server is used when it is specified.
1368 (modest_ui_actions_on_send_receive):
1369 Check that a connection is open before proceeding.
1370 Receive and then send, instead of vice-versa, as per the specification.
1372 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-mail-operation.c:
1375 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1376 though I guess it should be something other than NULL.
1378 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1380 * src/maemo/easysetup/modest-easysetup-wizard.c:
1381 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1382 combo twice, to avoid an g_warning and to make it visible again.
1383 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1384 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1385 (already intended) dereference when detaching, because we then recreate the menu.
1386 But I am not sure why the warning was happening, and it is possible that this is a memory
1389 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1391 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1392 and uri_parse_mailto() utility functions.
1393 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1395 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1397 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1399 * src/dbus_api/modest-dbus-api.h:
1400 * src/dbus_api/modest-dbus-callbacks.c:
1401 Use an idle callback to execute the modest code in the application's own thread.
1402 Remove the helloworld example method.
1403 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1404 parsed, and the open-message method is not implemented because this is not yet implemented in
1406 * libmodest-dbus-client/libmodest-dbus-client.c:
1407 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1408 (libmodest_dbus_client_open_message):
1409 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1411 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1412 body without crashing.
1414 * tests/dbus_api/Makefile.am:
1415 * tests/dbus_api/test_mail_to.c:
1416 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1418 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1420 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1421 Added file to fix the build. Sorry.
1423 * src/dbus_api/Makefile.am:
1424 * src/dbus_api/modest-dbus-api.h:
1425 * src/dbus_api/modest-dbus-callbacks.h:
1426 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1427 (modest_dbus_req_handler):
1428 Put constants in a separate header so it can be reused by the
1429 client library, without duplication
1431 * libmodest-dbus-client/Makefile.am:
1432 * libmodest-dbus-client/libmodest-dbus-client.c:
1433 (libmodest_dbus_client_call_helloworld),
1434 (libmodfest_dbus_client_send_mail),
1435 (libmodfest_dbus_client_mailto),
1436 (libmodfest_dbus_client_open_message):
1437 * libmodest-dbus-client/libmodest-dbus-client.h:
1438 (Partly) Implement a send_mail D-Bus method.
1440 * tests/dbus_api/Makefile.am:
1441 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1442 the send_email D-Bus method.
1444 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1448 * libmodest-dbus-client/Makefile.am:
1449 * libmodest-dbus-client/libmodest-dbus-client.c:
1450 * libmodest-dbus-client/libmodest-dbus-client.h:
1451 * tests/dbus_api/Makefile.am:
1452 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1453 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1455 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1457 * src/maemo/easysetup/modest-easysetup-wizard.c:
1458 (create_page_account_details):
1459 * src/maemo/modest-account-settings-dialog.c:
1460 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1461 widgets, because this might not be the default in future versions of the Maemo GTK+.
1462 However, I can not not get capitalization to work even in a simple test case.
1464 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1466 * src/maemo/easysetup/modest-easysetup-wizard.c:
1467 (create_page_custom_incoming), (create_page_custom_outgoing):
1468 * src/maemo/modest-account-settings-dialog.c:
1469 (create_page_account_details), (create_page_incoming),
1470 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1471 instead of using gtk_check_button_with_label(), so they are aligned like the other
1472 widgets, as per the UI spec.
1474 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1476 * src/maemo/easysetup/modest-easysetup-wizard.c:
1477 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1478 * src/widgets/modest-validating-entry.c:
1479 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1480 Modest prefix instead of an EasySetup prefix.
1482 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1484 * src/widgets/modest-validating-entry.h:
1485 * src/widgets/modest-validating-entry.c: (on_insert_text),
1486 Added easysetup_validating_entry_set_max_func(), used to set a callback
1487 to call when the max number of characters is reached. GtkEntry has a max-length
1488 already but is silent about it.
1490 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1491 (create_page_account_details), (create_page_user_details),
1493 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1494 (create_page_account_details), (create_page_user_details),
1495 (create_page_outgoing):
1496 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1497 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1498 the UI spec, when the user tries to enter more than the max number of characters.
1500 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1502 * src/maemo/easysetup/modest-easysetup-wizard.c:
1503 (create_page_user_details), (create_page_custom_incoming),
1504 (create_page_custom_outgoing):
1505 * src/maemo/modest-account-settings-dialog.c:
1506 (create_page_user_details), (create_page_incoming),
1507 (create_page_outgoing):
1508 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1509 (modest_connection_specific_smtp_edit_window_init):
1510 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1511 not appropriate. Bad Maemo-specific defaults!.
1513 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1515 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1516 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1517 (modest_signature_editor_dialog_set_settings):
1518 Disable the label and textview when the checkbox is disabled, and use the
1519 specified (UI spec) default signature text.
1521 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1523 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1524 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1526 * src/modest-defs.h:
1527 * src/modest-account-mgr-helpers.h:
1528 * src/modest-account-mgr-helpers.c:
1529 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1531 * src/maemo/Makefile.am:
1532 * src/maemo/modest-signature-editor-dialog.c:
1533 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1536 * src/maemo/modest-account-settings-dialog.h:
1537 * src/maemo/modest-account-settings-dialog.c:
1538 (modest_account_settings_dialog_finalize), (on_button_signature),
1539 (save_configuration): Use the new dialog when the Edit button is pressed, and
1540 save the changes if necessary, as per the UI spec.
1542 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1544 * src/maemo/Makefile.am:
1545 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1546 based on maemo-develoers email from Dirk.
1548 * src/maemo/easysetup/modest-easysetup-wizard.c:
1549 (create_page_welcome), (create_page_account_details),
1550 (create_page_user_details), (create_page_complete_easysetup),
1551 (create_page_custom_incoming), (create_page_custom_outgoing),
1552 (create_page_complete_custom),
1553 (modest_easysetup_wizard_dialog_init):
1554 * src/maemo/modest-account-settings-dialog.c:
1555 (create_page_account_details), (create_page_user_details),
1556 (create_page_incoming), (create_page_outgoing),
1557 (modest_account_settings_dialog_init):
1558 * src/maemo/modest-connection-specific-smtp-window.c:
1559 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1561 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/easysetup/modest-easysetup-wizard.c:
1564 (create_page_account_details), (create_page_custom_outgoing),
1565 (create_page_complete_custom):
1566 * src/maemo/modest-account-settings-dialog.c:
1567 (create_page_user_details), (create_page_incoming),
1568 (create_page_outgoing):
1569 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1570 (modest_connection_specific_smtp_edit_window_init):
1571 Use the correct (UI spec) port min/max, and use horizontal separators,
1574 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1576 * src/maemo/easysetup/modest-easysetup-wizard.c:
1577 (set_default_custom_servernames):
1578 * src/maemo/modest-account-settings-dialog.c:
1579 (create_page_incoming), (on_combo_outgoing_security_changed),
1580 (on_combo_incoming_security_changed), (create_page_outgoing),
1581 (modest_account_settings_dialog_set_account_name),
1582 (save_configuration):
1583 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1584 (on_combo_security_changed),
1585 (modest_connection_specific_smtp_edit_window_init),
1586 (modest_connection_specific_smtp_edit_window_set_connection),
1587 (modest_connection_specific_smtp_edit_window_get_settings):
1588 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1591 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1594 * src/maemo/easysetup/modest-easysetup-wizard.c:
1595 (create_page_custom_outgoing), (create_page_complete_custom):
1596 * src/maemo/modest-account-settings-dialog.c:
1597 (create_page_user_details), (create_page_outgoing):
1598 * src/maemo/modest-account-view-window.c: (button_box_new):
1599 Use changed logical IDs as per the most recent UI spec:
1600 mcen_bd_emailsetup_edit -> mcen_bd_edit
1601 mcen_bd_emailsetup_delete -> mcen_bd_delete
1602 mcen_bd_emailsetup_close -> mcen_bd_close
1604 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1608 * src/dbus_api/Makefile.am:
1609 * src/dbus_api/modest-dbus-callbacks.c:
1610 * src/dbus_api/modest-dbus-callbacks.h:
1611 * src/maemo/modest-platform.c: (modest_platform_init):
1612 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1614 * tests/Makefile.am:
1615 * tests/dbus_api/Makefile.am:
1616 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1618 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1620 * src/maemo/modest-account-settings-dialog.c:
1621 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1622 Removed unnecessary includes.
1624 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1626 * src/maemo/easysetup/modest-easysetup-wizard.c:
1627 * src/maemo/modest-account-settings-dialog.c:
1628 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1629 * src/widgets/Makefile.am:
1630 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1631 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1632 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1633 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1634 * src/widgets/modest-secureauth-combo-box.c:
1635 * src/widgets/modest-secureauth-combo-box.h:
1636 * src/widgets/modest-serversecurity-combo-box.c:
1637 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1638 made the GObject names more consistent with the rest of the Modest code.
1640 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1642 * src/maemo/easysetup/Makefile.am:
1643 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1644 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1645 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1646 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1647 * src/maemo/easysetup/modest-easysetup-wizard.c:
1648 * src/maemo/easysetup/modest-validating-entry.c:
1649 * src/maemo/easysetup/modest-validating-entry.h:
1650 * src/maemo/modest-account-settings-dialog.c:
1651 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1652 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1653 widgets/ because they are used outside of easysetup too. After checking in,
1654 svn will allow me to rename them too.
1656 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1658 * src/gnome/modest-msg-edit-window.c:
1659 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1660 linker error, to fix the build on the GNOME platform.
1661 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1662 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1663 ifdefed out to avoid a warning.
1665 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1667 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1668 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1669 some alternative for GTK+ 2.6.
1671 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1673 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1675 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1676 specified for EmailAccountsDialog in UI spec.
1678 * src/maemo/easysetup/modest-easysetup-wizard.c:
1679 * src/maemo/easysetup/modest-easysetup-wizard.h:
1680 * src/maemo/modest-account-settings-dialog.c:
1681 * src/maemo/modest-account-settings-dialog.h:
1682 Reuse a member window widget for the connection-specific SMTP server accounts,
1683 so we can tell it to create/save the accounts only if we actually save changes.
1685 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1686 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1687 (modest_connection_specific_smtp_edit_window_get_settings):
1688 Return a struct instance for temporarily remembering the entered data.
1690 * src/maemo/modest-connection-specific-smtp-window.h:
1691 * src/maemo/modest-connection-specific-smtp-window.c:
1692 (modest_connection_specific_smtp_window_finalize),
1693 (modest_connection_specific_smtp_window_fill_with_connections),
1695 (modest_connection_specific_smtp_window_save_server_accounts),
1696 (update_model_server_names): Do not actually save data until asked,
1697 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1699 (on_selection_changed),
1700 (modest_connection_specific_smtp_window_init): Disable the edit
1701 button when nothing is selected.
1703 * src/modest-account-mgr-helpers.c:
1704 * src/modest-account-mgr-helpers.h:
1705 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1708 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1710 * src/modest-account-mgr-helpers.h:
1711 * src/modest-account-mgr-helpers.c:
1712 (modest_account_mgr_get_unused_account_name),
1713 (modest_account_mgr_get_unused_account_display_name): Added these
1714 utility functions, to avoid code duplication.
1716 * src/maemo/easysetup/modest-easysetup-wizard.c:
1717 (create_page_account_details), (create_account):
1718 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1719 (on_combo_security_changed),
1720 (modest_connection_specific_smtp_edit_window_init),
1721 (modest_connection_specific_smtp_edit_window_save_settings):
1722 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1723 * src/maemo/modest-connection-specific-smtp-window.c:
1724 (modest_connection_specific_smtp_window_finalize),
1725 (modest_connection_specific_smtp_window_fill_with_connections),
1726 (on_button_edit), (modest_connection_specific_smtp_window_init):
1727 * src/maemo/modest-connection-specific-smtp-window.h:
1728 Implementing saving of connection-specific server accounts.
1730 But I need to refactor this so we can save the data for each
1731 possible connection-specific account and only actually create the server accounts
1732 when the easysetup finished, or the OK button is pressed on the account settings
1735 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1738 (on_combo_security_changed):
1739 (modest_connection_specific_smtp_edit_window_init):
1740 Auto-fill the port number as in the account settings.
1742 (modest_connection_specific_smtp_edit_window_set_connection):
1743 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1744 * src/maemo/modest-connection-specific-smtp-window.c:
1745 (fill_with_connections), (on_button_edit),
1746 (modest_connection_specific_smtp_window_init):
1747 Turn the edit window into a dialog to simplify the code, and
1748 set a WM hint as in a GtkDialog, because only a popup can be on top of
1749 another window in Maemo, and popups usually have no WM decoration.
1751 * src/modest-defs.h:
1752 * src/modest-account-mgr-helpers.c:
1753 (modest_account_mgr_set_connection_specific_smtp),
1754 (modest_account_mgr_remove_connection_specific_smtp),
1755 (modest_account_mgr_get_connection_specific_smtp):
1756 * src/modest-account-mgr-helpers.h: Some functions to write the
1757 connection-specific SMTP server information. Not yet used.
1760 * src/widgets/modest-folder-view.c: (text_cell_data):
1761 Fix a warning about an uninitialized variable.
1762 (on_configuration_key_changed): Put an #ifdef around the use
1763 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1765 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/modest-account-settings-dialog.h:
1768 * src/maemo/modest-account-settings-dialog.c:
1769 Added connect_for_modified() utility function to mark the new modified boolean.
1771 (create_page_account_details), (create_page_user_details),
1772 (create_page_incoming), (create_page_outgoing), (on_response),
1773 (modest_account_settings_dialog_init),
1774 (modest_account_settings_dialog_set_account_name):
1775 Only warn about unsaved changes when there are actually unsaved changes.
1777 * src/modest-account-mgr-helpers.c:
1778 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1779 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1780 to get the data from there in future.
1782 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-defs.h:
1786 * src/modest-account-mgr-helpers.h:
1787 * src/modest-account-mgr-helpers.c:
1788 Store the security account setting in a single conf key instead of using
1789 the options list, so that the list is left for just the to-be-removed camel hack,
1790 and because gconf_client_set_list() is failing for some reason.
1792 * src/modest-account-mgr.c:
1793 (modest_account_mgr_add_server_account):
1794 * src/maemo/modest-account-settings-dialog.c:
1795 (modest_account_settings_dialog_set_account_name),
1796 (save_configuration): Use the renamed functions.
1799 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1801 * src/widgets/Makefile.am:
1802 * src/widgets/modest-limit-retrieve-combo-box.c:
1803 * src/widgets/modest-limit-retrieve-combo-box.h:
1804 * src/widgets/modest-retrieve-combo-box.c:
1805 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1806 the account settings dialog.
1808 * src/modest-defs.h:
1809 * src/modest-account-mgr-helpers.h:
1810 * src/modest-account-mgr-helpers.c:
1811 (modest_server_account_get_option_secure_auth),
1812 (modest_server_account_set_option_secure_auth):
1813 * src/modest-account-mgr.c:
1814 (modest_account_mgr_add_server_account):
1815 Use the existing AUTH_MECH conf key for the secure-auth setting,
1816 instead of putting it in the list options, because this was actually used already.
1818 * src/maemo/modest-account-settings-dialog.c:
1819 (create_page_account_details),
1820 (modest_account_settings_dialog_set_account_name),
1821 (save_configuration):
1822 * src/maemo/modest-account-settings-dialog.h:
1823 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1824 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1826 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1828 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1829 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1830 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1832 * src/modest-defs.h:
1833 * src/maemo/modest-account-settings-dialog.c:
1834 (create_page_incoming), (on_combo_outgoing_security_changed),
1835 (on_combo_incoming_security_changed), (create_page_outgoing),
1836 (modest_account_settings_dialog_set_account_name),
1837 (save_configuration): Load/Save the port number, and change it when the
1838 security combo changes, to suitable defaults.
1840 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1842 * src/modest-account-mgr.c:
1843 (modest_account_mgr_add_server_account): Set the security and secure-auth
1844 options, and add a comment saying that the other camel-specific options should be
1847 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1849 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1851 * src/modest-tny-account-store.c: (account_list_free),
1852 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1853 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1856 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-protocol-info.c:
1859 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1860 is required by our UI spec. Maybe something in our implementation will use this eventually.
1861 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1862 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1863 instead of the previous 0 placeholder.
1865 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1866 secure-auth settings.
1867 * src/modest-account-mgr-helpers.h:
1868 * src/modest-account-mgr-helpers.c:
1869 (modest_server_account_data_get_option_secure_auth),
1870 (modest_server_account_set_option_secure_auth),
1871 (modest_server_account_data_get_option_security),
1872 (modest_server_account_set_option_security): Added this API for getting and setting the security
1873 and secure-auth settings.
1875 * src/maemo/modest-account-settings-dialog.h:
1876 * src/maemo/modest-account-settings-dialog.c:
1877 (modest_account_settings_dialog_finalize), (check_data),
1878 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1879 about changing titles.
1880 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1881 (save_configuration): Save the security and secure-auth settings.
1883 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1884 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1886 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1888 * src/modest-defs.h:
1889 * src/modest-account-mgr.c:
1890 (modest_account_mgr_add_server_account):
1891 Added and used defines for the options key and value pair strings,
1892 that are used so far, though they do not seem to correspond to anything in our
1893 UI specs or ModestProtocol enum.
1895 * src/modest-account-mgr-helpers.h:
1896 * src/modest-account-mgr-helpers.c:
1897 (compare_option_strings_for_name),
1898 (modest_server_account_data_get_option_value),
1899 (modest_server_account_data_get_option_bool),
1900 (modest_account_mgr_get_server_account_option):
1901 Added helper functions for parsing the options GSList.
1903 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1905 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1906 display name is based on the supplied account name.
1907 * src/modest-account-mgr.c:
1908 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1909 with an inefficient, but good-enough, implementation.
1911 * src/maemo/easysetup/modest-easysetup-wizard.c:
1912 (create_page_account_details), (on_before_next), (create_account):
1913 Check for existing display names rather than (non-user-visible) account names, and just
1914 create and set a unique account name at the end.
1916 * src/maemo/modest-account-settings-dialog.c:
1917 (modest_account_settings_dialog_init),
1918 (modest_account_settings_dialog_set_account_name),
1919 (create_page_incoming): Show the display name, instead of the account name.
1920 (on_response): Do some (not all) extra checks, as in the UI spec.
1921 (save_configuration): Save the display name if it was changed.
1923 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1925 * po/en_GB.po: Added needed logical ID and translation.
1926 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1927 (init_view): Made the is-default column clicking work.
1929 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1932 * src/maemo/easysetup/Makefile.am:
1933 * src/maemo/easysetup/modest-easysetup-wizard.c:
1934 (modest_easysetup_wizard_dialog_init):
1935 * src/maemo/easysetup/provider-data-test.keyfile:
1936 * src/maemo/easysetup/provider-data.keyfile:
1937 Moved the provider data file to the new modest-providers-data package and used it from there.
1939 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1941 * src/modest-local-folder-info.c:
1942 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1943 N_() was already used on the static strings, but this just marks it for translation without
1944 using the translation.
1946 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/modest-account-settings-dialog.c:
1949 (create_page_incoming),
1950 (modest_account_settings_dialog_set_account_name):
1951 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1952 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1953 I will do this if nobody else gets there first.
1955 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1957 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1958 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1959 save the security stuff.
1961 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1963 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1964 Set the email address and user fullname, which I now see must be
1967 * src/maemo/modest-account-settings-dialog.h:
1968 * src/maemo/modest-account-settings-dialog.c:
1970 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1971 leave-on-server and authentication.
1972 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1975 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/modest-account-settings-dialog.c:
1979 * src/maemo/modest-account-settings-dialog.h:
1980 Most (but not all) of the widgets are now present as specified by the UI spec.
1981 No changes are yet saved, and some details are not properly shown yet.
1983 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1985 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1987 * src/maemo/Makefile.am:
1988 * src/maemo/modest-account-settings-dialog.c:
1989 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1990 an existing account. Doesn't do much yet.
1992 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1993 Open the accounts settings dialog when Edit is clicked.
1995 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1997 * src/maemo/easysetup/Makefile.am:
1998 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2000 * src/maemo/easysetup/modest-easysetup-wizard.c:
2001 (modest_easysetup_wizard_dialog_init):
2002 Try to get the source directory from the build system,
2003 instead of hard-coding "./" into the source code, when opening our local
2004 copies of the configuration files.
2005 But this still fails when opening the wizard from the Accounts window,
2006 maybe because the working directory seems to change at runtime.
2007 So the wizard will fail the second time unless you copy the files into their
2008 proper locations - see the stdout warnings for the paths.
2010 (create_page_account_details),(on_before_next):
2011 Check for existing non-server accounts instead of server accounts,
2012 so the default account name is useful again, and to prevent trying to
2015 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2016 Show the wizard when New is clicked.
2018 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2019 (init_view): Show the column headers, and show the columns that are
2020 specified in the UI specs. However, something in Maemo's GTK+ prevents
2021 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2022 change the default account. This is despite unsetting the special properties.
2024 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2026 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2027 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2028 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2029 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2030 to make that clearer.
2031 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2033 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/modest-account-view-window.c:
2036 (modest_account_view_window_init),
2037 (modest_account_view_window_new):
2038 Use the same buttons as specified in the
2039 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2040 the existing widgets, which never had a chance of working.
2041 Put the ModestAccountView treeview in a scrolled window.
2042 Do not repeat the initialization in both _init() and _new().
2044 * src/widgets/modest-account-view.c: (update_account_view):
2045 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2046 this widget and window shows no accounts.
2048 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2050 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2052 * src/maemo/easysetup/modest-easysetup-wizard.c:
2053 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2054 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2055 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2058 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2059 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2060 accounts exist yet, as in the UI spec.
2062 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2064 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2066 * src/maemo/Makefile.am:
2067 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2068 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2069 New window for editing connection-specific smtp details.
2070 Not fully implemented.
2072 * src/maemo/modest-connection-specific-smtp-window.c:
2073 (modest_connection_specific_smtp_window_finalize) :
2074 unref the tree model.
2075 (on_button_edit): Show the edit window.
2077 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2079 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2082 * src/maemo/Makefile.am:
2083 * src/maemo/modest-connection-specific-smtp-window.c:
2084 * src/maemo/modest-connection-specific-smtp-window.h:
2085 New window for showing the list of connections, for connection-specific
2086 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2087 * src/maemo/easysetup/modest-easysetup-wizard.c:
2088 (create_page_custom_outgoing): Show the new window when the button is clicked.
2090 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2092 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2093 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2094 * src/maemo/modest-msg-edit-window.c:
2095 (modest_msg_edit_window_insert_image):
2096 * src/modest-conf.c: (modest_conf_key_escape):
2097 * src/modest-mail-operation.c:
2098 (modest_mail_operation_send_new_mail):
2099 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2100 (modest_ui_actions_on_new_account):
2101 * src/widgets/modest-attachment-view.c: (update_filename_request):
2102 * src/widgets/modest-mail-header-view.c:
2103 Corrected warnings that were breaking the build, by commenting out unused variables,
2104 and a function, and by including a header.
2106 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2108 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2109 so we can #ifdef around platform-specific code when necessary.
2110 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2111 to allow this to build for the GNOME platform too.
2113 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2115 * src/maemo/easysetup/modest-easysetup-wizard.c:
2116 Added util_increment_name() and used it in create_page_account_details()
2117 to make sure that the default account name is always a new name.
2119 (modest_easysetup_wizard_dialog_init),
2120 (set_default_custom_servernames): Some minor memory management fixes.
2122 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2126 * src/modest-runtime.c: (init_i18n): Restored the translation
2127 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2128 are defined in config.h, and the translations are installed.
2130 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2131 is defined for translation.
2133 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2135 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2137 * src/maemo/easysetup/modest-easysetup-wizard.c:
2138 (modest_easysetup_wizard_dialog_init):
2139 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2140 Use realistic paths (though they should use $prefix generically) to the
2141 mcc_mapping and provider-data.keyfile files which might work when they
2142 are installed by the future version of the operator-wizard package,
2143 and then fallback to paths in our source code, with an explanatory
2146 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2150 * src/maemo/Makefile.am:
2151 * src/maemo/easysetup/: Added files from the previously-exernal
2152 osso-modest-easysetup.
2153 * src/maemo/modest-main-window-ui.h:
2154 * src/modest-ui-actions.c:
2155 * src/modest-ui-actions.h:
2156 Added modest_ui_actions_on_new_account() as a signal handler for the
2157 New Account menu item. It shows the easysetup wizard.
2158 * po/en_GB.po: Added additional needed logical IDs and translations.
2160 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2161 Apparently ChangeLog is not used for some vague Nokia legal reasons.