TnyFolder *folder_to_select; /* folder to select after the next update */
- gulong changed_signal;
- gulong account_inserted_signal;
- gulong account_removed_signal;
- gulong account_changed_signal;
- gulong conf_key_signal;
- gulong display_name_changed_signal;
-
/* not unref this object, its a singlenton */
ModestEmailClipboard *clipboard;
GtkCellRenderer *messages_renderer;
- gulong outbox_deleted_handler;
-
GSList *signal_handlers;
GdkColor *active_color;
};
convert_parent_folders_to_dots (gchar **item_name)
{
gint n_parents = 0;
+ gint n_inbox_parents = 0;
gchar *c;
+ gchar *path_start;
gchar *last_separator;
if (item_name == NULL)
return;
+ path_start = *item_name;
for (c = *item_name; *c != '\0'; c++) {
if (g_str_has_prefix (c, MODEST_FOLDER_PATH_SEPARATOR)) {
+ gchar *compare;
+ if (c != path_start) {
+ compare = g_strndup (path_start, c - path_start);
+ compare = g_strstrip (compare);
+ if (g_ascii_strcasecmp (compare, "inbox") == 0) {
+ n_inbox_parents++;
+ }
+ g_free (compare);
+ }
n_parents++;
+ path_start = c + 1;
}
}
gint i;
buffer = g_string_new ("");
- for (i = 0; i < n_parents; i++) {
+ for (i = 0; i < n_parents - n_inbox_parents; i++) {
buffer = g_string_append (buffer, MODEST_FOLDER_DOT);
}
buffer = g_string_append (buffer, last_separator);
{
ThreePixbufs *retval;
- if (!*pixbuf)
- *pixbuf = gdk_pixbuf_copy (modest_platform_get_icon (icon_code, FOLDER_ICON_SIZE));
+ if (!*pixbuf) {
+ GdkPixbuf *icon;
+ icon = modest_platform_get_icon (icon_code, FOLDER_ICON_SIZE);
+ if (icon) {
+ *pixbuf = gdk_pixbuf_copy (icon);
+ }
+ }
- if (!*pixbuf_open)
+ if (!*pixbuf_open && pixbuf && *pixbuf)
*pixbuf_open = get_composite_pixbuf ("qgn_list_gene_fldr_exp",
FOLDER_ICON_SIZE,
*pixbuf);
- if (!*pixbuf_close)
+ if (!*pixbuf_close && pixbuf && *pixbuf)
*pixbuf_close = get_composite_pixbuf ("qgn_list_gene_fldr_clp",
FOLDER_ICON_SIZE,
*pixbuf);
type != TNY_FOLDER_TYPE_INBOX &&
modest_tny_folder_store_is_remote (TNY_FOLDER_STORE (instance))) {
#ifdef MODEST_TOOLKIT_HILDON2
- return get_composite_icons (MODEST_FOLDER_ICON_ACCOUNT,
+ return get_composite_icons (MODEST_FOLDER_ICON_REMOTE_FOLDER,
&anorm_pixbuf,
&anorm_pixbuf_open,
&anorm_pixbuf_close);
priv->visible_account_id = NULL;
priv->mailbox = NULL;
priv->folder_to_select = NULL;
- priv->outbox_deleted_handler = 0;
priv->reexpand = TRUE;
priv->signal_handlers = 0;
setup_drag_and_drop (GTK_TREE_VIEW(obj));
/* Connect signals */
- g_signal_connect (G_OBJECT (obj),
- "key-press-event",
- G_CALLBACK (on_key_pressed), NULL);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT (obj), "key-press-event",
+ G_CALLBACK (on_key_pressed), NULL);
- priv->display_name_changed_signal =
- g_signal_connect (modest_runtime_get_account_mgr (),
- "display_name_changed",
- G_CALLBACK (on_display_name_changed),
- obj);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ (GObject*) modest_runtime_get_account_mgr (),
+ "display_name_changed",
+ G_CALLBACK (on_display_name_changed),
+ obj);
/*
* Track changes in the local account name (in the device it
* will be the device name)
*/
- priv->conf_key_signal = g_signal_connect (G_OBJECT(conf),
- "key_changed",
- G_CALLBACK(on_configuration_key_changed),
- obj);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT(conf),
+ "key_changed",
+ G_CALLBACK(on_configuration_key_changed),
+ obj);
priv->active_color = NULL;
update_style (obj);
- g_signal_connect (G_OBJECT (obj), "notify::style", G_CALLBACK (on_notify_style), (gpointer) obj);
-
-
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT (obj), "notify::style",
+ G_CALLBACK (on_notify_style), (gpointer) obj);
}
static void
/* Free external references */
if (priv->account_store) {
- g_signal_handler_disconnect (G_OBJECT(priv->account_store),
- priv->account_inserted_signal);
- g_signal_handler_disconnect (G_OBJECT(priv->account_store),
- priv->account_removed_signal);
- g_signal_handler_disconnect (G_OBJECT(priv->account_store),
- priv->account_changed_signal);
g_object_unref (G_OBJECT(priv->account_store));
priv->account_store = NULL;
}
modest_folder_view_finalize (GObject *obj)
{
ModestFolderViewPrivate *priv;
- GtkTreeSelection *sel;
- TnyAccount *local_account;
g_return_if_fail (obj);
priv->timer_expander = 0;
}
- local_account = (TnyAccount *)
- modest_tny_account_store_get_local_folders_account (modest_runtime_get_account_store ());
- if (local_account) {
- if (g_signal_handler_is_connected (local_account,
- priv->outbox_deleted_handler))
- g_signal_handler_disconnect (local_account,
- priv->outbox_deleted_handler);
- g_object_unref (local_account);
- }
-
- if (g_signal_handler_is_connected (modest_runtime_get_account_mgr (),
- priv->display_name_changed_signal)) {
- g_signal_handler_disconnect (modest_runtime_get_account_mgr (),
- priv->display_name_changed_signal);
- priv->display_name_changed_signal = 0;
- }
-
- sel = gtk_tree_view_get_selection (GTK_TREE_VIEW(obj));
- if (sel)
- g_signal_handler_disconnect (G_OBJECT(sel), priv->changed_signal);
-
g_free (priv->local_account_name);
g_free (priv->visible_account_id);
g_free (priv->mailbox);
- if (priv->conf_key_signal) {
- g_signal_handler_disconnect (modest_runtime_get_conf (),
- priv->conf_key_signal);
- priv->conf_key_signal = 0;
- }
-
/* Clear hidding array created by cut operation */
_clear_hidding_filter (MODEST_FOLDER_VIEW (obj));
if (G_UNLIKELY (priv->account_store)) {
- if (g_signal_handler_is_connected (G_OBJECT (priv->account_store),
- priv->account_inserted_signal))
- g_signal_handler_disconnect (G_OBJECT (priv->account_store),
- priv->account_inserted_signal);
- if (g_signal_handler_is_connected (G_OBJECT (priv->account_store),
- priv->account_removed_signal))
- g_signal_handler_disconnect (G_OBJECT (priv->account_store),
- priv->account_removed_signal);
- if (g_signal_handler_is_connected (G_OBJECT (priv->account_store),
- priv->account_changed_signal))
- g_signal_handler_disconnect (G_OBJECT (priv->account_store),
- priv->account_changed_signal);
+ if (modest_signal_mgr_is_connected (priv->signal_handlers,
+ G_OBJECT (priv->account_store),
+ "account_inserted"))
+ priv->signal_handlers = modest_signal_mgr_disconnect (priv->signal_handlers,
+ G_OBJECT (priv->account_store),
+ "account_inserted");
+ if (modest_signal_mgr_is_connected (priv->signal_handlers,
+ G_OBJECT (priv->account_store),
+ "account_removed"))
+ priv->signal_handlers = modest_signal_mgr_disconnect (priv->signal_handlers,
+ G_OBJECT (priv->account_store),
+ "account_removed");
+ if (modest_signal_mgr_is_connected (priv->signal_handlers,
+ G_OBJECT (priv->account_store),
+ "account_changed"))
+ priv->signal_handlers = modest_signal_mgr_disconnect (priv->signal_handlers,
+ G_OBJECT (priv->account_store),
+ "account_changed");
g_object_unref (G_OBJECT (priv->account_store));
}
priv->account_store = g_object_ref (G_OBJECT (account_store));
- priv->account_removed_signal =
- g_signal_connect (G_OBJECT(account_store), "account_removed",
- G_CALLBACK (on_account_removed), self);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT(account_store), "account_removed",
+ G_CALLBACK (on_account_removed), self);
- priv->account_inserted_signal =
- g_signal_connect (G_OBJECT(account_store), "account_inserted",
- G_CALLBACK (on_account_inserted), self);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT(account_store), "account_inserted",
+ G_CALLBACK (on_account_inserted), self);
- priv->account_changed_signal =
- g_signal_connect (G_OBJECT(account_store), "account_changed",
- G_CALLBACK (on_account_changed), self);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT(account_store), "account_changed",
+ G_CALLBACK (on_account_changed), self);
modest_folder_view_update_model (MODEST_FOLDER_VIEW (self), account_store);
priv->reselect = FALSE;
for a merge folder */
if (TNY_IS_GTK_FOLDER_LIST_STORE (model) &&
MODEST_IS_TNY_LOCAL_FOLDERS_ACCOUNT (account)) {
-
- priv->outbox_deleted_handler =
- g_signal_connect (account,
- "outbox-deleted",
- G_CALLBACK (on_outbox_deleted_cb),
- user_data);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ (GObject*) account, "outbox-deleted",
+ G_CALLBACK (on_outbox_deleted_cb),
+ user_data);
}
/* Refilter the model */
/* Disconnect the signal handler */
if (TNY_IS_GTK_FOLDER_LIST_STORE (model) &&
MODEST_IS_TNY_LOCAL_FOLDERS_ACCOUNT (account)) {
- if (g_signal_handler_is_connected (account,
- priv->outbox_deleted_handler))
- g_signal_handler_disconnect (account,
- priv->outbox_deleted_handler);
+ if (modest_signal_mgr_is_connected (priv->signal_handlers, (GObject*) account, "outbox-deleted"))
+ priv->signal_handlers = modest_signal_mgr_disconnect (priv->signal_handlers,
+ (GObject *) account,
+ "outbox-deleted");
}
/* Remove the account from the model */
priv->do_refresh = do_refresh;
sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(self));
- priv->changed_signal = g_signal_connect (sel, "changed",
- G_CALLBACK (on_selection_changed), self);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ (GObject*) sel, "changed",
+ G_CALLBACK (on_selection_changed), self);
- g_signal_connect (self, "row-activated", G_CALLBACK (on_row_activated), self);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ self, "row-activated",
+ G_CALLBACK (on_row_activated), self);
- g_signal_connect (self, "expose-event", G_CALLBACK (modest_folder_view_on_map), NULL);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ self, "expose-event",
+ G_CALLBACK (modest_folder_view_on_map), NULL);
return GTK_WIDGET(self);
}
{
ModestFolderViewPrivate *priv;
GtkTreeModel *model;
- GtkTreeModel *filter_model = NULL, *sortable = NULL;
+ GtkTreeModel *filter_model = NULL, *sortable = NULL, *old_tny_model;
g_return_val_if_fail (self && MODEST_IS_FOLDER_VIEW (self), FALSE);
g_return_val_if_fail (account_store && MODEST_IS_TNY_ACCOUNT_STORE(account_store),
acc_store = modest_runtime_get_account_store ();
account = modest_tny_account_store_get_local_folders_account (acc_store);
- if (g_signal_handler_is_connected (account,
- priv->outbox_deleted_handler))
- g_signal_handler_disconnect (account,
- priv->outbox_deleted_handler);
+ if (modest_signal_mgr_is_connected (priv->signal_handlers, (GObject *) account,
+ "outbox-deleted"))
+ priv->signal_handlers = modest_signal_mgr_disconnect (priv->signal_handlers,
+ (GObject *) account,
+ "outbox-deleted");
- priv->outbox_deleted_handler =
- g_signal_connect (account,
- "outbox-deleted",
- G_CALLBACK (on_outbox_deleted_cb),
- self);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ (GObject*) account, "outbox-deleted",
+ G_CALLBACK (on_outbox_deleted_cb),
+ self);
g_object_unref (account);
}
self,
NULL);
- if (priv->signal_handlers > 0) {
- GtkTreeModel *old_tny_model;
-
- if (get_inner_models (self, NULL, NULL, &old_tny_model)) {
+ if (get_inner_models (self, NULL, NULL, &old_tny_model)) {
+ if (modest_signal_mgr_is_connected (priv->signal_handlers, (GObject *) old_tny_model,
+ "activity-changed"))
priv->signal_handlers = modest_signal_mgr_disconnect (priv->signal_handlers,
- G_OBJECT (old_tny_model),
+ G_OBJECT (old_tny_model),
"activity-changed");
- }
}
/* Set new model */
gtk_tree_view_set_model (GTK_TREE_VIEW(self), filter_model);
#ifndef MODEST_TOOLKIT_HILDON2
- g_signal_connect (G_OBJECT(filter_model), "row-inserted",
- (GCallback) on_row_inserted_maybe_select_folder, self);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT(filter_model), "row-inserted",
+ (GCallback) on_row_inserted_maybe_select_folder, self);
#endif
#ifdef MODEST_TOOLKIT_HILDON2
return is_account2 - is_account1;
}
+static gint
+compare_folders (const gchar *name1, const gchar *name2)
+{
+ const gchar *separator1, *separator2;
+ const gchar *next1, *next2;
+ gchar *top1, *top2;
+ gint cmp;
+
+ if (name1 == NULL || name1[0] == '\0')
+ return -1;
+ if (name2 == NULL || name2[0] == '\0')
+ return 1;
+
+ separator1 = strstr (name1, MODEST_FOLDER_PATH_SEPARATOR);
+ if (separator1) {
+ top1 = g_strndup (name1, separator1 - name1);
+ } else {
+ top1 = g_strdup (name1);
+ }
+
+ separator2 = strstr (name2, MODEST_FOLDER_PATH_SEPARATOR);
+ if (separator2) {
+ top2 = g_strndup (name2, separator2 - name2);
+ } else {
+ top2 = g_strdup (name2);
+ }
+
+
+ cmp = modest_text_utils_utf8_strcmp (top1, top2, TRUE);
+ g_free (top1);
+ g_free (top2);
+
+ if (cmp != 0)
+ return cmp;
+
+ if (separator1 == NULL && separator2 == NULL)
+ return 0;
+
+ next1 = (separator1 != NULL)?separator1 + strlen (MODEST_FOLDER_PATH_SEPARATOR):NULL;
+ next2 = (separator2 != NULL)?separator2 + strlen (MODEST_FOLDER_PATH_SEPARATOR):NULL;
+
+ return compare_folders (next1, next2);
+}
+
+
/*
* This function orders the mail accounts according to these rules:
* 1st - remote accounts
}
/* Pure sort by name */
- cmp = modest_text_utils_utf8_strcmp (name1, name2, TRUE);
+ cmp = compare_folders (name1, name2);
finish:
if (folder1)
g_object_unref(G_OBJECT(folder1));
#ifdef MODEST_TOOLKIT_HILDON2
return;
#endif
+ ModestFolderViewPrivate *priv;
+
+ priv = MODEST_FOLDER_VIEW_GET_PRIVATE (self);
+
gtk_drag_dest_set (GTK_WIDGET (self),
GTK_DEST_DEFAULT_HIGHLIGHT,
folder_view_drag_types,
G_N_ELEMENTS (folder_view_drag_types),
GDK_ACTION_MOVE | GDK_ACTION_COPY);
- g_signal_connect (G_OBJECT (self),
- "drag_data_received",
- G_CALLBACK (on_drag_data_received),
- NULL);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT (self), "drag_data_received",
+ G_CALLBACK (on_drag_data_received), NULL);
/* Set up the treeview as a dnd source */
G_N_ELEMENTS (folder_view_drag_types),
GDK_ACTION_MOVE | GDK_ACTION_COPY);
- g_signal_connect (G_OBJECT (self),
- "drag_motion",
- G_CALLBACK (on_drag_motion),
- NULL);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT (self), "drag_motion",
+ G_CALLBACK (on_drag_motion), NULL);
- g_signal_connect (G_OBJECT (self),
- "drag_data_get",
- G_CALLBACK (on_drag_data_get),
- NULL);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT (self), "drag_data_get",
+ G_CALLBACK (on_drag_data_get), NULL);
- g_signal_connect (G_OBJECT (self),
- "drag_drop",
- G_CALLBACK (drag_drop_cb),
- NULL);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT (self), "drag_drop",
+ G_CALLBACK (drag_drop_cb), NULL);
}
/*
/* Set copied model */
gtk_tree_view_set_model (GTK_TREE_VIEW (folder_view_dst), new_filter_model);
#ifndef MODEST_TOOLKIT_HILDON2
- g_signal_connect (G_OBJECT(new_filter_model), "row-inserted",
- (GCallback) on_row_inserted_maybe_select_folder, folder_view_dst);
+ priv->signal_handlers = modest_signal_mgr_connect (priv->signal_handlers,
+ G_OBJECT(new_filter_model), "row-inserted",
+ (GCallback) on_row_inserted_maybe_select_folder,
+ folder_view_dst);
#endif
#ifdef MODEST_TOOLKIT_HILDON2
if (new_tny_model) {