+2007-05-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_init):
+ Use gtk_window_set_default_size() to make this window big enough, so
+ we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
+
+2007-05-17 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-connection-specific-smtp-edit-window.h:
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init),
+ Do not try to connect to a combobox signal before the combobox exists.
+ This fixes the cras in projects.maemo.org bug NB#56288 .
+ (modest_connection_specific_smtp_edit_window_get_settings):
+ Remove the server_account_name parameter which was being checked for NULL
+ though it was not used.
+
+ * src/maemo/modest-connection-specific-smtp-window.c:
+ (modest_connection_specific_smtp_window_fill_with_connections),
+ (on_button_edit), (modest_connection_specific_smtp_window_init):
+ Correct the number of treemodel columns to prevent a warning.
+ Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
+ libconic does not work.
+
+2007-05-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
+ SMTP when "None" was chosen by the user. However, with my SMTP server that
+ does not support ANONYMOUS, the emails do not leave the Outbox and I see
+ no error dialog.
+
+2007-05-16 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
+ to explain the memory management issue with the ID in the ModestPair.
+
+ * src/gnome/modest-account-assistant.c: (add_receiving_page),
+ (add_sending_page), (modest_account_assistant_finalize):
+ * src/gnome/modest-gnome-global-settings-dialog.c:
+ (create_updating_page), (create_composing_page):
+ * src/gnome/modest-msg-edit-window.c: (get_transports),
+ (init_window), (modest_msg_edit_window_finalize),
+ (modest_msg_edit_window_get_msg_data):
+ * src/gnome/modest-store-widget.c: (imap_pop_configuration):
+ * src/gnome/modest-transport-widget.c:
+ (modest_transport_widget_finalize), (smtp_configuration):
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (create_updating_page), (create_composing_page):
+ * src/maemo/modest-msg-edit-window.c: (get_transports),
+ (init_window), (modest_msg_edit_window_finalize),
+ (modest_msg_edit_window_get_msg_data),
+ (modest_msg_edit_window_free_msg_data):
+ * src/maemo/modest-store-widget.c: (imap_pop_configuration),
+ (modest_store_widget_finalize):
+ * src/maemo/modest-transport-widget.c:
+ (modest_transport_widget_finalize), (smtp_configuration):
+ * src/modest-main.c: (send_mail):
+ * src/widgets/modest-combo-box.h:
+ * src/widgets/modest-global-settings-dialog-priv.h:
+ * src/widgets/modest-global-settings-dialog.c:
+ (modest_global_settings_dialog_finalize):
+ * src/widgets/modest-msg-edit-window.h:
+ Whenever using modest_combo_box_new(), keep the ModestPairList alive
+ as long as the combo box, to prevent use of freed memory for the ID.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
+ get_accounts(), to make this clearer. Do not check for the enabled gconf
+ key, because we do not use this for server accounts (at least, not yet).
+ This allows us to send email again.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-platform.c:
+ (on_modest_conf_update_interval_changed), (modest_platform_init):
+ Only respond to this particular key change. All these strcmp()s cannot be
+ efficient.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-maemo-global-settings-dialog.c:
+ (current_connection): Prevent a crash in scratchbox when
+ ny_maemo_conic_device_get_current_iap_id() returns NULL.
+ * src/maemo/modest-platform.c:
+ (on_modest_conf_update_interval_changed), (modest_platform_init):
+ Get the update interval from gconf and reset it when the gconf key changes.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-protocol-info.c:
+ * src/modest-protocol-info.h: Adde enum-specific get functions,
+ instead of using a ModestProtocolType enum parameter.
+
+ * src/gnome/modest-account-assistant.c:
+ * src/gnome/modest-store-widget.c:
+ * src/gnome/modest-store-widget.h:
+ * src/gnome/modest-transport-widget.c:
+ * src/gnome/modest-transport-widget.h:
+ * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
+ * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ * src/maemo/modest-account-settings-dialog.c:
+ * src/maemo/modest-account-settings-dialog.h:
+ * src/maemo/modest-store-widget.c:
+ * src/maemo/modest-store-widget.h:
+ * src/maemo/modest-transport-widget.c:
+ * src/maemo/modest-transport-widget.h:
+ * src/modest-account-mgr-helpers.c:
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr.c:
+ * src/modest-account-mgr.h:
+ * src/modest-tny-account.c:
+ * src/modest-tny-folder.c:
+ * src/widgets/modest-account-view.c:
+ * src/widgets/modest-retrieve-combo-box.c:
+ * src/widgets/modest-retrieve-combo-box.h:
+ * src/widgets/modest-secureauth-combo-box.c:
+ * src/widgets/modest-serversecurity-combo-box.c:
+ * src/widgets/modest-serversecurity-combo-box.h:
+ * tests/check_account-mgr.c:
+ Use the specific functions, and use the re-renamed enum values for GNOME too.
+
+2007-05-15 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-pair.h:
+ * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
+ so we can get the second based on the first.
+
+ * src/maemo/modest-account-settings-dialog.h:
+ * src/maemo/modest-account-settings-dialog.c:
+ Added get_supported_secure_authentication_methods(), though it is mostly
+ commented-out for now until the necessary API is committed to tinymail.
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration): Request the supported authentication methods from the
+ server, so we can choose a working method.
+
+ * src/modest-tny-account-store.h:
+ * src/modest-tny-account-store.c:
+ (modest_tny_account_store_get_session): Rename from
+ tny_account_store_get_session().
+
+2007-05-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-protocol-info.h: Split the ModestProtocol enum
+ into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
+ There was no need to have these unrelated values in one enum.
+
+ * src/: many files: Adapted to changed enum. This makes the code a bit
+ clearer, and the compiler could catch some errors.
+
+2007-05-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Show the detailed internal camel error message when an error happens
+ during the configuration, so that our testers can give us more clues.
+ For instance, in projects.maemo.org bug NB#56910 .
+
+2007-05-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
+ change tny_account_set_mech() to tny_account_set_secure_auth_mech().
+
+2007-05-14 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
+ * src/maemo/modest-account-settings-dialog.c:
+ (modest_account_settings_dialog_set_account_name),
+ (save_configuration): For the incoming secure authentication checkbox,
+ use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
+ the UI specification. PLAIN does not seem to be supported for most IMAP
+ servers anyway, and I am not sure what it would mean.
+ However, we probably need to discover which of the secure-authentication
+ mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_server_account_data):
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Use tny_account_set_mech() to set secure-authentication methods,
+ with some special-casing for IMAP, based on my observations of how
+ evolution behaves.
+
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr.c:
+ * src/modest-defs.h: Comment that the URI is only used for local folders.
+
+2007-05-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
+ parameter const, just to be neat.
+ * src/modest-text-utils.c: (modest_text_utils_inline):
+ End g_strconcat() with NULL, as its documentation says. This is almost
+ certainly the cause of my crash at startup on the device. Interestingly,
+ valgrind doesn't tell us about these errors.
+
+2007-05-11 Murray Cumming <murrayc@murrayc.com>
+
+ * scripts/build-packages: Added more precise comments about how to use
+ this script, though I still get this error:
+ dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
+ error building tinymail
+
+2007-05-11 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (on_account_update):
+ Very slight cleanup, hoping to make it simpler to discover what causes
+ a crash here sometimes.
+
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account): Set the port. Added
+ comments about the options and a TODO comment because I need to find out
+ how to specify the secure authentication method.
+
+2007-05-11 Marcus Bauer <marcusb@openismus.com>
+
+ * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
+ changed CFlags paths form modest to libmodest
+
+2007-05-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_get_server_account_data),
+ (modest_account_mgr_free_server_account_data):
+ * src/modest-account-mgr-helpers.h:
+ * src/modest-account-mgr.c:
+ (modest_account_mgr_add_server_account):
+ * src/modest-defs.h:
+ * src/modest-tny-account.c:
+ (modest_tny_account_new_from_server_account):
+ Determine the options for tny_camel_account_add_option() here,
+ based on the settings, rather than storing them directly in gconf.
+
+2007-05-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Show a more friendly error dialog now that we expect (from the tinymail
+ documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
+
+2007-05-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (on_account_update): Check that
+ account_name is not NULL, to prevent a crash at startup that I am
+ seeing on the N800. I do wonder why it is NULL.
+
+ * src/maemo/easysetup/modest-easysetup-wizard.c:
+ (create_page_user_details):
+ * src/maemo/modest-account-settings-dialog.c:
+ (create_page_user_details), (create_page_outgoing):
+ * src/maemo/modest-connection-specific-smtp-edit-window.c:
+ (modest_connection_specific_smtp_edit_window_init):
+ * src/modest-ui-actions.c:
+ (modest_ui_actions_on_password_requested):
+ Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
+ might do something useful with the on-screen keyboard.
+
+2007-05-10 Murray Cumming <murrayc@murrayc.com>
+
+ * src/maemo/modest-main-window.c: (on_account_update):
+ Avoid adding a menu item to priv->accounts_popup if accounts_popup is
+ NULL, to avoid lots of warnings. However, it probably should not be NULL.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (on_account_changed):
+ Correct the signature of this signal handler.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
+ Show a HildonNote instead of a GtkDialog for Maemo.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/widgets/modest-account-view.h:
+ * src/widgets/modest-account-view.c: (on_account_changed),
+ (on_account_removed). Added a boolean flag, set/unset by
+ modest_account_view_block_conf_updates(),
+ modest_account_view_unblock_conf_updates() to prevent unnecessary
+ updates, but this is not very useful because the gconf notifications are
+ so delays (maybe only on Maemo Bora).
+ So auto-updating is turned off, and these functions do an explicit
+ update when necessary.
+ However, something else is still doing too much work when adding/removing
+ accounts, probably in another part of the application.
+
+ * src/maemo/modest-account-view-window.c:
+ (on_delete_button_clicked), (on_edit_button_clicked),
+ (on_new_button_clicked): Use the new functions.
+
+2007-05-09 Murray Cumming <murrayc@murrayc.com>
+
+ * src/modest-account-mgr-helpers.c:
+ (modest_account_mgr_set_first_account_as_default):
+ Sort the list of names alphabetically-by-title, so we choose the first one
+ based on that.
+ * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
+ alphabetically by the title.
+
+ This fixes projects.maemo.org bug NB#56418 .
+
+ * src/modest-account-mgr-priv.c:
+ (_modest_account_mgr_account_from_key):
+ * src/modest-account-mgr.c: (on_key_change): Initialize variables to
+ avoid a valgrind error, and possible random behaviour.
+