Add new message button to folders window

[modest] / src / hildon2 / modest-header-window.c

diff --git a/src/hildon2/modest-header-window.c b/src/hildon2/modest-header-window.c
index e2dfaee..02df917 100644 (file)
--- a/src/hildon2/modest-header-window.c
+++ b/src/hildon2/modest-header-window.c
@@ -248,6 +248,8 @@ modest_header_window_finalize (GObject *obj)
        priv = MODEST_HEADER_WINDOW_GET_PRIVATE(obj);
 
        g_object_unref (priv->folder);
+       g_object_unref (priv->header_view);
+       g_object_unref (priv->empty_view);
 
        if (priv->current_store_account) {
                g_free (priv->current_store_account);
@@ -342,11 +344,6 @@ connect_signals (ModestHeaderWindow *self)
                                           self);
 
        /* Mail Operation Queue */
-       priv->queue_change_handler =
-               g_signal_connect (G_OBJECT (modest_runtime_get_mail_operation_queue ()),
-                                 "queue-changed",
-                                 G_CALLBACK (on_queue_changed),
-                                 self);
        priv->sighandlers = modest_signal_mgr_connect (priv->sighandlers,
                                                       G_OBJECT (modest_runtime_get_window_mgr ()),
                                                       "progress-list-changed",
@@ -415,8 +412,26 @@ modest_header_window_new (TnyFolder *folder, const gchar *account_name)
 
        priv->contents_view = hildon_pannable_area_new ();
 
+       /* We need to do this here to properly listen for mail
+          operations because create_header_view launches a mail
+          operation */
+       priv->queue_change_handler =
+               g_signal_connect (G_OBJECT (modest_runtime_get_mail_operation_queue ()),
+                                 "queue-changed",
+                                 G_CALLBACK (on_queue_changed),
+                                 self);
+
        priv->header_view  = create_header_view (MODEST_WINDOW (self), folder);
        priv->empty_view = create_empty_view ();
+
+       /* Transform the floating reference in a "hard" reference. We
+          need to do this because the widgets could be added/removed
+          to containers many times so we always need to keep a
+          reference. It could happen also that some widget is never
+          added to any container */
+       g_object_ref_sink (priv->header_view);
+       g_object_ref_sink (priv->empty_view);
+
        g_signal_connect (G_OBJECT (self), "edit-mode-changed",
                          G_CALLBACK (edit_mode_changed), (gpointer) self);
        setup_menu (self);
@@ -533,6 +548,7 @@ static void setup_menu (ModestHeaderWindow *self)
        hildon_button_set_title (HILDON_BUTTON (priv->sort_button), _("mcen_me_sort"));
        g_signal_connect (G_OBJECT (priv->sort_button), "clicked",
                          G_CALLBACK (modest_ui_actions_on_sort), (gpointer) self);
+       hildon_button_set_style(HILDON_BUTTON (priv->sort_button), HILDON_BUTTON_STYLE_PICKER);
        modest_hildon2_window_add_button_to_menu (MODEST_HILDON2_WINDOW (self), GTK_BUTTON (priv->sort_button),
                                                  modest_ui_dimming_rules_on_sort);
        modest_hildon2_window_add_to_menu (MODEST_HILDON2_WINDOW (self), _("mcen_me_inbox_sendandreceive"), NULL,
@@ -621,7 +637,6 @@ set_contents_state (ModestHeaderWindow *self,
                break;
        }
        priv->contents_state = state;
-       
 }
 
 static void
@@ -629,9 +644,9 @@ on_msg_count_changed (ModestHeaderView *header_view,
                      TnyFolder *folder,
                      TnyFolderChange *change,
                      ModestHeaderWindow *header_window)
-{      
+{
        g_return_if_fail (MODEST_IS_HEADER_WINDOW (header_window));
-       
+
        update_view (MODEST_HEADER_WINDOW (header_window), change);
 }
 
@@ -811,8 +826,6 @@ update_progress_hint (ModestHeaderWindow *self)
                priv->progress_hint = TRUE;
        }
 
-       return;
-
        if (!priv->progress_hint && priv->current_store_account) {
                priv->progress_hint = 
                        modest_window_mgr_has_progress_operation_on_account (modest_runtime_get_window_mgr (),
@@ -956,12 +969,21 @@ edit_mode_changed (ModestHeaderWindow *header_window,
                break;
        }
 
-       if (enabled)
+       if (enabled) {
                modest_header_view_set_filter (MODEST_HEADER_VIEW (priv->header_view), 
                                               filter);
-       else
+       } else {
+               GtkTreeSelection *sel;
+
+               /* Unselect all. This will prevent us from keeping a
+                  reference to a TnyObject that we don't want to
+                  have */
+               sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->header_view));
+               gtk_tree_selection_unselect_all (sel);
+
                modest_header_view_unset_filter (MODEST_HEADER_VIEW (priv->header_view), 
                                                 filter);
+       }
 }
 
 static void