Update copyright stuff, fix conky.conf weirdness.
[monky] / src / linux.c
index 6922667..4703304 100644 (file)
@@ -8,7 +8,7 @@
  *
  * Copyright (c) 2004, Hannu Saransaari and Lauri Hakkarainen
  * Copyright (c) 2007 Toni Spets
- * Copyright (c) 2005-2007 Brenden Matthews, Philip Kovacs, et. al.
+ * Copyright (c) 2005-2009 Brenden Matthews, Philip Kovacs, et. al.
  *     (see AUTHORS)
  * All rights reserved.
  *
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  *
- * $Id$ */
+ */
 
 #include "conky.h"
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
+#include "logging.h"
+#include "common.h"
+#include "linux.h"
 #include <dirent.h>
 #include <ctype.h>
 #include <errno.h>
@@ -52,6 +52,9 @@
 #include <linux/sockios.h>
 #include <net/if.h>
 #include <arpa/inet.h>
+#ifdef _NET_IF_H
+#define _LINUX_IF_H
+#endif
 #include <linux/route.h>
 #include <math.h>
 
@@ -70,11 +73,11 @@ static int show_nice_processes;
  * using a flag in this manner creates less confusing code. */
 static int prefer_proc = 0;
 
-void prepare_update()
+void prepare_update(void)
 {
 }
 
-void update_uptime()
+void update_uptime(void)
 {
 #ifdef HAVE_SYSINFO
        if (!prefer_proc) {
@@ -123,7 +126,7 @@ int check_mount(char *s)
 /* these things are also in sysinfo except Buffers:
  * (that's why I'm reading them from proc) */
 
-void update_meminfo()
+void update_meminfo(void)
 {
        FILE *meminfo_fp;
        static int rep = 0;
@@ -132,7 +135,7 @@ void update_meminfo()
        char buf[256];
 
        info.mem = info.memmax = info.swap = info.swapmax = info.bufmem =
-               info.buffers = info.cached = 0;
+               info.buffers = info.cached = info.memfree = info.memeasyfree = 0;
 
        if (!(meminfo_fp = open_file("/proc/meminfo", &rep))) {
                return;
@@ -144,21 +147,22 @@ void update_meminfo()
                }
 
                if (strncmp(buf, "MemTotal:", 9) == 0) {
-                       sscanf(buf, "%*s %Lu", &info.memmax);
+                       sscanf(buf, "%*s %llu", &info.memmax);
                } else if (strncmp(buf, "MemFree:", 8) == 0) {
-                       sscanf(buf, "%*s %Lu", &info.mem);
+                       sscanf(buf, "%*s %llu", &info.memfree);
                } else if (strncmp(buf, "SwapTotal:", 10) == 0) {
-                       sscanf(buf, "%*s %Lu", &info.swapmax);
+                       sscanf(buf, "%*s %llu", &info.swapmax);
                } else if (strncmp(buf, "SwapFree:", 9) == 0) {
-                       sscanf(buf, "%*s %Lu", &info.swap);
+                       sscanf(buf, "%*s %llu", &info.swap);
                } else if (strncmp(buf, "Buffers:", 8) == 0) {
-                       sscanf(buf, "%*s %Lu", &info.buffers);
+                       sscanf(buf, "%*s %llu", &info.buffers);
                } else if (strncmp(buf, "Cached:", 7) == 0) {
-                       sscanf(buf, "%*s %Lu", &info.cached);
+                       sscanf(buf, "%*s %llu", &info.cached);
                }
        }
 
-       info.mem = info.memmax - info.mem;
+       info.mem = info.memmax - info.memfree;
+       info.memeasyfree = info.memfree;
        info.swap = info.swapmax - info.swap;
 
        info.bufmem = info.cached + info.buffers;
@@ -168,55 +172,75 @@ void update_meminfo()
        fclose(meminfo_fp);
 }
 
-int get_laptop_mode()
+int get_laptop_mode(void)
 {
        FILE *fp;
        int val = -1;
 
        if ((fp = fopen("/proc/sys/vm/laptop_mode", "r")) != NULL)
                fscanf(fp, "%d\n", &val);
+       fclose(fp);
        return val;
 }
 
-int interface_up(const char *dev)
+/* my system says:
+ * # cat /sys/block/sda/queue/scheduler
+ * noop [anticipatory] cfq
+ */
+char *get_ioscheduler(char *disk)
 {
-       int fd;
-       struct ifreq ifr;
+       FILE *fp;
+       char buf[128];
 
-       if((fd = socket(PF_INET, SOCK_DGRAM, 0)) < 0) {
-               CRIT_ERR("could not create sockfd");
-               return 0;
+       if (!disk)
+               return strndup("n/a", text_buffer_size);
+
+       snprintf(buf, 127, "/sys/block/%s/queue/scheduler", disk);
+       if ((fp = fopen(buf, "r")) == NULL) {
+               return strndup("n/a", text_buffer_size);
        }
-       strncpy(ifr.ifr_name, dev, IFNAMSIZ);
-       if(ioctl(fd, SIOCGIFFLAGS, &ifr)) {
-               /* if device does not exist, treat like not up */
-               if (errno != ENODEV)
-                       perror("SIOCGIFFLAGS");
-       } else {
-               close(fd);
-               return (ifr.ifr_flags & IFF_UP);
+       while (!feof(fp)) {
+               fscanf(fp, "%127s", buf);
+               if (buf[0] == '[') {
+                       buf[strlen(buf) - 1] = '\0';
+                       fclose(fp);
+                       return strndup(buf + 1, text_buffer_size);
+               }
        }
-       close(fd);
-       return 0;
+       fclose(fp);
+       return strndup("n/a", text_buffer_size);
 }
 
 #define COND_FREE(x) if(x) free(x); x = 0
 #define SAVE_SET_STRING(x, y) \
        if (x && strcmp((char *)x, (char *)y)) { \
                free(x); \
-               x = strdup("multiple"); \
+               x = strndup("multiple", text_buffer_size); \
        } else if (!x) { \
-               x = strdup(y); \
+               x = strndup(y, text_buffer_size); \
        }
 
-void update_gateway_info()
+void update_gateway_info_failure(const char *reason)
+{
+       if(reason != NULL) {
+               perror(reason);
+       }
+       //2 pointers to 1 location causes a crash when we try to free them both
+       info.gw_info.iface = strndup("failed", text_buffer_size);
+       info.gw_info.ip = strndup("failed", text_buffer_size);
+}
+
+
+/* Iface Destination Gateway Flags RefCnt Use Metric Mask MTU Window IRTT */
+#define RT_ENTRY_FORMAT "%63s %lx %lx %x %*d %*d %*d %lx %*d %*d %*d\n"
+
+void update_gateway_info(void)
 {
        FILE *fp;
        struct in_addr ina;
        char iface[64];
        unsigned long dest, gate, mask;
        unsigned int flags;
-       short ref, use, metric, mtu, win, irtt;
 
        struct gateway_info *gw_info = &info.gw_info;
 
@@ -225,22 +249,20 @@ void update_gateway_info()
        gw_info->count = 0;
 
        if ((fp = fopen("/proc/net/route", "r")) == NULL) {
-               perror("fopen()");
-               goto FAIL;
-       }
-       if (fscanf(fp, "%*[^\n]\n") == EOF) {
-               perror("fscanf()");
-               goto CLOSE_FAIL;
+               update_gateway_info_failure("fopen()");
+               return;
        }
+
+       /* skip over the table header line, which is always present */
+       fscanf(fp, "%*[^\n]\n");
+
        while (!feof(fp)) {
-               // Iface Destination Gateway Flags RefCnt Use Metric Mask MTU Window IRTT
-               if(fscanf(fp, "%63s %lx %lx %x %hd %hd %hd %lx %hd %hd %hd\n",
-                               iface, &dest, &gate, &flags, &ref, &use,
-                               &metric, &mask, &mtu, &win, &irtt) != 11) {
-                       perror("fscanf()");
-                       goto CLOSE_FAIL;
+               if(fscanf(fp, RT_ENTRY_FORMAT,
+                         iface, &dest, &gate, &flags, &mask) != 5) {
+                       update_gateway_info_failure("fscanf()");
+                       break;
                }
-               if (flags & RTF_GATEWAY && dest == 0 && mask == 0) {
+               if (!(dest || mask) && ((flags & RTF_GATEWAY) || !gate) ) {
                        gw_info->count++;
                        SAVE_SET_STRING(gw_info->iface, iface)
                        ina.s_addr = gate;
@@ -249,17 +271,13 @@ void update_gateway_info()
        }
        fclose(fp);
        return;
-CLOSE_FAIL:
-       fclose(fp);
-FAIL:
-       info.gw_info.iface = info.gw_info.ip = strdup("failed");
-       return;
 }
 
-inline void update_net_stats()
+void update_net_stats(void)
 {
        FILE *net_dev_fp;
        static int rep = 0;
+       static char first = 1;
 
        // FIXME: arbitrary size chosen to keep code simple.
        int i, i2;
@@ -295,7 +313,7 @@ inline void update_net_stats()
        for (i2 = 0; i2 < 16; i2++) {
                struct net_stat *ns;
                char *s, *p;
-        char temp_addr[17];
+               char temp_addr[18];
                long long r, t, last_recv, last_trans;
 
                if (fgets(buf, 255, net_dev_fp) == NULL) {
@@ -320,17 +338,14 @@ inline void update_net_stats()
                ns = get_net_stat(s);
                ns->up = 1;
                memset(&(ns->addr.sa_data), 0, 14);
-        if(NULL == ns->addrs)
-            ns->addrs = (char*) malloc(17 * 16);
-        if(NULL != ns->addrs)
-             memset(ns->addrs, 0, 17 * 16); /* Up to 17 chars per ip, max 16 interfaces. Nasty memory usage... */
+
+               memset(ns->addrs, 0, 17 * 16 + 1); /* Up to 17 chars per ip, max 16 interfaces. Nasty memory usage... */
+
                last_recv = ns->recv;
                last_trans = ns->trans;
 
                /* bytes packets errs drop fifo frame compressed multicast|bytes ... */
-               sscanf(p, "%Ld  %*d     %*d  %*d  %*d  %*d   %*d        %*d       %Ld",
+               sscanf(p, "%lld  %*d     %*d  %*d  %*d  %*d   %*d        %*d       %lld",
                        &r, &t);
 
                /* if recv or trans is less than last time, an overflow happened */
@@ -352,27 +367,27 @@ inline void update_net_stats()
                i = socket(PF_INET, SOCK_DGRAM, IPPROTO_IP);
 
                conf.ifc_buf = malloc(sizeof(struct ifreq) * 16);
-
                conf.ifc_len = sizeof(struct ifreq) * 16;
+               memset(conf.ifc_buf, 0, conf.ifc_len);
 
                ioctl((long) i, SIOCGIFCONF, &conf);
 
                for (k = 0; k < conf.ifc_len / sizeof(struct ifreq); k++) {
-                       struct net_stat *ns;
-
-                       ns = get_net_stat(
-                               ((struct ifreq *) conf.ifc_buf)[k].ifr_ifrn.ifrn_name);
-                       ns->addr = ((struct ifreq *) conf.ifc_buf)[k].ifr_ifru.ifru_addr;
-           if(NULL != ns->addrs)
-           {
-               sprintf(temp_addr, "%u.%u.%u.%u, ",
-                   ns->addr.sa_data[2] & 255,
-                   ns->addr.sa_data[3] & 255,
-                   ns->addr.sa_data[4] & 255,
-                   ns->addr.sa_data[5] & 255);
-               if(NULL == strstr(ns->addrs, temp_addr))
-                   strncpy(ns->addrs + strlen(ns->addrs), temp_addr, 17);
-            }
+                       struct net_stat *ns2;
+
+                       if (!(((struct ifreq *) conf.ifc_buf) + k))
+                               break;
+
+                       ns2 = get_net_stat(
+                                       ((struct ifreq *) conf.ifc_buf)[k].ifr_ifrn.ifrn_name);
+                       ns2->addr = ((struct ifreq *) conf.ifc_buf)[k].ifr_ifru.ifru_addr;
+                       sprintf(temp_addr, "%u.%u.%u.%u, ",
+                                       ns2->addr.sa_data[2] & 255,
+                                       ns2->addr.sa_data[3] & 255,
+                                       ns2->addr.sa_data[4] & 255,
+                                       ns2->addr.sa_data[5] & 255);
+                       if(NULL == strstr(ns2->addrs, temp_addr))
+                               strncpy(ns2->addrs + strlen(ns2->addrs), temp_addr, 17);
                }
 
                close((long) i);
@@ -381,9 +396,12 @@ inline void update_net_stats()
 
                /*** end ip addr patch ***/
 
-               /* calculate speeds */
-               ns->net_rec[0] = (ns->recv - last_recv) / delta;
-               ns->net_trans[0] = (ns->trans - last_trans) / delta;
+               if (!first) {
+                       /* calculate speeds */
+                       ns->net_rec[0] = (ns->recv - last_recv) / delta;
+                       ns->net_trans[0] = (ns->trans - last_trans) / delta;
+               }
+
                curtmp1 = 0;
                curtmp2 = 0;
                // get an average
@@ -464,6 +482,7 @@ inline void update_net_stats()
                free(winfo);
 #endif
        }
+       first = 0;
 
        fclose(net_dev_fp);
 
@@ -472,7 +491,7 @@ inline void update_net_stats()
 
 int result;
 
-void update_total_processes()
+void update_total_processes(void)
 {
 #ifdef HAVE_SYSINFO
        if (!prefer_proc) {
@@ -490,7 +509,7 @@ void update_total_processes()
                        info.procs = 0;
                        return;
                }
-               fscanf(fp, "%*f %*f %*f %*d/%hd", &info.procs);
+               fscanf(fp, "%*f %*f %*f %*d/%hu", &info.procs);
                fclose(fp);
        }
        info.mask |= (1 << INFO_PROCS);
@@ -531,15 +550,15 @@ void determine_longstat(char *buf)
        }
 }
 
-void get_cpu_count()
+void get_cpu_count(void)
 {
        FILE *stat_fp;
        static int rep = 0;
+       char buf[256];
 
        if (info.cpu_usage) {
                return;
        }
-       char buf[256];
 
        if (!(stat_fp = open_file("/proc/stat", &rep))) {
                return;
@@ -567,16 +586,16 @@ void get_cpu_count()
 #define TMPL_LONGSTAT "%*s %llu %llu %llu %llu %llu %llu %llu %llu"
 #define TMPL_SHORTSTAT "%*s %llu %llu %llu %llu"
 
-inline static void update_stat()
+inline static void update_stat(void)
 {
        FILE *stat_fp;
        static int rep = 0;
        static struct cpu_info *cpu = NULL;
        char buf[256];
        unsigned int i;
-       unsigned int index;
+       unsigned int idx;
        double curtmp;
-       char *stat_template = NULL;
+       const char *stat_template = NULL;
        unsigned int malloc_cpu_size = 0;
 
        /* add check for !info.cpu_usage since that mem is freed on a SIGUSR1 */
@@ -604,7 +623,7 @@ inline static void update_stat()
                return;
        }
 
-       index = 0;
+       idx = 0;
        while (!feof(stat_fp)) {
                if (fgets(buf, 255, stat_fp) == NULL) {
                        break;
@@ -614,68 +633,73 @@ inline static void update_stat()
                        sscanf(buf, "%*s %hu", &info.run_procs);
                        info.mask |= (1 << INFO_RUN_PROCS);
                } else if (strncmp(buf, "cpu", 3) == 0) {
-                       index = isdigit(buf[3]) ? ((int) buf[3]) - 0x2F : 0;
-                       sscanf(buf, stat_template, &(cpu[index].cpu_user),
-                               &(cpu[index].cpu_nice), &(cpu[index].cpu_system),
-                               &(cpu[index].cpu_idle), &(cpu[index].cpu_iowait),
-                               &(cpu[index].cpu_irq), &(cpu[index].cpu_softirq),
-                               &(cpu[index].cpu_steal));
-
-                       cpu[index].cpu_total = cpu[index].cpu_user + cpu[index].cpu_nice +
-                               cpu[index].cpu_system + cpu[index].cpu_idle +
-                               cpu[index].cpu_iowait + cpu[index].cpu_irq +
-                               cpu[index].cpu_softirq + cpu[index].cpu_steal;
-
-                       cpu[index].cpu_active_total = cpu[index].cpu_total -
-                               (cpu[index].cpu_idle + cpu[index].cpu_iowait);
+                       double delta;
+                       if (isdigit(buf[3])) {
+                               idx = atoi(&buf[3]) + 1;
+                       } else {
+                               idx = 0;
+                       }
+                       sscanf(buf, stat_template, &(cpu[idx].cpu_user),
+                               &(cpu[idx].cpu_nice), &(cpu[idx].cpu_system),
+                               &(cpu[idx].cpu_idle), &(cpu[idx].cpu_iowait),
+                               &(cpu[idx].cpu_irq), &(cpu[idx].cpu_softirq),
+                               &(cpu[idx].cpu_steal));
+
+                       cpu[idx].cpu_total = cpu[idx].cpu_user + cpu[idx].cpu_nice +
+                               cpu[idx].cpu_system + cpu[idx].cpu_idle +
+                               cpu[idx].cpu_iowait + cpu[idx].cpu_irq +
+                               cpu[idx].cpu_softirq + cpu[idx].cpu_steal;
+
+                       cpu[idx].cpu_active_total = cpu[idx].cpu_total -
+                               (cpu[idx].cpu_idle + cpu[idx].cpu_iowait);
                        info.mask |= (1 << INFO_CPU);
 
-                       double delta = current_update_time - last_update_time;
+                       delta = current_update_time - last_update_time;
 
                        if (delta <= 0.001) {
                                break;
                        }
 
-                       cpu[index].cpu_val[0] = (cpu[index].cpu_active_total -
-                               cpu[index].cpu_last_active_total) /
-                               (float) (cpu[index].cpu_total - cpu[index].cpu_last_total);
+                       cpu[idx].cpu_val[0] = (cpu[idx].cpu_active_total -
+                               cpu[idx].cpu_last_active_total) /
+                               (float) (cpu[idx].cpu_total - cpu[idx].cpu_last_total);
                        curtmp = 0;
                        for (i = 0; i < info.cpu_avg_samples; i++) {
-                               curtmp += cpu[index].cpu_val[i];
+                               curtmp += cpu[idx].cpu_val[i];
                        }
                        /* TESTING -- I've removed this, because I don't think it is right.
                         * You shouldn't divide by the cpu count here ...
                         * removing for testing */
-                       /* if (index == 0) {
-                               info.cpu_usage[index] = curtmp / info.cpu_avg_samples /
+                       /* if (idx == 0) {
+                               info.cpu_usage[idx] = curtmp / info.cpu_avg_samples /
                                        info.cpu_count;
                        } else {
-                               info.cpu_usage[index] = curtmp / info.cpu_avg_samples;
+                               info.cpu_usage[idx] = curtmp / info.cpu_avg_samples;
                        } */
                        /* TESTING -- this line replaces the prev. "suspect" if/else */
-                       info.cpu_usage[index] = curtmp / info.cpu_avg_samples;
+                       info.cpu_usage[idx] = curtmp / info.cpu_avg_samples;
 
-                       cpu[index].cpu_last_total = cpu[index].cpu_total;
-                       cpu[index].cpu_last_active_total = cpu[index].cpu_active_total;
+                       cpu[idx].cpu_last_total = cpu[idx].cpu_total;
+                       cpu[idx].cpu_last_active_total = cpu[idx].cpu_active_total;
                        for (i = info.cpu_avg_samples - 1; i > 0; i--) {
-                               cpu[index].cpu_val[i] = cpu[index].cpu_val[i - 1];
+                               cpu[idx].cpu_val[i] = cpu[idx].cpu_val[i - 1];
                        }
                }
        }
        fclose(stat_fp);
 }
 
-void update_running_processes()
+void update_running_processes(void)
 {
        update_stat();
 }
 
-void update_cpu_usage()
+void update_cpu_usage(void)
 {
        update_stat();
 }
 
-void update_load_average()
+void update_load_average(void)
 {
 #ifdef HAVE_GETLOADAVG
        if (!prefer_proc) {
@@ -705,7 +729,7 @@ void update_load_average()
 #define PROC_I8K "/proc/i8k"
 #define I8K_DELIM " "
 static char *i8k_procbuf = NULL;
-void update_i8k()
+void update_i8k(void)
 {
        FILE *fp;
 
@@ -780,7 +804,7 @@ static int get_first_file_in_a_directory(const char *dir, char *s, int *rep)
 }
 
 int open_sysfs_sensor(const char *dir, const char *dev, const char *type, int n,
-               int *div, char *devtype)
+               int *divisor, char *devtype)
 {
        char path[256];
        char buf[256];
@@ -828,14 +852,14 @@ int open_sysfs_sensor(const char *dir, const char *dev, const char *type, int n,
        fd = open(path, O_RDONLY);
        if (fd < 0) {
                CRIT_ERR("can't open '%s': %s\nplease check your device or remove this "
-                       "var from Conky", path, strerror(errno));
+                       "var from "PACKAGE_NAME, path, strerror(errno));
        }
 
        if (strcmp(type, "in") == 0 || strcmp(type, "temp") == 0
                        || strcmp(type, "tempf") == 0) {
-               *div = 1;
+               *divisor = 1;
        } else {
-               *div = 0;
+               *divisor = 0;
        }
        /* fan does not use *_div as a read divisor */
        if (strcmp("fan", type) == 0) {
@@ -862,7 +886,7 @@ int open_sysfs_sensor(const char *dir, const char *dev, const char *type, int n,
                        ERR("open_sysfs_sensor(): can't read from sysfs");
                } else {
                        divbuf[divn] = '\0';
-                       *div = atoi(divbuf);
+                       *divisor = atoi(divbuf);
                }
        }
 
@@ -871,7 +895,7 @@ int open_sysfs_sensor(const char *dir, const char *dev, const char *type, int n,
        return fd;
 }
 
-double get_sysfs_info(int *fd, int div, char *devtype, char *type)
+double get_sysfs_info(int *fd, int divisor, char *devtype, char *type)
 {
        int val = 0;
 
@@ -912,17 +936,17 @@ double get_sysfs_info(int *fd, int div, char *devtype, char *type)
        /* divide voltage and temperature by 1000 */
        /* or if any other divisor is given, use that */
        if (strcmp(type, "tempf") == 0) {
-               if (div > 1) {
-                       return ((val / div + 40) * 9.0 / 5) - 40;
-               } else if (div) {
+               if (divisor > 1) {
+                       return ((val / divisor + 40) * 9.0 / 5) - 40;
+               } else if (divisor) {
                        return ((val / 1000.0 + 40) * 9.0 / 5) - 40;
                } else {
                        return ((val + 40) * 9.0 / 5) - 40;
                }
        } else {
-               if (div > 1) {
-                       return val / div;
-               } else if (div) {
+               if (divisor > 1) {
+                       return val / divisor;
+               } else if (divisor) {
                        return val / 1000.0;
                } else {
                        return val;
@@ -985,75 +1009,12 @@ void get_adt746x_cpu(char *p_client_buffer, size_t client_buffer_size)
        snprintf(p_client_buffer, client_buffer_size, "%s", adt746x_cpu_state);
 }
 
-/* Thanks to "Walt Nelson" <wnelsonjr@comcast.net> */
-
-/***********************************************************************/
-/* This file is part of x86info.
- * (C) 2001 Dave Jones.
- *
- * Licensed under the terms of the GNU GPL License version 2.
- *
- * Estimate CPU MHz routine by Andrea Arcangeli <andrea@suse.de>
- * Small changes by David Sterba <sterd9am@ss1000.ms.mff.cuni.cz> */
-
-#if  defined(__i386) || defined(__x86_64)
-__inline__ unsigned long long int rdtsc()
-{
-       unsigned long long int x;
-
-       __asm__ volatile(".byte 0x0f, 0x31":"=A" (x));
-       return x;
-}
-#endif
-
-/* return system frequency in MHz (use divisor=1) or GHz (use divisor=1000) */
-void get_freq_dynamic(char *p_client_buffer, size_t client_buffer_size,
-               char *p_format, int divisor)
-{
-#if  defined(__i386) || defined(__x86_64)
-       struct timezone tz;
-       struct timeval tvstart, tvstop;
-       unsigned long long cycles[2];   /* gotta be 64 bit */
-       unsigned int microseconds;      /* total time taken */
-
-       if (!p_client_buffer || client_buffer_size <= 0 || !p_format
-                       || divisor <= 0) {
-               return;
-       }
-
-       memset(&tz, 0, sizeof(tz));
-
-       /* get this function in cached memory */
-       gettimeofday(&tvstart, &tz);
-       cycles[0] = rdtsc();
-       gettimeofday(&tvstart, &tz);
-
-       /* we don't trust that this is any specific length of time */
-       usleep(100);
-       cycles[1] = rdtsc();
-       gettimeofday(&tvstop, &tz);
-       microseconds = ((tvstop.tv_sec - tvstart.tv_sec) * 1000000) +
-               (tvstop.tv_usec - tvstart.tv_usec);
-
-       snprintf(p_client_buffer, client_buffer_size, p_format,
-               (float) ((cycles[1] - cycles[0]) / microseconds) / divisor);
-       return;
-#else
-       /* FIXME: hardwired: get freq for first cpu!
-        * this whole function needs to be rethought and redone for
-        * multi-cpu/multi-core/multi-threaded environments and
-        * arbitrary combinations thereof */
-       get_freq(p_client_buffer, client_buffer_size, p_format, divisor, 1);
-       return;
-#endif
-}
-
 #define CPUFREQ_PREFIX "/sys/devices/system/cpu"
 #define CPUFREQ_POSTFIX "cpufreq/scaling_cur_freq"
 
 /* return system frequency in MHz (use divisor=1) or GHz (use divisor=1000) */
-char get_freq(char *p_client_buffer, size_t client_buffer_size, char *p_format,
-               int divisor, unsigned int cpu)
+char get_freq(char *p_client_buffer, size_t client_buffer_size,
+               const char *p_format, int divisor, unsigned int cpu)
 {
        FILE *f;
        static int rep = 0;
@@ -1089,7 +1050,7 @@ char get_freq(char *p_client_buffer, size_t client_buffer_size, char *p_format,
        // open the CPU information file
        f = open_file("/proc/cpuinfo", &rep);
        if (!f) {
-               perror("Conky: Failed to access '/proc/cpuinfo' at get_freq()");
+               perror(PACKAGE_NAME": Failed to access '/proc/cpuinfo' at get_freq()");
                return 0;
        }
 
@@ -1151,7 +1112,7 @@ char get_freq(char *p_client_buffer, size_t client_buffer_size, char *p_format,
 
 /* return cpu voltage in mV (use divisor=1) or V (use divisor=1000) */
 char get_voltage(char *p_client_buffer, size_t client_buffer_size,
-               char *p_format, int divisor, unsigned int cpu)
+               const char *p_format, int divisor, unsigned int cpu)
 {
        FILE *f;
        char s[256];
@@ -1179,7 +1140,7 @@ char get_voltage(char *p_client_buffer, size_t client_buffer_size,
                }
                fclose(f);
        } else {
-               fprintf(stderr, "Conky: Failed to access '%s' at ", current_freq_file);
+               fprintf(stderr, PACKAGE_NAME": Failed to access '%s' at ", current_freq_file);
                perror("get_voltage()");
                if (f) {
                        fclose(f);
@@ -1207,7 +1168,7 @@ char get_voltage(char *p_client_buffer, size_t client_buffer_size,
                }
                fclose(f);
        } else {
-               fprintf(stderr, "Conky: Failed to access '%s' at ", current_freq_file);
+               fprintf(stderr, PACKAGE_NAME": Failed to access '%s' at ", current_freq_file);
                perror("get_voltage()");
                if (f) {
                        fclose(f);
@@ -1253,11 +1214,24 @@ void get_acpi_fan(char *p_client_buffer, size_t client_buffer_size)
        snprintf(p_client_buffer, client_buffer_size, "%s", buf);
 }
 
+#define SYSFS_AC_ADAPTER_DIR "/sys/class/power_supply/AC"
 #define ACPI_AC_ADAPTER_DIR "/proc/acpi/ac_adapter/"
+/* Linux 2.6.25 onwards ac adapter info is in
+   /sys/class/power_supply/AC/
+   On my system I get the following.
+     /sys/class/power_supply/AC/uevent:
+     PHYSDEVPATH=/devices/LNXSYSTM:00/device:00/PNP0A08:00/device:01/PNP0C09:00/ACPI0003:00
+     PHYSDEVBUS=acpi
+     PHYSDEVDRIVER=ac
+     POWER_SUPPLY_NAME=AC
+     POWER_SUPPLY_TYPE=Mains
+     POWER_SUPPLY_ONLINE=1
+*/
 
 void get_acpi_ac_adapter(char *p_client_buffer, size_t client_buffer_size)
 {
        static int rep = 0;
+
        char buf[256];
        char buf2[256];
        FILE *fp;
@@ -1266,25 +1240,44 @@ void get_acpi_ac_adapter(char *p_client_buffer, size_t client_buffer_size)
                return;
        }
 
-       /* yeah, slow... :/ */
-       if (!get_first_file_in_a_directory(ACPI_AC_ADAPTER_DIR, buf, &rep)) {
-               snprintf(p_client_buffer, client_buffer_size, "no ac_adapters?");
-               return;
-       }
+       snprintf(buf2, sizeof(buf2), "%s/uevent", SYSFS_AC_ADAPTER_DIR);
+       fp = open_file(buf2, &rep);
+       if (fp) {
+               /* sysfs processing */
+               while (!feof(fp)) {
+                       if (fgets(buf, sizeof(buf), fp) == NULL)
+                               break;
 
-       snprintf(buf2, sizeof(buf2), "%s%s/state", ACPI_AC_ADAPTER_DIR, buf);
+                       if (strncmp(buf, "POWER_SUPPLY_ONLINE=", 20) == 0) {
+                               int online = 0;
+                               sscanf(buf, "POWER_SUPPLY_ONLINE=%d", &online);
+                               snprintf(p_client_buffer, client_buffer_size,
+                                        "%s-line", (online ? "on" : "off"));
+                               break;
+                       }
+               }
+               fclose(fp);
+       } else {
+               /* yeah, slow... :/ */
+               if (!get_first_file_in_a_directory(ACPI_AC_ADAPTER_DIR, buf, &rep)) {
+                       snprintf(p_client_buffer, client_buffer_size, "no ac_adapters?");
+                       return;
+               }
 
-       fp = open_file(buf2, &rep);
-       if (!fp) {
-               snprintf(p_client_buffer, client_buffer_size,
-                       "No ac adapter found.... where is it?");
-               return;
-       }
-       memset(buf, 0, sizeof(buf));
-       fscanf(fp, "%*s %99s", buf);
-       fclose(fp);
+               snprintf(buf2, sizeof(buf2), "%s%s/state", ACPI_AC_ADAPTER_DIR, buf);
 
-       snprintf(p_client_buffer, client_buffer_size, "%s", buf);
+               fp = open_file(buf2, &rep);
+               if (!fp) {
+                       snprintf(p_client_buffer, client_buffer_size,
+                                "No ac adapter found.... where is it?");
+                       return;
+               }
+               memset(buf, 0, sizeof(buf));
+               fscanf(fp, "%*s %99s", buf);
+               fclose(fp);
+
+               snprintf(p_client_buffer, client_buffer_size, "%s", buf);
+       }
 }
 
 /*
@@ -1434,9 +1427,9 @@ present voltage:         16608 mV
 #define APM_PATH "/proc/apm"
 #define MAX_BATTERY_COUNT 4
 
-static FILE *sysfs_bat_fp[MAX_BATTERY_COUNT];
-static FILE *acpi_bat_fp[MAX_BATTERY_COUNT];
-static FILE *apm_bat_fp[MAX_BATTERY_COUNT];
+static FILE *sysfs_bat_fp[MAX_BATTERY_COUNT] = { NULL, NULL, NULL, NULL };
+static FILE *acpi_bat_fp[MAX_BATTERY_COUNT] = { NULL, NULL, NULL, NULL };
+static FILE *apm_bat_fp[MAX_BATTERY_COUNT] = { NULL, NULL, NULL, NULL };
 
 static int batteries_initialized = 0;
 static char batteries[MAX_BATTERY_COUNT][32];
@@ -1485,13 +1478,15 @@ int get_battery_idx(const char *bat)
        return idx;
 }
 
-void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
+void set_return_value(char *buffer, unsigned int n, int item, int idx);
+
+void get_battery_stuff(char *buffer, unsigned int n, const char *bat, int item)
 {
-       static int idx, rep = 0, rep2 = 0;
+       static int idx, rep = 0, rep1 = 0, rep2 = 0;
        char acpi_path[128];
+       char sysfs_path[128];
 
        snprintf(acpi_path, 127, ACPI_BATTERY_BASE_PATH "/%s/state", bat);
-       char sysfs_path[128];
        snprintf(sysfs_path, 127, SYSFS_BATTERY_BASE_PATH "/%s/uevent", bat);
 
        init_batteries();
@@ -1500,7 +1495,8 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
 
        /* don't update battery too often */
        if (current_update_time - last_battery_time[idx] < 29.5) {
-               goto set_return_value;
+               set_return_value(buffer, n, item, idx);
+               return;
        }
 
        last_battery_time[idx] = current_update_time;
@@ -1509,32 +1505,34 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
        memset(last_battery_time_str[idx], 0, sizeof(last_battery_time_str[idx]));
 
        /* first try SYSFS if that fails try ACPI */
-       if (sysfs_bat_fp[idx] == NULL && acpi_bat_fp[idx] == NULL && apm_bat_fp[idx] == NULL)
+
+       if (sysfs_bat_fp[idx] == NULL && acpi_bat_fp[idx] == NULL && apm_bat_fp[idx] == NULL) {
                sysfs_bat_fp[idx] = open_file(sysfs_path, &rep);
-  
-       if (sysfs_bat_fp[idx] == NULL && acpi_bat_fp[idx] == NULL && apm_bat_fp[idx] == NULL)
-               acpi_bat_fp[idx] = open_file(acpi_path, &rep);
-  
+       }
+
+       if (sysfs_bat_fp[idx] == NULL && acpi_bat_fp[idx] == NULL && apm_bat_fp[idx] == NULL) {
+               acpi_bat_fp[idx] = open_file(acpi_path, &rep1);
+       }
+
        if (sysfs_bat_fp[idx] != NULL) {
                /* SYSFS */
                int present_rate = -1;
                int remaining_capacity = -1;
                char charging_state[64];
                char present[4];
-               strcpy(charging_state, "Unknown");
+
+               strcpy(charging_state, "unknown");
+
                while (!feof(sysfs_bat_fp[idx])) {
                        char buf[256];
                        if (fgets(buf, 256, sysfs_bat_fp[idx]) == NULL)
                                break;
+
                        /* let's just hope units are ok */
                        if (strncmp (buf, "POWER_SUPPLY_PRESENT=1", 22) == 0)
-                               strcpy(present, "Yes");
+                               strcpy(present, "yes");
                        else if (strncmp (buf, "POWER_SUPPLY_PRESENT=0", 22) == 0)
-                               strcpy(present, "No");
+                               strcpy(present, "no");
                        else if (strncmp (buf, "POWER_SUPPLY_STATUS=", 20) == 0)
                                sscanf(buf, "POWER_SUPPLY_STATUS=%63s", charging_state);
                        /* present_rate is not the same as the
@@ -1552,14 +1550,14 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
                        else if (strncmp(buf, "POWER_SUPPLY_CHARGE_FULL=", 25) == 0)
                                sscanf(buf, "POWER_SUPPLY_CHARGE_FULL=%d", &acpi_last_full[idx]);
                }
+
                fclose(sysfs_bat_fp[idx]);
                sysfs_bat_fp[idx] = NULL;
+
                /* Hellf[i]re notes that remaining capacity can exceed acpi_last_full */
                if (remaining_capacity > acpi_last_full[idx])
                        acpi_last_full[idx] = remaining_capacity;  /* normalize to 100% */
+
                /* not present */
                if (strcmp(present, "No") == 0) {
                        strncpy(last_battery_str[idx], "not present", 64);
@@ -1568,33 +1566,41 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
                else if (strcmp(charging_state, "Charging") == 0) {
                        if (acpi_last_full[idx] != 0 && present_rate > 0) {
                                /* e.g. charging 75% */
-                               snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1, "Charging %i%%",
+                               snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1, "charging %i%%",
                                        (int) (((float) remaining_capacity / acpi_last_full[idx]) * 100 ));
                                /* e.g. 2h 37m */
                                format_seconds(last_battery_time_str[idx], sizeof(last_battery_time_str[idx])-1,
                                              (long) (((float)(acpi_last_full[idx] - remaining_capacity) / present_rate) * 3600));
                        } else if (acpi_last_full[idx] != 0 && present_rate <= 0) {
-                               snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1, "Charging %d%%",
+                               snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1, "charging %d%%",
                                        (int) (((float)remaining_capacity / acpi_last_full[idx]) * 100));
+                               snprintf(last_battery_time_str[idx],
+                                       sizeof(last_battery_time_str[idx]) - 1, "unknown");
                        } else {
-                               strncpy(last_battery_str[idx], "Charging", sizeof(last_battery_str[idx])-1);
+                               strncpy(last_battery_str[idx], "charging", sizeof(last_battery_str[idx])-1);
+                               snprintf(last_battery_time_str[idx],
+                                       sizeof(last_battery_time_str[idx]) - 1, "unknown");
                        }
                }
                /* discharging */
                else if (strncmp(charging_state, "Discharging", 64) == 0) {
                        if (present_rate > 0) {
                                /* e.g. discharging 35% */
-                               snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1, "Discharging %i%%",
+                               snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1, "discharging %i%%",
                                        (int) (((float) remaining_capacity / acpi_last_full[idx]) * 100 ));
                                /* e.g. 1h 12m */
                                format_seconds(last_battery_time_str[idx], sizeof(last_battery_time_str[idx])-1,
-                                             (long) (((float)(acpi_last_full[idx] - remaining_capacity) / present_rate) * 3600));
+                                             (long) (((float) remaining_capacity / present_rate) * 3600));
                        } else if (present_rate == 0) { /* Thanks to Nexox for this one */
-                               snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1, "Full");
+                               snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1, "full");
+                               snprintf(last_battery_time_str[idx],
+                                       sizeof(last_battery_time_str[idx]) - 1, "unknown");
                        } else {
                                snprintf(last_battery_str[idx], sizeof(last_battery_str[idx])-1,
-                                       "Discharging %d%%",
+                                       "discharging %d%%",
                                        (int) (((float)remaining_capacity / acpi_last_full[idx]) * 100));
+                               snprintf(last_battery_time_str[idx],
+                                       sizeof(last_battery_time_str[idx]) - 1, "unknown");
                        }
                }
                /* charged */
@@ -1604,21 +1610,21 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
                                 * when the second one is empty and the first one
                                 * being charged. */
                                if (remaining_capacity == 0)
-                                       strcpy(last_battery_str[idx], "Empty");
+                                       strcpy(last_battery_str[idx], "empty");
                                else
-                                       strcpy(last_battery_str[idx], "Charged");
+                                       strcpy(last_battery_str[idx], "charged");
                }
                /* unknown, probably full / AC */
                else {
                        if (acpi_last_full[idx] != 0
                            && remaining_capacity != acpi_last_full[idx])
-                               snprintf(last_battery_str[idx], 64, "Unknown %d%%",
+                               snprintf(last_battery_str[idx], 64, "unknown %d%%",
                                        (int) (((float)remaining_capacity / acpi_last_full[idx]) * 100));
                        else
                                strncpy(last_battery_str[idx], "AC", 64);
                }
-       } else if (acpi_bat_fp[idx] != NULL) {
-               /* ACPI */
+       } else if (acpi_bat_fp[idx] != NULL) {
+               /* ACPI */
                int present_rate = -1;
                int remaining_capacity = -1;
                char charging_state[64];
@@ -1626,12 +1632,12 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
 
                /* read last full capacity if it's zero */
                if (acpi_last_full[idx] == 0) {
-                       static int rep = 0;
+                       static int rep3 = 0;
                        char path[128];
                        FILE *fp;
 
                        snprintf(path, 127, ACPI_BATTERY_BASE_PATH "/%s/info", bat);
-                       fp = open_file(path, &rep);
+                       fp = open_file(path, &rep3);
                        if (fp != NULL) {
                                while (!feof(fp)) {
                                        char b[256];
@@ -1640,7 +1646,7 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
                                                break;
                                        }
                                        if (sscanf(b, "last full capacity: %d",
-                                                       &acpi_last_full[idx]) != 0) {
+                                                               &acpi_last_full[idx]) != 0) {
                                                break;
                                        }
                                }
@@ -1680,46 +1686,54 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
                /* not present */
                if (strcmp(present, "no") == 0) {
                        strncpy(last_battery_str[idx], "not present", 64);
-               /* charging */
+                       /* charging */
                } else if (strcmp(charging_state, "charging") == 0) {
                        if (acpi_last_full[idx] != 0 && present_rate > 0) {
                                /* e.g. charging 75% */
                                snprintf(last_battery_str[idx],
-                                       sizeof(last_battery_str[idx]) - 1, "charging %i%%",
-                                       (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
+                                               sizeof(last_battery_str[idx]) - 1, "charging %i%%",
+                                               (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
                                /* e.g. 2h 37m */
                                format_seconds(last_battery_time_str[idx],
-                                       sizeof(last_battery_time_str[idx]) - 1,
-                                       (long) (((acpi_last_full[idx] - remaining_capacity) *
-                                       3600) / present_rate));
+                                               sizeof(last_battery_time_str[idx]) - 1,
+                                               (long) (((acpi_last_full[idx] - remaining_capacity) *
+                                                               3600) / present_rate));
                        } else if (acpi_last_full[idx] != 0 && present_rate <= 0) {
                                snprintf(last_battery_str[idx],
-                                       sizeof(last_battery_str[idx]) - 1, "charging %d%%",
-                                       (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
+                                               sizeof(last_battery_str[idx]) - 1, "charging %d%%",
+                                               (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
+                               snprintf(last_battery_time_str[idx],
+                                               sizeof(last_battery_time_str[idx]) - 1, "unknown");
                        } else {
                                strncpy(last_battery_str[idx], "charging",
-                                       sizeof(last_battery_str[idx]) - 1);
+                                               sizeof(last_battery_str[idx]) - 1);
+                               snprintf(last_battery_time_str[idx],
+                                               sizeof(last_battery_time_str[idx]) - 1, "unknown");
                        }
-               /* discharging */
+                       /* discharging */
                } else if (strncmp(charging_state, "discharging", 64) == 0) {
                        if (present_rate > 0) {
                                /* e.g. discharging 35% */
                                snprintf(last_battery_str[idx],
-                                       sizeof(last_battery_str[idx]) - 1, "discharging %i%%",
-                                       (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
+                                               sizeof(last_battery_str[idx]) - 1, "discharging %i%%",
+                                               (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
                                /* e.g. 1h 12m */
                                format_seconds(last_battery_time_str[idx],
-                                       sizeof(last_battery_time_str[idx]) - 1,
-                                       (long) ((remaining_capacity * 3600) / present_rate));
+                                               sizeof(last_battery_time_str[idx]) - 1,
+                                               (long) ((remaining_capacity * 3600) / present_rate));
                        } else if (present_rate == 0) { /* Thanks to Nexox for this one */
                                snprintf(last_battery_str[idx],
-                                       sizeof(last_battery_str[idx]) - 1, "full");
+                                               sizeof(last_battery_str[idx]) - 1, "full");
+                               snprintf(last_battery_time_str[idx],
+                                               sizeof(last_battery_time_str[idx]) - 1, "unknown");
                        } else {
                                snprintf(last_battery_str[idx],
-                                       sizeof(last_battery_str[idx]) - 1, "discharging %d%%",
-                                       (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
+                                               sizeof(last_battery_str[idx]) - 1, "discharging %d%%",
+                                               (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
+                               snprintf(last_battery_time_str[idx],
+                                               sizeof(last_battery_time_str[idx]) - 1, "unknown");
                        }
-               /* charged */
+                       /* charged */
                } else if (strncmp(charging_state, "charged", 64) == 0) {
                        /* thanks to Lukas Zapletal <lzap@seznam.cz> */
                        /* Below happens with the second battery on my X40,
@@ -1729,12 +1743,14 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
                        } else {
                                strcpy(last_battery_str[idx], "charged");
                        }
-               /* unknown, probably full / AC */
+                       /* unknown, probably full / AC */
                } else {
-                       if (acpi_last_full[idx] != 0
+                       if (strncmp(charging_state, "Full", 64) == 0) {
+                               strncpy(last_battery_str[idx], "full", 64);
+                       } else if (acpi_last_full[idx] != 0
                                        && remaining_capacity != acpi_last_full[idx]) {
                                snprintf(last_battery_str[idx], 64, "unknown %d%%",
-                                       (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
+                                               (int) ((remaining_capacity * 100) / acpi_last_full[idx]));
                        } else {
                                strncpy(last_battery_str[idx], "AC", 64);
                        }
@@ -1746,7 +1762,8 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
                }
 
                if (apm_bat_fp[idx] != NULL) {
-                       int ac, status, flag, life;
+                       unsigned int ac, status, flag;
+                       int life;
 
                        fscanf(apm_bat_fp[idx], "%*s %*s %*x %x   %x       %x     %d%%",
                                &ac, &status, &flag, &life);
@@ -1768,28 +1785,44 @@ void get_battery_stuff(char *buf, unsigned int n, const char *bat, int item)
                        apm_bat_fp[idx] = NULL;
                }
        }
+       set_return_value(buffer, n, item, idx);
+}
 
-set_return_value:
+void set_return_value(char *buffer, unsigned int n, int item, int idx)
+{
        switch (item) {
                case BATTERY_STATUS:
-                       snprintf(buf, n, "%s", last_battery_str[idx]);
+                       snprintf(buffer, n, "%s", last_battery_str[idx]);
                        break;
                case BATTERY_TIME:
-                       snprintf(buf, n, "%s", last_battery_time_str[idx]);
+                       snprintf(buffer, n, "%s", last_battery_time_str[idx]);
                        break;
                default:
                        break;
        }
 }
 
+void get_battery_short_status(char *buffer, unsigned int n, const char *bat)
+{
+       get_battery_stuff(buffer, n, bat, BATTERY_STATUS);
+       if (0 == strncmp("charging", buffer, 8)) {
+               buffer[0] = 'C';
+               memmove(buffer + 1, buffer + 8, n - 8);
+       } else if (0 == strncmp("discharging", buffer, 11)) {
+               buffer[0] = 'D';
+               memmove(buffer + 1, buffer + 11, n - 11);
+       }
+}
+
 int get_battery_perct(const char *bat)
 {
-       static int rep;
+       static int rep = 0;
        int idx;
        char acpi_path[128];
+       char sysfs_path[128];
+       int remaining_capacity = -1;
 
        snprintf(acpi_path, 127, ACPI_BATTERY_BASE_PATH "/%s/state", bat);
-       char sysfs_path[128];
        snprintf(sysfs_path, 127, SYSFS_BATTERY_BASE_PATH "/%s/uevent", bat);
 
        init_batteries();
@@ -1804,13 +1837,14 @@ int get_battery_perct(const char *bat)
 
        /* Only check for SYSFS or ACPI */
 
-       if (sysfs_bat_fp[idx] == NULL && acpi_bat_fp[idx] == NULL && apm_bat_fp[idx] == NULL)
+       if (sysfs_bat_fp[idx] == NULL && acpi_bat_fp[idx] == NULL && apm_bat_fp[idx] == NULL) {
                sysfs_bat_fp[idx] = open_file(sysfs_path, &rep);
+               rep = 0;
+       }
 
-       if (sysfs_bat_fp[idx] == NULL && acpi_bat_fp[idx] == NULL && apm_bat_fp[idx] == NULL)
+       if (sysfs_bat_fp[idx] == NULL && acpi_bat_fp[idx] == NULL && apm_bat_fp[idx] == NULL) {
                acpi_bat_fp[idx] = open_file(acpi_path, &rep);
-
-       int remaining_capacity = -1;
+       }
 
        if (sysfs_bat_fp[idx] != NULL) {
                /* SYSFS */
@@ -1819,14 +1853,15 @@ int get_battery_perct(const char *bat)
                        if (fgets(buf, 256, sysfs_bat_fp[idx]) == NULL)
                                break;
 
-                       if (strncmp(buf, "POWER_SUPPLY_CHARGE_NOW=", 24) == 0)
+                       if (strncmp(buf, "POWER_SUPPLY_CHARGE_NOW=", 24) == 0) {
                                sscanf(buf, "POWER_SUPPLY_CHARGE_NOW=%d", &remaining_capacity);
-                       else if (strncmp(buf, "POWER_SUPPLY_CHARGE_FULL=",25) != 0)
-                               sscanf(buf, "POWER_SUPPLY_CHARGE_FULL=%d", &acpi_last_full[idx]);
-                       else if (strncmp(buf, "POWER_SUPPLY_ENERGY_NOW=", 24) == 0)
+                       } else if (strncmp(buf, "POWER_SUPPLY_CHARGE_FULL=",25) == 0) {
+                               sscanf(buf, "POWER_SUPPLY_CHARGE_FULL=%d", &acpi_design_capacity[idx]);
+                       } else if (strncmp(buf, "POWER_SUPPLY_ENERGY_NOW=", 24) == 0) {
                                sscanf(buf, "POWER_SUPPLY_ENERGY_NOW=%d", &remaining_capacity);
-                       else if (strncmp(buf, "POWER_SUPPLY_ENERGY_FULL=",25) != 0)
-                               sscanf(buf, "POWER_SUPPLY_ENERGY_FULL=%d", &acpi_last_full[idx]);
+                       } else if (strncmp(buf, "POWER_SUPPLY_ENERGY_FULL=",25) == 0) {
+                               sscanf(buf, "POWER_SUPPLY_ENERGY_FULL=%d", &acpi_design_capacity[idx]);
+                       }
                }
 
                fclose(sysfs_bat_fp[idx]);
@@ -1836,12 +1871,12 @@ int get_battery_perct(const char *bat)
                /* ACPI */
                /* read last full capacity if it's zero */
                if (acpi_design_capacity[idx] == 0) {
-                       static int rep;
+                       static int rep2;
                        char path[128];
                        FILE *fp;
 
                        snprintf(path, 127, ACPI_BATTERY_BASE_PATH "/%s/info", bat);
-                       fp = open_file(path, &rep);
+                       fp = open_file(path, &rep2);
                        if (fp != NULL) {
                                while (!feof(fp)) {
                                        char b[256];
@@ -1878,6 +1913,7 @@ int get_battery_perct(const char *bat)
        /* compute the battery percentage */
        last_battery_perct[idx] =
                (int) (((float) remaining_capacity / acpi_design_capacity[idx]) * 100);
+       if (last_battery_perct[idx] > 100) last_battery_perct[idx] = 100;
        return last_battery_perct[idx];
 }
 
@@ -1915,23 +1951,27 @@ static char pb_battery_info[3][32];
 static double pb_battery_info_update;
 
 #define PMU_PATH "/proc/pmu"
-void get_powerbook_batt_info(char *buf, size_t n, int i)
+void get_powerbook_batt_info(char *buffer, size_t n, int i)
 {
        static int rep = 0;
        const char *batt_path = PMU_PATH "/battery_0";
        const char *info_path = PMU_PATH "/info";
-       int flags, charge, max_charge, ac = -1;
-       long time = -1;
+       unsigned int flags;
+       int charge, max_charge, ac = -1;
+       long timeval = -1;
 
        /* don't update battery too often */
        if (current_update_time - pb_battery_info_update < 29.5) {
-               snprintf(buf, n, "%s", pb_battery_info[i]);
+               snprintf(buffer, n, "%s", pb_battery_info[i]);
                return;
        }
        pb_battery_info_update = current_update_time;
 
        if (pmu_battery_fp == NULL) {
                pmu_battery_fp = open_file(batt_path, &rep);
+               if (pmu_battery_fp == NULL) {
+                       return;
+               }
        }
 
        if (pmu_battery_fp != NULL) {
@@ -1950,12 +1990,15 @@ void get_powerbook_batt_info(char *buf, size_t n, int i)
                        } else if (buf[0] == 'm') {
                                sscanf(buf, "max_charge : %d", &max_charge);
                        } else if (buf[0] == 't') {
-                               sscanf(buf, "time rem.  : %ld", &time);
+                               sscanf(buf, "time rem.  : %ld", &timeval);
                        }
                }
        }
        if (pmu_info_fp == NULL) {
                pmu_info_fp = open_file(info_path, &rep);
+               if (pmu_info_fp == NULL) {
+                       return;
+               }
        }
 
        if (pmu_info_fp != NULL) {
@@ -1973,19 +2016,24 @@ void get_powerbook_batt_info(char *buf, size_t n, int i)
        }
        /* update status string */
        if ((ac && !(flags & PMU_BATT_PRESENT))) {
-               strcpy(pb_battery_info[PB_BATT_STATUS], "AC");
+               strncpy(pb_battery_info[PB_BATT_STATUS], "AC", sizeof(pb_battery_info[PB_BATT_STATUS]));
        } else if (ac && (flags & PMU_BATT_PRESENT)
                        && !(flags & PMU_BATT_CHARGING)) {
-               strcpy(pb_battery_info[PB_BATT_STATUS], "charged");
+               strncpy(pb_battery_info[PB_BATT_STATUS], "charged", sizeof(pb_battery_info[PB_BATT_STATUS]));
        } else if ((flags & PMU_BATT_PRESENT) && (flags & PMU_BATT_CHARGING)) {
-               strcpy(pb_battery_info[PB_BATT_STATUS], "charging");
+               strncpy(pb_battery_info[PB_BATT_STATUS], "charging", sizeof(pb_battery_info[PB_BATT_STATUS]));
        } else {
-               strcpy(pb_battery_info[PB_BATT_STATUS], "discharging");
+               strncpy(pb_battery_info[PB_BATT_STATUS], "discharging", sizeof(pb_battery_info[PB_BATT_STATUS]));
        }
 
        /* update percentage string */
-       if (time == 0) {
-               pb_battery_info[PB_BATT_PERCENT][0] = 0;
+       if (timeval == 0 && ac && (flags & PMU_BATT_PRESENT)
+                       && !(flags & PMU_BATT_CHARGING)) {
+               snprintf(pb_battery_info[PB_BATT_PERCENT],
+                       sizeof(pb_battery_info[PB_BATT_PERCENT]), "100%%");
+       } else if (timeval == 0) {
+               snprintf(pb_battery_info[PB_BATT_PERCENT],
+                       sizeof(pb_battery_info[PB_BATT_PERCENT]), "unknown");
        } else {
                snprintf(pb_battery_info[PB_BATT_PERCENT],
                        sizeof(pb_battery_info[PB_BATT_PERCENT]), "%d%%",
@@ -1993,370 +2041,27 @@ void get_powerbook_batt_info(char *buf, size_t n, int i)
        }
 
        /* update time string */
-       if (time == 0) {                        /* fully charged or battery not present */
-               pb_battery_info[PB_BATT_TIME][0] = 0;
-       } else if (time < 60 * 60) {    /* don't show secs */
+       if (timeval == 0) {                     /* fully charged or battery not present */
+               snprintf(pb_battery_info[PB_BATT_TIME],
+                       sizeof(pb_battery_info[PB_BATT_TIME]), "unknown");
+       } else if (timeval < 60 * 60) { /* don't show secs */
                format_seconds_short(pb_battery_info[PB_BATT_TIME],
-                       sizeof(pb_battery_info[PB_BATT_TIME]), time);
+                       sizeof(pb_battery_info[PB_BATT_TIME]), timeval);
        } else {
                format_seconds(pb_battery_info[PB_BATT_TIME],
-                       sizeof(pb_battery_info[PB_BATT_TIME]), time);
+                       sizeof(pb_battery_info[PB_BATT_TIME]), timeval);
        }
 
-       snprintf(buf, n, "%s", pb_battery_info[i]);
+       snprintf(buffer, n, "%s", pb_battery_info[i]);
 }
 
-void update_top()
+void update_top(void)
 {
        show_nice_processes = 1;
-       process_find_top(info.cpu, info.memu);
+       process_find_top(info.cpu, info.memu, info.time);
        info.first_process = get_first_process();
 }
 
-/* The following ifdefs were adapted from gkrellm */
-#include <linux/major.h>
-
-#if !defined(MD_MAJOR)
-#define MD_MAJOR 9
-#endif
-
-#if !defined(LVM_BLK_MAJOR)
-#define LVM_BLK_MAJOR 58
-#endif
-
-#if !defined(NBD_MAJOR)
-#define NBD_MAJOR 43
-#endif
-
-void update_diskio()
-{
-       static unsigned int last = UINT_MAX;
-       static unsigned int last_read = UINT_MAX;
-       static unsigned int last_write = UINT_MAX;
-       FILE *fp;
-       static int rep = 0;
-
-       char buf[512], devbuf[64];
-       int major, minor, i;
-       unsigned int current = 0;
-       unsigned int current_read = 0;
-       unsigned int current_write = 0;
-       unsigned int reads, writes = 0;
-       int col_count = 0;
-
-       if (!(fp = open_file("/proc/diskstats", &rep))) {
-               diskio_value = 0;
-               return;
-       }
-
-       /* read reads and writes from all disks (minor = 0), including cd-roms
-        * and floppies, and sum them up */
-       while (!feof(fp)) {
-               fgets(buf, 512, fp);
-               col_count = sscanf(buf, "%u %u %s %*u %*u %u %*u %*u %*u %u", &major,
-                       &minor, devbuf, &reads, &writes);
-               /* ignore subdevices (they have only 3 matching entries in their line)
-                * and virtual devices (LVM, network block devices, RAM disks, Loopback)
-                *
-                * XXX: ignore devices which are part of a SW RAID (MD_MAJOR) */
-               if (col_count == 5 && major != LVM_BLK_MAJOR && major != NBD_MAJOR
-                               && major != RAMDISK_MAJOR && major != LOOP_MAJOR) {
-                       current += reads + writes;
-                       current_read += reads;
-                       current_write += writes;
-               } else {
-                       col_count = sscanf(buf, "%u %u %s %*u %u %*u %u",
-                               &major, &minor, devbuf, &reads, &writes);
-                       if (col_count != 5) {
-                               continue;
-                       }
-               }
-               for (i = 0; i < MAX_DISKIO_STATS; i++) {
-                       if (diskio_stats[i].dev &&
-                                       strcmp(devbuf, diskio_stats[i].dev) == 0) {
-                               diskio_stats[i].current =
-                                       (reads + writes - diskio_stats[i].last) / 2;
-                               diskio_stats[i].current_read =
-                                       (reads - diskio_stats[i].last_read) / 2;
-                               diskio_stats[i].current_write =
-                                       (writes - diskio_stats[i].last_write) / 2;
-                               if (reads + writes < diskio_stats[i].last) {
-                                       diskio_stats[i].current = 0;
-                               }
-                               if (reads < diskio_stats[i].last_read) {
-                                       diskio_stats[i].current_read = 0;
-                                       diskio_stats[i].current = diskio_stats[i].current_write;
-                               }
-                               if (writes < diskio_stats[i].last_write) {
-                                       diskio_stats[i].current_write = 0;
-                                       diskio_stats[i].current = diskio_stats[i].current_read;
-                               }
-                               diskio_stats[i].last = reads + writes;
-                               diskio_stats[i].last_read = reads;
-                               diskio_stats[i].last_write = writes;
-                       }
-               }
-       }
-
-       /* since the values in /proc/diststats are absolute, we have to substract
-        * our last reading. The numbers stand for "sectors read", and we therefore
-        * have to divide by two to get KB */
-       int tot = ((double) (current - last) / 2);
-       int tot_read = ((double) (current_read - last_read) / 2);
-       int tot_write = ((double) (current_write - last_write) / 2);
-
-       if (last_read > current_read) {
-               tot_read = 0;
-       }
-       if (last_write > current_write) {
-               tot_write = 0;
-       }
-
-       if (last > current) {
-               /* we hit this either if it's the very first time we run this, or
-                * when /proc/diskstats overflows; while 0 is not correct, it's at
-                * least not way off */
-               tot = 0;
-       }
-       last = current;
-       last_read = current_read;
-       last_write = current_write;
-
-       diskio_value = tot;
-       diskio_read_value = tot_read;
-       diskio_write_value = tot_write;
-
-       fclose(fp);
-}
-
-/* Here come the IBM ACPI-specific things. For reference, see
- * http://ibm-acpi.sourceforge.net/README
- * If IBM ACPI is installed, /proc/acpi/ibm contains the following files:
-bay
-beep
-bluetooth
-brightness
-cmos
-dock
-driver
-ecdump
-fan
-hotkey
-led
-light
-thermal
-video
-volume
- * The content of these files is described in detail in the aforementioned
- * README - some of them also in the following functions accessing them.
- * Peter Tarjan (ptarjan@citromail.hu) */
-
-#define IBM_ACPI_DIR "/proc/acpi/ibm"
-
-/* get fan speed on IBM/Lenovo laptops running the ibm acpi.
- * /proc/acpi/ibm/fan looks like this (3 lines):
-status:         disabled
-speed:          2944
-commands:       enable, disable
- * Peter Tarjan (ptarjan@citromail.hu) */
-
-void get_ibm_acpi_fan(char *p_client_buffer, size_t client_buffer_size)
-{
-       if (!p_client_buffer || client_buffer_size <= 0) {
-               return;
-       }
-
-       FILE *fp;
-       unsigned int speed = 0;
-       char fan[128];
-
-       snprintf(fan, 127, "%s/fan", IBM_ACPI_DIR);
-
-       fp = fopen(fan, "r");
-       if (fp != NULL) {
-               while (!feof(fp)) {
-                       char line[256];
-
-                       if (fgets(line, 255, fp) == NULL) {
-                               break;
-                       }
-                       if (sscanf(line, "speed: %d", &speed)) {
-                               break;
-                       }
-               }
-       } else {
-               CRIT_ERR("can't open '%s': %s\nYou are not using the IBM ACPI. Remove "
-                       "ibm* from your Conky config file.", fan, strerror(errno));
-       }
-
-       fclose(fp);
-       snprintf(p_client_buffer, client_buffer_size, "%d", speed);
-}
-
-/* get the measured temperatures from the temperature sensors
- * on IBM/Lenovo laptops running the ibm acpi.
- * There are 8 values in /proc/acpi/ibm/thermal, and according to
- * http://ibm-acpi.sourceforge.net/README
- * these mean the following (at least on an IBM R51...)
- * 0:  CPU (also on the T series laptops)
- * 1:  Mini PCI Module (?)
- * 2:  HDD (?)
- * 3:  GPU (also on the T series laptops)
- * 4:  Battery (?)
- * 5:  N/A
- * 6:  Battery (?)
- * 7:  N/A
- * I'm not too sure about those with the question mark, but the values I'm
- * reading from *my* thermal file (on a T42p) look realistic for the
- * hdd and the battery.
- * #5 and #7 are always -128.
- * /proc/acpi/ibm/thermal looks like this (1 line):
-temperatures:   41 43 31 46 33 -128 29 -128
- * Peter Tarjan (ptarjan@citromail.hu) */
-
-static double last_ibm_acpi_temp_time;
-void get_ibm_acpi_temps()
-{
-
-       /* don't update too often */
-       if (current_update_time - last_ibm_acpi_temp_time < 10.00) {
-               return;
-       }
-       last_ibm_acpi_temp_time = current_update_time;
-
-       /* if (!p_client_buffer || client_buffer_size <= 0) {
-               return;
-       } */
-
-       FILE *fp;
-
-       char thermal[128];
-
-       snprintf(thermal, 127, "%s/thermal", IBM_ACPI_DIR);
-       fp = fopen(thermal, "r");
-
-       if (fp != NULL) {
-               while (!feof(fp)) {
-                       char line[256];
-
-                       if (fgets(line, 255, fp) == NULL) {
-                               break;
-                       }
-                       if (sscanf(line, "temperatures: %d %d %d %d %d %d %d %d",
-                                       &ibm_acpi.temps[0], &ibm_acpi.temps[1], &ibm_acpi.temps[2],
-                                       &ibm_acpi.temps[3], &ibm_acpi.temps[4], &ibm_acpi.temps[5],
-                                       &ibm_acpi.temps[6], &ibm_acpi.temps[7])) {
-                               break;
-                       }
-               }
-       } else {
-               CRIT_ERR("can't open '%s': %s\nYou are not using the IBM ACPI. Remove "
-                       "ibm* from your Conky config file.", thermal, strerror(errno));
-       }
-
-       fclose(fp);
-}
-
-/* get volume (0-14) on IBM/Lenovo laptops running the ibm acpi.
- * "Volume" here is none of the mixer volumes, but a "master of masters"
- * volume adjusted by the IBM volume keys.
- * /proc/acpi/ibm/fan looks like this (4 lines):
-level:          4
-mute:           off
-commands:       up, down, mute
-commands:       level <level> (<level> is 0-15)
- * Peter Tarjan (ptarjan@citromail.hu) */
-
-void get_ibm_acpi_volume(char *p_client_buffer, size_t client_buffer_size)
-{
-       if (!p_client_buffer || client_buffer_size <= 0) {
-               return;
-       }
-
-       FILE *fp;
-
-       char volume[128];
-
-       snprintf(volume, 127, "%s/volume", IBM_ACPI_DIR);
-       unsigned int vol = -1;
-       char mute[3] = "";
-
-       fp = fopen(volume, "r");
-       if (fp != NULL) {
-               while (!feof(fp)) {
-                       char line[256];
-                       unsigned int read_vol = -1;
-
-                       if (fgets(line, 255, fp) == NULL) {
-                               break;
-                       }
-                       if (sscanf(line, "level: %d", &read_vol)) {
-                               vol = read_vol;
-                               continue;
-                       }
-                       if (sscanf(line, "mute: %s", mute)) {
-                               break;
-                       }
-               }
-       } else {
-               CRIT_ERR("can't open '%s': %s\nYou are not using the IBM ACPI. Remove "
-                       "ibm* from your Conky config file.", volume, strerror(errno));
-       }
-
-       fclose(fp);
-
-       if (strcmp(mute, "on") == 0) {
-               snprintf(p_client_buffer, client_buffer_size, "%s", "mute");
-               return;
-       } else {
-               snprintf(p_client_buffer, client_buffer_size, "%d", vol);
-               return;
-       }
-}
-
-/* static FILE *fp = NULL; */
-
-/* get LCD brightness on IBM/Lenovo laptops running the ibm acpi.
- * /proc/acpi/ibm/brightness looks like this (3 lines):
-level:          7
-commands:       up, down
-commands:       level <level> (<level> is 0-7)
- * Peter Tarjan (ptarjan@citromail.hu) */
-
-void get_ibm_acpi_brightness(char *p_client_buffer, size_t client_buffer_size)
-{
-       if (!p_client_buffer || client_buffer_size <= 0) {
-               return;
-       }
-
-       FILE *fp;
-       unsigned int brightness = 0;
-       char filename[128];
-
-       snprintf(filename, 127, "%s/brightness", IBM_ACPI_DIR);
-
-       fp = fopen(filename, "r");
-       if (fp != NULL) {
-               while (!feof(fp)) {
-                       char line[256];
-
-                       if (fgets(line, 255, fp) == NULL) {
-                               break;
-                       }
-                       if (sscanf(line, "level: %d", &brightness)) {
-                               break;
-                       }
-               }
-       } else {
-               CRIT_ERR("can't open '%s': %s\nYou are not using the IBM ACPI. Remove "
-                       "ibm* from your Conky config file.", filename, strerror(errno));
-       }
-
-       fclose(fp);
-
-       snprintf(p_client_buffer, client_buffer_size, "%d", brightness);
-}
-
 void update_entropy(void)
 {
        static int rep = 0;
@@ -2384,3 +2089,24 @@ void update_entropy(void)
 
        info.mask |= (1 << INFO_ENTROPY);
 }
+
+const char *get_disk_protect_queue(const char *disk)
+{
+       FILE *fp;
+       char path[128];
+       int state;
+
+       snprintf(path, 127, "/sys/block/%s/device/unload_heads", disk);
+       if (access(path, F_OK)) {
+               snprintf(path, 127, "/sys/block/%s/queue/protect", disk);
+       }
+       if ((fp = fopen(path, "r")) == NULL)
+               return "n/a   ";
+       if (fscanf(fp, "%d\n", &state) != 1) {
+               fclose(fp);
+               return "failed";
+       }
+       fclose(fp);
+       return (state > 0) ? "frozen" : "free  ";
+}
+