* Fix some detected memory leaks
[modest] / src / maemo / easysetup / modest-easysetup-wizard.c
index 8c29837..0433321 100644 (file)
@@ -14,7 +14,7 @@
 #include <gtk/gtkbutton.h>
 #include <gtk/gtkcheckbutton.h>
 #include <gtk/gtkmessagedialog.h>
-#include <hildon-widgets/hildon-caption.h>
+#include <gtk/gtkseparator.h>
 #include "maemo/easysetup/modest-easysetup-country-combo-box.h"
 #include "maemo/easysetup/modest-easysetup-provider-combo-box.h"
 #include "maemo/easysetup/modest-easysetup-servertype-combo-box.h"
@@ -26,6 +26,8 @@
 #include "modest-account-mgr-helpers.h"
 #include "modest-runtime.h" /* For modest_runtime_get_account_mgr(). */
 #include "maemo/modest-connection-specific-smtp-window.h"
+#include "maemo/modest-maemo-ui-constants.h"
+#include "maemo/modest-account-settings-dialog.h"
 #include <gconf/gconf-client.h>
 #include <string.h> /* For strlen(). */
 
@@ -89,6 +91,8 @@ modest_easysetup_wizard_dialog_finalize (GObject *object)
                
        if (self->specific_window)
                gtk_widget_destroy (self->specific_window);
+               
+       g_free (self->saved_account_name);
        
        G_OBJECT_CLASS (modest_easysetup_wizard_dialog_parent_class)->finalize (object);
 }
@@ -97,7 +101,7 @@ static void
 show_error (GtkWindow *parent_window, const gchar* text);
 
 static gboolean
-create_account (ModestEasysetupWizardDialog *self);
+create_account (ModestEasysetupWizardDialog *self, gboolean enabled);
 
 static void
 create_subsequent_easysetup_pages (ModestEasysetupWizardDialog *self);
@@ -188,7 +192,7 @@ static GtkWidget* create_caption_new_with_asterix(ModestEasysetupWizardDialog *s
 static GtkWidget*
 create_page_welcome (ModestEasysetupWizardDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, 2);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        GtkWidget *label = gtk_label_new(_("mcen_ia_emailsetup_intro"));
        gtk_box_pack_start (GTK_BOX (box), label, FALSE, FALSE, 0);
        gtk_widget_show (label);
@@ -236,13 +240,19 @@ on_combo_account_serviceprovider (GtkComboBox *widget, gpointer user_data)
        g_free (provider_id);
 }
 
+static void
+on_entry_max (ModestValidatingEntry *self, gpointer user_data)
+{
+       ModestEasysetupWizardDialog *dialog = MODEST_EASYSETUP_WIZARD_DIALOG (user_data);
+       show_error (GTK_WINDOW (dialog), _("ckdg_ib_maximum_characters_reached"));
+}
 
 static GtkWidget*
 create_page_account_details (ModestEasysetupWizardDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, 2);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        GtkWidget *label = gtk_label_new(_("mcen_ia_accountdetails"));
-       gtk_box_pack_start (GTK_BOX (box), label, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), label, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (label);
        
        /* Create a size group to be used by all captions.
@@ -255,21 +265,24 @@ create_page_account_details (ModestEasysetupWizardDialog *self)
        GtkWidget *caption = create_caption_new_with_asterix (self, sizegroup, _("mcen_fi_country"), 
                self->combo_account_country, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->combo_account_country);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* connect to country combo's changed signal, so we can fill the provider combo: */
     g_signal_connect (G_OBJECT (self->combo_account_country), "changed",
             G_CALLBACK (on_combo_account_country), self);
             
-       
+       GtkWidget *separator = gtk_hseparator_new ();
+       gtk_box_pack_start (GTK_BOX (box), separator, FALSE, FALSE, MODEST_MARGIN_HALF);
+       gtk_widget_show (separator);
+            
        /* The service provider widgets: */     
        self->combo_account_serviceprovider = GTK_WIDGET (easysetup_provider_combo_box_new ());
        
        caption = create_caption_new_with_asterix (self, sizegroup, _("mcen_fi_serviceprovider"), 
                self->combo_account_serviceprovider, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->combo_account_serviceprovider);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* connect to providers combo's changed signal, so we can fill the email address: */
@@ -315,7 +328,10 @@ create_page_account_details (ModestEasysetupWizardDialog *self)
                
        
        /* The description widgets: */  
-       self->entry_account_title = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_account_title = GTK_WIDGET (modest_validating_entry_new ());
+       /* Do use auto-capitalization: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_account_title), 
+               HILDON_GTK_INPUT_MODE_FULL | HILDON_GTK_INPUT_MODE_AUTOCAP);
        
        /* Set a default account title, choosing one that does not already exist: */
        /* Note that this is irrelevant to the non-user visible name, which we will create later. */
@@ -332,7 +348,7 @@ create_page_account_details (ModestEasysetupWizardDialog *self)
        caption = create_caption_new_with_asterix (self, sizegroup, _("mcen_fi_account_title"), 
                self->entry_account_title, NULL, HILDON_CAPTION_MANDATORY);
        gtk_widget_show (self->entry_account_title);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* Prevent the use of some characters in the account title, 
@@ -349,13 +365,15 @@ create_page_account_details (ModestEasysetupWizardDialog *self)
        list_prevent = g_list_append (list_prevent, ">"); 
        list_prevent = g_list_append (list_prevent, "|");
        list_prevent = g_list_append (list_prevent, "^");       
-       easysetup_validating_entry_set_unallowed_characters (
-               EASYSETUP_VALIDATING_ENTRY (self->entry_account_title), list_prevent);
+       modest_validating_entry_set_unallowed_characters (
+               MODEST_VALIDATING_ENTRY (self->entry_account_title), list_prevent);
        g_list_free (list_prevent);
        
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_account_title), 64);
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_account_title), 
+               on_entry_max, self);
        
        gtk_widget_show (GTK_WIDGET (box));
        
@@ -365,7 +383,7 @@ create_page_account_details (ModestEasysetupWizardDialog *self)
 static GtkWidget*
 create_page_user_details (ModestEasysetupWizardDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, 2);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        
        /* Create a size group to be used by all captions.
         * Note that HildonCaption does not create a default size group if we do not specify one.
@@ -373,14 +391,18 @@ create_page_user_details (ModestEasysetupWizardDialog *self)
        GtkSizeGroup* sizegroup = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
         
        /* The name widgets: */
-       self->entry_user_name = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_user_name = GTK_WIDGET (modest_validating_entry_new ());
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_user_name), HILDON_GTK_INPUT_MODE_FULL);
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_user_name), 64);
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_user_name), 
+               on_entry_max, self);
        GtkWidget *caption = create_caption_new_with_asterix (self, sizegroup, 
                _("mcen_li_emailsetup_name"), self->entry_user_name, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->entry_user_name);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* Prevent the use of some characters in the name, 
@@ -388,49 +410,59 @@ create_page_user_details (ModestEasysetupWizardDialog *self)
        GList *list_prevent = NULL;
        list_prevent = g_list_append (list_prevent, "<");
        list_prevent = g_list_append (list_prevent, ">");
-       easysetup_validating_entry_set_unallowed_characters (
-               EASYSETUP_VALIDATING_ENTRY (self->entry_user_name), list_prevent);
+       modest_validating_entry_set_unallowed_characters (
+               MODEST_VALIDATING_ENTRY (self->entry_user_name), list_prevent);
        g_list_free (list_prevent);
        
        /* The username widgets: */     
-       self->entry_user_username = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_user_username = GTK_WIDGET (modest_validating_entry_new ());
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_user_username), HILDON_GTK_INPUT_MODE_FULL);
        caption = create_caption_new_with_asterix (self, sizegroup, _("mail_fi_username"), 
                self->entry_user_username, NULL, HILDON_CAPTION_MANDATORY);
        gtk_widget_show (self->entry_user_username);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* Prevent the use of some characters in the username, 
         * as required by our UI specification: */
-       easysetup_validating_entry_set_unallowed_characters_whitespace (
-               EASYSETUP_VALIDATING_ENTRY (self->entry_user_username));
+       modest_validating_entry_set_unallowed_characters_whitespace (
+               MODEST_VALIDATING_ENTRY (self->entry_user_username));
        
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_user_username), 64);
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_user_username), 
+               on_entry_max, self);
        
        /* The password widgets: */     
        self->entry_user_password = gtk_entry_new ();
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_user_password), HILDON_GTK_INPUT_MODE_FULL);
        gtk_entry_set_visibility (GTK_ENTRY (self->entry_user_password), FALSE);
        /* gtk_entry_set_invisible_char (GTK_ENTRY (self->entry_user_password), '*'); */
        caption = create_caption_new_with_asterix (self, sizegroup, 
                _("mail_fi_password"), self->entry_user_password, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->entry_user_password);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* The email address widgets: */        
-       self->entry_user_email = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_user_email = GTK_WIDGET (modest_validating_entry_new ());
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_user_email), HILDON_GTK_INPUT_MODE_FULL);
        caption = create_caption_new_with_asterix (self, sizegroup, 
                _("mcen_li_emailsetup_email_address"), self->entry_user_email, NULL, HILDON_CAPTION_MANDATORY);
        gtk_entry_set_text (GTK_ENTRY (self->entry_user_email), EXAMPLE_EMAIL_ADDRESS); /* Default text. */
        gtk_widget_show (self->entry_user_email);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_user_email), 64);
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_user_email), 
+               on_entry_max, self);
        
        
        gtk_widget_show (GTK_WIDGET (box));
@@ -440,7 +472,7 @@ create_page_user_details (ModestEasysetupWizardDialog *self)
 
 static GtkWidget* create_page_complete_easysetup (ModestEasysetupWizardDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, 2);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        GtkWidget *label = gtk_label_new(_("mcen_ia_emailsetup_setup_complete"));
        gtk_box_pack_start (GTK_BOX (box), label, FALSE, FALSE, 0);
        gtk_widget_show (label);
@@ -492,7 +524,7 @@ static void on_combo_servertype_changed(GtkComboBox *combobox, gpointer user_dat
            
 static GtkWidget* create_page_custom_incoming (ModestEasysetupWizardDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, 2);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        
        /* Create a size group to be used by all captions.
         * Note that HildonCaption does not create a default size group if we do not specify one.
@@ -507,11 +539,13 @@ static GtkWidget* create_page_custom_incoming (ModestEasysetupWizardDialog *self
        GtkWidget *caption = create_caption_new_with_asterix (self, sizegroup, 
                _("mcen_li_emailsetup_type"), self->combo_incoming_servertype, NULL, HILDON_CAPTION_MANDATORY);
        gtk_widget_show (self->combo_incoming_servertype);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        if(!self->entry_incomingserver)
                self->entry_incomingserver = gtk_entry_new ();
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_incomingserver), HILDON_GTK_INPUT_MODE_FULL);
        set_default_custom_servernames (self);
 
        if (self->caption_incoming)
@@ -524,7 +558,7 @@ static GtkWidget* create_page_custom_incoming (ModestEasysetupWizardDialog *self
                "Incoming Server", self->entry_incomingserver, NULL, HILDON_CAPTION_MANDATORY);
        update_incoming_server_title (self);
        gtk_widget_show (self->entry_incomingserver);
-       gtk_box_pack_start (GTK_BOX (box), self->caption_incoming, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), self->caption_incoming, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (self->caption_incoming);
        
        /* Change the caption title when the servertype changes, 
@@ -541,14 +575,16 @@ static GtkWidget* create_page_custom_incoming (ModestEasysetupWizardDialog *self
        caption = hildon_caption_new (sizegroup, _("mcen_li_emailsetup_secure_connection"), 
                self->combo_incoming_security, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->combo_incoming_security);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        if(!self->checkbox_incoming_auth)
-               self->checkbox_incoming_auth = 
-                       gtk_check_button_new_with_label (_("mcen_li_emailsetup_secure_authentication"));
-       gtk_box_pack_start (GTK_BOX (box), self->checkbox_incoming_auth, FALSE, FALSE, 2);
+               self->checkbox_incoming_auth = gtk_check_button_new ();
+       caption = hildon_caption_new (sizegroup, _("mcen_li_emailsetup_secure_authentication"), 
+               self->checkbox_incoming_auth, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->checkbox_incoming_auth);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
+       gtk_widget_show (caption);
        
        gtk_widget_show (GTK_WIDGET (box));
        
@@ -597,7 +633,7 @@ on_button_outgoing_smtp_servers (GtkButton *button, gpointer user_data)
 
 static GtkWidget* create_page_custom_outgoing (ModestEasysetupWizardDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, 2);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        
        /* Create a size group to be used by all captions.
         * Note that HildonCaption does not create a default size group if we do not specify one.
@@ -607,10 +643,12 @@ static GtkWidget* create_page_custom_outgoing (ModestEasysetupWizardDialog *self
        /* The outgoing server widgets: */
        if (!self->entry_outgoingserver)
                self->entry_outgoingserver = gtk_entry_new ();
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_outgoingserver), HILDON_GTK_INPUT_MODE_FULL);
        GtkWidget *caption = create_caption_new_with_asterix (self, sizegroup, 
                _("mcen_li_emailsetup_smtp"), self->entry_outgoingserver, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->entry_outgoingserver);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        set_default_custom_servernames (self);
        
@@ -624,7 +662,7 @@ static GtkWidget* create_page_custom_outgoing (ModestEasysetupWizardDialog *self
        caption = hildon_caption_new (sizegroup, _("mcen_li_emailsetup_secure_connection"), 
                self->combo_outgoing_security, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->combo_outgoing_security);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* The secure authentication widgets: */
@@ -633,25 +671,33 @@ static GtkWidget* create_page_custom_outgoing (ModestEasysetupWizardDialog *self
        caption = hildon_caption_new (sizegroup, _("mcen_li_emailsetup_secure_authentication"), 
                self->combo_outgoing_auth, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->combo_outgoing_auth);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
+       GtkWidget *separator = gtk_hseparator_new ();
+       gtk_box_pack_start (GTK_BOX (box), separator, FALSE, FALSE, MODEST_MARGIN_HALF);
+       gtk_widget_show (separator);
+       
        /* connection-specific checkbox: */
        if (!self->checkbox_outgoing_smtp_specific) {
-               self->checkbox_outgoing_smtp_specific = gtk_check_button_new_with_label (_("mcen_fi_advsetup_connection_smtp"));
+               self->checkbox_outgoing_smtp_specific = gtk_check_button_new ();
                gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (self->checkbox_outgoing_smtp_specific), 
                        FALSE);
        }
-       gtk_box_pack_start (GTK_BOX (box), self->checkbox_outgoing_smtp_specific, FALSE, FALSE, 2);
+       caption = hildon_caption_new (sizegroup, _("mcen_fi_advsetup_connection_smtp"), 
+               self->checkbox_outgoing_smtp_specific, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->checkbox_outgoing_smtp_specific);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
+       gtk_widget_show (caption);
        
        /* Connection-specific SMTP-Severs Edit button: */
        if (!self->button_outgoing_smtp_servers)
-               self->button_outgoing_smtp_servers = gtk_button_new_with_label (_("mcen_bd_emailsetup_edit"));
+               self->button_outgoing_smtp_servers = gtk_button_new_with_label (_("mcen_bd_edit"));
        caption = hildon_caption_new (sizegroup, _("mcen_fi_advsetup_optional_smtp"), 
                self->button_outgoing_smtp_servers, NULL, HILDON_CAPTION_OPTIONAL);
+       hildon_caption_set_child_expand (HILDON_CAPTION (caption), FALSE);
        gtk_widget_show (self->button_outgoing_smtp_servers);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
        /* Only enable the button when the checkbox is checked: */
@@ -667,21 +713,92 @@ static GtkWidget* create_page_custom_outgoing (ModestEasysetupWizardDialog *self
        return GTK_WIDGET (box);
 }
 
+static gboolean
+on_timeout_show_advanced_edit(gpointer user_data)
+{
+       ModestEasysetupWizardDialog * self = MODEST_EASYSETUP_WIZARD_DIALOG (user_data);
+       
+       if (!(self->saved_account_name))
+               return FALSE;
+       
+       /* Show the Account Settings window: */
+       ModestAccountSettingsDialog *dialog = modest_account_settings_dialog_new ();
+       modest_account_settings_dialog_set_account_name (dialog, self->saved_account_name);
+       
+       gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (self));
+       
+       gtk_dialog_run (GTK_DIALOG (dialog));
+
+       /* TODO: The hide() is not necessary.
+        * It is just here to show that it doesn't work,
+        * just as destroy doesn't work.
+        */
+       gtk_widget_hide (GTK_WIDGET(dialog));
+
+       /* TODO: The dialog remains on screen, not allowing any interaction.
+        * But gtk_widget_destroy() should always destroy.
+        */
+       printf("debug: destroying settings dialog\n");
+       gtk_widget_destroy (GTK_WIDGET (dialog));
+       printf("debug: after destroying settings dialog (doesn't seem to work).\n");
+       
+       return FALSE; /* Do not call this timeout callback again. */
+}
+
+static void
+on_button_edit_advanced_settings (GtkButton *button, gpointer user_data)
+{
+       ModestEasysetupWizardDialog * self = MODEST_EASYSETUP_WIZARD_DIALOG (user_data);
+       
+       /* Save the new account, so we can edit it with ModestAccountSettingsDialog, 
+        * without recoding it to use non-gconf information.
+        * This account will be deleted if Finish is never actually clicked. */
+
+       gboolean saved = TRUE;
+       gboolean was_already_saved = TRUE;
+       if (!(self->saved_account_name)) {
+               saved = create_account (self, FALSE);
+               was_already_saved = FALSE;
+       }
+               
+       if (!saved)
+               return;
+               
+       if (!(self->saved_account_name))
+               return;
+       
+       /* Show the Account Settings window: */
+       if (was_already_saved) {
+               /* Just show the dialog immediately: */
+               on_timeout_show_advanced_edit(self);
+       }
+       else
+       {
+               printf ("debug: waiting for gconf to update its local cache. "
+               "This is a hack to work around a maemo gconf bug in maemo bora.\n");
+       
+           g_timeout_add (5000, on_timeout_show_advanced_edit, self);
+       }
+}
 static GtkWidget* create_page_complete_custom (ModestEasysetupWizardDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, 2);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        GtkWidget *label = gtk_label_new(_("mcen_ia_emailsetup_setup_complete"));
        gtk_box_pack_start (GTK_BOX (box), label, FALSE, FALSE, 0);
        gtk_widget_show (label);
        
        if (!self->button_edit)
-               self->button_edit = gtk_button_new_with_label (_("mcen_bd_emailsetup_edit"));
+               self->button_edit = gtk_button_new_with_label (_("mcen_bd_edit"));
        GtkWidget *caption = hildon_caption_new (NULL, _("mcen_fi_advanced_settings"), 
                self->button_edit, NULL, HILDON_CAPTION_OPTIONAL);
+       hildon_caption_set_child_expand (HILDON_CAPTION (caption), FALSE);
        gtk_widget_show (self->button_edit);
-       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, 2);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (caption);
        
+       g_signal_connect (G_OBJECT (self->button_edit), "clicked", 
+               G_CALLBACK (on_button_edit_advanced_settings), self);
+       
        gtk_widget_show (GTK_WIDGET (box));
        return GTK_WIDGET (box);
 }
@@ -695,12 +812,23 @@ on_response (ModestWizardDialog *wizard_dialog,
        gpointer user_data)
 {
        ModestEasysetupWizardDialog *self = MODEST_EASYSETUP_WIZARD_DIALOG (wizard_dialog);
+       
+       if (response_id == GTK_RESPONSE_CANCEL) {
+               /* Remove any temporarily-saved account that will not actually be needed: */
+               if (self->saved_account_name) {
+                       modest_account_mgr_remove_account (self->account_manager,
+                                                                    self->saved_account_name, FALSE);
+               }       
+       }
+       
        invoke_enable_buttons_vfunc (self);
 }
 
 static void
 modest_easysetup_wizard_dialog_init (ModestEasysetupWizardDialog *self)
 {
+       gtk_container_set_border_width (GTK_CONTAINER (self), MODEST_MARGIN_HALF);
+       
        /* Create the notebook to be used by the ModestWizardDialog base class:
         * Each page of the notebook will be a page of the wizard: */
        GtkNotebook *notebook = GTK_NOTEBOOK (gtk_notebook_new());
@@ -918,6 +1046,9 @@ static void set_default_custom_servernames (ModestEasysetupWizardDialog *account
        /* Set a default domain for the server, based on the email address,
         * if no server name was already specified.
         */
+       if (!account_wizard->entry_outgoingserver)
+               return;
+               
        const gchar* outgoing_existing = gtk_entry_get_text (GTK_ENTRY (account_wizard->entry_outgoingserver));
        if ((!outgoing_existing || (strlen(outgoing_existing) == 0)) 
                && account_wizard->entry_user_email) {
@@ -991,7 +1122,14 @@ on_before_next (ModestWizardDialog *dialog, GtkWidget *current_page, GtkWidget *
         */
        if(!next_page) /* This is NULL when this is a click on Finish. */
        {
-               create_account (account_wizard);
+               if (account_wizard->saved_account_name) {
+                       /* Just enable the already-saved account (temporarily created when 
+                        * editing advanced settings): */
+                       modest_account_mgr_set_enabled (account_wizard->account_manager, 
+                               account_wizard->saved_account_name, TRUE);
+               } else {
+                       create_account (account_wizard, TRUE /* enabled */);
+               }
        }
        
        
@@ -1039,28 +1177,32 @@ on_enable_buttons (ModestWizardDialog *dialog, GtkWidget *current_page)
                        enable_next = FALSE;
        }
                        
-       /* Enable the buttons, 
-        * identifying them via their associated response codes:
-        */
-       GtkDialog *dialog_base = GTK_DIALOG (dialog);
-    gtk_dialog_set_response_sensitive (dialog_base,
-                                       MODEST_WIZARD_DIALOG_NEXT,
-                                       enable_next);
-                                       
+    /* Enable the buttons, 
+        * identifying them via their associated response codes: */
+                                  
     /* Disable the Finish button until we are on the last page,
      * because HildonWizardDialog enables this for all but the first page: */
     GtkNotebook *notebook = NULL;
+    GtkDialog *dialog_base = GTK_DIALOG (dialog);
        g_object_get (dialog_base, "wizard-notebook", &notebook, NULL);
        
     gint current = gtk_notebook_get_current_page (notebook);
     gint last = gtk_notebook_get_n_pages (notebook) - 1;
-    gboolean is_last = (current == last);
+    const gboolean is_last = (current == last);
     
     if(!is_last) {
        gtk_dialog_set_response_sensitive (dialog_base,
                                        MODEST_WIZARD_DIALOG_FINISH,
                                        FALSE);
+    } else
+    {
+       /* Disable Next on the last page: */
+       enable_next = FALSE;
     }
+       
+    gtk_dialog_set_response_sensitive (dialog_base,
+                                       MODEST_WIZARD_DIALOG_NEXT,
+                                       enable_next);
 }
 
 static void
@@ -1086,21 +1228,24 @@ modest_easysetup_wizard_dialog_class_init (ModestEasysetupWizardDialogClass *kla
 static void
 show_error (GtkWindow *parent_window, const gchar* text)
 {
+       GtkDialog *dialog = GTK_DIALOG (hildon_note_new_information (parent_window, text));
+       /*
        GtkDialog *dialog = GTK_DIALOG (gtk_message_dialog_new (parent_window,
                (GtkDialogFlags)0,
                 GTK_MESSAGE_ERROR,
                 GTK_BUTTONS_OK,
                 text ));
+       */
                 
-                gtk_dialog_run (dialog);
-                gtk_widget_destroy (GTK_WIDGET (dialog));
+       gtk_dialog_run (dialog);
+       gtk_widget_destroy (GTK_WIDGET (dialog));
 }
 
 /** Attempt to create the account from the information that the user has entered.
  * @result: TRUE if the account was successfully created.
  */
 gboolean
-create_account (ModestEasysetupWizardDialog *self)
+create_account (ModestEasysetupWizardDialog *self, gboolean enabled)
 {
        ModestEasysetupWizardDialogPrivate *priv = WIZARD_DIALOG_GET_PRIVATE (self);
        
@@ -1207,7 +1352,9 @@ create_account (ModestEasysetupWizardDialog *self)
        
        /* Sanity check: */
        /* There must be at least one account now: */
-       GSList *account_names = modest_account_mgr_account_names (self->account_manager);
+       /* Note, when this fails is is caused by a Maemo gconf bug that has been 
+        * fixed in versions after 3.1. */
+       GSList *account_names = modest_account_mgr_account_names (self->account_manager, FALSE);
        if(!account_names)
        {
                g_warning ("modest_account_mgr_account_names() returned NULL after adding an account.");
@@ -1232,7 +1379,7 @@ create_account (ModestEasysetupWizardDialog *self)
                /* Note: We need something as default, or modest_account_mgr_add_server_account will fail. */
                protocol_outgoing = MODEST_PROTOCOL_TRANSPORT_SENDMAIL; 
                if (servertype_outgoing == MODEST_PRESETS_SERVER_TYPE_SMTP)
-                       protocol_outgoing = MODEST_PROTOCOL_TRANSPORT_SMTP; /* TODO: Is this what we want? */
+                       protocol_outgoing = MODEST_PROTOCOL_TRANSPORT_SMTP;
                
                ModestPresetsSecurity security_outgoing = 
                        modest_presets_get_info_server_security (priv->presets, provider_id, 
@@ -1256,12 +1403,6 @@ create_account (ModestEasysetupWizardDialog *self)
                
                protocol_authentication_outgoing = modest_secureauth_combo_box_get_active_secureauth (
                        MODEST_SECUREAUTH_COMBO_BOX (self->combo_outgoing_auth));
-               
-               /* TODO: 
-               gboolean specific = gtk_toggle_button_get_active (
-                       GTK_TOGGLE_BUTTON (self->checkbox_outgoing_smtp_specific));
-               */
-               
        }
            
        /* Add a (outgoing) server account to be used by the account: */
@@ -1289,7 +1430,8 @@ create_account (ModestEasysetupWizardDialog *self)
        /* Create the account, which will contain the two "server accounts": */
        created = modest_account_mgr_add_account (self->account_manager, account_name, 
                store_name, /* The name of our POP/IMAP server account. */
-               transport_name /* The name of our SMTP server account. */);
+               transport_name, /* The name of our SMTP server account. */
+               enabled);
        g_free (store_name);
        g_free (transport_name);
        
@@ -1313,13 +1455,17 @@ create_account (ModestEasysetupWizardDialog *self)
                MODEST_ACCOUNT_DISPLAY_NAME, display_name, FALSE /* not server account */);
 
        /* Save the connection-specific SMTP server accounts. */
+       gboolean result = TRUE;
        if (self->specific_window)
-               return modest_connection_specific_smtp_window_save_server_accounts (
+               result = modest_connection_specific_smtp_window_save_server_accounts (
                        MODEST_CONNECTION_SPECIFIC_SMTP_WINDOW (self->specific_window), account_name);
                        
+       g_free (self->saved_account_name);
+       self->saved_account_name = g_strdup (account_name);
+       
        g_free (account_name);
 
-       return FALSE;
+       return result;
 }