2007-05-14 Murray Cumming <murrayc@murrayc.com>
[modest] / src / maemo / modest-account-settings-dialog.c
index 505e91f..9d6b01a 100644 (file)
@@ -15,8 +15,8 @@
 #include <gtk/gtkcheckbutton.h>
 #include <gtk/gtkmessagedialog.h>
 #include <gtk/gtkstock.h>
-#include <hildon-widgets/hildon-caption.h>
-#include <hildon-widgets/hildon-number-editor.h>
+#include "modest-hildon-includes.h"
+
 #include "widgets/modest-serversecurity-combo-box.h"
 #include "widgets/modest-secureauth-combo-box.h"
 #include "widgets/modest-validating-entry.h"
@@ -27,7 +27,8 @@
 #include "modest-account-mgr-helpers.h" /* For modest_account_mgr_get_account_data(). */
 #include "modest-runtime.h" /* For modest_runtime_get_account_mgr(). */
 #include "maemo/modest-connection-specific-smtp-window.h"
-#include <maemo/modest-maemo-ui-constants.h>
+#include "maemo/modest-signature-editor-dialog.h"
+#include "widgets/modest-ui-constants.h"
 #include <gconf/gconf-client.h>
 #include <string.h> /* For strlen(). */
 
@@ -98,6 +99,9 @@ modest_account_settings_dialog_finalize (GObject *object)
                
        if (self->specific_window)
                gtk_widget_destroy (self->specific_window);
+               
+       if (self->signature_dialog)
+               gtk_widget_destroy (self->signature_dialog);
        
        G_OBJECT_CLASS (modest_account_settings_dialog_parent_class)->finalize (object);
 }
@@ -212,10 +216,18 @@ static GtkWidget* create_caption_new_with_asterix(ModestAccountSettingsDialog *s
        return caption;
 }
 
+
+static void
+on_entry_max (ModestValidatingEntry *self, gpointer user_data)
+{
+       ModestAccountSettingsDialog *dialog = MODEST_ACCOUNT_SETTINGS_DIALOG (user_data);
+       show_error (GTK_WINDOW (dialog), _("ckdg_ib_maximum_characters_reached"));
+}
+
 static GtkWidget*
 create_page_account_details (ModestAccountSettingsDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_HALF);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        GtkWidget *label = gtk_label_new(_("mcen_ia_accountdetails"));
        gtk_box_pack_start (GTK_BOX (box), label, FALSE, FALSE, MODEST_MARGIN_HALF);
        gtk_widget_show (label);
@@ -226,7 +238,10 @@ create_page_account_details (ModestAccountSettingsDialog *self)
        GtkSizeGroup* sizegroup = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
            
        /* The description widgets: */  
-       self->entry_account_title = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_account_title = GTK_WIDGET (modest_validating_entry_new ());
+       /* Do use auto-capitalization: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_account_title), 
+               HILDON_GTK_INPUT_MODE_FULL | HILDON_GTK_INPUT_MODE_AUTOCAP);
        GtkWidget *caption = create_caption_new_with_asterix (self, sizegroup, _("mcen_fi_account_title"), 
                self->entry_account_title, NULL, HILDON_CAPTION_MANDATORY);
        gtk_widget_show (self->entry_account_title);
@@ -248,13 +263,15 @@ create_page_account_details (ModestAccountSettingsDialog *self)
        list_prevent = g_list_append (list_prevent, ">"); 
        list_prevent = g_list_append (list_prevent, "|");
        list_prevent = g_list_append (list_prevent, "^");       
-       easysetup_validating_entry_set_unallowed_characters (
-               EASYSETUP_VALIDATING_ENTRY (self->entry_account_title), list_prevent);
+       modest_validating_entry_set_unallowed_characters (
+               MODEST_VALIDATING_ENTRY (self->entry_account_title), list_prevent);
        g_list_free (list_prevent);
        
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_account_title), 64);
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_account_title), 
+               on_entry_max, self);
        
        /* The retrieve combobox: */
        self->combo_retrieve = GTK_WIDGET (modest_retrieve_combo_box_new ());
@@ -276,11 +293,13 @@ create_page_account_details (ModestAccountSettingsDialog *self)
 
        /* The leave-messages widgets: */
        if(!self->checkbox_leave_messages)
-               self->checkbox_leave_messages = 
-                       gtk_check_button_new_with_label (_("mcen_fi_advsetup_leave_on_server"));
-       gtk_box_pack_start (GTK_BOX (box), self->checkbox_leave_messages, FALSE, FALSE, MODEST_MARGIN_HALF);
+               self->checkbox_leave_messages = gtk_check_button_new ();
+       caption = create_caption_new_with_asterix (self, sizegroup, _("mcen_fi_advsetup_leave_on_server"), 
+               self->checkbox_leave_messages, NULL, HILDON_CAPTION_MANDATORY);
        gtk_widget_show (self->checkbox_leave_messages);
        connect_for_modified (self, self->checkbox_leave_messages);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
+       gtk_widget_show (caption);
        
        gtk_widget_show (GTK_WIDGET (box));
        
@@ -290,13 +309,43 @@ create_page_account_details (ModestAccountSettingsDialog *self)
 static void
 on_button_signature (GtkButton *button, gpointer user_data)
 {
+       ModestAccountSettingsDialog * self = MODEST_ACCOUNT_SETTINGS_DIALOG (user_data);
        
+       /* Create the window, if necessary: */
+       if (!(self->signature_dialog)) {
+               self->signature_dialog = GTK_WIDGET (modest_signature_editor_dialog_new ());
+       
+               gboolean use_signature = FALSE;
+               gchar *signature = modest_account_mgr_get_signature(self->account_manager, self->account_name, 
+                       &use_signature);
+               const gchar* account_title = gtk_entry_get_text (GTK_ENTRY (self->entry_account_title));
+               modest_signature_editor_dialog_set_settings (
+                       MODEST_SIGNATURE_EDITOR_DIALOG (self->signature_dialog), 
+                       use_signature, signature, account_title);
+               g_free (signature);
+               signature = NULL;
+       }
+
+       /* Show the window: */  
+       gtk_window_set_transient_for (GTK_WINDOW (self->signature_dialog), GTK_WINDOW (self));
+       gtk_window_set_modal (GTK_WINDOW (self->signature_dialog), TRUE);
+    const gint response = gtk_dialog_run (GTK_DIALOG (self->signature_dialog));
+    gtk_widget_hide (self->signature_dialog);
+    if (response != GTK_RESPONSE_OK) {
+       /* Destroy the widget now, and its data: */
+       gtk_widget_destroy (self->signature_dialog);
+       self->signature_dialog = NULL;
+    }
+    else {
+       /* Mark modified, so we use the dialog's data later: */
+       self->modified = TRUE;  
+    }
 }
 
 static GtkWidget*
 create_page_user_details (ModestAccountSettingsDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_HALF);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        
        /* Create a size group to be used by all captions.
         * Note that HildonCaption does not create a default size group if we do not specify one.
@@ -304,10 +353,14 @@ create_page_user_details (ModestAccountSettingsDialog *self)
        GtkSizeGroup* sizegroup = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
         
        /* The name widgets: */
-       self->entry_user_name = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_user_name = GTK_WIDGET (modest_validating_entry_new ());
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_user_name), HILDON_GTK_INPUT_MODE_FULL);
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_user_name), 64);
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_user_name), 
+               on_entry_max, self);
        GtkWidget *caption = create_caption_new_with_asterix (self, sizegroup, 
                _("mcen_li_emailsetup_name"), self->entry_user_name, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->entry_user_name);
@@ -320,12 +373,14 @@ create_page_user_details (ModestAccountSettingsDialog *self)
        GList *list_prevent = NULL;
        list_prevent = g_list_append (list_prevent, "<");
        list_prevent = g_list_append (list_prevent, ">");
-       easysetup_validating_entry_set_unallowed_characters (
-               EASYSETUP_VALIDATING_ENTRY (self->entry_user_name), list_prevent);
+       modest_validating_entry_set_unallowed_characters (
+               MODEST_VALIDATING_ENTRY (self->entry_user_name), list_prevent);
        g_list_free (list_prevent);
        
        /* The username widgets: */     
-       self->entry_user_username = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_user_username = GTK_WIDGET (modest_validating_entry_new ());
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_user_username), HILDON_GTK_INPUT_MODE_FULL);
        caption = create_caption_new_with_asterix (self, sizegroup, _("mail_fi_username"), 
                self->entry_user_username, NULL, HILDON_CAPTION_MANDATORY);
        gtk_widget_show (self->entry_user_username);
@@ -335,15 +390,20 @@ create_page_user_details (ModestAccountSettingsDialog *self)
        
        /* Prevent the use of some characters in the username, 
         * as required by our UI specification: */
-       easysetup_validating_entry_set_unallowed_characters_whitespace (
-               EASYSETUP_VALIDATING_ENTRY (self->entry_user_username));
+       modest_validating_entry_set_unallowed_characters_whitespace (
+               MODEST_VALIDATING_ENTRY (self->entry_user_username));
        
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_user_username), 64);
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_user_username), 
+               on_entry_max, self);
        
        /* The password widgets: */     
        self->entry_user_password = gtk_entry_new ();
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_user_password), 
+               HILDON_GTK_INPUT_MODE_FULL | HILDON_GTK_INPUT_MODE_INVISIBLE);
        gtk_entry_set_visibility (GTK_ENTRY (self->entry_user_password), FALSE);
        /* gtk_entry_set_invisible_char (GTK_ENTRY (self->entry_user_password), '*'); */
        caption = create_caption_new_with_asterix (self, sizegroup, 
@@ -354,7 +414,9 @@ create_page_user_details (ModestAccountSettingsDialog *self)
        gtk_widget_show (caption);
        
        /* The email address widgets: */        
-       self->entry_user_email = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_user_email = GTK_WIDGET (modest_validating_entry_new ());
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_user_email), HILDON_GTK_INPUT_MODE_FULL);
        caption = create_caption_new_with_asterix (self, sizegroup, 
                _("mcen_li_emailsetup_email_address"), self->entry_user_email, NULL, HILDON_CAPTION_MANDATORY);
        gtk_entry_set_text (GTK_ENTRY (self->entry_user_email), EXAMPLE_EMAIL_ADDRESS); /* Default text. */
@@ -364,9 +426,10 @@ create_page_user_details (ModestAccountSettingsDialog *self)
        gtk_widget_show (caption);
        
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_user_email), 64);
-       
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_user_email), 
+               on_entry_max, self);
        
        /* Signature button: */
        if (!self->button_signature)
@@ -418,7 +481,7 @@ static void update_incoming_server_security_choices (ModestAccountSettingsDialog
            
 static GtkWidget* create_page_incoming (ModestAccountSettingsDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_HALF);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        
        /* Create a size group to be used by all captions.
         * Note that HildonCaption does not create a default size group if we do not specify one.
@@ -428,6 +491,8 @@ static GtkWidget* create_page_incoming (ModestAccountSettingsDialog *self)
        /* The incoming server widgets: */
        if(!self->entry_incomingserver)
                self->entry_incomingserver = gtk_entry_new ();
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_incomingserver), HILDON_GTK_INPUT_MODE_FULL);
 
        if (self->caption_incoming)
          gtk_widget_destroy (self->caption_incoming);
@@ -470,11 +535,13 @@ static GtkWidget* create_page_incoming (ModestAccountSettingsDialog *self)
        
        /* The secure authentication widgets: */
        if(!self->checkbox_incoming_auth)
-               self->checkbox_incoming_auth = 
-                       gtk_check_button_new_with_label (_("mcen_li_emailsetup_secure_authentication"));
-       gtk_box_pack_start (GTK_BOX (box), self->checkbox_incoming_auth, FALSE, FALSE, MODEST_MARGIN_HALF);
+               self->checkbox_incoming_auth = gtk_check_button_new ();
+       caption = hildon_caption_new (sizegroup, _("mcen_li_emailsetup_secure_authentication"), 
+               self->checkbox_incoming_auth, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->checkbox_incoming_auth);
        connect_for_modified (self, self->checkbox_incoming_auth);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
+       gtk_widget_show (caption);
        
        gtk_widget_show (GTK_WIDGET (box));
        
@@ -569,7 +636,7 @@ on_combo_incoming_security_changed (GtkComboBox *widget, gpointer user_data)
 
 static GtkWidget* create_page_outgoing (ModestAccountSettingsDialog *self)
 {
-       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_HALF);
+       GtkWidget *box = gtk_vbox_new (FALSE, MODEST_MARGIN_NONE);
        
        /* Create a size group to be used by all captions.
         * Note that HildonCaption does not create a default size group if we do not specify one.
@@ -579,6 +646,8 @@ static GtkWidget* create_page_outgoing (ModestAccountSettingsDialog *self)
        /* The outgoing server widgets: */
        if (!self->entry_outgoingserver)
                self->entry_outgoingserver = gtk_entry_new ();
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_outgoingserver), HILDON_GTK_INPUT_MODE_FULL);
        GtkWidget *caption = create_caption_new_with_asterix (self, sizegroup, 
                _("mcen_li_emailsetup_smtp"), self->entry_outgoingserver, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->entry_outgoingserver);
@@ -600,7 +669,9 @@ static GtkWidget* create_page_outgoing (ModestAccountSettingsDialog *self)
        g_signal_connect (G_OBJECT (self->combo_outgoing_auth), "changed", (GCallback)on_combo_outgoing_auth_changed, self);
        
        /* The username widgets: */     
-       self->entry_outgoing_username = GTK_WIDGET (easysetup_validating_entry_new ());
+       self->entry_outgoing_username = GTK_WIDGET (modest_validating_entry_new ());
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_outgoing_username), HILDON_GTK_INPUT_MODE_FULL);
        self->caption_outgoing_username = create_caption_new_with_asterix (self, sizegroup, _("mail_fi_username"), 
                self->entry_outgoing_username, NULL, HILDON_CAPTION_MANDATORY);
        gtk_widget_show (self->entry_outgoing_username);
@@ -610,15 +681,20 @@ static GtkWidget* create_page_outgoing (ModestAccountSettingsDialog *self)
        
        /* Prevent the use of some characters in the username, 
         * as required by our UI specification: */
-       easysetup_validating_entry_set_unallowed_characters_whitespace (
-               EASYSETUP_VALIDATING_ENTRY (self->entry_outgoing_username));
+       modest_validating_entry_set_unallowed_characters_whitespace (
+               MODEST_VALIDATING_ENTRY (self->entry_outgoing_username));
        
        /* Set max length as in the UI spec:
-        * TODO: The UI spec seems to want us to show a dialog if we hit the maximum. */
+        * The UI spec seems to want us to show a dialog if we hit the maximum. */
        gtk_entry_set_max_length (GTK_ENTRY (self->entry_outgoing_username), 64);
-       
+       modest_validating_entry_set_max_func (MODEST_VALIDATING_ENTRY (self->entry_outgoing_username), 
+               on_entry_max, self);
+               
        /* The password widgets: */     
        self->entry_outgoing_password = gtk_entry_new ();
+       /* Auto-capitalization is the default, so let's turn it off: */
+       hildon_gtk_entry_set_input_mode (GTK_ENTRY (self->entry_outgoing_password), 
+               HILDON_GTK_INPUT_MODE_FULL | HILDON_GTK_INPUT_MODE_INVISIBLE);
        gtk_entry_set_visibility (GTK_ENTRY (self->entry_outgoing_password), FALSE);
        /* gtk_entry_set_invisible_char (GTK_ENTRY (self->entry_outgoing_password), '*'); */
        self->caption_outgoing_password = create_caption_new_with_asterix (self, sizegroup, 
@@ -660,12 +736,15 @@ static GtkWidget* create_page_outgoing (ModestAccountSettingsDialog *self)
        
        /* connection-specific checkbox: */
        if (!self->checkbox_outgoing_smtp_specific) {
-               self->checkbox_outgoing_smtp_specific = gtk_check_button_new_with_label (_("mcen_fi_advsetup_connection_smtp"));
+               self->checkbox_outgoing_smtp_specific = gtk_check_button_new ();
                gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (self->checkbox_outgoing_smtp_specific), 
                        FALSE);
        }
-       gtk_box_pack_start (GTK_BOX (box), self->checkbox_outgoing_smtp_specific, FALSE, FALSE, MODEST_MARGIN_HALF);
+       caption = hildon_caption_new (sizegroup, _("mcen_fi_advsetup_connection_smtp"), 
+               self->checkbox_outgoing_smtp_specific, NULL, HILDON_CAPTION_OPTIONAL);
        gtk_widget_show (self->checkbox_outgoing_smtp_specific);
+       gtk_box_pack_start (GTK_BOX (box), caption, FALSE, FALSE, MODEST_MARGIN_HALF);
+       gtk_widget_show (caption);
        connect_for_modified (self, self->checkbox_outgoing_smtp_specific);
        
        /* Connection-specific SMTP-Severs Edit button: */
@@ -747,11 +826,9 @@ on_response (GtkDialog *wizard_dialog,
        
        /* Warn about unsaved changes: */
        if (response_id == GTK_RESPONSE_CANCEL && self->modified) {
-               GtkDialog *dialog = GTK_DIALOG (gtk_message_dialog_new (GTK_WINDOW (self),
-               (GtkDialogFlags)0,
-                GTK_MESSAGE_INFO,
-                GTK_BUTTONS_OK_CANCEL, /* TODO: These button names are ambiguous, and not specified in the UI specification. */
-                _("imum_nc_wizard_confirm_lose_changes") ));
+               GtkDialog *dialog = GTK_DIALOG (hildon_note_new_confirmation (GTK_WINDOW (self), 
+                       _("imum_nc_wizard_confirm_lose_changes")));
+               /* TODO: These button names will be ambiguous, and not specified in the UI specification. */
                 
                 const gint dialog_response = gtk_dialog_run (dialog);
                 gtk_widget_destroy (GTK_WIDGET (dialog));
@@ -760,7 +837,7 @@ on_response (GtkDialog *wizard_dialog,
                        prevent_response = TRUE;
        }
        /* Check for invalid input: */
-       else if (!check_data (self)) {
+       else if (response_id != GTK_RESPONSE_CANCEL && !check_data (self)) {
                prevent_response = TRUE;
        }
                
@@ -771,12 +848,19 @@ on_response (GtkDialog *wizard_dialog,
                return; 
        }
                
-               
        if (response_id == GTK_RESPONSE_OK) {
                /* Try to save the changes: */  
                const gboolean saved = save_configuration (self);
-               if (saved)
-                       show_ok (GTK_WINDOW (self), _("mcen_ib_advsetup_settings_saved"));
+               if (saved) {
+                       /* Do not show the account-saved dialog if we are just saving this 
+                        * temporarily, because from the user's point of view it will not 
+                        * really be saved (saved + enabled) until later.
+                        */
+                       const gboolean enabled = 
+                               modest_account_mgr_get_enabled (self->account_manager, self->account_name);
+                       if (enabled)
+                               show_ok (GTK_WINDOW (self), _("mcen_ib_advsetup_settings_saved"));
+               }
                else
                        show_error (GTK_WINDOW (self), _("mail_ib_setting_failed"));
        }
@@ -833,7 +917,12 @@ modest_account_settings_dialog_init (ModestAccountSettingsDialog *self)
     g_signal_connect (G_OBJECT (self), "response",
             G_CALLBACK (on_response), self); 
             
-    self->modified = FALSE;      
+    self->modified = FALSE;
+    
+    /* When this window is shown, hibernation should not be possible, 
+        * because there is no sensible way to save the state: */
+    modest_window_mgr_prevent_hibernation_while_window_is_shown (
+       modest_runtime_get_window_mgr (), GTK_WINDOW (self)); 
 }
 
 ModestAccountSettingsDialog*
@@ -926,10 +1015,16 @@ void modest_account_settings_dialog_set_account_name (ModestAccountSettingsDialo
                gtk_entry_set_text( GTK_ENTRY (dialog->entry_incomingserver), 
                        incoming_account->hostname ? incoming_account->hostname : "");
                        
+               /* The UI spec says:
+                * If secure authentication is unchecked, allow sending username and password also as plain text.
+        * If secure authentication is checked, require one of the secure methods during connection: SSL, TLS, CRAM-MD5 etc. 
+                * TODO: Do we need to discover which of these (SSL, TLS, CRAM-MD5) is supported?
+         */
                const ModestProtocol secure_auth = modest_server_account_get_secure_auth(
                        dialog->account_manager, incoming_account->account_name);
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON (dialog->checkbox_incoming_auth), 
-                       secure_auth == MODEST_PROTOCOL_AUTH_PASSWORD);
+                       secure_auth != MODEST_PROTOCOL_AUTH_PASSWORD);
+               /* Note that MODEST_PROTOCOL_AUTH_PLAIN should probably never be used. */
                        
                update_incoming_server_title (dialog, incoming_account->proto);
                update_incoming_server_security_choices (dialog, incoming_account->proto);
@@ -1008,6 +1103,18 @@ save_configuration (ModestAccountSettingsDialog *dialog)
                MODEST_ACCOUNT_EMAIL, emailaddress, FALSE /* not server account */);
        if (!test)
                return FALSE;
+               
+       /* Signature: */
+       if (dialog->signature_dialog) {
+               gboolean use_signature = FALSE;
+       gchar *signature = modest_signature_editor_dialog_get_settings (
+               MODEST_SIGNATURE_EDITOR_DIALOG (dialog->signature_dialog),
+               &use_signature);
+       
+       modest_account_mgr_set_signature(dialog->account_manager, account_name, 
+               signature, use_signature);
+       g_free (signature);
+    }
        
        gchar *retrieve = modest_retrieve_combo_box_get_active_retrieve_conf (
                MODEST_RETRIEVE_COMBO_BOX (dialog->combo_retrieve));
@@ -1038,21 +1145,20 @@ save_configuration (ModestAccountSettingsDialog *dialog)
                return FALSE;
                                
        const gchar* username = gtk_entry_get_text (GTK_ENTRY (dialog->entry_user_username));
-       test = modest_account_mgr_set_string (dialog->account_manager, incoming_account_name,
-               MODEST_ACCOUNT_USERNAME, username, TRUE /* server account */);
-       if (!test)
-               return FALSE;
-                               
+       modest_server_account_set_username (dialog->account_manager, incoming_account_name, username);
+       
        const gchar* password = gtk_entry_get_text (GTK_ENTRY (dialog->entry_user_password));
-       test = modest_account_mgr_set_string (dialog->account_manager, incoming_account_name,
-               MODEST_ACCOUNT_PASSWORD, password, TRUE /*  server account */);
-       if (!test)
-               return FALSE;
+       modest_server_account_set_password (dialog->account_manager, incoming_account_name, password);
                        
+       /* The UI spec says:
+        * If secure authentication is unchecked, allow sending username and password also as plain text.
+        * If secure authentication is checked, require one of the secure methods during connection: SSL, TLS, CRAM-MD5 etc. 
+        * TODO: Do we need to discover which of these (SSL, TLS, CRAM-MD5) is supported?
+     */
        const ModestProtocol protocol_authentication_incoming = gtk_toggle_button_get_active 
                (GTK_TOGGLE_BUTTON (dialog->checkbox_incoming_auth)) 
-                       ? MODEST_PROTOCOL_AUTH_PASSWORD
-                       : MODEST_PROTOCOL_AUTH_NONE;
+                       ? MODEST_PROTOCOL_AUTH_CRAMMD5
+                       : MODEST_PROTOCOL_AUTH_PASSWORD;
        modest_server_account_set_secure_auth (dialog->account_manager, incoming_account_name, protocol_authentication_incoming);
                        
        const ModestProtocol protocol_security_incoming = modest_serversecurity_combo_box_get_active_serversecurity (
@@ -1079,16 +1185,12 @@ save_configuration (ModestAccountSettingsDialog *dialog)
                return FALSE;
                
        username = gtk_entry_get_text (GTK_ENTRY (dialog->entry_outgoing_username));
-       test = modest_account_mgr_set_string (dialog->account_manager, outgoing_account_name,
-               MODEST_ACCOUNT_USERNAME, username, TRUE /* server account */);
-       if (!test)
-               return FALSE;
+       modest_server_account_set_username (dialog->account_manager, outgoing_account_name,
+               username);
                
        password = gtk_entry_get_text (GTK_ENTRY (dialog->entry_outgoing_password));
-       test = modest_account_mgr_set_string (dialog->account_manager, outgoing_account_name,
-               MODEST_ACCOUNT_PASSWORD, password, TRUE /*  server account */);
-       if (!test)
-               return FALSE;
+       modest_server_account_set_password (dialog->account_manager, outgoing_account_name,
+               password);
        
        const ModestProtocol protocol_security_outgoing = modest_serversecurity_combo_box_get_active_serversecurity (
                MODEST_SERVERSECURITY_COMBO_BOX (dialog->combo_outgoing_security));
@@ -1186,27 +1288,33 @@ modest_account_settings_dialog_class_init (ModestAccountSettingsDialogClass *kla
 static void
 show_error (GtkWindow *parent_window, const gchar* text)
 {
+       GtkDialog *dialog = GTK_DIALOG (hildon_note_new_information (parent_window, text));
+       /*
        GtkDialog *dialog = GTK_DIALOG (gtk_message_dialog_new (parent_window,
                (GtkDialogFlags)0,
                 GTK_MESSAGE_ERROR,
                 GTK_BUTTONS_OK,
                 text ));
-                
-                gtk_dialog_run (dialog);
-                gtk_widget_destroy (GTK_WIDGET (dialog));
+       */       
+       
+       gtk_dialog_run (dialog);
+       gtk_widget_destroy (GTK_WIDGET (dialog));
 }
 
 static void
 show_ok (GtkWindow *parent_window, const gchar* text)
 {
+       GtkDialog *dialog = GTK_DIALOG (hildon_note_new_information (parent_window, text));
+       /*
        GtkDialog *dialog = GTK_DIALOG (gtk_message_dialog_new (parent_window,
                (GtkDialogFlags)0,
                 GTK_MESSAGE_INFO,
                 GTK_BUTTONS_OK,
                 text ));
+       */
                 
-                gtk_dialog_run (dialog);
-                gtk_widget_destroy (GTK_WIDGET (dialog));
+       gtk_dialog_run (dialog);
+       gtk_widget_destroy (GTK_WIDGET (dialog));
 }