}
-gboolean modest_account_mgr_set_connection_specific_smtp (ModestAccountMgr *self,
- const gchar* connection_id, const gchar* server_account_name)
+gboolean
+modest_account_mgr_set_connection_specific_smtp (ModestAccountMgr *self,
+ const gchar* connection_id,
+ const gchar* server_account_name)
{
modest_account_mgr_remove_connection_specific_smtp (self, connection_id);
result = FALSE;
} else {
/* The server account is in the item after the connection name: */
- list = g_slist_append (list, (gpointer)connection_id);
- list = g_slist_append (list, (gpointer)server_account_name);
+ list = g_slist_append (list, g_strdup (connection_id));
+ list = g_slist_append (list, g_strdup (server_account_name));
/* Reset the changed list: */
modest_conf_set_list (conf, MODEST_CONF_CONNECTION_SPECIFIC_SMTP_LIST, list,
}
}
- /* TODO: Should we free the items too, or just the list? */
- g_slist_free (list);
+ /* Free the list */
+ if (list) {
+ g_slist_foreach (list, (GFunc) g_free, NULL);
+ g_slist_free (list);
+ }
return result;
}
*
* Returns: TRUE if it worked, FALSE otherwise
*/
-gboolean modest_account_mgr_remove_connection_specific_smtp (ModestAccountMgr *self,
- const gchar* connection_id)
+gboolean
+modest_account_mgr_remove_connection_specific_smtp (ModestAccountMgr *self,
+ const gchar* connection_id)
{
ModestAccountMgrPrivate *priv = MODEST_ACCOUNT_MGR_GET_PRIVATE (self);
result = FALSE;
}
- /* TODO: Should we free the items too, or just the list? */
- g_slist_free (list);
+ /* Free the list */
+ if (list) {
+ g_slist_foreach (list, (GFunc) g_free, NULL);
+ g_slist_free (list);
+ }
return result;
}
iter = g_slist_next (iter);
}
- /*
- if (!result) {
- printf (" debug: no server found for connection_id=%s.\n", connection_id);
+ /* Free the list */
+ if (list) {
+ g_slist_foreach (list, (GFunc) g_free, NULL);
+ g_slist_free (list);
}
- */
-
- /* TODO: Should we free the items too, or just the list? */
- g_slist_free (list);
return result;
}
modest_account_mgr_set_string (self, account_name, MODEST_ACCOUNT_SECURITY, str_value, TRUE);
}
-ModestServerAccountSettings*
+ModestServerAccountSettings *
modest_account_mgr_load_server_settings (ModestAccountMgr *self, const gchar* name, gboolean is_transport_and_not_store)
{
ModestServerAccountSettings *settings;
ModestProtocol *protocol;
ModestProtocolRegistry *registry;
gchar *string;
-
- g_return_val_if_fail (modest_account_mgr_account_exists (self, name, TRUE), NULL);
+
+ if (!modest_account_mgr_account_exists (self, name, TRUE)) {
+ g_message ("%s account %s does not exist", __FUNCTION__, name);
+ return NULL;
+ }
+
registry = modest_runtime_get_protocol_registry ();
settings = modest_server_account_settings_new ();
string = modest_account_mgr_get_string (self, name,
MODEST_ACCOUNT_HOSTNAME,TRUE);
- modest_server_account_settings_set_hostname (settings, string);
- g_free (string);
+ if (string) {
+ modest_server_account_settings_set_hostname (settings, string);
+ g_free (string);
+ } else {
+ goto on_error;
+ }
string = modest_account_mgr_get_string (self, name,
MODEST_ACCOUNT_USERNAME,TRUE);
- modest_server_account_settings_set_username (settings, string);
- g_free (string);
+ if (string) {
+ modest_server_account_settings_set_username (settings, string);
+ g_free (string);
+ } else {
+ goto on_error;
+ }
string = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_PROTO, TRUE);
- if (is_transport_and_not_store) {
- protocol = modest_protocol_registry_get_protocol_by_name (registry, MODEST_PROTOCOL_REGISTRY_TRANSPORT_PROTOCOLS, string);
+ if (string) {
+ gchar *tag = NULL;
+ if (is_transport_and_not_store) {
+ tag = MODEST_PROTOCOL_REGISTRY_TRANSPORT_PROTOCOLS;
+ } else {
+ tag = MODEST_PROTOCOL_REGISTRY_STORE_PROTOCOLS;
+ }
+ protocol = modest_protocol_registry_get_protocol_by_name (registry, tag, string);
+
+ modest_server_account_settings_set_protocol (settings,
+ modest_protocol_get_type_id (protocol));
+ g_free (string);
} else {
- protocol = modest_protocol_registry_get_protocol_by_name (registry, MODEST_PROTOCOL_REGISTRY_STORE_PROTOCOLS, string);
+ goto on_error;
}
- modest_server_account_settings_set_protocol (settings,
- modest_protocol_get_type_id (protocol));
- g_free (string);
modest_server_account_settings_set_port (settings,
modest_account_mgr_get_int (self, name, MODEST_ACCOUNT_PORT, TRUE));
} else {
modest_server_account_settings_set_auth_protocol (settings, MODEST_PROTOCOLS_AUTH_NONE);
}
-
+
string = modest_account_mgr_get_string (self, name, MODEST_ACCOUNT_SECURITY, TRUE);
if (string) {
protocol = modest_protocol_registry_get_protocol_by_name (registry, MODEST_PROTOCOL_REGISTRY_CONNECTION_PROTOCOLS, string);
string = modest_account_mgr_get_string (self, name,
MODEST_ACCOUNT_PASSWORD, TRUE);
- modest_server_account_settings_set_password (settings, string);
- g_free (string);
-
+ if (string) {
+ modest_server_account_settings_set_password (settings, string);
+ g_free (string);
+ }
+
string = modest_account_mgr_get_string (self, name,
MODEST_ACCOUNT_URI, TRUE);
- modest_server_account_settings_set_uri (settings, string);
- g_free (string);
-
+ if (string) {
+ modest_server_account_settings_set_uri (settings, string);
+ g_free (string);
+ }
+
return settings;
+
+ on_error:
+ g_free (settings);
+ return NULL;
}
gboolean
if (server_account) {
ModestServerAccountSettings *store_settings;
store_settings = modest_account_mgr_load_server_settings (self, server_account, FALSE);
- modest_account_settings_set_store_settings (settings,
- store_settings);
- g_object_unref (store_settings);
g_free (server_account);
+
+ /* It could happen that the account data is corrupted
+ so it's not loaded properly */
+ if (store_settings) {
+ modest_account_settings_set_store_settings (settings,
+ store_settings);
+ g_object_unref (store_settings);
+ } else {
+ g_message ("%s can not load server settings. Account corrupted?", __FUNCTION__);
+ g_object_unref (settings);
+ return NULL;
+ }
}
/* transport */
if (server_account) {
ModestServerAccountSettings *transport_settings;
transport_settings = modest_account_mgr_load_server_settings (self, server_account, TRUE);
- modest_account_settings_set_transport_settings (settings, transport_settings);
- g_object_unref (transport_settings);
g_free (server_account);
+
+ if (transport_settings) {
+ modest_account_settings_set_transport_settings (settings, transport_settings);
+ g_object_unref (transport_settings);
+ } else {
+ g_message ("%s can not load server settings. Account corrupted?", __FUNCTION__);
+ g_object_unref (settings);
+ return NULL;
+ }
}
return settings;
projects / modest / blobdiff