* oops, revert to previous version
[modest] / src / modest-account-mgr.c
index 01a3325..c89deab 100644 (file)
@@ -11,6 +11,7 @@ static void    modest_account_mgr_init          (ModestAccountMgr *obj);
 static void    modest_account_mgr_finalize      (GObject *obj);
 
 static gchar*   get_account_keyname (const gchar *accname, const gchar *name);
+static gchar*   get_server_account_keyname (const gchar *accname, const gchar *name);
 
 /* list my signals */
 enum {
@@ -137,38 +138,21 @@ modest_account_mgr_add_account (ModestAccountMgr *self, const gchar* name,
         */
        priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
 
-       /* SMF:
-        * key = get_account_keyname (name, MODEST_ACCOUNT_DISPLAY_NAME);
-         * doesn't work this way, instead use:
-         */
-       key = g_strconcat (MODEST_ACCOUNT_NAMESPACE, "/",
-                             name, MODEST_ACCOUNT_DISPLAY_NAME, NULL);
-
+       key = get_account_keyname (name, MODEST_ACCOUNT_DISPLAY_NAME);
        modest_conf_set_string (priv->modest_conf, key, name, err);
        g_free (key);
 
        if (store_account) {
-               /* SMF:
-                * key = get_account_keyname (name, MODEST_ACCOUNT_STORE_ACCOUNT);
-                * as above, does not work.
-                 */
-               key = g_strconcat (MODEST_ACCOUNT_NAMESPACE, "/",
-                                  name, MODEST_ACCOUNT_STORE_ACCOUNT, NULL);
-
-                modest_conf_set_string (priv->modest_conf, key, store_account, err);
+               key = get_account_keyname (name, MODEST_ACCOUNT_STORE_ACCOUNT);
+               modest_conf_set_string (priv->modest_conf, key, store_account, err);
                g_free (key);
        }
 
        if (transport_account) {
-               /* SMF:
-                * key = get_account_keyname (name, MODEST_ACCOUNT_TRANSPORT_ACCOUNT);
-                * ...
-                */
-               key = g_strconcat (MODEST_ACCOUNT_NAMESPACE, "/",
-                                  name, MODEST_ACCOUNT_TRANSPORT_ACCOUNT, NULL);
+               key = get_account_keyname (name, MODEST_ACCOUNT_TRANSPORT_ACCOUNT);
                modest_conf_set_string (priv->modest_conf, key, transport_account, err);
                g_free (key);
-        }
+       }
 
        return TRUE; /* TODO: error handling */
 }
@@ -291,6 +275,23 @@ modest_account_mgr_remove_server_account    (ModestAccountMgr *self,
 }
 
 
+/* strip the first /n/ character from each element */
+/* caller must make sure all elements are strings with
+ * length >= n, and also that data can be freed.
+ */
+static GSList*
+strip_prefix_from_elements (GSList *lst, guint n)
+{
+       GSList *cursor = lst;
+       while (cursor) {
+               gchar *str = (gchar*)cursor->data;
+               cursor->data = g_strdup (str + n);
+               g_free (str);
+               cursor = cursor->next;
+       }
+       return lst;
+}
+
 
 
 GSList*
@@ -303,6 +304,8 @@ modest_account_mgr_server_account_names   (ModestAccountMgr *self,
        GSList *accounts;
        GSList *cursor;
        ModestAccountMgrPrivate *priv;
+       const size_t prefix_len =
+               strlen (MODEST_SERVER_ACCOUNT_NAMESPACE "/");
 
        g_return_val_if_fail (self, NULL);
 
@@ -313,7 +316,7 @@ modest_account_mgr_server_account_names   (ModestAccountMgr *self,
 
        /* no restrictions, return everything */
        if (type == MODEST_PROTO_TYPE_ANY && !proto)
-               return accounts;
+               return strip_prefix_from_elements (accounts,prefix_len);
 
        /* otherwise, filter out the none-matching ones */
        cursor = accounts;
@@ -339,7 +342,7 @@ modest_account_mgr_server_account_names   (ModestAccountMgr *self,
                        cursor = cursor->next;
        }
 
-       return accounts;
+       return strip_prefix_from_elements (accounts, prefix_len);
 }
 
 
@@ -349,49 +352,70 @@ modest_account_mgr_account_names  (ModestAccountMgr *self, GError **err)
 {
        GSList *accounts, *cursor;
        ModestAccountMgrPrivate *priv;
+       const size_t prefix_len =
+               strlen (MODEST_ACCOUNT_NAMESPACE "/");
+
 
        g_return_val_if_fail (self, NULL);
 
        priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
 
-       return  modest_conf_list_subkeys (priv->modest_conf,
-                                         MODEST_ACCOUNT_NAMESPACE,
-                                         err);
+       accounts = modest_conf_list_subkeys (priv->modest_conf,
+                                            MODEST_ACCOUNT_NAMESPACE,
+                                            err);
+       return strip_prefix_from_elements (accounts, prefix_len);
 }
 
 
-gchar*
-modest_account_mgr_get_account_string (ModestAccountMgr *self, const gchar *name,
-                                      const gchar *key, GError **err)
+
+static gchar*
+get_account_string (ModestAccountMgr *self, const gchar *name,
+                   const gchar *key, gboolean server_account,
+                   GError **err)
 {
        ModestAccountMgrPrivate *priv;
 
        gchar *keyname;
-       gchar *retval;
+       gchar * retval;
 
        g_return_val_if_fail (self, NULL);
        g_return_val_if_fail (name, NULL);
        g_return_val_if_fail (key, NULL);
 
-       keyname = get_account_keyname (name, key);
-
-        g_warning ("modest_account_mgr_get_account_string > %s", keyname);
+       if (server_account)
+               keyname = get_server_account_keyname (name, key);
+       else
+               keyname = get_account_keyname (name, key);
 
        priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
-
-       retval = modest_conf_get_string (priv->modest_conf,
-                                        keyname, err);
-
+       retval = modest_conf_get_string (priv->modest_conf,keyname,err);
        g_free (keyname);
+
        return retval;
 }
 
 
+gchar*
+modest_account_mgr_get_server_account_string (ModestAccountMgr *self, const gchar *name,
+                                          const gchar *key, GError **err)
+{
+       return get_account_string (self, name, key, TRUE, err);
+}
 
-gint
-modest_account_mgr_get_account_int (ModestAccountMgr *self, const gchar *name,
+gchar*
+modest_account_mgr_get_account_string (ModestAccountMgr *self, const gchar *name,
                                    const gchar *key, GError **err)
 {
+       return get_account_string (self, name, key, FALSE, err);
+}
+
+
+
+static gint
+get_account_int (ModestAccountMgr *self, const gchar *name,
+                const gchar *key, gboolean server_account,
+                GError **err)
+{
        ModestAccountMgrPrivate *priv;
 
        gchar *keyname;
@@ -401,41 +425,85 @@ modest_account_mgr_get_account_int (ModestAccountMgr *self, const gchar *name,
        g_return_val_if_fail (name, -1);
        g_return_val_if_fail (key, -1);
 
-       keyname = get_account_keyname (name, key);
+       if (server_account)
+               keyname = get_server_account_keyname (name, key);
+       else
+               keyname = get_account_keyname (name, key);
+
        priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
        retval = modest_conf_get_int (priv->modest_conf,keyname,err);
-
        g_free (keyname);
+
        return retval;
 }
 
 
-gboolean modest_account_mgr_get_account_bool (ModestAccountMgr *self, const gchar *name,
-                                             const gchar *key, GError **err)
+gint
+modest_account_mgr_get_server_account_int (ModestAccountMgr *self, const gchar *name,
+                                          const gchar *key, GError **err)
+{
+       return get_account_int (self, name, key, TRUE, err);
+}
+
+gint
+modest_account_mgr_get_account_int (ModestAccountMgr *self, const gchar *name,
+                                   const gchar *key, GError **err)
+{
+       return get_account_int (self, name, key, FALSE, err);
+}
+
+
+
+static gboolean
+get_account_bool (ModestAccountMgr *self, const gchar *name,
+                 const gchar *key, gboolean server_account,
+                 GError **err)
 {
        ModestAccountMgrPrivate *priv;
 
        gchar *keyname;
        gboolean retval;
 
-       g_return_val_if_fail (self, FALSE);
-       g_return_val_if_fail (name, FALSE);
-       g_return_val_if_fail (key, FALSE);
+       g_return_val_if_fail (self, -1);
+       g_return_val_if_fail (name, -1);
+       g_return_val_if_fail (key, -1);
 
-       keyname = get_account_keyname (name, key);
-       priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
-       retval = modest_conf_get_bool (priv->modest_conf,keyname,err);
+       if (server_account)
+               keyname = get_server_account_keyname (name, key);
+       else
+               keyname = get_account_keyname (name, key);
 
+       priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
+       retval = modest_conf_get_int (priv->modest_conf,keyname,err);
        g_free (keyname);
+
        return retval;
 }
 
 
 
-gboolean
-modest_account_mgr_set_account_string  (ModestAccountMgr *self, const gchar *name,
-                                       const gchar *key, const gchar* val,
-                                       GError **err)
+gint
+modest_account_mgr_get_server_account_bool (ModestAccountMgr *self, const gchar *name,
+                                          const gchar *key, GError **err)
+{
+       return get_account_bool (self, name, key, TRUE, err);
+}
+
+gint
+modest_account_mgr_get_account_bool (ModestAccountMgr *self, const gchar *name,
+                                   const gchar *key, GError **err)
+{
+       return get_account_bool (self, name, key, FALSE, err);
+}
+
+
+
+
+
+static gboolean
+set_account_string  (ModestAccountMgr *self, const gchar *name,
+                    const gchar *key, const gchar* val, gboolean server_account,
+                    GError **err)
 {
        ModestAccountMgrPrivate *priv;
 
@@ -446,8 +514,13 @@ modest_account_mgr_set_account_string  (ModestAccountMgr *self, const gchar *nam
        g_return_val_if_fail (name, FALSE);
        g_return_val_if_fail (key, FALSE);
 
-       keyname = get_account_keyname (name, key);
+       if (server_account)
+               keyname = get_server_account_keyname (name, key);
+       else
+               keyname = get_account_keyname (name, key);
+
        priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
+
        retval = modest_conf_set_string (priv->modest_conf,keyname,val,err);
 
        g_free (keyname);
@@ -456,21 +529,48 @@ modest_account_mgr_set_account_string  (ModestAccountMgr *self, const gchar *nam
 
 
 
+
+
 gboolean
-modest_account_mgr_set_account_int  (ModestAccountMgr *self, const gchar *name,
-                                    const gchar *key, gint val, GError **err)
+modest_account_mgr_set_server_account_string  (ModestAccountMgr *self, const gchar *name,
+                                              const gchar *key, const gchar* val,
+                                              GError **err)
+{
+       return set_account_string (self, name, key, val, TRUE, err);
+}
+
+
+
+gboolean
+modest_account_mgr_set_account_string  (ModestAccountMgr *self, const gchar *name,
+                                       const gchar *key, const gchar* val,
+                                       GError **err)
+{
+       return set_account_string (self, name, key, val, FALSE, err);
+}
+
+
+static gboolean
+set_account_int  (ModestAccountMgr *self, const gchar *name,
+                 const gchar *key, gboolean server_account, int val,
+                 GError **err)
 {
        ModestAccountMgrPrivate *priv;
 
        gchar *keyname;
        gboolean retval;
 
-       g_return_val_if_fail (self, -1);
-       g_return_val_if_fail (name, -1);
-       g_return_val_if_fail (key, -1);
+       g_return_val_if_fail (self, FALSE);
+       g_return_val_if_fail (name, FALSE);
+       g_return_val_if_fail (key, FALSE);
+
+       if (server_account)
+               keyname = get_server_account_keyname (name, key);
+       else
+               keyname = get_account_keyname (name, key);
 
-       keyname = get_account_keyname (name, key);
        priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
+
        retval = modest_conf_set_int (priv->modest_conf,keyname,val,err);
 
        g_free (keyname);
@@ -479,10 +579,30 @@ modest_account_mgr_set_account_int  (ModestAccountMgr *self, const gchar *name,
 
 
 
+gboolean
+modest_account_mgr_set_server_account_int (ModestAccountMgr *self, const gchar *name,
+                                          const gchar *key, int val,
+                                          GError **err)
+{
+       return set_account_int (self, name, key, val, TRUE, err);
+}
+
 
 gboolean
-modest_account_mgr_set_account_bool  (ModestAccountMgr *self, const gchar *name,
-                                     const gchar *key, gboolean val, GError **err)
+modest_account_mgr_set_account_int  (ModestAccountMgr *self, const gchar *name,
+                                    const gchar *key, int val,
+                                    GError **err)
+{
+       return set_account_int (self, name, key, val, FALSE, err);
+}
+
+
+
+
+static gboolean
+set_account_bool  (ModestAccountMgr *self, const gchar *name,
+                  const gchar *key, gboolean server_account, gboolean val,
+                  GError **err)
 {
        ModestAccountMgrPrivate *priv;
 
@@ -493,8 +613,13 @@ modest_account_mgr_set_account_bool  (ModestAccountMgr *self, const gchar *name,
        g_return_val_if_fail (name, FALSE);
        g_return_val_if_fail (key, FALSE);
 
-       keyname = get_account_keyname (name, key);
+       if (server_account)
+               keyname = get_server_account_keyname (name, key);
+       else
+               keyname = get_account_keyname (name, key);
+
        priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
+
        retval = modest_conf_set_bool (priv->modest_conf,keyname,val,err);
 
        g_free (keyname);
@@ -503,8 +628,30 @@ modest_account_mgr_set_account_bool  (ModestAccountMgr *self, const gchar *name,
 
 
 gboolean
-modest_account_mgr_account_exists (ModestAccountMgr *self, const gchar *name,
-                                  GError **err)
+modest_account_mgr_set_server_account_bool  (ModestAccountMgr *self, const gchar *name,
+                                            const gchar *key, gboolean val,
+                                            GError **err)
+{
+       return set_account_bool (self, name, key, val, TRUE, err);
+}
+
+
+
+gboolean
+modest_account_mgr_set_account_bool  (ModestAccountMgr *self, const gchar *name,
+                                       const gchar *key, gboolean val,
+                                       GError **err)
+{
+       return set_account_bool (self, name, key, val, FALSE, err);
+}
+
+
+
+
+
+gboolean
+account_exists (ModestAccountMgr *self, const gchar *name, gboolean server_account,
+               GError **err)
 {
        ModestAccountMgrPrivate *priv;
 
@@ -514,7 +661,10 @@ modest_account_mgr_account_exists (ModestAccountMgr *self, const gchar *name,
        g_return_val_if_fail (self, FALSE);
        g_return_val_if_fail (name, FALSE);
 
-       keyname = get_account_keyname (name, NULL);
+       if (server_account)
+               keyname = get_account_keyname (name, NULL);
+       else
+               keyname = get_server_account_keyname (name, NULL);
 
        priv = MODEST_ACCOUNT_MGR_GET_PRIVATE(self);
        retval = modest_conf_key_exists (priv->modest_conf,keyname,err);
@@ -524,6 +674,23 @@ modest_account_mgr_account_exists (ModestAccountMgr *self, const gchar *name,
 }
 
 
+gboolean
+modest_account_mgr_server_account_exists (ModestAccountMgr *self, const gchar *name,
+                                  GError **err)
+{
+       return account_exists (self, name, TRUE, err);
+}
+
+
+
+gboolean
+modest_account_mgr_account_exists (ModestAccountMgr *self, const gchar *name,
+                                  GError **err)
+{
+       return account_exists (self, name, FALSE, err);
+}
+
+
 
 /* must be freed by caller */
 static gchar*
@@ -531,10 +698,25 @@ get_account_keyname (const gchar *accname, const gchar *name)
 {
        if (name)
                return g_strconcat
-                       (accname, "/", name, NULL);
+                        (MODEST_ACCOUNT_NAMESPACE, "/",
+                         accname, "/", name, NULL);
        else
-               return g_strconcat
-                       /* SMF: I think, this has to be done somewhere else. For now it's a quick fix. */
-                       (MODEST_ACCOUNT_NAMESPACE, "/", accname, NULL);
+                return g_strconcat
+                        (MODEST_ACCOUNT_NAMESPACE, "/",
+                         accname, NULL);
 }
 
+
+/* must be freed by caller */
+static gchar*
+get_server_account_keyname (const gchar *accname, const gchar *name)
+{
+       if (name)
+               return g_strconcat
+                       (MODEST_SERVER_ACCOUNT_NAMESPACE, "/",
+                        accname, "/", name, NULL);
+       else
+               return g_strconcat
+                       (MODEST_SERVER_ACCOUNT_NAMESPACE, "/",
+                        accname, NULL);
+}