tny_header_set_from (TNY_HEADER (header), from);
tny_header_set_replyto (TNY_HEADER (header), from);
}
- if ((mailto != NULL) && (strlen(mailto) > 0))
- tny_header_set_to (TNY_HEADER (header), mailto);
+ if ((mailto != NULL) && (strlen(mailto) > 0)) {
+ gchar *removed_to = modest_text_utils_remove_duplicate_addresses (mailto);
+ tny_header_set_to (TNY_HEADER (header), removed_to);
+ g_free (removed_to);
+ }
if ((cc != NULL) && (strlen(cc) > 0))
tny_header_set_cc (TNY_HEADER (header), cc);
if ((bcc != NULL) && (strlen(bcc) > 0))
return new_msg;
}
+
+
+static gint
+count_addresses (const gchar* addresses)
+{
+ gint count = 1;
+
+ if (!addresses)
+ return 0;
+
+ while (*addresses) {
+ if (*addresses == ',' || *addresses == ';')
+ ++count;
+ ++addresses;
+ }
+
+ return count;
+}
+
+
/* get the new To:, based on the old header,
* result is newly allocated or NULL in case of error
* */
get_new_to (TnyMsg *msg, TnyHeader *header, const gchar* from,
ModestTnyMsgReplyMode reply_mode)
{
- const gchar* old_reply_to;
+ gchar* old_reply_to;
gchar* old_from;
gchar* new_to;
/* reply to sender, use ReplyTo or From */
- //old_reply_to = tny_header_get_replyto (header);
old_reply_to = modest_tny_mime_part_get_header_value (TNY_MIME_PART(msg),
"Reply-To");
old_from = tny_header_dup_from (header);
- if (!old_from && !old_reply_to) {
+ if (!old_from && !old_reply_to) {
g_warning ("%s: failed to get either Reply-To: or From: from header",
__FUNCTION__);
return NULL;
/* otherwise use either Reply-To: (preferred) or From: */
new_to = g_strdup (old_reply_to ? old_reply_to : old_from);
g_free (old_from);
+ g_free (old_reply_to);
/* in case of ReplyAll, we need to add the Recipients in the old To: */
if (reply_mode == MODEST_TNY_MSG_REPLY_MODE_ALL) {
/* remove duplicate entries */
gchar *tmp = modest_text_utils_remove_duplicate_addresses (new_to);
g_free (new_to);
- new_to = tmp;
+ new_to = tmp;
+
+ /* now, strip me (the new From:) from the new_to, but only if
+ * there are >1 addresses there */
+ if (count_addresses (new_to) > 1) {
+ gchar *tmp = modest_text_utils_remove_address (new_to, from);
+ g_free (new_to);
+ new_to = tmp;
+ }
}
return new_to;