* src/widgets/modest-recpt-editor.c:
[modest] / src / widgets / modest-folder-view.c
index 4a83066..7fe6dd9 100644 (file)
@@ -469,27 +469,18 @@ icon_cell_data  (GtkTreeViewColumn *column,  GtkCellRenderer *renderer,
        GObject *rendobj = NULL, *instance = NULL;
        GdkPixbuf *pixbuf = NULL;
        TnyFolderType type = TNY_FOLDER_TYPE_UNKNOWN;
-       gchar *fname = NULL;
        const gchar *account_id = NULL;
-       gint unread = 0;
        gboolean has_children;
        
        rendobj = G_OBJECT(renderer);
        gtk_tree_model_get (tree_model, iter,
                            TNY_GTK_FOLDER_STORE_TREE_MODEL_TYPE_COLUMN, &type,
-                           TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN, &fname,
-                           TNY_GTK_FOLDER_STORE_TREE_MODEL_UNREAD_COLUMN, &unread,
                            TNY_GTK_FOLDER_STORE_TREE_MODEL_INSTANCE_COLUMN, &instance,
                            -1);
        has_children = gtk_tree_model_iter_has_child (tree_model, iter);
 
-       if (!fname)
-               return;
-
-       if (!instance) {
-               g_free (fname);
+       if (!instance) 
                return;
-       }
 
        /* MERGE is not needed anymore as the folder now has the correct type jschmid */
        /* We include the MERGE type here because it's used to create
@@ -542,7 +533,6 @@ icon_cell_data  (GtkTreeViewColumn *column,  GtkCellRenderer *renderer,
        }
        
        g_object_unref (G_OBJECT (instance));
-       g_free (fname);
 
        /* Set pixbuf */
        g_object_set (rendobj, "pixbuf", pixbuf, NULL);
@@ -1436,6 +1426,22 @@ on_progress_changed (ModestMailOperation *mail_op,
        g_slice_free (DndHelper, helper);
 }
 
+
+/* get the folder for the row the treepath refers to. */
+/* folder must be unref'd */
+static TnyFolder*
+tree_path_to_folder (GtkTreeModel *model, GtkTreePath *path)
+{
+       GtkTreeIter iter;
+       TnyFolder *folder = NULL;
+       
+       if (gtk_tree_model_get_iter (model,&iter, path))
+               gtk_tree_model_get (model, &iter,
+                                   TNY_GTK_FOLDER_STORE_TREE_MODEL_INSTANCE_COLUMN, &folder,
+                                   -1);
+       return folder;
+}
+
 /*
  * This function is used by drag_data_received_cb to manage drag and
  * drop of a header, i.e, and drag from the header view to the folder
@@ -1451,13 +1457,13 @@ drag_and_drop_from_header_view (GtkTreeModel *source_model,
        TnyHeader *header = NULL;
        TnyFolder *folder = NULL;
        ModestMailOperation *mail_op = NULL;
-       GtkTreeIter source_iter, dest_iter;
+       GtkTreeIter source_iter;
 
        g_return_if_fail (GTK_IS_TREE_MODEL(source_model));
        g_return_if_fail (GTK_IS_TREE_MODEL(dest_model));
        g_return_if_fail (dest_row);
        g_return_if_fail (helper);
-       
+
        /* Get header */
        gtk_tree_model_get_iter (source_model, &source_iter, helper->source_row);
        gtk_tree_model_get (source_model, &source_iter, 
@@ -1469,15 +1475,16 @@ drag_and_drop_from_header_view (GtkTreeModel *source_model,
        }
        
        /* Get Folder */
-       gtk_tree_model_get_iter (dest_model, &dest_iter, dest_row);
-       gtk_tree_model_get (dest_model, &dest_iter, 
-                           TNY_GTK_FOLDER_STORE_TREE_MODEL_INSTANCE_COLUMN, 
-                           &folder, -1);
-
+       folder = tree_path_to_folder (dest_model, dest_row);
        if (!TNY_IS_FOLDER(folder)) {
                g_warning ("BUG: %s could not get a valid folder", __FUNCTION__);
                goto cleanup;
        }
+       if (modest_tny_folder_get_rules(folder) & MODEST_FOLDER_RULES_FOLDER_NON_WRITEABLE) {
+               g_debug ("folder rules: cannot write to that folder");
+               goto cleanup;
+       }
+       
 
        /* Transfer message */
        mail_op = modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_RECEIVE, 
@@ -1525,13 +1532,35 @@ drag_and_drop_from_folder_view (GtkTreeModel     *source_model,
        GtkTreeIter parent_iter, iter;
        TnyFolderStore *parent_folder = NULL;
        TnyFolder *folder = NULL;
+       gboolean forbidden = TRUE;
+
+       /* check the folder rules for the destination */
+       folder = tree_path_to_folder (dest_model, dest_row);
+       if (folder) {
+               ModestTnyFolderRules rules =
+                       modest_tny_folder_get_rules (folder);
+               forbidden = rules & MODEST_FOLDER_RULES_FOLDER_NON_WRITEABLE;
+               if (forbidden)
+                       g_debug ("folder rules: cannot write to that folder");
+               g_object_unref (folder);
+       }
+       
+       if (!forbidden) {
+               /* check the folder rules for the source */
+               folder = tree_path_to_folder (source_model, helper->source_row);
+               if (folder) {
+                       ModestTnyFolderRules rules =
+                               modest_tny_folder_get_rules (folder);
+                       forbidden = rules & MODEST_FOLDER_RULES_FOLDER_NON_MOVEABLE;
+                       if (forbidden)
+                               g_debug ("folder rules: cannot move that folder");
+                       g_object_unref (folder);
+               }
+       }
 
+       
        /* Check if the drag is possible */
-/*     if (!gtk_tree_path_compare (helper->source_row, dest_row) || */
-/*         !gtk_tree_drag_dest_row_drop_possible (GTK_TREE_DRAG_DEST (dest_model), */
-/*                                                dest_row, */
-/*                                                selection_data)) { */
-       if (!gtk_tree_path_compare (helper->source_row, dest_row)) {
+       if (forbidden || !gtk_tree_path_compare (helper->source_row, dest_row)) {
 
                gtk_drag_finish (helper->context, FALSE, FALSE, helper->time);
                gtk_tree_path_free (helper->source_row);        
@@ -2010,28 +2039,15 @@ find_inbox_iter (GtkTreeModel *model, GtkTreeIter *iter, GtkTreeIter *inbox_iter
        do {
                GtkTreeIter child;
                TnyFolderType type = TNY_FOLDER_TYPE_UNKNOWN;
-               gchar *name = NULL;
 
                gtk_tree_model_get (model, iter, 
-                                   TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN, &name,
                                    TNY_GTK_FOLDER_STORE_TREE_MODEL_TYPE_COLUMN, 
                                    &type, -1);
                        
                gboolean result = FALSE;
                if (type == TNY_FOLDER_TYPE_INBOX) {
                        result = TRUE;
-               } else if (type == TNY_FOLDER_TYPE_NORMAL) {
-                       /* tinymail's camel implementation only provides TNY_FOLDER_TYPE_NORMAL
-                        * when getting folders from the cache, before connectin, so we do 
-                        * an extra check. We could fix this in tinymail, but it's easier 
-                        * to do here.
-                        */
-                        if (strcmp (name, "Inbox") == 0)
-                               result = TRUE;
-               }
-               
-               g_free (name);
-               
+               }               
                if (result) {
                        *inbox_iter = *iter;
                        return TRUE;
@@ -2056,10 +2072,7 @@ modest_folder_view_select_first_inbox_or_local (ModestFolderView *self)
        GtkTreeModel *model;
        GtkTreeIter iter, inbox_iter;
        GtkTreeSelection *sel;
-
-/*     /\* Do not set it if the folder view was not painted *\/ */
-/*     if (!GTK_WIDGET_MAPPED (self)) */
-/*             return; */
+       GtkTreePath *path = NULL;
 
        model = gtk_tree_view_get_model (GTK_TREE_VIEW (self));
        if (!model)
@@ -2069,15 +2082,15 @@ modest_folder_view_select_first_inbox_or_local (ModestFolderView *self)
        sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (self));
 
        gtk_tree_model_get_iter_first (model, &iter);
-       gtk_tree_selection_unselect_all (sel);
 
-       if (find_inbox_iter (model, &iter, &inbox_iter)) {
-               gtk_tree_selection_select_iter (sel, &inbox_iter);
-       }
-       else {
-               gtk_tree_model_get_iter_first (model, &iter);
-               gtk_tree_selection_select_iter (sel, &iter);
-       }
+       if (find_inbox_iter (model, &iter, &inbox_iter))
+               path = gtk_tree_model_get_path (model, &inbox_iter);
+       else
+               path = gtk_tree_path_new_first ();
+
+       /* Select the row and free */
+       gtk_tree_view_set_cursor (GTK_TREE_VIEW (self), path, NULL, FALSE);
+       gtk_tree_path_free (path);
 }