X-Git-Url: http://git.maemo.org/git/?a=blobdiff_plain;f=deb-src%2Flibperl-critic-perl%2Flibperl-critic-perl-1.088%2Flib%2FPerl%2FCritic%2FPolicy%2FBuiltinFunctions%2FRequireGlobFunction.pm;fp=deb-src%2Flibperl-critic-perl%2Flibperl-critic-perl-1.088%2Flib%2FPerl%2FCritic%2FPolicy%2FBuiltinFunctions%2FRequireGlobFunction.pm;h=d5243af26b26dd35f91b4c8195ad8c809f16fef9;hb=9235c81891f90483b524a2ccb1f8c15689c8dfd3;hp=0000000000000000000000000000000000000000;hpb=3b84a260e354a1cd3480729daaedbeeab0eae136;p=pkg-perl diff --git a/deb-src/libperl-critic-perl/libperl-critic-perl-1.088/lib/Perl/Critic/Policy/BuiltinFunctions/RequireGlobFunction.pm b/deb-src/libperl-critic-perl/libperl-critic-perl-1.088/lib/Perl/Critic/Policy/BuiltinFunctions/RequireGlobFunction.pm new file mode 100644 index 0000000..d5243af --- /dev/null +++ b/deb-src/libperl-critic-perl/libperl-critic-perl-1.088/lib/Perl/Critic/Policy/BuiltinFunctions/RequireGlobFunction.pm @@ -0,0 +1,97 @@ +############################################################################## +# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/BuiltinFunctions/RequireGlobFunction.pm $ +# $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $ +# $Author: clonezone $ +# $Revision: 2489 $ +############################################################################## + +package Perl::Critic::Policy::BuiltinFunctions::RequireGlobFunction; + +use 5.006001; +use strict; +use warnings; +use Readonly; + +use Perl::Critic::Utils qw{ :severities }; +use base 'Perl::Critic::Policy'; + +our $VERSION = '1.088'; + +#----------------------------------------------------------------------------- + +Readonly::Scalar my $GLOB_RX => qr{ [*?] }mx; +Readonly::Scalar my $DESC => q{Glob written as <...>}; +Readonly::Scalar my $EXPL => [ 167 ]; + +#----------------------------------------------------------------------------- + +sub supported_parameters { return () } +sub default_severity { return $SEVERITY_HIGHEST } +sub default_themes { return qw( core pbp bugs ) } +sub applies_to { return 'PPI::Token::QuoteLike::Readline' } + +#----------------------------------------------------------------------------- + +sub violates { + my ( $self, $elem, undef ) = @_; + + if ( $elem =~ $GLOB_RX ) { + return $self->violation( $DESC, $EXPL, $elem ); + } + return; #ok! +} + +1; + +__END__ + +#----------------------------------------------------------------------------- + +=pod + +=head1 NAME + +Perl::Critic::Policy::BuiltinFunctions::RequireGlobFunction - Use C instead of <*>. + +=head1 AFFILIATION + +This Policy is part of the core L distribution. + + +=head1 DESCRIPTION + +Conway discourages the use of the C< <..> > construct for globbing, as +it is easily confused with the angle bracket file input operator. +Instead, he recommends the use of the C function as it makes +it much more obvious what you're attempting to do. + + @files = <*.pl>; # not ok + @files = glob( "*.pl" ); # ok + + +=head1 CONFIGURATION + +This Policy is not configurable except for the standard options. + + +=head1 AUTHOR + +Graham TerMarsch + +=head1 COPYRIGHT + +Copyright (C) 2005-2007 Graham TerMarsch. All rights reserved. + +This program is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. + +=cut + +# Local Variables: +# mode: cperl +# cperl-indent-level: 4 +# fill-column: 78 +# indent-tabs-mode: nil +# c-indentation-style: bsd +# End: +# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :