X-Git-Url: http://git.maemo.org/git/?a=blobdiff_plain;f=src%2Fhildon2%2Fmodest-header-window.c;h=9abe2b05e97a88df3b3adddd9997ac0af9f1d294;hb=c8865f8136111276c5f1f21819272c208ed97532;hp=5ed64c6ac17b99a6531dced7ae97ce90c8904458;hpb=8184189ac54be832c690375d5e780ca122da1e2c;p=modest diff --git a/src/hildon2/modest-header-window.c b/src/hildon2/modest-header-window.c index 5ed64c6..9abe2b0 100644 --- a/src/hildon2/modest-header-window.c +++ b/src/hildon2/modest-header-window.c @@ -77,8 +77,6 @@ struct _ModestHeaderWindowPrivate { /* state bar */ ContentsState contents_state; - TnyFolder *folder; - /* autoscroll */ gboolean autoscroll; @@ -89,6 +87,8 @@ struct _ModestHeaderWindowPrivate { /* signals */ GSList *sighandlers; gulong queue_change_handler; + gulong sort_column_handler; + gulong notify_model; /* progress hint */ gboolean progress_hint; @@ -101,6 +101,9 @@ struct _ModestHeaderWindowPrivate { GtkWidget *csm_menu; gdouble x_coord; gdouble y_coord; + + /* weak refs */ + GtkTreeModel *model_weak_ref; }; #define MODEST_HEADER_WINDOW_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE((o), \ MODEST_TYPE_HEADER_WINDOW, \ @@ -170,6 +173,11 @@ static void on_horizontal_movement (HildonPannableArea *hildonpannable, gdouble initial_x, gdouble initial_y, gpointer user_data); +static void on_header_view_model_destroyed (gpointer user_data, + GObject *model); +static gboolean on_key_press(GtkWidget *widget, + GdkEventKey *event, + gpointer user_data); /* globals */ static GtkWindowClass *parent_class = NULL; @@ -238,17 +246,19 @@ modest_header_window_init (ModestHeaderWindow *obj) priv->top_vbox = NULL; priv->contents_view = NULL; priv->contents_state = CONTENTS_STATE_NONE; - priv->folder = NULL; priv->updating_banner = NULL; priv->updating_banner_timeout = 0; priv->autoscroll = TRUE; priv->progress_hint = FALSE; priv->queue_change_handler = 0; + priv->sort_column_handler = 0; + priv->model_weak_ref = NULL; priv->current_store_account = NULL; priv->sort_button = NULL; priv->new_message_button = NULL; priv->x_coord = 0; priv->y_coord = 0; + priv->notify_model = 0; modest_window_mgr_register_help_id (modest_runtime_get_window_mgr(), GTK_WINDOW(obj), @@ -259,13 +269,30 @@ static void modest_header_window_finalize (GObject *obj) { ModestHeaderWindowPrivate *priv; + TnyFolder *folder; priv = MODEST_HEADER_WINDOW_GET_PRIVATE(obj); - tny_folder_sync_async (TNY_FOLDER (priv->folder), - FALSE, NULL, NULL, NULL); + if (priv->model_weak_ref) { + g_object_weak_unref ((GObject *) priv->model_weak_ref, + on_header_view_model_destroyed, + obj); + if (g_signal_handler_is_connected (G_OBJECT (priv->model_weak_ref), + priv->sort_column_handler)) { + g_signal_handler_disconnect (G_OBJECT (priv->model_weak_ref), + priv->sort_column_handler); + } + on_header_view_model_destroyed (obj, (GObject *) priv->model_weak_ref); + } + + folder = modest_header_view_get_folder ((ModestHeaderView *) priv->header_view); + if (folder) { + tny_folder_sync_async (folder, FALSE, NULL, NULL, NULL); + g_object_unref (folder); + } + + modest_header_window_disconnect_signals (MODEST_WINDOW (obj)); - g_object_unref (priv->folder); g_object_unref (priv->header_view); g_object_unref (priv->empty_view); @@ -274,10 +301,6 @@ modest_header_window_finalize (GObject *obj) priv->current_store_account = NULL; } - /* Sanity check: shouldn't be needed, the window mgr should - call this function before */ - modest_header_window_disconnect_signals (MODEST_WINDOW (obj)); - if (priv->updating_banner_timeout > 0) { g_source_remove (priv->updating_banner_timeout); priv->updating_banner_timeout = 0; @@ -294,12 +317,34 @@ static void modest_header_window_disconnect_signals (ModestWindow *self) { ModestHeaderWindowPrivate *priv; + priv = MODEST_HEADER_WINDOW_GET_PRIVATE(self); + if (g_signal_handler_is_connected ((GObject*) priv->header_view, priv->notify_model)) { + g_signal_handler_disconnect ((GObject*) priv->header_view, priv->notify_model); + priv->notify_model = 0; + } + if (g_signal_handler_is_connected (G_OBJECT (modest_runtime_get_mail_operation_queue ()), - priv->queue_change_handler)) + priv->queue_change_handler)) { g_signal_handler_disconnect (G_OBJECT (modest_runtime_get_mail_operation_queue ()), priv->queue_change_handler); + priv->queue_change_handler = 0; + } + + if (priv->header_view) { + GtkTreeModel *sortable; + + sortable = gtk_tree_view_get_model (GTK_TREE_VIEW (priv->header_view)); + if (sortable) { + if (g_signal_handler_is_connected (G_OBJECT (sortable), + priv->sort_column_handler)) { + g_signal_handler_disconnect (G_OBJECT (sortable), + priv->sort_column_handler); + priv->sort_column_handler = 0; + } + } + } modest_signal_mgr_disconnect_all_and_destroy (priv->sighandlers); priv->sighandlers = NULL; @@ -308,11 +353,8 @@ modest_header_window_disconnect_signals (ModestWindow *self) static void connect_signals (ModestHeaderWindow *self) -{ - ModestHeaderWindowPrivate *priv; - GtkTreeSortable *sortable; - - priv = MODEST_HEADER_WINDOW_GET_PRIVATE(self); +{ + ModestHeaderWindowPrivate *priv = MODEST_HEADER_WINDOW_GET_PRIVATE(self); /* header view */ @@ -337,15 +379,6 @@ connect_signals (ModestHeaderWindow *self) G_CALLBACK (on_expose_event), self); - sortable = GTK_TREE_SORTABLE (gtk_tree_view_get_model (GTK_TREE_VIEW (priv->header_view))); - - priv->sighandlers = - modest_signal_mgr_connect (priv->sighandlers, - G_OBJECT (sortable), - "sort-column-changed", - G_CALLBACK (on_sort_column_changed), - self); - priv->sighandlers = modest_signal_mgr_connect (priv->sighandlers, G_OBJECT (self), @@ -381,6 +414,10 @@ connect_signals (ModestHeaderWindow *self) G_CALLBACK (on_horizontal_movement), self); } + + + g_signal_connect(G_OBJECT(self), "key-press-event", + G_CALLBACK(on_key_press), self); } static void @@ -493,12 +530,90 @@ static void on_mark_read_csm_activated (GtkMenuItem *item, gpointer user_data) { + TnyHeader *header; + ModestHeaderWindow *self; + ModestHeaderWindowPrivate *priv; + + self = (ModestHeaderWindow *) user_data; + priv = MODEST_HEADER_WINDOW_GET_PRIVATE (self); + + header = modest_header_view_get_header_at_pos ((ModestHeaderView *) priv->header_view, + priv->x_coord, priv->y_coord); + + if (header) { + tny_header_set_flag (header, TNY_HEADER_FLAG_SEEN); + g_object_unref (header); + } } static void on_mark_unread_csm_activated (GtkMenuItem *item, gpointer user_data) { + TnyHeader *header; + ModestHeaderWindow *self; + ModestHeaderWindowPrivate *priv; + + self = (ModestHeaderWindow *) user_data; + priv = MODEST_HEADER_WINDOW_GET_PRIVATE (self); + + header = modest_header_view_get_header_at_pos ((ModestHeaderView *) priv->header_view, + priv->x_coord, priv->y_coord); + + if (header) { + tny_header_unset_flag (header, TNY_HEADER_FLAG_SEEN); + g_object_unref (header); + } +} + +static void +on_header_view_model_destroyed (gpointer user_data, + GObject *model) +{ + ModestHeaderWindow *self; + ModestHeaderWindowPrivate *priv; + + self = (ModestHeaderWindow *) user_data; + if (!GTK_IS_WIDGET (self)) + return; + + priv = MODEST_HEADER_WINDOW_GET_PRIVATE (self); + priv->model_weak_ref = NULL; + + priv->sort_column_handler = 0; +} + +static void +on_header_view_model_changed (GObject *gobject, + GParamSpec *arg1, + gpointer user_data) +{ + ModestHeaderWindow *self = (ModestHeaderWindow *) user_data; + ModestHeaderWindowPrivate *priv = MODEST_HEADER_WINDOW_GET_PRIVATE (self); + GtkTreeModel *model = gtk_tree_view_get_model (GTK_TREE_VIEW (gobject)); + + if (priv->model_weak_ref ) { + g_object_weak_unref ((GObject *) priv->model_weak_ref, + on_header_view_model_destroyed, + self); + if (g_signal_handler_is_connected (G_OBJECT (priv->model_weak_ref), + priv->sort_column_handler)) { + g_signal_handler_disconnect (G_OBJECT (priv->model_weak_ref), + priv->sort_column_handler); + } + on_header_view_model_destroyed (self, (GObject *) priv->model_weak_ref); + } + + if (!model) + return; + + /* Connect the signal. Listen to object destruction to disconnect it */ + priv->sort_column_handler = g_signal_connect ((GObject *) model, + "sort-column-changed", + G_CALLBACK (on_sort_column_changed), + self); + priv->model_weak_ref = model; + g_object_weak_ref ((GObject *) model, on_header_view_model_destroyed, self); } static GtkWidget * @@ -509,6 +624,10 @@ create_header_view (ModestWindow *self, TnyFolder *folder) ModestHeaderWindowPrivate *priv; header_view = modest_header_view_new (NULL, MODEST_HEADER_VIEW_STYLE_TWOLINES); + priv = MODEST_HEADER_WINDOW_GET_PRIVATE (self); + priv->notify_model = g_signal_connect ((GObject*) header_view, "notify::model", + G_CALLBACK (on_header_view_model_changed), self); + modest_header_view_set_folder (MODEST_HEADER_VIEW (header_view), folder, TRUE, self, folder_refreshed_cb, self); modest_header_view_set_filter (MODEST_HEADER_VIEW (header_view), @@ -517,7 +636,6 @@ create_header_view (ModestWindow *self, TnyFolder *folder) MODEST_CONF_HEADER_VIEW_KEY); /* Create CSM menu */ - priv = MODEST_HEADER_WINDOW_GET_PRIVATE (self); priv->csm_menu = gtk_menu_new (); delete_item = gtk_menu_item_new_with_label (_HL("wdgt_bd_delete")); mark_read_item = gtk_menu_item_new_with_label (_("mcen_me_inbox_mark_as_read")); @@ -525,6 +643,9 @@ create_header_view (ModestWindow *self, TnyFolder *folder) gtk_menu_shell_append (GTK_MENU_SHELL (priv->csm_menu), delete_item); gtk_menu_shell_append (GTK_MENU_SHELL (priv->csm_menu), mark_read_item); gtk_menu_shell_append (GTK_MENU_SHELL (priv->csm_menu), mark_unread_item); + hildon_gtk_widget_set_theme_size (delete_item, MODEST_EDITABLE_SIZE); + hildon_gtk_widget_set_theme_size (mark_unread_item, MODEST_EDITABLE_SIZE); + hildon_gtk_widget_set_theme_size (mark_read_item, MODEST_EDITABLE_SIZE); gtk_widget_show_all (priv->csm_menu); /* Connect signals */ @@ -619,12 +740,10 @@ modest_header_window_new (TnyFolder *folder, const gchar *account_name, const gc self = MODEST_HEADER_WINDOW(g_object_new(MODEST_TYPE_HEADER_WINDOW, NULL)); priv = MODEST_HEADER_WINDOW_GET_PRIVATE(self); - priv->folder = g_object_ref (folder); - priv->contents_view = hildon_pannable_area_new (); alignment = gtk_alignment_new (0.0, 0.0, 1.0, 1.0); gtk_alignment_set_padding (GTK_ALIGNMENT (alignment), - 0, 0, + HILDON_MARGIN_HALF, 0, HILDON_MARGIN_DOUBLE, HILDON_MARGIN_DOUBLE); /* We need to do this here to properly listen for mail @@ -777,7 +896,12 @@ static void setup_menu (ModestHeaderWindow *self) modest_hildon2_window_add_to_menu (MODEST_HILDON2_WINDOW (self), _("mcen_me_new_message"), "n", APP_MENU_CALLBACK (modest_ui_actions_on_new_msg), MODEST_DIMMING_CALLBACK (modest_ui_dimming_rules_on_new_msg)); - modest_hildon2_window_add_to_menu (MODEST_HILDON2_WINDOW (self), _("mcen_me_move_messages"), NULL, + modest_hildon2_window_add_to_menu (MODEST_HILDON2_WINDOW (self), + dngettext(GETTEXT_PACKAGE, + "mcen_me_move_message", + "mcen_me_move_messages", + 2), + NULL, APP_MENU_CALLBACK (set_moveto_edit_mode), MODEST_DIMMING_CALLBACK (modest_ui_dimming_rules_on_move_to)); modest_hildon2_window_add_to_menu (MODEST_HILDON2_WINDOW (self), _("mcen_me_delete_messages"), NULL, @@ -789,8 +913,8 @@ static void setup_menu (ModestHeaderWindow *self) priv->sort_button = hildon_button_new (MODEST_EDITABLE_SIZE, HILDON_BUTTON_ARRANGEMENT_VERTICAL); hildon_button_set_title (HILDON_BUTTON (priv->sort_button), _("mcen_me_sort")); - g_signal_connect (G_OBJECT (priv->sort_button), "clicked", - G_CALLBACK (modest_ui_actions_on_sort), (gpointer) self); + g_signal_connect_after (G_OBJECT (priv->sort_button), "clicked", + G_CALLBACK (modest_ui_actions_on_sort), (gpointer) self); hildon_button_set_style(HILDON_BUTTON (priv->sort_button), HILDON_BUTTON_STYLE_PICKER); hildon_button_set_title_alignment (HILDON_BUTTON (priv->sort_button), 0.5, 0.5); hildon_button_set_value_alignment (HILDON_BUTTON (priv->sort_button), 0.5, 0.5); @@ -812,10 +936,14 @@ update_view (ModestHeaderWindow *self, gboolean refilter = FALSE; gboolean folder_empty = FALSE; gboolean all_marked_as_deleted = FALSE; + TnyFolder *folder; g_return_if_fail (MODEST_IS_HEADER_WINDOW(self)); priv = MODEST_HEADER_WINDOW_GET_PRIVATE (self); - g_return_if_fail (priv->folder); + + folder = modest_header_view_get_folder ((ModestHeaderView *) priv->header_view); + if (!folder) + return; if (change != NULL) { TnyFolderChangeChanged changed; @@ -825,13 +953,14 @@ update_view (ModestHeaderWindow *self, if ((changed) & TNY_FOLDER_CHANGE_CHANGED_ALL_COUNT) folder_empty = (((guint) tny_folder_change_get_new_all_count (change)) == 0); else - folder_empty = (((guint) tny_folder_get_all_count (TNY_FOLDER (priv->folder))) == 0); + folder_empty = (((guint) tny_folder_get_all_count (folder)) == 0); if ((changed) & TNY_FOLDER_CHANGE_CHANGED_EXPUNGED_HEADERS) refilter = TRUE; } else { - folder_empty = (((guint) tny_folder_get_all_count (TNY_FOLDER (priv->folder))) == 0); + folder_empty = (((guint) tny_folder_get_all_count (folder)) == 0); } + g_object_unref (folder); /* Check if all messages are marked to be deleted */ all_marked_as_deleted = modest_header_view_is_empty (MODEST_HEADER_VIEW (priv->header_view)); @@ -1251,6 +1380,12 @@ update_sort_button (ModestHeaderWindow *self) const gchar *value = NULL; priv = MODEST_HEADER_WINDOW_GET_PRIVATE (self); + + /* This could happen as the first time the model is set the + header_view is still not assigned to priv->header_view */ + if (!priv->header_view) + return; + sortable = GTK_TREE_SORTABLE (gtk_tree_view_get_model (GTK_TREE_VIEW (priv->header_view))); if (!gtk_tree_sortable_get_sort_column_id (sortable, @@ -1340,3 +1475,35 @@ on_horizontal_movement (HildonPannableArea *hildonpannable, g_object_unref (header); } } + + +static gboolean +on_key_press(GtkWidget *widget, GdkEventKey *event, gpointer user_data) +{ + ModestHeaderWindowPrivate *priv; + HildonPannableArea *pannable; + /* FIXME: set scroll_speed depends on for how long the key was pressed */ + gint scroll_speed = 3; + + if (event->type == GDK_KEY_RELEASE) + return FALSE; + + priv = MODEST_HEADER_WINDOW_GET_PRIVATE(user_data); + + pannable = HILDON_PANNABLE_AREA (priv->contents_view); + + switch (event->keyval) { + + case GDK_Up: + priv->autoscroll = FALSE; + modest_maemo_utils_scroll_pannable(pannable, 0, -scroll_speed); + break; + + case GDK_Down: + priv->autoscroll = FALSE; + modest_maemo_utils_scroll_pannable(pannable, 0, scroll_speed); + break; + } + + return FALSE; +}