X-Git-Url: http://git.maemo.org/git/?a=blobdiff_plain;f=src%2Fmodest-mail-operation.c;h=e4bd9c6f64bbccc754687dd1d0cd08a7a181cbeb;hb=2a9c49313371c158d63b872d7b9576c1130e791a;hp=7691b5f7422fce80101b0aaa2be1e52b02842a57;hpb=6d468b7495df51350ddbcca3b6cdf3b1a70dc24a;p=modest diff --git a/src/modest-mail-operation.c b/src/modest-mail-operation.c index 7691b5f..e4bd9c6 100644 --- a/src/modest-mail-operation.c +++ b/src/modest-mail-operation.c @@ -41,6 +41,7 @@ #include #include #include +#include #include #include #include @@ -107,6 +108,18 @@ static void sync_folder_finish_callback (TnyFolder *self, static gboolean _check_memory_low (ModestMailOperation *mail_op); + +typedef struct { + ModestTnySendQueue *queue; + ModestMailOperation *self; + guint error_handler; + guint start_handler; + guint stop_handler; +} RunQueueHelper; + +static void run_queue_notify_and_destroy (RunQueueHelper *helper, + ModestMailOperationStatus status); + /* Helpers for the update account operation (send & receive)*/ typedef struct { @@ -601,11 +614,6 @@ modest_mail_operation_clone_state (ModestMailOperation *self) ModestMailOperationState *state; ModestMailOperationPrivate *priv; - /* FIXME: this should be fixed properly - * - * in some cases, priv was NULL, so checking here to - * make sure. - */ g_return_val_if_fail (self, NULL); priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self); g_return_val_if_fail (priv, NULL); @@ -630,17 +638,24 @@ modest_mail_operation_clone_state (ModestMailOperation *self) /* ************************** SEND ACTIONS ************************* */ /* ******************************************************************* */ +typedef struct +{ + ModestMailOperation *mail_op; + gboolean notify; +} SendNewMailHelper; + static void -send_mail_on_added_to_outbox (TnySendQueue *send_queue, - gboolean cancelled, - TnyMsg *msg, - GError *err, - gpointer user_data) +send_mail_on_sync_async_cb (TnyFolder *folder, + gboolean cancelled, + GError *err, + gpointer user_data) { ModestMailOperationPrivate *priv; ModestMailOperation *self; + SendNewMailHelper *helper; - self = MODEST_MAIL_OPERATION (user_data); + helper = (SendNewMailHelper *) user_data; + self = helper->mail_op; priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self); if (cancelled || err) @@ -654,53 +669,132 @@ send_mail_on_added_to_outbox (TnySendQueue *send_queue, } else { priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS; } + end: - modest_mail_operation_notify_end (self); - g_object_unref (self); + if (helper->notify) + modest_mail_operation_notify_end (self); + + g_object_unref (helper->mail_op); + g_slice_free (SendNewMailHelper, helper); } -void -modest_mail_operation_send_mail (ModestMailOperation *self, - TnyTransportAccount *transport_account, - TnyMsg* msg) +static void +run_queue_start (TnySendQueue *self, + gpointer user_data) { - TnySendQueue *send_queue = NULL; + RunQueueHelper *helper = (RunQueueHelper *) user_data; + ModestMailOperation *mail_op; + + g_debug ("%s sending queue successfully started", __FUNCTION__); + + /* Wait for the message to be sent */ + mail_op = modest_mail_operation_new (NULL); + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), + mail_op); + modest_mail_operation_run_queue (mail_op, helper->queue); + g_object_unref (mail_op); + + /* Free the helper and end operation */ + run_queue_notify_and_destroy (helper, MODEST_MAIL_OPERATION_STATUS_SUCCESS); +} + +static void +run_queue_error_happened (TnySendQueue *queue, + TnyHeader *header, + TnyMsg *msg, + GError *error, + gpointer user_data) +{ + RunQueueHelper *helper = (RunQueueHelper *) user_data; ModestMailOperationPrivate *priv; - - g_return_if_fail (self && MODEST_IS_MAIL_OPERATION (self)); - g_return_if_fail (transport_account && TNY_IS_TRANSPORT_ACCOUNT (transport_account)); - g_return_if_fail (msg && TNY_IS_MSG (msg)); - - priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self); - /* Get account and set it into mail_operation */ - priv->account = g_object_ref (transport_account); - priv->op_type = MODEST_MAIL_OPERATION_TYPE_SEND; - priv->done = 1; - priv->total = 1; + /* If we are here this means that the send queue could not + start to send emails. Shouldn't happen as this means that + we could not create the thread */ + g_debug ("%s sending queue failed to create the thread", __FUNCTION__); - send_queue = TNY_SEND_QUEUE (modest_runtime_get_send_queue (transport_account, TRUE)); - if (!TNY_IS_SEND_QUEUE(send_queue)) { - if (priv->error) { - g_error_free (priv->error); - priv->error = NULL; - } + priv = MODEST_MAIL_OPERATION_GET_PRIVATE (helper->self); + priv->error = g_error_copy ((const GError *) error); + + if (error->code != TNY_SYSTEM_ERROR_UNKNOWN) { + /* This code is here for safety reasons. It should + never be called, because that would mean that we + are not controlling some error case */ + g_warning ("%s Error %s should not happen", + __FUNCTION__, error->message); + } + + /* Free helper and end operation */ + run_queue_notify_and_destroy (helper, MODEST_MAIL_OPERATION_STATUS_FAILED); +} + +static void +send_mail_on_added_to_outbox (TnySendQueue *send_queue, + gboolean cancelled, + TnyMsg *msg, + GError *err, + gpointer user_data) +{ + ModestMailOperationPrivate *priv; + ModestMailOperation *self; + SendNewMailHelper *helper; + + helper = (SendNewMailHelper *) user_data; + self = helper->mail_op; + priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self); + + if (cancelled || err) + goto end; + + if (err) { g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR, - MODEST_MAIL_OPERATION_ERROR_ITEM_NOT_FOUND, - "modest: could not find send queue for account\n"); - priv->status = MODEST_MAIL_OPERATION_STATUS_FAILED; - modest_mail_operation_notify_end (self); + MODEST_MAIL_OPERATION_ERROR_SEND_QUEUE_ADD_ERROR, + "Error adding a msg to the send queue\n"); + priv->status = MODEST_MAIL_OPERATION_STATUS_FINISHED_WITH_ERRORS; } else { - modest_mail_operation_notify_start (self); - /* Add the msg to the queue. The callback will - finalize the mail operation */ - tny_send_queue_add_async (send_queue, msg, send_mail_on_added_to_outbox, - NULL, g_object_ref (self)); - modest_tny_send_queue_set_requested_send_receive (MODEST_TNY_SEND_QUEUE (send_queue), - FALSE); + priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS; + } + + end: + if (helper->notify) { + TnyTransportAccount *trans_account; + ModestTnySendQueue *queue; + + trans_account = (TnyTransportAccount *) modest_mail_operation_get_account (self); + queue = modest_runtime_get_send_queue (trans_account, TRUE); + if (queue) { + RunQueueHelper *helper; + + /* Create the helper */ + helper = g_slice_new0 (RunQueueHelper); + helper->queue = g_object_ref (queue); + helper->self = g_object_ref (self); + + /* if sending is ongoing wait for the queue to + stop. Otherwise wait for the queue-start + signal. It could happen that the queue + could not start, then check also the error + happened signal */ + if (modest_tny_send_queue_sending_in_progress (queue)) { + run_queue_start (TNY_SEND_QUEUE (queue), helper); + } else { + helper->start_handler = g_signal_connect (queue, "queue-start", + G_CALLBACK (run_queue_start), + helper); + helper->error_handler = g_signal_connect (queue, "error-happened", + G_CALLBACK (run_queue_error_happened), + helper); + } + } else { + /* Finalize this mail operation */ + modest_mail_operation_notify_end (self); + } + g_object_unref (trans_account); } -} + g_object_unref (helper->mail_op); + g_slice_free (SendNewMailHelper, helper); +} static gboolean idle_create_msg_cb (gpointer idle_data) @@ -843,6 +937,7 @@ modest_mail_operation_send_new_mail_cb (ModestMailOperation *self, TnyMsg *msg, gpointer userdata) { + TnySendQueue *send_queue = NULL; ModestMailOperationPrivate *priv = NULL; SendNewMailInfo *info = (SendNewMailInfo *) userdata; TnyFolder *draft_folder = NULL; @@ -863,8 +958,31 @@ modest_mail_operation_send_new_mail_cb (ModestMailOperation *self, goto end; } - /* Call mail operation */ - modest_mail_operation_send_mail (self, info->transport_account, msg); + /* Add message to send queue */ + send_queue = TNY_SEND_QUEUE (modest_runtime_get_send_queue (info->transport_account, TRUE)); + if (!TNY_IS_SEND_QUEUE(send_queue)) { + if (priv->error) { + g_error_free (priv->error); + priv->error = NULL; + } + g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR, + MODEST_MAIL_OPERATION_ERROR_ITEM_NOT_FOUND, + "modest: could not find send queue for account\n"); + priv->status = MODEST_MAIL_OPERATION_STATUS_FAILED; + modest_mail_operation_notify_end (self); + goto end; + } else { + SendNewMailHelper *helper = g_slice_new (SendNewMailHelper); + helper->mail_op = g_object_ref (self); + helper->notify = (info->draft_msg == NULL); + + /* Add the msg to the queue. The callback will free + the helper */ + modest_tny_send_queue_set_requested_send_receive (MODEST_TNY_SEND_QUEUE (send_queue), + FALSE); + tny_send_queue_add_async (send_queue, msg, send_mail_on_added_to_outbox, + NULL, helper); + } if (info->draft_msg != NULL) { TnyList *tmp_headers = NULL; @@ -872,6 +990,7 @@ modest_mail_operation_send_new_mail_cb (ModestMailOperation *self, TnyFolder *src_folder = NULL; TnyFolderType folder_type; TnyTransportAccount *transport_account = NULL; + SendNewMailHelper *helper = NULL; /* To remove the old mail from its source folder, we need to get the * transport account of the original draft message (the transport account @@ -890,16 +1009,21 @@ modest_mail_operation_send_new_mail_cb (ModestMailOperation *self, if (!draft_folder) { g_warning ("%s: modest_tny_account_get_special_folder(..) returned a NULL drafts folder", __FUNCTION__); + modest_mail_operation_notify_end (self); goto end; } if (!outbox_folder) { g_warning ("%s: modest_tny_account_get_special_folder(..) returned a NULL outbox folder", __FUNCTION__); + modest_mail_operation_notify_end (self); goto end; } folder = tny_msg_get_folder (info->draft_msg); - if (folder == NULL) goto end; + if (folder == NULL) { + modest_mail_operation_notify_end (self); + goto end; + } folder_type = modest_tny_folder_guess_folder_type (folder); if (folder_type == TNY_FOLDER_TYPE_INVALID) @@ -912,12 +1036,16 @@ modest_mail_operation_send_new_mail_cb (ModestMailOperation *self, /* Note: This can fail (with a warning) if the message is not really already in a folder, * because this function requires it to have a UID. */ + helper = g_slice_new (SendNewMailHelper); + helper->mail_op = g_object_ref (self); + helper->notify = TRUE; + tmp_headers = tny_simple_list_new (); tny_list_append (tmp_headers, (GObject*) header); tny_folder_remove_msgs_async (src_folder, tmp_headers, NULL, NULL, NULL); g_object_unref (tmp_headers); - tny_folder_sync_async (src_folder, TRUE, NULL, NULL, NULL); /* expunge */ - + tny_folder_sync_async (src_folder, TRUE, send_mail_on_sync_async_cb, + NULL, helper); g_object_unref (folder); } @@ -957,7 +1085,9 @@ modest_mail_operation_send_new_mail (ModestMailOperation *self, priv->op_type = MODEST_MAIL_OPERATION_TYPE_SEND; priv->account = TNY_ACCOUNT (g_object_ref (transport_account)); priv->status = MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS; - + + modest_mail_operation_notify_start (self); + /* Check parametters */ if (to == NULL) { /* Set status failed and set an error */ @@ -965,6 +1095,7 @@ modest_mail_operation_send_new_mail (ModestMailOperation *self, g_set_error (&(priv->error), MODEST_MAIL_OPERATION_ERROR, MODEST_MAIL_OPERATION_ERROR_BAD_PARAMETER, _("Error trying to send a mail. You need to set at least one recipient")); + modest_mail_operation_notify_end (self); return; } info = g_slice_new0 (SendNewMailInfo); @@ -976,7 +1107,6 @@ modest_mail_operation_send_new_mail (ModestMailOperation *self, g_object_ref (draft_msg); - modest_mail_operation_notify_start (self); modest_mail_operation_create_msg (self, from, to, cc, bcc, subject, plain_body, html_body, attachments_list, images_list, priority_flags, modest_mail_operation_send_new_mail_cb, info); @@ -1021,12 +1151,14 @@ modest_mail_operation_save_to_drafts_add_msg_cb(TnyFolder *self, TnyHeader *header = tny_msg_get_header (info->draft_msg); TnyFolder *src_folder = tny_header_get_folder (header); + g_debug ("--- REMOVE AND SYNC"); /* Remove the old draft */ tny_folder_remove_msg (src_folder, header, NULL); /* Synchronize to expunge and to update the msg counts */ tny_folder_sync_async (info->drafts, TRUE, NULL, NULL, NULL); tny_folder_sync_async (src_folder, TRUE, NULL, NULL, NULL); + g_debug ("--- REMOVED - SYNCED"); g_object_unref (G_OBJECT(header)); g_object_unref (G_OBJECT(src_folder)); @@ -1158,6 +1290,7 @@ modest_mail_operation_save_to_drafts (ModestMailOperation *self, info->callback = callback; info->user_data = user_data; + g_debug ("--- CREATE MESSAGE"); modest_mail_operation_notify_start (self); modest_mail_operation_create_msg (self, from, to, cc, bcc, subject, plain_body, html_body, attachments_list, images_list, priority_flags, @@ -1269,10 +1402,17 @@ static void update_account_send_mail (UpdateAccountInfo *info) { TnyTransportAccount *transport_account = NULL; + ModestTnyAccountStore *account_store; + + account_store = modest_runtime_get_account_store (); + + /* We don't try to send messages while sending mails is blocked */ + if (modest_tny_account_store_is_send_mail_blocked (account_store)) + return; /* Get the transport account */ transport_account = (TnyTransportAccount *) - modest_tny_account_store_get_transport_account_for_open_connection (modest_runtime_get_account_store(), + modest_tny_account_store_get_transport_account_for_open_connection (account_store, info->account_name); if (transport_account) { @@ -1630,7 +1770,7 @@ recurse_folders_async_cb (TnyFolderStore *folder_store, /* Add pending call */ info->pending_calls++; - tny_folder_store_get_folders_async (folder, folders, NULL, + tny_folder_store_get_folders_async (folder, folders, NULL, FALSE, recurse_folders_async_cb, NULL, info); g_object_unref (folders); @@ -1781,7 +1921,7 @@ modest_mail_operation_update_account (ModestMailOperation *self, /* Get all folders and continue in the callback */ folders = tny_simple_list_new (); tny_folder_store_get_folders_async (TNY_FOLDER_STORE (priv->account), - folders, NULL, + folders, NULL, FALSE, recurse_folders_async_cb, NULL, info); g_object_unref (folders); @@ -2601,14 +2741,15 @@ remove_msgs_async_cb (TnyFolder *folder, { gboolean expunge, leave_on_server; const gchar *account_name; - const gchar *proto; TnyAccount *account; - ModestTransportStoreProtocol account_proto = MODEST_PROTOCOL_TRANSPORT_STORE_UNKNOWN; + ModestProtocolType account_proto = MODEST_PROTOCOL_REGISTRY_TYPE_INVALID; ModestMailOperation *self; ModestMailOperationPrivate *priv; + ModestProtocolRegistry *protocol_registry; self = (ModestMailOperation *) user_data; priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self); + protocol_registry = modest_runtime_get_protocol_registry (); if (canceled || err) { /* If canceled by the user, ignore the error given by Tinymail */ @@ -2630,14 +2771,11 @@ remove_msgs_async_cb (TnyFolder *folder, leave_on_server = modest_account_mgr_get_leave_on_server (modest_runtime_get_account_mgr (), account_name); - proto = tny_account_get_proto (account); + account_proto = modest_tny_account_get_protocol_type (account); g_object_unref (account); - - if (proto) - account_proto = modest_protocol_info_get_transport_store_protocol (proto); - if (((account_proto == MODEST_PROTOCOL_STORE_POP) && !leave_on_server) || - modest_tny_folder_is_remote_folder (folder) == FALSE) + if (( (modest_protocol_registry_protocol_type_has_leave_on_server (protocol_registry, account_proto) && !leave_on_server) || + modest_tny_folder_is_remote_folder (folder) == FALSE)) expunge = TRUE; else expunge = FALSE; @@ -2754,9 +2892,6 @@ notify_progress_of_multiple_messages (ModestMailOperation *self, /* We know that tinymail sends us information about * transferred bytes with this particular message - * - * (FIXME: this is very ugly, and no I (djcb) didn't write this code, - * I just added the 'if' so we don't get runtime warning) */ if (status->message) is_num_bytes = (g_ascii_strcasecmp (status->message, "Retrieving message") == 0); @@ -2944,12 +3079,16 @@ modest_mail_operation_xfer_msgs (ModestMailOperation *self, TnyAccount *dst_account = NULL; gboolean leave_on_server; ModestMailOperationState *state; + ModestProtocolRegistry *protocol_registry; + ModestProtocolType account_protocol; g_return_if_fail (self && MODEST_IS_MAIL_OPERATION (self)); g_return_if_fail (headers && TNY_IS_LIST (headers)); g_return_if_fail (folder && TNY_IS_FOLDER (folder)); priv = MODEST_MAIL_OPERATION_GET_PRIVATE(self); + protocol_registry = modest_runtime_get_protocol_registry (); + priv->total = tny_list_get_length (headers); priv->done = 0; priv->status = MODEST_MAIL_OPERATION_STATUS_IN_PROGRESS; @@ -3040,8 +3179,8 @@ modest_mail_operation_xfer_msgs (ModestMailOperation *self, this could cause an error if we're offline while transferring an already downloaded message from a POP account */ - if (modest_protocol_info_get_transport_store_protocol (tny_account_get_proto (priv->account)) == - MODEST_PROTOCOL_STORE_POP) { + account_protocol = modest_tny_account_get_protocol_type (priv->account); + if (modest_protocol_registry_protocol_type_has_leave_on_server (protocol_registry, account_protocol)) { const gchar *account_name; account_name = modest_tny_account_get_parent_modest_account_name_for_server_account (priv->account); @@ -3209,20 +3348,45 @@ modest_mail_operation_refresh_folder (ModestMailOperation *self, } static void -run_queue_stop (ModestTnySendQueue *queue, - ModestMailOperation *self) +run_queue_notify_and_destroy (RunQueueHelper *helper, + ModestMailOperationStatus status) { ModestMailOperationPrivate *priv; - g_return_if_fail (MODEST_IS_MAIL_OPERATION (self)); - g_return_if_fail (MODEST_IS_TNY_SEND_QUEUE (queue)); - priv = MODEST_MAIL_OPERATION_GET_PRIVATE (self); + /* Disconnect */ + if (helper->error_handler && + g_signal_handler_is_connected (helper->queue, helper->error_handler)) + g_signal_handler_disconnect (helper->queue, helper->error_handler); + if (helper->start_handler && + g_signal_handler_is_connected (helper->queue, helper->start_handler)) + g_signal_handler_disconnect (helper->queue, helper->start_handler); + if (helper->stop_handler && + g_signal_handler_is_connected (helper->queue, helper->stop_handler)) + g_signal_handler_disconnect (helper->queue, helper->stop_handler); - priv->status = MODEST_MAIL_OPERATION_STATUS_SUCCESS; + /* Set status */ + priv = MODEST_MAIL_OPERATION_GET_PRIVATE (helper->self); + priv->status = status; - modest_mail_operation_notify_end (self); - g_signal_handlers_disconnect_by_func (queue, run_queue_stop, self); - g_object_unref (self); + /* Notify end */ + modest_mail_operation_notify_end (helper->self); + + /* Free data */ + g_object_unref (helper->queue); + g_object_unref (helper->self); + g_slice_free (RunQueueHelper, helper); +} + +static void +run_queue_stop (ModestTnySendQueue *queue, + gpointer user_data) +{ + RunQueueHelper *helper; + + g_debug ("%s sending queue stopped", __FUNCTION__); + + helper = (RunQueueHelper *) user_data; + run_queue_notify_and_destroy (helper, MODEST_MAIL_OPERATION_STATUS_SUCCESS); } void @@ -3230,6 +3394,7 @@ modest_mail_operation_run_queue (ModestMailOperation *self, ModestTnySendQueue *queue) { ModestMailOperationPrivate *priv; + RunQueueHelper *helper; g_return_if_fail (MODEST_IS_MAIL_OPERATION (self)); g_return_if_fail (MODEST_IS_TNY_SEND_QUEUE (queue)); @@ -3239,9 +3404,17 @@ modest_mail_operation_run_queue (ModestMailOperation *self, priv->account = TNY_ACCOUNT (tny_camel_send_queue_get_transport_account (TNY_CAMEL_SEND_QUEUE (queue))); priv->op_type = MODEST_MAIL_OPERATION_TYPE_RUN_QUEUE; + /* Create the helper */ + helper = g_slice_new0 (RunQueueHelper); + helper->queue = g_object_ref (queue); + helper->self = g_object_ref (self); + helper->stop_handler = g_signal_connect (queue, "queue-stop", + G_CALLBACK (run_queue_stop), + helper); + + /* Notify operation has started */ modest_mail_operation_notify_start (self); - g_object_ref (self); - g_signal_connect ((gpointer) queue, "queue-stop", G_CALLBACK (run_queue_stop), (gpointer) self); + g_debug ("%s, run queue started", __FUNCTION__); } static void