X-Git-Url: http://git.maemo.org/git/?a=blobdiff_plain;f=src%2Fmodest-ui-actions.c;h=9a5687688c384d7a473798debe1867a0d7198928;hb=17650658e9c61cb055beecba2e865f2de3a2cbea;hp=c84fd6952f6dfaebba466d7be56696bcd44bdf07;hpb=7c554315330b15c198391928a502333c821c6b40;p=modest diff --git a/src/modest-ui-actions.c b/src/modest-ui-actions.c index c84fd69..7f21072 100644 --- a/src/modest-ui-actions.c +++ b/src/modest-ui-actions.c @@ -41,7 +41,6 @@ #include #include "modest-error.h" #include "modest-ui-actions.h" -#include "modest-protocol-info.h" #include "modest-tny-platform-factory.h" #include "modest-platform.h" #include "modest-debug.h" @@ -49,12 +48,21 @@ #include #include #include +#ifdef MODEST_TOOLKIT_HILDON2 +#include +#include +#include +#include +#include +#endif #ifdef MODEST_PLATFORM_MAEMO #include "maemo/modest-osso-state-saving.h" +#endif /* MODEST_PLATFORM_MAEMO */ +#ifndef MODEST_TOOLKIT_GTK #include "maemo/modest-hildon-includes.h" #include "maemo/modest-connection-specific-smtp-window.h" -#endif /* MODEST_PLATFORM_MAEMO */ +#endif /* !MODEST_TOOLKIT_GTK */ #include #include "widgets/modest-ui-constants.h" @@ -68,11 +76,6 @@ #include "modest-account-mgr-helpers.h" #include "modest-mail-operation.h" #include "modest-text-utils.h" - -#ifdef MODEST_HAVE_EASYSETUP -#include "easysetup/modest-easysetup-wizard.h" -#endif /* MODEST_HAVE_EASYSETUP */ - #include #include #include @@ -82,6 +85,9 @@ #include +#define MIN_FREE_SPACE 5 * 1024 * 1024 +#define MODEST_MOVE_TO_DIALOG_FOLDER_VIEW "move-to-dialog-folder-view" + typedef struct _GetMsgAsyncHelper { ModestWindow *window; ModestMailOperation *mail_op; @@ -102,6 +108,7 @@ typedef struct _ReplyForwardHelper { ReplyForwardAction action; gchar *account_name; GtkWidget *parent_window; + TnyHeader *header; } ReplyForwardHelper; typedef struct _MoveToHelper { @@ -114,6 +121,10 @@ typedef struct _PasteAsAttachmentHelper { GtkWidget *banner; } PasteAsAttachmentHelper; +typedef struct { + TnyList *list; + ModestWindow *win; +} MoveToInfo; /* * The do_headers_action uses this kind of functions to perform some @@ -154,37 +165,47 @@ static gboolean connect_to_get_msg (ModestWindow *win, gint num_of_uncached_msgs, TnyAccount *account); -static gboolean remote_folder_is_pop (TnyFolderStore *folder); +static gboolean remote_folder_has_leave_on_server (TnyFolderStore *folder); static void do_create_folder (GtkWindow *window, TnyFolderStore *parent_folder, const gchar *suggested_name); -static GtkWidget* get_folder_view_from_move_to_dialog (GtkWidget *move_to_dialog); - static TnyAccount *get_account_from_folder_store (TnyFolderStore *folder_store); -static void transfer_messages_helper (GtkWindow *win, - TnyFolder *src_folder, - TnyList *headers, - TnyFolder *dst_folder); +static void modest_ui_actions_on_main_window_move_to (GtkAction *action, + GtkWidget *folder_view, + TnyFolderStore *dst_folder, + ModestMainWindow *win); +#ifdef MODEST_TOOLKIT_HILDON2 +static void modest_ui_actions_on_folder_window_move_to (GtkWidget *folder_view, + TnyFolderStore *dst_folder, + TnyList *selection, + GtkWindow *win); +#endif + +static void modest_ui_actions_on_window_move_to (GtkAction *action, + TnyList *list_to_move, + TnyFolderStore *dst_folder, + ModestWindow *win); /* * This function checks whether a TnyFolderStore is a pop account */ static gboolean -remote_folder_is_pop (TnyFolderStore *folder) +remote_folder_has_leave_on_server (TnyFolderStore *folder) { - const gchar *proto = NULL; - TnyAccount *account = NULL; + TnyAccount *account; + gboolean result; g_return_val_if_fail (TNY_IS_FOLDER_STORE (folder), FALSE); account = get_account_from_folder_store (folder); - proto = tny_account_get_proto (account); + result = (modest_protocol_registry_protocol_type_has_leave_on_server (modest_runtime_get_protocol_registry (), + modest_tny_account_get_protocol_type (account))); g_object_unref (account); - return (modest_protocol_info_get_transport_store_protocol (proto) == MODEST_PROTOCOL_STORE_POP); + return result; } /* FIXME: this should be merged with the similar code in modest-account-view-window */ @@ -194,36 +215,59 @@ remote_folder_is_pop (TnyFolderStore *folder) gboolean modest_ui_actions_run_account_setup_wizard (ModestWindow *win) { - gboolean result = FALSE; - GtkWindow *dialog, *wizard; + gboolean result = FALSE; + GtkWindow *wizard; gint dialog_response; - /* Show the easy-setup wizard: */ - dialog = modest_window_mgr_get_modal (modest_runtime_get_window_mgr()); - if (dialog) { - /* old wizard is active already; - */ - gtk_window_present (GTK_WINDOW(dialog)); - return FALSE; - } - - - /* there is no such wizard yet */ + /* there is no such wizard yet */ wizard = GTK_WINDOW (modest_platform_get_account_settings_wizard ()); - modest_window_mgr_set_modal (modest_runtime_get_window_mgr(), wizard); + modest_window_mgr_set_modal (modest_runtime_get_window_mgr(), GTK_WINDOW (wizard), (GtkWindow *) win); +#ifndef MODEST_TOOLKIT_HILDON2 /* always present a main window in the background * we do it here, so we cannot end up with two wizards (as this * function might be called in modest_window_mgr_get_main_window as well */ - if (!win) + if (!win) win = modest_window_mgr_get_main_window (modest_runtime_get_window_mgr(), TRUE); /* create if not existent */ - - /* make sure the mainwindow is visible */ - gtk_window_set_transient_for (GTK_WINDOW (wizard), GTK_WINDOW (win)); - gtk_widget_show_all (GTK_WIDGET(win)); - gtk_window_present (GTK_WINDOW(win)); - +#else + if (!win) { + GList *window_list; + ModestWindowMgr *mgr; + + mgr = modest_runtime_get_window_mgr (); + + window_list = modest_window_mgr_get_window_list (mgr); + if (window_list == NULL) { + win = MODEST_WINDOW (modest_accounts_window_new ()); + modest_window_mgr_register_window (mgr, win, NULL); + gtk_widget_show_all (GTK_WIDGET (win)); + + win = MODEST_WINDOW (modest_folder_window_new (NULL)); + modest_window_mgr_register_window (mgr, win, NULL); + + gtk_widget_show_all (GTK_WIDGET (win)); + } else { + g_list_free (window_list); + } + } +#endif + + if (win) + gtk_window_set_transient_for (GTK_WINDOW (wizard), GTK_WINDOW (win)); + + /* make sure the mainwindow is visible. We need to present the + wizard again to give it the focus back. show_all are needed + in order to get the widgets properly drawn (MainWindow main + paned won't be in its right position and the dialog will be + missplaced */ +#ifndef MODEST_TOOLKIT_HILDON2 + gtk_widget_show_all (GTK_WIDGET (win)); + gtk_widget_show_all (GTK_WIDGET (wizard)); + gtk_window_present (GTK_WINDOW (win)); + gtk_window_present (GTK_WINDOW (wizard)); +#endif + dialog_response = gtk_dialog_run (GTK_DIALOG (wizard)); gtk_widget_destroy (GTK_WIDGET (wizard)); if (gtk_events_pending ()) @@ -299,6 +343,13 @@ get_selected_headers (ModestWindow *win) return list; +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_HEADER_WINDOW (win)) { + GtkWidget *header_view; + + header_view = GTK_WIDGET (modest_header_window_get_header_view (MODEST_HEADER_WINDOW (win))); + return modest_header_view_get_selected_headers (MODEST_HEADER_VIEW(header_view)); +#endif } else return NULL; } @@ -379,6 +430,12 @@ modest_ui_actions_refresh_message_window_after_delete (ModestMsgViewWindow* win) void modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) { + modest_ui_actions_on_edit_mode_delete_message (win); +} + +gboolean +modest_ui_actions_on_edit_mode_delete_message (ModestWindow *win) +{ TnyList *header_list = NULL; TnyIterator *iter = NULL; TnyHeader *header = NULL; @@ -387,8 +444,9 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) gint response; ModestWindowMgr *mgr; GtkWidget *header_view = NULL; + gboolean retval = TRUE; - g_return_if_fail (MODEST_IS_WINDOW(win)); + g_return_val_if_fail (MODEST_IS_WINDOW(win), FALSE); /* Check first if the header view has the focus */ if (MODEST_IS_MAIN_WINDOW (win)) { @@ -396,13 +454,13 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (win), MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); if (!gtk_widget_is_focus (header_view)) - return; + return FALSE; } /* Get the headers, either from the header view (if win is the main window), * or from the message view window: */ header_list = get_selected_headers (win); - if (!header_list) return; + if (!header_list) return FALSE; /* Check if any of the headers are already opened, or in the process of being opened */ if (MODEST_IS_MAIN_WINDOW (win)) { @@ -427,11 +485,11 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) msg = g_strdup_printf (_("mcen_nc_unable_to_delete_n_messages"), opened_headers); - modest_platform_run_information_dialog (GTK_WINDOW (win), (const gchar *) msg); + modest_platform_run_information_dialog (GTK_WINDOW (win), (const gchar *) msg, FALSE); g_free (msg); g_object_unref (header_list); - return; + return FALSE; } } @@ -440,7 +498,12 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) iter = tny_list_create_iterator (header_list); header = TNY_HEADER (tny_iterator_get_current (iter)); if (header) { - desc = g_strdup_printf ("%s", tny_header_get_subject (header)); + gchar *subject; + subject = tny_header_dup_subject (header); + if (!subject) + subject = g_strdup (_("mail_va_no_subject")); + desc = g_strdup_printf ("%s", subject); + g_free (subject); g_object_unref (header); } @@ -507,13 +570,12 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) /* Get main window */ mgr = modest_runtime_get_window_mgr (); main_window = modest_window_mgr_get_main_window (mgr, FALSE); /* don't create */ - } else { + } else if (MODEST_IS_MAIN_WINDOW (win)) { /* Move cursor to next row */ main_window = win; /* Select next or previous row */ if (gtk_tree_row_reference_valid (next_row_reference)) { -/* next_path = gtk_tree_row_reference_get_path (row_reference); */ gtk_tree_selection_select_path (sel, next_path); } else if (gtk_tree_row_reference_valid (prev_row_reference)) { @@ -521,29 +583,36 @@ modest_ui_actions_on_delete_message (GtkAction *action, ModestWindow *win) } /* Free */ - if (next_row_reference != NULL) + if (gtk_tree_row_reference_valid (next_row_reference)) gtk_tree_row_reference_free (next_row_reference); if (next_path != NULL) gtk_tree_path_free (next_path); - if (prev_row_reference != NULL) + if (gtk_tree_row_reference_valid (prev_row_reference)) gtk_tree_row_reference_free (prev_row_reference); if (prev_path != NULL) - gtk_tree_path_free (prev_path); + gtk_tree_path_free (prev_path); } /* Update toolbar dimming state */ - if (main_window) + if (main_window) { + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (main_window)); modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); + } /* Free */ g_list_foreach (sel_list, (GFunc) gtk_tree_path_free, NULL); g_list_free (sel_list); + retval = TRUE; + } else { + retval = FALSE; } /* Free*/ g_free(message); g_free(desc); g_object_unref (header_list); + + return retval; } @@ -561,7 +630,7 @@ modest_ui_actions_on_delete_message_or_folder (GtkAction *action, ModestWindow * w = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (win), MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); if (gtk_widget_is_focus (w)) { - modest_ui_actions_on_delete_folder (action, MODEST_MAIN_WINDOW(win)); + modest_ui_actions_on_delete_folder (action, MODEST_WINDOW(win)); return; } } @@ -619,6 +688,14 @@ modest_ui_actions_on_close_window (GtkAction *action, ModestWindow *win) } void +modest_ui_actions_add_to_contacts (GtkAction *action, ModestWindow *win) +{ + g_return_if_fail (MODEST_IS_MSG_VIEW_WINDOW (win)); + + modest_msg_view_window_add_to_contacts (MODEST_MSG_VIEW_WINDOW (win)); +} + +void modest_ui_actions_on_add_to_contacts (GtkAction *action, ModestWindow *win) { GtkClipboard *clipboard = NULL; @@ -638,38 +715,32 @@ modest_ui_actions_on_add_to_contacts (GtkAction *action, ModestWindow *win) } void -modest_ui_actions_on_accounts (GtkAction *action, +modest_ui_actions_on_new_account (GtkAction *action, + ModestWindow *window) +{ + modest_ui_actions_run_account_setup_wizard (window); +} + +void +modest_ui_actions_on_accounts (GtkAction *action, ModestWindow *win) { /* This is currently only implemented for Maemo */ if (!modest_account_mgr_has_accounts (modest_runtime_get_account_mgr(), TRUE)) { - if (!modest_ui_actions_run_account_setup_wizard (win)) + if (!modest_ui_actions_run_account_setup_wizard (win)) g_debug ("%s: wizard was already running", __FUNCTION__); - + return; } else { /* Show the list of accounts */ GtkWindow *account_win = GTK_WINDOW (modest_account_view_window_new ()); - gtk_window_set_transient_for (account_win, GTK_WINDOW (win)); - + /* The accounts dialog must be modal */ - modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), account_win); + modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), GTK_WINDOW (account_win), (GtkWindow *) win); modest_utils_show_dialog_and_forget (GTK_WINDOW (win), GTK_DIALOG (account_win)); } } -#ifdef MODEST_PLATFORM_MAEMO -static void -on_smtp_servers_window_hide (GtkWindow* window, gpointer user_data) -{ - /* Save any changes. */ - modest_connection_specific_smtp_window_save_server_accounts ( - MODEST_CONNECTION_SPECIFIC_SMTP_WINDOW (window)); - gtk_widget_destroy (GTK_WIDGET (window)); -} -#endif - - void modest_ui_actions_on_smtp_servers (GtkAction *action, ModestWindow *win) { @@ -677,23 +748,19 @@ modest_ui_actions_on_smtp_servers (GtkAction *action, ModestWindow *win) * because it requires an API (libconic) to detect different connection * possiblities. */ -#ifdef MODEST_PLATFORM_MAEMO /* Defined in config.h */ - +#ifndef MODEST_TOOLKIT_GTK /* Defined in config.h */ + /* Create the window if necessary: */ GtkWidget *specific_window = GTK_WIDGET (modest_connection_specific_smtp_window_new ()); modest_connection_specific_smtp_window_fill_with_connections ( MODEST_CONNECTION_SPECIFIC_SMTP_WINDOW (specific_window), modest_runtime_get_account_mgr()); - /* Show the window: */ - gtk_window_set_transient_for (GTK_WINDOW (specific_window), GTK_WINDOW (win)); - gtk_window_set_modal (GTK_WINDOW (specific_window), TRUE); + /* Show the window: */ + modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), + GTK_WINDOW (specific_window), (GtkWindow *) win); gtk_widget_show (specific_window); - - /* Save changes when the window is hidden: */ - g_signal_connect (specific_window, "hide", - G_CALLBACK (on_smtp_servers_window_hide), win); -#endif /* MODEST_PLATFORM_MAEMO */ +#endif /* !MODEST_TOOLKIT_GTK */ } void @@ -715,8 +782,18 @@ modest_ui_actions_compose_msg(ModestWindow *win, ModestWindow *msg_win = NULL; ModestAccountMgr *mgr = modest_runtime_get_account_mgr(); ModestTnyAccountStore *store = modest_runtime_get_account_store(); + GnomeVFSFileSize total_size, allowed_size; + + /* we check for low-mem */ + if (modest_platform_check_memory_low (win, TRUE)) + goto cleanup; - account_name = modest_account_mgr_get_default_account(mgr); +#ifdef MODEST_TOOLKIT_HILDON2 + account_name = g_strdup (modest_window_get_active_account(win)); +#endif + if (!account_name) { + account_name = modest_account_mgr_get_default_account(mgr); + } if (!account_name) { g_printerr ("modest: no account found\n"); goto cleanup; @@ -739,12 +816,12 @@ modest_ui_actions_compose_msg(ModestWindow *win, signature = modest_account_mgr_get_signature (mgr, account_name, &use_signature); if (body_str != NULL) { - body = use_signature ? g_strconcat(body_str, "\n", signature, NULL) : g_strdup(body_str); + body = use_signature ? g_strconcat(body_str, "\n--\n", signature, NULL) : g_strdup(body_str); } else { - body = use_signature ? g_strconcat("\n", signature, NULL) : g_strdup(""); + body = use_signature ? g_strconcat("\n--\n", signature, NULL) : g_strdup(""); } - msg = modest_tny_msg_new (to_str, from_str, cc_str, bcc_str, subject_str, body, NULL); + msg = modest_tny_msg_new (to_str, from_str, cc_str, bcc_str, subject_str, body, NULL, NULL, NULL); if (!msg) { g_printerr ("modest: failed to create new msg\n"); goto cleanup; @@ -752,26 +829,43 @@ modest_ui_actions_compose_msg(ModestWindow *win, /* Create and register edit window */ /* This is destroyed by TODO. */ + total_size = 0; + allowed_size = MODEST_MAX_ATTACHMENT_SIZE; msg_win = modest_msg_edit_window_new (msg, account_name, FALSE); - while (attachments) { - modest_msg_edit_window_attach_file_one((ModestMsgEditWindow *)msg_win, - attachments->data); - attachments = g_slist_next(attachments); + + if (!modest_window_mgr_register_window (modest_runtime_get_window_mgr(), msg_win, win)) { + gtk_widget_destroy (GTK_WIDGET (msg_win)); + goto cleanup; } - modest_window_mgr_register_window (modest_runtime_get_window_mgr(), msg_win); modest_msg_edit_window_set_modified (MODEST_MSG_EDIT_WINDOW (msg_win), set_as_modified); - gtk_widget_show_all (GTK_WIDGET (msg_win)); + while (attachments) { + total_size += + modest_msg_edit_window_attach_file_one((ModestMsgEditWindow *)msg_win, + attachments->data, allowed_size); + + if (total_size > allowed_size) { + g_warning ("%s: total size: %u", + __FUNCTION__, (unsigned int)total_size); + break; + } + allowed_size -= total_size; + + attachments = g_slist_next(attachments); + } + cleanup: g_free (from_str); g_free (signature); g_free (body); g_free (account_name); - if (account) g_object_unref (G_OBJECT(account)); - if (folder) g_object_unref (G_OBJECT(folder)); - if (msg_win) g_object_unref (G_OBJECT(msg_win)); - if (msg) g_object_unref (G_OBJECT(msg)); + if (account) + g_object_unref (G_OBJECT(account)); + if (folder) + g_object_unref (G_OBJECT(folder)); + if (msg) + g_object_unref (G_OBJECT(msg)); } void @@ -796,6 +890,47 @@ modest_ui_actions_msg_retrieval_check (ModestMailOperation *mail_op, /* If there is no message or the operation was not successful */ status = modest_mail_operation_get_status (mail_op); if (!msg || status != MODEST_MAIL_OPERATION_STATUS_SUCCESS) { + const GError *error; + + /* If it's a memory low issue, then show a banner */ + error = modest_mail_operation_get_error (mail_op); + if (error && error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_LOW_MEMORY) { + GObject *source = modest_mail_operation_get_source (mail_op); + modest_platform_run_information_dialog (GTK_IS_WINDOW (source) ? GTK_WINDOW (source) : NULL, + _KR("memr_ib_operation_disabled"), + TRUE); + g_object_unref (source); + } + + if (error && ((error->code == TNY_SERVICE_ERROR_NO_SUCH_MESSAGE) || + error->code == TNY_SERVICE_ERROR_MESSAGE_NOT_AVAILABLE)) { + gchar *subject, *msg, *format = NULL; + TnyAccount *account; + subject = tny_header_dup_subject (header); + if (!subject) + subject = g_strdup (_("mail_va_no_subject")); + + account = modest_mail_operation_get_account (mail_op); + if (account) { + ModestProtocol *protocol; + ModestProtocolType proto; + proto = modest_tny_account_get_protocol_type (account); + protocol = modest_protocol_registry_get_protocol_by_type (modest_runtime_get_protocol_registry (), proto); + if (protocol) + format = modest_protocol_get_translation (protocol, MODEST_PROTOCOL_TRANSLATION_MSG_NOT_AVAILABLE, subject); + g_object_unref (account); + } + + if (!format) + format = g_strdup (_("emev_ni_ui_imap_message_not_available_in_server")); + + msg = g_strdup_printf (format, subject); + modest_platform_run_information_dialog (NULL, msg, FALSE); + g_free (msg); + g_free (format); + g_free (subject); + } /* Remove the header from the preregistered uids */ modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), @@ -807,34 +942,66 @@ modest_ui_actions_msg_retrieval_check (ModestMailOperation *mail_op, return TRUE; } -static void -open_msg_cb (ModestMailOperation *mail_op, - TnyHeader *header, - gboolean canceled, - TnyMsg *msg, - GError *err, - gpointer user_data) +typedef struct { + guint idle_handler; + gchar *message; + GtkWidget *banner; +} OpenMsgBannerInfo; + +typedef struct { + GtkTreeModel *model; + TnyHeader *header; + OpenMsgBannerInfo *banner_info; + GtkTreeRowReference *rowref; +} OpenMsgHelper; + +gboolean +open_msg_banner_idle (gpointer userdata) { - ModestWindowMgr *mgr = NULL; - ModestWindow *parent_win = NULL; - ModestWindow *win = NULL; - TnyFolderType folder_type = TNY_FOLDER_TYPE_UNKNOWN; - gchar *account = NULL; - TnyFolder *folder; - gboolean open_in_editor = FALSE; + OpenMsgBannerInfo *banner_info = (OpenMsgBannerInfo *) userdata; + + gdk_threads_enter (); + banner_info->idle_handler = 0; + banner_info->banner = modest_platform_animation_banner (NULL, NULL, banner_info->message); + if (banner_info) + g_object_ref (banner_info->banner); - /* Do nothing if there was any problem with the mail - operation. The error will be shown by the error_handler of - the mail operation */ - if (!modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) - return; + gdk_threads_leave (); - parent_win = (ModestWindow *) modest_mail_operation_get_source (mail_op); - folder = tny_header_get_folder (header); + return FALSE; + +} - /* Mark header as read */ - headers_action_mark_as_read (header, MODEST_WINDOW(parent_win), NULL); +static GtkWidget * +get_header_view_from_window (ModestWindow *window) +{ + GtkWidget *header_view; + + if (MODEST_IS_MAIN_WINDOW (window)) { + header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (window), + MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_HEADER_WINDOW (window)){ + header_view = GTK_WIDGET (modest_header_window_get_header_view (MODEST_HEADER_WINDOW (window))); +#endif + } else { + header_view = NULL; + } + return header_view; +} + +static gchar * +get_info_from_header (TnyHeader *header, gboolean *is_draft, gboolean *can_open) +{ + TnyFolder *folder; + gchar *account = NULL; + TnyFolderType folder_type = TNY_FOLDER_TYPE_UNKNOWN; + + *is_draft = FALSE; + *can_open = TRUE; + + folder = tny_header_get_folder (header); /* Gets folder type (OUTBOX headers will be opened in edit window */ if (modest_tny_folder_is_local_folder (folder)) { folder_type = modest_tny_folder_get_local_or_mmc_folder_type (folder); @@ -842,7 +1009,6 @@ open_msg_cb (ModestMailOperation *mail_op, g_warning ("%s: BUG: TNY_FOLDER_TYPE_INVALID", __FUNCTION__); } - if (folder_type == TNY_FOLDER_TYPE_OUTBOX) { TnyTransportAccount *traccount = NULL; ModestTnyAccountStore *accstore = modest_runtime_get_account_store(); @@ -850,108 +1016,128 @@ open_msg_cb (ModestMailOperation *mail_op, if (traccount) { ModestTnySendQueue *send_queue = NULL; ModestTnySendQueueStatus status; - char *msg_id; + gchar *msg_id; account = g_strdup(modest_tny_account_get_parent_modest_account_name_for_server_account( TNY_ACCOUNT(traccount))); - send_queue = modest_runtime_get_send_queue(traccount); - msg_id = modest_tny_send_queue_get_msg_id (header); - status = modest_tny_send_queue_get_msg_status(send_queue, msg_id); - /* Only open messages in outbox with the editor if they are in Failed state */ - if (status == MODEST_TNY_SEND_QUEUE_FAILED) { - open_in_editor = TRUE; + send_queue = modest_runtime_get_send_queue(traccount, TRUE); + if (TNY_IS_SEND_QUEUE (send_queue)) { + msg_id = modest_tny_send_queue_get_msg_id (header); + status = modest_tny_send_queue_get_msg_status(send_queue, msg_id); + g_free (msg_id); + /* Only open messages in outbox with the editor if they are in Failed state */ + if (status == MODEST_TNY_SEND_QUEUE_FAILED) { + *is_draft = TRUE; + } +#ifdef MODEST_TOOLKIT_HILDON2 + else { + /* In Fremantle we can not + open any message from + outbox which is not in + failed state */ + *can_open = FALSE; + } +#endif } - g_free(msg_id); g_object_unref(traccount); } else { g_warning("Cannot get transport account for message in outbox!!"); } } else if (folder_type == TNY_FOLDER_TYPE_DRAFTS) { - open_in_editor = TRUE; /* Open in editor if the message is in the Drafts folder */ + *is_draft = TRUE; /* Open in editor if the message is in the Drafts folder */ + } + + if (!account) { + TnyAccount *acc = tny_folder_get_account (folder); + if (acc) { + account = + g_strdup (modest_tny_account_get_parent_modest_account_name_for_server_account (acc)); + g_object_unref (acc); + } } + g_object_unref (folder); + + return account; +} + +static void +open_msg_cb (ModestMailOperation *mail_op, + TnyHeader *header, + gboolean canceled, + TnyMsg *msg, + GError *err, + gpointer user_data) +{ + ModestWindowMgr *mgr = NULL; + ModestWindow *parent_win = NULL; + ModestWindow *win = NULL; + gchar *account = NULL; + gboolean open_in_editor = FALSE; + gboolean can_open; + OpenMsgHelper *helper = (OpenMsgHelper *) user_data; + + /* Do nothing if there was any problem with the mail + operation. The error will be shown by the error_handler of + the mail operation */ + if (!modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) + return; + + parent_win = (ModestWindow *) modest_mail_operation_get_source (mail_op); + + /* Mark header as read */ + headers_action_mark_as_read (header, MODEST_WINDOW(parent_win), NULL); + + account = get_info_from_header (header, &open_in_editor, &can_open); + /* Get account */ if (!account) account = g_strdup (modest_window_get_active_account (MODEST_WINDOW (parent_win))); if (!account) account = modest_account_mgr_get_default_account (modest_runtime_get_account_mgr()); - + if (open_in_editor) { ModestAccountMgr *mgr = modest_runtime_get_account_mgr (); - const gchar *from_header = NULL; + gchar *from_header = NULL, *acc_name; - from_header = tny_header_get_from (header); + from_header = tny_header_dup_from (header); /* we cannot edit without a valid account... */ if (!modest_account_mgr_has_accounts(mgr, TRUE)) { - if (!modest_ui_actions_run_account_setup_wizard(parent_win)) + if (!modest_ui_actions_run_account_setup_wizard(parent_win)) { + modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), + header); + g_free (from_header); goto cleanup; - } - - if (from_header) { - GSList *accounts = modest_account_mgr_account_names (mgr, TRUE); - GSList *node = NULL; - for (node = accounts; node != NULL; node = g_slist_next (node)) { - gchar *from = modest_account_mgr_get_from_string (mgr, node->data); - - if (from && (strcmp (from_header, from) == 0)) { - g_free (account); - account = g_strdup (node->data); - g_free (from); - break; - } - g_free (from); } - g_slist_foreach (accounts, (GFunc) g_free, NULL); - g_slist_free (accounts); } - win = modest_msg_edit_window_new (msg, account, TRUE); - - - /* Show banner */ - modest_platform_information_banner_with_timeout - (NULL, NULL, _("mail_ib_opening_draft_message"), 1200); + acc_name = modest_utils_get_account_name_from_recipient (from_header); + g_free (from_header); + if (acc_name) { + g_free (account); + account = acc_name; + } + win = modest_msg_edit_window_new (msg, account, TRUE); } else { gchar *uid = modest_tny_folder_get_header_unique_id (header); - - if (MODEST_IS_MAIN_WINDOW (parent_win)) { - GtkWidget *header_view; - GtkTreeSelection *sel; - GList *sel_list = NULL; - GtkTreeModel *model; - - header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(parent_win), - MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); - sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (header_view)); - sel_list = gtk_tree_selection_get_selected_rows (sel, &model); - - if (sel_list != NULL) { - GtkTreeRowReference *row_reference; - - row_reference = gtk_tree_row_reference_new (model, (GtkTreePath *) sel_list->data); - g_list_foreach (sel_list, (GFunc) gtk_tree_path_free, NULL); - g_list_free (sel_list); - - win = modest_msg_view_window_new_with_header_model ( - msg, account, (const gchar*) uid, - model, row_reference); - gtk_tree_row_reference_free (row_reference); - } else { - win = modest_msg_view_window_new_for_attachment (msg, account, (const gchar*) uid); - } + if (helper->rowref && helper->model) { + win = modest_msg_view_window_new_with_header_model (msg, account, (const gchar*) uid, + helper->model, helper->rowref); } else { win = modest_msg_view_window_new_for_attachment (msg, account, (const gchar*) uid); } g_free (uid); } - + /* Register and show new window */ if (win != NULL) { mgr = modest_runtime_get_window_mgr (); - modest_window_mgr_register_window (mgr, win); - g_object_unref (win); + if (!modest_window_mgr_register_window (mgr, win, NULL)) { + gtk_widget_destroy (GTK_WIDGET (win)); + goto cleanup; + } gtk_widget_show_all (GTK_WIDGET(win)); } @@ -964,33 +1150,89 @@ cleanup: /* Free */ g_free(account); g_object_unref (parent_win); - g_object_unref (folder); +} + +static gboolean +is_memory_full_error (GError *error) +{ + gboolean enough_free_space = TRUE; + GnomeVFSURI *cache_dir_uri; + const gchar *cache_dir; + GnomeVFSFileSize free_space; + + cache_dir = tny_account_store_get_cache_dir (TNY_ACCOUNT_STORE (modest_runtime_get_account_store ())); + cache_dir_uri = gnome_vfs_uri_new (cache_dir); + if (gnome_vfs_get_volume_free_space (cache_dir_uri, &free_space) == GNOME_VFS_OK) { + if (free_space < MIN_FREE_SPACE) + enough_free_space = FALSE; + } + gnome_vfs_uri_unref (cache_dir_uri); + + if ((error->code == TNY_SYSTEM_ERROR_MEMORY || + /* When asking for a mail and no space left on device + tinymail returns this error */ + error->code == TNY_SERVICE_ERROR_MESSAGE_NOT_AVAILABLE || + /* When the folder summary could not be read or + written */ + error->code == TNY_IO_ERROR_WRITE || + error->code == TNY_IO_ERROR_READ) && + !enough_free_space) { + return TRUE; + } else { + return FALSE; + } +} + +static gboolean +check_memory_full_error (GtkWidget *parent_window, GError *err) +{ + if (err == NULL) + return FALSE; + + if (is_memory_full_error (err)) + modest_platform_information_banner (parent_window, + NULL, _KR("cerm_device_memory_full")); + else if (err->code == TNY_SYSTEM_ERROR_MEMORY) + /* If the account was created in memory full + conditions then tinymail won't be able to + connect so it'll return this error code */ + modest_platform_information_banner (parent_window, + NULL, _("emev_ui_imap_inbox_select_error")); + else + return FALSE; + + return TRUE; } void -modest_ui_actions_get_msgs_full_error_handler (ModestMailOperation *mail_op, - gpointer user_data) +modest_ui_actions_disk_operations_error_handler (ModestMailOperation *mail_op, + gpointer user_data) { const GError *error; GObject *win = NULL; + ModestMailOperationStatus status; win = modest_mail_operation_get_source (mail_op); error = modest_mail_operation_get_error (mail_op); + status = modest_mail_operation_get_status (mail_op); - /* Show error */ - if (error->code == TNY_SYSTEM_ERROR_MEMORY || - error->code == TNY_IO_ERROR_WRITE || - error->code == TNY_IO_ERROR_READ) { - ModestMailOperationStatus st = modest_mail_operation_get_status (mail_op); - /* If the mail op has been cancelled then it's not an error: don't show any message */ - if (st != MODEST_MAIL_OPERATION_STATUS_CANCELED) { + /* If the mail op has been cancelled then it's not an error: + don't show any message */ + if (status != MODEST_MAIL_OPERATION_STATUS_CANCELED) { + if (is_memory_full_error ((GError *) error)) { + modest_platform_information_banner ((GtkWidget *) win, + NULL, _KR("cerm_device_memory_full")); + } else if (error->code == TNY_SYSTEM_ERROR_MEMORY) { modest_platform_information_banner ((GtkWidget *) win, - NULL, dgettext("ke-recv", - "cerm_device_memory_full")); + NULL, _("emev_ui_imap_inbox_select_error")); + } else if (error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_FILE_IO) { + modest_platform_information_banner ((GtkWidget *) win, + NULL, _CS ("sfil_ni_unable_to_open_file_not_found")); + } else if (user_data) { + modest_platform_information_banner ((GtkWidget *) win, + NULL, user_data); } - } else if (user_data) { - modest_platform_information_banner ((GtkWidget *) win, - NULL, user_data); } if (win) @@ -1010,93 +1252,209 @@ get_account_from_header_list (TnyList *headers) TnyIterator *iter = tny_list_create_iterator (headers); TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter)); TnyFolder *folder = tny_header_get_folder (header); + + if (!folder) { + g_object_unref (header); + + while (!tny_iterator_is_done (iter)) { + header = TNY_HEADER (tny_iterator_get_current (iter)); + folder = tny_header_get_folder (header); + if (folder) + break; + g_object_unref (header); + header = NULL; + tny_iterator_next (iter); + } + } + + if (folder) { + account = tny_folder_get_account (folder); + g_object_unref (folder); + } + + if (header) + g_object_unref (header); + + g_object_unref (iter); + } + return account; +} + +static TnyAccount* +get_account_from_header (TnyHeader *header) +{ + TnyAccount *account = NULL; + TnyFolder *folder; + + folder = tny_header_get_folder (header); + + if (folder) { account = tny_folder_get_account (folder); g_object_unref (folder); - g_object_unref (header); - g_object_unref (iter); } return account; } -static void -foreach_unregister_headers (gpointer data, - gpointer user_data) +static void +open_msg_helper_destroyer (gpointer user_data) { - ModestWindowMgr *mgr = (ModestWindowMgr *) user_data; - TnyHeader *header = TNY_HEADER (data); + OpenMsgHelper *helper = (OpenMsgHelper *) user_data; - modest_window_mgr_unregister_header (mgr, header); + if (helper->banner_info) { + g_free (helper->banner_info->message); + if (helper->banner_info->idle_handler > 0) { + g_source_remove (helper->banner_info->idle_handler); + helper->banner_info->idle_handler = 0; + } + if (helper->banner_info->banner != NULL) { + gtk_widget_destroy (helper->banner_info->banner); + g_object_unref (helper->banner_info->banner); + helper->banner_info->banner = NULL; + } + g_slice_free (OpenMsgBannerInfo, helper->banner_info); + helper->banner_info = NULL; + } + g_object_unref (helper->model); + g_object_unref (helper->header); + gtk_tree_row_reference_free (helper->rowref); + g_slice_free (OpenMsgHelper, helper); } static void -open_msgs_performer(gboolean canceled, +open_msg_performer(gboolean canceled, GError *err, GtkWindow *parent_window, TnyAccount *account, gpointer user_data) { ModestMailOperation *mail_op = NULL; - const gchar *proto_name; gchar *error_msg; - ModestTransportStoreProtocol proto; - TnyList *not_opened_headers; + ModestProtocolType proto; TnyConnectionStatus status; + OpenMsgHelper *helper = NULL; + ModestProtocol *protocol; + ModestProtocolRegistry *protocol_registry; + gchar *subject; - not_opened_headers = TNY_LIST (user_data); + helper = (OpenMsgHelper *) user_data; status = tny_account_get_connection_status (account); if (err || canceled) { - /* Unregister the already registered headers */ - tny_list_foreach (not_opened_headers, foreach_unregister_headers, - modest_runtime_get_window_mgr ()); + modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), helper->header); + /* Free the helper */ + open_msg_helper_destroyer (helper); + + /* In memory full conditions we could get this error here */ + check_memory_full_error ((GtkWidget *) parent_window, err); + goto clean; } /* Get the error message depending on the protocol */ - proto_name = tny_account_get_proto (account); - if (proto_name != NULL) { - proto = modest_protocol_info_get_transport_store_protocol (proto_name); - } else { - proto = MODEST_PROTOCOL_STORE_MAILDIR; + proto = modest_tny_account_get_protocol_type (account); + if (proto == MODEST_PROTOCOL_REGISTRY_TYPE_INVALID) { + proto = MODEST_PROTOCOLS_STORE_MAILDIR; } - - /* Create the error messages */ - if (tny_list_get_length (not_opened_headers) == 1) { - if (proto == MODEST_PROTOCOL_STORE_POP) { - error_msg = g_strdup (_("emev_ni_ui_pop3_msg_recv_error")); - } else if (proto == MODEST_PROTOCOL_STORE_IMAP) { - TnyIterator *iter = tny_list_create_iterator (not_opened_headers); - TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter)); - error_msg = g_strdup_printf (_("emev_ni_ui_imap_message_not_available_in_server"), - tny_header_get_subject (header)); - g_object_unref (header); - g_object_unref (iter); - } else { - error_msg = g_strdup (_("mail_ni_ui_folder_get_msg_folder_error")); - } - } else { + + protocol_registry = modest_runtime_get_protocol_registry (); + subject = tny_header_dup_subject (helper->header); + + protocol = modest_protocol_registry_get_protocol_by_type (protocol_registry, proto); + error_msg = modest_protocol_get_translation (protocol, MODEST_PROTOCOL_TRANSLATION_MSG_NOT_AVAILABLE, subject); + if (subject) + g_free (subject); + + if (error_msg == NULL) { error_msg = g_strdup (_("mail_ni_ui_folder_get_msg_folder_error")); } +#ifndef MODEST_TOOLKIT_HILDON2 + gboolean show_open_draft = FALSE; + if (modest_protocol_registry_protocol_type_has_tag (protocol_registry, + proto, + MODEST_PROTOCOL_REGISTRY_LOCAL_STORE_PROTOCOLS)) { + TnyFolder *folder; + TnyFolderType folder_type; + + folder = tny_header_get_folder (helper->header); + folder_type = modest_tny_folder_get_local_or_mmc_folder_type (folder); + show_open_draft = (folder_type == TNY_FOLDER_TYPE_DRAFTS); + g_object_unref (folder); + } +#endif + +#ifdef MODEST_TOOLKIT_HILDON2 + gboolean is_draft; + gboolean can_open; + gchar *account_name = get_info_from_header (helper->header, &is_draft, &can_open); + + if (!can_open) { + modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), helper->header); + g_free (account_name); + open_msg_helper_destroyer (helper); + goto clean; + } + + if (!is_draft) { + ModestWindow *window; + GtkWidget *header_view; + gchar *uid; + + header_view = get_header_view_from_window (MODEST_WINDOW (parent_window)); + uid = modest_tny_folder_get_header_unique_id (helper->header); + if (header_view) { + window = modest_msg_view_window_new_from_header_view + (MODEST_HEADER_VIEW (header_view), account_name, uid, helper->rowref); + if (window != NULL) { + if (!modest_window_mgr_register_window (modest_runtime_get_window_mgr (), + window, NULL)) { + gtk_widget_destroy (GTK_WIDGET (window)); + } else { + gtk_widget_show_all (GTK_WIDGET(window)); + } + } + } + g_free (account_name); + g_free (uid); + open_msg_helper_destroyer (helper); + goto clean; + } + g_free (account_name); +#endif /* Create the mail operation */ mail_op = modest_mail_operation_new_with_error_handling ((GObject *) parent_window, - modest_ui_actions_get_msgs_full_error_handler, + modest_ui_actions_disk_operations_error_handler, error_msg, g_free); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - + + +#ifndef MODEST_TOOLKIT_HILDON2 + if (show_open_draft) { + helper->banner_info = g_slice_new (OpenMsgBannerInfo); + helper->banner_info->message = g_strdup (_("mail_ib_opening_draft_message")); + helper->banner_info->banner = NULL; + helper->banner_info->idle_handler = g_timeout_add (500, open_msg_banner_idle, + helper->banner_info); + } +#endif + + + TnyList *headers; + headers = TNY_LIST (tny_simple_list_new ()); + tny_list_prepend (headers, G_OBJECT (helper->header)); modest_mail_operation_get_msgs_full (mail_op, - not_opened_headers, + headers, open_msg_cb, - NULL, - NULL); + helper, + open_msg_helper_destroyer); + g_object_unref (headers); /* Frees */ clean: if (mail_op) g_object_unref (mail_op); - g_object_unref (not_opened_headers); g_object_unref (account); } @@ -1106,143 +1464,172 @@ open_msgs_performer(gboolean canceled, * same when trying to open messages. */ static void -open_msgs_from_headers (TnyList *headers, ModestWindow *win) +open_msg_from_header (TnyHeader *header, GtkTreeRowReference *rowref, ModestWindow *win) { ModestWindowMgr *mgr = NULL; - TnyIterator *iter = NULL, *iter_not_opened = NULL; - TnyList *not_opened_headers = NULL; - TnyHeaderFlags flags = 0; TnyAccount *account; - gint uncached_msgs = 0; - - g_return_if_fail (headers != NULL); + gboolean cached = FALSE; + gboolean found; + GtkWidget *header_view = NULL; + OpenMsgHelper *helper; + ModestWindow *window; - /* Check that only one message is selected for opening */ - if (tny_list_get_length (headers) != 1) { - modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, - _("mcen_ib_select_one_message")); - return; - } + g_return_if_fail (header != NULL && rowref != NULL); mgr = modest_runtime_get_window_mgr (); - iter = tny_list_create_iterator (headers); + + /* get model */ + header_view = get_header_view_from_window (MODEST_WINDOW (win)); + if (header_view == NULL) + return; /* Get the account */ - account = get_account_from_header_list (headers); - - /* Look if we already have a message view for each header. If - true, then remove the header from the list of headers to - open */ - not_opened_headers = tny_simple_list_new (); - while (!tny_iterator_is_done (iter)) { + account = get_account_from_header (header); + if (!account) + return; - ModestWindow *window = NULL; - TnyHeader *header = NULL; - gboolean found = FALSE; - - header = TNY_HEADER (tny_iterator_get_current (iter)); - if (header) - flags = tny_header_get_flags (header); + window = NULL; + found = modest_window_mgr_find_registered_header (mgr, header, &window); - window = NULL; - found = modest_window_mgr_find_registered_header (mgr, header, &window); - - /* Do not open again the message and present the - window to the user */ - if (found) { - if (window) - gtk_window_present (GTK_WINDOW (window)); - else - /* the header has been registered already, we don't do - * anything but wait for the window to come up*/ - g_debug ("header %p already registered, waiting for window", header); + /* Do not open again the message and present the + window to the user */ + if (found) { + if (window) { +#ifndef MODEST_TOOLKIT_HILDON2 + gtk_window_present (GTK_WINDOW (window)); +#endif } else { - tny_list_append (not_opened_headers, G_OBJECT (header)); + /* the header has been registered already, we don't do + * anything but wait for the window to come up*/ + g_debug ("header %p already registered, waiting for window", header); } - - if (header) - g_object_unref (header); - - tny_iterator_next (iter); + goto cleanup; } - g_object_unref (iter); - iter = NULL; /* Open each message */ - if (tny_list_get_length (not_opened_headers) == 0) - goto cleanup; - - /* If some messages would have to be downloaded, ask the user to - * make a connection. It's generally easier to do this here (in the mainloop) - * than later in a thread: - */ - if (tny_list_get_length (not_opened_headers) > 0) { - uncached_msgs = header_list_count_uncached_msgs (not_opened_headers); - - if (uncached_msgs > 0) { - /* Allways download if we are online. */ - if (!tny_device_is_online (modest_runtime_get_device ())) { - gint response; - - /* If ask for user permission to download the messages */ - response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win), - ngettext("mcen_nc_get_msg", - "mcen_nc_get_msgs", - uncached_msgs)); - - /* End if the user does not want to continue */ - if (response == GTK_RESPONSE_CANCEL) - goto cleanup; + cached = tny_header_get_flags (header) & TNY_HEADER_FLAG_CACHED; + if (!cached) { + /* Allways download if we are online. */ + if (!tny_device_is_online (modest_runtime_get_device ())) { + gint response; + + /* If ask for user permission to download the messages */ + response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win), + _("mcen_nc_get_msg")); + + /* End if the user does not want to continue */ + if (response == GTK_RESPONSE_CANCEL) { + goto cleanup; } } } - - /* Register the headers before actually creating the windows: */ - iter_not_opened = tny_list_create_iterator (not_opened_headers); - while (!tny_iterator_is_done (iter_not_opened)) { - TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter_not_opened)); - if (header) { - modest_window_mgr_register_header (mgr, header, NULL); - g_object_unref (header); - } - tny_iterator_next (iter_not_opened); - } - g_object_unref (iter_not_opened); - iter_not_opened = NULL; + + /* We register the window for opening */ + modest_window_mgr_register_header (mgr, header, NULL); + + /* Create the helper. We need to get a reference to the model + here because it could change while the message is readed + (the user could switch between folders) */ + helper = g_slice_new (OpenMsgHelper); + helper->model = g_object_ref (gtk_tree_view_get_model (GTK_TREE_VIEW (header_view))); + helper->header = g_object_ref (header); + helper->rowref = gtk_tree_row_reference_copy (rowref); + helper->banner_info = NULL; /* Connect to the account and perform */ - if (uncached_msgs > 0) { + if (!cached) { modest_platform_connect_and_perform ((GtkWindow *) win, TRUE, g_object_ref (account), - open_msgs_performer, g_object_ref (not_opened_headers)); + open_msg_performer, helper); } else { /* Call directly the performer, do not need to connect */ - open_msgs_performer (FALSE, NULL, (GtkWindow *) win, g_object_ref (account), - g_object_ref (not_opened_headers)); + open_msg_performer (FALSE, NULL, (GtkWindow *) win, + g_object_ref (account), helper); } cleanup: /* Clean */ if (account) g_object_unref (account); - if (not_opened_headers) - g_object_unref (not_opened_headers); } void modest_ui_actions_on_open (GtkAction *action, ModestWindow *win) { TnyList *headers; + TnyHeader *header; + gint headers_count; + TnyIterator *iter; + + /* we check for low-mem; in that case, show a warning, and don't allow + * opening + */ + if (modest_platform_check_memory_low (MODEST_WINDOW(win), TRUE)) + return; /* Get headers */ headers = get_selected_headers (win); if (!headers) return; + headers_count = tny_list_get_length (headers); + if (headers_count != 1) { + if (headers_count > 1) { + /* Don't allow activation if there are more than one message selected */ + modest_platform_information_banner (NULL, NULL, _("mcen_ib_select_one_message")); + } + + g_object_unref (headers); + return; + } + + iter = tny_list_create_iterator (headers); + header = TNY_HEADER (tny_iterator_get_current (iter)); + g_object_unref (iter); + /* Open them */ - open_msgs_from_headers (headers, win); + if (header) { + open_msg_from_header (header, NULL, win); + g_object_unref (header); + } g_object_unref(headers); } +static void +rf_helper_window_closed (gpointer data, + GObject *object) +{ + ReplyForwardHelper *helper = (ReplyForwardHelper *) data; + + helper->parent_window = NULL; +} + +static ReplyForwardHelper* +create_reply_forward_helper (ReplyForwardAction action, + ModestWindow *win, + guint reply_forward_type, + TnyHeader *header) +{ + ReplyForwardHelper *rf_helper = NULL; + const gchar *active_acc = modest_window_get_active_account (win); + + rf_helper = g_slice_new0 (ReplyForwardHelper); + rf_helper->reply_forward_type = reply_forward_type; + rf_helper->action = action; + rf_helper->parent_window = (MODEST_IS_WINDOW (win)) ? GTK_WIDGET (win) : NULL; + rf_helper->header = (header) ? g_object_ref (header) : NULL; + rf_helper->account_name = (active_acc) ? + g_strdup (active_acc) : + modest_account_mgr_get_default_account (modest_runtime_get_account_mgr()); + + /* Note that window could be destroyed just AFTER calling + register_window so we must ensure that this pointer does + not hold invalid references */ + if (rf_helper->parent_window) + g_object_weak_ref (G_OBJECT (rf_helper->parent_window), + rf_helper_window_closed, rf_helper); + + return rf_helper; +} static void free_reply_forward_helper (gpointer data) @@ -1251,6 +1638,11 @@ free_reply_forward_helper (gpointer data) helper = (ReplyForwardHelper *) data; g_free (helper->account_name); + if (helper->header) + g_object_unref (helper->header); + if (helper->parent_window) + g_object_weak_unref (G_OBJECT (helper->parent_window), + rf_helper_window_closed, helper); g_slice_free (ReplyForwardHelper, helper); } @@ -1262,7 +1654,7 @@ reply_forward_cb (ModestMailOperation *mail_op, GError *err, gpointer user_data) { - TnyMsg *new_msg; + TnyMsg *new_msg = NULL; ReplyForwardHelper *rf_helper; ModestWindow *msg_win = NULL; ModestEditType edit_type; @@ -1275,11 +1667,9 @@ reply_forward_cb (ModestMailOperation *mail_op, /* If there was any error. The mail operation could be NULL, this means that we already have the message downloaded and that we didn't do a mail operation to retrieve it */ - if (mail_op && !modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) - return; - - g_return_if_fail (user_data != NULL); rf_helper = (ReplyForwardHelper *) user_data; + if (mail_op && !modest_ui_actions_msg_retrieval_check (mail_op, header, msg)) + goto cleanup; from = modest_account_mgr_get_from_string (modest_runtime_get_account_mgr(), rf_helper->account_name); @@ -1311,14 +1701,17 @@ reply_forward_cb (ModestMailOperation *mail_op, edit_type = MODEST_EDIT_TYPE_FORWARD; break; default: + modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), + header); g_return_if_reached (); return; } + g_free (from); g_free (signature); if (!new_msg) { - g_printerr ("modest: failed to create message\n"); + g_warning ("%s: failed to create message\n", __FUNCTION__); goto cleanup; } @@ -1326,16 +1719,17 @@ reply_forward_cb (ModestMailOperation *mail_op, rf_helper->account_name, TNY_ACCOUNT_TYPE_STORE); if (!account) { - g_printerr ("modest: failed to get tnyaccount for '%s'\n", rf_helper->account_name); + g_warning ("%s: failed to get tnyaccount for '%s'\n", __FUNCTION__, rf_helper->account_name); goto cleanup; } /* Create and register the windows */ msg_win = modest_msg_edit_window_new (new_msg, rf_helper->account_name, FALSE); mgr = modest_runtime_get_window_mgr (); - modest_window_mgr_register_window (mgr, msg_win); + modest_window_mgr_register_window (mgr, msg_win, (ModestWindow *) rf_helper->parent_window); - if (rf_helper->parent_window != NULL) { + /* Note that register_window could have deleted the account */ + if (MODEST_IS_WINDOW (rf_helper->parent_window)) { gdouble parent_zoom; parent_zoom = modest_window_get_zoom (MODEST_WINDOW (rf_helper->parent_window)); @@ -1346,13 +1740,15 @@ reply_forward_cb (ModestMailOperation *mail_op, gtk_widget_show_all (GTK_WIDGET (msg_win)); cleanup: - if (msg_win) - g_object_unref (msg_win); + /* We always unregister the header because the message is + forwarded or replied so the original one is no longer + opened */ + modest_window_mgr_unregister_header (modest_runtime_get_window_mgr (), + header); if (new_msg) g_object_unref (G_OBJECT (new_msg)); if (account) g_object_unref (G_OBJECT (account)); -/* g_object_unref (msg); */ free_reply_forward_helper (rf_helper); } @@ -1409,132 +1805,170 @@ connect_to_get_msg (ModestWindow *win, return modest_platform_connect_and_wait((GtkWindow *) win, account); } +static void +reply_forward_performer (gboolean canceled, + GError *err, + GtkWindow *parent_window, + TnyAccount *account, + gpointer user_data) +{ + ReplyForwardHelper *rf_helper = NULL; + ModestMailOperation *mail_op; + + rf_helper = (ReplyForwardHelper *) user_data; + + if (canceled || err) { + free_reply_forward_helper (rf_helper); + return; + } + + /* Retrieve the message */ + modest_window_mgr_register_header (modest_runtime_get_window_mgr (), rf_helper->header, NULL); + mail_op = modest_mail_operation_new_with_error_handling (G_OBJECT (parent_window), + modest_ui_actions_disk_operations_error_handler, + NULL, NULL); + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); + modest_mail_operation_get_msg (mail_op, rf_helper->header, TRUE, reply_forward_cb, rf_helper); + + /* Frees */ + g_object_unref(mail_op); +} + /* * Common code for the reply and forward actions */ static void reply_forward (ReplyForwardAction action, ModestWindow *win) { - ModestMailOperation *mail_op = NULL; - TnyList *header_list = NULL; ReplyForwardHelper *rf_helper = NULL; guint reply_forward_type; - gboolean continue_download = TRUE; - gboolean do_retrieve = TRUE; - + g_return_if_fail (MODEST_IS_WINDOW(win)); + /* we check for low-mem; in that case, show a warning, and don't allow + * reply/forward (because it could potentially require a lot of memory */ + if (modest_platform_check_memory_low (MODEST_WINDOW(win), TRUE)) + return; + + /* we need an account when editing */ if (!modest_account_mgr_has_accounts(modest_runtime_get_account_mgr(), TRUE)) { if (!modest_ui_actions_run_account_setup_wizard (win)) return; } - - header_list = get_selected_headers (win); - if (!header_list) - return; - reply_forward_type = + reply_forward_type = modest_conf_get_int (modest_runtime_get_conf (), - (action == ACTION_FORWARD) ? MODEST_CONF_FORWARD_TYPE : MODEST_CONF_REPLY_TYPE, + (action == ACTION_FORWARD) ? + MODEST_CONF_FORWARD_TYPE : + MODEST_CONF_REPLY_TYPE, NULL); - /* check if we need to download msg before asking about it */ - do_retrieve = (action == ACTION_FORWARD) || - (reply_forward_type != MODEST_TNY_MSG_REPLY_TYPE_CITE); - - if (do_retrieve){ - gint num_of_unc_msgs; - - /* check that the messages have been previously downloaded */ - num_of_unc_msgs = header_list_count_uncached_msgs(header_list); - /* If there are any uncached message ask the user - * whether he/she wants to download them. */ - if (num_of_unc_msgs) { - TnyAccount *account = get_account_from_header_list (header_list); - continue_download = connect_to_get_msg (win, num_of_unc_msgs, account); - g_object_unref (account); - } - } - - if (!continue_download) { - g_object_unref (header_list); - return; - } - - /* We assume that we can only select messages of the - same folder and that we reply all of them from the - same account. In fact the interface currently only - allows single selection */ - - /* Fill helpers */ - rf_helper = g_slice_new0 (ReplyForwardHelper); - rf_helper->reply_forward_type = reply_forward_type; - rf_helper->action = action; - rf_helper->account_name = g_strdup (modest_window_get_active_account (win)); - - if ((win != NULL) && (MODEST_IS_WINDOW (win))) - rf_helper->parent_window = GTK_WIDGET (win); - if (!rf_helper->account_name) - rf_helper->account_name = - modest_account_mgr_get_default_account (modest_runtime_get_account_mgr()); - - if (MODEST_IS_MSG_VIEW_WINDOW(win)) { - TnyMsg *msg; - TnyHeader *header; + if (MODEST_IS_MSG_VIEW_WINDOW (win)) { + TnyMsg *msg = NULL; + TnyHeader *header = NULL; /* Get header and message. Do not free them here, the reply_forward_cb must do it */ msg = modest_msg_view_window_get_message (MODEST_MSG_VIEW_WINDOW(win)); - header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW(win)); - if (!msg || !header) { - if (msg) - g_object_unref (msg); - g_printerr ("modest: no message found\n"); - return; - } else { + header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (win)); + + if (msg && header) { + /* Create helper */ + rf_helper = create_reply_forward_helper (action, win, + reply_forward_type, header); reply_forward_cb (NULL, header, FALSE, msg, NULL, rf_helper); + } else { + g_warning("%s: no message or header found in viewer\n", __FUNCTION__); } - if (header) + + if (msg) + g_object_unref (msg); + if (header) g_object_unref (header); } else { - TnyHeader *header; + TnyHeader *header = NULL; TnyIterator *iter; + gboolean do_retrieve = TRUE; + TnyList *header_list = NULL; + + header_list = get_selected_headers (win); + if (!header_list) + return; + /* Check that only one message is selected for replying */ + if (tny_list_get_length (header_list) != 1) { + modest_platform_information_banner ((win) ? GTK_WIDGET (win) : NULL, + NULL, _("mcen_ib_select_one_message")); + g_object_unref (header_list); + return; + } /* Only reply/forward to one message */ iter = tny_list_create_iterator (header_list); header = TNY_HEADER (tny_iterator_get_current (iter)); g_object_unref (iter); - if (header) { - /* Retrieve messages */ - if (do_retrieve) { - mail_op = - modest_mail_operation_new_with_error_handling (G_OBJECT(win), - modest_ui_actions_get_msgs_full_error_handler, - NULL, NULL); - modest_mail_operation_queue_add ( - modest_runtime_get_mail_operation_queue (), mail_op); - - modest_mail_operation_get_msg (mail_op, - header, - reply_forward_cb, - rf_helper); - /* Clean */ - g_object_unref(mail_op); - } else { - /* we put a ref here to prevent double unref as the reply - * forward callback unrefs the header at its end */ - reply_forward_cb (NULL, header, FALSE, NULL, NULL, rf_helper); - } + /* Retrieve messages */ + do_retrieve = (action == ACTION_FORWARD) || + (reply_forward_type != MODEST_TNY_MSG_REPLY_TYPE_CITE); + if (do_retrieve) { + TnyAccount *account = NULL; + TnyFolder *folder = NULL; + gdouble download = TRUE; + guint uncached_msgs = 0; + + folder = tny_header_get_folder (header); + if (!folder) + goto do_retrieve_frees; + account = tny_folder_get_account (folder); + if (!account) + goto do_retrieve_frees; + + uncached_msgs = header_list_count_uncached_msgs (header_list); + + if (uncached_msgs > 0) { + /* Allways download if we are online. */ + if (!tny_device_is_online (modest_runtime_get_device ())) { + gint response; + + /* If ask for user permission to download the messages */ + response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win), + ngettext("mcen_nc_get_msg", + "mcen_nc_get_msgs", + uncached_msgs)); + + /* End if the user does not want to continue */ + if (response == GTK_RESPONSE_CANCEL) + download = FALSE; + } + } - g_object_unref (header); + if (download) { + /* Create helper */ + rf_helper = create_reply_forward_helper (action, win, + reply_forward_type, header); + if (uncached_msgs > 0) { + modest_platform_connect_and_perform (GTK_WINDOW (win), + TRUE, account, + reply_forward_performer, + rf_helper); + } else { + reply_forward_performer (FALSE, NULL, GTK_WINDOW (win), + account, rf_helper); + } + } + do_retrieve_frees: + if (account) + g_object_unref (account); + if (folder) + g_object_unref (folder); + } else { + reply_forward_cb (NULL, header, FALSE, NULL, NULL, rf_helper); } - + /* Frees */ + g_object_unref (header_list); + g_object_unref (header); } - - /* Free */ - g_object_unref (header_list); } void @@ -1609,21 +2043,27 @@ void modest_ui_actions_on_sort (GtkAction *action, ModestWindow *window) { + GtkWidget *header_view = NULL; + g_return_if_fail (MODEST_IS_WINDOW(window)); if (MODEST_IS_MAIN_WINDOW (window)) { - GtkWidget *header_view; header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(window), MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); - if (!header_view) { - modest_platform_information_banner (NULL, NULL, _CS("ckdg_ib_nothing_to_sort")); - - return; - } +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_HEADER_WINDOW (window)) { + header_view = GTK_WIDGET (modest_header_window_get_header_view (MODEST_HEADER_WINDOW (window))); +#endif + } - /* Show sorting dialog */ - modest_platform_run_sort_dialog (GTK_WINDOW (window), MODEST_SORT_HEADERS); + if (!header_view) { + modest_platform_information_banner (NULL, NULL, _CS("ckdg_ib_nothing_to_sort")); + + return; } + + /* Show sorting dialog */ + modest_utils_run_sort_dialog (GTK_WINDOW (window), MODEST_SORT_HEADERS); } static void @@ -1676,6 +2116,9 @@ typedef struct { TnyAccount *account; ModestWindow *win; gchar *account_name; + gboolean poke_status; + gboolean interactive; + ModestMailOperation *mail_op; } SendReceiveInfo; static void @@ -1685,12 +2128,18 @@ do_send_receive_performer (gboolean canceled, TnyAccount *account, gpointer user_data) { - ModestMailOperation *mail_op; SendReceiveInfo *info; info = (SendReceiveInfo *) user_data; if (err || canceled) { + /* In memory full conditions we could get this error here */ + check_memory_full_error ((GtkWidget *) parent_window, err); + + if (info->mail_op) { + modest_mail_operation_queue_remove (modest_runtime_get_mail_operation_queue (), + info->mail_op); + } goto clean; } @@ -1698,25 +2147,21 @@ do_send_receive_performer (gboolean canceled, if (info->win && MODEST_IS_MAIN_WINDOW (info->win)) { modest_main_window_notify_send_receive_initied (MODEST_MAIN_WINDOW (info->win)); } - - mail_op = modest_mail_operation_new_with_error_handling ((info->win) ? G_OBJECT (info->win) : NULL, - modest_ui_actions_send_receive_error_handler, - NULL, NULL); if (info->win && MODEST_IS_MAIN_WINDOW (info->win)) - g_signal_connect (G_OBJECT(mail_op), "operation-finished", + g_signal_connect (G_OBJECT (info->mail_op), "operation-finished", G_CALLBACK (on_send_receive_finished), info->win); /* Send & receive. */ - modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_update_account (mail_op, info->account_name, (info->win) ? FALSE : TRUE, + modest_mail_operation_update_account (info->mail_op, info->account_name, info->poke_status, info->interactive, (info->win) ? retrieve_all_messages_cb : NULL, new_messages_arrived, info->win); - g_object_unref (G_OBJECT (mail_op)); clean: /* Frees */ + if (info->mail_op) + g_object_unref (G_OBJECT (info->mail_op)); if (info->account_name) g_free (info->account_name); if (info->win) @@ -1735,6 +2180,8 @@ do_send_receive_performer (gboolean canceled, void modest_ui_actions_do_send_receive (const gchar *account_name, gboolean force_connection, + gboolean poke_status, + gboolean interactive, ModestWindow *win) { gchar *acc_name = NULL; @@ -1762,8 +2209,17 @@ modest_ui_actions_do_send_receive (const gchar *account_name, info = g_slice_new (SendReceiveInfo); info->account_name = acc_name; info->win = (win) ? g_object_ref (win) : NULL; + info->poke_status = poke_status; + info->interactive = interactive; info->account = modest_tny_account_store_get_server_account (acc_store, acc_name, TNY_ACCOUNT_TYPE_STORE); + /* We need to create the operation here, because otherwise it + could happen that the queue emits the queue-empty signal + while we're trying to connect the account */ + info->mail_op = modest_mail_operation_new_with_error_handling ((info->win) ? G_OBJECT (info->win) : NULL, + modest_ui_actions_disk_operations_error_handler, + NULL, NULL); + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), info->mail_op); /* Invoke the connect and perform */ modest_platform_connect_and_perform ((win) ? GTK_WINDOW (win) : NULL, @@ -1792,7 +2248,7 @@ modest_ui_actions_do_cancel_send (const gchar *account_name, } /* Get send queue*/ - send_queue = TNY_SEND_QUEUE (modest_runtime_get_send_queue (transport_account)); + send_queue = TNY_SEND_QUEUE (modest_runtime_get_send_queue (transport_account, TRUE)); if (!TNY_IS_SEND_QUEUE(send_queue)) { g_set_error (&error, MODEST_MAIL_OPERATION_ERROR, MODEST_MAIL_OPERATION_ERROR_ITEM_NOT_FOUND, @@ -1850,7 +2306,9 @@ modest_ui_actions_cancel_send (GtkAction *action, ModestWindow *win) */ void modest_ui_actions_do_send_receive_all (ModestWindow *win, - gboolean force_connection) + gboolean force_connection, + gboolean poke_status, + gboolean interactive) { GSList *account_names, *iter; @@ -1859,7 +2317,9 @@ modest_ui_actions_do_send_receive_all (ModestWindow *win, iter = account_names; while (iter) { - modest_ui_actions_do_send_receive ((const char*) iter->data, force_connection, win); + modest_ui_actions_do_send_receive ((const char*) iter->data, + force_connection, + poke_status, interactive, win); iter = g_slist_next (iter); } @@ -1898,10 +2358,20 @@ modest_ui_actions_on_send_receive (GtkAction *action, ModestWindow *win) if (folder_store) g_object_unref (folder_store); - } + /* Refresh the active account. Force the connection if needed + and poke the status of all folders */ + modest_ui_actions_do_send_receive (NULL, TRUE, TRUE, TRUE, win); +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_ACCOUNTS_WINDOW (win)) { + modest_ui_actions_do_send_receive_all (win, TRUE, TRUE, TRUE); +#endif + } else { + const gchar *active_account; + active_account = modest_window_get_active_account (MODEST_WINDOW (win)); + + modest_ui_actions_do_send_receive (active_account, TRUE, TRUE, TRUE, win); + } - /* Refresh the active account. Force the connection if needed */ - modest_ui_actions_do_send_receive (NULL, TRUE, win); } @@ -1954,8 +2424,10 @@ modest_ui_actions_on_header_selected (ModestHeaderView *header_view, GtkWidget *folder_view = modest_main_window_get_child_widget (main_window, MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); - if (folder != NULL) + if (folder != NULL) { modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), folder, FALSE); + g_object_unref (folder); + } gtk_widget_grab_focus (GTK_WIDGET (folder_view)); return; } @@ -1969,34 +2441,45 @@ modest_ui_actions_on_header_selected (ModestHeaderView *header_view, gtk_widget_grab_focus (GTK_WIDGET(header_view)); /* Update toolbar dimming state */ + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (main_window)); modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); } void modest_ui_actions_on_header_activated (ModestHeaderView *header_view, TnyHeader *header, - ModestMainWindow *main_window) + GtkTreePath *path, + ModestWindow *window) { - TnyList *headers; - - g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window)); + GtkWidget *open_widget; + GtkTreeRowReference *rowref; - if (!header) - return; + g_return_if_fail (MODEST_IS_WINDOW(window)); + g_return_if_fail (MODEST_IS_HEADER_VIEW (header_view)); + g_return_if_fail (TNY_IS_HEADER (header)); if (modest_header_view_count_selected_headers (header_view) > 1) { + /* Don't allow activation if there are more than one message selected */ modest_platform_information_banner (NULL, NULL, _("mcen_ib_select_one_message")); return; } + /* we check for low-mem; in that case, show a warning, and don't allow + * activating headers + */ + if (modest_platform_check_memory_low (MODEST_WINDOW(window), TRUE)) + return; -/* headers = tny_simple_list_new (); */ -/* tny_list_prepend (headers, G_OBJECT (header)); */ - headers = modest_header_view_get_selected_headers (header_view); - - open_msgs_from_headers (headers, MODEST_WINDOW (main_window)); + if (MODEST_IS_MAIN_WINDOW (window)) { + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (window)); + open_widget = modest_window_get_action_widget (MODEST_WINDOW (window), "/MenuBar/EmailMenu/EmailOpenMenu"); + if (!GTK_WIDGET_IS_SENSITIVE (open_widget)) + return; + } - g_object_unref (headers); + rowref = gtk_tree_row_reference_new (gtk_tree_view_get_model (GTK_TREE_VIEW (header_view)), path); + open_msg_from_header (header, rowref, MODEST_WINDOW (window)); + gtk_tree_row_reference_free (rowref); } static void @@ -2036,29 +2519,43 @@ folder_refreshed_cb (ModestMailOperation *mail_op, gpointer user_data) { ModestMainWindow *win = NULL; - GtkWidget *header_view; + GtkWidget *folder_view; + const GError *error; g_return_if_fail (TNY_IS_FOLDER (folder)); win = MODEST_MAIN_WINDOW (user_data); - header_view = - modest_main_window_get_child_widget(win, MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); - if (header_view) { - TnyFolder *current_folder; + /* Check if the operation failed due to memory low conditions */ + error = modest_mail_operation_get_error (mail_op); + if (error && error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_LOW_MEMORY) { + modest_platform_run_information_dialog (GTK_WINDOW (win), + _KR("memr_ib_operation_disabled"), + TRUE); + return; + } - current_folder = modest_header_view_get_folder (MODEST_HEADER_VIEW (header_view)); - if (current_folder != NULL && folder != current_folder) { - g_object_unref (current_folder); - return; - } else if (current_folder) + folder_view = + modest_main_window_get_child_widget(win, MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + + if (folder_view) { + TnyFolderStore *current_folder; + + current_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); + if (current_folder) { + gboolean different = ((TnyFolderStore *) folder != current_folder); g_object_unref (current_folder); + if (different) + return; + } } /* Check if folder is empty and set headers view contents style */ if (tny_folder_get_all_count (folder) == 0) modest_main_window_set_contents_style (win, MODEST_MAIN_WINDOW_CONTENTS_STYLE_EMPTY); + } void @@ -2088,11 +2585,15 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, } } else { if (TNY_IS_FOLDER (folder_store) && selected) { - + TnyAccount *account; + const gchar *account_name = NULL; + /* Update the active account */ - TnyAccount *account = modest_tny_folder_get_account (TNY_FOLDER (folder_store)); + account = modest_tny_folder_get_account (TNY_FOLDER (folder_store)); if (account) { set_active_account_from_tny_account (account, MODEST_WINDOW (main_window)); + account_name = + modest_tny_account_get_parent_modest_account_name_for_server_account (account); g_object_unref (account); account = NULL; } @@ -2110,6 +2611,8 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, empty view if there are no messages */ modest_header_view_set_folder (MODEST_HEADER_VIEW(header_view), TNY_FOLDER (folder_store), + TRUE, + MODEST_WINDOW (main_window), folder_refreshed_cb, main_window); @@ -2121,18 +2624,24 @@ modest_ui_actions_on_folder_selection_changed (ModestFolderView *folder_view, G_OBJECT(header_view), MODEST_CONF_HEADER_VIEW_KEY); } else { - /* Update the active account */ - //modest_window_set_active_account (MODEST_WINDOW (main_window), NULL); - /* Save only if we're seeing headers */ + /* No need to save the header view + configuration for Maemo because it only + saves the sorting stuff and that it's + already being done by the sort + dialog. Remove it when the GNOME version + has the same behaviour */ +#ifdef MODEST_TOOLKIT_GTK if (modest_main_window_get_contents_style (main_window) == MODEST_MAIN_WINDOW_CONTENTS_STYLE_HEADERS) modest_widget_memory_save (conf, G_OBJECT (header_view), MODEST_CONF_HEADER_VIEW_KEY); +#endif modest_header_view_clear (MODEST_HEADER_VIEW(header_view)); } } - /* Update toolbar dimming state */ + /* Update dimming state */ + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (main_window)); modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (main_window)); } @@ -2209,6 +2718,12 @@ void modest_ui_actions_on_msg_attachment_clicked (ModestMsgView *msgview, TnyMimePart *mime_part, ModestWindow *win) { + /* we check for low-mem; in that case, show a warning, and don't allow + * viewing attachments + */ + if (modest_platform_check_memory_low (MODEST_WINDOW(win), TRUE)) + return; + modest_msg_view_window_view_attachment (MODEST_MSG_VIEW_WINDOW (win), mime_part); } @@ -2226,6 +2741,9 @@ on_save_to_drafts_cb (ModestMailOperation *mail_op, gpointer user_data) { ModestMsgEditWindow *edit_window; + + /* TODO: in hildon 2 we have to dim and undim the header views while we're saving */ +#ifndef MODEST_TOOLKIT_HILDON2 ModestMainWindow *win; /* FIXME. Make the header view sensitive again. This is a @@ -2238,21 +2756,71 @@ on_save_to_drafts_cb (ModestMailOperation *mail_op, win, MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); if (hdrview) gtk_widget_set_sensitive(hdrview, TRUE); } +#endif edit_window = MODEST_MSG_EDIT_WINDOW (user_data); - /* It might not be a good idea to do nothing if there was an error, - * so let's at least show a generic error banner. */ - /* TODO error while saving attachment, show "Saving draft failed" banner */ - if (modest_mail_operation_get_error (mail_op) != NULL) { - g_warning ("%s failed: %s\n", __FUNCTION__, (modest_mail_operation_get_error (mail_op))->message); - modest_platform_information_banner (NULL, NULL, _("mail_ib_file_operation_failed")); - } else { + /* Set draft is there was no error */ + if (!modest_mail_operation_get_error (mail_op)) modest_msg_edit_window_set_draft (edit_window, saved_draft); - } + g_object_unref(edit_window); } +static gboolean +enough_space_for_message (ModestMsgEditWindow *edit_window, + MsgData *data) +{ + TnyAccountStore *acc_store; + guint64 available_disk, expected_size; + gint parts_count; + guint64 parts_size; + + /* Check size */ + acc_store = TNY_ACCOUNT_STORE (modest_runtime_get_account_store()); + available_disk = modest_utils_get_available_space (NULL); + modest_msg_edit_window_get_parts_size (edit_window, &parts_count, &parts_size); + expected_size = modest_tny_msg_estimate_size (data->plain_body, + data->html_body, + parts_count, + parts_size); + + /* Double check: memory full condition or message too big */ + if (available_disk < MIN_FREE_SPACE || + expected_size > available_disk) { + + modest_platform_information_banner (NULL, NULL, + _KR("cerm_device_memory_full")); + return FALSE; + } + + /* + * djcb: if we're in low-memory state, we only allow for + * saving messages smaller than + * MODEST_MAX_LOW_MEMORY_MESSAGE_SIZE (see modest-defs.h) this + * should still allow for sending anything critical... + */ + if ((expected_size > MODEST_MAX_LOW_MEMORY_MESSAGE_SIZE) && + modest_platform_check_memory_low (MODEST_WINDOW(edit_window), TRUE)) + return FALSE; + + /* + * djcb: we also make sure that the attachments are smaller than the max size + * this is for the case where we'd try to forward a message with attachments + * bigger than our max allowed size, or sending an message from drafts which + * somehow got past our checks when attaching. + */ + if (expected_size > MODEST_MAX_ATTACHMENT_SIZE) { + modest_platform_run_information_dialog ( + GTK_WINDOW(edit_window), + _KR("memr_ib_operation_disabled"), + TRUE); + return FALSE; + } + + return TRUE; +} + gboolean modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edit_window) { @@ -2261,28 +2829,16 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi MsgData *data; gchar *account_name, *from; ModestAccountMgr *account_mgr; -/* char *info_text; */ gboolean had_error = FALSE; - guint64 available_disk, expected_size; - gint parts_count; - guint64 parts_size; + ModestMainWindow *win = NULL; g_return_val_if_fail (MODEST_IS_MSG_EDIT_WINDOW(edit_window), FALSE); data = modest_msg_edit_window_get_msg_data (edit_window); /* Check size */ - available_disk = modest_folder_available_space (NULL); - modest_msg_edit_window_get_parts_size (edit_window, &parts_count, &parts_size); - expected_size = modest_tny_msg_estimate_size (data->plain_body, - data->html_body, - parts_count, - parts_size); - - if ((available_disk != -1) && expected_size > available_disk) { + if (!enough_space_for_message (edit_window, data)) { modest_msg_edit_window_free_msg_data (edit_window, data); - - modest_platform_information_banner (NULL, NULL, dgettext("ke-recv", "cerm_device_memory_full")); return FALSE; } @@ -2304,7 +2860,7 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi transport_account = TNY_TRANSPORT_ACCOUNT(modest_tny_account_store_get_server_account - (modest_runtime_get_account_store(), + (modest_runtime_get_account_store (), account_name, TNY_ACCOUNT_TYPE_TRANSPORT)); if (!transport_account) { @@ -2316,7 +2872,8 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi from = modest_account_mgr_get_from_string (account_mgr, account_name); /* Create the mail operation */ - mail_operation = modest_mail_operation_new (NULL); + mail_operation = modest_mail_operation_new_with_error_handling (NULL, modest_ui_actions_disk_operations_error_handler, + NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_operation); modest_mail_operation_save_to_drafts (mail_operation, @@ -2335,8 +2892,27 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi on_save_to_drafts_cb, g_object_ref(edit_window)); -/* info_text = g_strdup_printf (_("mail_va_saved_to_drafts"), _("mcen_me_folder_drafts")); */ - modest_platform_information_banner (NULL, NULL, _CS("sfil_ib_saving")); +#ifdef MODEST_TOOLKIT_HILDON2 + /* In hildon2 we always show the information banner on saving to drafts. + * It will be a system information banner in this case. + */ + gchar *text = g_strdup_printf (_("mail_va_saved_to_drafts"), _("mcen_me_folder_drafts")); + modest_platform_information_banner (NULL, NULL, text); + g_free (text); +#else + /* Use the main window as the parent of the banner, if the + main window does not exist it won't be shown, if the parent + window exists then it's properly shown. We don't use the + editor window because it could be closed (save to drafts + could happen after closing the window */ + win = (ModestMainWindow *) + modest_window_mgr_get_main_window( modest_runtime_get_window_mgr(), FALSE); + if (win) { + gchar *text = g_strdup_printf (_("mail_va_saved_to_drafts"), _("mcen_me_folder_drafts")); + modest_platform_information_banner (GTK_WIDGET (win), NULL, text); + g_free (text); + } +#endif modest_msg_edit_window_set_modified (edit_window, FALSE); /* Frees */ @@ -2362,8 +2938,6 @@ modest_ui_actions_on_save_to_drafts (GtkWidget *widget, ModestMsgEditWindow *edi * we find a better solution it should be removed * See NB#65125 (commend #18) for details. */ - ModestMainWindow *win = MODEST_MAIN_WINDOW(modest_window_mgr_get_main_window( - modest_runtime_get_window_mgr(), FALSE)); if (!had_error && win != NULL) { ModestFolderView *view = MODEST_FOLDER_VIEW(modest_main_window_get_child_widget( win, MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW)); @@ -2393,37 +2967,27 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) { TnyTransportAccount *transport_account = NULL; gboolean had_error = FALSE; - guint64 available_disk, expected_size; - gint parts_count; - guint64 parts_size; + MsgData *data; + ModestAccountMgr *account_mgr; + gchar *account_name; + gchar *from; + ModestMailOperation *mail_operation; g_return_val_if_fail (MODEST_IS_MSG_EDIT_WINDOW(edit_window), TRUE); if (!modest_msg_edit_window_check_names (edit_window, TRUE)) return TRUE; - /* FIXME: Code added just for testing. The final version will - use the send queue provided by tinymail and some - classifier */ - MsgData *data = modest_msg_edit_window_get_msg_data (edit_window); + data = modest_msg_edit_window_get_msg_data (edit_window); /* Check size */ - available_disk = modest_folder_available_space (NULL); - modest_msg_edit_window_get_parts_size (edit_window, &parts_count, &parts_size); - expected_size = modest_tny_msg_estimate_size (data->plain_body, - data->html_body, - parts_count, - parts_size); - - if ((available_disk != -1) && expected_size > available_disk) { + if (!enough_space_for_message (edit_window, data)) { modest_msg_edit_window_free_msg_data (edit_window, data); - - modest_platform_information_banner (NULL, NULL, dgettext("ke-recv", "cerm_device_memory_full")); return FALSE; } - ModestAccountMgr *account_mgr = modest_runtime_get_account_mgr(); - gchar *account_name = g_strdup (data->account_name); + account_mgr = modest_runtime_get_account_mgr(); + account_name = g_strdup (data->account_name); if (!account_name) account_name = g_strdup(modest_window_get_active_account (MODEST_WINDOW(edit_window))); @@ -2440,9 +3004,10 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) /* Get the currently-active transport account for this modest account: */ if (strcmp (account_name, MODEST_LOCAL_FOLDERS_ACCOUNT_ID) != 0) { - transport_account = TNY_TRANSPORT_ACCOUNT(modest_tny_account_store_get_server_account - (modest_runtime_get_account_store(), - account_name, TNY_ACCOUNT_TYPE_TRANSPORT)); + transport_account = + TNY_TRANSPORT_ACCOUNT(modest_tny_account_store_get_server_account + (modest_runtime_get_account_store (), + account_name, TNY_ACCOUNT_TYPE_TRANSPORT)); } if (!transport_account) { @@ -2452,17 +3017,17 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) return TRUE; } - gchar *from = modest_account_mgr_get_from_string (account_mgr, account_name); /* Create the mail operation */ - ModestMailOperation *mail_operation = modest_mail_operation_new (NULL); + from = modest_account_mgr_get_from_string (account_mgr, account_name); + mail_operation = modest_mail_operation_new_with_error_handling (NULL, modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_operation); modest_mail_operation_send_new_mail (mail_operation, transport_account, data->draft_msg, from, - data->to, + data->to, data->cc, data->bcc, data->subject, @@ -2478,7 +3043,8 @@ modest_ui_actions_on_send (GtkWidget *widget, ModestMsgEditWindow *edit_window) if (modest_mail_operation_get_error (mail_operation) != NULL) { const GError *error = modest_mail_operation_get_error (mail_operation); - if (error->code == MODEST_MAIL_OPERATION_ERROR_INSTANCE_CREATION_FAILED) { + if (error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_INSTANCE_CREATION_FAILED) { g_warning ("%s failed: %s\n", __FUNCTION__, (modest_mail_operation_get_error (mail_operation))->message); modest_platform_information_banner (NULL, NULL, _CS("sfil_ni_not_enough_memory")); had_error = TRUE; @@ -2616,11 +3182,14 @@ modest_ui_actions_on_select_editor_background_color (GtkAction *action, } void -modest_ui_actions_on_insert_image (GtkAction *action, +modest_ui_actions_on_insert_image (GObject *object, ModestMsgEditWindow *window) { g_return_if_fail (MODEST_IS_MSG_EDIT_WINDOW (window)); - g_return_if_fail (GTK_IS_ACTION (action)); + + + if (modest_platform_check_memory_low (MODEST_WINDOW(window), TRUE)) + return; if (modest_msg_edit_window_get_format (MODEST_MSG_EDIT_WINDOW(window)) == MODEST_MSG_EDIT_FORMAT_TEXT) return; @@ -2635,6 +3204,9 @@ modest_ui_actions_on_attach_file (GtkAction *action, g_return_if_fail (MODEST_IS_MSG_EDIT_WINDOW (window)); g_return_if_fail (GTK_IS_ACTION (action)); + if (modest_platform_check_memory_low (MODEST_WINDOW(window), TRUE)) + return; + modest_msg_edit_window_offer_attach_file (window); } @@ -2643,11 +3215,42 @@ modest_ui_actions_on_remove_attachments (GtkAction *action, ModestMsgEditWindow *window) { g_return_if_fail (MODEST_IS_MSG_EDIT_WINDOW (window)); - g_return_if_fail (GTK_IS_ACTION (action)); modest_msg_edit_window_remove_attachments (window, NULL); } + +#ifndef MODEST_TOOLKIT_GTK +typedef struct { + guint handler; + gchar *name; + GtkWindow *win; + TnyFolderStore *folder; +} CreateFolderHelper; + +static gboolean +show_create_folder_in_timeout (gpointer data) +{ + CreateFolderHelper *helper = (CreateFolderHelper *) data; + + /* Remove the timeout ASAP, we can not wait until the dialog + is shown because it could take a lot of time and so the + timeout could be called twice or more times */ + g_source_remove (helper->handler); + + gdk_threads_enter (); + do_create_folder (helper->win, helper->folder, helper->name); + gdk_threads_leave (); + + g_object_unref (helper->win); + g_object_unref (helper->folder); + g_free (helper->name); + g_slice_free (CreateFolderHelper, helper); + + return FALSE; +} +#endif + static void do_create_folder_cb (ModestMailOperation *mail_op, TnyFolderStore *parent_folder, @@ -2658,15 +3261,38 @@ do_create_folder_cb (ModestMailOperation *mail_op, GtkWindow *source_win = (GtkWindow *) modest_mail_operation_get_source (mail_op); if (modest_mail_operation_get_error (mail_op)) { - /* Show an error */ - modest_platform_information_banner (GTK_WIDGET (source_win), NULL, - _("mail_in_ui_folder_create_error")); - /* Try again */ + /* Show an error. If there was some problem writing to + disk, show it, otherwise show the generic folder + create error. We do it here and not in an error + handler because the call to do_create_folder will + stop the main loop in a gtk_dialog_run and then, + the message won't be shown until that dialog is + closed */ + modest_ui_actions_disk_operations_error_handler (mail_op, + _("mail_in_ui_folder_create_error")); + + /* Try again. Do *NOT* show any error because the mail + operations system will do it for us because we + created the mail_op with new_with_error_handler */ +#ifndef MODEST_TOOLKIT_GTK + CreateFolderHelper *helper; + helper = g_slice_new0 (CreateFolderHelper); + helper->name = g_strdup (suggested_name); + helper->folder = g_object_ref (parent_folder); + helper->win = g_object_ref (source_win); + + /* Ugly but neccesary stuff. The problem is that the + dialog when is shown calls a function that destroys + all the temporary windows, so the banner is + destroyed */ + helper->handler = g_timeout_add (2000, show_create_folder_in_timeout, helper); +#else do_create_folder (source_win, parent_folder, (const gchar *) suggested_name); +#endif } else { /* the 'source_win' is either the ModestMainWindow, or the 'Move to folder'-dialog - * FIXME: any other? */ + * FIXME: any other? */ GtkWidget *folder_view; if (MODEST_IS_MAIN_WINDOW(source_win)) @@ -2674,12 +3300,15 @@ do_create_folder_cb (ModestMailOperation *mail_op, modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (source_win), MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); else - folder_view = - get_folder_view_from_move_to_dialog (GTK_WIDGET(source_win)); - - /* Select the newly created folder */ - modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), - new_folder, FALSE); + folder_view = GTK_WIDGET(g_object_get_data (G_OBJECT (source_win), + MODEST_MOVE_TO_DIALOG_FOLDER_VIEW)); + + /* Select the newly created folder. It could happen + that the widget is no longer there (i.e. the window + has been destroyed, so we need to check this */ + if (folder_view) + modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), + new_folder, FALSE); g_object_unref (new_folder); } /* Free. Note that the first time it'll be NULL so noop */ @@ -2687,53 +3316,77 @@ do_create_folder_cb (ModestMailOperation *mail_op, g_object_unref (source_win); } -static void -do_create_folder (GtkWindow *parent_window, - TnyFolderStore *parent_folder, - const gchar *suggested_name) -{ - gint result; - gchar *folder_name = NULL; - - result = modest_platform_run_new_folder_dialog (GTK_WINDOW (parent_window), - parent_folder, - (gchar *) suggested_name, - &folder_name); - - if (result == GTK_RESPONSE_ACCEPT) { - ModestMailOperation *mail_op; - - mail_op = modest_mail_operation_new (G_OBJECT(parent_window)); - - modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), - mail_op); - modest_mail_operation_create_folder (mail_op, - parent_folder, - (const gchar *) folder_name, - do_create_folder_cb, - folder_name); - g_object_unref (mail_op); - } -} +typedef struct { + gchar *folder_name; + TnyFolderStore *parent; +} CreateFolderConnect; static void -create_folder_performer (gboolean canceled, +do_create_folder_performer (gboolean canceled, GError *err, GtkWindow *parent_window, TnyAccount *account, gpointer user_data) { - TnyFolderStore *parent_folder = TNY_FOLDER_STORE (user_data); + CreateFolderConnect *helper = (CreateFolderConnect *) user_data; + ModestMailOperation *mail_op; if (canceled || err) { + /* In memory full conditions we could get this error here */ + check_memory_full_error ((GtkWidget *) parent_window, err); goto frees; } - /* Run the new folder dialog */ - do_create_folder (GTK_WINDOW (parent_window), parent_folder, NULL); + mail_op = modest_mail_operation_new ((GObject *) parent_window); + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), + mail_op); + modest_mail_operation_create_folder (mail_op, + helper->parent, + (const gchar *) helper->folder_name, + do_create_folder_cb, + g_strdup (helper->folder_name)); + g_object_unref (mail_op); frees: - g_object_unref (parent_folder); + if (helper->parent) + g_object_unref (helper->parent); + if (helper->folder_name) + g_free (helper->folder_name); + g_slice_free (CreateFolderConnect, helper); +} + + +static void +do_create_folder (GtkWindow *parent_window, + TnyFolderStore *suggested_parent, + const gchar *suggested_name) +{ + gint result; + gchar *folder_name = NULL; + TnyFolderStore *parent_folder = NULL; + + result = modest_platform_run_new_folder_dialog (GTK_WINDOW (parent_window), + suggested_parent, + (gchar *) suggested_name, + &folder_name, + &parent_folder); + + if (result == GTK_RESPONSE_ACCEPT && parent_folder) { + CreateFolderConnect *helper = (CreateFolderConnect *) g_slice_new0 (CreateFolderHelper); + helper->folder_name = g_strdup (folder_name); + helper->parent = g_object_ref (parent_folder); + + modest_platform_connect_if_remote_and_perform (GTK_WINDOW (parent_window), + TRUE, + parent_folder, + do_create_folder_performer, + helper); + } + + if (folder_name) + g_free (folder_name); + if (parent_folder) + g_object_unref (parent_folder); } static void @@ -2742,38 +3395,52 @@ modest_ui_actions_create_folder(GtkWidget *parent_window, { TnyFolderStore *parent_folder; +#ifdef MODEST_TOOLKIT_HILDON2 + ModestTnyAccountStore *acc_store; + + acc_store = modest_runtime_get_account_store (); + + parent_folder = (TnyFolderStore *) + modest_tny_account_store_get_local_folders_account (acc_store); +#else parent_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW(folder_view)); - - if (parent_folder) { - /* The parent folder will be freed in the callback */ - modest_platform_connect_if_remote_and_perform (GTK_WINDOW (parent_window), - TRUE, - parent_folder, - create_folder_performer, - parent_folder); - } +#endif + + if (parent_folder) + do_create_folder (GTK_WINDOW (parent_window), parent_folder, NULL); } -void -modest_ui_actions_on_new_folder (GtkAction *action, ModestMainWindow *main_window) +void +modest_ui_actions_on_new_folder (GtkAction *action, ModestWindow *window) { - GtkWidget *folder_view; - - g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window)); - folder_view = modest_main_window_get_child_widget (main_window, - MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); - if (!folder_view) - return; + g_return_if_fail (MODEST_IS_WINDOW(window)); + + if (MODEST_IS_MAIN_WINDOW (window)) { + GtkWidget *folder_view; + + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (window), + MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + if (!folder_view) + return; + + modest_ui_actions_create_folder (GTK_WIDGET (window), folder_view); +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_FOLDER_WINDOW (window)) { + GtkWidget *folder_view; - modest_ui_actions_create_folder (GTK_WIDGET (main_window), folder_view); + folder_view = GTK_WIDGET (modest_folder_window_get_folder_view (MODEST_FOLDER_WINDOW (window))); + modest_ui_actions_create_folder (GTK_WIDGET (window), folder_view); +#endif + } else { + g_assert_not_reached (); + } } static void modest_ui_actions_rename_folder_error_handler (ModestMailOperation *mail_op, gpointer user_data) { - ModestMainWindow *window = MODEST_MAIN_WINDOW (user_data); const GError *error = NULL; const gchar *message = NULL; @@ -2782,17 +3449,21 @@ modest_ui_actions_rename_folder_error_handler (ModestMailOperation *mail_op, if (!error) g_return_if_reached (); - switch (error->code) { - case MODEST_MAIL_OPERATION_ERROR_FOLDER_EXISTS: + if (error->domain == MODEST_MAIL_OPERATION_ERROR && + error->code == MODEST_MAIL_OPERATION_ERROR_FOLDER_EXISTS) { message = _CS("ckdg_ib_folder_already_exists"); - break; - default: - g_warning ("%s: BUG: unexpected error:[%d]: %s", __FUNCTION__, - error->code, error->message); - return; + } else if (error->domain == TNY_ERROR_DOMAIN && + error->code == TNY_SERVICE_ERROR_STATE) { + /* This means that the folder is already in use (a + message is opened for example */ + message = _("emev_ni_internal_error"); + } else { + message = _CS("ckdg_ib_unable_to_rename"); } - modest_platform_information_banner (GTK_WIDGET (window), NULL, message); + /* We don't set a parent for the dialog because the dialog + will be destroyed so the banner won't appear */ + modest_platform_information_banner (NULL, NULL, message); } typedef struct { @@ -2805,9 +3476,21 @@ on_rename_folder_cb (ModestMailOperation *mail_op, TnyFolder *new_folder, gpointer user_data) { - /* Select now */ - modest_folder_view_select_folder (MODEST_FOLDER_VIEW (user_data), - new_folder, FALSE); + ModestFolderView *folder_view; + + /* If the window was closed when renaming a folder, or if + * it's not a main window this will happen */ + if (!MODEST_IS_FOLDER_VIEW (user_data)) + return; + + folder_view = MODEST_FOLDER_VIEW (user_data); + /* Note that if the rename fails new_folder will be NULL */ + if (new_folder) { + modest_folder_view_select_folder (folder_view, new_folder, FALSE); + } else { + modest_folder_view_select_first_inbox_or_local (folder_view); + } + gtk_widget_grab_focus (GTK_WIDGET (folder_view)); } static void @@ -2822,11 +3505,10 @@ on_rename_folder_performer (gboolean canceled, GtkWidget *folder_view = NULL; RenameFolderInfo *data = (RenameFolderInfo*)user_data; - if (!canceled && (err == NULL) && MODEST_IS_MAIN_WINDOW(parent_window)) { - - folder_view = modest_main_window_get_child_widget ( - MODEST_MAIN_WINDOW (parent_window), - MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + if (canceled || err) { + /* In memory full conditions we could get this error here */ + check_memory_full_error ((GtkWidget *) parent_window, err); + } else { mail_op = modest_mail_operation_new_with_error_handling (G_OBJECT(parent_window), @@ -2836,9 +3518,18 @@ on_rename_folder_performer (gboolean canceled, modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - /* Clear the headers view */ - sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (folder_view)); - gtk_tree_selection_unselect_all (sel); + if (MODEST_IS_MAIN_WINDOW(parent_window)) { + + folder_view = modest_main_window_get_child_widget ( + MODEST_MAIN_WINDOW (parent_window), + MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + + /* Clear the headers view */ + sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (folder_view)); + gtk_tree_selection_unselect_all (sel); + } else { + folder_view = NULL; + } /* Actually rename the folder */ modest_mail_operation_rename_folder (mail_op, @@ -2846,49 +3537,58 @@ on_rename_folder_performer (gboolean canceled, (const gchar *) (data->new_name), on_rename_folder_cb, folder_view); + g_object_unref (data->folder); + g_object_unref (mail_op); } - g_object_unref (mail_op); g_free (data->new_name); g_free (data); } void modest_ui_actions_on_rename_folder (GtkAction *action, - ModestMainWindow *main_window) + ModestWindow *window) +{ + modest_ui_actions_on_edit_mode_rename_folder (window); +} + +gboolean +modest_ui_actions_on_edit_mode_rename_folder (ModestWindow *window) { TnyFolderStore *folder; GtkWidget *folder_view; - GtkWidget *header_view; + gboolean do_rename = TRUE; - g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window)); + g_return_val_if_fail (MODEST_IS_WINDOW(window), FALSE); - folder_view = modest_main_window_get_child_widget (main_window, - MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); - if (!folder_view) - return; + if (MODEST_IS_MAIN_WINDOW (window)) { + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (window), + MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + if (!folder_view) + return FALSE; - header_view = modest_main_window_get_child_widget (main_window, - MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); - - if (!header_view) - return; +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_FOLDER_WINDOW (window)) { + folder_view = GTK_WIDGET (modest_folder_window_get_folder_view (MODEST_FOLDER_WINDOW (window))); +#endif + } else { + return FALSE; + } folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW(folder_view)); if (!folder) - return; + return FALSE; if (TNY_IS_FOLDER (folder)) { - gchar *folder_name; + gchar *folder_name = NULL; gint response; const gchar *current_name; TnyFolderStore *parent; - gboolean do_rename = TRUE; current_name = tny_folder_get_name (TNY_FOLDER (folder)); parent = tny_folder_get_folder_store (TNY_FOLDER (folder)); - response = modest_platform_run_rename_folder_dialog (GTK_WINDOW (main_window), + response = modest_platform_run_rename_folder_dialog (GTK_WINDOW (window), parent, current_name, &folder_name); g_object_unref (parent); @@ -2897,13 +3597,14 @@ modest_ui_actions_on_rename_folder (GtkAction *action, do_rename = FALSE; } else { RenameFolderInfo *rename_folder_data = g_new0 (RenameFolderInfo, 1); - rename_folder_data->folder = folder; + rename_folder_data->folder = g_object_ref (folder); rename_folder_data->new_name = folder_name; - modest_platform_connect_if_remote_and_perform (GTK_WINDOW(main_window), TRUE, + modest_platform_connect_if_remote_and_perform (GTK_WINDOW(window), TRUE, folder, on_rename_folder_performer, rename_folder_data); } } g_object_unref (folder); + return do_rename; } static void @@ -2913,7 +3614,8 @@ modest_ui_actions_delete_folder_error_handler (ModestMailOperation *mail_op, GObject *win = modest_mail_operation_get_source (mail_op); modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, - _("mail_in_ui_folder_delete_error")); + _("mail_in_ui_folder_delete_error"), + FALSE); g_object_unref (win); } @@ -2934,15 +3636,25 @@ on_delete_folder_cb (gboolean canceled, ModestMailOperation *mail_op; GtkTreeSelection *sel; - if (!MODEST_IS_MAIN_WINDOW(parent_window) || canceled || (err!=NULL)) { + if (!MODEST_IS_WINDOW(parent_window) || canceled || (err!=NULL)) { g_object_unref (G_OBJECT (info->folder)); g_free (info); return; } - folder_view = modest_main_window_get_child_widget ( + if (MODEST_IS_MAIN_WINDOW (parent_window)) { + folder_view = modest_main_window_get_child_widget ( MODEST_MAIN_WINDOW (parent_window), MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_FOLDER_WINDOW (parent_window)) { + folder_view = GTK_WIDGET (modest_folder_window_get_folder_view (MODEST_FOLDER_WINDOW (parent_window))); +#endif + } else { + g_object_unref (G_OBJECT (info->folder)); + g_free (info); + return; + } /* Unselect the folder before deleting it to free the headers */ sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (folder_view)); @@ -2965,35 +3677,48 @@ on_delete_folder_cb (gboolean canceled, g_free (info); } -static void -delete_folder (ModestMainWindow *main_window, gboolean move_to_trash) +static gboolean +delete_folder (ModestWindow *window, gboolean move_to_trash) { TnyFolderStore *folder; GtkWidget *folder_view; gint response; gchar *message; - g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window)); + g_return_val_if_fail (MODEST_IS_WINDOW(window), FALSE); + + if (MODEST_IS_MAIN_WINDOW (window)) { - folder_view = modest_main_window_get_child_widget (main_window, - MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (window), + MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_FOLDER_WINDOW (window)) { + folder_view = GTK_WIDGET (modest_folder_window_get_folder_view (MODEST_FOLDER_WINDOW (window))); +#endif + } else { + return FALSE; + } if (!folder_view) - return; + return FALSE; folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); + if (!folder) + return FALSE; + /* Show an error if it's an account */ if (!TNY_IS_FOLDER (folder)) { - modest_platform_run_information_dialog (GTK_WINDOW (main_window), - _("mail_in_ui_folder_delete_error")); + modest_platform_run_information_dialog (GTK_WINDOW (window), + _("mail_in_ui_folder_delete_error"), + FALSE); g_object_unref (G_OBJECT (folder)); - return; + return FALSE; } - /* Ask the user */ + /* Ask the user */ message = g_strdup_printf (_("mcen_nc_delete_folder_text"), tny_folder_get_name (TNY_FOLDER (folder))); - response = modest_platform_run_confirmation_dialog (GTK_WINDOW (main_window), + response = modest_platform_run_confirmation_dialog (GTK_WINDOW (window), (const gchar *) message); g_free (message); @@ -3004,22 +3729,31 @@ delete_folder (ModestMainWindow *main_window, gboolean move_to_trash) info->move_to_trash = move_to_trash; g_object_ref (G_OBJECT (info->folder)); TnyAccount *account = tny_folder_get_account (TNY_FOLDER (folder)); - modest_platform_connect_if_remote_and_perform (GTK_WINDOW (main_window), + modest_platform_connect_if_remote_and_perform (GTK_WINDOW (window), TRUE, TNY_FOLDER_STORE (account), on_delete_folder_cb, info); g_object_unref (account); + return TRUE; + } else { + return FALSE; } g_object_unref (G_OBJECT (folder)); } -void +void modest_ui_actions_on_delete_folder (GtkAction *action, - ModestMainWindow *main_window) + ModestWindow *window) { - g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window)); + modest_ui_actions_on_edit_mode_delete_folder (window); +} + +gboolean +modest_ui_actions_on_edit_mode_delete_folder (ModestWindow *window) +{ + g_return_val_if_fail (MODEST_IS_WINDOW(window), TRUE); - delete_folder (main_window, FALSE); + return delete_folder (window, FALSE); } void @@ -3027,64 +3761,101 @@ modest_ui_actions_on_move_folder_to_trash_folder (GtkAction *action, ModestMainW { g_return_if_fail (MODEST_IS_MAIN_WINDOW(main_window)); - delete_folder (main_window, TRUE); + delete_folder (MODEST_WINDOW (main_window), TRUE); } +typedef struct _PasswordDialogFields { + GtkWidget *username; + GtkWidget *password; + GtkWidget *dialog; +} PasswordDialogFields; + +static void +password_dialog_check_field (GtkEditable *editable, + PasswordDialogFields *fields) +{ + const gchar *value; + gboolean any_value_empty = FALSE; + + value = gtk_entry_get_text (GTK_ENTRY (fields->username)); + if ((value == NULL) || value[0] == '\0') { + any_value_empty = TRUE; + } + value = gtk_entry_get_text (GTK_ENTRY (fields->password)); + if ((value == NULL) || value[0] == '\0') { + any_value_empty = TRUE; + } + gtk_dialog_set_response_sensitive (GTK_DIALOG (fields->dialog), GTK_RESPONSE_ACCEPT, !any_value_empty); +} + void -modest_ui_actions_on_password_requested (TnyAccountStore *account_store, +modest_ui_actions_on_password_requested (TnyAccountStore *account_store, const gchar* server_account_name, gchar **username, - gchar **password, - gboolean *cancel, + gchar **password, + gboolean *cancel, gboolean *remember, ModestMainWindow *main_window) { g_return_if_fail(server_account_name); - + gboolean completed = FALSE; + PasswordDialogFields *fields = NULL; + /* Initalize output parameters: */ if (cancel) *cancel = FALSE; - + if (remember) *remember = TRUE; - -#ifdef MODEST_PLATFORM_MAEMO + +#ifndef MODEST_TOOLKIT_GTK /* Maemo uses a different (awkward) button order, * It should probably just use gtk_alternative_dialog_button_order (). */ - GtkWidget *dialog = gtk_dialog_new_with_buttons (_("mail_ti_password_protected"), - NULL, - GTK_DIALOG_MODAL, - _("mcen_bd_dialog_ok"), - GTK_RESPONSE_ACCEPT, - _("mcen_bd_dialog_cancel"), - GTK_RESPONSE_REJECT, - NULL); +#ifdef MODEST_TOOLKIT_HILDON2 + GtkWidget *dialog = + gtk_dialog_new_with_buttons (_("mail_ti_password_protected"), + NULL, + GTK_DIALOG_MODAL, + _HL("wdgt_bd_done"), + GTK_RESPONSE_ACCEPT, + NULL); #else - GtkWidget *dialog = gtk_dialog_new_with_buttons (_("mail_ti_password_protected"), - NULL, - GTK_DIALOG_MODAL, - GTK_STOCK_CANCEL, - GTK_RESPONSE_REJECT, - GTK_STOCK_OK, - GTK_RESPONSE_ACCEPT, - NULL); -#endif /* MODEST_PLATFORM_MAEMO */ + GtkWidget *dialog = + gtk_dialog_new_with_buttons (_("mail_ti_password_protected"), + NULL, + GTK_DIALOG_MODAL, + _("mcen_bd_dialog_ok"), + GTK_RESPONSE_ACCEPT, + _("mcen_bd_dialog_cancel"), + GTK_RESPONSE_REJECT, + NULL); +#endif /* MODEST_TOOLKIT_HILDON2 */ +#else + GtkWidget *dialog = + gtk_dialog_new_with_buttons (_("mail_ti_password_protected"), + NULL, + GTK_DIALOG_MODAL, + GTK_STOCK_CANCEL, + GTK_RESPONSE_REJECT, + GTK_STOCK_OK, + GTK_RESPONSE_ACCEPT, + NULL); +#endif /* MODEST_TOOLKIT_GTK */ + + modest_window_mgr_set_modal (modest_runtime_get_window_mgr(), GTK_WINDOW (dialog), NULL); - modest_window_mgr_set_modal (modest_runtime_get_window_mgr(), GTK_WINDOW (dialog)); - gchar *server_name = modest_account_mgr_get_server_account_hostname ( modest_runtime_get_account_mgr(), server_account_name); if (!server_name) {/* This happened once, though I don't know why. murrayc. */ g_warning("%s: Could not get server name for server account '%s'", __FUNCTION__, server_account_name); if (cancel) *cancel = TRUE; + gtk_widget_destroy (dialog); return; } - - /* This causes a warning because the logical ID has no %s in it, - * though the translation does, but there is not much we can do about that: */ + gchar *txt = g_strdup_printf (_("mail_ia_password_info"), server_name); gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), gtk_label_new(txt), FALSE, FALSE, 0); @@ -3095,112 +3866,139 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, /* username: */ gchar *initial_username = modest_account_mgr_get_server_account_username ( modest_runtime_get_account_mgr(), server_account_name); - + GtkWidget *entry_username = gtk_entry_new (); if (initial_username) gtk_entry_set_text (GTK_ENTRY (entry_username), initial_username); /* Dim this if a connection has ever succeeded with this username, * as per the UI spec: */ - const gboolean username_known = - modest_account_mgr_get_server_account_username_has_succeeded( - modest_runtime_get_account_mgr(), server_account_name); - gtk_widget_set_sensitive (entry_username, !username_known); - -#ifdef MODEST_PLATFORM_MAEMO + /* const gboolean username_known = */ + /* modest_account_mgr_get_server_account_username_has_succeeded( */ + /* modest_runtime_get_account_mgr(), server_account_name); */ + /* gtk_widget_set_sensitive (entry_username, !username_known); */ + + /* We drop the username sensitive code and disallow changing it here + * as tinymail does not support really changing the username in the callback + */ + gtk_widget_set_sensitive (entry_username, FALSE); + +#ifndef MODEST_TOOLKIT_GTK /* Auto-capitalization is the default, so let's turn it off: */ hildon_gtk_entry_set_input_mode (GTK_ENTRY (entry_username), HILDON_GTK_INPUT_MODE_FULL); - + /* Create a size group to be used by all captions. * Note that HildonCaption does not create a default size group if we do not specify one. * We use GTK_SIZE_GROUP_HORIZONTAL, so that the widths are the same. */ GtkSizeGroup *sizegroup = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL); - + GtkWidget *caption = hildon_caption_new (sizegroup, _("mail_fi_username"), entry_username, NULL, HILDON_CAPTION_MANDATORY); gtk_widget_show (entry_username); gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), caption, FALSE, FALSE, MODEST_MARGIN_HALF); gtk_widget_show (caption); -#else +#else gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), entry_username, TRUE, FALSE, 0); -#endif /* MODEST_PLATFORM_MAEMO */ - +#endif /* !MODEST_TOOLKIT_GTK */ + /* password: */ GtkWidget *entry_password = gtk_entry_new (); gtk_entry_set_visibility (GTK_ENTRY(entry_password), FALSE); /* gtk_entry_set_invisible_char (GTK_ENTRY(entry_password), "*"); */ - -#ifdef MODEST_PLATFORM_MAEMO + +#ifndef MODEST_TOOLKIT_GTK /* Auto-capitalization is the default, so let's turn it off: */ - hildon_gtk_entry_set_input_mode (GTK_ENTRY (entry_password), + hildon_gtk_entry_set_input_mode (GTK_ENTRY (entry_password), HILDON_GTK_INPUT_MODE_FULL | HILDON_GTK_INPUT_MODE_INVISIBLE); - - caption = hildon_caption_new (sizegroup, + + caption = hildon_caption_new (sizegroup, _("mail_fi_password"), entry_password, NULL, HILDON_CAPTION_MANDATORY); gtk_widget_show (entry_password); - gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), caption, + gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), caption, FALSE, FALSE, MODEST_MARGIN_HALF); gtk_widget_show (caption); g_object_unref (sizegroup); -#else +#else gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), entry_password, TRUE, FALSE, 0); -#endif /* MODEST_PLATFORM_MAEMO */ +#endif /* !MODEST_TOOLKIT_GTK */ if (initial_username != NULL) gtk_widget_grab_focus (GTK_WIDGET (entry_password)); - + /* This is not in the Maemo UI spec: remember_pass_check = gtk_check_button_new_with_label (_("Remember password")); gtk_box_pack_start (GTK_BOX(GTK_DIALOG(dialog)->vbox), remember_pass_check, TRUE, FALSE, 0); */ + fields = g_slice_new0 (PasswordDialogFields); + fields->username = entry_username; + fields->password = entry_password; + fields->dialog = dialog; + + g_signal_connect (entry_username, "changed", G_CALLBACK (password_dialog_check_field), fields); + g_signal_connect (entry_password, "changed", G_CALLBACK (password_dialog_check_field), fields); + password_dialog_check_field (NULL, fields); + gtk_widget_show_all (GTK_WIDGET(GTK_DIALOG(dialog)->vbox)); - - if (gtk_dialog_run (GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) { - if (username) { - *username = g_strdup (gtk_entry_get_text (GTK_ENTRY(entry_username))); - - modest_account_mgr_set_server_account_username ( - modest_runtime_get_account_mgr(), server_account_name, - *username); - - const gboolean username_was_changed = - (strcmp (*username, initial_username) != 0); - if (username_was_changed) { - g_warning ("%s: tinymail does not yet support changing the " - "username in the get_password() callback.\n", __FUNCTION__); + + while (!completed) { + + if (gtk_dialog_run (GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) { + if (username) { + *username = g_strdup (gtk_entry_get_text (GTK_ENTRY(entry_username))); + + /* Note that an empty field becomes the "" string */ + if (*username && strlen (*username) > 0) { + modest_account_mgr_set_server_account_username (modest_runtime_get_account_mgr(), + server_account_name, + *username); + completed = TRUE; + + const gboolean username_was_changed = + (strcmp (*username, initial_username) != 0); + if (username_was_changed) { + g_warning ("%s: tinymail does not yet support changing the " + "username in the get_password() callback.\n", __FUNCTION__); + } + } else { + g_free (*username); + *username = NULL; + /* Show error */ + modest_platform_information_banner (GTK_WIDGET (dialog), NULL, + _("mcen_ib_username_pw_incorrect")); + completed = FALSE; + } } - } - - if (password) { - *password = g_strdup (gtk_entry_get_text (GTK_ENTRY(entry_password))); - - /* We do not save the password in the configuration, - * because this function is only called for passwords that should - * not be remembered: - modest_server_account_set_password ( + + if (password) { + *password = g_strdup (gtk_entry_get_text (GTK_ENTRY(entry_password))); + + /* We do not save the password in the configuration, + * because this function is only called for passwords that should + * not be remembered: + modest_server_account_set_password ( modest_runtime_get_account_mgr(), server_account_name, *password); - */ + */ + } + if (cancel) + *cancel = FALSE; + } else { +#ifndef MODEST_TOOLKIT_HILDON2 + /* Set parent to NULL or the banner will disappear with its parent dialog */ + modest_platform_information_banner(NULL, NULL, _("mail_ib_login_cancelled")); +#endif + completed = TRUE; + if (username) + *username = NULL; + if (password) + *password = NULL; + if (cancel) + *cancel = TRUE; } - - if (cancel) - *cancel = FALSE; - - } else { - modest_platform_information_banner(GTK_WIDGET (main_window), NULL, _("mail_ib_login_cancelled")); - - if (username) - *username = NULL; - - if (password) - *password = NULL; - - if (cancel) - *cancel = TRUE; } /* This is not in the Maemo UI spec: @@ -3210,7 +4008,9 @@ modest_ui_actions_on_password_requested (TnyAccountStore *account_store, *remember = FALSE; */ + g_free (initial_username); gtk_widget_destroy (dialog); + g_slice_free (PasswordDialogFields, fields); /* printf ("DEBUG: %s: cancel=%d\n", __FUNCTION__, *cancel); */ } @@ -3247,8 +4047,10 @@ modest_ui_actions_on_cut (GtkAction *action, if (num_of_unc_msgs) { TnyAccount *account = get_account_from_header_list (header_list); - continue_download = connect_to_get_msg (window, num_of_unc_msgs, account); - g_object_unref (account); + if (account) { + continue_download = connect_to_get_msg (window, num_of_unc_msgs, account); + g_object_unref (account); + } } if (num_of_unc_msgs == 0 || continue_download) { @@ -3287,9 +4089,16 @@ modest_ui_actions_on_copy (GtkAction *action, gtk_clipboard_set_can_store (clipboard, NULL, 0); gtk_clipboard_store (clipboard); } else if (GTK_IS_HTML (focused_widget)) { - gtk_html_copy (GTK_HTML (focused_widget)); - gtk_clipboard_set_can_store (clipboard, NULL, 0); - gtk_clipboard_store (clipboard); + const gchar *sel; + int len = -1; + sel = gtk_html_get_selection_html (GTK_HTML (focused_widget), &len); + if ((sel == NULL) || (sel[0] == '\0')) { + copied = FALSE; + } else { + gtk_html_copy (GTK_HTML (focused_widget)); + gtk_clipboard_set_can_store (clipboard, NULL, 0); + gtk_clipboard_store (clipboard); + } } else if (GTK_IS_TEXT_VIEW (focused_widget)) { GtkTextBuffer *buffer; buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (focused_widget)); @@ -3308,8 +4117,10 @@ modest_ui_actions_on_copy (GtkAction *action, if (num_of_unc_msgs) { TnyAccount *account = get_account_from_header_list (header_list); - continue_download = connect_to_get_msg (window, num_of_unc_msgs, account); - g_object_unref (account); + if (account) { + continue_download = connect_to_get_msg (window, num_of_unc_msgs, account); + g_object_unref (account); + } } if (num_of_unc_msgs == 0 || continue_download) { @@ -3386,8 +4197,10 @@ paste_as_attachment_free (gpointer data) { PasteAsAttachmentHelper *helper = (PasteAsAttachmentHelper *) data; - gtk_widget_destroy (helper->banner); - g_object_unref (helper->banner); + if (helper->banner) { + gtk_widget_destroy (helper->banner); + g_object_unref (helper->banner); + } g_free (helper); } @@ -3430,8 +4243,8 @@ modest_ui_actions_on_paste (GtkAction *action, gtk_text_buffer_paste_clipboard (buffer, clipboard, NULL, TRUE); } else if (MODEST_IS_MSG_EDIT_WINDOW (window)) { ModestMailOperation *mail_op; - TnyFolder *src_folder; - TnyList *data; + TnyFolder *src_folder = NULL; + TnyList *data = NULL; gboolean delete; PasteAsAttachmentHelper *helper = g_new0 (PasteAsAttachmentHelper, 1); helper->window = MODEST_MSG_EDIT_WINDOW (window); @@ -3441,7 +4254,6 @@ modest_ui_actions_on_paste (GtkAction *action, mail_op = modest_mail_operation_new (G_OBJECT (window)); if (helper->banner != NULL) { g_object_ref (G_OBJECT (helper->banner)); - gtk_window_set_modal (GTK_WINDOW (helper->banner), FALSE); gtk_widget_show (GTK_WIDGET (helper->banner)); } @@ -3452,6 +4264,12 @@ modest_ui_actions_on_paste (GtkAction *action, helper, paste_as_attachment_free); } + /* Free */ + if (data) + g_object_unref (data); + if (src_folder) + g_object_unref (src_folder); + } } else if (MODEST_IS_FOLDER_VIEW (focused_widget)) { ModestEmailClipboard *clipboard = NULL; @@ -3576,9 +4394,9 @@ modest_ui_actions_on_select_all (GtkAction *action, /* Set focuse on header view */ gtk_widget_grab_focus (header_view); - /* Enable window dimming management */ modest_window_enable_dimming (MODEST_WINDOW(window)); + modest_ui_actions_check_menu_dimming_rules (MODEST_WINDOW (window)); modest_ui_actions_check_toolbar_dimming_rules (MODEST_WINDOW (window)); } @@ -3676,7 +4494,9 @@ modest_ui_actions_on_toggle_fullscreen (GtkToggleAction *toggle, if (active != fullscreen) { modest_window_mgr_set_fullscreen_mode (mgr, active); +#ifndef MODEST_TOOLKIT_HILDON2 gtk_window_present (GTK_WINDOW (window)); +#endif } } @@ -3693,7 +4513,9 @@ modest_ui_actions_on_change_fullscreen (GtkAction *action, fullscreen = modest_window_mgr_get_fullscreen_mode (mgr); modest_window_mgr_set_fullscreen_mode (mgr, !fullscreen); +#ifndef MODEST_TOOLKIT_HILDON2 gtk_window_present (GTK_WINDOW (window)); +#endif } /* @@ -3705,37 +4527,7 @@ headers_action_show_details (TnyHeader *header, gpointer user_data) { - GtkWidget *dialog; - - /* Create dialog */ - dialog = modest_details_dialog_new_with_header (GTK_WINDOW (window), header); - - /* Run dialog */ - gtk_window_set_modal (GTK_WINDOW (dialog), TRUE); - gtk_widget_show_all (dialog); - gtk_dialog_run (GTK_DIALOG (dialog)); - - gtk_widget_destroy (dialog); -} - -/* - * Show the folder details in a ModestDetailsDialog widget - */ -static void -show_folder_details (TnyFolder *folder, - GtkWindow *window) -{ - GtkWidget *dialog; - - /* Create dialog */ - dialog = modest_details_dialog_new_with_folder (window, folder); - - /* Run dialog */ - gtk_window_set_modal (GTK_WINDOW (dialog), TRUE); - gtk_widget_show_all (dialog); - gtk_dialog_run (GTK_DIALOG (dialog)); - - gtk_widget_destroy (dialog); + modest_platform_run_header_details_dialog (GTK_WINDOW (window), header); } /* @@ -3789,7 +4581,8 @@ modest_ui_actions_on_details (GtkAction *action, /* This function should not be called for account items, * because we dim the menu item for them. */ if (TNY_IS_FOLDER (folder_store)) { - show_folder_details (TNY_FOLDER (folder_store), GTK_WINDOW (win)); + modest_platform_run_folder_details_dialog (GTK_WINDOW (win), + TNY_FOLDER (folder_store)); } g_object_unref (folder_store); @@ -3800,6 +4593,19 @@ modest_ui_actions_on_details (GtkAction *action, /* Show details of each header */ do_headers_action (win, headers_action_show_details, header_view); } +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_HEADER_WINDOW (win)) { + TnyFolder *folder; + GtkWidget *header_view; + + header_view = GTK_WIDGET (modest_header_window_get_header_view (MODEST_HEADER_WINDOW (win))); + folder = modest_header_view_get_folder (MODEST_HEADER_VIEW (header_view)); + if (folder) { + modest_platform_run_folder_details_dialog (GTK_WINDOW (win), + folder); + g_object_unref (folder); + } +#endif } } @@ -3842,7 +4648,7 @@ modest_ui_actions_on_toggle_toolbar (GtkToggleAction *toggle, active = gtk_toggle_action_get_active (GTK_TOGGLE_ACTION (toggle)); - /* Check if we want to toggle the toolbar vuew in fullscreen + /* Check if we want to toggle the toolbar view in fullscreen or normal mode */ if (!strcmp (gtk_action_get_name (GTK_ACTION (toggle)), "ViewShowToolbarFullScreen")) { @@ -3898,13 +4704,7 @@ modest_ui_actions_on_check_names (GtkAction *action, ModestMsgEditWindow *window modest_msg_edit_window_check_names (window, FALSE); } -static void -create_move_to_dialog_on_new_folder(GtkWidget *button, gpointer user_data) -{ - modest_ui_actions_create_folder (gtk_widget_get_toplevel (button), - GTK_WIDGET (user_data)); -} - +#ifndef MODEST_TOOLKIT_HILDON2 /* * This function is used to track changes in the selection of the * folder view that is inside the "move to" dialog to enable/disable @@ -3920,8 +4720,6 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, gpointer user_data) { GtkWidget *dialog = NULL; - GtkWidget *ok_button = NULL, *new_button = NULL; - GList *children = NULL; gboolean ok_sensitive = TRUE, new_sensitive = TRUE; gboolean moving_folder = FALSE; gboolean is_local_account = TRUE; @@ -3929,20 +4727,14 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, ModestTnyFolderRules rules; g_return_if_fail (MODEST_IS_FOLDER_VIEW(self)); - + if (!selected) return; - - /* Get the OK button */ + dialog = gtk_widget_get_ancestor (GTK_WIDGET (self), GTK_TYPE_DIALOG); if (!dialog) return; - children = gtk_container_get_children (GTK_CONTAINER (GTK_DIALOG (dialog)->action_area)); - ok_button = GTK_WIDGET (children->next->next->data); - new_button = GTK_WIDGET (children->next->data); - g_list_free (children); - /* check if folder_store is an remote account */ if (TNY_IS_ACCOUNT (folder_store)) { TnyAccount *local_account = NULL; @@ -3955,17 +4747,23 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, if ((gpointer) local_account != (gpointer) folder_store && (gpointer) mmc_account != (gpointer) folder_store) { - const char *proto_name = tny_account_get_proto (TNY_ACCOUNT (folder_store)); - ModestTransportStoreProtocol proto = MODEST_PROTOCOL_STORE_MAILDIR; - if (proto_name != NULL) { - proto = modest_protocol_info_get_transport_store_protocol (proto_name); + ModestProtocolType proto; + proto = modest_tny_account_get_protocol_type (TNY_ACCOUNT (folder_store)); + if (proto == MODEST_PROTOCOL_REGISTRY_TYPE_INVALID) { + proto = MODEST_PROTOCOLS_STORE_MAILDIR; } is_local_account = FALSE; /* New button should be dimmed on remote POP account root */ - new_sensitive = (proto != MODEST_PROTOCOL_STORE_POP); + new_sensitive = (modest_protocol_registry_protocol_type_has_tag (modest_runtime_get_protocol_registry (), + proto, + MODEST_PROTOCOL_REGISTRY_STORE_HAS_FOLDERS)); } g_object_unref (local_account); + + /* It could not exist */ + if (mmc_account) + g_object_unref (mmc_account); } /* Check the target folder rules */ @@ -3992,21 +4790,21 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, /* Get the folder to move */ moved_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); - + /* Check that we're not moving to the same folder */ if (TNY_IS_FOLDER (moved_folder)) { parent = tny_folder_get_folder_store (TNY_FOLDER (moved_folder)); if (parent == folder_store) ok_sensitive = FALSE; g_object_unref (parent); - } + } if (ok_sensitive && TNY_IS_ACCOUNT (folder_store)) { /* Do not allow to move to an account unless it's the local folders account */ if (!is_local_account) ok_sensitive = FALSE; - } + } if (ok_sensitive && (moved_folder == folder_store)) { /* Do not allow to move to itself */ @@ -4047,64 +4845,90 @@ on_move_to_dialog_folder_selection_changed (ModestFolderView* self, } end: - /* Set sensitivity of the OK button */ - gtk_widget_set_sensitive (ok_button, ok_sensitive); - /* Set sensitivity of the NEW button */ - gtk_widget_set_sensitive (new_button, new_sensitive); + /* Set sensitivity of the OK and NEW button */ + gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), GTK_RESPONSE_OK, ok_sensitive); + gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), MODEST_GTK_RESPONSE_NEW_FOLDER, new_sensitive); } +#endif + +static void +on_move_to_dialog_response (GtkDialog *dialog, + gint response, + gpointer user_data) +{ + GtkWidget *parent_win, *folder_view; + MoveToInfo *helper = NULL; + helper = (MoveToInfo *) user_data; -#define MODEST_MOVE_TO_DIALOG_FOLDER_VIEW "move-to-dialog-folder-view" + parent_win = (GtkWidget *) helper->win; + folder_view = GTK_WIDGET (g_object_get_data (G_OBJECT (dialog), + MODEST_MOVE_TO_DIALOG_FOLDER_VIEW)); -static GtkWidget* -get_folder_view_from_move_to_dialog (GtkWidget *move_to_dialog) -{ - return GTK_WIDGET(g_object_get_data (G_OBJECT(move_to_dialog), - MODEST_MOVE_TO_DIALOG_FOLDER_VIEW)); + switch (response) { + TnyFolderStore *dst_folder; + + case MODEST_GTK_RESPONSE_NEW_FOLDER: + modest_ui_actions_create_folder (GTK_WIDGET (parent_win), folder_view); + return; + case GTK_RESPONSE_NONE: + case GTK_RESPONSE_CANCEL: + case GTK_RESPONSE_DELETE_EVENT: + break; + case GTK_RESPONSE_OK: + dst_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); + /* Do window specific stuff */ + if (MODEST_IS_MAIN_WINDOW (parent_win)) { + modest_ui_actions_on_main_window_move_to (NULL, + folder_view, + dst_folder, + MODEST_MAIN_WINDOW (parent_win)); +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_FOLDER_WINDOW (parent_win)) { + modest_ui_actions_on_folder_window_move_to (folder_view, + dst_folder, + helper->list, + GTK_WINDOW (parent_win)); +#endif + } else { + /* Moving from headers window in edit mode */ + modest_ui_actions_on_window_move_to (NULL, helper->list, + dst_folder, + MODEST_WINDOW (parent_win)); + } + + if (dst_folder) + g_object_unref (dst_folder); + + break; + default: + g_warning ("%s unexpected response id %d", __FUNCTION__, response); + } + + /* Free the helper and exit */ + if (helper->list) + g_object_unref (helper->list); + g_slice_free (MoveToInfo, helper); + gtk_widget_destroy (GTK_WIDGET (dialog)); } static GtkWidget* create_move_to_dialog (GtkWindow *win, - GtkWidget *folder_view, - GtkWidget **tree_view) + GtkWidget *folder_view) { - GtkWidget *dialog, *scroll; - GtkWidget *new_button; - - dialog = gtk_dialog_new_with_buttons (_("mcen_ti_moveto_folders_title"), - GTK_WINDOW (win), - GTK_DIALOG_MODAL | GTK_DIALOG_NO_SEPARATOR | GTK_DIALOG_DESTROY_WITH_PARENT, - NULL); - - gtk_dialog_add_button (GTK_DIALOG (dialog), _("mcen_bd_dialog_ok"), GTK_RESPONSE_ACCEPT); - /* We do this manually so GTK+ does not associate a response ID for - * the button. */ - new_button = gtk_button_new_from_stock (_("mcen_bd_new")); - gtk_box_pack_end (GTK_BOX (GTK_DIALOG (dialog)->action_area), new_button, FALSE, FALSE, 0); - gtk_dialog_add_button (GTK_DIALOG (dialog), _("mcen_bd_dialog_cancel"), GTK_RESPONSE_REJECT); + GtkWidget *dialog, *tree_view = NULL; - /* Create scrolled window */ - scroll = gtk_scrolled_window_new (NULL, NULL); - gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scroll), - GTK_POLICY_AUTOMATIC, - GTK_POLICY_AUTOMATIC); - - /* Create folder view */ - *tree_view = modest_platform_create_folder_view (NULL); + dialog = modest_platform_create_move_to_dialog (win, &tree_view); +#ifndef MODEST_TOOLKIT_HILDON2 /* Track changes in the selection to * disable the OK button whenever "Move to" is not possible * disbale NEW button whenever New is not possible */ - g_signal_connect (*tree_view, + g_signal_connect (tree_view, "folder_selection_changed", G_CALLBACK (on_move_to_dialog_folder_selection_changed), win); - - /* Listen to clicks on New button */ - g_signal_connect (G_OBJECT (new_button), - "clicked", - G_CALLBACK(create_move_to_dialog_on_new_folder), - *tree_view); +#endif /* It could happen that we're trying to move a message from a window (msg window for example) after the main window was @@ -4113,16 +4937,16 @@ create_move_to_dialog (GtkWindow *win, if (MODEST_IS_FOLDER_VIEW (folder_view)) { const gchar *visible_id = NULL; - modest_folder_view_set_style (MODEST_FOLDER_VIEW (*tree_view), + modest_folder_view_set_style (MODEST_FOLDER_VIEW (tree_view), MODEST_FOLDER_VIEW_STYLE_SHOW_ALL); modest_folder_view_copy_model (MODEST_FOLDER_VIEW(folder_view), - MODEST_FOLDER_VIEW(*tree_view)); + MODEST_FOLDER_VIEW(tree_view)); visible_id = modest_folder_view_get_account_id_of_visible_server_account (MODEST_FOLDER_VIEW(folder_view)); /* Show the same account than the one that is shown in the main window */ - modest_folder_view_set_account_id_of_visible_server_account (MODEST_FOLDER_VIEW(*tree_view), + modest_folder_view_set_account_id_of_visible_server_account (MODEST_FOLDER_VIEW(tree_view), visible_id); } else { const gchar *active_account_name = NULL; @@ -4130,9 +4954,9 @@ create_move_to_dialog (GtkWindow *win, ModestAccountSettings *settings = NULL; ModestServerAccountSettings *store_settings = NULL; - modest_folder_view_set_style (MODEST_FOLDER_VIEW (*tree_view), + modest_folder_view_set_style (MODEST_FOLDER_VIEW (tree_view), MODEST_FOLDER_VIEW_STYLE_SHOW_ALL); - modest_folder_view_update_model (MODEST_FOLDER_VIEW (*tree_view), + modest_folder_view_update_model (MODEST_FOLDER_VIEW (tree_view), TNY_ACCOUNT_STORE (modest_runtime_get_account_store ())); active_account_name = modest_window_get_active_account (MODEST_WINDOW (win)); @@ -4144,72 +4968,31 @@ create_move_to_dialog (GtkWindow *win, store_settings = modest_account_settings_get_store_settings (settings); store_account_name = modest_server_account_settings_get_account_name (store_settings); - modest_folder_view_set_account_id_of_visible_server_account (MODEST_FOLDER_VIEW (*tree_view), + modest_folder_view_set_account_id_of_visible_server_account (MODEST_FOLDER_VIEW (tree_view), store_account_name); g_object_unref (store_settings); g_object_unref (settings); } } - /* we keep a pointer to the embedded folder view, so we can retrieve it with - * get_folder_view_from_move_to_dialog - * (see above) later (needed for focus handling) + /* we keep a pointer to the embedded folder view, so we can + * retrieve it with get_folder_view_from_move_to_dialog (see + * above) later (needed for focus handling) */ - g_object_set_data (G_OBJECT(dialog), MODEST_MOVE_TO_DIALOG_FOLDER_VIEW, *tree_view); + g_object_set_data (G_OBJECT(dialog), MODEST_MOVE_TO_DIALOG_FOLDER_VIEW, tree_view); - /* Hide special folders */ - modest_folder_view_show_non_move_folders (MODEST_FOLDER_VIEW (*tree_view), FALSE); - - gtk_container_add (GTK_CONTAINER (scroll), *tree_view); - - /* Add scroll to dialog */ - gtk_box_pack_start (GTK_BOX (GTK_DIALOG (dialog)->vbox), - scroll, TRUE, TRUE, 0); + modest_folder_view_show_non_move_folders (MODEST_FOLDER_VIEW (tree_view), FALSE); +#ifndef MODEST_TOOLKIT_HILDON2 + modest_folder_view_select_first_inbox_or_local (MODEST_FOLDER_VIEW (tree_view)); +#endif - gtk_widget_show_all (GTK_WIDGET(GTK_DIALOG(dialog)->vbox)); - gtk_window_set_default_size (GTK_WINDOW (dialog), 300, 300); + gtk_widget_show (GTK_WIDGET (tree_view)); return dialog; } /* - * Returns TRUE if at least one of the headers of the list belongs to - * a message that has been fully retrieved. - */ -#if 0 /* no longer in use. delete in 2007.10 */ -static gboolean -has_retrieved_msgs (TnyList *list) -{ - TnyIterator *iter; - gboolean found = FALSE; - - iter = tny_list_create_iterator (list); - while (!tny_iterator_is_done (iter) && !found) { - TnyHeader *header; - TnyHeaderFlags flags = 0; - - header = TNY_HEADER (tny_iterator_get_current (iter)); - if (header) { - flags = tny_header_get_flags (header); - if (flags & TNY_HEADER_FLAG_CACHED) -/* if (!(flags & TNY_HEADER_FLAG_PARTIAL)) */ - found = TRUE; - - g_object_unref (header); - } - - if (!found) - tny_iterator_next (iter); - } - g_object_unref (iter); - - return found; -} -#endif /* 0 */ - - -/* * Shows a confirmation dialog to the user when we're moving messages * from a remote server to the local storage. Returns the dialog * response. If it's other kind of movement then it always returns @@ -4271,45 +5054,65 @@ modest_ui_actions_msgs_move_to_confirmation (ModestWindow *win, } static void +move_to_helper_destroyer (gpointer user_data) +{ + MoveToHelper *helper = (MoveToHelper *) user_data; + + /* Close the "Pasting" information banner */ + if (helper->banner) { + gtk_widget_destroy (GTK_WIDGET (helper->banner)); + g_object_unref (helper->banner); + } + if (gtk_tree_row_reference_valid (helper->reference)) { + gtk_tree_row_reference_free (helper->reference); + helper->reference = NULL; + } + g_free (helper); +} + +static void move_to_cb (ModestMailOperation *mail_op, gpointer user_data) { MoveToHelper *helper = (MoveToHelper *) user_data; + GObject *object = modest_mail_operation_get_source (mail_op); /* Note that the operation could have failed, in that case do nothing */ - if (modest_mail_operation_get_status (mail_op) == - MODEST_MAIL_OPERATION_STATUS_SUCCESS) { - - GObject *object = modest_mail_operation_get_source (mail_op); - if (MODEST_IS_MSG_VIEW_WINDOW (object)) { - ModestMsgViewWindow *self = MODEST_MSG_VIEW_WINDOW (object); + if (modest_mail_operation_get_status (mail_op) != + MODEST_MAIL_OPERATION_STATUS_SUCCESS) + goto frees; - if (!modest_msg_view_window_select_next_message (self) && - !modest_msg_view_window_select_previous_message (self)) { - /* No more messages to view, so close this window */ - modest_ui_actions_on_close_window (NULL, MODEST_WINDOW(self)); - } - } else if (MODEST_IS_MAIN_WINDOW (object) && helper->reference != NULL) { - GtkWidget *header_view; - GtkTreePath *path; - GtkTreeSelection *sel; + if (MODEST_IS_MSG_VIEW_WINDOW (object)) { + ModestMsgViewWindow *self = MODEST_MSG_VIEW_WINDOW (object); - header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(object), - MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); - sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (header_view)); - path = gtk_tree_row_reference_get_path (helper->reference); - gtk_tree_selection_select_path (sel, path); - gtk_tree_path_free (path); + if (!modest_msg_view_window_select_next_message (self) && + !modest_msg_view_window_select_previous_message (self)) { + /* No more messages to view, so close this window */ + modest_ui_actions_on_close_window (NULL, MODEST_WINDOW(self)); } - g_object_unref (object); - } + } else if (MODEST_IS_MAIN_WINDOW (object) && + gtk_tree_row_reference_valid (helper->reference)) { + GtkWidget *header_view; + GtkTreePath *path; + GtkTreeSelection *sel; - /* Close the "Pasting" information banner */ - gtk_widget_destroy (GTK_WIDGET(helper->banner)); - if (helper->reference != NULL) - gtk_tree_row_reference_free (helper->reference); - g_free (helper); + header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(object), + MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); + sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (header_view)); + path = gtk_tree_row_reference_get_path (helper->reference); + /* We need to unselect the previous one + because we could be copying instead of + moving */ + gtk_tree_selection_unselect_all (sel); + gtk_tree_selection_select_path (sel, path); + gtk_tree_path_free (path); + } + g_object_unref (object); + + frees: + /* Destroy the helper */ + move_to_helper_destroyer (helper); } static void @@ -4321,13 +5124,17 @@ folder_move_to_cb (ModestMailOperation *mail_op, GObject *object; object = modest_mail_operation_get_source (mail_op); - folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(object), - MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); - g_object_ref (folder_view); - g_object_unref (object); - move_to_cb (mail_op, user_data); - modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), new_folder, FALSE); - g_object_unref (folder_view); + if (MODEST_IS_MAIN_WINDOW (object)) { + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(object), + MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + g_object_ref (folder_view); + g_object_unref (object); + move_to_cb (mail_op, user_data); + modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), new_folder, FALSE); + g_object_unref (folder_view); + } else { + move_to_cb (mail_op, user_data); + } } static void @@ -4341,55 +5148,36 @@ void modest_ui_actions_move_folder_error_handler (ModestMailOperation *mail_op, gpointer user_data) { - ModestWindow *main_window = NULL; GObject *win = NULL; - + +#ifndef MODEST_TOOLKIT_HILDON2 + ModestWindow *main_window = NULL; + /* Disable next automatic folder selection */ main_window = modest_window_mgr_get_main_window (modest_runtime_get_window_mgr (), FALSE); /* don't create */ if (main_window) { GtkWidget *folder_view = NULL; - + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (main_window), MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); modest_folder_view_disable_next_folder_selection (MODEST_FOLDER_VIEW(folder_view)); - + if (user_data && TNY_IS_FOLDER (user_data)) { modest_folder_view_select_folder (MODEST_FOLDER_VIEW (folder_view), TNY_FOLDER (user_data), FALSE); } } - - /* Show notification dialog */ +#endif + /* Show notification dialog only if the main window exists */ win = modest_mail_operation_get_source (mail_op); - modest_platform_run_information_dialog ((GtkWindow *) win, _("mail_in_ui_folder_move_target_error")); + modest_platform_run_information_dialog ((GtkWindow *) win, + _("mail_in_ui_folder_move_target_error"), + FALSE); if (win) g_object_unref (win); } -void -modest_ui_actions_send_receive_error_handler (ModestMailOperation *mail_op, - gpointer user_data) -{ - GObject *win = modest_mail_operation_get_source (mail_op); - const GError *error = modest_mail_operation_get_error (mail_op); - - g_return_if_fail (error != NULL); - if (error->message != NULL) - g_printerr ("modest: %s\n", error->message); - else - g_printerr ("modest: unkonw error on send&receive operation"); - - /* Show error message */ -/* if (modest_mail_operation_get_id (mail_op) == MODEST_MAIL_OPERATION_TYPE_RECEIVE) */ -/* modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, */ -/* _CS("sfil_ib_unable_to_receive")); */ -/* else */ -/* modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, */ -/* _CS("sfil_ib_unable_to_send")); */ - g_object_unref (win); -} - static void open_msg_for_purge_cb (ModestMailOperation *mail_op, TnyHeader *header, @@ -4441,7 +5229,9 @@ open_msg_for_purge_cb (ModestMailOperation *mail_op, response = modest_platform_run_confirmation_dialog (GTK_WINDOW (win),_("mcen_nc_purge_file_text_inbox")); if (response == GTK_RESPONSE_OK) { - modest_platform_information_banner (NULL, NULL, _("mcen_ib_removing_attachment")); + GtkWidget *info; + info = + modest_platform_animation_banner (GTK_WIDGET (win), NULL, _("mcen_me_inbox_remove_attachments")); iter = tny_list_create_iterator (parts); while (!tny_iterator_is_done (iter)) { TnyMimePart *part; @@ -4458,10 +5248,9 @@ open_msg_for_purge_cb (ModestMailOperation *mail_op, g_object_unref (iter); tny_msg_rewrite_cache (msg); + + gtk_widget_destroy (info); } - /* } else { */ - /* This string no longer exists, refer to NB#75415 for more info */ - /* modest_platform_information_banner (NULL, NULL, _("mail_ib_attachment_already_purged")); */ } modest_window_mgr_unregister_header (mgr, header); @@ -4519,10 +5308,10 @@ modest_ui_actions_on_main_window_remove_attachments (GtkAction *action, ModestMailOperation *mail_op = NULL; modest_window_mgr_register_header (modest_runtime_get_window_mgr (), header, NULL); mail_op = modest_mail_operation_new_with_error_handling (G_OBJECT (win), - modest_ui_actions_get_msgs_full_error_handler, + modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_get_msg (mail_op, header, open_msg_for_purge_cb, win); + modest_mail_operation_get_msg (mail_op, header, FALSE, open_msg_for_purge_cb, win); g_object_unref (mail_op); } @@ -4536,7 +5325,7 @@ modest_ui_actions_on_main_window_remove_attachments (GtkAction *action, * Checks if we need a connection to do the transfer and if the user * wants to connect to complete it */ -void +static void modest_ui_actions_xfer_messages_check (GtkWindow *parent_window, TnyFolderStore *src_folder, TnyList *headers, @@ -4548,8 +5337,6 @@ modest_ui_actions_xfer_messages_check (GtkWindow *parent_window, TnyAccount *src_account; gint uncached_msgs = 0; - uncached_msgs = header_list_count_uncached_msgs (headers); - /* We don't need any further check if * * 1- the source folder is local OR @@ -4571,6 +5358,7 @@ modest_ui_actions_xfer_messages_check (GtkWindow *parent_window, * offline, it'll take place the next time we get a * connection) */ + uncached_msgs = header_list_count_uncached_msgs (headers); src_account = get_account_from_folder_store (src_folder); if (uncached_msgs > 0) { guint num_headers; @@ -4590,14 +5378,14 @@ modest_ui_actions_xfer_messages_check (GtkWindow *parent_window, /* The transfer is possible and the user wants to */ *do_xfer = TRUE; - if (remote_folder_is_pop (src_folder) && delete_originals) { + if (remote_folder_has_leave_on_server (src_folder) && delete_originals) { const gchar *account_name; gboolean leave_on_server; - + account_name = modest_tny_account_get_parent_modest_account_name_for_server_account (src_account); leave_on_server = modest_account_mgr_get_leave_on_server (modest_runtime_get_account_mgr (), account_name); - + if (leave_on_server == TRUE) { *need_connection = FALSE; } else { @@ -4612,6 +5400,31 @@ modest_ui_actions_xfer_messages_check (GtkWindow *parent_window, g_object_unref (src_account); } +static void +xfer_messages_error_handler (ModestMailOperation *mail_op, + gpointer user_data) +{ + GObject *win; + const GError *error; + + win = modest_mail_operation_get_source (mail_op); + error = modest_mail_operation_get_error (mail_op); + + if (error && is_memory_full_error ((GError *) error)) + modest_platform_information_banner ((GtkWidget *) win, + NULL, _KR("cerm_device_memory_full")); + else + modest_platform_run_information_dialog ((GtkWindow *) win, + _("mail_in_ui_folder_move_target_error"), + FALSE); + if (win) + g_object_unref (win); +} + +typedef struct { + TnyFolderStore *dst_folder; + TnyList *headers; +} XferMsgsHelper; /** * Utility function that transfer messages from both the main window @@ -4624,80 +5437,77 @@ xfer_messages_performer (gboolean canceled, TnyAccount *account, gpointer user_data) { - TnyFolderStore *dst_folder = TNY_FOLDER_STORE (user_data); ModestWindow *win = MODEST_WINDOW (parent_window); - TnyList *headers = NULL; TnyAccount *dst_account = NULL; - const gchar *proto_str = NULL; - gboolean dst_is_pop = FALSE; + gboolean dst_forbids_message_add = FALSE; + XferMsgsHelper *helper; + MoveToHelper *movehelper; + ModestMailOperation *mail_op; + + helper = (XferMsgsHelper *) user_data; if (canceled || err) { - /* Show the proper error message */ - modest_ui_actions_on_account_connection_error (parent_window, account); - g_object_unref (dst_folder); - return; + if (!check_memory_full_error ((GtkWidget *) parent_window, err)) { + /* Show the proper error message */ + modest_ui_actions_on_account_connection_error (parent_window, account); + } + goto end; } - dst_account = tny_folder_get_account (TNY_FOLDER (dst_folder)); - proto_str = tny_account_get_proto (dst_account); + dst_account = tny_folder_get_account (TNY_FOLDER (helper->dst_folder)); /* tinymail will return NULL for local folders it seems */ - dst_is_pop = proto_str && - (modest_protocol_info_get_transport_store_protocol (proto_str) == - MODEST_PROTOCOL_STORE_POP); - + dst_forbids_message_add = modest_protocol_registry_protocol_type_has_tag (modest_runtime_get_protocol_registry (), + modest_tny_account_get_protocol_type (dst_account), + MODEST_PROTOCOL_REGISTRY_STORE_FORBID_MESSAGE_ADD); g_object_unref (dst_account); - /* Get selected headers */ - headers = get_selected_headers (MODEST_WINDOW (win)); - if (!headers) { - g_warning ("%s: no headers selected", __FUNCTION__); - return; - } - - - if (dst_is_pop) { + if (dst_forbids_message_add) { modest_platform_information_banner (GTK_WIDGET (win), NULL, ngettext("mail_in_ui_folder_move_target_error", "mail_in_ui_folder_move_targets_error", - tny_list_get_length (headers))); - g_object_unref (headers); - return; + tny_list_get_length (helper->headers))); + goto end; } - MoveToHelper *helper = g_new0 (MoveToHelper, 1); - helper->banner = modest_platform_animation_banner (GTK_WIDGET (win), NULL, - _CS("ckct_nw_pasting")); - if (helper->banner != NULL) { - gtk_window_set_modal (GTK_WINDOW(helper->banner), FALSE); - gtk_widget_show (GTK_WIDGET(helper->banner)); + movehelper = g_new0 (MoveToHelper, 1); + +#ifndef MODEST_TOOLKIT_HILDON2 + movehelper->banner = modest_platform_animation_banner (GTK_WIDGET (win), NULL, + _CS("ckct_nw_pasting")); + if (movehelper->banner != NULL) { + g_object_ref (movehelper->banner); + gtk_widget_show (GTK_WIDGET (movehelper->banner)); } +#endif if (MODEST_IS_MAIN_WINDOW (win)) { GtkWidget *header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW(win), MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); - helper->reference = get_next_after_selected_headers (MODEST_HEADER_VIEW (header_view)); + movehelper->reference = get_next_after_selected_headers (MODEST_HEADER_VIEW (header_view)); } - ModestMailOperation *mail_op = - modest_mail_operation_new_with_error_handling (G_OBJECT(win), - modest_ui_actions_move_folder_error_handler, - NULL, NULL); + /* Perform the mail operation */ + mail_op = modest_mail_operation_new_with_error_handling (G_OBJECT(win), + xfer_messages_error_handler, + movehelper, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); modest_mail_operation_xfer_msgs (mail_op, - headers, - TNY_FOLDER (dst_folder), + helper->headers, + TNY_FOLDER (helper->dst_folder), TRUE, msgs_move_to_cb, - helper); + movehelper); g_object_unref (G_OBJECT (mail_op)); - g_object_unref (headers); - g_object_unref (dst_folder); + end: + g_object_unref (helper->dst_folder); + g_object_unref (helper->headers); + g_slice_free (XferMsgsHelper, helper); } typedef struct { @@ -4714,21 +5524,23 @@ on_move_folder_cb (gboolean canceled, GError *err, GtkWindow *parent_window, MoveFolderInfo *info = (MoveFolderInfo*)user_data; GtkTreeSelection *sel; ModestMailOperation *mail_op = NULL; - - if (canceled || err || !MODEST_IS_MAIN_WINDOW (parent_window)) { + + if (canceled || err || !MODEST_IS_WINDOW (parent_window)) { g_object_unref (G_OBJECT (info->src_folder)); g_object_unref (G_OBJECT (info->dst_folder)); g_free (info); return; } - + MoveToHelper *helper = g_new0 (MoveToHelper, 1); +#ifndef MODEST_TOOLKIT_HILDON2 helper->banner = modest_platform_animation_banner (GTK_WIDGET (parent_window), NULL, _CS("ckct_nw_pasting")); if (helper->banner != NULL) { - gtk_window_set_modal (GTK_WINDOW(helper->banner), FALSE); + g_object_ref (helper->banner); gtk_widget_show (GTK_WIDGET(helper->banner)); } +#endif /* Clean folder on header view before moving it */ sel = gtk_tree_view_get_selection (GTK_TREE_VIEW (info->folder_view)); gtk_tree_selection_unselect_all (sel); @@ -4754,21 +5566,23 @@ on_move_folder_cb (gboolean canceled, GError *err, GtkWindow *parent_window, /* modest_folder_view_select_folder (MODEST_FOLDER_VIEW(folder_view), */ /* TNY_FOLDER (src_folder), TRUE); */ + if (MODEST_IS_MAIN_WINDOW (parent_window)) { + modest_folder_view_select_folder (MODEST_FOLDER_VIEW(info->folder_view), + TNY_FOLDER (info->dst_folder), TRUE); + } modest_mail_operation_xfer_folder (mail_op, TNY_FOLDER (info->src_folder), info->dst_folder, info->delete_original, folder_move_to_cb, helper); + g_object_unref (G_OBJECT (info->src_folder)); - if (modest_mail_operation_get_status (mail_op) == MODEST_MAIL_OPERATION_STATUS_SUCCESS) { - modest_folder_view_select_folder (MODEST_FOLDER_VIEW(info->folder_view), - TNY_FOLDER (info->dst_folder), TRUE); - } + /* if (modest_mail_operation_get_status (mail_op) == MODEST_MAIL_OPERATION_STATUS_SUCCESS) { */ + /* } */ /* Unref mail operation */ g_object_unref (G_OBJECT (mail_op)); - g_object_unref (G_OBJECT (info->src_folder)); g_object_unref (G_OBJECT (info->dst_folder)); g_free (user_data); } @@ -4801,7 +5615,8 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, src_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); /* Get header view */ - header_view = MODEST_HEADER_VIEW(modest_main_window_get_child_widget (win, MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW)); + header_view = (ModestHeaderView *) + modest_main_window_get_child_widget (win, MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); /* Get folder or messages to transfer */ if (gtk_widget_is_focus (folder_view)) { @@ -4817,7 +5632,7 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, do_xfer = FALSE; } - if (do_xfer) { + if (do_xfer) { MoveFolderInfo *info = g_new0 (MoveFolderInfo, 1); DoubleConnectionInfo *connect_info = g_slice_new (DoubleConnectionInfo); @@ -4840,8 +5655,8 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, headers = modest_header_view_get_selected_headers(header_view); /* Transfer the messages */ - transfer_messages_helper (GTK_WINDOW (win), TNY_FOLDER (src_folder), - headers, TNY_FOLDER (dst_folder)); + modest_ui_actions_transfer_messages_helper (GTK_WINDOW (win), TNY_FOLDER (src_folder), + headers, TNY_FOLDER (dst_folder)); g_object_unref (headers); } @@ -4850,15 +5665,81 @@ modest_ui_actions_on_main_window_move_to (GtkAction *action, g_object_unref (src_folder); } +#ifdef MODEST_TOOLKIT_HILDON2 +/* + * UI handler for the "Move to" action when invoked from the + * ModestFolderWindow + */ +static void +modest_ui_actions_on_folder_window_move_to (GtkWidget *folder_view, + TnyFolderStore *dst_folder, + TnyList *selection, + GtkWindow *win) +{ + TnyFolderStore *src_folder = NULL; + TnyIterator *iterator; + + if (tny_list_get_length (selection) != 1) + return; + + iterator = tny_list_create_iterator (selection); + src_folder = TNY_FOLDER_STORE (tny_iterator_get_current (iterator)); + g_object_unref (iterator); -static void -transfer_messages_helper (GtkWindow *win, - TnyFolder *src_folder, - TnyList *headers, - TnyFolder *dst_folder) + + gboolean do_xfer = TRUE; + + /* Allow only to transfer folders to the local root folder */ + if (TNY_IS_ACCOUNT (dst_folder) && + !MODEST_IS_TNY_LOCAL_FOLDERS_ACCOUNT (dst_folder) && + !modest_tny_account_is_memory_card_account (TNY_ACCOUNT (dst_folder))) { + do_xfer = FALSE; + /* Show an error */ + modest_platform_run_information_dialog (win, + _("mail_in_ui_folder_move_target_error"), + FALSE); + } else if (!TNY_IS_FOLDER (src_folder)) { + g_warning ("%s: src_folder is not a TnyFolder.\n", __FUNCTION__); + do_xfer = FALSE; + } + + if (do_xfer) { + MoveFolderInfo *info = g_new0 (MoveFolderInfo, 1); + DoubleConnectionInfo *connect_info = g_slice_new (DoubleConnectionInfo); + + info->src_folder = g_object_ref (src_folder); + info->dst_folder = g_object_ref (dst_folder); + info->delete_original = TRUE; + info->folder_view = folder_view; + + connect_info->callback = on_move_folder_cb; + connect_info->dst_account = get_account_from_folder_store (TNY_FOLDER_STORE (dst_folder)); + connect_info->data = info; + + modest_platform_double_connect_and_perform(GTK_WINDOW (win), TRUE, + TNY_FOLDER_STORE (src_folder), + connect_info); + } + + /* Frees */ + g_object_unref (src_folder); +} +#endif + + +void +modest_ui_actions_transfer_messages_helper (GtkWindow *win, + TnyFolder *src_folder, + TnyList *headers, + TnyFolder *dst_folder) { gboolean need_connection = TRUE; gboolean do_xfer = TRUE; + XferMsgsHelper *helper; + + g_return_if_fail (TNY_IS_FOLDER (src_folder)); + g_return_if_fail (TNY_IS_FOLDER (dst_folder)); + g_return_if_fail (TNY_IS_LIST (headers)); modest_ui_actions_xfer_messages_check (win, TNY_FOLDER_STORE (src_folder), headers, TNY_FOLDER (dst_folder), @@ -4869,11 +5750,16 @@ transfer_messages_helper (GtkWindow *win, if (!do_xfer) return; + /* Create the helper */ + helper = g_slice_new (XferMsgsHelper); + helper->dst_folder = g_object_ref (dst_folder); + helper->headers = g_object_ref (headers); + if (need_connection) { DoubleConnectionInfo *connect_info = g_slice_new (DoubleConnectionInfo); connect_info->callback = xfer_messages_performer; connect_info->dst_account = tny_folder_get_account (TNY_FOLDER (dst_folder)); - connect_info->data = g_object_ref (dst_folder); + connect_info->data = helper; modest_platform_double_connect_and_perform(GTK_WINDOW (win), TRUE, TNY_FOLDER_STORE (src_folder), @@ -4881,8 +5767,7 @@ transfer_messages_helper (GtkWindow *win, } else { TnyAccount *src_account = get_account_from_folder_store (TNY_FOLDER_STORE (src_folder)); xfer_messages_performer (FALSE, NULL, GTK_WINDOW (win), - src_account, - g_object_ref (dst_folder)); + src_account, helper); g_object_unref (src_account); } } @@ -4891,85 +5776,91 @@ transfer_messages_helper (GtkWindow *win, * UI handler for the "Move to" action when invoked from the * ModestMsgViewWindow */ -static void -modest_ui_actions_on_msg_view_window_move_to (GtkAction *action, - TnyFolderStore *dst_folder, - ModestMsgViewWindow *win) +static void +modest_ui_actions_on_window_move_to (GtkAction *action, + TnyList *headers, + TnyFolderStore *dst_folder, + ModestWindow *win) { - TnyList *headers = NULL; - TnyHeader *header = NULL; TnyFolder *src_folder = NULL; g_return_if_fail (TNY_IS_FOLDER (dst_folder)); - /* Create header list */ - header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (win)); - src_folder = TNY_FOLDER (tny_header_get_folder(header)); - headers = tny_simple_list_new (); - tny_list_append (headers, G_OBJECT (header)); + if (headers) { + TnyHeader *header = NULL; + TnyIterator *iter; - /* Transfer the messages */ - transfer_messages_helper (GTK_WINDOW (win), src_folder, headers, - TNY_FOLDER (dst_folder)); + iter = tny_list_create_iterator (headers); + header = (TnyHeader *) tny_iterator_get_current (iter); + src_folder = tny_header_get_folder (header); - /* Frees */ - g_object_unref (header); - g_object_unref (headers); + /* Transfer the messages */ + modest_ui_actions_transfer_messages_helper (GTK_WINDOW (win), src_folder, + headers, + TNY_FOLDER (dst_folder)); + + /* Frees */ + g_object_unref (header); + g_object_unref (iter); + g_object_unref (src_folder); + } } void modest_ui_actions_on_move_to (GtkAction *action, ModestWindow *win) { - GtkWidget *dialog = NULL, *folder_view = NULL, *tree_view = NULL; - gint result = 0; - TnyFolderStore *dst_folder = NULL; - ModestMainWindow *main_window; + modest_ui_actions_on_edit_mode_move_to (win); +} + +gboolean +modest_ui_actions_on_edit_mode_move_to (ModestWindow *win) +{ + GtkWidget *dialog = NULL; + MoveToInfo *helper = NULL; + TnyList *list_to_move; - g_return_if_fail (MODEST_IS_MAIN_WINDOW (win) || - MODEST_IS_MSG_VIEW_WINDOW (win)); + g_return_val_if_fail (MODEST_IS_WINDOW (win), FALSE); +#ifndef MODEST_TOOLKIT_HILDON2 /* Get the main window if exists */ + ModestMainWindow *main_window; if (MODEST_IS_MAIN_WINDOW (win)) main_window = MODEST_MAIN_WINDOW (win); else main_window = MODEST_MAIN_WINDOW (modest_window_mgr_get_main_window (modest_runtime_get_window_mgr (), FALSE)); /* don't create */ +#endif - /* Get the folder view widget if exists */ - if (main_window) - folder_view = modest_main_window_get_child_widget (main_window, - MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); - else - folder_view = NULL; + list_to_move = modest_platform_get_list_to_move (MODEST_WINDOW (win)); + + if (!list_to_move) + return FALSE; + + if (tny_list_get_length (list_to_move) < 1) { + g_object_unref (list_to_move); + return FALSE; + } /* Create and run the dialog */ - dialog = create_move_to_dialog (GTK_WINDOW (win), folder_view, &tree_view); - modest_folder_view_select_first_inbox_or_local (MODEST_FOLDER_VIEW (tree_view)); - gtk_window_set_modal (GTK_WINDOW (dialog), TRUE); - result = gtk_dialog_run (GTK_DIALOG(dialog)); - g_object_ref (tree_view); - gtk_widget_destroy (dialog); + dialog = create_move_to_dialog (GTK_WINDOW (win), NULL); + modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), + GTK_WINDOW (dialog), + (GtkWindow *) win); - if (result != GTK_RESPONSE_ACCEPT) - return; + /* Create helper */ + helper = g_slice_new0 (MoveToInfo); + helper->list = list_to_move; + helper->win = win; - dst_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (tree_view)); - /* Do window specific stuff */ - if (MODEST_IS_MAIN_WINDOW (win)) { - modest_ui_actions_on_main_window_move_to (action, - folder_view, - dst_folder, - MODEST_MAIN_WINDOW (win)); - } else { - modest_ui_actions_on_msg_view_window_move_to (action, - dst_folder, - MODEST_MSG_VIEW_WINDOW (win)); - } + /* Listen to response signal */ + g_signal_connect (dialog, "response", G_CALLBACK (on_move_to_dialog_response), helper); + + /* Show the dialog */ + gtk_widget_show (dialog); - if (dst_folder) - g_object_unref (dst_folder); + return TRUE; } /* @@ -5009,10 +5900,12 @@ do_headers_action (ModestWindow *win, /* Trick: do a poke status in order to speed up the signaling of observers */ - tny_folder_poke_status (folder); + if (folder) { + tny_folder_poke_status (folder); + g_object_unref (folder); + } /* Frees */ - g_object_unref (folder); g_object_unref (iter); g_object_unref (headers_list); } @@ -5034,6 +5927,10 @@ modest_ui_actions_save_attachments (GtkAction *action, ModestWindow *window) { if (MODEST_IS_MSG_VIEW_WINDOW (window)) { + + if (modest_platform_check_memory_low (MODEST_WINDOW(window), TRUE)) + return; + modest_msg_view_window_save_attachments (MODEST_MSG_VIEW_WINDOW (window), NULL); } else { /* not supported window for this action */ @@ -5075,17 +5972,62 @@ void modest_ui_actions_on_help (GtkAction *action, GtkWindow *win) { + /* Help app is not available at all in fremantle */ +#ifndef MODEST_TOOLKIT_HILDON2 const gchar *help_id; - g_return_if_fail (action); g_return_if_fail (win && GTK_IS_WINDOW(win)); help_id = modest_window_mgr_get_help_id (modest_runtime_get_window_mgr(), win); - - if (help_id) - modest_platform_show_help (GTK_WINDOW (win), help_id); + + if (help_id) + modest_platform_show_help (GTK_WINDOW (win), help_id); +#endif +} + +void +modest_ui_actions_on_csm_help (GtkAction *action, + GtkWindow *win) +{ + /* Help app is not available at all in fremantle */ +#ifndef MODEST_TOOLKIT_HILDON2 + + const gchar* help_id = NULL; + GtkWidget *folder_view; + TnyFolderStore *folder_store; + + g_return_if_fail (win && MODEST_IS_MAIN_WINDOW (win)); + + /* Get selected folder */ + folder_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (win), + MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); + folder_store = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); + + /* Switch help_id */ + if (folder_store && TNY_IS_FOLDER (folder_store)) + help_id = modest_tny_folder_get_help_id (TNY_FOLDER (folder_store)); + + if (folder_store) + g_object_unref (folder_store); + + if (help_id) + modest_platform_show_help (GTK_WINDOW (win), help_id); else - g_warning ("%s: no help for window %p", __FUNCTION__, win); + modest_ui_actions_on_help (action, win); +#endif +} + +static void +retrieve_contents_cb (ModestMailOperation *mail_op, + TnyHeader *header, + gboolean canceled, + TnyMsg *msg, + GError *err, + gpointer user_data) +{ + /* We only need this callback to show an error in case of + memory low condition */ + modest_ui_actions_msg_retrieval_check (mail_op, header, msg); } static void @@ -5099,15 +6041,16 @@ retrieve_msg_contents_performer (gboolean canceled, TnyList *headers = TNY_LIST (user_data); if (err || canceled) { + check_memory_full_error ((GtkWidget *) parent_window, err); goto out; } /* Create mail operation */ mail_op = modest_mail_operation_new_with_error_handling ((GObject *) parent_window, - modest_ui_actions_get_msgs_full_error_handler, + modest_ui_actions_disk_operations_error_handler, NULL, NULL); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); - modest_mail_operation_get_msgs_full (mail_op, headers, NULL, NULL, NULL); + modest_mail_operation_get_msgs_full (mail_op, headers, retrieve_contents_cb, NULL, NULL); /* Frees */ g_object_unref (mail_op); @@ -5264,6 +6207,12 @@ modest_ui_actions_on_search_messages (GtkAction *action, ModestWindow *window) { g_return_if_fail (MODEST_IS_WINDOW (window)); + /* we check for low-mem; in that case, show a warning, and don't allow + * searching + */ + if (modest_platform_check_memory_low (window, TRUE)) + return; + modest_platform_show_search_messages (GTK_WINDOW (window)); } @@ -5271,17 +6220,33 @@ void modest_ui_actions_on_open_addressbook (GtkAction *action, ModestWindow *win) { g_return_if_fail (MODEST_IS_WINDOW (win)); + + + /* we check for low-mem; in that case, show a warning, and don't allow + * for the addressbook + */ + if (modest_platform_check_memory_low (win, TRUE)) + return; + + modest_platform_show_addressbook (GTK_WINDOW (win)); } void -modest_ui_actions_on_toggle_find_in_page (GtkToggleAction *action, +modest_ui_actions_on_toggle_find_in_page (GtkAction *action, ModestWindow *window) { + gboolean active; g_return_if_fail (MODEST_IS_MSG_EDIT_WINDOW (window)); - modest_msg_edit_window_toggle_find_toolbar (MODEST_MSG_EDIT_WINDOW (window), gtk_toggle_action_get_active (action)); + if (GTK_IS_TOGGLE_ACTION (action)) + active = gtk_toggle_action_get_active (GTK_TOGGLE_ACTION (action)); + else + active = TRUE; + + modest_msg_edit_window_toggle_find_toolbar (MODEST_MSG_EDIT_WINDOW (window), + active); } static void @@ -5349,46 +6314,45 @@ modest_ui_actions_on_send_queue_error_happened (TnySendQueue *self, TnyTransportAccount *server_account; gchar *message = NULL; - /* Don't show anything if the user cancelled something */ - if (err->code == TNY_SYSTEM_ERROR_CANCEL) + /* Don't show anything if the user cancelled something or the + * send receive request is not interactive. Authentication + * errors are managed by the account store so no need to show + * a dialog here again */ + if (err->code == TNY_SYSTEM_ERROR_CANCEL || + err->code == TNY_SERVICE_ERROR_AUTHENTICATE || + !modest_tny_send_queue_get_requested_send_receive (MODEST_TNY_SEND_QUEUE (self))) return; + /* Get the server name: */ server_account = TNY_TRANSPORT_ACCOUNT (tny_camel_send_queue_get_transport_account (TNY_CAMEL_SEND_QUEUE (self))); - if (server_account) { - server_name = tny_account_get_hostname (TNY_ACCOUNT (server_account)); - - g_object_unref (server_account); - server_account = NULL; - } - - g_return_if_fail (server_name); + if (server_account) + server_name = tny_account_get_hostname (TNY_ACCOUNT (server_account)); + else + g_return_if_reached (); /* Show the appropriate message text for the GError: */ switch (err->code) { case TNY_SERVICE_ERROR_CONNECT: message = g_strdup_printf (_("emev_ib_ui_smtp_server_invalid"), server_name); break; - case TNY_SERVICE_ERROR_AUTHENTICATE: - message = g_strdup_printf (_("emev_ni_ui_smtp_authentication_fail_error"), server_name); - break; case TNY_SERVICE_ERROR_SEND: - message = g_strdup (_("emev_ib_ui_smtp_send_error")); + message = g_strdup (_CS("sfil_ib_unable_to_send")); + break; + case TNY_SERVICE_ERROR_UNAVAILABLE: + message = g_strdup_printf (_("emev_ib_ui_smtp_server_invalid"), server_name); break; default: g_warning ("%s: unexpected ERROR %d", __FUNCTION__, err->code); - message = g_strdup (_("emev_ib_ui_smtp_send_error")); + message = g_strdup (_CS("sfil_ib_unable_to_send")); break; } - - /* TODO if the username or the password where not defined we - should show the Accounts Settings dialog or the Connection - specific SMTP server window */ - modest_platform_run_information_dialog (NULL, message); + modest_platform_run_information_dialog (NULL, message, FALSE); g_free (message); + g_object_unref (server_account); } void @@ -5397,82 +6361,79 @@ modest_ui_actions_on_send_queue_status_changed (ModestTnySendQueue *send_queue, guint status, gpointer user_data) { - ModestMainWindow *main_window = NULL; + ModestWindow *top_window = NULL; ModestWindowMgr *mgr = NULL; - GtkWidget *folder_view = NULL, *header_view = NULL; - TnyFolderStore *selected_folder = NULL; + GtkWidget *header_view = NULL; + TnyFolder *selected_folder = NULL; TnyFolderType folder_type; mgr = modest_runtime_get_window_mgr (); - main_window = MODEST_MAIN_WINDOW (modest_window_mgr_get_main_window (mgr, - FALSE));/* don't create */ - if (!main_window) + top_window = modest_window_mgr_get_current_top (mgr); + + if (!top_window) return; - /* Check if selected folder is OUTBOX */ - folder_view = modest_main_window_get_child_widget (main_window, - MODEST_MAIN_WINDOW_WIDGET_TYPE_FOLDER_VIEW); - header_view = modest_main_window_get_child_widget (main_window, - MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); +#ifndef MODEST_TOOLKIT_HILDON2 + if (MODEST_IS_MAIN_WINDOW (top_window)) { + header_view = modest_main_window_get_child_widget (MODEST_MAIN_WINDOW (top_window), + MODEST_MAIN_WINDOW_WIDGET_TYPE_HEADER_VIEW); + } +#else + if (MODEST_IS_HEADER_WINDOW (top_window)) { + header_view = (GtkWidget *) + modest_header_window_get_header_view (MODEST_HEADER_WINDOW (top_window)); + } +#endif - selected_folder = modest_folder_view_get_selected (MODEST_FOLDER_VIEW (folder_view)); - if (!TNY_IS_FOLDER (selected_folder)) - goto frees; + /* Get selected folder */ + selected_folder = modest_header_view_get_folder (MODEST_HEADER_VIEW (header_view)); + if (!selected_folder) + return; /* gtk_tree_view_column_queue_resize is only available in GTK+ 2.8 */ -#if GTK_CHECK_VERSION(2, 8, 0) - folder_type = modest_tny_folder_guess_folder_type (TNY_FOLDER (selected_folder)); - if (folder_type == TNY_FOLDER_TYPE_OUTBOX) { +#if GTK_CHECK_VERSION(2, 8, 0) + folder_type = modest_tny_folder_guess_folder_type (selected_folder); + if (folder_type == TNY_FOLDER_TYPE_OUTBOX) { GtkTreeViewColumn *tree_column; - tree_column = gtk_tree_view_get_column (GTK_TREE_VIEW (header_view), + tree_column = gtk_tree_view_get_column (GTK_TREE_VIEW (header_view), TNY_GTK_HEADER_LIST_MODEL_FROM_COLUMN); - gtk_tree_view_column_queue_resize (tree_column); - } -#else + if (tree_column) + gtk_tree_view_column_queue_resize (tree_column); + } +#else /* #if GTK_CHECK_VERSION(2, 8, 0) */ gtk_widget_queue_draw (header_view); -#endif +#endif +#ifndef MODEST_TOOLKIT_HILDON2 /* Rerun dimming rules, because the message could become deletable for example */ - modest_window_check_dimming_rules_group (MODEST_WINDOW (main_window), + modest_window_check_dimming_rules_group (MODEST_WINDOW (top_window), MODEST_DIMMING_RULES_TOOLBAR); - + modest_window_check_dimming_rules_group (MODEST_WINDOW (top_window), + MODEST_DIMMING_RULES_MENU); +#endif + /* Free */ - frees: - if (selected_folder != NULL) - g_object_unref (selected_folder); + g_object_unref (selected_folder); } -void +void modest_ui_actions_on_account_connection_error (GtkWindow *parent_window, TnyAccount *account) { - ModestTransportStoreProtocol proto; - const gchar *proto_name; + ModestProtocolType protocol_type; + ModestProtocol *protocol; gchar *error_note = NULL; - - proto_name = tny_account_get_proto (account); - proto = modest_protocol_info_get_transport_store_protocol (proto_name); - - switch (proto) { - case MODEST_PROTOCOL_STORE_POP: - error_note = g_strdup_printf (_("emev_ni_ui_pop3_msg_connect_error"), - tny_account_get_hostname (account)); - break; - case MODEST_PROTOCOL_STORE_IMAP: - error_note = g_strdup_printf (_("emev_ni_ui_imap_connect_server_error"), - tny_account_get_hostname (account)); - break; - case MODEST_PROTOCOL_STORE_MAILDIR: - case MODEST_PROTOCOL_STORE_MBOX: - error_note = g_strdup (_("emev_nc_mailbox_notavailable")); - break; - default: - g_warning ("%s: This should not be reached", __FUNCTION__); - } - if (error_note) { - modest_platform_run_information_dialog (parent_window, error_note); + protocol_type = modest_tny_account_get_protocol_type (account); + protocol = modest_protocol_registry_get_protocol_by_type (modest_runtime_get_protocol_registry (), + protocol_type); + + error_note = modest_protocol_get_translation (protocol, MODEST_PROTOCOL_TRANSLATION_ACCOUNT_CONNECTION_ERROR, tny_account_get_hostname (account)); + if (error_note == NULL) { + g_warning ("%s: This should not be reached", __FUNCTION__); + } else { + modest_platform_run_information_dialog (parent_window, error_note, FALSE); g_free (error_note); } } @@ -5481,9 +6442,11 @@ gchar * modest_ui_actions_get_msg_already_deleted_error_msg (ModestWindow *win) { gchar *msg = NULL; + gchar *subject; TnyFolderStore *folder = NULL; TnyAccount *account = NULL; - ModestTransportStoreProtocol proto; + ModestProtocolType proto; + ModestProtocol *protocol; TnyHeader *header = NULL; if (MODEST_IS_MAIN_WINDOW (win)) { @@ -5503,6 +6466,24 @@ modest_ui_actions_get_msg_already_deleted_error_msg (ModestWindow *win) folder = TNY_FOLDER_STORE (tny_header_get_folder (header)); g_object_unref (iter); g_object_unref (headers); +#ifdef MODEST_TOOLKIT_HILDON2 + } else if (MODEST_IS_HEADER_WINDOW (win)) { + GtkWidget *header_view; + TnyList* headers = NULL; + TnyIterator *iter; + header_view = GTK_WIDGET (modest_header_window_get_header_view (MODEST_HEADER_WINDOW (win))); + headers = modest_header_view_get_selected_headers (MODEST_HEADER_VIEW (header_view)); + if (!headers || tny_list_get_length (headers) == 0) { + if (headers) + g_object_unref (headers); + return NULL; + } + iter = tny_list_create_iterator (headers); + header = TNY_HEADER (tny_iterator_get_current (iter)); + folder = TNY_FOLDER_STORE (tny_header_get_folder (header)); + g_object_unref (iter); + g_object_unref (headers); +#endif } else if (MODEST_IS_MSG_VIEW_WINDOW (win)) { header = modest_msg_view_window_get_header (MODEST_MSG_VIEW_WINDOW (win)); folder = TNY_FOLDER_STORE (tny_header_get_folder (header)); @@ -5510,13 +6491,15 @@ modest_ui_actions_get_msg_already_deleted_error_msg (ModestWindow *win) /* Get the account type */ account = tny_folder_get_account (TNY_FOLDER (folder)); - proto = modest_protocol_info_get_transport_store_protocol (tny_account_get_proto (account)); - if (proto == MODEST_PROTOCOL_STORE_POP) { - msg = g_strdup (_("emev_ni_ui_pop3_msg_recv_error")); - } else if (proto == MODEST_PROTOCOL_STORE_IMAP) { - msg = g_strdup_printf (_("emev_ni_ui_imap_message_not_available_in_server"), - tny_header_get_subject (header)); - } else { + proto = modest_tny_account_get_protocol_type (account); + protocol = modest_protocol_registry_get_protocol_by_type (modest_runtime_get_protocol_registry (), + proto); + + subject = tny_header_dup_subject (header); + msg = modest_protocol_get_translation (protocol, MODEST_PROTOCOL_TRANSLATION_MSG_NOT_AVAILABLE, subject); + if (subject) + g_free (subject); + if (msg == NULL) { msg = g_strdup_printf (_("mail_ni_ui_folder_get_msg_folder_error")); } @@ -5527,3 +6510,49 @@ modest_ui_actions_get_msg_already_deleted_error_msg (ModestWindow *win) return msg; } + +gboolean +modest_ui_actions_on_delete_account (GtkWindow *parent_window, + const gchar *account_name, + const gchar *account_title) +{ + ModestAccountMgr *account_mgr; + gchar *txt = NULL; + gint response; + ModestProtocol *protocol; + gboolean removed = FALSE; + + g_return_val_if_fail (account_name, FALSE); + g_return_val_if_fail (account_title, FALSE); + + account_mgr = modest_runtime_get_account_mgr(); + + /* The warning text depends on the account type: */ + protocol = modest_protocol_registry_get_protocol_by_type (modest_runtime_get_protocol_registry (), + modest_account_mgr_get_store_protocol (account_mgr, + account_name)); + txt = modest_protocol_get_translation (protocol, + MODEST_PROTOCOL_TRANSLATION_DELETE_MAILBOX, + account_title); + if (txt == NULL) + txt = g_strdup_printf (_("emev_nc_delete_mailbox"), account_title); + + response = modest_platform_run_confirmation_dialog (parent_window, txt); + g_free (txt); + txt = NULL; + + if (response == GTK_RESPONSE_OK) { + /* Remove account. If it succeeds then it also removes + the account from the ModestAccountView: */ + gboolean is_default = FALSE; + gchar *default_account_name = modest_account_mgr_get_default_account (account_mgr); + if (default_account_name && (strcmp (default_account_name, account_name) == 0)) + is_default = TRUE; + g_free (default_account_name); + + removed = modest_account_mgr_remove_account (account_mgr, account_name); + if (!removed) + g_warning ("%s: modest_account_mgr_remove_account() failed.\n", __FUNCTION__); + } + return removed; +}