X-Git-Url: http://git.maemo.org/git/?a=blobdiff_plain;f=src%2Fmodest-widget-memory.c;h=97f647f99b52cdee993244a15de012a4d5bcae08;hb=b1a1d32172bbd65556139329d035c1f69c8ce91b;hp=fc894b99c4961b04226d3f9e67deabcc75e00286;hpb=64333784e87e5ea5c6156078caacaca7ffbd6b5f;p=modest

diff --git a/src/modest-widget-memory.c b/src/modest-widget-memory.c
index fc894b9..97f647f 100644
--- a/src/modest-widget-memory.c
+++ b/src/modest-widget-memory.c
@@ -219,15 +219,16 @@ static gboolean
 save_settings_paned (ModestConf *conf, GtkPaned *paned, const gchar *name)
 {
 	gchar *key;
-	int pos;
+	int pos, percent;
 
 	/* Don't save the paned position if it's not visible, 
 	 * because it could not be correct: */
 	if (GTK_WIDGET_VISIBLE (GTK_WIDGET (paned)) && GTK_WIDGET_REALIZED (GTK_WIDGET (paned))) {
 		pos = gtk_paned_get_position (paned);
-		
+		percent = pos * 100 / GTK_WIDGET (paned)->allocation.width;
+
 		key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_POS);
-		modest_conf_set_int (conf, key, pos, NULL);
+		modest_conf_set_int (conf, key, percent, NULL);
 		g_free (key);
 	}
 	
@@ -239,27 +240,13 @@ static gboolean
 restore_settings_paned (ModestConf *conf, GtkPaned *paned, const gchar *name)
 {
  	gchar *key;
-	int pos;
+	int percent, pos;
 	
-	key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_POS);
+	key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_POS);	
+	percent = modest_conf_get_int (conf, key, NULL);
 	
-	if (modest_conf_key_exists (conf, key, NULL)) {
-		pos = modest_conf_get_int (conf, key, NULL);
-		
-		/* TODO: Remove this hack so that paned positions can really be used.
-		 * The paned position is incorrectly saved somehow before its even visible,
-		 * when we show the main window only some time after creating it,
-		 * so this prevents a wrong value from being used. */
-		const gint max = (GTK_WIDGET(paned)->allocation.width)/3;
-		if (pos > max)
-			pos = max;
-		
-			
-		gtk_paned_set_position (paned, pos);
-	} else {
-		/* The initial position must follow the 30/70 rule */
-		gtk_paned_set_position (paned, GTK_WIDGET(paned)->requisition.width/3);
-	}
+	pos = GTK_WIDGET (paned)->allocation.width * percent /100;
+	gtk_paned_set_position (paned, pos);
 
 	g_free (key);
 	return TRUE;
@@ -290,6 +277,9 @@ save_settings_header_view (ModestConf *conf, ModestHeaderView *header_view,
 	}
 	
 	type  = modest_tny_folder_guess_folder_type (folder);
+	if (type == TNY_FOLDER_TYPE_INVALID)
+		g_warning ("%s: BUG: TNY_FOLDER_TYPE_INVALID", __FUNCTION__);
+	
 	style = modest_header_view_get_style   (header_view);
 	
 	key = _modest_widget_memory_get_keyname_with_double_type (name, type, style,
@@ -378,6 +368,9 @@ restore_settings_header_view (ModestConf *conf, ModestHeaderView *header_view,
 		return TRUE; /* no folder: no settings */
 	
 	type = modest_tny_folder_guess_folder_type (folder);	
+	if (type == TNY_FOLDER_TYPE_INVALID)
+		g_warning ("%s: BUG: TNY_FOLDER_TYPE_INVALID", __FUNCTION__);
+
 	style = modest_header_view_get_style (header_view);
 
 	key = _modest_widget_memory_get_keyname_with_double_type (name, type, style,
@@ -388,6 +381,7 @@ restore_settings_header_view (ModestConf *conf, ModestHeaderView *header_view,
 	if (modest_conf_key_exists (conf, sort_key, NULL)) {
 		gchar *value = modest_conf_get_string (conf, sort_key, NULL);
 		sscanf (value, "%d:%d:%d", &sort_colid, &sort_type, &sort_flag_id);
+		g_free (value);
 	}
 
 	if (modest_conf_key_exists (conf, key, NULL)) {