X-Git-Url: http://git.maemo.org/git/?a=blobdiff_plain;f=src%2Fwidgets%2Fmodest-global-settings-dialog.c;h=c21f03d3358f9c9cf10650f351a2eae0923065db;hb=633375fc06361329e8d3b8979558febb62d1cc21;hp=8085b48ac1ea2f30bc2d915ba2ff2c01998d5175;hpb=46a234c81bceecac16ac22ae3f281b79247d46f7;p=modest diff --git a/src/widgets/modest-global-settings-dialog.c b/src/widgets/modest-global-settings-dialog.c index 8085b48..c21f03d 100644 --- a/src/widgets/modest-global-settings-dialog.c +++ b/src/widgets/modest-global-settings-dialog.c @@ -39,16 +39,19 @@ #include "modest-runtime.h" #include "modest-ui-constants.h" #include "modest-tny-msg.h" +#include "modest-platform.h" #include "widgets/modest-combo-box.h" #ifdef MODEST_PLATFORM_MAEMO -#ifdef MODEST_HILDON_VERSION_0 +#ifdef MODEST_HAVE_HILDON0_WIDGETS #include #else #include -#endif /*MODEST_HILDON_VERSION_0*/ +#endif /*MODEST_HAVE_HILDON0_WIDGETS*/ #endif /* include other impl specific header files */ +#define RETURN_FALSE_ON_ERROR(error) if (error) { g_clear_error (&error); return FALSE; } + /* 'private'/'protected' functions */ static void modest_global_settings_dialog_class_init (ModestGlobalSettingsDialogClass *klass); static void modest_global_settings_dialog_init (ModestGlobalSettingsDialog *obj); @@ -57,6 +60,10 @@ static void modest_global_settings_dialog_finalize (GObject *obj); static void on_response (GtkDialog *dialog, gint arg1, gpointer user_data); +static void get_current_settings (ModestGlobalSettingsDialogPrivate *priv, + ModestGlobalSettingsState *state); + +static ModestConnectedVia current_connection_default (void); /* list my signals */ enum { @@ -105,48 +112,41 @@ modest_global_settings_dialog_class_init (ModestGlobalSettingsDialogClass *klass gobject_class->finalize = modest_global_settings_dialog_finalize; g_type_class_add_private (gobject_class, sizeof(ModestGlobalSettingsDialogPrivate)); + + klass->current_connection_func = current_connection_default; } static void modest_global_settings_dialog_init (ModestGlobalSettingsDialog *self) { ModestGlobalSettingsDialogPrivate *priv; -/* GdkGeometry *geometry; */ priv = MODEST_GLOBAL_SETTINGS_DIALOG_GET_PRIVATE (self); priv->notebook = gtk_notebook_new (); - + /* Add the buttons: */ - gtk_dialog_add_button (GTK_DIALOG (self), GTK_STOCK_OK, GTK_RESPONSE_OK); - gtk_dialog_add_button (GTK_DIALOG (self), GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL); + gtk_dialog_add_button (GTK_DIALOG (self), _("mcen_bd_dialog_ok"), GTK_RESPONSE_OK); + gtk_dialog_add_button (GTK_DIALOG (self), _("mcen_bd_dialog_cancel"), GTK_RESPONSE_CANCEL); /* Connect to the dialog's response signal: */ - g_signal_connect (G_OBJECT (self), "response", - G_CALLBACK (on_response), self); + g_signal_connect (G_OBJECT (self), "response", G_CALLBACK (on_response), self); /* Set title */ gtk_window_set_title (GTK_WINDOW (self), _("mcen_ti_options")); - - /* Set geometry */ -/* geometry = g_malloc0(sizeof (GdkGeometry)); */ -/* geometry->max_width = MODEST_DIALOG_WINDOW_MAX_WIDTH; */ -/* geometry->min_width = MODEST_DIALOG_WINDOW_MIN_WIDTH; */ -/* geometry->max_height = MODEST_DIALOG_WINDOW_MAX_HEIGHT; */ -/* geometry->min_height = MODEST_DIALOG_WINDOW_MIN_HEIGHT; */ -/* gtk_window_set_geometry_hints (GTK_WINDOW (self), */ -/* GTK_WIDGET (self), */ -/* geometry, */ -/* GDK_HINT_MIN_SIZE | GDK_HINT_MAX_SIZE); */ - gtk_widget_set_size_request (GTK_WIDGET (self), - MODEST_DIALOG_WINDOW_MAX_WIDTH, - MODEST_DIALOG_WINDOW_MAX_HEIGHT); } static void modest_global_settings_dialog_finalize (GObject *obj) { -/* free/unref instance resources here */ + ModestGlobalSettingsDialogPrivate *priv = + MODEST_GLOBAL_SETTINGS_DIALOG_GET_PRIVATE (obj); + + /* These had to stay alive as long as the comboboxes that used them: */ + modest_pair_list_free (priv->connect_via_list); + modest_pair_list_free (priv->update_interval_list); + modest_pair_list_free (priv->msg_format_list); + G_OBJECT_CLASS(parent_class)->finalize (obj); } @@ -173,8 +173,8 @@ _modest_global_settings_dialog_get_connected_via (void) { GSList *list = NULL; - add_to_modest_pair_list (MODEST_CONNECTED_VIA_WLAN, - _("mcen_va_options_connectiontype_wlan"), + add_to_modest_pair_list (MODEST_CONNECTED_VIA_WLAN_OR_WIMAX, + _("mcen_va_options_connectiontype_wlan_wimax"), &list); add_to_modest_pair_list (MODEST_CONNECTED_VIA_ANY, _("mcen_va_options_connectiontype_all"), @@ -232,13 +232,15 @@ _modest_global_settings_dialog_get_msg_formats (void) } void -_modest_global_settings_dialog_load_conf (ModestGlobalSettingsDialogPrivate *priv) +_modest_global_settings_dialog_load_conf (ModestGlobalSettingsDialog *self) { ModestConf *conf; gboolean checked; gint combo_id, value; GError *error = NULL; + ModestGlobalSettingsDialogPrivate *priv; + priv = MODEST_GLOBAL_SETTINGS_DIALOG_GET_PRIVATE (self); conf = modest_runtime_get_conf (); /* Autoupdate */ @@ -249,16 +251,21 @@ _modest_global_settings_dialog_load_conf (ModestGlobalSettingsDialogPrivate *pri checked = FALSE; } gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (priv->auto_update), checked); + priv->initial_state.auto_update = checked; /* Connected by */ combo_id = modest_conf_get_int (conf, MODEST_CONF_UPDATE_WHEN_CONNECTED_BY, &error); if (error) { g_error_free (error); error = NULL; - combo_id = MODEST_CONNECTED_VIA_WLAN; + combo_id = MODEST_CONNECTED_VIA_WLAN_OR_WIMAX; } modest_combo_box_set_active_id (MODEST_COMBO_BOX (priv->connect_via), (gpointer) &combo_id); + priv->initial_state.connect_via = combo_id; + + /* Emit toggled to update the visibility of connect_by caption */ + gtk_toggle_button_toggled (GTK_TOGGLE_BUTTON (priv->auto_update)); /* Update interval */ combo_id = modest_conf_get_int (conf, MODEST_CONF_UPDATE_INTERVAL, &error); @@ -269,6 +276,7 @@ _modest_global_settings_dialog_load_conf (ModestGlobalSettingsDialogPrivate *pri } modest_combo_box_set_active_id (MODEST_COMBO_BOX (priv->update_interval), (gpointer) &combo_id); + priv->initial_state.update_interval = combo_id; /* Size limit */ value = modest_conf_get_int (conf, MODEST_CONF_MSG_SIZE_LIMIT, &error); @@ -282,10 +290,9 @@ _modest_global_settings_dialog_load_conf (ModestGlobalSettingsDialogPrivate *pri #ifdef MODEST_PLATFORM_MAEMO hildon_number_editor_set_value (HILDON_NUMBER_EDITOR (priv->size_limit), value); #else - gtk_spin_button_set_value (GTK_SPIN_BUTTON (priv->size_limit, value); + gtk_spin_button_set_value (GTK_SPIN_BUTTON (priv->size_limit), value); #endif - - /* TODO Fix with the value */ + priv->initial_state.size_limit = value; /* Play sound */ checked = modest_conf_get_bool (conf, MODEST_CONF_PLAY_SOUND_MSG_ARRIVE, &error); @@ -295,75 +302,129 @@ _modest_global_settings_dialog_load_conf (ModestGlobalSettingsDialogPrivate *pri checked = FALSE; } gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (priv->play_sound), checked); + priv->initial_state.play_sound = checked; /* Msg format */ - combo_id = modest_conf_get_int (conf, MODEST_CONF_PREFER_FORMATTED_TEXT, &error); + checked = modest_conf_get_bool (conf, MODEST_CONF_PREFER_FORMATTED_TEXT, &error); if (error) { g_error_free (error); error = NULL; combo_id = MODEST_FILE_FORMAT_FORMATTED_TEXT; - } + } + combo_id = (checked) ? MODEST_FILE_FORMAT_FORMATTED_TEXT : MODEST_FILE_FORMAT_PLAIN_TEXT; modest_combo_box_set_active_id (MODEST_COMBO_BOX (priv->msg_format), (gpointer) &combo_id); - - /* Include reply */ - value = modest_conf_get_int (conf, MODEST_CONF_REPLY_TYPE, &error); - if (error) { - g_error_free (error); - error = NULL; - value = MODEST_TNY_MSG_REPLY_TYPE_QUOTE; - } - if (value == MODEST_TNY_MSG_REPLY_TYPE_QUOTE) - checked = TRUE; - else - checked = FALSE; - gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (priv->include_reply), checked); + priv->initial_state.prefer_formatted_text = checked; } -void -_modest_global_settings_dialog_save_conf (ModestGlobalSettingsDialogPrivate *priv) +static void +get_current_settings (ModestGlobalSettingsDialogPrivate *priv, + ModestGlobalSettingsState *state) { - ModestConf *conf; - gboolean checked; - gint *combo_id, value; + gint *id; - conf = modest_runtime_get_conf (); + /* Get values from UI */ + state->auto_update = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (priv->auto_update)); + id = modest_combo_box_get_active_id (MODEST_COMBO_BOX (priv->connect_via)); + state->connect_via = *id; +#ifdef MODEST_PLATFORM_MAEMO + state->size_limit = hildon_number_editor_get_value (HILDON_NUMBER_EDITOR (priv->size_limit)); +#else + state->size_limit = gtk_spin_button_get_value (GTK_SPIN_BUTTON (priv->size_limit)); +#endif + id = modest_combo_box_get_active_id (MODEST_COMBO_BOX (priv->update_interval)); + state->update_interval = *id; + state->play_sound = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (priv->play_sound)); + id = modest_combo_box_get_active_id (MODEST_COMBO_BOX (priv->msg_format)); + state->prefer_formatted_text = (*id == MODEST_FILE_FORMAT_FORMATTED_TEXT) ? TRUE : FALSE; +} - /* Autoupdate */ - checked = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (priv->auto_update)); - modest_conf_set_bool (conf, MODEST_CONF_AUTO_UPDATE, checked, NULL); +gboolean +_modest_global_settings_dialog_save_conf (ModestGlobalSettingsDialog *self) +{ + ModestConf *conf; + ModestGlobalSettingsState current_state; + GError *error = NULL; + ModestGlobalSettingsDialogPrivate *priv; - /* Connected by */ - combo_id = modest_combo_box_get_active_id (MODEST_COMBO_BOX (priv->connect_via)); - modest_conf_set_int (conf, MODEST_CONF_UPDATE_WHEN_CONNECTED_BY, *combo_id, NULL); + priv = MODEST_GLOBAL_SETTINGS_DIALOG_GET_PRIVATE (self); - /* Update interval */ - combo_id = modest_combo_box_get_active_id (MODEST_COMBO_BOX (priv->update_interval)); - modest_conf_set_int (conf, MODEST_CONF_UPDATE_INTERVAL, *combo_id, NULL); + conf = modest_runtime_get_conf (); - /* Size limit */ - /* It's better to do this in the subclasses, but it's just one - line, so we'll leave it here for the moment */ -#ifdef MODEST_PLATFORM_MAEMO - value = hildon_number_editor_get_value (HILDON_NUMBER_EDITOR (priv->size_limit)); -#else - value = gtk_spin_button_set_value (GTK_SPIN_BUTTON (priv->size_limit); -#endif - modest_conf_set_int (conf, MODEST_CONF_MSG_SIZE_LIMIT, value, NULL); + get_current_settings (priv, ¤t_state); + + /* Save configuration */ + modest_conf_set_bool (conf, MODEST_CONF_AUTO_UPDATE, current_state.auto_update, &error); + RETURN_FALSE_ON_ERROR(error); + modest_conf_set_int (conf, MODEST_CONF_UPDATE_WHEN_CONNECTED_BY, current_state.connect_via, NULL); + RETURN_FALSE_ON_ERROR(error); + modest_conf_set_int (conf, MODEST_CONF_UPDATE_INTERVAL, current_state.update_interval, NULL); + RETURN_FALSE_ON_ERROR(error); + modest_conf_set_int (conf, MODEST_CONF_MSG_SIZE_LIMIT, current_state.size_limit, NULL); + RETURN_FALSE_ON_ERROR(error); + modest_conf_set_bool (conf, MODEST_CONF_PLAY_SOUND_MSG_ARRIVE, current_state.play_sound, NULL); + RETURN_FALSE_ON_ERROR(error); + modest_conf_set_bool (conf, MODEST_CONF_PREFER_FORMATTED_TEXT, current_state.prefer_formatted_text, NULL); + RETURN_FALSE_ON_ERROR(error); + + /* Apply changes */ + if (priv->initial_state.auto_update != current_state.auto_update || + priv->initial_state.connect_via != current_state.connect_via || + priv->initial_state.update_interval != current_state.update_interval) { + + TnyAccountStore *account_store; + TnyDevice *device; + + if (!current_state.auto_update) { + modest_platform_set_update_interval (0); + /* To avoid a new indentation level */ + goto exit; + } + + account_store = TNY_ACCOUNT_STORE (modest_runtime_get_account_store ()); + device = tny_account_store_get_device (account_store); + + if (tny_device_is_online (device)) { + /* If connected via any then set update interval */ + if (current_state.connect_via == MODEST_CONNECTED_VIA_ANY) { + modest_platform_set_update_interval (current_state.update_interval); + } else { + /* Set update interval only if we + selected the same connect_via + method than the one already used by + the device */ + ModestConnectedVia connect_via = + MODEST_GLOBAL_SETTINGS_DIALOG_GET_CLASS(self)->current_connection_func (); + + if (current_state.connect_via == connect_via) + modest_platform_set_update_interval (current_state.update_interval); + else + modest_platform_set_update_interval (0); + } + } else { + /* Disable autoupdate in offline mode */ + modest_platform_set_update_interval (0); + } + g_object_unref (device); + } - /* Play sound */ - checked = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (priv->play_sound)); - modest_conf_set_bool (conf, MODEST_CONF_PLAY_SOUND_MSG_ARRIVE, checked, NULL); +exit: + return TRUE; +} - /* Msg format */ - combo_id = modest_combo_box_get_active_id (MODEST_COMBO_BOX (priv->msg_format)); - modest_conf_set_int (conf, MODEST_CONF_PREFER_FORMATTED_TEXT, *combo_id, NULL); - - /* Include reply */ - checked = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (priv->include_reply)); - modest_conf_set_int (conf, MODEST_CONF_REPLY_TYPE, - (checked) ? MODEST_TNY_MSG_REPLY_TYPE_QUOTE : - MODEST_TNY_MSG_REPLY_TYPE_CITE, NULL); +static gboolean +settings_changed (ModestGlobalSettingsState initial_state, + ModestGlobalSettingsState current_state) +{ + if (initial_state.auto_update != current_state.auto_update || + initial_state.connect_via != current_state.connect_via || + initial_state.update_interval != current_state.update_interval || + initial_state.size_limit != current_state.size_limit || + initial_state.play_sound != current_state.play_sound || + initial_state.prefer_formatted_text != current_state.prefer_formatted_text) + return TRUE; + else + return FALSE; } static void @@ -372,9 +433,42 @@ on_response (GtkDialog *dialog, gpointer user_data) { ModestGlobalSettingsDialogPrivate *priv; + ModestGlobalSettingsState current_state; + gboolean changed; priv = MODEST_GLOBAL_SETTINGS_DIALOG_GET_PRIVATE (user_data); - if (arg1 == GTK_RESPONSE_OK) - _modest_global_settings_dialog_save_conf (priv); + get_current_settings (priv, ¤t_state); + changed = settings_changed (priv->initial_state, current_state); + + if (arg1 == GTK_RESPONSE_OK) { + if (changed) { + gboolean saved; + + saved = _modest_global_settings_dialog_save_conf (MODEST_GLOBAL_SETTINGS_DIALOG (dialog)); + if (saved) { + modest_platform_run_information_dialog (GTK_WINDOW (user_data), + _("mcen_ib_advsetup_settings_saved")); + } else { + modest_platform_run_information_dialog (GTK_WINDOW (user_data), + _("mail_ib_setting_failed")); + } + } + } else { + if (changed) { + gint response; + response = modest_platform_run_confirmation_dialog (GTK_WINDOW (user_data), + _("imum_nc_wizard_confirm_lose_changes")); + /* Do not close if the user Cancels */ + if (response == GTK_RESPONSE_CANCEL) + g_signal_stop_emission_by_name (dialog, "response"); + } + } +} + +static ModestConnectedVia +current_connection_default (void) +{ + g_warning ("You must implement %s", __FUNCTION__); + g_return_val_if_reached (MODEST_CONNECTED_VIA_ANY); }