Fixing a bug with adding a bazillion callbacks

diff --git a/src/dialogs.py b/src/dialogs.py
index 7d33d31..f33ba22 100644 (file)
--- a/src/dialogs.py
+++ b/src/dialogs.py
@@ -406,6 +406,16 @@ class ContactList(object):
                        titleLabel.setWordWrap(True)
                        numberSelector = QtGui.QComboBox()
                        self._populate_number_selector(numberSelector, cid, i, numbers)
+
+                       callback = functools.partial(
+                               self._on_change_number,
+                               i
+                       )
+                       callback.__name__ = "thanks partials for not having names and pyqt for requiring them"
+                       numberSelector.activated.connect(
+                               QtCore.pyqtSlot(int)(callback)
+                       )
+
                        if self._closeIcon is self._SENTINEL_ICON:
                                deleteButton = QtGui.QPushButton("Delete")
                        else:
@@ -470,15 +480,6 @@ class ContactList(object):
                else:
                        selector.setEnabled(False)
 
-               callback = functools.partial(
-                       self._on_change_number,
-                       cidIndex
-               )
-               callback.__name__ = "thanks partials for not having names and pyqt for requiring them"
-               selector.activated.connect(
-                       QtCore.pyqtSlot(int)(callback)
-               )
-
        @misc_utils.log_exception(_moduleLogger)
        def _on_change_number(self, cidIndex, index):
                with qui_utils.notify_error(self._app.errorLog):