Add safety checks to hildon-sort-dialog.c

* src/hildon-sort-dialog.c
(hildon_sort_dialog_add_sort_key_with_sorting)
(sort_key_changed)
Add safety checks

diff --git a/ChangeLog b/ChangeLog
index 7783925..f8153cd 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-04-29  Alejandro Pinheiro  <apinheiro@igalia.com>
+
+       * src/hildon-sort-dialog.c
+       (hildon_sort_dialog_add_sort_key_with_sorting)
+       (sort_key_changed)
+       Add safety checks
+
 2009-04-29  Claudio Saavedra  <csaavedra@igalia.com>
 
        * src/Makefile.am: Move generated sources to CLEANFILES, so that

diff --git a/src/hildon-sort-dialog.c b/src/hildon-sort-dialog.c
index 3ef8bab..3f5b49f 100644 (file)
--- a/src/hildon-sort-dialog.c
+++ b/src/hildon-sort-dialog.c
@@ -161,6 +161,7 @@ sort_key_changed                                (GtkWidget *widget,
     g_assert (priv);
 
     gint index = gtk_combo_box_get_active (GTK_COMBO_BOX (widget));
+    g_return_if_fail (index < priv->index_counter && index > 0);
 
     if (priv->key_reversed [index] != priv->reversed) {
         reconstruct_combo (dialog, TRUE, priv->key_reversed [index]);
@@ -217,6 +218,7 @@ hildon_sort_dialog_add_sort_key_with_sorting    (HildonSortDialog *dialog,
     HildonSortDialogPrivate *priv;
 
     g_return_val_if_fail (HILDON_IS_SORT_DIALOG (dialog), -1);
+    g_return_val_if_fail (sort_key != NULL, -1);
 
     priv = HILDON_SORT_DIALOG_GET_PRIVATE (dialog);
     g_assert (priv);