2009-02-13 Claudio Saavedra <csaavedra@igalia.com>

* src/hildon-time-selector.c (hildon_time_selector_set_time):
	* src/hildon-date-selector.c
	(hildon_date_selector_select_current_date):
	Do not compare unsigned integers to be greater than or equal 0,
	because it's always TRUE.

diff --git a/ChangeLog b/ChangeLog
index 71dad2a..ef78049 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2009-02-13  Claudio Saavedra  <csaavedra@igalia.com>
 
+       * src/hildon-time-selector.c (hildon_time_selector_set_time):
+       * src/hildon-date-selector.c
+       (hildon_date_selector_select_current_date):
+       Do not compare unsigned integers to be greater than or equal 0,
+       because it's always TRUE.
+
+2009-02-13  Claudio Saavedra  <csaavedra@igalia.com>
+
        * src/hildon-date-selector.c (hildon_date_selector_construct_ui),
        (hildon_date_selector_constructor): Do not select the current
        date until we are handle the "changed" signal, to avoid having bogus

diff --git a/src/hildon-date-selector.c b/src/hildon-date-selector.c
index 94de680..4c4a03e 100644 (file)
--- a/src/hildon-date-selector.c
+++ b/src/hildon-date-selector.c
@@ -782,7 +782,7 @@ hildon_date_selector_select_current_date (HildonDateSelector * selector,
   max_year = selector->priv->max_year;
 
   g_return_val_if_fail (min_year <= year && year <= max_year, FALSE);
-  g_return_val_if_fail (month >= 0 && month < 12, FALSE);
+  g_return_val_if_fail (month < 12, FALSE);
 
   num_days = _month_days (month, year);
   g_return_val_if_fail (day > 0 && day <= num_days, FALSE);

diff --git a/src/hildon-time-selector.c b/src/hildon-time-selector.c
index 9f3574a..b2688a5 100644 (file)
--- a/src/hildon-time-selector.c
+++ b/src/hildon-time-selector.c
@@ -527,8 +527,8 @@ hildon_time_selector_set_time (HildonTimeSelector * selector,
   GtkTreeIter iter;
   gint hours_item = 0;
 
-  g_return_val_if_fail (hours >= 0 && hours <= 23, FALSE);
-  g_return_val_if_fail (minutes >= 0 && minutes <= 59, FALSE);
+  g_return_val_if_fail (hours <= 23, FALSE);
+  g_return_val_if_fail (minutes <= 59, FALSE);
 
   if (selector->priv->ampm_format) {
     _set_pm (selector, hours >= 12);