2008-12-02 Alberto Garcia <agarcia@igalia.com>

* examples/hildon-app-menu-example.c (create_menu)
	Show items after adding them to the menu, as in the future the
	menu will no longer call gtk_widget_show() on the added items.

	* src/hildon-app-menu.c:
	Update example as explained above.

diff --git a/ChangeLog b/ChangeLog
index f88ce7a..a0f5a7b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
 2008-12-02  Alberto Garcia  <agarcia@igalia.com>
 
+       * examples/hildon-app-menu-example.c (create_menu)
+       Show items after adding them to the menu, as in the future the
+       menu will no longer call gtk_widget_show() on the added items.
+
+       * src/hildon-app-menu.c:
+       Update example as explained above.
+
+2008-12-02  Alberto Garcia  <agarcia@igalia.com>
+
        * src/hildon-app-menu.c
        (hildon_app_menu_insert, hildon_app_menu_add_filter):
        Make sure that all menu items have finger height.

diff --git a/examples/hildon-app-menu-example.c b/examples/hildon-app-menu-example.c
index afb7034..eb2d321 100644 (file)
--- a/examples/hildon-app-menu-example.c
+++ b/examples/hildon-app-menu-example.c
@@ -49,6 +49,7 @@ create_menu                                     (GtkWidget     *label,
     gtk_button_set_label (GTK_BUTTON (button), "Menu command one");
     g_signal_connect_after (button, "clicked", G_CALLBACK (menu_button_clicked), label);
     hildon_app_menu_append (menu, GTK_BUTTON (button));
+    gtk_widget_show (button);
 
     gtk_widget_add_accelerator (button, "activate", accel, GDK_r, GDK_CONTROL_MASK, GTK_ACCEL_VISIBLE);
 
@@ -56,21 +57,25 @@ create_menu                                     (GtkWidget     *label,
     gtk_button_set_label (GTK_BUTTON (button), "Menu command two");
     g_signal_connect_after (button, "clicked", G_CALLBACK (menu_button_clicked), label);
     hildon_app_menu_append (menu, GTK_BUTTON (button));
+    gtk_widget_show (button);
 
     button = hildon_gtk_button_new (buttonsize);
     gtk_button_set_label (GTK_BUTTON (button), "Menu command three");
     g_signal_connect_after (button, "clicked", G_CALLBACK (menu_button_clicked), label);
     hildon_app_menu_append (menu, GTK_BUTTON (button));
+    gtk_widget_show (button);
 
     button = hildon_gtk_button_new (buttonsize);
     gtk_button_set_label (GTK_BUTTON (button), "Menu command four");
     g_signal_connect_after (button, "clicked", G_CALLBACK (menu_button_clicked), label);
     hildon_app_menu_append (menu, GTK_BUTTON (button));
+    gtk_widget_show (button);
 
     button = hildon_gtk_button_new (buttonsize);
     gtk_button_set_label (GTK_BUTTON (button), "Menu command five");
     g_signal_connect_after (button, "clicked", G_CALLBACK (menu_button_clicked), label);
     hildon_app_menu_append (menu, GTK_BUTTON (button));
+    gtk_widget_show (button);
 
     /* Filters */
     button = hildon_gtk_radio_button_new (buttonsize, NULL);
@@ -78,12 +83,14 @@ create_menu                                     (GtkWidget     *label,
     g_signal_connect_after (button, "clicked", G_CALLBACK (menu_button_clicked), label);
     hildon_app_menu_add_filter (menu, GTK_BUTTON (button));
     gtk_toggle_button_set_mode (GTK_TOGGLE_BUTTON (button), FALSE);
+    gtk_widget_show (button);
 
     button = hildon_gtk_radio_button_new_from_widget (buttonsize, GTK_RADIO_BUTTON (button));
     gtk_button_set_label (GTK_BUTTON (button), "filter two");
     g_signal_connect_after (button, "clicked", G_CALLBACK (menu_button_clicked), label);
     hildon_app_menu_add_filter (menu, GTK_BUTTON (button));
     gtk_toggle_button_set_mode (GTK_TOGGLE_BUTTON (button), FALSE);
+    gtk_widget_show (button);
 
     return menu;
 }

diff --git a/src/hildon-app-menu.c b/src/hildon-app-menu.c
index 0cc5fd8..ab4d0d9 100644 (file)
--- a/src/hildon-app-menu.c
+++ b/src/hildon-app-menu.c
@@ -63,23 +63,27 @@
  * button = gtk_button_new_with_label ("Menu command one");
  * g_signal_connect_after (button, "clicked", G_CALLBACK (button_one_clicked), userdata);
  * hildon_app_menu_append (menu, GTK_BUTTON (button));
+ * gtk_widget_show (button);
  * <!-- -->
  * // Another button
  * button = gtk_button_new_with_label ("Menu command two");
  * g_signal_connect_after (button, "clicked", G_CALLBACK (button_two_clicked), userdata);
  * hildon_app_menu_append (menu, GTK_BUTTON (button));
+ * gtk_widget_show (button);
  * <!-- -->
  * // Create a filter and add it to the menu
  * filter = gtk_radio_button_new_with_label (NULL, "Filter one");
  * gtk_toggle_button_set_mode (GTK_TOGGLE_BUTTON (filter), FALSE);
  * g_signal_connect_after (filter, "clicked", G_CALLBACK (filter_one_clicked), userdata);
  * hildon_app_menu_add_filter (menu, GTK_BUTTON (filter));
+ * gtk_widget_show (button);
  * <!-- -->
  * // Add a new filter
  * filter = gtk_radio_button_new_with_label_from_widget (GTK_RADIO_BUTTON (filter), "Filter two");
  * gtk_toggle_button_set_mode (GTK_TOGGLE_BUTTON (filter), FALSE);
  * g_signal_connect_after (filter, "clicked", G_CALLBACK (filter_two_clicked), userdata);
  * hildon_app_menu_add_filter (menu, GTK_BUTTON (filter));
+ * gtk_widget_show (button);
  * <!-- -->
  * // Add the menu to the window
  * hildon_stackable_window_set_main_menu (win, menu);