sched: fix memory leak in a failure path
authorLi Zefan <lizf@cn.fujitsu.com>
Fri, 7 Nov 2008 06:47:21 +0000 (14:47 +0800)
committerIngo Molnar <mingo@elte.hu>
Fri, 7 Nov 2008 07:29:58 +0000 (08:29 +0100)
Impact: fix rare memory leak in the sched-domains manual reconfiguration code

In the failure path, rd is not attached to a sched domain,
so it causes a leak.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

kernel/sched.c

index 4c7e2bc..57c933f 100644 (file)
@@ -7676,6 +7676,7 @@ static int __build_sched_domains(const cpumask_t *cpu_map,
 error:
        free_sched_groups(cpu_map, tmpmask);
        SCHED_CPUMASK_FREE((void *)allmasks);
+       kfree(rd);
        return -ENOMEM;
 #endif
 }