Fixed some leaks, after valgrinding.
authorAlejandro G. Castro <alex@igalia.com>
Fri, 12 Dec 2008 11:29:48 +0000 (11:29 +0000)
committerAlejandro G. Castro <alex@igalia.com>
Fri, 12 Dec 2008 11:29:48 +0000 (11:29 +0000)
* src/hildon-touch-selector.c:
(_default_print_func): Fixed a leak.
(hildon_touch_selector_append_column): Fixed a leak.
* src/hildon-date-button.c:
(hildon_date_button_init): Fixed a leak.
* src/hildon-date-selector.c
(hildon_date_selector_finalize): Fixed a leak.

ChangeLog
src/hildon-date-button.c
src/hildon-date-selector.c
src/hildon-touch-selector.c

index e0d2805..79bb19b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2008-12-12  Alejandro G. Castro         <alex@igalia.com>
+
+       Fixed some leaks, after valgrinding.
+
+       * src/hildon-touch-selector.c:
+       (_default_print_func): Fixed a leak.
+       (hildon_touch_selector_append_column): Fixed a leak.
+       * src/hildon-date-button.c:
+       (hildon_date_button_init): Fixed a leak.
+       * src/hildon-date-selector.c
+       (hildon_date_selector_finalize): Fixed a leak.
+
 2008-12-12  Claudio Saavedra  <csaavedra@igalia.com>
 
        Based on a patch by Christian Dywan (christian@imendio.com)
index 3c12833..7c0afba 100644 (file)
@@ -86,6 +86,8 @@ hildon_date_button_init (HildonDateButton * self)
 
   hildon_picker_button_set_selector (HILDON_PICKER_BUTTON (self),
                                      HILDON_TOUCH_SELECTOR (date_selector));
+
+  g_object_unref (date_selector);
 }
 
 /**
index b9c5e36..d4e8bca 100644 (file)
@@ -282,6 +282,7 @@ hildon_date_selector_finalize (GObject * object)
   selector = HILDON_DATE_SELECTOR (object);
 
   g_slist_free (selector->priv->column_order);
+  g_free (selector->priv->format);
 
   (*G_OBJECT_CLASS (hildon_date_selector_parent_class)->finalize) (object);
 }
index aa95d2f..7070a6e 100644 (file)
@@ -459,6 +459,12 @@ _default_print_func (HildonTouchSelector * selector)
         g_free (result);
         result = aux;
       }
+
+      if (current_string) {
+        g_free (current_string);
+        current_string = NULL;
+      }
+
       i++;
     }
 
@@ -1024,7 +1030,6 @@ hildon_touch_selector_append_column (HildonTouchSelector * selector,
 
     va_start (args, cell_renderer);
     new_column = _create_new_column (selector, model, cell_renderer, args);
-    g_object_ref_sink (new_column);
     va_end (args);
 
     selector->priv->columns = g_slist_append (selector->priv->columns,