Dirk-Jan C. Binnema [Thu, 2 Aug 2007 07:20:58 +0000 (07:20 +0000)]
* with the latest tinymail, there is no need to force a refresh
of the folder model anymore, when the account name changes.
pmo-trunk-r2905
Jose Dapena Paz [Thu, 2 Aug 2007 06:41:08 +0000 (06:41 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_xfer_messages_from_move_to): now we
show an information banner on trying to move messages to a pop
folder as this is not allowed (fixes NB#63285).
pmo-trunk-r2904
Jose Dapena Paz [Thu, 2 Aug 2007 06:04:26 +0000 (06:04 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_on_delete_folder): now we focus inbox
folder on finishing the delete folder operation (fixes
NB#63239).
pmo-trunk-r2903
Javier Fernandez Garcia-Boente [Wed, 1 Aug 2007 21:36:50 +0000 (21:36 +0000)]
* Review Move_to dimming rules to check for ROOT folders,
or INBOX or SENT, DRAFT and OUTBOX special folder.
* Fixes: NB#62939
pmo-trunk-r2902
Jose Dapena Paz [Wed, 1 Aug 2007 18:30:06 +0000 (18:30 +0000)]
* src/widgets/modest-recpt-editor.c:
* Modified the maximum number of lines, to 1024. Practically,
it means the field has an "unlimited" number of lines
(fixes NB#63209).
pmo-trunk-r2901
Murray Cumming [Wed, 1 Aug 2007 18:29:35 +0000 (18:29 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_account_mgr_get_first_account_name(),
using code from modest_account_mgr_set_first_account_as_default().
* src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
(account_number_changed): Call set_at_least_one_account_visible() so that
the first account is visible when first added, without the user having to
use the View menu.
I do wonder how this worked before.
pmo-trunk-r2900
Jose Dapena Paz [Wed, 1 Aug 2007 18:01:10 +0000 (18:01 +0000)]
* src/modest-text-utils.c:
* (modest_text_utils_validate_email_address): a domain part
that finishes with a dot (for example "a@b.") is not valid
(fixes NB#63204).
pmo-trunk-r2899
Jose Dapena Paz [Wed, 1 Aug 2007 17:21:39 +0000 (17:21 +0000)]
* src/maemo/modest-msg-edit-window.c:
* A missing else was breaking save to drafts deletion of
old draft.
* src/modest-mail-operation.c:
* Now save to drafts first adds the new message, and then
removes the old one.
* Now save to drafts folder sync is asynchronous.
pmo-trunk-r2898
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 16:35:15 +0000 (16:35 +0000)]
* fix some of the tedious value checking, as specified in
NB#59361 (which is fixed now)
pmo-trunk-r2896
Jose Dapena Paz [Wed, 1 Aug 2007 16:28:24 +0000 (16:28 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Added entry verification in subject field. In particular we
discard the bullet special unicode character (fixes NB#62721).
pmo-trunk-r2895
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 16:07:37 +0000 (16:07 +0000)]
* the real fix for NB#64809, the previous accidentaly
fixed the same issue in the normal account setup, now we're
fixing it for the connection-specific smtp servers as well.
also fixed the label for the Port number
pmo-trunk-r2894
Murray Cumming [Wed, 1 Aug 2007 16:07:11 +0000 (16:07 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (show_password_warning_only),
(show_wrong_password), (request_password_and_wait), (get_password),
(modest_tny_account_store_alert): Remove the (incomplete anyway)
attempts to show UI only in the main context, which used g_idle_add()
and mainloops, because tinymail now guarantees that it only calls these
callbacks in the mainloop with the gdk lock. This makes everything much
simpler.
pmo-trunk-r2893
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 15:45:03 +0000 (15:45 +0000)]
* validate the domain names
Fixes: NB#64809
pmo-trunk-r2892
Murray Cumming [Wed, 1 Aug 2007 15:16:04 +0000 (15:16 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
error dialog, instead of ignoring it.
pmo-trunk-r2891
Alberto Garcia [Wed, 1 Aug 2007 14:26:43 +0000 (14:26 +0000)]
* Use the correct translation string instead of a fixed one when
trying to save several attachments (Fixes: NB#63764)
pmo-trunk-r2890
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 14:24:55 +0000 (14:24 +0000)]
* port numbers should be in the range [1,65535], 0 is not valid.
Fixes: #NB64831
pmo-trunk-r2889
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 13:27:11 +0000 (13:27 +0000)]
* more changes to the account management; now the following should work again:
- changing account names (updates modest-account-view, and modest-folder-view)
- expand root folders
- change modest-account-mgr to only emit change signals once per 500ms
- modest-account-mgr changes notification now only give the "parent account",
not the server account, and not for every single key
- accounts are changed, not recreated
pmo-trunk-r2888
Jose Dapena Paz [Wed, 1 Aug 2007 12:41:30 +0000 (12:41 +0000)]
* src/maemo/modest-progress-bar-widget.c:
* Now we show the undetermined string for receiving and sending
when we're getting only one message. This should fit the
optional ammendment in UI specs (fixes NB#56182).
pmo-trunk-r2887
Murray Cumming [Wed, 1 Aug 2007 11:54:01 +0000 (11:54 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_get_header),
(modest_msg_view_window_last_message_selected):
Added comments to explain the use of priv->header_model.
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_open_msg),
(modest_ui_dimming_rules_on_mark_as_read_msg),
(modest_ui_dimming_rules_on_mark_as_unread_msg),
(modest_ui_dimming_rules_on_remove_attachments),
(_invalid_attach_selected), (_selected_msg_marked_as):
Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
and changed the parameter to a ModestMainWindow to make it clearer that
it never uses any other kind of window.
Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
instead of the selected message.
I notice that much of the dimming code and the ModestMsgViewWindow code
hard-codes the assumption that the viewed message is always selected in
the header view. This does not seem wise or simple.
(modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
examine the actual message instead of whatever might be selected
in the header view. This stops the delete toolbar button and menu item
from being dimmed when opening a message view the search UI,
partially fixing projects.maemo.org bug NB#63811.
However, when actually deleting, I now get this warning:
tny_header_set_flags: This is a header instance for a new message.
Only priority and attachment flags are supported
pmo-trunk-r2886
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 10:41:49 +0000 (10:41 +0000)]
* forgot to commit this
pmo-trunk-r2885
Jose Dapena Paz [Wed, 1 Aug 2007 09:16:47 +0000 (09:16 +0000)]
* src/widgets/modest-msg-view.c:
* Modified the html adjustment change handler to prevent some
infinite recursions. In particular one happening on removing
attachments.
* src/widgets/modest-attachment-view.c:
* Add support for showing purged attached messages.
* src/modest-ui-dimming-rules.c:
* Now we don't dim remove attachments for message attachments in
view, as we now support this (fixes NB#64068).
pmo-trunk-r2884
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 08:44:29 +0000 (08:44 +0000)]
* step 2 of the account fixes; for now, account changes
are turned-off, as we get hangs when we get alert-popups
pmo-trunk-r2883
Jose Dapena Paz [Wed, 1 Aug 2007 07:26:51 +0000 (07:26 +0000)]
* src/widgets/modest-msg-edit-window.h,
src/maemo/modest-msg-edit-window.c:
* New method (modest_msg_edit_window_get_message_uid), that
gets the message uid of the current draft or outbox message
the mail was openend from.
* src/widgets/modest-window-mgr.c:
* Modify all the message register methods, to add support for
also registering edit windows (fixes NB#64714).
pmo-trunk-r2882
Jose Dapena Paz [Wed, 1 Aug 2007 06:50:59 +0000 (06:50 +0000)]
* src/modest-text-utils.[ch]:
* New (modest_text_utils_get_email_address) function, that
obtains the email address email@address from a full
address Full Address <email@address>.
* src/maemo/modest-address-book.c:
* (modest_address_book_add_address): now we add the email part
of an address to the addressbook, instead of the full address
(fixes NB#64733).
pmo-trunk-r2881
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 06:19:46 +0000 (06:19 +0000)]
* added modest_tny_account_update_from_server_account_name, we need
this function for the new account management. this is done by refactoring
some code -- the functions here are much too long anyway, which makes
maintenance / refactoring / fixing hard.
no functional changes yet.
pmo-trunk-r2880
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 20:53:05 +0000 (20:53 +0000)]
* don't try to load some icons which are not present,
and we're not using anyway. saves some runtime warnings
pmo-trunk-r2879
Javier Fernandez Garcia-Boente [Tue, 31 Jul 2007 18:37:05 +0000 (18:37 +0000)]
* Review dimming rules about mark as read/unread headers.
Now, rules considerd that all headers must be equal to dim
or not menu options.
* Fixes: NB#60676
pmo-trunk-r2878
Javier Fernandez Garcia-Boente [Tue, 31 Jul 2007 17:37:15 +0000 (17:37 +0000)]
* Show progress data of the first queued mail operation.
* Show a initial message avoiding show empty progress bar
while async operation does not send back progress information.
* Fixes: NB#60517
pmo-trunk-r2877
Jose Dapena Paz [Tue, 31 Jul 2007 17:16:52 +0000 (17:16 +0000)]
* src/maemo/modest-msg-edit-window.c:
* We make the max image with even smaller, to avoid confusion
having in one line a full image and a small character.
* Now we correct the scroll position to show the cursor if
the text view is focused and the cursor is not really visible.
Calculation of cursor visibility is done manually, and after
last text view size update. This way we finally get the cursor
at its proper position on inserting big images (fixes
NB#62829).
pmo-trunk-r2876
Jose Dapena Paz [Tue, 31 Jul 2007 15:44:38 +0000 (15:44 +0000)]
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
* Set "Other..." option as the first in providers combobox.
* Use the logical id (fixes NB#64683).
pmo-trunk-r2875
Jose Dapena Paz [Tue, 31 Jul 2007 15:32:04 +0000 (15:32 +0000)]
* src/widgets/modest-recpt-editor.c:
* Fix some recursion errors in validation methods
(fixes NB#64721).
pmo-trunk-r2873
Jose Dapena Paz [Tue, 31 Jul 2007 14:09:30 +0000 (14:09 +0000)]
* src/modest-ui-actions.c:
* On deleting messages from viewer, if there's no next message
or user cancels retrieving next message, we close the window
(fixes NB#64684).
* src/modest-mail-operation.c:
* Get the TnyCamelMemStream type before opening threads so that
we don't get the initial type in parallel from two threads
(due to a possible thread problem in gtype system).
pmo-trunk-r2872
Javier Fernandez Garcia-Boente [Tue, 31 Jul 2007 13:37:55 +0000 (13:37 +0000)]
* Review dimming rules _selected_msg_sent_in_progress
utility function, searching into all send-queues,
rather than current active account send-queue.
* Fixes: NB#62702
pmo-trunk-r2871
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 13:13:23 +0000 (13:13 +0000)]
Added new fixes and merges added into changelog - week 31 - 31th july.
pmo-trunk-r2870
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 12:37:47 +0000 (12:37 +0000)]
* this one too, belongs to the prev. commit
pmo-trunk-r2869
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 12:36:22 +0000 (12:36 +0000)]
* restore some functionality after the changes, by reenabling the key-changed
signal in modest-account-mgr, and change it's listeners.
Note: updating account name in the Accounts dialog works now; but it's not
propagated correctly to the account in the folder view yet.
pmo-trunk-r2868
Philip Van Hoof [Tue, 31 Jul 2007 08:35:45 +0000 (08:35 +0000)]
Compilation fix
pmo-trunk-r2867
Philip Van Hoof [Tue, 31 Jul 2007 08:24:20 +0000 (08:24 +0000)]
2007-07-31 Philip Van Hoof <pvanhoof@gnome.org>
* Merging back devel/sessionwork to trunk/
pmo-trunk-r2866
Jose Dapena Paz [Tue, 31 Jul 2007 08:19:43 +0000 (08:19 +0000)]
* src/modest-text-utils.[ch]:
* New method (modest_text_utils_text_buffer_get_text): wrapper
around gtk_text_buffer_get_slice, that replaces the image
pixbuf special character 0xFFFC with a blank space.
* src/modest-msg-edit-window.c:
* Use the new modest_text_utils_text_buffer_get_text to get the
plain body representation of a formatted html mail. This
makes a mail with only images return a length greater than 0
(fixes NB#64627).
pmo-trunk-r2865
Johannes Schmid [Tue, 31 Jul 2007 08:05:46 +0000 (08:05 +0000)]
2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
* src/modest-ui-actions.c: (modest_ui_actions_on_send):
Show account wizard if no accounts are defined while sending
(automatic sending after the account wizard finished does not
work because it takes some time until the accoun
pmo-trunk-r2862
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 07:42:45 +0000 (07:42 +0000)]
Added new fixes to changelog - week 31 - 31th july.
pmo-trunk-r2861
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 07:07:05 +0000 (07:07 +0000)]
* explicitely undim the Ok-button after an entry_changed, so Ok is enabled
again after the some condition that made it disabled before, disappears.
Fixes: NB#64621
pmo-trunk-r2860
Jose Dapena Paz [Mon, 30 Jul 2007 17:09:29 +0000 (17:09 +0000)]
* src/modest-ui-actions.c:
* If we get a folder empty selection, and focus is in
headers view, move focus to folder view.
* src/maemo/modest-main-window.c:
* If the message count of the folder is 0 then move the focus to
the folder view (fixes NB#63198).
pmo-trunk-r2859
Jose Dapena Paz [Mon, 30 Jul 2007 16:13:11 +0000 (16:13 +0000)]
* src/maemo/modest-address-book.c:
* Now check names information banner can only be shown if the
operation lasts for more than 2 seconds (fixes NB#63057).
pmo-trunk-r2858
Jose Dapena Paz [Mon, 30 Jul 2007 15:46:53 +0000 (15:46 +0000)]
* src/widgets/modest-recpt-editor.c:
* WOps, forgot to take into account quoted address names.
With this we really fix NB#62993.
pmo-trunk-r2857
Jose Dapena Paz [Mon, 30 Jul 2007 15:35:44 +0000 (15:35 +0000)]
* src/widgets/modest-recpt-editor.c:
* Now validation functions remove \n and \t characters
* Now validation functions add a \n after each , or ; if they're
not at the end, and no \n has been inserted before
* Now we validate the string on set_recipients. This way, the
characters get proper layout on setting fields in editor
(fixes NB#62993).
pmo-trunk-r2856
Murray Cumming [Mon, 30 Jul 2007 14:55:58 +0000 (14:55 +0000)]
2007-07-30 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (on_account_removed),
(on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
account is removed from the View menu. We have TnyAccountStore
and ModestTnyAccountStore signals that seem very similar, but this
seems to work for now.
* src/maemo/modest-main-window.c:
(on_show_account_action_activated): Prevent dereference
of a NULL if the accoutn does not really exist, though that
should not happen anymore.
This fixes projects.maemo.org bug NB#64606.
pmo-trunk-r2855
Dirk-Jan C. Binnema [Mon, 30 Jul 2007 14:52:04 +0000 (14:52 +0000)]
Added new fixes to changelog - week 31 - 30th july.
pmo-trunk-r2854
Jose Dapena Paz [Mon, 30 Jul 2007 14:05:07 +0000 (14:05 +0000)]
* src/maemo/modest-account-settings-dialog.c:
* (create_page_user_details): use a scrolled window for options
so that showing vkb does not hide the ok/cancel buttons. We
also add proper focus adjustment (fixes NB#64537).
* (create_page_outgoing): add proper focus adjustment.
pmo-trunk-r2852
Jose Dapena Paz [Mon, 30 Jul 2007 13:44:54 +0000 (13:44 +0000)]
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added 80% and 120% to editor so that we use the zoom levels
specified in Email UI specs 2.2 document wiki. Fixes NB#61337.
pmo-trunk-r2851
Jose Dapena Paz [Mon, 30 Jul 2007 13:35:02 +0000 (13:35 +0000)]
* src/maemo/modest-main-window.c:
* Show only "Send&Receive/All" option when there are 2 or more
accounts. The older condition was "there are 1 or more"
(fixes NB#59238).
pmo-trunk-r2850
Jose Dapena Paz [Mon, 30 Jul 2007 13:07:41 +0000 (13:07 +0000)]
* src/modest-tny-msg.[ch]:
* (create_reply_forward_mail): now get a TnyHeader attribute
for the case we don't have a full TnyMsg available.
* (modest_tny_msg_create_forward_msg): use the new
create_reply_forward_mail api.
* (modest_tny_msg_create_reply_msg): now it gets a TnyHeader
parameter for the case there's no TnyMsg available (it should
happen at least on replying without original message in main
window.
* src/modest-ui-actions.c:
* (reply_forward_cb): uses the new
modest_tny_msg_create_reply_msg api.
* (reply_forward_cb): now we don't free the header parameter
in this callback, as this should be done by callers.
* (reply_forward): now we don't show the retrieve confirmation
dialog on replying without original message in reply. We don't
retrieve the original message too (fixes NB#63674).
pmo-trunk-r2849
Jose Dapena Paz [Mon, 30 Jul 2007 11:23:39 +0000 (11:23 +0000)]
* src/maemo/modest-platform.c:
* (modest_platform_run_folder_name_dialog): we don't show
insensitive information banner for ok button (fixes NB#64174).
pmo-trunk-r2847
Jose Dapena Paz [Mon, 30 Jul 2007 11:15:49 +0000 (11:15 +0000)]
* src/modest-tny-msg.[ch]:
* Now modest_tny_msg_get_body tells if the original body was
plain text or html.
* src/widgets/modest-msg-edit-window.h:
* Now modest_msg_edit_window_new gets a new parameter
preserve_is_rich, that sets the format to the one in the
original message in case it's set.
* src/maemo/modest-msg-edit-window.c:
* Preserves the plain text format in case it's requested
(fixes NB#64170).
* Now we reset modified status on constructor to prevent getting
modifications from construction process.
* src/modest-ui-actions.c:
* Use the new modest_msg_edit_window_new api. For messages
opened from drafts, it preserves the format (plain or html).
For other messages, it respects the configuration preference.
* src/gnome/modest-msg-edit-window.c:
* Fill the new is_html parameter in modest_tny_msg_new method.
pmo-trunk-r2846
Javier Fernandez Garcia-Boente [Mon, 30 Jul 2007 10:38:58 +0000 (10:38 +0000)]
* Outbox messsages are opened in edit window.
* If they are modifed, they are saved to draf if ther was not send.
* Otherwise, they are saved again into outbox
* Messages which are being edited are excluded from sent-queue.
* Fixes: NB#57915
pmo-trunk-r2843
Jose Dapena Paz [Mon, 30 Jul 2007 09:46:26 +0000 (09:46 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Fixed an error in the condition to change colors in
modest_msg_edit_window_set_format_state. The condition to
declare a changeset was reversed.
* (modest_msg_edit_window_set_format_state): now we set
the bullet attribute out of the freeze/thaw region, as
bullet format is applied only if not frozen (fixes NB#63500).
pmo-trunk-r2842
Murray Cumming [Mon, 30 Jul 2007 08:22:37 +0000 (08:22 +0000)]
2007-07-30 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (run_account_setup_wizard),
(modest_ui_actions_on_accounts): Revert a change that set these
to modal dialogs, freezing the UI when they show secondary dialogs.
This fixed projects.maemo.org bug NB#64519.
pmo-trunk-r2839
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 18:40:30 +0000 (18:40 +0000)]
* small optimization; we don't need to retrieve name, message count for the
icon-cell rendering.
pmo-trunk-r2836
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 16:51:36 +0000 (16:51 +0000)]
* refresh header view after deleting a message from outbox.
fixes: NB#63428, and maybe some others (will check)
pmo-trunk-r2834
Jose Dapena Paz [Fri, 27 Jul 2007 16:37:36 +0000 (16:37 +0000)]
* src/modest-ui-actions.c:
* Added modality and transiency for settings, accounts,
header and folder details (fixes NB#64326).
pmo-trunk-r2833
Jose Dapena Paz [Fri, 27 Jul 2007 16:19:11 +0000 (16:19 +0000)]
* src/modest-ui-dimming-rules.c:
* Now rename is disabled also for "Archive" folder
(fixes NB#64259).
pmo-trunk-r2832
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 16:07:03 +0000 (16:07 +0000)]
* don't accept folder names starting with ' ', take copy-paste into account
this should fix NB#58923
pmo-trunk-r2831
Jose Dapena Paz [Fri, 27 Jul 2007 16:05:36 +0000 (16:05 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_on_cut, modest_ui_actions_on_copy):
now we store the clipboard on copy operation for gtkhtml. We
add storing for all the text clipboard operations
(fixes NB#64206).
pmo-trunk-r2830
Murray Cumming [Fri, 27 Jul 2007 15:38:16 +0000 (15:38 +0000)]
2007-07-27 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-header-view-render.c:
(_modest_header_view_compact_header_cell_data):
Some checks and initialization to try to deal with a crash,
probably ineffective.
pmo-trunk-r2829
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 14:58:08 +0000 (14:58 +0000)]
* trivial fix for NB#64328
pmo-trunk-r2828
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 14:35:04 +0000 (14:35 +0000)]
* let the folder view honour the modest-folder-rules, for drag&drop of
both headers and messages; fixes #64263
pmo-trunk-r2827
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 14:21:57 +0000 (14:21 +0000)]
Added wpeditor0 as dependency.
pmo-trunk-r2826
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 13:35:24 +0000 (13:35 +0000)]
* modest_text_utils_get_display_date: we do a quick check whether the date
is within the last 24h before doing the expensive extra strftime. As this
function is called for every header in the header view, this should help
a bit (it was showing up high in the profile before)
pmo-trunk-r2825
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 12:53:52 +0000 (12:53 +0000)]
Added new fixes to changelog - week 31 - 27th july.
pmo-trunk-r2823
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 12:00:30 +0000 (12:00 +0000)]
* make the hyperlinkify regexp code a bit faster, also don't try
to hyperlinkify really big parts, because it will take very, very
long even in sbox. limit is 100KB now.
pmo-trunk-r2822
Jose Dapena Paz [Fri, 27 Jul 2007 11:45:45 +0000 (11:45 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now opening attached messages inherits zoom level
(fixes NB#64130).
pmo-trunk-r2821
Jose Dapena Paz [Fri, 27 Jul 2007 10:17:59 +0000 (10:17 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we use window manager on reading messages. If a message
is already shown in another window, it closes the window
and presents the other (fixes NB#64051).
pmo-trunk-r2819
Murray Cumming [Fri, 27 Jul 2007 10:03:32 +0000 (10:03 +0000)]
2007-07-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_get_supported_secure_authentication_methods):
Make sure that we have a connection, asking the user for one
if necessary.
* src/maemo/modest-main-window.c: (modest_main_window_on_show):
Check for a connection before showing the wizard, because
the wizard needs a connection to check for server capabilities.
pmo-trunk-r2818
Murray Cumming [Fri, 27 Jul 2007 09:12:10 +0000 (09:12 +0000)]
2007-07-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-view-window.c:
(on_new_button_clicked): Remember the wizard dialog instance,
so we can just present it again if necessary. This prevents
multiple windows from appearing if you click again quickly on the
New button before the dialog appears, fixing projects.maemo.org
bug NB#64169.
pmo-trunk-r2817
Murray Cumming [Fri, 27 Jul 2007 08:41:38 +0000 (08:41 +0000)]
2007-07-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (modest_main_window_on_show):
Offer a connection dialog if there is no connection when
starting modest. This should fix projects.maemo.org bug NB#61134.
pmo-trunk-r2816
Murray Cumming [Fri, 27 Jul 2007 08:17:05 +0000 (08:17 +0000)]
2007-07-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
Reverted my last commit. I was able to fix the build by doing
apt-get install wpeditor0 (replacing other wpeditor packages) and
an explicit apt-get install wpeditor-dev to upgrade the -dev
package.
pmo-trunk-r2815
Murray Cumming [Fri, 27 Jul 2007 08:08:49 +0000 (08:08 +0000)]
2007-07-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
Commented out the use of wp_text_buffer_replace_image()
because it does not exist, to break the build. Added a TODO for it.
pmo-trunk-r2814
Sergio Villar Senin [Thu, 26 Jul 2007 20:12:16 +0000 (20:12 +0000)]
* Fixes NB#64200, do not ask for a new connection when trying to open a message if it was already downloaded
pmo-trunk-r2813
Jose Dapena Paz [Thu, 26 Jul 2007 19:23:42 +0000 (19:23 +0000)]
* src/maemo/modest-msg-view-window-ui-dimming.h:
* Added dimming rule for delete in menu (fixes NB#63246).
pmo-trunk-r2812
Sergio Villar Senin [Thu, 26 Jul 2007 18:57:29 +0000 (18:57 +0000)]
* Select the INBOX with the proper GtkTreeView call instead of trying to select it with the GtkTreeSelection
pmo-trunk-r2811
Sergio Villar Senin [Thu, 26 Jul 2007 18:55:02 +0000 (18:55 +0000)]
* Fixes NB#64270, now it's not possible to move a folder into itself
pmo-trunk-r2810
Jose Dapena Paz [Thu, 26 Jul 2007 16:48:08 +0000 (16:48 +0000)]
* src/widgets/modest-msg-edit-window.h:
* New API method for adding a part as an attachment.
* src/widgets/modest-folder-view.h:
* Removed non implemented method ..._get_selected_name.
* src/widgets/modest-ui-actions.c:
* Now, if we have messages in clipboard and we paste them in
editor, they're pasted as attachments (fixes NB#63810).
* src/maemo/modest-msg-edit-window.c:
* Added DEBUG_BUFFER method and calls for debugging buffer
status. This throw messages only if DEBUG is defined.
* Now we update properly the visibility of BCC and CC fields
(fixes NB#62722).
* Refactored the way we obtain a pixbuf from a stream, to
share implementation among new image attachment or replaced
image attachment.
* Now we have a method to fill attachment replacements with
the images. This way we can recover the images in the buffer
properly for a mail opened from drafts (fixes NB#62369).
* Now we add the find toolbar using HildonWindow API. This
way the frame is properly configured (fixes NB#63201).
* Now we use the refactored toggle action block notify in maemo
utils.
* Now, if the buffer is empty, we show the "nothing to find"
warning on performing find in page (fixes NB#62350).
* Update dimming implementation of paste action to make paste
available also when there are messages in the clipboard.
* Now we replace the image replacements with images also when
tags are applied. This way, undo works better for inline
images (fixes NB#63336, NB#60993).
* New method to add parts as attachments.
* Now we register that deserializer can create new tags. This
should prevent crashes on copying buffers with tags
(fixes NB#64214 and NB#64368).
pmo-trunk-r2809
Javier Fernandez Garcia-Boente [Thu, 26 Jul 2007 16:42:09 +0000 (16:42 +0000)]
* Open outbox messages in a draft view window.
* Fixes: NB#57915
pmo-trunk-r2808
Murray Cumming [Thu, 26 Jul 2007 16:09:24 +0000 (16:09 +0000)]
2007-07-26 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (recreate_all_accounts):
Recreate them even if they were NULL before. I guess something
else was already creating them before, or this would never
have worked.
(modest_tny_account_store_get_server_account): Make sure that
the tny accounts have been created before trying to find one.
This allows libmodest_dbus_client_compose_mail() to work
when the UI is not yet visible.
This is probably useful in other cases too.
(get_password): When the password is wrong after it is entered
in the protected password dialog, show an info banner (in an
idle handler) before showing the protected password dialog
again.
pmo-trunk-r2807
Dirk-Jan C. Binnema [Thu, 26 Jul 2007 12:46:24 +0000 (12:46 +0000)]
Added new fixes to changelog - week 31.
pmo-trunk-r2806
Sergio Villar Senin [Thu, 26 Jul 2007 12:40:40 +0000 (12:40 +0000)]
* Deleted a private method that made no sense. Replaced it by gtk_tree_view_set_cursor
pmo-trunk-r2805
Sergio Villar Senin [Thu, 26 Jul 2007 12:18:22 +0000 (12:18 +0000)]
* Fixes blocker NB#60968, it now shows Fullscreen instead of the logical id
pmo-trunk-r2804
Jose Dapena Paz [Thu, 26 Jul 2007 11:35:04 +0000 (11:35 +0000)]
* src/widgets/modest-msg-view.c:
* Arg, the new size was wrong, setting a right one
(re fixes NB#62820).
pmo-trunk-r2803
Jose Dapena Paz [Thu, 26 Jul 2007 11:31:45 +0000 (11:31 +0000)]
* src/widgets/modest-msg-view.c:
* Now we readjust the scrolls in a timeout of 250
milliseconds after setting a new message. This should
prevent being able to scroll the body inside its area
when it shouldn't (fixes NB#62820).
pmo-trunk-r2802
Jose Dapena Paz [Thu, 26 Jul 2007 08:06:06 +0000 (08:06 +0000)]
* src/widgets/modest-folder-view.c:
* Send display name update signal more frequently
pmo-trunk-r2801
Jose Dapena Paz [Thu, 26 Jul 2007 08:01:31 +0000 (08:01 +0000)]
* src/widgets/modest-details-dialog.c:
* Reorganisation of fields shown in details dialog.
pmo-trunk-r2800
Jose Dapena Paz [Thu, 26 Jul 2007 07:52:11 +0000 (07:52 +0000)]
* src/modest-mail-operation.c:
* (modest_mail_operation_cancel): a mail operation without an
account is a not expected status, so we show a warning for
this.
pmo-trunk-r2799
Murray Cumming [Thu, 26 Jul 2007 07:33:06 +0000 (07:33 +0000)]
2007-07-26 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.h:
* src/modest-ui-actions.c: Added
modest_do_refresh_current_folder() containing some code from
modest_ui_actions_on_send_receive().
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
Call modest_do_refresh_current_folder() before refreshing the
requested account, as in modest_ui_actions_on_send_receive().
This is strange, but seems to be necessary to show new mails.
Now new emails are finally visible in the UI when downloaded
via the automatic update interval, fixing bug NB#57458.
This also works because bug NB#57458 has been fixed somehow.
pmo-trunk-r2798
Murray Cumming [Thu, 26 Jul 2007 06:43:26 +0000 (06:43 +0000)]
Update the ChangeLog: This fixes projects.maemo.org bug
NB#64225.
pmo-trunk-r2797
Murray Cumming [Thu, 26 Jul 2007 06:42:47 +0000 (06:42 +0000)]
2007-07-26 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
printf more details when we get unhandled D-Bus methods, because
it is interesting.
* src/modest-mail-operation.c: (update_account_thread):
Comment out the tny_camel_pop_store_account_reconnect(), because this
is apparently no longer needed, and it did not work before anyway.
See the comment in the code.
* src/modest-search.c: (modest_search_folder): Ignore deleted emails,
by checking the header flags.
pmo-trunk-r2796
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 16:03:50 +0000 (16:03 +0000)]
* make the memory card Archive folder a localized one,
make sure the folder rules understand it's a special folder
pmo-trunk-r2795
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 15:15:30 +0000 (15:15 +0000)]
* add new addresses to the addressbook automatically when sending.
fixes major bug NB#63631
pmo-trunk-r2794
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 12:44:59 +0000 (12:44 +0000)]
* inliner. save the bcc field as wel. Fixes major bug NB#64120
pmo-trunk-r2793
Murray Cumming [Wed, 25 Jul 2007 12:34:45 +0000 (12:34 +0000)]
2007-07-25 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added
modest_maemo_show_information_note_in_main_context_and_forget().
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Use the new function to show simple error dialogs in the main
context, though question dialogs are still in the current context,
which is unfortunately usually not the main context. This should
fix some hangs.
pmo-trunk-r2792
Dirk-Jan C. Binnema [Wed, 25 Jul 2007 12:20:42 +0000 (12:20 +0000)]
* don't do a regexp-search when doing search-in-page.
this actually fixes #64261 when searching for "\", and
the not-yet-discovered bug that we were doing regexp searches.
the crashing bug is actually in gtkhtml, will move the bug
there.
pmo-trunk-r2791