From 2c0463a9ae8751547c39302aeb31c6cef16b5df4 Mon Sep 17 00:00:00 2001 From: "Eric W. Biederman" Date: Tue, 12 Dec 2006 15:26:07 -0700 Subject: [PATCH 1/1] 9p: Use kthread_stop instead of sending a SIGKILL. Since the kthread api does not bump the reference count on processes that tracked it is not safe allow user space to kill the threads, as I still retain a pointer to the task_struct. Signed-off-by: Eric W. Biederman Acked-by: Eric Van Hensbergen --- fs/9p/mux.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/9p/mux.c b/fs/9p/mux.c index 147ceef..c783874 100644 --- a/fs/9p/mux.c +++ b/fs/9p/mux.c @@ -256,7 +256,7 @@ static void v9fs_mux_poll_stop(struct v9fs_mux_data *m) vpt->muxnum--; if (!vpt->muxnum) { dprintk(DEBUG_MUX, "destroy proc %p\n", vpt); - send_sig(SIGKILL, vpt->task, 1); + kthread_stop(vpt->task); vpt->task = NULL; v9fs_mux_poll_task_num--; } @@ -438,11 +438,8 @@ static int v9fs_poll_proc(void *a) vpt = a; dprintk(DEBUG_MUX, "start %p %p\n", current, vpt); - allow_signal(SIGKILL); while (!kthread_should_stop()) { set_current_state(TASK_INTERRUPTIBLE); - if (signal_pending(current)) - break; list_for_each_entry_safe(m, mtmp, &vpt->mux_list, mux_list) { v9fs_poll_mux(m); -- 1.7.9.5