From 8ad9fa5d8be7fd04e723020088eca664971eb363 Mon Sep 17 00:00:00 2001 From: aliguori Date: Wed, 12 Nov 2008 22:29:11 +0000 Subject: [PATCH] Fix brown-paper-bag bugs from live-migration patch (Charles Duffy) In TCP migration, prevent an endless loop trying to retrieve error status. In exec migration, set the close pointer in the FdMigrationState structure. Color me embarrassed. Signed-off-by: Charles Duffy Signed-off-by: Anthony Liguori git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5713 c046a42c-6fe2-441c-8c8c-71466251a162 --- migration-exec.c | 1 + migration-tcp.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/migration-exec.c b/migration-exec.c index 5d0b215..caeed4b 100644 --- a/migration-exec.c +++ b/migration-exec.c @@ -85,6 +85,7 @@ MigrationState *exec_start_outgoing_migration(const char *command, s->opaque = qemu_popen(f, "w"); + s->close = exec_close; s->get_error = file_errno; s->write = file_write; s->mig_state.cancel = migrate_fd_cancel; diff --git a/migration-tcp.c b/migration-tcp.c index 100644b..6fc1943 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -32,7 +32,7 @@ static int socket_errno(FdMigrationState *s) { - return (s->get_error(s)); + return socket_error(); } static int socket_write(FdMigrationState *s, const void * buf, size_t size) -- 1.7.9.5