From cf98c5983db9c035eea122927a50f7d83fc5eeb5 Mon Sep 17 00:00:00 2001 From: horwitz Date: Thu, 18 Jun 2009 10:21:52 +0000 Subject: [PATCH] Fix:Core:Fix coverity bug #37, Pointer 'diitem' dereferenced before NULL check. git-svn-id: https://navit.svn.sourceforge.net/svnroot/navit/trunk/navit@2342 ffa7fe5e-494d-0410-b361-a75ebd5db220 --- navit/popup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/navit/popup.c b/navit/popup.c index d5c09f1..2b8611d 100644 --- a/navit/popup.c +++ b/navit/popup.c @@ -259,7 +259,7 @@ popup_show_item(struct navit *nav, void *popup, struct displayitem *di) menu_item=popup_printf(menu, menu_type_submenu, "Item"); popup_printf(menu_item, menu_type_menu, "type: 0x%x", diitem->type); popup_printf(menu_item, menu_type_menu, "id: 0x%x 0x%x", diitem->id_hi, diitem->id_lo); - if (diitem->map) { + if (diitem && diitem->map) { mr=map_rect_new(diitem->map,NULL); item=map_rect_get_item_byid(mr, diitem->id_hi, diitem->id_lo); dbg(1,"item=%p\n", item); -- 1.7.9.5