Introduce command-line config utility

[browser-switch] / main.c

diff --git a/main.c b/main.c
index 57c2246..30361c8 100644 (file)
--- a/main.c
+++ b/main.c
@@ -22,8 +22,8 @@
 
 #include <stdlib.h>
 #include <string.h>
-#include <stdio.h>
 #include <signal.h>
+#include <errno.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <dbus/dbus-glib.h>
@@ -31,71 +31,41 @@
 #include "browser-switchboard.h"
 #include "launcher.h"
 #include "dbus-server-bindings.h"
-#include "configfile.h"
+#include "config.h"
+#include "log.h"
 
 struct swb_context ctx;
 
-static void set_config_defaults(struct swb_context *ctx) {
-       if (!ctx)
-               return;
-       free(ctx->other_browser_cmd);
-       ctx->continuous_mode = 0;
-       ctx->default_browser_launcher = NULL;
-       ctx->other_browser_cmd = NULL;
-}
-
 static void waitforzombies(int signalnum) {
        while (waitpid(-1, NULL, WNOHANG) > 0)
-               printf("Waited for a zombie\n");
+               log_msg("Waited for a zombie\n");
 }
 
 static void read_config(int signalnum) {
-       FILE *fp;
-       int continuous_mode_seen = 0;
-       struct swb_config_line line;
-       char *default_browser = NULL;
-
-       set_config_defaults(&ctx);
-
-       if (!(fp = open_config_file()))
-               goto out_noopen;
-
-       /* Parse the config file
-          TODO: should we handle errors differently than EOF? */
-       if (!parse_config_file_begin())
-               goto out;
-       while (!parse_config_file_line(fp, &line)) {
-               if (line.parsed) {
-                       if (!strcmp(line.key, "continuous_mode")) {
-                               if (!continuous_mode_seen) {
-                                       ctx.continuous_mode = atoi(line.value);
-                                       continuous_mode_seen = 1;
-                               }
-                               free(line.value);
-                       } else if (!strcmp(line.key, "default_browser")) {
-                               if (!default_browser)
-                                       default_browser = line.value;
-                       } else if (!strcmp(line.key, "other_browser_cmd")) {
-                               if (!ctx.other_browser_cmd)
-                                       ctx.other_browser_cmd = line.value;
-                       } else {
-                               /* Don't need this line's contents */
-                               free(line.value);
-                       }
+       struct swb_config cfg;
+
+       swb_config_init(&cfg);
+
+       swb_config_load(&cfg);
+
+       log_config(cfg.logging);
+       ctx.continuous_mode = cfg.continuous_mode;
+       if (cfg.other_browser_cmd) {
+               if (!(ctx.other_browser_cmd = strdup(cfg.other_browser_cmd))) {
+                       log_perror(errno, "Failed to set other_browser_cmd");
+                       exit(1);
                }
-               free(line.key);
-       }
-       parse_config_file_end();
+       } else
+               ctx.other_browser_cmd = NULL;
+       update_default_browser(&ctx, cfg.default_browser);
 
-       printf("continuous_mode: %d\n", ctx.continuous_mode);
-       printf("default_browser: '%s'\n", default_browser?default_browser:"NULL");
-       printf("other_browser_cmd: '%s'\n", ctx.other_browser_cmd?ctx.other_browser_cmd:"NULL");
+       log_msg("continuous_mode: %d\n", cfg.continuous_mode);
+       log_msg("default_browser: '%s'\n", cfg.default_browser);
+       log_msg("other_browser_cmd: '%s'\n",
+               cfg.other_browser_cmd?cfg.other_browser_cmd:"NULL");
+       log_msg("logging: '%s'\n", cfg.logging);
 
-out:
-       fclose(fp);
-out_noopen:
-       update_default_browser(&ctx, default_browser);
-       free(default_browser);
+       swb_config_free(&cfg);
        return;
 }
 
@@ -116,14 +86,14 @@ int main() {
                /* SIGCHLD -- clean up after zombies */
                act.sa_handler = waitforzombies;
                if (sigaction(SIGCHLD, &act, NULL) == -1) {
-                       printf("Installing signal handler failed\n");
+                       log_msg("Installing signal handler failed\n");
                        return 1;
                }
 
                /* SIGHUP -- reread config file */
                act.sa_handler = read_config;
                if (sigaction(SIGHUP, &act, NULL) == -1) {
-                       printf("Installing signal handler failed\n");
+                       log_msg("Installing signal handler failed\n");
                        return 1;
                }
        }
@@ -136,14 +106,14 @@ int main() {
        /* Get a connection to the D-Bus session bus */
        ctx.session_bus = dbus_g_bus_get(DBUS_BUS_SESSION, &error);
        if (!ctx.session_bus) {
-               printf("Couldn't get a D-Bus bus connection\n");
+               log_msg("Couldn't get a D-Bus bus connection\n");
                return 1;
        }
        ctx.dbus_proxy = dbus_g_proxy_new_for_name(ctx.session_bus,
                        "org.freedesktop.DBus", "/org/freedesktop/DBus",
                        "org.freedesktop.DBus");
        if (!ctx.dbus_proxy) {
-               printf("Couldn't get an org.freedesktop.DBus proxy\n");
+               log_msg("Couldn't get an org.freedesktop.DBus proxy\n");
                return 1;
        }
 
@@ -159,12 +129,12 @@ int main() {
                               G_TYPE_INVALID,
                               G_TYPE_UINT, &reqname_result,
                               G_TYPE_INVALID)) {
-               printf("Couldn't acquire browser-switchboard lock: %s\n",
-                      error->message);
+               log_msg("Couldn't acquire browser-switchboard lock: %s\n",
+                       error->message);
                return 1;
        }
        if (reqname_result != DBUS_REQUEST_NAME_REPLY_PRIMARY_OWNER) {  
-               printf("Another browser-switchboard already running\n");
+               log_msg("Another browser-switchboard already running\n");
                return 1;
        }
 
@@ -180,9 +150,9 @@ int main() {
                        G_OBJECT(obj_osso_browser_req));
 
        mainloop = g_main_loop_new(NULL, FALSE);
-       printf("Starting main loop\n");
+       log_msg("Starting main loop\n");
        g_main_loop_run(mainloop);
-       printf("Main loop completed\n");
+       log_msg("Main loop completed\n");
 
        return 0;
 }