Don't allow remove method calls on non-favorite services
[connman] / src / service.c
index 22c4057..a6ee992 100644 (file)
@@ -45,8 +45,11 @@ struct connman_service {
        unsigned int order;
        char *name;
        char *passphrase;
+       char *profile;
        struct connman_device *device;
        struct connman_network *network;
+       DBusMessage *pending;
+       guint timeout;
 };
 
 static void append_path(gpointer value, gpointer user_data)
@@ -171,14 +174,14 @@ static void state_changed(struct connman_service *service)
 }
 
 static DBusMessage *get_properties(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
+                                       DBusMessage *msg, void *user_data)
 {
-       struct connman_service *service = data;
+       struct connman_service *service = user_data;
        DBusMessage *reply;
        DBusMessageIter array, dict;
        const char *str;
 
-       DBG("conn %p", conn);
+       DBG("service %p", service);
 
        reply = dbus_message_new_method_return(msg);
        if (reply == NULL)
@@ -234,14 +237,14 @@ static DBusMessage *get_properties(DBusConnection *conn,
 }
 
 static DBusMessage *set_property(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
+                                       DBusMessage *msg, void *user_data)
 {
-       struct connman_service *service = data;
+       struct connman_service *service = user_data;
        DBusMessageIter iter, value;
        const char *name;
        int type;
 
-       DBG("conn %p", conn);
+       DBG("service %p", service);
 
        if (dbus_message_iter_init(msg, &iter) == FALSE)
                return __connman_error_invalid_arguments(msg);
@@ -274,62 +277,171 @@ static DBusMessage *set_property(DBusConnection *conn,
                if (service->network != NULL)
                        connman_network_set_string(service->network,
                                "WiFi.Passphrase", service->passphrase);
+
+               __connman_storage_save_service(service);
        }
 
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
 
+static gboolean connect_timeout(gpointer user_data)
+{
+       struct connman_service *service = user_data;
+
+       DBG("service %p", service);
+
+       service->timeout = 0;
+
+       if (service->network != NULL)
+               __connman_network_disconnect(service->network);
+
+       if (service->pending != NULL) {
+               DBusMessage *reply;
+
+               reply = __connman_error_operation_timeout(service->pending);
+               if (reply != NULL)
+                       g_dbus_send_message(connection, reply);
+
+               dbus_message_unref(service->pending);
+               service->pending = NULL;
+
+               __connman_service_indicate_state(service,
+                                       CONNMAN_SERVICE_STATE_FAILURE);
+       }
+
+       return FALSE;
+}
+
 static DBusMessage *connect_service(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
+                                       DBusMessage *msg, void *user_data)
 {
-       struct connman_service *service = data;
+       struct connman_service *service = user_data;
+
+       DBG("service %p", service);
+
+       if (service->pending != NULL)
+               return __connman_error_in_progress(msg);
+
+       if (service->state == CONNMAN_SERVICE_STATE_READY)
+               return __connman_error_already_connected(msg);
+
+       if (service->network != NULL) {
+               int err;
+
+               connman_network_set_string(service->network,
+                               "WiFi.Passphrase", service->passphrase);
+
+               err = connman_network_connect(service->network);
+               if (err < 0 && err != -EINPROGRESS)
+                       return __connman_error_failed(msg, -err);
+
+               service->pending = dbus_message_ref(msg);
+
+               service->timeout = g_timeout_add_seconds(45,
+                                               connect_timeout, service);
+
+               return NULL;
+       } else if (service->device != NULL) {
+               if (service->favorite == FALSE)
+                       return __connman_error_no_carrier(msg);
 
-       if (service->device != NULL) {
                if (__connman_device_connect(service->device) < 0)
-                       return __connman_error_failed(msg);
+                       return __connman_error_failed(msg, EINVAL);
 
-               service->state = CONNMAN_SERVICE_STATE_READY;
+               service->pending = dbus_message_ref(msg);
+               service->timeout = g_timeout_add_seconds(15,
+                                               connect_timeout, service);
 
-               state_changed(service);
+               return NULL;
        }
 
        return __connman_error_not_supported(msg);
 }
 
 static DBusMessage *disconnect_service(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
+                                       DBusMessage *msg, void *user_data)
 {
-       struct connman_service *service = data;
+       struct connman_service *service = user_data;
 
-       if (service->device != NULL) {
-               if (__connman_device_connect(service->device) < 0)
-                       return __connman_error_failed(msg);
+       DBG("service %p", service);
 
-               service->state = CONNMAN_SERVICE_STATE_IDLE;
+       if (service->pending != NULL) {
+               DBusMessage *reply;
 
-               state_changed(service);
+               reply = __connman_error_operation_aborted(service->pending);
+               if (reply != NULL)
+                       g_dbus_send_message(conn, reply);
+
+               dbus_message_unref(service->pending);
+               service->pending = NULL;
+
+               return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
+       }
+
+       if (service->network != NULL) {
+               struct connman_device *device;
+               int err;
+
+               device = connman_network_get_device(service->network);
+               if (device != NULL)
+                       __connman_device_disconnect(device);
+
+               err = __connman_network_disconnect(service->network);
+               if (err < 0 && err != -EINPROGRESS)
+                       return __connman_error_failed(msg, -err);
+
+               return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
+       } else if (service->device != NULL) {
+               int err;
+
+               if (service->favorite == FALSE)
+                       return __connman_error_no_carrier(msg);
+
+               err = __connman_device_disconnect(service->device);
+               if (err < 0)
+                       return __connman_error_failed(msg, -err);
+
+               return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
        }
 
        return __connman_error_not_supported(msg);
 }
 
 static DBusMessage *remove_service(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
+                                       DBusMessage *msg, void *user_data)
 {
-       struct connman_service *service = data;
+       struct connman_service *service = user_data;
+
+       DBG("service %p", service);
 
        if (service->type == CONNMAN_SERVICE_TYPE_ETHERNET)
                return __connman_error_not_supported(msg);
 
+       if (service->favorite == FALSE)
+               return __connman_error_not_supported(msg);
+
+       if (service->network != NULL) {
+               struct connman_device *device;
+
+               device = connman_network_get_device(service->network);
+               if (device != NULL)
+                       __connman_device_disconnect(device);
+
+               __connman_network_disconnect(service->network);
+       }
+
        connman_service_set_favorite(service, FALSE);
+       __connman_storage_save_service(service);
 
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
 
 static DBusMessage *move_before(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
+                                       DBusMessage *msg, void *user_data)
 {
-       struct connman_service *service = data;
+       struct connman_service *service = user_data;
+
+       DBG("service %p", service);
 
        if (service->favorite == FALSE)
                return __connman_error_not_supported(msg);
@@ -338,9 +450,11 @@ static DBusMessage *move_before(DBusConnection *conn,
 }
 
 static DBusMessage *move_after(DBusConnection *conn,
-                                       DBusMessage *msg, void *data)
+                                       DBusMessage *msg, void *user_data)
 {
-       struct connman_service *service = data;
+       struct connman_service *service = user_data;
+
+       DBG("service %p", service);
 
        if (service->favorite == FALSE)
                return __connman_error_not_supported(msg);
@@ -351,7 +465,8 @@ static DBusMessage *move_after(DBusConnection *conn,
 static GDBusMethodTable service_methods[] = {
        { "GetProperties", "",   "a{sv}", get_properties     },
        { "SetProperty",   "sv", "",      set_property       },
-       { "Connect",       "",   "",      connect_service    },
+       { "Connect",       "",   "",      connect_service,
+                                               G_DBUS_METHOD_FLAG_ASYNC },
        { "Disconnect",    "",   "",      disconnect_service },
        { "Remove",        "",   "",      remove_service     },
        { "MoveBefore",    "o",  "",      move_before        },
@@ -364,15 +479,23 @@ static GDBusSignalTable service_signals[] = {
        { },
 };
 
-static void service_free(gpointer data)
+static void service_free(gpointer user_data)
 {
-       struct connman_service *service = data;
+       struct connman_service *service = user_data;
        char *path = service->path;
 
        DBG("service %p", service);
 
        g_hash_table_remove(service_hash, service->identifier);
 
+       if (service->timeout > 0)
+               g_source_remove(service->timeout);
+
+       if (service->pending != NULL) {
+               dbus_message_unref(service->pending);
+               service->pending = NULL;
+       }
+
        service->path = NULL;
 
        if (path != NULL) {
@@ -386,6 +509,7 @@ static void service_free(gpointer data)
        if (service->network != NULL)
                connman_network_unref(service->network);
 
+       g_free(service->profile);
        g_free(service->name);
        g_free(service->passphrase);
        g_free(service->identifier);
@@ -393,12 +517,12 @@ static void service_free(gpointer data)
 }
 
 /**
- * connman_service_put:
+ * __connman_service_put:
  * @service: service structure
  *
  * Release service if no longer needed
  */
-void connman_service_put(struct connman_service *service)
+void __connman_service_put(struct connman_service *service)
 {
        DBG("service %p", service);
 
@@ -472,7 +596,7 @@ struct connman_service *connman_service_ref(struct connman_service *service)
  */
 void connman_service_unref(struct connman_service *service)
 {
-       connman_service_put(service);
+       __connman_service_put(service);
 }
 
 static gint service_compare(gconstpointer a, gconstpointer b,
@@ -481,6 +605,13 @@ static gint service_compare(gconstpointer a, gconstpointer b,
        struct connman_service *service_a = (void *) a;
        struct connman_service *service_b = (void *) b;
 
+       if (service_a->state != service_b->state) {
+               if (service_a->state == CONNMAN_SERVICE_STATE_READY)
+                       return -1;
+               if (service_b->state == CONNMAN_SERVICE_STATE_READY)
+                       return 1;
+       }
+
        if (service_a->order > service_b->order)
                return -1;
 
@@ -512,7 +643,7 @@ int connman_service_set_favorite(struct connman_service *service,
        if (iter == NULL)
                return -ENOENT;
 
-       if (service->favorite)
+       if (service->favorite == favorite)
                return -EALREADY;
 
        service->favorite = favorite;
@@ -541,65 +672,100 @@ int __connman_service_set_carrier(struct connman_service *service,
                break;
        }
 
-       if (carrier == TRUE)
-               service->state = CONNMAN_SERVICE_STATE_CARRIER;
-       else
-               service->state = CONNMAN_SERVICE_STATE_IDLE;
+       if (carrier == FALSE) {
+               service->state = CONNMAN_SERVICE_STATE_DISCONNECT;
+               state_changed(service);
 
-       state_changed(service);
+               service->state = CONNMAN_SERVICE_STATE_IDLE;
+               state_changed(service);
+       } else {
+               service->state = CONNMAN_SERVICE_STATE_CARRIER;
+               state_changed(service);
+       }
 
        return connman_service_set_favorite(service, carrier);
 }
 
-int __connman_service_indicate_configuration(struct connman_service *service)
+int __connman_service_indicate_state(struct connman_service *service,
+                                       enum connman_service_state state)
 {
-       DBG("service %p", service);
+       GSequenceIter *iter;
+
+       DBG("service %p state %d", service, state);
 
        if (service == NULL)
                return -EINVAL;
 
-       service->state = CONNMAN_SERVICE_STATE_CONFIGURATION;
+       if (state == CONNMAN_SERVICE_STATE_CARRIER)
+               return __connman_service_set_carrier(service, TRUE);
+
+       if (service->state == state)
+               return -EALREADY;
+
+       if (service->state == CONNMAN_SERVICE_STATE_IDLE &&
+                               state == CONNMAN_SERVICE_STATE_DISCONNECT)
+               return -EINVAL;
+
+       if (state == CONNMAN_SERVICE_STATE_IDLE &&
+                       service->state != CONNMAN_SERVICE_STATE_DISCONNECT) {
+               service->state = CONNMAN_SERVICE_STATE_DISCONNECT;
+               state_changed(service);
+       }
 
+       service->state = state;
        state_changed(service);
 
-       return 0;
-}
+       if (state == CONNMAN_SERVICE_STATE_READY) {
+               connman_service_set_favorite(service, TRUE);
+               __connman_storage_save_service(service);
 
-int __connman_service_ready(struct connman_service *service)
-{
-       DBG("service %p", service);
+               if (service->timeout > 0)
+                       g_source_remove(service->timeout);
 
-       if (service == NULL)
-               return -EINVAL;
+               if (service->pending != NULL) {
+                       g_dbus_send_reply(connection, service->pending,
+                                                       DBUS_TYPE_INVALID);
 
-       service->state = CONNMAN_SERVICE_STATE_READY;
+                       dbus_message_unref(service->pending);
+                       service->pending = NULL;
+               }
+       }
 
-       state_changed(service);
+       if (state == CONNMAN_SERVICE_STATE_FAILURE) {
+               if (service->timeout > 0)
+                       g_source_remove(service->timeout);
 
-       return 0;
-}
+               if (service->pending != NULL) {
+                       DBusMessage *reply;
 
-int __connman_service_disconnect(struct connman_service *service)
-{
-       DBG("service %p", service);
+                       reply = __connman_error_failed(service->pending, EIO);
+                       if (reply != NULL)
+                               g_dbus_send_message(connection, reply);
 
-       if (service == NULL)
-               return -EINVAL;
+                       dbus_message_unref(service->pending);
+                       service->pending = NULL;
+               }
 
-       service->state = CONNMAN_SERVICE_STATE_DISCONNECT;
+               service->state = CONNMAN_SERVICE_STATE_IDLE;
+               state_changed(service);
+       }
 
-       state_changed(service);
+       iter = g_hash_table_lookup(service_hash, service->identifier);
+       if (iter != NULL)
+               g_sequence_sort_changed(iter, service_compare, NULL);
+
+       __connman_profile_changed();
 
        return 0;
 }
 
 /**
- * connman_service_lookup:
+ * __connman_service_lookup:
  * @identifier: service identifier
  *
  * Look up a service by identifier (reference count will not be increased)
  */
-struct connman_service *connman_service_lookup(const char *identifier)
+static struct connman_service *__connman_service_lookup(const char *identifier)
 {
        GSequenceIter *iter;
 
@@ -611,12 +777,12 @@ struct connman_service *connman_service_lookup(const char *identifier)
 }
 
 /**
- * connman_service_get:
+ * __connman_service_get:
  * @identifier: service identifier
  *
  * Look up a service by identifier or create a new one if not found
  */
-struct connman_service *connman_service_get(const char *identifier)
+static struct connman_service *__connman_service_get(const char *identifier)
 {
        struct connman_service *service;
        GSequenceIter *iter;
@@ -639,6 +805,10 @@ struct connman_service *connman_service_get(const char *identifier)
 
        service->identifier = g_strdup(identifier);
 
+       service->profile = g_strdup(__connman_profile_active_ident());
+
+       __connman_storage_load_service(service);
+
        iter = g_sequence_insert_sorted(service_list, service,
                                                service_compare, NULL);
 
@@ -649,7 +819,8 @@ struct connman_service *connman_service_get(const char *identifier)
 
 static int service_register(struct connman_service *service)
 {
-       const char *path = __connman_profile_active();
+       const char *path = __connman_profile_active_path();
+       GSequenceIter *iter;
 
        DBG("service %p", service);
 
@@ -665,6 +836,12 @@ static int service_register(struct connman_service *service)
                                        service_methods, service_signals,
                                                        NULL, service, NULL);
 
+       __connman_storage_load_service(service);
+
+       iter = g_hash_table_lookup(service_hash, service->identifier);
+       if (iter != NULL)
+               g_sequence_sort_changed(iter, service_compare, NULL);
+
        __connman_profile_changed();
 
        return 0;
@@ -679,12 +856,17 @@ static int service_register(struct connman_service *service)
 struct connman_service *__connman_service_lookup_from_device(struct connman_device *device)
 {
        struct connman_service *service;
+       const char *ident;
        char *name;
 
-       name = g_strdup_printf("%s_%d", __connman_device_get_type(device),
-                                       connman_device_get_index(device));
+       ident = __connman_device_get_ident(device);
+       if (ident == NULL)
+               return NULL;
+
+       name = g_strdup_printf("%s_%s",
+                               __connman_device_get_type(device), ident);
 
-       service = connman_service_lookup(name);
+       service = __connman_service_lookup(name);
 
        g_free(name);
 
@@ -723,17 +905,22 @@ static enum connman_service_type convert_device_type(struct connman_device *devi
 struct connman_service *__connman_service_create_from_device(struct connman_device *device)
 {
        struct connman_service *service;
+       const char *ident;
        char *name;
 
-       name = g_strdup_printf("%s_%d", __connman_device_get_type(device),
-                                       connman_device_get_index(device));
+       ident = __connman_device_get_ident(device);
+       if (ident == NULL)
+               return NULL;
+
+       name = g_strdup_printf("%s_%s",
+                               __connman_device_get_type(device), ident);
 
-       service = connman_service_get(name);
+       service = __connman_service_get(name);
        if (service == NULL)
                goto done;
 
        if (service->path != NULL) {
-               connman_service_put(service);
+               __connman_service_put(service);
                service = NULL;
                goto done;
        }
@@ -759,17 +946,21 @@ done:
 struct connman_service *__connman_service_lookup_from_network(struct connman_network *network)
 {
        struct connman_service *service;
-       const char *group;
+       const char *ident, *group;
        char *name;
 
+       ident = __connman_network_get_ident(network);
+       if (ident == NULL)
+               return NULL;
+
        group = __connman_network_get_group(network);
        if (group == NULL)
                return NULL;
 
-       name = g_strdup_printf("%s_%s",
-                               __connman_network_get_type(network), group);
+       name = g_strdup_printf("%s_%s_%s",
+                       __connman_network_get_type(network), ident, group);
 
-       service = connman_service_lookup(name);
+       service = __connman_service_lookup(name);
 
        g_free(name);
 
@@ -874,17 +1065,21 @@ static void update_from_network(struct connman_service *service,
 struct connman_service *__connman_service_create_from_network(struct connman_network *network)
 {
        struct connman_service *service;
-       const char *group;
+       const char *ident, *group;
        char *name;
 
+       ident = __connman_network_get_ident(network);
+       if (ident == NULL)
+               return NULL;
+
        group = __connman_network_get_group(network);
        if (group == NULL)
                return NULL;
 
-       name = g_strdup_printf("%s_%s",
-                               __connman_network_get_type(network), group);
+       name = g_strdup_printf("%s_%s_%s",
+                       __connman_network_get_type(network), ident, group);
 
-       service = connman_service_get(name);
+       service = __connman_service_get(name);
        if (service == NULL)
                goto done;
 
@@ -893,13 +1088,15 @@ struct connman_service *__connman_service_create_from_network(struct connman_net
 
                __connman_profile_changed();
 
-               connman_service_put(service);
+               __connman_service_put(service);
                service = NULL;
                goto done;
        }
 
        service->type = convert_network_type(network);
 
+       service->state = CONNMAN_SERVICE_STATE_IDLE;
+
        update_from_network(service, network);
 
        service_register(service);
@@ -910,12 +1107,141 @@ done:
        return service;
 }
 
+static int service_load(struct connman_service *service)
+{
+       GKeyFile *keyfile;
+       gchar *pathname, *data = NULL;
+       gsize length;
+       char *str;
+
+       DBG("service %p", service);
+
+       if (service->profile == NULL)
+               return -EINVAL;
+
+       pathname = g_strdup_printf("%s/%s.conf", STORAGEDIR, service->profile);
+       if (pathname == NULL)
+               return -ENOMEM;
+
+       keyfile = g_key_file_new();
+
+       if (g_file_get_contents(pathname, &data, &length, NULL) == FALSE) {
+               g_free(pathname);
+               return -ENOENT;
+       }
+
+       g_free(pathname);
+
+       if (g_key_file_load_from_data(keyfile, data, length,
+                                                       0, NULL) == FALSE) {
+               g_free(data);
+               return -EILSEQ;
+       }
+
+       g_free(data);
+
+       switch (service->type) {
+       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_ETHERNET:
+               break;
+       case CONNMAN_SERVICE_TYPE_WIFI:
+       case CONNMAN_SERVICE_TYPE_WIMAX:
+               service->favorite = g_key_file_get_boolean(keyfile,
+                               service->identifier, "Favorite", NULL);
+               break;
+       }
+
+       str = g_key_file_get_string(keyfile,
+                               service->identifier, "Passphrase", NULL);
+       if (str != NULL) {
+               g_free(service->passphrase);
+               service->passphrase = str;
+       }
+
+       g_key_file_free(keyfile);
+
+       return 0;
+}
+
+static int service_save(struct connman_service *service)
+{
+       GKeyFile *keyfile;
+       gchar *pathname, *data = NULL;
+       gsize length;
+
+       DBG("service %p", service);
+
+       if (service->profile == NULL)
+               return -EINVAL;
+
+       pathname = g_strdup_printf("%s/%s.conf", STORAGEDIR, service->profile);
+       if (pathname == NULL)
+               return -ENOMEM;
+
+       keyfile = g_key_file_new();
+
+       if (g_file_get_contents(pathname, &data, &length, NULL) == FALSE)
+               goto update;
+
+       if (length > 0) {
+               if (g_key_file_load_from_data(keyfile, data, length,
+                                                       0, NULL) == FALSE)
+                       goto done;
+       }
+
+       g_free(data);
+
+update:
+       if (service->name != NULL)
+               g_key_file_set_string(keyfile, service->identifier,
+                                               "Name", service->name);
+
+       switch (service->type) {
+       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_ETHERNET:
+               break;
+       case CONNMAN_SERVICE_TYPE_WIFI:
+       case CONNMAN_SERVICE_TYPE_WIMAX:
+               g_key_file_set_boolean(keyfile, service->identifier,
+                                       "Favorite", service->favorite);
+               break;
+       }
+
+       if (service->passphrase != NULL)
+               g_key_file_set_string(keyfile, service->identifier,
+                                       "Passphrase", service->passphrase);
+
+       data = g_key_file_to_data(keyfile, &length, NULL);
+
+       if (g_file_set_contents(pathname, data, length, NULL) == FALSE)
+               connman_error("Failed to store service information");
+
+done:
+       g_free(data);
+
+       g_key_file_free(keyfile);
+
+       g_free(pathname);
+
+       return 0;
+}
+
+static struct connman_storage service_storage = {
+       .name           = "service",
+       .priority       = CONNMAN_STORAGE_PRIORITY_LOW,
+       .service_load   = service_load,
+       .service_save   = service_save,
+};
+
 int __connman_service_init(void)
 {
        DBG("");
 
        connection = connman_dbus_get_connection();
 
+       if (connman_storage_register(&service_storage) < 0)
+               connman_error("Failed to register service storage");
+
        service_hash = g_hash_table_new_full(g_str_hash, g_str_equal,
                                                                NULL, NULL);
 
@@ -934,5 +1260,7 @@ void __connman_service_cleanup(void)
        g_hash_table_destroy(service_hash);
        service_hash = NULL;
 
+       connman_storage_unregister(&service_storage);
+
        dbus_connection_unref(connection);
 }