X-Git-Url: http://git.maemo.org/git/?p=dh-make-perl;a=blobdiff_plain;f=dev%2Farm%2Flibperl-critic-perl%2Flibperl-critic-perl-1.088%2Flib%2FPerl%2FCritic%2FPolicy%2FValuesAndExpressions%2FRequireInterpolationOfMetachars.pm;fp=dev%2Farm%2Flibperl-critic-perl%2Flibperl-critic-perl-1.088%2Flib%2FPerl%2FCritic%2FPolicy%2FValuesAndExpressions%2FRequireInterpolationOfMetachars.pm;h=be289c3280e1fcb288a8857f9ec31bb8700ec187;hp=0000000000000000000000000000000000000000;hb=f477fa73365d491991707e7ed9217b48d6994551;hpb=da95c414033799c3a62606f299c3c00b5c77ca11 diff --git a/dev/arm/libperl-critic-perl/libperl-critic-perl-1.088/lib/Perl/Critic/Policy/ValuesAndExpressions/RequireInterpolationOfMetachars.pm b/dev/arm/libperl-critic-perl/libperl-critic-perl-1.088/lib/Perl/Critic/Policy/ValuesAndExpressions/RequireInterpolationOfMetachars.pm new file mode 100644 index 0000000..be289c3 --- /dev/null +++ b/dev/arm/libperl-critic-perl/libperl-critic-perl-1.088/lib/Perl/Critic/Policy/ValuesAndExpressions/RequireInterpolationOfMetachars.pm @@ -0,0 +1,121 @@ +############################################################################## +# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/ValuesAndExpressions/RequireInterpolationOfMetachars.pm $ +# $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $ +# $Author: clonezone $ +# $Revision: 2489 $ +############################################################################## + +package Perl::Critic::Policy::ValuesAndExpressions::RequireInterpolationOfMetachars; + +use 5.006001; +use strict; +use warnings; +use Readonly; + +use Perl::Critic::Utils qw{ :severities }; +use base 'Perl::Critic::Policy'; + +#----------------------------------------------------------------------------- + +our $VERSION = '1.088'; + +#----------------------------------------------------------------------------- + +Readonly::Scalar my $DESC => q{String *may* require interpolation}; +Readonly::Scalar my $EXPL => [ 51 ]; + +#----------------------------------------------------------------------------- + +sub supported_parameters { return () } +sub default_severity { return $SEVERITY_LOWEST } +sub default_themes { return qw(core pbp cosmetic) } +sub applies_to { return qw(PPI::Token::Quote::Single + PPI::Token::Quote::Literal) } + +#----------------------------------------------------------------------------- + +sub violates { + my ( $self, $elem, undef ) = @_; + # The string() method strips off the quotes + return if not _needs_interpolation( $elem->string() ); + return if _looks_like_email_address( $elem->string() ); + return $self->violation( $DESC, $EXPL, $elem ); +} + +#----------------------------------------------------------------------------- + +sub _needs_interpolation { + my $string = shift; + return $string =~ m{ [\$\@] \S+ }mxo #Contains a $ or @ + || $string =~ m{ \\[tnrfae0xcNLuLUEQ] }mxo; #Contains metachars +} + +#----------------------------------------------------------------------------- + +sub _looks_like_email_address { + my $string = shift; + return $string =~ m{\A [^\@\s]+ \@ [\w\-.]+ \z}mxo; +} + +1; + +__END__ + +#----------------------------------------------------------------------------- + +=pod + +=head1 NAME + +Perl::Critic::Policy::ValuesAndExpressions::RequireInterpolationOfMetachars - Warns that you might have used single quotes when you really wanted double-quotes. + +=head1 AFFILIATION + +This Policy is part of the core L distribution. + + +=head1 DESCRIPTION + +This policy warns you if you use single-quotes or C with a string +that has unescaped metacharacters that may need interpolation. Its hard +to know for sure if a string really should be interpolated without +looking into the symbol table. This policy just makes an educated +guess by looking for metacharacters and sigils which usually indicate that +the string should be interpolated. + + +=head1 CONFIGURATION + +This Policy is not configurable except for the standard options. + + +=head1 NOTES + +Perl's own C pragma also warns you about this. + +=head1 SEE ALSO + +L + +=head1 AUTHOR + +Jeffrey Ryan Thalhammer + +=head1 COPYRIGHT + +Copyright (c) 2005-2008 Jeffrey Ryan Thalhammer. All rights reserved. + +This program is free software; you can redistribute it and/or modify +it under the same terms as Perl itself. The full text of this license +can be found in the LICENSE file included with this module. + +=cut + +# Local Variables: +# mode: cperl +# cperl-indent-level: 4 +# fill-column: 78 +# indent-tabs-mode: nil +# c-indentation-style: bsd +# End: +# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :