Due to crashes, temporarilly dropping missed call detection
[gc-dialer] / src / dialcentral_qt.py
index 820d6d7..b99d32a 100755 (executable)
@@ -14,6 +14,7 @@ from PyQt4 import QtCore
 
 import constants
 from util import qtpie
+from util import qwrappers
 from util import qui_utils
 from util import misc as misc_utils
 
@@ -23,7 +24,30 @@ import session
 _moduleLogger = logging.getLogger(__name__)
 
 
-class Dialcentral(object):
+class LedWrapper(object):
+
+       def __init__(self):
+               self._ledHandler = None
+               self._init = False
+
+       def off(self):
+               self._lazy_init()
+               if self._ledHandler is not None:
+                       self._ledHandler.off()
+
+       def _lazy_init(self):
+               if self._init:
+                       return
+               self._init = True
+               try:
+                       import led_handler
+                       self._ledHandler = led_handler.LedHandler()
+               except Exception, e:
+                       _moduleLogger.exception('Unable to initialize LED Handling: "%s"' % str(e))
+                       self._ledHandler = None
+
+
+class Dialcentral(qwrappers.ApplicationWrapper):
 
        _DATA_PATHS = [
                os.path.join(os.path.dirname(__file__), "../share"),
@@ -31,43 +55,28 @@ class Dialcentral(object):
        ]
 
        def __init__(self, app):
-               self._app = app
-               self._recent = []
-               self._hiddenCategories = set()
-               self._hiddenUnits = {}
-               self._clipboard = QtGui.QApplication.clipboard()
                self._dataPath = None
+               self._aboutDialog = None
+               self._ledHandler = LedWrapper()
+               self.notifyOnMissed = False
+               self.notifyOnVoicemail = False
+               self.notifyOnSms = False
 
-               self._mainWindow = None
-
-               self._fullscreenAction = QtGui.QAction(None)
-               self._fullscreenAction.setText("Fullscreen")
-               self._fullscreenAction.setCheckable(True)
-               self._fullscreenAction.setShortcut(QtGui.QKeySequence("CTRL+Enter"))
-               self._fullscreenAction.toggled.connect(self._on_toggle_fullscreen)
-
-               self._logAction = QtGui.QAction(None)
-               self._logAction.setText("Log")
-               self._logAction.setShortcut(QtGui.QKeySequence("CTRL+l"))
-               self._logAction.triggered.connect(self._on_log)
-
-               self._quitAction = QtGui.QAction(None)
-               self._quitAction.setText("Quit")
-               self._quitAction.setShortcut(QtGui.QKeySequence("CTRL+q"))
-               self._quitAction.triggered.connect(self._on_quit)
-
-               self._app.lastWindowClosed.connect(self._on_app_quit)
-               self._mainWindow = MainWindow(None, self)
-               self._mainWindow.window.destroyed.connect(self._on_child_close)
-
-               self.load_settings()
+               try:
+                       import alarm_handler
+                       if alarm_handler.AlarmHandler is not alarm_handler._NoneAlarmHandler:
+                               self._alarmHandler = alarm_handler.AlarmHandler()
+                       else:
+                               self._alarmHandler = None
+               except (ImportError, OSError):
+                       self._alarmHandler = None
+               except Exception:
+                       _moduleLogger.exception("Notification failure")
+                       self._alarmHandler = None
+               if self._alarmHandler is None:
+                       _moduleLogger.info("No notification support")
 
-               self._mainWindow.show()
-               self._idleDelay = QtCore.QTimer()
-               self._idleDelay.setSingleShot(True)
-               self._idleDelay.setInterval(0)
-               self._idleDelay.timeout.connect(lambda: self._mainWindow.start())
-               self._idleDelay.start()
+               qwrappers.ApplicationWrapper.__init__(self, app, constants)
 
        def load_settings(self):
                try:
@@ -87,14 +96,16 @@ class Dialcentral(object):
 
                blobs = "", ""
                isFullscreen = False
+               isPortrait = qui_utils.screen_orientation() == QtCore.Qt.Vertical
                tabIndex = 0
                try:
-                       blobs = (
+                       blobs = [
                                config.get(constants.__pretty_app_name__, "bin_blob_%i" % i)
                                for i in xrange(len(self._mainWindow.get_default_credentials()))
-                       )
+                       ]
                        isFullscreen = config.getboolean(constants.__pretty_app_name__, "fullscreen")
                        tabIndex = config.getint(constants.__pretty_app_name__, "tab")
+                       isPortrait = config.getboolean(constants.__pretty_app_name__, "portrait")
                except ConfigParser.NoOptionError, e:
                        _moduleLogger.info(
                                "Settings file %s is missing option %s" % (
@@ -109,10 +120,31 @@ class Dialcentral(object):
                                        e.section,
                                ),
                        )
-                       return
                except Exception:
                        _moduleLogger.exception("Unknown loading error")
-                       return
+
+               if self._alarmHandler is not None:
+                       try:
+                               self._alarmHandler.load_settings(config, "alarm")
+                               self.notifyOnMissed = config.getboolean("2 - Account Info", "notifyOnMissed")
+                               self.notifyOnVoicemail = config.getboolean("2 - Account Info", "notifyOnVoicemail")
+                               self.notifyOnSms = config.getboolean("2 - Account Info", "notifyOnSms")
+                       except ConfigParser.NoOptionError, e:
+                               _moduleLogger.info(
+                                       "Settings file %s is missing option %s" % (
+                                               constants._user_settings_,
+                                               e.option,
+                                       ),
+                               )
+                       except ConfigParser.NoSectionError, e:
+                               _moduleLogger.info(
+                                       "Settings file %s is missing section %s" % (
+                                               constants._user_settings_,
+                                               e.section,
+                                       ),
+                               )
+                       except Exception:
+                               _moduleLogger.exception("Unknown loading error")
 
                creds = (
                        base64.b64decode(blob)
@@ -120,6 +152,7 @@ class Dialcentral(object):
                )
                self._mainWindow.set_default_credentials(*creds)
                self._fullscreenAction.setChecked(isFullscreen)
+               self._orientationAction.setChecked(isPortrait)
                self._mainWindow.set_current_tab(tabIndex)
                self._mainWindow.load_settings(config)
 
@@ -130,10 +163,19 @@ class Dialcentral(object):
                config.add_section(constants.__pretty_app_name__)
                config.set(constants.__pretty_app_name__, "tab", str(self._mainWindow.get_current_tab()))
                config.set(constants.__pretty_app_name__, "fullscreen", str(self._fullscreenAction.isChecked()))
+               config.set(constants.__pretty_app_name__, "portrait", str(self._orientationAction.isChecked()))
                for i, value in enumerate(self._mainWindow.get_default_credentials()):
                        blob = base64.b64encode(value)
                        config.set(constants.__pretty_app_name__, "bin_blob_%i" % i, blob)
 
+               if self._alarmHandler is not None:
+                       config.add_section("alarm")
+                       self._alarmHandler.save_settings(config, "alarm")
+               config.add_section("2 - Account Info")
+               config.set("2 - Account Info", "notifyOnMissed", repr(self.notifyOnMissed))
+               config.set("2 - Account Info", "notifyOnVoicemail", repr(self.notifyOnVoicemail))
+               config.set("2 - Account Info", "notifyOnSms", repr(self.notifyOnSms))
+
                self._mainWindow.save_settings(config)
 
                with open(constants._user_settings_, "wb") as configFile:
@@ -151,65 +193,46 @@ class Dialcentral(object):
                else:
                        return None
 
+       def get_resource(self, name):
+               if self._dataPath is None:
+                       for path in self._DATA_PATHS:
+                               if os.path.exists(os.path.join(path, name)):
+                                       self._dataPath = path
+                                       break
+               if self._dataPath is not None:
+                       return os.path.join(self._dataPath, name)
+               else:
+                       return None
+
+       def _close_windows(self):
+               qwrappers.ApplicationWrapper._close_windows(self)
+               if self._aboutDialog  is not None:
+                       self._aboutDialog.close()
+
        @property
        def fsContactsPath(self):
                return os.path.join(constants._data_path_, "contacts")
 
        @property
-       def fullscreenAction(self):
-               return self._fullscreenAction
+       def alarmHandler(self):
+               return self._alarmHandler
 
        @property
-       def logAction(self):
-               return self._logAction
-
-       @property
-       def quitAction(self):
-               return self._quitAction
-
-       def _close_windows(self):
-               if self._mainWindow is not None:
-                       self.save_settings()
-                       self._mainWindow.window.destroyed.disconnect(self._on_child_close)
-                       self._mainWindow.close()
-                       self._mainWindow = None
+       def ledHandler(self):
+               return self._ledHandler
 
-       @QtCore.pyqtSlot()
-       @QtCore.pyqtSlot(bool)
-       @misc_utils.log_exception(_moduleLogger)
-       def _on_app_quit(self, checked = False):
-               if self._mainWindow is not None:
-                       self.save_settings()
-                       self._mainWindow.destroy()
-
-       @QtCore.pyqtSlot(QtCore.QObject)
-       @misc_utils.log_exception(_moduleLogger)
-       def _on_child_close(self, obj = None):
-               if self._mainWindow is not None:
-                       self.save_settings()
-                       self._mainWindow = None
+       def _new_main_window(self):
+               return MainWindow(None, self)
 
        @QtCore.pyqtSlot()
        @QtCore.pyqtSlot(bool)
        @misc_utils.log_exception(_moduleLogger)
-       def _on_toggle_fullscreen(self, checked = False):
-               for window in self._walk_children():
-                       window.set_fullscreen(checked)
-
-       @QtCore.pyqtSlot()
-       @QtCore.pyqtSlot(bool)
-       @misc_utils.log_exception(_moduleLogger)
-       def _on_log(self, checked = False):
-               with open(constants._user_logpath_, "r") as f:
-                       logLines = f.xreadlines()
-                       log = "".join(logLines)
-                       self._clipboard.setText(log)
-
-       @QtCore.pyqtSlot()
-       @QtCore.pyqtSlot(bool)
-       @misc_utils.log_exception(_moduleLogger)
-       def _on_quit(self, checked = False):
-               self._close_windows()
+       def _on_about(self, checked = True):
+               with qui_utils.notify_error(self._errorLog):
+                       if self._aboutDialog is None:
+                               import dialogs
+                               self._aboutDialog = dialogs.AboutDialog(self)
+                       response = self._aboutDialog.run(self._mainWindow.window)
 
 
 class DelayedWidget(object):
@@ -246,6 +269,10 @@ class DelayedWidget(object):
                else:
                        self._child.disable()
 
+       @property
+       def child(self):
+               return self._child
+
        def enable(self):
                self._isEnabled = True
                if self._child is not None:
@@ -282,7 +309,7 @@ def _tab_factory(tab, app, session, errorLog):
        return gv_views.__dict__[tab](app, session, errorLog)
 
 
-class MainWindow(object):
+class MainWindow(qwrappers.WindowWrapper):
 
        KEYPAD_TAB = 0
        RECENT_TAB = 1
@@ -324,16 +351,16 @@ class MainWindow(object):
        assert len(_TAB_SETTINGS_NAMES) == MAX_TABS
 
        def __init__(self, parent, app):
-               self._app = app
-
-               self._errorLog = qui_utils.QErrorLog()
-               self._errorDisplay = qui_utils.ErrorDisplay(self._errorLog)
+               qwrappers.WindowWrapper.__init__(self, parent, app)
+               self._window.setWindowTitle("%s" % constants.__pretty_app_name__)
+               self._errorLog = self._app.errorLog
 
                self._session = session.Session(self._errorLog, constants._data_path_)
                self._session.error.connect(self._on_session_error)
                self._session.loggedIn.connect(self._on_login)
                self._session.loggedOut.connect(self._on_logout)
                self._session.draft.recipientsChanged.connect(self._on_recipients_changed)
+               self._session.newMessages.connect(self._on_new_message_alert)
                self._defaultCredentials = "", ""
                self._curentCredentials = "", ""
                self._currentTab = 0
@@ -341,7 +368,6 @@ class MainWindow(object):
                self._credentialsDialog = None
                self._smsEntryDialog = None
                self._accountDialog = None
-               self._aboutDialog = None
 
                self._tabsContents = [
                        DelayedWidget(self._app, self._TAB_SETTINGS_NAMES[i])
@@ -355,37 +381,30 @@ class MainWindow(object):
                        self._tabWidget.setTabPosition(QtGui.QTabWidget.South)
                else:
                        self._tabWidget.setTabPosition(QtGui.QTabWidget.West)
+               defaultTabIconSize = self._tabWidget.iconSize()
+               defaultTabIconWidth, defaultTabIconHeight = defaultTabIconSize.width(), defaultTabIconSize.height()
                for tabIndex, (tabTitle, tabIcon) in enumerate(
                        zip(self._TAB_TITLES, self._TAB_ICONS)
                ):
-                       if constants.IS_MAEMO:
-                               icon = self._app.get_icon(tabIcon)
-                               if icon is None:
-                                       self._tabWidget.addTab(self._tabsContents[tabIndex].toplevel, tabTitle)
-                               else:
-                                       self._tabWidget.addTab(self._tabsContents[tabIndex].toplevel, icon, "")
+                       icon = self._app.get_icon(tabIcon)
+                       if constants.IS_MAEMO and icon is not None:
+                               tabTitle = ""
+
+                       if icon is None:
+                               self._tabWidget.addTab(self._tabsContents[tabIndex].toplevel, tabTitle)
                        else:
-                               icon = self._app.get_icon(tabIcon)
+                               iconSize = icon.availableSizes()[0]
+                               defaultTabIconWidth = max(defaultTabIconWidth, iconSize.width())
+                               defaultTabIconHeight = max(defaultTabIconHeight, iconSize.height())
                                self._tabWidget.addTab(self._tabsContents[tabIndex].toplevel, icon, tabTitle)
+               defaultTabIconWidth = max(defaultTabIconWidth, 32)
+               defaultTabIconHeight = max(defaultTabIconHeight, 32)
+               self._tabWidget.setIconSize(QtCore.QSize(defaultTabIconWidth, defaultTabIconHeight))
                self._tabWidget.currentChanged.connect(self._on_tab_changed)
                self._tabWidget.setContentsMargins(0, 0, 0, 0)
 
-               self._layout = QtGui.QVBoxLayout()
-               self._layout.setContentsMargins(0, 0, 0, 0)
-               self._layout.addWidget(self._errorDisplay.toplevel)
                self._layout.addWidget(self._tabWidget)
 
-               centralWidget = QtGui.QWidget()
-               centralWidget.setLayout(self._layout)
-               centralWidget.setContentsMargins(0, 0, 0, 0)
-
-               self._window = QtGui.QMainWindow(parent)
-               self._window.setAttribute(QtCore.Qt.WA_DeleteOnClose, True)
-               qui_utils.set_autorient(self._window, True)
-               qui_utils.set_stackable(self._window, True)
-               self._window.setWindowTitle("%s" % constants.__pretty_app_name__)
-               self._window.setCentralWidget(centralWidget)
-
                self._loginTabAction = QtGui.QAction(None)
                self._loginTabAction.setText("Login")
                self._loginTabAction.triggered.connect(self._on_login_requested)
@@ -403,51 +422,18 @@ class MainWindow(object):
                self._refreshTabAction.setShortcut(QtGui.QKeySequence("CTRL+r"))
                self._refreshTabAction.triggered.connect(self._on_refresh)
 
-               self._aboutAction = QtGui.QAction(None)
-               self._aboutAction.setText("About")
-               self._aboutAction.triggered.connect(self._on_about)
-
-               self._closeWindowAction = QtGui.QAction(None)
-               self._closeWindowAction.setText("Close")
-               self._closeWindowAction.setShortcut(QtGui.QKeySequence("CTRL+w"))
-               self._closeWindowAction.triggered.connect(self._on_close_window)
+               fileMenu = self._window.menuBar().addMenu("&File")
+               fileMenu.addAction(self._loginTabAction)
+               fileMenu.addAction(self._refreshTabAction)
 
-               if constants.IS_MAEMO:
-                       fileMenu = self._window.menuBar().addMenu("&File")
-                       fileMenu.addAction(self._loginTabAction)
-                       fileMenu.addAction(self._refreshTabAction)
-
-                       toolsMenu = self._window.menuBar().addMenu("&Tools")
-                       toolsMenu.addAction(self._accountTabAction)
-                       toolsMenu.addAction(self._importTabAction)
-                       toolsMenu.addAction(self._aboutAction)
-
-                       self._window.addAction(self._closeWindowAction)
-                       self._window.addAction(self._app.quitAction)
-                       self._window.addAction(self._app.fullscreenAction)
-               else:
-                       fileMenu = self._window.menuBar().addMenu("&File")
-                       fileMenu.addAction(self._loginTabAction)
-                       fileMenu.addAction(self._refreshTabAction)
-                       fileMenu.addAction(self._closeWindowAction)
-                       fileMenu.addAction(self._app.quitAction)
-
-                       viewMenu = self._window.menuBar().addMenu("&View")
-                       viewMenu.addAction(self._app.fullscreenAction)
-
-                       toolsMenu = self._window.menuBar().addMenu("&Tools")
-                       toolsMenu.addAction(self._accountTabAction)
-                       toolsMenu.addAction(self._importTabAction)
-                       toolsMenu.addAction(self._aboutAction)
-
-               self._window.addAction(self._app.logAction)
+               toolsMenu = self._window.menuBar().addMenu("&Tools")
+               toolsMenu.addAction(self._accountTabAction)
+               toolsMenu.addAction(self._importTabAction)
+               toolsMenu.addAction(self._app.aboutAction)
 
                self._initialize_tab(self._tabWidget.currentIndex())
                self.set_fullscreen(self._app.fullscreenAction.isChecked())
-
-       @property
-       def window(self):
-               return self._window
+               self.set_orientation(self._app.orientationAction.isChecked())
 
        def set_default_credentials(self, username, password):
                self._defaultCredentials = username, password
@@ -456,16 +442,13 @@ class MainWindow(object):
                return self._defaultCredentials
 
        def walk_children(self):
-               return (diag for diag in (
-                       self._credentialsDialog,
-                       self._smsEntryDialog,
-                       self._accountDialog,
-                       self._aboutDialog,
-                       )
-                       if diag is not None
-               )
+               if self._smsEntryDialog is not None:
+                       return (self._smsEntryDialog, )
+               else:
+                       return ()
 
        def start(self):
+               qwrappers.WindowWrapper.start(self)
                assert self._session.state == self._session.LOGGEDOUT_STATE, "Initialization messed up"
                if self._defaultCredentials != ("", ""):
                        username, password = self._defaultCredentials[0], self._defaultCredentials[1]
@@ -475,12 +458,20 @@ class MainWindow(object):
                        self._prompt_for_login()
 
        def close(self):
+               for diag in (
+                       self._credentialsDialog,
+                       self._accountDialog,
+               ):
+                       if diag is not None:
+                               diag.close()
                for child in self.walk_children():
                        child.window.destroyed.disconnect(self._on_child_close)
+                       child.window.closed.disconnect(self._on_child_close)
                        child.close()
                self._window.close()
 
        def destroy(self):
+               qwrappers.WindowWrapper.destroy(self)
                if self._session.state != self._session.LOGGEDOUT_STATE:
                        self._session.logout()
 
@@ -529,38 +520,30 @@ class MainWindow(object):
                        for settingName, settingValue in tabSettings.iteritems():
                                config.set(sectionName, settingName, settingValue)
 
-       def show(self):
-               self._window.show()
-               for child in self.walk_children():
-                       child.show()
-
-       def hide(self):
-               for child in self.walk_children():
-                       child.hide()
-               self._window.hide()
-
-       def set_fullscreen(self, isFullscreen):
-               if isFullscreen:
-                       self._window.showFullScreen()
+       def set_orientation(self, isPortrait):
+               qwrappers.WindowWrapper.set_orientation(self, isPortrait)
+               if isPortrait:
+                       self._tabWidget.setTabPosition(QtGui.QTabWidget.South)
                else:
-                       self._window.showNormal()
-               for child in self.walk_children():
-                       child.set_fullscreen(isFullscreen)
+                       self._tabWidget.setTabPosition(QtGui.QTabWidget.West)
 
        def _initialize_tab(self, index):
                assert index < self.MAX_TABS, "Invalid tab"
                if not self._tabsContents[index].has_child():
                        tab = self._TAB_CLASS[index](self._app, self._session, self._errorLog)
                        self._tabsContents[index].set_child(tab)
-                       self._tabsContents[index].refresh(force=False)
+               self._tabsContents[index].refresh(force=False)
 
        def _prompt_for_login(self):
                if self._credentialsDialog is None:
                        import dialogs
                        self._credentialsDialog = dialogs.CredentialsDialog(self._app)
-               username, password = self._credentialsDialog.run(
+               credentials = self._credentialsDialog.run(
                        self._defaultCredentials[0], self._defaultCredentials[1], self.window
                )
+               if credentials is None:
+                       return
+               username, password = credentials
                self._curentCredentials = username, password
                self._session.login(username, password)
 
@@ -568,22 +551,49 @@ class MainWindow(object):
                if self._accountDialog is None:
                        import dialogs
                        self._accountDialog = dialogs.AccountDialog(self._app)
+                       if self._app.alarmHandler is None:
+                               self._accountDialog.setIfNotificationsSupported(False)
+               if self._app.alarmHandler is not None:
+                       self._accountDialog.notifications = self._app.alarmHandler.isEnabled
+                       self._accountDialog.notificationTime = self._app.alarmHandler.recurrence
+                       self._accountDialog.notifyOnMissed = self._app.notifyOnMissed
+                       self._accountDialog.notifyOnVoicemail = self._app.notifyOnVoicemail
+                       self._accountDialog.notifyOnSms = self._app.notifyOnSms
                self._accountDialog.set_callbacks(
                        self._session.get_callback_numbers(), self._session.get_callback_number()
                )
-               self._accountDialog.accountNumber = self._session.get_account_number()
-               response = self._accountDialog.run()
+               accountNumberToDisplay = self._session.get_account_number()
+               if not accountNumberToDisplay:
+                       accountNumberToDisplay = "Not Available (%s)" % self._session.state
+               self._accountDialog.set_account_number(accountNumberToDisplay)
+               response = self._accountDialog.run(self.window)
                if response == QtGui.QDialog.Accepted:
                        if self._accountDialog.doClear:
                                self._session.logout_and_clear()
+                               self._defaultCredentials = "", ""
+                               self._curentCredentials = "", ""
+                               for tab in self._tabsContents:
+                                       tab.disable()
                        else:
                                callbackNumber = self._accountDialog.selectedCallback
                                self._session.set_callback_number(callbackNumber)
+                       if self._app.alarmHandler is not None:
+                               self._app.alarmHandler.apply_settings(self._accountDialog.notifications, self._accountDialog.notificationTime)
+                               self._app.notifyOnMissed = self._accountDialog.notifyOnMissed
+                               self._app.notifyOnVoicemail = self._accountDialog.notifyOnVoicemail
+                               self._app.notifyOnSms = self._accountDialog.notifyOnSms
+                               self._app.save_settings()
                elif response == QtGui.QDialog.Rejected:
                        _moduleLogger.info("Cancelled")
                else:
                        _moduleLogger.info("Unknown response")
 
+       @QtCore.pyqtSlot()
+       @misc_utils.log_exception(_moduleLogger)
+       def _on_new_message_alert(self):
+               with qui_utils.notify_error(self._errorLog):
+                       self._errorLog.push_message("New messages available")
+
        @QtCore.pyqtSlot(str)
        @misc_utils.log_exception(_moduleLogger)
        def _on_session_error(self, message):
@@ -603,6 +613,7 @@ class MainWindow(object):
 
                        for tab in self._tabsContents:
                                tab.enable()
+                       self._initialize_tab(self._currentTab)
 
        @QtCore.pyqtSlot()
        @misc_utils.log_exception(_moduleLogger)
@@ -621,6 +632,13 @@ class MainWindow(object):
                        if self._smsEntryDialog is None:
                                import dialogs
                                self._smsEntryDialog = dialogs.SMSEntryWindow(self.window, self._app, self._session, self._errorLog)
+                               self._smsEntryDialog.window.destroyed.connect(self._on_child_close)
+                               self._smsEntryDialog.window.closed.connect(self._on_child_close)
+                               self._smsEntryDialog.window.show()
+
+       @misc_utils.log_exception(_moduleLogger)
+       def _on_child_close(self, obj = None):
+               self._smsEntryDialog = None
 
        @QtCore.pyqtSlot()
        @QtCore.pyqtSlot(bool)
@@ -649,34 +667,22 @@ class MainWindow(object):
        def _on_import(self, checked = True):
                with qui_utils.notify_error(self._errorLog):
                        csvName = QtGui.QFileDialog.getOpenFileName(self._window, caption="Import", filter="CSV Files (*.csv)")
+                       csvName = unicode(csvName)
                        if not csvName:
                                return
                        import shutil
                        shutil.copy2(csvName, self._app.fsContactsPath)
-                       self._tabsContents[self.CONTACTS_TAB].update_addressbooks()
+                       if self._tabsContents[self.CONTACTS_TAB].has_child:
+                               self._tabsContents[self.CONTACTS_TAB].child.update_addressbooks()
 
        @QtCore.pyqtSlot()
        @QtCore.pyqtSlot(bool)
        @misc_utils.log_exception(_moduleLogger)
        def _on_account(self, checked = True):
                with qui_utils.notify_error(self._errorLog):
+                       assert self._session.state == self._session.LOGGEDIN_STATE, "Must be logged in for settings"
                        self._show_account_dialog()
 
-       @QtCore.pyqtSlot()
-       @QtCore.pyqtSlot(bool)
-       def _on_about(self, checked = True):
-               with qui_utils.notify_error(self._errorLog):
-                       if self._aboutDialog is None:
-                               import dialogs
-                               self._aboutDialog = dialogs.AboutDialog(self._app)
-                       response = self._aboutDialog.run()
-
-       @QtCore.pyqtSlot()
-       @QtCore.pyqtSlot(bool)
-       @misc_utils.log_exception(_moduleLogger)
-       def _on_close_window(self, checked = True):
-               self.close()
-
 
 def run():
        app = QtGui.QApplication([])