Tweaking handling of empty callbacks to give the user a hint

git-svn-id: file:///svnroot/gc-dialer/trunk@455 c39d3808-3fe2-4d86-a59f-b7f623ee9f21

diff --git a/src/dc_glade.py b/src/dc_glade.py
index c976cdb..e75c4dc 100755 (executable)
--- a/src/dc_glade.py
+++ b/src/dc_glade.py
@@ -408,6 +408,9 @@ class Dialcentral(object):
                                credentials = self._credentialsDialog.request_credentials(
                                        defaultCredentials = self._credentials
                                )
+                               if not self._phoneBackends[tmpServiceId].get_callback_number():
+                                       # subtle reminder to the users to configure things
+                                       self._notebook.set_current_page(self.ACCOUNT_TAB)
                        username, password = credentials
                        loggedIn = self._phoneBackends[tmpServiceId].login(username, password)
 

diff --git a/src/gv_views.py b/src/gv_views.py
index df7b403..5ee2033 100644 (file)
--- a/src/gv_views.py
+++ b/src/gv_views.py
@@ -17,6 +17,10 @@ Lesser General Public License for more details.
 You should have received a copy of the GNU Lesser General Public
 License along with this library; if not, write to the Free Software
 Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+@todo Touch selector for notification time
+@todo Test if hildonize should do stackables by default
+@todo Alternate UI for dialogs
 """
 
 from __future__ import with_statement
@@ -748,7 +752,7 @@ class AccountInfo(object):
 
        def _set_callback_number(self, number):
                try:
-                       if not self._backend.is_valid_syntax(number):
+                       if not self._backend.is_valid_syntax(number) and 0 < len(number):
                                self._errorDisplay.push_message("%s is not a valid callback number" % number)
                        elif number == self._backend.get_callback_number():
                                logging.warning(