Removed gnome/ directory Added empty gtk/ directory Fixed build of tests
Modest executes again in GNOME :-) pmo-trunk-r7036
GNOME version compiles again. It does not link yet though, because there are some undefined functions pmo-trunk-r7031
* src/gnome/modest-account-assistant.[ch]: * Now it inherits from ModestWizardDialog * Save account after edition. * Finish implementation of controls. * Layout fixes. * src/gnome/modest-account-view-window.c: * Use same confirmation dialog for removing accounts we use in maemo. * Make dialog really close when finished. * Show account wizard on pressing new account. * Properly start dimming of account view. * src/gnome/modest-msg-edit-window.c: * Fix build. * src/gnome/modest-platform.c: * Use new account assistant. * Use new account settings dialog. * Some build fixes. * src/gnome/modest-account-settings-dialog.c: * Remove unused private area. * Remove scrolled windows in dialog tabs (to avoid the strange grey area surronding fields). * Dim fields that can break message cache. * src/gnome/modest-main-window.c: * Save messages paned position. * src/gnome/modest-gnome-global-settings-dialog.c: * Remove separator * Some layout fixes. * Now we retrieve configuration from modest conf, and we also store it back properly. * Now we properly use the updatable fields in common global settings dialog private area. * Now we set the dialog action buttons using gnome stocks. * src/widgets/modest-header-view.c: * Cell renderers fixed size only used in maemo platform. * Moved src/maemo/easysetup/modest-wizard-dialog.[ch] to src/widgets. * Specific maemo and gnome code (in gnome we use stocks buttons). * src/widgets/modest-global-settings-dialog.c: * Now dialog buttons are created in specific implementations. This way we get maemo buttons or gnome stock buttons depending on the platform. * src/widgets/Makefile.am, src/maemo/easysetup/Makefile.am: * Now wizard dialog is in widgets directory. * src/modest-init.c: * Added default value for msg paned. * src/maemo/modest-maemo-global-settings-dialog.c: * Now we create the action buttons in platform implementations. * src/maemo/easysetup/modest-easysetup-wizard-dialog.h: * Use the new path for wizard dialog include. pmo-trunk-r4637
This change will break temporally the wizard storage (was broken anyway). * src/modest-protocol-info.[ch]: * Add method to retrieve the pair list of stores supported. * src/gnome/modest-account-assistant.c: * More work on HIG. Implemented new incoming server details. pmo-trunk-r4122
* src/gnome/modest-account-view-window.c: * Now it's a GtkDialog. Fits better with common and maemo code. * Close button is now implemented as an action button of the dialog. * Added scrolled window to accounts tree view. It also provides a border (better HIG compliance). * Other layout changes to fit better HIG. * Use translation strings from modest.po. * src/gnome/modest-main-window-ui.h * Add more maemo standard menu actions. * src/gnome/modest-msg-edit-window.c: * Some changes to improve HIG compliance. * Scrolled window for message. * Not it's gtkhtml based. * It's a WIP, no menus working and a lot of issues not tested yet. But it's a preliminar work for the future gnome editor. * src/gnome/modest-platform.c: * Now folder view does not get headers. * src/gnome/modest-main-window.c: * Added ui dimming rules support. * Added menu option and shortcut for toggling folders view. * Implemented style methods. * Now default view for header view is compact view instead of columns view. * Set toolbar better to set important hint. * Added translation domain for ui manager. * src/gnome/modest-icon-names.h: * Stock for split view. * src/gnome/ui/modest-msg-view-window-ui.xml: * More maemo menus also in modest. * src/gnome/ui/modest-main-window-ui.xml: * More maemo menus also in modest. * src/gnome/modest-msg-view-window.c: * Adaptation to common maemo actions. * Changed layout to fit better with HIG. * Support for ui dimming rules. * Misc changes for fixing build. * src/gnome/modest-account-assistant.c: * WIP. Moving to HIG and adding missing functionality. * Use maemo translation strings where it's ok. * Fix some erros in GtkAssistant usage. * src/modest-init.c: * Now split view is common to gnome and maemo. pmo-trunk-r4120
This patch includes a lot of work to refactor and reorganize the account settings dialogs. The main improvement is the implementation of ModestAccountSettings and ModestServerAccountSettings. These classes represent the settings of accounts and server accounts in memory, avoiding storage in ModestConf for temporal or non persistent account settings. * src/modest-protocol-info.[ch]: * New method modest_protocol_info_get_connection_protocol, that obtains a ModestConnectionProtocol from a string. * src/modest-server-account-settings.[ch]: * New class, that represents server settings (common for store and transport server settings. It's only a memory storage. Persistence is managed in ModestAccountMgr. * src/modest-account-settings.[ch]: * New class, that represents an account. It contains two ModestServerStoreSettings for store and transport accounts associated with the account. It represents all the common account information (display name, user fullname, email address, etc). * src/modest-account-mgr-helpers.[ch]: * Added internal method null_means_empty for avoiding setting NULL to values we shouldn't put NULL. * (modest_account_mgr_get_store_protocol): use the new settings api. * (get_secure_auth_for_conf_string): removed, as it's also in ModestProtocolInfo. Also use modest_protocol_info_get_auth_protocol_name instead of the big if. * (get_security_for_conf_string): removed, as it's also in ModestProtocolInfo. Also removed if. * Replaced modest_account_mgr_get_server_account_data with modest_account_mgr_load_server_settings. The method creates an instance of ModestServerAccountSettings from a ModestConf account. * Removed free method for server account data. * Added method modest_account_mgr_save_server_settings. It stores a ModestServerAccountSettings in ModestConf. * Replaced modest_account_mgr_get_account_data with modest_account_mgr_load_account_settings. This fills a ModestAccountSettings instance with information, and also obtains the store and transport server settings. Also removed old ModestAccountData and ModestServerAccountData structs. * New method modest_account_mgr_save_account_settings, that saves an account to ModestConf. It's more intended for updating an existing accoung. * Methods get_retrieve_type_name and get_retrieve_type, to convert from string representation of retrieve types into modest ModestAccountRetrieveType and viceversa. * src/modest-account-mgr.[ch]: * New (modest_account_mgr_add_account_from_settings): creates a new account in ModestConf, and emits the signal to register it in the list of available accounts. * Usage of ModestAccountRetrieveType instead of conf strings. * Use ModestAccountSettings and ModestServerAccountSettings instead of deprecated ModestAccountData and ModestServerAccountData. * src/modest-tny-account.c: * Use ModestAccountSettings and ModestServerAccountSettings. * src/modest-tny-account-store.c: * Use ModestAccountSettings. * src/modest-mail-operation.c: * Use ModestAccountRetrieveType instead of strings. * src/modest-widget-memory.c: * Use ModestAccountSettings. * src/widgets/modest-retrieve-combo-box.[ch]: * Use ModestAccountRetrieveType instead of strings. * src/widgets/modest-account-view.c: * Use ModestServerAccountSettings and ModestAccountSettings. * src/widgets/modest-header-view.c: * Small change, if model is NULL, expose returns silently. * src/modest-ui-actions.c: * Use ModestAccountSettings api. * Make some specific maemo code be now usable again also in gnome port. * src/maemo/modest-connection-specific-smtp-window.c: * User ModestServerAccountSettings api. * src/maemo/easysetup/modest-easysetup-wizard.[ch]: * Big work here to adapt to ModestAccountSettings. As a benefit, now we use it to pass the settings to ModestAccountSettingsDialog (advanced settings). We only save to the account manager on finishing and approving changes. * Moved code to create the account to ModestAccountMgr, and added code to fill the ModestAccountSettings. * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: * New method to set the provider to others. * src/maemo/modest-account-view-window.c: * Use ModestAccountSettings. * src/maemo/modest-account-settings-dialog.c: * Use ModestAccountSettings. * Move storage and fetch code from ModestConf to account manager. * Added code to fill and retrieve information in ModestAccountSettings and ModestServerAccountSettings. * Now it works with ModestAccountSettings, instead of storing directly to ModestConf. * src/maemo/modest-main-window.c: * Use ModestAccountSettings for management of accounts menu options. * src/maemo/modest-connection-specific-smtp-edit-window.c: * Use ModestServerAccountSettings. * src/modes-platform.h, src/maemo/modest-plaform.c, src/gnome/modest-platform.c: * Provide methods to retrieve an instance of the account settings dialog and the account settings wizard. * Provide valid implementation of some dialogs in gnome port. And some work for splitting modest-maemo-utils in modest-utils (for common usable methods) and modest-maemo-utils (specific maemo platform): * src/modest-utils.[ch]: * New set of methods, now available for all modest platforms. * Reworked many other objects, to use this split. * src/maemo/modest-maemo-utils.[ch]: * Moved a lot of methods to modest-utils. pmo-trunk-r3846
These changes are for reenabling build of gnome port. * src/modest-tny-account.[ch]: * New method modest_tny_folder_store_is_remote, coming from a specific maemo modest_platform method. As this does not have any platform specific code, we moved it to a common place. * Use hildon calls only in maemo. * src/modest-platform.h: * Removed method modest_platform_is_network_folderstore, replaced by modest_tny_folder_store_is_remote. * src/modest-tny-platform-factory.c: * As the private area does not have fields, commented it and its initialisation. * src/gnome/modest-main-window-ui.h: * Replaced modest_ui_actions_on_delete with modest_ui_actions_on_delete_message. * src/gnome/modest-account-view-window.c: * Update calls to new api of modest_account_mgr_remove_account. * src/gnome/modest-store-widget.[ch]: * Replaced ModestProtoList with ModestPairList. * Fixed a typo in return types. * src/gnome/modest-address-book.c: * Updated api. * src/gnome/modest-transport-widget.c: * Add auth_protos to the private struct. * src/gnome/modest-msg-edit-window.c: * Use ModestProtoList instead of ModestPairList * Remove references to a msg id. * Update api call to check_names method. * Added implementation of ..._get_child_widget method. * Added stub implementations of reset_modified, toggle_find_toolbar, add_part, redo, offer_attach_file, attach_file_one, set_draft, is_modified, get_clipboard_text, can_redo, can_undo and get_message_uid. * src/gnome/modest-platform.c: * Remove calls to non_implemented method (it does not exists now). * Now show_help method returns void. * Added new methods connect_and_perform, and connect_and_perform_if_network_account. These methods act as it's always connected. * Added stub implementation of remove_new_mail_notification, check_and_wait_for_account_is_online, run_certificate_confirmation_dialog, run_rename_folder_dialog, and show_addressboook. * src/gnome/modest-main-window.c: * Use new TnyMsgView interface based access to msg view. * Prevent a crash as now we initialize the dimming manager. * Added stub implementation for notify_send_receive_initied, send_receive_completed, transfer_mode_enabled, and on_msg_view_window_msg_changed. * src/gnome/modest-gnome-global-settings-dialog.c: * Update internal global settings dialog methods. * src/gnome/modest-icon-names.h: * Add pending icons. * src/gnome/modest-gnome-info-bar.c: * Update progress_change handler api. * src/gnome/modest-msg-view-window.c: * Use modest_ui_actions_on_delete_message instead of ..._on_delete. * Use the TnyMsgView api for accessing the message. * Implementation of modest_msg_view_window_get_header, modest_msg_view_window_get_folder_type. * Stub implementation of last_message_selected, first_message_selected, transfer_mode_enabled, on_transfer_mode, get_attachments, is_search_result and has_headers_model. * src/gnome/modest-account-assistant.c: * Update api calls. * src/widgets/modest-recpt-editor.c: * Protect specific hildon calls with ifdefs. * src/widgets/modest-window.c: * Add a pending include. * src/modest-init.c: * Add a missing gnome vfs include. * Update the stock icons in the list. * src/modest-ui-actions.c: * Remove common dependencies to connection specific smtp window dialog. * Remove all calls to hildon_banner. * Use the new modest_tny_folder_store_is_remote method. * src/maemo/modest-platform.c: * Removed method modest_platform_is_network_folderstore. * src/modest-search.[ch]: * Defined ModestFolderResult and ModestSearchHit here. We provide different structs for dbus. * src/modest-tny-account-store.c: * Use the account settings hash only in maemo. * src/Makefile.am: * Include dbus api only in maemo. * configure.ac: * New conditional for compiling dbus api (which depends on osso, and then, it's maemo speficic). * Makefile.am: * Only compile dbus client if enabled. pmo-trunk-r3810
* The "account-changed" signal is now properly managed in the ModestTnyAccountStore and in ModestTnyAccount, there were some errors in the handler that were actually preventing the account update to happen * Changed the signature of the method modest_tny_account_update_from_account * Added display_name_changed signal to notify changes in the display name of the accounts * ModestConf does not listen for key changes, all signal emissions related to changes in the configuration must be triggered by the account manager * Removed the ModestConf delayed notification system, we do not need it since we're not listening for chey changes there anymore * All the modest_account_mgr_(get/set)_(int/book/string/list) are now private methods and could not be used by third parties * Added a lot of getters and setters to the modest-account-mgr-helpers. We did that to ensure that nobody changes the configuration keys directly (because maybe we want to notify key changes) * Renamed old modest_server_account_get_xxx by modest_account_mgr_get_server_account_xxx * Renamed old modest_server_account_set_xxx by modest_account_mgr_set_server_account_xxx * FolderView now changes the display name of an account if it changes * AccountView now changes the display name of an account if it changes * Removed unused code here and there * Several aesthetic changes here and there * TODO: I realized that the account-settings dialog thinks that something has changed when you change it and then revert the change * TODO: detect in the account-settings dialog which changes should issue an "account-changed" signals and which ones not, for example a change in the display name should not force an account reload pmo-trunk-r3433
* gnome is currently broken; tell our users pmo-trunk-r2386
* cleanup the configuration system a bit: - don't have an overall 'hildon0' or 'hildon1' check, because this causes problems with sardine - check for ogs, hildon-help, hildon-notify etc. separately - turn on -Werr for *all* maemo builds pmo-trunk-r2383
2007-05-16 Murray Cumming <murrayc@murrayc.com> * src/modest-pair.h: Improve the documentation for modest_combo_box_new() to explain the memory management issue with the ID in the ModestPair. * src/gnome/modest-account-assistant.c: (add_receiving_page), (add_sending_page), (modest_account_assistant_finalize): * src/gnome/modest-gnome-global-settings-dialog.c: (create_updating_page), (create_composing_page): * src/gnome/modest-msg-edit-window.c: (get_transports), (init_window), (modest_msg_edit_window_finalize), (modest_msg_edit_window_get_msg_data): * src/gnome/modest-store-widget.c: (imap_pop_configuration): * src/gnome/modest-transport-widget.c: (modest_transport_widget_finalize), (smtp_configuration): * src/maemo/modest-maemo-global-settings-dialog.c: (create_updating_page), (create_composing_page): * src/maemo/modest-msg-edit-window.c: (get_transports), (init_window), (modest_msg_edit_window_finalize), (modest_msg_edit_window_get_msg_data), (modest_msg_edit_window_free_msg_data): * src/maemo/modest-store-widget.c: (imap_pop_configuration), (modest_store_widget_finalize): * src/maemo/modest-transport-widget.c: (modest_transport_widget_finalize), (smtp_configuration): * src/modest-main.c: (send_mail): * src/widgets/modest-combo-box.h: * src/widgets/modest-global-settings-dialog-priv.h: * src/widgets/modest-global-settings-dialog.c: (modest_global_settings_dialog_finalize): * src/widgets/modest-msg-edit-window.h: Whenever using modest_combo_box_new(), keep the ModestPairList alive as long as the combo box, to prevent use of freed memory for the ID. pmo-trunk-r1887
2007-05-15 Murray Cumming <murrayc@murrayc.com> * src/modest-protocol-info.c: * src/modest-protocol-info.h: Adde enum-specific get functions, instead of using a ModestProtocolType enum parameter. * src/gnome/modest-account-assistant.c: * src/gnome/modest-store-widget.c: * src/gnome/modest-store-widget.h: * src/gnome/modest-transport-widget.c: * src/gnome/modest-transport-widget.h: * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c: * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h: * src/maemo/easysetup/modest-easysetup-wizard.c: * src/maemo/modest-account-settings-dialog.c: * src/maemo/modest-account-settings-dialog.h: * src/maemo/modest-store-widget.c: * src/maemo/modest-store-widget.h: * src/maemo/modest-transport-widget.c: * src/maemo/modest-transport-widget.h: * src/modest-account-mgr-helpers.c: * src/modest-account-mgr-helpers.h: * src/modest-account-mgr.c: * src/modest-account-mgr.h: * src/modest-tny-account.c: * src/modest-tny-folder.c: * src/widgets/modest-account-view.c: * src/widgets/modest-retrieve-combo-box.c: * src/widgets/modest-retrieve-combo-box.h: * src/widgets/modest-secureauth-combo-box.c: * src/widgets/modest-serversecurity-combo-box.c: * src/widgets/modest-serversecurity-combo-box.h: * tests/check_account-mgr.c: Use the specific functions, and use the re-renamed enum values for GNOME too. pmo-trunk-r1874
2007-05-15 Murray Cumming <murrayc@murrayc.com> * src/modest-pair.h: * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(), so we can get the second based on the first. * src/maemo/modest-account-settings-dialog.h: * src/maemo/modest-account-settings-dialog.c: Added get_supported_secure_authentication_methods(), though it is mostly commented-out for now until the necessary API is committed to tinymail. (modest_account_settings_dialog_set_account_name), (save_configuration): Request the supported authentication methods from the server, so we can choose a working method. * src/modest-tny-account-store.h: * src/modest-tny-account-store.c: (modest_tny_account_store_get_session): Rename from tny_account_store_get_session(). pmo-trunk-r1872
2007-05-14 Murray Cumming <murrayc@murrayc.com> * src/modest-protocol-info.h: Split the ModestProtocol enum into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication. There was no need to have these unrelated values in one enum. * src/: many files: Adapted to changed enum. This makes the code a bit clearer, and the compiler could catch some errors. pmo-trunk-r1857
* compile fixes for gnome pmo-trunk-r1736
* big commit, mainly cleanups: - renamed gtk frontend into "gnome", which is more accurate - create "src/modest-platform.h" and platform-specific src/maemo/modest-platform.c and src/gtk/platform.c - get rid of all the #if-#else-stuff in src/, use the modest-platform instead - implemented modest_platform_get_file_icon_name, to get the icon name for some file or mime-type - move the menubar_to_menu to modest_maemo_utils_menubar_to_menu pmo-trunk-r875