* Renamed modest-easysetup-wizard by modest-easysetup-wizard-dialog because it was actually the object's name * Moved easysetup wizard dialog public attributes to the private structure pmo-trunk-r4244
This patch includes a lot of work to refactor and reorganize the account settings dialogs. The main improvement is the implementation of ModestAccountSettings and ModestServerAccountSettings. These classes represent the settings of accounts and server accounts in memory, avoiding storage in ModestConf for temporal or non persistent account settings. * src/modest-protocol-info.[ch]: * New method modest_protocol_info_get_connection_protocol, that obtains a ModestConnectionProtocol from a string. * src/modest-server-account-settings.[ch]: * New class, that represents server settings (common for store and transport server settings. It's only a memory storage. Persistence is managed in ModestAccountMgr. * src/modest-account-settings.[ch]: * New class, that represents an account. It contains two ModestServerStoreSettings for store and transport accounts associated with the account. It represents all the common account information (display name, user fullname, email address, etc). * src/modest-account-mgr-helpers.[ch]: * Added internal method null_means_empty for avoiding setting NULL to values we shouldn't put NULL. * (modest_account_mgr_get_store_protocol): use the new settings api. * (get_secure_auth_for_conf_string): removed, as it's also in ModestProtocolInfo. Also use modest_protocol_info_get_auth_protocol_name instead of the big if. * (get_security_for_conf_string): removed, as it's also in ModestProtocolInfo. Also removed if. * Replaced modest_account_mgr_get_server_account_data with modest_account_mgr_load_server_settings. The method creates an instance of ModestServerAccountSettings from a ModestConf account. * Removed free method for server account data. * Added method modest_account_mgr_save_server_settings. It stores a ModestServerAccountSettings in ModestConf. * Replaced modest_account_mgr_get_account_data with modest_account_mgr_load_account_settings. This fills a ModestAccountSettings instance with information, and also obtains the store and transport server settings. Also removed old ModestAccountData and ModestServerAccountData structs. * New method modest_account_mgr_save_account_settings, that saves an account to ModestConf. It's more intended for updating an existing accoung. * Methods get_retrieve_type_name and get_retrieve_type, to convert from string representation of retrieve types into modest ModestAccountRetrieveType and viceversa. * src/modest-account-mgr.[ch]: * New (modest_account_mgr_add_account_from_settings): creates a new account in ModestConf, and emits the signal to register it in the list of available accounts. * Usage of ModestAccountRetrieveType instead of conf strings. * Use ModestAccountSettings and ModestServerAccountSettings instead of deprecated ModestAccountData and ModestServerAccountData. * src/modest-tny-account.c: * Use ModestAccountSettings and ModestServerAccountSettings. * src/modest-tny-account-store.c: * Use ModestAccountSettings. * src/modest-mail-operation.c: * Use ModestAccountRetrieveType instead of strings. * src/modest-widget-memory.c: * Use ModestAccountSettings. * src/widgets/modest-retrieve-combo-box.[ch]: * Use ModestAccountRetrieveType instead of strings. * src/widgets/modest-account-view.c: * Use ModestServerAccountSettings and ModestAccountSettings. * src/widgets/modest-header-view.c: * Small change, if model is NULL, expose returns silently. * src/modest-ui-actions.c: * Use ModestAccountSettings api. * Make some specific maemo code be now usable again also in gnome port. * src/maemo/modest-connection-specific-smtp-window.c: * User ModestServerAccountSettings api. * src/maemo/easysetup/modest-easysetup-wizard.[ch]: * Big work here to adapt to ModestAccountSettings. As a benefit, now we use it to pass the settings to ModestAccountSettingsDialog (advanced settings). We only save to the account manager on finishing and approving changes. * Moved code to create the account to ModestAccountMgr, and added code to fill the ModestAccountSettings. * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: * New method to set the provider to others. * src/maemo/modest-account-view-window.c: * Use ModestAccountSettings. * src/maemo/modest-account-settings-dialog.c: * Use ModestAccountSettings. * Move storage and fetch code from ModestConf to account manager. * Added code to fill and retrieve information in ModestAccountSettings and ModestServerAccountSettings. * Now it works with ModestAccountSettings, instead of storing directly to ModestConf. * src/maemo/modest-main-window.c: * Use ModestAccountSettings for management of accounts menu options. * src/maemo/modest-connection-specific-smtp-edit-window.c: * Use ModestServerAccountSettings. * src/modes-platform.h, src/maemo/modest-plaform.c, src/gnome/modest-platform.c: * Provide methods to retrieve an instance of the account settings dialog and the account settings wizard. * Provide valid implementation of some dialogs in gnome port. And some work for splitting modest-maemo-utils in modest-utils (for common usable methods) and modest-maemo-utils (specific maemo platform): * src/modest-utils.[ch]: * New set of methods, now available for all modest platforms. * Reworked many other objects, to use this split. * src/maemo/modest-maemo-utils.[ch]: * Moved a lot of methods to modest-utils. pmo-trunk-r3846
When creating each page in the account setup wizard don't check whether the widgets that they contain already exist: they can't. Also, set them to NULL after destroying each page. pmo-trunk-r3818
* cleaner version of the patch to make sure no double account-setup-wizards are shown * fixes a critical G-Warning in modest-window-mgr * apparently also fixes: NB#66304 pmo-trunk-r3075
* automatically register the main window * make sure only one ModestEasySetupWizardDialog instance can be alive at any time, letting modest-easysetup-wizard.c keep track of that * if the we're asked for a new instance, present the old one instead Fixes: NB#66408, and all other cases where this could happen. pmo-trunk-r3061
2007-06-25 Johannes Schmid <johannes.schmid@openismus.com> * src/dbus_api/modest-dbus-callbacks.c: * src/maemo/easysetup/modest-easysetup-wizard.h: * src/maemo/easysetup/modest-wizard-dialog.c: (init): * src/maemo/modest-connection-specific-smtp-edit-window.c: (modest_connection_specific_smtp_edit_window_init): * src/maemo/modest-maemo-global-settings-dialog.c: (on_range_error): * src/maemo/modest-maemo-utils.c: (modest_maemo_utils_setup_images_filechooser): * src/maemo/modest-main-window.c: (create_details_widget): * src/maemo/modest-msg-edit-window.c: (modest_msg_edit_window_attach_file_noninteractive), (modest_msg_edit_window_color_button_change), (modest_msg_edit_window_set_zoom): * src/modest-mail-operation.c: (update_account_thread): * src/modest-tny-account-store.c: * src/modest-tny-account.c: * src/widgets/modest-global-settings-dialog.c: * src/widgets/modest-window.h: Fixed build on bora! pmo-trunk-r2391
* fix the (c) headers pmo-trunk-r1908
* src/modest-ui-actions.[ch]: * (..._on_delete) action simply closes the edit window, emitting a delete-event signal. * (..._on_close_window) also sends a delete-event. * (..._on_new_msg) adds the signature if there's one configured in the account. Also removed the "save to drafts" part just on creating the new message (fixes #NB55341, #NB55391). * (reply_forward_func) now gets the signature of the account. * (..._on_save_to_drafts). New action that saves an edited message as a draft. * src/modest-text-utils.[ch]: * (..._quote, ..._cite and ..._inline) now put the signature. * Added ..._convert_buffer_to_html. This way we can convert to html tags a subpart of a document (it does not add html headers). Also modified ..._convert_to_html to use this function. * Added ..._convert_to_html_body. It converts a string to an html that can be included inside a formatted html document. * src/maemo/modest-address-book.c: * (..._select_addresses): after selecting an address of a recipient editor through the select contacts dialog, focus is asigned to the ModestRecptEditor. * (select_email_addrs_for_contact): when the dialog is loaded, first address is selected by default. * src/maemo/modest-msg-edit-window.c: * Implemented dim rule: if focus is not in body or message format is plain text, font actions are dimmed. Also configured proper insensitive_press messages. * Implemented dim rule: if To: recipient field is empty, send action is dimmed. Also configured proper insensitive_press message. * Delete event handler. It shows a dialog for saving the mail as a draft if message is modified. * Fixed the html document parsing procedure, as it wasn't previously really parsed because the buffer length was not provided. * If the account setup specified that it should by default create plain text mails, it's used. Also radio menu option is updated properly. * Now we get correctly the focused widget. If "Select contacts" is selected, it adds contacts to the focused recipient list, or to To: field if no recipient list is focused. * If the To: field is empty on opening editor, focus goes to it. * Now the message stores a reference to the draft message used to create the mail. * Refactored the ..._select_contacts function to use the general "open_addressbook" function. * Added ..._is_modified and ..._reset_modified. It tells if the message was modified by the user. * src/maemo/ui/modest-msg-edit-window-ui.xml: * Added email menu options Send, Save to drafts, new message, delete. * Added close window and close all windows menu actions. * src/modest-formatter.[ch]: * Now the formatter adds the signature properly. * src/modest-mail-operation.[ch]: * Added ..._save_to_drafts operation. It creates a mail from editor and saves it to the active account drafts folder. * src/modest-defs.h: * Added configuration option for preferring formatted of plain text. * src/widgets/modest-recpt-view.[ch]: * Now button release event is processed after the default handler. * src/widgets/modest-recpt-editor.[ch]: * Completely new behavior for keyboard and mouse edition. Now only one address per line. Keyboard and mouse selection treat resolved addresses as a whole (you shouldn't be able to manipulate a part of resolved address). * Keyboard shortcut for adding addresses with the addressbook. * Better focus and cursor handling. * Now the widget does not use GTK_CAN_FOCUS. * (..._get_buffer): new API function to export the internal buffer. * (..._grab_focus): new function to make the textview grab the focus. * src/widgets/modest-scroll-text.[ch]: * Small fixes to calculation of the number of lines. Now it also makes the cursor visible. * src/widgets/modest-msg-edit-window-ui.h: * Added actions for "window close", "new message", "delete", "save to drafts", "all windows close" * src/modest-tny-msg.[ch]: * Support plain text quoted texts as input of msg editor. * Now (create_reply_forward_mail) takes the "prefer formatted" option. * Now it uses the logical id's for "Re:" and "Fwd:" strings. * Added signature support. * src/maemo/modest-main-window-ui.h: * Added a new action for new messages. It's used for showing a simple "New" menu option for creating new messages from the view (fixes #NB55368). pmo-trunk-r1720
* Added some missing includes * Added a "," that was causing a build problem * Added MSG-NOT404 confirmation note when moving messages pmo-trunk-r1707
* fixes for latest hildon version pmo-trunk-r1704
https://projects.maemo.org pmo-trunk-r1701
2007-04-19 Murray Cumming <murrayc@murrayc.com> * src/maemo/modest-address-book.c: Added include to avoid a warning. * po/en_GB.po: Added missing mcen_bd_emailsetup_close string, specified for EmailAccountsDialog in UI spec. * src/maemo/easysetup/modest-easysetup-wizard.c: * src/maemo/easysetup/modest-easysetup-wizard.h: * src/maemo/modest-account-settings-dialog.c: * src/maemo/modest-account-settings-dialog.h: Reuse a member window widget for the connection-specific SMTP server accounts, so we can tell it to create/save the accounts only if we actually save changes. * src/maemo/modest-connection-specific-smtp-edit-window.h: * src/maemo/modest-connection-specific-smtp-edit-window.c: (modest_connection_specific_smtp_edit_window_get_settings): Return a struct instance for temporarily remembering the entered data. * src/maemo/modest-connection-specific-smtp-window.h: * src/maemo/modest-connection-specific-smtp-window.c: (modest_connection_specific_smtp_window_finalize), (modest_connection_specific_smtp_window_fill_with_connections), (on_button_edit), (modest_connection_specific_smtp_window_save_server_accounts), (update_model_server_names): Do not actually save data until asked, when the caller calls modest_connection_specific_smtp_window_save_server_accounts(). (on_selection_changed), (modest_connection_specific_smtp_window_init): Disable the edit button when nothing is selected. * src/modest-account-mgr-helpers.c: * src/modest-account-mgr-helpers.h: Put modest_account_mgr_free_server_account_data() in the header now that I use the struct elsewhere. pmo-trunk-r1596
Committing so that svn lets me rename pmo-trunk-r1518
2007-04-03 Murray Cumming <murrayc@murrayc.com> * configure.ac: * src/Makefile.am: * src/maemo/Makefile.am: * src/maemo/easysetup/: Added files from the previously-exernal osso-modest-easysetup. * src/maemo/modest-main-window-ui.h: * src/modest-ui-actions.c: * src/modest-ui-actions.h: Added modest_ui_actions_on_new_account() as a signal handler for the New Account menu item. It shows the easysetup wizard. * po/en_GB.po: Added additional needed logical IDs and translations. Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc. Apparently ChangeLog is not used for some vague Nokia legal reasons. pmo-trunk-r1491
Added files from osso-modest-easysetup pmo-trunk-r1487