1 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/modest-connection-specific-smtp-window.c:
4 Fix UI specification problems with projects.meamo.org NB#60479
6 2007-07-04 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
9 clue when this has failed, because the error dialog is not always shown
10 (at least in earlier version).
12 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
13 GError message, because the generic error dialog is not helpful.
15 'This message is not currently available (can't let a new connection go online)'
16 when trying to open an IMAP message.
18 (_modest_ui_actions_open): Offer a connection when some messages would
19 have to be downloaded and we are offline.
21 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
23 * src/widgets/modest-folder-view.c:
24 Don't check for MERGE type anymore as we use the correct type
26 NOTE: For the last two changes you need to update your tinymail copy
27 because of API changes!
29 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
31 * src/modest-tny-local-folders-account.c:
32 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
33 (see projects.maemo.org NB#61580)
35 2007-07-04 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-tny-account.c: (on_connection_status_changed):
38 Commented out the call to modest_platform_connect_and_wait() because this
39 seems to always hang, and I would like to know if this is the only thing
40 that causes a hang when showing the connection dialog.
41 It is not very useful anyway.
43 2007-07-04 Murray Cumming <murrayc@murrayc.com>
45 * src/maemo/modest-msg-view-window.c:
46 (modest_msg_view_window_select_next_message):
48 * src/modest-platform.h:
49 * src/maemo/modest-platform.c:
50 Added modest_platform_connect_and_wait(), which calls
51 tny_maemo_conic_device_connect() always in the main thread, by calling it
52 in an idle handler and waiting for the idle handler to run. It should be
53 in the main thread because it uses GTK+ UI code. It just returns TRUE
54 if the device is already online.
56 There is some nasty code to ensure that subsequent calls to
57 modest_platform_connect_and_wait() just wait for the first one to finish,
58 by checking repeatedly in another idle handler. This is necessary,
59 because other threads (or even the main thread, via another idle handler)
60 can call modest_platform_connect_and_wait() while
61 modest_platform_connect_and_wait() is running.
63 (modest_platform_connect_and_wait_if_network_account),
64 (modest_platform_connect_and_wait_if_network_folderstore):
65 Convenience functions that calls modest_platform_connect_and_wait() if
66 the account or folder might want network access.
68 * src/modest-mail-operation.c:
69 (modest_mail_operation_update_account):
70 * src/modest-ui-actions.c: (download_uncached_messages),
71 (modest_ui_actions_on_rename_folder), (delete_folder),
72 (modest_ui_actions_on_main_window_move_to),
73 (modest_ui_actions_on_msg_view_window_move_to):
74 * src/widgets/modest-folder-view.c:
75 (drag_and_drop_from_folder_view):
76 Offer a connection if we are offline.
78 * src/modest-tny-account.c: (on_connection_status_changed):
79 Document this as only handling errors during network operations in progress,
80 and replace the idle code with a simple call to
81 modest_platform_connect_and_wait(), which does this instead.
83 2007-07-03 Murray Cumming <murrayc@murrayc.com>
85 * src/modest-tny-account.c:
86 (modest_tny_account_get_special_folder): (util_on_idle),
87 Handle the GError so we can see when tny_folder_store_get_folders()
88 fails, as it currently does while something else is connecting.
90 Added util_run_in_main_thread_and_wait()
91 which uses an idlen handler and mainloop to ensure that the function
92 is called in the main thread.
93 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
94 to make sure that we call attempt the connection in the mainloop only,
95 which might solve some hangs.
97 2007-07-03 Murray Cumming <murrayc@murrayc.com>
99 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
100 be found by their display name. This is never useful.
101 * src/modest-tny-account-store.c: (on_account_removed): Find the account
102 by its ID, instead of trying to use its ID as its display name.
104 * src/modest-tny-account-store.h:
105 * src/modest-tny-account.c:
106 (modest_tny_account_get_special_folder): Add a g_warning() when
107 tny_folder_store_get_folders() returns an empty list for the maildir.
109 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
110 Add a g_warning() when this returns NULL, because that it not allowed
113 2007-07-02 Armin Burgmeier <armin@openismus.com>
115 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
116 note when trying to cancel the wizard. This fixes projects.maemo.org
119 2007-07-02 Murray Cumming <murrayc@murrayc.com>
121 * src/modest-tny-account.h:
122 * src/modest-tny-account.c:
123 (modest_tny_account_new_from_server_account),
124 (modest_tny_account_new_from_server_account_name),
125 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
126 because this must now be set before setting the proto. This is usd in
127 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
128 warning in camel_session_get_service() caused by
129 tny_camel_transport_account_prepare().
131 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
134 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
136 * src/maemo/modest-connection-specific-smtp-edit-window.c:
138 (modest_connection_specific_smtp_edit_window_init):
140 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
143 2007-06-29 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-tny-account.c:
146 (modest_tny_account_new_from_server_account):
147 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
148 now uses to request a connection when it needs one, and which it uses
149 to tell us that something is wrong with the connection, so we can force
150 the accounts offline to prevent further problems.
153 * src/modest-init.c: (init_default_settings):
154 * src/modest-mail-operation.c:
155 (modest_mail_operation_update_account):
156 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
157 This should not be necessary anymore. Do not set the conf key that
158 determined this (it was always TRUE and not set anywhere else).
160 * src/modest-ui-actions.h: Remove unused and unimplemented
161 modest_ui_actions_on_online_toggle_toggled().
163 2007-06-29 Murray Cumming <murrayc@murrayc.com
165 * src/maemo/modest-main-window.c: (connect_signals):
166 Don't connect to delete_event twice. Maybe this was harmless.
168 2007-06-29 Murray Cumming <murrayc@murrayc.com
170 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
171 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
172 Debug output to give some more clue when a folder move is not allowed.
174 2007-06-28 Murray Cumming <murrayc@murrayc.com
176 * src/modest-tny-account.c: (on_modest_file_system_info),
177 (modest_tny_account_get_mmc_account_name):
178 Always call the callback, without checking whether the name has changed.
179 * src/widgets/modest-folder-view.c: (strings_are_equal),
180 (on_model_foreach_set_name), (on_get_mmc_account_name),
181 (text_cell_data): Compare the name here, and use the name from
182 the account rather than from the
183 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
184 if the name was changed after the account was added to the model.
185 That's a tinymail bug but not one that I want to fix now.
187 This finally fixes projects.maemo.org bug NB#59301.
189 2007-06-27 Armin Burgmeier <armin@openismus.com>
191 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
194 2007-06-27 Murray Cumming <murrayc@murrayc.com
196 * src/modest-tny-account.h:
197 * src/modest-tny-account.c:
198 Added modest_tny_account_get_mmc_account_name(), to set the memory
199 card name asynchronously for the given account and then notify.
200 (modest_tny_account_new_for_local_folders): Use this new function instead
201 of using hildon_file_system_info_async_new() directly.
203 * src/widgets/modest-folder-view.c: (text_cell_data):
204 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
205 gtk_tree_model_row_changed() when it is available.
207 This should fix projects.maemo.org bug NB#59301.
209 2007-06-27 Murray Cumming <murrayc@murrayc.com
211 * src/modest-mail-operation.c: (update_account_thread),
212 (get_msgs_full_thread): Fix typo failures in the revert
215 2007-06-27 Murray Cumming <murrayc@murrayc.com
217 * src/maemo/modest-maemo-global-settings-dialog.c:
218 (idle_select_default_focus):
219 * src/modest-mail-operation.c: (idle_notify_progress),
220 (idle_notify_progress_once), (set_last_updated_idle),
221 (update_account_thread), (get_msgs_full_thread):
222 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
223 * src/widgets/modest-header-view.c:
224 (idle_notify_headers_count_changed_destroy),
225 (idle_notify_headers_count_changed):
226 Reverted the additions of gdk_threads_enter/leave(), in case this
227 helps with a startup hang on the device.
229 2007-06-26 Armin Burgmeier <armin@openismus.com>
231 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
232 for supported secure authentication methods from server by
233 gtk_dialog_run(), saving CPU time and a potential race condition.
235 2007-06-26 Armin Burgmeier <armin@openismus.com>
237 * src/maemo/modest-maemo-utils.h:
238 * src/maemo/modest-maemo-utils.c: Added a
239 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
240 only error code to tell the calling code when the user canceled the
243 * src/maemo/modest-account-settings-dialog.h:
244 * src/maemo/modest-account-settings-dialog.c:
245 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
246 message if the retrieval of secure authentication methods was canceled
247 by the user. Perform the check before saving anything to configuration
248 to not end up with half-committed configuration changes, do not show
249 a "Saving to configuration failed" note when authentication methods
250 could not be retrieved.
252 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
255 2007-06-26 Murray Cumming <murrayc@murrayc.com>
257 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
258 Only return the first level of folders under accounts, because the
259 osso-global-search UI spec doesn't want the rest.
260 This fixed projects.maemo.org bug NB#61811.
262 2007-06-26 Murray Cumming <murrayc@murrayc.com>
264 * src/modest-tny-account-store.c:
265 * src/modest-tny-account-store.h:
266 Added modest_tny_account_is_memory_card_account().
267 * src/maemo/modest-main-window.c: (create_details_widget):
268 Show the same information items for the memory card as we show for the
269 local-folders, to fix projects.maemo.org bug NB#59307.
271 2007-06-26 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-account-store.c: (get_password):
274 Added some checks for NULL to maybe prevent crashes, though I think
275 it was Philip's last commit that actually prevented the crash here
276 when creating a first new account.
277 But the new account is still not usable (no messages are shown)
278 until a restart of the application.
280 2007-06-26 Murray Cumming <murrayc@murrayc.com>
282 * src/maemo/modest-maemo-global-settings-dialog.c:
283 (idle_select_default_focus):
284 * src/modest-mail-operation.c: (idle_notify_progress),
285 (idle_notify_progress_once), (idle_notify_update_account_queue),
286 (set_last_updated_idle), (update_account_thread),
287 (notify_get_msgs_full), (get_msgs_full_destroyer),
288 (get_msgs_full_thread):
289 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
290 * src/widgets/modest-header-view.c:
291 (idle_notify_headers_count_changed_destroy),
292 (idle_notify_headers_count_changed):
293 Use gdk_threads_enter() and gdk_threads_enter_leave() in
294 all idle handlers, because some other thread could be blocking
295 the GDK lock, so that it can do GUI stuff.
297 2007-06-26 Murray Cumming <murrayc@murrayc.com>
299 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
300 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
301 (on_idle_send_receive), (on_idle_open_default_inbox):
302 * src/maemo/modest-msg-edit-window.c:
303 (modest_msg_edit_window_attach_file_noninteractive):
304 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
305 to prevent a hang. I don't quite understand why these are necessary,
306 beause we should already be in the main loop. I guess something outside
307 of the main loop is taking the lock.
309 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
310 we are really using URIs, and use files that are more likely to exist.
312 2007-06-26 Murray Cumming <murrayc@murrayc.com>
314 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
315 necessary because configure.ac now defines different variables.
317 2007-06-26 Murray Cumming <murrayc@murrayc.com>
319 * libmodest-dbus-client/libmodest-dbus-client.c:
320 * libmodest-dbus-client/libmodest-dbus-client.h:
321 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
322 libmodest_dbus_client_compose_mail() is what things actually use.
324 * src/dbus_api/modest-dbus-api.h:
325 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
326 * tests/dbus_api/Makefile.am:
327 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
330 2007-06-26 Murray Cumming <murrayc@murrayc.com>
332 * src/modest-init.c: (modest_init_local_folders):
333 For memory-card (or other non local-folders) maildir accounts,
334 always create an Archive folder, so that there is somewhere to put
335 messages. This should be less confusing, because the user does not need
336 to guess that the need to create a folder.
338 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
340 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
341 Fixed icon size by using (50, 50) which is the same as defined by
344 2007-06-25 Armin Burgmeier <armin@openismus.com>
346 * src/widgets/modest-window-mgr.c:
348 * configure.ac: Correctly recognize hildon-notify presence and fixed
349 the build without it being installed.
351 2007-06-25 Murray Cumming <murrayc@murrayc.com>
353 * libmodest-dbus-client/libmodest-dbus-client.c:
354 (libmodest_dbus_client_search): Fix the build. Sorry.
355 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
356 (reply_forward_cb): Initialize variables to fix the build.
358 * src/modest-tny-account-store.c:
359 (modest_tny_account_store_get_tny_account_by): Fix the account URI
360 comparison (a silly typo) so that email search results can be opened
361 when there are more than one account.
363 2007-06-25 Murray Cumming <murrayc@murrayc.com>
365 * libmodest-dbus-client/libmodest-dbus-client.c:
366 (libmodest_dbus_client_search),
367 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
368 instead of 1 second, because the search gets folders and messages from
369 the server, which can take a long time. When it times out,
370 osso-global-search will report no results.
372 We need to specify whether we should search only cached information
373 (maybe with a user preference), and the osso-email-search-plugin
374 API should really be improved to allow that option, and to allow results
375 to be delivered asynchronously in batches.
377 2007-06-25 Murray Cumming <murrayc@murrayc.com>
379 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
380 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
381 GTK_ICON_SIZE_DIALOG is probably the wrong size.
383 2007-06-25 Murray Cumming <murrayc@murrayc.com>
385 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
386 that is an empty string. D-Bus seems to give us these instead of NULL.
388 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
390 * src/dbus_api/modest-dbus-callbacks.c:
391 * src/maemo/easysetup/modest-easysetup-wizard.h:
392 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
393 * src/maemo/modest-connection-specific-smtp-edit-window.c:
394 (modest_connection_specific_smtp_edit_window_init):
395 * src/maemo/modest-maemo-global-settings-dialog.c:
397 * src/maemo/modest-maemo-utils.c:
398 (modest_maemo_utils_setup_images_filechooser):
399 * src/maemo/modest-main-window.c: (create_details_widget):
400 * src/maemo/modest-msg-edit-window.c:
401 (modest_msg_edit_window_attach_file_noninteractive),
402 (modest_msg_edit_window_color_button_change),
403 (modest_msg_edit_window_set_zoom):
404 * src/modest-mail-operation.c: (update_account_thread):
405 * src/modest-tny-account-store.c:
406 * src/modest-tny-account.c:
407 * src/widgets/modest-global-settings-dialog.c:
408 * src/widgets/modest-window.h:
412 2007-06-25 Murray Cumming <murrayc@murrayc.com>
414 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
415 * src/modest-search.c: (modest_search_folder),
416 (modest_search_all_accounts): Actually search only in the specified folder,
417 doing a simple match on the folder ID.
418 * src/modest-search.h: Added a folder field to the ModestSearch struct,
419 and added some documentation.
421 2007-06-22 Armin Burgmeier <armin@openismus.com>
423 * src/maemo/modest-maemo-utils.h:
424 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
425 modest_maemo_utils_get_supported_secure_authentication_methods.
427 * src/maemo/easysetup/modest-easysetup-wizard.c:
428 * src/maemo/modest-account-settings-dialog.c: Show correct error if
429 one occured, not just "Server does not support secure authentication".
431 2007-06-22 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-tny-account-store.c: (get_password):
434 Restored the call to tny_account_set_user() because Philip seems to have
435 stopped this from crashing (by not using the freed string). It still does
436 not work, but now we can test it.
438 2007-06-22 Murray Cumming <murrayc@murrayc.com>
440 * src/maemo/modest-msg-edit-window.c: (init_window):
441 Comment out use of an uninitialzed GtkScrolledWindow variable,
442 to fix the build and stop a crash. Yet again.
444 2007-06-22 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-tny-account-store.c: (get_password):
447 Remove the call to tny_account_set_user() because this actually crashes.
448 As mentioned in the last commit, it is known to not work anyway.
450 2007-06-22 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-tny-account-store.c: (get_password):
453 Use tny_account_set_username() to tell tinymail that the username might
454 have changed too. But tinymail ignores this: see projects.maemo.org
456 * src/modest-ui-actions.c:
457 (modest_ui_actions_on_password_requested): Remove the useless attempt to
458 reset the connection when changing the username, and improve the comments.
459 Save the changed username to gconf at least, so it is used when Modest is
462 2007-06-21 Murray Cumming <murrayc@murrayc.com>
464 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
465 Do not use a query, so that we get all folders, including for POP and
466 local-folders. They work as search criteria too.
467 This fixes projects.maemo.org bug NB#57740.
469 2007-06-21 Murray Cumming <murrayc@murrayc.com>
471 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
472 Comment out the use of hildon_notification_set_sound() because it is
473 not declared, to fix the build. Warnings are serious, people.
475 2007-06-21 Armin Burgmeier <armin@openismus.com>
477 * src/maemo/modest-maemo-utils.h:
478 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
479 modest_maemo_utils_get_supported_secure_authentication_methods()
480 to query authentication methods for a specific user. This should fix
481 projects.maemo.org bug NB#61369.
483 * src/maemo/easysetup/modest-easysetup-wizard.c:
484 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
487 2007-06-21 Murray Cumming <murrayc@murrayc.com>
489 * libmodest-dbus-client/libmodest-dbus-client.h:
490 * libmodest-dbus-client/libmodest-dbus-client.c:
491 (modest_dbus_message_iter_get_search_hit),
492 (libmodest_dbus_client_search):
493 Reorganised and commented this.
494 Removed modest_search_hit_free() from the public API because it
497 Added libmodest_dbus_client_get_folders() and
498 modest_folder_result_list_free().
500 * src/dbus_api/modest-dbus-api.h:
501 * src/dbus_api/modest-dbus-callbacks.c:
502 (modest_dbus_req_filter): Commented. Moved most code to
503 on_dbus_method_search() and added on_dbus_method_get_folders().
505 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
506 of the extra D-Bus handler.
508 * tests/dbus_api/Makefile.am:
509 * tests/dbus_api/test_get_folders.c: New test for
510 libmodest_dbus_client_get_folders(). This seems to return an empty list
511 at the moment. That could be the same error that causes the message list
512 to be empty sometimes.
513 This should help with projects.maemo.org bug NB#57740.
515 2007-06-21 Armin Burgmeier <armin@openismus.com>
517 * src/modest-mail-operation.c: Do not call
518 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
519 notify the operation's end after having set the status to CANCELED for
520 the operation queue to listen on. This fixes a deadlock when there
521 were mail operations in the queue during its finalization.
523 * src/modest-singletons.c: Reordered uninitialization of the account
524 manager to happen after the mail operation queue was uninitialized
525 because the mail operation's in the queue might still try to access
526 the account manager (see modest_mail_operation_notify_end()). This
527 fixes a potential crash when terminating the application.
529 2007-06-21 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-search.c:
532 (search_mime_part_and_child_parts): Moved some code here so we
533 can search recursively in child folders.
534 (modest_search_folder): Search in the message as a mime part, instead
535 of just its child mime parts.
536 (read_chunk), (search_mime_part_ogs):
537 Check how many bytes were read, to prevent an endless loop.
538 Searching in message bodies now works. This finishes the fix for
539 projects.maemo.org bug NB#61007.
541 2007-06-20 Murray Cumming <murrayc@murrayc.com>
543 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
544 Add a g_warning when the item is not a folder.
546 * src/modest-ui-dimming-rules.c:
547 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
548 when selected item is not a folder (for instance, an account), because
549 the UI spec only talks about folders.
550 I am not sure what the UI spec wants, so this might not totally fix
551 projects.maemo.org bug NB#60794.
553 2007-06-20 Murray Cumming <murrayc@murrayc.com>
555 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
556 (load_from_file): Sort the list. The unsorted list would be more noticeable
557 in non-English locales.
559 * src/maemo/modest-msg-edit-window.c:
560 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
561 warning and fix the build.
563 * src/maemo/modest-progress-bar-widget.c:
564 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
565 avoid a g_warning, and probably to avoid a crash.
567 2007-06-20 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-search.c: (modest_search_folder): Check for a GError
570 when calling tny_folder_get_headers(), to show that this is not the cause
573 2007-06-20 Murray Cumming <murrayc@murrayc.com>
575 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
576 Actually set the body query instead of the subject query.
578 * src/modest-search.c: (search_mime_part_ogs),
579 (search_mime_part_strcmp): Remove extra space from the text/* regex,
580 which would probably cause it to fail if we got this far.
582 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
583 to simplify the code.
584 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
585 be causing search-in-body to fail.
587 2007-06-20 Murray Cumming <murrayc@murrayc.com>
589 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
591 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
592 Better debug message when the folder cannot be found.
593 This should help with fixing projects.maemo.org bug #61287.
594 * src/modest-search.c: (add_hit): Do not leak the furl string.
596 2007-06-20 Murray Cumming <murrayc@murrayc.com>
598 * src/modest-ui-actions.c:
599 (modest_ui_actions_on_folder_selection_changed):
600 Do not special-case TNY_MERGE_FOLDER here, because
601 modest_tny_folder_get_account() already does that. This fixes
602 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
603 shown when the Outbox was selected).
605 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
607 * libmodest-dbus-client/libmodest-dbus-client.c:
608 (_dbus_iter_get_string_or_null): Initialize the string variable in
609 case this helps with Dirk's crash.
611 2007-06-19 Murray Cumming <murrayc@murrayc.com>
613 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
614 though it is not implemented yet (this function is maybe not even used),
615 to avoid breaking ABI in future.
616 * libmodest-dbus-client/libmodest-dbus-client.c:
617 (get_attachments_string): Moved some code into this generic function.
618 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
619 sends email. It is maybe not used.
620 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
621 (on_send_mail): Use attachments.
623 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
624 * src/maemo/modest-msg-edit-window.c:
625 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
626 a filename before using it, to fix projects.maemo.org bug NB#58233.
628 2007-06-19 Murray Cumming <murrayc@murrayc.com>
630 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
631 Initialize the continue_download variable to fix the build, and probably
632 to fix randome behaviour.
634 2007-06-18 Armin Burgmeier <armin@openismus.com>
636 * src/modest-tny-send-queue.h:
637 * src/modest-tny-send-queue.c: Keep track of the status of messages in
638 the queue so we can later show it in the UI. Replaced
639 modest_tny_send_queue_msg_is_being_sent() by
640 modest_tny_send_queue_get_msg_status().
642 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
644 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
645 gpointer. This probably was not harmful, but just to be sure.
647 2007-06-18 Murray Cumming <murrayc@murrayc.com>
649 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
650 Fix the build, but leave the function broken on Bora, because
651 hildon_uri_action_get_service() does not exist.
652 osso_uri_action_get_service() does not exist either, it seems.
654 2007-06-18 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-tny-account.c:
657 (modest_tny_account_new_from_server_account):
658 Uncommented the url debug output again, because it is useful for
659 debugging, as I said in the comment.
661 2007-06-18 Murray Cumming <murrayc@murrayc.com>
663 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
665 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
666 for Mameo Bora, to fix the build.
668 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
671 Fixed build with hildon < 0.99
673 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
674 Check if the selected account is busy instead of checking all accounts
676 * src/modest-account-mgr-priv.h:
677 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
678 (modest_account_mgr_init), (compare_account_name),
679 (modest_account_mgr_set_account_busy),
680 (modest_account_mgr_account_is_busy):
681 * src/modest-account-mgr.h:
682 Added busy information to the account manager. It possible to
683 set an account to busy or not busy now.
685 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
686 (modest_mail_operation_update_account),
687 (modest_mail_operation_notify_end):
688 Set the account to busy/not busy depending on the operation state.
690 * src/widgets/modest-account-view.c:
691 (modest_account_view_finalize), (get_last_updated_string),
692 (update_account_view), (on_account_busy_changed), (init_view):
693 Show string "Refreshing..." if the account is currently busy.
695 All this fixes projects.maemo.org bug NB#59711
697 2007-06-14 Armin Burgmeier <armin@openismus.com>
699 * src/widgets/modest-attachments-view.h:
700 * src/widgets/modest-attachments-view.c: Added
701 modest_attachments_view_has_attachments() and fixed coordinate
702 transformation in get_att_view_at_coords(). This fixes attachment
705 * src/widgets/modest-msg-view.c: Make use of
706 modest_attachments_view_has_attachments() to decide whether to show
707 attachments in the header.
709 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
712 (on_change), (on_combo_security_changed),
713 (modest_connection_specific_smtp_edit_window_init),
714 (modest_connection_specific_smtp_edit_window_set_connection),
715 (modest_connection_specific_smtp_edit_window_is_dirty):
716 * src/maemo/modest-connection-specific-smtp-edit-window.h:
717 * src/maemo/modest-connection-specific-smtp-window.c:
720 Show an comfirmation dialog for the smpt-edit-window if there are
721 unsaved changes and the user hits cancel.
722 (projects.maemo.org bug NB#60479)
724 2007-06-14 Armin Burgmeier <armin@openismus.com>
726 * src/maemo/easysetup/modest-easysetup-wizard.c:
727 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
728 address" info in banner instead of node, and select all the text as
729 per UI spec. This fixes projects.maemo.org bug NB#60550.
731 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
733 reviewed by: <delete if not using a buddy>
735 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
736 * src/modest-ui-actions.c: (folder_refreshed_cb):
738 2007-06-14 Murray Cumming <murrayc@murrayc.com>
740 * src/widgets/modest-folder-view.c: (filter_row):
741 Explictly filter out the per-account outbox accounts. I don't know why
742 these only sometimes show up, but now they should never show up in the UI.
743 This should fix projects.maemo.org bug NB#60160.
745 2007-06-14 Murray Cumming <murrayc@murrayc.com>
747 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
748 when the toolbar does not exist yet.
749 * src/modest-widget-memory.c: (save_settings_header_view):
750 Added g_warnings() to help us to discover when we are trying to set
751 an empty columns list in gconf.
753 2007-06-14 Murray Cumming <murrayc@murrayc.com>
757 Added modest_init_get_default_header_view_column_ids().
759 * src/modest-widget-memory.c: (restore_settings_header_view):
760 Use the new function to get defaults, if the gconf key is empty,
761 instead of not creating any columns. This seems to fix the
762 empty right-hand pane problems.
764 * src/widgets/modest-header-view.h: Improved documentation.
766 2007-06-13 Murray Cumming <murrayc@murrayc.com>
768 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
769 Revert the use of the display name as the account name, because this
770 is generally wrong and would break the code that follows.
772 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
774 * src/maemo/easysetup/modest-easysetup-wizard.c:
775 (check_for_supported_auth_methods), (on_before_next),
778 More correct fix for projects.maemo.org bug NB# 58991
779 Do not longer accept AUTH_PASSWORD as secure method and choose
780 correct method when creating the account.
782 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
784 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
785 Fixed projects.maemo.org bug NB# 58991
787 2007-06-13 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-init.c: (modest_init_init_core),
790 (modest_init_local_folders): Fixed compilation errors.
792 2007-06-13 Murray Cumming <murrayc@murrayc.com>
794 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
795 Remove unnecessary lib/include, though it is good in principle when needed.
797 * src/modest-init.c: (modest_init_one_local_folder),
798 (modest_init_local_folders):
799 * src/modest-init.h: Initialize the .modest library for memory cards,
800 instead of just doing nothing for them. This should allow us to create
801 folders there, fixing projects.maemo.org bug NB#59297.
803 2007-06-13 Murray Cumming <murrayc@murrayc.com>
805 * libmodest-dbus-client/libmodest-dbus-client.c:
806 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
807 (libmodest_dbus_client_compose_mail),
808 (libmodest_dbus_client_open_message),
809 (libmodest_dbus_client_send_and_receive),
810 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
812 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
813 (on_idle_open_message), (modest_dbus_req_handler),
814 (search_result_to_message), (modest_dbus_req_filter):
815 * src/modest-search.c: (add_hit), (modest_search_folder),
816 (modest_search_all_accounts): Improved debug messages.
818 * tests/dbus_api/test_open_message.c: (main): Improved comments.
820 * src/modest-tny-account-store.c:
821 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
824 2007-06-13 Murray Cumming <murrayc@murrayc.com>
827 2007-06-12 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-tny-account-store.c: (get_server_accounts):
830 Call modest_tny_local_folders_account_add_merged_outbox_folders()
831 even when there are no accounts, so that the Outbox folder is always
832 visible. This fixes projects.maemo.org bug NB#60158.
834 2007-06-12 Murray Cumming <murrayc@murrayc.com>
836 * src/maemo/modest-main-window.c: (create_details_widget):
837 Use the mcen_va_never logical ID.
839 2007-06-12 Murray Cumming <murrayc@murrayc.com>
841 * src/dbus_api/modest-dbus-api.h:
842 * src/dbus_api/modest-dbus-callbacks.c:
843 (on_idle_open_default_inbox), (on_open_default_inbox),
844 (modest_dbus_req_handler):
845 Added a new OpenDefaultInbox method.
847 * libmodest-dbus-client/libmodest-dbus-client.h:
848 * libmodest-dbus-client/libmodest-dbus-client.c:
849 Added libmodest_dbus_client_open_default_inbox() to call the new
850 dbus method. This should be useful to projects.maemo.org bug NB#57214,
851 though it should maybe be used by a new osso-email-interface function.
853 * tests/dbus_api/Makefile.am:
854 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
857 2007-06-12 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
860 NULL, so that the signals get all the keys. This should not actually
861 change any behaviour because we currently update everything when anything
864 2007-06-12 Murray Cumming <murrayc@murrayc.com>
866 * src/widgets/modest-folder-view.c: (text_cell_data),
867 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
868 (find_inbox_iter): If tinymail tells us that the folder is
869 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
870 This causes the inbox to be selected at startup, fixing part of
871 projects.maemo.org bug NB#56305.
873 * src/modest-ui-dimming-rules.c:
874 (modest_ui_dimming_rules_on_tools_smtp_servers):
875 * src/modest-ui-dimming-rules.h: Added a callback function to dim
876 the SMTP servers menu item.
877 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
878 that the SMTP Servers menu item is dimmed when there are no accounts,
879 as a future version of the UI spec will require. This fixes
880 projects.maemo.org bug NB#56305.
882 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
884 * src/maemo/modest-maemo-utils.c:
885 (modest_maemo_utils_get_supported_secure_authentication_methods):
886 Added label to dialog instead of unreadable title
888 * src/maemo/modest-main-window.c: (sync_accounts_cb),
889 (modest_main_window_new):
890 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
893 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
894 * src/modest-account-mgr.h:
895 Added method to avoid code duplication
897 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
898 (modest_ui_actions_on_send_receive):
899 Use modest_account_mgr_has_accounts
901 2007-06-11 Murray Cumming <murrayc@murrayc.com>
903 * src/maemo/easysetup/modest-presets.c:
904 (modest_presets_get_info_server_security): Do not report secure auth
906 * src/modest-protocol-info.c: Use the defines for the gconf key names
907 for secure authentication. This was not working because we were writing
908 Password and reading password, and the check was case sensitive.
909 With this, gmail now works for receiving and sending when created via
912 2007-06-11 Murray Cumming <murrayc@murrayc.com>
914 * src/maemo/easysetup/modest-presets.c:
915 (modest_presets_get_info_server_security): Correct the key name for
916 SecureSmtp, because it seems to be case-sensitive.
917 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
918 Do not try to get the 0th notebook page if there are 0 pages, to
921 2007-06-11 Murray Cumming <murrayc@murrayc.com>
923 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
924 Prevent use of the new notification feature for now, because it currently
925 shows one dialog for each new email, which is annoying.
927 2007-06-11 Murray Cumming <murrayc@murrayc.com>
929 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
930 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
931 when no country was selected, so that we show the global ones.
932 * src/maemo/easysetup/modest-presets.c:
933 (modest_presets_get_providers): Return only the global providers, not
934 all providers when mmc=0 was requested.
936 2007-06-11 Murray Cumming <murrayc@murrayc.com>
938 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
939 (easysetup_provider_combo_box_fill): Remove debug code that showed the
940 provider ID in the combo.
942 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
943 Do not show the page numbers, because it would be confusing when we add
944 the 2 extra pages for the custom setup, when the user chooses the "Other"
945 provider. This fixes projects.maemo.org bug NB#59028
947 * src/modest-init.c: (modest_init_init_core),
948 (modest_init_local_folders):
950 * src/modest-tny-account.c:
951 (modest_tny_account_new_for_local_folders): Do not create default folders
952 for the memory card. This should fix projects.maemo.org bug NB#59328.
954 2007-06-11 Murray Cumming <murrayc@murrayc.com>
956 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
957 Free the changed_conf_keys string items. They are already freed in the
958 idle handler if that runs first.
960 2007-06-11 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-ui-actions.c:
963 (modest_ui_actions_on_password_requested): Check that the server name
964 is not NULL, because I just saw a password dialog with (null) as the
967 * src/modest-tny-folder.[h|c]: Added
968 modest_tny_folder_is_memory_card_folder().
969 * src/modest-ui-dimming-rules.c:
970 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
971 menu item for memory cards, as per the UI spec (section 7.4). This should
972 fix projects.maemo.org bug NB#59297.
974 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
976 * src/maemo/modest-main-window.c: (sync_accounts_cb):
977 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
978 is another problem with the code, see Murray's comment at line 772)
980 2007-06-08 Murray Cumming <murrayc@murrayc.com>
982 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
983 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
984 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
985 (load_from_file), (easysetup_country_combo_box_init),
986 (easysetup_country_combo_box_get_active_country_ids),
987 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
988 instead of just one ID, to avoid duplicate country names in the UI.
990 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
991 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
992 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
993 a single ID, avoiding duplicate providers.
994 * src/maemo/easysetup/modest-easysetup-wizard.c:
995 (on_combo_account_country): Adapt to use a list.
997 2007-06-08 Murray Cumming <murrayc@murrayc.com>
999 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1000 keys changed in the last X seconds.
1002 * src/modest-account-mgr.h:
1003 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1004 (on_key_change), (modest_account_mgr_class_init),
1005 (modest_account_mgr_init), (modest_account_mgr_finalize):
1006 As the keys are changed, save them in a GSList* and signal that GSList*
1007 further every X seconds, to batch changes, to allow us to do just one
1008 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1009 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1011 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1012 changed signal signature.
1014 * src/modest-conf.c: (modest_conf_set_list),
1015 (modest_conf_on_change): Reenable notification.
1017 (modest_conf_maemo_fake_on_change): Comment out the hack that
1018 notified immediately instead of asynchronously.
1020 * src/widgets/modest-account-view.h:
1021 * src/widgets/modest-account-view.c:
1022 (update_account_view): Select the previously-selected account ID,
1023 if possible. This fixes projects.maemo.org bug NB#56933.
1025 (on_account_changed), (on_account_removed),
1026 (modest_account_view_select_account):
1028 Remove the block/unblock functions
1029 because they were not useful.
1031 * src/maemo/modest-account-view-window.c:
1032 (on_delete_button_clicked), (on_edit_button_clicked),
1033 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1035 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1037 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1038 Improve the error dialog to show Incorrect Account Settings, which seems
1039 clearer, and say that the internal error message (to be removed from the
1040 dialog later) is often misleading.
1041 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1043 * src/modest-tny-account.c:
1044 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1045 URL because this is so useful for debugging on the device.
1047 * src/widgets/modest-serversecurity-combo-box.c:
1048 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1050 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1052 * src/modest-mail-operation.c:
1053 (modest_mail_operation_send_new_mail):
1054 Added a comment about a nasty but apparently harmless message. Details
1055 added to the wiki g_warnings() page.
1057 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1059 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1060 (modest_tny_send_queue_class_init):
1061 Do not use the priv struct because it is empty, to avoid g_warnings
1062 about a non-existant priv struct.
1064 * src/modest-tny-account-store.c:
1065 (modest_tny_account_store_get_server_account),
1066 (modest_tny_account_store_get_transport_account_for_open_connection
1067 ): Do not try to get transport server accounts for local folders,
1068 because they don't have any. This avoids a g_warning().
1070 * src/maemo/modest-main-window.c:
1071 (modest_main_window_notify_send_receive_initied),
1072 (on_configuration_key_changed):
1073 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1074 * src/modest-defs.h:
1075 * src/modest-mail-operation.c:
1076 (modest_mail_operation_update_account):
1077 * src/modest-tny-account-store.h:
1078 * src/modest-tny-account.c:
1079 (modest_tny_account_get_special_folder),
1080 (modest_tny_account_new_for_local_folders),
1081 (modest_tny_account_new_for_per_account_local_outbox_folder):
1082 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1083 * src/modest-tny-local-folders-account.c:
1084 (add_account_folders_to_merged_folder):
1085 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1086 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1087 (modest_ui_actions_on_send):
1088 * src/widgets/modest-folder-view.c: (update_model):
1089 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1090 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1091 modest_tny_account_store_get_tny_account_by_account() to
1092 modest_tny_account_store_get_server_account() to make the code clearer.
1094 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1096 * src/dbus_api/modest-dbus-api.h:
1097 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1098 * src/maemo/modest-msg-edit-window.c:
1099 (modest_msg_edit_window_attach_file_noninteractive):
1100 added g_warning in case the file to be attached does not exist
1101 * tests/dbus_api/test_compose_mail.c: (main):
1102 removed obsolete comment, added generic files as test case
1104 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-tny-account-store.c: (get_server_accounts):
1107 Create the local folders account only once, not once for each outbox, and
1108 not only when there are some outboxes.
1110 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1112 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1113 code that is causing a crash at startup. Sergio says that he is fixing this.
1115 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1117 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1118 * src/maemo/modest-account-settings-dialog.c:
1119 (create_page_outgoing),
1120 (modest_account_settings_dialog_set_account_name),
1121 (save_configuration):
1122 - Fixed handling of the "Use secure authentication" toggle to comply with
1123 the ui specification. See also projects.maemo.org bug NB#58400
1125 - Restore the Secure connection setting combo correctly when loading
1128 * src/maemo/modest-maemo-utils.c:
1129 (on_camel_account_get_supported_secure_authentication),
1130 (modest_maemo_utils_get_supported_secure_authentication_methods):
1131 Fixed a crasher if operation is canceled
1133 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1134 (modest_protocol_info_auth_is_secure):
1135 * src/modest-protocol-info.h:
1137 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1138 the sense of the "Use secure authentication" toggle.
1140 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1142 * src/modest-tny-account-store.h:
1143 * src/modest-tny-account-store.c:
1144 Added modest_tny_account_store_get_local_folders_account().
1146 * src/modest-tny-folder.h:
1147 * src/modest-tny-folder.c:
1148 (modest_tny_folder_get_account):
1149 Added this replacement for tny_folder_get_account() which returns
1150 the local-folders account for TnyMergeFolders, to avoid the
1151 warning about the unimplemented get_account_func() vfunc().
1153 (modest_tny_folder_get_rules),
1154 * src/modest-ui-actions.c:
1155 (modest_ui_actions_on_folder_selection_changed):
1156 * src/modest-mail-operation.c:
1157 (modest_mail_operation_remove_folder),
1158 (modest_mail_operation_xfer_folder),
1159 (modest_mail_operation_rename_folder),
1160 (modest_mail_operation_get_msg),
1161 (modest_mail_operation_get_msgs_full),
1162 (modest_mail_operation_remove_msg),
1163 (modest_mail_operation_xfer_msgs),
1164 (modest_mail_operation_refresh_folder):
1165 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1167 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1169 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1170 (modest_server_account_set_security):
1171 * src/modest-defs.h: Add comments explaining that our
1172 UI spec means TLS when it says Normal, so these do not look like errors.
1174 * src/modest-tny-account.c:
1175 (modest_tny_account_new_from_server_account): Use the new tinymail
1176 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1177 for TLS. This should fix projects.maemo.org bug NB#58460.
1179 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1181 * src/maemo/easysetup/modest-easysetup-wizard.c:
1182 (create_account): Correct the position of the gconf sanity check warning.
1183 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1184 of using the g_idle_add() hack, because this does not seem to be necessary
1185 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1186 caused by something other than maemo's gconf.
1187 This fixes projects.maemo.org bug #59022.
1189 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-account-mgr-helpers.c:
1192 (modest_account_mgr_get_default_account): Do not check that the account
1193 exists if there is no default account (NULL), to fix a runtime warning.
1195 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1197 * src/widgets/modest-folder-view.c: (update_model):
1198 Do not unref the treemodel before we have finished with it.
1199 This prevents a valgrind warning and an occasional crash at startup.
1201 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1203 * libmodest-dbus-client/libmodest-dbus-client.h:
1204 added libmodest_dbus_client_compose_mail()
1205 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1207 added functions needed for SendAsMail() functionality
1208 * src/maemo/modest-msg-edit-window.c:
1209 (modest_msg_edit_window_attach_file_noninteractive):
1210 non interactively attaching files to message edit window
1211 * src/widgets/modest-msg-edit-window.h:
1212 * tests/dbus_api/Makefile.am:
1213 added test_compose_mail.c
1214 * tests/dbus_api/test_compose_mail.c: (main):
1216 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1218 * src/modest-account-view.c:
1219 Fixed bug projects.maemo.org bug NB#59307
1221 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1223 * src/maemo/easysetup/modest-easysetup-wizard.c:
1224 (get_serverport_incoming), (on_before_next), (create_account):
1225 * src/maemo/modest-account-settings-dialog.c:
1226 (modest_account_settings_dialog_set_account_name):
1227 * src/maemo/modest-maemo-utils.c:
1228 (on_camel_account_get_supported_secure_authentication_status),
1229 (on_camel_account_get_supported_secure_authentication),
1230 (on_secure_auth_cancel),
1231 (modest_maemo_utils_get_supported_secure_authentication_methods):
1233 Implemented security authentication for settings and easysetup.
1235 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1237 * src/maemo/modest-main-window.c: (create_details_widget):
1238 Show the total size for memory card accounts too, instead of showing
1239 the name again. Fixes bug projects.maemo.org bug NB#59307.
1241 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1244 * src/modest-tny-simple-folder-store.c:
1245 * src/modest-tny-simple-folder-store.h: Removed.
1247 * src/modest-tny-local-folders-account.h
1248 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1249 for the local-folders maildir, with an extra TnyMergedFolder containing
1250 the folders of the per-account outbox store accounts.
1251 * src/modest-tny-account-store.c: (get_server_accounts):
1252 Add the outboxes to the special local folders account after creating it.
1254 * src/modest-tny-account.c:
1255 (modest_tny_account_new_for_local_folders): Create the derived
1256 account when creating the main local-folders account.
1258 * src/maemo/modest-main-window.c: (create_details_widget),
1259 (modest_main_window_set_contents_style):
1260 Adapted to the use of the derived account instead of the folder store.
1262 * src/modest-ui-actions.c:
1263 (modest_ui_actions_on_folder_selection_changed):
1264 * src/modest-ui-dimming-rules.c:
1265 (modest_ui_dimming_rules_on_new_folder):
1266 * src/widgets/modest-folder-view.c: (text_cell_data),
1267 (icon_cell_data), (filter_row), (update_model),
1268 (get_cmp_rows_type_pos):
1271 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1272 Do not get the priv struct, because no priv struct has been set,
1273 to avoid a runtime warning.
1275 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1276 #ifelse with #else, to fix a warning, to fix the build.
1279 2007-06-05 Christian Kellner <ckellner@openismus.com>
1281 * libmodest-dbus-client/libmodest-dbus-client.c:
1282 Fix small typo in doc (why do you always see them
1283 AFTER committing stuff?)
1286 2007-06-05 Christian Kellner <ckellner@openismus.com>
1288 * libmodest-dbus-client/libmodest-dbus-client.c:
1289 (libmodest_dbus_client_search):
1290 Initialize hit list with NULL. Also set folder list
1291 to "" if NULL was supplied.
1294 2007-06-03 Christian Kellner <ckellner@openismus.com>
1296 * libmodest-dbus-client/libmodest-dbus-client.c:
1297 (modest_search_hit_list_free):
1298 Make it save to call it with NULL.
1300 * src/dbus_api/modest-dbus-callbacks.c:
1301 * src/modest-search.c:
1302 Return full ModestSearchHits as the search result list not TnyHeader
1303 since can't be around withouth the correspoding TnyFolder.
1305 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1307 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1308 Added currently commented code to check for secure auth
1310 * src/maemo/modest-account-settings-dialog.c: (on_response),
1311 (save_configuration), (show_ok):
1312 Fixed projects.maemo.org bugs NB #59248 and #59251
1314 * src/maemo/modest-maemo-utils.c:
1315 (on_camel_account_get_supported_secure_authentication_status),
1316 (on_camel_account_get_supported_secure_authentication),
1317 (modest_maemo_utils_get_supported_secure_authentication_methods):
1318 * src/maemo/modest-maemo-utils.h:
1319 Moved get_supported_secure_authentication() method here to be able
1320 to use it from easysetup wizard.
1322 * src/modest-pair.c: (on_pair_compare_as_string):
1323 Should compare string with first part of pair and not
1324 strcmp pairs which will crash.
1326 * src/modest-protocol-info.c:
1327 (modest_protocol_info_protocol_is_store):
1328 * src/modest-protocol-info.h:
1329 Added modest_protocol_info_get_auth_protocol_name()
1331 2007-06-03 Armin Burgmeier <armin@openismus.com>
1333 * src/modest-mail-operation.c:
1334 (modest_mail_operation_get_msgs_full): Set priv->account also when
1335 only retrieving a single message. This avoids a crash when canceling
1338 (modest_mail_operation_notify_end): Do not explicitely remove the
1339 operation from the queue but only emit the progress_changed signal.
1340 The queue itself listens to that signal to remove the operation when
1341 it is finished. This reduces coupling and removes a potential deadlock
1342 when modest_mail_operation_notify_end() is called from the queue
1343 itself. If that is a problem performance-wise, I would suggest to
1344 implement a status-changed signal or something.
1346 * src/modest-mail-operation-queue.c: Make sure to never call a
1347 function from another file while the queue is locked. This (hopefully)
1348 fixes another deadlock when exiting the application while retrieving
1351 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1353 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1354 Fixed build if libogs is not available
1356 2007-06-03 Christian Kellner <ckellner@openismus.com>
1358 * libmodest-dbus-client/libmodest-dbus-client.h:
1359 * libmodest-dbus-client/libmodest-dbus-client.c:
1360 (libmodest_dbus_client_delete_message):
1361 Implement deletion of messages (Client side).
1363 (modest_search_hit_free),
1364 (modest_search_hit_list_free):
1365 Utility functions to free the result hits.
1367 * src/dbus_api/modest-dbus-api.h:
1368 * src/dbus_api/modest-dbus-callbacks.c:
1369 (on_delete_message),
1370 (modest_dbus_req_handler):
1371 Implement deletion of messages (Server side).
1373 * tests/dbus_api/test_search.c: (main):
1376 * tests/dbus_api/Makefile.am:
1377 * tests/dbus_api/test_delete_message:
1378 Add little test for the message deletion logic
1380 2007-06-03 Armin Burgmeier <armin@openismus.com>
1382 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1383 when the operation queue was not empty. projects.maemo.org bug
1386 2007-06-03 Armin Burgmeier <armin@openismus.com>
1388 * src/widgets/modest-account-view.c
1389 (on_account_default_toggled): Toggle default account column
1390 explicitely instead of waiting for gconf notification (which is
1391 currently ignored). This should fix projects.maemo.org bug NB#56910
1392 for now. It should probably be removed when gconf notifications are
1395 2007-06-03 Christian Kellner <ckellner@openismus.com>
1397 * libmodest-dbus-client/libmodest-dbus-client.c:
1398 Removed debugging spew.
1400 * src/dbus_api/modest-dbus-callbacks.c:
1401 Added debugging info.
1403 * src/modest-search.c:
1404 (modest_search_all_accounts):
1405 Use tny_account_store_get_accounts () on the account store
1406 to get all accounts which is the way to get all accounts.
1408 * tests/dbus_api/test_search.c: (main):
1409 Make it possible to supply the search term on the command line.
1411 2007-06-03 Christian Kellner <ckellner@openismus.com>
1413 * libmodest-dbus-client/libmodest-dbus-client.c:
1414 * libmodest-dbus-client/libmodest-dbus-client.h:
1415 Implement searching for mesages over raw dbus. (Client side)
1417 * src/dbus_api/Makefile.am:
1418 * src/dbus_api/modest-dbus-api.h:
1419 * src/dbus_api/modest-dbus-callbacks.c:
1420 * src/dbus_api/modest-dbus-callbacks.h:
1421 Search framework (Server side). Also implement on_idle_open_message().
1423 * src/maemo/modest-platform.c: (modest_platform_init):
1424 Prepare for raw dbus/osso rpc interaction.
1426 * src/modest-search.h:
1427 Changed minsize from unspecific guint to guint32.
1429 * src/modest-search.c:
1431 Added strange hack which magically made tnymail work.
1433 (modest_search_folder),
1434 (modest_search_account),
1435 (modest_search_all_accounts):
1436 Implement helper functions to search all accounts, specific account
1439 * tests/dbus_api/Makefile.am:
1440 * tests/dbus_api/test_open_message.c:
1441 Read url to open from commandline.
1443 * tests/dbus_api/test_search.c:
1444 Implement small test for dbus search stuff
1446 2007-06-02 Armin Burgmeier <armin@openismus.com>
1448 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1449 include account type and account title. This fixes projects.maemo.org
1452 * src/maemo/modest-account-view-window.c: Set a title for the window.
1454 2007-06-02 Armin Burgmeier <armin@openismus.com>
1456 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1457 incoming and outgoing server name based on email address and server
1458 types as long as the names have not been edited manually. This fixes
1459 projects.maemo.org bug NB#58671.
1461 2007-06-02 Armin Burgmeier <armin@openismus.com>
1463 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1464 server type cannot be changed in future to the incoming details page
1465 when creating an account. This fixes projects.maemo.org bug NB#59029.
1467 2007-06-02 Armin Burgmeier <armin@openismus.com>
1469 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1470 and assigned max width chars so that they wrap instead of being
1471 truncated. Fixes projects.maemo.org bug NB#56126.
1473 2007-06-02 Armin Burgmeier <armin@openismus.com>
1475 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1476 introductory note to the connection specific smtp servers dialog, as
1477 section 8.12 of the email UI specification requires. This fixes
1478 projects.maemo.org bug NB#59212.
1480 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1482 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1483 Check for running mail operations, and offer to cancel them, as per the UI
1484 spec. This fixes projects.maemo.org bug NB#59041 .
1485 However, I suspect that tinymail may still use the network connection
1486 in ways that we cannot detect or cancel. But it should at least adapt to
1487 changes fairly well.
1489 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1491 * src/modest-tny-account-store.c: (recreate_all_accounts),
1492 (get_cached_accounts), (get_server_accounts): Do more sensible
1493 ref-counting of the temporarily-cached outbox accounts list. This seems
1494 to fix a crash when entering the password when the password was wrong.
1496 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1498 * src/gnome/modest-main-window.c: (connect_signals):
1499 * src/modest-tny-account-store.c: (get_password),
1500 (modest_tny_account_store_alert): Added comments and clues and
1501 commented-out code about how we currently fail to deal with connection
1502 errors and wrong passwords, and how we should.
1504 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1506 * src/widgets/modest-retrieve-combo-box.c:
1507 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1508 This fixes projects.maemo.org bug NB#58472 .
1510 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1512 * src/maemo/easysetup/modest-easysetup-wizard.c:
1513 (create_page_complete_easysetup):
1514 (create_page_complete_custom): Correct the last commit,
1515 putting the correct sentences in the correct pages.
1517 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1519 * src/maemo/easysetup/modest-easysetup-wizard.c:
1520 (create_page_complete_custom): Show the second sentence of text
1521 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1524 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1526 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1527 Set the leave-on-server conf key by default. This fixes
1528 projects.maemo.org bug NB#59258 .
1530 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1532 * src/maemo/modest-account-view-window.c:
1533 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1534 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1537 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1539 * src/maemo/easysetup/modest-easysetup-wizard.c:
1540 (create_caption_new_with_asterisk):
1541 * src/maemo/modest-account-settings-dialog.c:
1542 (create_caption_new_with_asterisk):
1543 Uncomment the code to add the asterisk, because they are no longer in the
1544 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1545 (update_incoming_server_title): Add an asterisk here too.
1547 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1549 * src/maemo/modest-maemo-global-settings-dialog.c:
1550 (current_connection): Check that we are even connected before trying to
1551 get the current connection name, to prevent a warning.
1553 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1554 Change the comments because tny_maemo_conic_device_connect() is now meant to
1556 * src/modest-mail-operation.c:
1557 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1558 make sure we have a connection and fail if we can't connect.
1560 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1562 * src/maemo/modest-main-window.c:
1563 (on_account_store_connecting_finished): Do not try to get the
1564 connection ID if we are not really connected. I am surprised that
1565 this signal handler is called when we are not connected.
1567 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1569 * src/modest-error.h:
1570 * src/modest-ui-actions.c:
1571 (modest_ui_actions_get_msgs_full_error_handler):
1572 Renamed an enum, added comments, added an enum
1573 for retrieve-limit errors.
1575 * src/modest-mail-operation.c: (foreach_add_item),
1576 (internal_folder_observer_update), (update_account_thread),
1577 (modest_mail_operation_get_msgs_full):
1578 (modest_mail_operation_update_account),
1579 Added comments about how this works, and some code that should
1580 (but does not) check the retrieve-limit. See the TODO comment.
1582 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1584 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1585 Initialize help_id to fix the build. Warnings are good.
1587 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1589 * src/widgets/modest-hbox-cell-renderer.c:
1590 (modest_hbox_cell_renderer_append):
1591 * src/widgets/modest-vbox-cell-renderer.c:
1592 (modest_vbox_cell_renderer_append):
1593 Fix the last commit by doing an extra ref.
1595 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1597 * src/widgets/modest-hbox-cell-renderer.c:
1598 (modest_hbox_cell_renderer_append):
1599 * src/widgets/modest-vbox-cell-renderer.c:
1600 (modest_vbox_cell_renderer_append):
1601 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1602 to fix the build with Maemo Bora.
1603 However, there seems to be a remaining crash, probably due to reference
1606 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1608 * src/modest-tny-account.c:
1609 (modest_tny_account_new_for_local_folders):
1610 Use hildon_file_system_info_async_new() to get a better name for
1611 the memory card account, setting it as the account name.
1612 The timing seems to work, but this is probably
1613 not the best place to do this. See the TODO comment.
1614 * src/maemo/modest-main-window.c: (create_details_widget):
1615 * src/widgets/modest-folder-view.c: (text_cell_data):
1616 Use the tny account name instead of hardcoding a name.
1618 2007-05-30 Christian Kellner <ckellner@openismus.com>
1620 * src/modest-search.c: (modest_search):
1621 Correctly set part_search_func even if we have already parsed
1622 the query and thus a valid OgsTextSearcher object.
1624 2007-05-30 Christian Kellner <ckellner@openismus.com>
1627 Search and check for libogs.
1630 Incooparte the ogs build env.
1632 * src/modest-mime-part-search-stream.c:
1633 * src/modest-mime-part-search-stream.h:
1634 Removed since we do the real searching now in modest-search.c.
1636 * src/modest-search.c:
1637 * src/modest-search.h:
1638 Implement support for ogs. We use that if available and requested
1639 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1640 should now handle the corner case when the search term is spread
1641 across multiple reads.
1642 Also the logic in modest_search () was corrected to search all
1643 requested fields until one is found.
1645 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1649 * src/modest-init.h:
1650 * src/modest-init.c: Made modest_init_local_folders() take a
1651 path and be public so we can iniitialize maildir folders on
1654 * src/modest-local-folder-info.h:
1655 * src/modest-local-folder-info.c:
1656 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1658 * src/modest-tny-account.c:
1659 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1660 still means the standard local-folders path on the local volume.
1662 * src/modest-tny-account-store.c:
1663 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1664 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1665 all accounts when that happens.
1666 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1667 this too, so it shows up in the treeview.
1669 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1671 * src/maemo/modest-maemo-global-settings-dialog.c:
1672 (current_connection):
1673 * src/widgets/modest-global-settings-dialog.c:
1674 (current_connection_default):
1675 Use the enum values instead of 0, 1 and -1,
1676 to make the code clearer.
1678 * src/modest-account-mgr-helpers.c:
1679 (modest_account_mgr_get_connection_specific_smtp): Make this code
1682 * src/modest-runtime.h:
1683 * src/modest-runtime.c:
1684 Added modest_runtime_remove_all_send_queues().
1685 * src/maemo/modest-main-window.c:
1686 (on_account_store_connecting_finished): Recreate the send queues,
1687 using the appropriate transport accounts for this new connection.
1688 Some futher adapting might be needed if the old send queues are not
1689 automatically stopped at this point.
1691 * src/modest-tny-account-store.c: (get_server_accounts):
1692 Create the connection-specific transport accounts, so that they can
1693 be found later by their ID.
1695 * src/modest-tny-account.h:
1696 * src/modest-tny-account.c:
1697 Added modest_tny_account_new_from_server_account_name().
1698 modest_tny_account_new_from_server_account(): Do not create the
1699 send queues here, because they will be
1700 recreated anyway when the connection changes for the first time.
1702 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1704 * src/modest-local-folder-info.h:
1705 * src/modest-local-folder-info.c:
1706 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1707 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1708 tbox_folder): Take a modest account name instead of a server TnyAccount,
1709 so we can have per-modest-account rather than per-transport-account
1711 We must make sure that we change or recreate the exisitng send queues
1712 when the connection changes for connection-specific transport accounts.
1714 * src/modest-tny-account-store.c:
1715 (create_per_account_local_outbox_folders): Create outboxed per modest
1716 account, not per transport account.
1718 * src/modest-tny-account.h:
1719 * src/modest-tny-account.c:
1720 (modest_tny_account_get_special_folder): For outboxes, get the
1721 parent modest account name. The account is ignored for other folders.
1722 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1723 modest account name rather than a server TnyAccount.
1725 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1727 * src/modest-tny-account.c:
1728 (modest_tny_account_new_from_server_account):
1729 Call modest_runtime_get_send_queue() immediately after creating transport
1730 accounts, so that they start trying to send email from the outbox as soon
1731 as possible at startup. This is probably what we want.
1733 * src/modest-mail-operation.c: (update_account_thread):
1734 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1735 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1736 * src/modest-tny-send-queue.h:
1737 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1738 (modest_ui_actions_on_send):
1739 Added comments about how sending works, though it needs some more work.
1741 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1743 * src/modest-tny-account.c:
1744 (modest_tny_account_get_special_folder): Add TODO because this fails when
1745 the network is busy.
1746 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1747 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1748 Do not try to show this window when there is no active account. The UI
1749 specs does not tell us what to do in this case.
1751 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1755 * src/maemo/Makefile.am:
1756 * src/widgets/Makefile.am: Some dist fixes.
1758 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1760 * src/maemo/modest-connection-specific-smtp-window.c:
1761 (on_button_edit): Make the code clearer, to prevent a double free.
1763 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1765 * src/maemo/modest-account-settings-dialog.c:
1766 (modest_account_settings_dialog_set_account_name),
1767 Check the connection-specific smtp servers checkbox if there are any.
1769 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1770 (modest_connection_specific_smtp_edit_window_init):
1771 Start with a suitable port number.
1773 * src/modest-account-mgr-helpers.h:
1774 * src/modest-account-mgr-helpers.c: Added
1775 modest_account_mgr_get_has_connection_specific_smtp().
1777 (modest_account_mgr_set_connection_specific_smtp),
1778 (modest_account_mgr_remove_connection_specific_smtp),
1779 (modest_account_mgr_get_has_connection_specific_smtp),
1780 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1781 connection-specific smtp server accounts in the account, rather than
1782 the server account conf dir.
1784 This fixes bug projects.maemo.org bug NB#58263 .
1786 * src/modest-tny-account-store.c:
1787 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1788 if there are no server accounts yet, to prevent an infinite loop when there
1789 are no accounts. Document that one must be called before the other.
1791 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-account-mgr-helpers.c:
1794 (modest_account_mgr_get_default_account): Make sure that at least
1795 one account is always the default, if there are any enabled accounts.
1796 This is just a sanity check that shouldn't be necessary.
1798 * src/modest-account-mgr-priv.c:
1799 (_modest_account_mgr_account_from_key): Unescape the conf key to
1800 get the real account name. For instance, this is an issue if a space
1801 was in the account name, which can happen because the account name
1802 is generated from the display name.
1803 (_modest_account_mgr_get_account_keyname): Always escape the
1805 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1806 Unescape the conf keys to get the real account names.
1808 For instance, previously the is-default radio button in the accounts
1809 list was not checked for any accounts at first. This fixes that,
1810 and might fix several similar bugs.
1812 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1815 Removed some debug printfs.
1817 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1819 Modest on-disk outbox directories are now here, for instance:
1820 $HOME/.modest/outboxes/<account-id-1>/outbox
1821 $HOME/.modest/outboxes/<account-id-2>/outbox
1823 $HOME/.modest/local-folders/outbox
1824 so we can have a separate outbox for each account.
1825 But they are shown as one outbox in the GtkTreeView, by using a
1826 TnyMergeFolder in a ModestTnySimpleFolderStore.
1829 * src/modest-tny-simple-folder-store.c:
1830 * src/modest-tny-simple-folder-store.h:
1831 Added ModestTnySimpleFolderStore, used to contain folders from
1832 other folder stores, such as other accounts.
1834 * src/modest-tny-outbox-account.h:
1835 * src/modest-tny-outbox-account.c:
1836 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1837 used for the per-account local outbox folders.
1839 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1840 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1841 only use this (internally) now for the non-outbox local folders.
1843 * src/modest-init.h:
1844 * src/modest-init.c: Added modest_init_one_local_folder(), for
1845 setting up the directory structure for each local folder.
1847 * src/modest-local-folder-info.c:
1848 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1849 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1851 * src/modest-local-folder-info.h:
1852 * src/modest-tny-account-store.c: (on_account_removed),
1853 (on_account_changed), (create_per_account_local_outbox_folders),
1854 (get_server_accounts), (modest_tny_account_store_get_accounts),
1855 (modest_tny_account_store_get_tny_account_by_account),
1856 (modest_tny_folder_store_is_virtual_local_folders):
1858 * src/modest-tny-account.h:
1859 * src/modest-tny-account.c:
1860 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1861 to create an on-disk per-account local outbox folder for each
1863 (create_per_account_local_outbox_folders): Create a local outbox folder
1864 for each transport account.
1865 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1866 for all local folders.
1868 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1869 instead of using g_object_get/set() directly. It is clearer.
1871 (modest_tny_folder_store_get_message_count),
1872 (modest_tny_folder_store_get_local_size
1873 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1874 because we now use these with non-acount folder stores.
1876 (modest_tny_account_get_special_folder),
1877 (modest_tny_account_new_from_server_account),
1878 (modest_tny_account_new_from_account):
1879 (recurse_folders): Adjust to the new outbox system.
1881 * src/modest-tny-folder.h:
1882 * src/modest-tny-folder.c:
1883 (modest_tny_folder_is_local_folder),
1884 (modest_tny_folder_get_local_folder_type),
1885 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1887 * src/widgets/modest-main-window.h:
1888 * src/maemo/modest-main-window.c: (create_details_widget),
1889 (modest_main_window_set_contents_style): Show details for any folder store,
1892 (modest_tny_folder_get_rules):
1893 Remove the const. C does not support constness enough for this.
1895 * src/modest-ui-actions.c:
1896 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1897 make all outboxes appear as one, in the usual local-folders tree node.
1899 (set_active_account_from_tny_account),
1900 (modest_ui_actions_on_folder_selection_changed):
1901 * src/widgets/modest-folder-view.c: (text_cell_data),
1902 (icon_cell_data), (filter_row),
1903 (add_account_folders_to_merged_folder),
1904 (add_account_folders_to_simple_folder_store), (),
1905 (get_cmp_rows_type_pos), (cmp_rows),
1906 (modest_folder_view_set_account_id_of_visible_server_account):
1907 Adjust to the new outbox system, using generic folder stores and folders
1908 in the GtkTreeModel.
1910 2007-05-23 Christian Kellner <ckellner@openismus.com>
1912 * src/modest-mail-operation.c:
1913 (modest_mail_operation_update_account):
1914 Use info->max_size instead of unintialized local var [small
1915 build fix]. (Added TODO to review that change since I don't
1918 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1920 * libmodest-dbus-client/libmodest-dbus-client.c:
1921 (libmodest_dbus_client_compose_mail): function added
1922 * src/dbus_api/modest-dbus-api.h:
1923 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1924 (on_compose_mail): Implementation of the SendAsMail functionality
1926 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1928 * src/modest-account-mgr.c:
1929 (modest_account_mgr_add_server_account): Set the secure-connection
1930 conf key for transport accounts as well as store accounts. I don't know
1931 why the if was there. For instance, this makes sure that we use SSL
1932 for the gmail preset from the easysetup wizard.
1934 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1936 * src/gnome/modest-main-window.c:
1937 (on_account_store_connecting_finished), (connect_signals):
1938 * src/maemo/modest-main-window.c:
1939 (on_account_store_connecting_finished), (connect_signals),
1940 (modest_main_window_new):
1941 Handle TnyAccountStore::connecting-finished instead of
1942 TnyDevice::connection-changed, because we cannot actually perform
1943 operations on accounts until TnyAccountStore has itself responded to
1944 the TnyDevice::connection-changed signal. This prevents a GError from
1946 Do not try to update at startup, because we (at least on scratchbox)
1947 already do an update at startup when the device goes online.
1948 This prevents a GError from tinymail.
1949 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1950 Added TODO about stopping simultaneous operations.
1952 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1954 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1955 * src/modest-mail-operation-queue.c:
1956 (modest_mail_operation_queue_remove):
1957 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1958 about where they happened.
1960 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1962 * src/modest-ui-actions.c:
1963 (modest_ui_actions_on_password_requested): Make sure that the remember
1964 output parameter is always TRUE.
1966 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1968 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1969 Show a OK/Cancel dialog if the error is a question, though we still do not
1970 know anything more about what we are asking the user.
1971 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1972 Fix an uninitialized variable (helper). This is a logic error, however.
1974 2007-05-21 Christian Kellner <ckellner@openismus.com>
1976 * src/modest-search.h:
1977 Correct bit shifting in the ModestSearchFlags enum.
1979 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-tny-account.c:
1982 (modest_tny_account_new_from_server_account): Do not use the lsub and
1983 check-all hard-coded IMAP options when using POP.
1985 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-tny-account.c:
1988 (modest_tny_account_new_from_server_account):
1989 Use NULL for the secure-auth method for POP when Password auth has been
1990 specified by the user, as we already do for IMAP. "auth=Login" causes
1991 an error from camel or the server.
1993 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/modest-account-settings-dialog.c:
1996 (create_page_account_details),
1997 (modest_account_settings_dialog_set_account_name):
1998 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1999 for the leave-on-server checkbox, rathr than just the checkbox, when
2000 the protocol is not POP.
2002 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2004 * src/widgets/modest-account-view.c:
2005 * src/widgets/modest-account-view.h:
2006 Added modest_account_view_select_account() which will be useful later
2007 to asynchronously re-select the edited account.
2009 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/modest-account-settings-dialog.c:
2012 (modest_account_settings_dialog_set_account_name):
2013 Automatically choose the port numbers based on the secure authentication
2014 methods, if they have not been chosen before.
2015 This fixes projects.maemo.org bug NB#56273 .
2017 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/modest-main-window-ui.h:
2020 * src/modest-ui-actions.c:
2021 * src/modest-ui-actions.h:
2022 Connect the Tools/SMTP Servers menu item to
2023 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2024 SMTP servers dialog, as in the UI specification and saves changes when it
2025 is closed. This fixed projects.maemo.org bug NB#56305 .
2027 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2029 * src/maemo/modest-connection-specific-smtp-window.c:
2030 (modest_connection_specific_smtp_window_init):
2031 Use gtk_window_set_default_size() to make this window big enough, so
2032 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2034 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2036 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2037 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2038 (modest_connection_specific_smtp_edit_window_init),
2039 Do not try to connect to a combobox signal before the combobox exists.
2040 This fixes the cras in projects.maemo.org bug NB#56288 .
2041 (modest_connection_specific_smtp_edit_window_get_settings):
2042 Remove the server_account_name parameter which was being checked for NULL
2043 though it was not used.
2045 * src/maemo/modest-connection-specific-smtp-window.c:
2046 (modest_connection_specific_smtp_window_fill_with_connections),
2047 (on_button_edit), (modest_connection_specific_smtp_window_init):
2048 Correct the number of treemodel columns to prevent a warning.
2049 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2050 libconic does not work.
2052 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2054 * src/modest-tny-account.c:
2055 (modest_tny_account_new_from_server_account):
2056 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2057 SMTP when "None" was chosen by the user. However, with my SMTP server that
2058 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2061 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2063 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2064 to explain the memory management issue with the ID in the ModestPair.
2066 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2067 (add_sending_page), (modest_account_assistant_finalize):
2068 * src/gnome/modest-gnome-global-settings-dialog.c:
2069 (create_updating_page), (create_composing_page):
2070 * src/gnome/modest-msg-edit-window.c: (get_transports),
2071 (init_window), (modest_msg_edit_window_finalize),
2072 (modest_msg_edit_window_get_msg_data):
2073 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2074 * src/gnome/modest-transport-widget.c:
2075 (modest_transport_widget_finalize), (smtp_configuration):
2076 * src/maemo/modest-maemo-global-settings-dialog.c:
2077 (create_updating_page), (create_composing_page):
2078 * src/maemo/modest-msg-edit-window.c: (get_transports),
2079 (init_window), (modest_msg_edit_window_finalize),
2080 (modest_msg_edit_window_get_msg_data),
2081 (modest_msg_edit_window_free_msg_data):
2082 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2083 (modest_store_widget_finalize):
2084 * src/maemo/modest-transport-widget.c:
2085 (modest_transport_widget_finalize), (smtp_configuration):
2086 * src/modest-main.c: (send_mail):
2087 * src/widgets/modest-combo-box.h:
2088 * src/widgets/modest-global-settings-dialog-priv.h:
2089 * src/widgets/modest-global-settings-dialog.c:
2090 (modest_global_settings_dialog_finalize):
2091 * src/widgets/modest-msg-edit-window.h:
2092 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2093 as long as the combo box, to prevent use of freed memory for the ID.
2095 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2097 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2098 get_accounts(), to make this clearer. Do not check for the enabled gconf
2099 key, because we do not use this for server accounts (at least, not yet).
2100 This allows us to send email again.
2102 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2104 * src/maemo/modest-platform.c:
2105 (on_modest_conf_update_interval_changed), (modest_platform_init):
2106 Only respond to this particular key change. All these strcmp()s cannot be
2109 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2111 * src/maemo/modest-maemo-global-settings-dialog.c:
2112 (current_connection): Prevent a crash in scratchbox when
2113 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2114 * src/maemo/modest-platform.c:
2115 (on_modest_conf_update_interval_changed), (modest_platform_init):
2116 Get the update interval from gconf and reset it when the gconf key changes.
2118 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2120 * src/modest-protocol-info.c:
2121 * src/modest-protocol-info.h: Adde enum-specific get functions,
2122 instead of using a ModestProtocolType enum parameter.
2124 * src/gnome/modest-account-assistant.c:
2125 * src/gnome/modest-store-widget.c:
2126 * src/gnome/modest-store-widget.h:
2127 * src/gnome/modest-transport-widget.c:
2128 * src/gnome/modest-transport-widget.h:
2129 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2130 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2131 * src/maemo/easysetup/modest-easysetup-wizard.c:
2132 * src/maemo/modest-account-settings-dialog.c:
2133 * src/maemo/modest-account-settings-dialog.h:
2134 * src/maemo/modest-store-widget.c:
2135 * src/maemo/modest-store-widget.h:
2136 * src/maemo/modest-transport-widget.c:
2137 * src/maemo/modest-transport-widget.h:
2138 * src/modest-account-mgr-helpers.c:
2139 * src/modest-account-mgr-helpers.h:
2140 * src/modest-account-mgr.c:
2141 * src/modest-account-mgr.h:
2142 * src/modest-tny-account.c:
2143 * src/modest-tny-folder.c:
2144 * src/widgets/modest-account-view.c:
2145 * src/widgets/modest-retrieve-combo-box.c:
2146 * src/widgets/modest-retrieve-combo-box.h:
2147 * src/widgets/modest-secureauth-combo-box.c:
2148 * src/widgets/modest-serversecurity-combo-box.c:
2149 * src/widgets/modest-serversecurity-combo-box.h:
2150 * tests/check_account-mgr.c:
2151 Use the specific functions, and use the re-renamed enum values for GNOME too.
2153 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2155 * src/modest-pair.h:
2156 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2157 so we can get the second based on the first.
2159 * src/maemo/modest-account-settings-dialog.h:
2160 * src/maemo/modest-account-settings-dialog.c:
2161 Added get_supported_secure_authentication_methods(), though it is mostly
2162 commented-out for now until the necessary API is committed to tinymail.
2163 (modest_account_settings_dialog_set_account_name),
2164 (save_configuration): Request the supported authentication methods from the
2165 server, so we can choose a working method.
2167 * src/modest-tny-account-store.h:
2168 * src/modest-tny-account-store.c:
2169 (modest_tny_account_store_get_session): Rename from
2170 tny_account_store_get_session().
2172 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2174 * src/modest-protocol-info.h: Split the ModestProtocol enum
2175 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2176 There was no need to have these unrelated values in one enum.
2178 * src/: many files: Adapted to changed enum. This makes the code a bit
2179 clearer, and the compiler could catch some errors.
2181 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2184 Show the detailed internal camel error message when an error happens
2185 during the configuration, so that our testers can give us more clues.
2186 For instance, in projects.maemo.org bug NB#56910 .
2188 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2190 * src/modest-tny-account.c:
2191 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2192 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2194 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2196 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2197 * src/maemo/modest-account-settings-dialog.c:
2198 (modest_account_settings_dialog_set_account_name),
2199 (save_configuration): For the incoming secure authentication checkbox,
2200 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2201 the UI specification. PLAIN does not seem to be supported for most IMAP
2202 servers anyway, and I am not sure what it would mean.
2203 However, we probably need to discover which of the secure-authentication
2204 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2205 * src/modest-account-mgr-helpers.c:
2206 (modest_account_mgr_get_server_account_data):
2208 * src/modest-tny-account.c:
2209 (modest_tny_account_new_from_server_account):
2210 Use tny_account_set_mech() to set secure-authentication methods,
2211 with some special-casing for IMAP, based on my observations of how
2214 * src/modest-account-mgr-helpers.h:
2215 * src/modest-account-mgr.c:
2216 * src/modest-defs.h: Comment that the URI is only used for local folders.
2218 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2220 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2221 parameter const, just to be neat.
2222 * src/modest-text-utils.c: (modest_text_utils_inline):
2223 End g_strconcat() with NULL, as its documentation says. This is almost
2224 certainly the cause of my crash at startup on the device. Interestingly,
2225 valgrind doesn't tell us about these errors.
2227 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2229 * scripts/build-packages: Added more precise comments about how to use
2230 this script, though I still get this error:
2231 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2232 error building tinymail
2234 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2236 * src/maemo/modest-main-window.c: (on_account_update):
2237 Very slight cleanup, hoping to make it simpler to discover what causes
2238 a crash here sometimes.
2240 * src/modest-tny-account.c:
2241 (modest_tny_account_new_from_server_account): Set the port. Added
2242 comments about the options and a TODO comment because I need to find out
2243 how to specify the secure authentication method.
2245 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2247 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2248 changed CFlags paths form modest to libmodest
2250 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2252 * src/modest-account-mgr-helpers.c:
2253 (modest_account_mgr_get_server_account_data),
2254 (modest_account_mgr_free_server_account_data):
2255 * src/modest-account-mgr-helpers.h:
2256 * src/modest-account-mgr.c:
2257 (modest_account_mgr_add_server_account):
2258 * src/modest-defs.h:
2259 * src/modest-tny-account.c:
2260 (modest_tny_account_new_from_server_account):
2261 Determine the options for tny_camel_account_add_option() here,
2262 based on the settings, rather than storing them directly in gconf.
2264 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2266 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2267 Show a more friendly error dialog now that we expect (from the tinymail
2268 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2270 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2272 * src/maemo/modest-main-window.c: (on_account_update): Check that
2273 account_name is not NULL, to prevent a crash at startup that I am
2274 seeing on the N800. I do wonder why it is NULL.
2276 * src/maemo/easysetup/modest-easysetup-wizard.c:
2277 (create_page_user_details):
2278 * src/maemo/modest-account-settings-dialog.c:
2279 (create_page_user_details), (create_page_outgoing):
2280 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2281 (modest_connection_specific_smtp_edit_window_init):
2282 * src/modest-ui-actions.c:
2283 (modest_ui_actions_on_password_requested):
2284 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2285 might do something useful with the on-screen keyboard.
2287 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2289 * src/maemo/modest-main-window.c: (on_account_update):
2290 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2291 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2293 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-tny-account-store.c: (on_account_changed):
2296 Correct the signature of this signal handler.
2298 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2300 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2301 Show a HildonNote instead of a GtkDialog for Maemo.
2303 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2305 * src/widgets/modest-account-view.h:
2306 * src/widgets/modest-account-view.c: (on_account_changed),
2307 (on_account_removed). Added a boolean flag, set/unset by
2308 modest_account_view_block_conf_updates(),
2309 modest_account_view_unblock_conf_updates() to prevent unnecessary
2310 updates, but this is not very useful because the gconf notifications are
2311 so delays (maybe only on Maemo Bora).
2312 So auto-updating is turned off, and these functions do an explicit
2313 update when necessary.
2314 However, something else is still doing too much work when adding/removing
2315 accounts, probably in another part of the application.
2317 * src/maemo/modest-account-view-window.c:
2318 (on_delete_button_clicked), (on_edit_button_clicked),
2319 (on_new_button_clicked): Use the new functions.
2321 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2323 * src/modest-account-mgr-helpers.c:
2324 (modest_account_mgr_set_first_account_as_default):
2325 Sort the list of names alphabetically-by-title, so we choose the first one
2327 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2328 alphabetically by the title.
2330 This fixes projects.maemo.org bug NB#56418 .
2332 * src/modest-account-mgr-priv.c:
2333 (_modest_account_mgr_account_from_key):
2334 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2335 avoid a valgrind error, and possible random behaviour.
2337 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2339 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2340 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2341 tinymail documentation to say that this can be expected.
2342 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2343 pretty, and should not happen, but I would prefer to know when it does.
2345 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2347 * configure.ac: When using the older hildon version, probably on Bora,
2348 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2350 * src/widgets/modest-attachment-view.c:
2351 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2354 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2356 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2357 Implemented the prototype. Can be tested with
2358 tests/dbus_api/test_open_message:
2360 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2362 * src/modest-tny-account-store.c:
2363 (modest_tny_account_store_instance_init), (get_password):
2364 * src/modest-ui-actions.c:
2365 (modest_ui_actions_on_password_requested):
2366 Do not store the password in gconf, because this function is called
2367 for non-remembered passwords. Actually use the cached (in the hash map)
2368 password instead of releasing it.
2369 The password will now not be remembered if it is asked via the protected
2370 password dialog, as per the UI spec.
2372 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2374 * src/modest-defs.h:
2375 * src/modest-account-mgr-helpers.h:
2376 * src/modest-account-mgr-helpers.c:
2377 Added modest_server_account_get_username_has_succeeded(),
2378 modest_server_account_set_username_has_succeeded().
2379 (modest_server_account_set_username),
2380 Reset the has-succeeded flag if the username changes.
2382 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2383 * src/maemo/modest-connection-specific-smtp-window.c:
2384 (modest_connection_specific_smtp_window_save_server_accounts):
2385 Use modest_server_account_set_username() instead of using
2386 modest_conf_set_string() directly, so that the has-succeeded flag is always
2389 * src/modest-ui-actions.c:
2390 (modest_ui_actions_on_password_requested): Dim the username entry if
2391 the username has ever worked, as per the UI spec.
2393 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2395 * src/modest-tny-account-store.c: (get_password):
2396 * src/modest-ui-actions.c:
2397 (modest_ui_actions_on_password_requested):
2398 Allow the username to be changed too, though there is more work to
2399 be done on exactly how this behaves.
2401 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-account-mgr-helpers.h:
2404 * src/modest-account-mgr-helpers.c:
2405 Added modest_account_mgr_get_display_name(),
2406 modest_server_account_get_username(),
2407 modest_server_account_set_username(),
2408 modest_server_account_set_password(),
2409 modest_server_account_get_hostname() functions so we do not need to
2410 use the conf API directly.
2412 * src/maemo/modest-main-window.c: (connect_signals):
2413 Actually connect ot the ModestAccountStore::request-password signal,
2414 so that we show the dialog when the password is requested by Tinymail,
2415 for isntance if it is empty.
2417 * src/modest-marshal.list:
2418 * src/modest-tny-account-store.c:
2419 (modest_tny_account_store_class_init), (get_password),
2420 (modest_tny_account_store_alert):
2421 * src/modest-tny-account-store.h:
2422 * src/modest-ui-actions.h:
2423 * src/modest-ui-actions.c:
2424 (modest_ui_actions_on_password_requested):
2425 Change the signal parameters, so it is obvious that we are providing
2426 the non human-readable server name, and receiving both the username
2427 and password, though changing of the username is not yet implemented.
2428 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2429 for the GNOME version.
2431 This should fix the projects.maemo.org bug NB#56209, though it does not
2432 work on Bora, because the gconf_client_get() for the password fails
2433 immediately after we save it with gconf_client_set().
2435 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2438 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2439 caused an undefined symbol error:
2440 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2442 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2444 * src/modest-tny-account-store.c:
2445 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2446 using a GError instead of a string message, so we can translate it in
2449 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2451 * src/maemo/modest-address-book.c:
2452 (modest_address_book_check_names):
2453 * src/maemo/modest-msg-view-window.c:
2454 (modest_msg_view_window_clipboard_owner_change):
2455 * src/modest-init.c: (modest_init_init_ui):
2456 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2457 (update_folders_cb), (modest_mail_operation_update_account):
2458 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2459 (modest_ui_actions_on_msg_attachment_clicked),
2460 (modest_ui_actions_on_msg_recpt_activated):
2461 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2462 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2463 (modest_msg_view_search_next):
2464 * src/widgets/modest-recpt-editor.c:
2465 (modest_recpt_editor_on_button_release_event),
2466 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2467 g_message(). At this point we should only be seeing interesting errors on
2468 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2470 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2472 (modest_wizard_dialog_force_title_update):
2473 * src/maemo/easysetup/modest-wizard-dialog.h:
2474 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2475 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2476 can update the title when appropriate. Otherwise the title is wrong if the
2477 pages are added after adding the notebook to the dialog.
2478 This must be a problem in HildonWizardDialog too.
2479 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2481 * src/maemo/easysetup/modest-easysetup-wizard.c:
2482 (create_subsequent_customsetup_pages),
2483 (create_subsequent_easysetup_pages):
2484 Call modest_wizard_dialog_force_title_update() so that the title is
2485 correct even with GTK+ < 2.10.
2486 This fixes projects.maemo.org bug NB#56145 .
2488 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2490 * src/maemo/modest-platform.c:
2491 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2492 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2495 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2497 * src/widgets/modest-window.h:
2498 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2499 and modest_window_save_state(), which invokes it.
2501 * src/widgets/modest-window-mgr.h:
2502 * src/widgets/modest-window-mgr.c:
2503 Added modest_window_mgr_save_state_for_all_windows(), which calls
2504 the save_state vfunc on all registered windows, if implemented.
2506 * src/gnome/modest-msg-edit-window.c:
2507 * src/gnome/modest-msg-view-window.c:
2508 * src/maemo/modest-msg-edit-window.c:
2509 * src/maemo/modest-msg-view-window.c:
2510 * src/maemo/modest-main-window.c:
2511 Specify the existing save_settings functions as implementations of
2512 ModestWindow::save_state_func().
2514 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2515 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2516 enabling hibernation, for instance.
2518 We may need to do the same thing for restoring settings.
2521 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2523 * src/widgets/modest-window-mgr.c:
2524 * src/widgets/modest-window-mgr.h:
2525 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2526 modest_window_mgr_get_hibernation_is_prevented().
2528 * src/maemo/modest-main-window.c:
2529 (on_hildon_program_is_topmost_notify): Prevent hibernation
2530 (possible when the application goes to the background in the WM),
2531 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2533 * src/maemo/easysetup/modest-easysetup-wizard.c:
2534 (modest_easysetup_wizard_dialog_init):
2535 * src/maemo/modest-account-settings-dialog.c:
2536 (modest_account_settings_dialog_init):
2537 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2538 (modest_connection_specific_smtp_edit_window_init):
2539 * src/maemo/modest-connection-specific-smtp-window.c:
2540 (modest_connection_specific_smtp_window_init):
2541 * src/maemo/modest-signature-editor-dialog.c:
2542 (modest_signature_editor_dialog_init):
2543 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2544 prevent hibernation while any of these account settings dialogs are open.
2546 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/Makefile.am:
2549 * src/maemo/modest-osso-state-saving.c:
2550 * src/maemo/modest-osso-state-saving.h: Added
2551 modest_osso_load_state() and modest_osso_save_state() though they do
2552 nothing now. They should iterate through all the open windows and load/save
2554 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2555 save state when closing.
2557 * src/maemo/modest-main-window.c:
2558 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2559 Add a notification handler for the HildonProgram::is-topmost property,
2560 so we can allow hibernation when the application goes into the background.
2561 But we still need to detect when the accounts setup windows are open so
2562 we can stop hibernation when they are open.
2563 To do this, I also added the main window the HildonProgram. This might have
2564 other side-effects/benefits, and should maybe be done for other windows.
2566 * src/maemo/modest-osso-autosave-callbacks.h:
2567 * src/maemo/modest-osso-autosave-callbacks.c:
2568 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2569 though it does not do anything yet, and we might never need this to do
2570 anything. For instance, we already save drafts.
2572 * src/maemo/modest-platform.c: (modest_platform_init):
2573 Specify the libosso auto-save callback.
2575 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2577 * src/maemo/modest-platform.c:
2578 (modest_platform_set_update_interval):
2579 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2580 aparently stays valid between application instances, so we can use this
2581 to remove and reset it later. According to a maemo-developers email from
2584 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2586 * configure.ac: Depend on libalarm for Maemo.
2588 * src/dbus_api/modest-dbus-api.h:
2589 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2590 (on_send_receive), (modest_dbus_req_handler):
2591 Handle a SEND_RECEIVE D-Bus method.
2593 * libmodest-dbus-client/libmodest-dbus-client.c:
2594 (libmodest_dbus_client_send_and_receive):
2595 * libmodest-dbus-client/libmodest-dbus-client.h:
2596 Add C convenience functions for calling the new D-Bus method.
2598 * src/modest-platform.h:
2599 * src/gnome/modest-platform.c:
2600 * src/maemo/modest-platform.c:
2601 Added modest_platform_set_update_interval(), which uses the
2602 alarmd API on Maemo.
2603 (modest_platform_init),
2604 Call modest_platform_set_update_interval(), using a hard-coded
2605 interval for now (until the global settings dialog is implemented),
2606 though I am not sure that this makes sense yet.
2608 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2610 * src/dbus_api/modest-dbus-callbacks.c:
2611 (modest_osso_cb_hw_state_handler):
2612 * src/dbus_api/modest-dbus-callbacks.h:
2613 * src/maemo/modest-platform.c: (modest_platform_init):
2614 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2615 in case this has some effect on the ability for Maemo to ping the
2618 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2620 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2621 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2622 warning. It is probably a logic error, but I need to fix the build.
2624 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2626 * src/modest-account-mgr.h:
2627 * src/modest-account-mgr.c:
2628 (modest_account_mgr_account_names): Add a gboolean enabled_only
2629 parameter, so we can get lists of onlt the enabled accounts.
2631 (modest_account_mgr_add_account),,
2632 (modest_account_mgr_account_with_display_name_exists):
2633 * src/maemo/modest-msg-edit-window.c: (get_transports):
2634 * src/modest-account-mgr-helpers.c:
2635 (modest_account_mgr_set_first_account_as_default):
2636 * src/modest-init.c: (init_default_account_maybe):
2637 * src/modest-tny-account-store.c: (get_accounts):
2638 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2639 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2640 * tests/check_account-mgr.c: (START_TEST):
2641 Provide the extra parameter, as appropriate.
2643 * src/widgets/modest-account-view.c: (update_account_view):
2644 Do not show disabled accounts (meaning that there is no way to
2645 enable/disable accounts in the UI (the feature is not in our UI
2646 specification), so we can use this internally only to mark unfinished
2647 or temporary account data.
2649 * src/maemo/easysetup/modest-easysetup-wizard.c:
2650 (create_account): Add boolean enable parameter, so we can specify FALSE
2651 to create the temporary account.
2652 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2653 (on_before_next): When finishing, when there is a temporary account, just
2655 Also, use a timeout to delay the showing of the dialog until gconf is likely
2656 to return correct information, due to a maemo gconf bug that is fixed in
2657 osso 1.1, but not yet in Bora.
2658 However, the dialog stays on screen after it is destroyed.
2660 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2661 for invalid data when cancelling. Use a hildon note instead of a dialog
2662 to complain about invalid data. Do not show the account-saved note if the
2663 account is disabled (a temporary account that will not really be saved for use
2666 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2668 * src/modest-account-mgr-helpers.h:
2669 * src/modest-account-mgr-helpers.c:
2670 Added modest_account_mgr_unset_default_account(),
2671 Added modest_account_mgr_set_first_account_as_default().
2673 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2674 If it was the default account, unset the default account name.
2676 * src/maemo/modest-account-view-window.c:
2677 (on_delete_button_clicked): If it was the default account,
2678 set the first remaining account as the default instead.
2680 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2681 a NULL account or a NULL default account, to prevent a crash. This should
2682 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2685 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2687 * src/widgets/modest-recpt-editor.c:
2688 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2689 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2690 TODO comment for this. This fixes the build.
2692 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2693 be the best place for it. This will in future update all auto-update accounts,
2694 rather than just the current/default account, when that gconf key exists.
2695 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2696 if there are no accounts, before calling do_send_receive().
2697 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2699 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2700 * src/maemo/modest-main-window-ui.h:
2701 * src/maemo/modest-main-window.c: (on_connection_changed),
2702 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2703 directly, becaue the signal handler does more.
2705 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-account-mgr-helpers.c:
2708 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2709 for the case that the account does not exist.
2711 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2712 (equivalent to the modest account name) rather than the tinymail account name
2713 (equivalent to the modest account title - human readable) to get the account data.
2714 Check for null account data to prevent the crash, and add a TODO comment saying that
2715 this needs fixing because it is using the server account name instead of the account name.
2717 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2719 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2720 * src/maemo/modest-account-settings-dialog.c: (show_error),
2722 Use hildon_note_new_information() for informative and error messages,
2723 which seems to be expected for Maemo applications (no documentation that I know of
2724 says this). I am surprised that there is no distinction between info and error
2727 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2729 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2730 it is easy to find where this is used.
2732 * src/maemo/easysetup/modest-easysetup-wizard.c:
2733 (create_page_welcome), (create_page_account_details),
2734 (create_page_user_details), (create_page_complete_easysetup),
2735 (create_page_custom_incoming), (create_page_custom_outgoing),
2736 (create_page_complete_custom):
2737 * src/maemo/modest-account-settings-dialog.c:
2738 (create_page_account_details), (create_page_user_details),
2739 (create_page_incoming), (create_page_outgoing):
2740 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2742 (modest_connection_specific_smtp_edit_window_init):
2743 * src/maemo/modest-connection-specific-smtp-window.c:
2744 (modest_connection_specific_smtp_window_init):
2745 * src/maemo/modest-signature-editor-dialog.c:
2746 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2747 and scrolling policy as per the Email Application Layout Guide, if I have
2750 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2752 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2753 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2754 which were empty, because these vfuncs have been removed from TnyAccountStore.
2755 This fixes the build.
2757 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2759 * src/maemo/modest-main-window.c:
2760 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2761 showing/hiding it. Added TODO because it probably should not be NULL.
2762 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2763 because unnecessary g_warnings() make degugging difficult.
2765 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2767 * src/maemo/modest-msg-edit-window.c:
2768 (modest_msg_edit_window_select_color),
2769 (modest_msg_edit_window_select_background_color): 2 const corrections and
2770 moving 2 #endifs before closing brackets, to fix the build.
2772 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2774 * src/maemo/easysetup/modest-easysetup-wizard.h:
2775 * src/maemo/easysetup/modest-easysetup-wizard.c:
2776 (modest_easysetup_wizard_dialog_finalize),
2777 (on_button_edit_advanced_settings), (create_page_complete_custom),
2778 (on_response), (create_account):
2779 Implement the Advanced Settings edit button, by saving the account information,
2780 for the Advanded Settings dialog to use directly from gconf, and removing it
2781 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2782 Bug #5533 in the projects.maemo.org bugzilla.
2784 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2786 * src/maemo/modest-msg-view-window.c:
2787 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2788 when opening a message window.
2790 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2792 * src/maemo/easysetup/modest-easysetup-wizard.c:
2793 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2796 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2797 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2798 gconf settings. I probably added more checks than necessary, but that is safer.
2800 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2801 variable to fix the build, but this seems to be used when it is still NULL.
2803 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2805 * src/modest-platform.h:
2806 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2807 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2808 * src/modest-main.c: Implement this function so we can avoid using
2809 maemo-specific API from cross-platform code.
2811 * src/modest-tny-account-store.c:
2812 (get_smtp_specific_transport_account_for_open_connection):
2813 * src/modest-ui-actions.c: (check_for_connection),
2814 (modest_ui_actions_on_item_not_found):
2815 Use modest_platform_connect_and_wait() and put #idefs around other
2816 maemo-specific code, because only maemo currently has a way to
2817 identify connection names.
2819 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2821 * src/modest-tny-account-store.h:
2822 * src/modest-tny-account-store.c:
2823 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2824 the connection-specific SMTP server settings in the configuration.
2826 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2828 * src/maemo/modest-main-window.c: (on_connection_changed),
2830 * src/modest-main.c: (main), (start_ui), (send_mail):
2831 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2832 that is what is intended.
2834 * src/modest-ui-actions.c: (action_send), (action_receive),
2835 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2836 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2837 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2838 SMTP server is used when it is specified.
2840 (modest_ui_actions_on_send_receive):
2841 Check that a connection is open before proceeding.
2842 Receive and then send, instead of vice-versa, as per the specification.
2844 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2846 * src/modest-mail-operation.c:
2847 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2848 though I guess it should be something other than NULL.
2850 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2852 * src/maemo/easysetup/modest-easysetup-wizard.c:
2853 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2854 combo twice, to avoid an g_warning and to make it visible again.
2855 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2856 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2857 (already intended) dereference when detaching, because we then recreate the menu.
2858 But I am not sure why the warning was happening, and it is possible that this is a memory
2861 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2863 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2864 and uri_parse_mailto() utility functions.
2865 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2867 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2869 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2871 * src/dbus_api/modest-dbus-api.h:
2872 * src/dbus_api/modest-dbus-callbacks.c:
2873 Use an idle callback to execute the modest code in the application's own thread.
2874 Remove the helloworld example method.
2875 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2876 parsed, and the open-message method is not implemented because this is not yet implemented in
2878 * libmodest-dbus-client/libmodest-dbus-client.c:
2879 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2880 (libmodest_dbus_client_open_message):
2881 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2883 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2884 body without crashing.
2886 * tests/dbus_api/Makefile.am:
2887 * tests/dbus_api/test_mail_to.c:
2888 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2890 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2892 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2893 Added file to fix the build. Sorry.
2895 * src/dbus_api/Makefile.am:
2896 * src/dbus_api/modest-dbus-api.h:
2897 * src/dbus_api/modest-dbus-callbacks.h:
2898 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2899 (modest_dbus_req_handler):
2900 Put constants in a separate header so it can be reused by the
2901 client library, without duplication
2903 * libmodest-dbus-client/Makefile.am:
2904 * libmodest-dbus-client/libmodest-dbus-client.c:
2905 (libmodest_dbus_client_call_helloworld),
2906 (libmodfest_dbus_client_send_mail),
2907 (libmodfest_dbus_client_mailto),
2908 (libmodfest_dbus_client_open_message):
2909 * libmodest-dbus-client/libmodest-dbus-client.h:
2910 (Partly) Implement a send_mail D-Bus method.
2912 * tests/dbus_api/Makefile.am:
2913 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2914 the send_email D-Bus method.
2916 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2920 * libmodest-dbus-client/Makefile.am:
2921 * libmodest-dbus-client/libmodest-dbus-client.c:
2922 * libmodest-dbus-client/libmodest-dbus-client.h:
2923 * tests/dbus_api/Makefile.am:
2924 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2925 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2927 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2929 * src/maemo/easysetup/modest-easysetup-wizard.c:
2930 (create_page_account_details):
2931 * src/maemo/modest-account-settings-dialog.c:
2932 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2933 widgets, because this might not be the default in future versions of the Maemo GTK+.
2934 However, I can not not get capitalization to work even in a simple test case.
2936 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2938 * src/maemo/easysetup/modest-easysetup-wizard.c:
2939 (create_page_custom_incoming), (create_page_custom_outgoing):
2940 * src/maemo/modest-account-settings-dialog.c:
2941 (create_page_account_details), (create_page_incoming),
2942 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2943 instead of using gtk_check_button_with_label(), so they are aligned like the other
2944 widgets, as per the UI spec.
2946 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2948 * src/maemo/easysetup/modest-easysetup-wizard.c:
2949 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2950 * src/widgets/modest-validating-entry.c:
2951 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2952 Modest prefix instead of an EasySetup prefix.
2954 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2956 * src/widgets/modest-validating-entry.h:
2957 * src/widgets/modest-validating-entry.c: (on_insert_text),
2958 Added easysetup_validating_entry_set_max_func(), used to set a callback
2959 to call when the max number of characters is reached. GtkEntry has a max-length
2960 already but is silent about it.
2962 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2963 (create_page_account_details), (create_page_user_details),
2965 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2966 (create_page_account_details), (create_page_user_details),
2967 (create_page_outgoing):
2968 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2969 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2970 the UI spec, when the user tries to enter more than the max number of characters.
2972 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/easysetup/modest-easysetup-wizard.c:
2975 (create_page_user_details), (create_page_custom_incoming),
2976 (create_page_custom_outgoing):
2977 * src/maemo/modest-account-settings-dialog.c:
2978 (create_page_user_details), (create_page_incoming),
2979 (create_page_outgoing):
2980 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2981 (modest_connection_specific_smtp_edit_window_init):
2982 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2983 not appropriate. Bad Maemo-specific defaults!.
2985 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2987 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2988 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2989 (modest_signature_editor_dialog_set_settings):
2990 Disable the label and textview when the checkbox is disabled, and use the
2991 specified (UI spec) default signature text.
2993 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2995 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2996 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2998 * src/modest-defs.h:
2999 * src/modest-account-mgr-helpers.h:
3000 * src/modest-account-mgr-helpers.c:
3001 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3003 * src/maemo/Makefile.am:
3004 * src/maemo/modest-signature-editor-dialog.c:
3005 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3008 * src/maemo/modest-account-settings-dialog.h:
3009 * src/maemo/modest-account-settings-dialog.c:
3010 (modest_account_settings_dialog_finalize), (on_button_signature),
3011 (save_configuration): Use the new dialog when the Edit button is pressed, and
3012 save the changes if necessary, as per the UI spec.
3014 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3016 * src/maemo/Makefile.am:
3017 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3018 based on maemo-develoers email from Dirk.
3020 * src/maemo/easysetup/modest-easysetup-wizard.c:
3021 (create_page_welcome), (create_page_account_details),
3022 (create_page_user_details), (create_page_complete_easysetup),
3023 (create_page_custom_incoming), (create_page_custom_outgoing),
3024 (create_page_complete_custom),
3025 (modest_easysetup_wizard_dialog_init):
3026 * src/maemo/modest-account-settings-dialog.c:
3027 (create_page_account_details), (create_page_user_details),
3028 (create_page_incoming), (create_page_outgoing),
3029 (modest_account_settings_dialog_init):
3030 * src/maemo/modest-connection-specific-smtp-window.c:
3031 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3033 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/easysetup/modest-easysetup-wizard.c:
3036 (create_page_account_details), (create_page_custom_outgoing),
3037 (create_page_complete_custom):
3038 * src/maemo/modest-account-settings-dialog.c:
3039 (create_page_user_details), (create_page_incoming),
3040 (create_page_outgoing):
3041 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3042 (modest_connection_specific_smtp_edit_window_init):
3043 Use the correct (UI spec) port min/max, and use horizontal separators,
3046 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3048 * src/maemo/easysetup/modest-easysetup-wizard.c:
3049 (set_default_custom_servernames):
3050 * src/maemo/modest-account-settings-dialog.c:
3051 (create_page_incoming), (on_combo_outgoing_security_changed),
3052 (on_combo_incoming_security_changed), (create_page_outgoing),
3053 (modest_account_settings_dialog_set_account_name),
3054 (save_configuration):
3055 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3056 (on_combo_security_changed),
3057 (modest_connection_specific_smtp_edit_window_init),
3058 (modest_connection_specific_smtp_edit_window_set_connection),
3059 (modest_connection_specific_smtp_edit_window_get_settings):
3060 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3063 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3066 * src/maemo/easysetup/modest-easysetup-wizard.c:
3067 (create_page_custom_outgoing), (create_page_complete_custom):
3068 * src/maemo/modest-account-settings-dialog.c:
3069 (create_page_user_details), (create_page_outgoing):
3070 * src/maemo/modest-account-view-window.c: (button_box_new):
3071 Use changed logical IDs as per the most recent UI spec:
3072 mcen_bd_emailsetup_edit -> mcen_bd_edit
3073 mcen_bd_emailsetup_delete -> mcen_bd_delete
3074 mcen_bd_emailsetup_close -> mcen_bd_close
3076 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3080 * src/dbus_api/Makefile.am:
3081 * src/dbus_api/modest-dbus-callbacks.c:
3082 * src/dbus_api/modest-dbus-callbacks.h:
3083 * src/maemo/modest-platform.c: (modest_platform_init):
3084 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3086 * tests/Makefile.am:
3087 * tests/dbus_api/Makefile.am:
3088 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3090 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3092 * src/maemo/modest-account-settings-dialog.c:
3093 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3094 Removed unnecessary includes.
3096 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3098 * src/maemo/easysetup/modest-easysetup-wizard.c:
3099 * src/maemo/modest-account-settings-dialog.c:
3100 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3101 * src/widgets/Makefile.am:
3102 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3103 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3104 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3105 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3106 * src/widgets/modest-secureauth-combo-box.c:
3107 * src/widgets/modest-secureauth-combo-box.h:
3108 * src/widgets/modest-serversecurity-combo-box.c:
3109 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3110 made the GObject names more consistent with the rest of the Modest code.
3112 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3114 * src/maemo/easysetup/Makefile.am:
3115 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3116 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3117 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3118 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3119 * src/maemo/easysetup/modest-easysetup-wizard.c:
3120 * src/maemo/easysetup/modest-validating-entry.c:
3121 * src/maemo/easysetup/modest-validating-entry.h:
3122 * src/maemo/modest-account-settings-dialog.c:
3123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3124 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3125 widgets/ because they are used outside of easysetup too. After checking in,
3126 svn will allow me to rename them too.
3128 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3130 * src/gnome/modest-msg-edit-window.c:
3131 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3132 linker error, to fix the build on the GNOME platform.
3133 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3134 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3135 ifdefed out to avoid a warning.
3137 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3139 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3140 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3141 some alternative for GTK+ 2.6.
3143 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3145 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3147 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3148 specified for EmailAccountsDialog in UI spec.
3150 * src/maemo/easysetup/modest-easysetup-wizard.c:
3151 * src/maemo/easysetup/modest-easysetup-wizard.h:
3152 * src/maemo/modest-account-settings-dialog.c:
3153 * src/maemo/modest-account-settings-dialog.h:
3154 Reuse a member window widget for the connection-specific SMTP server accounts,
3155 so we can tell it to create/save the accounts only if we actually save changes.
3157 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3158 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3159 (modest_connection_specific_smtp_edit_window_get_settings):
3160 Return a struct instance for temporarily remembering the entered data.
3162 * src/maemo/modest-connection-specific-smtp-window.h:
3163 * src/maemo/modest-connection-specific-smtp-window.c:
3164 (modest_connection_specific_smtp_window_finalize),
3165 (modest_connection_specific_smtp_window_fill_with_connections),
3167 (modest_connection_specific_smtp_window_save_server_accounts),
3168 (update_model_server_names): Do not actually save data until asked,
3169 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3171 (on_selection_changed),
3172 (modest_connection_specific_smtp_window_init): Disable the edit
3173 button when nothing is selected.
3175 * src/modest-account-mgr-helpers.c:
3176 * src/modest-account-mgr-helpers.h:
3177 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3180 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3182 * src/modest-account-mgr-helpers.h:
3183 * src/modest-account-mgr-helpers.c:
3184 (modest_account_mgr_get_unused_account_name),
3185 (modest_account_mgr_get_unused_account_display_name): Added these
3186 utility functions, to avoid code duplication.
3188 * src/maemo/easysetup/modest-easysetup-wizard.c:
3189 (create_page_account_details), (create_account):
3190 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3191 (on_combo_security_changed),
3192 (modest_connection_specific_smtp_edit_window_init),
3193 (modest_connection_specific_smtp_edit_window_save_settings):
3194 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3195 * src/maemo/modest-connection-specific-smtp-window.c:
3196 (modest_connection_specific_smtp_window_finalize),
3197 (modest_connection_specific_smtp_window_fill_with_connections),
3198 (on_button_edit), (modest_connection_specific_smtp_window_init):
3199 * src/maemo/modest-connection-specific-smtp-window.h:
3200 Implementing saving of connection-specific server accounts.
3202 But I need to refactor this so we can save the data for each
3203 possible connection-specific account and only actually create the server accounts
3204 when the easysetup finished, or the OK button is pressed on the account settings
3207 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3209 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3210 (on_combo_security_changed):
3211 (modest_connection_specific_smtp_edit_window_init):
3212 Auto-fill the port number as in the account settings.
3214 (modest_connection_specific_smtp_edit_window_set_connection):
3215 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3216 * src/maemo/modest-connection-specific-smtp-window.c:
3217 (fill_with_connections), (on_button_edit),
3218 (modest_connection_specific_smtp_window_init):
3219 Turn the edit window into a dialog to simplify the code, and
3220 set a WM hint as in a GtkDialog, because only a popup can be on top of
3221 another window in Maemo, and popups usually have no WM decoration.
3223 * src/modest-defs.h:
3224 * src/modest-account-mgr-helpers.c:
3225 (modest_account_mgr_set_connection_specific_smtp),
3226 (modest_account_mgr_remove_connection_specific_smtp),
3227 (modest_account_mgr_get_connection_specific_smtp):
3228 * src/modest-account-mgr-helpers.h: Some functions to write the
3229 connection-specific SMTP server information. Not yet used.
3232 * src/widgets/modest-folder-view.c: (text_cell_data):
3233 Fix a warning about an uninitialized variable.
3234 (on_configuration_key_changed): Put an #ifdef around the use
3235 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3237 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3239 * src/maemo/modest-account-settings-dialog.h:
3240 * src/maemo/modest-account-settings-dialog.c:
3241 Added connect_for_modified() utility function to mark the new modified boolean.
3243 (create_page_account_details), (create_page_user_details),
3244 (create_page_incoming), (create_page_outgoing), (on_response),
3245 (modest_account_settings_dialog_init),
3246 (modest_account_settings_dialog_set_account_name):
3247 Only warn about unsaved changes when there are actually unsaved changes.
3249 * src/modest-account-mgr-helpers.c:
3250 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3251 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3252 to get the data from there in future.
3254 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3256 * src/modest-defs.h:
3258 * src/modest-account-mgr-helpers.h:
3259 * src/modest-account-mgr-helpers.c:
3260 Store the security account setting in a single conf key instead of using
3261 the options list, so that the list is left for just the to-be-removed camel hack,
3262 and because gconf_client_set_list() is failing for some reason.
3264 * src/modest-account-mgr.c:
3265 (modest_account_mgr_add_server_account):
3266 * src/maemo/modest-account-settings-dialog.c:
3267 (modest_account_settings_dialog_set_account_name),
3268 (save_configuration): Use the renamed functions.
3271 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3273 * src/widgets/Makefile.am:
3274 * src/widgets/modest-limit-retrieve-combo-box.c:
3275 * src/widgets/modest-limit-retrieve-combo-box.h:
3276 * src/widgets/modest-retrieve-combo-box.c:
3277 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3278 the account settings dialog.
3280 * src/modest-defs.h:
3281 * src/modest-account-mgr-helpers.h:
3282 * src/modest-account-mgr-helpers.c:
3283 (modest_server_account_get_option_secure_auth),
3284 (modest_server_account_set_option_secure_auth):
3285 * src/modest-account-mgr.c:
3286 (modest_account_mgr_add_server_account):
3287 Use the existing AUTH_MECH conf key for the secure-auth setting,
3288 instead of putting it in the list options, because this was actually used already.
3290 * src/maemo/modest-account-settings-dialog.c:
3291 (create_page_account_details),
3292 (modest_account_settings_dialog_set_account_name),
3293 (save_configuration):
3294 * src/maemo/modest-account-settings-dialog.h:
3295 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3296 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3298 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3300 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3301 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3302 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3304 * src/modest-defs.h:
3305 * src/maemo/modest-account-settings-dialog.c:
3306 (create_page_incoming), (on_combo_outgoing_security_changed),
3307 (on_combo_incoming_security_changed), (create_page_outgoing),
3308 (modest_account_settings_dialog_set_account_name),
3309 (save_configuration): Load/Save the port number, and change it when the
3310 security combo changes, to suitable defaults.
3312 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3314 * src/modest-account-mgr.c:
3315 (modest_account_mgr_add_server_account): Set the security and secure-auth
3316 options, and add a comment saying that the other camel-specific options should be
3319 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3321 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3323 * src/modest-tny-account-store.c: (account_list_free),
3324 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3325 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3328 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3330 * src/modest-protocol-info.c:
3331 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3332 is required by our UI spec. Maybe something in our implementation will use this eventually.
3333 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3334 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3335 instead of the previous 0 placeholder.
3337 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3338 secure-auth settings.
3339 * src/modest-account-mgr-helpers.h:
3340 * src/modest-account-mgr-helpers.c:
3341 (modest_server_account_data_get_option_secure_auth),
3342 (modest_server_account_set_option_secure_auth),
3343 (modest_server_account_data_get_option_security),
3344 (modest_server_account_set_option_security): Added this API for getting and setting the security
3345 and secure-auth settings.
3347 * src/maemo/modest-account-settings-dialog.h:
3348 * src/maemo/modest-account-settings-dialog.c:
3349 (modest_account_settings_dialog_finalize), (check_data),
3350 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3351 about changing titles.
3352 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3353 (save_configuration): Save the security and secure-auth settings.
3355 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3356 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3358 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3360 * src/modest-defs.h:
3361 * src/modest-account-mgr.c:
3362 (modest_account_mgr_add_server_account):
3363 Added and used defines for the options key and value pair strings,
3364 that are used so far, though they do not seem to correspond to anything in our
3365 UI specs or ModestProtocol enum.
3367 * src/modest-account-mgr-helpers.h:
3368 * src/modest-account-mgr-helpers.c:
3369 (compare_option_strings_for_name),
3370 (modest_server_account_data_get_option_value),
3371 (modest_server_account_data_get_option_bool),
3372 (modest_account_mgr_get_server_account_option):
3373 Added helper functions for parsing the options GSList.
3375 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3377 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3378 display name is based on the supplied account name.
3379 * src/modest-account-mgr.c:
3380 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3381 with an inefficient, but good-enough, implementation.
3383 * src/maemo/easysetup/modest-easysetup-wizard.c:
3384 (create_page_account_details), (on_before_next), (create_account):
3385 Check for existing display names rather than (non-user-visible) account names, and just
3386 create and set a unique account name at the end.
3388 * src/maemo/modest-account-settings-dialog.c:
3389 (modest_account_settings_dialog_init),
3390 (modest_account_settings_dialog_set_account_name),
3391 (create_page_incoming): Show the display name, instead of the account name.
3392 (on_response): Do some (not all) extra checks, as in the UI spec.
3393 (save_configuration): Save the display name if it was changed.
3395 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3397 * po/en_GB.po: Added needed logical ID and translation.
3398 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3399 (init_view): Made the is-default column clicking work.
3401 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3404 * src/maemo/easysetup/Makefile.am:
3405 * src/maemo/easysetup/modest-easysetup-wizard.c:
3406 (modest_easysetup_wizard_dialog_init):
3407 * src/maemo/easysetup/provider-data-test.keyfile:
3408 * src/maemo/easysetup/provider-data.keyfile:
3409 Moved the provider data file to the new modest-providers-data package and used it from there.
3411 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3413 * src/modest-local-folder-info.c:
3414 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3415 N_() was already used on the static strings, but this just marks it for translation without
3416 using the translation.
3418 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3420 * src/maemo/modest-account-settings-dialog.c:
3421 (create_page_incoming),
3422 (modest_account_settings_dialog_set_account_name):
3423 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3424 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3425 I will do this if nobody else gets there first.
3427 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3429 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3430 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3431 save the security stuff.
3433 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3435 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3436 Set the email address and user fullname, which I now see must be
3439 * src/maemo/modest-account-settings-dialog.h:
3440 * src/maemo/modest-account-settings-dialog.c:
3442 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3443 leave-on-server and authentication.
3444 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3447 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3450 * src/maemo/modest-account-settings-dialog.c:
3451 * src/maemo/modest-account-settings-dialog.h:
3452 Most (but not all) of the widgets are now present as specified by the UI spec.
3453 No changes are yet saved, and some details are not properly shown yet.
3455 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3457 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3459 * src/maemo/Makefile.am:
3460 * src/maemo/modest-account-settings-dialog.c:
3461 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3462 an existing account. Doesn't do much yet.
3464 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3465 Open the accounts settings dialog when Edit is clicked.
3467 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3469 * src/maemo/easysetup/Makefile.am:
3470 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3472 * src/maemo/easysetup/modest-easysetup-wizard.c:
3473 (modest_easysetup_wizard_dialog_init):
3474 Try to get the source directory from the build system,
3475 instead of hard-coding "./" into the source code, when opening our local
3476 copies of the configuration files.
3477 But this still fails when opening the wizard from the Accounts window,
3478 maybe because the working directory seems to change at runtime.
3479 So the wizard will fail the second time unless you copy the files into their
3480 proper locations - see the stdout warnings for the paths.
3482 (create_page_account_details),(on_before_next):
3483 Check for existing non-server accounts instead of server accounts,
3484 so the default account name is useful again, and to prevent trying to
3487 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3488 Show the wizard when New is clicked.
3490 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3491 (init_view): Show the column headers, and show the columns that are
3492 specified in the UI specs. However, something in Maemo's GTK+ prevents
3493 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3494 change the default account. This is despite unsetting the special properties.
3496 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3498 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3499 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3500 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3501 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3502 to make that clearer.
3503 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3505 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3507 * src/maemo/modest-account-view-window.c:
3508 (modest_account_view_window_init),
3509 (modest_account_view_window_new):
3510 Use the same buttons as specified in the
3511 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3512 the existing widgets, which never had a chance of working.
3513 Put the ModestAccountView treeview in a scrolled window.
3514 Do not repeat the initialization in both _init() and _new().
3516 * src/widgets/modest-account-view.c: (update_account_view):
3517 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3518 this widget and window shows no accounts.
3520 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3522 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3524 * src/maemo/easysetup/modest-easysetup-wizard.c:
3525 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3526 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3527 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3530 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3531 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3532 accounts exist yet, as in the UI spec.
3534 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3536 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3538 * src/maemo/Makefile.am:
3539 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3540 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3541 New window for editing connection-specific smtp details.
3542 Not fully implemented.
3544 * src/maemo/modest-connection-specific-smtp-window.c:
3545 (modest_connection_specific_smtp_window_finalize) :
3546 unref the tree model.
3547 (on_button_edit): Show the edit window.
3549 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3551 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3554 * src/maemo/Makefile.am:
3555 * src/maemo/modest-connection-specific-smtp-window.c:
3556 * src/maemo/modest-connection-specific-smtp-window.h:
3557 New window for showing the list of connections, for connection-specific
3558 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3559 * src/maemo/easysetup/modest-easysetup-wizard.c:
3560 (create_page_custom_outgoing): Show the new window when the button is clicked.
3562 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3564 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3565 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3566 * src/maemo/modest-msg-edit-window.c:
3567 (modest_msg_edit_window_insert_image):
3568 * src/modest-conf.c: (modest_conf_key_escape):
3569 * src/modest-mail-operation.c:
3570 (modest_mail_operation_send_new_mail):
3571 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3572 (modest_ui_actions_on_new_account):
3573 * src/widgets/modest-attachment-view.c: (update_filename_request):
3574 * src/widgets/modest-mail-header-view.c:
3575 Corrected warnings that were breaking the build, by commenting out unused variables,
3576 and a function, and by including a header.
3578 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3580 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3581 so we can #ifdef around platform-specific code when necessary.
3582 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3583 to allow this to build for the GNOME platform too.
3585 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3587 * src/maemo/easysetup/modest-easysetup-wizard.c:
3588 Added util_increment_name() and used it in create_page_account_details()
3589 to make sure that the default account name is always a new name.
3591 (modest_easysetup_wizard_dialog_init),
3592 (set_default_custom_servernames): Some minor memory management fixes.
3594 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3598 * src/modest-runtime.c: (init_i18n): Restored the translation
3599 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3600 are defined in config.h, and the translations are installed.
3602 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3603 is defined for translation.
3605 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3607 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3609 * src/maemo/easysetup/modest-easysetup-wizard.c:
3610 (modest_easysetup_wizard_dialog_init):
3611 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3612 Use realistic paths (though they should use $prefix generically) to the
3613 mcc_mapping and provider-data.keyfile files which might work when they
3614 are installed by the future version of the operator-wizard package,
3615 and then fallback to paths in our source code, with an explanatory
3618 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3622 * src/maemo/Makefile.am:
3623 * src/maemo/easysetup/: Added files from the previously-exernal
3624 osso-modest-easysetup.
3625 * src/maemo/modest-main-window-ui.h:
3626 * src/modest-ui-actions.c:
3627 * src/modest-ui-actions.h:
3628 Added modest_ui_actions_on_new_account() as a signal handler for the
3629 New Account menu item. It shows the easysetup wizard.
3630 * po/en_GB.po: Added additional needed logical IDs and translations.