1 2007-07-24 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
4 Try a couple of tricks to force the treeview to update (
5 poke the folder, and do a send/receive refresh), but the deleted
6 email still appears with a strike-through instead of really being
9 2007-07-23 Murray Cumming <murrayc@murrayc.com>
11 * src/dbus_api/modest-dbus-callbacks.c:
12 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
13 because their ID is not human-readable (see the comment about
14 improvements needed to the osso-email-interface API) and
15 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
17 2007-07-23 Murray Cumming <murrayc@murrayc.com>
19 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
20 (add_folders_to_list), (on_dbus_method_get_folders),
21 (modest_dbus_req_filter):
22 * src/maemo/modest-maemo-utils.c:
23 (on_camel_account_get_supported_secure_authentication):
24 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
25 (on_header_view_focus_in):
26 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
27 * src/modest-formatter.c: (modest_formatter_create_body_part):
28 * src/modest-mail-operation.c: (recurse_folders),
29 (update_account_thread), (get_msgs_full_thread),
30 (modest_mail_operation_get_msgs_full),
31 (modest_mail_operation_xfer_msgs):
32 * src/modest-search.c: (search_mime_part_and_child_parts),
33 (modest_search_account), (modest_search_all_accounts):
34 * src/modest-tny-account.c:
35 (modest_tny_account_get_special_folder), (recurse_folders):
36 * src/modest-tny-local-folders-account.c:
37 (modest_tny_local_folders_account_query_passes):
38 * src/modest-tny-msg.c: (copy_mime_part),
39 (modest_tny_msg_find_body_part_from_mime_part):
40 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
41 (modest_tny_send_queue_try_to_send):
42 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
43 (_modest_ui_actions_open), (download_uncached_messages),
44 (reply_forward), (modest_ui_actions_on_copy),
45 (modest_ui_actions_on_details), (has_retrieved_msgs),
46 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
48 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
49 (_selected_msg_marked_as), (_msg_download_completed),
50 (_selected_msg_sent_in_progress):
51 * src/widgets/modest-attachments-view.c:
52 (modest_attachments_view_set_message):
53 * src/widgets/modest-msg-view.c: (find_cid_image):
54 * tests/check_folder-transfer.c: (find_folders):
55 * tests/check_update-account.c: (func):
56 * tests/dbus_api/test_get_folders.c: (main):
57 Checked all uses of tny_iterator_get_current(), making sure
58 that the object is unreferenced (3 or 4 places did not),
59 and adding checks for NULL.
61 2007-07-23 Murray Cumming <murrayc@murrayc.com>
63 * src/dbus_api/modest-dbus-callbacks.c:
64 (on_idle_open_default_inbox): Make sure that the application UI is
66 * src/maemo/easysetup/modest-easysetup-wizard.c:
67 (on_entry_invalid_character): Show the word whitespace instead
68 of (null) in the banner when whitespace was entered.
69 (show_error): Add a comment that this does not work in
70 Maemo Bora, though we do not know why.
72 2007-07-23 Murray Cumming <murrayc@murrayc.com>
74 * src/modest-tny-account.c:
75 (modest_tny_account_get_special_folder): Use an if instead of
76 an assert for when the parent account name is NULL, because this
77 might be causing a crash in projects.maemo.org bug 63192.
78 * src/modest-mail-operation.c:
79 (modest_mail_operation_send_new_mail_cb),
80 (modest_mail_operation_remove_folder): unref the folder that is
81 returned from modest_tny_account_get_special_folder().
83 2007-07-23 Murray Cumming <murrayc@murrayc.com>
85 * src/modest-ui-actions.c:
86 (modest_ui_actions_on_password_requested):
87 Show mail_ib_login_cancelled info banner when the user cancels
88 the protected password dialog, to fix projects.maemo.org
91 2007-07-23 Murray Cumming <murrayc@murrayc.com>
93 * src/maemo/modest-account-settings-dialog.c:
94 (create_page_outgoing): Put this page in a GtkScrolledWindow,
95 matching the UI mock-up in the UI spec, and allowing access
96 to all widgets even when the on-screen keyboard is active.
98 2007-07-23 Murray Cumming <murrayc@murrayc.com>
100 Reverted this previous commit from Johannes,
101 because the scrollbars are always visible and because
102 I think we only need it on onepage of the account
103 settings, not the account wizard.
104 (I wrote the wrong instructions in the bug.)
106 * src/maemo/easysetup/modest-easysetup-wizard.c:
107 Added scrollbars to account wizard dialog.
108 Fixed projects.maemo.org NB #62744
110 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
112 * src/maemo/easysetup/modest-easysetup-wizard.c:
113 (create_page_user_details):
114 Use auto-cap for name (projects.maemo.org NB#63716)
115 * src/widgets/modest-account-view.c: (on_account_busy_changed):
117 2007-07-22 Armin Burgmeier <armin@openismus.com>
119 * src/maemo/modest-ui-actions.c: Use current account instead of
120 default account for creating viewer windows, so that the viewer
121 window knows to which account the viewed message belongs.
123 * src/maemo/modest-msg-view-window.c: Destroy the window when the
124 corresponding account is deleted. This fixes projects.maemo.org bug
127 2007-07-18 Armin Burgmeier <armin@openismus.com>
129 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
130 the dialog close after entering an invalid port number and clicking
131 OK. This fixes projects.maemo.org bug NB#63602.
133 2007-07-18 Armin Burgmeier <armin@openismus.com>
135 * src/modest-tny-account-store.c:
136 (get_server_accounts): Set parent modest account name for each
137 connection-specific transport account so that special folders of such
138 an account can be looked up. This fixes a crash when changing account
139 settings. This might also be related to projects.maemo.org bug
142 2007-07-16 Armin Burgmeier <armin@openismus.com>
144 * src/modest-ui-actions.c: Added a button to create a folder to the
145 move-to dialog. This fixes projects.maemo.org bug NB#.
147 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
149 * src/maemo/easysetup/modest-easysetup-wizard.c:
150 Added scrollbars to account wizard dialog.
151 Fixed projects.maemo.org NB #62744
153 2007-07-16 Murray Cumming <murrayc@murrayc.com>
155 * src/widgets/modest-msg-view.h:
156 * src/widgets/modest-msg-view.c:
157 Added modest_msg_view_get_message_is_empty() but this needs
159 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
160 Check if there is any text in the message yet.
161 But this needs to be implemented properly.
162 (modest_msg_edit_window_toggle_find_toolbar):
163 * src/maemo/modest-msg-view-window.c:
164 (modest_msg_view_window_toggle_find_toolbar):
165 Show a banner warning if there is no text to search, when
166 trying to start a search. This partially fixes
167 projects.maemo.org bug NB#62350.
169 2007-07-13 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-mail-operation.c: (update_account_thread):
172 Initialized num_new_headers to fix the build.
174 2007-07-13 Murray Cumming <murrayc@murrayc.com>
176 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
177 Ignore modest accounts whose server accounts don't exist in gconf.
178 This prevents us trying to create TnyAccount instances for those
179 server accounts when the server account has been removed from gconf,
180 but the parent modest account has not yet been removed from modest.
181 I don't know why this is only noticeable now. It was probably just
182 a harmeless g_warning() anyway.
184 2007-07-13 Murray Cumming <murrayc@murrayc.com>
186 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
187 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
189 2007-07-12 Armin Burgmeier <armin@openismus.com>
191 * src/maemo/modest-main-window.c: Make default account appear bold
192 in view, tools/send & receive and toolbar/send & receive SCM menus.
193 This fixes projects.maemo.org bug NB#59010.
195 2007-07-12 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
198 Add a short-cut, by checking if the folder store is an account.
199 This ensures that the Sort menu item and toolbar is dimmed for
200 the local-folders account root item, fixing
201 projects.maemo.org bug NB#62545.
203 2007-07-12 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-tny-account-store.c: (get_password):
206 Show the password dialog (via the signal) only in the mainloop, via
207 an idle handler that we wait for. This could theoretically prevent
208 hangs, though I worry that it could introduce some too.
210 2007-07-12 Murray Cumming <murrayc@murrayc.com>
212 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
213 * src/maemo/modest-platform.c:
214 (modest_platform_connect_and_wait):
215 Take a TnyAccount* parameter and try to set it to online
216 (a TnyCamel-only API), because tinymail sets accounts to offline
217 when the user cancels a password dialog, and doesn't ask again until
218 it has been set to online.
219 However, this is commented out because it causes a hang now.
221 (modest_platform_connect_and_wait_if_network_account):
222 * src/modest-mail-operation.c:
223 (modest_mail_operation_update_account):
224 * src/modest-platform.h:
225 * src/modest-ui-actions.c: (_modest_ui_actions_open),
226 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
228 2007-07-12 Armin Burgmeier <armin@openismus.com>
230 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
232 * src/modest-mail-operation.c:
233 * src/modest-ui-actions.c: Check for already existing folder before
234 querying the server, show error message from camel if the request
235 still fails. This fixes projects.maemo.org bug NB#58701.
237 2007-07-12 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-tny-account-store.h:
240 * src/modest-tny-account-store.c:
241 Added modest_tny_account_store_forget_password_in_memory(),
242 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
243 when creating a new account, so that new passwords will be used, instead of
244 us thinking that it's a second request as a result of a failed password again.
246 2007-07-12 Murray Cumming <murrayc@murrayc.com>
248 * src/dbus_api/modest-dbus-callbacks.c:
249 (on_idle_open_message): If the message is in drafts then open it
250 in an edit window instead of a view window. This fixes
251 projects.maemo.org bug NB#63005.
253 2007-07-12 Murray Cumming <murrayc@murrayc.com>
255 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
256 Avoided a harmless g_warning().
258 2007-07-12 Murray Cumming <murrayc@murrayc.com>
260 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
261 Pass the modest account name, not the TnyAccount display name to
262 modest_msg_view_window_new() so that the reply feature works,
263 fixing projects.maemo.org bug NB#62892.
265 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
266 (modest_msg_view_window_new_with_header_model):
267 * src/maemo/modest-msg-view-window.c:
268 (modest_msg_view_window_new_with_header_model),
269 (modest_msg_view_window_new):
270 * src/modest-ui-actions.c: (reply_forward):
271 * src/widgets/modest-msg-view-window.h:
272 * src/widgets/modest-window.c: (modest_window_set_active_account):
273 Rename an account parameter to modest_account_name to make this clearer.
275 2007-07-11 Murray Cumming <murrayc@murrayc.com>
277 * src/modest-ui-actions.h:
278 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
279 modest_do_message_delete().
280 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
281 Call modest_do_message_delete(), hoping that this would cause messages
282 to be really deleted from search instead of just marked with strike through.
283 Does not seem to help.
285 2007-07-11 Armin Burgmeier <armin@openismus.com>
287 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
288 priv->reselect to FALSE prior to calling
289 modest_folder_view_select_first_inbox_or_local() to prevent endless
290 recursion and thus a crash on startup.
292 2007-07-11 Armin Burgmeier <armin@openismus.com>
294 * src/maemo/modest-account-settings-dialog.h: Include
295 <gtk/gtknotebook.h> to fix the build (at least for me).
297 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
298 Use "New FolderN" as default suggested name if "New folder" already
299 exists, with N being the first free number, though never exceed "New
300 folder99" in which case we just fall back to "New Folder" even though
301 it already exists. This fixes projects.maemo.org bug NB#58663.
303 2007-07-11 Murray Cumming <murrayc@murrayc.com>
305 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
306 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
307 projects.maemo.org bug NB#62778.
309 2007-07-11 Murray Cumming <murrayc@murrayc.com>
311 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
312 Ignore the wrong (for now) secure-smtp setting in the presets -
313 just default to requiring secure authentication for SMTP, because
316 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
318 * src/widgets/modest-folder-view.c: (filter_row)
319 Do not show drafts folder (see UI specs)
321 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
323 * src/modest-ui-actions.c:
324 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
325 place and also not necessary.
327 * src/widgets/modest-folder-view.c: (filter_row)
328 Guess folder type and hide Sent & Outbox if necessary.
329 Fixed project.maemo.org NB#57328
331 2007-07-11 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-ui-actions.h:
334 * src/modest-ui-actions.c:
335 (modest_ui_actions_on_delete_message):
336 Move some code into a new
337 modest_ui_actions_refresh_message_window_after_delete()
338 function so we can use it from elsewhere.
340 * src/dbus_api/modest-dbus-callbacks.c:
341 (on_idle_delete_message), (on_delete_message): Used an idle
342 handler, as we do for the other D-Bus method handlers.
343 Call modest_ui_actions_refresh_message_window_after_delete()
344 if the deleted message was open in a window. This fixed
345 projects.maemo.org bug NB#62862.
347 2007-07-11 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-main.c: (main): Only show the UI at the start if
350 the showui command line option was given. For instance,
351 run-standalone src/modest showui
352 Otherwise, we wait for the top_application D-Bus method to
353 be sent by hildon-desktop when the application is selected
355 This allows us to run without a UI when osso-global-search
356 uses our D-Bus methods.
358 2007-07-11 Murray Cumming <murrayc@murrayc.com>
360 * src/dbus_api/modest-dbus-api.h: Added a define for a
361 top-application D-Bus method.
362 * src/dbus_api/modest-dbus-callbacks.c:
363 (on_top_application),
364 (modest_dbus_req_handler): Handle the top-application D-Bus
365 method, which might be an undocumented D-Bus signal sent by
366 hildon-desktop when it starts the application from the menu.
367 But I am not sure and I need to test it on the device, because
368 my scratchbox does not have the application in the menu now.
369 This method shows the main window, so that it can be invisible
370 when started, for instance, just for email searching from
373 * src/maemo/modest-main-window.c: (restore_settings),
374 (modest_main_window_new): Do not show the window immediately
375 upon creation. We show it later.
376 * src/modest-widget-memory.c: (save_settings_paned):
377 Try (unsuccessfully) to avoid saving the paned position when
378 it is not even visible.
379 (restore_settings_paned): Do not allow a silly paned position.
380 This seems necessary when not showing the window at first.
382 * tests/dbus_api/Makefile.am:
383 * tests/dbus_api/test_top_application.c: (main): Test for the
386 2007-07-10 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-ui-dimming-rules.c:
389 (modest_ui_dimming_rules_on_new_msg),
390 (modest_ui_dimming_rules_on_reply_msg),
391 (modest_ui_dimming_rules_on_delete_msg),
392 (modest_ui_dimming_rules_on_details),
393 (modest_ui_dimming_rules_on_view_window_move_to),
394 (modest_ui_dimming_rules_on_view_previous),
395 (modest_ui_dimming_rules_on_view_next),
396 (_invalid_folder_for_purge): Added checks before
397 casting the window. This looks like an actual
398 logic error in _invalid_folder_for_purge(), because it
399 tries to use a ModestMainWindow as a message window.
401 2007-07-10 Murray Cumming <murrayc@murrayc.com>
403 * src/maemo/modest-account-settings-dialog.c:
404 (show_error): Use the same implementation as in
405 modest-easysetup-wizard.c:
406 (on_entry_invalid_character): The logical ID contains a %s.
407 Guessed what it should be.
408 (on_entry_max), (check_data), (on_response): Adapt to
409 changed show_error().
410 (create_page_account_details): Really call
411 modest_validating_entry_set_func() on the correct widgets.
412 * src/maemo/easysetup/modest-easysetup-wizard.c:
413 (on_entry_invalid_character): Fix the logical ID here too.
414 (create_page_account_details),
415 (create_page_user_details):
417 modest_validating_entry_set_func() on the correct widgets.
419 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
420 Do not try to use the account if it is NULL.
422 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
424 * src/modest-ui-actions.c: (create_move_to_dialog),
425 (modest_ui_actions_on_main_window_move_to),
426 (modest_ui_actions_on_msg_view_window_move_to):
427 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
428 (filter_row), (modest_folder_view_show_non_move_folders):
429 * src/widgets/modest-folder-view.h:
431 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
432 the Sent folder yet as it does not report the correct folder type.
434 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
436 * src/maemo/modest-msg-edit-window.c: (init_window):
439 2007-07-10 Murray Cumming <murrayc@murrayc.com>
441 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
442 Take a parent widget instead of a parent window, and
443 implement this with hildon_banner_show_information() instead.
444 Non-Maemo builds can just ifdef that there.
445 This fixed projects.maemo.org bug NB#62766.
447 (on_entry_invalid_character): Use show_error() again instead
448 of using hildon directly, and use the _CS() macro to use the correct
450 (create_account), (check_for_supported_auth_methods), (on_entry_max):
451 Pass a widget instead od a window to show_error().
453 2007-07-10 Murray Cumming <murrayc@murrayc.com>
455 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
456 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
457 This allows us to show the server name in the error message, fixing
458 projects.maemo.org bug NB#62904.
459 Also, use the appropriate logical ID message for the account protocol.
461 2007-07-10 Murray Cumming <murrayc@murrayc.com>
463 * src/modest-tny-account-store.c: (on_idle_wrong_password):
464 A compilation fix, though the build wasn't broken for me.
466 2007-07-09 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
469 Do not try to unref a NULL folder store, to avoid a runtime warning.
470 This seems to happen sometimes when changing accounts settings.
472 2007-07-09 Murray Cumming <murrayc@murrayc.com>
474 * src/modest-tny-account-store.c:
475 (modest_tny_account_store_instance_init),
476 (modest_tny_account_store_finalize),
477 (on_account_settings_hide), (on_idle_wrong_password):
478 Use a GHashTable to ensure that we only show one account settings
479 dialog per modest account. This avoids us having a dialog open for
480 both the store and transport accounts, or due to repeated get_password()
481 calls that shouldn't happen anyway.
483 2007-07-09 Murray Cumming <murrayc@murrayc.com>
485 * src/maemo/modest-maemo-utils.c: (on_hide),
486 (modest_maemo_show_dialog_and_forget): Handle the response, because
487 the window is not even hidden by default.
489 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
490 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
491 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
492 which seems to prevent some modality problems.
494 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
495 Ignore user cancellation errors.
497 * src/modest-account-mgr-helpers.h:
498 * src/modest-account-mgr-helpers.c:
499 Added modest_server_account_get_password() and
500 modest_server_account_get_has_password() to avoid direct use of
503 * src/maemo/modest-account-settings-dialog.h:
504 * src/maemo/modest-account-settings-dialog.c:
505 (modest_account_settings_dialog_init): Store the notebook so we can
507 Added modest_account_settings_dialog_switch_to_user_info().
509 * src/modest-tny-account-store.c:
510 (get_password): When the password in the account settings is wrong (we think),
511 show the relevant page of the account settings dialog, in the mainloop.
512 However, we currently get many of these at once because cancel does not
514 (forget_password): Do not forget the password
515 from the account settings, because this causes side-effects when
516 tinymail seems to call it at strange time, maybe because of how we
517 are cancelling get_password().
518 (modest_tny_account_store_alert): Ignore user cancellations.
520 2007-07-09 Murray Cumming <murrayc@murrayc.com>
522 * src/maemo/modest-maemo-utils.h:
523 * src/maemo/modest-maemo-utils.c:
524 Added modest_maemo_show_information_note_and_forget() for use instead of
525 gtk_dialog_run() when the response is not needed, to avoid an extra
526 mainloop which could cause a hang.
528 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
529 Use the logical IDs for the error message, though they are not
530 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
531 because gtk_dialog_run() caused a hang here (the window did not close).
532 This fixes projects.maemo.org bug NB#62646.
534 2007-07-09 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-account-mgr-helpers.h:
537 * src/modest-account-mgr-helpers.c:
538 Added modest_account_mgr_get_store_protocol().
540 * src/maemo/modest-account-view-window.c:
541 (on_delete_button_clicked): Show different warning text depending on
542 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
543 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
546 2007-07-09 Murray Cumming <murrayc@murrayc.com>
548 * src/maemo/modest-msg-edit-window.c:
549 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
550 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
552 2007-07-07 Armin Burgmeier <armin@openismus.com>
554 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
555 ckdg_ib_maximum_characters_reached from correct package.
557 * src/modest-ui-actions.c: Show an error message when a folder could
558 not be created. Tinymail does not give us specific error codes about
559 what has gone wrong, so we assume that a folder with that name
560 already exists, though there might be other reasons.
562 2007-07-06 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
565 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
566 give a more exact error message that can be partly translated.
568 2007-07-05 Murray Cumming <murrayc@murrayc.com>
570 * src/maemo/modest-address-book.c:
571 (select_email_addrs_for_contact): Specify a default window size for the
572 select-email-address dialog, so that it is probably big enough for the
573 title. This should fix projects.maemo.org bug NB#62277.
575 2007-07-05 Murray Cumming <murrayc@murrayc.com>
577 * src/maemo/easysetup/modest-easysetup-wizard.c:
578 (create_page_complete_easysetup): Use
579 gtk_widget_set_size() request to ensure that the text wraps
582 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
584 * src/maemo/easysetup/modest-easysetup-wizard.c:
585 (on_entry_invalid_character), (create_page_account_details),
586 (create_page_user_details):
587 Use new API of ModestValidatingEntry. But for some reason the banner is
588 not shown. I will have to investigate that further.
590 * src/widgets/modest-validating-entry.c: (on_insert_text),
591 (modest_validating_entry_set_func):
592 * src/widgets/modest-validating-entry.h:
593 Added a new callback function to be able to react to prevented
594 characters whitespaces to e.g show a banner.
596 2007-07-05 Armin Burgmeier <armin@openismus.com>
598 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
599 notification of HildonNumberEditor instead of remembering the port
600 number. Thanks to Johannes for pointing this out.
602 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
604 * src/maemo/easysetup/modest-easysetup-wizard.c:
605 Check if there are any user changes before showing a confirmation
606 dialog (projects.maemo.org NB#60946)
608 2007-07-05 Armin Burgmeier <armin@openismus.com>
610 * src/maemo/modest-account-settings-dialog.c: Remember custom port
611 number at the beginning of the dialog and set the modified flag at the
612 end if the port number has changed. This is necessary because
613 HildonNumberEditor does not support notification when the value has
616 2007-07-05 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-ui-actions.c:
619 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
620 a connection before asking anything else. Correct the check for the destination
621 folder so that it succeeds when online.
622 This fixed projects.maemo.org bug NB#61645.
624 2007-07-05 Murray Cumming <murrayc@murrayc.com>
626 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
627 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
628 to fix projects.maemo.org bug NB#62439.
630 2007-07-05 Murray Cumming <murrayc@murrayc.com>
632 * src/modest-tny-account.c: (on_connection_status_changed):
633 Really do not use tny_device_force_offline() here. See the previous comment.
635 2007-07-04 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account.c: (on_connection_status_changed):
638 Do not use tny_device_force_offline() when tinymail says that something
639 went wrong with the connection. It seems to report this unnecessarily.
641 2007-07-04 Murray Cumming <murrayc@murrayc.com>
643 * src/maemo/modest-connection-specific-smtp-window.c:
644 (modest_connection_specific_smtp_window_init):
645 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
646 does not seem to have any effect in osso 1.1 (though it works in
647 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
649 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
651 * src/maemo/modest-connection-specific-smtp-window.c:
652 Fix UI specification problems with projects.meamo.org NB#60479
654 2007-07-04 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
657 clue when this has failed, because the error dialog is not always shown
658 (at least in earlier version).
660 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
661 GError message, because the generic error dialog is not helpful.
663 'This message is not currently available (can't let a new connection go online)'
664 when trying to open an IMAP message.
666 (_modest_ui_actions_open): Offer a connection when some messages would
667 have to be downloaded and we are offline.
669 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
671 * src/widgets/modest-folder-view.c:
672 Don't check for MERGE type anymore as we use the correct type
674 NOTE: For the last two changes you need to update your tinymail copy
675 because of API changes!
677 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
679 * src/modest-tny-local-folders-account.c:
680 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
681 (see projects.maemo.org NB#61580)
683 2007-07-04 Murray Cumming <murrayc@murrayc.com>
685 * src/modest-tny-account.c: (on_connection_status_changed):
686 Commented out the call to modest_platform_connect_and_wait() because this
687 seems to always hang, and I would like to know if this is the only thing
688 that causes a hang when showing the connection dialog.
689 It is not very useful anyway.
691 2007-07-04 Murray Cumming <murrayc@murrayc.com>
693 * src/maemo/modest-msg-view-window.c:
694 (modest_msg_view_window_select_next_message):
696 * src/modest-platform.h:
697 * src/maemo/modest-platform.c:
698 Added modest_platform_connect_and_wait(), which calls
699 tny_maemo_conic_device_connect() always in the main thread, by calling it
700 in an idle handler and waiting for the idle handler to run. It should be
701 in the main thread because it uses GTK+ UI code. It just returns TRUE
702 if the device is already online.
704 There is some nasty code to ensure that subsequent calls to
705 modest_platform_connect_and_wait() just wait for the first one to finish,
706 by checking repeatedly in another idle handler. This is necessary,
707 because other threads (or even the main thread, via another idle handler)
708 can call modest_platform_connect_and_wait() while
709 modest_platform_connect_and_wait() is running.
711 (modest_platform_connect_and_wait_if_network_account),
712 (modest_platform_connect_and_wait_if_network_folderstore):
713 Convenience functions that calls modest_platform_connect_and_wait() if
714 the account or folder might want network access.
716 * src/modest-mail-operation.c:
717 (modest_mail_operation_update_account):
718 * src/modest-ui-actions.c: (download_uncached_messages),
719 (modest_ui_actions_on_rename_folder), (delete_folder),
720 (modest_ui_actions_on_main_window_move_to),
721 (modest_ui_actions_on_msg_view_window_move_to):
722 * src/widgets/modest-folder-view.c:
723 (drag_and_drop_from_folder_view):
724 Offer a connection if we are offline.
726 * src/modest-tny-account.c: (on_connection_status_changed):
727 Document this as only handling errors during network operations in progress,
728 and replace the idle code with a simple call to
729 modest_platform_connect_and_wait(), which does this instead.
731 2007-07-03 Murray Cumming <murrayc@murrayc.com>
733 * src/modest-tny-account.c:
734 (modest_tny_account_get_special_folder): (util_on_idle),
735 Handle the GError so we can see when tny_folder_store_get_folders()
736 fails, as it currently does while something else is connecting.
738 Added util_run_in_main_thread_and_wait()
739 which uses an idlen handler and mainloop to ensure that the function
740 is called in the main thread.
741 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
742 to make sure that we call attempt the connection in the mainloop only,
743 which might solve some hangs.
745 2007-07-03 Murray Cumming <murrayc@murrayc.com>
747 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
748 be found by their display name. This is never useful.
749 * src/modest-tny-account-store.c: (on_account_removed): Find the account
750 by its ID, instead of trying to use its ID as its display name.
752 * src/modest-tny-account-store.h:
753 * src/modest-tny-account.c:
754 (modest_tny_account_get_special_folder): Add a g_warning() when
755 tny_folder_store_get_folders() returns an empty list for the maildir.
757 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
758 Add a g_warning() when this returns NULL, because that it not allowed
761 2007-07-02 Armin Burgmeier <armin@openismus.com>
763 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
764 note when trying to cancel the wizard. This fixes projects.maemo.org
767 2007-07-02 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-tny-account.h:
770 * src/modest-tny-account.c:
771 (modest_tny_account_new_from_server_account),
772 (modest_tny_account_new_from_server_account_name),
773 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
774 because this must now be set before setting the proto. This is usd in
775 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
776 warning in camel_session_get_service() caused by
777 tny_camel_transport_account_prepare().
779 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
782 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
784 * src/maemo/modest-connection-specific-smtp-edit-window.c:
786 (modest_connection_specific_smtp_edit_window_init):
788 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
791 2007-06-29 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-tny-account.c:
794 (modest_tny_account_new_from_server_account):
795 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
796 now uses to request a connection when it needs one, and which it uses
797 to tell us that something is wrong with the connection, so we can force
798 the accounts offline to prevent further problems.
801 * src/modest-init.c: (init_default_settings):
802 * src/modest-mail-operation.c:
803 (modest_mail_operation_update_account):
804 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
805 This should not be necessary anymore. Do not set the conf key that
806 determined this (it was always TRUE and not set anywhere else).
808 * src/modest-ui-actions.h: Remove unused and unimplemented
809 modest_ui_actions_on_online_toggle_toggled().
811 2007-06-29 Murray Cumming <murrayc@murrayc.com
813 * src/maemo/modest-main-window.c: (connect_signals):
814 Don't connect to delete_event twice. Maybe this was harmless.
816 2007-06-29 Murray Cumming <murrayc@murrayc.com
818 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
819 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
820 Debug output to give some more clue when a folder move is not allowed.
822 2007-06-28 Murray Cumming <murrayc@murrayc.com
824 * src/modest-tny-account.c: (on_modest_file_system_info),
825 (modest_tny_account_get_mmc_account_name):
826 Always call the callback, without checking whether the name has changed.
827 * src/widgets/modest-folder-view.c: (strings_are_equal),
828 (on_model_foreach_set_name), (on_get_mmc_account_name),
829 (text_cell_data): Compare the name here, and use the name from
830 the account rather than from the
831 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
832 if the name was changed after the account was added to the model.
833 That's a tinymail bug but not one that I want to fix now.
835 This finally fixes projects.maemo.org bug NB#59301.
837 2007-06-27 Armin Burgmeier <armin@openismus.com>
839 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
842 2007-06-27 Murray Cumming <murrayc@murrayc.com
844 * src/modest-tny-account.h:
845 * src/modest-tny-account.c:
846 Added modest_tny_account_get_mmc_account_name(), to set the memory
847 card name asynchronously for the given account and then notify.
848 (modest_tny_account_new_for_local_folders): Use this new function instead
849 of using hildon_file_system_info_async_new() directly.
851 * src/widgets/modest-folder-view.c: (text_cell_data):
852 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
853 gtk_tree_model_row_changed() when it is available.
855 This should fix projects.maemo.org bug NB#59301.
857 2007-06-27 Murray Cumming <murrayc@murrayc.com
859 * src/modest-mail-operation.c: (update_account_thread),
860 (get_msgs_full_thread): Fix typo failures in the revert
863 2007-06-27 Murray Cumming <murrayc@murrayc.com
865 * src/maemo/modest-maemo-global-settings-dialog.c:
866 (idle_select_default_focus):
867 * src/modest-mail-operation.c: (idle_notify_progress),
868 (idle_notify_progress_once), (set_last_updated_idle),
869 (update_account_thread), (get_msgs_full_thread):
870 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
871 * src/widgets/modest-header-view.c:
872 (idle_notify_headers_count_changed_destroy),
873 (idle_notify_headers_count_changed):
874 Reverted the additions of gdk_threads_enter/leave(), in case this
875 helps with a startup hang on the device.
877 2007-06-26 Armin Burgmeier <armin@openismus.com>
879 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
880 for supported secure authentication methods from server by
881 gtk_dialog_run(), saving CPU time and a potential race condition.
883 2007-06-26 Armin Burgmeier <armin@openismus.com>
885 * src/maemo/modest-maemo-utils.h:
886 * src/maemo/modest-maemo-utils.c: Added a
887 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
888 only error code to tell the calling code when the user canceled the
891 * src/maemo/modest-account-settings-dialog.h:
892 * src/maemo/modest-account-settings-dialog.c:
893 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
894 message if the retrieval of secure authentication methods was canceled
895 by the user. Perform the check before saving anything to configuration
896 to not end up with half-committed configuration changes, do not show
897 a "Saving to configuration failed" note when authentication methods
898 could not be retrieved.
900 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
903 2007-06-26 Murray Cumming <murrayc@murrayc.com>
905 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
906 Only return the first level of folders under accounts, because the
907 osso-global-search UI spec doesn't want the rest.
908 This fixed projects.maemo.org bug NB#61811.
910 2007-06-26 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-tny-account-store.c:
913 * src/modest-tny-account-store.h:
914 Added modest_tny_account_is_memory_card_account().
915 * src/maemo/modest-main-window.c: (create_details_widget):
916 Show the same information items for the memory card as we show for the
917 local-folders, to fix projects.maemo.org bug NB#59307.
919 2007-06-26 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-tny-account-store.c: (get_password):
922 Added some checks for NULL to maybe prevent crashes, though I think
923 it was Philip's last commit that actually prevented the crash here
924 when creating a first new account.
925 But the new account is still not usable (no messages are shown)
926 until a restart of the application.
928 2007-06-26 Murray Cumming <murrayc@murrayc.com>
930 * src/maemo/modest-maemo-global-settings-dialog.c:
931 (idle_select_default_focus):
932 * src/modest-mail-operation.c: (idle_notify_progress),
933 (idle_notify_progress_once), (idle_notify_update_account_queue),
934 (set_last_updated_idle), (update_account_thread),
935 (notify_get_msgs_full), (get_msgs_full_destroyer),
936 (get_msgs_full_thread):
937 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
938 * src/widgets/modest-header-view.c:
939 (idle_notify_headers_count_changed_destroy),
940 (idle_notify_headers_count_changed):
941 Use gdk_threads_enter() and gdk_threads_enter_leave() in
942 all idle handlers, because some other thread could be blocking
943 the GDK lock, so that it can do GUI stuff.
945 2007-06-26 Murray Cumming <murrayc@murrayc.com>
947 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
948 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
949 (on_idle_send_receive), (on_idle_open_default_inbox):
950 * src/maemo/modest-msg-edit-window.c:
951 (modest_msg_edit_window_attach_file_noninteractive):
952 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
953 to prevent a hang. I don't quite understand why these are necessary,
954 beause we should already be in the main loop. I guess something outside
955 of the main loop is taking the lock.
957 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
958 we are really using URIs, and use files that are more likely to exist.
960 2007-06-26 Murray Cumming <murrayc@murrayc.com>
962 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
963 necessary because configure.ac now defines different variables.
965 2007-06-26 Murray Cumming <murrayc@murrayc.com>
967 * libmodest-dbus-client/libmodest-dbus-client.c:
968 * libmodest-dbus-client/libmodest-dbus-client.h:
969 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
970 libmodest_dbus_client_compose_mail() is what things actually use.
972 * src/dbus_api/modest-dbus-api.h:
973 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
974 * tests/dbus_api/Makefile.am:
975 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
978 2007-06-26 Murray Cumming <murrayc@murrayc.com>
980 * src/modest-init.c: (modest_init_local_folders):
981 For memory-card (or other non local-folders) maildir accounts,
982 always create an Archive folder, so that there is somewhere to put
983 messages. This should be less confusing, because the user does not need
984 to guess that the need to create a folder.
986 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
988 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
989 Fixed icon size by using (50, 50) which is the same as defined by
992 2007-06-25 Armin Burgmeier <armin@openismus.com>
994 * src/widgets/modest-window-mgr.c:
996 * configure.ac: Correctly recognize hildon-notify presence and fixed
997 the build without it being installed.
999 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1001 * libmodest-dbus-client/libmodest-dbus-client.c:
1002 (libmodest_dbus_client_search): Fix the build. Sorry.
1003 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1004 (reply_forward_cb): Initialize variables to fix the build.
1006 * src/modest-tny-account-store.c:
1007 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1008 comparison (a silly typo) so that email search results can be opened
1009 when there are more than one account.
1011 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1013 * libmodest-dbus-client/libmodest-dbus-client.c:
1014 (libmodest_dbus_client_search),
1015 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1016 instead of 1 second, because the search gets folders and messages from
1017 the server, which can take a long time. When it times out,
1018 osso-global-search will report no results.
1020 We need to specify whether we should search only cached information
1021 (maybe with a user preference), and the osso-email-search-plugin
1022 API should really be improved to allow that option, and to allow results
1023 to be delivered asynchronously in batches.
1025 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1027 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1028 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1029 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1031 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1033 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1034 that is an empty string. D-Bus seems to give us these instead of NULL.
1036 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1038 * src/dbus_api/modest-dbus-callbacks.c:
1039 * src/maemo/easysetup/modest-easysetup-wizard.h:
1040 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1041 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1042 (modest_connection_specific_smtp_edit_window_init):
1043 * src/maemo/modest-maemo-global-settings-dialog.c:
1045 * src/maemo/modest-maemo-utils.c:
1046 (modest_maemo_utils_setup_images_filechooser):
1047 * src/maemo/modest-main-window.c: (create_details_widget):
1048 * src/maemo/modest-msg-edit-window.c:
1049 (modest_msg_edit_window_attach_file_noninteractive),
1050 (modest_msg_edit_window_color_button_change),
1051 (modest_msg_edit_window_set_zoom):
1052 * src/modest-mail-operation.c: (update_account_thread):
1053 * src/modest-tny-account-store.c:
1054 * src/modest-tny-account.c:
1055 * src/widgets/modest-global-settings-dialog.c:
1056 * src/widgets/modest-window.h:
1058 Fixed build on bora!
1060 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1062 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1063 * src/modest-search.c: (modest_search_folder),
1064 (modest_search_all_accounts): Actually search only in the specified folder,
1065 doing a simple match on the folder ID.
1066 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1067 and added some documentation.
1069 2007-06-22 Armin Burgmeier <armin@openismus.com>
1071 * src/maemo/modest-maemo-utils.h:
1072 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1073 modest_maemo_utils_get_supported_secure_authentication_methods.
1075 * src/maemo/easysetup/modest-easysetup-wizard.c:
1076 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1077 one occured, not just "Server does not support secure authentication".
1079 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-tny-account-store.c: (get_password):
1082 Restored the call to tny_account_set_user() because Philip seems to have
1083 stopped this from crashing (by not using the freed string). It still does
1084 not work, but now we can test it.
1086 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1088 * src/maemo/modest-msg-edit-window.c: (init_window):
1089 Comment out use of an uninitialzed GtkScrolledWindow variable,
1090 to fix the build and stop a crash. Yet again.
1092 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-tny-account-store.c: (get_password):
1095 Remove the call to tny_account_set_user() because this actually crashes.
1096 As mentioned in the last commit, it is known to not work anyway.
1098 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-tny-account-store.c: (get_password):
1101 Use tny_account_set_username() to tell tinymail that the username might
1102 have changed too. But tinymail ignores this: see projects.maemo.org
1104 * src/modest-ui-actions.c:
1105 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1106 reset the connection when changing the username, and improve the comments.
1107 Save the changed username to gconf at least, so it is used when Modest is
1110 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1112 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1113 Do not use a query, so that we get all folders, including for POP and
1114 local-folders. They work as search criteria too.
1115 This fixes projects.maemo.org bug NB#57740.
1117 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1120 Comment out the use of hildon_notification_set_sound() because it is
1121 not declared, to fix the build. Warnings are serious, people.
1123 2007-06-21 Armin Burgmeier <armin@openismus.com>
1125 * src/maemo/modest-maemo-utils.h:
1126 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1127 modest_maemo_utils_get_supported_secure_authentication_methods()
1128 to query authentication methods for a specific user. This should fix
1129 projects.maemo.org bug NB#61369.
1131 * src/maemo/easysetup/modest-easysetup-wizard.c:
1132 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1135 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1137 * libmodest-dbus-client/libmodest-dbus-client.h:
1138 * libmodest-dbus-client/libmodest-dbus-client.c:
1139 (modest_dbus_message_iter_get_search_hit),
1140 (libmodest_dbus_client_search):
1141 Reorganised and commented this.
1142 Removed modest_search_hit_free() from the public API because it
1145 Added libmodest_dbus_client_get_folders() and
1146 modest_folder_result_list_free().
1148 * src/dbus_api/modest-dbus-api.h:
1149 * src/dbus_api/modest-dbus-callbacks.c:
1150 (modest_dbus_req_filter): Commented. Moved most code to
1151 on_dbus_method_search() and added on_dbus_method_get_folders().
1153 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1154 of the extra D-Bus handler.
1156 * tests/dbus_api/Makefile.am:
1157 * tests/dbus_api/test_get_folders.c: New test for
1158 libmodest_dbus_client_get_folders(). This seems to return an empty list
1159 at the moment. That could be the same error that causes the message list
1160 to be empty sometimes.
1161 This should help with projects.maemo.org bug NB#57740.
1163 2007-06-21 Armin Burgmeier <armin@openismus.com>
1165 * src/modest-mail-operation.c: Do not call
1166 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1167 notify the operation's end after having set the status to CANCELED for
1168 the operation queue to listen on. This fixes a deadlock when there
1169 were mail operations in the queue during its finalization.
1171 * src/modest-singletons.c: Reordered uninitialization of the account
1172 manager to happen after the mail operation queue was uninitialized
1173 because the mail operation's in the queue might still try to access
1174 the account manager (see modest_mail_operation_notify_end()). This
1175 fixes a potential crash when terminating the application.
1177 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1179 * src/modest-search.c:
1180 (search_mime_part_and_child_parts): Moved some code here so we
1181 can search recursively in child folders.
1182 (modest_search_folder): Search in the message as a mime part, instead
1183 of just its child mime parts.
1184 (read_chunk), (search_mime_part_ogs):
1185 Check how many bytes were read, to prevent an endless loop.
1186 Searching in message bodies now works. This finishes the fix for
1187 projects.maemo.org bug NB#61007.
1189 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1192 Add a g_warning when the item is not a folder.
1194 * src/modest-ui-dimming-rules.c:
1195 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1196 when selected item is not a folder (for instance, an account), because
1197 the UI spec only talks about folders.
1198 I am not sure what the UI spec wants, so this might not totally fix
1199 projects.maemo.org bug NB#60794.
1201 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1204 (load_from_file): Sort the list. The unsorted list would be more noticeable
1205 in non-English locales.
1207 * src/maemo/modest-msg-edit-window.c:
1208 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1209 warning and fix the build.
1211 * src/maemo/modest-progress-bar-widget.c:
1212 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1213 avoid a g_warning, and probably to avoid a crash.
1215 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1217 * src/modest-search.c: (modest_search_folder): Check for a GError
1218 when calling tny_folder_get_headers(), to show that this is not the cause
1221 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1223 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1224 Actually set the body query instead of the subject query.
1226 * src/modest-search.c: (search_mime_part_ogs),
1227 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1228 which would probably cause it to fail if we got this far.
1230 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1231 to simplify the code.
1232 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1233 be causing search-in-body to fail.
1235 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1237 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1239 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1240 Better debug message when the folder cannot be found.
1241 This should help with fixing projects.maemo.org bug #61287.
1242 * src/modest-search.c: (add_hit): Do not leak the furl string.
1244 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1246 * src/modest-ui-actions.c:
1247 (modest_ui_actions_on_folder_selection_changed):
1248 Do not special-case TNY_MERGE_FOLDER here, because
1249 modest_tny_folder_get_account() already does that. This fixes
1250 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1251 shown when the Outbox was selected).
1253 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1255 * libmodest-dbus-client/libmodest-dbus-client.c:
1256 (_dbus_iter_get_string_or_null): Initialize the string variable in
1257 case this helps with Dirk's crash.
1259 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1261 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1262 though it is not implemented yet (this function is maybe not even used),
1263 to avoid breaking ABI in future.
1264 * libmodest-dbus-client/libmodest-dbus-client.c:
1265 (get_attachments_string): Moved some code into this generic function.
1266 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1267 sends email. It is maybe not used.
1268 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1269 (on_send_mail): Use attachments.
1271 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1272 * src/maemo/modest-msg-edit-window.c:
1273 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1274 a filename before using it, to fix projects.maemo.org bug NB#58233.
1276 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1278 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1279 Initialize the continue_download variable to fix the build, and probably
1280 to fix randome behaviour.
1282 2007-06-18 Armin Burgmeier <armin@openismus.com>
1284 * src/modest-tny-send-queue.h:
1285 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1286 the queue so we can later show it in the UI. Replaced
1287 modest_tny_send_queue_msg_is_being_sent() by
1288 modest_tny_send_queue_get_msg_status().
1290 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1292 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1293 gpointer. This probably was not harmful, but just to be sure.
1295 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1297 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1298 Fix the build, but leave the function broken on Bora, because
1299 hildon_uri_action_get_service() does not exist.
1300 osso_uri_action_get_service() does not exist either, it seems.
1302 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1304 * src/modest-tny-account.c:
1305 (modest_tny_account_new_from_server_account):
1306 Uncommented the url debug output again, because it is useful for
1307 debugging, as I said in the comment.
1309 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1311 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1313 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1314 for Mameo Bora, to fix the build.
1316 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1319 Fixed build with hildon < 0.99
1321 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1322 Check if the selected account is busy instead of checking all accounts
1324 * src/modest-account-mgr-priv.h:
1325 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1326 (modest_account_mgr_init), (compare_account_name),
1327 (modest_account_mgr_set_account_busy),
1328 (modest_account_mgr_account_is_busy):
1329 * src/modest-account-mgr.h:
1330 Added busy information to the account manager. It possible to
1331 set an account to busy or not busy now.
1333 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1334 (modest_mail_operation_update_account),
1335 (modest_mail_operation_notify_end):
1336 Set the account to busy/not busy depending on the operation state.
1338 * src/widgets/modest-account-view.c:
1339 (modest_account_view_finalize), (get_last_updated_string),
1340 (update_account_view), (on_account_busy_changed), (init_view):
1341 Show string "Refreshing..." if the account is currently busy.
1343 All this fixes projects.maemo.org bug NB#59711
1345 2007-06-14 Armin Burgmeier <armin@openismus.com>
1347 * src/widgets/modest-attachments-view.h:
1348 * src/widgets/modest-attachments-view.c: Added
1349 modest_attachments_view_has_attachments() and fixed coordinate
1350 transformation in get_att_view_at_coords(). This fixes attachment
1353 * src/widgets/modest-msg-view.c: Make use of
1354 modest_attachments_view_has_attachments() to decide whether to show
1355 attachments in the header.
1357 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1359 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1360 (on_change), (on_combo_security_changed),
1361 (modest_connection_specific_smtp_edit_window_init),
1362 (modest_connection_specific_smtp_edit_window_set_connection),
1363 (modest_connection_specific_smtp_edit_window_is_dirty):
1364 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1365 * src/maemo/modest-connection-specific-smtp-window.c:
1368 Show an comfirmation dialog for the smpt-edit-window if there are
1369 unsaved changes and the user hits cancel.
1370 (projects.maemo.org bug NB#60479)
1372 2007-06-14 Armin Burgmeier <armin@openismus.com>
1374 * src/maemo/easysetup/modest-easysetup-wizard.c:
1375 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1376 address" info in banner instead of node, and select all the text as
1377 per UI spec. This fixes projects.maemo.org bug NB#60550.
1379 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1381 reviewed by: <delete if not using a buddy>
1383 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1384 * src/modest-ui-actions.c: (folder_refreshed_cb):
1386 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1388 * src/widgets/modest-folder-view.c: (filter_row):
1389 Explictly filter out the per-account outbox accounts. I don't know why
1390 these only sometimes show up, but now they should never show up in the UI.
1391 This should fix projects.maemo.org bug NB#60160.
1393 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1395 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1396 when the toolbar does not exist yet.
1397 * src/modest-widget-memory.c: (save_settings_header_view):
1398 Added g_warnings() to help us to discover when we are trying to set
1399 an empty columns list in gconf.
1401 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-init.h:
1404 * src/modest-init.c:
1405 Added modest_init_get_default_header_view_column_ids().
1407 * src/modest-widget-memory.c: (restore_settings_header_view):
1408 Use the new function to get defaults, if the gconf key is empty,
1409 instead of not creating any columns. This seems to fix the
1410 empty right-hand pane problems.
1412 * src/widgets/modest-header-view.h: Improved documentation.
1414 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1416 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1417 Revert the use of the display name as the account name, because this
1418 is generally wrong and would break the code that follows.
1420 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1422 * src/maemo/easysetup/modest-easysetup-wizard.c:
1423 (check_for_supported_auth_methods), (on_before_next),
1426 More correct fix for projects.maemo.org bug NB# 58991
1427 Do not longer accept AUTH_PASSWORD as secure method and choose
1428 correct method when creating the account.
1430 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1432 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1433 Fixed projects.maemo.org bug NB# 58991
1435 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1437 * src/modest-init.c: (modest_init_init_core),
1438 (modest_init_local_folders): Fixed compilation errors.
1440 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1442 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1443 Remove unnecessary lib/include, though it is good in principle when needed.
1445 * src/modest-init.c: (modest_init_one_local_folder),
1446 (modest_init_local_folders):
1447 * src/modest-init.h: Initialize the .modest library for memory cards,
1448 instead of just doing nothing for them. This should allow us to create
1449 folders there, fixing projects.maemo.org bug NB#59297.
1451 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1453 * libmodest-dbus-client/libmodest-dbus-client.c:
1454 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1455 (libmodest_dbus_client_compose_mail),
1456 (libmodest_dbus_client_open_message),
1457 (libmodest_dbus_client_send_and_receive),
1458 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1460 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1461 (on_idle_open_message), (modest_dbus_req_handler),
1462 (search_result_to_message), (modest_dbus_req_filter):
1463 * src/modest-search.c: (add_hit), (modest_search_folder),
1464 (modest_search_all_accounts): Improved debug messages.
1466 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1468 * src/modest-tny-account-store.c:
1469 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1472 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1475 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1477 * src/modest-tny-account-store.c: (get_server_accounts):
1478 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1479 even when there are no accounts, so that the Outbox folder is always
1480 visible. This fixes projects.maemo.org bug NB#60158.
1482 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/modest-main-window.c: (create_details_widget):
1485 Use the mcen_va_never logical ID.
1487 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1489 * src/dbus_api/modest-dbus-api.h:
1490 * src/dbus_api/modest-dbus-callbacks.c:
1491 (on_idle_open_default_inbox), (on_open_default_inbox),
1492 (modest_dbus_req_handler):
1493 Added a new OpenDefaultInbox method.
1495 * libmodest-dbus-client/libmodest-dbus-client.h:
1496 * libmodest-dbus-client/libmodest-dbus-client.c:
1497 Added libmodest_dbus_client_open_default_inbox() to call the new
1498 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1499 though it should maybe be used by a new osso-email-interface function.
1501 * tests/dbus_api/Makefile.am:
1502 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1505 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1507 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1508 NULL, so that the signals get all the keys. This should not actually
1509 change any behaviour because we currently update everything when anything
1512 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1514 * src/widgets/modest-folder-view.c: (text_cell_data),
1515 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1516 (find_inbox_iter): If tinymail tells us that the folder is
1517 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1518 This causes the inbox to be selected at startup, fixing part of
1519 projects.maemo.org bug NB#56305.
1521 * src/modest-ui-dimming-rules.c:
1522 (modest_ui_dimming_rules_on_tools_smtp_servers):
1523 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1524 the SMTP servers menu item.
1525 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1526 that the SMTP Servers menu item is dimmed when there are no accounts,
1527 as a future version of the UI spec will require. This fixes
1528 projects.maemo.org bug NB#56305.
1530 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1532 * src/maemo/modest-maemo-utils.c:
1533 (modest_maemo_utils_get_supported_secure_authentication_methods):
1534 Added label to dialog instead of unreadable title
1536 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1537 (modest_main_window_new):
1538 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1541 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1542 * src/modest-account-mgr.h:
1543 Added method to avoid code duplication
1545 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1546 (modest_ui_actions_on_send_receive):
1547 Use modest_account_mgr_has_accounts
1549 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1551 * src/maemo/easysetup/modest-presets.c:
1552 (modest_presets_get_info_server_security): Do not report secure auth
1554 * src/modest-protocol-info.c: Use the defines for the gconf key names
1555 for secure authentication. This was not working because we were writing
1556 Password and reading password, and the check was case sensitive.
1557 With this, gmail now works for receiving and sending when created via
1560 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1562 * src/maemo/easysetup/modest-presets.c:
1563 (modest_presets_get_info_server_security): Correct the key name for
1564 SecureSmtp, because it seems to be case-sensitive.
1565 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1566 Do not try to get the 0th notebook page if there are 0 pages, to
1567 avoid a g_warning().
1569 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1571 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1572 Prevent use of the new notification feature for now, because it currently
1573 shows one dialog for each new email, which is annoying.
1575 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1577 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1578 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1579 when no country was selected, so that we show the global ones.
1580 * src/maemo/easysetup/modest-presets.c:
1581 (modest_presets_get_providers): Return only the global providers, not
1582 all providers when mmc=0 was requested.
1584 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1586 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1587 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1588 provider ID in the combo.
1590 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1591 Do not show the page numbers, because it would be confusing when we add
1592 the 2 extra pages for the custom setup, when the user chooses the "Other"
1593 provider. This fixes projects.maemo.org bug NB#59028
1595 * src/modest-init.c: (modest_init_init_core),
1596 (modest_init_local_folders):
1597 * src/modest-init.h:
1598 * src/modest-tny-account.c:
1599 (modest_tny_account_new_for_local_folders): Do not create default folders
1600 for the memory card. This should fix projects.maemo.org bug NB#59328.
1602 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1605 Free the changed_conf_keys string items. They are already freed in the
1606 idle handler if that runs first.
1608 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1610 * src/modest-ui-actions.c:
1611 (modest_ui_actions_on_password_requested): Check that the server name
1612 is not NULL, because I just saw a password dialog with (null) as the
1615 * src/modest-tny-folder.[h|c]: Added
1616 modest_tny_folder_is_memory_card_folder().
1617 * src/modest-ui-dimming-rules.c:
1618 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1619 menu item for memory cards, as per the UI spec (section 7.4). This should
1620 fix projects.maemo.org bug NB#59297.
1622 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1624 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1625 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1626 is another problem with the code, see Murray's comment at line 772)
1628 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1630 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1631 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1632 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1633 (load_from_file), (easysetup_country_combo_box_init),
1634 (easysetup_country_combo_box_get_active_country_ids),
1635 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1636 instead of just one ID, to avoid duplicate country names in the UI.
1638 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1639 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1640 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1641 a single ID, avoiding duplicate providers.
1642 * src/maemo/easysetup/modest-easysetup-wizard.c:
1643 (on_combo_account_country): Adapt to use a list.
1645 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1648 keys changed in the last X seconds.
1650 * src/modest-account-mgr.h:
1651 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1652 (on_key_change), (modest_account_mgr_class_init),
1653 (modest_account_mgr_init), (modest_account_mgr_finalize):
1654 As the keys are changed, save them in a GSList* and signal that GSList*
1655 further every X seconds, to batch changes, to allow us to do just one
1656 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1657 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1659 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1660 changed signal signature.
1662 * src/modest-conf.c: (modest_conf_set_list),
1663 (modest_conf_on_change): Reenable notification.
1665 (modest_conf_maemo_fake_on_change): Comment out the hack that
1666 notified immediately instead of asynchronously.
1668 * src/widgets/modest-account-view.h:
1669 * src/widgets/modest-account-view.c:
1670 (update_account_view): Select the previously-selected account ID,
1671 if possible. This fixes projects.maemo.org bug NB#56933.
1673 (on_account_changed), (on_account_removed),
1674 (modest_account_view_select_account):
1676 Remove the block/unblock functions
1677 because they were not useful.
1679 * src/maemo/modest-account-view-window.c:
1680 (on_delete_button_clicked), (on_edit_button_clicked),
1681 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1683 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1685 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1686 Improve the error dialog to show Incorrect Account Settings, which seems
1687 clearer, and say that the internal error message (to be removed from the
1688 dialog later) is often misleading.
1689 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1691 * src/modest-tny-account.c:
1692 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1693 URL because this is so useful for debugging on the device.
1695 * src/widgets/modest-serversecurity-combo-box.c:
1696 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1698 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-mail-operation.c:
1701 (modest_mail_operation_send_new_mail):
1702 Added a comment about a nasty but apparently harmless message. Details
1703 added to the wiki g_warnings() page.
1705 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1708 (modest_tny_send_queue_class_init):
1709 Do not use the priv struct because it is empty, to avoid g_warnings
1710 about a non-existant priv struct.
1712 * src/modest-tny-account-store.c:
1713 (modest_tny_account_store_get_server_account),
1714 (modest_tny_account_store_get_transport_account_for_open_connection
1715 ): Do not try to get transport server accounts for local folders,
1716 because they don't have any. This avoids a g_warning().
1718 * src/maemo/modest-main-window.c:
1719 (modest_main_window_notify_send_receive_initied),
1720 (on_configuration_key_changed):
1721 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1722 * src/modest-defs.h:
1723 * src/modest-mail-operation.c:
1724 (modest_mail_operation_update_account):
1725 * src/modest-tny-account-store.h:
1726 * src/modest-tny-account.c:
1727 (modest_tny_account_get_special_folder),
1728 (modest_tny_account_new_for_local_folders),
1729 (modest_tny_account_new_for_per_account_local_outbox_folder):
1730 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1731 * src/modest-tny-local-folders-account.c:
1732 (add_account_folders_to_merged_folder):
1733 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1734 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1735 (modest_ui_actions_on_send):
1736 * src/widgets/modest-folder-view.c: (update_model):
1737 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1738 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1739 modest_tny_account_store_get_tny_account_by_account() to
1740 modest_tny_account_store_get_server_account() to make the code clearer.
1742 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1744 * src/dbus_api/modest-dbus-api.h:
1745 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1746 * src/maemo/modest-msg-edit-window.c:
1747 (modest_msg_edit_window_attach_file_noninteractive):
1748 added g_warning in case the file to be attached does not exist
1749 * tests/dbus_api/test_compose_mail.c: (main):
1750 removed obsolete comment, added generic files as test case
1752 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1754 * src/modest-tny-account-store.c: (get_server_accounts):
1755 Create the local folders account only once, not once for each outbox, and
1756 not only when there are some outboxes.
1758 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1760 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1761 code that is causing a crash at startup. Sergio says that he is fixing this.
1763 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1765 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1766 * src/maemo/modest-account-settings-dialog.c:
1767 (create_page_outgoing),
1768 (modest_account_settings_dialog_set_account_name),
1769 (save_configuration):
1770 - Fixed handling of the "Use secure authentication" toggle to comply with
1771 the ui specification. See also projects.maemo.org bug NB#58400
1773 - Restore the Secure connection setting combo correctly when loading
1776 * src/maemo/modest-maemo-utils.c:
1777 (on_camel_account_get_supported_secure_authentication),
1778 (modest_maemo_utils_get_supported_secure_authentication_methods):
1779 Fixed a crasher if operation is canceled
1781 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1782 (modest_protocol_info_auth_is_secure):
1783 * src/modest-protocol-info.h:
1785 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1786 the sense of the "Use secure authentication" toggle.
1788 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1790 * src/modest-tny-account-store.h:
1791 * src/modest-tny-account-store.c:
1792 Added modest_tny_account_store_get_local_folders_account().
1794 * src/modest-tny-folder.h:
1795 * src/modest-tny-folder.c:
1796 (modest_tny_folder_get_account):
1797 Added this replacement for tny_folder_get_account() which returns
1798 the local-folders account for TnyMergeFolders, to avoid the
1799 warning about the unimplemented get_account_func() vfunc().
1801 (modest_tny_folder_get_rules),
1802 * src/modest-ui-actions.c:
1803 (modest_ui_actions_on_folder_selection_changed):
1804 * src/modest-mail-operation.c:
1805 (modest_mail_operation_remove_folder),
1806 (modest_mail_operation_xfer_folder),
1807 (modest_mail_operation_rename_folder),
1808 (modest_mail_operation_get_msg),
1809 (modest_mail_operation_get_msgs_full),
1810 (modest_mail_operation_remove_msg),
1811 (modest_mail_operation_xfer_msgs),
1812 (modest_mail_operation_refresh_folder):
1813 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1815 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1817 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1818 (modest_server_account_set_security):
1819 * src/modest-defs.h: Add comments explaining that our
1820 UI spec means TLS when it says Normal, so these do not look like errors.
1822 * src/modest-tny-account.c:
1823 (modest_tny_account_new_from_server_account): Use the new tinymail
1824 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1825 for TLS. This should fix projects.maemo.org bug NB#58460.
1827 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/easysetup/modest-easysetup-wizard.c:
1830 (create_account): Correct the position of the gconf sanity check warning.
1831 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1832 of using the g_idle_add() hack, because this does not seem to be necessary
1833 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1834 caused by something other than maemo's gconf.
1835 This fixes projects.maemo.org bug #59022.
1837 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1839 * src/modest-account-mgr-helpers.c:
1840 (modest_account_mgr_get_default_account): Do not check that the account
1841 exists if there is no default account (NULL), to fix a runtime warning.
1843 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1845 * src/widgets/modest-folder-view.c: (update_model):
1846 Do not unref the treemodel before we have finished with it.
1847 This prevents a valgrind warning and an occasional crash at startup.
1849 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1851 * libmodest-dbus-client/libmodest-dbus-client.h:
1852 added libmodest_dbus_client_compose_mail()
1853 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1855 added functions needed for SendAsMail() functionality
1856 * src/maemo/modest-msg-edit-window.c:
1857 (modest_msg_edit_window_attach_file_noninteractive):
1858 non interactively attaching files to message edit window
1859 * src/widgets/modest-msg-edit-window.h:
1860 * tests/dbus_api/Makefile.am:
1861 added test_compose_mail.c
1862 * tests/dbus_api/test_compose_mail.c: (main):
1864 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1866 * src/modest-account-view.c:
1867 Fixed bug projects.maemo.org bug NB#59307
1869 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1871 * src/maemo/easysetup/modest-easysetup-wizard.c:
1872 (get_serverport_incoming), (on_before_next), (create_account):
1873 * src/maemo/modest-account-settings-dialog.c:
1874 (modest_account_settings_dialog_set_account_name):
1875 * src/maemo/modest-maemo-utils.c:
1876 (on_camel_account_get_supported_secure_authentication_status),
1877 (on_camel_account_get_supported_secure_authentication),
1878 (on_secure_auth_cancel),
1879 (modest_maemo_utils_get_supported_secure_authentication_methods):
1881 Implemented security authentication for settings and easysetup.
1883 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1885 * src/maemo/modest-main-window.c: (create_details_widget):
1886 Show the total size for memory card accounts too, instead of showing
1887 the name again. Fixes bug projects.maemo.org bug NB#59307.
1889 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1892 * src/modest-tny-simple-folder-store.c:
1893 * src/modest-tny-simple-folder-store.h: Removed.
1895 * src/modest-tny-local-folders-account.h
1896 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1897 for the local-folders maildir, with an extra TnyMergedFolder containing
1898 the folders of the per-account outbox store accounts.
1899 * src/modest-tny-account-store.c: (get_server_accounts):
1900 Add the outboxes to the special local folders account after creating it.
1902 * src/modest-tny-account.c:
1903 (modest_tny_account_new_for_local_folders): Create the derived
1904 account when creating the main local-folders account.
1906 * src/maemo/modest-main-window.c: (create_details_widget),
1907 (modest_main_window_set_contents_style):
1908 Adapted to the use of the derived account instead of the folder store.
1910 * src/modest-ui-actions.c:
1911 (modest_ui_actions_on_folder_selection_changed):
1912 * src/modest-ui-dimming-rules.c:
1913 (modest_ui_dimming_rules_on_new_folder):
1914 * src/widgets/modest-folder-view.c: (text_cell_data),
1915 (icon_cell_data), (filter_row), (update_model),
1916 (get_cmp_rows_type_pos):
1919 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1920 Do not get the priv struct, because no priv struct has been set,
1921 to avoid a runtime warning.
1923 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1924 #ifelse with #else, to fix a warning, to fix the build.
1927 2007-06-05 Christian Kellner <ckellner@openismus.com>
1929 * libmodest-dbus-client/libmodest-dbus-client.c:
1930 Fix small typo in doc (why do you always see them
1931 AFTER committing stuff?)
1934 2007-06-05 Christian Kellner <ckellner@openismus.com>
1936 * libmodest-dbus-client/libmodest-dbus-client.c:
1937 (libmodest_dbus_client_search):
1938 Initialize hit list with NULL. Also set folder list
1939 to "" if NULL was supplied.
1942 2007-06-03 Christian Kellner <ckellner@openismus.com>
1944 * libmodest-dbus-client/libmodest-dbus-client.c:
1945 (modest_search_hit_list_free):
1946 Make it save to call it with NULL.
1948 * src/dbus_api/modest-dbus-callbacks.c:
1949 * src/modest-search.c:
1950 Return full ModestSearchHits as the search result list not TnyHeader
1951 since can't be around withouth the correspoding TnyFolder.
1953 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1955 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1956 Added currently commented code to check for secure auth
1958 * src/maemo/modest-account-settings-dialog.c: (on_response),
1959 (save_configuration), (show_ok):
1960 Fixed projects.maemo.org bugs NB #59248 and #59251
1962 * src/maemo/modest-maemo-utils.c:
1963 (on_camel_account_get_supported_secure_authentication_status),
1964 (on_camel_account_get_supported_secure_authentication),
1965 (modest_maemo_utils_get_supported_secure_authentication_methods):
1966 * src/maemo/modest-maemo-utils.h:
1967 Moved get_supported_secure_authentication() method here to be able
1968 to use it from easysetup wizard.
1970 * src/modest-pair.c: (on_pair_compare_as_string):
1971 Should compare string with first part of pair and not
1972 strcmp pairs which will crash.
1974 * src/modest-protocol-info.c:
1975 (modest_protocol_info_protocol_is_store):
1976 * src/modest-protocol-info.h:
1977 Added modest_protocol_info_get_auth_protocol_name()
1979 2007-06-03 Armin Burgmeier <armin@openismus.com>
1981 * src/modest-mail-operation.c:
1982 (modest_mail_operation_get_msgs_full): Set priv->account also when
1983 only retrieving a single message. This avoids a crash when canceling
1986 (modest_mail_operation_notify_end): Do not explicitely remove the
1987 operation from the queue but only emit the progress_changed signal.
1988 The queue itself listens to that signal to remove the operation when
1989 it is finished. This reduces coupling and removes a potential deadlock
1990 when modest_mail_operation_notify_end() is called from the queue
1991 itself. If that is a problem performance-wise, I would suggest to
1992 implement a status-changed signal or something.
1994 * src/modest-mail-operation-queue.c: Make sure to never call a
1995 function from another file while the queue is locked. This (hopefully)
1996 fixes another deadlock when exiting the application while retrieving
1999 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2001 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2002 Fixed build if libogs is not available
2004 2007-06-03 Christian Kellner <ckellner@openismus.com>
2006 * libmodest-dbus-client/libmodest-dbus-client.h:
2007 * libmodest-dbus-client/libmodest-dbus-client.c:
2008 (libmodest_dbus_client_delete_message):
2009 Implement deletion of messages (Client side).
2011 (modest_search_hit_free),
2012 (modest_search_hit_list_free):
2013 Utility functions to free the result hits.
2015 * src/dbus_api/modest-dbus-api.h:
2016 * src/dbus_api/modest-dbus-callbacks.c:
2017 (on_delete_message),
2018 (modest_dbus_req_handler):
2019 Implement deletion of messages (Server side).
2021 * tests/dbus_api/test_search.c: (main):
2024 * tests/dbus_api/Makefile.am:
2025 * tests/dbus_api/test_delete_message:
2026 Add little test for the message deletion logic
2028 2007-06-03 Armin Burgmeier <armin@openismus.com>
2030 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2031 when the operation queue was not empty. projects.maemo.org bug
2034 2007-06-03 Armin Burgmeier <armin@openismus.com>
2036 * src/widgets/modest-account-view.c
2037 (on_account_default_toggled): Toggle default account column
2038 explicitely instead of waiting for gconf notification (which is
2039 currently ignored). This should fix projects.maemo.org bug NB#56910
2040 for now. It should probably be removed when gconf notifications are
2043 2007-06-03 Christian Kellner <ckellner@openismus.com>
2045 * libmodest-dbus-client/libmodest-dbus-client.c:
2046 Removed debugging spew.
2048 * src/dbus_api/modest-dbus-callbacks.c:
2049 Added debugging info.
2051 * src/modest-search.c:
2052 (modest_search_all_accounts):
2053 Use tny_account_store_get_accounts () on the account store
2054 to get all accounts which is the way to get all accounts.
2056 * tests/dbus_api/test_search.c: (main):
2057 Make it possible to supply the search term on the command line.
2059 2007-06-03 Christian Kellner <ckellner@openismus.com>
2061 * libmodest-dbus-client/libmodest-dbus-client.c:
2062 * libmodest-dbus-client/libmodest-dbus-client.h:
2063 Implement searching for mesages over raw dbus. (Client side)
2065 * src/dbus_api/Makefile.am:
2066 * src/dbus_api/modest-dbus-api.h:
2067 * src/dbus_api/modest-dbus-callbacks.c:
2068 * src/dbus_api/modest-dbus-callbacks.h:
2069 Search framework (Server side). Also implement on_idle_open_message().
2071 * src/maemo/modest-platform.c: (modest_platform_init):
2072 Prepare for raw dbus/osso rpc interaction.
2074 * src/modest-search.h:
2075 Changed minsize from unspecific guint to guint32.
2077 * src/modest-search.c:
2079 Added strange hack which magically made tnymail work.
2081 (modest_search_folder),
2082 (modest_search_account),
2083 (modest_search_all_accounts):
2084 Implement helper functions to search all accounts, specific account
2087 * tests/dbus_api/Makefile.am:
2088 * tests/dbus_api/test_open_message.c:
2089 Read url to open from commandline.
2091 * tests/dbus_api/test_search.c:
2092 Implement small test for dbus search stuff
2094 2007-06-02 Armin Burgmeier <armin@openismus.com>
2096 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2097 include account type and account title. This fixes projects.maemo.org
2100 * src/maemo/modest-account-view-window.c: Set a title for the window.
2102 2007-06-02 Armin Burgmeier <armin@openismus.com>
2104 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2105 incoming and outgoing server name based on email address and server
2106 types as long as the names have not been edited manually. This fixes
2107 projects.maemo.org bug NB#58671.
2109 2007-06-02 Armin Burgmeier <armin@openismus.com>
2111 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2112 server type cannot be changed in future to the incoming details page
2113 when creating an account. This fixes projects.maemo.org bug NB#59029.
2115 2007-06-02 Armin Burgmeier <armin@openismus.com>
2117 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2118 and assigned max width chars so that they wrap instead of being
2119 truncated. Fixes projects.maemo.org bug NB#56126.
2121 2007-06-02 Armin Burgmeier <armin@openismus.com>
2123 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2124 introductory note to the connection specific smtp servers dialog, as
2125 section 8.12 of the email UI specification requires. This fixes
2126 projects.maemo.org bug NB#59212.
2128 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2130 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2131 Check for running mail operations, and offer to cancel them, as per the UI
2132 spec. This fixes projects.maemo.org bug NB#59041 .
2133 However, I suspect that tinymail may still use the network connection
2134 in ways that we cannot detect or cancel. But it should at least adapt to
2135 changes fairly well.
2137 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-tny-account-store.c: (recreate_all_accounts),
2140 (get_cached_accounts), (get_server_accounts): Do more sensible
2141 ref-counting of the temporarily-cached outbox accounts list. This seems
2142 to fix a crash when entering the password when the password was wrong.
2144 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2146 * src/gnome/modest-main-window.c: (connect_signals):
2147 * src/modest-tny-account-store.c: (get_password),
2148 (modest_tny_account_store_alert): Added comments and clues and
2149 commented-out code about how we currently fail to deal with connection
2150 errors and wrong passwords, and how we should.
2152 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2154 * src/widgets/modest-retrieve-combo-box.c:
2155 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2156 This fixes projects.maemo.org bug NB#58472 .
2158 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2160 * src/maemo/easysetup/modest-easysetup-wizard.c:
2161 (create_page_complete_easysetup):
2162 (create_page_complete_custom): Correct the last commit,
2163 putting the correct sentences in the correct pages.
2165 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2167 * src/maemo/easysetup/modest-easysetup-wizard.c:
2168 (create_page_complete_custom): Show the second sentence of text
2169 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2172 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2174 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2175 Set the leave-on-server conf key by default. This fixes
2176 projects.maemo.org bug NB#59258 .
2178 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2180 * src/maemo/modest-account-view-window.c:
2181 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2182 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2185 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2187 * src/maemo/easysetup/modest-easysetup-wizard.c:
2188 (create_caption_new_with_asterisk):
2189 * src/maemo/modest-account-settings-dialog.c:
2190 (create_caption_new_with_asterisk):
2191 Uncomment the code to add the asterisk, because they are no longer in the
2192 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2193 (update_incoming_server_title): Add an asterisk here too.
2195 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2197 * src/maemo/modest-maemo-global-settings-dialog.c:
2198 (current_connection): Check that we are even connected before trying to
2199 get the current connection name, to prevent a warning.
2201 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2202 Change the comments because tny_maemo_conic_device_connect() is now meant to
2204 * src/modest-mail-operation.c:
2205 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2206 make sure we have a connection and fail if we can't connect.
2208 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/modest-main-window.c:
2211 (on_account_store_connecting_finished): Do not try to get the
2212 connection ID if we are not really connected. I am surprised that
2213 this signal handler is called when we are not connected.
2215 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2217 * src/modest-error.h:
2218 * src/modest-ui-actions.c:
2219 (modest_ui_actions_get_msgs_full_error_handler):
2220 Renamed an enum, added comments, added an enum
2221 for retrieve-limit errors.
2223 * src/modest-mail-operation.c: (foreach_add_item),
2224 (internal_folder_observer_update), (update_account_thread),
2225 (modest_mail_operation_get_msgs_full):
2226 (modest_mail_operation_update_account),
2227 Added comments about how this works, and some code that should
2228 (but does not) check the retrieve-limit. See the TODO comment.
2230 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2232 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2233 Initialize help_id to fix the build. Warnings are good.
2235 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2237 * src/widgets/modest-hbox-cell-renderer.c:
2238 (modest_hbox_cell_renderer_append):
2239 * src/widgets/modest-vbox-cell-renderer.c:
2240 (modest_vbox_cell_renderer_append):
2241 Fix the last commit by doing an extra ref.
2243 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2245 * src/widgets/modest-hbox-cell-renderer.c:
2246 (modest_hbox_cell_renderer_append):
2247 * src/widgets/modest-vbox-cell-renderer.c:
2248 (modest_vbox_cell_renderer_append):
2249 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2250 to fix the build with Maemo Bora.
2251 However, there seems to be a remaining crash, probably due to reference
2254 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2256 * src/modest-tny-account.c:
2257 (modest_tny_account_new_for_local_folders):
2258 Use hildon_file_system_info_async_new() to get a better name for
2259 the memory card account, setting it as the account name.
2260 The timing seems to work, but this is probably
2261 not the best place to do this. See the TODO comment.
2262 * src/maemo/modest-main-window.c: (create_details_widget):
2263 * src/widgets/modest-folder-view.c: (text_cell_data):
2264 Use the tny account name instead of hardcoding a name.
2266 2007-05-30 Christian Kellner <ckellner@openismus.com>
2268 * src/modest-search.c: (modest_search):
2269 Correctly set part_search_func even if we have already parsed
2270 the query and thus a valid OgsTextSearcher object.
2272 2007-05-30 Christian Kellner <ckellner@openismus.com>
2275 Search and check for libogs.
2278 Incooparte the ogs build env.
2280 * src/modest-mime-part-search-stream.c:
2281 * src/modest-mime-part-search-stream.h:
2282 Removed since we do the real searching now in modest-search.c.
2284 * src/modest-search.c:
2285 * src/modest-search.h:
2286 Implement support for ogs. We use that if available and requested
2287 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2288 should now handle the corner case when the search term is spread
2289 across multiple reads.
2290 Also the logic in modest_search () was corrected to search all
2291 requested fields until one is found.
2293 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2297 * src/modest-init.h:
2298 * src/modest-init.c: Made modest_init_local_folders() take a
2299 path and be public so we can iniitialize maildir folders on
2302 * src/modest-local-folder-info.h:
2303 * src/modest-local-folder-info.c:
2304 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2306 * src/modest-tny-account.c:
2307 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2308 still means the standard local-folders path on the local volume.
2310 * src/modest-tny-account-store.c:
2311 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2312 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2313 all accounts when that happens.
2314 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2315 this too, so it shows up in the treeview.
2317 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2319 * src/maemo/modest-maemo-global-settings-dialog.c:
2320 (current_connection):
2321 * src/widgets/modest-global-settings-dialog.c:
2322 (current_connection_default):
2323 Use the enum values instead of 0, 1 and -1,
2324 to make the code clearer.
2326 * src/modest-account-mgr-helpers.c:
2327 (modest_account_mgr_get_connection_specific_smtp): Make this code
2330 * src/modest-runtime.h:
2331 * src/modest-runtime.c:
2332 Added modest_runtime_remove_all_send_queues().
2333 * src/maemo/modest-main-window.c:
2334 (on_account_store_connecting_finished): Recreate the send queues,
2335 using the appropriate transport accounts for this new connection.
2336 Some futher adapting might be needed if the old send queues are not
2337 automatically stopped at this point.
2339 * src/modest-tny-account-store.c: (get_server_accounts):
2340 Create the connection-specific transport accounts, so that they can
2341 be found later by their ID.
2343 * src/modest-tny-account.h:
2344 * src/modest-tny-account.c:
2345 Added modest_tny_account_new_from_server_account_name().
2346 modest_tny_account_new_from_server_account(): Do not create the
2347 send queues here, because they will be
2348 recreated anyway when the connection changes for the first time.
2350 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2352 * src/modest-local-folder-info.h:
2353 * src/modest-local-folder-info.c:
2354 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2355 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2356 tbox_folder): Take a modest account name instead of a server TnyAccount,
2357 so we can have per-modest-account rather than per-transport-account
2359 We must make sure that we change or recreate the exisitng send queues
2360 when the connection changes for connection-specific transport accounts.
2362 * src/modest-tny-account-store.c:
2363 (create_per_account_local_outbox_folders): Create outboxed per modest
2364 account, not per transport account.
2366 * src/modest-tny-account.h:
2367 * src/modest-tny-account.c:
2368 (modest_tny_account_get_special_folder): For outboxes, get the
2369 parent modest account name. The account is ignored for other folders.
2370 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2371 modest account name rather than a server TnyAccount.
2373 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-tny-account.c:
2376 (modest_tny_account_new_from_server_account):
2377 Call modest_runtime_get_send_queue() immediately after creating transport
2378 accounts, so that they start trying to send email from the outbox as soon
2379 as possible at startup. This is probably what we want.
2381 * src/modest-mail-operation.c: (update_account_thread):
2382 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2383 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2384 * src/modest-tny-send-queue.h:
2385 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2386 (modest_ui_actions_on_send):
2387 Added comments about how sending works, though it needs some more work.
2389 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-tny-account.c:
2392 (modest_tny_account_get_special_folder): Add TODO because this fails when
2393 the network is busy.
2394 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2395 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2396 Do not try to show this window when there is no active account. The UI
2397 specs does not tell us what to do in this case.
2399 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2403 * src/maemo/Makefile.am:
2404 * src/widgets/Makefile.am: Some dist fixes.
2406 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/modest-connection-specific-smtp-window.c:
2409 (on_button_edit): Make the code clearer, to prevent a double free.
2411 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2413 * src/maemo/modest-account-settings-dialog.c:
2414 (modest_account_settings_dialog_set_account_name),
2415 Check the connection-specific smtp servers checkbox if there are any.
2417 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2418 (modest_connection_specific_smtp_edit_window_init):
2419 Start with a suitable port number.
2421 * src/modest-account-mgr-helpers.h:
2422 * src/modest-account-mgr-helpers.c: Added
2423 modest_account_mgr_get_has_connection_specific_smtp().
2425 (modest_account_mgr_set_connection_specific_smtp),
2426 (modest_account_mgr_remove_connection_specific_smtp),
2427 (modest_account_mgr_get_has_connection_specific_smtp),
2428 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2429 connection-specific smtp server accounts in the account, rather than
2430 the server account conf dir.
2432 This fixes bug projects.maemo.org bug NB#58263 .
2434 * src/modest-tny-account-store.c:
2435 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2436 if there are no server accounts yet, to prevent an infinite loop when there
2437 are no accounts. Document that one must be called before the other.
2439 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2441 * src/modest-account-mgr-helpers.c:
2442 (modest_account_mgr_get_default_account): Make sure that at least
2443 one account is always the default, if there are any enabled accounts.
2444 This is just a sanity check that shouldn't be necessary.
2446 * src/modest-account-mgr-priv.c:
2447 (_modest_account_mgr_account_from_key): Unescape the conf key to
2448 get the real account name. For instance, this is an issue if a space
2449 was in the account name, which can happen because the account name
2450 is generated from the display name.
2451 (_modest_account_mgr_get_account_keyname): Always escape the
2453 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2454 Unescape the conf keys to get the real account names.
2456 For instance, previously the is-default radio button in the accounts
2457 list was not checked for any accounts at first. This fixes that,
2458 and might fix several similar bugs.
2460 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2462 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2463 Removed some debug printfs.
2465 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2467 Modest on-disk outbox directories are now here, for instance:
2468 $HOME/.modest/outboxes/<account-id-1>/outbox
2469 $HOME/.modest/outboxes/<account-id-2>/outbox
2471 $HOME/.modest/local-folders/outbox
2472 so we can have a separate outbox for each account.
2473 But they are shown as one outbox in the GtkTreeView, by using a
2474 TnyMergeFolder in a ModestTnySimpleFolderStore.
2477 * src/modest-tny-simple-folder-store.c:
2478 * src/modest-tny-simple-folder-store.h:
2479 Added ModestTnySimpleFolderStore, used to contain folders from
2480 other folder stores, such as other accounts.
2482 * src/modest-tny-outbox-account.h:
2483 * src/modest-tny-outbox-account.c:
2484 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2485 used for the per-account local outbox folders.
2487 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2488 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2489 only use this (internally) now for the non-outbox local folders.
2491 * src/modest-init.h:
2492 * src/modest-init.c: Added modest_init_one_local_folder(), for
2493 setting up the directory structure for each local folder.
2495 * src/modest-local-folder-info.c:
2496 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2497 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2499 * src/modest-local-folder-info.h:
2500 * src/modest-tny-account-store.c: (on_account_removed),
2501 (on_account_changed), (create_per_account_local_outbox_folders),
2502 (get_server_accounts), (modest_tny_account_store_get_accounts),
2503 (modest_tny_account_store_get_tny_account_by_account),
2504 (modest_tny_folder_store_is_virtual_local_folders):
2506 * src/modest-tny-account.h:
2507 * src/modest-tny-account.c:
2508 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2509 to create an on-disk per-account local outbox folder for each
2511 (create_per_account_local_outbox_folders): Create a local outbox folder
2512 for each transport account.
2513 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2514 for all local folders.
2516 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2517 instead of using g_object_get/set() directly. It is clearer.
2519 (modest_tny_folder_store_get_message_count),
2520 (modest_tny_folder_store_get_local_size
2521 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2522 because we now use these with non-acount folder stores.
2524 (modest_tny_account_get_special_folder),
2525 (modest_tny_account_new_from_server_account),
2526 (modest_tny_account_new_from_account):
2527 (recurse_folders): Adjust to the new outbox system.
2529 * src/modest-tny-folder.h:
2530 * src/modest-tny-folder.c:
2531 (modest_tny_folder_is_local_folder),
2532 (modest_tny_folder_get_local_folder_type),
2533 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2535 * src/widgets/modest-main-window.h:
2536 * src/maemo/modest-main-window.c: (create_details_widget),
2537 (modest_main_window_set_contents_style): Show details for any folder store,
2540 (modest_tny_folder_get_rules):
2541 Remove the const. C does not support constness enough for this.
2543 * src/modest-ui-actions.c:
2544 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2545 make all outboxes appear as one, in the usual local-folders tree node.
2547 (set_active_account_from_tny_account),
2548 (modest_ui_actions_on_folder_selection_changed):
2549 * src/widgets/modest-folder-view.c: (text_cell_data),
2550 (icon_cell_data), (filter_row),
2551 (add_account_folders_to_merged_folder),
2552 (add_account_folders_to_simple_folder_store), (),
2553 (get_cmp_rows_type_pos), (cmp_rows),
2554 (modest_folder_view_set_account_id_of_visible_server_account):
2555 Adjust to the new outbox system, using generic folder stores and folders
2556 in the GtkTreeModel.
2558 2007-05-23 Christian Kellner <ckellner@openismus.com>
2560 * src/modest-mail-operation.c:
2561 (modest_mail_operation_update_account):
2562 Use info->max_size instead of unintialized local var [small
2563 build fix]. (Added TODO to review that change since I don't
2566 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2568 * libmodest-dbus-client/libmodest-dbus-client.c:
2569 (libmodest_dbus_client_compose_mail): function added
2570 * src/dbus_api/modest-dbus-api.h:
2571 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2572 (on_compose_mail): Implementation of the SendAsMail functionality
2574 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2576 * src/modest-account-mgr.c:
2577 (modest_account_mgr_add_server_account): Set the secure-connection
2578 conf key for transport accounts as well as store accounts. I don't know
2579 why the if was there. For instance, this makes sure that we use SSL
2580 for the gmail preset from the easysetup wizard.
2582 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2584 * src/gnome/modest-main-window.c:
2585 (on_account_store_connecting_finished), (connect_signals):
2586 * src/maemo/modest-main-window.c:
2587 (on_account_store_connecting_finished), (connect_signals),
2588 (modest_main_window_new):
2589 Handle TnyAccountStore::connecting-finished instead of
2590 TnyDevice::connection-changed, because we cannot actually perform
2591 operations on accounts until TnyAccountStore has itself responded to
2592 the TnyDevice::connection-changed signal. This prevents a GError from
2594 Do not try to update at startup, because we (at least on scratchbox)
2595 already do an update at startup when the device goes online.
2596 This prevents a GError from tinymail.
2597 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2598 Added TODO about stopping simultaneous operations.
2600 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2603 * src/modest-mail-operation-queue.c:
2604 (modest_mail_operation_queue_remove):
2605 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2606 about where they happened.
2608 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2610 * src/modest-ui-actions.c:
2611 (modest_ui_actions_on_password_requested): Make sure that the remember
2612 output parameter is always TRUE.
2614 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2616 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2617 Show a OK/Cancel dialog if the error is a question, though we still do not
2618 know anything more about what we are asking the user.
2619 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2620 Fix an uninitialized variable (helper). This is a logic error, however.
2622 2007-05-21 Christian Kellner <ckellner@openismus.com>
2624 * src/modest-search.h:
2625 Correct bit shifting in the ModestSearchFlags enum.
2627 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2629 * src/modest-tny-account.c:
2630 (modest_tny_account_new_from_server_account): Do not use the lsub and
2631 check-all hard-coded IMAP options when using POP.
2633 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2635 * src/modest-tny-account.c:
2636 (modest_tny_account_new_from_server_account):
2637 Use NULL for the secure-auth method for POP when Password auth has been
2638 specified by the user, as we already do for IMAP. "auth=Login" causes
2639 an error from camel or the server.
2641 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/modest-account-settings-dialog.c:
2644 (create_page_account_details),
2645 (modest_account_settings_dialog_set_account_name):
2646 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2647 for the leave-on-server checkbox, rathr than just the checkbox, when
2648 the protocol is not POP.
2650 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2652 * src/widgets/modest-account-view.c:
2653 * src/widgets/modest-account-view.h:
2654 Added modest_account_view_select_account() which will be useful later
2655 to asynchronously re-select the edited account.
2657 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/modest-account-settings-dialog.c:
2660 (modest_account_settings_dialog_set_account_name):
2661 Automatically choose the port numbers based on the secure authentication
2662 methods, if they have not been chosen before.
2663 This fixes projects.maemo.org bug NB#56273 .
2665 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2667 * src/maemo/modest-main-window-ui.h:
2668 * src/modest-ui-actions.c:
2669 * src/modest-ui-actions.h:
2670 Connect the Tools/SMTP Servers menu item to
2671 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2672 SMTP servers dialog, as in the UI specification and saves changes when it
2673 is closed. This fixed projects.maemo.org bug NB#56305 .
2675 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/modest-connection-specific-smtp-window.c:
2678 (modest_connection_specific_smtp_window_init):
2679 Use gtk_window_set_default_size() to make this window big enough, so
2680 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2682 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2684 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2685 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2686 (modest_connection_specific_smtp_edit_window_init),
2687 Do not try to connect to a combobox signal before the combobox exists.
2688 This fixes the cras in projects.maemo.org bug NB#56288 .
2689 (modest_connection_specific_smtp_edit_window_get_settings):
2690 Remove the server_account_name parameter which was being checked for NULL
2691 though it was not used.
2693 * src/maemo/modest-connection-specific-smtp-window.c:
2694 (modest_connection_specific_smtp_window_fill_with_connections),
2695 (on_button_edit), (modest_connection_specific_smtp_window_init):
2696 Correct the number of treemodel columns to prevent a warning.
2697 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2698 libconic does not work.
2700 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2702 * src/modest-tny-account.c:
2703 (modest_tny_account_new_from_server_account):
2704 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2705 SMTP when "None" was chosen by the user. However, with my SMTP server that
2706 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2709 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2711 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2712 to explain the memory management issue with the ID in the ModestPair.
2714 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2715 (add_sending_page), (modest_account_assistant_finalize):
2716 * src/gnome/modest-gnome-global-settings-dialog.c:
2717 (create_updating_page), (create_composing_page):
2718 * src/gnome/modest-msg-edit-window.c: (get_transports),
2719 (init_window), (modest_msg_edit_window_finalize),
2720 (modest_msg_edit_window_get_msg_data):
2721 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2722 * src/gnome/modest-transport-widget.c:
2723 (modest_transport_widget_finalize), (smtp_configuration):
2724 * src/maemo/modest-maemo-global-settings-dialog.c:
2725 (create_updating_page), (create_composing_page):
2726 * src/maemo/modest-msg-edit-window.c: (get_transports),
2727 (init_window), (modest_msg_edit_window_finalize),
2728 (modest_msg_edit_window_get_msg_data),
2729 (modest_msg_edit_window_free_msg_data):
2730 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2731 (modest_store_widget_finalize):
2732 * src/maemo/modest-transport-widget.c:
2733 (modest_transport_widget_finalize), (smtp_configuration):
2734 * src/modest-main.c: (send_mail):
2735 * src/widgets/modest-combo-box.h:
2736 * src/widgets/modest-global-settings-dialog-priv.h:
2737 * src/widgets/modest-global-settings-dialog.c:
2738 (modest_global_settings_dialog_finalize):
2739 * src/widgets/modest-msg-edit-window.h:
2740 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2741 as long as the combo box, to prevent use of freed memory for the ID.
2743 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2745 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2746 get_accounts(), to make this clearer. Do not check for the enabled gconf
2747 key, because we do not use this for server accounts (at least, not yet).
2748 This allows us to send email again.
2750 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/modest-platform.c:
2753 (on_modest_conf_update_interval_changed), (modest_platform_init):
2754 Only respond to this particular key change. All these strcmp()s cannot be
2757 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2759 * src/maemo/modest-maemo-global-settings-dialog.c:
2760 (current_connection): Prevent a crash in scratchbox when
2761 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2762 * src/maemo/modest-platform.c:
2763 (on_modest_conf_update_interval_changed), (modest_platform_init):
2764 Get the update interval from gconf and reset it when the gconf key changes.
2766 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2768 * src/modest-protocol-info.c:
2769 * src/modest-protocol-info.h: Adde enum-specific get functions,
2770 instead of using a ModestProtocolType enum parameter.
2772 * src/gnome/modest-account-assistant.c:
2773 * src/gnome/modest-store-widget.c:
2774 * src/gnome/modest-store-widget.h:
2775 * src/gnome/modest-transport-widget.c:
2776 * src/gnome/modest-transport-widget.h:
2777 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2778 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2779 * src/maemo/easysetup/modest-easysetup-wizard.c:
2780 * src/maemo/modest-account-settings-dialog.c:
2781 * src/maemo/modest-account-settings-dialog.h:
2782 * src/maemo/modest-store-widget.c:
2783 * src/maemo/modest-store-widget.h:
2784 * src/maemo/modest-transport-widget.c:
2785 * src/maemo/modest-transport-widget.h:
2786 * src/modest-account-mgr-helpers.c:
2787 * src/modest-account-mgr-helpers.h:
2788 * src/modest-account-mgr.c:
2789 * src/modest-account-mgr.h:
2790 * src/modest-tny-account.c:
2791 * src/modest-tny-folder.c:
2792 * src/widgets/modest-account-view.c:
2793 * src/widgets/modest-retrieve-combo-box.c:
2794 * src/widgets/modest-retrieve-combo-box.h:
2795 * src/widgets/modest-secureauth-combo-box.c:
2796 * src/widgets/modest-serversecurity-combo-box.c:
2797 * src/widgets/modest-serversecurity-combo-box.h:
2798 * tests/check_account-mgr.c:
2799 Use the specific functions, and use the re-renamed enum values for GNOME too.
2801 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2803 * src/modest-pair.h:
2804 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2805 so we can get the second based on the first.
2807 * src/maemo/modest-account-settings-dialog.h:
2808 * src/maemo/modest-account-settings-dialog.c:
2809 Added get_supported_secure_authentication_methods(), though it is mostly
2810 commented-out for now until the necessary API is committed to tinymail.
2811 (modest_account_settings_dialog_set_account_name),
2812 (save_configuration): Request the supported authentication methods from the
2813 server, so we can choose a working method.
2815 * src/modest-tny-account-store.h:
2816 * src/modest-tny-account-store.c:
2817 (modest_tny_account_store_get_session): Rename from
2818 tny_account_store_get_session().
2820 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2822 * src/modest-protocol-info.h: Split the ModestProtocol enum
2823 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2824 There was no need to have these unrelated values in one enum.
2826 * src/: many files: Adapted to changed enum. This makes the code a bit
2827 clearer, and the compiler could catch some errors.
2829 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2831 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2832 Show the detailed internal camel error message when an error happens
2833 during the configuration, so that our testers can give us more clues.
2834 For instance, in projects.maemo.org bug NB#56910 .
2836 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2838 * src/modest-tny-account.c:
2839 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2840 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2842 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2844 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2845 * src/maemo/modest-account-settings-dialog.c:
2846 (modest_account_settings_dialog_set_account_name),
2847 (save_configuration): For the incoming secure authentication checkbox,
2848 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2849 the UI specification. PLAIN does not seem to be supported for most IMAP
2850 servers anyway, and I am not sure what it would mean.
2851 However, we probably need to discover which of the secure-authentication
2852 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2853 * src/modest-account-mgr-helpers.c:
2854 (modest_account_mgr_get_server_account_data):
2856 * src/modest-tny-account.c:
2857 (modest_tny_account_new_from_server_account):
2858 Use tny_account_set_mech() to set secure-authentication methods,
2859 with some special-casing for IMAP, based on my observations of how
2862 * src/modest-account-mgr-helpers.h:
2863 * src/modest-account-mgr.c:
2864 * src/modest-defs.h: Comment that the URI is only used for local folders.
2866 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2868 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2869 parameter const, just to be neat.
2870 * src/modest-text-utils.c: (modest_text_utils_inline):
2871 End g_strconcat() with NULL, as its documentation says. This is almost
2872 certainly the cause of my crash at startup on the device. Interestingly,
2873 valgrind doesn't tell us about these errors.
2875 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2877 * scripts/build-packages: Added more precise comments about how to use
2878 this script, though I still get this error:
2879 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2880 error building tinymail
2882 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2884 * src/maemo/modest-main-window.c: (on_account_update):
2885 Very slight cleanup, hoping to make it simpler to discover what causes
2886 a crash here sometimes.
2888 * src/modest-tny-account.c:
2889 (modest_tny_account_new_from_server_account): Set the port. Added
2890 comments about the options and a TODO comment because I need to find out
2891 how to specify the secure authentication method.
2893 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2895 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2896 changed CFlags paths form modest to libmodest
2898 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2900 * src/modest-account-mgr-helpers.c:
2901 (modest_account_mgr_get_server_account_data),
2902 (modest_account_mgr_free_server_account_data):
2903 * src/modest-account-mgr-helpers.h:
2904 * src/modest-account-mgr.c:
2905 (modest_account_mgr_add_server_account):
2906 * src/modest-defs.h:
2907 * src/modest-tny-account.c:
2908 (modest_tny_account_new_from_server_account):
2909 Determine the options for tny_camel_account_add_option() here,
2910 based on the settings, rather than storing them directly in gconf.
2912 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2914 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2915 Show a more friendly error dialog now that we expect (from the tinymail
2916 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2918 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2920 * src/maemo/modest-main-window.c: (on_account_update): Check that
2921 account_name is not NULL, to prevent a crash at startup that I am
2922 seeing on the N800. I do wonder why it is NULL.
2924 * src/maemo/easysetup/modest-easysetup-wizard.c:
2925 (create_page_user_details):
2926 * src/maemo/modest-account-settings-dialog.c:
2927 (create_page_user_details), (create_page_outgoing):
2928 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2929 (modest_connection_specific_smtp_edit_window_init):
2930 * src/modest-ui-actions.c:
2931 (modest_ui_actions_on_password_requested):
2932 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2933 might do something useful with the on-screen keyboard.
2935 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2937 * src/maemo/modest-main-window.c: (on_account_update):
2938 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2939 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2941 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2943 * src/modest-tny-account-store.c: (on_account_changed):
2944 Correct the signature of this signal handler.
2946 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2948 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2949 Show a HildonNote instead of a GtkDialog for Maemo.
2951 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2953 * src/widgets/modest-account-view.h:
2954 * src/widgets/modest-account-view.c: (on_account_changed),
2955 (on_account_removed). Added a boolean flag, set/unset by
2956 modest_account_view_block_conf_updates(),
2957 modest_account_view_unblock_conf_updates() to prevent unnecessary
2958 updates, but this is not very useful because the gconf notifications are
2959 so delays (maybe only on Maemo Bora).
2960 So auto-updating is turned off, and these functions do an explicit
2961 update when necessary.
2962 However, something else is still doing too much work when adding/removing
2963 accounts, probably in another part of the application.
2965 * src/maemo/modest-account-view-window.c:
2966 (on_delete_button_clicked), (on_edit_button_clicked),
2967 (on_new_button_clicked): Use the new functions.
2969 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2971 * src/modest-account-mgr-helpers.c:
2972 (modest_account_mgr_set_first_account_as_default):
2973 Sort the list of names alphabetically-by-title, so we choose the first one
2975 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2976 alphabetically by the title.
2978 This fixes projects.maemo.org bug NB#56418 .
2980 * src/modest-account-mgr-priv.c:
2981 (_modest_account_mgr_account_from_key):
2982 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2983 avoid a valgrind error, and possible random behaviour.
2985 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2987 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2988 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2989 tinymail documentation to say that this can be expected.
2990 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2991 pretty, and should not happen, but I would prefer to know when it does.
2993 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2995 * configure.ac: When using the older hildon version, probably on Bora,
2996 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2998 * src/widgets/modest-attachment-view.c:
2999 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3002 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3004 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3005 Implemented the prototype. Can be tested with
3006 tests/dbus_api/test_open_message:
3008 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3010 * src/modest-tny-account-store.c:
3011 (modest_tny_account_store_instance_init), (get_password):
3012 * src/modest-ui-actions.c:
3013 (modest_ui_actions_on_password_requested):
3014 Do not store the password in gconf, because this function is called
3015 for non-remembered passwords. Actually use the cached (in the hash map)
3016 password instead of releasing it.
3017 The password will now not be remembered if it is asked via the protected
3018 password dialog, as per the UI spec.
3020 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3022 * src/modest-defs.h:
3023 * src/modest-account-mgr-helpers.h:
3024 * src/modest-account-mgr-helpers.c:
3025 Added modest_server_account_get_username_has_succeeded(),
3026 modest_server_account_set_username_has_succeeded().
3027 (modest_server_account_set_username),
3028 Reset the has-succeeded flag if the username changes.
3030 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3031 * src/maemo/modest-connection-specific-smtp-window.c:
3032 (modest_connection_specific_smtp_window_save_server_accounts):
3033 Use modest_server_account_set_username() instead of using
3034 modest_conf_set_string() directly, so that the has-succeeded flag is always
3037 * src/modest-ui-actions.c:
3038 (modest_ui_actions_on_password_requested): Dim the username entry if
3039 the username has ever worked, as per the UI spec.
3041 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3043 * src/modest-tny-account-store.c: (get_password):
3044 * src/modest-ui-actions.c:
3045 (modest_ui_actions_on_password_requested):
3046 Allow the username to be changed too, though there is more work to
3047 be done on exactly how this behaves.
3049 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3051 * src/modest-account-mgr-helpers.h:
3052 * src/modest-account-mgr-helpers.c:
3053 Added modest_account_mgr_get_display_name(),
3054 modest_server_account_get_username(),
3055 modest_server_account_set_username(),
3056 modest_server_account_set_password(),
3057 modest_server_account_get_hostname() functions so we do not need to
3058 use the conf API directly.
3060 * src/maemo/modest-main-window.c: (connect_signals):
3061 Actually connect ot the ModestAccountStore::request-password signal,
3062 so that we show the dialog when the password is requested by Tinymail,
3063 for isntance if it is empty.
3065 * src/modest-marshal.list:
3066 * src/modest-tny-account-store.c:
3067 (modest_tny_account_store_class_init), (get_password),
3068 (modest_tny_account_store_alert):
3069 * src/modest-tny-account-store.h:
3070 * src/modest-ui-actions.h:
3071 * src/modest-ui-actions.c:
3072 (modest_ui_actions_on_password_requested):
3073 Change the signal parameters, so it is obvious that we are providing
3074 the non human-readable server name, and receiving both the username
3075 and password, though changing of the username is not yet implemented.
3076 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3077 for the GNOME version.
3079 This should fix the projects.maemo.org bug NB#56209, though it does not
3080 work on Bora, because the gconf_client_get() for the password fails
3081 immediately after we save it with gconf_client_set().
3083 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3086 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3087 caused an undefined symbol error:
3088 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3090 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3092 * src/modest-tny-account-store.c:
3093 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3094 using a GError instead of a string message, so we can translate it in
3097 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3099 * src/maemo/modest-address-book.c:
3100 (modest_address_book_check_names):
3101 * src/maemo/modest-msg-view-window.c:
3102 (modest_msg_view_window_clipboard_owner_change):
3103 * src/modest-init.c: (modest_init_init_ui):
3104 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3105 (update_folders_cb), (modest_mail_operation_update_account):
3106 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3107 (modest_ui_actions_on_msg_attachment_clicked),
3108 (modest_ui_actions_on_msg_recpt_activated):
3109 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3110 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3111 (modest_msg_view_search_next):
3112 * src/widgets/modest-recpt-editor.c:
3113 (modest_recpt_editor_on_button_release_event),
3114 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3115 g_message(). At this point we should only be seeing interesting errors on
3116 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3118 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3120 (modest_wizard_dialog_force_title_update):
3121 * src/maemo/easysetup/modest-wizard-dialog.h:
3122 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3123 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3124 can update the title when appropriate. Otherwise the title is wrong if the
3125 pages are added after adding the notebook to the dialog.
3126 This must be a problem in HildonWizardDialog too.
3127 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3129 * src/maemo/easysetup/modest-easysetup-wizard.c:
3130 (create_subsequent_customsetup_pages),
3131 (create_subsequent_easysetup_pages):
3132 Call modest_wizard_dialog_force_title_update() so that the title is
3133 correct even with GTK+ < 2.10.
3134 This fixes projects.maemo.org bug NB#56145 .
3136 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3138 * src/maemo/modest-platform.c:
3139 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3140 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3143 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3145 * src/widgets/modest-window.h:
3146 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3147 and modest_window_save_state(), which invokes it.
3149 * src/widgets/modest-window-mgr.h:
3150 * src/widgets/modest-window-mgr.c:
3151 Added modest_window_mgr_save_state_for_all_windows(), which calls
3152 the save_state vfunc on all registered windows, if implemented.
3154 * src/gnome/modest-msg-edit-window.c:
3155 * src/gnome/modest-msg-view-window.c:
3156 * src/maemo/modest-msg-edit-window.c:
3157 * src/maemo/modest-msg-view-window.c:
3158 * src/maemo/modest-main-window.c:
3159 Specify the existing save_settings functions as implementations of
3160 ModestWindow::save_state_func().
3162 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3163 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3164 enabling hibernation, for instance.
3166 We may need to do the same thing for restoring settings.
3169 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3171 * src/widgets/modest-window-mgr.c:
3172 * src/widgets/modest-window-mgr.h:
3173 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3174 modest_window_mgr_get_hibernation_is_prevented().
3176 * src/maemo/modest-main-window.c:
3177 (on_hildon_program_is_topmost_notify): Prevent hibernation
3178 (possible when the application goes to the background in the WM),
3179 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3181 * src/maemo/easysetup/modest-easysetup-wizard.c:
3182 (modest_easysetup_wizard_dialog_init):
3183 * src/maemo/modest-account-settings-dialog.c:
3184 (modest_account_settings_dialog_init):
3185 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3186 (modest_connection_specific_smtp_edit_window_init):
3187 * src/maemo/modest-connection-specific-smtp-window.c:
3188 (modest_connection_specific_smtp_window_init):
3189 * src/maemo/modest-signature-editor-dialog.c:
3190 (modest_signature_editor_dialog_init):
3191 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3192 prevent hibernation while any of these account settings dialogs are open.
3194 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3196 * src/maemo/Makefile.am:
3197 * src/maemo/modest-osso-state-saving.c:
3198 * src/maemo/modest-osso-state-saving.h: Added
3199 modest_osso_load_state() and modest_osso_save_state() though they do
3200 nothing now. They should iterate through all the open windows and load/save
3202 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3203 save state when closing.
3205 * src/maemo/modest-main-window.c:
3206 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3207 Add a notification handler for the HildonProgram::is-topmost property,
3208 so we can allow hibernation when the application goes into the background.
3209 But we still need to detect when the accounts setup windows are open so
3210 we can stop hibernation when they are open.
3211 To do this, I also added the main window the HildonProgram. This might have
3212 other side-effects/benefits, and should maybe be done for other windows.
3214 * src/maemo/modest-osso-autosave-callbacks.h:
3215 * src/maemo/modest-osso-autosave-callbacks.c:
3216 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3217 though it does not do anything yet, and we might never need this to do
3218 anything. For instance, we already save drafts.
3220 * src/maemo/modest-platform.c: (modest_platform_init):
3221 Specify the libosso auto-save callback.
3223 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3225 * src/maemo/modest-platform.c:
3226 (modest_platform_set_update_interval):
3227 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3228 aparently stays valid between application instances, so we can use this
3229 to remove and reset it later. According to a maemo-developers email from
3232 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3234 * configure.ac: Depend on libalarm for Maemo.
3236 * src/dbus_api/modest-dbus-api.h:
3237 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3238 (on_send_receive), (modest_dbus_req_handler):
3239 Handle a SEND_RECEIVE D-Bus method.
3241 * libmodest-dbus-client/libmodest-dbus-client.c:
3242 (libmodest_dbus_client_send_and_receive):
3243 * libmodest-dbus-client/libmodest-dbus-client.h:
3244 Add C convenience functions for calling the new D-Bus method.
3246 * src/modest-platform.h:
3247 * src/gnome/modest-platform.c:
3248 * src/maemo/modest-platform.c:
3249 Added modest_platform_set_update_interval(), which uses the
3250 alarmd API on Maemo.
3251 (modest_platform_init),
3252 Call modest_platform_set_update_interval(), using a hard-coded
3253 interval for now (until the global settings dialog is implemented),
3254 though I am not sure that this makes sense yet.
3256 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3258 * src/dbus_api/modest-dbus-callbacks.c:
3259 (modest_osso_cb_hw_state_handler):
3260 * src/dbus_api/modest-dbus-callbacks.h:
3261 * src/maemo/modest-platform.c: (modest_platform_init):
3262 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3263 in case this has some effect on the ability for Maemo to ping the
3266 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3268 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3269 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3270 warning. It is probably a logic error, but I need to fix the build.
3272 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3274 * src/modest-account-mgr.h:
3275 * src/modest-account-mgr.c:
3276 (modest_account_mgr_account_names): Add a gboolean enabled_only
3277 parameter, so we can get lists of onlt the enabled accounts.
3279 (modest_account_mgr_add_account),,
3280 (modest_account_mgr_account_with_display_name_exists):
3281 * src/maemo/modest-msg-edit-window.c: (get_transports):
3282 * src/modest-account-mgr-helpers.c:
3283 (modest_account_mgr_set_first_account_as_default):
3284 * src/modest-init.c: (init_default_account_maybe):
3285 * src/modest-tny-account-store.c: (get_accounts):
3286 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3287 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3288 * tests/check_account-mgr.c: (START_TEST):
3289 Provide the extra parameter, as appropriate.
3291 * src/widgets/modest-account-view.c: (update_account_view):
3292 Do not show disabled accounts (meaning that there is no way to
3293 enable/disable accounts in the UI (the feature is not in our UI
3294 specification), so we can use this internally only to mark unfinished
3295 or temporary account data.
3297 * src/maemo/easysetup/modest-easysetup-wizard.c:
3298 (create_account): Add boolean enable parameter, so we can specify FALSE
3299 to create the temporary account.
3300 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3301 (on_before_next): When finishing, when there is a temporary account, just
3303 Also, use a timeout to delay the showing of the dialog until gconf is likely
3304 to return correct information, due to a maemo gconf bug that is fixed in
3305 osso 1.1, but not yet in Bora.
3306 However, the dialog stays on screen after it is destroyed.
3308 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3309 for invalid data when cancelling. Use a hildon note instead of a dialog
3310 to complain about invalid data. Do not show the account-saved note if the
3311 account is disabled (a temporary account that will not really be saved for use
3314 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3316 * src/modest-account-mgr-helpers.h:
3317 * src/modest-account-mgr-helpers.c:
3318 Added modest_account_mgr_unset_default_account(),
3319 Added modest_account_mgr_set_first_account_as_default().
3321 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3322 If it was the default account, unset the default account name.
3324 * src/maemo/modest-account-view-window.c:
3325 (on_delete_button_clicked): If it was the default account,
3326 set the first remaining account as the default instead.
3328 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3329 a NULL account or a NULL default account, to prevent a crash. This should
3330 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3333 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3335 * src/widgets/modest-recpt-editor.c:
3336 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3337 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3338 TODO comment for this. This fixes the build.
3340 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3341 be the best place for it. This will in future update all auto-update accounts,
3342 rather than just the current/default account, when that gconf key exists.
3343 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3344 if there are no accounts, before calling do_send_receive().
3345 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3347 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3348 * src/maemo/modest-main-window-ui.h:
3349 * src/maemo/modest-main-window.c: (on_connection_changed),
3350 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3351 directly, becaue the signal handler does more.
3353 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3355 * src/modest-account-mgr-helpers.c:
3356 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3357 for the case that the account does not exist.
3359 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3360 (equivalent to the modest account name) rather than the tinymail account name
3361 (equivalent to the modest account title - human readable) to get the account data.
3362 Check for null account data to prevent the crash, and add a TODO comment saying that
3363 this needs fixing because it is using the server account name instead of the account name.
3365 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3367 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3368 * src/maemo/modest-account-settings-dialog.c: (show_error),
3370 Use hildon_note_new_information() for informative and error messages,
3371 which seems to be expected for Maemo applications (no documentation that I know of
3372 says this). I am surprised that there is no distinction between info and error
3375 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3377 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3378 it is easy to find where this is used.
3380 * src/maemo/easysetup/modest-easysetup-wizard.c:
3381 (create_page_welcome), (create_page_account_details),
3382 (create_page_user_details), (create_page_complete_easysetup),
3383 (create_page_custom_incoming), (create_page_custom_outgoing),
3384 (create_page_complete_custom):
3385 * src/maemo/modest-account-settings-dialog.c:
3386 (create_page_account_details), (create_page_user_details),
3387 (create_page_incoming), (create_page_outgoing):
3388 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3389 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3390 (modest_connection_specific_smtp_edit_window_init):
3391 * src/maemo/modest-connection-specific-smtp-window.c:
3392 (modest_connection_specific_smtp_window_init):
3393 * src/maemo/modest-signature-editor-dialog.c:
3394 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3395 and scrolling policy as per the Email Application Layout Guide, if I have
3398 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3400 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3401 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3402 which were empty, because these vfuncs have been removed from TnyAccountStore.
3403 This fixes the build.
3405 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3407 * src/maemo/modest-main-window.c:
3408 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3409 showing/hiding it. Added TODO because it probably should not be NULL.
3410 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3411 because unnecessary g_warnings() make degugging difficult.
3413 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3415 * src/maemo/modest-msg-edit-window.c:
3416 (modest_msg_edit_window_select_color),
3417 (modest_msg_edit_window_select_background_color): 2 const corrections and
3418 moving 2 #endifs before closing brackets, to fix the build.
3420 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3422 * src/maemo/easysetup/modest-easysetup-wizard.h:
3423 * src/maemo/easysetup/modest-easysetup-wizard.c:
3424 (modest_easysetup_wizard_dialog_finalize),
3425 (on_button_edit_advanced_settings), (create_page_complete_custom),
3426 (on_response), (create_account):
3427 Implement the Advanced Settings edit button, by saving the account information,
3428 for the Advanded Settings dialog to use directly from gconf, and removing it
3429 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3430 Bug #5533 in the projects.maemo.org bugzilla.
3432 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/modest-msg-view-window.c:
3435 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3436 when opening a message window.
3438 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3440 * src/maemo/easysetup/modest-easysetup-wizard.c:
3441 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3444 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3445 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3446 gconf settings. I probably added more checks than necessary, but that is safer.
3448 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3449 variable to fix the build, but this seems to be used when it is still NULL.
3451 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3453 * src/modest-platform.h:
3454 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3455 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3456 * src/modest-main.c: Implement this function so we can avoid using
3457 maemo-specific API from cross-platform code.
3459 * src/modest-tny-account-store.c:
3460 (get_smtp_specific_transport_account_for_open_connection):
3461 * src/modest-ui-actions.c: (check_for_connection),
3462 (modest_ui_actions_on_item_not_found):
3463 Use modest_platform_connect_and_wait() and put #idefs around other
3464 maemo-specific code, because only maemo currently has a way to
3465 identify connection names.
3467 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3469 * src/modest-tny-account-store.h:
3470 * src/modest-tny-account-store.c:
3471 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3472 the connection-specific SMTP server settings in the configuration.
3474 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3476 * src/maemo/modest-main-window.c: (on_connection_changed),
3478 * src/modest-main.c: (main), (start_ui), (send_mail):
3479 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3480 that is what is intended.
3482 * src/modest-ui-actions.c: (action_send), (action_receive),
3483 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3484 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3485 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3486 SMTP server is used when it is specified.
3488 (modest_ui_actions_on_send_receive):
3489 Check that a connection is open before proceeding.
3490 Receive and then send, instead of vice-versa, as per the specification.
3492 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3494 * src/modest-mail-operation.c:
3495 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3496 though I guess it should be something other than NULL.
3498 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3500 * src/maemo/easysetup/modest-easysetup-wizard.c:
3501 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3502 combo twice, to avoid an g_warning and to make it visible again.
3503 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3504 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3505 (already intended) dereference when detaching, because we then recreate the menu.
3506 But I am not sure why the warning was happening, and it is possible that this is a memory
3509 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3511 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3512 and uri_parse_mailto() utility functions.
3513 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3515 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3517 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3519 * src/dbus_api/modest-dbus-api.h:
3520 * src/dbus_api/modest-dbus-callbacks.c:
3521 Use an idle callback to execute the modest code in the application's own thread.
3522 Remove the helloworld example method.
3523 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3524 parsed, and the open-message method is not implemented because this is not yet implemented in
3526 * libmodest-dbus-client/libmodest-dbus-client.c:
3527 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3528 (libmodest_dbus_client_open_message):
3529 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3531 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3532 body without crashing.
3534 * tests/dbus_api/Makefile.am:
3535 * tests/dbus_api/test_mail_to.c:
3536 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3538 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3540 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3541 Added file to fix the build. Sorry.
3543 * src/dbus_api/Makefile.am:
3544 * src/dbus_api/modest-dbus-api.h:
3545 * src/dbus_api/modest-dbus-callbacks.h:
3546 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3547 (modest_dbus_req_handler):
3548 Put constants in a separate header so it can be reused by the
3549 client library, without duplication
3551 * libmodest-dbus-client/Makefile.am:
3552 * libmodest-dbus-client/libmodest-dbus-client.c:
3553 (libmodest_dbus_client_call_helloworld),
3554 (libmodfest_dbus_client_send_mail),
3555 (libmodfest_dbus_client_mailto),
3556 (libmodfest_dbus_client_open_message):
3557 * libmodest-dbus-client/libmodest-dbus-client.h:
3558 (Partly) Implement a send_mail D-Bus method.
3560 * tests/dbus_api/Makefile.am:
3561 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3562 the send_email D-Bus method.
3564 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3568 * libmodest-dbus-client/Makefile.am:
3569 * libmodest-dbus-client/libmodest-dbus-client.c:
3570 * libmodest-dbus-client/libmodest-dbus-client.h:
3571 * tests/dbus_api/Makefile.am:
3572 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3573 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3575 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3577 * src/maemo/easysetup/modest-easysetup-wizard.c:
3578 (create_page_account_details):
3579 * src/maemo/modest-account-settings-dialog.c:
3580 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3581 widgets, because this might not be the default in future versions of the Maemo GTK+.
3582 However, I can not not get capitalization to work even in a simple test case.
3584 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3586 * src/maemo/easysetup/modest-easysetup-wizard.c:
3587 (create_page_custom_incoming), (create_page_custom_outgoing):
3588 * src/maemo/modest-account-settings-dialog.c:
3589 (create_page_account_details), (create_page_incoming),
3590 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3591 instead of using gtk_check_button_with_label(), so they are aligned like the other
3592 widgets, as per the UI spec.
3594 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3596 * src/maemo/easysetup/modest-easysetup-wizard.c:
3597 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3598 * src/widgets/modest-validating-entry.c:
3599 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3600 Modest prefix instead of an EasySetup prefix.
3602 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3604 * src/widgets/modest-validating-entry.h:
3605 * src/widgets/modest-validating-entry.c: (on_insert_text),
3606 Added easysetup_validating_entry_set_max_func(), used to set a callback
3607 to call when the max number of characters is reached. GtkEntry has a max-length
3608 already but is silent about it.
3610 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3611 (create_page_account_details), (create_page_user_details),
3613 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3614 (create_page_account_details), (create_page_user_details),
3615 (create_page_outgoing):
3616 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3617 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3618 the UI spec, when the user tries to enter more than the max number of characters.
3620 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3622 * src/maemo/easysetup/modest-easysetup-wizard.c:
3623 (create_page_user_details), (create_page_custom_incoming),
3624 (create_page_custom_outgoing):
3625 * src/maemo/modest-account-settings-dialog.c:
3626 (create_page_user_details), (create_page_incoming),
3627 (create_page_outgoing):
3628 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3629 (modest_connection_specific_smtp_edit_window_init):
3630 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3631 not appropriate. Bad Maemo-specific defaults!.
3633 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3635 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3636 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3637 (modest_signature_editor_dialog_set_settings):
3638 Disable the label and textview when the checkbox is disabled, and use the
3639 specified (UI spec) default signature text.
3641 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3644 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3646 * src/modest-defs.h:
3647 * src/modest-account-mgr-helpers.h:
3648 * src/modest-account-mgr-helpers.c:
3649 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3651 * src/maemo/Makefile.am:
3652 * src/maemo/modest-signature-editor-dialog.c:
3653 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3656 * src/maemo/modest-account-settings-dialog.h:
3657 * src/maemo/modest-account-settings-dialog.c:
3658 (modest_account_settings_dialog_finalize), (on_button_signature),
3659 (save_configuration): Use the new dialog when the Edit button is pressed, and
3660 save the changes if necessary, as per the UI spec.
3662 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3664 * src/maemo/Makefile.am:
3665 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3666 based on maemo-develoers email from Dirk.
3668 * src/maemo/easysetup/modest-easysetup-wizard.c:
3669 (create_page_welcome), (create_page_account_details),
3670 (create_page_user_details), (create_page_complete_easysetup),
3671 (create_page_custom_incoming), (create_page_custom_outgoing),
3672 (create_page_complete_custom),
3673 (modest_easysetup_wizard_dialog_init):
3674 * src/maemo/modest-account-settings-dialog.c:
3675 (create_page_account_details), (create_page_user_details),
3676 (create_page_incoming), (create_page_outgoing),
3677 (modest_account_settings_dialog_init):
3678 * src/maemo/modest-connection-specific-smtp-window.c:
3679 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3681 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3683 * src/maemo/easysetup/modest-easysetup-wizard.c:
3684 (create_page_account_details), (create_page_custom_outgoing),
3685 (create_page_complete_custom):
3686 * src/maemo/modest-account-settings-dialog.c:
3687 (create_page_user_details), (create_page_incoming),
3688 (create_page_outgoing):
3689 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3690 (modest_connection_specific_smtp_edit_window_init):
3691 Use the correct (UI spec) port min/max, and use horizontal separators,
3694 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3696 * src/maemo/easysetup/modest-easysetup-wizard.c:
3697 (set_default_custom_servernames):
3698 * src/maemo/modest-account-settings-dialog.c:
3699 (create_page_incoming), (on_combo_outgoing_security_changed),
3700 (on_combo_incoming_security_changed), (create_page_outgoing),
3701 (modest_account_settings_dialog_set_account_name),
3702 (save_configuration):
3703 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3704 (on_combo_security_changed),
3705 (modest_connection_specific_smtp_edit_window_init),
3706 (modest_connection_specific_smtp_edit_window_set_connection),
3707 (modest_connection_specific_smtp_edit_window_get_settings):
3708 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3711 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3714 * src/maemo/easysetup/modest-easysetup-wizard.c:
3715 (create_page_custom_outgoing), (create_page_complete_custom):
3716 * src/maemo/modest-account-settings-dialog.c:
3717 (create_page_user_details), (create_page_outgoing):
3718 * src/maemo/modest-account-view-window.c: (button_box_new):
3719 Use changed logical IDs as per the most recent UI spec:
3720 mcen_bd_emailsetup_edit -> mcen_bd_edit
3721 mcen_bd_emailsetup_delete -> mcen_bd_delete
3722 mcen_bd_emailsetup_close -> mcen_bd_close
3724 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3728 * src/dbus_api/Makefile.am:
3729 * src/dbus_api/modest-dbus-callbacks.c:
3730 * src/dbus_api/modest-dbus-callbacks.h:
3731 * src/maemo/modest-platform.c: (modest_platform_init):
3732 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3734 * tests/Makefile.am:
3735 * tests/dbus_api/Makefile.am:
3736 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3738 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3740 * src/maemo/modest-account-settings-dialog.c:
3741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3742 Removed unnecessary includes.
3744 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/easysetup/modest-easysetup-wizard.c:
3747 * src/maemo/modest-account-settings-dialog.c:
3748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3749 * src/widgets/Makefile.am:
3750 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3751 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3752 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3753 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3754 * src/widgets/modest-secureauth-combo-box.c:
3755 * src/widgets/modest-secureauth-combo-box.h:
3756 * src/widgets/modest-serversecurity-combo-box.c:
3757 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3758 made the GObject names more consistent with the rest of the Modest code.
3760 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3762 * src/maemo/easysetup/Makefile.am:
3763 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3764 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3765 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3766 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3767 * src/maemo/easysetup/modest-easysetup-wizard.c:
3768 * src/maemo/easysetup/modest-validating-entry.c:
3769 * src/maemo/easysetup/modest-validating-entry.h:
3770 * src/maemo/modest-account-settings-dialog.c:
3771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3772 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3773 widgets/ because they are used outside of easysetup too. After checking in,
3774 svn will allow me to rename them too.
3776 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3778 * src/gnome/modest-msg-edit-window.c:
3779 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3780 linker error, to fix the build on the GNOME platform.
3781 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3782 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3783 ifdefed out to avoid a warning.
3785 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3787 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3788 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3789 some alternative for GTK+ 2.6.
3791 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3793 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3795 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3796 specified for EmailAccountsDialog in UI spec.
3798 * src/maemo/easysetup/modest-easysetup-wizard.c:
3799 * src/maemo/easysetup/modest-easysetup-wizard.h:
3800 * src/maemo/modest-account-settings-dialog.c:
3801 * src/maemo/modest-account-settings-dialog.h:
3802 Reuse a member window widget for the connection-specific SMTP server accounts,
3803 so we can tell it to create/save the accounts only if we actually save changes.
3805 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3806 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3807 (modest_connection_specific_smtp_edit_window_get_settings):
3808 Return a struct instance for temporarily remembering the entered data.
3810 * src/maemo/modest-connection-specific-smtp-window.h:
3811 * src/maemo/modest-connection-specific-smtp-window.c:
3812 (modest_connection_specific_smtp_window_finalize),
3813 (modest_connection_specific_smtp_window_fill_with_connections),
3815 (modest_connection_specific_smtp_window_save_server_accounts),
3816 (update_model_server_names): Do not actually save data until asked,
3817 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3819 (on_selection_changed),
3820 (modest_connection_specific_smtp_window_init): Disable the edit
3821 button when nothing is selected.
3823 * src/modest-account-mgr-helpers.c:
3824 * src/modest-account-mgr-helpers.h:
3825 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3828 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3830 * src/modest-account-mgr-helpers.h:
3831 * src/modest-account-mgr-helpers.c:
3832 (modest_account_mgr_get_unused_account_name),
3833 (modest_account_mgr_get_unused_account_display_name): Added these
3834 utility functions, to avoid code duplication.
3836 * src/maemo/easysetup/modest-easysetup-wizard.c:
3837 (create_page_account_details), (create_account):
3838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3839 (on_combo_security_changed),
3840 (modest_connection_specific_smtp_edit_window_init),
3841 (modest_connection_specific_smtp_edit_window_save_settings):
3842 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3843 * src/maemo/modest-connection-specific-smtp-window.c:
3844 (modest_connection_specific_smtp_window_finalize),
3845 (modest_connection_specific_smtp_window_fill_with_connections),
3846 (on_button_edit), (modest_connection_specific_smtp_window_init):
3847 * src/maemo/modest-connection-specific-smtp-window.h:
3848 Implementing saving of connection-specific server accounts.
3850 But I need to refactor this so we can save the data for each
3851 possible connection-specific account and only actually create the server accounts
3852 when the easysetup finished, or the OK button is pressed on the account settings
3855 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3857 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3858 (on_combo_security_changed):
3859 (modest_connection_specific_smtp_edit_window_init):
3860 Auto-fill the port number as in the account settings.
3862 (modest_connection_specific_smtp_edit_window_set_connection):
3863 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3864 * src/maemo/modest-connection-specific-smtp-window.c:
3865 (fill_with_connections), (on_button_edit),
3866 (modest_connection_specific_smtp_window_init):
3867 Turn the edit window into a dialog to simplify the code, and
3868 set a WM hint as in a GtkDialog, because only a popup can be on top of
3869 another window in Maemo, and popups usually have no WM decoration.
3871 * src/modest-defs.h:
3872 * src/modest-account-mgr-helpers.c:
3873 (modest_account_mgr_set_connection_specific_smtp),
3874 (modest_account_mgr_remove_connection_specific_smtp),
3875 (modest_account_mgr_get_connection_specific_smtp):
3876 * src/modest-account-mgr-helpers.h: Some functions to write the
3877 connection-specific SMTP server information. Not yet used.
3880 * src/widgets/modest-folder-view.c: (text_cell_data):
3881 Fix a warning about an uninitialized variable.
3882 (on_configuration_key_changed): Put an #ifdef around the use
3883 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3885 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3887 * src/maemo/modest-account-settings-dialog.h:
3888 * src/maemo/modest-account-settings-dialog.c:
3889 Added connect_for_modified() utility function to mark the new modified boolean.
3891 (create_page_account_details), (create_page_user_details),
3892 (create_page_incoming), (create_page_outgoing), (on_response),
3893 (modest_account_settings_dialog_init),
3894 (modest_account_settings_dialog_set_account_name):
3895 Only warn about unsaved changes when there are actually unsaved changes.
3897 * src/modest-account-mgr-helpers.c:
3898 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3899 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3900 to get the data from there in future.
3902 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3904 * src/modest-defs.h:
3906 * src/modest-account-mgr-helpers.h:
3907 * src/modest-account-mgr-helpers.c:
3908 Store the security account setting in a single conf key instead of using
3909 the options list, so that the list is left for just the to-be-removed camel hack,
3910 and because gconf_client_set_list() is failing for some reason.
3912 * src/modest-account-mgr.c:
3913 (modest_account_mgr_add_server_account):
3914 * src/maemo/modest-account-settings-dialog.c:
3915 (modest_account_settings_dialog_set_account_name),
3916 (save_configuration): Use the renamed functions.
3919 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3921 * src/widgets/Makefile.am:
3922 * src/widgets/modest-limit-retrieve-combo-box.c:
3923 * src/widgets/modest-limit-retrieve-combo-box.h:
3924 * src/widgets/modest-retrieve-combo-box.c:
3925 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3926 the account settings dialog.
3928 * src/modest-defs.h:
3929 * src/modest-account-mgr-helpers.h:
3930 * src/modest-account-mgr-helpers.c:
3931 (modest_server_account_get_option_secure_auth),
3932 (modest_server_account_set_option_secure_auth):
3933 * src/modest-account-mgr.c:
3934 (modest_account_mgr_add_server_account):
3935 Use the existing AUTH_MECH conf key for the secure-auth setting,
3936 instead of putting it in the list options, because this was actually used already.
3938 * src/maemo/modest-account-settings-dialog.c:
3939 (create_page_account_details),
3940 (modest_account_settings_dialog_set_account_name),
3941 (save_configuration):
3942 * src/maemo/modest-account-settings-dialog.h:
3943 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3944 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3946 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3948 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3949 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3950 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3952 * src/modest-defs.h:
3953 * src/maemo/modest-account-settings-dialog.c:
3954 (create_page_incoming), (on_combo_outgoing_security_changed),
3955 (on_combo_incoming_security_changed), (create_page_outgoing),
3956 (modest_account_settings_dialog_set_account_name),
3957 (save_configuration): Load/Save the port number, and change it when the
3958 security combo changes, to suitable defaults.
3960 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3962 * src/modest-account-mgr.c:
3963 (modest_account_mgr_add_server_account): Set the security and secure-auth
3964 options, and add a comment saying that the other camel-specific options should be
3967 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3969 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3971 * src/modest-tny-account-store.c: (account_list_free),
3972 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3973 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3976 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3978 * src/modest-protocol-info.c:
3979 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3980 is required by our UI spec. Maybe something in our implementation will use this eventually.
3981 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3982 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3983 instead of the previous 0 placeholder.
3985 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3986 secure-auth settings.
3987 * src/modest-account-mgr-helpers.h:
3988 * src/modest-account-mgr-helpers.c:
3989 (modest_server_account_data_get_option_secure_auth),
3990 (modest_server_account_set_option_secure_auth),
3991 (modest_server_account_data_get_option_security),
3992 (modest_server_account_set_option_security): Added this API for getting and setting the security
3993 and secure-auth settings.
3995 * src/maemo/modest-account-settings-dialog.h:
3996 * src/maemo/modest-account-settings-dialog.c:
3997 (modest_account_settings_dialog_finalize), (check_data),
3998 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3999 about changing titles.
4000 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4001 (save_configuration): Save the security and secure-auth settings.
4003 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4004 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4006 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4008 * src/modest-defs.h:
4009 * src/modest-account-mgr.c:
4010 (modest_account_mgr_add_server_account):
4011 Added and used defines for the options key and value pair strings,
4012 that are used so far, though they do not seem to correspond to anything in our
4013 UI specs or ModestProtocol enum.
4015 * src/modest-account-mgr-helpers.h:
4016 * src/modest-account-mgr-helpers.c:
4017 (compare_option_strings_for_name),
4018 (modest_server_account_data_get_option_value),
4019 (modest_server_account_data_get_option_bool),
4020 (modest_account_mgr_get_server_account_option):
4021 Added helper functions for parsing the options GSList.
4023 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4025 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4026 display name is based on the supplied account name.
4027 * src/modest-account-mgr.c:
4028 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4029 with an inefficient, but good-enough, implementation.
4031 * src/maemo/easysetup/modest-easysetup-wizard.c:
4032 (create_page_account_details), (on_before_next), (create_account):
4033 Check for existing display names rather than (non-user-visible) account names, and just
4034 create and set a unique account name at the end.
4036 * src/maemo/modest-account-settings-dialog.c:
4037 (modest_account_settings_dialog_init),
4038 (modest_account_settings_dialog_set_account_name),
4039 (create_page_incoming): Show the display name, instead of the account name.
4040 (on_response): Do some (not all) extra checks, as in the UI spec.
4041 (save_configuration): Save the display name if it was changed.
4043 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4045 * po/en_GB.po: Added needed logical ID and translation.
4046 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4047 (init_view): Made the is-default column clicking work.
4049 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4052 * src/maemo/easysetup/Makefile.am:
4053 * src/maemo/easysetup/modest-easysetup-wizard.c:
4054 (modest_easysetup_wizard_dialog_init):
4055 * src/maemo/easysetup/provider-data-test.keyfile:
4056 * src/maemo/easysetup/provider-data.keyfile:
4057 Moved the provider data file to the new modest-providers-data package and used it from there.
4059 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4061 * src/modest-local-folder-info.c:
4062 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4063 N_() was already used on the static strings, but this just marks it for translation without
4064 using the translation.
4066 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4068 * src/maemo/modest-account-settings-dialog.c:
4069 (create_page_incoming),
4070 (modest_account_settings_dialog_set_account_name):
4071 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4072 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4073 I will do this if nobody else gets there first.
4075 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4077 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4078 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4079 save the security stuff.
4081 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4083 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4084 Set the email address and user fullname, which I now see must be
4087 * src/maemo/modest-account-settings-dialog.h:
4088 * src/maemo/modest-account-settings-dialog.c:
4090 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4091 leave-on-server and authentication.
4092 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4095 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4098 * src/maemo/modest-account-settings-dialog.c:
4099 * src/maemo/modest-account-settings-dialog.h:
4100 Most (but not all) of the widgets are now present as specified by the UI spec.
4101 No changes are yet saved, and some details are not properly shown yet.
4103 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4105 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4107 * src/maemo/Makefile.am:
4108 * src/maemo/modest-account-settings-dialog.c:
4109 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4110 an existing account. Doesn't do much yet.
4112 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4113 Open the accounts settings dialog when Edit is clicked.
4115 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4117 * src/maemo/easysetup/Makefile.am:
4118 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4120 * src/maemo/easysetup/modest-easysetup-wizard.c:
4121 (modest_easysetup_wizard_dialog_init):
4122 Try to get the source directory from the build system,
4123 instead of hard-coding "./" into the source code, when opening our local
4124 copies of the configuration files.
4125 But this still fails when opening the wizard from the Accounts window,
4126 maybe because the working directory seems to change at runtime.
4127 So the wizard will fail the second time unless you copy the files into their
4128 proper locations - see the stdout warnings for the paths.
4130 (create_page_account_details),(on_before_next):
4131 Check for existing non-server accounts instead of server accounts,
4132 so the default account name is useful again, and to prevent trying to
4135 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4136 Show the wizard when New is clicked.
4138 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4139 (init_view): Show the column headers, and show the columns that are
4140 specified in the UI specs. However, something in Maemo's GTK+ prevents
4141 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4142 change the default account. This is despite unsetting the special properties.
4144 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4146 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4147 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4148 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4149 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4150 to make that clearer.
4151 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4153 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4155 * src/maemo/modest-account-view-window.c:
4156 (modest_account_view_window_init),
4157 (modest_account_view_window_new):
4158 Use the same buttons as specified in the
4159 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4160 the existing widgets, which never had a chance of working.
4161 Put the ModestAccountView treeview in a scrolled window.
4162 Do not repeat the initialization in both _init() and _new().
4164 * src/widgets/modest-account-view.c: (update_account_view):
4165 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4166 this widget and window shows no accounts.
4168 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4170 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4172 * src/maemo/easysetup/modest-easysetup-wizard.c:
4173 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4174 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4175 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4178 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4179 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4180 accounts exist yet, as in the UI spec.
4182 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4184 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4186 * src/maemo/Makefile.am:
4187 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4188 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4189 New window for editing connection-specific smtp details.
4190 Not fully implemented.
4192 * src/maemo/modest-connection-specific-smtp-window.c:
4193 (modest_connection_specific_smtp_window_finalize) :
4194 unref the tree model.
4195 (on_button_edit): Show the edit window.
4197 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4199 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4202 * src/maemo/Makefile.am:
4203 * src/maemo/modest-connection-specific-smtp-window.c:
4204 * src/maemo/modest-connection-specific-smtp-window.h:
4205 New window for showing the list of connections, for connection-specific
4206 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4207 * src/maemo/easysetup/modest-easysetup-wizard.c:
4208 (create_page_custom_outgoing): Show the new window when the button is clicked.
4210 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4212 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4213 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4214 * src/maemo/modest-msg-edit-window.c:
4215 (modest_msg_edit_window_insert_image):
4216 * src/modest-conf.c: (modest_conf_key_escape):
4217 * src/modest-mail-operation.c:
4218 (modest_mail_operation_send_new_mail):
4219 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4220 (modest_ui_actions_on_new_account):
4221 * src/widgets/modest-attachment-view.c: (update_filename_request):
4222 * src/widgets/modest-mail-header-view.c:
4223 Corrected warnings that were breaking the build, by commenting out unused variables,
4224 and a function, and by including a header.
4226 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4228 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4229 so we can #ifdef around platform-specific code when necessary.
4230 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4231 to allow this to build for the GNOME platform too.
4233 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4235 * src/maemo/easysetup/modest-easysetup-wizard.c:
4236 Added util_increment_name() and used it in create_page_account_details()
4237 to make sure that the default account name is always a new name.
4239 (modest_easysetup_wizard_dialog_init),
4240 (set_default_custom_servernames): Some minor memory management fixes.
4242 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4246 * src/modest-runtime.c: (init_i18n): Restored the translation
4247 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4248 are defined in config.h, and the translations are installed.
4250 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4251 is defined for translation.
4253 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4255 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4257 * src/maemo/easysetup/modest-easysetup-wizard.c:
4258 (modest_easysetup_wizard_dialog_init):
4259 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4260 Use realistic paths (though they should use $prefix generically) to the
4261 mcc_mapping and provider-data.keyfile files which might work when they
4262 are installed by the future version of the operator-wizard package,
4263 and then fallback to paths in our source code, with an explanatory
4266 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4270 * src/maemo/Makefile.am:
4271 * src/maemo/easysetup/: Added files from the previously-exernal
4272 osso-modest-easysetup.
4273 * src/maemo/modest-main-window-ui.h:
4274 * src/modest-ui-actions.c:
4275 * src/modest-ui-actions.h:
4276 Added modest_ui_actions_on_new_account() as a signal handler for the
4277 New Account menu item. It shows the easysetup wizard.
4278 * po/en_GB.po: Added additional needed logical IDs and translations.