1 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
4 Show the detailed internal camel error message when an error happens
5 during the configuration, so that our testers can give us more clues.
6 For instance, in projects.maemo.org bug NB#56910 .
8 2007-05-14 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-tny-account.c:
11 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
12 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
14 2007-05-14 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
17 * src/maemo/modest-account-settings-dialog.c:
18 (modest_account_settings_dialog_set_account_name),
19 (save_configuration): For the incoming secure authentication checkbox,
20 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
21 the UI specification. PLAIN does not seem to be supported for most IMAP
22 servers anyway, and I am not sure what it would mean.
23 However, we probably need to discover which of the secure-authentication
24 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
25 * src/modest-account-mgr-helpers.c:
26 (modest_account_mgr_get_server_account_data):
28 * src/modest-tny-account.c:
29 (modest_tny_account_new_from_server_account):
30 Use tny_account_set_mech() to set secure-authentication methods,
31 with some special-casing for IMAP, based on my observations of how
34 * src/modest-account-mgr-helpers.h:
35 * src/modest-account-mgr.c:
36 * src/modest-defs.h: Comment that the URI is only used for local folders.
38 2007-05-11 Murray Cumming <murrayc@murrayc.com>
40 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
41 parameter const, just to be neat.
42 * src/modest-text-utils.c: (modest_text_utils_inline):
43 End g_strconcat() with NULL, as its documentation says. This is almost
44 certainly the cause of my crash at startup on the device. Interestingly,
45 valgrind doesn't tell us about these errors.
47 2007-05-11 Murray Cumming <murrayc@murrayc.com>
49 * scripts/build-packages: Added more precise comments about how to use
50 this script, though I still get this error:
51 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
52 error building tinymail
54 2007-05-11 Murray Cumming <murrayc@murrayc.com>
56 * src/maemo/modest-main-window.c: (on_account_update):
57 Very slight cleanup, hoping to make it simpler to discover what causes
58 a crash here sometimes.
60 * src/modest-tny-account.c:
61 (modest_tny_account_new_from_server_account): Set the port. Added
62 comments about the options and a TODO comment because I need to find out
63 how to specify the secure authentication method.
65 2007-05-11 Marcus Bauer <marcusb@openismus.com>
67 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
68 changed CFlags paths form modest to libmodest
70 2007-05-10 Murray Cumming <murrayc@murrayc.com>
72 * src/modest-account-mgr-helpers.c:
73 (modest_account_mgr_get_server_account_data),
74 (modest_account_mgr_free_server_account_data):
75 * src/modest-account-mgr-helpers.h:
76 * src/modest-account-mgr.c:
77 (modest_account_mgr_add_server_account):
79 * src/modest-tny-account.c:
80 (modest_tny_account_new_from_server_account):
81 Determine the options for tny_camel_account_add_option() here,
82 based on the settings, rather than storing them directly in gconf.
84 2007-05-10 Murray Cumming <murrayc@murrayc.com>
86 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
87 Show a more friendly error dialog now that we expect (from the tinymail
88 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
90 2007-05-10 Murray Cumming <murrayc@murrayc.com>
92 * src/maemo/modest-main-window.c: (on_account_update): Check that
93 account_name is not NULL, to prevent a crash at startup that I am
94 seeing on the N800. I do wonder why it is NULL.
96 * src/maemo/easysetup/modest-easysetup-wizard.c:
97 (create_page_user_details):
98 * src/maemo/modest-account-settings-dialog.c:
99 (create_page_user_details), (create_page_outgoing):
100 * src/maemo/modest-connection-specific-smtp-edit-window.c:
101 (modest_connection_specific_smtp_edit_window_init):
102 * src/modest-ui-actions.c:
103 (modest_ui_actions_on_password_requested):
104 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
105 might do something useful with the on-screen keyboard.
107 2007-05-10 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/modest-main-window.c: (on_account_update):
110 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
111 NULL, to avoid lots of warnings. However, it probably should not be NULL.
113 2007-05-09 Murray Cumming <murrayc@murrayc.com>
115 * src/modest-tny-account-store.c: (on_account_changed):
116 Correct the signature of this signal handler.
118 2007-05-09 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
121 Show a HildonNote instead of a GtkDialog for Maemo.
123 2007-05-09 Murray Cumming <murrayc@murrayc.com>
125 * src/widgets/modest-account-view.h:
126 * src/widgets/modest-account-view.c: (on_account_changed),
127 (on_account_removed). Added a boolean flag, set/unset by
128 modest_account_view_block_conf_updates(),
129 modest_account_view_unblock_conf_updates() to prevent unnecessary
130 updates, but this is not very useful because the gconf notifications are
131 so delays (maybe only on Maemo Bora).
132 So auto-updating is turned off, and these functions do an explicit
133 update when necessary.
134 However, something else is still doing too much work when adding/removing
135 accounts, probably in another part of the application.
137 * src/maemo/modest-account-view-window.c:
138 (on_delete_button_clicked), (on_edit_button_clicked),
139 (on_new_button_clicked): Use the new functions.
141 2007-05-09 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-account-mgr-helpers.c:
144 (modest_account_mgr_set_first_account_as_default):
145 Sort the list of names alphabetically-by-title, so we choose the first one
147 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
148 alphabetically by the title.
150 This fixes projects.maemo.org bug NB#56418 .
152 * src/modest-account-mgr-priv.c:
153 (_modest_account_mgr_account_from_key):
154 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
155 avoid a valgrind error, and possible random behaviour.
157 2007-05-09 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
160 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
161 tinymail documentation to say that this can be expected.
162 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
163 pretty, and should not happen, but I would prefer to know when it does.
165 2007-05-09 Murray Cumming <murrayc@murrayc.com>
167 * configure.ac: When using the older hildon version, probably on Bora,
168 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
170 * src/widgets/modest-attachment-view.c:
171 (modest_attachment_view_set_part_default): Initialize variables, to fix the
174 2007-05-09 Marcus Bauer <marcusb@openismus.com>
176 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
177 Implemented the prototype. Can be tested with
178 tests/dbus_api/test_open_message:
180 2007-05-08 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-tny-account-store.c:
183 (modest_tny_account_store_instance_init), (get_password):
184 * src/modest-ui-actions.c:
185 (modest_ui_actions_on_password_requested):
186 Do not store the password in gconf, because this function is called
187 for non-remembered passwords. Actually use the cached (in the hash map)
188 password instead of releasing it.
189 The password will now not be remembered if it is asked via the protected
190 password dialog, as per the UI spec.
192 2007-05-08 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-account-mgr-helpers.h:
196 * src/modest-account-mgr-helpers.c:
197 Added modest_server_account_get_username_has_succeeded(),
198 modest_server_account_set_username_has_succeeded().
199 (modest_server_account_set_username),
200 Reset the has-succeeded flag if the username changes.
202 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
203 * src/maemo/modest-connection-specific-smtp-window.c:
204 (modest_connection_specific_smtp_window_save_server_accounts):
205 Use modest_server_account_set_username() instead of using
206 modest_conf_set_string() directly, so that the has-succeeded flag is always
209 * src/modest-ui-actions.c:
210 (modest_ui_actions_on_password_requested): Dim the username entry if
211 the username has ever worked, as per the UI spec.
213 2007-05-08 Murray Cumming <murrayc@murrayc.com>
215 * src/modest-tny-account-store.c: (get_password):
216 * src/modest-ui-actions.c:
217 (modest_ui_actions_on_password_requested):
218 Allow the username to be changed too, though there is more work to
219 be done on exactly how this behaves.
221 2007-05-08 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-account-mgr-helpers.h:
224 * src/modest-account-mgr-helpers.c:
225 Added modest_account_mgr_get_display_name(),
226 modest_server_account_get_username(),
227 modest_server_account_set_username(),
228 modest_server_account_set_password(),
229 modest_server_account_get_hostname() functions so we do not need to
230 use the conf API directly.
232 * src/maemo/modest-main-window.c: (connect_signals):
233 Actually connect ot the ModestAccountStore::request-password signal,
234 so that we show the dialog when the password is requested by Tinymail,
235 for isntance if it is empty.
237 * src/modest-marshal.list:
238 * src/modest-tny-account-store.c:
239 (modest_tny_account_store_class_init), (get_password),
240 (modest_tny_account_store_alert):
241 * src/modest-tny-account-store.h:
242 * src/modest-ui-actions.h:
243 * src/modest-ui-actions.c:
244 (modest_ui_actions_on_password_requested):
245 Change the signal parameters, so it is obvious that we are providing
246 the non human-readable server name, and receiving both the username
247 and password, though changing of the username is not yet implemented.
248 Change the dialog UI to match the Maemo UI specifications, with #idfefing
249 for the GNOME version.
251 This should fix the projects.maemo.org bug NB#56209, though it does not
252 work on Bora, because the gconf_client_get() for the password fails
253 immediately after we save it with gconf_client_set().
255 2007-05-08 Murray Cumming <murrayc@murrayc.com>
258 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
259 caused an undefined symbol error:
260 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
262 2007-05-08 Murray Cumming <murrayc@murrayc.com>
264 * src/modest-tny-account-store.c:
265 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
266 using a GError instead of a string message, so we can translate it in
269 2007-05-08 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/modest-address-book.c:
272 (modest_address_book_check_names):
273 * src/maemo/modest-msg-view-window.c:
274 (modest_msg_view_window_clipboard_owner_change):
275 * src/modest-init.c: (modest_init_init_ui):
276 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
277 (update_folders_cb), (modest_mail_operation_update_account):
278 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
279 (modest_ui_actions_on_msg_attachment_clicked),
280 (modest_ui_actions_on_msg_recpt_activated):
281 * src/widgets/modest-header-view.c: (drag_data_get_cb):
282 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
283 (modest_msg_view_search_next):
284 * src/widgets/modest-recpt-editor.c:
285 (modest_recpt_editor_on_button_release_event),
286 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
287 g_message(). At this point we should only be seeing interesting errors on
288 stdout. Debugging messages could be #ifdefed-out if they are still useful.
290 2007-05-07 Murray Cumming <murrayc@murrayc.com>
292 (modest_wizard_dialog_force_title_update):
293 * src/maemo/easysetup/modest-wizard-dialog.h:
294 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
295 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
296 can update the title when appropriate. Otherwise the title is wrong if the
297 pages are added after adding the notebook to the dialog.
298 This must be a problem in HildonWizardDialog too.
299 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
301 * src/maemo/easysetup/modest-easysetup-wizard.c:
302 (create_subsequent_customsetup_pages),
303 (create_subsequent_easysetup_pages):
304 Call modest_wizard_dialog_force_title_update() so that the title is
305 correct even with GTK+ < 2.10.
306 This fixes projects.maemo.org bug NB#56145 .
308 2007-05-07 Murray Cumming <murrayc@murrayc.com>
310 * src/maemo/modest-platform.c:
311 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
312 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
315 2007-05-07 Murray Cumming <murrayc@murrayc.com>
317 * src/widgets/modest-window.h:
318 * src/widgets/modest-window.c: Added a save_state_func vfunc,
319 and modest_window_save_state(), which invokes it.
321 * src/widgets/modest-window-mgr.h:
322 * src/widgets/modest-window-mgr.c:
323 Added modest_window_mgr_save_state_for_all_windows(), which calls
324 the save_state vfunc on all registered windows, if implemented.
326 * src/gnome/modest-msg-edit-window.c:
327 * src/gnome/modest-msg-view-window.c:
328 * src/maemo/modest-msg-edit-window.c:
329 * src/maemo/modest-msg-view-window.c:
330 * src/maemo/modest-main-window.c:
331 Specify the existing save_settings functions as implementations of
332 ModestWindow::save_state_func().
334 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
335 Call modest_window_mgr_save_state_for_all_windows(). This happens before
336 enabling hibernation, for instance.
338 We may need to do the same thing for restoring settings.
341 2007-05-07 Murray Cumming <murrayc@murrayc.com>
343 * src/widgets/modest-window-mgr.c:
344 * src/widgets/modest-window-mgr.h:
345 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
346 modest_window_mgr_get_hibernation_is_prevented().
348 * src/maemo/modest-main-window.c:
349 (on_hildon_program_is_topmost_notify): Prevent hibernation
350 (possible when the application goes to the background in the WM),
351 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
353 * src/maemo/easysetup/modest-easysetup-wizard.c:
354 (modest_easysetup_wizard_dialog_init):
355 * src/maemo/modest-account-settings-dialog.c:
356 (modest_account_settings_dialog_init):
357 * src/maemo/modest-connection-specific-smtp-edit-window.c:
358 (modest_connection_specific_smtp_edit_window_init):
359 * src/maemo/modest-connection-specific-smtp-window.c:
360 (modest_connection_specific_smtp_window_init):
361 * src/maemo/modest-signature-editor-dialog.c:
362 (modest_signature_editor_dialog_init):
363 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
364 prevent hibernation while any of these account settings dialogs are open.
366 2007-05-04 Murray Cumming <murrayc@murrayc.com>
368 * src/maemo/Makefile.am:
369 * src/maemo/modest-osso-state-saving.c:
370 * src/maemo/modest-osso-state-saving.h: Added
371 modest_osso_load_state() and modest_osso_save_state() though they do
372 nothing now. They should iterate through all the open windows and load/save
374 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
375 save state when closing.
377 * src/maemo/modest-main-window.c:
378 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
379 Add a notification handler for the HildonProgram::is-topmost property,
380 so we can allow hibernation when the application goes into the background.
381 But we still need to detect when the accounts setup windows are open so
382 we can stop hibernation when they are open.
383 To do this, I also added the main window the HildonProgram. This might have
384 other side-effects/benefits, and should maybe be done for other windows.
386 * src/maemo/modest-osso-autosave-callbacks.h:
387 * src/maemo/modest-osso-autosave-callbacks.c:
388 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
389 though it does not do anything yet, and we might never need this to do
390 anything. For instance, we already save drafts.
392 * src/maemo/modest-platform.c: (modest_platform_init):
393 Specify the libosso auto-save callback.
395 2007-05-03 Murray Cumming <murrayc@murrayc.com>
397 * src/maemo/modest-platform.c:
398 (modest_platform_set_update_interval):
399 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
400 aparently stays valid between application instances, so we can use this
401 to remove and reset it later. According to a maemo-developers email from
404 2007-05-03 Murray Cumming <murrayc@murrayc.com>
406 * configure.ac: Depend on libalarm for Maemo.
408 * src/dbus_api/modest-dbus-api.h:
409 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
410 (on_send_receive), (modest_dbus_req_handler):
411 Handle a SEND_RECEIVE D-Bus method.
413 * libmodest-dbus-client/libmodest-dbus-client.c:
414 (libmodest_dbus_client_send_and_receive):
415 * libmodest-dbus-client/libmodest-dbus-client.h:
416 Add C convenience functions for calling the new D-Bus method.
418 * src/modest-platform.h:
419 * src/gnome/modest-platform.c:
420 * src/maemo/modest-platform.c:
421 Added modest_platform_set_update_interval(), which uses the
423 (modest_platform_init),
424 Call modest_platform_set_update_interval(), using a hard-coded
425 interval for now (until the global settings dialog is implemented),
426 though I am not sure that this makes sense yet.
428 2007-05-02 Murray Cumming <murrayc@murrayc.com>
430 * src/dbus_api/modest-dbus-callbacks.c:
431 (modest_osso_cb_hw_state_handler):
432 * src/dbus_api/modest-dbus-callbacks.h:
433 * src/maemo/modest-platform.c: (modest_platform_init):
434 Registered (empty) callbacks for the osso hardware state D-Bus signals,
435 in case this has some effect on the ability for Maemo to ping the
438 2007-05-02 Murray Cumming <murrayc@murrayc.com>
440 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
441 Comment out an if() that checks a gchar for < 0, causing a build-breaking
442 warning. It is probably a logic error, but I need to fix the build.
444 2007-05-02 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-account-mgr.h:
447 * src/modest-account-mgr.c:
448 (modest_account_mgr_account_names): Add a gboolean enabled_only
449 parameter, so we can get lists of onlt the enabled accounts.
451 (modest_account_mgr_add_account),,
452 (modest_account_mgr_account_with_display_name_exists):
453 * src/maemo/modest-msg-edit-window.c: (get_transports):
454 * src/modest-account-mgr-helpers.c:
455 (modest_account_mgr_set_first_account_as_default):
456 * src/modest-init.c: (init_default_account_maybe):
457 * src/modest-tny-account-store.c: (get_accounts):
458 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
459 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
460 * tests/check_account-mgr.c: (START_TEST):
461 Provide the extra parameter, as appropriate.
463 * src/widgets/modest-account-view.c: (update_account_view):
464 Do not show disabled accounts (meaning that there is no way to
465 enable/disable accounts in the UI (the feature is not in our UI
466 specification), so we can use this internally only to mark unfinished
467 or temporary account data.
469 * src/maemo/easysetup/modest-easysetup-wizard.c:
470 (create_account): Add boolean enable parameter, so we can specify FALSE
471 to create the temporary account.
472 (on_button_edit_advanced_settings): Create the temporary account as disabled.
473 (on_before_next): When finishing, when there is a temporary account, just
475 Also, use a timeout to delay the showing of the dialog until gconf is likely
476 to return correct information, due to a maemo gconf bug that is fixed in
477 osso 1.1, but not yet in Bora.
478 However, the dialog stays on screen after it is destroyed.
480 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
481 for invalid data when cancelling. Use a hildon note instead of a dialog
482 to complain about invalid data. Do not show the account-saved note if the
483 account is disabled (a temporary account that will not really be saved for use
486 2007-04-30 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-account-mgr-helpers.h:
489 * src/modest-account-mgr-helpers.c:
490 Added modest_account_mgr_unset_default_account(),
491 Added modest_account_mgr_set_first_account_as_default().
493 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
494 If it was the default account, unset the default account name.
496 * src/maemo/modest-account-view-window.c:
497 (on_delete_button_clicked): If it was the default account,
498 set the first remaining account as the default instead.
500 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
501 a NULL account or a NULL default account, to prevent a crash. This should
502 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
505 2007-04-30 Murray Cumming <murrayc@murrayc.com>
507 * src/widgets/modest-recpt-editor.c:
508 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
509 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
510 TODO comment for this. This fixes the build.
512 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
513 be the best place for it. This will in future update all auto-update accounts,
514 rather than just the current/default account, when that gconf key exists.
515 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
516 if there are no accounts, before calling do_send_receive().
517 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
519 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
520 * src/maemo/modest-main-window-ui.h:
521 * src/maemo/modest-main-window.c: (on_connection_changed),
522 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
523 directly, becaue the signal handler does more.
525 2007-04-30 Murray Cumming <murrayc@murrayc.com>
527 * src/modest-account-mgr-helpers.c:
528 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
529 for the case that the account does not exist.
531 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
532 (equivalent to the modest account name) rather than the tinymail account name
533 (equivalent to the modest account title - human readable) to get the account data.
534 Check for null account data to prevent the crash, and add a TODO comment saying that
535 this needs fixing because it is using the server account name instead of the account name.
537 2007-04-29 Murray Cumming <murrayc@murrayc.com>
539 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
540 * src/maemo/modest-account-settings-dialog.c: (show_error),
542 Use hildon_note_new_information() for informative and error messages,
543 which seems to be expected for Maemo applications (no documentation that I know of
544 says this). I am surprised that there is no distinction between info and error
547 2007-04-29 Murray Cumming <murrayc@murrayc.com>
549 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
550 it is easy to find where this is used.
552 * src/maemo/easysetup/modest-easysetup-wizard.c:
553 (create_page_welcome), (create_page_account_details),
554 (create_page_user_details), (create_page_complete_easysetup),
555 (create_page_custom_incoming), (create_page_custom_outgoing),
556 (create_page_complete_custom):
557 * src/maemo/modest-account-settings-dialog.c:
558 (create_page_account_details), (create_page_user_details),
559 (create_page_incoming), (create_page_outgoing):
560 * src/maemo/modest-account-view-window.c: (window_vbox_new):
561 * src/maemo/modest-connection-specific-smtp-edit-window.c:
562 (modest_connection_specific_smtp_edit_window_init):
563 * src/maemo/modest-connection-specific-smtp-window.c:
564 (modest_connection_specific_smtp_window_init):
565 * src/maemo/modest-signature-editor-dialog.c:
566 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
567 and scrolling policy as per the Email Application Layout Guide, if I have
570 2007-04-27 Murray Cumming <murrayc@murrayc.com>
572 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
573 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
574 which were empty, because these vfuncs have been removed from TnyAccountStore.
575 This fixes the build.
577 2007-04-27 Murray Cumming <murrayc@murrayc.com>
579 * src/maemo/modest-main-window.c:
580 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
581 showing/hiding it. Added TODO because it probably should not be NULL.
582 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
583 because unnecessary g_warnings() make degugging difficult.
585 2007-04-27 Murray Cumming <murrayc@murrayc.com>
587 * src/maemo/modest-msg-edit-window.c:
588 (modest_msg_edit_window_select_color),
589 (modest_msg_edit_window_select_background_color): 2 const corrections and
590 moving 2 #endifs before closing brackets, to fix the build.
592 2007-04-27 Murray Cumming <murrayc@murrayc.com>
594 * src/maemo/easysetup/modest-easysetup-wizard.h:
595 * src/maemo/easysetup/modest-easysetup-wizard.c:
596 (modest_easysetup_wizard_dialog_finalize),
597 (on_button_edit_advanced_settings), (create_page_complete_custom),
598 (on_response), (create_account):
599 Implement the Advanced Settings edit button, by saving the account information,
600 for the Advanded Settings dialog to use directly from gconf, and removing it
601 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
602 Bug #5533 in the projects.maemo.org bugzilla.
604 2007-04-27 Murray Cumming <murrayc@murrayc.com>
606 * src/maemo/modest-msg-view-window.c:
607 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
608 when opening a message window.
610 2007-04-27 Murray Cumming <murrayc@murrayc.com>
612 * src/maemo/easysetup/modest-easysetup-wizard.c:
613 (create_page_custom_outgoing): Correct the position of the horizontal separator to
616 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
617 before showing/hiding them, to avoid a crash when clicking on folders when there are no
618 gconf settings. I probably added more checks than necessary, but that is safer.
620 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
621 variable to fix the build, but this seems to be used when it is still NULL.
623 2007-04-27 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-platform.h:
626 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
627 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
628 * src/modest-main.c: Implement this function so we can avoid using
629 maemo-specific API from cross-platform code.
631 * src/modest-tny-account-store.c:
632 (get_smtp_specific_transport_account_for_open_connection):
633 * src/modest-ui-actions.c: (check_for_connection),
634 (modest_ui_actions_on_item_not_found):
635 Use modest_platform_connect_and_wait() and put #idefs around other
636 maemo-specific code, because only maemo currently has a way to
637 identify connection names.
639 2007-04-27 Murray Cumming <murrayc@murrayc.com>
641 * src/modest-tny-account-store.h:
642 * src/modest-tny-account-store.c:
643 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
644 the connection-specific SMTP server settings in the configuration.
646 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
648 * src/maemo/modest-main-window.c: (on_connection_changed),
650 * src/modest-main.c: (main), (start_ui), (send_mail):
651 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
652 that is what is intended.
654 * src/modest-ui-actions.c: (action_send), (action_receive),
655 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
656 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
657 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
658 SMTP server is used when it is specified.
660 (modest_ui_actions_on_send_receive):
661 Check that a connection is open before proceeding.
662 Receive and then send, instead of vice-versa, as per the specification.
664 2007-04-26 Murray Cumming <murrayc@murrayc.com>
666 * src/modest-mail-operation.c:
667 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
668 though I guess it should be something other than NULL.
670 2007-04-26 Murray Cumming <murrayc@murrayc.com>
672 * src/maemo/easysetup/modest-easysetup-wizard.c:
673 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
674 combo twice, to avoid an g_warning and to make it visible again.
675 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
676 attached before detaching it, to avoid a g_warning, and add comment about the implicit
677 (already intended) dereference when detaching, because we then recreate the menu.
678 But I am not sure why the warning was happening, and it is possible that this is a memory
681 2007-04-25 Murray Cumming <murrayc@murrayc.com>
683 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
684 and uri_parse_mailto() utility functions.
685 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
687 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
689 2007-04-24 Murray Cumming <murrayc@murrayc.com>
691 * src/dbus_api/modest-dbus-api.h:
692 * src/dbus_api/modest-dbus-callbacks.c:
693 Use an idle callback to execute the modest code in the application's own thread.
694 Remove the helloworld example method.
695 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
696 parsed, and the open-message method is not implemented because this is not yet implemented in
698 * libmodest-dbus-client/libmodest-dbus-client.c:
699 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
700 (libmodest_dbus_client_open_message):
701 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
703 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
704 body without crashing.
706 * tests/dbus_api/Makefile.am:
707 * tests/dbus_api/test_mail_to.c:
708 * tests/dbus_api/test_open_message.c: New tests for the new methods.
710 2007-04-24 Murray Cumming <murrayc@murrayc.com>
712 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
713 Added file to fix the build. Sorry.
715 * src/dbus_api/Makefile.am:
716 * src/dbus_api/modest-dbus-api.h:
717 * src/dbus_api/modest-dbus-callbacks.h:
718 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
719 (modest_dbus_req_handler):
720 Put constants in a separate header so it can be reused by the
721 client library, without duplication
723 * libmodest-dbus-client/Makefile.am:
724 * libmodest-dbus-client/libmodest-dbus-client.c:
725 (libmodest_dbus_client_call_helloworld),
726 (libmodfest_dbus_client_send_mail),
727 (libmodfest_dbus_client_mailto),
728 (libmodfest_dbus_client_open_message):
729 * libmodest-dbus-client/libmodest-dbus-client.h:
730 (Partly) Implement a send_mail D-Bus method.
732 * tests/dbus_api/Makefile.am:
733 * tests/dbus_api/test_send_mail.c: (main): Added a test for
734 the send_email D-Bus method.
736 2007-04-24 Murray Cumming <murrayc@murrayc.com>
740 * libmodest-dbus-client/Makefile.am:
741 * libmodest-dbus-client/libmodest-dbus-client.c:
742 * libmodest-dbus-client/libmodest-dbus-client.h:
743 * tests/dbus_api/Makefile.am:
744 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
745 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
747 2007-04-24 Murray Cumming <murrayc@murrayc.com>
749 * src/maemo/easysetup/modest-easysetup-wizard.c:
750 (create_page_account_details):
751 * src/maemo/modest-account-settings-dialog.c:
752 (create_page_account_details): Explicitly set auto-capitalization mode for the title
753 widgets, because this might not be the default in future versions of the Maemo GTK+.
754 However, I can not not get capitalization to work even in a simple test case.
756 2007-04-24 Murray Cumming <murrayc@murrayc.com>
758 * src/maemo/easysetup/modest-easysetup-wizard.c:
759 (create_page_custom_incoming), (create_page_custom_outgoing):
760 * src/maemo/modest-account-settings-dialog.c:
761 (create_page_account_details), (create_page_incoming),
762 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
763 instead of using gtk_check_button_with_label(), so they are aligned like the other
764 widgets, as per the UI spec.
766 2007-04-24 Murray Cumming <murrayc@murrayc.com>
768 * src/maemo/easysetup/modest-easysetup-wizard.c:
769 * src/maemo/modest-connection-specific-smtp-edit-window.c:
770 * src/widgets/modest-validating-entry.c:
771 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
772 Modest prefix instead of an EasySetup prefix.
774 2007-04-23 Murray Cumming <murrayc@murrayc.com>
776 * src/widgets/modest-validating-entry.h:
777 * src/widgets/modest-validating-entry.c: (on_insert_text),
778 Added easysetup_validating_entry_set_max_func(), used to set a callback
779 to call when the max number of characters is reached. GtkEntry has a max-length
780 already but is silent about it.
782 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
783 (create_page_account_details), (create_page_user_details),
785 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
786 (create_page_account_details), (create_page_user_details),
787 (create_page_outgoing):
788 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
789 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
790 the UI spec, when the user tries to enter more than the max number of characters.
792 2007-04-23 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/easysetup/modest-easysetup-wizard.c:
795 (create_page_user_details), (create_page_custom_incoming),
796 (create_page_custom_outgoing):
797 * src/maemo/modest-account-settings-dialog.c:
798 (create_page_user_details), (create_page_incoming),
799 (create_page_outgoing):
800 * src/maemo/modest-connection-specific-smtp-edit-window.c:
801 (modest_connection_specific_smtp_edit_window_init):
802 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
803 not appropriate. Bad Maemo-specific defaults!.
805 2007-04-23 Murray Cumming <murrayc@murrayc.com>
807 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
808 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
809 (modest_signature_editor_dialog_set_settings):
810 Disable the label and textview when the checkbox is disabled, and use the
811 specified (UI spec) default signature text.
813 2007-04-23 Murray Cumming <murrayc@murrayc.com>
815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
816 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
819 * src/modest-account-mgr-helpers.h:
820 * src/modest-account-mgr-helpers.c:
821 Added modest_account_mgr_get/set_signature(), using new gconf keys.
823 * src/maemo/Makefile.am:
824 * src/maemo/modest-signature-editor-dialog.c:
825 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
828 * src/maemo/modest-account-settings-dialog.h:
829 * src/maemo/modest-account-settings-dialog.c:
830 (modest_account_settings_dialog_finalize), (on_button_signature),
831 (save_configuration): Use the new dialog when the Edit button is pressed, and
832 save the changes if necessary, as per the UI spec.
834 2007-04-23 Murray Cumming <murrayc@murrayc.com>
836 * src/maemo/Makefile.am:
837 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
838 based on maemo-develoers email from Dirk.
840 * src/maemo/easysetup/modest-easysetup-wizard.c:
841 (create_page_welcome), (create_page_account_details),
842 (create_page_user_details), (create_page_complete_easysetup),
843 (create_page_custom_incoming), (create_page_custom_outgoing),
844 (create_page_complete_custom),
845 (modest_easysetup_wizard_dialog_init):
846 * src/maemo/modest-account-settings-dialog.c:
847 (create_page_account_details), (create_page_user_details),
848 (create_page_incoming), (create_page_outgoing),
849 (modest_account_settings_dialog_init):
850 * src/maemo/modest-connection-specific-smtp-window.c:
851 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
853 2007-04-23 Murray Cumming <murrayc@murrayc.com>
855 * src/maemo/easysetup/modest-easysetup-wizard.c:
856 (create_page_account_details), (create_page_custom_outgoing),
857 (create_page_complete_custom):
858 * src/maemo/modest-account-settings-dialog.c:
859 (create_page_user_details), (create_page_incoming),
860 (create_page_outgoing):
861 * src/maemo/modest-connection-specific-smtp-edit-window.c:
862 (modest_connection_specific_smtp_edit_window_init):
863 Use the correct (UI spec) port min/max, and use horizontal separators,
866 2007-04-23 Murray Cumming <murrayc@murrayc.com>
868 * src/maemo/easysetup/modest-easysetup-wizard.c:
869 (set_default_custom_servernames):
870 * src/maemo/modest-account-settings-dialog.c:
871 (create_page_incoming), (on_combo_outgoing_security_changed),
872 (on_combo_incoming_security_changed), (create_page_outgoing),
873 (modest_account_settings_dialog_set_account_name),
874 (save_configuration):
875 * src/maemo/modest-connection-specific-smtp-edit-window.c:
876 (on_combo_security_changed),
877 (modest_connection_specific_smtp_edit_window_init),
878 (modest_connection_specific_smtp_edit_window_set_connection),
879 (modest_connection_specific_smtp_edit_window_get_settings):
880 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
883 2007-04-20 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/easysetup/modest-easysetup-wizard.c:
887 (create_page_custom_outgoing), (create_page_complete_custom):
888 * src/maemo/modest-account-settings-dialog.c:
889 (create_page_user_details), (create_page_outgoing):
890 * src/maemo/modest-account-view-window.c: (button_box_new):
891 Use changed logical IDs as per the most recent UI spec:
892 mcen_bd_emailsetup_edit -> mcen_bd_edit
893 mcen_bd_emailsetup_delete -> mcen_bd_delete
894 mcen_bd_emailsetup_close -> mcen_bd_close
896 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
900 * src/dbus_api/Makefile.am:
901 * src/dbus_api/modest-dbus-callbacks.c:
902 * src/dbus_api/modest-dbus-callbacks.h:
903 * src/maemo/modest-platform.c: (modest_platform_init):
904 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
907 * tests/dbus_api/Makefile.am:
908 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
910 2007-04-20 Murray Cumming <murrayc@murrayc.com>
912 * src/maemo/modest-account-settings-dialog.c:
913 * src/maemo/modest-connection-specific-smtp-edit-window.c:
914 Removed unnecessary includes.
916 2007-04-20 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/easysetup/modest-easysetup-wizard.c:
919 * src/maemo/modest-account-settings-dialog.c:
920 * src/maemo/modest-connection-specific-smtp-edit-window.c:
921 * src/widgets/Makefile.am:
922 * src/widgets/modest-easysetup-secureauth-combo-box.c:
923 * src/widgets/modest-easysetup-secureauth-combo-box.h:
924 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
925 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
926 * src/widgets/modest-secureauth-combo-box.c:
927 * src/widgets/modest-secureauth-combo-box.h:
928 * src/widgets/modest-serversecurity-combo-box.c:
929 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
930 made the GObject names more consistent with the rest of the Modest code.
932 2007-04-20 Murray Cumming <murrayc@murrayc.com>
934 * src/maemo/easysetup/Makefile.am:
935 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
936 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
937 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
938 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
939 * src/maemo/easysetup/modest-easysetup-wizard.c:
940 * src/maemo/easysetup/modest-validating-entry.c:
941 * src/maemo/easysetup/modest-validating-entry.h:
942 * src/maemo/modest-account-settings-dialog.c:
943 * src/maemo/modest-connection-specific-smtp-edit-window.c:
944 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
945 widgets/ because they are used outside of easysetup too. After checking in,
946 svn will allow me to rename them too.
948 2007-04-20 Murray Cumming <murrayc@murrayc.com>
950 * src/gnome/modest-msg-edit-window.c:
951 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
952 linker error, to fix the build on the GNOME platform.
953 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
954 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
955 ifdefed out to avoid a warning.
957 2007-04-20 Murray Cumming <murrayc@murrayc.com>
959 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
960 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
961 some alternative for GTK+ 2.6.
963 2007-04-19 Murray Cumming <murrayc@murrayc.com>
965 * src/maemo/modest-address-book.c: Added include to avoid a warning.
967 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
968 specified for EmailAccountsDialog in UI spec.
970 * src/maemo/easysetup/modest-easysetup-wizard.c:
971 * src/maemo/easysetup/modest-easysetup-wizard.h:
972 * src/maemo/modest-account-settings-dialog.c:
973 * src/maemo/modest-account-settings-dialog.h:
974 Reuse a member window widget for the connection-specific SMTP server accounts,
975 so we can tell it to create/save the accounts only if we actually save changes.
977 * src/maemo/modest-connection-specific-smtp-edit-window.h:
978 * src/maemo/modest-connection-specific-smtp-edit-window.c:
979 (modest_connection_specific_smtp_edit_window_get_settings):
980 Return a struct instance for temporarily remembering the entered data.
982 * src/maemo/modest-connection-specific-smtp-window.h:
983 * src/maemo/modest-connection-specific-smtp-window.c:
984 (modest_connection_specific_smtp_window_finalize),
985 (modest_connection_specific_smtp_window_fill_with_connections),
987 (modest_connection_specific_smtp_window_save_server_accounts),
988 (update_model_server_names): Do not actually save data until asked,
989 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
991 (on_selection_changed),
992 (modest_connection_specific_smtp_window_init): Disable the edit
993 button when nothing is selected.
995 * src/modest-account-mgr-helpers.c:
996 * src/modest-account-mgr-helpers.h:
997 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1000 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-account-mgr-helpers.h:
1003 * src/modest-account-mgr-helpers.c:
1004 (modest_account_mgr_get_unused_account_name),
1005 (modest_account_mgr_get_unused_account_display_name): Added these
1006 utility functions, to avoid code duplication.
1008 * src/maemo/easysetup/modest-easysetup-wizard.c:
1009 (create_page_account_details), (create_account):
1010 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1011 (on_combo_security_changed),
1012 (modest_connection_specific_smtp_edit_window_init),
1013 (modest_connection_specific_smtp_edit_window_save_settings):
1014 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1015 * src/maemo/modest-connection-specific-smtp-window.c:
1016 (modest_connection_specific_smtp_window_finalize),
1017 (modest_connection_specific_smtp_window_fill_with_connections),
1018 (on_button_edit), (modest_connection_specific_smtp_window_init):
1019 * src/maemo/modest-connection-specific-smtp-window.h:
1020 Implementing saving of connection-specific server accounts.
1022 But I need to refactor this so we can save the data for each
1023 possible connection-specific account and only actually create the server accounts
1024 when the easysetup finished, or the OK button is pressed on the account settings
1027 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1029 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1030 (on_combo_security_changed):
1031 (modest_connection_specific_smtp_edit_window_init):
1032 Auto-fill the port number as in the account settings.
1034 (modest_connection_specific_smtp_edit_window_set_connection):
1035 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1036 * src/maemo/modest-connection-specific-smtp-window.c:
1037 (fill_with_connections), (on_button_edit),
1038 (modest_connection_specific_smtp_window_init):
1039 Turn the edit window into a dialog to simplify the code, and
1040 set a WM hint as in a GtkDialog, because only a popup can be on top of
1041 another window in Maemo, and popups usually have no WM decoration.
1043 * src/modest-defs.h:
1044 * src/modest-account-mgr-helpers.c:
1045 (modest_account_mgr_set_connection_specific_smtp),
1046 (modest_account_mgr_remove_connection_specific_smtp),
1047 (modest_account_mgr_get_connection_specific_smtp):
1048 * src/modest-account-mgr-helpers.h: Some functions to write the
1049 connection-specific SMTP server information. Not yet used.
1052 * src/widgets/modest-folder-view.c: (text_cell_data):
1053 Fix a warning about an uninitialized variable.
1054 (on_configuration_key_changed): Put an #ifdef around the use
1055 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1057 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1059 * src/maemo/modest-account-settings-dialog.h:
1060 * src/maemo/modest-account-settings-dialog.c:
1061 Added connect_for_modified() utility function to mark the new modified boolean.
1063 (create_page_account_details), (create_page_user_details),
1064 (create_page_incoming), (create_page_outgoing), (on_response),
1065 (modest_account_settings_dialog_init),
1066 (modest_account_settings_dialog_set_account_name):
1067 Only warn about unsaved changes when there are actually unsaved changes.
1069 * src/modest-account-mgr-helpers.c:
1070 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1071 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1072 to get the data from there in future.
1074 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1076 * src/modest-defs.h:
1078 * src/modest-account-mgr-helpers.h:
1079 * src/modest-account-mgr-helpers.c:
1080 Store the security account setting in a single conf key instead of using
1081 the options list, so that the list is left for just the to-be-removed camel hack,
1082 and because gconf_client_set_list() is failing for some reason.
1084 * src/modest-account-mgr.c:
1085 (modest_account_mgr_add_server_account):
1086 * src/maemo/modest-account-settings-dialog.c:
1087 (modest_account_settings_dialog_set_account_name),
1088 (save_configuration): Use the renamed functions.
1091 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1093 * src/widgets/Makefile.am:
1094 * src/widgets/modest-limit-retrieve-combo-box.c:
1095 * src/widgets/modest-limit-retrieve-combo-box.h:
1096 * src/widgets/modest-retrieve-combo-box.c:
1097 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1098 the account settings dialog.
1100 * src/modest-defs.h:
1101 * src/modest-account-mgr-helpers.h:
1102 * src/modest-account-mgr-helpers.c:
1103 (modest_server_account_get_option_secure_auth),
1104 (modest_server_account_set_option_secure_auth):
1105 * src/modest-account-mgr.c:
1106 (modest_account_mgr_add_server_account):
1107 Use the existing AUTH_MECH conf key for the secure-auth setting,
1108 instead of putting it in the list options, because this was actually used already.
1110 * src/maemo/modest-account-settings-dialog.c:
1111 (create_page_account_details),
1112 (modest_account_settings_dialog_set_account_name),
1113 (save_configuration):
1114 * src/maemo/modest-account-settings-dialog.h:
1115 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1116 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1118 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1120 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1121 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1122 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1124 * src/modest-defs.h:
1125 * src/maemo/modest-account-settings-dialog.c:
1126 (create_page_incoming), (on_combo_outgoing_security_changed),
1127 (on_combo_incoming_security_changed), (create_page_outgoing),
1128 (modest_account_settings_dialog_set_account_name),
1129 (save_configuration): Load/Save the port number, and change it when the
1130 security combo changes, to suitable defaults.
1132 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1134 * src/modest-account-mgr.c:
1135 (modest_account_mgr_add_server_account): Set the security and secure-auth
1136 options, and add a comment saying that the other camel-specific options should be
1139 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1141 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1143 * src/modest-tny-account-store.c: (account_list_free),
1144 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1145 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1148 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1150 * src/modest-protocol-info.c:
1151 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1152 is required by our UI spec. Maybe something in our implementation will use this eventually.
1153 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1154 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1155 instead of the previous 0 placeholder.
1157 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1158 secure-auth settings.
1159 * src/modest-account-mgr-helpers.h:
1160 * src/modest-account-mgr-helpers.c:
1161 (modest_server_account_data_get_option_secure_auth),
1162 (modest_server_account_set_option_secure_auth),
1163 (modest_server_account_data_get_option_security),
1164 (modest_server_account_set_option_security): Added this API for getting and setting the security
1165 and secure-auth settings.
1167 * src/maemo/modest-account-settings-dialog.h:
1168 * src/maemo/modest-account-settings-dialog.c:
1169 (modest_account_settings_dialog_finalize), (check_data),
1170 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1171 about changing titles.
1172 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1173 (save_configuration): Save the security and secure-auth settings.
1175 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1176 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1178 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1180 * src/modest-defs.h:
1181 * src/modest-account-mgr.c:
1182 (modest_account_mgr_add_server_account):
1183 Added and used defines for the options key and value pair strings,
1184 that are used so far, though they do not seem to correspond to anything in our
1185 UI specs or ModestProtocol enum.
1187 * src/modest-account-mgr-helpers.h:
1188 * src/modest-account-mgr-helpers.c:
1189 (compare_option_strings_for_name),
1190 (modest_server_account_data_get_option_value),
1191 (modest_server_account_data_get_option_bool),
1192 (modest_account_mgr_get_server_account_option):
1193 Added helper functions for parsing the options GSList.
1195 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1198 display name is based on the supplied account name.
1199 * src/modest-account-mgr.c:
1200 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1201 with an inefficient, but good-enough, implementation.
1203 * src/maemo/easysetup/modest-easysetup-wizard.c:
1204 (create_page_account_details), (on_before_next), (create_account):
1205 Check for existing display names rather than (non-user-visible) account names, and just
1206 create and set a unique account name at the end.
1208 * src/maemo/modest-account-settings-dialog.c:
1209 (modest_account_settings_dialog_init),
1210 (modest_account_settings_dialog_set_account_name),
1211 (create_page_incoming): Show the display name, instead of the account name.
1212 (on_response): Do some (not all) extra checks, as in the UI spec.
1213 (save_configuration): Save the display name if it was changed.
1215 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1217 * po/en_GB.po: Added needed logical ID and translation.
1218 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1219 (init_view): Made the is-default column clicking work.
1221 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1224 * src/maemo/easysetup/Makefile.am:
1225 * src/maemo/easysetup/modest-easysetup-wizard.c:
1226 (modest_easysetup_wizard_dialog_init):
1227 * src/maemo/easysetup/provider-data-test.keyfile:
1228 * src/maemo/easysetup/provider-data.keyfile:
1229 Moved the provider data file to the new modest-providers-data package and used it from there.
1231 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1233 * src/modest-local-folder-info.c:
1234 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1235 N_() was already used on the static strings, but this just marks it for translation without
1236 using the translation.
1238 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/modest-account-settings-dialog.c:
1241 (create_page_incoming),
1242 (modest_account_settings_dialog_set_account_name):
1243 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1244 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1245 I will do this if nobody else gets there first.
1247 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1249 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1250 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1251 save the security stuff.
1253 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1256 Set the email address and user fullname, which I now see must be
1259 * src/maemo/modest-account-settings-dialog.h:
1260 * src/maemo/modest-account-settings-dialog.c:
1262 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1263 leave-on-server and authentication.
1264 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1267 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/modest-account-settings-dialog.c:
1271 * src/maemo/modest-account-settings-dialog.h:
1272 Most (but not all) of the widgets are now present as specified by the UI spec.
1273 No changes are yet saved, and some details are not properly shown yet.
1275 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1277 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/Makefile.am:
1280 * src/maemo/modest-account-settings-dialog.c:
1281 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1282 an existing account. Doesn't do much yet.
1284 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1285 Open the accounts settings dialog when Edit is clicked.
1287 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1289 * src/maemo/easysetup/Makefile.am:
1290 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1292 * src/maemo/easysetup/modest-easysetup-wizard.c:
1293 (modest_easysetup_wizard_dialog_init):
1294 Try to get the source directory from the build system,
1295 instead of hard-coding "./" into the source code, when opening our local
1296 copies of the configuration files.
1297 But this still fails when opening the wizard from the Accounts window,
1298 maybe because the working directory seems to change at runtime.
1299 So the wizard will fail the second time unless you copy the files into their
1300 proper locations - see the stdout warnings for the paths.
1302 (create_page_account_details),(on_before_next):
1303 Check for existing non-server accounts instead of server accounts,
1304 so the default account name is useful again, and to prevent trying to
1307 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1308 Show the wizard when New is clicked.
1310 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1311 (init_view): Show the column headers, and show the columns that are
1312 specified in the UI specs. However, something in Maemo's GTK+ prevents
1313 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1314 change the default account. This is despite unsetting the special properties.
1316 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1318 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1319 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1320 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1321 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1322 to make that clearer.
1323 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1325 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1327 * src/maemo/modest-account-view-window.c:
1328 (modest_account_view_window_init),
1329 (modest_account_view_window_new):
1330 Use the same buttons as specified in the
1331 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1332 the existing widgets, which never had a chance of working.
1333 Put the ModestAccountView treeview in a scrolled window.
1334 Do not repeat the initialization in both _init() and _new().
1336 * src/widgets/modest-account-view.c: (update_account_view):
1337 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1338 this widget and window shows no accounts.
1340 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1342 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/easysetup/modest-easysetup-wizard.c:
1345 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1346 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1347 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1350 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1351 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1352 accounts exist yet, as in the UI spec.
1354 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1356 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/Makefile.am:
1359 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1360 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1361 New window for editing connection-specific smtp details.
1362 Not fully implemented.
1364 * src/maemo/modest-connection-specific-smtp-window.c:
1365 (modest_connection_specific_smtp_window_finalize) :
1366 unref the tree model.
1367 (on_button_edit): Show the edit window.
1369 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1371 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1374 * src/maemo/Makefile.am:
1375 * src/maemo/modest-connection-specific-smtp-window.c:
1376 * src/maemo/modest-connection-specific-smtp-window.h:
1377 New window for showing the list of connections, for connection-specific
1378 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1379 * src/maemo/easysetup/modest-easysetup-wizard.c:
1380 (create_page_custom_outgoing): Show the new window when the button is clicked.
1382 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1384 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1385 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1386 * src/maemo/modest-msg-edit-window.c:
1387 (modest_msg_edit_window_insert_image):
1388 * src/modest-conf.c: (modest_conf_key_escape):
1389 * src/modest-mail-operation.c:
1390 (modest_mail_operation_send_new_mail):
1391 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1392 (modest_ui_actions_on_new_account):
1393 * src/widgets/modest-attachment-view.c: (update_filename_request):
1394 * src/widgets/modest-mail-header-view.c:
1395 Corrected warnings that were breaking the build, by commenting out unused variables,
1396 and a function, and by including a header.
1398 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1400 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1401 so we can #ifdef around platform-specific code when necessary.
1402 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1403 to allow this to build for the GNOME platform too.
1405 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1407 * src/maemo/easysetup/modest-easysetup-wizard.c:
1408 Added util_increment_name() and used it in create_page_account_details()
1409 to make sure that the default account name is always a new name.
1411 (modest_easysetup_wizard_dialog_init),
1412 (set_default_custom_servernames): Some minor memory management fixes.
1414 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1418 * src/modest-runtime.c: (init_i18n): Restored the translation
1419 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1420 are defined in config.h, and the translations are installed.
1422 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1423 is defined for translation.
1425 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1427 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1429 * src/maemo/easysetup/modest-easysetup-wizard.c:
1430 (modest_easysetup_wizard_dialog_init):
1431 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1432 Use realistic paths (though they should use $prefix generically) to the
1433 mcc_mapping and provider-data.keyfile files which might work when they
1434 are installed by the future version of the operator-wizard package,
1435 and then fallback to paths in our source code, with an explanatory
1438 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1442 * src/maemo/Makefile.am:
1443 * src/maemo/easysetup/: Added files from the previously-exernal
1444 osso-modest-easysetup.
1445 * src/maemo/modest-main-window-ui.h:
1446 * src/modest-ui-actions.c:
1447 * src/modest-ui-actions.h:
1448 Added modest_ui_actions_on_new_account() as a signal handler for the
1449 New Account menu item. It shows the easysetup wizard.
1450 * po/en_GB.po: Added additional needed logical IDs and translations.
1452 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1453 Apparently ChangeLog is not used for some vague Nokia legal reasons.