1 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 (create_page_user_details):
5 Use auto-cap for name (projects.maemo.org NB#63716)
6 * src/widgets/modest-account-view.c: (on_account_busy_changed):
8 2007-07-22 Armin Burgmeier <armin@openismus.com>
10 * src/maemo/modest-ui-actions.c: Use current account instead of
11 default account for creating viewer windows, so that the viewer
12 window knows to which account the viewed message belongs.
14 * src/maemo/modest-msg-view-window.c: Destroy the window when the
15 corresponding account is deleted. This fixes projects.maemo.org bug
18 2007-07-18 Armin Burgmeier <armin@openismus.com>
20 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
21 the dialog close after entering an invalid port number and clicking
22 OK. This fixes projects.maemo.org bug NB#63602.
24 2007-07-18 Armin Burgmeier <armin@openismus.com>
26 * src/modest-tny-account-store.c:
27 (get_server_accounts): Set parent modest account name for each
28 connection-specific transport account so that special folders of such
29 an account can be looked up. This fixes a crash when changing account
30 settings. This might also be related to projects.maemo.org bug
33 2007-07-16 Armin Burgmeier <armin@openismus.com>
35 * src/modest-ui-actions.c: Added a button to create a folder to the
36 move-to dialog. This fixes projects.maemo.org bug NB#.
38 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
40 * src/maemo/easysetup/modest-easysetup-wizard.c:
41 Added scrollbars to account wizard dialog.
42 Fixed projects.maemo.org NB #62744
44 2007-07-16 Murray Cumming <murrayc@murrayc.com>
46 * src/widgets/modest-msg-view.h:
47 * src/widgets/modest-msg-view.c:
48 Added modest_msg_view_get_message_is_empty() but this needs
50 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
51 Check if there is any text in the message yet.
52 But this needs to be implemented properly.
53 (modest_msg_edit_window_toggle_find_toolbar):
54 * src/maemo/modest-msg-view-window.c:
55 (modest_msg_view_window_toggle_find_toolbar):
56 Show a banner warning if there is no text to search, when
57 trying to start a search. This partially fixes
58 projects.maemo.org bug NB#62350.
60 2007-07-13 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-mail-operation.c: (update_account_thread):
63 Initialized num_new_headers to fix the build.
65 2007-07-13 Murray Cumming <murrayc@murrayc.com>
67 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
68 Ignore modest accounts whose server accounts don't exist in gconf.
69 This prevents us trying to create TnyAccount instances for those
70 server accounts when the server account has been removed from gconf,
71 but the parent modest account has not yet been removed from modest.
72 I don't know why this is only noticeable now. It was probably just
73 a harmeless g_warning() anyway.
75 2007-07-13 Murray Cumming <murrayc@murrayc.com>
77 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
78 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
80 2007-07-12 Armin Burgmeier <armin@openismus.com>
82 * src/maemo/modest-main-window.c: Make default account appear bold
83 in view, tools/send & receive and toolbar/send & receive SCM menus.
84 This fixes projects.maemo.org bug NB#59010.
86 2007-07-12 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
89 Add a short-cut, by checking if the folder store is an account.
90 This ensures that the Sort menu item and toolbar is dimmed for
91 the local-folders account root item, fixing
92 projects.maemo.org bug NB#62545.
94 2007-07-12 Murray Cumming <murrayc@murrayc.com>
96 * src/modest-tny-account-store.c: (get_password):
97 Show the password dialog (via the signal) only in the mainloop, via
98 an idle handler that we wait for. This could theoretically prevent
99 hangs, though I worry that it could introduce some too.
101 2007-07-12 Murray Cumming <murrayc@murrayc.com>
103 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
104 * src/maemo/modest-platform.c:
105 (modest_platform_connect_and_wait):
106 Take a TnyAccount* parameter and try to set it to online
107 (a TnyCamel-only API), because tinymail sets accounts to offline
108 when the user cancels a password dialog, and doesn't ask again until
109 it has been set to online.
110 However, this is commented out because it causes a hang now.
112 (modest_platform_connect_and_wait_if_network_account):
113 * src/modest-mail-operation.c:
114 (modest_mail_operation_update_account):
115 * src/modest-platform.h:
116 * src/modest-ui-actions.c: (_modest_ui_actions_open),
117 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
119 2007-07-12 Armin Burgmeier <armin@openismus.com>
121 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
123 * src/modest-mail-operation.c:
124 * src/modest-ui-actions.c: Check for already existing folder before
125 querying the server, show error message from camel if the request
126 still fails. This fixes projects.maemo.org bug NB#58701.
128 2007-07-12 Murray Cumming <murrayc@murrayc.com>
130 * src/modest-tny-account-store.h:
131 * src/modest-tny-account-store.c:
132 Added modest_tny_account_store_forget_password_in_memory(),
133 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
134 when creating a new account, so that new passwords will be used, instead of
135 us thinking that it's a second request as a result of a failed password again.
137 2007-07-12 Murray Cumming <murrayc@murrayc.com>
139 * src/dbus_api/modest-dbus-callbacks.c:
140 (on_idle_open_message): If the message is in drafts then open it
141 in an edit window instead of a view window. This fixes
142 projects.maemo.org bug NB#63005.
144 2007-07-12 Murray Cumming <murrayc@murrayc.com>
146 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
147 Avoided a harmless g_warning().
149 2007-07-12 Murray Cumming <murrayc@murrayc.com>
151 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
152 Pass the modest account name, not the TnyAccount display name to
153 modest_msg_view_window_new() so that the reply feature works,
154 fixing projects.maemo.org bug NB#62892.
156 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
157 (modest_msg_view_window_new_with_header_model):
158 * src/maemo/modest-msg-view-window.c:
159 (modest_msg_view_window_new_with_header_model),
160 (modest_msg_view_window_new):
161 * src/modest-ui-actions.c: (reply_forward):
162 * src/widgets/modest-msg-view-window.h:
163 * src/widgets/modest-window.c: (modest_window_set_active_account):
164 Rename an account parameter to modest_account_name to make this clearer.
166 2007-07-11 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-ui-actions.h:
169 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
170 modest_do_message_delete().
171 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
172 Call modest_do_message_delete(), hoping that this would cause messages
173 to be really deleted from search instead of just marked with strike through.
174 Does not seem to help.
176 2007-07-11 Armin Burgmeier <armin@openismus.com>
178 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
179 priv->reselect to FALSE prior to calling
180 modest_folder_view_select_first_inbox_or_local() to prevent endless
181 recursion and thus a crash on startup.
183 2007-07-11 Armin Burgmeier <armin@openismus.com>
185 * src/maemo/modest-account-settings-dialog.h: Include
186 <gtk/gtknotebook.h> to fix the build (at least for me).
188 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
189 Use "New FolderN" as default suggested name if "New folder" already
190 exists, with N being the first free number, though never exceed "New
191 folder99" in which case we just fall back to "New Folder" even though
192 it already exists. This fixes projects.maemo.org bug NB#58663.
194 2007-07-11 Murray Cumming <murrayc@murrayc.com>
196 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
197 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
198 projects.maemo.org bug NB#62778.
200 2007-07-11 Murray Cumming <murrayc@murrayc.com>
202 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
203 Ignore the wrong (for now) secure-smtp setting in the presets -
204 just default to requiring secure authentication for SMTP, because
207 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
209 * src/widgets/modest-folder-view.c: (filter_row)
210 Do not show drafts folder (see UI specs)
212 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
214 * src/modest-ui-actions.c:
215 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
216 place and also not necessary.
218 * src/widgets/modest-folder-view.c: (filter_row)
219 Guess folder type and hide Sent & Outbox if necessary.
220 Fixed project.maemo.org NB#57328
222 2007-07-11 Murray Cumming <murrayc@murrayc.com>
224 * src/modest-ui-actions.h:
225 * src/modest-ui-actions.c:
226 (modest_ui_actions_on_delete_message):
227 Move some code into a new
228 modest_ui_actions_refresh_message_window_after_delete()
229 function so we can use it from elsewhere.
231 * src/dbus_api/modest-dbus-callbacks.c:
232 (on_idle_delete_message), (on_delete_message): Used an idle
233 handler, as we do for the other D-Bus method handlers.
234 Call modest_ui_actions_refresh_message_window_after_delete()
235 if the deleted message was open in a window. This fixed
236 projects.maemo.org bug NB#62862.
238 2007-07-11 Murray Cumming <murrayc@murrayc.com>
240 * src/modest-main.c: (main): Only show the UI at the start if
241 the showui command line option was given. For instance,
242 run-standalone src/modest showui
243 Otherwise, we wait for the top_application D-Bus method to
244 be sent by hildon-desktop when the application is selected
246 This allows us to run without a UI when osso-global-search
247 uses our D-Bus methods.
249 2007-07-11 Murray Cumming <murrayc@murrayc.com>
251 * src/dbus_api/modest-dbus-api.h: Added a define for a
252 top-application D-Bus method.
253 * src/dbus_api/modest-dbus-callbacks.c:
254 (on_top_application),
255 (modest_dbus_req_handler): Handle the top-application D-Bus
256 method, which might be an undocumented D-Bus signal sent by
257 hildon-desktop when it starts the application from the menu.
258 But I am not sure and I need to test it on the device, because
259 my scratchbox does not have the application in the menu now.
260 This method shows the main window, so that it can be invisible
261 when started, for instance, just for email searching from
264 * src/maemo/modest-main-window.c: (restore_settings),
265 (modest_main_window_new): Do not show the window immediately
266 upon creation. We show it later.
267 * src/modest-widget-memory.c: (save_settings_paned):
268 Try (unsuccessfully) to avoid saving the paned position when
269 it is not even visible.
270 (restore_settings_paned): Do not allow a silly paned position.
271 This seems necessary when not showing the window at first.
273 * tests/dbus_api/Makefile.am:
274 * tests/dbus_api/test_top_application.c: (main): Test for the
277 2007-07-10 Murray Cumming <murrayc@murrayc.com>
279 * src/modest-ui-dimming-rules.c:
280 (modest_ui_dimming_rules_on_new_msg),
281 (modest_ui_dimming_rules_on_reply_msg),
282 (modest_ui_dimming_rules_on_delete_msg),
283 (modest_ui_dimming_rules_on_details),
284 (modest_ui_dimming_rules_on_view_window_move_to),
285 (modest_ui_dimming_rules_on_view_previous),
286 (modest_ui_dimming_rules_on_view_next),
287 (_invalid_folder_for_purge): Added checks before
288 casting the window. This looks like an actual
289 logic error in _invalid_folder_for_purge(), because it
290 tries to use a ModestMainWindow as a message window.
292 2007-07-10 Murray Cumming <murrayc@murrayc.com>
294 * src/maemo/modest-account-settings-dialog.c:
295 (show_error): Use the same implementation as in
296 modest-easysetup-wizard.c:
297 (on_entry_invalid_character): The logical ID contains a %s.
298 Guessed what it should be.
299 (on_entry_max), (check_data), (on_response): Adapt to
300 changed show_error().
301 (create_page_account_details): Really call
302 modest_validating_entry_set_func() on the correct widgets.
303 * src/maemo/easysetup/modest-easysetup-wizard.c:
304 (on_entry_invalid_character): Fix the logical ID here too.
305 (create_page_account_details),
306 (create_page_user_details):
308 modest_validating_entry_set_func() on the correct widgets.
310 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
311 Do not try to use the account if it is NULL.
313 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
315 * src/modest-ui-actions.c: (create_move_to_dialog),
316 (modest_ui_actions_on_main_window_move_to),
317 (modest_ui_actions_on_msg_view_window_move_to):
318 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
319 (filter_row), (modest_folder_view_show_non_move_folders):
320 * src/widgets/modest-folder-view.h:
322 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
323 the Sent folder yet as it does not report the correct folder type.
325 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
327 * src/maemo/modest-msg-edit-window.c: (init_window):
330 2007-07-10 Murray Cumming <murrayc@murrayc.com>
332 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
333 Take a parent widget instead of a parent window, and
334 implement this with hildon_banner_show_information() instead.
335 Non-Maemo builds can just ifdef that there.
336 This fixed projects.maemo.org bug NB#62766.
338 (on_entry_invalid_character): Use show_error() again instead
339 of using hildon directly, and use the _CS() macro to use the correct
341 (create_account), (check_for_supported_auth_methods), (on_entry_max):
342 Pass a widget instead od a window to show_error().
344 2007-07-10 Murray Cumming <murrayc@murrayc.com>
346 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
347 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
348 This allows us to show the server name in the error message, fixing
349 projects.maemo.org bug NB#62904.
350 Also, use the appropriate logical ID message for the account protocol.
352 2007-07-10 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-tny-account-store.c: (on_idle_wrong_password):
355 A compilation fix, though the build wasn't broken for me.
357 2007-07-09 Murray Cumming <murrayc@murrayc.com>
359 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
360 Do not try to unref a NULL folder store, to avoid a runtime warning.
361 This seems to happen sometimes when changing accounts settings.
363 2007-07-09 Murray Cumming <murrayc@murrayc.com>
365 * src/modest-tny-account-store.c:
366 (modest_tny_account_store_instance_init),
367 (modest_tny_account_store_finalize),
368 (on_account_settings_hide), (on_idle_wrong_password):
369 Use a GHashTable to ensure that we only show one account settings
370 dialog per modest account. This avoids us having a dialog open for
371 both the store and transport accounts, or due to repeated get_password()
372 calls that shouldn't happen anyway.
374 2007-07-09 Murray Cumming <murrayc@murrayc.com>
376 * src/maemo/modest-maemo-utils.c: (on_hide),
377 (modest_maemo_show_dialog_and_forget): Handle the response, because
378 the window is not even hidden by default.
380 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
381 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
382 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
383 which seems to prevent some modality problems.
385 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
386 Ignore user cancellation errors.
388 * src/modest-account-mgr-helpers.h:
389 * src/modest-account-mgr-helpers.c:
390 Added modest_server_account_get_password() and
391 modest_server_account_get_has_password() to avoid direct use of
394 * src/maemo/modest-account-settings-dialog.h:
395 * src/maemo/modest-account-settings-dialog.c:
396 (modest_account_settings_dialog_init): Store the notebook so we can
398 Added modest_account_settings_dialog_switch_to_user_info().
400 * src/modest-tny-account-store.c:
401 (get_password): When the password in the account settings is wrong (we think),
402 show the relevant page of the account settings dialog, in the mainloop.
403 However, we currently get many of these at once because cancel does not
405 (forget_password): Do not forget the password
406 from the account settings, because this causes side-effects when
407 tinymail seems to call it at strange time, maybe because of how we
408 are cancelling get_password().
409 (modest_tny_account_store_alert): Ignore user cancellations.
411 2007-07-09 Murray Cumming <murrayc@murrayc.com>
413 * src/maemo/modest-maemo-utils.h:
414 * src/maemo/modest-maemo-utils.c:
415 Added modest_maemo_show_information_note_and_forget() for use instead of
416 gtk_dialog_run() when the response is not needed, to avoid an extra
417 mainloop which could cause a hang.
419 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
420 Use the logical IDs for the error message, though they are not
421 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
422 because gtk_dialog_run() caused a hang here (the window did not close).
423 This fixes projects.maemo.org bug NB#62646.
425 2007-07-09 Murray Cumming <murrayc@murrayc.com>
427 * src/modest-account-mgr-helpers.h:
428 * src/modest-account-mgr-helpers.c:
429 Added modest_account_mgr_get_store_protocol().
431 * src/maemo/modest-account-view-window.c:
432 (on_delete_button_clicked): Show different warning text depending on
433 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
434 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
437 2007-07-09 Murray Cumming <murrayc@murrayc.com>
439 * src/maemo/modest-msg-edit-window.c:
440 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
441 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
443 2007-07-07 Armin Burgmeier <armin@openismus.com>
445 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
446 ckdg_ib_maximum_characters_reached from correct package.
448 * src/modest-ui-actions.c: Show an error message when a folder could
449 not be created. Tinymail does not give us specific error codes about
450 what has gone wrong, so we assume that a folder with that name
451 already exists, though there might be other reasons.
453 2007-07-06 Murray Cumming <murrayc@murrayc.com>
455 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
456 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
457 give a more exact error message that can be partly translated.
459 2007-07-05 Murray Cumming <murrayc@murrayc.com>
461 * src/maemo/modest-address-book.c:
462 (select_email_addrs_for_contact): Specify a default window size for the
463 select-email-address dialog, so that it is probably big enough for the
464 title. This should fix projects.maemo.org bug NB#62277.
466 2007-07-05 Murray Cumming <murrayc@murrayc.com>
468 * src/maemo/easysetup/modest-easysetup-wizard.c:
469 (create_page_complete_easysetup): Use
470 gtk_widget_set_size() request to ensure that the text wraps
473 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
475 * src/maemo/easysetup/modest-easysetup-wizard.c:
476 (on_entry_invalid_character), (create_page_account_details),
477 (create_page_user_details):
478 Use new API of ModestValidatingEntry. But for some reason the banner is
479 not shown. I will have to investigate that further.
481 * src/widgets/modest-validating-entry.c: (on_insert_text),
482 (modest_validating_entry_set_func):
483 * src/widgets/modest-validating-entry.h:
484 Added a new callback function to be able to react to prevented
485 characters whitespaces to e.g show a banner.
487 2007-07-05 Armin Burgmeier <armin@openismus.com>
489 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
490 notification of HildonNumberEditor instead of remembering the port
491 number. Thanks to Johannes for pointing this out.
493 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
495 * src/maemo/easysetup/modest-easysetup-wizard.c:
496 Check if there are any user changes before showing a confirmation
497 dialog (projects.maemo.org NB#60946)
499 2007-07-05 Armin Burgmeier <armin@openismus.com>
501 * src/maemo/modest-account-settings-dialog.c: Remember custom port
502 number at the beginning of the dialog and set the modified flag at the
503 end if the port number has changed. This is necessary because
504 HildonNumberEditor does not support notification when the value has
507 2007-07-05 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-ui-actions.c:
510 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
511 a connection before asking anything else. Correct the check for the destination
512 folder so that it succeeds when online.
513 This fixed projects.maemo.org bug NB#61645.
515 2007-07-05 Murray Cumming <murrayc@murrayc.com>
517 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
518 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
519 to fix projects.maemo.org bug NB#62439.
521 2007-07-05 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-tny-account.c: (on_connection_status_changed):
524 Really do not use tny_device_force_offline() here. See the previous comment.
526 2007-07-04 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-tny-account.c: (on_connection_status_changed):
529 Do not use tny_device_force_offline() when tinymail says that something
530 went wrong with the connection. It seems to report this unnecessarily.
532 2007-07-04 Murray Cumming <murrayc@murrayc.com>
534 * src/maemo/modest-connection-specific-smtp-window.c:
535 (modest_connection_specific_smtp_window_init):
536 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
537 does not seem to have any effect in osso 1.1 (though it works in
538 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
540 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
542 * src/maemo/modest-connection-specific-smtp-window.c:
543 Fix UI specification problems with projects.meamo.org NB#60479
545 2007-07-04 Murray Cumming <murrayc@murrayc.com>
547 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
548 clue when this has failed, because the error dialog is not always shown
549 (at least in earlier version).
551 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
552 GError message, because the generic error dialog is not helpful.
554 'This message is not currently available (can't let a new connection go online)'
555 when trying to open an IMAP message.
557 (_modest_ui_actions_open): Offer a connection when some messages would
558 have to be downloaded and we are offline.
560 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
562 * src/widgets/modest-folder-view.c:
563 Don't check for MERGE type anymore as we use the correct type
565 NOTE: For the last two changes you need to update your tinymail copy
566 because of API changes!
568 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
570 * src/modest-tny-local-folders-account.c:
571 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
572 (see projects.maemo.org NB#61580)
574 2007-07-04 Murray Cumming <murrayc@murrayc.com>
576 * src/modest-tny-account.c: (on_connection_status_changed):
577 Commented out the call to modest_platform_connect_and_wait() because this
578 seems to always hang, and I would like to know if this is the only thing
579 that causes a hang when showing the connection dialog.
580 It is not very useful anyway.
582 2007-07-04 Murray Cumming <murrayc@murrayc.com>
584 * src/maemo/modest-msg-view-window.c:
585 (modest_msg_view_window_select_next_message):
587 * src/modest-platform.h:
588 * src/maemo/modest-platform.c:
589 Added modest_platform_connect_and_wait(), which calls
590 tny_maemo_conic_device_connect() always in the main thread, by calling it
591 in an idle handler and waiting for the idle handler to run. It should be
592 in the main thread because it uses GTK+ UI code. It just returns TRUE
593 if the device is already online.
595 There is some nasty code to ensure that subsequent calls to
596 modest_platform_connect_and_wait() just wait for the first one to finish,
597 by checking repeatedly in another idle handler. This is necessary,
598 because other threads (or even the main thread, via another idle handler)
599 can call modest_platform_connect_and_wait() while
600 modest_platform_connect_and_wait() is running.
602 (modest_platform_connect_and_wait_if_network_account),
603 (modest_platform_connect_and_wait_if_network_folderstore):
604 Convenience functions that calls modest_platform_connect_and_wait() if
605 the account or folder might want network access.
607 * src/modest-mail-operation.c:
608 (modest_mail_operation_update_account):
609 * src/modest-ui-actions.c: (download_uncached_messages),
610 (modest_ui_actions_on_rename_folder), (delete_folder),
611 (modest_ui_actions_on_main_window_move_to),
612 (modest_ui_actions_on_msg_view_window_move_to):
613 * src/widgets/modest-folder-view.c:
614 (drag_and_drop_from_folder_view):
615 Offer a connection if we are offline.
617 * src/modest-tny-account.c: (on_connection_status_changed):
618 Document this as only handling errors during network operations in progress,
619 and replace the idle code with a simple call to
620 modest_platform_connect_and_wait(), which does this instead.
622 2007-07-03 Murray Cumming <murrayc@murrayc.com>
624 * src/modest-tny-account.c:
625 (modest_tny_account_get_special_folder): (util_on_idle),
626 Handle the GError so we can see when tny_folder_store_get_folders()
627 fails, as it currently does while something else is connecting.
629 Added util_run_in_main_thread_and_wait()
630 which uses an idlen handler and mainloop to ensure that the function
631 is called in the main thread.
632 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
633 to make sure that we call attempt the connection in the mainloop only,
634 which might solve some hangs.
636 2007-07-03 Murray Cumming <murrayc@murrayc.com>
638 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
639 be found by their display name. This is never useful.
640 * src/modest-tny-account-store.c: (on_account_removed): Find the account
641 by its ID, instead of trying to use its ID as its display name.
643 * src/modest-tny-account-store.h:
644 * src/modest-tny-account.c:
645 (modest_tny_account_get_special_folder): Add a g_warning() when
646 tny_folder_store_get_folders() returns an empty list for the maildir.
648 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
649 Add a g_warning() when this returns NULL, because that it not allowed
652 2007-07-02 Armin Burgmeier <armin@openismus.com>
654 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
655 note when trying to cancel the wizard. This fixes projects.maemo.org
658 2007-07-02 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-tny-account.h:
661 * src/modest-tny-account.c:
662 (modest_tny_account_new_from_server_account),
663 (modest_tny_account_new_from_server_account_name),
664 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
665 because this must now be set before setting the proto. This is usd in
666 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
667 warning in camel_session_get_service() caused by
668 tny_camel_transport_account_prepare().
670 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
673 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
675 * src/maemo/modest-connection-specific-smtp-edit-window.c:
677 (modest_connection_specific_smtp_edit_window_init):
679 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
682 2007-06-29 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-tny-account.c:
685 (modest_tny_account_new_from_server_account):
686 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
687 now uses to request a connection when it needs one, and which it uses
688 to tell us that something is wrong with the connection, so we can force
689 the accounts offline to prevent further problems.
692 * src/modest-init.c: (init_default_settings):
693 * src/modest-mail-operation.c:
694 (modest_mail_operation_update_account):
695 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
696 This should not be necessary anymore. Do not set the conf key that
697 determined this (it was always TRUE and not set anywhere else).
699 * src/modest-ui-actions.h: Remove unused and unimplemented
700 modest_ui_actions_on_online_toggle_toggled().
702 2007-06-29 Murray Cumming <murrayc@murrayc.com
704 * src/maemo/modest-main-window.c: (connect_signals):
705 Don't connect to delete_event twice. Maybe this was harmless.
707 2007-06-29 Murray Cumming <murrayc@murrayc.com
709 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
710 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
711 Debug output to give some more clue when a folder move is not allowed.
713 2007-06-28 Murray Cumming <murrayc@murrayc.com
715 * src/modest-tny-account.c: (on_modest_file_system_info),
716 (modest_tny_account_get_mmc_account_name):
717 Always call the callback, without checking whether the name has changed.
718 * src/widgets/modest-folder-view.c: (strings_are_equal),
719 (on_model_foreach_set_name), (on_get_mmc_account_name),
720 (text_cell_data): Compare the name here, and use the name from
721 the account rather than from the
722 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
723 if the name was changed after the account was added to the model.
724 That's a tinymail bug but not one that I want to fix now.
726 This finally fixes projects.maemo.org bug NB#59301.
728 2007-06-27 Armin Burgmeier <armin@openismus.com>
730 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
733 2007-06-27 Murray Cumming <murrayc@murrayc.com
735 * src/modest-tny-account.h:
736 * src/modest-tny-account.c:
737 Added modest_tny_account_get_mmc_account_name(), to set the memory
738 card name asynchronously for the given account and then notify.
739 (modest_tny_account_new_for_local_folders): Use this new function instead
740 of using hildon_file_system_info_async_new() directly.
742 * src/widgets/modest-folder-view.c: (text_cell_data):
743 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
744 gtk_tree_model_row_changed() when it is available.
746 This should fix projects.maemo.org bug NB#59301.
748 2007-06-27 Murray Cumming <murrayc@murrayc.com
750 * src/modest-mail-operation.c: (update_account_thread),
751 (get_msgs_full_thread): Fix typo failures in the revert
754 2007-06-27 Murray Cumming <murrayc@murrayc.com
756 * src/maemo/modest-maemo-global-settings-dialog.c:
757 (idle_select_default_focus):
758 * src/modest-mail-operation.c: (idle_notify_progress),
759 (idle_notify_progress_once), (set_last_updated_idle),
760 (update_account_thread), (get_msgs_full_thread):
761 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
762 * src/widgets/modest-header-view.c:
763 (idle_notify_headers_count_changed_destroy),
764 (idle_notify_headers_count_changed):
765 Reverted the additions of gdk_threads_enter/leave(), in case this
766 helps with a startup hang on the device.
768 2007-06-26 Armin Burgmeier <armin@openismus.com>
770 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
771 for supported secure authentication methods from server by
772 gtk_dialog_run(), saving CPU time and a potential race condition.
774 2007-06-26 Armin Burgmeier <armin@openismus.com>
776 * src/maemo/modest-maemo-utils.h:
777 * src/maemo/modest-maemo-utils.c: Added a
778 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
779 only error code to tell the calling code when the user canceled the
782 * src/maemo/modest-account-settings-dialog.h:
783 * src/maemo/modest-account-settings-dialog.c:
784 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
785 message if the retrieval of secure authentication methods was canceled
786 by the user. Perform the check before saving anything to configuration
787 to not end up with half-committed configuration changes, do not show
788 a "Saving to configuration failed" note when authentication methods
789 could not be retrieved.
791 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
794 2007-06-26 Murray Cumming <murrayc@murrayc.com>
796 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
797 Only return the first level of folders under accounts, because the
798 osso-global-search UI spec doesn't want the rest.
799 This fixed projects.maemo.org bug NB#61811.
801 2007-06-26 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-tny-account-store.c:
804 * src/modest-tny-account-store.h:
805 Added modest_tny_account_is_memory_card_account().
806 * src/maemo/modest-main-window.c: (create_details_widget):
807 Show the same information items for the memory card as we show for the
808 local-folders, to fix projects.maemo.org bug NB#59307.
810 2007-06-26 Murray Cumming <murrayc@murrayc.com>
812 * src/modest-tny-account-store.c: (get_password):
813 Added some checks for NULL to maybe prevent crashes, though I think
814 it was Philip's last commit that actually prevented the crash here
815 when creating a first new account.
816 But the new account is still not usable (no messages are shown)
817 until a restart of the application.
819 2007-06-26 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/modest-maemo-global-settings-dialog.c:
822 (idle_select_default_focus):
823 * src/modest-mail-operation.c: (idle_notify_progress),
824 (idle_notify_progress_once), (idle_notify_update_account_queue),
825 (set_last_updated_idle), (update_account_thread),
826 (notify_get_msgs_full), (get_msgs_full_destroyer),
827 (get_msgs_full_thread):
828 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
829 * src/widgets/modest-header-view.c:
830 (idle_notify_headers_count_changed_destroy),
831 (idle_notify_headers_count_changed):
832 Use gdk_threads_enter() and gdk_threads_enter_leave() in
833 all idle handlers, because some other thread could be blocking
834 the GDK lock, so that it can do GUI stuff.
836 2007-06-26 Murray Cumming <murrayc@murrayc.com>
838 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
839 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
840 (on_idle_send_receive), (on_idle_open_default_inbox):
841 * src/maemo/modest-msg-edit-window.c:
842 (modest_msg_edit_window_attach_file_noninteractive):
843 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
844 to prevent a hang. I don't quite understand why these are necessary,
845 beause we should already be in the main loop. I guess something outside
846 of the main loop is taking the lock.
848 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
849 we are really using URIs, and use files that are more likely to exist.
851 2007-06-26 Murray Cumming <murrayc@murrayc.com>
853 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
854 necessary because configure.ac now defines different variables.
856 2007-06-26 Murray Cumming <murrayc@murrayc.com>
858 * libmodest-dbus-client/libmodest-dbus-client.c:
859 * libmodest-dbus-client/libmodest-dbus-client.h:
860 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
861 libmodest_dbus_client_compose_mail() is what things actually use.
863 * src/dbus_api/modest-dbus-api.h:
864 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
865 * tests/dbus_api/Makefile.am:
866 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
869 2007-06-26 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-init.c: (modest_init_local_folders):
872 For memory-card (or other non local-folders) maildir accounts,
873 always create an Archive folder, so that there is somewhere to put
874 messages. This should be less confusing, because the user does not need
875 to guess that the need to create a folder.
877 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
879 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
880 Fixed icon size by using (50, 50) which is the same as defined by
883 2007-06-25 Armin Burgmeier <armin@openismus.com>
885 * src/widgets/modest-window-mgr.c:
887 * configure.ac: Correctly recognize hildon-notify presence and fixed
888 the build without it being installed.
890 2007-06-25 Murray Cumming <murrayc@murrayc.com>
892 * libmodest-dbus-client/libmodest-dbus-client.c:
893 (libmodest_dbus_client_search): Fix the build. Sorry.
894 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
895 (reply_forward_cb): Initialize variables to fix the build.
897 * src/modest-tny-account-store.c:
898 (modest_tny_account_store_get_tny_account_by): Fix the account URI
899 comparison (a silly typo) so that email search results can be opened
900 when there are more than one account.
902 2007-06-25 Murray Cumming <murrayc@murrayc.com>
904 * libmodest-dbus-client/libmodest-dbus-client.c:
905 (libmodest_dbus_client_search),
906 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
907 instead of 1 second, because the search gets folders and messages from
908 the server, which can take a long time. When it times out,
909 osso-global-search will report no results.
911 We need to specify whether we should search only cached information
912 (maybe with a user preference), and the osso-email-search-plugin
913 API should really be improved to allow that option, and to allow results
914 to be delivered asynchronously in batches.
916 2007-06-25 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
919 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
920 GTK_ICON_SIZE_DIALOG is probably the wrong size.
922 2007-06-25 Murray Cumming <murrayc@murrayc.com>
924 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
925 that is an empty string. D-Bus seems to give us these instead of NULL.
927 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
929 * src/dbus_api/modest-dbus-callbacks.c:
930 * src/maemo/easysetup/modest-easysetup-wizard.h:
931 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
932 * src/maemo/modest-connection-specific-smtp-edit-window.c:
933 (modest_connection_specific_smtp_edit_window_init):
934 * src/maemo/modest-maemo-global-settings-dialog.c:
936 * src/maemo/modest-maemo-utils.c:
937 (modest_maemo_utils_setup_images_filechooser):
938 * src/maemo/modest-main-window.c: (create_details_widget):
939 * src/maemo/modest-msg-edit-window.c:
940 (modest_msg_edit_window_attach_file_noninteractive),
941 (modest_msg_edit_window_color_button_change),
942 (modest_msg_edit_window_set_zoom):
943 * src/modest-mail-operation.c: (update_account_thread):
944 * src/modest-tny-account-store.c:
945 * src/modest-tny-account.c:
946 * src/widgets/modest-global-settings-dialog.c:
947 * src/widgets/modest-window.h:
951 2007-06-25 Murray Cumming <murrayc@murrayc.com>
953 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
954 * src/modest-search.c: (modest_search_folder),
955 (modest_search_all_accounts): Actually search only in the specified folder,
956 doing a simple match on the folder ID.
957 * src/modest-search.h: Added a folder field to the ModestSearch struct,
958 and added some documentation.
960 2007-06-22 Armin Burgmeier <armin@openismus.com>
962 * src/maemo/modest-maemo-utils.h:
963 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
964 modest_maemo_utils_get_supported_secure_authentication_methods.
966 * src/maemo/easysetup/modest-easysetup-wizard.c:
967 * src/maemo/modest-account-settings-dialog.c: Show correct error if
968 one occured, not just "Server does not support secure authentication".
970 2007-06-22 Murray Cumming <murrayc@murrayc.com>
972 * src/modest-tny-account-store.c: (get_password):
973 Restored the call to tny_account_set_user() because Philip seems to have
974 stopped this from crashing (by not using the freed string). It still does
975 not work, but now we can test it.
977 2007-06-22 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/modest-msg-edit-window.c: (init_window):
980 Comment out use of an uninitialzed GtkScrolledWindow variable,
981 to fix the build and stop a crash. Yet again.
983 2007-06-22 Murray Cumming <murrayc@murrayc.com>
985 * src/modest-tny-account-store.c: (get_password):
986 Remove the call to tny_account_set_user() because this actually crashes.
987 As mentioned in the last commit, it is known to not work anyway.
989 2007-06-22 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-tny-account-store.c: (get_password):
992 Use tny_account_set_username() to tell tinymail that the username might
993 have changed too. But tinymail ignores this: see projects.maemo.org
995 * src/modest-ui-actions.c:
996 (modest_ui_actions_on_password_requested): Remove the useless attempt to
997 reset the connection when changing the username, and improve the comments.
998 Save the changed username to gconf at least, so it is used when Modest is
1001 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1003 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1004 Do not use a query, so that we get all folders, including for POP and
1005 local-folders. They work as search criteria too.
1006 This fixes projects.maemo.org bug NB#57740.
1008 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1010 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1011 Comment out the use of hildon_notification_set_sound() because it is
1012 not declared, to fix the build. Warnings are serious, people.
1014 2007-06-21 Armin Burgmeier <armin@openismus.com>
1016 * src/maemo/modest-maemo-utils.h:
1017 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1018 modest_maemo_utils_get_supported_secure_authentication_methods()
1019 to query authentication methods for a specific user. This should fix
1020 projects.maemo.org bug NB#61369.
1022 * src/maemo/easysetup/modest-easysetup-wizard.c:
1023 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1026 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1028 * libmodest-dbus-client/libmodest-dbus-client.h:
1029 * libmodest-dbus-client/libmodest-dbus-client.c:
1030 (modest_dbus_message_iter_get_search_hit),
1031 (libmodest_dbus_client_search):
1032 Reorganised and commented this.
1033 Removed modest_search_hit_free() from the public API because it
1036 Added libmodest_dbus_client_get_folders() and
1037 modest_folder_result_list_free().
1039 * src/dbus_api/modest-dbus-api.h:
1040 * src/dbus_api/modest-dbus-callbacks.c:
1041 (modest_dbus_req_filter): Commented. Moved most code to
1042 on_dbus_method_search() and added on_dbus_method_get_folders().
1044 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1045 of the extra D-Bus handler.
1047 * tests/dbus_api/Makefile.am:
1048 * tests/dbus_api/test_get_folders.c: New test for
1049 libmodest_dbus_client_get_folders(). This seems to return an empty list
1050 at the moment. That could be the same error that causes the message list
1051 to be empty sometimes.
1052 This should help with projects.maemo.org bug NB#57740.
1054 2007-06-21 Armin Burgmeier <armin@openismus.com>
1056 * src/modest-mail-operation.c: Do not call
1057 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1058 notify the operation's end after having set the status to CANCELED for
1059 the operation queue to listen on. This fixes a deadlock when there
1060 were mail operations in the queue during its finalization.
1062 * src/modest-singletons.c: Reordered uninitialization of the account
1063 manager to happen after the mail operation queue was uninitialized
1064 because the mail operation's in the queue might still try to access
1065 the account manager (see modest_mail_operation_notify_end()). This
1066 fixes a potential crash when terminating the application.
1068 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1070 * src/modest-search.c:
1071 (search_mime_part_and_child_parts): Moved some code here so we
1072 can search recursively in child folders.
1073 (modest_search_folder): Search in the message as a mime part, instead
1074 of just its child mime parts.
1075 (read_chunk), (search_mime_part_ogs):
1076 Check how many bytes were read, to prevent an endless loop.
1077 Searching in message bodies now works. This finishes the fix for
1078 projects.maemo.org bug NB#61007.
1080 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1082 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1083 Add a g_warning when the item is not a folder.
1085 * src/modest-ui-dimming-rules.c:
1086 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1087 when selected item is not a folder (for instance, an account), because
1088 the UI spec only talks about folders.
1089 I am not sure what the UI spec wants, so this might not totally fix
1090 projects.maemo.org bug NB#60794.
1092 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1094 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1095 (load_from_file): Sort the list. The unsorted list would be more noticeable
1096 in non-English locales.
1098 * src/maemo/modest-msg-edit-window.c:
1099 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1100 warning and fix the build.
1102 * src/maemo/modest-progress-bar-widget.c:
1103 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1104 avoid a g_warning, and probably to avoid a crash.
1106 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1108 * src/modest-search.c: (modest_search_folder): Check for a GError
1109 when calling tny_folder_get_headers(), to show that this is not the cause
1112 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1114 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1115 Actually set the body query instead of the subject query.
1117 * src/modest-search.c: (search_mime_part_ogs),
1118 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1119 which would probably cause it to fail if we got this far.
1121 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1122 to simplify the code.
1123 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1124 be causing search-in-body to fail.
1126 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1128 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1130 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1131 Better debug message when the folder cannot be found.
1132 This should help with fixing projects.maemo.org bug #61287.
1133 * src/modest-search.c: (add_hit): Do not leak the furl string.
1135 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1137 * src/modest-ui-actions.c:
1138 (modest_ui_actions_on_folder_selection_changed):
1139 Do not special-case TNY_MERGE_FOLDER here, because
1140 modest_tny_folder_get_account() already does that. This fixes
1141 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1142 shown when the Outbox was selected).
1144 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1146 * libmodest-dbus-client/libmodest-dbus-client.c:
1147 (_dbus_iter_get_string_or_null): Initialize the string variable in
1148 case this helps with Dirk's crash.
1150 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1152 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1153 though it is not implemented yet (this function is maybe not even used),
1154 to avoid breaking ABI in future.
1155 * libmodest-dbus-client/libmodest-dbus-client.c:
1156 (get_attachments_string): Moved some code into this generic function.
1157 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1158 sends email. It is maybe not used.
1159 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1160 (on_send_mail): Use attachments.
1162 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1163 * src/maemo/modest-msg-edit-window.c:
1164 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1165 a filename before using it, to fix projects.maemo.org bug NB#58233.
1167 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1169 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1170 Initialize the continue_download variable to fix the build, and probably
1171 to fix randome behaviour.
1173 2007-06-18 Armin Burgmeier <armin@openismus.com>
1175 * src/modest-tny-send-queue.h:
1176 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1177 the queue so we can later show it in the UI. Replaced
1178 modest_tny_send_queue_msg_is_being_sent() by
1179 modest_tny_send_queue_get_msg_status().
1181 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1183 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1184 gpointer. This probably was not harmful, but just to be sure.
1186 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1188 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1189 Fix the build, but leave the function broken on Bora, because
1190 hildon_uri_action_get_service() does not exist.
1191 osso_uri_action_get_service() does not exist either, it seems.
1193 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-tny-account.c:
1196 (modest_tny_account_new_from_server_account):
1197 Uncommented the url debug output again, because it is useful for
1198 debugging, as I said in the comment.
1200 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1202 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1204 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1205 for Mameo Bora, to fix the build.
1207 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1210 Fixed build with hildon < 0.99
1212 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1213 Check if the selected account is busy instead of checking all accounts
1215 * src/modest-account-mgr-priv.h:
1216 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1217 (modest_account_mgr_init), (compare_account_name),
1218 (modest_account_mgr_set_account_busy),
1219 (modest_account_mgr_account_is_busy):
1220 * src/modest-account-mgr.h:
1221 Added busy information to the account manager. It possible to
1222 set an account to busy or not busy now.
1224 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1225 (modest_mail_operation_update_account),
1226 (modest_mail_operation_notify_end):
1227 Set the account to busy/not busy depending on the operation state.
1229 * src/widgets/modest-account-view.c:
1230 (modest_account_view_finalize), (get_last_updated_string),
1231 (update_account_view), (on_account_busy_changed), (init_view):
1232 Show string "Refreshing..." if the account is currently busy.
1234 All this fixes projects.maemo.org bug NB#59711
1236 2007-06-14 Armin Burgmeier <armin@openismus.com>
1238 * src/widgets/modest-attachments-view.h:
1239 * src/widgets/modest-attachments-view.c: Added
1240 modest_attachments_view_has_attachments() and fixed coordinate
1241 transformation in get_att_view_at_coords(). This fixes attachment
1244 * src/widgets/modest-msg-view.c: Make use of
1245 modest_attachments_view_has_attachments() to decide whether to show
1246 attachments in the header.
1248 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1250 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1251 (on_change), (on_combo_security_changed),
1252 (modest_connection_specific_smtp_edit_window_init),
1253 (modest_connection_specific_smtp_edit_window_set_connection),
1254 (modest_connection_specific_smtp_edit_window_is_dirty):
1255 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1256 * src/maemo/modest-connection-specific-smtp-window.c:
1259 Show an comfirmation dialog for the smpt-edit-window if there are
1260 unsaved changes and the user hits cancel.
1261 (projects.maemo.org bug NB#60479)
1263 2007-06-14 Armin Burgmeier <armin@openismus.com>
1265 * src/maemo/easysetup/modest-easysetup-wizard.c:
1266 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1267 address" info in banner instead of node, and select all the text as
1268 per UI spec. This fixes projects.maemo.org bug NB#60550.
1270 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1272 reviewed by: <delete if not using a buddy>
1274 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1275 * src/modest-ui-actions.c: (folder_refreshed_cb):
1277 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1279 * src/widgets/modest-folder-view.c: (filter_row):
1280 Explictly filter out the per-account outbox accounts. I don't know why
1281 these only sometimes show up, but now they should never show up in the UI.
1282 This should fix projects.maemo.org bug NB#60160.
1284 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1286 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1287 when the toolbar does not exist yet.
1288 * src/modest-widget-memory.c: (save_settings_header_view):
1289 Added g_warnings() to help us to discover when we are trying to set
1290 an empty columns list in gconf.
1292 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-init.h:
1295 * src/modest-init.c:
1296 Added modest_init_get_default_header_view_column_ids().
1298 * src/modest-widget-memory.c: (restore_settings_header_view):
1299 Use the new function to get defaults, if the gconf key is empty,
1300 instead of not creating any columns. This seems to fix the
1301 empty right-hand pane problems.
1303 * src/widgets/modest-header-view.h: Improved documentation.
1305 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1307 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1308 Revert the use of the display name as the account name, because this
1309 is generally wrong and would break the code that follows.
1311 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1313 * src/maemo/easysetup/modest-easysetup-wizard.c:
1314 (check_for_supported_auth_methods), (on_before_next),
1317 More correct fix for projects.maemo.org bug NB# 58991
1318 Do not longer accept AUTH_PASSWORD as secure method and choose
1319 correct method when creating the account.
1321 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1323 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1324 Fixed projects.maemo.org bug NB# 58991
1326 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-init.c: (modest_init_init_core),
1329 (modest_init_local_folders): Fixed compilation errors.
1331 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1333 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1334 Remove unnecessary lib/include, though it is good in principle when needed.
1336 * src/modest-init.c: (modest_init_one_local_folder),
1337 (modest_init_local_folders):
1338 * src/modest-init.h: Initialize the .modest library for memory cards,
1339 instead of just doing nothing for them. This should allow us to create
1340 folders there, fixing projects.maemo.org bug NB#59297.
1342 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1344 * libmodest-dbus-client/libmodest-dbus-client.c:
1345 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1346 (libmodest_dbus_client_compose_mail),
1347 (libmodest_dbus_client_open_message),
1348 (libmodest_dbus_client_send_and_receive),
1349 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1351 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1352 (on_idle_open_message), (modest_dbus_req_handler),
1353 (search_result_to_message), (modest_dbus_req_filter):
1354 * src/modest-search.c: (add_hit), (modest_search_folder),
1355 (modest_search_all_accounts): Improved debug messages.
1357 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1359 * src/modest-tny-account-store.c:
1360 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1363 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1366 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-tny-account-store.c: (get_server_accounts):
1369 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1370 even when there are no accounts, so that the Outbox folder is always
1371 visible. This fixes projects.maemo.org bug NB#60158.
1373 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1375 * src/maemo/modest-main-window.c: (create_details_widget):
1376 Use the mcen_va_never logical ID.
1378 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1380 * src/dbus_api/modest-dbus-api.h:
1381 * src/dbus_api/modest-dbus-callbacks.c:
1382 (on_idle_open_default_inbox), (on_open_default_inbox),
1383 (modest_dbus_req_handler):
1384 Added a new OpenDefaultInbox method.
1386 * libmodest-dbus-client/libmodest-dbus-client.h:
1387 * libmodest-dbus-client/libmodest-dbus-client.c:
1388 Added libmodest_dbus_client_open_default_inbox() to call the new
1389 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1390 though it should maybe be used by a new osso-email-interface function.
1392 * tests/dbus_api/Makefile.am:
1393 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1396 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1398 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1399 NULL, so that the signals get all the keys. This should not actually
1400 change any behaviour because we currently update everything when anything
1403 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1405 * src/widgets/modest-folder-view.c: (text_cell_data),
1406 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1407 (find_inbox_iter): If tinymail tells us that the folder is
1408 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1409 This causes the inbox to be selected at startup, fixing part of
1410 projects.maemo.org bug NB#56305.
1412 * src/modest-ui-dimming-rules.c:
1413 (modest_ui_dimming_rules_on_tools_smtp_servers):
1414 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1415 the SMTP servers menu item.
1416 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1417 that the SMTP Servers menu item is dimmed when there are no accounts,
1418 as a future version of the UI spec will require. This fixes
1419 projects.maemo.org bug NB#56305.
1421 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1423 * src/maemo/modest-maemo-utils.c:
1424 (modest_maemo_utils_get_supported_secure_authentication_methods):
1425 Added label to dialog instead of unreadable title
1427 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1428 (modest_main_window_new):
1429 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1432 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1433 * src/modest-account-mgr.h:
1434 Added method to avoid code duplication
1436 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1437 (modest_ui_actions_on_send_receive):
1438 Use modest_account_mgr_has_accounts
1440 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1442 * src/maemo/easysetup/modest-presets.c:
1443 (modest_presets_get_info_server_security): Do not report secure auth
1445 * src/modest-protocol-info.c: Use the defines for the gconf key names
1446 for secure authentication. This was not working because we were writing
1447 Password and reading password, and the check was case sensitive.
1448 With this, gmail now works for receiving and sending when created via
1451 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1453 * src/maemo/easysetup/modest-presets.c:
1454 (modest_presets_get_info_server_security): Correct the key name for
1455 SecureSmtp, because it seems to be case-sensitive.
1456 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1457 Do not try to get the 0th notebook page if there are 0 pages, to
1458 avoid a g_warning().
1460 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1462 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1463 Prevent use of the new notification feature for now, because it currently
1464 shows one dialog for each new email, which is annoying.
1466 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1468 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1469 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1470 when no country was selected, so that we show the global ones.
1471 * src/maemo/easysetup/modest-presets.c:
1472 (modest_presets_get_providers): Return only the global providers, not
1473 all providers when mmc=0 was requested.
1475 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1478 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1479 provider ID in the combo.
1481 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1482 Do not show the page numbers, because it would be confusing when we add
1483 the 2 extra pages for the custom setup, when the user chooses the "Other"
1484 provider. This fixes projects.maemo.org bug NB#59028
1486 * src/modest-init.c: (modest_init_init_core),
1487 (modest_init_local_folders):
1488 * src/modest-init.h:
1489 * src/modest-tny-account.c:
1490 (modest_tny_account_new_for_local_folders): Do not create default folders
1491 for the memory card. This should fix projects.maemo.org bug NB#59328.
1493 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1495 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1496 Free the changed_conf_keys string items. They are already freed in the
1497 idle handler if that runs first.
1499 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1501 * src/modest-ui-actions.c:
1502 (modest_ui_actions_on_password_requested): Check that the server name
1503 is not NULL, because I just saw a password dialog with (null) as the
1506 * src/modest-tny-folder.[h|c]: Added
1507 modest_tny_folder_is_memory_card_folder().
1508 * src/modest-ui-dimming-rules.c:
1509 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1510 menu item for memory cards, as per the UI spec (section 7.4). This should
1511 fix projects.maemo.org bug NB#59297.
1513 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1515 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1516 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1517 is another problem with the code, see Murray's comment at line 772)
1519 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1521 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1522 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1523 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1524 (load_from_file), (easysetup_country_combo_box_init),
1525 (easysetup_country_combo_box_get_active_country_ids),
1526 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1527 instead of just one ID, to avoid duplicate country names in the UI.
1529 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1530 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1531 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1532 a single ID, avoiding duplicate providers.
1533 * src/maemo/easysetup/modest-easysetup-wizard.c:
1534 (on_combo_account_country): Adapt to use a list.
1536 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1538 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1539 keys changed in the last X seconds.
1541 * src/modest-account-mgr.h:
1542 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1543 (on_key_change), (modest_account_mgr_class_init),
1544 (modest_account_mgr_init), (modest_account_mgr_finalize):
1545 As the keys are changed, save them in a GSList* and signal that GSList*
1546 further every X seconds, to batch changes, to allow us to do just one
1547 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1548 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1550 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1551 changed signal signature.
1553 * src/modest-conf.c: (modest_conf_set_list),
1554 (modest_conf_on_change): Reenable notification.
1556 (modest_conf_maemo_fake_on_change): Comment out the hack that
1557 notified immediately instead of asynchronously.
1559 * src/widgets/modest-account-view.h:
1560 * src/widgets/modest-account-view.c:
1561 (update_account_view): Select the previously-selected account ID,
1562 if possible. This fixes projects.maemo.org bug NB#56933.
1564 (on_account_changed), (on_account_removed),
1565 (modest_account_view_select_account):
1567 Remove the block/unblock functions
1568 because they were not useful.
1570 * src/maemo/modest-account-view-window.c:
1571 (on_delete_button_clicked), (on_edit_button_clicked),
1572 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1574 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1576 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1577 Improve the error dialog to show Incorrect Account Settings, which seems
1578 clearer, and say that the internal error message (to be removed from the
1579 dialog later) is often misleading.
1580 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1582 * src/modest-tny-account.c:
1583 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1584 URL because this is so useful for debugging on the device.
1586 * src/widgets/modest-serversecurity-combo-box.c:
1587 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1589 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1591 * src/modest-mail-operation.c:
1592 (modest_mail_operation_send_new_mail):
1593 Added a comment about a nasty but apparently harmless message. Details
1594 added to the wiki g_warnings() page.
1596 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1598 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1599 (modest_tny_send_queue_class_init):
1600 Do not use the priv struct because it is empty, to avoid g_warnings
1601 about a non-existant priv struct.
1603 * src/modest-tny-account-store.c:
1604 (modest_tny_account_store_get_server_account),
1605 (modest_tny_account_store_get_transport_account_for_open_connection
1606 ): Do not try to get transport server accounts for local folders,
1607 because they don't have any. This avoids a g_warning().
1609 * src/maemo/modest-main-window.c:
1610 (modest_main_window_notify_send_receive_initied),
1611 (on_configuration_key_changed):
1612 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1613 * src/modest-defs.h:
1614 * src/modest-mail-operation.c:
1615 (modest_mail_operation_update_account):
1616 * src/modest-tny-account-store.h:
1617 * src/modest-tny-account.c:
1618 (modest_tny_account_get_special_folder),
1619 (modest_tny_account_new_for_local_folders),
1620 (modest_tny_account_new_for_per_account_local_outbox_folder):
1621 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1622 * src/modest-tny-local-folders-account.c:
1623 (add_account_folders_to_merged_folder):
1624 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1625 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1626 (modest_ui_actions_on_send):
1627 * src/widgets/modest-folder-view.c: (update_model):
1628 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1629 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1630 modest_tny_account_store_get_tny_account_by_account() to
1631 modest_tny_account_store_get_server_account() to make the code clearer.
1633 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1635 * src/dbus_api/modest-dbus-api.h:
1636 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1637 * src/maemo/modest-msg-edit-window.c:
1638 (modest_msg_edit_window_attach_file_noninteractive):
1639 added g_warning in case the file to be attached does not exist
1640 * tests/dbus_api/test_compose_mail.c: (main):
1641 removed obsolete comment, added generic files as test case
1643 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1645 * src/modest-tny-account-store.c: (get_server_accounts):
1646 Create the local folders account only once, not once for each outbox, and
1647 not only when there are some outboxes.
1649 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1651 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1652 code that is causing a crash at startup. Sergio says that he is fixing this.
1654 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1656 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1657 * src/maemo/modest-account-settings-dialog.c:
1658 (create_page_outgoing),
1659 (modest_account_settings_dialog_set_account_name),
1660 (save_configuration):
1661 - Fixed handling of the "Use secure authentication" toggle to comply with
1662 the ui specification. See also projects.maemo.org bug NB#58400
1664 - Restore the Secure connection setting combo correctly when loading
1667 * src/maemo/modest-maemo-utils.c:
1668 (on_camel_account_get_supported_secure_authentication),
1669 (modest_maemo_utils_get_supported_secure_authentication_methods):
1670 Fixed a crasher if operation is canceled
1672 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1673 (modest_protocol_info_auth_is_secure):
1674 * src/modest-protocol-info.h:
1676 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1677 the sense of the "Use secure authentication" toggle.
1679 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1681 * src/modest-tny-account-store.h:
1682 * src/modest-tny-account-store.c:
1683 Added modest_tny_account_store_get_local_folders_account().
1685 * src/modest-tny-folder.h:
1686 * src/modest-tny-folder.c:
1687 (modest_tny_folder_get_account):
1688 Added this replacement for tny_folder_get_account() which returns
1689 the local-folders account for TnyMergeFolders, to avoid the
1690 warning about the unimplemented get_account_func() vfunc().
1692 (modest_tny_folder_get_rules),
1693 * src/modest-ui-actions.c:
1694 (modest_ui_actions_on_folder_selection_changed):
1695 * src/modest-mail-operation.c:
1696 (modest_mail_operation_remove_folder),
1697 (modest_mail_operation_xfer_folder),
1698 (modest_mail_operation_rename_folder),
1699 (modest_mail_operation_get_msg),
1700 (modest_mail_operation_get_msgs_full),
1701 (modest_mail_operation_remove_msg),
1702 (modest_mail_operation_xfer_msgs),
1703 (modest_mail_operation_refresh_folder):
1704 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1706 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1708 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1709 (modest_server_account_set_security):
1710 * src/modest-defs.h: Add comments explaining that our
1711 UI spec means TLS when it says Normal, so these do not look like errors.
1713 * src/modest-tny-account.c:
1714 (modest_tny_account_new_from_server_account): Use the new tinymail
1715 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1716 for TLS. This should fix projects.maemo.org bug NB#58460.
1718 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1720 * src/maemo/easysetup/modest-easysetup-wizard.c:
1721 (create_account): Correct the position of the gconf sanity check warning.
1722 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1723 of using the g_idle_add() hack, because this does not seem to be necessary
1724 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1725 caused by something other than maemo's gconf.
1726 This fixes projects.maemo.org bug #59022.
1728 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1730 * src/modest-account-mgr-helpers.c:
1731 (modest_account_mgr_get_default_account): Do not check that the account
1732 exists if there is no default account (NULL), to fix a runtime warning.
1734 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1736 * src/widgets/modest-folder-view.c: (update_model):
1737 Do not unref the treemodel before we have finished with it.
1738 This prevents a valgrind warning and an occasional crash at startup.
1740 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1742 * libmodest-dbus-client/libmodest-dbus-client.h:
1743 added libmodest_dbus_client_compose_mail()
1744 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1746 added functions needed for SendAsMail() functionality
1747 * src/maemo/modest-msg-edit-window.c:
1748 (modest_msg_edit_window_attach_file_noninteractive):
1749 non interactively attaching files to message edit window
1750 * src/widgets/modest-msg-edit-window.h:
1751 * tests/dbus_api/Makefile.am:
1752 added test_compose_mail.c
1753 * tests/dbus_api/test_compose_mail.c: (main):
1755 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1757 * src/modest-account-view.c:
1758 Fixed bug projects.maemo.org bug NB#59307
1760 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1762 * src/maemo/easysetup/modest-easysetup-wizard.c:
1763 (get_serverport_incoming), (on_before_next), (create_account):
1764 * src/maemo/modest-account-settings-dialog.c:
1765 (modest_account_settings_dialog_set_account_name):
1766 * src/maemo/modest-maemo-utils.c:
1767 (on_camel_account_get_supported_secure_authentication_status),
1768 (on_camel_account_get_supported_secure_authentication),
1769 (on_secure_auth_cancel),
1770 (modest_maemo_utils_get_supported_secure_authentication_methods):
1772 Implemented security authentication for settings and easysetup.
1774 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1776 * src/maemo/modest-main-window.c: (create_details_widget):
1777 Show the total size for memory card accounts too, instead of showing
1778 the name again. Fixes bug projects.maemo.org bug NB#59307.
1780 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1783 * src/modest-tny-simple-folder-store.c:
1784 * src/modest-tny-simple-folder-store.h: Removed.
1786 * src/modest-tny-local-folders-account.h
1787 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1788 for the local-folders maildir, with an extra TnyMergedFolder containing
1789 the folders of the per-account outbox store accounts.
1790 * src/modest-tny-account-store.c: (get_server_accounts):
1791 Add the outboxes to the special local folders account after creating it.
1793 * src/modest-tny-account.c:
1794 (modest_tny_account_new_for_local_folders): Create the derived
1795 account when creating the main local-folders account.
1797 * src/maemo/modest-main-window.c: (create_details_widget),
1798 (modest_main_window_set_contents_style):
1799 Adapted to the use of the derived account instead of the folder store.
1801 * src/modest-ui-actions.c:
1802 (modest_ui_actions_on_folder_selection_changed):
1803 * src/modest-ui-dimming-rules.c:
1804 (modest_ui_dimming_rules_on_new_folder):
1805 * src/widgets/modest-folder-view.c: (text_cell_data),
1806 (icon_cell_data), (filter_row), (update_model),
1807 (get_cmp_rows_type_pos):
1810 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1811 Do not get the priv struct, because no priv struct has been set,
1812 to avoid a runtime warning.
1814 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1815 #ifelse with #else, to fix a warning, to fix the build.
1818 2007-06-05 Christian Kellner <ckellner@openismus.com>
1820 * libmodest-dbus-client/libmodest-dbus-client.c:
1821 Fix small typo in doc (why do you always see them
1822 AFTER committing stuff?)
1825 2007-06-05 Christian Kellner <ckellner@openismus.com>
1827 * libmodest-dbus-client/libmodest-dbus-client.c:
1828 (libmodest_dbus_client_search):
1829 Initialize hit list with NULL. Also set folder list
1830 to "" if NULL was supplied.
1833 2007-06-03 Christian Kellner <ckellner@openismus.com>
1835 * libmodest-dbus-client/libmodest-dbus-client.c:
1836 (modest_search_hit_list_free):
1837 Make it save to call it with NULL.
1839 * src/dbus_api/modest-dbus-callbacks.c:
1840 * src/modest-search.c:
1841 Return full ModestSearchHits as the search result list not TnyHeader
1842 since can't be around withouth the correspoding TnyFolder.
1844 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1846 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1847 Added currently commented code to check for secure auth
1849 * src/maemo/modest-account-settings-dialog.c: (on_response),
1850 (save_configuration), (show_ok):
1851 Fixed projects.maemo.org bugs NB #59248 and #59251
1853 * src/maemo/modest-maemo-utils.c:
1854 (on_camel_account_get_supported_secure_authentication_status),
1855 (on_camel_account_get_supported_secure_authentication),
1856 (modest_maemo_utils_get_supported_secure_authentication_methods):
1857 * src/maemo/modest-maemo-utils.h:
1858 Moved get_supported_secure_authentication() method here to be able
1859 to use it from easysetup wizard.
1861 * src/modest-pair.c: (on_pair_compare_as_string):
1862 Should compare string with first part of pair and not
1863 strcmp pairs which will crash.
1865 * src/modest-protocol-info.c:
1866 (modest_protocol_info_protocol_is_store):
1867 * src/modest-protocol-info.h:
1868 Added modest_protocol_info_get_auth_protocol_name()
1870 2007-06-03 Armin Burgmeier <armin@openismus.com>
1872 * src/modest-mail-operation.c:
1873 (modest_mail_operation_get_msgs_full): Set priv->account also when
1874 only retrieving a single message. This avoids a crash when canceling
1877 (modest_mail_operation_notify_end): Do not explicitely remove the
1878 operation from the queue but only emit the progress_changed signal.
1879 The queue itself listens to that signal to remove the operation when
1880 it is finished. This reduces coupling and removes a potential deadlock
1881 when modest_mail_operation_notify_end() is called from the queue
1882 itself. If that is a problem performance-wise, I would suggest to
1883 implement a status-changed signal or something.
1885 * src/modest-mail-operation-queue.c: Make sure to never call a
1886 function from another file while the queue is locked. This (hopefully)
1887 fixes another deadlock when exiting the application while retrieving
1890 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1892 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1893 Fixed build if libogs is not available
1895 2007-06-03 Christian Kellner <ckellner@openismus.com>
1897 * libmodest-dbus-client/libmodest-dbus-client.h:
1898 * libmodest-dbus-client/libmodest-dbus-client.c:
1899 (libmodest_dbus_client_delete_message):
1900 Implement deletion of messages (Client side).
1902 (modest_search_hit_free),
1903 (modest_search_hit_list_free):
1904 Utility functions to free the result hits.
1906 * src/dbus_api/modest-dbus-api.h:
1907 * src/dbus_api/modest-dbus-callbacks.c:
1908 (on_delete_message),
1909 (modest_dbus_req_handler):
1910 Implement deletion of messages (Server side).
1912 * tests/dbus_api/test_search.c: (main):
1915 * tests/dbus_api/Makefile.am:
1916 * tests/dbus_api/test_delete_message:
1917 Add little test for the message deletion logic
1919 2007-06-03 Armin Burgmeier <armin@openismus.com>
1921 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1922 when the operation queue was not empty. projects.maemo.org bug
1925 2007-06-03 Armin Burgmeier <armin@openismus.com>
1927 * src/widgets/modest-account-view.c
1928 (on_account_default_toggled): Toggle default account column
1929 explicitely instead of waiting for gconf notification (which is
1930 currently ignored). This should fix projects.maemo.org bug NB#56910
1931 for now. It should probably be removed when gconf notifications are
1934 2007-06-03 Christian Kellner <ckellner@openismus.com>
1936 * libmodest-dbus-client/libmodest-dbus-client.c:
1937 Removed debugging spew.
1939 * src/dbus_api/modest-dbus-callbacks.c:
1940 Added debugging info.
1942 * src/modest-search.c:
1943 (modest_search_all_accounts):
1944 Use tny_account_store_get_accounts () on the account store
1945 to get all accounts which is the way to get all accounts.
1947 * tests/dbus_api/test_search.c: (main):
1948 Make it possible to supply the search term on the command line.
1950 2007-06-03 Christian Kellner <ckellner@openismus.com>
1952 * libmodest-dbus-client/libmodest-dbus-client.c:
1953 * libmodest-dbus-client/libmodest-dbus-client.h:
1954 Implement searching for mesages over raw dbus. (Client side)
1956 * src/dbus_api/Makefile.am:
1957 * src/dbus_api/modest-dbus-api.h:
1958 * src/dbus_api/modest-dbus-callbacks.c:
1959 * src/dbus_api/modest-dbus-callbacks.h:
1960 Search framework (Server side). Also implement on_idle_open_message().
1962 * src/maemo/modest-platform.c: (modest_platform_init):
1963 Prepare for raw dbus/osso rpc interaction.
1965 * src/modest-search.h:
1966 Changed minsize from unspecific guint to guint32.
1968 * src/modest-search.c:
1970 Added strange hack which magically made tnymail work.
1972 (modest_search_folder),
1973 (modest_search_account),
1974 (modest_search_all_accounts):
1975 Implement helper functions to search all accounts, specific account
1978 * tests/dbus_api/Makefile.am:
1979 * tests/dbus_api/test_open_message.c:
1980 Read url to open from commandline.
1982 * tests/dbus_api/test_search.c:
1983 Implement small test for dbus search stuff
1985 2007-06-02 Armin Burgmeier <armin@openismus.com>
1987 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1988 include account type and account title. This fixes projects.maemo.org
1991 * src/maemo/modest-account-view-window.c: Set a title for the window.
1993 2007-06-02 Armin Burgmeier <armin@openismus.com>
1995 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1996 incoming and outgoing server name based on email address and server
1997 types as long as the names have not been edited manually. This fixes
1998 projects.maemo.org bug NB#58671.
2000 2007-06-02 Armin Burgmeier <armin@openismus.com>
2002 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2003 server type cannot be changed in future to the incoming details page
2004 when creating an account. This fixes projects.maemo.org bug NB#59029.
2006 2007-06-02 Armin Burgmeier <armin@openismus.com>
2008 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2009 and assigned max width chars so that they wrap instead of being
2010 truncated. Fixes projects.maemo.org bug NB#56126.
2012 2007-06-02 Armin Burgmeier <armin@openismus.com>
2014 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2015 introductory note to the connection specific smtp servers dialog, as
2016 section 8.12 of the email UI specification requires. This fixes
2017 projects.maemo.org bug NB#59212.
2019 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2022 Check for running mail operations, and offer to cancel them, as per the UI
2023 spec. This fixes projects.maemo.org bug NB#59041 .
2024 However, I suspect that tinymail may still use the network connection
2025 in ways that we cannot detect or cancel. But it should at least adapt to
2026 changes fairly well.
2028 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2030 * src/modest-tny-account-store.c: (recreate_all_accounts),
2031 (get_cached_accounts), (get_server_accounts): Do more sensible
2032 ref-counting of the temporarily-cached outbox accounts list. This seems
2033 to fix a crash when entering the password when the password was wrong.
2035 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2037 * src/gnome/modest-main-window.c: (connect_signals):
2038 * src/modest-tny-account-store.c: (get_password),
2039 (modest_tny_account_store_alert): Added comments and clues and
2040 commented-out code about how we currently fail to deal with connection
2041 errors and wrong passwords, and how we should.
2043 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2045 * src/widgets/modest-retrieve-combo-box.c:
2046 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2047 This fixes projects.maemo.org bug NB#58472 .
2049 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2051 * src/maemo/easysetup/modest-easysetup-wizard.c:
2052 (create_page_complete_easysetup):
2053 (create_page_complete_custom): Correct the last commit,
2054 putting the correct sentences in the correct pages.
2056 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2058 * src/maemo/easysetup/modest-easysetup-wizard.c:
2059 (create_page_complete_custom): Show the second sentence of text
2060 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2063 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2065 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2066 Set the leave-on-server conf key by default. This fixes
2067 projects.maemo.org bug NB#59258 .
2069 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/modest-account-view-window.c:
2072 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2073 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2076 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/easysetup/modest-easysetup-wizard.c:
2079 (create_caption_new_with_asterisk):
2080 * src/maemo/modest-account-settings-dialog.c:
2081 (create_caption_new_with_asterisk):
2082 Uncomment the code to add the asterisk, because they are no longer in the
2083 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2084 (update_incoming_server_title): Add an asterisk here too.
2086 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2088 * src/maemo/modest-maemo-global-settings-dialog.c:
2089 (current_connection): Check that we are even connected before trying to
2090 get the current connection name, to prevent a warning.
2092 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2093 Change the comments because tny_maemo_conic_device_connect() is now meant to
2095 * src/modest-mail-operation.c:
2096 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2097 make sure we have a connection and fail if we can't connect.
2099 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2101 * src/maemo/modest-main-window.c:
2102 (on_account_store_connecting_finished): Do not try to get the
2103 connection ID if we are not really connected. I am surprised that
2104 this signal handler is called when we are not connected.
2106 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2108 * src/modest-error.h:
2109 * src/modest-ui-actions.c:
2110 (modest_ui_actions_get_msgs_full_error_handler):
2111 Renamed an enum, added comments, added an enum
2112 for retrieve-limit errors.
2114 * src/modest-mail-operation.c: (foreach_add_item),
2115 (internal_folder_observer_update), (update_account_thread),
2116 (modest_mail_operation_get_msgs_full):
2117 (modest_mail_operation_update_account),
2118 Added comments about how this works, and some code that should
2119 (but does not) check the retrieve-limit. See the TODO comment.
2121 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2123 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2124 Initialize help_id to fix the build. Warnings are good.
2126 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2128 * src/widgets/modest-hbox-cell-renderer.c:
2129 (modest_hbox_cell_renderer_append):
2130 * src/widgets/modest-vbox-cell-renderer.c:
2131 (modest_vbox_cell_renderer_append):
2132 Fix the last commit by doing an extra ref.
2134 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2136 * src/widgets/modest-hbox-cell-renderer.c:
2137 (modest_hbox_cell_renderer_append):
2138 * src/widgets/modest-vbox-cell-renderer.c:
2139 (modest_vbox_cell_renderer_append):
2140 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2141 to fix the build with Maemo Bora.
2142 However, there seems to be a remaining crash, probably due to reference
2145 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2147 * src/modest-tny-account.c:
2148 (modest_tny_account_new_for_local_folders):
2149 Use hildon_file_system_info_async_new() to get a better name for
2150 the memory card account, setting it as the account name.
2151 The timing seems to work, but this is probably
2152 not the best place to do this. See the TODO comment.
2153 * src/maemo/modest-main-window.c: (create_details_widget):
2154 * src/widgets/modest-folder-view.c: (text_cell_data):
2155 Use the tny account name instead of hardcoding a name.
2157 2007-05-30 Christian Kellner <ckellner@openismus.com>
2159 * src/modest-search.c: (modest_search):
2160 Correctly set part_search_func even if we have already parsed
2161 the query and thus a valid OgsTextSearcher object.
2163 2007-05-30 Christian Kellner <ckellner@openismus.com>
2166 Search and check for libogs.
2169 Incooparte the ogs build env.
2171 * src/modest-mime-part-search-stream.c:
2172 * src/modest-mime-part-search-stream.h:
2173 Removed since we do the real searching now in modest-search.c.
2175 * src/modest-search.c:
2176 * src/modest-search.h:
2177 Implement support for ogs. We use that if available and requested
2178 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2179 should now handle the corner case when the search term is spread
2180 across multiple reads.
2181 Also the logic in modest_search () was corrected to search all
2182 requested fields until one is found.
2184 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2186 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2188 * src/modest-init.h:
2189 * src/modest-init.c: Made modest_init_local_folders() take a
2190 path and be public so we can iniitialize maildir folders on
2193 * src/modest-local-folder-info.h:
2194 * src/modest-local-folder-info.c:
2195 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2197 * src/modest-tny-account.c:
2198 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2199 still means the standard local-folders path on the local volume.
2201 * src/modest-tny-account-store.c:
2202 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2203 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2204 all accounts when that happens.
2205 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2206 this too, so it shows up in the treeview.
2208 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/modest-maemo-global-settings-dialog.c:
2211 (current_connection):
2212 * src/widgets/modest-global-settings-dialog.c:
2213 (current_connection_default):
2214 Use the enum values instead of 0, 1 and -1,
2215 to make the code clearer.
2217 * src/modest-account-mgr-helpers.c:
2218 (modest_account_mgr_get_connection_specific_smtp): Make this code
2221 * src/modest-runtime.h:
2222 * src/modest-runtime.c:
2223 Added modest_runtime_remove_all_send_queues().
2224 * src/maemo/modest-main-window.c:
2225 (on_account_store_connecting_finished): Recreate the send queues,
2226 using the appropriate transport accounts for this new connection.
2227 Some futher adapting might be needed if the old send queues are not
2228 automatically stopped at this point.
2230 * src/modest-tny-account-store.c: (get_server_accounts):
2231 Create the connection-specific transport accounts, so that they can
2232 be found later by their ID.
2234 * src/modest-tny-account.h:
2235 * src/modest-tny-account.c:
2236 Added modest_tny_account_new_from_server_account_name().
2237 modest_tny_account_new_from_server_account(): Do not create the
2238 send queues here, because they will be
2239 recreated anyway when the connection changes for the first time.
2241 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2243 * src/modest-local-folder-info.h:
2244 * src/modest-local-folder-info.c:
2245 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2246 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2247 tbox_folder): Take a modest account name instead of a server TnyAccount,
2248 so we can have per-modest-account rather than per-transport-account
2250 We must make sure that we change or recreate the exisitng send queues
2251 when the connection changes for connection-specific transport accounts.
2253 * src/modest-tny-account-store.c:
2254 (create_per_account_local_outbox_folders): Create outboxed per modest
2255 account, not per transport account.
2257 * src/modest-tny-account.h:
2258 * src/modest-tny-account.c:
2259 (modest_tny_account_get_special_folder): For outboxes, get the
2260 parent modest account name. The account is ignored for other folders.
2261 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2262 modest account name rather than a server TnyAccount.
2264 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2266 * src/modest-tny-account.c:
2267 (modest_tny_account_new_from_server_account):
2268 Call modest_runtime_get_send_queue() immediately after creating transport
2269 accounts, so that they start trying to send email from the outbox as soon
2270 as possible at startup. This is probably what we want.
2272 * src/modest-mail-operation.c: (update_account_thread):
2273 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2274 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2275 * src/modest-tny-send-queue.h:
2276 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2277 (modest_ui_actions_on_send):
2278 Added comments about how sending works, though it needs some more work.
2280 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2282 * src/modest-tny-account.c:
2283 (modest_tny_account_get_special_folder): Add TODO because this fails when
2284 the network is busy.
2285 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2286 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2287 Do not try to show this window when there is no active account. The UI
2288 specs does not tell us what to do in this case.
2290 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2294 * src/maemo/Makefile.am:
2295 * src/widgets/Makefile.am: Some dist fixes.
2297 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2299 * src/maemo/modest-connection-specific-smtp-window.c:
2300 (on_button_edit): Make the code clearer, to prevent a double free.
2302 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2304 * src/maemo/modest-account-settings-dialog.c:
2305 (modest_account_settings_dialog_set_account_name),
2306 Check the connection-specific smtp servers checkbox if there are any.
2308 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2309 (modest_connection_specific_smtp_edit_window_init):
2310 Start with a suitable port number.
2312 * src/modest-account-mgr-helpers.h:
2313 * src/modest-account-mgr-helpers.c: Added
2314 modest_account_mgr_get_has_connection_specific_smtp().
2316 (modest_account_mgr_set_connection_specific_smtp),
2317 (modest_account_mgr_remove_connection_specific_smtp),
2318 (modest_account_mgr_get_has_connection_specific_smtp),
2319 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2320 connection-specific smtp server accounts in the account, rather than
2321 the server account conf dir.
2323 This fixes bug projects.maemo.org bug NB#58263 .
2325 * src/modest-tny-account-store.c:
2326 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2327 if there are no server accounts yet, to prevent an infinite loop when there
2328 are no accounts. Document that one must be called before the other.
2330 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-account-mgr-helpers.c:
2333 (modest_account_mgr_get_default_account): Make sure that at least
2334 one account is always the default, if there are any enabled accounts.
2335 This is just a sanity check that shouldn't be necessary.
2337 * src/modest-account-mgr-priv.c:
2338 (_modest_account_mgr_account_from_key): Unescape the conf key to
2339 get the real account name. For instance, this is an issue if a space
2340 was in the account name, which can happen because the account name
2341 is generated from the display name.
2342 (_modest_account_mgr_get_account_keyname): Always escape the
2344 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2345 Unescape the conf keys to get the real account names.
2347 For instance, previously the is-default radio button in the accounts
2348 list was not checked for any accounts at first. This fixes that,
2349 and might fix several similar bugs.
2351 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2354 Removed some debug printfs.
2356 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2358 Modest on-disk outbox directories are now here, for instance:
2359 $HOME/.modest/outboxes/<account-id-1>/outbox
2360 $HOME/.modest/outboxes/<account-id-2>/outbox
2362 $HOME/.modest/local-folders/outbox
2363 so we can have a separate outbox for each account.
2364 But they are shown as one outbox in the GtkTreeView, by using a
2365 TnyMergeFolder in a ModestTnySimpleFolderStore.
2368 * src/modest-tny-simple-folder-store.c:
2369 * src/modest-tny-simple-folder-store.h:
2370 Added ModestTnySimpleFolderStore, used to contain folders from
2371 other folder stores, such as other accounts.
2373 * src/modest-tny-outbox-account.h:
2374 * src/modest-tny-outbox-account.c:
2375 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2376 used for the per-account local outbox folders.
2378 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2379 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2380 only use this (internally) now for the non-outbox local folders.
2382 * src/modest-init.h:
2383 * src/modest-init.c: Added modest_init_one_local_folder(), for
2384 setting up the directory structure for each local folder.
2386 * src/modest-local-folder-info.c:
2387 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2388 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2390 * src/modest-local-folder-info.h:
2391 * src/modest-tny-account-store.c: (on_account_removed),
2392 (on_account_changed), (create_per_account_local_outbox_folders),
2393 (get_server_accounts), (modest_tny_account_store_get_accounts),
2394 (modest_tny_account_store_get_tny_account_by_account),
2395 (modest_tny_folder_store_is_virtual_local_folders):
2397 * src/modest-tny-account.h:
2398 * src/modest-tny-account.c:
2399 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2400 to create an on-disk per-account local outbox folder for each
2402 (create_per_account_local_outbox_folders): Create a local outbox folder
2403 for each transport account.
2404 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2405 for all local folders.
2407 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2408 instead of using g_object_get/set() directly. It is clearer.
2410 (modest_tny_folder_store_get_message_count),
2411 (modest_tny_folder_store_get_local_size
2412 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2413 because we now use these with non-acount folder stores.
2415 (modest_tny_account_get_special_folder),
2416 (modest_tny_account_new_from_server_account),
2417 (modest_tny_account_new_from_account):
2418 (recurse_folders): Adjust to the new outbox system.
2420 * src/modest-tny-folder.h:
2421 * src/modest-tny-folder.c:
2422 (modest_tny_folder_is_local_folder),
2423 (modest_tny_folder_get_local_folder_type),
2424 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2426 * src/widgets/modest-main-window.h:
2427 * src/maemo/modest-main-window.c: (create_details_widget),
2428 (modest_main_window_set_contents_style): Show details for any folder store,
2431 (modest_tny_folder_get_rules):
2432 Remove the const. C does not support constness enough for this.
2434 * src/modest-ui-actions.c:
2435 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2436 make all outboxes appear as one, in the usual local-folders tree node.
2438 (set_active_account_from_tny_account),
2439 (modest_ui_actions_on_folder_selection_changed):
2440 * src/widgets/modest-folder-view.c: (text_cell_data),
2441 (icon_cell_data), (filter_row),
2442 (add_account_folders_to_merged_folder),
2443 (add_account_folders_to_simple_folder_store), (),
2444 (get_cmp_rows_type_pos), (cmp_rows),
2445 (modest_folder_view_set_account_id_of_visible_server_account):
2446 Adjust to the new outbox system, using generic folder stores and folders
2447 in the GtkTreeModel.
2449 2007-05-23 Christian Kellner <ckellner@openismus.com>
2451 * src/modest-mail-operation.c:
2452 (modest_mail_operation_update_account):
2453 Use info->max_size instead of unintialized local var [small
2454 build fix]. (Added TODO to review that change since I don't
2457 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2459 * libmodest-dbus-client/libmodest-dbus-client.c:
2460 (libmodest_dbus_client_compose_mail): function added
2461 * src/dbus_api/modest-dbus-api.h:
2462 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2463 (on_compose_mail): Implementation of the SendAsMail functionality
2465 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2467 * src/modest-account-mgr.c:
2468 (modest_account_mgr_add_server_account): Set the secure-connection
2469 conf key for transport accounts as well as store accounts. I don't know
2470 why the if was there. For instance, this makes sure that we use SSL
2471 for the gmail preset from the easysetup wizard.
2473 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2475 * src/gnome/modest-main-window.c:
2476 (on_account_store_connecting_finished), (connect_signals):
2477 * src/maemo/modest-main-window.c:
2478 (on_account_store_connecting_finished), (connect_signals),
2479 (modest_main_window_new):
2480 Handle TnyAccountStore::connecting-finished instead of
2481 TnyDevice::connection-changed, because we cannot actually perform
2482 operations on accounts until TnyAccountStore has itself responded to
2483 the TnyDevice::connection-changed signal. This prevents a GError from
2485 Do not try to update at startup, because we (at least on scratchbox)
2486 already do an update at startup when the device goes online.
2487 This prevents a GError from tinymail.
2488 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2489 Added TODO about stopping simultaneous operations.
2491 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2493 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2494 * src/modest-mail-operation-queue.c:
2495 (modest_mail_operation_queue_remove):
2496 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2497 about where they happened.
2499 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2501 * src/modest-ui-actions.c:
2502 (modest_ui_actions_on_password_requested): Make sure that the remember
2503 output parameter is always TRUE.
2505 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2507 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2508 Show a OK/Cancel dialog if the error is a question, though we still do not
2509 know anything more about what we are asking the user.
2510 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2511 Fix an uninitialized variable (helper). This is a logic error, however.
2513 2007-05-21 Christian Kellner <ckellner@openismus.com>
2515 * src/modest-search.h:
2516 Correct bit shifting in the ModestSearchFlags enum.
2518 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2520 * src/modest-tny-account.c:
2521 (modest_tny_account_new_from_server_account): Do not use the lsub and
2522 check-all hard-coded IMAP options when using POP.
2524 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2526 * src/modest-tny-account.c:
2527 (modest_tny_account_new_from_server_account):
2528 Use NULL for the secure-auth method for POP when Password auth has been
2529 specified by the user, as we already do for IMAP. "auth=Login" causes
2530 an error from camel or the server.
2532 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2534 * src/maemo/modest-account-settings-dialog.c:
2535 (create_page_account_details),
2536 (modest_account_settings_dialog_set_account_name):
2537 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2538 for the leave-on-server checkbox, rathr than just the checkbox, when
2539 the protocol is not POP.
2541 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2543 * src/widgets/modest-account-view.c:
2544 * src/widgets/modest-account-view.h:
2545 Added modest_account_view_select_account() which will be useful later
2546 to asynchronously re-select the edited account.
2548 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2550 * src/maemo/modest-account-settings-dialog.c:
2551 (modest_account_settings_dialog_set_account_name):
2552 Automatically choose the port numbers based on the secure authentication
2553 methods, if they have not been chosen before.
2554 This fixes projects.maemo.org bug NB#56273 .
2556 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/modest-main-window-ui.h:
2559 * src/modest-ui-actions.c:
2560 * src/modest-ui-actions.h:
2561 Connect the Tools/SMTP Servers menu item to
2562 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2563 SMTP servers dialog, as in the UI specification and saves changes when it
2564 is closed. This fixed projects.maemo.org bug NB#56305 .
2566 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2568 * src/maemo/modest-connection-specific-smtp-window.c:
2569 (modest_connection_specific_smtp_window_init):
2570 Use gtk_window_set_default_size() to make this window big enough, so
2571 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2573 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2575 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2576 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2577 (modest_connection_specific_smtp_edit_window_init),
2578 Do not try to connect to a combobox signal before the combobox exists.
2579 This fixes the cras in projects.maemo.org bug NB#56288 .
2580 (modest_connection_specific_smtp_edit_window_get_settings):
2581 Remove the server_account_name parameter which was being checked for NULL
2582 though it was not used.
2584 * src/maemo/modest-connection-specific-smtp-window.c:
2585 (modest_connection_specific_smtp_window_fill_with_connections),
2586 (on_button_edit), (modest_connection_specific_smtp_window_init):
2587 Correct the number of treemodel columns to prevent a warning.
2588 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2589 libconic does not work.
2591 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2593 * src/modest-tny-account.c:
2594 (modest_tny_account_new_from_server_account):
2595 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2596 SMTP when "None" was chosen by the user. However, with my SMTP server that
2597 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2600 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2603 to explain the memory management issue with the ID in the ModestPair.
2605 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2606 (add_sending_page), (modest_account_assistant_finalize):
2607 * src/gnome/modest-gnome-global-settings-dialog.c:
2608 (create_updating_page), (create_composing_page):
2609 * src/gnome/modest-msg-edit-window.c: (get_transports),
2610 (init_window), (modest_msg_edit_window_finalize),
2611 (modest_msg_edit_window_get_msg_data):
2612 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2613 * src/gnome/modest-transport-widget.c:
2614 (modest_transport_widget_finalize), (smtp_configuration):
2615 * src/maemo/modest-maemo-global-settings-dialog.c:
2616 (create_updating_page), (create_composing_page):
2617 * src/maemo/modest-msg-edit-window.c: (get_transports),
2618 (init_window), (modest_msg_edit_window_finalize),
2619 (modest_msg_edit_window_get_msg_data),
2620 (modest_msg_edit_window_free_msg_data):
2621 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2622 (modest_store_widget_finalize):
2623 * src/maemo/modest-transport-widget.c:
2624 (modest_transport_widget_finalize), (smtp_configuration):
2625 * src/modest-main.c: (send_mail):
2626 * src/widgets/modest-combo-box.h:
2627 * src/widgets/modest-global-settings-dialog-priv.h:
2628 * src/widgets/modest-global-settings-dialog.c:
2629 (modest_global_settings_dialog_finalize):
2630 * src/widgets/modest-msg-edit-window.h:
2631 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2632 as long as the combo box, to prevent use of freed memory for the ID.
2634 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2636 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2637 get_accounts(), to make this clearer. Do not check for the enabled gconf
2638 key, because we do not use this for server accounts (at least, not yet).
2639 This allows us to send email again.
2641 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/modest-platform.c:
2644 (on_modest_conf_update_interval_changed), (modest_platform_init):
2645 Only respond to this particular key change. All these strcmp()s cannot be
2648 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2650 * src/maemo/modest-maemo-global-settings-dialog.c:
2651 (current_connection): Prevent a crash in scratchbox when
2652 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2653 * src/maemo/modest-platform.c:
2654 (on_modest_conf_update_interval_changed), (modest_platform_init):
2655 Get the update interval from gconf and reset it when the gconf key changes.
2657 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2659 * src/modest-protocol-info.c:
2660 * src/modest-protocol-info.h: Adde enum-specific get functions,
2661 instead of using a ModestProtocolType enum parameter.
2663 * src/gnome/modest-account-assistant.c:
2664 * src/gnome/modest-store-widget.c:
2665 * src/gnome/modest-store-widget.h:
2666 * src/gnome/modest-transport-widget.c:
2667 * src/gnome/modest-transport-widget.h:
2668 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2669 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2670 * src/maemo/easysetup/modest-easysetup-wizard.c:
2671 * src/maemo/modest-account-settings-dialog.c:
2672 * src/maemo/modest-account-settings-dialog.h:
2673 * src/maemo/modest-store-widget.c:
2674 * src/maemo/modest-store-widget.h:
2675 * src/maemo/modest-transport-widget.c:
2676 * src/maemo/modest-transport-widget.h:
2677 * src/modest-account-mgr-helpers.c:
2678 * src/modest-account-mgr-helpers.h:
2679 * src/modest-account-mgr.c:
2680 * src/modest-account-mgr.h:
2681 * src/modest-tny-account.c:
2682 * src/modest-tny-folder.c:
2683 * src/widgets/modest-account-view.c:
2684 * src/widgets/modest-retrieve-combo-box.c:
2685 * src/widgets/modest-retrieve-combo-box.h:
2686 * src/widgets/modest-secureauth-combo-box.c:
2687 * src/widgets/modest-serversecurity-combo-box.c:
2688 * src/widgets/modest-serversecurity-combo-box.h:
2689 * tests/check_account-mgr.c:
2690 Use the specific functions, and use the re-renamed enum values for GNOME too.
2692 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2694 * src/modest-pair.h:
2695 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2696 so we can get the second based on the first.
2698 * src/maemo/modest-account-settings-dialog.h:
2699 * src/maemo/modest-account-settings-dialog.c:
2700 Added get_supported_secure_authentication_methods(), though it is mostly
2701 commented-out for now until the necessary API is committed to tinymail.
2702 (modest_account_settings_dialog_set_account_name),
2703 (save_configuration): Request the supported authentication methods from the
2704 server, so we can choose a working method.
2706 * src/modest-tny-account-store.h:
2707 * src/modest-tny-account-store.c:
2708 (modest_tny_account_store_get_session): Rename from
2709 tny_account_store_get_session().
2711 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2713 * src/modest-protocol-info.h: Split the ModestProtocol enum
2714 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2715 There was no need to have these unrelated values in one enum.
2717 * src/: many files: Adapted to changed enum. This makes the code a bit
2718 clearer, and the compiler could catch some errors.
2720 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2722 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2723 Show the detailed internal camel error message when an error happens
2724 during the configuration, so that our testers can give us more clues.
2725 For instance, in projects.maemo.org bug NB#56910 .
2727 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2729 * src/modest-tny-account.c:
2730 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2731 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2733 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2735 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2736 * src/maemo/modest-account-settings-dialog.c:
2737 (modest_account_settings_dialog_set_account_name),
2738 (save_configuration): For the incoming secure authentication checkbox,
2739 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2740 the UI specification. PLAIN does not seem to be supported for most IMAP
2741 servers anyway, and I am not sure what it would mean.
2742 However, we probably need to discover which of the secure-authentication
2743 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2744 * src/modest-account-mgr-helpers.c:
2745 (modest_account_mgr_get_server_account_data):
2747 * src/modest-tny-account.c:
2748 (modest_tny_account_new_from_server_account):
2749 Use tny_account_set_mech() to set secure-authentication methods,
2750 with some special-casing for IMAP, based on my observations of how
2753 * src/modest-account-mgr-helpers.h:
2754 * src/modest-account-mgr.c:
2755 * src/modest-defs.h: Comment that the URI is only used for local folders.
2757 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2759 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2760 parameter const, just to be neat.
2761 * src/modest-text-utils.c: (modest_text_utils_inline):
2762 End g_strconcat() with NULL, as its documentation says. This is almost
2763 certainly the cause of my crash at startup on the device. Interestingly,
2764 valgrind doesn't tell us about these errors.
2766 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2768 * scripts/build-packages: Added more precise comments about how to use
2769 this script, though I still get this error:
2770 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2771 error building tinymail
2773 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2775 * src/maemo/modest-main-window.c: (on_account_update):
2776 Very slight cleanup, hoping to make it simpler to discover what causes
2777 a crash here sometimes.
2779 * src/modest-tny-account.c:
2780 (modest_tny_account_new_from_server_account): Set the port. Added
2781 comments about the options and a TODO comment because I need to find out
2782 how to specify the secure authentication method.
2784 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2786 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2787 changed CFlags paths form modest to libmodest
2789 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2791 * src/modest-account-mgr-helpers.c:
2792 (modest_account_mgr_get_server_account_data),
2793 (modest_account_mgr_free_server_account_data):
2794 * src/modest-account-mgr-helpers.h:
2795 * src/modest-account-mgr.c:
2796 (modest_account_mgr_add_server_account):
2797 * src/modest-defs.h:
2798 * src/modest-tny-account.c:
2799 (modest_tny_account_new_from_server_account):
2800 Determine the options for tny_camel_account_add_option() here,
2801 based on the settings, rather than storing them directly in gconf.
2803 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2805 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2806 Show a more friendly error dialog now that we expect (from the tinymail
2807 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2809 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/modest-main-window.c: (on_account_update): Check that
2812 account_name is not NULL, to prevent a crash at startup that I am
2813 seeing on the N800. I do wonder why it is NULL.
2815 * src/maemo/easysetup/modest-easysetup-wizard.c:
2816 (create_page_user_details):
2817 * src/maemo/modest-account-settings-dialog.c:
2818 (create_page_user_details), (create_page_outgoing):
2819 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2820 (modest_connection_specific_smtp_edit_window_init):
2821 * src/modest-ui-actions.c:
2822 (modest_ui_actions_on_password_requested):
2823 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2824 might do something useful with the on-screen keyboard.
2826 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2828 * src/maemo/modest-main-window.c: (on_account_update):
2829 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2830 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2832 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2834 * src/modest-tny-account-store.c: (on_account_changed):
2835 Correct the signature of this signal handler.
2837 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2840 Show a HildonNote instead of a GtkDialog for Maemo.
2842 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2844 * src/widgets/modest-account-view.h:
2845 * src/widgets/modest-account-view.c: (on_account_changed),
2846 (on_account_removed). Added a boolean flag, set/unset by
2847 modest_account_view_block_conf_updates(),
2848 modest_account_view_unblock_conf_updates() to prevent unnecessary
2849 updates, but this is not very useful because the gconf notifications are
2850 so delays (maybe only on Maemo Bora).
2851 So auto-updating is turned off, and these functions do an explicit
2852 update when necessary.
2853 However, something else is still doing too much work when adding/removing
2854 accounts, probably in another part of the application.
2856 * src/maemo/modest-account-view-window.c:
2857 (on_delete_button_clicked), (on_edit_button_clicked),
2858 (on_new_button_clicked): Use the new functions.
2860 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2862 * src/modest-account-mgr-helpers.c:
2863 (modest_account_mgr_set_first_account_as_default):
2864 Sort the list of names alphabetically-by-title, so we choose the first one
2866 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2867 alphabetically by the title.
2869 This fixes projects.maemo.org bug NB#56418 .
2871 * src/modest-account-mgr-priv.c:
2872 (_modest_account_mgr_account_from_key):
2873 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2874 avoid a valgrind error, and possible random behaviour.
2876 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2878 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2879 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2880 tinymail documentation to say that this can be expected.
2881 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2882 pretty, and should not happen, but I would prefer to know when it does.
2884 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2886 * configure.ac: When using the older hildon version, probably on Bora,
2887 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2889 * src/widgets/modest-attachment-view.c:
2890 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2893 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2895 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2896 Implemented the prototype. Can be tested with
2897 tests/dbus_api/test_open_message:
2899 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2901 * src/modest-tny-account-store.c:
2902 (modest_tny_account_store_instance_init), (get_password):
2903 * src/modest-ui-actions.c:
2904 (modest_ui_actions_on_password_requested):
2905 Do not store the password in gconf, because this function is called
2906 for non-remembered passwords. Actually use the cached (in the hash map)
2907 password instead of releasing it.
2908 The password will now not be remembered if it is asked via the protected
2909 password dialog, as per the UI spec.
2911 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2913 * src/modest-defs.h:
2914 * src/modest-account-mgr-helpers.h:
2915 * src/modest-account-mgr-helpers.c:
2916 Added modest_server_account_get_username_has_succeeded(),
2917 modest_server_account_set_username_has_succeeded().
2918 (modest_server_account_set_username),
2919 Reset the has-succeeded flag if the username changes.
2921 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2922 * src/maemo/modest-connection-specific-smtp-window.c:
2923 (modest_connection_specific_smtp_window_save_server_accounts):
2924 Use modest_server_account_set_username() instead of using
2925 modest_conf_set_string() directly, so that the has-succeeded flag is always
2928 * src/modest-ui-actions.c:
2929 (modest_ui_actions_on_password_requested): Dim the username entry if
2930 the username has ever worked, as per the UI spec.
2932 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2934 * src/modest-tny-account-store.c: (get_password):
2935 * src/modest-ui-actions.c:
2936 (modest_ui_actions_on_password_requested):
2937 Allow the username to be changed too, though there is more work to
2938 be done on exactly how this behaves.
2940 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2942 * src/modest-account-mgr-helpers.h:
2943 * src/modest-account-mgr-helpers.c:
2944 Added modest_account_mgr_get_display_name(),
2945 modest_server_account_get_username(),
2946 modest_server_account_set_username(),
2947 modest_server_account_set_password(),
2948 modest_server_account_get_hostname() functions so we do not need to
2949 use the conf API directly.
2951 * src/maemo/modest-main-window.c: (connect_signals):
2952 Actually connect ot the ModestAccountStore::request-password signal,
2953 so that we show the dialog when the password is requested by Tinymail,
2954 for isntance if it is empty.
2956 * src/modest-marshal.list:
2957 * src/modest-tny-account-store.c:
2958 (modest_tny_account_store_class_init), (get_password),
2959 (modest_tny_account_store_alert):
2960 * src/modest-tny-account-store.h:
2961 * src/modest-ui-actions.h:
2962 * src/modest-ui-actions.c:
2963 (modest_ui_actions_on_password_requested):
2964 Change the signal parameters, so it is obvious that we are providing
2965 the non human-readable server name, and receiving both the username
2966 and password, though changing of the username is not yet implemented.
2967 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2968 for the GNOME version.
2970 This should fix the projects.maemo.org bug NB#56209, though it does not
2971 work on Bora, because the gconf_client_get() for the password fails
2972 immediately after we save it with gconf_client_set().
2974 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2977 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2978 caused an undefined symbol error:
2979 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2981 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2983 * src/modest-tny-account-store.c:
2984 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2985 using a GError instead of a string message, so we can translate it in
2988 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2990 * src/maemo/modest-address-book.c:
2991 (modest_address_book_check_names):
2992 * src/maemo/modest-msg-view-window.c:
2993 (modest_msg_view_window_clipboard_owner_change):
2994 * src/modest-init.c: (modest_init_init_ui):
2995 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2996 (update_folders_cb), (modest_mail_operation_update_account):
2997 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2998 (modest_ui_actions_on_msg_attachment_clicked),
2999 (modest_ui_actions_on_msg_recpt_activated):
3000 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3001 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3002 (modest_msg_view_search_next):
3003 * src/widgets/modest-recpt-editor.c:
3004 (modest_recpt_editor_on_button_release_event),
3005 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3006 g_message(). At this point we should only be seeing interesting errors on
3007 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3009 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3011 (modest_wizard_dialog_force_title_update):
3012 * src/maemo/easysetup/modest-wizard-dialog.h:
3013 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3014 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3015 can update the title when appropriate. Otherwise the title is wrong if the
3016 pages are added after adding the notebook to the dialog.
3017 This must be a problem in HildonWizardDialog too.
3018 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3020 * src/maemo/easysetup/modest-easysetup-wizard.c:
3021 (create_subsequent_customsetup_pages),
3022 (create_subsequent_easysetup_pages):
3023 Call modest_wizard_dialog_force_title_update() so that the title is
3024 correct even with GTK+ < 2.10.
3025 This fixes projects.maemo.org bug NB#56145 .
3027 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3029 * src/maemo/modest-platform.c:
3030 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3031 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3034 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3036 * src/widgets/modest-window.h:
3037 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3038 and modest_window_save_state(), which invokes it.
3040 * src/widgets/modest-window-mgr.h:
3041 * src/widgets/modest-window-mgr.c:
3042 Added modest_window_mgr_save_state_for_all_windows(), which calls
3043 the save_state vfunc on all registered windows, if implemented.
3045 * src/gnome/modest-msg-edit-window.c:
3046 * src/gnome/modest-msg-view-window.c:
3047 * src/maemo/modest-msg-edit-window.c:
3048 * src/maemo/modest-msg-view-window.c:
3049 * src/maemo/modest-main-window.c:
3050 Specify the existing save_settings functions as implementations of
3051 ModestWindow::save_state_func().
3053 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3054 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3055 enabling hibernation, for instance.
3057 We may need to do the same thing for restoring settings.
3060 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3062 * src/widgets/modest-window-mgr.c:
3063 * src/widgets/modest-window-mgr.h:
3064 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3065 modest_window_mgr_get_hibernation_is_prevented().
3067 * src/maemo/modest-main-window.c:
3068 (on_hildon_program_is_topmost_notify): Prevent hibernation
3069 (possible when the application goes to the background in the WM),
3070 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3072 * src/maemo/easysetup/modest-easysetup-wizard.c:
3073 (modest_easysetup_wizard_dialog_init):
3074 * src/maemo/modest-account-settings-dialog.c:
3075 (modest_account_settings_dialog_init):
3076 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3077 (modest_connection_specific_smtp_edit_window_init):
3078 * src/maemo/modest-connection-specific-smtp-window.c:
3079 (modest_connection_specific_smtp_window_init):
3080 * src/maemo/modest-signature-editor-dialog.c:
3081 (modest_signature_editor_dialog_init):
3082 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3083 prevent hibernation while any of these account settings dialogs are open.
3085 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3087 * src/maemo/Makefile.am:
3088 * src/maemo/modest-osso-state-saving.c:
3089 * src/maemo/modest-osso-state-saving.h: Added
3090 modest_osso_load_state() and modest_osso_save_state() though they do
3091 nothing now. They should iterate through all the open windows and load/save
3093 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3094 save state when closing.
3096 * src/maemo/modest-main-window.c:
3097 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3098 Add a notification handler for the HildonProgram::is-topmost property,
3099 so we can allow hibernation when the application goes into the background.
3100 But we still need to detect when the accounts setup windows are open so
3101 we can stop hibernation when they are open.
3102 To do this, I also added the main window the HildonProgram. This might have
3103 other side-effects/benefits, and should maybe be done for other windows.
3105 * src/maemo/modest-osso-autosave-callbacks.h:
3106 * src/maemo/modest-osso-autosave-callbacks.c:
3107 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3108 though it does not do anything yet, and we might never need this to do
3109 anything. For instance, we already save drafts.
3111 * src/maemo/modest-platform.c: (modest_platform_init):
3112 Specify the libosso auto-save callback.
3114 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3116 * src/maemo/modest-platform.c:
3117 (modest_platform_set_update_interval):
3118 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3119 aparently stays valid between application instances, so we can use this
3120 to remove and reset it later. According to a maemo-developers email from
3123 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3125 * configure.ac: Depend on libalarm for Maemo.
3127 * src/dbus_api/modest-dbus-api.h:
3128 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3129 (on_send_receive), (modest_dbus_req_handler):
3130 Handle a SEND_RECEIVE D-Bus method.
3132 * libmodest-dbus-client/libmodest-dbus-client.c:
3133 (libmodest_dbus_client_send_and_receive):
3134 * libmodest-dbus-client/libmodest-dbus-client.h:
3135 Add C convenience functions for calling the new D-Bus method.
3137 * src/modest-platform.h:
3138 * src/gnome/modest-platform.c:
3139 * src/maemo/modest-platform.c:
3140 Added modest_platform_set_update_interval(), which uses the
3141 alarmd API on Maemo.
3142 (modest_platform_init),
3143 Call modest_platform_set_update_interval(), using a hard-coded
3144 interval for now (until the global settings dialog is implemented),
3145 though I am not sure that this makes sense yet.
3147 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3149 * src/dbus_api/modest-dbus-callbacks.c:
3150 (modest_osso_cb_hw_state_handler):
3151 * src/dbus_api/modest-dbus-callbacks.h:
3152 * src/maemo/modest-platform.c: (modest_platform_init):
3153 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3154 in case this has some effect on the ability for Maemo to ping the
3157 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3159 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3160 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3161 warning. It is probably a logic error, but I need to fix the build.
3163 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3165 * src/modest-account-mgr.h:
3166 * src/modest-account-mgr.c:
3167 (modest_account_mgr_account_names): Add a gboolean enabled_only
3168 parameter, so we can get lists of onlt the enabled accounts.
3170 (modest_account_mgr_add_account),,
3171 (modest_account_mgr_account_with_display_name_exists):
3172 * src/maemo/modest-msg-edit-window.c: (get_transports):
3173 * src/modest-account-mgr-helpers.c:
3174 (modest_account_mgr_set_first_account_as_default):
3175 * src/modest-init.c: (init_default_account_maybe):
3176 * src/modest-tny-account-store.c: (get_accounts):
3177 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3178 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3179 * tests/check_account-mgr.c: (START_TEST):
3180 Provide the extra parameter, as appropriate.
3182 * src/widgets/modest-account-view.c: (update_account_view):
3183 Do not show disabled accounts (meaning that there is no way to
3184 enable/disable accounts in the UI (the feature is not in our UI
3185 specification), so we can use this internally only to mark unfinished
3186 or temporary account data.
3188 * src/maemo/easysetup/modest-easysetup-wizard.c:
3189 (create_account): Add boolean enable parameter, so we can specify FALSE
3190 to create the temporary account.
3191 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3192 (on_before_next): When finishing, when there is a temporary account, just
3194 Also, use a timeout to delay the showing of the dialog until gconf is likely
3195 to return correct information, due to a maemo gconf bug that is fixed in
3196 osso 1.1, but not yet in Bora.
3197 However, the dialog stays on screen after it is destroyed.
3199 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3200 for invalid data when cancelling. Use a hildon note instead of a dialog
3201 to complain about invalid data. Do not show the account-saved note if the
3202 account is disabled (a temporary account that will not really be saved for use
3205 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3207 * src/modest-account-mgr-helpers.h:
3208 * src/modest-account-mgr-helpers.c:
3209 Added modest_account_mgr_unset_default_account(),
3210 Added modest_account_mgr_set_first_account_as_default().
3212 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3213 If it was the default account, unset the default account name.
3215 * src/maemo/modest-account-view-window.c:
3216 (on_delete_button_clicked): If it was the default account,
3217 set the first remaining account as the default instead.
3219 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3220 a NULL account or a NULL default account, to prevent a crash. This should
3221 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3224 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3226 * src/widgets/modest-recpt-editor.c:
3227 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3228 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3229 TODO comment for this. This fixes the build.
3231 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3232 be the best place for it. This will in future update all auto-update accounts,
3233 rather than just the current/default account, when that gconf key exists.
3234 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3235 if there are no accounts, before calling do_send_receive().
3236 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3238 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3239 * src/maemo/modest-main-window-ui.h:
3240 * src/maemo/modest-main-window.c: (on_connection_changed),
3241 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3242 directly, becaue the signal handler does more.
3244 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3246 * src/modest-account-mgr-helpers.c:
3247 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3248 for the case that the account does not exist.
3250 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3251 (equivalent to the modest account name) rather than the tinymail account name
3252 (equivalent to the modest account title - human readable) to get the account data.
3253 Check for null account data to prevent the crash, and add a TODO comment saying that
3254 this needs fixing because it is using the server account name instead of the account name.
3256 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3258 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3259 * src/maemo/modest-account-settings-dialog.c: (show_error),
3261 Use hildon_note_new_information() for informative and error messages,
3262 which seems to be expected for Maemo applications (no documentation that I know of
3263 says this). I am surprised that there is no distinction between info and error
3266 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3268 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3269 it is easy to find where this is used.
3271 * src/maemo/easysetup/modest-easysetup-wizard.c:
3272 (create_page_welcome), (create_page_account_details),
3273 (create_page_user_details), (create_page_complete_easysetup),
3274 (create_page_custom_incoming), (create_page_custom_outgoing),
3275 (create_page_complete_custom):
3276 * src/maemo/modest-account-settings-dialog.c:
3277 (create_page_account_details), (create_page_user_details),
3278 (create_page_incoming), (create_page_outgoing):
3279 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3280 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3281 (modest_connection_specific_smtp_edit_window_init):
3282 * src/maemo/modest-connection-specific-smtp-window.c:
3283 (modest_connection_specific_smtp_window_init):
3284 * src/maemo/modest-signature-editor-dialog.c:
3285 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3286 and scrolling policy as per the Email Application Layout Guide, if I have
3289 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3291 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3292 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3293 which were empty, because these vfuncs have been removed from TnyAccountStore.
3294 This fixes the build.
3296 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3298 * src/maemo/modest-main-window.c:
3299 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3300 showing/hiding it. Added TODO because it probably should not be NULL.
3301 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3302 because unnecessary g_warnings() make degugging difficult.
3304 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3306 * src/maemo/modest-msg-edit-window.c:
3307 (modest_msg_edit_window_select_color),
3308 (modest_msg_edit_window_select_background_color): 2 const corrections and
3309 moving 2 #endifs before closing brackets, to fix the build.
3311 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3313 * src/maemo/easysetup/modest-easysetup-wizard.h:
3314 * src/maemo/easysetup/modest-easysetup-wizard.c:
3315 (modest_easysetup_wizard_dialog_finalize),
3316 (on_button_edit_advanced_settings), (create_page_complete_custom),
3317 (on_response), (create_account):
3318 Implement the Advanced Settings edit button, by saving the account information,
3319 for the Advanded Settings dialog to use directly from gconf, and removing it
3320 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3321 Bug #5533 in the projects.maemo.org bugzilla.
3323 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3325 * src/maemo/modest-msg-view-window.c:
3326 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3327 when opening a message window.
3329 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3331 * src/maemo/easysetup/modest-easysetup-wizard.c:
3332 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3335 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3336 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3337 gconf settings. I probably added more checks than necessary, but that is safer.
3339 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3340 variable to fix the build, but this seems to be used when it is still NULL.
3342 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3344 * src/modest-platform.h:
3345 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3346 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3347 * src/modest-main.c: Implement this function so we can avoid using
3348 maemo-specific API from cross-platform code.
3350 * src/modest-tny-account-store.c:
3351 (get_smtp_specific_transport_account_for_open_connection):
3352 * src/modest-ui-actions.c: (check_for_connection),
3353 (modest_ui_actions_on_item_not_found):
3354 Use modest_platform_connect_and_wait() and put #idefs around other
3355 maemo-specific code, because only maemo currently has a way to
3356 identify connection names.
3358 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3360 * src/modest-tny-account-store.h:
3361 * src/modest-tny-account-store.c:
3362 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3363 the connection-specific SMTP server settings in the configuration.
3365 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3367 * src/maemo/modest-main-window.c: (on_connection_changed),
3369 * src/modest-main.c: (main), (start_ui), (send_mail):
3370 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3371 that is what is intended.
3373 * src/modest-ui-actions.c: (action_send), (action_receive),
3374 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3375 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3376 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3377 SMTP server is used when it is specified.
3379 (modest_ui_actions_on_send_receive):
3380 Check that a connection is open before proceeding.
3381 Receive and then send, instead of vice-versa, as per the specification.
3383 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-mail-operation.c:
3386 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3387 though I guess it should be something other than NULL.
3389 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3391 * src/maemo/easysetup/modest-easysetup-wizard.c:
3392 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3393 combo twice, to avoid an g_warning and to make it visible again.
3394 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3395 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3396 (already intended) dereference when detaching, because we then recreate the menu.
3397 But I am not sure why the warning was happening, and it is possible that this is a memory
3400 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3402 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3403 and uri_parse_mailto() utility functions.
3404 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3406 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3408 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3410 * src/dbus_api/modest-dbus-api.h:
3411 * src/dbus_api/modest-dbus-callbacks.c:
3412 Use an idle callback to execute the modest code in the application's own thread.
3413 Remove the helloworld example method.
3414 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3415 parsed, and the open-message method is not implemented because this is not yet implemented in
3417 * libmodest-dbus-client/libmodest-dbus-client.c:
3418 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3419 (libmodest_dbus_client_open_message):
3420 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3422 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3423 body without crashing.
3425 * tests/dbus_api/Makefile.am:
3426 * tests/dbus_api/test_mail_to.c:
3427 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3429 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3431 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3432 Added file to fix the build. Sorry.
3434 * src/dbus_api/Makefile.am:
3435 * src/dbus_api/modest-dbus-api.h:
3436 * src/dbus_api/modest-dbus-callbacks.h:
3437 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3438 (modest_dbus_req_handler):
3439 Put constants in a separate header so it can be reused by the
3440 client library, without duplication
3442 * libmodest-dbus-client/Makefile.am:
3443 * libmodest-dbus-client/libmodest-dbus-client.c:
3444 (libmodest_dbus_client_call_helloworld),
3445 (libmodfest_dbus_client_send_mail),
3446 (libmodfest_dbus_client_mailto),
3447 (libmodfest_dbus_client_open_message):
3448 * libmodest-dbus-client/libmodest-dbus-client.h:
3449 (Partly) Implement a send_mail D-Bus method.
3451 * tests/dbus_api/Makefile.am:
3452 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3453 the send_email D-Bus method.
3455 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3459 * libmodest-dbus-client/Makefile.am:
3460 * libmodest-dbus-client/libmodest-dbus-client.c:
3461 * libmodest-dbus-client/libmodest-dbus-client.h:
3462 * tests/dbus_api/Makefile.am:
3463 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3464 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3466 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3468 * src/maemo/easysetup/modest-easysetup-wizard.c:
3469 (create_page_account_details):
3470 * src/maemo/modest-account-settings-dialog.c:
3471 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3472 widgets, because this might not be the default in future versions of the Maemo GTK+.
3473 However, I can not not get capitalization to work even in a simple test case.
3475 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3477 * src/maemo/easysetup/modest-easysetup-wizard.c:
3478 (create_page_custom_incoming), (create_page_custom_outgoing):
3479 * src/maemo/modest-account-settings-dialog.c:
3480 (create_page_account_details), (create_page_incoming),
3481 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3482 instead of using gtk_check_button_with_label(), so they are aligned like the other
3483 widgets, as per the UI spec.
3485 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/easysetup/modest-easysetup-wizard.c:
3488 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3489 * src/widgets/modest-validating-entry.c:
3490 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3491 Modest prefix instead of an EasySetup prefix.
3493 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3495 * src/widgets/modest-validating-entry.h:
3496 * src/widgets/modest-validating-entry.c: (on_insert_text),
3497 Added easysetup_validating_entry_set_max_func(), used to set a callback
3498 to call when the max number of characters is reached. GtkEntry has a max-length
3499 already but is silent about it.
3501 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3502 (create_page_account_details), (create_page_user_details),
3504 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3505 (create_page_account_details), (create_page_user_details),
3506 (create_page_outgoing):
3507 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3508 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3509 the UI spec, when the user tries to enter more than the max number of characters.
3511 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3513 * src/maemo/easysetup/modest-easysetup-wizard.c:
3514 (create_page_user_details), (create_page_custom_incoming),
3515 (create_page_custom_outgoing):
3516 * src/maemo/modest-account-settings-dialog.c:
3517 (create_page_user_details), (create_page_incoming),
3518 (create_page_outgoing):
3519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3520 (modest_connection_specific_smtp_edit_window_init):
3521 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3522 not appropriate. Bad Maemo-specific defaults!.
3524 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3527 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3528 (modest_signature_editor_dialog_set_settings):
3529 Disable the label and textview when the checkbox is disabled, and use the
3530 specified (UI spec) default signature text.
3532 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3535 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3537 * src/modest-defs.h:
3538 * src/modest-account-mgr-helpers.h:
3539 * src/modest-account-mgr-helpers.c:
3540 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3542 * src/maemo/Makefile.am:
3543 * src/maemo/modest-signature-editor-dialog.c:
3544 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3547 * src/maemo/modest-account-settings-dialog.h:
3548 * src/maemo/modest-account-settings-dialog.c:
3549 (modest_account_settings_dialog_finalize), (on_button_signature),
3550 (save_configuration): Use the new dialog when the Edit button is pressed, and
3551 save the changes if necessary, as per the UI spec.
3553 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3555 * src/maemo/Makefile.am:
3556 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3557 based on maemo-develoers email from Dirk.
3559 * src/maemo/easysetup/modest-easysetup-wizard.c:
3560 (create_page_welcome), (create_page_account_details),
3561 (create_page_user_details), (create_page_complete_easysetup),
3562 (create_page_custom_incoming), (create_page_custom_outgoing),
3563 (create_page_complete_custom),
3564 (modest_easysetup_wizard_dialog_init):
3565 * src/maemo/modest-account-settings-dialog.c:
3566 (create_page_account_details), (create_page_user_details),
3567 (create_page_incoming), (create_page_outgoing),
3568 (modest_account_settings_dialog_init):
3569 * src/maemo/modest-connection-specific-smtp-window.c:
3570 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3572 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3574 * src/maemo/easysetup/modest-easysetup-wizard.c:
3575 (create_page_account_details), (create_page_custom_outgoing),
3576 (create_page_complete_custom):
3577 * src/maemo/modest-account-settings-dialog.c:
3578 (create_page_user_details), (create_page_incoming),
3579 (create_page_outgoing):
3580 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3581 (modest_connection_specific_smtp_edit_window_init):
3582 Use the correct (UI spec) port min/max, and use horizontal separators,
3585 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3587 * src/maemo/easysetup/modest-easysetup-wizard.c:
3588 (set_default_custom_servernames):
3589 * src/maemo/modest-account-settings-dialog.c:
3590 (create_page_incoming), (on_combo_outgoing_security_changed),
3591 (on_combo_incoming_security_changed), (create_page_outgoing),
3592 (modest_account_settings_dialog_set_account_name),
3593 (save_configuration):
3594 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3595 (on_combo_security_changed),
3596 (modest_connection_specific_smtp_edit_window_init),
3597 (modest_connection_specific_smtp_edit_window_set_connection),
3598 (modest_connection_specific_smtp_edit_window_get_settings):
3599 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3602 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3605 * src/maemo/easysetup/modest-easysetup-wizard.c:
3606 (create_page_custom_outgoing), (create_page_complete_custom):
3607 * src/maemo/modest-account-settings-dialog.c:
3608 (create_page_user_details), (create_page_outgoing):
3609 * src/maemo/modest-account-view-window.c: (button_box_new):
3610 Use changed logical IDs as per the most recent UI spec:
3611 mcen_bd_emailsetup_edit -> mcen_bd_edit
3612 mcen_bd_emailsetup_delete -> mcen_bd_delete
3613 mcen_bd_emailsetup_close -> mcen_bd_close
3615 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3619 * src/dbus_api/Makefile.am:
3620 * src/dbus_api/modest-dbus-callbacks.c:
3621 * src/dbus_api/modest-dbus-callbacks.h:
3622 * src/maemo/modest-platform.c: (modest_platform_init):
3623 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3625 * tests/Makefile.am:
3626 * tests/dbus_api/Makefile.am:
3627 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3629 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3631 * src/maemo/modest-account-settings-dialog.c:
3632 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3633 Removed unnecessary includes.
3635 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3637 * src/maemo/easysetup/modest-easysetup-wizard.c:
3638 * src/maemo/modest-account-settings-dialog.c:
3639 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3640 * src/widgets/Makefile.am:
3641 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3642 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3643 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3644 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3645 * src/widgets/modest-secureauth-combo-box.c:
3646 * src/widgets/modest-secureauth-combo-box.h:
3647 * src/widgets/modest-serversecurity-combo-box.c:
3648 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3649 made the GObject names more consistent with the rest of the Modest code.
3651 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3653 * src/maemo/easysetup/Makefile.am:
3654 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3655 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3656 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3657 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3658 * src/maemo/easysetup/modest-easysetup-wizard.c:
3659 * src/maemo/easysetup/modest-validating-entry.c:
3660 * src/maemo/easysetup/modest-validating-entry.h:
3661 * src/maemo/modest-account-settings-dialog.c:
3662 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3663 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3664 widgets/ because they are used outside of easysetup too. After checking in,
3665 svn will allow me to rename them too.
3667 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3669 * src/gnome/modest-msg-edit-window.c:
3670 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3671 linker error, to fix the build on the GNOME platform.
3672 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3673 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3674 ifdefed out to avoid a warning.
3676 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3678 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3679 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3680 some alternative for GTK+ 2.6.
3682 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3684 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3686 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3687 specified for EmailAccountsDialog in UI spec.
3689 * src/maemo/easysetup/modest-easysetup-wizard.c:
3690 * src/maemo/easysetup/modest-easysetup-wizard.h:
3691 * src/maemo/modest-account-settings-dialog.c:
3692 * src/maemo/modest-account-settings-dialog.h:
3693 Reuse a member window widget for the connection-specific SMTP server accounts,
3694 so we can tell it to create/save the accounts only if we actually save changes.
3696 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3697 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3698 (modest_connection_specific_smtp_edit_window_get_settings):
3699 Return a struct instance for temporarily remembering the entered data.
3701 * src/maemo/modest-connection-specific-smtp-window.h:
3702 * src/maemo/modest-connection-specific-smtp-window.c:
3703 (modest_connection_specific_smtp_window_finalize),
3704 (modest_connection_specific_smtp_window_fill_with_connections),
3706 (modest_connection_specific_smtp_window_save_server_accounts),
3707 (update_model_server_names): Do not actually save data until asked,
3708 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3710 (on_selection_changed),
3711 (modest_connection_specific_smtp_window_init): Disable the edit
3712 button when nothing is selected.
3714 * src/modest-account-mgr-helpers.c:
3715 * src/modest-account-mgr-helpers.h:
3716 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3719 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3721 * src/modest-account-mgr-helpers.h:
3722 * src/modest-account-mgr-helpers.c:
3723 (modest_account_mgr_get_unused_account_name),
3724 (modest_account_mgr_get_unused_account_display_name): Added these
3725 utility functions, to avoid code duplication.
3727 * src/maemo/easysetup/modest-easysetup-wizard.c:
3728 (create_page_account_details), (create_account):
3729 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3730 (on_combo_security_changed),
3731 (modest_connection_specific_smtp_edit_window_init),
3732 (modest_connection_specific_smtp_edit_window_save_settings):
3733 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3734 * src/maemo/modest-connection-specific-smtp-window.c:
3735 (modest_connection_specific_smtp_window_finalize),
3736 (modest_connection_specific_smtp_window_fill_with_connections),
3737 (on_button_edit), (modest_connection_specific_smtp_window_init):
3738 * src/maemo/modest-connection-specific-smtp-window.h:
3739 Implementing saving of connection-specific server accounts.
3741 But I need to refactor this so we can save the data for each
3742 possible connection-specific account and only actually create the server accounts
3743 when the easysetup finished, or the OK button is pressed on the account settings
3746 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3749 (on_combo_security_changed):
3750 (modest_connection_specific_smtp_edit_window_init):
3751 Auto-fill the port number as in the account settings.
3753 (modest_connection_specific_smtp_edit_window_set_connection):
3754 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3755 * src/maemo/modest-connection-specific-smtp-window.c:
3756 (fill_with_connections), (on_button_edit),
3757 (modest_connection_specific_smtp_window_init):
3758 Turn the edit window into a dialog to simplify the code, and
3759 set a WM hint as in a GtkDialog, because only a popup can be on top of
3760 another window in Maemo, and popups usually have no WM decoration.
3762 * src/modest-defs.h:
3763 * src/modest-account-mgr-helpers.c:
3764 (modest_account_mgr_set_connection_specific_smtp),
3765 (modest_account_mgr_remove_connection_specific_smtp),
3766 (modest_account_mgr_get_connection_specific_smtp):
3767 * src/modest-account-mgr-helpers.h: Some functions to write the
3768 connection-specific SMTP server information. Not yet used.
3771 * src/widgets/modest-folder-view.c: (text_cell_data):
3772 Fix a warning about an uninitialized variable.
3773 (on_configuration_key_changed): Put an #ifdef around the use
3774 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3776 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3778 * src/maemo/modest-account-settings-dialog.h:
3779 * src/maemo/modest-account-settings-dialog.c:
3780 Added connect_for_modified() utility function to mark the new modified boolean.
3782 (create_page_account_details), (create_page_user_details),
3783 (create_page_incoming), (create_page_outgoing), (on_response),
3784 (modest_account_settings_dialog_init),
3785 (modest_account_settings_dialog_set_account_name):
3786 Only warn about unsaved changes when there are actually unsaved changes.
3788 * src/modest-account-mgr-helpers.c:
3789 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3790 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3791 to get the data from there in future.
3793 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3795 * src/modest-defs.h:
3797 * src/modest-account-mgr-helpers.h:
3798 * src/modest-account-mgr-helpers.c:
3799 Store the security account setting in a single conf key instead of using
3800 the options list, so that the list is left for just the to-be-removed camel hack,
3801 and because gconf_client_set_list() is failing for some reason.
3803 * src/modest-account-mgr.c:
3804 (modest_account_mgr_add_server_account):
3805 * src/maemo/modest-account-settings-dialog.c:
3806 (modest_account_settings_dialog_set_account_name),
3807 (save_configuration): Use the renamed functions.
3810 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3812 * src/widgets/Makefile.am:
3813 * src/widgets/modest-limit-retrieve-combo-box.c:
3814 * src/widgets/modest-limit-retrieve-combo-box.h:
3815 * src/widgets/modest-retrieve-combo-box.c:
3816 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3817 the account settings dialog.
3819 * src/modest-defs.h:
3820 * src/modest-account-mgr-helpers.h:
3821 * src/modest-account-mgr-helpers.c:
3822 (modest_server_account_get_option_secure_auth),
3823 (modest_server_account_set_option_secure_auth):
3824 * src/modest-account-mgr.c:
3825 (modest_account_mgr_add_server_account):
3826 Use the existing AUTH_MECH conf key for the secure-auth setting,
3827 instead of putting it in the list options, because this was actually used already.
3829 * src/maemo/modest-account-settings-dialog.c:
3830 (create_page_account_details),
3831 (modest_account_settings_dialog_set_account_name),
3832 (save_configuration):
3833 * src/maemo/modest-account-settings-dialog.h:
3834 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3835 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3837 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3839 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3840 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3841 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3843 * src/modest-defs.h:
3844 * src/maemo/modest-account-settings-dialog.c:
3845 (create_page_incoming), (on_combo_outgoing_security_changed),
3846 (on_combo_incoming_security_changed), (create_page_outgoing),
3847 (modest_account_settings_dialog_set_account_name),
3848 (save_configuration): Load/Save the port number, and change it when the
3849 security combo changes, to suitable defaults.
3851 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3853 * src/modest-account-mgr.c:
3854 (modest_account_mgr_add_server_account): Set the security and secure-auth
3855 options, and add a comment saying that the other camel-specific options should be
3858 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3860 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3862 * src/modest-tny-account-store.c: (account_list_free),
3863 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3864 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3867 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3869 * src/modest-protocol-info.c:
3870 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3871 is required by our UI spec. Maybe something in our implementation will use this eventually.
3872 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3873 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3874 instead of the previous 0 placeholder.
3876 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3877 secure-auth settings.
3878 * src/modest-account-mgr-helpers.h:
3879 * src/modest-account-mgr-helpers.c:
3880 (modest_server_account_data_get_option_secure_auth),
3881 (modest_server_account_set_option_secure_auth),
3882 (modest_server_account_data_get_option_security),
3883 (modest_server_account_set_option_security): Added this API for getting and setting the security
3884 and secure-auth settings.
3886 * src/maemo/modest-account-settings-dialog.h:
3887 * src/maemo/modest-account-settings-dialog.c:
3888 (modest_account_settings_dialog_finalize), (check_data),
3889 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3890 about changing titles.
3891 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3892 (save_configuration): Save the security and secure-auth settings.
3894 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3895 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3897 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3899 * src/modest-defs.h:
3900 * src/modest-account-mgr.c:
3901 (modest_account_mgr_add_server_account):
3902 Added and used defines for the options key and value pair strings,
3903 that are used so far, though they do not seem to correspond to anything in our
3904 UI specs or ModestProtocol enum.
3906 * src/modest-account-mgr-helpers.h:
3907 * src/modest-account-mgr-helpers.c:
3908 (compare_option_strings_for_name),
3909 (modest_server_account_data_get_option_value),
3910 (modest_server_account_data_get_option_bool),
3911 (modest_account_mgr_get_server_account_option):
3912 Added helper functions for parsing the options GSList.
3914 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3916 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3917 display name is based on the supplied account name.
3918 * src/modest-account-mgr.c:
3919 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3920 with an inefficient, but good-enough, implementation.
3922 * src/maemo/easysetup/modest-easysetup-wizard.c:
3923 (create_page_account_details), (on_before_next), (create_account):
3924 Check for existing display names rather than (non-user-visible) account names, and just
3925 create and set a unique account name at the end.
3927 * src/maemo/modest-account-settings-dialog.c:
3928 (modest_account_settings_dialog_init),
3929 (modest_account_settings_dialog_set_account_name),
3930 (create_page_incoming): Show the display name, instead of the account name.
3931 (on_response): Do some (not all) extra checks, as in the UI spec.
3932 (save_configuration): Save the display name if it was changed.
3934 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3936 * po/en_GB.po: Added needed logical ID and translation.
3937 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3938 (init_view): Made the is-default column clicking work.
3940 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3943 * src/maemo/easysetup/Makefile.am:
3944 * src/maemo/easysetup/modest-easysetup-wizard.c:
3945 (modest_easysetup_wizard_dialog_init):
3946 * src/maemo/easysetup/provider-data-test.keyfile:
3947 * src/maemo/easysetup/provider-data.keyfile:
3948 Moved the provider data file to the new modest-providers-data package and used it from there.
3950 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3952 * src/modest-local-folder-info.c:
3953 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3954 N_() was already used on the static strings, but this just marks it for translation without
3955 using the translation.
3957 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3959 * src/maemo/modest-account-settings-dialog.c:
3960 (create_page_incoming),
3961 (modest_account_settings_dialog_set_account_name):
3962 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3963 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3964 I will do this if nobody else gets there first.
3966 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3968 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3969 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3970 save the security stuff.
3972 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3974 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3975 Set the email address and user fullname, which I now see must be
3978 * src/maemo/modest-account-settings-dialog.h:
3979 * src/maemo/modest-account-settings-dialog.c:
3981 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3982 leave-on-server and authentication.
3983 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3986 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3989 * src/maemo/modest-account-settings-dialog.c:
3990 * src/maemo/modest-account-settings-dialog.h:
3991 Most (but not all) of the widgets are now present as specified by the UI spec.
3992 No changes are yet saved, and some details are not properly shown yet.
3994 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3996 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3998 * src/maemo/Makefile.am:
3999 * src/maemo/modest-account-settings-dialog.c:
4000 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4001 an existing account. Doesn't do much yet.
4003 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4004 Open the accounts settings dialog when Edit is clicked.
4006 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4008 * src/maemo/easysetup/Makefile.am:
4009 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4011 * src/maemo/easysetup/modest-easysetup-wizard.c:
4012 (modest_easysetup_wizard_dialog_init):
4013 Try to get the source directory from the build system,
4014 instead of hard-coding "./" into the source code, when opening our local
4015 copies of the configuration files.
4016 But this still fails when opening the wizard from the Accounts window,
4017 maybe because the working directory seems to change at runtime.
4018 So the wizard will fail the second time unless you copy the files into their
4019 proper locations - see the stdout warnings for the paths.
4021 (create_page_account_details),(on_before_next):
4022 Check for existing non-server accounts instead of server accounts,
4023 so the default account name is useful again, and to prevent trying to
4026 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4027 Show the wizard when New is clicked.
4029 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4030 (init_view): Show the column headers, and show the columns that are
4031 specified in the UI specs. However, something in Maemo's GTK+ prevents
4032 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4033 change the default account. This is despite unsetting the special properties.
4035 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4037 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4038 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4039 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4040 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4041 to make that clearer.
4042 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4044 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4046 * src/maemo/modest-account-view-window.c:
4047 (modest_account_view_window_init),
4048 (modest_account_view_window_new):
4049 Use the same buttons as specified in the
4050 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4051 the existing widgets, which never had a chance of working.
4052 Put the ModestAccountView treeview in a scrolled window.
4053 Do not repeat the initialization in both _init() and _new().
4055 * src/widgets/modest-account-view.c: (update_account_view):
4056 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4057 this widget and window shows no accounts.
4059 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4061 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4063 * src/maemo/easysetup/modest-easysetup-wizard.c:
4064 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4065 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4066 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4069 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4070 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4071 accounts exist yet, as in the UI spec.
4073 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4075 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4077 * src/maemo/Makefile.am:
4078 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4079 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4080 New window for editing connection-specific smtp details.
4081 Not fully implemented.
4083 * src/maemo/modest-connection-specific-smtp-window.c:
4084 (modest_connection_specific_smtp_window_finalize) :
4085 unref the tree model.
4086 (on_button_edit): Show the edit window.
4088 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4090 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4093 * src/maemo/Makefile.am:
4094 * src/maemo/modest-connection-specific-smtp-window.c:
4095 * src/maemo/modest-connection-specific-smtp-window.h:
4096 New window for showing the list of connections, for connection-specific
4097 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4098 * src/maemo/easysetup/modest-easysetup-wizard.c:
4099 (create_page_custom_outgoing): Show the new window when the button is clicked.
4101 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4103 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4104 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4105 * src/maemo/modest-msg-edit-window.c:
4106 (modest_msg_edit_window_insert_image):
4107 * src/modest-conf.c: (modest_conf_key_escape):
4108 * src/modest-mail-operation.c:
4109 (modest_mail_operation_send_new_mail):
4110 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4111 (modest_ui_actions_on_new_account):
4112 * src/widgets/modest-attachment-view.c: (update_filename_request):
4113 * src/widgets/modest-mail-header-view.c:
4114 Corrected warnings that were breaking the build, by commenting out unused variables,
4115 and a function, and by including a header.
4117 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4119 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4120 so we can #ifdef around platform-specific code when necessary.
4121 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4122 to allow this to build for the GNOME platform too.
4124 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4126 * src/maemo/easysetup/modest-easysetup-wizard.c:
4127 Added util_increment_name() and used it in create_page_account_details()
4128 to make sure that the default account name is always a new name.
4130 (modest_easysetup_wizard_dialog_init),
4131 (set_default_custom_servernames): Some minor memory management fixes.
4133 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4137 * src/modest-runtime.c: (init_i18n): Restored the translation
4138 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4139 are defined in config.h, and the translations are installed.
4141 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4142 is defined for translation.
4144 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4146 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4148 * src/maemo/easysetup/modest-easysetup-wizard.c:
4149 (modest_easysetup_wizard_dialog_init):
4150 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4151 Use realistic paths (though they should use $prefix generically) to the
4152 mcc_mapping and provider-data.keyfile files which might work when they
4153 are installed by the future version of the operator-wizard package,
4154 and then fallback to paths in our source code, with an explanatory
4157 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4161 * src/maemo/Makefile.am:
4162 * src/maemo/easysetup/: Added files from the previously-exernal
4163 osso-modest-easysetup.
4164 * src/maemo/modest-main-window-ui.h:
4165 * src/modest-ui-actions.c:
4166 * src/modest-ui-actions.h:
4167 Added modest_ui_actions_on_new_account() as a signal handler for the
4168 New Account menu item. It shows the easysetup wizard.
4169 * po/en_GB.po: Added additional needed logical IDs and translations.