1 2007-07-26 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
4 printf more details when we get unhandled D-Bus methods, because
7 * src/modest-mail-operation.c: (update_account_thread):
8 Comment out the tny_camel_pop_store_account_reconnect(), because this
9 is apparently no longer needed, and it did not work before anyway.
10 See the comment in the code.
12 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
13 by checking the header flags.
15 2007-07-25 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-maemo-utils.h:
18 * src/maemo/modest-maemo-utils.c: Added
19 modest_maemo_show_information_note_in_main_context_and_forget().
20 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
21 Use the new function to show simple error dialogs in the main
22 context, though question dialogs are still in the current context,
23 which is unfortunately usually not the main context. This should
26 2007-07-25 Murray Cumming <murrayc@murrayc.com>
28 * src/modest-tny-account-store.c: (get_password):
29 Never save the entered username and password in gconf,
30 because the UI spec says we should not. This helps
31 slightly with projects.maemo.org bug NB#63671.
33 2007-07-25 Murray Cumming <murrayc@murrayc.com>
35 * src/widgets/modest-msg-edit-window.h:
36 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
37 Moved some code here to make it simpler.
38 (modest_msg_edit_window_attach_file_one): Renamed from
39 modest_msg_edit_window_attach_file_interactive().
40 (modest_msg_edit_window_offer_attach_file): Renamed from
41 modest_msg_edit_window_attach_file() and used
42 modest_msg_edit_window_attach_file_one() instead of
43 copy/pasting the code. The old code for one was not using
44 GnomeVFS. This allows use of smb:// URLs when using send-as
45 from external applications, fixing bug NB#63741.
47 (modest_msg_edit_window_insert_image),
48 (modest_msg_edit_window_add_attachment_clicked):
49 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
50 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
51 Adapted to the new function names.
53 2007-07-25 Murray Cumming <murrayc@murrayc.com>
55 (modest_platform_set_update_interval): Set the alarm recurrence
56 fields so that auto-update does not just happen the first time.
57 This should have fixed projects.maemo.org bug NB#63938.
59 When this happens you can see a printf when the D-Bus method is
61 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
63 However, I do not actually seem to get new POP messages even when
64 clicking the refresh button manually. A restart gets them.
65 This might be a problem in today's tinymail only.
67 2007-07-24 Murray Cumming <murrayc@murrayc.com>
69 * src/maemo/modest-maemo-global-settings-dialog.c:
71 Avoid a crash (probably only in scratchbox) when strcmp()ing a
72 NULL when closing the dialog.
74 2007-07-24 Murray Cumming <murrayc@murrayc.com>
76 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
77 Remove the hacky send/receive that didn't work, and instead
78 refilter the treemodel to make the deleted email really vanish from
79 the UI (though the delete-from-menu code does has commented out
80 the code that does that). This fixes projects.maemo.org bug
83 2007-07-24 Murray Cumming <murrayc@murrayc.com>
85 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
86 Try a couple of tricks to force the treeview to update (
87 poke the folder, and do a send/receive refresh), but the deleted
88 email still appears with a strike-through instead of really being
91 2007-07-23 Murray Cumming <murrayc@murrayc.com>
93 * src/dbus_api/modest-dbus-callbacks.c:
94 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
95 because their ID is not human-readable (see the comment about
96 improvements needed to the osso-email-interface API) and
97 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
99 2007-07-23 Murray Cumming <murrayc@murrayc.com>
101 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
102 (add_folders_to_list), (on_dbus_method_get_folders),
103 (modest_dbus_req_filter):
104 * src/maemo/modest-maemo-utils.c:
105 (on_camel_account_get_supported_secure_authentication):
106 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
107 (on_header_view_focus_in):
108 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
109 * src/modest-formatter.c: (modest_formatter_create_body_part):
110 * src/modest-mail-operation.c: (recurse_folders),
111 (update_account_thread), (get_msgs_full_thread),
112 (modest_mail_operation_get_msgs_full),
113 (modest_mail_operation_xfer_msgs):
114 * src/modest-search.c: (search_mime_part_and_child_parts),
115 (modest_search_account), (modest_search_all_accounts):
116 * src/modest-tny-account.c:
117 (modest_tny_account_get_special_folder), (recurse_folders):
118 * src/modest-tny-local-folders-account.c:
119 (modest_tny_local_folders_account_query_passes):
120 * src/modest-tny-msg.c: (copy_mime_part),
121 (modest_tny_msg_find_body_part_from_mime_part):
122 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
123 (modest_tny_send_queue_try_to_send):
124 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
125 (_modest_ui_actions_open), (download_uncached_messages),
126 (reply_forward), (modest_ui_actions_on_copy),
127 (modest_ui_actions_on_details), (has_retrieved_msgs),
128 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
130 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
131 (_selected_msg_marked_as), (_msg_download_completed),
132 (_selected_msg_sent_in_progress):
133 * src/widgets/modest-attachments-view.c:
134 (modest_attachments_view_set_message):
135 * src/widgets/modest-msg-view.c: (find_cid_image):
136 * tests/check_folder-transfer.c: (find_folders):
137 * tests/check_update-account.c: (func):
138 * tests/dbus_api/test_get_folders.c: (main):
139 Checked all uses of tny_iterator_get_current(), making sure
140 that the object is unreferenced (3 or 4 places did not),
141 and adding checks for NULL.
143 2007-07-23 Murray Cumming <murrayc@murrayc.com>
145 * src/dbus_api/modest-dbus-callbacks.c:
146 (on_idle_open_default_inbox): Make sure that the application UI is
148 * src/maemo/easysetup/modest-easysetup-wizard.c:
149 (on_entry_invalid_character): Show the word whitespace instead
150 of (null) in the banner when whitespace was entered.
151 (show_error): Add a comment that this does not work in
152 Maemo Bora, though we do not know why.
154 2007-07-23 Murray Cumming <murrayc@murrayc.com>
156 * src/modest-tny-account.c:
157 (modest_tny_account_get_special_folder): Use an if instead of
158 an assert for when the parent account name is NULL, because this
159 might be causing a crash in projects.maemo.org bug 63192.
160 * src/modest-mail-operation.c:
161 (modest_mail_operation_send_new_mail_cb),
162 (modest_mail_operation_remove_folder): unref the folder that is
163 returned from modest_tny_account_get_special_folder().
165 2007-07-23 Murray Cumming <murrayc@murrayc.com>
167 * src/modest-ui-actions.c:
168 (modest_ui_actions_on_password_requested):
169 Show mail_ib_login_cancelled info banner when the user cancels
170 the protected password dialog, to fix projects.maemo.org
173 2007-07-23 Murray Cumming <murrayc@murrayc.com>
175 * src/maemo/modest-account-settings-dialog.c:
176 (create_page_outgoing): Put this page in a GtkScrolledWindow,
177 matching the UI mock-up in the UI spec, and allowing access
178 to all widgets even when the on-screen keyboard is active.
180 2007-07-23 Murray Cumming <murrayc@murrayc.com>
182 Reverted this previous commit from Johannes,
183 because the scrollbars are always visible and because
184 I think we only need it on onepage of the account
185 settings, not the account wizard.
186 (I wrote the wrong instructions in the bug.)
188 * src/maemo/easysetup/modest-easysetup-wizard.c:
189 Added scrollbars to account wizard dialog.
190 Fixed projects.maemo.org NB #62744
192 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
194 * src/maemo/easysetup/modest-easysetup-wizard.c:
195 (create_page_user_details):
196 Use auto-cap for name (projects.maemo.org NB#63716)
197 * src/widgets/modest-account-view.c: (on_account_busy_changed):
199 2007-07-22 Armin Burgmeier <armin@openismus.com>
201 * src/maemo/modest-ui-actions.c: Use current account instead of
202 default account for creating viewer windows, so that the viewer
203 window knows to which account the viewed message belongs.
205 * src/maemo/modest-msg-view-window.c: Destroy the window when the
206 corresponding account is deleted. This fixes projects.maemo.org bug
209 2007-07-18 Armin Burgmeier <armin@openismus.com>
211 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
212 the dialog close after entering an invalid port number and clicking
213 OK. This fixes projects.maemo.org bug NB#63602.
215 2007-07-18 Armin Burgmeier <armin@openismus.com>
217 * src/modest-tny-account-store.c:
218 (get_server_accounts): Set parent modest account name for each
219 connection-specific transport account so that special folders of such
220 an account can be looked up. This fixes a crash when changing account
221 settings. This might also be related to projects.maemo.org bug
224 2007-07-16 Armin Burgmeier <armin@openismus.com>
226 * src/modest-ui-actions.c: Added a button to create a folder to the
227 move-to dialog. This fixes projects.maemo.org bug NB#.
229 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
231 * src/maemo/easysetup/modest-easysetup-wizard.c:
232 Added scrollbars to account wizard dialog.
233 Fixed projects.maemo.org NB #62744
235 2007-07-16 Murray Cumming <murrayc@murrayc.com>
237 * src/widgets/modest-msg-view.h:
238 * src/widgets/modest-msg-view.c:
239 Added modest_msg_view_get_message_is_empty() but this needs
241 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
242 Check if there is any text in the message yet.
243 But this needs to be implemented properly.
244 (modest_msg_edit_window_toggle_find_toolbar):
245 * src/maemo/modest-msg-view-window.c:
246 (modest_msg_view_window_toggle_find_toolbar):
247 Show a banner warning if there is no text to search, when
248 trying to start a search. This partially fixes
249 projects.maemo.org bug NB#62350.
251 2007-07-13 Murray Cumming <murrayc@murrayc.com>
253 * src/modest-mail-operation.c: (update_account_thread):
254 Initialized num_new_headers to fix the build.
256 2007-07-13 Murray Cumming <murrayc@murrayc.com>
258 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
259 Ignore modest accounts whose server accounts don't exist in gconf.
260 This prevents us trying to create TnyAccount instances for those
261 server accounts when the server account has been removed from gconf,
262 but the parent modest account has not yet been removed from modest.
263 I don't know why this is only noticeable now. It was probably just
264 a harmeless g_warning() anyway.
266 2007-07-13 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
269 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
271 2007-07-12 Armin Burgmeier <armin@openismus.com>
273 * src/maemo/modest-main-window.c: Make default account appear bold
274 in view, tools/send & receive and toolbar/send & receive SCM menus.
275 This fixes projects.maemo.org bug NB#59010.
277 2007-07-12 Murray Cumming <murrayc@murrayc.com>
279 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
280 Add a short-cut, by checking if the folder store is an account.
281 This ensures that the Sort menu item and toolbar is dimmed for
282 the local-folders account root item, fixing
283 projects.maemo.org bug NB#62545.
285 2007-07-12 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-tny-account-store.c: (get_password):
288 Show the password dialog (via the signal) only in the mainloop, via
289 an idle handler that we wait for. This could theoretically prevent
290 hangs, though I worry that it could introduce some too.
292 2007-07-12 Murray Cumming <murrayc@murrayc.com>
294 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
295 * src/maemo/modest-platform.c:
296 (modest_platform_connect_and_wait):
297 Take a TnyAccount* parameter and try to set it to online
298 (a TnyCamel-only API), because tinymail sets accounts to offline
299 when the user cancels a password dialog, and doesn't ask again until
300 it has been set to online.
301 However, this is commented out because it causes a hang now.
303 (modest_platform_connect_and_wait_if_network_account):
304 * src/modest-mail-operation.c:
305 (modest_mail_operation_update_account):
306 * src/modest-platform.h:
307 * src/modest-ui-actions.c: (_modest_ui_actions_open),
308 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
310 2007-07-12 Armin Burgmeier <armin@openismus.com>
312 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
314 * src/modest-mail-operation.c:
315 * src/modest-ui-actions.c: Check for already existing folder before
316 querying the server, show error message from camel if the request
317 still fails. This fixes projects.maemo.org bug NB#58701.
319 2007-07-12 Murray Cumming <murrayc@murrayc.com>
321 * src/modest-tny-account-store.h:
322 * src/modest-tny-account-store.c:
323 Added modest_tny_account_store_forget_password_in_memory(),
324 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
325 when creating a new account, so that new passwords will be used, instead of
326 us thinking that it's a second request as a result of a failed password again.
328 2007-07-12 Murray Cumming <murrayc@murrayc.com>
330 * src/dbus_api/modest-dbus-callbacks.c:
331 (on_idle_open_message): If the message is in drafts then open it
332 in an edit window instead of a view window. This fixes
333 projects.maemo.org bug NB#63005.
335 2007-07-12 Murray Cumming <murrayc@murrayc.com>
337 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
338 Avoided a harmless g_warning().
340 2007-07-12 Murray Cumming <murrayc@murrayc.com>
342 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
343 Pass the modest account name, not the TnyAccount display name to
344 modest_msg_view_window_new() so that the reply feature works,
345 fixing projects.maemo.org bug NB#62892.
347 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
348 (modest_msg_view_window_new_with_header_model):
349 * src/maemo/modest-msg-view-window.c:
350 (modest_msg_view_window_new_with_header_model),
351 (modest_msg_view_window_new):
352 * src/modest-ui-actions.c: (reply_forward):
353 * src/widgets/modest-msg-view-window.h:
354 * src/widgets/modest-window.c: (modest_window_set_active_account):
355 Rename an account parameter to modest_account_name to make this clearer.
357 2007-07-11 Murray Cumming <murrayc@murrayc.com>
359 * src/modest-ui-actions.h:
360 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
361 modest_do_message_delete().
362 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
363 Call modest_do_message_delete(), hoping that this would cause messages
364 to be really deleted from search instead of just marked with strike through.
365 Does not seem to help.
367 2007-07-11 Armin Burgmeier <armin@openismus.com>
369 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
370 priv->reselect to FALSE prior to calling
371 modest_folder_view_select_first_inbox_or_local() to prevent endless
372 recursion and thus a crash on startup.
374 2007-07-11 Armin Burgmeier <armin@openismus.com>
376 * src/maemo/modest-account-settings-dialog.h: Include
377 <gtk/gtknotebook.h> to fix the build (at least for me).
379 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
380 Use "New FolderN" as default suggested name if "New folder" already
381 exists, with N being the first free number, though never exceed "New
382 folder99" in which case we just fall back to "New Folder" even though
383 it already exists. This fixes projects.maemo.org bug NB#58663.
385 2007-07-11 Murray Cumming <murrayc@murrayc.com>
387 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
388 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
389 projects.maemo.org bug NB#62778.
391 2007-07-11 Murray Cumming <murrayc@murrayc.com>
393 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
394 Ignore the wrong (for now) secure-smtp setting in the presets -
395 just default to requiring secure authentication for SMTP, because
398 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
400 * src/widgets/modest-folder-view.c: (filter_row)
401 Do not show drafts folder (see UI specs)
403 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
405 * src/modest-ui-actions.c:
406 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
407 place and also not necessary.
409 * src/widgets/modest-folder-view.c: (filter_row)
410 Guess folder type and hide Sent & Outbox if necessary.
411 Fixed project.maemo.org NB#57328
413 2007-07-11 Murray Cumming <murrayc@murrayc.com>
415 * src/modest-ui-actions.h:
416 * src/modest-ui-actions.c:
417 (modest_ui_actions_on_delete_message):
418 Move some code into a new
419 modest_ui_actions_refresh_message_window_after_delete()
420 function so we can use it from elsewhere.
422 * src/dbus_api/modest-dbus-callbacks.c:
423 (on_idle_delete_message), (on_delete_message): Used an idle
424 handler, as we do for the other D-Bus method handlers.
425 Call modest_ui_actions_refresh_message_window_after_delete()
426 if the deleted message was open in a window. This fixed
427 projects.maemo.org bug NB#62862.
429 2007-07-11 Murray Cumming <murrayc@murrayc.com>
431 * src/modest-main.c: (main): Only show the UI at the start if
432 the showui command line option was given. For instance,
433 run-standalone src/modest showui
434 Otherwise, we wait for the top_application D-Bus method to
435 be sent by hildon-desktop when the application is selected
437 This allows us to run without a UI when osso-global-search
438 uses our D-Bus methods.
440 2007-07-11 Murray Cumming <murrayc@murrayc.com>
442 * src/dbus_api/modest-dbus-api.h: Added a define for a
443 top-application D-Bus method.
444 * src/dbus_api/modest-dbus-callbacks.c:
445 (on_top_application),
446 (modest_dbus_req_handler): Handle the top-application D-Bus
447 method, which might be an undocumented D-Bus signal sent by
448 hildon-desktop when it starts the application from the menu.
449 But I am not sure and I need to test it on the device, because
450 my scratchbox does not have the application in the menu now.
451 This method shows the main window, so that it can be invisible
452 when started, for instance, just for email searching from
455 * src/maemo/modest-main-window.c: (restore_settings),
456 (modest_main_window_new): Do not show the window immediately
457 upon creation. We show it later.
458 * src/modest-widget-memory.c: (save_settings_paned):
459 Try (unsuccessfully) to avoid saving the paned position when
460 it is not even visible.
461 (restore_settings_paned): Do not allow a silly paned position.
462 This seems necessary when not showing the window at first.
464 * tests/dbus_api/Makefile.am:
465 * tests/dbus_api/test_top_application.c: (main): Test for the
468 2007-07-10 Murray Cumming <murrayc@murrayc.com>
470 * src/modest-ui-dimming-rules.c:
471 (modest_ui_dimming_rules_on_new_msg),
472 (modest_ui_dimming_rules_on_reply_msg),
473 (modest_ui_dimming_rules_on_delete_msg),
474 (modest_ui_dimming_rules_on_details),
475 (modest_ui_dimming_rules_on_view_window_move_to),
476 (modest_ui_dimming_rules_on_view_previous),
477 (modest_ui_dimming_rules_on_view_next),
478 (_invalid_folder_for_purge): Added checks before
479 casting the window. This looks like an actual
480 logic error in _invalid_folder_for_purge(), because it
481 tries to use a ModestMainWindow as a message window.
483 2007-07-10 Murray Cumming <murrayc@murrayc.com>
485 * src/maemo/modest-account-settings-dialog.c:
486 (show_error): Use the same implementation as in
487 modest-easysetup-wizard.c:
488 (on_entry_invalid_character): The logical ID contains a %s.
489 Guessed what it should be.
490 (on_entry_max), (check_data), (on_response): Adapt to
491 changed show_error().
492 (create_page_account_details): Really call
493 modest_validating_entry_set_func() on the correct widgets.
494 * src/maemo/easysetup/modest-easysetup-wizard.c:
495 (on_entry_invalid_character): Fix the logical ID here too.
496 (create_page_account_details),
497 (create_page_user_details):
499 modest_validating_entry_set_func() on the correct widgets.
501 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
502 Do not try to use the account if it is NULL.
504 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
506 * src/modest-ui-actions.c: (create_move_to_dialog),
507 (modest_ui_actions_on_main_window_move_to),
508 (modest_ui_actions_on_msg_view_window_move_to):
509 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
510 (filter_row), (modest_folder_view_show_non_move_folders):
511 * src/widgets/modest-folder-view.h:
513 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
514 the Sent folder yet as it does not report the correct folder type.
516 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
518 * src/maemo/modest-msg-edit-window.c: (init_window):
521 2007-07-10 Murray Cumming <murrayc@murrayc.com>
523 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
524 Take a parent widget instead of a parent window, and
525 implement this with hildon_banner_show_information() instead.
526 Non-Maemo builds can just ifdef that there.
527 This fixed projects.maemo.org bug NB#62766.
529 (on_entry_invalid_character): Use show_error() again instead
530 of using hildon directly, and use the _CS() macro to use the correct
532 (create_account), (check_for_supported_auth_methods), (on_entry_max):
533 Pass a widget instead od a window to show_error().
535 2007-07-10 Murray Cumming <murrayc@murrayc.com>
537 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
538 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
539 This allows us to show the server name in the error message, fixing
540 projects.maemo.org bug NB#62904.
541 Also, use the appropriate logical ID message for the account protocol.
543 2007-07-10 Murray Cumming <murrayc@murrayc.com>
545 * src/modest-tny-account-store.c: (on_idle_wrong_password):
546 A compilation fix, though the build wasn't broken for me.
548 2007-07-09 Murray Cumming <murrayc@murrayc.com>
550 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
551 Do not try to unref a NULL folder store, to avoid a runtime warning.
552 This seems to happen sometimes when changing accounts settings.
554 2007-07-09 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-tny-account-store.c:
557 (modest_tny_account_store_instance_init),
558 (modest_tny_account_store_finalize),
559 (on_account_settings_hide), (on_idle_wrong_password):
560 Use a GHashTable to ensure that we only show one account settings
561 dialog per modest account. This avoids us having a dialog open for
562 both the store and transport accounts, or due to repeated get_password()
563 calls that shouldn't happen anyway.
565 2007-07-09 Murray Cumming <murrayc@murrayc.com>
567 * src/maemo/modest-maemo-utils.c: (on_hide),
568 (modest_maemo_show_dialog_and_forget): Handle the response, because
569 the window is not even hidden by default.
571 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
572 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
573 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
574 which seems to prevent some modality problems.
576 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
577 Ignore user cancellation errors.
579 * src/modest-account-mgr-helpers.h:
580 * src/modest-account-mgr-helpers.c:
581 Added modest_server_account_get_password() and
582 modest_server_account_get_has_password() to avoid direct use of
585 * src/maemo/modest-account-settings-dialog.h:
586 * src/maemo/modest-account-settings-dialog.c:
587 (modest_account_settings_dialog_init): Store the notebook so we can
589 Added modest_account_settings_dialog_switch_to_user_info().
591 * src/modest-tny-account-store.c:
592 (get_password): When the password in the account settings is wrong (we think),
593 show the relevant page of the account settings dialog, in the mainloop.
594 However, we currently get many of these at once because cancel does not
596 (forget_password): Do not forget the password
597 from the account settings, because this causes side-effects when
598 tinymail seems to call it at strange time, maybe because of how we
599 are cancelling get_password().
600 (modest_tny_account_store_alert): Ignore user cancellations.
602 2007-07-09 Murray Cumming <murrayc@murrayc.com>
604 * src/maemo/modest-maemo-utils.h:
605 * src/maemo/modest-maemo-utils.c:
606 Added modest_maemo_show_information_note_and_forget() for use instead of
607 gtk_dialog_run() when the response is not needed, to avoid an extra
608 mainloop which could cause a hang.
610 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
611 Use the logical IDs for the error message, though they are not
612 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
613 because gtk_dialog_run() caused a hang here (the window did not close).
614 This fixes projects.maemo.org bug NB#62646.
616 2007-07-09 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-account-mgr-helpers.h:
619 * src/modest-account-mgr-helpers.c:
620 Added modest_account_mgr_get_store_protocol().
622 * src/maemo/modest-account-view-window.c:
623 (on_delete_button_clicked): Show different warning text depending on
624 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
625 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
628 2007-07-09 Murray Cumming <murrayc@murrayc.com>
630 * src/maemo/modest-msg-edit-window.c:
631 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
632 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
634 2007-07-07 Armin Burgmeier <armin@openismus.com>
636 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
637 ckdg_ib_maximum_characters_reached from correct package.
639 * src/modest-ui-actions.c: Show an error message when a folder could
640 not be created. Tinymail does not give us specific error codes about
641 what has gone wrong, so we assume that a folder with that name
642 already exists, though there might be other reasons.
644 2007-07-06 Murray Cumming <murrayc@murrayc.com>
646 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
647 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
648 give a more exact error message that can be partly translated.
650 2007-07-05 Murray Cumming <murrayc@murrayc.com>
652 * src/maemo/modest-address-book.c:
653 (select_email_addrs_for_contact): Specify a default window size for the
654 select-email-address dialog, so that it is probably big enough for the
655 title. This should fix projects.maemo.org bug NB#62277.
657 2007-07-05 Murray Cumming <murrayc@murrayc.com>
659 * src/maemo/easysetup/modest-easysetup-wizard.c:
660 (create_page_complete_easysetup): Use
661 gtk_widget_set_size() request to ensure that the text wraps
664 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
666 * src/maemo/easysetup/modest-easysetup-wizard.c:
667 (on_entry_invalid_character), (create_page_account_details),
668 (create_page_user_details):
669 Use new API of ModestValidatingEntry. But for some reason the banner is
670 not shown. I will have to investigate that further.
672 * src/widgets/modest-validating-entry.c: (on_insert_text),
673 (modest_validating_entry_set_func):
674 * src/widgets/modest-validating-entry.h:
675 Added a new callback function to be able to react to prevented
676 characters whitespaces to e.g show a banner.
678 2007-07-05 Armin Burgmeier <armin@openismus.com>
680 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
681 notification of HildonNumberEditor instead of remembering the port
682 number. Thanks to Johannes for pointing this out.
684 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
686 * src/maemo/easysetup/modest-easysetup-wizard.c:
687 Check if there are any user changes before showing a confirmation
688 dialog (projects.maemo.org NB#60946)
690 2007-07-05 Armin Burgmeier <armin@openismus.com>
692 * src/maemo/modest-account-settings-dialog.c: Remember custom port
693 number at the beginning of the dialog and set the modified flag at the
694 end if the port number has changed. This is necessary because
695 HildonNumberEditor does not support notification when the value has
698 2007-07-05 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-ui-actions.c:
701 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
702 a connection before asking anything else. Correct the check for the destination
703 folder so that it succeeds when online.
704 This fixed projects.maemo.org bug NB#61645.
706 2007-07-05 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
709 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
710 to fix projects.maemo.org bug NB#62439.
712 2007-07-05 Murray Cumming <murrayc@murrayc.com>
714 * src/modest-tny-account.c: (on_connection_status_changed):
715 Really do not use tny_device_force_offline() here. See the previous comment.
717 2007-07-04 Murray Cumming <murrayc@murrayc.com>
719 * src/modest-tny-account.c: (on_connection_status_changed):
720 Do not use tny_device_force_offline() when tinymail says that something
721 went wrong with the connection. It seems to report this unnecessarily.
723 2007-07-04 Murray Cumming <murrayc@murrayc.com>
725 * src/maemo/modest-connection-specific-smtp-window.c:
726 (modest_connection_specific_smtp_window_init):
727 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
728 does not seem to have any effect in osso 1.1 (though it works in
729 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
731 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
733 * src/maemo/modest-connection-specific-smtp-window.c:
734 Fix UI specification problems with projects.meamo.org NB#60479
736 2007-07-04 Murray Cumming <murrayc@murrayc.com>
738 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
739 clue when this has failed, because the error dialog is not always shown
740 (at least in earlier version).
742 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
743 GError message, because the generic error dialog is not helpful.
745 'This message is not currently available (can't let a new connection go online)'
746 when trying to open an IMAP message.
748 (_modest_ui_actions_open): Offer a connection when some messages would
749 have to be downloaded and we are offline.
751 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
753 * src/widgets/modest-folder-view.c:
754 Don't check for MERGE type anymore as we use the correct type
756 NOTE: For the last two changes you need to update your tinymail copy
757 because of API changes!
759 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
761 * src/modest-tny-local-folders-account.c:
762 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
763 (see projects.maemo.org NB#61580)
765 2007-07-04 Murray Cumming <murrayc@murrayc.com>
767 * src/modest-tny-account.c: (on_connection_status_changed):
768 Commented out the call to modest_platform_connect_and_wait() because this
769 seems to always hang, and I would like to know if this is the only thing
770 that causes a hang when showing the connection dialog.
771 It is not very useful anyway.
773 2007-07-04 Murray Cumming <murrayc@murrayc.com>
775 * src/maemo/modest-msg-view-window.c:
776 (modest_msg_view_window_select_next_message):
778 * src/modest-platform.h:
779 * src/maemo/modest-platform.c:
780 Added modest_platform_connect_and_wait(), which calls
781 tny_maemo_conic_device_connect() always in the main thread, by calling it
782 in an idle handler and waiting for the idle handler to run. It should be
783 in the main thread because it uses GTK+ UI code. It just returns TRUE
784 if the device is already online.
786 There is some nasty code to ensure that subsequent calls to
787 modest_platform_connect_and_wait() just wait for the first one to finish,
788 by checking repeatedly in another idle handler. This is necessary,
789 because other threads (or even the main thread, via another idle handler)
790 can call modest_platform_connect_and_wait() while
791 modest_platform_connect_and_wait() is running.
793 (modest_platform_connect_and_wait_if_network_account),
794 (modest_platform_connect_and_wait_if_network_folderstore):
795 Convenience functions that calls modest_platform_connect_and_wait() if
796 the account or folder might want network access.
798 * src/modest-mail-operation.c:
799 (modest_mail_operation_update_account):
800 * src/modest-ui-actions.c: (download_uncached_messages),
801 (modest_ui_actions_on_rename_folder), (delete_folder),
802 (modest_ui_actions_on_main_window_move_to),
803 (modest_ui_actions_on_msg_view_window_move_to):
804 * src/widgets/modest-folder-view.c:
805 (drag_and_drop_from_folder_view):
806 Offer a connection if we are offline.
808 * src/modest-tny-account.c: (on_connection_status_changed):
809 Document this as only handling errors during network operations in progress,
810 and replace the idle code with a simple call to
811 modest_platform_connect_and_wait(), which does this instead.
813 2007-07-03 Murray Cumming <murrayc@murrayc.com>
815 * src/modest-tny-account.c:
816 (modest_tny_account_get_special_folder): (util_on_idle),
817 Handle the GError so we can see when tny_folder_store_get_folders()
818 fails, as it currently does while something else is connecting.
820 Added util_run_in_main_thread_and_wait()
821 which uses an idlen handler and mainloop to ensure that the function
822 is called in the main thread.
823 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
824 to make sure that we call attempt the connection in the mainloop only,
825 which might solve some hangs.
827 2007-07-03 Murray Cumming <murrayc@murrayc.com>
829 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
830 be found by their display name. This is never useful.
831 * src/modest-tny-account-store.c: (on_account_removed): Find the account
832 by its ID, instead of trying to use its ID as its display name.
834 * src/modest-tny-account-store.h:
835 * src/modest-tny-account.c:
836 (modest_tny_account_get_special_folder): Add a g_warning() when
837 tny_folder_store_get_folders() returns an empty list for the maildir.
839 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
840 Add a g_warning() when this returns NULL, because that it not allowed
843 2007-07-02 Armin Burgmeier <armin@openismus.com>
845 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
846 note when trying to cancel the wizard. This fixes projects.maemo.org
849 2007-07-02 Murray Cumming <murrayc@murrayc.com>
851 * src/modest-tny-account.h:
852 * src/modest-tny-account.c:
853 (modest_tny_account_new_from_server_account),
854 (modest_tny_account_new_from_server_account_name),
855 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
856 because this must now be set before setting the proto. This is usd in
857 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
858 warning in camel_session_get_service() caused by
859 tny_camel_transport_account_prepare().
861 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
864 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
868 (modest_connection_specific_smtp_edit_window_init):
870 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
873 2007-06-29 Murray Cumming <murrayc@murrayc.com>
875 * src/modest-tny-account.c:
876 (modest_tny_account_new_from_server_account):
877 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
878 now uses to request a connection when it needs one, and which it uses
879 to tell us that something is wrong with the connection, so we can force
880 the accounts offline to prevent further problems.
883 * src/modest-init.c: (init_default_settings):
884 * src/modest-mail-operation.c:
885 (modest_mail_operation_update_account):
886 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
887 This should not be necessary anymore. Do not set the conf key that
888 determined this (it was always TRUE and not set anywhere else).
890 * src/modest-ui-actions.h: Remove unused and unimplemented
891 modest_ui_actions_on_online_toggle_toggled().
893 2007-06-29 Murray Cumming <murrayc@murrayc.com
895 * src/maemo/modest-main-window.c: (connect_signals):
896 Don't connect to delete_event twice. Maybe this was harmless.
898 2007-06-29 Murray Cumming <murrayc@murrayc.com
900 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
901 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
902 Debug output to give some more clue when a folder move is not allowed.
904 2007-06-28 Murray Cumming <murrayc@murrayc.com
906 * src/modest-tny-account.c: (on_modest_file_system_info),
907 (modest_tny_account_get_mmc_account_name):
908 Always call the callback, without checking whether the name has changed.
909 * src/widgets/modest-folder-view.c: (strings_are_equal),
910 (on_model_foreach_set_name), (on_get_mmc_account_name),
911 (text_cell_data): Compare the name here, and use the name from
912 the account rather than from the
913 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
914 if the name was changed after the account was added to the model.
915 That's a tinymail bug but not one that I want to fix now.
917 This finally fixes projects.maemo.org bug NB#59301.
919 2007-06-27 Armin Burgmeier <armin@openismus.com>
921 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
924 2007-06-27 Murray Cumming <murrayc@murrayc.com
926 * src/modest-tny-account.h:
927 * src/modest-tny-account.c:
928 Added modest_tny_account_get_mmc_account_name(), to set the memory
929 card name asynchronously for the given account and then notify.
930 (modest_tny_account_new_for_local_folders): Use this new function instead
931 of using hildon_file_system_info_async_new() directly.
933 * src/widgets/modest-folder-view.c: (text_cell_data):
934 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
935 gtk_tree_model_row_changed() when it is available.
937 This should fix projects.maemo.org bug NB#59301.
939 2007-06-27 Murray Cumming <murrayc@murrayc.com
941 * src/modest-mail-operation.c: (update_account_thread),
942 (get_msgs_full_thread): Fix typo failures in the revert
945 2007-06-27 Murray Cumming <murrayc@murrayc.com
947 * src/maemo/modest-maemo-global-settings-dialog.c:
948 (idle_select_default_focus):
949 * src/modest-mail-operation.c: (idle_notify_progress),
950 (idle_notify_progress_once), (set_last_updated_idle),
951 (update_account_thread), (get_msgs_full_thread):
952 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
953 * src/widgets/modest-header-view.c:
954 (idle_notify_headers_count_changed_destroy),
955 (idle_notify_headers_count_changed):
956 Reverted the additions of gdk_threads_enter/leave(), in case this
957 helps with a startup hang on the device.
959 2007-06-26 Armin Burgmeier <armin@openismus.com>
961 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
962 for supported secure authentication methods from server by
963 gtk_dialog_run(), saving CPU time and a potential race condition.
965 2007-06-26 Armin Burgmeier <armin@openismus.com>
967 * src/maemo/modest-maemo-utils.h:
968 * src/maemo/modest-maemo-utils.c: Added a
969 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
970 only error code to tell the calling code when the user canceled the
973 * src/maemo/modest-account-settings-dialog.h:
974 * src/maemo/modest-account-settings-dialog.c:
975 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
976 message if the retrieval of secure authentication methods was canceled
977 by the user. Perform the check before saving anything to configuration
978 to not end up with half-committed configuration changes, do not show
979 a "Saving to configuration failed" note when authentication methods
980 could not be retrieved.
982 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
985 2007-06-26 Murray Cumming <murrayc@murrayc.com>
987 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
988 Only return the first level of folders under accounts, because the
989 osso-global-search UI spec doesn't want the rest.
990 This fixed projects.maemo.org bug NB#61811.
992 2007-06-26 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-tny-account-store.c:
995 * src/modest-tny-account-store.h:
996 Added modest_tny_account_is_memory_card_account().
997 * src/maemo/modest-main-window.c: (create_details_widget):
998 Show the same information items for the memory card as we show for the
999 local-folders, to fix projects.maemo.org bug NB#59307.
1001 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-tny-account-store.c: (get_password):
1004 Added some checks for NULL to maybe prevent crashes, though I think
1005 it was Philip's last commit that actually prevented the crash here
1006 when creating a first new account.
1007 But the new account is still not usable (no messages are shown)
1008 until a restart of the application.
1010 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1012 * src/maemo/modest-maemo-global-settings-dialog.c:
1013 (idle_select_default_focus):
1014 * src/modest-mail-operation.c: (idle_notify_progress),
1015 (idle_notify_progress_once), (idle_notify_update_account_queue),
1016 (set_last_updated_idle), (update_account_thread),
1017 (notify_get_msgs_full), (get_msgs_full_destroyer),
1018 (get_msgs_full_thread):
1019 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1020 * src/widgets/modest-header-view.c:
1021 (idle_notify_headers_count_changed_destroy),
1022 (idle_notify_headers_count_changed):
1023 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1024 all idle handlers, because some other thread could be blocking
1025 the GDK lock, so that it can do GUI stuff.
1027 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1029 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1030 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1031 (on_idle_send_receive), (on_idle_open_default_inbox):
1032 * src/maemo/modest-msg-edit-window.c:
1033 (modest_msg_edit_window_attach_file_noninteractive):
1034 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1035 to prevent a hang. I don't quite understand why these are necessary,
1036 beause we should already be in the main loop. I guess something outside
1037 of the main loop is taking the lock.
1039 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1040 we are really using URIs, and use files that are more likely to exist.
1042 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1044 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1045 necessary because configure.ac now defines different variables.
1047 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1049 * libmodest-dbus-client/libmodest-dbus-client.c:
1050 * libmodest-dbus-client/libmodest-dbus-client.h:
1051 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1052 libmodest_dbus_client_compose_mail() is what things actually use.
1054 * src/dbus_api/modest-dbus-api.h:
1055 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1056 * tests/dbus_api/Makefile.am:
1057 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1060 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1062 * src/modest-init.c: (modest_init_local_folders):
1063 For memory-card (or other non local-folders) maildir accounts,
1064 always create an Archive folder, so that there is somewhere to put
1065 messages. This should be less confusing, because the user does not need
1066 to guess that the need to create a folder.
1068 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1070 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1071 Fixed icon size by using (50, 50) which is the same as defined by
1074 2007-06-25 Armin Burgmeier <armin@openismus.com>
1076 * src/widgets/modest-window-mgr.c:
1077 * src/modest-init.c:
1078 * configure.ac: Correctly recognize hildon-notify presence and fixed
1079 the build without it being installed.
1081 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1083 * libmodest-dbus-client/libmodest-dbus-client.c:
1084 (libmodest_dbus_client_search): Fix the build. Sorry.
1085 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1086 (reply_forward_cb): Initialize variables to fix the build.
1088 * src/modest-tny-account-store.c:
1089 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1090 comparison (a silly typo) so that email search results can be opened
1091 when there are more than one account.
1093 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1095 * libmodest-dbus-client/libmodest-dbus-client.c:
1096 (libmodest_dbus_client_search),
1097 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1098 instead of 1 second, because the search gets folders and messages from
1099 the server, which can take a long time. When it times out,
1100 osso-global-search will report no results.
1102 We need to specify whether we should search only cached information
1103 (maybe with a user preference), and the osso-email-search-plugin
1104 API should really be improved to allow that option, and to allow results
1105 to be delivered asynchronously in batches.
1107 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1109 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1110 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1111 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1113 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1115 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1116 that is an empty string. D-Bus seems to give us these instead of NULL.
1118 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1120 * src/dbus_api/modest-dbus-callbacks.c:
1121 * src/maemo/easysetup/modest-easysetup-wizard.h:
1122 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1124 (modest_connection_specific_smtp_edit_window_init):
1125 * src/maemo/modest-maemo-global-settings-dialog.c:
1127 * src/maemo/modest-maemo-utils.c:
1128 (modest_maemo_utils_setup_images_filechooser):
1129 * src/maemo/modest-main-window.c: (create_details_widget):
1130 * src/maemo/modest-msg-edit-window.c:
1131 (modest_msg_edit_window_attach_file_noninteractive),
1132 (modest_msg_edit_window_color_button_change),
1133 (modest_msg_edit_window_set_zoom):
1134 * src/modest-mail-operation.c: (update_account_thread):
1135 * src/modest-tny-account-store.c:
1136 * src/modest-tny-account.c:
1137 * src/widgets/modest-global-settings-dialog.c:
1138 * src/widgets/modest-window.h:
1140 Fixed build on bora!
1142 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1144 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1145 * src/modest-search.c: (modest_search_folder),
1146 (modest_search_all_accounts): Actually search only in the specified folder,
1147 doing a simple match on the folder ID.
1148 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1149 and added some documentation.
1151 2007-06-22 Armin Burgmeier <armin@openismus.com>
1153 * src/maemo/modest-maemo-utils.h:
1154 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1155 modest_maemo_utils_get_supported_secure_authentication_methods.
1157 * src/maemo/easysetup/modest-easysetup-wizard.c:
1158 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1159 one occured, not just "Server does not support secure authentication".
1161 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-tny-account-store.c: (get_password):
1164 Restored the call to tny_account_set_user() because Philip seems to have
1165 stopped this from crashing (by not using the freed string). It still does
1166 not work, but now we can test it.
1168 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1170 * src/maemo/modest-msg-edit-window.c: (init_window):
1171 Comment out use of an uninitialzed GtkScrolledWindow variable,
1172 to fix the build and stop a crash. Yet again.
1174 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-tny-account-store.c: (get_password):
1177 Remove the call to tny_account_set_user() because this actually crashes.
1178 As mentioned in the last commit, it is known to not work anyway.
1180 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-tny-account-store.c: (get_password):
1183 Use tny_account_set_username() to tell tinymail that the username might
1184 have changed too. But tinymail ignores this: see projects.maemo.org
1186 * src/modest-ui-actions.c:
1187 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1188 reset the connection when changing the username, and improve the comments.
1189 Save the changed username to gconf at least, so it is used when Modest is
1192 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1194 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1195 Do not use a query, so that we get all folders, including for POP and
1196 local-folders. They work as search criteria too.
1197 This fixes projects.maemo.org bug NB#57740.
1199 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1201 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1202 Comment out the use of hildon_notification_set_sound() because it is
1203 not declared, to fix the build. Warnings are serious, people.
1205 2007-06-21 Armin Burgmeier <armin@openismus.com>
1207 * src/maemo/modest-maemo-utils.h:
1208 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1209 modest_maemo_utils_get_supported_secure_authentication_methods()
1210 to query authentication methods for a specific user. This should fix
1211 projects.maemo.org bug NB#61369.
1213 * src/maemo/easysetup/modest-easysetup-wizard.c:
1214 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1217 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1219 * libmodest-dbus-client/libmodest-dbus-client.h:
1220 * libmodest-dbus-client/libmodest-dbus-client.c:
1221 (modest_dbus_message_iter_get_search_hit),
1222 (libmodest_dbus_client_search):
1223 Reorganised and commented this.
1224 Removed modest_search_hit_free() from the public API because it
1227 Added libmodest_dbus_client_get_folders() and
1228 modest_folder_result_list_free().
1230 * src/dbus_api/modest-dbus-api.h:
1231 * src/dbus_api/modest-dbus-callbacks.c:
1232 (modest_dbus_req_filter): Commented. Moved most code to
1233 on_dbus_method_search() and added on_dbus_method_get_folders().
1235 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1236 of the extra D-Bus handler.
1238 * tests/dbus_api/Makefile.am:
1239 * tests/dbus_api/test_get_folders.c: New test for
1240 libmodest_dbus_client_get_folders(). This seems to return an empty list
1241 at the moment. That could be the same error that causes the message list
1242 to be empty sometimes.
1243 This should help with projects.maemo.org bug NB#57740.
1245 2007-06-21 Armin Burgmeier <armin@openismus.com>
1247 * src/modest-mail-operation.c: Do not call
1248 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1249 notify the operation's end after having set the status to CANCELED for
1250 the operation queue to listen on. This fixes a deadlock when there
1251 were mail operations in the queue during its finalization.
1253 * src/modest-singletons.c: Reordered uninitialization of the account
1254 manager to happen after the mail operation queue was uninitialized
1255 because the mail operation's in the queue might still try to access
1256 the account manager (see modest_mail_operation_notify_end()). This
1257 fixes a potential crash when terminating the application.
1259 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1261 * src/modest-search.c:
1262 (search_mime_part_and_child_parts): Moved some code here so we
1263 can search recursively in child folders.
1264 (modest_search_folder): Search in the message as a mime part, instead
1265 of just its child mime parts.
1266 (read_chunk), (search_mime_part_ogs):
1267 Check how many bytes were read, to prevent an endless loop.
1268 Searching in message bodies now works. This finishes the fix for
1269 projects.maemo.org bug NB#61007.
1271 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1274 Add a g_warning when the item is not a folder.
1276 * src/modest-ui-dimming-rules.c:
1277 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1278 when selected item is not a folder (for instance, an account), because
1279 the UI spec only talks about folders.
1280 I am not sure what the UI spec wants, so this might not totally fix
1281 projects.maemo.org bug NB#60794.
1283 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1285 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1286 (load_from_file): Sort the list. The unsorted list would be more noticeable
1287 in non-English locales.
1289 * src/maemo/modest-msg-edit-window.c:
1290 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1291 warning and fix the build.
1293 * src/maemo/modest-progress-bar-widget.c:
1294 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1295 avoid a g_warning, and probably to avoid a crash.
1297 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1299 * src/modest-search.c: (modest_search_folder): Check for a GError
1300 when calling tny_folder_get_headers(), to show that this is not the cause
1303 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1305 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1306 Actually set the body query instead of the subject query.
1308 * src/modest-search.c: (search_mime_part_ogs),
1309 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1310 which would probably cause it to fail if we got this far.
1312 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1313 to simplify the code.
1314 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1315 be causing search-in-body to fail.
1317 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1319 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1321 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1322 Better debug message when the folder cannot be found.
1323 This should help with fixing projects.maemo.org bug #61287.
1324 * src/modest-search.c: (add_hit): Do not leak the furl string.
1326 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-ui-actions.c:
1329 (modest_ui_actions_on_folder_selection_changed):
1330 Do not special-case TNY_MERGE_FOLDER here, because
1331 modest_tny_folder_get_account() already does that. This fixes
1332 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1333 shown when the Outbox was selected).
1335 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1337 * libmodest-dbus-client/libmodest-dbus-client.c:
1338 (_dbus_iter_get_string_or_null): Initialize the string variable in
1339 case this helps with Dirk's crash.
1341 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1343 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1344 though it is not implemented yet (this function is maybe not even used),
1345 to avoid breaking ABI in future.
1346 * libmodest-dbus-client/libmodest-dbus-client.c:
1347 (get_attachments_string): Moved some code into this generic function.
1348 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1349 sends email. It is maybe not used.
1350 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1351 (on_send_mail): Use attachments.
1353 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1354 * src/maemo/modest-msg-edit-window.c:
1355 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1356 a filename before using it, to fix projects.maemo.org bug NB#58233.
1358 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1361 Initialize the continue_download variable to fix the build, and probably
1362 to fix randome behaviour.
1364 2007-06-18 Armin Burgmeier <armin@openismus.com>
1366 * src/modest-tny-send-queue.h:
1367 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1368 the queue so we can later show it in the UI. Replaced
1369 modest_tny_send_queue_msg_is_being_sent() by
1370 modest_tny_send_queue_get_msg_status().
1372 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1374 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1375 gpointer. This probably was not harmful, but just to be sure.
1377 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1380 Fix the build, but leave the function broken on Bora, because
1381 hildon_uri_action_get_service() does not exist.
1382 osso_uri_action_get_service() does not exist either, it seems.
1384 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1386 * src/modest-tny-account.c:
1387 (modest_tny_account_new_from_server_account):
1388 Uncommented the url debug output again, because it is useful for
1389 debugging, as I said in the comment.
1391 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1393 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1395 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1396 for Mameo Bora, to fix the build.
1398 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1401 Fixed build with hildon < 0.99
1403 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1404 Check if the selected account is busy instead of checking all accounts
1406 * src/modest-account-mgr-priv.h:
1407 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1408 (modest_account_mgr_init), (compare_account_name),
1409 (modest_account_mgr_set_account_busy),
1410 (modest_account_mgr_account_is_busy):
1411 * src/modest-account-mgr.h:
1412 Added busy information to the account manager. It possible to
1413 set an account to busy or not busy now.
1415 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1416 (modest_mail_operation_update_account),
1417 (modest_mail_operation_notify_end):
1418 Set the account to busy/not busy depending on the operation state.
1420 * src/widgets/modest-account-view.c:
1421 (modest_account_view_finalize), (get_last_updated_string),
1422 (update_account_view), (on_account_busy_changed), (init_view):
1423 Show string "Refreshing..." if the account is currently busy.
1425 All this fixes projects.maemo.org bug NB#59711
1427 2007-06-14 Armin Burgmeier <armin@openismus.com>
1429 * src/widgets/modest-attachments-view.h:
1430 * src/widgets/modest-attachments-view.c: Added
1431 modest_attachments_view_has_attachments() and fixed coordinate
1432 transformation in get_att_view_at_coords(). This fixes attachment
1435 * src/widgets/modest-msg-view.c: Make use of
1436 modest_attachments_view_has_attachments() to decide whether to show
1437 attachments in the header.
1439 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1441 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1442 (on_change), (on_combo_security_changed),
1443 (modest_connection_specific_smtp_edit_window_init),
1444 (modest_connection_specific_smtp_edit_window_set_connection),
1445 (modest_connection_specific_smtp_edit_window_is_dirty):
1446 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1447 * src/maemo/modest-connection-specific-smtp-window.c:
1450 Show an comfirmation dialog for the smpt-edit-window if there are
1451 unsaved changes and the user hits cancel.
1452 (projects.maemo.org bug NB#60479)
1454 2007-06-14 Armin Burgmeier <armin@openismus.com>
1456 * src/maemo/easysetup/modest-easysetup-wizard.c:
1457 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1458 address" info in banner instead of node, and select all the text as
1459 per UI spec. This fixes projects.maemo.org bug NB#60550.
1461 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1463 reviewed by: <delete if not using a buddy>
1465 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1466 * src/modest-ui-actions.c: (folder_refreshed_cb):
1468 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1470 * src/widgets/modest-folder-view.c: (filter_row):
1471 Explictly filter out the per-account outbox accounts. I don't know why
1472 these only sometimes show up, but now they should never show up in the UI.
1473 This should fix projects.maemo.org bug NB#60160.
1475 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1478 when the toolbar does not exist yet.
1479 * src/modest-widget-memory.c: (save_settings_header_view):
1480 Added g_warnings() to help us to discover when we are trying to set
1481 an empty columns list in gconf.
1483 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-init.h:
1486 * src/modest-init.c:
1487 Added modest_init_get_default_header_view_column_ids().
1489 * src/modest-widget-memory.c: (restore_settings_header_view):
1490 Use the new function to get defaults, if the gconf key is empty,
1491 instead of not creating any columns. This seems to fix the
1492 empty right-hand pane problems.
1494 * src/widgets/modest-header-view.h: Improved documentation.
1496 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1498 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1499 Revert the use of the display name as the account name, because this
1500 is generally wrong and would break the code that follows.
1502 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1504 * src/maemo/easysetup/modest-easysetup-wizard.c:
1505 (check_for_supported_auth_methods), (on_before_next),
1508 More correct fix for projects.maemo.org bug NB# 58991
1509 Do not longer accept AUTH_PASSWORD as secure method and choose
1510 correct method when creating the account.
1512 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1514 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1515 Fixed projects.maemo.org bug NB# 58991
1517 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1519 * src/modest-init.c: (modest_init_init_core),
1520 (modest_init_local_folders): Fixed compilation errors.
1522 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1524 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1525 Remove unnecessary lib/include, though it is good in principle when needed.
1527 * src/modest-init.c: (modest_init_one_local_folder),
1528 (modest_init_local_folders):
1529 * src/modest-init.h: Initialize the .modest library for memory cards,
1530 instead of just doing nothing for them. This should allow us to create
1531 folders there, fixing projects.maemo.org bug NB#59297.
1533 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1535 * libmodest-dbus-client/libmodest-dbus-client.c:
1536 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1537 (libmodest_dbus_client_compose_mail),
1538 (libmodest_dbus_client_open_message),
1539 (libmodest_dbus_client_send_and_receive),
1540 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1542 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1543 (on_idle_open_message), (modest_dbus_req_handler),
1544 (search_result_to_message), (modest_dbus_req_filter):
1545 * src/modest-search.c: (add_hit), (modest_search_folder),
1546 (modest_search_all_accounts): Improved debug messages.
1548 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1550 * src/modest-tny-account-store.c:
1551 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1554 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1557 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1559 * src/modest-tny-account-store.c: (get_server_accounts):
1560 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1561 even when there are no accounts, so that the Outbox folder is always
1562 visible. This fixes projects.maemo.org bug NB#60158.
1564 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1566 * src/maemo/modest-main-window.c: (create_details_widget):
1567 Use the mcen_va_never logical ID.
1569 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1571 * src/dbus_api/modest-dbus-api.h:
1572 * src/dbus_api/modest-dbus-callbacks.c:
1573 (on_idle_open_default_inbox), (on_open_default_inbox),
1574 (modest_dbus_req_handler):
1575 Added a new OpenDefaultInbox method.
1577 * libmodest-dbus-client/libmodest-dbus-client.h:
1578 * libmodest-dbus-client/libmodest-dbus-client.c:
1579 Added libmodest_dbus_client_open_default_inbox() to call the new
1580 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1581 though it should maybe be used by a new osso-email-interface function.
1583 * tests/dbus_api/Makefile.am:
1584 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1587 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1589 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1590 NULL, so that the signals get all the keys. This should not actually
1591 change any behaviour because we currently update everything when anything
1594 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1596 * src/widgets/modest-folder-view.c: (text_cell_data),
1597 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1598 (find_inbox_iter): If tinymail tells us that the folder is
1599 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1600 This causes the inbox to be selected at startup, fixing part of
1601 projects.maemo.org bug NB#56305.
1603 * src/modest-ui-dimming-rules.c:
1604 (modest_ui_dimming_rules_on_tools_smtp_servers):
1605 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1606 the SMTP servers menu item.
1607 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1608 that the SMTP Servers menu item is dimmed when there are no accounts,
1609 as a future version of the UI spec will require. This fixes
1610 projects.maemo.org bug NB#56305.
1612 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1614 * src/maemo/modest-maemo-utils.c:
1615 (modest_maemo_utils_get_supported_secure_authentication_methods):
1616 Added label to dialog instead of unreadable title
1618 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1619 (modest_main_window_new):
1620 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1623 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1624 * src/modest-account-mgr.h:
1625 Added method to avoid code duplication
1627 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1628 (modest_ui_actions_on_send_receive):
1629 Use modest_account_mgr_has_accounts
1631 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1633 * src/maemo/easysetup/modest-presets.c:
1634 (modest_presets_get_info_server_security): Do not report secure auth
1636 * src/modest-protocol-info.c: Use the defines for the gconf key names
1637 for secure authentication. This was not working because we were writing
1638 Password and reading password, and the check was case sensitive.
1639 With this, gmail now works for receiving and sending when created via
1642 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1644 * src/maemo/easysetup/modest-presets.c:
1645 (modest_presets_get_info_server_security): Correct the key name for
1646 SecureSmtp, because it seems to be case-sensitive.
1647 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1648 Do not try to get the 0th notebook page if there are 0 pages, to
1649 avoid a g_warning().
1651 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1654 Prevent use of the new notification feature for now, because it currently
1655 shows one dialog for each new email, which is annoying.
1657 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1659 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1660 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1661 when no country was selected, so that we show the global ones.
1662 * src/maemo/easysetup/modest-presets.c:
1663 (modest_presets_get_providers): Return only the global providers, not
1664 all providers when mmc=0 was requested.
1666 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1669 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1670 provider ID in the combo.
1672 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1673 Do not show the page numbers, because it would be confusing when we add
1674 the 2 extra pages for the custom setup, when the user chooses the "Other"
1675 provider. This fixes projects.maemo.org bug NB#59028
1677 * src/modest-init.c: (modest_init_init_core),
1678 (modest_init_local_folders):
1679 * src/modest-init.h:
1680 * src/modest-tny-account.c:
1681 (modest_tny_account_new_for_local_folders): Do not create default folders
1682 for the memory card. This should fix projects.maemo.org bug NB#59328.
1684 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1686 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1687 Free the changed_conf_keys string items. They are already freed in the
1688 idle handler if that runs first.
1690 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1692 * src/modest-ui-actions.c:
1693 (modest_ui_actions_on_password_requested): Check that the server name
1694 is not NULL, because I just saw a password dialog with (null) as the
1697 * src/modest-tny-folder.[h|c]: Added
1698 modest_tny_folder_is_memory_card_folder().
1699 * src/modest-ui-dimming-rules.c:
1700 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1701 menu item for memory cards, as per the UI spec (section 7.4). This should
1702 fix projects.maemo.org bug NB#59297.
1704 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1706 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1707 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1708 is another problem with the code, see Murray's comment at line 772)
1710 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1712 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1713 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1714 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1715 (load_from_file), (easysetup_country_combo_box_init),
1716 (easysetup_country_combo_box_get_active_country_ids),
1717 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1718 instead of just one ID, to avoid duplicate country names in the UI.
1720 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1721 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1722 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1723 a single ID, avoiding duplicate providers.
1724 * src/maemo/easysetup/modest-easysetup-wizard.c:
1725 (on_combo_account_country): Adapt to use a list.
1727 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1729 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1730 keys changed in the last X seconds.
1732 * src/modest-account-mgr.h:
1733 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1734 (on_key_change), (modest_account_mgr_class_init),
1735 (modest_account_mgr_init), (modest_account_mgr_finalize):
1736 As the keys are changed, save them in a GSList* and signal that GSList*
1737 further every X seconds, to batch changes, to allow us to do just one
1738 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1739 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1741 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1742 changed signal signature.
1744 * src/modest-conf.c: (modest_conf_set_list),
1745 (modest_conf_on_change): Reenable notification.
1747 (modest_conf_maemo_fake_on_change): Comment out the hack that
1748 notified immediately instead of asynchronously.
1750 * src/widgets/modest-account-view.h:
1751 * src/widgets/modest-account-view.c:
1752 (update_account_view): Select the previously-selected account ID,
1753 if possible. This fixes projects.maemo.org bug NB#56933.
1755 (on_account_changed), (on_account_removed),
1756 (modest_account_view_select_account):
1758 Remove the block/unblock functions
1759 because they were not useful.
1761 * src/maemo/modest-account-view-window.c:
1762 (on_delete_button_clicked), (on_edit_button_clicked),
1763 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1765 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1767 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1768 Improve the error dialog to show Incorrect Account Settings, which seems
1769 clearer, and say that the internal error message (to be removed from the
1770 dialog later) is often misleading.
1771 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1773 * src/modest-tny-account.c:
1774 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1775 URL because this is so useful for debugging on the device.
1777 * src/widgets/modest-serversecurity-combo-box.c:
1778 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1780 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1782 * src/modest-mail-operation.c:
1783 (modest_mail_operation_send_new_mail):
1784 Added a comment about a nasty but apparently harmless message. Details
1785 added to the wiki g_warnings() page.
1787 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1789 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1790 (modest_tny_send_queue_class_init):
1791 Do not use the priv struct because it is empty, to avoid g_warnings
1792 about a non-existant priv struct.
1794 * src/modest-tny-account-store.c:
1795 (modest_tny_account_store_get_server_account),
1796 (modest_tny_account_store_get_transport_account_for_open_connection
1797 ): Do not try to get transport server accounts for local folders,
1798 because they don't have any. This avoids a g_warning().
1800 * src/maemo/modest-main-window.c:
1801 (modest_main_window_notify_send_receive_initied),
1802 (on_configuration_key_changed):
1803 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1804 * src/modest-defs.h:
1805 * src/modest-mail-operation.c:
1806 (modest_mail_operation_update_account):
1807 * src/modest-tny-account-store.h:
1808 * src/modest-tny-account.c:
1809 (modest_tny_account_get_special_folder),
1810 (modest_tny_account_new_for_local_folders),
1811 (modest_tny_account_new_for_per_account_local_outbox_folder):
1812 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1813 * src/modest-tny-local-folders-account.c:
1814 (add_account_folders_to_merged_folder):
1815 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1816 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1817 (modest_ui_actions_on_send):
1818 * src/widgets/modest-folder-view.c: (update_model):
1819 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1820 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1821 modest_tny_account_store_get_tny_account_by_account() to
1822 modest_tny_account_store_get_server_account() to make the code clearer.
1824 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1826 * src/dbus_api/modest-dbus-api.h:
1827 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1828 * src/maemo/modest-msg-edit-window.c:
1829 (modest_msg_edit_window_attach_file_noninteractive):
1830 added g_warning in case the file to be attached does not exist
1831 * tests/dbus_api/test_compose_mail.c: (main):
1832 removed obsolete comment, added generic files as test case
1834 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1836 * src/modest-tny-account-store.c: (get_server_accounts):
1837 Create the local folders account only once, not once for each outbox, and
1838 not only when there are some outboxes.
1840 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1842 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1843 code that is causing a crash at startup. Sergio says that he is fixing this.
1845 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1847 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1848 * src/maemo/modest-account-settings-dialog.c:
1849 (create_page_outgoing),
1850 (modest_account_settings_dialog_set_account_name),
1851 (save_configuration):
1852 - Fixed handling of the "Use secure authentication" toggle to comply with
1853 the ui specification. See also projects.maemo.org bug NB#58400
1855 - Restore the Secure connection setting combo correctly when loading
1858 * src/maemo/modest-maemo-utils.c:
1859 (on_camel_account_get_supported_secure_authentication),
1860 (modest_maemo_utils_get_supported_secure_authentication_methods):
1861 Fixed a crasher if operation is canceled
1863 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1864 (modest_protocol_info_auth_is_secure):
1865 * src/modest-protocol-info.h:
1867 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1868 the sense of the "Use secure authentication" toggle.
1870 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1872 * src/modest-tny-account-store.h:
1873 * src/modest-tny-account-store.c:
1874 Added modest_tny_account_store_get_local_folders_account().
1876 * src/modest-tny-folder.h:
1877 * src/modest-tny-folder.c:
1878 (modest_tny_folder_get_account):
1879 Added this replacement for tny_folder_get_account() which returns
1880 the local-folders account for TnyMergeFolders, to avoid the
1881 warning about the unimplemented get_account_func() vfunc().
1883 (modest_tny_folder_get_rules),
1884 * src/modest-ui-actions.c:
1885 (modest_ui_actions_on_folder_selection_changed):
1886 * src/modest-mail-operation.c:
1887 (modest_mail_operation_remove_folder),
1888 (modest_mail_operation_xfer_folder),
1889 (modest_mail_operation_rename_folder),
1890 (modest_mail_operation_get_msg),
1891 (modest_mail_operation_get_msgs_full),
1892 (modest_mail_operation_remove_msg),
1893 (modest_mail_operation_xfer_msgs),
1894 (modest_mail_operation_refresh_folder):
1895 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1897 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1899 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1900 (modest_server_account_set_security):
1901 * src/modest-defs.h: Add comments explaining that our
1902 UI spec means TLS when it says Normal, so these do not look like errors.
1904 * src/modest-tny-account.c:
1905 (modest_tny_account_new_from_server_account): Use the new tinymail
1906 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1907 for TLS. This should fix projects.maemo.org bug NB#58460.
1909 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/easysetup/modest-easysetup-wizard.c:
1912 (create_account): Correct the position of the gconf sanity check warning.
1913 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1914 of using the g_idle_add() hack, because this does not seem to be necessary
1915 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1916 caused by something other than maemo's gconf.
1917 This fixes projects.maemo.org bug #59022.
1919 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-account-mgr-helpers.c:
1922 (modest_account_mgr_get_default_account): Do not check that the account
1923 exists if there is no default account (NULL), to fix a runtime warning.
1925 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1927 * src/widgets/modest-folder-view.c: (update_model):
1928 Do not unref the treemodel before we have finished with it.
1929 This prevents a valgrind warning and an occasional crash at startup.
1931 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1933 * libmodest-dbus-client/libmodest-dbus-client.h:
1934 added libmodest_dbus_client_compose_mail()
1935 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1937 added functions needed for SendAsMail() functionality
1938 * src/maemo/modest-msg-edit-window.c:
1939 (modest_msg_edit_window_attach_file_noninteractive):
1940 non interactively attaching files to message edit window
1941 * src/widgets/modest-msg-edit-window.h:
1942 * tests/dbus_api/Makefile.am:
1943 added test_compose_mail.c
1944 * tests/dbus_api/test_compose_mail.c: (main):
1946 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1948 * src/modest-account-view.c:
1949 Fixed bug projects.maemo.org bug NB#59307
1951 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1953 * src/maemo/easysetup/modest-easysetup-wizard.c:
1954 (get_serverport_incoming), (on_before_next), (create_account):
1955 * src/maemo/modest-account-settings-dialog.c:
1956 (modest_account_settings_dialog_set_account_name):
1957 * src/maemo/modest-maemo-utils.c:
1958 (on_camel_account_get_supported_secure_authentication_status),
1959 (on_camel_account_get_supported_secure_authentication),
1960 (on_secure_auth_cancel),
1961 (modest_maemo_utils_get_supported_secure_authentication_methods):
1963 Implemented security authentication for settings and easysetup.
1965 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1967 * src/maemo/modest-main-window.c: (create_details_widget):
1968 Show the total size for memory card accounts too, instead of showing
1969 the name again. Fixes bug projects.maemo.org bug NB#59307.
1971 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1974 * src/modest-tny-simple-folder-store.c:
1975 * src/modest-tny-simple-folder-store.h: Removed.
1977 * src/modest-tny-local-folders-account.h
1978 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1979 for the local-folders maildir, with an extra TnyMergedFolder containing
1980 the folders of the per-account outbox store accounts.
1981 * src/modest-tny-account-store.c: (get_server_accounts):
1982 Add the outboxes to the special local folders account after creating it.
1984 * src/modest-tny-account.c:
1985 (modest_tny_account_new_for_local_folders): Create the derived
1986 account when creating the main local-folders account.
1988 * src/maemo/modest-main-window.c: (create_details_widget),
1989 (modest_main_window_set_contents_style):
1990 Adapted to the use of the derived account instead of the folder store.
1992 * src/modest-ui-actions.c:
1993 (modest_ui_actions_on_folder_selection_changed):
1994 * src/modest-ui-dimming-rules.c:
1995 (modest_ui_dimming_rules_on_new_folder):
1996 * src/widgets/modest-folder-view.c: (text_cell_data),
1997 (icon_cell_data), (filter_row), (update_model),
1998 (get_cmp_rows_type_pos):
2001 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2002 Do not get the priv struct, because no priv struct has been set,
2003 to avoid a runtime warning.
2005 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2006 #ifelse with #else, to fix a warning, to fix the build.
2009 2007-06-05 Christian Kellner <ckellner@openismus.com>
2011 * libmodest-dbus-client/libmodest-dbus-client.c:
2012 Fix small typo in doc (why do you always see them
2013 AFTER committing stuff?)
2016 2007-06-05 Christian Kellner <ckellner@openismus.com>
2018 * libmodest-dbus-client/libmodest-dbus-client.c:
2019 (libmodest_dbus_client_search):
2020 Initialize hit list with NULL. Also set folder list
2021 to "" if NULL was supplied.
2024 2007-06-03 Christian Kellner <ckellner@openismus.com>
2026 * libmodest-dbus-client/libmodest-dbus-client.c:
2027 (modest_search_hit_list_free):
2028 Make it save to call it with NULL.
2030 * src/dbus_api/modest-dbus-callbacks.c:
2031 * src/modest-search.c:
2032 Return full ModestSearchHits as the search result list not TnyHeader
2033 since can't be around withouth the correspoding TnyFolder.
2035 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2037 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2038 Added currently commented code to check for secure auth
2040 * src/maemo/modest-account-settings-dialog.c: (on_response),
2041 (save_configuration), (show_ok):
2042 Fixed projects.maemo.org bugs NB #59248 and #59251
2044 * src/maemo/modest-maemo-utils.c:
2045 (on_camel_account_get_supported_secure_authentication_status),
2046 (on_camel_account_get_supported_secure_authentication),
2047 (modest_maemo_utils_get_supported_secure_authentication_methods):
2048 * src/maemo/modest-maemo-utils.h:
2049 Moved get_supported_secure_authentication() method here to be able
2050 to use it from easysetup wizard.
2052 * src/modest-pair.c: (on_pair_compare_as_string):
2053 Should compare string with first part of pair and not
2054 strcmp pairs which will crash.
2056 * src/modest-protocol-info.c:
2057 (modest_protocol_info_protocol_is_store):
2058 * src/modest-protocol-info.h:
2059 Added modest_protocol_info_get_auth_protocol_name()
2061 2007-06-03 Armin Burgmeier <armin@openismus.com>
2063 * src/modest-mail-operation.c:
2064 (modest_mail_operation_get_msgs_full): Set priv->account also when
2065 only retrieving a single message. This avoids a crash when canceling
2068 (modest_mail_operation_notify_end): Do not explicitely remove the
2069 operation from the queue but only emit the progress_changed signal.
2070 The queue itself listens to that signal to remove the operation when
2071 it is finished. This reduces coupling and removes a potential deadlock
2072 when modest_mail_operation_notify_end() is called from the queue
2073 itself. If that is a problem performance-wise, I would suggest to
2074 implement a status-changed signal or something.
2076 * src/modest-mail-operation-queue.c: Make sure to never call a
2077 function from another file while the queue is locked. This (hopefully)
2078 fixes another deadlock when exiting the application while retrieving
2081 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2083 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2084 Fixed build if libogs is not available
2086 2007-06-03 Christian Kellner <ckellner@openismus.com>
2088 * libmodest-dbus-client/libmodest-dbus-client.h:
2089 * libmodest-dbus-client/libmodest-dbus-client.c:
2090 (libmodest_dbus_client_delete_message):
2091 Implement deletion of messages (Client side).
2093 (modest_search_hit_free),
2094 (modest_search_hit_list_free):
2095 Utility functions to free the result hits.
2097 * src/dbus_api/modest-dbus-api.h:
2098 * src/dbus_api/modest-dbus-callbacks.c:
2099 (on_delete_message),
2100 (modest_dbus_req_handler):
2101 Implement deletion of messages (Server side).
2103 * tests/dbus_api/test_search.c: (main):
2106 * tests/dbus_api/Makefile.am:
2107 * tests/dbus_api/test_delete_message:
2108 Add little test for the message deletion logic
2110 2007-06-03 Armin Burgmeier <armin@openismus.com>
2112 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2113 when the operation queue was not empty. projects.maemo.org bug
2116 2007-06-03 Armin Burgmeier <armin@openismus.com>
2118 * src/widgets/modest-account-view.c
2119 (on_account_default_toggled): Toggle default account column
2120 explicitely instead of waiting for gconf notification (which is
2121 currently ignored). This should fix projects.maemo.org bug NB#56910
2122 for now. It should probably be removed when gconf notifications are
2125 2007-06-03 Christian Kellner <ckellner@openismus.com>
2127 * libmodest-dbus-client/libmodest-dbus-client.c:
2128 Removed debugging spew.
2130 * src/dbus_api/modest-dbus-callbacks.c:
2131 Added debugging info.
2133 * src/modest-search.c:
2134 (modest_search_all_accounts):
2135 Use tny_account_store_get_accounts () on the account store
2136 to get all accounts which is the way to get all accounts.
2138 * tests/dbus_api/test_search.c: (main):
2139 Make it possible to supply the search term on the command line.
2141 2007-06-03 Christian Kellner <ckellner@openismus.com>
2143 * libmodest-dbus-client/libmodest-dbus-client.c:
2144 * libmodest-dbus-client/libmodest-dbus-client.h:
2145 Implement searching for mesages over raw dbus. (Client side)
2147 * src/dbus_api/Makefile.am:
2148 * src/dbus_api/modest-dbus-api.h:
2149 * src/dbus_api/modest-dbus-callbacks.c:
2150 * src/dbus_api/modest-dbus-callbacks.h:
2151 Search framework (Server side). Also implement on_idle_open_message().
2153 * src/maemo/modest-platform.c: (modest_platform_init):
2154 Prepare for raw dbus/osso rpc interaction.
2156 * src/modest-search.h:
2157 Changed minsize from unspecific guint to guint32.
2159 * src/modest-search.c:
2161 Added strange hack which magically made tnymail work.
2163 (modest_search_folder),
2164 (modest_search_account),
2165 (modest_search_all_accounts):
2166 Implement helper functions to search all accounts, specific account
2169 * tests/dbus_api/Makefile.am:
2170 * tests/dbus_api/test_open_message.c:
2171 Read url to open from commandline.
2173 * tests/dbus_api/test_search.c:
2174 Implement small test for dbus search stuff
2176 2007-06-02 Armin Burgmeier <armin@openismus.com>
2178 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2179 include account type and account title. This fixes projects.maemo.org
2182 * src/maemo/modest-account-view-window.c: Set a title for the window.
2184 2007-06-02 Armin Burgmeier <armin@openismus.com>
2186 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2187 incoming and outgoing server name based on email address and server
2188 types as long as the names have not been edited manually. This fixes
2189 projects.maemo.org bug NB#58671.
2191 2007-06-02 Armin Burgmeier <armin@openismus.com>
2193 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2194 server type cannot be changed in future to the incoming details page
2195 when creating an account. This fixes projects.maemo.org bug NB#59029.
2197 2007-06-02 Armin Burgmeier <armin@openismus.com>
2199 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2200 and assigned max width chars so that they wrap instead of being
2201 truncated. Fixes projects.maemo.org bug NB#56126.
2203 2007-06-02 Armin Burgmeier <armin@openismus.com>
2205 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2206 introductory note to the connection specific smtp servers dialog, as
2207 section 8.12 of the email UI specification requires. This fixes
2208 projects.maemo.org bug NB#59212.
2210 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2212 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2213 Check for running mail operations, and offer to cancel them, as per the UI
2214 spec. This fixes projects.maemo.org bug NB#59041 .
2215 However, I suspect that tinymail may still use the network connection
2216 in ways that we cannot detect or cancel. But it should at least adapt to
2217 changes fairly well.
2219 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2221 * src/modest-tny-account-store.c: (recreate_all_accounts),
2222 (get_cached_accounts), (get_server_accounts): Do more sensible
2223 ref-counting of the temporarily-cached outbox accounts list. This seems
2224 to fix a crash when entering the password when the password was wrong.
2226 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2228 * src/gnome/modest-main-window.c: (connect_signals):
2229 * src/modest-tny-account-store.c: (get_password),
2230 (modest_tny_account_store_alert): Added comments and clues and
2231 commented-out code about how we currently fail to deal with connection
2232 errors and wrong passwords, and how we should.
2234 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2236 * src/widgets/modest-retrieve-combo-box.c:
2237 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2238 This fixes projects.maemo.org bug NB#58472 .
2240 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2242 * src/maemo/easysetup/modest-easysetup-wizard.c:
2243 (create_page_complete_easysetup):
2244 (create_page_complete_custom): Correct the last commit,
2245 putting the correct sentences in the correct pages.
2247 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2249 * src/maemo/easysetup/modest-easysetup-wizard.c:
2250 (create_page_complete_custom): Show the second sentence of text
2251 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2254 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2256 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2257 Set the leave-on-server conf key by default. This fixes
2258 projects.maemo.org bug NB#59258 .
2260 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2262 * src/maemo/modest-account-view-window.c:
2263 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2264 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2267 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2269 * src/maemo/easysetup/modest-easysetup-wizard.c:
2270 (create_caption_new_with_asterisk):
2271 * src/maemo/modest-account-settings-dialog.c:
2272 (create_caption_new_with_asterisk):
2273 Uncomment the code to add the asterisk, because they are no longer in the
2274 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2275 (update_incoming_server_title): Add an asterisk here too.
2277 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2279 * src/maemo/modest-maemo-global-settings-dialog.c:
2280 (current_connection): Check that we are even connected before trying to
2281 get the current connection name, to prevent a warning.
2283 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2284 Change the comments because tny_maemo_conic_device_connect() is now meant to
2286 * src/modest-mail-operation.c:
2287 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2288 make sure we have a connection and fail if we can't connect.
2290 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/modest-main-window.c:
2293 (on_account_store_connecting_finished): Do not try to get the
2294 connection ID if we are not really connected. I am surprised that
2295 this signal handler is called when we are not connected.
2297 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2299 * src/modest-error.h:
2300 * src/modest-ui-actions.c:
2301 (modest_ui_actions_get_msgs_full_error_handler):
2302 Renamed an enum, added comments, added an enum
2303 for retrieve-limit errors.
2305 * src/modest-mail-operation.c: (foreach_add_item),
2306 (internal_folder_observer_update), (update_account_thread),
2307 (modest_mail_operation_get_msgs_full):
2308 (modest_mail_operation_update_account),
2309 Added comments about how this works, and some code that should
2310 (but does not) check the retrieve-limit. See the TODO comment.
2312 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2314 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2315 Initialize help_id to fix the build. Warnings are good.
2317 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2319 * src/widgets/modest-hbox-cell-renderer.c:
2320 (modest_hbox_cell_renderer_append):
2321 * src/widgets/modest-vbox-cell-renderer.c:
2322 (modest_vbox_cell_renderer_append):
2323 Fix the last commit by doing an extra ref.
2325 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2327 * src/widgets/modest-hbox-cell-renderer.c:
2328 (modest_hbox_cell_renderer_append):
2329 * src/widgets/modest-vbox-cell-renderer.c:
2330 (modest_vbox_cell_renderer_append):
2331 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2332 to fix the build with Maemo Bora.
2333 However, there seems to be a remaining crash, probably due to reference
2336 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2338 * src/modest-tny-account.c:
2339 (modest_tny_account_new_for_local_folders):
2340 Use hildon_file_system_info_async_new() to get a better name for
2341 the memory card account, setting it as the account name.
2342 The timing seems to work, but this is probably
2343 not the best place to do this. See the TODO comment.
2344 * src/maemo/modest-main-window.c: (create_details_widget):
2345 * src/widgets/modest-folder-view.c: (text_cell_data):
2346 Use the tny account name instead of hardcoding a name.
2348 2007-05-30 Christian Kellner <ckellner@openismus.com>
2350 * src/modest-search.c: (modest_search):
2351 Correctly set part_search_func even if we have already parsed
2352 the query and thus a valid OgsTextSearcher object.
2354 2007-05-30 Christian Kellner <ckellner@openismus.com>
2357 Search and check for libogs.
2360 Incooparte the ogs build env.
2362 * src/modest-mime-part-search-stream.c:
2363 * src/modest-mime-part-search-stream.h:
2364 Removed since we do the real searching now in modest-search.c.
2366 * src/modest-search.c:
2367 * src/modest-search.h:
2368 Implement support for ogs. We use that if available and requested
2369 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2370 should now handle the corner case when the search term is spread
2371 across multiple reads.
2372 Also the logic in modest_search () was corrected to search all
2373 requested fields until one is found.
2375 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2377 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2379 * src/modest-init.h:
2380 * src/modest-init.c: Made modest_init_local_folders() take a
2381 path and be public so we can iniitialize maildir folders on
2384 * src/modest-local-folder-info.h:
2385 * src/modest-local-folder-info.c:
2386 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2388 * src/modest-tny-account.c:
2389 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2390 still means the standard local-folders path on the local volume.
2392 * src/modest-tny-account-store.c:
2393 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2394 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2395 all accounts when that happens.
2396 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2397 this too, so it shows up in the treeview.
2399 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2401 * src/maemo/modest-maemo-global-settings-dialog.c:
2402 (current_connection):
2403 * src/widgets/modest-global-settings-dialog.c:
2404 (current_connection_default):
2405 Use the enum values instead of 0, 1 and -1,
2406 to make the code clearer.
2408 * src/modest-account-mgr-helpers.c:
2409 (modest_account_mgr_get_connection_specific_smtp): Make this code
2412 * src/modest-runtime.h:
2413 * src/modest-runtime.c:
2414 Added modest_runtime_remove_all_send_queues().
2415 * src/maemo/modest-main-window.c:
2416 (on_account_store_connecting_finished): Recreate the send queues,
2417 using the appropriate transport accounts for this new connection.
2418 Some futher adapting might be needed if the old send queues are not
2419 automatically stopped at this point.
2421 * src/modest-tny-account-store.c: (get_server_accounts):
2422 Create the connection-specific transport accounts, so that they can
2423 be found later by their ID.
2425 * src/modest-tny-account.h:
2426 * src/modest-tny-account.c:
2427 Added modest_tny_account_new_from_server_account_name().
2428 modest_tny_account_new_from_server_account(): Do not create the
2429 send queues here, because they will be
2430 recreated anyway when the connection changes for the first time.
2432 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2434 * src/modest-local-folder-info.h:
2435 * src/modest-local-folder-info.c:
2436 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2437 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2438 tbox_folder): Take a modest account name instead of a server TnyAccount,
2439 so we can have per-modest-account rather than per-transport-account
2441 We must make sure that we change or recreate the exisitng send queues
2442 when the connection changes for connection-specific transport accounts.
2444 * src/modest-tny-account-store.c:
2445 (create_per_account_local_outbox_folders): Create outboxed per modest
2446 account, not per transport account.
2448 * src/modest-tny-account.h:
2449 * src/modest-tny-account.c:
2450 (modest_tny_account_get_special_folder): For outboxes, get the
2451 parent modest account name. The account is ignored for other folders.
2452 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2453 modest account name rather than a server TnyAccount.
2455 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2457 * src/modest-tny-account.c:
2458 (modest_tny_account_new_from_server_account):
2459 Call modest_runtime_get_send_queue() immediately after creating transport
2460 accounts, so that they start trying to send email from the outbox as soon
2461 as possible at startup. This is probably what we want.
2463 * src/modest-mail-operation.c: (update_account_thread):
2464 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2465 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2466 * src/modest-tny-send-queue.h:
2467 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2468 (modest_ui_actions_on_send):
2469 Added comments about how sending works, though it needs some more work.
2471 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2473 * src/modest-tny-account.c:
2474 (modest_tny_account_get_special_folder): Add TODO because this fails when
2475 the network is busy.
2476 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2477 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2478 Do not try to show this window when there is no active account. The UI
2479 specs does not tell us what to do in this case.
2481 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2485 * src/maemo/Makefile.am:
2486 * src/widgets/Makefile.am: Some dist fixes.
2488 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2490 * src/maemo/modest-connection-specific-smtp-window.c:
2491 (on_button_edit): Make the code clearer, to prevent a double free.
2493 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/modest-account-settings-dialog.c:
2496 (modest_account_settings_dialog_set_account_name),
2497 Check the connection-specific smtp servers checkbox if there are any.
2499 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2500 (modest_connection_specific_smtp_edit_window_init):
2501 Start with a suitable port number.
2503 * src/modest-account-mgr-helpers.h:
2504 * src/modest-account-mgr-helpers.c: Added
2505 modest_account_mgr_get_has_connection_specific_smtp().
2507 (modest_account_mgr_set_connection_specific_smtp),
2508 (modest_account_mgr_remove_connection_specific_smtp),
2509 (modest_account_mgr_get_has_connection_specific_smtp),
2510 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2511 connection-specific smtp server accounts in the account, rather than
2512 the server account conf dir.
2514 This fixes bug projects.maemo.org bug NB#58263 .
2516 * src/modest-tny-account-store.c:
2517 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2518 if there are no server accounts yet, to prevent an infinite loop when there
2519 are no accounts. Document that one must be called before the other.
2521 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2523 * src/modest-account-mgr-helpers.c:
2524 (modest_account_mgr_get_default_account): Make sure that at least
2525 one account is always the default, if there are any enabled accounts.
2526 This is just a sanity check that shouldn't be necessary.
2528 * src/modest-account-mgr-priv.c:
2529 (_modest_account_mgr_account_from_key): Unescape the conf key to
2530 get the real account name. For instance, this is an issue if a space
2531 was in the account name, which can happen because the account name
2532 is generated from the display name.
2533 (_modest_account_mgr_get_account_keyname): Always escape the
2535 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2536 Unescape the conf keys to get the real account names.
2538 For instance, previously the is-default radio button in the accounts
2539 list was not checked for any accounts at first. This fixes that,
2540 and might fix several similar bugs.
2542 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2544 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2545 Removed some debug printfs.
2547 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2549 Modest on-disk outbox directories are now here, for instance:
2550 $HOME/.modest/outboxes/<account-id-1>/outbox
2551 $HOME/.modest/outboxes/<account-id-2>/outbox
2553 $HOME/.modest/local-folders/outbox
2554 so we can have a separate outbox for each account.
2555 But they are shown as one outbox in the GtkTreeView, by using a
2556 TnyMergeFolder in a ModestTnySimpleFolderStore.
2559 * src/modest-tny-simple-folder-store.c:
2560 * src/modest-tny-simple-folder-store.h:
2561 Added ModestTnySimpleFolderStore, used to contain folders from
2562 other folder stores, such as other accounts.
2564 * src/modest-tny-outbox-account.h:
2565 * src/modest-tny-outbox-account.c:
2566 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2567 used for the per-account local outbox folders.
2569 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2570 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2571 only use this (internally) now for the non-outbox local folders.
2573 * src/modest-init.h:
2574 * src/modest-init.c: Added modest_init_one_local_folder(), for
2575 setting up the directory structure for each local folder.
2577 * src/modest-local-folder-info.c:
2578 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2579 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2581 * src/modest-local-folder-info.h:
2582 * src/modest-tny-account-store.c: (on_account_removed),
2583 (on_account_changed), (create_per_account_local_outbox_folders),
2584 (get_server_accounts), (modest_tny_account_store_get_accounts),
2585 (modest_tny_account_store_get_tny_account_by_account),
2586 (modest_tny_folder_store_is_virtual_local_folders):
2588 * src/modest-tny-account.h:
2589 * src/modest-tny-account.c:
2590 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2591 to create an on-disk per-account local outbox folder for each
2593 (create_per_account_local_outbox_folders): Create a local outbox folder
2594 for each transport account.
2595 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2596 for all local folders.
2598 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2599 instead of using g_object_get/set() directly. It is clearer.
2601 (modest_tny_folder_store_get_message_count),
2602 (modest_tny_folder_store_get_local_size
2603 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2604 because we now use these with non-acount folder stores.
2606 (modest_tny_account_get_special_folder),
2607 (modest_tny_account_new_from_server_account),
2608 (modest_tny_account_new_from_account):
2609 (recurse_folders): Adjust to the new outbox system.
2611 * src/modest-tny-folder.h:
2612 * src/modest-tny-folder.c:
2613 (modest_tny_folder_is_local_folder),
2614 (modest_tny_folder_get_local_folder_type),
2615 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2617 * src/widgets/modest-main-window.h:
2618 * src/maemo/modest-main-window.c: (create_details_widget),
2619 (modest_main_window_set_contents_style): Show details for any folder store,
2622 (modest_tny_folder_get_rules):
2623 Remove the const. C does not support constness enough for this.
2625 * src/modest-ui-actions.c:
2626 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2627 make all outboxes appear as one, in the usual local-folders tree node.
2629 (set_active_account_from_tny_account),
2630 (modest_ui_actions_on_folder_selection_changed):
2631 * src/widgets/modest-folder-view.c: (text_cell_data),
2632 (icon_cell_data), (filter_row),
2633 (add_account_folders_to_merged_folder),
2634 (add_account_folders_to_simple_folder_store), (),
2635 (get_cmp_rows_type_pos), (cmp_rows),
2636 (modest_folder_view_set_account_id_of_visible_server_account):
2637 Adjust to the new outbox system, using generic folder stores and folders
2638 in the GtkTreeModel.
2640 2007-05-23 Christian Kellner <ckellner@openismus.com>
2642 * src/modest-mail-operation.c:
2643 (modest_mail_operation_update_account):
2644 Use info->max_size instead of unintialized local var [small
2645 build fix]. (Added TODO to review that change since I don't
2648 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2650 * libmodest-dbus-client/libmodest-dbus-client.c:
2651 (libmodest_dbus_client_compose_mail): function added
2652 * src/dbus_api/modest-dbus-api.h:
2653 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2654 (on_compose_mail): Implementation of the SendAsMail functionality
2656 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2658 * src/modest-account-mgr.c:
2659 (modest_account_mgr_add_server_account): Set the secure-connection
2660 conf key for transport accounts as well as store accounts. I don't know
2661 why the if was there. For instance, this makes sure that we use SSL
2662 for the gmail preset from the easysetup wizard.
2664 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2666 * src/gnome/modest-main-window.c:
2667 (on_account_store_connecting_finished), (connect_signals):
2668 * src/maemo/modest-main-window.c:
2669 (on_account_store_connecting_finished), (connect_signals),
2670 (modest_main_window_new):
2671 Handle TnyAccountStore::connecting-finished instead of
2672 TnyDevice::connection-changed, because we cannot actually perform
2673 operations on accounts until TnyAccountStore has itself responded to
2674 the TnyDevice::connection-changed signal. This prevents a GError from
2676 Do not try to update at startup, because we (at least on scratchbox)
2677 already do an update at startup when the device goes online.
2678 This prevents a GError from tinymail.
2679 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2680 Added TODO about stopping simultaneous operations.
2682 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2684 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2685 * src/modest-mail-operation-queue.c:
2686 (modest_mail_operation_queue_remove):
2687 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2688 about where they happened.
2690 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2692 * src/modest-ui-actions.c:
2693 (modest_ui_actions_on_password_requested): Make sure that the remember
2694 output parameter is always TRUE.
2696 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2698 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2699 Show a OK/Cancel dialog if the error is a question, though we still do not
2700 know anything more about what we are asking the user.
2701 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2702 Fix an uninitialized variable (helper). This is a logic error, however.
2704 2007-05-21 Christian Kellner <ckellner@openismus.com>
2706 * src/modest-search.h:
2707 Correct bit shifting in the ModestSearchFlags enum.
2709 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2711 * src/modest-tny-account.c:
2712 (modest_tny_account_new_from_server_account): Do not use the lsub and
2713 check-all hard-coded IMAP options when using POP.
2715 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2717 * src/modest-tny-account.c:
2718 (modest_tny_account_new_from_server_account):
2719 Use NULL for the secure-auth method for POP when Password auth has been
2720 specified by the user, as we already do for IMAP. "auth=Login" causes
2721 an error from camel or the server.
2723 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2725 * src/maemo/modest-account-settings-dialog.c:
2726 (create_page_account_details),
2727 (modest_account_settings_dialog_set_account_name):
2728 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2729 for the leave-on-server checkbox, rathr than just the checkbox, when
2730 the protocol is not POP.
2732 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2734 * src/widgets/modest-account-view.c:
2735 * src/widgets/modest-account-view.h:
2736 Added modest_account_view_select_account() which will be useful later
2737 to asynchronously re-select the edited account.
2739 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2741 * src/maemo/modest-account-settings-dialog.c:
2742 (modest_account_settings_dialog_set_account_name):
2743 Automatically choose the port numbers based on the secure authentication
2744 methods, if they have not been chosen before.
2745 This fixes projects.maemo.org bug NB#56273 .
2747 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2749 * src/maemo/modest-main-window-ui.h:
2750 * src/modest-ui-actions.c:
2751 * src/modest-ui-actions.h:
2752 Connect the Tools/SMTP Servers menu item to
2753 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2754 SMTP servers dialog, as in the UI specification and saves changes when it
2755 is closed. This fixed projects.maemo.org bug NB#56305 .
2757 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2759 * src/maemo/modest-connection-specific-smtp-window.c:
2760 (modest_connection_specific_smtp_window_init):
2761 Use gtk_window_set_default_size() to make this window big enough, so
2762 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2764 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2766 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2767 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2768 (modest_connection_specific_smtp_edit_window_init),
2769 Do not try to connect to a combobox signal before the combobox exists.
2770 This fixes the cras in projects.maemo.org bug NB#56288 .
2771 (modest_connection_specific_smtp_edit_window_get_settings):
2772 Remove the server_account_name parameter which was being checked for NULL
2773 though it was not used.
2775 * src/maemo/modest-connection-specific-smtp-window.c:
2776 (modest_connection_specific_smtp_window_fill_with_connections),
2777 (on_button_edit), (modest_connection_specific_smtp_window_init):
2778 Correct the number of treemodel columns to prevent a warning.
2779 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2780 libconic does not work.
2782 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2784 * src/modest-tny-account.c:
2785 (modest_tny_account_new_from_server_account):
2786 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2787 SMTP when "None" was chosen by the user. However, with my SMTP server that
2788 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2791 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2793 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2794 to explain the memory management issue with the ID in the ModestPair.
2796 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2797 (add_sending_page), (modest_account_assistant_finalize):
2798 * src/gnome/modest-gnome-global-settings-dialog.c:
2799 (create_updating_page), (create_composing_page):
2800 * src/gnome/modest-msg-edit-window.c: (get_transports),
2801 (init_window), (modest_msg_edit_window_finalize),
2802 (modest_msg_edit_window_get_msg_data):
2803 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2804 * src/gnome/modest-transport-widget.c:
2805 (modest_transport_widget_finalize), (smtp_configuration):
2806 * src/maemo/modest-maemo-global-settings-dialog.c:
2807 (create_updating_page), (create_composing_page):
2808 * src/maemo/modest-msg-edit-window.c: (get_transports),
2809 (init_window), (modest_msg_edit_window_finalize),
2810 (modest_msg_edit_window_get_msg_data),
2811 (modest_msg_edit_window_free_msg_data):
2812 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2813 (modest_store_widget_finalize):
2814 * src/maemo/modest-transport-widget.c:
2815 (modest_transport_widget_finalize), (smtp_configuration):
2816 * src/modest-main.c: (send_mail):
2817 * src/widgets/modest-combo-box.h:
2818 * src/widgets/modest-global-settings-dialog-priv.h:
2819 * src/widgets/modest-global-settings-dialog.c:
2820 (modest_global_settings_dialog_finalize):
2821 * src/widgets/modest-msg-edit-window.h:
2822 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2823 as long as the combo box, to prevent use of freed memory for the ID.
2825 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2827 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2828 get_accounts(), to make this clearer. Do not check for the enabled gconf
2829 key, because we do not use this for server accounts (at least, not yet).
2830 This allows us to send email again.
2832 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/modest-platform.c:
2835 (on_modest_conf_update_interval_changed), (modest_platform_init):
2836 Only respond to this particular key change. All these strcmp()s cannot be
2839 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2841 * src/maemo/modest-maemo-global-settings-dialog.c:
2842 (current_connection): Prevent a crash in scratchbox when
2843 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2844 * src/maemo/modest-platform.c:
2845 (on_modest_conf_update_interval_changed), (modest_platform_init):
2846 Get the update interval from gconf and reset it when the gconf key changes.
2848 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2850 * src/modest-protocol-info.c:
2851 * src/modest-protocol-info.h: Adde enum-specific get functions,
2852 instead of using a ModestProtocolType enum parameter.
2854 * src/gnome/modest-account-assistant.c:
2855 * src/gnome/modest-store-widget.c:
2856 * src/gnome/modest-store-widget.h:
2857 * src/gnome/modest-transport-widget.c:
2858 * src/gnome/modest-transport-widget.h:
2859 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2860 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2861 * src/maemo/easysetup/modest-easysetup-wizard.c:
2862 * src/maemo/modest-account-settings-dialog.c:
2863 * src/maemo/modest-account-settings-dialog.h:
2864 * src/maemo/modest-store-widget.c:
2865 * src/maemo/modest-store-widget.h:
2866 * src/maemo/modest-transport-widget.c:
2867 * src/maemo/modest-transport-widget.h:
2868 * src/modest-account-mgr-helpers.c:
2869 * src/modest-account-mgr-helpers.h:
2870 * src/modest-account-mgr.c:
2871 * src/modest-account-mgr.h:
2872 * src/modest-tny-account.c:
2873 * src/modest-tny-folder.c:
2874 * src/widgets/modest-account-view.c:
2875 * src/widgets/modest-retrieve-combo-box.c:
2876 * src/widgets/modest-retrieve-combo-box.h:
2877 * src/widgets/modest-secureauth-combo-box.c:
2878 * src/widgets/modest-serversecurity-combo-box.c:
2879 * src/widgets/modest-serversecurity-combo-box.h:
2880 * tests/check_account-mgr.c:
2881 Use the specific functions, and use the re-renamed enum values for GNOME too.
2883 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2885 * src/modest-pair.h:
2886 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2887 so we can get the second based on the first.
2889 * src/maemo/modest-account-settings-dialog.h:
2890 * src/maemo/modest-account-settings-dialog.c:
2891 Added get_supported_secure_authentication_methods(), though it is mostly
2892 commented-out for now until the necessary API is committed to tinymail.
2893 (modest_account_settings_dialog_set_account_name),
2894 (save_configuration): Request the supported authentication methods from the
2895 server, so we can choose a working method.
2897 * src/modest-tny-account-store.h:
2898 * src/modest-tny-account-store.c:
2899 (modest_tny_account_store_get_session): Rename from
2900 tny_account_store_get_session().
2902 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2904 * src/modest-protocol-info.h: Split the ModestProtocol enum
2905 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2906 There was no need to have these unrelated values in one enum.
2908 * src/: many files: Adapted to changed enum. This makes the code a bit
2909 clearer, and the compiler could catch some errors.
2911 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2913 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2914 Show the detailed internal camel error message when an error happens
2915 during the configuration, so that our testers can give us more clues.
2916 For instance, in projects.maemo.org bug NB#56910 .
2918 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2920 * src/modest-tny-account.c:
2921 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2922 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2924 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2926 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2927 * src/maemo/modest-account-settings-dialog.c:
2928 (modest_account_settings_dialog_set_account_name),
2929 (save_configuration): For the incoming secure authentication checkbox,
2930 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2931 the UI specification. PLAIN does not seem to be supported for most IMAP
2932 servers anyway, and I am not sure what it would mean.
2933 However, we probably need to discover which of the secure-authentication
2934 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2935 * src/modest-account-mgr-helpers.c:
2936 (modest_account_mgr_get_server_account_data):
2938 * src/modest-tny-account.c:
2939 (modest_tny_account_new_from_server_account):
2940 Use tny_account_set_mech() to set secure-authentication methods,
2941 with some special-casing for IMAP, based on my observations of how
2944 * src/modest-account-mgr-helpers.h:
2945 * src/modest-account-mgr.c:
2946 * src/modest-defs.h: Comment that the URI is only used for local folders.
2948 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2950 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2951 parameter const, just to be neat.
2952 * src/modest-text-utils.c: (modest_text_utils_inline):
2953 End g_strconcat() with NULL, as its documentation says. This is almost
2954 certainly the cause of my crash at startup on the device. Interestingly,
2955 valgrind doesn't tell us about these errors.
2957 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2959 * scripts/build-packages: Added more precise comments about how to use
2960 this script, though I still get this error:
2961 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2962 error building tinymail
2964 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2966 * src/maemo/modest-main-window.c: (on_account_update):
2967 Very slight cleanup, hoping to make it simpler to discover what causes
2968 a crash here sometimes.
2970 * src/modest-tny-account.c:
2971 (modest_tny_account_new_from_server_account): Set the port. Added
2972 comments about the options and a TODO comment because I need to find out
2973 how to specify the secure authentication method.
2975 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2977 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2978 changed CFlags paths form modest to libmodest
2980 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2982 * src/modest-account-mgr-helpers.c:
2983 (modest_account_mgr_get_server_account_data),
2984 (modest_account_mgr_free_server_account_data):
2985 * src/modest-account-mgr-helpers.h:
2986 * src/modest-account-mgr.c:
2987 (modest_account_mgr_add_server_account):
2988 * src/modest-defs.h:
2989 * src/modest-tny-account.c:
2990 (modest_tny_account_new_from_server_account):
2991 Determine the options for tny_camel_account_add_option() here,
2992 based on the settings, rather than storing them directly in gconf.
2994 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2996 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2997 Show a more friendly error dialog now that we expect (from the tinymail
2998 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3000 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3002 * src/maemo/modest-main-window.c: (on_account_update): Check that
3003 account_name is not NULL, to prevent a crash at startup that I am
3004 seeing on the N800. I do wonder why it is NULL.
3006 * src/maemo/easysetup/modest-easysetup-wizard.c:
3007 (create_page_user_details):
3008 * src/maemo/modest-account-settings-dialog.c:
3009 (create_page_user_details), (create_page_outgoing):
3010 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3011 (modest_connection_specific_smtp_edit_window_init):
3012 * src/modest-ui-actions.c:
3013 (modest_ui_actions_on_password_requested):
3014 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3015 might do something useful with the on-screen keyboard.
3017 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3019 * src/maemo/modest-main-window.c: (on_account_update):
3020 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3021 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3023 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3025 * src/modest-tny-account-store.c: (on_account_changed):
3026 Correct the signature of this signal handler.
3028 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3030 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3031 Show a HildonNote instead of a GtkDialog for Maemo.
3033 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3035 * src/widgets/modest-account-view.h:
3036 * src/widgets/modest-account-view.c: (on_account_changed),
3037 (on_account_removed). Added a boolean flag, set/unset by
3038 modest_account_view_block_conf_updates(),
3039 modest_account_view_unblock_conf_updates() to prevent unnecessary
3040 updates, but this is not very useful because the gconf notifications are
3041 so delays (maybe only on Maemo Bora).
3042 So auto-updating is turned off, and these functions do an explicit
3043 update when necessary.
3044 However, something else is still doing too much work when adding/removing
3045 accounts, probably in another part of the application.
3047 * src/maemo/modest-account-view-window.c:
3048 (on_delete_button_clicked), (on_edit_button_clicked),
3049 (on_new_button_clicked): Use the new functions.
3051 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3053 * src/modest-account-mgr-helpers.c:
3054 (modest_account_mgr_set_first_account_as_default):
3055 Sort the list of names alphabetically-by-title, so we choose the first one
3057 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3058 alphabetically by the title.
3060 This fixes projects.maemo.org bug NB#56418 .
3062 * src/modest-account-mgr-priv.c:
3063 (_modest_account_mgr_account_from_key):
3064 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3065 avoid a valgrind error, and possible random behaviour.
3067 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3069 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3070 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3071 tinymail documentation to say that this can be expected.
3072 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3073 pretty, and should not happen, but I would prefer to know when it does.
3075 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3077 * configure.ac: When using the older hildon version, probably on Bora,
3078 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3080 * src/widgets/modest-attachment-view.c:
3081 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3084 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3086 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3087 Implemented the prototype. Can be tested with
3088 tests/dbus_api/test_open_message:
3090 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3092 * src/modest-tny-account-store.c:
3093 (modest_tny_account_store_instance_init), (get_password):
3094 * src/modest-ui-actions.c:
3095 (modest_ui_actions_on_password_requested):
3096 Do not store the password in gconf, because this function is called
3097 for non-remembered passwords. Actually use the cached (in the hash map)
3098 password instead of releasing it.
3099 The password will now not be remembered if it is asked via the protected
3100 password dialog, as per the UI spec.
3102 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3104 * src/modest-defs.h:
3105 * src/modest-account-mgr-helpers.h:
3106 * src/modest-account-mgr-helpers.c:
3107 Added modest_server_account_get_username_has_succeeded(),
3108 modest_server_account_set_username_has_succeeded().
3109 (modest_server_account_set_username),
3110 Reset the has-succeeded flag if the username changes.
3112 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3113 * src/maemo/modest-connection-specific-smtp-window.c:
3114 (modest_connection_specific_smtp_window_save_server_accounts):
3115 Use modest_server_account_set_username() instead of using
3116 modest_conf_set_string() directly, so that the has-succeeded flag is always
3119 * src/modest-ui-actions.c:
3120 (modest_ui_actions_on_password_requested): Dim the username entry if
3121 the username has ever worked, as per the UI spec.
3123 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3125 * src/modest-tny-account-store.c: (get_password):
3126 * src/modest-ui-actions.c:
3127 (modest_ui_actions_on_password_requested):
3128 Allow the username to be changed too, though there is more work to
3129 be done on exactly how this behaves.
3131 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3133 * src/modest-account-mgr-helpers.h:
3134 * src/modest-account-mgr-helpers.c:
3135 Added modest_account_mgr_get_display_name(),
3136 modest_server_account_get_username(),
3137 modest_server_account_set_username(),
3138 modest_server_account_set_password(),
3139 modest_server_account_get_hostname() functions so we do not need to
3140 use the conf API directly.
3142 * src/maemo/modest-main-window.c: (connect_signals):
3143 Actually connect ot the ModestAccountStore::request-password signal,
3144 so that we show the dialog when the password is requested by Tinymail,
3145 for isntance if it is empty.
3147 * src/modest-marshal.list:
3148 * src/modest-tny-account-store.c:
3149 (modest_tny_account_store_class_init), (get_password),
3150 (modest_tny_account_store_alert):
3151 * src/modest-tny-account-store.h:
3152 * src/modest-ui-actions.h:
3153 * src/modest-ui-actions.c:
3154 (modest_ui_actions_on_password_requested):
3155 Change the signal parameters, so it is obvious that we are providing
3156 the non human-readable server name, and receiving both the username
3157 and password, though changing of the username is not yet implemented.
3158 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3159 for the GNOME version.
3161 This should fix the projects.maemo.org bug NB#56209, though it does not
3162 work on Bora, because the gconf_client_get() for the password fails
3163 immediately after we save it with gconf_client_set().
3165 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3168 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3169 caused an undefined symbol error:
3170 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3172 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3174 * src/modest-tny-account-store.c:
3175 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3176 using a GError instead of a string message, so we can translate it in
3179 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3181 * src/maemo/modest-address-book.c:
3182 (modest_address_book_check_names):
3183 * src/maemo/modest-msg-view-window.c:
3184 (modest_msg_view_window_clipboard_owner_change):
3185 * src/modest-init.c: (modest_init_init_ui):
3186 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3187 (update_folders_cb), (modest_mail_operation_update_account):
3188 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3189 (modest_ui_actions_on_msg_attachment_clicked),
3190 (modest_ui_actions_on_msg_recpt_activated):
3191 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3192 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3193 (modest_msg_view_search_next):
3194 * src/widgets/modest-recpt-editor.c:
3195 (modest_recpt_editor_on_button_release_event),
3196 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3197 g_message(). At this point we should only be seeing interesting errors on
3198 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3200 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3202 (modest_wizard_dialog_force_title_update):
3203 * src/maemo/easysetup/modest-wizard-dialog.h:
3204 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3205 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3206 can update the title when appropriate. Otherwise the title is wrong if the
3207 pages are added after adding the notebook to the dialog.
3208 This must be a problem in HildonWizardDialog too.
3209 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3211 * src/maemo/easysetup/modest-easysetup-wizard.c:
3212 (create_subsequent_customsetup_pages),
3213 (create_subsequent_easysetup_pages):
3214 Call modest_wizard_dialog_force_title_update() so that the title is
3215 correct even with GTK+ < 2.10.
3216 This fixes projects.maemo.org bug NB#56145 .
3218 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3220 * src/maemo/modest-platform.c:
3221 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3222 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3225 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3227 * src/widgets/modest-window.h:
3228 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3229 and modest_window_save_state(), which invokes it.
3231 * src/widgets/modest-window-mgr.h:
3232 * src/widgets/modest-window-mgr.c:
3233 Added modest_window_mgr_save_state_for_all_windows(), which calls
3234 the save_state vfunc on all registered windows, if implemented.
3236 * src/gnome/modest-msg-edit-window.c:
3237 * src/gnome/modest-msg-view-window.c:
3238 * src/maemo/modest-msg-edit-window.c:
3239 * src/maemo/modest-msg-view-window.c:
3240 * src/maemo/modest-main-window.c:
3241 Specify the existing save_settings functions as implementations of
3242 ModestWindow::save_state_func().
3244 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3245 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3246 enabling hibernation, for instance.
3248 We may need to do the same thing for restoring settings.
3251 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3253 * src/widgets/modest-window-mgr.c:
3254 * src/widgets/modest-window-mgr.h:
3255 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3256 modest_window_mgr_get_hibernation_is_prevented().
3258 * src/maemo/modest-main-window.c:
3259 (on_hildon_program_is_topmost_notify): Prevent hibernation
3260 (possible when the application goes to the background in the WM),
3261 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3263 * src/maemo/easysetup/modest-easysetup-wizard.c:
3264 (modest_easysetup_wizard_dialog_init):
3265 * src/maemo/modest-account-settings-dialog.c:
3266 (modest_account_settings_dialog_init):
3267 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3268 (modest_connection_specific_smtp_edit_window_init):
3269 * src/maemo/modest-connection-specific-smtp-window.c:
3270 (modest_connection_specific_smtp_window_init):
3271 * src/maemo/modest-signature-editor-dialog.c:
3272 (modest_signature_editor_dialog_init):
3273 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3274 prevent hibernation while any of these account settings dialogs are open.
3276 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3278 * src/maemo/Makefile.am:
3279 * src/maemo/modest-osso-state-saving.c:
3280 * src/maemo/modest-osso-state-saving.h: Added
3281 modest_osso_load_state() and modest_osso_save_state() though they do
3282 nothing now. They should iterate through all the open windows and load/save
3284 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3285 save state when closing.
3287 * src/maemo/modest-main-window.c:
3288 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3289 Add a notification handler for the HildonProgram::is-topmost property,
3290 so we can allow hibernation when the application goes into the background.
3291 But we still need to detect when the accounts setup windows are open so
3292 we can stop hibernation when they are open.
3293 To do this, I also added the main window the HildonProgram. This might have
3294 other side-effects/benefits, and should maybe be done for other windows.
3296 * src/maemo/modest-osso-autosave-callbacks.h:
3297 * src/maemo/modest-osso-autosave-callbacks.c:
3298 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3299 though it does not do anything yet, and we might never need this to do
3300 anything. For instance, we already save drafts.
3302 * src/maemo/modest-platform.c: (modest_platform_init):
3303 Specify the libosso auto-save callback.
3305 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3307 * src/maemo/modest-platform.c:
3308 (modest_platform_set_update_interval):
3309 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3310 aparently stays valid between application instances, so we can use this
3311 to remove and reset it later. According to a maemo-developers email from
3314 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3316 * configure.ac: Depend on libalarm for Maemo.
3318 * src/dbus_api/modest-dbus-api.h:
3319 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3320 (on_send_receive), (modest_dbus_req_handler):
3321 Handle a SEND_RECEIVE D-Bus method.
3323 * libmodest-dbus-client/libmodest-dbus-client.c:
3324 (libmodest_dbus_client_send_and_receive):
3325 * libmodest-dbus-client/libmodest-dbus-client.h:
3326 Add C convenience functions for calling the new D-Bus method.
3328 * src/modest-platform.h:
3329 * src/gnome/modest-platform.c:
3330 * src/maemo/modest-platform.c:
3331 Added modest_platform_set_update_interval(), which uses the
3332 alarmd API on Maemo.
3333 (modest_platform_init),
3334 Call modest_platform_set_update_interval(), using a hard-coded
3335 interval for now (until the global settings dialog is implemented),
3336 though I am not sure that this makes sense yet.
3338 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3340 * src/dbus_api/modest-dbus-callbacks.c:
3341 (modest_osso_cb_hw_state_handler):
3342 * src/dbus_api/modest-dbus-callbacks.h:
3343 * src/maemo/modest-platform.c: (modest_platform_init):
3344 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3345 in case this has some effect on the ability for Maemo to ping the
3348 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3350 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3351 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3352 warning. It is probably a logic error, but I need to fix the build.
3354 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3356 * src/modest-account-mgr.h:
3357 * src/modest-account-mgr.c:
3358 (modest_account_mgr_account_names): Add a gboolean enabled_only
3359 parameter, so we can get lists of onlt the enabled accounts.
3361 (modest_account_mgr_add_account),,
3362 (modest_account_mgr_account_with_display_name_exists):
3363 * src/maemo/modest-msg-edit-window.c: (get_transports):
3364 * src/modest-account-mgr-helpers.c:
3365 (modest_account_mgr_set_first_account_as_default):
3366 * src/modest-init.c: (init_default_account_maybe):
3367 * src/modest-tny-account-store.c: (get_accounts):
3368 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3369 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3370 * tests/check_account-mgr.c: (START_TEST):
3371 Provide the extra parameter, as appropriate.
3373 * src/widgets/modest-account-view.c: (update_account_view):
3374 Do not show disabled accounts (meaning that there is no way to
3375 enable/disable accounts in the UI (the feature is not in our UI
3376 specification), so we can use this internally only to mark unfinished
3377 or temporary account data.
3379 * src/maemo/easysetup/modest-easysetup-wizard.c:
3380 (create_account): Add boolean enable parameter, so we can specify FALSE
3381 to create the temporary account.
3382 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3383 (on_before_next): When finishing, when there is a temporary account, just
3385 Also, use a timeout to delay the showing of the dialog until gconf is likely
3386 to return correct information, due to a maemo gconf bug that is fixed in
3387 osso 1.1, but not yet in Bora.
3388 However, the dialog stays on screen after it is destroyed.
3390 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3391 for invalid data when cancelling. Use a hildon note instead of a dialog
3392 to complain about invalid data. Do not show the account-saved note if the
3393 account is disabled (a temporary account that will not really be saved for use
3396 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3398 * src/modest-account-mgr-helpers.h:
3399 * src/modest-account-mgr-helpers.c:
3400 Added modest_account_mgr_unset_default_account(),
3401 Added modest_account_mgr_set_first_account_as_default().
3403 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3404 If it was the default account, unset the default account name.
3406 * src/maemo/modest-account-view-window.c:
3407 (on_delete_button_clicked): If it was the default account,
3408 set the first remaining account as the default instead.
3410 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3411 a NULL account or a NULL default account, to prevent a crash. This should
3412 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3415 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3417 * src/widgets/modest-recpt-editor.c:
3418 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3419 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3420 TODO comment for this. This fixes the build.
3422 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3423 be the best place for it. This will in future update all auto-update accounts,
3424 rather than just the current/default account, when that gconf key exists.
3425 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3426 if there are no accounts, before calling do_send_receive().
3427 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3429 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3430 * src/maemo/modest-main-window-ui.h:
3431 * src/maemo/modest-main-window.c: (on_connection_changed),
3432 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3433 directly, becaue the signal handler does more.
3435 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3437 * src/modest-account-mgr-helpers.c:
3438 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3439 for the case that the account does not exist.
3441 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3442 (equivalent to the modest account name) rather than the tinymail account name
3443 (equivalent to the modest account title - human readable) to get the account data.
3444 Check for null account data to prevent the crash, and add a TODO comment saying that
3445 this needs fixing because it is using the server account name instead of the account name.
3447 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3449 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3450 * src/maemo/modest-account-settings-dialog.c: (show_error),
3452 Use hildon_note_new_information() for informative and error messages,
3453 which seems to be expected for Maemo applications (no documentation that I know of
3454 says this). I am surprised that there is no distinction between info and error
3457 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3459 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3460 it is easy to find where this is used.
3462 * src/maemo/easysetup/modest-easysetup-wizard.c:
3463 (create_page_welcome), (create_page_account_details),
3464 (create_page_user_details), (create_page_complete_easysetup),
3465 (create_page_custom_incoming), (create_page_custom_outgoing),
3466 (create_page_complete_custom):
3467 * src/maemo/modest-account-settings-dialog.c:
3468 (create_page_account_details), (create_page_user_details),
3469 (create_page_incoming), (create_page_outgoing):
3470 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3471 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3472 (modest_connection_specific_smtp_edit_window_init):
3473 * src/maemo/modest-connection-specific-smtp-window.c:
3474 (modest_connection_specific_smtp_window_init):
3475 * src/maemo/modest-signature-editor-dialog.c:
3476 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3477 and scrolling policy as per the Email Application Layout Guide, if I have
3480 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3482 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3483 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3484 which were empty, because these vfuncs have been removed from TnyAccountStore.
3485 This fixes the build.
3487 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3489 * src/maemo/modest-main-window.c:
3490 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3491 showing/hiding it. Added TODO because it probably should not be NULL.
3492 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3493 because unnecessary g_warnings() make degugging difficult.
3495 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3497 * src/maemo/modest-msg-edit-window.c:
3498 (modest_msg_edit_window_select_color),
3499 (modest_msg_edit_window_select_background_color): 2 const corrections and
3500 moving 2 #endifs before closing brackets, to fix the build.
3502 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3504 * src/maemo/easysetup/modest-easysetup-wizard.h:
3505 * src/maemo/easysetup/modest-easysetup-wizard.c:
3506 (modest_easysetup_wizard_dialog_finalize),
3507 (on_button_edit_advanced_settings), (create_page_complete_custom),
3508 (on_response), (create_account):
3509 Implement the Advanced Settings edit button, by saving the account information,
3510 for the Advanded Settings dialog to use directly from gconf, and removing it
3511 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3512 Bug #5533 in the projects.maemo.org bugzilla.
3514 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3516 * src/maemo/modest-msg-view-window.c:
3517 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3518 when opening a message window.
3520 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3522 * src/maemo/easysetup/modest-easysetup-wizard.c:
3523 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3526 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3527 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3528 gconf settings. I probably added more checks than necessary, but that is safer.
3530 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3531 variable to fix the build, but this seems to be used when it is still NULL.
3533 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3535 * src/modest-platform.h:
3536 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3537 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3538 * src/modest-main.c: Implement this function so we can avoid using
3539 maemo-specific API from cross-platform code.
3541 * src/modest-tny-account-store.c:
3542 (get_smtp_specific_transport_account_for_open_connection):
3543 * src/modest-ui-actions.c: (check_for_connection),
3544 (modest_ui_actions_on_item_not_found):
3545 Use modest_platform_connect_and_wait() and put #idefs around other
3546 maemo-specific code, because only maemo currently has a way to
3547 identify connection names.
3549 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3551 * src/modest-tny-account-store.h:
3552 * src/modest-tny-account-store.c:
3553 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3554 the connection-specific SMTP server settings in the configuration.
3556 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3558 * src/maemo/modest-main-window.c: (on_connection_changed),
3560 * src/modest-main.c: (main), (start_ui), (send_mail):
3561 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3562 that is what is intended.
3564 * src/modest-ui-actions.c: (action_send), (action_receive),
3565 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3566 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3567 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3568 SMTP server is used when it is specified.
3570 (modest_ui_actions_on_send_receive):
3571 Check that a connection is open before proceeding.
3572 Receive and then send, instead of vice-versa, as per the specification.
3574 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3576 * src/modest-mail-operation.c:
3577 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3578 though I guess it should be something other than NULL.
3580 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3582 * src/maemo/easysetup/modest-easysetup-wizard.c:
3583 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3584 combo twice, to avoid an g_warning and to make it visible again.
3585 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3586 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3587 (already intended) dereference when detaching, because we then recreate the menu.
3588 But I am not sure why the warning was happening, and it is possible that this is a memory
3591 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3593 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3594 and uri_parse_mailto() utility functions.
3595 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3597 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3599 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3601 * src/dbus_api/modest-dbus-api.h:
3602 * src/dbus_api/modest-dbus-callbacks.c:
3603 Use an idle callback to execute the modest code in the application's own thread.
3604 Remove the helloworld example method.
3605 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3606 parsed, and the open-message method is not implemented because this is not yet implemented in
3608 * libmodest-dbus-client/libmodest-dbus-client.c:
3609 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3610 (libmodest_dbus_client_open_message):
3611 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3613 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3614 body without crashing.
3616 * tests/dbus_api/Makefile.am:
3617 * tests/dbus_api/test_mail_to.c:
3618 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3620 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3622 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3623 Added file to fix the build. Sorry.
3625 * src/dbus_api/Makefile.am:
3626 * src/dbus_api/modest-dbus-api.h:
3627 * src/dbus_api/modest-dbus-callbacks.h:
3628 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3629 (modest_dbus_req_handler):
3630 Put constants in a separate header so it can be reused by the
3631 client library, without duplication
3633 * libmodest-dbus-client/Makefile.am:
3634 * libmodest-dbus-client/libmodest-dbus-client.c:
3635 (libmodest_dbus_client_call_helloworld),
3636 (libmodfest_dbus_client_send_mail),
3637 (libmodfest_dbus_client_mailto),
3638 (libmodfest_dbus_client_open_message):
3639 * libmodest-dbus-client/libmodest-dbus-client.h:
3640 (Partly) Implement a send_mail D-Bus method.
3642 * tests/dbus_api/Makefile.am:
3643 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3644 the send_email D-Bus method.
3646 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3650 * libmodest-dbus-client/Makefile.am:
3651 * libmodest-dbus-client/libmodest-dbus-client.c:
3652 * libmodest-dbus-client/libmodest-dbus-client.h:
3653 * tests/dbus_api/Makefile.am:
3654 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3655 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3657 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3659 * src/maemo/easysetup/modest-easysetup-wizard.c:
3660 (create_page_account_details):
3661 * src/maemo/modest-account-settings-dialog.c:
3662 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3663 widgets, because this might not be the default in future versions of the Maemo GTK+.
3664 However, I can not not get capitalization to work even in a simple test case.
3666 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3668 * src/maemo/easysetup/modest-easysetup-wizard.c:
3669 (create_page_custom_incoming), (create_page_custom_outgoing):
3670 * src/maemo/modest-account-settings-dialog.c:
3671 (create_page_account_details), (create_page_incoming),
3672 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3673 instead of using gtk_check_button_with_label(), so they are aligned like the other
3674 widgets, as per the UI spec.
3676 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3678 * src/maemo/easysetup/modest-easysetup-wizard.c:
3679 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3680 * src/widgets/modest-validating-entry.c:
3681 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3682 Modest prefix instead of an EasySetup prefix.
3684 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3686 * src/widgets/modest-validating-entry.h:
3687 * src/widgets/modest-validating-entry.c: (on_insert_text),
3688 Added easysetup_validating_entry_set_max_func(), used to set a callback
3689 to call when the max number of characters is reached. GtkEntry has a max-length
3690 already but is silent about it.
3692 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3693 (create_page_account_details), (create_page_user_details),
3695 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3696 (create_page_account_details), (create_page_user_details),
3697 (create_page_outgoing):
3698 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3699 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3700 the UI spec, when the user tries to enter more than the max number of characters.
3702 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3704 * src/maemo/easysetup/modest-easysetup-wizard.c:
3705 (create_page_user_details), (create_page_custom_incoming),
3706 (create_page_custom_outgoing):
3707 * src/maemo/modest-account-settings-dialog.c:
3708 (create_page_user_details), (create_page_incoming),
3709 (create_page_outgoing):
3710 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3711 (modest_connection_specific_smtp_edit_window_init):
3712 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3713 not appropriate. Bad Maemo-specific defaults!.
3715 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3717 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3718 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3719 (modest_signature_editor_dialog_set_settings):
3720 Disable the label and textview when the checkbox is disabled, and use the
3721 specified (UI spec) default signature text.
3723 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3726 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3728 * src/modest-defs.h:
3729 * src/modest-account-mgr-helpers.h:
3730 * src/modest-account-mgr-helpers.c:
3731 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3733 * src/maemo/Makefile.am:
3734 * src/maemo/modest-signature-editor-dialog.c:
3735 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3738 * src/maemo/modest-account-settings-dialog.h:
3739 * src/maemo/modest-account-settings-dialog.c:
3740 (modest_account_settings_dialog_finalize), (on_button_signature),
3741 (save_configuration): Use the new dialog when the Edit button is pressed, and
3742 save the changes if necessary, as per the UI spec.
3744 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/Makefile.am:
3747 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3748 based on maemo-develoers email from Dirk.
3750 * src/maemo/easysetup/modest-easysetup-wizard.c:
3751 (create_page_welcome), (create_page_account_details),
3752 (create_page_user_details), (create_page_complete_easysetup),
3753 (create_page_custom_incoming), (create_page_custom_outgoing),
3754 (create_page_complete_custom),
3755 (modest_easysetup_wizard_dialog_init):
3756 * src/maemo/modest-account-settings-dialog.c:
3757 (create_page_account_details), (create_page_user_details),
3758 (create_page_incoming), (create_page_outgoing),
3759 (modest_account_settings_dialog_init):
3760 * src/maemo/modest-connection-specific-smtp-window.c:
3761 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3763 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3765 * src/maemo/easysetup/modest-easysetup-wizard.c:
3766 (create_page_account_details), (create_page_custom_outgoing),
3767 (create_page_complete_custom):
3768 * src/maemo/modest-account-settings-dialog.c:
3769 (create_page_user_details), (create_page_incoming),
3770 (create_page_outgoing):
3771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3772 (modest_connection_specific_smtp_edit_window_init):
3773 Use the correct (UI spec) port min/max, and use horizontal separators,
3776 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3778 * src/maemo/easysetup/modest-easysetup-wizard.c:
3779 (set_default_custom_servernames):
3780 * src/maemo/modest-account-settings-dialog.c:
3781 (create_page_incoming), (on_combo_outgoing_security_changed),
3782 (on_combo_incoming_security_changed), (create_page_outgoing),
3783 (modest_account_settings_dialog_set_account_name),
3784 (save_configuration):
3785 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3786 (on_combo_security_changed),
3787 (modest_connection_specific_smtp_edit_window_init),
3788 (modest_connection_specific_smtp_edit_window_set_connection),
3789 (modest_connection_specific_smtp_edit_window_get_settings):
3790 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3793 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3796 * src/maemo/easysetup/modest-easysetup-wizard.c:
3797 (create_page_custom_outgoing), (create_page_complete_custom):
3798 * src/maemo/modest-account-settings-dialog.c:
3799 (create_page_user_details), (create_page_outgoing):
3800 * src/maemo/modest-account-view-window.c: (button_box_new):
3801 Use changed logical IDs as per the most recent UI spec:
3802 mcen_bd_emailsetup_edit -> mcen_bd_edit
3803 mcen_bd_emailsetup_delete -> mcen_bd_delete
3804 mcen_bd_emailsetup_close -> mcen_bd_close
3806 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3810 * src/dbus_api/Makefile.am:
3811 * src/dbus_api/modest-dbus-callbacks.c:
3812 * src/dbus_api/modest-dbus-callbacks.h:
3813 * src/maemo/modest-platform.c: (modest_platform_init):
3814 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3816 * tests/Makefile.am:
3817 * tests/dbus_api/Makefile.am:
3818 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3820 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3822 * src/maemo/modest-account-settings-dialog.c:
3823 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3824 Removed unnecessary includes.
3826 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3828 * src/maemo/easysetup/modest-easysetup-wizard.c:
3829 * src/maemo/modest-account-settings-dialog.c:
3830 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3831 * src/widgets/Makefile.am:
3832 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3833 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3834 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3835 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3836 * src/widgets/modest-secureauth-combo-box.c:
3837 * src/widgets/modest-secureauth-combo-box.h:
3838 * src/widgets/modest-serversecurity-combo-box.c:
3839 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3840 made the GObject names more consistent with the rest of the Modest code.
3842 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3844 * src/maemo/easysetup/Makefile.am:
3845 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3846 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3847 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3848 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3849 * src/maemo/easysetup/modest-easysetup-wizard.c:
3850 * src/maemo/easysetup/modest-validating-entry.c:
3851 * src/maemo/easysetup/modest-validating-entry.h:
3852 * src/maemo/modest-account-settings-dialog.c:
3853 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3854 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3855 widgets/ because they are used outside of easysetup too. After checking in,
3856 svn will allow me to rename them too.
3858 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3860 * src/gnome/modest-msg-edit-window.c:
3861 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3862 linker error, to fix the build on the GNOME platform.
3863 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3864 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3865 ifdefed out to avoid a warning.
3867 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3869 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3870 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3871 some alternative for GTK+ 2.6.
3873 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3875 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3877 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3878 specified for EmailAccountsDialog in UI spec.
3880 * src/maemo/easysetup/modest-easysetup-wizard.c:
3881 * src/maemo/easysetup/modest-easysetup-wizard.h:
3882 * src/maemo/modest-account-settings-dialog.c:
3883 * src/maemo/modest-account-settings-dialog.h:
3884 Reuse a member window widget for the connection-specific SMTP server accounts,
3885 so we can tell it to create/save the accounts only if we actually save changes.
3887 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3889 (modest_connection_specific_smtp_edit_window_get_settings):
3890 Return a struct instance for temporarily remembering the entered data.
3892 * src/maemo/modest-connection-specific-smtp-window.h:
3893 * src/maemo/modest-connection-specific-smtp-window.c:
3894 (modest_connection_specific_smtp_window_finalize),
3895 (modest_connection_specific_smtp_window_fill_with_connections),
3897 (modest_connection_specific_smtp_window_save_server_accounts),
3898 (update_model_server_names): Do not actually save data until asked,
3899 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3901 (on_selection_changed),
3902 (modest_connection_specific_smtp_window_init): Disable the edit
3903 button when nothing is selected.
3905 * src/modest-account-mgr-helpers.c:
3906 * src/modest-account-mgr-helpers.h:
3907 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3910 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3912 * src/modest-account-mgr-helpers.h:
3913 * src/modest-account-mgr-helpers.c:
3914 (modest_account_mgr_get_unused_account_name),
3915 (modest_account_mgr_get_unused_account_display_name): Added these
3916 utility functions, to avoid code duplication.
3918 * src/maemo/easysetup/modest-easysetup-wizard.c:
3919 (create_page_account_details), (create_account):
3920 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3921 (on_combo_security_changed),
3922 (modest_connection_specific_smtp_edit_window_init),
3923 (modest_connection_specific_smtp_edit_window_save_settings):
3924 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3925 * src/maemo/modest-connection-specific-smtp-window.c:
3926 (modest_connection_specific_smtp_window_finalize),
3927 (modest_connection_specific_smtp_window_fill_with_connections),
3928 (on_button_edit), (modest_connection_specific_smtp_window_init):
3929 * src/maemo/modest-connection-specific-smtp-window.h:
3930 Implementing saving of connection-specific server accounts.
3932 But I need to refactor this so we can save the data for each
3933 possible connection-specific account and only actually create the server accounts
3934 when the easysetup finished, or the OK button is pressed on the account settings
3937 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3939 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3940 (on_combo_security_changed):
3941 (modest_connection_specific_smtp_edit_window_init):
3942 Auto-fill the port number as in the account settings.
3944 (modest_connection_specific_smtp_edit_window_set_connection):
3945 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3946 * src/maemo/modest-connection-specific-smtp-window.c:
3947 (fill_with_connections), (on_button_edit),
3948 (modest_connection_specific_smtp_window_init):
3949 Turn the edit window into a dialog to simplify the code, and
3950 set a WM hint as in a GtkDialog, because only a popup can be on top of
3951 another window in Maemo, and popups usually have no WM decoration.
3953 * src/modest-defs.h:
3954 * src/modest-account-mgr-helpers.c:
3955 (modest_account_mgr_set_connection_specific_smtp),
3956 (modest_account_mgr_remove_connection_specific_smtp),
3957 (modest_account_mgr_get_connection_specific_smtp):
3958 * src/modest-account-mgr-helpers.h: Some functions to write the
3959 connection-specific SMTP server information. Not yet used.
3962 * src/widgets/modest-folder-view.c: (text_cell_data):
3963 Fix a warning about an uninitialized variable.
3964 (on_configuration_key_changed): Put an #ifdef around the use
3965 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3967 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3969 * src/maemo/modest-account-settings-dialog.h:
3970 * src/maemo/modest-account-settings-dialog.c:
3971 Added connect_for_modified() utility function to mark the new modified boolean.
3973 (create_page_account_details), (create_page_user_details),
3974 (create_page_incoming), (create_page_outgoing), (on_response),
3975 (modest_account_settings_dialog_init),
3976 (modest_account_settings_dialog_set_account_name):
3977 Only warn about unsaved changes when there are actually unsaved changes.
3979 * src/modest-account-mgr-helpers.c:
3980 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3981 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3982 to get the data from there in future.
3984 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3986 * src/modest-defs.h:
3988 * src/modest-account-mgr-helpers.h:
3989 * src/modest-account-mgr-helpers.c:
3990 Store the security account setting in a single conf key instead of using
3991 the options list, so that the list is left for just the to-be-removed camel hack,
3992 and because gconf_client_set_list() is failing for some reason.
3994 * src/modest-account-mgr.c:
3995 (modest_account_mgr_add_server_account):
3996 * src/maemo/modest-account-settings-dialog.c:
3997 (modest_account_settings_dialog_set_account_name),
3998 (save_configuration): Use the renamed functions.
4001 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4003 * src/widgets/Makefile.am:
4004 * src/widgets/modest-limit-retrieve-combo-box.c:
4005 * src/widgets/modest-limit-retrieve-combo-box.h:
4006 * src/widgets/modest-retrieve-combo-box.c:
4007 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4008 the account settings dialog.
4010 * src/modest-defs.h:
4011 * src/modest-account-mgr-helpers.h:
4012 * src/modest-account-mgr-helpers.c:
4013 (modest_server_account_get_option_secure_auth),
4014 (modest_server_account_set_option_secure_auth):
4015 * src/modest-account-mgr.c:
4016 (modest_account_mgr_add_server_account):
4017 Use the existing AUTH_MECH conf key for the secure-auth setting,
4018 instead of putting it in the list options, because this was actually used already.
4020 * src/maemo/modest-account-settings-dialog.c:
4021 (create_page_account_details),
4022 (modest_account_settings_dialog_set_account_name),
4023 (save_configuration):
4024 * src/maemo/modest-account-settings-dialog.h:
4025 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4026 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4028 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4030 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4031 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4032 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4034 * src/modest-defs.h:
4035 * src/maemo/modest-account-settings-dialog.c:
4036 (create_page_incoming), (on_combo_outgoing_security_changed),
4037 (on_combo_incoming_security_changed), (create_page_outgoing),
4038 (modest_account_settings_dialog_set_account_name),
4039 (save_configuration): Load/Save the port number, and change it when the
4040 security combo changes, to suitable defaults.
4042 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4044 * src/modest-account-mgr.c:
4045 (modest_account_mgr_add_server_account): Set the security and secure-auth
4046 options, and add a comment saying that the other camel-specific options should be
4049 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4051 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4053 * src/modest-tny-account-store.c: (account_list_free),
4054 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4055 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4058 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4060 * src/modest-protocol-info.c:
4061 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4062 is required by our UI spec. Maybe something in our implementation will use this eventually.
4063 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4064 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4065 instead of the previous 0 placeholder.
4067 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4068 secure-auth settings.
4069 * src/modest-account-mgr-helpers.h:
4070 * src/modest-account-mgr-helpers.c:
4071 (modest_server_account_data_get_option_secure_auth),
4072 (modest_server_account_set_option_secure_auth),
4073 (modest_server_account_data_get_option_security),
4074 (modest_server_account_set_option_security): Added this API for getting and setting the security
4075 and secure-auth settings.
4077 * src/maemo/modest-account-settings-dialog.h:
4078 * src/maemo/modest-account-settings-dialog.c:
4079 (modest_account_settings_dialog_finalize), (check_data),
4080 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4081 about changing titles.
4082 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4083 (save_configuration): Save the security and secure-auth settings.
4085 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4086 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4088 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4090 * src/modest-defs.h:
4091 * src/modest-account-mgr.c:
4092 (modest_account_mgr_add_server_account):
4093 Added and used defines for the options key and value pair strings,
4094 that are used so far, though they do not seem to correspond to anything in our
4095 UI specs or ModestProtocol enum.
4097 * src/modest-account-mgr-helpers.h:
4098 * src/modest-account-mgr-helpers.c:
4099 (compare_option_strings_for_name),
4100 (modest_server_account_data_get_option_value),
4101 (modest_server_account_data_get_option_bool),
4102 (modest_account_mgr_get_server_account_option):
4103 Added helper functions for parsing the options GSList.
4105 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4107 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4108 display name is based on the supplied account name.
4109 * src/modest-account-mgr.c:
4110 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4111 with an inefficient, but good-enough, implementation.
4113 * src/maemo/easysetup/modest-easysetup-wizard.c:
4114 (create_page_account_details), (on_before_next), (create_account):
4115 Check for existing display names rather than (non-user-visible) account names, and just
4116 create and set a unique account name at the end.
4118 * src/maemo/modest-account-settings-dialog.c:
4119 (modest_account_settings_dialog_init),
4120 (modest_account_settings_dialog_set_account_name),
4121 (create_page_incoming): Show the display name, instead of the account name.
4122 (on_response): Do some (not all) extra checks, as in the UI spec.
4123 (save_configuration): Save the display name if it was changed.
4125 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4127 * po/en_GB.po: Added needed logical ID and translation.
4128 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4129 (init_view): Made the is-default column clicking work.
4131 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4134 * src/maemo/easysetup/Makefile.am:
4135 * src/maemo/easysetup/modest-easysetup-wizard.c:
4136 (modest_easysetup_wizard_dialog_init):
4137 * src/maemo/easysetup/provider-data-test.keyfile:
4138 * src/maemo/easysetup/provider-data.keyfile:
4139 Moved the provider data file to the new modest-providers-data package and used it from there.
4141 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4143 * src/modest-local-folder-info.c:
4144 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4145 N_() was already used on the static strings, but this just marks it for translation without
4146 using the translation.
4148 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4150 * src/maemo/modest-account-settings-dialog.c:
4151 (create_page_incoming),
4152 (modest_account_settings_dialog_set_account_name):
4153 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4154 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4155 I will do this if nobody else gets there first.
4157 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4159 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4160 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4161 save the security stuff.
4163 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4165 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4166 Set the email address and user fullname, which I now see must be
4169 * src/maemo/modest-account-settings-dialog.h:
4170 * src/maemo/modest-account-settings-dialog.c:
4172 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4173 leave-on-server and authentication.
4174 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4177 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4180 * src/maemo/modest-account-settings-dialog.c:
4181 * src/maemo/modest-account-settings-dialog.h:
4182 Most (but not all) of the widgets are now present as specified by the UI spec.
4183 No changes are yet saved, and some details are not properly shown yet.
4185 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4187 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4189 * src/maemo/Makefile.am:
4190 * src/maemo/modest-account-settings-dialog.c:
4191 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4192 an existing account. Doesn't do much yet.
4194 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4195 Open the accounts settings dialog when Edit is clicked.
4197 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4199 * src/maemo/easysetup/Makefile.am:
4200 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4202 * src/maemo/easysetup/modest-easysetup-wizard.c:
4203 (modest_easysetup_wizard_dialog_init):
4204 Try to get the source directory from the build system,
4205 instead of hard-coding "./" into the source code, when opening our local
4206 copies of the configuration files.
4207 But this still fails when opening the wizard from the Accounts window,
4208 maybe because the working directory seems to change at runtime.
4209 So the wizard will fail the second time unless you copy the files into their
4210 proper locations - see the stdout warnings for the paths.
4212 (create_page_account_details),(on_before_next):
4213 Check for existing non-server accounts instead of server accounts,
4214 so the default account name is useful again, and to prevent trying to
4217 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4218 Show the wizard when New is clicked.
4220 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4221 (init_view): Show the column headers, and show the columns that are
4222 specified in the UI specs. However, something in Maemo's GTK+ prevents
4223 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4224 change the default account. This is despite unsetting the special properties.
4226 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4228 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4229 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4230 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4231 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4232 to make that clearer.
4233 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4235 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4237 * src/maemo/modest-account-view-window.c:
4238 (modest_account_view_window_init),
4239 (modest_account_view_window_new):
4240 Use the same buttons as specified in the
4241 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4242 the existing widgets, which never had a chance of working.
4243 Put the ModestAccountView treeview in a scrolled window.
4244 Do not repeat the initialization in both _init() and _new().
4246 * src/widgets/modest-account-view.c: (update_account_view):
4247 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4248 this widget and window shows no accounts.
4250 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4252 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4254 * src/maemo/easysetup/modest-easysetup-wizard.c:
4255 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4256 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4257 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4260 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4261 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4262 accounts exist yet, as in the UI spec.
4264 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4266 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4268 * src/maemo/Makefile.am:
4269 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4270 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4271 New window for editing connection-specific smtp details.
4272 Not fully implemented.
4274 * src/maemo/modest-connection-specific-smtp-window.c:
4275 (modest_connection_specific_smtp_window_finalize) :
4276 unref the tree model.
4277 (on_button_edit): Show the edit window.
4279 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4281 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4284 * src/maemo/Makefile.am:
4285 * src/maemo/modest-connection-specific-smtp-window.c:
4286 * src/maemo/modest-connection-specific-smtp-window.h:
4287 New window for showing the list of connections, for connection-specific
4288 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4289 * src/maemo/easysetup/modest-easysetup-wizard.c:
4290 (create_page_custom_outgoing): Show the new window when the button is clicked.
4292 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4294 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4295 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4296 * src/maemo/modest-msg-edit-window.c:
4297 (modest_msg_edit_window_insert_image):
4298 * src/modest-conf.c: (modest_conf_key_escape):
4299 * src/modest-mail-operation.c:
4300 (modest_mail_operation_send_new_mail):
4301 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4302 (modest_ui_actions_on_new_account):
4303 * src/widgets/modest-attachment-view.c: (update_filename_request):
4304 * src/widgets/modest-mail-header-view.c:
4305 Corrected warnings that were breaking the build, by commenting out unused variables,
4306 and a function, and by including a header.
4308 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4310 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4311 so we can #ifdef around platform-specific code when necessary.
4312 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4313 to allow this to build for the GNOME platform too.
4315 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4317 * src/maemo/easysetup/modest-easysetup-wizard.c:
4318 Added util_increment_name() and used it in create_page_account_details()
4319 to make sure that the default account name is always a new name.
4321 (modest_easysetup_wizard_dialog_init),
4322 (set_default_custom_servernames): Some minor memory management fixes.
4324 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4328 * src/modest-runtime.c: (init_i18n): Restored the translation
4329 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4330 are defined in config.h, and the translations are installed.
4332 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4333 is defined for translation.
4335 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4337 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4339 * src/maemo/easysetup/modest-easysetup-wizard.c:
4340 (modest_easysetup_wizard_dialog_init):
4341 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4342 Use realistic paths (though they should use $prefix generically) to the
4343 mcc_mapping and provider-data.keyfile files which might work when they
4344 are installed by the future version of the operator-wizard package,
4345 and then fallback to paths in our source code, with an explanatory
4348 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4352 * src/maemo/Makefile.am:
4353 * src/maemo/easysetup/: Added files from the previously-exernal
4354 osso-modest-easysetup.
4355 * src/maemo/modest-main-window-ui.h:
4356 * src/modest-ui-actions.c:
4357 * src/modest-ui-actions.h:
4358 Added modest_ui_actions_on_new_account() as a signal handler for the
4359 New Account menu item. It shows the easysetup wizard.
4360 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob