1 2007-06-25 Armin Burgmeier <armin@openismus.com>
3 * src/widgets/modest-window-mgr.c:
5 * configure.ac: Correctly recognize hildon-notify presence and fixed
6 the build without it being installed.
8 2007-06-25 Murray Cumming <murrayc@murrayc.com>
10 * libmodest-dbus-client/libmodest-dbus-client.c:
11 (libmodest_dbus_client_search): Fix the build. Sorry.
12 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
13 (reply_forward_cb): Initialize variables to fix the build.
15 * src/modest-tny-account-store.c:
16 (modest_tny_account_store_get_tny_account_by): Fix the account URI
17 comparison (a silly typo) so that email search results can be opened
18 when there are more than one account.
20 2007-06-25 Murray Cumming <murrayc@murrayc.com>
22 * libmodest-dbus-client/libmodest-dbus-client.c:
23 (libmodest_dbus_client_search),
24 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
25 instead of 1 second, because the search gets folders and messages from
26 the server, which can take a long time. When it times out,
27 osso-global-search will report no results.
29 We need to specify whether we should search only cached information
30 (maybe with a user preference), and the osso-email-search-plugin
31 API should really be improved to allow that option, and to allow results
32 to be delivered asynchronously in batches.
34 2007-06-25 Murray Cumming <murrayc@murrayc.com>
36 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
37 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
38 GTK_ICON_SIZE_DIALOG is probably the wrong size.
40 2007-06-25 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
43 that is an empty string. D-Bus seems to give us these instead of NULL.
45 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
47 * src/dbus_api/modest-dbus-callbacks.c:
48 * src/maemo/easysetup/modest-easysetup-wizard.h:
49 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
50 * src/maemo/modest-connection-specific-smtp-edit-window.c:
51 (modest_connection_specific_smtp_edit_window_init):
52 * src/maemo/modest-maemo-global-settings-dialog.c:
54 * src/maemo/modest-maemo-utils.c:
55 (modest_maemo_utils_setup_images_filechooser):
56 * src/maemo/modest-main-window.c: (create_details_widget):
57 * src/maemo/modest-msg-edit-window.c:
58 (modest_msg_edit_window_attach_file_noninteractive),
59 (modest_msg_edit_window_color_button_change),
60 (modest_msg_edit_window_set_zoom):
61 * src/modest-mail-operation.c: (update_account_thread):
62 * src/modest-tny-account-store.c:
63 * src/modest-tny-account.c:
64 * src/widgets/modest-global-settings-dialog.c:
65 * src/widgets/modest-window.h:
69 2007-06-25 Murray Cumming <murrayc@murrayc.com>
71 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
72 * src/modest-search.c: (modest_search_folder),
73 (modest_search_all_accounts): Actually search only in the specified folder,
74 doing a simple match on the folder ID.
75 * src/modest-search.h: Added a folder field to the ModestSearch struct,
76 and added some documentation.
78 2007-06-22 Armin Burgmeier <armin@openismus.com>
80 * src/maemo/modest-maemo-utils.h:
81 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
82 modest_maemo_utils_get_supported_secure_authentication_methods.
84 * src/maemo/easysetup/modest-easysetup-wizard.c:
85 * src/maemo/modest-account-settings-dialog.c: Show correct error if
86 one occured, not just "Server does not support secure authentication".
88 2007-06-22 Murray Cumming <murrayc@murrayc.com>
90 * src/modest-tny-account-store.c: (get_password):
91 Restored the call to tny_account_set_user() because Philip seems to have
92 stopped this from crashing (by not using the freed string). It still does
93 not work, but now we can test it.
95 2007-06-22 Murray Cumming <murrayc@murrayc.com>
97 * src/maemo/modest-msg-edit-window.c: (init_window):
98 Comment out use of an uninitialzed GtkScrolledWindow variable,
99 to fix the build and stop a crash. Yet again.
101 2007-06-22 Murray Cumming <murrayc@murrayc.com>
103 * src/modest-tny-account-store.c: (get_password):
104 Remove the call to tny_account_set_user() because this actually crashes.
105 As mentioned in the last commit, it is known to not work anyway.
107 2007-06-22 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-tny-account-store.c: (get_password):
110 Use tny_account_set_username() to tell tinymail that the username might
111 have changed too. But tinymail ignores this: see projects.maemo.org
113 * src/modest-ui-actions.c:
114 (modest_ui_actions_on_password_requested): Remove the useless attempt to
115 reset the connection when changing the username, and improve the comments.
116 Save the changed username to gconf at least, so it is used when Modest is
119 2007-06-21 Murray Cumming <murrayc@murrayc.com>
121 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
122 Do not use a query, so that we get all folders, including for POP and
123 local-folders. They work as search criteria too.
124 This fixes projects.maemo.org bug NB#57740.
126 2007-06-21 Murray Cumming <murrayc@murrayc.com>
128 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
129 Comment out the use of hildon_notification_set_sound() because it is
130 not declared, to fix the build. Warnings are serious, people.
132 2007-06-21 Armin Burgmeier <armin@openismus.com>
134 * src/maemo/modest-maemo-utils.h:
135 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
136 modest_maemo_utils_get_supported_secure_authentication_methods()
137 to query authentication methods for a specific user. This should fix
138 projects.maemo.org bug NB#61369.
140 * src/maemo/easysetup/modest-easysetup-wizard.c:
141 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
144 2007-06-21 Murray Cumming <murrayc@murrayc.com>
146 * libmodest-dbus-client/libmodest-dbus-client.h:
147 * libmodest-dbus-client/libmodest-dbus-client.c:
148 (modest_dbus_message_iter_get_search_hit),
149 (libmodest_dbus_client_search):
150 Reorganised and commented this.
151 Removed modest_search_hit_free() from the public API because it
154 Added libmodest_dbus_client_get_folders() and
155 modest_folder_result_list_free().
157 * src/dbus_api/modest-dbus-api.h:
158 * src/dbus_api/modest-dbus-callbacks.c:
159 (modest_dbus_req_filter): Commented. Moved most code to
160 on_dbus_method_search() and added on_dbus_method_get_folders().
162 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
163 of the extra D-Bus handler.
165 * tests/dbus_api/Makefile.am:
166 * tests/dbus_api/test_get_folders.c: New test for
167 libmodest_dbus_client_get_folders(). This seems to return an empty list
168 at the moment. That could be the same error that causes the message list
169 to be empty sometimes.
170 This should help with projects.maemo.org bug NB#57740.
172 2007-06-21 Armin Burgmeier <armin@openismus.com>
174 * src/modest-mail-operation.c: Do not call
175 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
176 notify the operation's end after having set the status to CANCELED for
177 the operation queue to listen on. This fixes a deadlock when there
178 were mail operations in the queue during its finalization.
180 * src/modest-singletons.c: Reordered uninitialization of the account
181 manager to happen after the mail operation queue was uninitialized
182 because the mail operation's in the queue might still try to access
183 the account manager (see modest_mail_operation_notify_end()). This
184 fixes a potential crash when terminating the application.
186 2007-06-21 Murray Cumming <murrayc@murrayc.com>
188 * src/modest-search.c:
189 (search_mime_part_and_child_parts): Moved some code here so we
190 can search recursively in child folders.
191 (modest_search_folder): Search in the message as a mime part, instead
192 of just its child mime parts.
193 (read_chunk), (search_mime_part_ogs):
194 Check how many bytes were read, to prevent an endless loop.
195 Searching in message bodies now works. This finishes the fix for
196 projects.maemo.org bug NB#61007.
198 2007-06-20 Murray Cumming <murrayc@murrayc.com>
200 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
201 Add a g_warning when the item is not a folder.
203 * src/modest-ui-dimming-rules.c:
204 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
205 when selected item is not a folder (for instance, an account), because
206 the UI spec only talks about folders.
207 I am not sure what the UI spec wants, so this might not totally fix
208 projects.maemo.org bug NB#60794.
210 2007-06-20 Murray Cumming <murrayc@murrayc.com>
212 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
213 (load_from_file): Sort the list. The unsorted list would be more noticeable
214 in non-English locales.
216 * src/maemo/modest-msg-edit-window.c:
217 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
218 warning and fix the build.
220 * src/maemo/modest-progress-bar-widget.c:
221 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
222 avoid a g_warning, and probably to avoid a crash.
224 2007-06-20 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-search.c: (modest_search_folder): Check for a GError
227 when calling tny_folder_get_headers(), to show that this is not the cause
230 2007-06-20 Murray Cumming <murrayc@murrayc.com>
232 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
233 Actually set the body query instead of the subject query.
235 * src/modest-search.c: (search_mime_part_ogs),
236 (search_mime_part_strcmp): Remove extra space from the text/* regex,
237 which would probably cause it to fail if we got this far.
239 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
240 to simplify the code.
241 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
242 be causing search-in-body to fail.
244 2007-06-20 Murray Cumming <murrayc@murrayc.com>
246 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
248 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
249 Better debug message when the folder cannot be found.
250 This should help with fixing projects.maemo.org bug #61287.
251 * src/modest-search.c: (add_hit): Do not leak the furl string.
253 2007-06-20 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-ui-actions.c:
256 (modest_ui_actions_on_folder_selection_changed):
257 Do not special-case TNY_MERGE_FOLDER here, because
258 modest_tny_folder_get_account() already does that. This fixes
259 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
260 shown when the Outbox was selected).
262 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
264 * libmodest-dbus-client/libmodest-dbus-client.c:
265 (_dbus_iter_get_string_or_null): Initialize the string variable in
266 case this helps with Dirk's crash.
268 2007-06-19 Murray Cumming <murrayc@murrayc.com>
270 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
271 though it is not implemented yet (this function is maybe not even used),
272 to avoid breaking ABI in future.
273 * libmodest-dbus-client/libmodest-dbus-client.c:
274 (get_attachments_string): Moved some code into this generic function.
275 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
276 sends email. It is maybe not used.
277 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
278 (on_send_mail): Use attachments.
280 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
281 * src/maemo/modest-msg-edit-window.c:
282 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
283 a filename before using it, to fix projects.maemo.org bug NB#58233.
285 2007-06-19 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
288 Initialize the continue_download variable to fix the build, and probably
289 to fix randome behaviour.
291 2007-06-18 Armin Burgmeier <armin@openismus.com>
293 * src/modest-tny-send-queue.h:
294 * src/modest-tny-send-queue.c: Keep track of the status of messages in
295 the queue so we can later show it in the UI. Replaced
296 modest_tny_send_queue_msg_is_being_sent() by
297 modest_tny_send_queue_get_msg_status().
299 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
301 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
302 gpointer. This probably was not harmful, but just to be sure.
304 2007-06-18 Murray Cumming <murrayc@murrayc.com>
306 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
307 Fix the build, but leave the function broken on Bora, because
308 hildon_uri_action_get_service() does not exist.
309 osso_uri_action_get_service() does not exist either, it seems.
311 2007-06-18 Murray Cumming <murrayc@murrayc.com>
313 * src/modest-tny-account.c:
314 (modest_tny_account_new_from_server_account):
315 Uncommented the url debug output again, because it is useful for
316 debugging, as I said in the comment.
318 2007-06-18 Murray Cumming <murrayc@murrayc.com>
320 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
322 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
323 for Mameo Bora, to fix the build.
325 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
328 Fixed build with hildon < 0.99
330 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
331 Check if the selected account is busy instead of checking all accounts
333 * src/modest-account-mgr-priv.h:
334 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
335 (modest_account_mgr_init), (compare_account_name),
336 (modest_account_mgr_set_account_busy),
337 (modest_account_mgr_account_is_busy):
338 * src/modest-account-mgr.h:
339 Added busy information to the account manager. It possible to
340 set an account to busy or not busy now.
342 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
343 (modest_mail_operation_update_account),
344 (modest_mail_operation_notify_end):
345 Set the account to busy/not busy depending on the operation state.
347 * src/widgets/modest-account-view.c:
348 (modest_account_view_finalize), (get_last_updated_string),
349 (update_account_view), (on_account_busy_changed), (init_view):
350 Show string "Refreshing..." if the account is currently busy.
352 All this fixes projects.maemo.org bug NB#59711
354 2007-06-14 Armin Burgmeier <armin@openismus.com>
356 * src/widgets/modest-attachments-view.h:
357 * src/widgets/modest-attachments-view.c: Added
358 modest_attachments_view_has_attachments() and fixed coordinate
359 transformation in get_att_view_at_coords(). This fixes attachment
362 * src/widgets/modest-msg-view.c: Make use of
363 modest_attachments_view_has_attachments() to decide whether to show
364 attachments in the header.
366 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
368 * src/maemo/modest-connection-specific-smtp-edit-window.c:
369 (on_change), (on_combo_security_changed),
370 (modest_connection_specific_smtp_edit_window_init),
371 (modest_connection_specific_smtp_edit_window_set_connection),
372 (modest_connection_specific_smtp_edit_window_is_dirty):
373 * src/maemo/modest-connection-specific-smtp-edit-window.h:
374 * src/maemo/modest-connection-specific-smtp-window.c:
377 Show an comfirmation dialog for the smpt-edit-window if there are
378 unsaved changes and the user hits cancel.
379 (projects.maemo.org bug NB#60479)
381 2007-06-14 Armin Burgmeier <armin@openismus.com>
383 * src/maemo/easysetup/modest-easysetup-wizard.c:
384 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
385 address" info in banner instead of node, and select all the text as
386 per UI spec. This fixes projects.maemo.org bug NB#60550.
388 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
390 reviewed by: <delete if not using a buddy>
392 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
393 * src/modest-ui-actions.c: (folder_refreshed_cb):
395 2007-06-14 Murray Cumming <murrayc@murrayc.com>
397 * src/widgets/modest-folder-view.c: (filter_row):
398 Explictly filter out the per-account outbox accounts. I don't know why
399 these only sometimes show up, but now they should never show up in the UI.
400 This should fix projects.maemo.org bug NB#60160.
402 2007-06-14 Murray Cumming <murrayc@murrayc.com>
404 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
405 when the toolbar does not exist yet.
406 * src/modest-widget-memory.c: (save_settings_header_view):
407 Added g_warnings() to help us to discover when we are trying to set
408 an empty columns list in gconf.
410 2007-06-14 Murray Cumming <murrayc@murrayc.com>
414 Added modest_init_get_default_header_view_column_ids().
416 * src/modest-widget-memory.c: (restore_settings_header_view):
417 Use the new function to get defaults, if the gconf key is empty,
418 instead of not creating any columns. This seems to fix the
419 empty right-hand pane problems.
421 * src/widgets/modest-header-view.h: Improved documentation.
423 2007-06-13 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
426 Revert the use of the display name as the account name, because this
427 is generally wrong and would break the code that follows.
429 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
431 * src/maemo/easysetup/modest-easysetup-wizard.c:
432 (check_for_supported_auth_methods), (on_before_next),
435 More correct fix for projects.maemo.org bug NB# 58991
436 Do not longer accept AUTH_PASSWORD as secure method and choose
437 correct method when creating the account.
439 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
441 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
442 Fixed projects.maemo.org bug NB# 58991
444 2007-06-13 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-init.c: (modest_init_init_core),
447 (modest_init_local_folders): Fixed compilation errors.
449 2007-06-13 Murray Cumming <murrayc@murrayc.com>
451 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
452 Remove unnecessary lib/include, though it is good in principle when needed.
454 * src/modest-init.c: (modest_init_one_local_folder),
455 (modest_init_local_folders):
456 * src/modest-init.h: Initialize the .modest library for memory cards,
457 instead of just doing nothing for them. This should allow us to create
458 folders there, fixing projects.maemo.org bug NB#59297.
460 2007-06-13 Murray Cumming <murrayc@murrayc.com>
462 * libmodest-dbus-client/libmodest-dbus-client.c:
463 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
464 (libmodest_dbus_client_compose_mail),
465 (libmodest_dbus_client_open_message),
466 (libmodest_dbus_client_send_and_receive),
467 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
469 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
470 (on_idle_open_message), (modest_dbus_req_handler),
471 (search_result_to_message), (modest_dbus_req_filter):
472 * src/modest-search.c: (add_hit), (modest_search_folder),
473 (modest_search_all_accounts): Improved debug messages.
475 * tests/dbus_api/test_open_message.c: (main): Improved comments.
477 * src/modest-tny-account-store.c:
478 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
481 2007-06-13 Murray Cumming <murrayc@murrayc.com>
484 2007-06-12 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-tny-account-store.c: (get_server_accounts):
487 Call modest_tny_local_folders_account_add_merged_outbox_folders()
488 even when there are no accounts, so that the Outbox folder is always
489 visible. This fixes projects.maemo.org bug NB#60158.
491 2007-06-12 Murray Cumming <murrayc@murrayc.com>
493 * src/maemo/modest-main-window.c: (create_details_widget):
494 Use the mcen_va_never logical ID.
496 2007-06-12 Murray Cumming <murrayc@murrayc.com>
498 * src/dbus_api/modest-dbus-api.h:
499 * src/dbus_api/modest-dbus-callbacks.c:
500 (on_idle_open_default_inbox), (on_open_default_inbox),
501 (modest_dbus_req_handler):
502 Added a new OpenDefaultInbox method.
504 * libmodest-dbus-client/libmodest-dbus-client.h:
505 * libmodest-dbus-client/libmodest-dbus-client.c:
506 Added libmodest_dbus_client_open_default_inbox() to call the new
507 dbus method. This should be useful to projects.maemo.org bug NB#57214,
508 though it should maybe be used by a new osso-email-interface function.
510 * tests/dbus_api/Makefile.am:
511 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
514 2007-06-12 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
517 NULL, so that the signals get all the keys. This should not actually
518 change any behaviour because we currently update everything when anything
521 2007-06-12 Murray Cumming <murrayc@murrayc.com>
523 * src/widgets/modest-folder-view.c: (text_cell_data),
524 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
525 (find_inbox_iter): If tinymail tells us that the folder is
526 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
527 This causes the inbox to be selected at startup, fixing part of
528 projects.maemo.org bug NB#56305.
530 * src/modest-ui-dimming-rules.c:
531 (modest_ui_dimming_rules_on_tools_smtp_servers):
532 * src/modest-ui-dimming-rules.h: Added a callback function to dim
533 the SMTP servers menu item.
534 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
535 that the SMTP Servers menu item is dimmed when there are no accounts,
536 as a future version of the UI spec will require. This fixes
537 projects.maemo.org bug NB#56305.
539 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
541 * src/maemo/modest-maemo-utils.c:
542 (modest_maemo_utils_get_supported_secure_authentication_methods):
543 Added label to dialog instead of unreadable title
545 * src/maemo/modest-main-window.c: (sync_accounts_cb),
546 (modest_main_window_new):
547 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
550 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
551 * src/modest-account-mgr.h:
552 Added method to avoid code duplication
554 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
555 (modest_ui_actions_on_send_receive):
556 Use modest_account_mgr_has_accounts
558 2007-06-11 Murray Cumming <murrayc@murrayc.com>
560 * src/maemo/easysetup/modest-presets.c:
561 (modest_presets_get_info_server_security): Do not report secure auth
563 * src/modest-protocol-info.c: Use the defines for the gconf key names
564 for secure authentication. This was not working because we were writing
565 Password and reading password, and the check was case sensitive.
566 With this, gmail now works for receiving and sending when created via
569 2007-06-11 Murray Cumming <murrayc@murrayc.com>
571 * src/maemo/easysetup/modest-presets.c:
572 (modest_presets_get_info_server_security): Correct the key name for
573 SecureSmtp, because it seems to be case-sensitive.
574 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
575 Do not try to get the 0th notebook page if there are 0 pages, to
578 2007-06-11 Murray Cumming <murrayc@murrayc.com>
580 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
581 Prevent use of the new notification feature for now, because it currently
582 shows one dialog for each new email, which is annoying.
584 2007-06-11 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
587 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
588 when no country was selected, so that we show the global ones.
589 * src/maemo/easysetup/modest-presets.c:
590 (modest_presets_get_providers): Return only the global providers, not
591 all providers when mmc=0 was requested.
593 2007-06-11 Murray Cumming <murrayc@murrayc.com>
595 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
596 (easysetup_provider_combo_box_fill): Remove debug code that showed the
597 provider ID in the combo.
599 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
600 Do not show the page numbers, because it would be confusing when we add
601 the 2 extra pages for the custom setup, when the user chooses the "Other"
602 provider. This fixes projects.maemo.org bug NB#59028
604 * src/modest-init.c: (modest_init_init_core),
605 (modest_init_local_folders):
607 * src/modest-tny-account.c:
608 (modest_tny_account_new_for_local_folders): Do not create default folders
609 for the memory card. This should fix projects.maemo.org bug NB#59328.
611 2007-06-11 Murray Cumming <murrayc@murrayc.com>
613 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
614 Free the changed_conf_keys string items. They are already freed in the
615 idle handler if that runs first.
617 2007-06-11 Murray Cumming <murrayc@murrayc.com>
619 * src/modest-ui-actions.c:
620 (modest_ui_actions_on_password_requested): Check that the server name
621 is not NULL, because I just saw a password dialog with (null) as the
624 * src/modest-tny-folder.[h|c]: Added
625 modest_tny_folder_is_memory_card_folder().
626 * src/modest-ui-dimming-rules.c:
627 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
628 menu item for memory cards, as per the UI spec (section 7.4). This should
629 fix projects.maemo.org bug NB#59297.
631 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
633 * src/maemo/modest-main-window.c: (sync_accounts_cb):
634 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
635 is another problem with the code, see Murray's comment at line 772)
637 2007-06-08 Murray Cumming <murrayc@murrayc.com>
639 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
640 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
641 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
642 (load_from_file), (easysetup_country_combo_box_init),
643 (easysetup_country_combo_box_get_active_country_ids),
644 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
645 instead of just one ID, to avoid duplicate country names in the UI.
647 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
648 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
649 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
650 a single ID, avoiding duplicate providers.
651 * src/maemo/easysetup/modest-easysetup-wizard.c:
652 (on_combo_account_country): Adapt to use a list.
654 2007-06-08 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
657 keys changed in the last X seconds.
659 * src/modest-account-mgr.h:
660 * src/modest-account-mgr.c: (on_timeout_notify_changes),
661 (on_key_change), (modest_account_mgr_class_init),
662 (modest_account_mgr_init), (modest_account_mgr_finalize):
663 As the keys are changed, save them in a GSList* and signal that GSList*
664 further every X seconds, to batch changes, to allow us to do just one
665 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
666 bug NB#56941 and other (UI-blocking) delays when changing account settings.
668 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
669 changed signal signature.
671 * src/modest-conf.c: (modest_conf_set_list),
672 (modest_conf_on_change): Reenable notification.
674 (modest_conf_maemo_fake_on_change): Comment out the hack that
675 notified immediately instead of asynchronously.
677 * src/widgets/modest-account-view.h:
678 * src/widgets/modest-account-view.c:
679 (update_account_view): Select the previously-selected account ID,
680 if possible. This fixes projects.maemo.org bug NB#56933.
682 (on_account_changed), (on_account_removed),
683 (modest_account_view_select_account):
685 Remove the block/unblock functions
686 because they were not useful.
688 * src/maemo/modest-account-view-window.c:
689 (on_delete_button_clicked), (on_edit_button_clicked),
690 (on_new_button_clicked): Remove the use of the non-working block/unblock.
692 2007-06-08 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
695 Improve the error dialog to show Incorrect Account Settings, which seems
696 clearer, and say that the internal error message (to be removed from the
697 dialog later) is often misleading.
698 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
700 * src/modest-tny-account.c:
701 (modest_tny_account_new_from_server_account): Uncomment the printf of the
702 URL because this is so useful for debugging on the device.
704 * src/widgets/modest-serversecurity-combo-box.c:
705 (modest_serversecurity_combo_box_fill): Correct a logical ID.
707 2007-06-08 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-mail-operation.c:
710 (modest_mail_operation_send_new_mail):
711 Added a comment about a nasty but apparently harmless message. Details
712 added to the wiki g_warnings() page.
714 2007-06-08 Murray Cumming <murrayc@murrayc.com>
716 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
717 (modest_tny_send_queue_class_init):
718 Do not use the priv struct because it is empty, to avoid g_warnings
719 about a non-existant priv struct.
721 * src/modest-tny-account-store.c:
722 (modest_tny_account_store_get_server_account),
723 (modest_tny_account_store_get_transport_account_for_open_connection
724 ): Do not try to get transport server accounts for local folders,
725 because they don't have any. This avoids a g_warning().
727 * src/maemo/modest-main-window.c:
728 (modest_main_window_notify_send_receive_initied),
729 (on_configuration_key_changed):
730 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
732 * src/modest-mail-operation.c:
733 (modest_mail_operation_update_account):
734 * src/modest-tny-account-store.h:
735 * src/modest-tny-account.c:
736 (modest_tny_account_get_special_folder),
737 (modest_tny_account_new_for_local_folders),
738 (modest_tny_account_new_for_per_account_local_outbox_folder):
739 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
740 * src/modest-tny-local-folders-account.c:
741 (add_account_folders_to_merged_folder):
742 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
743 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
744 (modest_ui_actions_on_send):
745 * src/widgets/modest-folder-view.c: (update_model):
746 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
747 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
748 modest_tny_account_store_get_tny_account_by_account() to
749 modest_tny_account_store_get_server_account() to make the code clearer.
751 2007-06-07 Marcus Bauer <marcusb@openismus.com>
753 * src/dbus_api/modest-dbus-api.h:
754 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
755 * src/maemo/modest-msg-edit-window.c:
756 (modest_msg_edit_window_attach_file_noninteractive):
757 added g_warning in case the file to be attached does not exist
758 * tests/dbus_api/test_compose_mail.c: (main):
759 removed obsolete comment, added generic files as test case
761 2007-06-07 Murray Cumming <murrayc@murrayc.com>
763 * src/modest-tny-account-store.c: (get_server_accounts):
764 Create the local folders account only once, not once for each outbox, and
765 not only when there are some outboxes.
767 2007-06-07 Murray Cumming <murrayc@murrayc.com>
769 * src/widgets/modest-folder-view.c: (update_model): Comment out some
770 code that is causing a crash at startup. Sergio says that he is fixing this.
772 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
774 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
775 * src/maemo/modest-account-settings-dialog.c:
776 (create_page_outgoing),
777 (modest_account_settings_dialog_set_account_name),
778 (save_configuration):
779 - Fixed handling of the "Use secure authentication" toggle to comply with
780 the ui specification. See also projects.maemo.org bug NB#58400
782 - Restore the Secure connection setting combo correctly when loading
785 * src/maemo/modest-maemo-utils.c:
786 (on_camel_account_get_supported_secure_authentication),
787 (modest_maemo_utils_get_supported_secure_authentication_methods):
788 Fixed a crasher if operation is canceled
790 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
791 (modest_protocol_info_auth_is_secure):
792 * src/modest-protocol-info.h:
794 Added two new methods to determine if a protocol/auth method is secure/encrypted in
795 the sense of the "Use secure authentication" toggle.
797 2007-06-07 Murray Cumming <murrayc@murrayc.com>
799 * src/modest-tny-account-store.h:
800 * src/modest-tny-account-store.c:
801 Added modest_tny_account_store_get_local_folders_account().
803 * src/modest-tny-folder.h:
804 * src/modest-tny-folder.c:
805 (modest_tny_folder_get_account):
806 Added this replacement for tny_folder_get_account() which returns
807 the local-folders account for TnyMergeFolders, to avoid the
808 warning about the unimplemented get_account_func() vfunc().
810 (modest_tny_folder_get_rules),
811 * src/modest-ui-actions.c:
812 (modest_ui_actions_on_folder_selection_changed):
813 * src/modest-mail-operation.c:
814 (modest_mail_operation_remove_folder),
815 (modest_mail_operation_xfer_folder),
816 (modest_mail_operation_rename_folder),
817 (modest_mail_operation_get_msg),
818 (modest_mail_operation_get_msgs_full),
819 (modest_mail_operation_remove_msg),
820 (modest_mail_operation_xfer_msgs),
821 (modest_mail_operation_refresh_folder):
822 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
824 2007-06-07 Murray Cumming <murrayc@murrayc.com>
826 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
827 (modest_server_account_set_security):
828 * src/modest-defs.h: Add comments explaining that our
829 UI spec means TLS when it says Normal, so these do not look like errors.
831 * src/modest-tny-account.c:
832 (modest_tny_account_new_from_server_account): Use the new tinymail
833 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
834 for TLS. This should fix projects.maemo.org bug NB#58460.
836 2007-06-06 Murray Cumming <murrayc@murrayc.com>
838 * src/maemo/easysetup/modest-easysetup-wizard.c:
839 (create_account): Correct the position of the gconf sanity check warning.
840 (on_button_edit_advanced_settings): Show the dialog immediately, instead
841 of using the g_idle_add() hack, because this does not seem to be necessary
842 on osso 1.1. It might even work on Maemo Bora if the problems were actually
843 caused by something other than maemo's gconf.
844 This fixes projects.maemo.org bug #59022.
846 2007-06-06 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-account-mgr-helpers.c:
849 (modest_account_mgr_get_default_account): Do not check that the account
850 exists if there is no default account (NULL), to fix a runtime warning.
852 2007-06-06 Murray Cumming <murrayc@murrayc.com>
854 * src/widgets/modest-folder-view.c: (update_model):
855 Do not unref the treemodel before we have finished with it.
856 This prevents a valgrind warning and an occasional crash at startup.
858 2007-06-06 Marcus Bauer <marcusb@openismus.com>
860 * libmodest-dbus-client/libmodest-dbus-client.h:
861 added libmodest_dbus_client_compose_mail()
862 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
864 added functions needed for SendAsMail() functionality
865 * src/maemo/modest-msg-edit-window.c:
866 (modest_msg_edit_window_attach_file_noninteractive):
867 non interactively attaching files to message edit window
868 * src/widgets/modest-msg-edit-window.h:
869 * tests/dbus_api/Makefile.am:
870 added test_compose_mail.c
871 * tests/dbus_api/test_compose_mail.c: (main):
873 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
875 * src/modest-account-view.c:
876 Fixed bug projects.maemo.org bug NB#59307
878 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
880 * src/maemo/easysetup/modest-easysetup-wizard.c:
881 (get_serverport_incoming), (on_before_next), (create_account):
882 * src/maemo/modest-account-settings-dialog.c:
883 (modest_account_settings_dialog_set_account_name):
884 * src/maemo/modest-maemo-utils.c:
885 (on_camel_account_get_supported_secure_authentication_status),
886 (on_camel_account_get_supported_secure_authentication),
887 (on_secure_auth_cancel),
888 (modest_maemo_utils_get_supported_secure_authentication_methods):
890 Implemented security authentication for settings and easysetup.
892 2007-06-05 Murray Cumming <murrayc@murrayc.com>
894 * src/maemo/modest-main-window.c: (create_details_widget):
895 Show the total size for memory card accounts too, instead of showing
896 the name again. Fixes bug projects.maemo.org bug NB#59307.
898 2007-06-05 Murray Cumming <murrayc@murrayc.com>
901 * src/modest-tny-simple-folder-store.c:
902 * src/modest-tny-simple-folder-store.h: Removed.
904 * src/modest-tny-local-folders-account.h
905 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
906 for the local-folders maildir, with an extra TnyMergedFolder containing
907 the folders of the per-account outbox store accounts.
908 * src/modest-tny-account-store.c: (get_server_accounts):
909 Add the outboxes to the special local folders account after creating it.
911 * src/modest-tny-account.c:
912 (modest_tny_account_new_for_local_folders): Create the derived
913 account when creating the main local-folders account.
915 * src/maemo/modest-main-window.c: (create_details_widget),
916 (modest_main_window_set_contents_style):
917 Adapted to the use of the derived account instead of the folder store.
919 * src/modest-ui-actions.c:
920 (modest_ui_actions_on_folder_selection_changed):
921 * src/modest-ui-dimming-rules.c:
922 (modest_ui_dimming_rules_on_new_folder):
923 * src/widgets/modest-folder-view.c: (text_cell_data),
924 (icon_cell_data), (filter_row), (update_model),
925 (get_cmp_rows_type_pos):
928 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
929 Do not get the priv struct, because no priv struct has been set,
930 to avoid a runtime warning.
932 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
933 #ifelse with #else, to fix a warning, to fix the build.
936 2007-06-05 Christian Kellner <ckellner@openismus.com>
938 * libmodest-dbus-client/libmodest-dbus-client.c:
939 Fix small typo in doc (why do you always see them
940 AFTER committing stuff?)
943 2007-06-05 Christian Kellner <ckellner@openismus.com>
945 * libmodest-dbus-client/libmodest-dbus-client.c:
946 (libmodest_dbus_client_search):
947 Initialize hit list with NULL. Also set folder list
948 to "" if NULL was supplied.
951 2007-06-03 Christian Kellner <ckellner@openismus.com>
953 * libmodest-dbus-client/libmodest-dbus-client.c:
954 (modest_search_hit_list_free):
955 Make it save to call it with NULL.
957 * src/dbus_api/modest-dbus-callbacks.c:
958 * src/modest-search.c:
959 Return full ModestSearchHits as the search result list not TnyHeader
960 since can't be around withouth the correspoding TnyFolder.
962 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
964 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
965 Added currently commented code to check for secure auth
967 * src/maemo/modest-account-settings-dialog.c: (on_response),
968 (save_configuration), (show_ok):
969 Fixed projects.maemo.org bugs NB #59248 and #59251
971 * src/maemo/modest-maemo-utils.c:
972 (on_camel_account_get_supported_secure_authentication_status),
973 (on_camel_account_get_supported_secure_authentication),
974 (modest_maemo_utils_get_supported_secure_authentication_methods):
975 * src/maemo/modest-maemo-utils.h:
976 Moved get_supported_secure_authentication() method here to be able
977 to use it from easysetup wizard.
979 * src/modest-pair.c: (on_pair_compare_as_string):
980 Should compare string with first part of pair and not
981 strcmp pairs which will crash.
983 * src/modest-protocol-info.c:
984 (modest_protocol_info_protocol_is_store):
985 * src/modest-protocol-info.h:
986 Added modest_protocol_info_get_auth_protocol_name()
988 2007-06-03 Armin Burgmeier <armin@openismus.com>
990 * src/modest-mail-operation.c:
991 (modest_mail_operation_get_msgs_full): Set priv->account also when
992 only retrieving a single message. This avoids a crash when canceling
995 (modest_mail_operation_notify_end): Do not explicitely remove the
996 operation from the queue but only emit the progress_changed signal.
997 The queue itself listens to that signal to remove the operation when
998 it is finished. This reduces coupling and removes a potential deadlock
999 when modest_mail_operation_notify_end() is called from the queue
1000 itself. If that is a problem performance-wise, I would suggest to
1001 implement a status-changed signal or something.
1003 * src/modest-mail-operation-queue.c: Make sure to never call a
1004 function from another file while the queue is locked. This (hopefully)
1005 fixes another deadlock when exiting the application while retrieving
1008 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1010 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1011 Fixed build if libogs is not available
1013 2007-06-03 Christian Kellner <ckellner@openismus.com>
1015 * libmodest-dbus-client/libmodest-dbus-client.h:
1016 * libmodest-dbus-client/libmodest-dbus-client.c:
1017 (libmodest_dbus_client_delete_message):
1018 Implement deletion of messages (Client side).
1020 (modest_search_hit_free),
1021 (modest_search_hit_list_free):
1022 Utility functions to free the result hits.
1024 * src/dbus_api/modest-dbus-api.h:
1025 * src/dbus_api/modest-dbus-callbacks.c:
1026 (on_delete_message),
1027 (modest_dbus_req_handler):
1028 Implement deletion of messages (Server side).
1030 * tests/dbus_api/test_search.c: (main):
1033 * tests/dbus_api/Makefile.am:
1034 * tests/dbus_api/test_delete_message:
1035 Add little test for the message deletion logic
1037 2007-06-03 Armin Burgmeier <armin@openismus.com>
1039 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1040 when the operation queue was not empty. projects.maemo.org bug
1043 2007-06-03 Armin Burgmeier <armin@openismus.com>
1045 * src/widgets/modest-account-view.c
1046 (on_account_default_toggled): Toggle default account column
1047 explicitely instead of waiting for gconf notification (which is
1048 currently ignored). This should fix projects.maemo.org bug NB#56910
1049 for now. It should probably be removed when gconf notifications are
1052 2007-06-03 Christian Kellner <ckellner@openismus.com>
1054 * libmodest-dbus-client/libmodest-dbus-client.c:
1055 Removed debugging spew.
1057 * src/dbus_api/modest-dbus-callbacks.c:
1058 Added debugging info.
1060 * src/modest-search.c:
1061 (modest_search_all_accounts):
1062 Use tny_account_store_get_accounts () on the account store
1063 to get all accounts which is the way to get all accounts.
1065 * tests/dbus_api/test_search.c: (main):
1066 Make it possible to supply the search term on the command line.
1068 2007-06-03 Christian Kellner <ckellner@openismus.com>
1070 * libmodest-dbus-client/libmodest-dbus-client.c:
1071 * libmodest-dbus-client/libmodest-dbus-client.h:
1072 Implement searching for mesages over raw dbus. (Client side)
1074 * src/dbus_api/Makefile.am:
1075 * src/dbus_api/modest-dbus-api.h:
1076 * src/dbus_api/modest-dbus-callbacks.c:
1077 * src/dbus_api/modest-dbus-callbacks.h:
1078 Search framework (Server side). Also implement on_idle_open_message().
1080 * src/maemo/modest-platform.c: (modest_platform_init):
1081 Prepare for raw dbus/osso rpc interaction.
1083 * src/modest-search.h:
1084 Changed minsize from unspecific guint to guint32.
1086 * src/modest-search.c:
1088 Added strange hack which magically made tnymail work.
1090 (modest_search_folder),
1091 (modest_search_account),
1092 (modest_search_all_accounts):
1093 Implement helper functions to search all accounts, specific account
1096 * tests/dbus_api/Makefile.am:
1097 * tests/dbus_api/test_open_message.c:
1098 Read url to open from commandline.
1100 * tests/dbus_api/test_search.c:
1101 Implement small test for dbus search stuff
1103 2007-06-02 Armin Burgmeier <armin@openismus.com>
1105 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1106 include account type and account title. This fixes projects.maemo.org
1109 * src/maemo/modest-account-view-window.c: Set a title for the window.
1111 2007-06-02 Armin Burgmeier <armin@openismus.com>
1113 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1114 incoming and outgoing server name based on email address and server
1115 types as long as the names have not been edited manually. This fixes
1116 projects.maemo.org bug NB#58671.
1118 2007-06-02 Armin Burgmeier <armin@openismus.com>
1120 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1121 server type cannot be changed in future to the incoming details page
1122 when creating an account. This fixes projects.maemo.org bug NB#59029.
1124 2007-06-02 Armin Burgmeier <armin@openismus.com>
1126 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1127 and assigned max width chars so that they wrap instead of being
1128 truncated. Fixes projects.maemo.org bug NB#56126.
1130 2007-06-02 Armin Burgmeier <armin@openismus.com>
1132 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1133 introductory note to the connection specific smtp servers dialog, as
1134 section 8.12 of the email UI specification requires. This fixes
1135 projects.maemo.org bug NB#59212.
1137 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1139 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1140 Check for running mail operations, and offer to cancel them, as per the UI
1141 spec. This fixes projects.maemo.org bug NB#59041 .
1142 However, I suspect that tinymail may still use the network connection
1143 in ways that we cannot detect or cancel. But it should at least adapt to
1144 changes fairly well.
1146 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1148 * src/modest-tny-account-store.c: (recreate_all_accounts),
1149 (get_cached_accounts), (get_server_accounts): Do more sensible
1150 ref-counting of the temporarily-cached outbox accounts list. This seems
1151 to fix a crash when entering the password when the password was wrong.
1153 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1155 * src/gnome/modest-main-window.c: (connect_signals):
1156 * src/modest-tny-account-store.c: (get_password),
1157 (modest_tny_account_store_alert): Added comments and clues and
1158 commented-out code about how we currently fail to deal with connection
1159 errors and wrong passwords, and how we should.
1161 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1163 * src/widgets/modest-retrieve-combo-box.c:
1164 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1165 This fixes projects.maemo.org bug NB#58472 .
1167 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/easysetup/modest-easysetup-wizard.c:
1170 (create_page_complete_easysetup):
1171 (create_page_complete_custom): Correct the last commit,
1172 putting the correct sentences in the correct pages.
1174 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1176 * src/maemo/easysetup/modest-easysetup-wizard.c:
1177 (create_page_complete_custom): Show the second sentence of text
1178 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1181 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1184 Set the leave-on-server conf key by default. This fixes
1185 projects.maemo.org bug NB#59258 .
1187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1189 * src/maemo/modest-account-view-window.c:
1190 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1191 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1194 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1196 * src/maemo/easysetup/modest-easysetup-wizard.c:
1197 (create_caption_new_with_asterisk):
1198 * src/maemo/modest-account-settings-dialog.c:
1199 (create_caption_new_with_asterisk):
1200 Uncomment the code to add the asterisk, because they are no longer in the
1201 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1202 (update_incoming_server_title): Add an asterisk here too.
1204 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1206 * src/maemo/modest-maemo-global-settings-dialog.c:
1207 (current_connection): Check that we are even connected before trying to
1208 get the current connection name, to prevent a warning.
1210 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1211 Change the comments because tny_maemo_conic_device_connect() is now meant to
1213 * src/modest-mail-operation.c:
1214 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1215 make sure we have a connection and fail if we can't connect.
1217 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1219 * src/maemo/modest-main-window.c:
1220 (on_account_store_connecting_finished): Do not try to get the
1221 connection ID if we are not really connected. I am surprised that
1222 this signal handler is called when we are not connected.
1224 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1226 * src/modest-error.h:
1227 * src/modest-ui-actions.c:
1228 (modest_ui_actions_get_msgs_full_error_handler):
1229 Renamed an enum, added comments, added an enum
1230 for retrieve-limit errors.
1232 * src/modest-mail-operation.c: (foreach_add_item),
1233 (internal_folder_observer_update), (update_account_thread),
1234 (modest_mail_operation_get_msgs_full):
1235 (modest_mail_operation_update_account),
1236 Added comments about how this works, and some code that should
1237 (but does not) check the retrieve-limit. See the TODO comment.
1239 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1242 Initialize help_id to fix the build. Warnings are good.
1244 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1246 * src/widgets/modest-hbox-cell-renderer.c:
1247 (modest_hbox_cell_renderer_append):
1248 * src/widgets/modest-vbox-cell-renderer.c:
1249 (modest_vbox_cell_renderer_append):
1250 Fix the last commit by doing an extra ref.
1252 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1254 * src/widgets/modest-hbox-cell-renderer.c:
1255 (modest_hbox_cell_renderer_append):
1256 * src/widgets/modest-vbox-cell-renderer.c:
1257 (modest_vbox_cell_renderer_append):
1258 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1259 to fix the build with Maemo Bora.
1260 However, there seems to be a remaining crash, probably due to reference
1263 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-tny-account.c:
1266 (modest_tny_account_new_for_local_folders):
1267 Use hildon_file_system_info_async_new() to get a better name for
1268 the memory card account, setting it as the account name.
1269 The timing seems to work, but this is probably
1270 not the best place to do this. See the TODO comment.
1271 * src/maemo/modest-main-window.c: (create_details_widget):
1272 * src/widgets/modest-folder-view.c: (text_cell_data):
1273 Use the tny account name instead of hardcoding a name.
1275 2007-05-30 Christian Kellner <ckellner@openismus.com>
1277 * src/modest-search.c: (modest_search):
1278 Correctly set part_search_func even if we have already parsed
1279 the query and thus a valid OgsTextSearcher object.
1281 2007-05-30 Christian Kellner <ckellner@openismus.com>
1284 Search and check for libogs.
1287 Incooparte the ogs build env.
1289 * src/modest-mime-part-search-stream.c:
1290 * src/modest-mime-part-search-stream.h:
1291 Removed since we do the real searching now in modest-search.c.
1293 * src/modest-search.c:
1294 * src/modest-search.h:
1295 Implement support for ogs. We use that if available and requested
1296 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1297 should now handle the corner case when the search term is spread
1298 across multiple reads.
1299 Also the logic in modest_search () was corrected to search all
1300 requested fields until one is found.
1302 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1304 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1306 * src/modest-init.h:
1307 * src/modest-init.c: Made modest_init_local_folders() take a
1308 path and be public so we can iniitialize maildir folders on
1311 * src/modest-local-folder-info.h:
1312 * src/modest-local-folder-info.c:
1313 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1315 * src/modest-tny-account.c:
1316 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1317 still means the standard local-folders path on the local volume.
1319 * src/modest-tny-account-store.c:
1320 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1321 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1322 all accounts when that happens.
1323 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1324 this too, so it shows up in the treeview.
1326 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/modest-maemo-global-settings-dialog.c:
1329 (current_connection):
1330 * src/widgets/modest-global-settings-dialog.c:
1331 (current_connection_default):
1332 Use the enum values instead of 0, 1 and -1,
1333 to make the code clearer.
1335 * src/modest-account-mgr-helpers.c:
1336 (modest_account_mgr_get_connection_specific_smtp): Make this code
1339 * src/modest-runtime.h:
1340 * src/modest-runtime.c:
1341 Added modest_runtime_remove_all_send_queues().
1342 * src/maemo/modest-main-window.c:
1343 (on_account_store_connecting_finished): Recreate the send queues,
1344 using the appropriate transport accounts for this new connection.
1345 Some futher adapting might be needed if the old send queues are not
1346 automatically stopped at this point.
1348 * src/modest-tny-account-store.c: (get_server_accounts):
1349 Create the connection-specific transport accounts, so that they can
1350 be found later by their ID.
1352 * src/modest-tny-account.h:
1353 * src/modest-tny-account.c:
1354 Added modest_tny_account_new_from_server_account_name().
1355 modest_tny_account_new_from_server_account(): Do not create the
1356 send queues here, because they will be
1357 recreated anyway when the connection changes for the first time.
1359 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-local-folder-info.h:
1362 * src/modest-local-folder-info.c:
1363 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1364 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1365 tbox_folder): Take a modest account name instead of a server TnyAccount,
1366 so we can have per-modest-account rather than per-transport-account
1368 We must make sure that we change or recreate the exisitng send queues
1369 when the connection changes for connection-specific transport accounts.
1371 * src/modest-tny-account-store.c:
1372 (create_per_account_local_outbox_folders): Create outboxed per modest
1373 account, not per transport account.
1375 * src/modest-tny-account.h:
1376 * src/modest-tny-account.c:
1377 (modest_tny_account_get_special_folder): For outboxes, get the
1378 parent modest account name. The account is ignored for other folders.
1379 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1380 modest account name rather than a server TnyAccount.
1382 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1384 * src/modest-tny-account.c:
1385 (modest_tny_account_new_from_server_account):
1386 Call modest_runtime_get_send_queue() immediately after creating transport
1387 accounts, so that they start trying to send email from the outbox as soon
1388 as possible at startup. This is probably what we want.
1390 * src/modest-mail-operation.c: (update_account_thread):
1391 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1392 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1393 * src/modest-tny-send-queue.h:
1394 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1395 (modest_ui_actions_on_send):
1396 Added comments about how sending works, though it needs some more work.
1398 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1400 * src/modest-tny-account.c:
1401 (modest_tny_account_get_special_folder): Add TODO because this fails when
1402 the network is busy.
1403 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1404 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1405 Do not try to show this window when there is no active account. The UI
1406 specs does not tell us what to do in this case.
1408 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1412 * src/maemo/Makefile.am:
1413 * src/widgets/Makefile.am: Some dist fixes.
1415 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1417 * src/maemo/modest-connection-specific-smtp-window.c:
1418 (on_button_edit): Make the code clearer, to prevent a double free.
1420 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1422 * src/maemo/modest-account-settings-dialog.c:
1423 (modest_account_settings_dialog_set_account_name),
1424 Check the connection-specific smtp servers checkbox if there are any.
1426 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1427 (modest_connection_specific_smtp_edit_window_init):
1428 Start with a suitable port number.
1430 * src/modest-account-mgr-helpers.h:
1431 * src/modest-account-mgr-helpers.c: Added
1432 modest_account_mgr_get_has_connection_specific_smtp().
1434 (modest_account_mgr_set_connection_specific_smtp),
1435 (modest_account_mgr_remove_connection_specific_smtp),
1436 (modest_account_mgr_get_has_connection_specific_smtp),
1437 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1438 connection-specific smtp server accounts in the account, rather than
1439 the server account conf dir.
1441 This fixes bug projects.maemo.org bug NB#58263 .
1443 * src/modest-tny-account-store.c:
1444 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1445 if there are no server accounts yet, to prevent an infinite loop when there
1446 are no accounts. Document that one must be called before the other.
1448 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1450 * src/modest-account-mgr-helpers.c:
1451 (modest_account_mgr_get_default_account): Make sure that at least
1452 one account is always the default, if there are any enabled accounts.
1453 This is just a sanity check that shouldn't be necessary.
1455 * src/modest-account-mgr-priv.c:
1456 (_modest_account_mgr_account_from_key): Unescape the conf key to
1457 get the real account name. For instance, this is an issue if a space
1458 was in the account name, which can happen because the account name
1459 is generated from the display name.
1460 (_modest_account_mgr_get_account_keyname): Always escape the
1462 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1463 Unescape the conf keys to get the real account names.
1465 For instance, previously the is-default radio button in the accounts
1466 list was not checked for any accounts at first. This fixes that,
1467 and might fix several similar bugs.
1469 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1472 Removed some debug printfs.
1474 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1476 Modest on-disk outbox directories are now here, for instance:
1477 $HOME/.modest/outboxes/<account-id-1>/outbox
1478 $HOME/.modest/outboxes/<account-id-2>/outbox
1480 $HOME/.modest/local-folders/outbox
1481 so we can have a separate outbox for each account.
1482 But they are shown as one outbox in the GtkTreeView, by using a
1483 TnyMergeFolder in a ModestTnySimpleFolderStore.
1486 * src/modest-tny-simple-folder-store.c:
1487 * src/modest-tny-simple-folder-store.h:
1488 Added ModestTnySimpleFolderStore, used to contain folders from
1489 other folder stores, such as other accounts.
1491 * src/modest-tny-outbox-account.h:
1492 * src/modest-tny-outbox-account.c:
1493 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1494 used for the per-account local outbox folders.
1496 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1497 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1498 only use this (internally) now for the non-outbox local folders.
1500 * src/modest-init.h:
1501 * src/modest-init.c: Added modest_init_one_local_folder(), for
1502 setting up the directory structure for each local folder.
1504 * src/modest-local-folder-info.c:
1505 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1506 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1508 * src/modest-local-folder-info.h:
1509 * src/modest-tny-account-store.c: (on_account_removed),
1510 (on_account_changed), (create_per_account_local_outbox_folders),
1511 (get_server_accounts), (modest_tny_account_store_get_accounts),
1512 (modest_tny_account_store_get_tny_account_by_account),
1513 (modest_tny_folder_store_is_virtual_local_folders):
1515 * src/modest-tny-account.h:
1516 * src/modest-tny-account.c:
1517 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1518 to create an on-disk per-account local outbox folder for each
1520 (create_per_account_local_outbox_folders): Create a local outbox folder
1521 for each transport account.
1522 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1523 for all local folders.
1525 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1526 instead of using g_object_get/set() directly. It is clearer.
1528 (modest_tny_folder_store_get_message_count),
1529 (modest_tny_folder_store_get_local_size
1530 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1531 because we now use these with non-acount folder stores.
1533 (modest_tny_account_get_special_folder),
1534 (modest_tny_account_new_from_server_account),
1535 (modest_tny_account_new_from_account):
1536 (recurse_folders): Adjust to the new outbox system.
1538 * src/modest-tny-folder.h:
1539 * src/modest-tny-folder.c:
1540 (modest_tny_folder_is_local_folder),
1541 (modest_tny_folder_get_local_folder_type),
1542 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1544 * src/widgets/modest-main-window.h:
1545 * src/maemo/modest-main-window.c: (create_details_widget),
1546 (modest_main_window_set_contents_style): Show details for any folder store,
1549 (modest_tny_folder_get_rules):
1550 Remove the const. C does not support constness enough for this.
1552 * src/modest-ui-actions.c:
1553 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1554 make all outboxes appear as one, in the usual local-folders tree node.
1556 (set_active_account_from_tny_account),
1557 (modest_ui_actions_on_folder_selection_changed):
1558 * src/widgets/modest-folder-view.c: (text_cell_data),
1559 (icon_cell_data), (filter_row),
1560 (add_account_folders_to_merged_folder),
1561 (add_account_folders_to_simple_folder_store), (),
1562 (get_cmp_rows_type_pos), (cmp_rows),
1563 (modest_folder_view_set_account_id_of_visible_server_account):
1564 Adjust to the new outbox system, using generic folder stores and folders
1565 in the GtkTreeModel.
1567 2007-05-23 Christian Kellner <ckellner@openismus.com>
1569 * src/modest-mail-operation.c:
1570 (modest_mail_operation_update_account):
1571 Use info->max_size instead of unintialized local var [small
1572 build fix]. (Added TODO to review that change since I don't
1575 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1577 * libmodest-dbus-client/libmodest-dbus-client.c:
1578 (libmodest_dbus_client_compose_mail): function added
1579 * src/dbus_api/modest-dbus-api.h:
1580 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1581 (on_compose_mail): Implementation of the SendAsMail functionality
1583 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1585 * src/modest-account-mgr.c:
1586 (modest_account_mgr_add_server_account): Set the secure-connection
1587 conf key for transport accounts as well as store accounts. I don't know
1588 why the if was there. For instance, this makes sure that we use SSL
1589 for the gmail preset from the easysetup wizard.
1591 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1593 * src/gnome/modest-main-window.c:
1594 (on_account_store_connecting_finished), (connect_signals):
1595 * src/maemo/modest-main-window.c:
1596 (on_account_store_connecting_finished), (connect_signals),
1597 (modest_main_window_new):
1598 Handle TnyAccountStore::connecting-finished instead of
1599 TnyDevice::connection-changed, because we cannot actually perform
1600 operations on accounts until TnyAccountStore has itself responded to
1601 the TnyDevice::connection-changed signal. This prevents a GError from
1603 Do not try to update at startup, because we (at least on scratchbox)
1604 already do an update at startup when the device goes online.
1605 This prevents a GError from tinymail.
1606 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1607 Added TODO about stopping simultaneous operations.
1609 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1611 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1612 * src/modest-mail-operation-queue.c:
1613 (modest_mail_operation_queue_remove):
1614 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1615 about where they happened.
1617 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-ui-actions.c:
1620 (modest_ui_actions_on_password_requested): Make sure that the remember
1621 output parameter is always TRUE.
1623 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1626 Show a OK/Cancel dialog if the error is a question, though we still do not
1627 know anything more about what we are asking the user.
1628 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1629 Fix an uninitialized variable (helper). This is a logic error, however.
1631 2007-05-21 Christian Kellner <ckellner@openismus.com>
1633 * src/modest-search.h:
1634 Correct bit shifting in the ModestSearchFlags enum.
1636 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1638 * src/modest-tny-account.c:
1639 (modest_tny_account_new_from_server_account): Do not use the lsub and
1640 check-all hard-coded IMAP options when using POP.
1642 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1644 * src/modest-tny-account.c:
1645 (modest_tny_account_new_from_server_account):
1646 Use NULL for the secure-auth method for POP when Password auth has been
1647 specified by the user, as we already do for IMAP. "auth=Login" causes
1648 an error from camel or the server.
1650 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1652 * src/maemo/modest-account-settings-dialog.c:
1653 (create_page_account_details),
1654 (modest_account_settings_dialog_set_account_name):
1655 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1656 for the leave-on-server checkbox, rathr than just the checkbox, when
1657 the protocol is not POP.
1659 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1661 * src/widgets/modest-account-view.c:
1662 * src/widgets/modest-account-view.h:
1663 Added modest_account_view_select_account() which will be useful later
1664 to asynchronously re-select the edited account.
1666 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/modest-account-settings-dialog.c:
1669 (modest_account_settings_dialog_set_account_name):
1670 Automatically choose the port numbers based on the secure authentication
1671 methods, if they have not been chosen before.
1672 This fixes projects.maemo.org bug NB#56273 .
1674 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1676 * src/maemo/modest-main-window-ui.h:
1677 * src/modest-ui-actions.c:
1678 * src/modest-ui-actions.h:
1679 Connect the Tools/SMTP Servers menu item to
1680 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1681 SMTP servers dialog, as in the UI specification and saves changes when it
1682 is closed. This fixed projects.maemo.org bug NB#56305 .
1684 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1686 * src/maemo/modest-connection-specific-smtp-window.c:
1687 (modest_connection_specific_smtp_window_init):
1688 Use gtk_window_set_default_size() to make this window big enough, so
1689 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1691 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1693 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1694 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1695 (modest_connection_specific_smtp_edit_window_init),
1696 Do not try to connect to a combobox signal before the combobox exists.
1697 This fixes the cras in projects.maemo.org bug NB#56288 .
1698 (modest_connection_specific_smtp_edit_window_get_settings):
1699 Remove the server_account_name parameter which was being checked for NULL
1700 though it was not used.
1702 * src/maemo/modest-connection-specific-smtp-window.c:
1703 (modest_connection_specific_smtp_window_fill_with_connections),
1704 (on_button_edit), (modest_connection_specific_smtp_window_init):
1705 Correct the number of treemodel columns to prevent a warning.
1706 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1707 libconic does not work.
1709 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1711 * src/modest-tny-account.c:
1712 (modest_tny_account_new_from_server_account):
1713 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1714 SMTP when "None" was chosen by the user. However, with my SMTP server that
1715 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1718 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1720 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1721 to explain the memory management issue with the ID in the ModestPair.
1723 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1724 (add_sending_page), (modest_account_assistant_finalize):
1725 * src/gnome/modest-gnome-global-settings-dialog.c:
1726 (create_updating_page), (create_composing_page):
1727 * src/gnome/modest-msg-edit-window.c: (get_transports),
1728 (init_window), (modest_msg_edit_window_finalize),
1729 (modest_msg_edit_window_get_msg_data):
1730 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1731 * src/gnome/modest-transport-widget.c:
1732 (modest_transport_widget_finalize), (smtp_configuration):
1733 * src/maemo/modest-maemo-global-settings-dialog.c:
1734 (create_updating_page), (create_composing_page):
1735 * src/maemo/modest-msg-edit-window.c: (get_transports),
1736 (init_window), (modest_msg_edit_window_finalize),
1737 (modest_msg_edit_window_get_msg_data),
1738 (modest_msg_edit_window_free_msg_data):
1739 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1740 (modest_store_widget_finalize):
1741 * src/maemo/modest-transport-widget.c:
1742 (modest_transport_widget_finalize), (smtp_configuration):
1743 * src/modest-main.c: (send_mail):
1744 * src/widgets/modest-combo-box.h:
1745 * src/widgets/modest-global-settings-dialog-priv.h:
1746 * src/widgets/modest-global-settings-dialog.c:
1747 (modest_global_settings_dialog_finalize):
1748 * src/widgets/modest-msg-edit-window.h:
1749 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1750 as long as the combo box, to prevent use of freed memory for the ID.
1752 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1754 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1755 get_accounts(), to make this clearer. Do not check for the enabled gconf
1756 key, because we do not use this for server accounts (at least, not yet).
1757 This allows us to send email again.
1759 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1761 * src/maemo/modest-platform.c:
1762 (on_modest_conf_update_interval_changed), (modest_platform_init):
1763 Only respond to this particular key change. All these strcmp()s cannot be
1766 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1768 * src/maemo/modest-maemo-global-settings-dialog.c:
1769 (current_connection): Prevent a crash in scratchbox when
1770 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1771 * src/maemo/modest-platform.c:
1772 (on_modest_conf_update_interval_changed), (modest_platform_init):
1773 Get the update interval from gconf and reset it when the gconf key changes.
1775 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1777 * src/modest-protocol-info.c:
1778 * src/modest-protocol-info.h: Adde enum-specific get functions,
1779 instead of using a ModestProtocolType enum parameter.
1781 * src/gnome/modest-account-assistant.c:
1782 * src/gnome/modest-store-widget.c:
1783 * src/gnome/modest-store-widget.h:
1784 * src/gnome/modest-transport-widget.c:
1785 * src/gnome/modest-transport-widget.h:
1786 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1787 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1788 * src/maemo/easysetup/modest-easysetup-wizard.c:
1789 * src/maemo/modest-account-settings-dialog.c:
1790 * src/maemo/modest-account-settings-dialog.h:
1791 * src/maemo/modest-store-widget.c:
1792 * src/maemo/modest-store-widget.h:
1793 * src/maemo/modest-transport-widget.c:
1794 * src/maemo/modest-transport-widget.h:
1795 * src/modest-account-mgr-helpers.c:
1796 * src/modest-account-mgr-helpers.h:
1797 * src/modest-account-mgr.c:
1798 * src/modest-account-mgr.h:
1799 * src/modest-tny-account.c:
1800 * src/modest-tny-folder.c:
1801 * src/widgets/modest-account-view.c:
1802 * src/widgets/modest-retrieve-combo-box.c:
1803 * src/widgets/modest-retrieve-combo-box.h:
1804 * src/widgets/modest-secureauth-combo-box.c:
1805 * src/widgets/modest-serversecurity-combo-box.c:
1806 * src/widgets/modest-serversecurity-combo-box.h:
1807 * tests/check_account-mgr.c:
1808 Use the specific functions, and use the re-renamed enum values for GNOME too.
1810 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1812 * src/modest-pair.h:
1813 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1814 so we can get the second based on the first.
1816 * src/maemo/modest-account-settings-dialog.h:
1817 * src/maemo/modest-account-settings-dialog.c:
1818 Added get_supported_secure_authentication_methods(), though it is mostly
1819 commented-out for now until the necessary API is committed to tinymail.
1820 (modest_account_settings_dialog_set_account_name),
1821 (save_configuration): Request the supported authentication methods from the
1822 server, so we can choose a working method.
1824 * src/modest-tny-account-store.h:
1825 * src/modest-tny-account-store.c:
1826 (modest_tny_account_store_get_session): Rename from
1827 tny_account_store_get_session().
1829 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1831 * src/modest-protocol-info.h: Split the ModestProtocol enum
1832 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1833 There was no need to have these unrelated values in one enum.
1835 * src/: many files: Adapted to changed enum. This makes the code a bit
1836 clearer, and the compiler could catch some errors.
1838 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1840 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1841 Show the detailed internal camel error message when an error happens
1842 during the configuration, so that our testers can give us more clues.
1843 For instance, in projects.maemo.org bug NB#56910 .
1845 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1847 * src/modest-tny-account.c:
1848 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1849 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1851 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1853 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1854 * src/maemo/modest-account-settings-dialog.c:
1855 (modest_account_settings_dialog_set_account_name),
1856 (save_configuration): For the incoming secure authentication checkbox,
1857 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1858 the UI specification. PLAIN does not seem to be supported for most IMAP
1859 servers anyway, and I am not sure what it would mean.
1860 However, we probably need to discover which of the secure-authentication
1861 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1862 * src/modest-account-mgr-helpers.c:
1863 (modest_account_mgr_get_server_account_data):
1865 * src/modest-tny-account.c:
1866 (modest_tny_account_new_from_server_account):
1867 Use tny_account_set_mech() to set secure-authentication methods,
1868 with some special-casing for IMAP, based on my observations of how
1871 * src/modest-account-mgr-helpers.h:
1872 * src/modest-account-mgr.c:
1873 * src/modest-defs.h: Comment that the URI is only used for local folders.
1875 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1877 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1878 parameter const, just to be neat.
1879 * src/modest-text-utils.c: (modest_text_utils_inline):
1880 End g_strconcat() with NULL, as its documentation says. This is almost
1881 certainly the cause of my crash at startup on the device. Interestingly,
1882 valgrind doesn't tell us about these errors.
1884 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1886 * scripts/build-packages: Added more precise comments about how to use
1887 this script, though I still get this error:
1888 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1889 error building tinymail
1891 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/modest-main-window.c: (on_account_update):
1894 Very slight cleanup, hoping to make it simpler to discover what causes
1895 a crash here sometimes.
1897 * src/modest-tny-account.c:
1898 (modest_tny_account_new_from_server_account): Set the port. Added
1899 comments about the options and a TODO comment because I need to find out
1900 how to specify the secure authentication method.
1902 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1904 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1905 changed CFlags paths form modest to libmodest
1907 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1909 * src/modest-account-mgr-helpers.c:
1910 (modest_account_mgr_get_server_account_data),
1911 (modest_account_mgr_free_server_account_data):
1912 * src/modest-account-mgr-helpers.h:
1913 * src/modest-account-mgr.c:
1914 (modest_account_mgr_add_server_account):
1915 * src/modest-defs.h:
1916 * src/modest-tny-account.c:
1917 (modest_tny_account_new_from_server_account):
1918 Determine the options for tny_camel_account_add_option() here,
1919 based on the settings, rather than storing them directly in gconf.
1921 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1923 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1924 Show a more friendly error dialog now that we expect (from the tinymail
1925 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1927 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1929 * src/maemo/modest-main-window.c: (on_account_update): Check that
1930 account_name is not NULL, to prevent a crash at startup that I am
1931 seeing on the N800. I do wonder why it is NULL.
1933 * src/maemo/easysetup/modest-easysetup-wizard.c:
1934 (create_page_user_details):
1935 * src/maemo/modest-account-settings-dialog.c:
1936 (create_page_user_details), (create_page_outgoing):
1937 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1938 (modest_connection_specific_smtp_edit_window_init):
1939 * src/modest-ui-actions.c:
1940 (modest_ui_actions_on_password_requested):
1941 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1942 might do something useful with the on-screen keyboard.
1944 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1946 * src/maemo/modest-main-window.c: (on_account_update):
1947 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1948 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1950 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1952 * src/modest-tny-account-store.c: (on_account_changed):
1953 Correct the signature of this signal handler.
1955 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1957 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1958 Show a HildonNote instead of a GtkDialog for Maemo.
1960 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1962 * src/widgets/modest-account-view.h:
1963 * src/widgets/modest-account-view.c: (on_account_changed),
1964 (on_account_removed). Added a boolean flag, set/unset by
1965 modest_account_view_block_conf_updates(),
1966 modest_account_view_unblock_conf_updates() to prevent unnecessary
1967 updates, but this is not very useful because the gconf notifications are
1968 so delays (maybe only on Maemo Bora).
1969 So auto-updating is turned off, and these functions do an explicit
1970 update when necessary.
1971 However, something else is still doing too much work when adding/removing
1972 accounts, probably in another part of the application.
1974 * src/maemo/modest-account-view-window.c:
1975 (on_delete_button_clicked), (on_edit_button_clicked),
1976 (on_new_button_clicked): Use the new functions.
1978 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1980 * src/modest-account-mgr-helpers.c:
1981 (modest_account_mgr_set_first_account_as_default):
1982 Sort the list of names alphabetically-by-title, so we choose the first one
1984 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1985 alphabetically by the title.
1987 This fixes projects.maemo.org bug NB#56418 .
1989 * src/modest-account-mgr-priv.c:
1990 (_modest_account_mgr_account_from_key):
1991 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1992 avoid a valgrind error, and possible random behaviour.
1994 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1996 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1997 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1998 tinymail documentation to say that this can be expected.
1999 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2000 pretty, and should not happen, but I would prefer to know when it does.
2002 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2004 * configure.ac: When using the older hildon version, probably on Bora,
2005 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2007 * src/widgets/modest-attachment-view.c:
2008 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2011 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2013 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2014 Implemented the prototype. Can be tested with
2015 tests/dbus_api/test_open_message:
2017 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2019 * src/modest-tny-account-store.c:
2020 (modest_tny_account_store_instance_init), (get_password):
2021 * src/modest-ui-actions.c:
2022 (modest_ui_actions_on_password_requested):
2023 Do not store the password in gconf, because this function is called
2024 for non-remembered passwords. Actually use the cached (in the hash map)
2025 password instead of releasing it.
2026 The password will now not be remembered if it is asked via the protected
2027 password dialog, as per the UI spec.
2029 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2031 * src/modest-defs.h:
2032 * src/modest-account-mgr-helpers.h:
2033 * src/modest-account-mgr-helpers.c:
2034 Added modest_server_account_get_username_has_succeeded(),
2035 modest_server_account_set_username_has_succeeded().
2036 (modest_server_account_set_username),
2037 Reset the has-succeeded flag if the username changes.
2039 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2040 * src/maemo/modest-connection-specific-smtp-window.c:
2041 (modest_connection_specific_smtp_window_save_server_accounts):
2042 Use modest_server_account_set_username() instead of using
2043 modest_conf_set_string() directly, so that the has-succeeded flag is always
2046 * src/modest-ui-actions.c:
2047 (modest_ui_actions_on_password_requested): Dim the username entry if
2048 the username has ever worked, as per the UI spec.
2050 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2052 * src/modest-tny-account-store.c: (get_password):
2053 * src/modest-ui-actions.c:
2054 (modest_ui_actions_on_password_requested):
2055 Allow the username to be changed too, though there is more work to
2056 be done on exactly how this behaves.
2058 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2060 * src/modest-account-mgr-helpers.h:
2061 * src/modest-account-mgr-helpers.c:
2062 Added modest_account_mgr_get_display_name(),
2063 modest_server_account_get_username(),
2064 modest_server_account_set_username(),
2065 modest_server_account_set_password(),
2066 modest_server_account_get_hostname() functions so we do not need to
2067 use the conf API directly.
2069 * src/maemo/modest-main-window.c: (connect_signals):
2070 Actually connect ot the ModestAccountStore::request-password signal,
2071 so that we show the dialog when the password is requested by Tinymail,
2072 for isntance if it is empty.
2074 * src/modest-marshal.list:
2075 * src/modest-tny-account-store.c:
2076 (modest_tny_account_store_class_init), (get_password),
2077 (modest_tny_account_store_alert):
2078 * src/modest-tny-account-store.h:
2079 * src/modest-ui-actions.h:
2080 * src/modest-ui-actions.c:
2081 (modest_ui_actions_on_password_requested):
2082 Change the signal parameters, so it is obvious that we are providing
2083 the non human-readable server name, and receiving both the username
2084 and password, though changing of the username is not yet implemented.
2085 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2086 for the GNOME version.
2088 This should fix the projects.maemo.org bug NB#56209, though it does not
2089 work on Bora, because the gconf_client_get() for the password fails
2090 immediately after we save it with gconf_client_set().
2092 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2095 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2096 caused an undefined symbol error:
2097 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2099 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2101 * src/modest-tny-account-store.c:
2102 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2103 using a GError instead of a string message, so we can translate it in
2106 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2108 * src/maemo/modest-address-book.c:
2109 (modest_address_book_check_names):
2110 * src/maemo/modest-msg-view-window.c:
2111 (modest_msg_view_window_clipboard_owner_change):
2112 * src/modest-init.c: (modest_init_init_ui):
2113 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2114 (update_folders_cb), (modest_mail_operation_update_account):
2115 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2116 (modest_ui_actions_on_msg_attachment_clicked),
2117 (modest_ui_actions_on_msg_recpt_activated):
2118 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2119 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2120 (modest_msg_view_search_next):
2121 * src/widgets/modest-recpt-editor.c:
2122 (modest_recpt_editor_on_button_release_event),
2123 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2124 g_message(). At this point we should only be seeing interesting errors on
2125 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2127 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2129 (modest_wizard_dialog_force_title_update):
2130 * src/maemo/easysetup/modest-wizard-dialog.h:
2131 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2132 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2133 can update the title when appropriate. Otherwise the title is wrong if the
2134 pages are added after adding the notebook to the dialog.
2135 This must be a problem in HildonWizardDialog too.
2136 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2138 * src/maemo/easysetup/modest-easysetup-wizard.c:
2139 (create_subsequent_customsetup_pages),
2140 (create_subsequent_easysetup_pages):
2141 Call modest_wizard_dialog_force_title_update() so that the title is
2142 correct even with GTK+ < 2.10.
2143 This fixes projects.maemo.org bug NB#56145 .
2145 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2147 * src/maemo/modest-platform.c:
2148 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2149 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2152 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2154 * src/widgets/modest-window.h:
2155 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2156 and modest_window_save_state(), which invokes it.
2158 * src/widgets/modest-window-mgr.h:
2159 * src/widgets/modest-window-mgr.c:
2160 Added modest_window_mgr_save_state_for_all_windows(), which calls
2161 the save_state vfunc on all registered windows, if implemented.
2163 * src/gnome/modest-msg-edit-window.c:
2164 * src/gnome/modest-msg-view-window.c:
2165 * src/maemo/modest-msg-edit-window.c:
2166 * src/maemo/modest-msg-view-window.c:
2167 * src/maemo/modest-main-window.c:
2168 Specify the existing save_settings functions as implementations of
2169 ModestWindow::save_state_func().
2171 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2172 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2173 enabling hibernation, for instance.
2175 We may need to do the same thing for restoring settings.
2178 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2180 * src/widgets/modest-window-mgr.c:
2181 * src/widgets/modest-window-mgr.h:
2182 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2183 modest_window_mgr_get_hibernation_is_prevented().
2185 * src/maemo/modest-main-window.c:
2186 (on_hildon_program_is_topmost_notify): Prevent hibernation
2187 (possible when the application goes to the background in the WM),
2188 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2190 * src/maemo/easysetup/modest-easysetup-wizard.c:
2191 (modest_easysetup_wizard_dialog_init):
2192 * src/maemo/modest-account-settings-dialog.c:
2193 (modest_account_settings_dialog_init):
2194 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2195 (modest_connection_specific_smtp_edit_window_init):
2196 * src/maemo/modest-connection-specific-smtp-window.c:
2197 (modest_connection_specific_smtp_window_init):
2198 * src/maemo/modest-signature-editor-dialog.c:
2199 (modest_signature_editor_dialog_init):
2200 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2201 prevent hibernation while any of these account settings dialogs are open.
2203 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2205 * src/maemo/Makefile.am:
2206 * src/maemo/modest-osso-state-saving.c:
2207 * src/maemo/modest-osso-state-saving.h: Added
2208 modest_osso_load_state() and modest_osso_save_state() though they do
2209 nothing now. They should iterate through all the open windows and load/save
2211 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2212 save state when closing.
2214 * src/maemo/modest-main-window.c:
2215 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2216 Add a notification handler for the HildonProgram::is-topmost property,
2217 so we can allow hibernation when the application goes into the background.
2218 But we still need to detect when the accounts setup windows are open so
2219 we can stop hibernation when they are open.
2220 To do this, I also added the main window the HildonProgram. This might have
2221 other side-effects/benefits, and should maybe be done for other windows.
2223 * src/maemo/modest-osso-autosave-callbacks.h:
2224 * src/maemo/modest-osso-autosave-callbacks.c:
2225 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2226 though it does not do anything yet, and we might never need this to do
2227 anything. For instance, we already save drafts.
2229 * src/maemo/modest-platform.c: (modest_platform_init):
2230 Specify the libosso auto-save callback.
2232 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/modest-platform.c:
2235 (modest_platform_set_update_interval):
2236 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2237 aparently stays valid between application instances, so we can use this
2238 to remove and reset it later. According to a maemo-developers email from
2241 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2243 * configure.ac: Depend on libalarm for Maemo.
2245 * src/dbus_api/modest-dbus-api.h:
2246 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2247 (on_send_receive), (modest_dbus_req_handler):
2248 Handle a SEND_RECEIVE D-Bus method.
2250 * libmodest-dbus-client/libmodest-dbus-client.c:
2251 (libmodest_dbus_client_send_and_receive):
2252 * libmodest-dbus-client/libmodest-dbus-client.h:
2253 Add C convenience functions for calling the new D-Bus method.
2255 * src/modest-platform.h:
2256 * src/gnome/modest-platform.c:
2257 * src/maemo/modest-platform.c:
2258 Added modest_platform_set_update_interval(), which uses the
2259 alarmd API on Maemo.
2260 (modest_platform_init),
2261 Call modest_platform_set_update_interval(), using a hard-coded
2262 interval for now (until the global settings dialog is implemented),
2263 though I am not sure that this makes sense yet.
2265 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2267 * src/dbus_api/modest-dbus-callbacks.c:
2268 (modest_osso_cb_hw_state_handler):
2269 * src/dbus_api/modest-dbus-callbacks.h:
2270 * src/maemo/modest-platform.c: (modest_platform_init):
2271 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2272 in case this has some effect on the ability for Maemo to ping the
2275 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2277 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2278 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2279 warning. It is probably a logic error, but I need to fix the build.
2281 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2283 * src/modest-account-mgr.h:
2284 * src/modest-account-mgr.c:
2285 (modest_account_mgr_account_names): Add a gboolean enabled_only
2286 parameter, so we can get lists of onlt the enabled accounts.
2288 (modest_account_mgr_add_account),,
2289 (modest_account_mgr_account_with_display_name_exists):
2290 * src/maemo/modest-msg-edit-window.c: (get_transports):
2291 * src/modest-account-mgr-helpers.c:
2292 (modest_account_mgr_set_first_account_as_default):
2293 * src/modest-init.c: (init_default_account_maybe):
2294 * src/modest-tny-account-store.c: (get_accounts):
2295 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2296 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2297 * tests/check_account-mgr.c: (START_TEST):
2298 Provide the extra parameter, as appropriate.
2300 * src/widgets/modest-account-view.c: (update_account_view):
2301 Do not show disabled accounts (meaning that there is no way to
2302 enable/disable accounts in the UI (the feature is not in our UI
2303 specification), so we can use this internally only to mark unfinished
2304 or temporary account data.
2306 * src/maemo/easysetup/modest-easysetup-wizard.c:
2307 (create_account): Add boolean enable parameter, so we can specify FALSE
2308 to create the temporary account.
2309 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2310 (on_before_next): When finishing, when there is a temporary account, just
2312 Also, use a timeout to delay the showing of the dialog until gconf is likely
2313 to return correct information, due to a maemo gconf bug that is fixed in
2314 osso 1.1, but not yet in Bora.
2315 However, the dialog stays on screen after it is destroyed.
2317 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2318 for invalid data when cancelling. Use a hildon note instead of a dialog
2319 to complain about invalid data. Do not show the account-saved note if the
2320 account is disabled (a temporary account that will not really be saved for use
2323 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2325 * src/modest-account-mgr-helpers.h:
2326 * src/modest-account-mgr-helpers.c:
2327 Added modest_account_mgr_unset_default_account(),
2328 Added modest_account_mgr_set_first_account_as_default().
2330 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2331 If it was the default account, unset the default account name.
2333 * src/maemo/modest-account-view-window.c:
2334 (on_delete_button_clicked): If it was the default account,
2335 set the first remaining account as the default instead.
2337 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2338 a NULL account or a NULL default account, to prevent a crash. This should
2339 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2342 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2344 * src/widgets/modest-recpt-editor.c:
2345 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2346 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2347 TODO comment for this. This fixes the build.
2349 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2350 be the best place for it. This will in future update all auto-update accounts,
2351 rather than just the current/default account, when that gconf key exists.
2352 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2353 if there are no accounts, before calling do_send_receive().
2354 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2356 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2357 * src/maemo/modest-main-window-ui.h:
2358 * src/maemo/modest-main-window.c: (on_connection_changed),
2359 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2360 directly, becaue the signal handler does more.
2362 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2364 * src/modest-account-mgr-helpers.c:
2365 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2366 for the case that the account does not exist.
2368 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2369 (equivalent to the modest account name) rather than the tinymail account name
2370 (equivalent to the modest account title - human readable) to get the account data.
2371 Check for null account data to prevent the crash, and add a TODO comment saying that
2372 this needs fixing because it is using the server account name instead of the account name.
2374 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2376 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2377 * src/maemo/modest-account-settings-dialog.c: (show_error),
2379 Use hildon_note_new_information() for informative and error messages,
2380 which seems to be expected for Maemo applications (no documentation that I know of
2381 says this). I am surprised that there is no distinction between info and error
2384 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2387 it is easy to find where this is used.
2389 * src/maemo/easysetup/modest-easysetup-wizard.c:
2390 (create_page_welcome), (create_page_account_details),
2391 (create_page_user_details), (create_page_complete_easysetup),
2392 (create_page_custom_incoming), (create_page_custom_outgoing),
2393 (create_page_complete_custom):
2394 * src/maemo/modest-account-settings-dialog.c:
2395 (create_page_account_details), (create_page_user_details),
2396 (create_page_incoming), (create_page_outgoing):
2397 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2398 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2399 (modest_connection_specific_smtp_edit_window_init):
2400 * src/maemo/modest-connection-specific-smtp-window.c:
2401 (modest_connection_specific_smtp_window_init):
2402 * src/maemo/modest-signature-editor-dialog.c:
2403 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2404 and scrolling policy as per the Email Application Layout Guide, if I have
2407 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2409 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2410 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2411 which were empty, because these vfuncs have been removed from TnyAccountStore.
2412 This fixes the build.
2414 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2416 * src/maemo/modest-main-window.c:
2417 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2418 showing/hiding it. Added TODO because it probably should not be NULL.
2419 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2420 because unnecessary g_warnings() make degugging difficult.
2422 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2424 * src/maemo/modest-msg-edit-window.c:
2425 (modest_msg_edit_window_select_color),
2426 (modest_msg_edit_window_select_background_color): 2 const corrections and
2427 moving 2 #endifs before closing brackets, to fix the build.
2429 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/easysetup/modest-easysetup-wizard.h:
2432 * src/maemo/easysetup/modest-easysetup-wizard.c:
2433 (modest_easysetup_wizard_dialog_finalize),
2434 (on_button_edit_advanced_settings), (create_page_complete_custom),
2435 (on_response), (create_account):
2436 Implement the Advanced Settings edit button, by saving the account information,
2437 for the Advanded Settings dialog to use directly from gconf, and removing it
2438 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2439 Bug #5533 in the projects.maemo.org bugzilla.
2441 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2443 * src/maemo/modest-msg-view-window.c:
2444 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2445 when opening a message window.
2447 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2449 * src/maemo/easysetup/modest-easysetup-wizard.c:
2450 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2453 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2454 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2455 gconf settings. I probably added more checks than necessary, but that is safer.
2457 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2458 variable to fix the build, but this seems to be used when it is still NULL.
2460 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2462 * src/modest-platform.h:
2463 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2464 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2465 * src/modest-main.c: Implement this function so we can avoid using
2466 maemo-specific API from cross-platform code.
2468 * src/modest-tny-account-store.c:
2469 (get_smtp_specific_transport_account_for_open_connection):
2470 * src/modest-ui-actions.c: (check_for_connection),
2471 (modest_ui_actions_on_item_not_found):
2472 Use modest_platform_connect_and_wait() and put #idefs around other
2473 maemo-specific code, because only maemo currently has a way to
2474 identify connection names.
2476 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2478 * src/modest-tny-account-store.h:
2479 * src/modest-tny-account-store.c:
2480 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2481 the connection-specific SMTP server settings in the configuration.
2483 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2485 * src/maemo/modest-main-window.c: (on_connection_changed),
2487 * src/modest-main.c: (main), (start_ui), (send_mail):
2488 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2489 that is what is intended.
2491 * src/modest-ui-actions.c: (action_send), (action_receive),
2492 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2493 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2494 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2495 SMTP server is used when it is specified.
2497 (modest_ui_actions_on_send_receive):
2498 Check that a connection is open before proceeding.
2499 Receive and then send, instead of vice-versa, as per the specification.
2501 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2503 * src/modest-mail-operation.c:
2504 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2505 though I guess it should be something other than NULL.
2507 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/easysetup/modest-easysetup-wizard.c:
2510 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2511 combo twice, to avoid an g_warning and to make it visible again.
2512 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2513 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2514 (already intended) dereference when detaching, because we then recreate the menu.
2515 But I am not sure why the warning was happening, and it is possible that this is a memory
2518 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2520 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2521 and uri_parse_mailto() utility functions.
2522 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2524 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2526 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2528 * src/dbus_api/modest-dbus-api.h:
2529 * src/dbus_api/modest-dbus-callbacks.c:
2530 Use an idle callback to execute the modest code in the application's own thread.
2531 Remove the helloworld example method.
2532 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2533 parsed, and the open-message method is not implemented because this is not yet implemented in
2535 * libmodest-dbus-client/libmodest-dbus-client.c:
2536 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2537 (libmodest_dbus_client_open_message):
2538 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2540 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2541 body without crashing.
2543 * tests/dbus_api/Makefile.am:
2544 * tests/dbus_api/test_mail_to.c:
2545 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2547 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2549 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2550 Added file to fix the build. Sorry.
2552 * src/dbus_api/Makefile.am:
2553 * src/dbus_api/modest-dbus-api.h:
2554 * src/dbus_api/modest-dbus-callbacks.h:
2555 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2556 (modest_dbus_req_handler):
2557 Put constants in a separate header so it can be reused by the
2558 client library, without duplication
2560 * libmodest-dbus-client/Makefile.am:
2561 * libmodest-dbus-client/libmodest-dbus-client.c:
2562 (libmodest_dbus_client_call_helloworld),
2563 (libmodfest_dbus_client_send_mail),
2564 (libmodfest_dbus_client_mailto),
2565 (libmodfest_dbus_client_open_message):
2566 * libmodest-dbus-client/libmodest-dbus-client.h:
2567 (Partly) Implement a send_mail D-Bus method.
2569 * tests/dbus_api/Makefile.am:
2570 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2571 the send_email D-Bus method.
2573 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2577 * libmodest-dbus-client/Makefile.am:
2578 * libmodest-dbus-client/libmodest-dbus-client.c:
2579 * libmodest-dbus-client/libmodest-dbus-client.h:
2580 * tests/dbus_api/Makefile.am:
2581 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2582 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2584 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/easysetup/modest-easysetup-wizard.c:
2587 (create_page_account_details):
2588 * src/maemo/modest-account-settings-dialog.c:
2589 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2590 widgets, because this might not be the default in future versions of the Maemo GTK+.
2591 However, I can not not get capitalization to work even in a simple test case.
2593 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2595 * src/maemo/easysetup/modest-easysetup-wizard.c:
2596 (create_page_custom_incoming), (create_page_custom_outgoing):
2597 * src/maemo/modest-account-settings-dialog.c:
2598 (create_page_account_details), (create_page_incoming),
2599 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2600 instead of using gtk_check_button_with_label(), so they are aligned like the other
2601 widgets, as per the UI spec.
2603 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/easysetup/modest-easysetup-wizard.c:
2606 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2607 * src/widgets/modest-validating-entry.c:
2608 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2609 Modest prefix instead of an EasySetup prefix.
2611 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2613 * src/widgets/modest-validating-entry.h:
2614 * src/widgets/modest-validating-entry.c: (on_insert_text),
2615 Added easysetup_validating_entry_set_max_func(), used to set a callback
2616 to call when the max number of characters is reached. GtkEntry has a max-length
2617 already but is silent about it.
2619 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2620 (create_page_account_details), (create_page_user_details),
2622 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2623 (create_page_account_details), (create_page_user_details),
2624 (create_page_outgoing):
2625 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2626 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2627 the UI spec, when the user tries to enter more than the max number of characters.
2629 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2631 * src/maemo/easysetup/modest-easysetup-wizard.c:
2632 (create_page_user_details), (create_page_custom_incoming),
2633 (create_page_custom_outgoing):
2634 * src/maemo/modest-account-settings-dialog.c:
2635 (create_page_user_details), (create_page_incoming),
2636 (create_page_outgoing):
2637 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2638 (modest_connection_specific_smtp_edit_window_init):
2639 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2640 not appropriate. Bad Maemo-specific defaults!.
2642 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2644 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2645 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2646 (modest_signature_editor_dialog_set_settings):
2647 Disable the label and textview when the checkbox is disabled, and use the
2648 specified (UI spec) default signature text.
2650 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2652 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2653 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2655 * src/modest-defs.h:
2656 * src/modest-account-mgr-helpers.h:
2657 * src/modest-account-mgr-helpers.c:
2658 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2660 * src/maemo/Makefile.am:
2661 * src/maemo/modest-signature-editor-dialog.c:
2662 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2665 * src/maemo/modest-account-settings-dialog.h:
2666 * src/maemo/modest-account-settings-dialog.c:
2667 (modest_account_settings_dialog_finalize), (on_button_signature),
2668 (save_configuration): Use the new dialog when the Edit button is pressed, and
2669 save the changes if necessary, as per the UI spec.
2671 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/Makefile.am:
2674 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2675 based on maemo-develoers email from Dirk.
2677 * src/maemo/easysetup/modest-easysetup-wizard.c:
2678 (create_page_welcome), (create_page_account_details),
2679 (create_page_user_details), (create_page_complete_easysetup),
2680 (create_page_custom_incoming), (create_page_custom_outgoing),
2681 (create_page_complete_custom),
2682 (modest_easysetup_wizard_dialog_init):
2683 * src/maemo/modest-account-settings-dialog.c:
2684 (create_page_account_details), (create_page_user_details),
2685 (create_page_incoming), (create_page_outgoing),
2686 (modest_account_settings_dialog_init):
2687 * src/maemo/modest-connection-specific-smtp-window.c:
2688 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2690 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2692 * src/maemo/easysetup/modest-easysetup-wizard.c:
2693 (create_page_account_details), (create_page_custom_outgoing),
2694 (create_page_complete_custom):
2695 * src/maemo/modest-account-settings-dialog.c:
2696 (create_page_user_details), (create_page_incoming),
2697 (create_page_outgoing):
2698 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2699 (modest_connection_specific_smtp_edit_window_init):
2700 Use the correct (UI spec) port min/max, and use horizontal separators,
2703 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2705 * src/maemo/easysetup/modest-easysetup-wizard.c:
2706 (set_default_custom_servernames):
2707 * src/maemo/modest-account-settings-dialog.c:
2708 (create_page_incoming), (on_combo_outgoing_security_changed),
2709 (on_combo_incoming_security_changed), (create_page_outgoing),
2710 (modest_account_settings_dialog_set_account_name),
2711 (save_configuration):
2712 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2713 (on_combo_security_changed),
2714 (modest_connection_specific_smtp_edit_window_init),
2715 (modest_connection_specific_smtp_edit_window_set_connection),
2716 (modest_connection_specific_smtp_edit_window_get_settings):
2717 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2720 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2723 * src/maemo/easysetup/modest-easysetup-wizard.c:
2724 (create_page_custom_outgoing), (create_page_complete_custom):
2725 * src/maemo/modest-account-settings-dialog.c:
2726 (create_page_user_details), (create_page_outgoing):
2727 * src/maemo/modest-account-view-window.c: (button_box_new):
2728 Use changed logical IDs as per the most recent UI spec:
2729 mcen_bd_emailsetup_edit -> mcen_bd_edit
2730 mcen_bd_emailsetup_delete -> mcen_bd_delete
2731 mcen_bd_emailsetup_close -> mcen_bd_close
2733 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2737 * src/dbus_api/Makefile.am:
2738 * src/dbus_api/modest-dbus-callbacks.c:
2739 * src/dbus_api/modest-dbus-callbacks.h:
2740 * src/maemo/modest-platform.c: (modest_platform_init):
2741 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2743 * tests/Makefile.am:
2744 * tests/dbus_api/Makefile.am:
2745 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2747 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2749 * src/maemo/modest-account-settings-dialog.c:
2750 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2751 Removed unnecessary includes.
2753 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2755 * src/maemo/easysetup/modest-easysetup-wizard.c:
2756 * src/maemo/modest-account-settings-dialog.c:
2757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2758 * src/widgets/Makefile.am:
2759 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2760 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2761 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2762 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2763 * src/widgets/modest-secureauth-combo-box.c:
2764 * src/widgets/modest-secureauth-combo-box.h:
2765 * src/widgets/modest-serversecurity-combo-box.c:
2766 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2767 made the GObject names more consistent with the rest of the Modest code.
2769 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2771 * src/maemo/easysetup/Makefile.am:
2772 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2773 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2774 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2775 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2776 * src/maemo/easysetup/modest-easysetup-wizard.c:
2777 * src/maemo/easysetup/modest-validating-entry.c:
2778 * src/maemo/easysetup/modest-validating-entry.h:
2779 * src/maemo/modest-account-settings-dialog.c:
2780 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2781 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2782 widgets/ because they are used outside of easysetup too. After checking in,
2783 svn will allow me to rename them too.
2785 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2787 * src/gnome/modest-msg-edit-window.c:
2788 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2789 linker error, to fix the build on the GNOME platform.
2790 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2791 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2792 ifdefed out to avoid a warning.
2794 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2796 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2797 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2798 some alternative for GTK+ 2.6.
2800 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2804 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2805 specified for EmailAccountsDialog in UI spec.
2807 * src/maemo/easysetup/modest-easysetup-wizard.c:
2808 * src/maemo/easysetup/modest-easysetup-wizard.h:
2809 * src/maemo/modest-account-settings-dialog.c:
2810 * src/maemo/modest-account-settings-dialog.h:
2811 Reuse a member window widget for the connection-specific SMTP server accounts,
2812 so we can tell it to create/save the accounts only if we actually save changes.
2814 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2816 (modest_connection_specific_smtp_edit_window_get_settings):
2817 Return a struct instance for temporarily remembering the entered data.
2819 * src/maemo/modest-connection-specific-smtp-window.h:
2820 * src/maemo/modest-connection-specific-smtp-window.c:
2821 (modest_connection_specific_smtp_window_finalize),
2822 (modest_connection_specific_smtp_window_fill_with_connections),
2824 (modest_connection_specific_smtp_window_save_server_accounts),
2825 (update_model_server_names): Do not actually save data until asked,
2826 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2828 (on_selection_changed),
2829 (modest_connection_specific_smtp_window_init): Disable the edit
2830 button when nothing is selected.
2832 * src/modest-account-mgr-helpers.c:
2833 * src/modest-account-mgr-helpers.h:
2834 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2837 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-account-mgr-helpers.h:
2840 * src/modest-account-mgr-helpers.c:
2841 (modest_account_mgr_get_unused_account_name),
2842 (modest_account_mgr_get_unused_account_display_name): Added these
2843 utility functions, to avoid code duplication.
2845 * src/maemo/easysetup/modest-easysetup-wizard.c:
2846 (create_page_account_details), (create_account):
2847 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2848 (on_combo_security_changed),
2849 (modest_connection_specific_smtp_edit_window_init),
2850 (modest_connection_specific_smtp_edit_window_save_settings):
2851 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2852 * src/maemo/modest-connection-specific-smtp-window.c:
2853 (modest_connection_specific_smtp_window_finalize),
2854 (modest_connection_specific_smtp_window_fill_with_connections),
2855 (on_button_edit), (modest_connection_specific_smtp_window_init):
2856 * src/maemo/modest-connection-specific-smtp-window.h:
2857 Implementing saving of connection-specific server accounts.
2859 But I need to refactor this so we can save the data for each
2860 possible connection-specific account and only actually create the server accounts
2861 when the easysetup finished, or the OK button is pressed on the account settings
2864 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2867 (on_combo_security_changed):
2868 (modest_connection_specific_smtp_edit_window_init):
2869 Auto-fill the port number as in the account settings.
2871 (modest_connection_specific_smtp_edit_window_set_connection):
2872 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2873 * src/maemo/modest-connection-specific-smtp-window.c:
2874 (fill_with_connections), (on_button_edit),
2875 (modest_connection_specific_smtp_window_init):
2876 Turn the edit window into a dialog to simplify the code, and
2877 set a WM hint as in a GtkDialog, because only a popup can be on top of
2878 another window in Maemo, and popups usually have no WM decoration.
2880 * src/modest-defs.h:
2881 * src/modest-account-mgr-helpers.c:
2882 (modest_account_mgr_set_connection_specific_smtp),
2883 (modest_account_mgr_remove_connection_specific_smtp),
2884 (modest_account_mgr_get_connection_specific_smtp):
2885 * src/modest-account-mgr-helpers.h: Some functions to write the
2886 connection-specific SMTP server information. Not yet used.
2889 * src/widgets/modest-folder-view.c: (text_cell_data):
2890 Fix a warning about an uninitialized variable.
2891 (on_configuration_key_changed): Put an #ifdef around the use
2892 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2894 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2896 * src/maemo/modest-account-settings-dialog.h:
2897 * src/maemo/modest-account-settings-dialog.c:
2898 Added connect_for_modified() utility function to mark the new modified boolean.
2900 (create_page_account_details), (create_page_user_details),
2901 (create_page_incoming), (create_page_outgoing), (on_response),
2902 (modest_account_settings_dialog_init),
2903 (modest_account_settings_dialog_set_account_name):
2904 Only warn about unsaved changes when there are actually unsaved changes.
2906 * src/modest-account-mgr-helpers.c:
2907 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2908 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2909 to get the data from there in future.
2911 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2913 * src/modest-defs.h:
2915 * src/modest-account-mgr-helpers.h:
2916 * src/modest-account-mgr-helpers.c:
2917 Store the security account setting in a single conf key instead of using
2918 the options list, so that the list is left for just the to-be-removed camel hack,
2919 and because gconf_client_set_list() is failing for some reason.
2921 * src/modest-account-mgr.c:
2922 (modest_account_mgr_add_server_account):
2923 * src/maemo/modest-account-settings-dialog.c:
2924 (modest_account_settings_dialog_set_account_name),
2925 (save_configuration): Use the renamed functions.
2928 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2930 * src/widgets/Makefile.am:
2931 * src/widgets/modest-limit-retrieve-combo-box.c:
2932 * src/widgets/modest-limit-retrieve-combo-box.h:
2933 * src/widgets/modest-retrieve-combo-box.c:
2934 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2935 the account settings dialog.
2937 * src/modest-defs.h:
2938 * src/modest-account-mgr-helpers.h:
2939 * src/modest-account-mgr-helpers.c:
2940 (modest_server_account_get_option_secure_auth),
2941 (modest_server_account_set_option_secure_auth):
2942 * src/modest-account-mgr.c:
2943 (modest_account_mgr_add_server_account):
2944 Use the existing AUTH_MECH conf key for the secure-auth setting,
2945 instead of putting it in the list options, because this was actually used already.
2947 * src/maemo/modest-account-settings-dialog.c:
2948 (create_page_account_details),
2949 (modest_account_settings_dialog_set_account_name),
2950 (save_configuration):
2951 * src/maemo/modest-account-settings-dialog.h:
2952 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2953 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2955 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2957 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2958 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2959 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2961 * src/modest-defs.h:
2962 * src/maemo/modest-account-settings-dialog.c:
2963 (create_page_incoming), (on_combo_outgoing_security_changed),
2964 (on_combo_incoming_security_changed), (create_page_outgoing),
2965 (modest_account_settings_dialog_set_account_name),
2966 (save_configuration): Load/Save the port number, and change it when the
2967 security combo changes, to suitable defaults.
2969 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2971 * src/modest-account-mgr.c:
2972 (modest_account_mgr_add_server_account): Set the security and secure-auth
2973 options, and add a comment saying that the other camel-specific options should be
2976 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2978 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2980 * src/modest-tny-account-store.c: (account_list_free),
2981 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2982 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2985 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2987 * src/modest-protocol-info.c:
2988 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2989 is required by our UI spec. Maybe something in our implementation will use this eventually.
2990 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2991 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2992 instead of the previous 0 placeholder.
2994 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2995 secure-auth settings.
2996 * src/modest-account-mgr-helpers.h:
2997 * src/modest-account-mgr-helpers.c:
2998 (modest_server_account_data_get_option_secure_auth),
2999 (modest_server_account_set_option_secure_auth),
3000 (modest_server_account_data_get_option_security),
3001 (modest_server_account_set_option_security): Added this API for getting and setting the security
3002 and secure-auth settings.
3004 * src/maemo/modest-account-settings-dialog.h:
3005 * src/maemo/modest-account-settings-dialog.c:
3006 (modest_account_settings_dialog_finalize), (check_data),
3007 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3008 about changing titles.
3009 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3010 (save_configuration): Save the security and secure-auth settings.
3012 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3013 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3015 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3017 * src/modest-defs.h:
3018 * src/modest-account-mgr.c:
3019 (modest_account_mgr_add_server_account):
3020 Added and used defines for the options key and value pair strings,
3021 that are used so far, though they do not seem to correspond to anything in our
3022 UI specs or ModestProtocol enum.
3024 * src/modest-account-mgr-helpers.h:
3025 * src/modest-account-mgr-helpers.c:
3026 (compare_option_strings_for_name),
3027 (modest_server_account_data_get_option_value),
3028 (modest_server_account_data_get_option_bool),
3029 (modest_account_mgr_get_server_account_option):
3030 Added helper functions for parsing the options GSList.
3032 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3034 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3035 display name is based on the supplied account name.
3036 * src/modest-account-mgr.c:
3037 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3038 with an inefficient, but good-enough, implementation.
3040 * src/maemo/easysetup/modest-easysetup-wizard.c:
3041 (create_page_account_details), (on_before_next), (create_account):
3042 Check for existing display names rather than (non-user-visible) account names, and just
3043 create and set a unique account name at the end.
3045 * src/maemo/modest-account-settings-dialog.c:
3046 (modest_account_settings_dialog_init),
3047 (modest_account_settings_dialog_set_account_name),
3048 (create_page_incoming): Show the display name, instead of the account name.
3049 (on_response): Do some (not all) extra checks, as in the UI spec.
3050 (save_configuration): Save the display name if it was changed.
3052 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3054 * po/en_GB.po: Added needed logical ID and translation.
3055 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3056 (init_view): Made the is-default column clicking work.
3058 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3061 * src/maemo/easysetup/Makefile.am:
3062 * src/maemo/easysetup/modest-easysetup-wizard.c:
3063 (modest_easysetup_wizard_dialog_init):
3064 * src/maemo/easysetup/provider-data-test.keyfile:
3065 * src/maemo/easysetup/provider-data.keyfile:
3066 Moved the provider data file to the new modest-providers-data package and used it from there.
3068 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3070 * src/modest-local-folder-info.c:
3071 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3072 N_() was already used on the static strings, but this just marks it for translation without
3073 using the translation.
3075 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3077 * src/maemo/modest-account-settings-dialog.c:
3078 (create_page_incoming),
3079 (modest_account_settings_dialog_set_account_name):
3080 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3081 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3082 I will do this if nobody else gets there first.
3084 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3086 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3087 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3088 save the security stuff.
3090 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3092 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3093 Set the email address and user fullname, which I now see must be
3096 * src/maemo/modest-account-settings-dialog.h:
3097 * src/maemo/modest-account-settings-dialog.c:
3099 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3100 leave-on-server and authentication.
3101 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3104 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3107 * src/maemo/modest-account-settings-dialog.c:
3108 * src/maemo/modest-account-settings-dialog.h:
3109 Most (but not all) of the widgets are now present as specified by the UI spec.
3110 No changes are yet saved, and some details are not properly shown yet.
3112 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3114 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3116 * src/maemo/Makefile.am:
3117 * src/maemo/modest-account-settings-dialog.c:
3118 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3119 an existing account. Doesn't do much yet.
3121 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3122 Open the accounts settings dialog when Edit is clicked.
3124 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3126 * src/maemo/easysetup/Makefile.am:
3127 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3129 * src/maemo/easysetup/modest-easysetup-wizard.c:
3130 (modest_easysetup_wizard_dialog_init):
3131 Try to get the source directory from the build system,
3132 instead of hard-coding "./" into the source code, when opening our local
3133 copies of the configuration files.
3134 But this still fails when opening the wizard from the Accounts window,
3135 maybe because the working directory seems to change at runtime.
3136 So the wizard will fail the second time unless you copy the files into their
3137 proper locations - see the stdout warnings for the paths.
3139 (create_page_account_details),(on_before_next):
3140 Check for existing non-server accounts instead of server accounts,
3141 so the default account name is useful again, and to prevent trying to
3144 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3145 Show the wizard when New is clicked.
3147 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3148 (init_view): Show the column headers, and show the columns that are
3149 specified in the UI specs. However, something in Maemo's GTK+ prevents
3150 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3151 change the default account. This is despite unsetting the special properties.
3153 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3155 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3156 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3157 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3158 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3159 to make that clearer.
3160 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3162 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3164 * src/maemo/modest-account-view-window.c:
3165 (modest_account_view_window_init),
3166 (modest_account_view_window_new):
3167 Use the same buttons as specified in the
3168 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3169 the existing widgets, which never had a chance of working.
3170 Put the ModestAccountView treeview in a scrolled window.
3171 Do not repeat the initialization in both _init() and _new().
3173 * src/widgets/modest-account-view.c: (update_account_view):
3174 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3175 this widget and window shows no accounts.
3177 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3179 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3181 * src/maemo/easysetup/modest-easysetup-wizard.c:
3182 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3183 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3184 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3187 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3188 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3189 accounts exist yet, as in the UI spec.
3191 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3193 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/Makefile.am:
3196 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3197 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3198 New window for editing connection-specific smtp details.
3199 Not fully implemented.
3201 * src/maemo/modest-connection-specific-smtp-window.c:
3202 (modest_connection_specific_smtp_window_finalize) :
3203 unref the tree model.
3204 (on_button_edit): Show the edit window.
3206 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3208 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3211 * src/maemo/Makefile.am:
3212 * src/maemo/modest-connection-specific-smtp-window.c:
3213 * src/maemo/modest-connection-specific-smtp-window.h:
3214 New window for showing the list of connections, for connection-specific
3215 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3216 * src/maemo/easysetup/modest-easysetup-wizard.c:
3217 (create_page_custom_outgoing): Show the new window when the button is clicked.
3219 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3221 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3222 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3223 * src/maemo/modest-msg-edit-window.c:
3224 (modest_msg_edit_window_insert_image):
3225 * src/modest-conf.c: (modest_conf_key_escape):
3226 * src/modest-mail-operation.c:
3227 (modest_mail_operation_send_new_mail):
3228 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3229 (modest_ui_actions_on_new_account):
3230 * src/widgets/modest-attachment-view.c: (update_filename_request):
3231 * src/widgets/modest-mail-header-view.c:
3232 Corrected warnings that were breaking the build, by commenting out unused variables,
3233 and a function, and by including a header.
3235 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3237 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3238 so we can #ifdef around platform-specific code when necessary.
3239 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3240 to allow this to build for the GNOME platform too.
3242 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3244 * src/maemo/easysetup/modest-easysetup-wizard.c:
3245 Added util_increment_name() and used it in create_page_account_details()
3246 to make sure that the default account name is always a new name.
3248 (modest_easysetup_wizard_dialog_init),
3249 (set_default_custom_servernames): Some minor memory management fixes.
3251 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3255 * src/modest-runtime.c: (init_i18n): Restored the translation
3256 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3257 are defined in config.h, and the translations are installed.
3259 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3260 is defined for translation.
3262 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3264 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3266 * src/maemo/easysetup/modest-easysetup-wizard.c:
3267 (modest_easysetup_wizard_dialog_init):
3268 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3269 Use realistic paths (though they should use $prefix generically) to the
3270 mcc_mapping and provider-data.keyfile files which might work when they
3271 are installed by the future version of the operator-wizard package,
3272 and then fallback to paths in our source code, with an explanatory
3275 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3279 * src/maemo/Makefile.am:
3280 * src/maemo/easysetup/: Added files from the previously-exernal
3281 osso-modest-easysetup.
3282 * src/maemo/modest-main-window-ui.h:
3283 * src/modest-ui-actions.c:
3284 * src/modest-ui-actions.h:
3285 Added modest_ui_actions_on_new_account() as a signal handler for the
3286 New Account menu item. It shows the easysetup wizard.
3287 * po/en_GB.po: Added additional needed logical IDs and translations.