1 2007-07-12 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_password):
4 Show the password dialog (via the signal) only in the mainloop, via
5 an idle handler that we wait for. This could theoretically prevent
6 hangs, though I worry that it could introduce some too.
8 2007-07-12 Murray Cumming <murrayc@murrayc.com>
10 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
11 * src/maemo/modest-platform.c:
12 (modest_platform_connect_and_wait):
13 Take a TnyAccount* parameter and try to set it to online
14 (a TnyCamel-only API), because tinymail sets accounts to offline
15 when the user cancels a password dialog, and doesn't ask again until
16 it has been set to online.
17 However, this is commented out because it causes a hang now.
19 (modest_platform_connect_and_wait_if_network_account):
20 * src/modest-mail-operation.c:
21 (modest_mail_operation_update_account):
22 * src/modest-platform.h:
23 * src/modest-ui-actions.c: (_modest_ui_actions_open),
24 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
26 2007-07-12 Armin Burgmeier <armin@openismus.com>
28 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
30 * src/modest-mail-operation.c:
31 * src/modest-ui-actions.c: Check for already existing folder before
32 querying the server, show error message from camel if the request
33 still fails. This fixes projects.maemo.org bug NB#58701.
35 2007-07-12 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-tny-account-store.h:
38 * src/modest-tny-account-store.c:
39 Added modest_tny_account_store_forget_password_in_memory(),
40 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
41 when creating a new account, so that new passwords will be used, instead of
42 us thinking that it's a second request as a result of a failed password again.
44 2007-07-12 Murray Cumming <murrayc@murrayc.com>
46 * src/dbus_api/modest-dbus-callbacks.c:
47 (on_idle_open_message): If the message is in drafts then open it
48 in an edit window instead of a view window. This fixes
49 projects.maemo.org bug NB#63005.
51 2007-07-12 Murray Cumming <murrayc@murrayc.com>
53 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
54 Avoided a harmless g_warning().
56 2007-07-12 Murray Cumming <murrayc@murrayc.com>
58 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
59 Pass the modest account name, not the TnyAccount display name to
60 modest_msg_view_window_new() so that the reply feature works,
61 fixing projects.maemo.org bug NB#62892.
63 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
64 (modest_msg_view_window_new_with_header_model):
65 * src/maemo/modest-msg-view-window.c:
66 (modest_msg_view_window_new_with_header_model),
67 (modest_msg_view_window_new):
68 * src/modest-ui-actions.c: (reply_forward):
69 * src/widgets/modest-msg-view-window.h:
70 * src/widgets/modest-window.c: (modest_window_set_active_account):
71 Rename an account parameter to modest_account_name to make this clearer.
73 2007-07-11 Murray Cumming <murrayc@murrayc.com>
75 * src/modest-ui-actions.h:
76 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
77 modest_do_message_delete().
78 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
79 Call modest_do_message_delete(), hoping that this would cause messages
80 to be really deleted from search instead of just marked with strike through.
81 Does not seem to help.
83 2007-07-11 Armin Burgmeier <armin@openismus.com>
85 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
86 priv->reselect to FALSE prior to calling
87 modest_folder_view_select_first_inbox_or_local() to prevent endless
88 recursion and thus a crash on startup.
90 2007-07-11 Armin Burgmeier <armin@openismus.com>
92 * src/maemo/modest-account-settings-dialog.h: Include
93 <gtk/gtknotebook.h> to fix the build (at least for me).
95 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
96 Use "New FolderN" as default suggested name if "New folder" already
97 exists, with N being the first free number, though never exceed "New
98 folder99" in which case we just fall back to "New Folder" even though
99 it already exists. This fixes projects.maemo.org bug NB#58663.
101 2007-07-11 Murray Cumming <murrayc@murrayc.com>
103 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
104 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
105 projects.maemo.org bug NB#62778.
107 2007-07-11 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
110 Ignore the wrong (for now) secure-smtp setting in the presets -
111 just default to requiring secure authentication for SMTP, because
114 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
116 * src/widgets/modest-folder-view.c: (filter_row)
117 Do not show drafts folder (see UI specs)
119 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
121 * src/modest-ui-actions.c:
122 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
123 place and also not necessary.
125 * src/widgets/modest-folder-view.c: (filter_row)
126 Guess folder type and hide Sent & Outbox if necessary.
127 Fixed project.maemo.org NB#57328
129 2007-07-11 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-ui-actions.h:
132 * src/modest-ui-actions.c:
133 (modest_ui_actions_on_delete_message):
134 Move some code into a new
135 modest_ui_actions_refresh_message_window_after_delete()
136 function so we can use it from elsewhere.
138 * src/dbus_api/modest-dbus-callbacks.c:
139 (on_idle_delete_message), (on_delete_message): Used an idle
140 handler, as we do for the other D-Bus method handlers.
141 Call modest_ui_actions_refresh_message_window_after_delete()
142 if the deleted message was open in a window. This fixed
143 projects.maemo.org bug NB#62862.
145 2007-07-11 Murray Cumming <murrayc@murrayc.com>
147 * src/modest-main.c: (main): Only show the UI at the start if
148 the showui command line option was given. For instance,
149 run-standalone src/modest showui
150 Otherwise, we wait for the top_application D-Bus method to
151 be sent by hildon-desktop when the application is selected
153 This allows us to run without a UI when osso-global-search
154 uses our D-Bus methods.
156 2007-07-11 Murray Cumming <murrayc@murrayc.com>
158 * src/dbus_api/modest-dbus-api.h: Added a define for a
159 top-application D-Bus method.
160 * src/dbus_api/modest-dbus-callbacks.c:
161 (on_top_application),
162 (modest_dbus_req_handler): Handle the top-application D-Bus
163 method, which might be an undocumented D-Bus signal sent by
164 hildon-desktop when it starts the application from the menu.
165 But I am not sure and I need to test it on the device, because
166 my scratchbox does not have the application in the menu now.
167 This method shows the main window, so that it can be invisible
168 when started, for instance, just for email searching from
171 * src/maemo/modest-main-window.c: (restore_settings),
172 (modest_main_window_new): Do not show the window immediately
173 upon creation. We show it later.
174 * src/modest-widget-memory.c: (save_settings_paned):
175 Try (unsuccessfully) to avoid saving the paned position when
176 it is not even visible.
177 (restore_settings_paned): Do not allow a silly paned position.
178 This seems necessary when not showing the window at first.
180 * tests/dbus_api/Makefile.am:
181 * tests/dbus_api/test_top_application.c: (main): Test for the
184 2007-07-10 Murray Cumming <murrayc@murrayc.com>
186 * src/modest-ui-dimming-rules.c:
187 (modest_ui_dimming_rules_on_new_msg),
188 (modest_ui_dimming_rules_on_reply_msg),
189 (modest_ui_dimming_rules_on_delete_msg),
190 (modest_ui_dimming_rules_on_details),
191 (modest_ui_dimming_rules_on_view_window_move_to),
192 (modest_ui_dimming_rules_on_view_previous),
193 (modest_ui_dimming_rules_on_view_next),
194 (_invalid_folder_for_purge): Added checks before
195 casting the window. This looks like an actual
196 logic error in _invalid_folder_for_purge(), because it
197 tries to use a ModestMainWindow as a message window.
199 2007-07-10 Murray Cumming <murrayc@murrayc.com>
201 * src/maemo/modest-account-settings-dialog.c:
202 (show_error): Use the same implementation as in
203 modest-easysetup-wizard.c:
204 (on_entry_invalid_character): The logical ID contains a %s.
205 Guessed what it should be.
206 (on_entry_max), (check_data), (on_response): Adapt to
207 changed show_error().
208 (create_page_account_details): Really call
209 modest_validating_entry_set_func() on the correct widgets.
210 * src/maemo/easysetup/modest-easysetup-wizard.c:
211 (on_entry_invalid_character): Fix the logical ID here too.
212 (create_page_account_details),
213 (create_page_user_details):
215 modest_validating_entry_set_func() on the correct widgets.
217 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
218 Do not try to use the account if it is NULL.
220 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
222 * src/modest-ui-actions.c: (create_move_to_dialog),
223 (modest_ui_actions_on_main_window_move_to),
224 (modest_ui_actions_on_msg_view_window_move_to):
225 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
226 (filter_row), (modest_folder_view_show_non_move_folders):
227 * src/widgets/modest-folder-view.h:
229 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
230 the Sent folder yet as it does not report the correct folder type.
232 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
234 * src/maemo/modest-msg-edit-window.c: (init_window):
237 2007-07-10 Murray Cumming <murrayc@murrayc.com>
239 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
240 Take a parent widget instead of a parent window, and
241 implement this with hildon_banner_show_information() instead.
242 Non-Maemo builds can just ifdef that there.
243 This fixed projects.maemo.org bug NB#62766.
245 (on_entry_invalid_character): Use show_error() again instead
246 of using hildon directly, and use the _CS() macro to use the correct
248 (create_account), (check_for_supported_auth_methods), (on_entry_max):
249 Pass a widget instead od a window to show_error().
251 2007-07-10 Murray Cumming <murrayc@murrayc.com>
253 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
254 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
255 This allows us to show the server name in the error message, fixing
256 projects.maemo.org bug NB#62904.
257 Also, use the appropriate logical ID message for the account protocol.
259 2007-07-10 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-tny-account-store.c: (on_idle_wrong_password):
262 A compilation fix, though the build wasn't broken for me.
264 2007-07-09 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
267 Do not try to unref a NULL folder store, to avoid a runtime warning.
268 This seems to happen sometimes when changing accounts settings.
270 2007-07-09 Murray Cumming <murrayc@murrayc.com>
272 * src/modest-tny-account-store.c:
273 (modest_tny_account_store_instance_init),
274 (modest_tny_account_store_finalize),
275 (on_account_settings_hide), (on_idle_wrong_password):
276 Use a GHashTable to ensure that we only show one account settings
277 dialog per modest account. This avoids us having a dialog open for
278 both the store and transport accounts, or due to repeated get_password()
279 calls that shouldn't happen anyway.
281 2007-07-09 Murray Cumming <murrayc@murrayc.com>
283 * src/maemo/modest-maemo-utils.c: (on_hide),
284 (modest_maemo_show_dialog_and_forget): Handle the response, because
285 the window is not even hidden by default.
287 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
288 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
289 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
290 which seems to prevent some modality problems.
292 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
293 Ignore user cancellation errors.
295 * src/modest-account-mgr-helpers.h:
296 * src/modest-account-mgr-helpers.c:
297 Added modest_server_account_get_password() and
298 modest_server_account_get_has_password() to avoid direct use of
301 * src/maemo/modest-account-settings-dialog.h:
302 * src/maemo/modest-account-settings-dialog.c:
303 (modest_account_settings_dialog_init): Store the notebook so we can
305 Added modest_account_settings_dialog_switch_to_user_info().
307 * src/modest-tny-account-store.c:
308 (get_password): When the password in the account settings is wrong (we think),
309 show the relevant page of the account settings dialog, in the mainloop.
310 However, we currently get many of these at once because cancel does not
312 (forget_password): Do not forget the password
313 from the account settings, because this causes side-effects when
314 tinymail seems to call it at strange time, maybe because of how we
315 are cancelling get_password().
316 (modest_tny_account_store_alert): Ignore user cancellations.
318 2007-07-09 Murray Cumming <murrayc@murrayc.com>
320 * src/maemo/modest-maemo-utils.h:
321 * src/maemo/modest-maemo-utils.c:
322 Added modest_maemo_show_information_note_and_forget() for use instead of
323 gtk_dialog_run() when the response is not needed, to avoid an extra
324 mainloop which could cause a hang.
326 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
327 Use the logical IDs for the error message, though they are not
328 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
329 because gtk_dialog_run() caused a hang here (the window did not close).
330 This fixes projects.maemo.org bug NB#62646.
332 2007-07-09 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-account-mgr-helpers.h:
335 * src/modest-account-mgr-helpers.c:
336 Added modest_account_mgr_get_store_protocol().
338 * src/maemo/modest-account-view-window.c:
339 (on_delete_button_clicked): Show different warning text depending on
340 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
341 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
344 2007-07-09 Murray Cumming <murrayc@murrayc.com>
346 * src/maemo/modest-msg-edit-window.c:
347 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
348 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
350 2007-07-07 Armin Burgmeier <armin@openismus.com>
352 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
353 ckdg_ib_maximum_characters_reached from correct package.
355 * src/modest-ui-actions.c: Show an error message when a folder could
356 not be created. Tinymail does not give us specific error codes about
357 what has gone wrong, so we assume that a folder with that name
358 already exists, though there might be other reasons.
360 2007-07-06 Murray Cumming <murrayc@murrayc.com>
362 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
363 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
364 give a more exact error message that can be partly translated.
366 2007-07-05 Murray Cumming <murrayc@murrayc.com>
368 * src/maemo/modest-address-book.c:
369 (select_email_addrs_for_contact): Specify a default window size for the
370 select-email-address dialog, so that it is probably big enough for the
371 title. This should fix projects.maemo.org bug NB#62277.
373 2007-07-05 Murray Cumming <murrayc@murrayc.com>
375 * src/maemo/easysetup/modest-easysetup-wizard.c:
376 (create_page_complete_easysetup): Use
377 gtk_widget_set_size() request to ensure that the text wraps
380 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
382 * src/maemo/easysetup/modest-easysetup-wizard.c:
383 (on_entry_invalid_character), (create_page_account_details),
384 (create_page_user_details):
385 Use new API of ModestValidatingEntry. But for some reason the banner is
386 not shown. I will have to investigate that further.
388 * src/widgets/modest-validating-entry.c: (on_insert_text),
389 (modest_validating_entry_set_func):
390 * src/widgets/modest-validating-entry.h:
391 Added a new callback function to be able to react to prevented
392 characters whitespaces to e.g show a banner.
394 2007-07-05 Armin Burgmeier <armin@openismus.com>
396 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
397 notification of HildonNumberEditor instead of remembering the port
398 number. Thanks to Johannes for pointing this out.
400 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
402 * src/maemo/easysetup/modest-easysetup-wizard.c:
403 Check if there are any user changes before showing a confirmation
404 dialog (projects.maemo.org NB#60946)
406 2007-07-05 Armin Burgmeier <armin@openismus.com>
408 * src/maemo/modest-account-settings-dialog.c: Remember custom port
409 number at the beginning of the dialog and set the modified flag at the
410 end if the port number has changed. This is necessary because
411 HildonNumberEditor does not support notification when the value has
414 2007-07-05 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-ui-actions.c:
417 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
418 a connection before asking anything else. Correct the check for the destination
419 folder so that it succeeds when online.
420 This fixed projects.maemo.org bug NB#61645.
422 2007-07-05 Murray Cumming <murrayc@murrayc.com>
424 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
425 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
426 to fix projects.maemo.org bug NB#62439.
428 2007-07-05 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-tny-account.c: (on_connection_status_changed):
431 Really do not use tny_device_force_offline() here. See the previous comment.
433 2007-07-04 Murray Cumming <murrayc@murrayc.com>
435 * src/modest-tny-account.c: (on_connection_status_changed):
436 Do not use tny_device_force_offline() when tinymail says that something
437 went wrong with the connection. It seems to report this unnecessarily.
439 2007-07-04 Murray Cumming <murrayc@murrayc.com>
441 * src/maemo/modest-connection-specific-smtp-window.c:
442 (modest_connection_specific_smtp_window_init):
443 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
444 does not seem to have any effect in osso 1.1 (though it works in
445 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
447 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
449 * src/maemo/modest-connection-specific-smtp-window.c:
450 Fix UI specification problems with projects.meamo.org NB#60479
452 2007-07-04 Murray Cumming <murrayc@murrayc.com>
454 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
455 clue when this has failed, because the error dialog is not always shown
456 (at least in earlier version).
458 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
459 GError message, because the generic error dialog is not helpful.
461 'This message is not currently available (can't let a new connection go online)'
462 when trying to open an IMAP message.
464 (_modest_ui_actions_open): Offer a connection when some messages would
465 have to be downloaded and we are offline.
467 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
469 * src/widgets/modest-folder-view.c:
470 Don't check for MERGE type anymore as we use the correct type
472 NOTE: For the last two changes you need to update your tinymail copy
473 because of API changes!
475 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
477 * src/modest-tny-local-folders-account.c:
478 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
479 (see projects.maemo.org NB#61580)
481 2007-07-04 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-tny-account.c: (on_connection_status_changed):
484 Commented out the call to modest_platform_connect_and_wait() because this
485 seems to always hang, and I would like to know if this is the only thing
486 that causes a hang when showing the connection dialog.
487 It is not very useful anyway.
489 2007-07-04 Murray Cumming <murrayc@murrayc.com>
491 * src/maemo/modest-msg-view-window.c:
492 (modest_msg_view_window_select_next_message):
494 * src/modest-platform.h:
495 * src/maemo/modest-platform.c:
496 Added modest_platform_connect_and_wait(), which calls
497 tny_maemo_conic_device_connect() always in the main thread, by calling it
498 in an idle handler and waiting for the idle handler to run. It should be
499 in the main thread because it uses GTK+ UI code. It just returns TRUE
500 if the device is already online.
502 There is some nasty code to ensure that subsequent calls to
503 modest_platform_connect_and_wait() just wait for the first one to finish,
504 by checking repeatedly in another idle handler. This is necessary,
505 because other threads (or even the main thread, via another idle handler)
506 can call modest_platform_connect_and_wait() while
507 modest_platform_connect_and_wait() is running.
509 (modest_platform_connect_and_wait_if_network_account),
510 (modest_platform_connect_and_wait_if_network_folderstore):
511 Convenience functions that calls modest_platform_connect_and_wait() if
512 the account or folder might want network access.
514 * src/modest-mail-operation.c:
515 (modest_mail_operation_update_account):
516 * src/modest-ui-actions.c: (download_uncached_messages),
517 (modest_ui_actions_on_rename_folder), (delete_folder),
518 (modest_ui_actions_on_main_window_move_to),
519 (modest_ui_actions_on_msg_view_window_move_to):
520 * src/widgets/modest-folder-view.c:
521 (drag_and_drop_from_folder_view):
522 Offer a connection if we are offline.
524 * src/modest-tny-account.c: (on_connection_status_changed):
525 Document this as only handling errors during network operations in progress,
526 and replace the idle code with a simple call to
527 modest_platform_connect_and_wait(), which does this instead.
529 2007-07-03 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-tny-account.c:
532 (modest_tny_account_get_special_folder): (util_on_idle),
533 Handle the GError so we can see when tny_folder_store_get_folders()
534 fails, as it currently does while something else is connecting.
536 Added util_run_in_main_thread_and_wait()
537 which uses an idlen handler and mainloop to ensure that the function
538 is called in the main thread.
539 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
540 to make sure that we call attempt the connection in the mainloop only,
541 which might solve some hangs.
543 2007-07-03 Murray Cumming <murrayc@murrayc.com>
545 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
546 be found by their display name. This is never useful.
547 * src/modest-tny-account-store.c: (on_account_removed): Find the account
548 by its ID, instead of trying to use its ID as its display name.
550 * src/modest-tny-account-store.h:
551 * src/modest-tny-account.c:
552 (modest_tny_account_get_special_folder): Add a g_warning() when
553 tny_folder_store_get_folders() returns an empty list for the maildir.
555 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
556 Add a g_warning() when this returns NULL, because that it not allowed
559 2007-07-02 Armin Burgmeier <armin@openismus.com>
561 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
562 note when trying to cancel the wizard. This fixes projects.maemo.org
565 2007-07-02 Murray Cumming <murrayc@murrayc.com>
567 * src/modest-tny-account.h:
568 * src/modest-tny-account.c:
569 (modest_tny_account_new_from_server_account),
570 (modest_tny_account_new_from_server_account_name),
571 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
572 because this must now be set before setting the proto. This is usd in
573 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
574 warning in camel_session_get_service() caused by
575 tny_camel_transport_account_prepare().
577 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
580 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
582 * src/maemo/modest-connection-specific-smtp-edit-window.c:
584 (modest_connection_specific_smtp_edit_window_init):
586 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
589 2007-06-29 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-tny-account.c:
592 (modest_tny_account_new_from_server_account):
593 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
594 now uses to request a connection when it needs one, and which it uses
595 to tell us that something is wrong with the connection, so we can force
596 the accounts offline to prevent further problems.
599 * src/modest-init.c: (init_default_settings):
600 * src/modest-mail-operation.c:
601 (modest_mail_operation_update_account):
602 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
603 This should not be necessary anymore. Do not set the conf key that
604 determined this (it was always TRUE and not set anywhere else).
606 * src/modest-ui-actions.h: Remove unused and unimplemented
607 modest_ui_actions_on_online_toggle_toggled().
609 2007-06-29 Murray Cumming <murrayc@murrayc.com
611 * src/maemo/modest-main-window.c: (connect_signals):
612 Don't connect to delete_event twice. Maybe this was harmless.
614 2007-06-29 Murray Cumming <murrayc@murrayc.com
616 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
617 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
618 Debug output to give some more clue when a folder move is not allowed.
620 2007-06-28 Murray Cumming <murrayc@murrayc.com
622 * src/modest-tny-account.c: (on_modest_file_system_info),
623 (modest_tny_account_get_mmc_account_name):
624 Always call the callback, without checking whether the name has changed.
625 * src/widgets/modest-folder-view.c: (strings_are_equal),
626 (on_model_foreach_set_name), (on_get_mmc_account_name),
627 (text_cell_data): Compare the name here, and use the name from
628 the account rather than from the
629 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
630 if the name was changed after the account was added to the model.
631 That's a tinymail bug but not one that I want to fix now.
633 This finally fixes projects.maemo.org bug NB#59301.
635 2007-06-27 Armin Burgmeier <armin@openismus.com>
637 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
640 2007-06-27 Murray Cumming <murrayc@murrayc.com
642 * src/modest-tny-account.h:
643 * src/modest-tny-account.c:
644 Added modest_tny_account_get_mmc_account_name(), to set the memory
645 card name asynchronously for the given account and then notify.
646 (modest_tny_account_new_for_local_folders): Use this new function instead
647 of using hildon_file_system_info_async_new() directly.
649 * src/widgets/modest-folder-view.c: (text_cell_data):
650 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
651 gtk_tree_model_row_changed() when it is available.
653 This should fix projects.maemo.org bug NB#59301.
655 2007-06-27 Murray Cumming <murrayc@murrayc.com
657 * src/modest-mail-operation.c: (update_account_thread),
658 (get_msgs_full_thread): Fix typo failures in the revert
661 2007-06-27 Murray Cumming <murrayc@murrayc.com
663 * src/maemo/modest-maemo-global-settings-dialog.c:
664 (idle_select_default_focus):
665 * src/modest-mail-operation.c: (idle_notify_progress),
666 (idle_notify_progress_once), (set_last_updated_idle),
667 (update_account_thread), (get_msgs_full_thread):
668 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
669 * src/widgets/modest-header-view.c:
670 (idle_notify_headers_count_changed_destroy),
671 (idle_notify_headers_count_changed):
672 Reverted the additions of gdk_threads_enter/leave(), in case this
673 helps with a startup hang on the device.
675 2007-06-26 Armin Burgmeier <armin@openismus.com>
677 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
678 for supported secure authentication methods from server by
679 gtk_dialog_run(), saving CPU time and a potential race condition.
681 2007-06-26 Armin Burgmeier <armin@openismus.com>
683 * src/maemo/modest-maemo-utils.h:
684 * src/maemo/modest-maemo-utils.c: Added a
685 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
686 only error code to tell the calling code when the user canceled the
689 * src/maemo/modest-account-settings-dialog.h:
690 * src/maemo/modest-account-settings-dialog.c:
691 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
692 message if the retrieval of secure authentication methods was canceled
693 by the user. Perform the check before saving anything to configuration
694 to not end up with half-committed configuration changes, do not show
695 a "Saving to configuration failed" note when authentication methods
696 could not be retrieved.
698 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
701 2007-06-26 Murray Cumming <murrayc@murrayc.com>
703 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
704 Only return the first level of folders under accounts, because the
705 osso-global-search UI spec doesn't want the rest.
706 This fixed projects.maemo.org bug NB#61811.
708 2007-06-26 Murray Cumming <murrayc@murrayc.com>
710 * src/modest-tny-account-store.c:
711 * src/modest-tny-account-store.h:
712 Added modest_tny_account_is_memory_card_account().
713 * src/maemo/modest-main-window.c: (create_details_widget):
714 Show the same information items for the memory card as we show for the
715 local-folders, to fix projects.maemo.org bug NB#59307.
717 2007-06-26 Murray Cumming <murrayc@murrayc.com>
719 * src/modest-tny-account-store.c: (get_password):
720 Added some checks for NULL to maybe prevent crashes, though I think
721 it was Philip's last commit that actually prevented the crash here
722 when creating a first new account.
723 But the new account is still not usable (no messages are shown)
724 until a restart of the application.
726 2007-06-26 Murray Cumming <murrayc@murrayc.com>
728 * src/maemo/modest-maemo-global-settings-dialog.c:
729 (idle_select_default_focus):
730 * src/modest-mail-operation.c: (idle_notify_progress),
731 (idle_notify_progress_once), (idle_notify_update_account_queue),
732 (set_last_updated_idle), (update_account_thread),
733 (notify_get_msgs_full), (get_msgs_full_destroyer),
734 (get_msgs_full_thread):
735 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
736 * src/widgets/modest-header-view.c:
737 (idle_notify_headers_count_changed_destroy),
738 (idle_notify_headers_count_changed):
739 Use gdk_threads_enter() and gdk_threads_enter_leave() in
740 all idle handlers, because some other thread could be blocking
741 the GDK lock, so that it can do GUI stuff.
743 2007-06-26 Murray Cumming <murrayc@murrayc.com>
745 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
746 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
747 (on_idle_send_receive), (on_idle_open_default_inbox):
748 * src/maemo/modest-msg-edit-window.c:
749 (modest_msg_edit_window_attach_file_noninteractive):
750 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
751 to prevent a hang. I don't quite understand why these are necessary,
752 beause we should already be in the main loop. I guess something outside
753 of the main loop is taking the lock.
755 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
756 we are really using URIs, and use files that are more likely to exist.
758 2007-06-26 Murray Cumming <murrayc@murrayc.com>
760 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
761 necessary because configure.ac now defines different variables.
763 2007-06-26 Murray Cumming <murrayc@murrayc.com>
765 * libmodest-dbus-client/libmodest-dbus-client.c:
766 * libmodest-dbus-client/libmodest-dbus-client.h:
767 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
768 libmodest_dbus_client_compose_mail() is what things actually use.
770 * src/dbus_api/modest-dbus-api.h:
771 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
772 * tests/dbus_api/Makefile.am:
773 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
776 2007-06-26 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-init.c: (modest_init_local_folders):
779 For memory-card (or other non local-folders) maildir accounts,
780 always create an Archive folder, so that there is somewhere to put
781 messages. This should be less confusing, because the user does not need
782 to guess that the need to create a folder.
784 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
786 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
787 Fixed icon size by using (50, 50) which is the same as defined by
790 2007-06-25 Armin Burgmeier <armin@openismus.com>
792 * src/widgets/modest-window-mgr.c:
794 * configure.ac: Correctly recognize hildon-notify presence and fixed
795 the build without it being installed.
797 2007-06-25 Murray Cumming <murrayc@murrayc.com>
799 * libmodest-dbus-client/libmodest-dbus-client.c:
800 (libmodest_dbus_client_search): Fix the build. Sorry.
801 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
802 (reply_forward_cb): Initialize variables to fix the build.
804 * src/modest-tny-account-store.c:
805 (modest_tny_account_store_get_tny_account_by): Fix the account URI
806 comparison (a silly typo) so that email search results can be opened
807 when there are more than one account.
809 2007-06-25 Murray Cumming <murrayc@murrayc.com>
811 * libmodest-dbus-client/libmodest-dbus-client.c:
812 (libmodest_dbus_client_search),
813 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
814 instead of 1 second, because the search gets folders and messages from
815 the server, which can take a long time. When it times out,
816 osso-global-search will report no results.
818 We need to specify whether we should search only cached information
819 (maybe with a user preference), and the osso-email-search-plugin
820 API should really be improved to allow that option, and to allow results
821 to be delivered asynchronously in batches.
823 2007-06-25 Murray Cumming <murrayc@murrayc.com>
825 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
826 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
827 GTK_ICON_SIZE_DIALOG is probably the wrong size.
829 2007-06-25 Murray Cumming <murrayc@murrayc.com>
831 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
832 that is an empty string. D-Bus seems to give us these instead of NULL.
834 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
836 * src/dbus_api/modest-dbus-callbacks.c:
837 * src/maemo/easysetup/modest-easysetup-wizard.h:
838 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
839 * src/maemo/modest-connection-specific-smtp-edit-window.c:
840 (modest_connection_specific_smtp_edit_window_init):
841 * src/maemo/modest-maemo-global-settings-dialog.c:
843 * src/maemo/modest-maemo-utils.c:
844 (modest_maemo_utils_setup_images_filechooser):
845 * src/maemo/modest-main-window.c: (create_details_widget):
846 * src/maemo/modest-msg-edit-window.c:
847 (modest_msg_edit_window_attach_file_noninteractive),
848 (modest_msg_edit_window_color_button_change),
849 (modest_msg_edit_window_set_zoom):
850 * src/modest-mail-operation.c: (update_account_thread):
851 * src/modest-tny-account-store.c:
852 * src/modest-tny-account.c:
853 * src/widgets/modest-global-settings-dialog.c:
854 * src/widgets/modest-window.h:
858 2007-06-25 Murray Cumming <murrayc@murrayc.com>
860 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
861 * src/modest-search.c: (modest_search_folder),
862 (modest_search_all_accounts): Actually search only in the specified folder,
863 doing a simple match on the folder ID.
864 * src/modest-search.h: Added a folder field to the ModestSearch struct,
865 and added some documentation.
867 2007-06-22 Armin Burgmeier <armin@openismus.com>
869 * src/maemo/modest-maemo-utils.h:
870 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
871 modest_maemo_utils_get_supported_secure_authentication_methods.
873 * src/maemo/easysetup/modest-easysetup-wizard.c:
874 * src/maemo/modest-account-settings-dialog.c: Show correct error if
875 one occured, not just "Server does not support secure authentication".
877 2007-06-22 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-tny-account-store.c: (get_password):
880 Restored the call to tny_account_set_user() because Philip seems to have
881 stopped this from crashing (by not using the freed string). It still does
882 not work, but now we can test it.
884 2007-06-22 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/modest-msg-edit-window.c: (init_window):
887 Comment out use of an uninitialzed GtkScrolledWindow variable,
888 to fix the build and stop a crash. Yet again.
890 2007-06-22 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-tny-account-store.c: (get_password):
893 Remove the call to tny_account_set_user() because this actually crashes.
894 As mentioned in the last commit, it is known to not work anyway.
896 2007-06-22 Murray Cumming <murrayc@murrayc.com>
898 * src/modest-tny-account-store.c: (get_password):
899 Use tny_account_set_username() to tell tinymail that the username might
900 have changed too. But tinymail ignores this: see projects.maemo.org
902 * src/modest-ui-actions.c:
903 (modest_ui_actions_on_password_requested): Remove the useless attempt to
904 reset the connection when changing the username, and improve the comments.
905 Save the changed username to gconf at least, so it is used when Modest is
908 2007-06-21 Murray Cumming <murrayc@murrayc.com>
910 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
911 Do not use a query, so that we get all folders, including for POP and
912 local-folders. They work as search criteria too.
913 This fixes projects.maemo.org bug NB#57740.
915 2007-06-21 Murray Cumming <murrayc@murrayc.com>
917 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
918 Comment out the use of hildon_notification_set_sound() because it is
919 not declared, to fix the build. Warnings are serious, people.
921 2007-06-21 Armin Burgmeier <armin@openismus.com>
923 * src/maemo/modest-maemo-utils.h:
924 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
925 modest_maemo_utils_get_supported_secure_authentication_methods()
926 to query authentication methods for a specific user. This should fix
927 projects.maemo.org bug NB#61369.
929 * src/maemo/easysetup/modest-easysetup-wizard.c:
930 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
933 2007-06-21 Murray Cumming <murrayc@murrayc.com>
935 * libmodest-dbus-client/libmodest-dbus-client.h:
936 * libmodest-dbus-client/libmodest-dbus-client.c:
937 (modest_dbus_message_iter_get_search_hit),
938 (libmodest_dbus_client_search):
939 Reorganised and commented this.
940 Removed modest_search_hit_free() from the public API because it
943 Added libmodest_dbus_client_get_folders() and
944 modest_folder_result_list_free().
946 * src/dbus_api/modest-dbus-api.h:
947 * src/dbus_api/modest-dbus-callbacks.c:
948 (modest_dbus_req_filter): Commented. Moved most code to
949 on_dbus_method_search() and added on_dbus_method_get_folders().
951 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
952 of the extra D-Bus handler.
954 * tests/dbus_api/Makefile.am:
955 * tests/dbus_api/test_get_folders.c: New test for
956 libmodest_dbus_client_get_folders(). This seems to return an empty list
957 at the moment. That could be the same error that causes the message list
958 to be empty sometimes.
959 This should help with projects.maemo.org bug NB#57740.
961 2007-06-21 Armin Burgmeier <armin@openismus.com>
963 * src/modest-mail-operation.c: Do not call
964 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
965 notify the operation's end after having set the status to CANCELED for
966 the operation queue to listen on. This fixes a deadlock when there
967 were mail operations in the queue during its finalization.
969 * src/modest-singletons.c: Reordered uninitialization of the account
970 manager to happen after the mail operation queue was uninitialized
971 because the mail operation's in the queue might still try to access
972 the account manager (see modest_mail_operation_notify_end()). This
973 fixes a potential crash when terminating the application.
975 2007-06-21 Murray Cumming <murrayc@murrayc.com>
977 * src/modest-search.c:
978 (search_mime_part_and_child_parts): Moved some code here so we
979 can search recursively in child folders.
980 (modest_search_folder): Search in the message as a mime part, instead
981 of just its child mime parts.
982 (read_chunk), (search_mime_part_ogs):
983 Check how many bytes were read, to prevent an endless loop.
984 Searching in message bodies now works. This finishes the fix for
985 projects.maemo.org bug NB#61007.
987 2007-06-20 Murray Cumming <murrayc@murrayc.com>
989 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
990 Add a g_warning when the item is not a folder.
992 * src/modest-ui-dimming-rules.c:
993 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
994 when selected item is not a folder (for instance, an account), because
995 the UI spec only talks about folders.
996 I am not sure what the UI spec wants, so this might not totally fix
997 projects.maemo.org bug NB#60794.
999 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1001 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1002 (load_from_file): Sort the list. The unsorted list would be more noticeable
1003 in non-English locales.
1005 * src/maemo/modest-msg-edit-window.c:
1006 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1007 warning and fix the build.
1009 * src/maemo/modest-progress-bar-widget.c:
1010 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1011 avoid a g_warning, and probably to avoid a crash.
1013 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1015 * src/modest-search.c: (modest_search_folder): Check for a GError
1016 when calling tny_folder_get_headers(), to show that this is not the cause
1019 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1021 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1022 Actually set the body query instead of the subject query.
1024 * src/modest-search.c: (search_mime_part_ogs),
1025 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1026 which would probably cause it to fail if we got this far.
1028 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1029 to simplify the code.
1030 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1031 be causing search-in-body to fail.
1033 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1035 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1037 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1038 Better debug message when the folder cannot be found.
1039 This should help with fixing projects.maemo.org bug #61287.
1040 * src/modest-search.c: (add_hit): Do not leak the furl string.
1042 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-ui-actions.c:
1045 (modest_ui_actions_on_folder_selection_changed):
1046 Do not special-case TNY_MERGE_FOLDER here, because
1047 modest_tny_folder_get_account() already does that. This fixes
1048 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1049 shown when the Outbox was selected).
1051 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1053 * libmodest-dbus-client/libmodest-dbus-client.c:
1054 (_dbus_iter_get_string_or_null): Initialize the string variable in
1055 case this helps with Dirk's crash.
1057 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1059 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1060 though it is not implemented yet (this function is maybe not even used),
1061 to avoid breaking ABI in future.
1062 * libmodest-dbus-client/libmodest-dbus-client.c:
1063 (get_attachments_string): Moved some code into this generic function.
1064 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1065 sends email. It is maybe not used.
1066 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1067 (on_send_mail): Use attachments.
1069 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1070 * src/maemo/modest-msg-edit-window.c:
1071 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1072 a filename before using it, to fix projects.maemo.org bug NB#58233.
1074 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1076 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1077 Initialize the continue_download variable to fix the build, and probably
1078 to fix randome behaviour.
1080 2007-06-18 Armin Burgmeier <armin@openismus.com>
1082 * src/modest-tny-send-queue.h:
1083 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1084 the queue so we can later show it in the UI. Replaced
1085 modest_tny_send_queue_msg_is_being_sent() by
1086 modest_tny_send_queue_get_msg_status().
1088 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1090 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1091 gpointer. This probably was not harmful, but just to be sure.
1093 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1096 Fix the build, but leave the function broken on Bora, because
1097 hildon_uri_action_get_service() does not exist.
1098 osso_uri_action_get_service() does not exist either, it seems.
1100 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1102 * src/modest-tny-account.c:
1103 (modest_tny_account_new_from_server_account):
1104 Uncommented the url debug output again, because it is useful for
1105 debugging, as I said in the comment.
1107 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1109 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1111 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1112 for Mameo Bora, to fix the build.
1114 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1117 Fixed build with hildon < 0.99
1119 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1120 Check if the selected account is busy instead of checking all accounts
1122 * src/modest-account-mgr-priv.h:
1123 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1124 (modest_account_mgr_init), (compare_account_name),
1125 (modest_account_mgr_set_account_busy),
1126 (modest_account_mgr_account_is_busy):
1127 * src/modest-account-mgr.h:
1128 Added busy information to the account manager. It possible to
1129 set an account to busy or not busy now.
1131 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1132 (modest_mail_operation_update_account),
1133 (modest_mail_operation_notify_end):
1134 Set the account to busy/not busy depending on the operation state.
1136 * src/widgets/modest-account-view.c:
1137 (modest_account_view_finalize), (get_last_updated_string),
1138 (update_account_view), (on_account_busy_changed), (init_view):
1139 Show string "Refreshing..." if the account is currently busy.
1141 All this fixes projects.maemo.org bug NB#59711
1143 2007-06-14 Armin Burgmeier <armin@openismus.com>
1145 * src/widgets/modest-attachments-view.h:
1146 * src/widgets/modest-attachments-view.c: Added
1147 modest_attachments_view_has_attachments() and fixed coordinate
1148 transformation in get_att_view_at_coords(). This fixes attachment
1151 * src/widgets/modest-msg-view.c: Make use of
1152 modest_attachments_view_has_attachments() to decide whether to show
1153 attachments in the header.
1155 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1157 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1158 (on_change), (on_combo_security_changed),
1159 (modest_connection_specific_smtp_edit_window_init),
1160 (modest_connection_specific_smtp_edit_window_set_connection),
1161 (modest_connection_specific_smtp_edit_window_is_dirty):
1162 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1163 * src/maemo/modest-connection-specific-smtp-window.c:
1166 Show an comfirmation dialog for the smpt-edit-window if there are
1167 unsaved changes and the user hits cancel.
1168 (projects.maemo.org bug NB#60479)
1170 2007-06-14 Armin Burgmeier <armin@openismus.com>
1172 * src/maemo/easysetup/modest-easysetup-wizard.c:
1173 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1174 address" info in banner instead of node, and select all the text as
1175 per UI spec. This fixes projects.maemo.org bug NB#60550.
1177 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1179 reviewed by: <delete if not using a buddy>
1181 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1182 * src/modest-ui-actions.c: (folder_refreshed_cb):
1184 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1186 * src/widgets/modest-folder-view.c: (filter_row):
1187 Explictly filter out the per-account outbox accounts. I don't know why
1188 these only sometimes show up, but now they should never show up in the UI.
1189 This should fix projects.maemo.org bug NB#60160.
1191 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1194 when the toolbar does not exist yet.
1195 * src/modest-widget-memory.c: (save_settings_header_view):
1196 Added g_warnings() to help us to discover when we are trying to set
1197 an empty columns list in gconf.
1199 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-init.h:
1202 * src/modest-init.c:
1203 Added modest_init_get_default_header_view_column_ids().
1205 * src/modest-widget-memory.c: (restore_settings_header_view):
1206 Use the new function to get defaults, if the gconf key is empty,
1207 instead of not creating any columns. This seems to fix the
1208 empty right-hand pane problems.
1210 * src/widgets/modest-header-view.h: Improved documentation.
1212 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1214 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1215 Revert the use of the display name as the account name, because this
1216 is generally wrong and would break the code that follows.
1218 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1220 * src/maemo/easysetup/modest-easysetup-wizard.c:
1221 (check_for_supported_auth_methods), (on_before_next),
1224 More correct fix for projects.maemo.org bug NB# 58991
1225 Do not longer accept AUTH_PASSWORD as secure method and choose
1226 correct method when creating the account.
1228 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1230 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1231 Fixed projects.maemo.org bug NB# 58991
1233 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-init.c: (modest_init_init_core),
1236 (modest_init_local_folders): Fixed compilation errors.
1238 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1240 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1241 Remove unnecessary lib/include, though it is good in principle when needed.
1243 * src/modest-init.c: (modest_init_one_local_folder),
1244 (modest_init_local_folders):
1245 * src/modest-init.h: Initialize the .modest library for memory cards,
1246 instead of just doing nothing for them. This should allow us to create
1247 folders there, fixing projects.maemo.org bug NB#59297.
1249 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1251 * libmodest-dbus-client/libmodest-dbus-client.c:
1252 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1253 (libmodest_dbus_client_compose_mail),
1254 (libmodest_dbus_client_open_message),
1255 (libmodest_dbus_client_send_and_receive),
1256 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1258 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1259 (on_idle_open_message), (modest_dbus_req_handler),
1260 (search_result_to_message), (modest_dbus_req_filter):
1261 * src/modest-search.c: (add_hit), (modest_search_folder),
1262 (modest_search_all_accounts): Improved debug messages.
1264 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1266 * src/modest-tny-account-store.c:
1267 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1270 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1273 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1275 * src/modest-tny-account-store.c: (get_server_accounts):
1276 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1277 even when there are no accounts, so that the Outbox folder is always
1278 visible. This fixes projects.maemo.org bug NB#60158.
1280 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1282 * src/maemo/modest-main-window.c: (create_details_widget):
1283 Use the mcen_va_never logical ID.
1285 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1287 * src/dbus_api/modest-dbus-api.h:
1288 * src/dbus_api/modest-dbus-callbacks.c:
1289 (on_idle_open_default_inbox), (on_open_default_inbox),
1290 (modest_dbus_req_handler):
1291 Added a new OpenDefaultInbox method.
1293 * libmodest-dbus-client/libmodest-dbus-client.h:
1294 * libmodest-dbus-client/libmodest-dbus-client.c:
1295 Added libmodest_dbus_client_open_default_inbox() to call the new
1296 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1297 though it should maybe be used by a new osso-email-interface function.
1299 * tests/dbus_api/Makefile.am:
1300 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1303 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1306 NULL, so that the signals get all the keys. This should not actually
1307 change any behaviour because we currently update everything when anything
1310 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1312 * src/widgets/modest-folder-view.c: (text_cell_data),
1313 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1314 (find_inbox_iter): If tinymail tells us that the folder is
1315 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1316 This causes the inbox to be selected at startup, fixing part of
1317 projects.maemo.org bug NB#56305.
1319 * src/modest-ui-dimming-rules.c:
1320 (modest_ui_dimming_rules_on_tools_smtp_servers):
1321 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1322 the SMTP servers menu item.
1323 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1324 that the SMTP Servers menu item is dimmed when there are no accounts,
1325 as a future version of the UI spec will require. This fixes
1326 projects.maemo.org bug NB#56305.
1328 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1330 * src/maemo/modest-maemo-utils.c:
1331 (modest_maemo_utils_get_supported_secure_authentication_methods):
1332 Added label to dialog instead of unreadable title
1334 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1335 (modest_main_window_new):
1336 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1339 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1340 * src/modest-account-mgr.h:
1341 Added method to avoid code duplication
1343 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1344 (modest_ui_actions_on_send_receive):
1345 Use modest_account_mgr_has_accounts
1347 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/easysetup/modest-presets.c:
1350 (modest_presets_get_info_server_security): Do not report secure auth
1352 * src/modest-protocol-info.c: Use the defines for the gconf key names
1353 for secure authentication. This was not working because we were writing
1354 Password and reading password, and the check was case sensitive.
1355 With this, gmail now works for receiving and sending when created via
1358 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1360 * src/maemo/easysetup/modest-presets.c:
1361 (modest_presets_get_info_server_security): Correct the key name for
1362 SecureSmtp, because it seems to be case-sensitive.
1363 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1364 Do not try to get the 0th notebook page if there are 0 pages, to
1365 avoid a g_warning().
1367 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1369 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1370 Prevent use of the new notification feature for now, because it currently
1371 shows one dialog for each new email, which is annoying.
1373 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1375 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1376 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1377 when no country was selected, so that we show the global ones.
1378 * src/maemo/easysetup/modest-presets.c:
1379 (modest_presets_get_providers): Return only the global providers, not
1380 all providers when mmc=0 was requested.
1382 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1384 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1385 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1386 provider ID in the combo.
1388 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1389 Do not show the page numbers, because it would be confusing when we add
1390 the 2 extra pages for the custom setup, when the user chooses the "Other"
1391 provider. This fixes projects.maemo.org bug NB#59028
1393 * src/modest-init.c: (modest_init_init_core),
1394 (modest_init_local_folders):
1395 * src/modest-init.h:
1396 * src/modest-tny-account.c:
1397 (modest_tny_account_new_for_local_folders): Do not create default folders
1398 for the memory card. This should fix projects.maemo.org bug NB#59328.
1400 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1402 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1403 Free the changed_conf_keys string items. They are already freed in the
1404 idle handler if that runs first.
1406 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1408 * src/modest-ui-actions.c:
1409 (modest_ui_actions_on_password_requested): Check that the server name
1410 is not NULL, because I just saw a password dialog with (null) as the
1413 * src/modest-tny-folder.[h|c]: Added
1414 modest_tny_folder_is_memory_card_folder().
1415 * src/modest-ui-dimming-rules.c:
1416 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1417 menu item for memory cards, as per the UI spec (section 7.4). This should
1418 fix projects.maemo.org bug NB#59297.
1420 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1422 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1423 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1424 is another problem with the code, see Murray's comment at line 772)
1426 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1428 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1429 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1430 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1431 (load_from_file), (easysetup_country_combo_box_init),
1432 (easysetup_country_combo_box_get_active_country_ids),
1433 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1434 instead of just one ID, to avoid duplicate country names in the UI.
1436 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1437 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1438 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1439 a single ID, avoiding duplicate providers.
1440 * src/maemo/easysetup/modest-easysetup-wizard.c:
1441 (on_combo_account_country): Adapt to use a list.
1443 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1445 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1446 keys changed in the last X seconds.
1448 * src/modest-account-mgr.h:
1449 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1450 (on_key_change), (modest_account_mgr_class_init),
1451 (modest_account_mgr_init), (modest_account_mgr_finalize):
1452 As the keys are changed, save them in a GSList* and signal that GSList*
1453 further every X seconds, to batch changes, to allow us to do just one
1454 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1455 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1457 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1458 changed signal signature.
1460 * src/modest-conf.c: (modest_conf_set_list),
1461 (modest_conf_on_change): Reenable notification.
1463 (modest_conf_maemo_fake_on_change): Comment out the hack that
1464 notified immediately instead of asynchronously.
1466 * src/widgets/modest-account-view.h:
1467 * src/widgets/modest-account-view.c:
1468 (update_account_view): Select the previously-selected account ID,
1469 if possible. This fixes projects.maemo.org bug NB#56933.
1471 (on_account_changed), (on_account_removed),
1472 (modest_account_view_select_account):
1474 Remove the block/unblock functions
1475 because they were not useful.
1477 * src/maemo/modest-account-view-window.c:
1478 (on_delete_button_clicked), (on_edit_button_clicked),
1479 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1481 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1483 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1484 Improve the error dialog to show Incorrect Account Settings, which seems
1485 clearer, and say that the internal error message (to be removed from the
1486 dialog later) is often misleading.
1487 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1489 * src/modest-tny-account.c:
1490 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1491 URL because this is so useful for debugging on the device.
1493 * src/widgets/modest-serversecurity-combo-box.c:
1494 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1496 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1498 * src/modest-mail-operation.c:
1499 (modest_mail_operation_send_new_mail):
1500 Added a comment about a nasty but apparently harmless message. Details
1501 added to the wiki g_warnings() page.
1503 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1505 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1506 (modest_tny_send_queue_class_init):
1507 Do not use the priv struct because it is empty, to avoid g_warnings
1508 about a non-existant priv struct.
1510 * src/modest-tny-account-store.c:
1511 (modest_tny_account_store_get_server_account),
1512 (modest_tny_account_store_get_transport_account_for_open_connection
1513 ): Do not try to get transport server accounts for local folders,
1514 because they don't have any. This avoids a g_warning().
1516 * src/maemo/modest-main-window.c:
1517 (modest_main_window_notify_send_receive_initied),
1518 (on_configuration_key_changed):
1519 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1520 * src/modest-defs.h:
1521 * src/modest-mail-operation.c:
1522 (modest_mail_operation_update_account):
1523 * src/modest-tny-account-store.h:
1524 * src/modest-tny-account.c:
1525 (modest_tny_account_get_special_folder),
1526 (modest_tny_account_new_for_local_folders),
1527 (modest_tny_account_new_for_per_account_local_outbox_folder):
1528 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1529 * src/modest-tny-local-folders-account.c:
1530 (add_account_folders_to_merged_folder):
1531 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1532 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1533 (modest_ui_actions_on_send):
1534 * src/widgets/modest-folder-view.c: (update_model):
1535 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1536 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1537 modest_tny_account_store_get_tny_account_by_account() to
1538 modest_tny_account_store_get_server_account() to make the code clearer.
1540 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1542 * src/dbus_api/modest-dbus-api.h:
1543 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1544 * src/maemo/modest-msg-edit-window.c:
1545 (modest_msg_edit_window_attach_file_noninteractive):
1546 added g_warning in case the file to be attached does not exist
1547 * tests/dbus_api/test_compose_mail.c: (main):
1548 removed obsolete comment, added generic files as test case
1550 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1552 * src/modest-tny-account-store.c: (get_server_accounts):
1553 Create the local folders account only once, not once for each outbox, and
1554 not only when there are some outboxes.
1556 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1558 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1559 code that is causing a crash at startup. Sergio says that he is fixing this.
1561 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1563 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1564 * src/maemo/modest-account-settings-dialog.c:
1565 (create_page_outgoing),
1566 (modest_account_settings_dialog_set_account_name),
1567 (save_configuration):
1568 - Fixed handling of the "Use secure authentication" toggle to comply with
1569 the ui specification. See also projects.maemo.org bug NB#58400
1571 - Restore the Secure connection setting combo correctly when loading
1574 * src/maemo/modest-maemo-utils.c:
1575 (on_camel_account_get_supported_secure_authentication),
1576 (modest_maemo_utils_get_supported_secure_authentication_methods):
1577 Fixed a crasher if operation is canceled
1579 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1580 (modest_protocol_info_auth_is_secure):
1581 * src/modest-protocol-info.h:
1583 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1584 the sense of the "Use secure authentication" toggle.
1586 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-tny-account-store.h:
1589 * src/modest-tny-account-store.c:
1590 Added modest_tny_account_store_get_local_folders_account().
1592 * src/modest-tny-folder.h:
1593 * src/modest-tny-folder.c:
1594 (modest_tny_folder_get_account):
1595 Added this replacement for tny_folder_get_account() which returns
1596 the local-folders account for TnyMergeFolders, to avoid the
1597 warning about the unimplemented get_account_func() vfunc().
1599 (modest_tny_folder_get_rules),
1600 * src/modest-ui-actions.c:
1601 (modest_ui_actions_on_folder_selection_changed):
1602 * src/modest-mail-operation.c:
1603 (modest_mail_operation_remove_folder),
1604 (modest_mail_operation_xfer_folder),
1605 (modest_mail_operation_rename_folder),
1606 (modest_mail_operation_get_msg),
1607 (modest_mail_operation_get_msgs_full),
1608 (modest_mail_operation_remove_msg),
1609 (modest_mail_operation_xfer_msgs),
1610 (modest_mail_operation_refresh_folder):
1611 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1613 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1615 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1616 (modest_server_account_set_security):
1617 * src/modest-defs.h: Add comments explaining that our
1618 UI spec means TLS when it says Normal, so these do not look like errors.
1620 * src/modest-tny-account.c:
1621 (modest_tny_account_new_from_server_account): Use the new tinymail
1622 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1623 for TLS. This should fix projects.maemo.org bug NB#58460.
1625 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1627 * src/maemo/easysetup/modest-easysetup-wizard.c:
1628 (create_account): Correct the position of the gconf sanity check warning.
1629 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1630 of using the g_idle_add() hack, because this does not seem to be necessary
1631 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1632 caused by something other than maemo's gconf.
1633 This fixes projects.maemo.org bug #59022.
1635 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1637 * src/modest-account-mgr-helpers.c:
1638 (modest_account_mgr_get_default_account): Do not check that the account
1639 exists if there is no default account (NULL), to fix a runtime warning.
1641 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1643 * src/widgets/modest-folder-view.c: (update_model):
1644 Do not unref the treemodel before we have finished with it.
1645 This prevents a valgrind warning and an occasional crash at startup.
1647 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1649 * libmodest-dbus-client/libmodest-dbus-client.h:
1650 added libmodest_dbus_client_compose_mail()
1651 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1653 added functions needed for SendAsMail() functionality
1654 * src/maemo/modest-msg-edit-window.c:
1655 (modest_msg_edit_window_attach_file_noninteractive):
1656 non interactively attaching files to message edit window
1657 * src/widgets/modest-msg-edit-window.h:
1658 * tests/dbus_api/Makefile.am:
1659 added test_compose_mail.c
1660 * tests/dbus_api/test_compose_mail.c: (main):
1662 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1664 * src/modest-account-view.c:
1665 Fixed bug projects.maemo.org bug NB#59307
1667 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1669 * src/maemo/easysetup/modest-easysetup-wizard.c:
1670 (get_serverport_incoming), (on_before_next), (create_account):
1671 * src/maemo/modest-account-settings-dialog.c:
1672 (modest_account_settings_dialog_set_account_name):
1673 * src/maemo/modest-maemo-utils.c:
1674 (on_camel_account_get_supported_secure_authentication_status),
1675 (on_camel_account_get_supported_secure_authentication),
1676 (on_secure_auth_cancel),
1677 (modest_maemo_utils_get_supported_secure_authentication_methods):
1679 Implemented security authentication for settings and easysetup.
1681 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1683 * src/maemo/modest-main-window.c: (create_details_widget):
1684 Show the total size for memory card accounts too, instead of showing
1685 the name again. Fixes bug projects.maemo.org bug NB#59307.
1687 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1690 * src/modest-tny-simple-folder-store.c:
1691 * src/modest-tny-simple-folder-store.h: Removed.
1693 * src/modest-tny-local-folders-account.h
1694 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1695 for the local-folders maildir, with an extra TnyMergedFolder containing
1696 the folders of the per-account outbox store accounts.
1697 * src/modest-tny-account-store.c: (get_server_accounts):
1698 Add the outboxes to the special local folders account after creating it.
1700 * src/modest-tny-account.c:
1701 (modest_tny_account_new_for_local_folders): Create the derived
1702 account when creating the main local-folders account.
1704 * src/maemo/modest-main-window.c: (create_details_widget),
1705 (modest_main_window_set_contents_style):
1706 Adapted to the use of the derived account instead of the folder store.
1708 * src/modest-ui-actions.c:
1709 (modest_ui_actions_on_folder_selection_changed):
1710 * src/modest-ui-dimming-rules.c:
1711 (modest_ui_dimming_rules_on_new_folder):
1712 * src/widgets/modest-folder-view.c: (text_cell_data),
1713 (icon_cell_data), (filter_row), (update_model),
1714 (get_cmp_rows_type_pos):
1717 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1718 Do not get the priv struct, because no priv struct has been set,
1719 to avoid a runtime warning.
1721 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1722 #ifelse with #else, to fix a warning, to fix the build.
1725 2007-06-05 Christian Kellner <ckellner@openismus.com>
1727 * libmodest-dbus-client/libmodest-dbus-client.c:
1728 Fix small typo in doc (why do you always see them
1729 AFTER committing stuff?)
1732 2007-06-05 Christian Kellner <ckellner@openismus.com>
1734 * libmodest-dbus-client/libmodest-dbus-client.c:
1735 (libmodest_dbus_client_search):
1736 Initialize hit list with NULL. Also set folder list
1737 to "" if NULL was supplied.
1740 2007-06-03 Christian Kellner <ckellner@openismus.com>
1742 * libmodest-dbus-client/libmodest-dbus-client.c:
1743 (modest_search_hit_list_free):
1744 Make it save to call it with NULL.
1746 * src/dbus_api/modest-dbus-callbacks.c:
1747 * src/modest-search.c:
1748 Return full ModestSearchHits as the search result list not TnyHeader
1749 since can't be around withouth the correspoding TnyFolder.
1751 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1753 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1754 Added currently commented code to check for secure auth
1756 * src/maemo/modest-account-settings-dialog.c: (on_response),
1757 (save_configuration), (show_ok):
1758 Fixed projects.maemo.org bugs NB #59248 and #59251
1760 * src/maemo/modest-maemo-utils.c:
1761 (on_camel_account_get_supported_secure_authentication_status),
1762 (on_camel_account_get_supported_secure_authentication),
1763 (modest_maemo_utils_get_supported_secure_authentication_methods):
1764 * src/maemo/modest-maemo-utils.h:
1765 Moved get_supported_secure_authentication() method here to be able
1766 to use it from easysetup wizard.
1768 * src/modest-pair.c: (on_pair_compare_as_string):
1769 Should compare string with first part of pair and not
1770 strcmp pairs which will crash.
1772 * src/modest-protocol-info.c:
1773 (modest_protocol_info_protocol_is_store):
1774 * src/modest-protocol-info.h:
1775 Added modest_protocol_info_get_auth_protocol_name()
1777 2007-06-03 Armin Burgmeier <armin@openismus.com>
1779 * src/modest-mail-operation.c:
1780 (modest_mail_operation_get_msgs_full): Set priv->account also when
1781 only retrieving a single message. This avoids a crash when canceling
1784 (modest_mail_operation_notify_end): Do not explicitely remove the
1785 operation from the queue but only emit the progress_changed signal.
1786 The queue itself listens to that signal to remove the operation when
1787 it is finished. This reduces coupling and removes a potential deadlock
1788 when modest_mail_operation_notify_end() is called from the queue
1789 itself. If that is a problem performance-wise, I would suggest to
1790 implement a status-changed signal or something.
1792 * src/modest-mail-operation-queue.c: Make sure to never call a
1793 function from another file while the queue is locked. This (hopefully)
1794 fixes another deadlock when exiting the application while retrieving
1797 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1799 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1800 Fixed build if libogs is not available
1802 2007-06-03 Christian Kellner <ckellner@openismus.com>
1804 * libmodest-dbus-client/libmodest-dbus-client.h:
1805 * libmodest-dbus-client/libmodest-dbus-client.c:
1806 (libmodest_dbus_client_delete_message):
1807 Implement deletion of messages (Client side).
1809 (modest_search_hit_free),
1810 (modest_search_hit_list_free):
1811 Utility functions to free the result hits.
1813 * src/dbus_api/modest-dbus-api.h:
1814 * src/dbus_api/modest-dbus-callbacks.c:
1815 (on_delete_message),
1816 (modest_dbus_req_handler):
1817 Implement deletion of messages (Server side).
1819 * tests/dbus_api/test_search.c: (main):
1822 * tests/dbus_api/Makefile.am:
1823 * tests/dbus_api/test_delete_message:
1824 Add little test for the message deletion logic
1826 2007-06-03 Armin Burgmeier <armin@openismus.com>
1828 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1829 when the operation queue was not empty. projects.maemo.org bug
1832 2007-06-03 Armin Burgmeier <armin@openismus.com>
1834 * src/widgets/modest-account-view.c
1835 (on_account_default_toggled): Toggle default account column
1836 explicitely instead of waiting for gconf notification (which is
1837 currently ignored). This should fix projects.maemo.org bug NB#56910
1838 for now. It should probably be removed when gconf notifications are
1841 2007-06-03 Christian Kellner <ckellner@openismus.com>
1843 * libmodest-dbus-client/libmodest-dbus-client.c:
1844 Removed debugging spew.
1846 * src/dbus_api/modest-dbus-callbacks.c:
1847 Added debugging info.
1849 * src/modest-search.c:
1850 (modest_search_all_accounts):
1851 Use tny_account_store_get_accounts () on the account store
1852 to get all accounts which is the way to get all accounts.
1854 * tests/dbus_api/test_search.c: (main):
1855 Make it possible to supply the search term on the command line.
1857 2007-06-03 Christian Kellner <ckellner@openismus.com>
1859 * libmodest-dbus-client/libmodest-dbus-client.c:
1860 * libmodest-dbus-client/libmodest-dbus-client.h:
1861 Implement searching for mesages over raw dbus. (Client side)
1863 * src/dbus_api/Makefile.am:
1864 * src/dbus_api/modest-dbus-api.h:
1865 * src/dbus_api/modest-dbus-callbacks.c:
1866 * src/dbus_api/modest-dbus-callbacks.h:
1867 Search framework (Server side). Also implement on_idle_open_message().
1869 * src/maemo/modest-platform.c: (modest_platform_init):
1870 Prepare for raw dbus/osso rpc interaction.
1872 * src/modest-search.h:
1873 Changed minsize from unspecific guint to guint32.
1875 * src/modest-search.c:
1877 Added strange hack which magically made tnymail work.
1879 (modest_search_folder),
1880 (modest_search_account),
1881 (modest_search_all_accounts):
1882 Implement helper functions to search all accounts, specific account
1885 * tests/dbus_api/Makefile.am:
1886 * tests/dbus_api/test_open_message.c:
1887 Read url to open from commandline.
1889 * tests/dbus_api/test_search.c:
1890 Implement small test for dbus search stuff
1892 2007-06-02 Armin Burgmeier <armin@openismus.com>
1894 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1895 include account type and account title. This fixes projects.maemo.org
1898 * src/maemo/modest-account-view-window.c: Set a title for the window.
1900 2007-06-02 Armin Burgmeier <armin@openismus.com>
1902 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1903 incoming and outgoing server name based on email address and server
1904 types as long as the names have not been edited manually. This fixes
1905 projects.maemo.org bug NB#58671.
1907 2007-06-02 Armin Burgmeier <armin@openismus.com>
1909 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1910 server type cannot be changed in future to the incoming details page
1911 when creating an account. This fixes projects.maemo.org bug NB#59029.
1913 2007-06-02 Armin Burgmeier <armin@openismus.com>
1915 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1916 and assigned max width chars so that they wrap instead of being
1917 truncated. Fixes projects.maemo.org bug NB#56126.
1919 2007-06-02 Armin Burgmeier <armin@openismus.com>
1921 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1922 introductory note to the connection specific smtp servers dialog, as
1923 section 8.12 of the email UI specification requires. This fixes
1924 projects.maemo.org bug NB#59212.
1926 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1928 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1929 Check for running mail operations, and offer to cancel them, as per the UI
1930 spec. This fixes projects.maemo.org bug NB#59041 .
1931 However, I suspect that tinymail may still use the network connection
1932 in ways that we cannot detect or cancel. But it should at least adapt to
1933 changes fairly well.
1935 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1937 * src/modest-tny-account-store.c: (recreate_all_accounts),
1938 (get_cached_accounts), (get_server_accounts): Do more sensible
1939 ref-counting of the temporarily-cached outbox accounts list. This seems
1940 to fix a crash when entering the password when the password was wrong.
1942 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1944 * src/gnome/modest-main-window.c: (connect_signals):
1945 * src/modest-tny-account-store.c: (get_password),
1946 (modest_tny_account_store_alert): Added comments and clues and
1947 commented-out code about how we currently fail to deal with connection
1948 errors and wrong passwords, and how we should.
1950 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1952 * src/widgets/modest-retrieve-combo-box.c:
1953 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1954 This fixes projects.maemo.org bug NB#58472 .
1956 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1958 * src/maemo/easysetup/modest-easysetup-wizard.c:
1959 (create_page_complete_easysetup):
1960 (create_page_complete_custom): Correct the last commit,
1961 putting the correct sentences in the correct pages.
1963 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1965 * src/maemo/easysetup/modest-easysetup-wizard.c:
1966 (create_page_complete_custom): Show the second sentence of text
1967 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1970 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1972 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1973 Set the leave-on-server conf key by default. This fixes
1974 projects.maemo.org bug NB#59258 .
1976 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/modest-account-view-window.c:
1979 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1980 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1983 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1985 * src/maemo/easysetup/modest-easysetup-wizard.c:
1986 (create_caption_new_with_asterisk):
1987 * src/maemo/modest-account-settings-dialog.c:
1988 (create_caption_new_with_asterisk):
1989 Uncomment the code to add the asterisk, because they are no longer in the
1990 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1991 (update_incoming_server_title): Add an asterisk here too.
1993 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/modest-maemo-global-settings-dialog.c:
1996 (current_connection): Check that we are even connected before trying to
1997 get the current connection name, to prevent a warning.
1999 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2000 Change the comments because tny_maemo_conic_device_connect() is now meant to
2002 * src/modest-mail-operation.c:
2003 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2004 make sure we have a connection and fail if we can't connect.
2006 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/modest-main-window.c:
2009 (on_account_store_connecting_finished): Do not try to get the
2010 connection ID if we are not really connected. I am surprised that
2011 this signal handler is called when we are not connected.
2013 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2015 * src/modest-error.h:
2016 * src/modest-ui-actions.c:
2017 (modest_ui_actions_get_msgs_full_error_handler):
2018 Renamed an enum, added comments, added an enum
2019 for retrieve-limit errors.
2021 * src/modest-mail-operation.c: (foreach_add_item),
2022 (internal_folder_observer_update), (update_account_thread),
2023 (modest_mail_operation_get_msgs_full):
2024 (modest_mail_operation_update_account),
2025 Added comments about how this works, and some code that should
2026 (but does not) check the retrieve-limit. See the TODO comment.
2028 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2030 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2031 Initialize help_id to fix the build. Warnings are good.
2033 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2035 * src/widgets/modest-hbox-cell-renderer.c:
2036 (modest_hbox_cell_renderer_append):
2037 * src/widgets/modest-vbox-cell-renderer.c:
2038 (modest_vbox_cell_renderer_append):
2039 Fix the last commit by doing an extra ref.
2041 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2043 * src/widgets/modest-hbox-cell-renderer.c:
2044 (modest_hbox_cell_renderer_append):
2045 * src/widgets/modest-vbox-cell-renderer.c:
2046 (modest_vbox_cell_renderer_append):
2047 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2048 to fix the build with Maemo Bora.
2049 However, there seems to be a remaining crash, probably due to reference
2052 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2054 * src/modest-tny-account.c:
2055 (modest_tny_account_new_for_local_folders):
2056 Use hildon_file_system_info_async_new() to get a better name for
2057 the memory card account, setting it as the account name.
2058 The timing seems to work, but this is probably
2059 not the best place to do this. See the TODO comment.
2060 * src/maemo/modest-main-window.c: (create_details_widget):
2061 * src/widgets/modest-folder-view.c: (text_cell_data):
2062 Use the tny account name instead of hardcoding a name.
2064 2007-05-30 Christian Kellner <ckellner@openismus.com>
2066 * src/modest-search.c: (modest_search):
2067 Correctly set part_search_func even if we have already parsed
2068 the query and thus a valid OgsTextSearcher object.
2070 2007-05-30 Christian Kellner <ckellner@openismus.com>
2073 Search and check for libogs.
2076 Incooparte the ogs build env.
2078 * src/modest-mime-part-search-stream.c:
2079 * src/modest-mime-part-search-stream.h:
2080 Removed since we do the real searching now in modest-search.c.
2082 * src/modest-search.c:
2083 * src/modest-search.h:
2084 Implement support for ogs. We use that if available and requested
2085 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2086 should now handle the corner case when the search term is spread
2087 across multiple reads.
2088 Also the logic in modest_search () was corrected to search all
2089 requested fields until one is found.
2091 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2093 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2095 * src/modest-init.h:
2096 * src/modest-init.c: Made modest_init_local_folders() take a
2097 path and be public so we can iniitialize maildir folders on
2100 * src/modest-local-folder-info.h:
2101 * src/modest-local-folder-info.c:
2102 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2104 * src/modest-tny-account.c:
2105 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2106 still means the standard local-folders path on the local volume.
2108 * src/modest-tny-account-store.c:
2109 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2110 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2111 all accounts when that happens.
2112 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2113 this too, so it shows up in the treeview.
2115 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2117 * src/maemo/modest-maemo-global-settings-dialog.c:
2118 (current_connection):
2119 * src/widgets/modest-global-settings-dialog.c:
2120 (current_connection_default):
2121 Use the enum values instead of 0, 1 and -1,
2122 to make the code clearer.
2124 * src/modest-account-mgr-helpers.c:
2125 (modest_account_mgr_get_connection_specific_smtp): Make this code
2128 * src/modest-runtime.h:
2129 * src/modest-runtime.c:
2130 Added modest_runtime_remove_all_send_queues().
2131 * src/maemo/modest-main-window.c:
2132 (on_account_store_connecting_finished): Recreate the send queues,
2133 using the appropriate transport accounts for this new connection.
2134 Some futher adapting might be needed if the old send queues are not
2135 automatically stopped at this point.
2137 * src/modest-tny-account-store.c: (get_server_accounts):
2138 Create the connection-specific transport accounts, so that they can
2139 be found later by their ID.
2141 * src/modest-tny-account.h:
2142 * src/modest-tny-account.c:
2143 Added modest_tny_account_new_from_server_account_name().
2144 modest_tny_account_new_from_server_account(): Do not create the
2145 send queues here, because they will be
2146 recreated anyway when the connection changes for the first time.
2148 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-local-folder-info.h:
2151 * src/modest-local-folder-info.c:
2152 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2153 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2154 tbox_folder): Take a modest account name instead of a server TnyAccount,
2155 so we can have per-modest-account rather than per-transport-account
2157 We must make sure that we change or recreate the exisitng send queues
2158 when the connection changes for connection-specific transport accounts.
2160 * src/modest-tny-account-store.c:
2161 (create_per_account_local_outbox_folders): Create outboxed per modest
2162 account, not per transport account.
2164 * src/modest-tny-account.h:
2165 * src/modest-tny-account.c:
2166 (modest_tny_account_get_special_folder): For outboxes, get the
2167 parent modest account name. The account is ignored for other folders.
2168 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2169 modest account name rather than a server TnyAccount.
2171 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2173 * src/modest-tny-account.c:
2174 (modest_tny_account_new_from_server_account):
2175 Call modest_runtime_get_send_queue() immediately after creating transport
2176 accounts, so that they start trying to send email from the outbox as soon
2177 as possible at startup. This is probably what we want.
2179 * src/modest-mail-operation.c: (update_account_thread):
2180 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2181 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2182 * src/modest-tny-send-queue.h:
2183 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2184 (modest_ui_actions_on_send):
2185 Added comments about how sending works, though it needs some more work.
2187 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2189 * src/modest-tny-account.c:
2190 (modest_tny_account_get_special_folder): Add TODO because this fails when
2191 the network is busy.
2192 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2193 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2194 Do not try to show this window when there is no active account. The UI
2195 specs does not tell us what to do in this case.
2197 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2201 * src/maemo/Makefile.am:
2202 * src/widgets/Makefile.am: Some dist fixes.
2204 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2206 * src/maemo/modest-connection-specific-smtp-window.c:
2207 (on_button_edit): Make the code clearer, to prevent a double free.
2209 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2211 * src/maemo/modest-account-settings-dialog.c:
2212 (modest_account_settings_dialog_set_account_name),
2213 Check the connection-specific smtp servers checkbox if there are any.
2215 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2216 (modest_connection_specific_smtp_edit_window_init):
2217 Start with a suitable port number.
2219 * src/modest-account-mgr-helpers.h:
2220 * src/modest-account-mgr-helpers.c: Added
2221 modest_account_mgr_get_has_connection_specific_smtp().
2223 (modest_account_mgr_set_connection_specific_smtp),
2224 (modest_account_mgr_remove_connection_specific_smtp),
2225 (modest_account_mgr_get_has_connection_specific_smtp),
2226 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2227 connection-specific smtp server accounts in the account, rather than
2228 the server account conf dir.
2230 This fixes bug projects.maemo.org bug NB#58263 .
2232 * src/modest-tny-account-store.c:
2233 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2234 if there are no server accounts yet, to prevent an infinite loop when there
2235 are no accounts. Document that one must be called before the other.
2237 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2239 * src/modest-account-mgr-helpers.c:
2240 (modest_account_mgr_get_default_account): Make sure that at least
2241 one account is always the default, if there are any enabled accounts.
2242 This is just a sanity check that shouldn't be necessary.
2244 * src/modest-account-mgr-priv.c:
2245 (_modest_account_mgr_account_from_key): Unescape the conf key to
2246 get the real account name. For instance, this is an issue if a space
2247 was in the account name, which can happen because the account name
2248 is generated from the display name.
2249 (_modest_account_mgr_get_account_keyname): Always escape the
2251 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2252 Unescape the conf keys to get the real account names.
2254 For instance, previously the is-default radio button in the accounts
2255 list was not checked for any accounts at first. This fixes that,
2256 and might fix several similar bugs.
2258 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2260 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2261 Removed some debug printfs.
2263 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2265 Modest on-disk outbox directories are now here, for instance:
2266 $HOME/.modest/outboxes/<account-id-1>/outbox
2267 $HOME/.modest/outboxes/<account-id-2>/outbox
2269 $HOME/.modest/local-folders/outbox
2270 so we can have a separate outbox for each account.
2271 But they are shown as one outbox in the GtkTreeView, by using a
2272 TnyMergeFolder in a ModestTnySimpleFolderStore.
2275 * src/modest-tny-simple-folder-store.c:
2276 * src/modest-tny-simple-folder-store.h:
2277 Added ModestTnySimpleFolderStore, used to contain folders from
2278 other folder stores, such as other accounts.
2280 * src/modest-tny-outbox-account.h:
2281 * src/modest-tny-outbox-account.c:
2282 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2283 used for the per-account local outbox folders.
2285 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2286 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2287 only use this (internally) now for the non-outbox local folders.
2289 * src/modest-init.h:
2290 * src/modest-init.c: Added modest_init_one_local_folder(), for
2291 setting up the directory structure for each local folder.
2293 * src/modest-local-folder-info.c:
2294 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2295 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2297 * src/modest-local-folder-info.h:
2298 * src/modest-tny-account-store.c: (on_account_removed),
2299 (on_account_changed), (create_per_account_local_outbox_folders),
2300 (get_server_accounts), (modest_tny_account_store_get_accounts),
2301 (modest_tny_account_store_get_tny_account_by_account),
2302 (modest_tny_folder_store_is_virtual_local_folders):
2304 * src/modest-tny-account.h:
2305 * src/modest-tny-account.c:
2306 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2307 to create an on-disk per-account local outbox folder for each
2309 (create_per_account_local_outbox_folders): Create a local outbox folder
2310 for each transport account.
2311 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2312 for all local folders.
2314 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2315 instead of using g_object_get/set() directly. It is clearer.
2317 (modest_tny_folder_store_get_message_count),
2318 (modest_tny_folder_store_get_local_size
2319 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2320 because we now use these with non-acount folder stores.
2322 (modest_tny_account_get_special_folder),
2323 (modest_tny_account_new_from_server_account),
2324 (modest_tny_account_new_from_account):
2325 (recurse_folders): Adjust to the new outbox system.
2327 * src/modest-tny-folder.h:
2328 * src/modest-tny-folder.c:
2329 (modest_tny_folder_is_local_folder),
2330 (modest_tny_folder_get_local_folder_type),
2331 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2333 * src/widgets/modest-main-window.h:
2334 * src/maemo/modest-main-window.c: (create_details_widget),
2335 (modest_main_window_set_contents_style): Show details for any folder store,
2338 (modest_tny_folder_get_rules):
2339 Remove the const. C does not support constness enough for this.
2341 * src/modest-ui-actions.c:
2342 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2343 make all outboxes appear as one, in the usual local-folders tree node.
2345 (set_active_account_from_tny_account),
2346 (modest_ui_actions_on_folder_selection_changed):
2347 * src/widgets/modest-folder-view.c: (text_cell_data),
2348 (icon_cell_data), (filter_row),
2349 (add_account_folders_to_merged_folder),
2350 (add_account_folders_to_simple_folder_store), (),
2351 (get_cmp_rows_type_pos), (cmp_rows),
2352 (modest_folder_view_set_account_id_of_visible_server_account):
2353 Adjust to the new outbox system, using generic folder stores and folders
2354 in the GtkTreeModel.
2356 2007-05-23 Christian Kellner <ckellner@openismus.com>
2358 * src/modest-mail-operation.c:
2359 (modest_mail_operation_update_account):
2360 Use info->max_size instead of unintialized local var [small
2361 build fix]. (Added TODO to review that change since I don't
2364 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2366 * libmodest-dbus-client/libmodest-dbus-client.c:
2367 (libmodest_dbus_client_compose_mail): function added
2368 * src/dbus_api/modest-dbus-api.h:
2369 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2370 (on_compose_mail): Implementation of the SendAsMail functionality
2372 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2374 * src/modest-account-mgr.c:
2375 (modest_account_mgr_add_server_account): Set the secure-connection
2376 conf key for transport accounts as well as store accounts. I don't know
2377 why the if was there. For instance, this makes sure that we use SSL
2378 for the gmail preset from the easysetup wizard.
2380 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2382 * src/gnome/modest-main-window.c:
2383 (on_account_store_connecting_finished), (connect_signals):
2384 * src/maemo/modest-main-window.c:
2385 (on_account_store_connecting_finished), (connect_signals),
2386 (modest_main_window_new):
2387 Handle TnyAccountStore::connecting-finished instead of
2388 TnyDevice::connection-changed, because we cannot actually perform
2389 operations on accounts until TnyAccountStore has itself responded to
2390 the TnyDevice::connection-changed signal. This prevents a GError from
2392 Do not try to update at startup, because we (at least on scratchbox)
2393 already do an update at startup when the device goes online.
2394 This prevents a GError from tinymail.
2395 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2396 Added TODO about stopping simultaneous operations.
2398 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2400 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2401 * src/modest-mail-operation-queue.c:
2402 (modest_mail_operation_queue_remove):
2403 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2404 about where they happened.
2406 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2408 * src/modest-ui-actions.c:
2409 (modest_ui_actions_on_password_requested): Make sure that the remember
2410 output parameter is always TRUE.
2412 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2414 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2415 Show a OK/Cancel dialog if the error is a question, though we still do not
2416 know anything more about what we are asking the user.
2417 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2418 Fix an uninitialized variable (helper). This is a logic error, however.
2420 2007-05-21 Christian Kellner <ckellner@openismus.com>
2422 * src/modest-search.h:
2423 Correct bit shifting in the ModestSearchFlags enum.
2425 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2427 * src/modest-tny-account.c:
2428 (modest_tny_account_new_from_server_account): Do not use the lsub and
2429 check-all hard-coded IMAP options when using POP.
2431 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2433 * src/modest-tny-account.c:
2434 (modest_tny_account_new_from_server_account):
2435 Use NULL for the secure-auth method for POP when Password auth has been
2436 specified by the user, as we already do for IMAP. "auth=Login" causes
2437 an error from camel or the server.
2439 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2441 * src/maemo/modest-account-settings-dialog.c:
2442 (create_page_account_details),
2443 (modest_account_settings_dialog_set_account_name):
2444 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2445 for the leave-on-server checkbox, rathr than just the checkbox, when
2446 the protocol is not POP.
2448 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2450 * src/widgets/modest-account-view.c:
2451 * src/widgets/modest-account-view.h:
2452 Added modest_account_view_select_account() which will be useful later
2453 to asynchronously re-select the edited account.
2455 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2457 * src/maemo/modest-account-settings-dialog.c:
2458 (modest_account_settings_dialog_set_account_name):
2459 Automatically choose the port numbers based on the secure authentication
2460 methods, if they have not been chosen before.
2461 This fixes projects.maemo.org bug NB#56273 .
2463 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/modest-main-window-ui.h:
2466 * src/modest-ui-actions.c:
2467 * src/modest-ui-actions.h:
2468 Connect the Tools/SMTP Servers menu item to
2469 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2470 SMTP servers dialog, as in the UI specification and saves changes when it
2471 is closed. This fixed projects.maemo.org bug NB#56305 .
2473 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2475 * src/maemo/modest-connection-specific-smtp-window.c:
2476 (modest_connection_specific_smtp_window_init):
2477 Use gtk_window_set_default_size() to make this window big enough, so
2478 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2480 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2482 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2483 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2484 (modest_connection_specific_smtp_edit_window_init),
2485 Do not try to connect to a combobox signal before the combobox exists.
2486 This fixes the cras in projects.maemo.org bug NB#56288 .
2487 (modest_connection_specific_smtp_edit_window_get_settings):
2488 Remove the server_account_name parameter which was being checked for NULL
2489 though it was not used.
2491 * src/maemo/modest-connection-specific-smtp-window.c:
2492 (modest_connection_specific_smtp_window_fill_with_connections),
2493 (on_button_edit), (modest_connection_specific_smtp_window_init):
2494 Correct the number of treemodel columns to prevent a warning.
2495 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2496 libconic does not work.
2498 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2500 * src/modest-tny-account.c:
2501 (modest_tny_account_new_from_server_account):
2502 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2503 SMTP when "None" was chosen by the user. However, with my SMTP server that
2504 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2507 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2509 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2510 to explain the memory management issue with the ID in the ModestPair.
2512 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2513 (add_sending_page), (modest_account_assistant_finalize):
2514 * src/gnome/modest-gnome-global-settings-dialog.c:
2515 (create_updating_page), (create_composing_page):
2516 * src/gnome/modest-msg-edit-window.c: (get_transports),
2517 (init_window), (modest_msg_edit_window_finalize),
2518 (modest_msg_edit_window_get_msg_data):
2519 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2520 * src/gnome/modest-transport-widget.c:
2521 (modest_transport_widget_finalize), (smtp_configuration):
2522 * src/maemo/modest-maemo-global-settings-dialog.c:
2523 (create_updating_page), (create_composing_page):
2524 * src/maemo/modest-msg-edit-window.c: (get_transports),
2525 (init_window), (modest_msg_edit_window_finalize),
2526 (modest_msg_edit_window_get_msg_data),
2527 (modest_msg_edit_window_free_msg_data):
2528 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2529 (modest_store_widget_finalize):
2530 * src/maemo/modest-transport-widget.c:
2531 (modest_transport_widget_finalize), (smtp_configuration):
2532 * src/modest-main.c: (send_mail):
2533 * src/widgets/modest-combo-box.h:
2534 * src/widgets/modest-global-settings-dialog-priv.h:
2535 * src/widgets/modest-global-settings-dialog.c:
2536 (modest_global_settings_dialog_finalize):
2537 * src/widgets/modest-msg-edit-window.h:
2538 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2539 as long as the combo box, to prevent use of freed memory for the ID.
2541 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2543 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2544 get_accounts(), to make this clearer. Do not check for the enabled gconf
2545 key, because we do not use this for server accounts (at least, not yet).
2546 This allows us to send email again.
2548 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2550 * src/maemo/modest-platform.c:
2551 (on_modest_conf_update_interval_changed), (modest_platform_init):
2552 Only respond to this particular key change. All these strcmp()s cannot be
2555 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2557 * src/maemo/modest-maemo-global-settings-dialog.c:
2558 (current_connection): Prevent a crash in scratchbox when
2559 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2560 * src/maemo/modest-platform.c:
2561 (on_modest_conf_update_interval_changed), (modest_platform_init):
2562 Get the update interval from gconf and reset it when the gconf key changes.
2564 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2566 * src/modest-protocol-info.c:
2567 * src/modest-protocol-info.h: Adde enum-specific get functions,
2568 instead of using a ModestProtocolType enum parameter.
2570 * src/gnome/modest-account-assistant.c:
2571 * src/gnome/modest-store-widget.c:
2572 * src/gnome/modest-store-widget.h:
2573 * src/gnome/modest-transport-widget.c:
2574 * src/gnome/modest-transport-widget.h:
2575 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2576 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2577 * src/maemo/easysetup/modest-easysetup-wizard.c:
2578 * src/maemo/modest-account-settings-dialog.c:
2579 * src/maemo/modest-account-settings-dialog.h:
2580 * src/maemo/modest-store-widget.c:
2581 * src/maemo/modest-store-widget.h:
2582 * src/maemo/modest-transport-widget.c:
2583 * src/maemo/modest-transport-widget.h:
2584 * src/modest-account-mgr-helpers.c:
2585 * src/modest-account-mgr-helpers.h:
2586 * src/modest-account-mgr.c:
2587 * src/modest-account-mgr.h:
2588 * src/modest-tny-account.c:
2589 * src/modest-tny-folder.c:
2590 * src/widgets/modest-account-view.c:
2591 * src/widgets/modest-retrieve-combo-box.c:
2592 * src/widgets/modest-retrieve-combo-box.h:
2593 * src/widgets/modest-secureauth-combo-box.c:
2594 * src/widgets/modest-serversecurity-combo-box.c:
2595 * src/widgets/modest-serversecurity-combo-box.h:
2596 * tests/check_account-mgr.c:
2597 Use the specific functions, and use the re-renamed enum values for GNOME too.
2599 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2601 * src/modest-pair.h:
2602 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2603 so we can get the second based on the first.
2605 * src/maemo/modest-account-settings-dialog.h:
2606 * src/maemo/modest-account-settings-dialog.c:
2607 Added get_supported_secure_authentication_methods(), though it is mostly
2608 commented-out for now until the necessary API is committed to tinymail.
2609 (modest_account_settings_dialog_set_account_name),
2610 (save_configuration): Request the supported authentication methods from the
2611 server, so we can choose a working method.
2613 * src/modest-tny-account-store.h:
2614 * src/modest-tny-account-store.c:
2615 (modest_tny_account_store_get_session): Rename from
2616 tny_account_store_get_session().
2618 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2620 * src/modest-protocol-info.h: Split the ModestProtocol enum
2621 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2622 There was no need to have these unrelated values in one enum.
2624 * src/: many files: Adapted to changed enum. This makes the code a bit
2625 clearer, and the compiler could catch some errors.
2627 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2629 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2630 Show the detailed internal camel error message when an error happens
2631 during the configuration, so that our testers can give us more clues.
2632 For instance, in projects.maemo.org bug NB#56910 .
2634 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2636 * src/modest-tny-account.c:
2637 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2638 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2640 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2642 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2643 * src/maemo/modest-account-settings-dialog.c:
2644 (modest_account_settings_dialog_set_account_name),
2645 (save_configuration): For the incoming secure authentication checkbox,
2646 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2647 the UI specification. PLAIN does not seem to be supported for most IMAP
2648 servers anyway, and I am not sure what it would mean.
2649 However, we probably need to discover which of the secure-authentication
2650 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2651 * src/modest-account-mgr-helpers.c:
2652 (modest_account_mgr_get_server_account_data):
2654 * src/modest-tny-account.c:
2655 (modest_tny_account_new_from_server_account):
2656 Use tny_account_set_mech() to set secure-authentication methods,
2657 with some special-casing for IMAP, based on my observations of how
2660 * src/modest-account-mgr-helpers.h:
2661 * src/modest-account-mgr.c:
2662 * src/modest-defs.h: Comment that the URI is only used for local folders.
2664 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2666 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2667 parameter const, just to be neat.
2668 * src/modest-text-utils.c: (modest_text_utils_inline):
2669 End g_strconcat() with NULL, as its documentation says. This is almost
2670 certainly the cause of my crash at startup on the device. Interestingly,
2671 valgrind doesn't tell us about these errors.
2673 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2675 * scripts/build-packages: Added more precise comments about how to use
2676 this script, though I still get this error:
2677 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2678 error building tinymail
2680 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2682 * src/maemo/modest-main-window.c: (on_account_update):
2683 Very slight cleanup, hoping to make it simpler to discover what causes
2684 a crash here sometimes.
2686 * src/modest-tny-account.c:
2687 (modest_tny_account_new_from_server_account): Set the port. Added
2688 comments about the options and a TODO comment because I need to find out
2689 how to specify the secure authentication method.
2691 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2693 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2694 changed CFlags paths form modest to libmodest
2696 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2698 * src/modest-account-mgr-helpers.c:
2699 (modest_account_mgr_get_server_account_data),
2700 (modest_account_mgr_free_server_account_data):
2701 * src/modest-account-mgr-helpers.h:
2702 * src/modest-account-mgr.c:
2703 (modest_account_mgr_add_server_account):
2704 * src/modest-defs.h:
2705 * src/modest-tny-account.c:
2706 (modest_tny_account_new_from_server_account):
2707 Determine the options for tny_camel_account_add_option() here,
2708 based on the settings, rather than storing them directly in gconf.
2710 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2712 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2713 Show a more friendly error dialog now that we expect (from the tinymail
2714 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2716 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2718 * src/maemo/modest-main-window.c: (on_account_update): Check that
2719 account_name is not NULL, to prevent a crash at startup that I am
2720 seeing on the N800. I do wonder why it is NULL.
2722 * src/maemo/easysetup/modest-easysetup-wizard.c:
2723 (create_page_user_details):
2724 * src/maemo/modest-account-settings-dialog.c:
2725 (create_page_user_details), (create_page_outgoing):
2726 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2727 (modest_connection_specific_smtp_edit_window_init):
2728 * src/modest-ui-actions.c:
2729 (modest_ui_actions_on_password_requested):
2730 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2731 might do something useful with the on-screen keyboard.
2733 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2735 * src/maemo/modest-main-window.c: (on_account_update):
2736 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2737 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2739 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2741 * src/modest-tny-account-store.c: (on_account_changed):
2742 Correct the signature of this signal handler.
2744 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2746 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2747 Show a HildonNote instead of a GtkDialog for Maemo.
2749 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2751 * src/widgets/modest-account-view.h:
2752 * src/widgets/modest-account-view.c: (on_account_changed),
2753 (on_account_removed). Added a boolean flag, set/unset by
2754 modest_account_view_block_conf_updates(),
2755 modest_account_view_unblock_conf_updates() to prevent unnecessary
2756 updates, but this is not very useful because the gconf notifications are
2757 so delays (maybe only on Maemo Bora).
2758 So auto-updating is turned off, and these functions do an explicit
2759 update when necessary.
2760 However, something else is still doing too much work when adding/removing
2761 accounts, probably in another part of the application.
2763 * src/maemo/modest-account-view-window.c:
2764 (on_delete_button_clicked), (on_edit_button_clicked),
2765 (on_new_button_clicked): Use the new functions.
2767 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2769 * src/modest-account-mgr-helpers.c:
2770 (modest_account_mgr_set_first_account_as_default):
2771 Sort the list of names alphabetically-by-title, so we choose the first one
2773 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2774 alphabetically by the title.
2776 This fixes projects.maemo.org bug NB#56418 .
2778 * src/modest-account-mgr-priv.c:
2779 (_modest_account_mgr_account_from_key):
2780 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2781 avoid a valgrind error, and possible random behaviour.
2783 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2785 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2786 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2787 tinymail documentation to say that this can be expected.
2788 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2789 pretty, and should not happen, but I would prefer to know when it does.
2791 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2793 * configure.ac: When using the older hildon version, probably on Bora,
2794 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2796 * src/widgets/modest-attachment-view.c:
2797 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2800 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2802 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2803 Implemented the prototype. Can be tested with
2804 tests/dbus_api/test_open_message:
2806 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2808 * src/modest-tny-account-store.c:
2809 (modest_tny_account_store_instance_init), (get_password):
2810 * src/modest-ui-actions.c:
2811 (modest_ui_actions_on_password_requested):
2812 Do not store the password in gconf, because this function is called
2813 for non-remembered passwords. Actually use the cached (in the hash map)
2814 password instead of releasing it.
2815 The password will now not be remembered if it is asked via the protected
2816 password dialog, as per the UI spec.
2818 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2820 * src/modest-defs.h:
2821 * src/modest-account-mgr-helpers.h:
2822 * src/modest-account-mgr-helpers.c:
2823 Added modest_server_account_get_username_has_succeeded(),
2824 modest_server_account_set_username_has_succeeded().
2825 (modest_server_account_set_username),
2826 Reset the has-succeeded flag if the username changes.
2828 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2829 * src/maemo/modest-connection-specific-smtp-window.c:
2830 (modest_connection_specific_smtp_window_save_server_accounts):
2831 Use modest_server_account_set_username() instead of using
2832 modest_conf_set_string() directly, so that the has-succeeded flag is always
2835 * src/modest-ui-actions.c:
2836 (modest_ui_actions_on_password_requested): Dim the username entry if
2837 the username has ever worked, as per the UI spec.
2839 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2841 * src/modest-tny-account-store.c: (get_password):
2842 * src/modest-ui-actions.c:
2843 (modest_ui_actions_on_password_requested):
2844 Allow the username to be changed too, though there is more work to
2845 be done on exactly how this behaves.
2847 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2849 * src/modest-account-mgr-helpers.h:
2850 * src/modest-account-mgr-helpers.c:
2851 Added modest_account_mgr_get_display_name(),
2852 modest_server_account_get_username(),
2853 modest_server_account_set_username(),
2854 modest_server_account_set_password(),
2855 modest_server_account_get_hostname() functions so we do not need to
2856 use the conf API directly.
2858 * src/maemo/modest-main-window.c: (connect_signals):
2859 Actually connect ot the ModestAccountStore::request-password signal,
2860 so that we show the dialog when the password is requested by Tinymail,
2861 for isntance if it is empty.
2863 * src/modest-marshal.list:
2864 * src/modest-tny-account-store.c:
2865 (modest_tny_account_store_class_init), (get_password),
2866 (modest_tny_account_store_alert):
2867 * src/modest-tny-account-store.h:
2868 * src/modest-ui-actions.h:
2869 * src/modest-ui-actions.c:
2870 (modest_ui_actions_on_password_requested):
2871 Change the signal parameters, so it is obvious that we are providing
2872 the non human-readable server name, and receiving both the username
2873 and password, though changing of the username is not yet implemented.
2874 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2875 for the GNOME version.
2877 This should fix the projects.maemo.org bug NB#56209, though it does not
2878 work on Bora, because the gconf_client_get() for the password fails
2879 immediately after we save it with gconf_client_set().
2881 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2884 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2885 caused an undefined symbol error:
2886 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2888 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-tny-account-store.c:
2891 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2892 using a GError instead of a string message, so we can translate it in
2895 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2897 * src/maemo/modest-address-book.c:
2898 (modest_address_book_check_names):
2899 * src/maemo/modest-msg-view-window.c:
2900 (modest_msg_view_window_clipboard_owner_change):
2901 * src/modest-init.c: (modest_init_init_ui):
2902 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2903 (update_folders_cb), (modest_mail_operation_update_account):
2904 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2905 (modest_ui_actions_on_msg_attachment_clicked),
2906 (modest_ui_actions_on_msg_recpt_activated):
2907 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2908 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2909 (modest_msg_view_search_next):
2910 * src/widgets/modest-recpt-editor.c:
2911 (modest_recpt_editor_on_button_release_event),
2912 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2913 g_message(). At this point we should only be seeing interesting errors on
2914 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2916 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2918 (modest_wizard_dialog_force_title_update):
2919 * src/maemo/easysetup/modest-wizard-dialog.h:
2920 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2921 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2922 can update the title when appropriate. Otherwise the title is wrong if the
2923 pages are added after adding the notebook to the dialog.
2924 This must be a problem in HildonWizardDialog too.
2925 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2927 * src/maemo/easysetup/modest-easysetup-wizard.c:
2928 (create_subsequent_customsetup_pages),
2929 (create_subsequent_easysetup_pages):
2930 Call modest_wizard_dialog_force_title_update() so that the title is
2931 correct even with GTK+ < 2.10.
2932 This fixes projects.maemo.org bug NB#56145 .
2934 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/modest-platform.c:
2937 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2938 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2941 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2943 * src/widgets/modest-window.h:
2944 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2945 and modest_window_save_state(), which invokes it.
2947 * src/widgets/modest-window-mgr.h:
2948 * src/widgets/modest-window-mgr.c:
2949 Added modest_window_mgr_save_state_for_all_windows(), which calls
2950 the save_state vfunc on all registered windows, if implemented.
2952 * src/gnome/modest-msg-edit-window.c:
2953 * src/gnome/modest-msg-view-window.c:
2954 * src/maemo/modest-msg-edit-window.c:
2955 * src/maemo/modest-msg-view-window.c:
2956 * src/maemo/modest-main-window.c:
2957 Specify the existing save_settings functions as implementations of
2958 ModestWindow::save_state_func().
2960 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2961 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2962 enabling hibernation, for instance.
2964 We may need to do the same thing for restoring settings.
2967 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2969 * src/widgets/modest-window-mgr.c:
2970 * src/widgets/modest-window-mgr.h:
2971 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2972 modest_window_mgr_get_hibernation_is_prevented().
2974 * src/maemo/modest-main-window.c:
2975 (on_hildon_program_is_topmost_notify): Prevent hibernation
2976 (possible when the application goes to the background in the WM),
2977 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2979 * src/maemo/easysetup/modest-easysetup-wizard.c:
2980 (modest_easysetup_wizard_dialog_init):
2981 * src/maemo/modest-account-settings-dialog.c:
2982 (modest_account_settings_dialog_init):
2983 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2984 (modest_connection_specific_smtp_edit_window_init):
2985 * src/maemo/modest-connection-specific-smtp-window.c:
2986 (modest_connection_specific_smtp_window_init):
2987 * src/maemo/modest-signature-editor-dialog.c:
2988 (modest_signature_editor_dialog_init):
2989 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2990 prevent hibernation while any of these account settings dialogs are open.
2992 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2994 * src/maemo/Makefile.am:
2995 * src/maemo/modest-osso-state-saving.c:
2996 * src/maemo/modest-osso-state-saving.h: Added
2997 modest_osso_load_state() and modest_osso_save_state() though they do
2998 nothing now. They should iterate through all the open windows and load/save
3000 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3001 save state when closing.
3003 * src/maemo/modest-main-window.c:
3004 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3005 Add a notification handler for the HildonProgram::is-topmost property,
3006 so we can allow hibernation when the application goes into the background.
3007 But we still need to detect when the accounts setup windows are open so
3008 we can stop hibernation when they are open.
3009 To do this, I also added the main window the HildonProgram. This might have
3010 other side-effects/benefits, and should maybe be done for other windows.
3012 * src/maemo/modest-osso-autosave-callbacks.h:
3013 * src/maemo/modest-osso-autosave-callbacks.c:
3014 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3015 though it does not do anything yet, and we might never need this to do
3016 anything. For instance, we already save drafts.
3018 * src/maemo/modest-platform.c: (modest_platform_init):
3019 Specify the libosso auto-save callback.
3021 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3023 * src/maemo/modest-platform.c:
3024 (modest_platform_set_update_interval):
3025 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3026 aparently stays valid between application instances, so we can use this
3027 to remove and reset it later. According to a maemo-developers email from
3030 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3032 * configure.ac: Depend on libalarm for Maemo.
3034 * src/dbus_api/modest-dbus-api.h:
3035 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3036 (on_send_receive), (modest_dbus_req_handler):
3037 Handle a SEND_RECEIVE D-Bus method.
3039 * libmodest-dbus-client/libmodest-dbus-client.c:
3040 (libmodest_dbus_client_send_and_receive):
3041 * libmodest-dbus-client/libmodest-dbus-client.h:
3042 Add C convenience functions for calling the new D-Bus method.
3044 * src/modest-platform.h:
3045 * src/gnome/modest-platform.c:
3046 * src/maemo/modest-platform.c:
3047 Added modest_platform_set_update_interval(), which uses the
3048 alarmd API on Maemo.
3049 (modest_platform_init),
3050 Call modest_platform_set_update_interval(), using a hard-coded
3051 interval for now (until the global settings dialog is implemented),
3052 though I am not sure that this makes sense yet.
3054 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3056 * src/dbus_api/modest-dbus-callbacks.c:
3057 (modest_osso_cb_hw_state_handler):
3058 * src/dbus_api/modest-dbus-callbacks.h:
3059 * src/maemo/modest-platform.c: (modest_platform_init):
3060 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3061 in case this has some effect on the ability for Maemo to ping the
3064 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3066 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3067 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3068 warning. It is probably a logic error, but I need to fix the build.
3070 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3072 * src/modest-account-mgr.h:
3073 * src/modest-account-mgr.c:
3074 (modest_account_mgr_account_names): Add a gboolean enabled_only
3075 parameter, so we can get lists of onlt the enabled accounts.
3077 (modest_account_mgr_add_account),,
3078 (modest_account_mgr_account_with_display_name_exists):
3079 * src/maemo/modest-msg-edit-window.c: (get_transports):
3080 * src/modest-account-mgr-helpers.c:
3081 (modest_account_mgr_set_first_account_as_default):
3082 * src/modest-init.c: (init_default_account_maybe):
3083 * src/modest-tny-account-store.c: (get_accounts):
3084 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3085 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3086 * tests/check_account-mgr.c: (START_TEST):
3087 Provide the extra parameter, as appropriate.
3089 * src/widgets/modest-account-view.c: (update_account_view):
3090 Do not show disabled accounts (meaning that there is no way to
3091 enable/disable accounts in the UI (the feature is not in our UI
3092 specification), so we can use this internally only to mark unfinished
3093 or temporary account data.
3095 * src/maemo/easysetup/modest-easysetup-wizard.c:
3096 (create_account): Add boolean enable parameter, so we can specify FALSE
3097 to create the temporary account.
3098 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3099 (on_before_next): When finishing, when there is a temporary account, just
3101 Also, use a timeout to delay the showing of the dialog until gconf is likely
3102 to return correct information, due to a maemo gconf bug that is fixed in
3103 osso 1.1, but not yet in Bora.
3104 However, the dialog stays on screen after it is destroyed.
3106 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3107 for invalid data when cancelling. Use a hildon note instead of a dialog
3108 to complain about invalid data. Do not show the account-saved note if the
3109 account is disabled (a temporary account that will not really be saved for use
3112 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3114 * src/modest-account-mgr-helpers.h:
3115 * src/modest-account-mgr-helpers.c:
3116 Added modest_account_mgr_unset_default_account(),
3117 Added modest_account_mgr_set_first_account_as_default().
3119 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3120 If it was the default account, unset the default account name.
3122 * src/maemo/modest-account-view-window.c:
3123 (on_delete_button_clicked): If it was the default account,
3124 set the first remaining account as the default instead.
3126 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3127 a NULL account or a NULL default account, to prevent a crash. This should
3128 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3131 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3133 * src/widgets/modest-recpt-editor.c:
3134 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3135 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3136 TODO comment for this. This fixes the build.
3138 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3139 be the best place for it. This will in future update all auto-update accounts,
3140 rather than just the current/default account, when that gconf key exists.
3141 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3142 if there are no accounts, before calling do_send_receive().
3143 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3145 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3146 * src/maemo/modest-main-window-ui.h:
3147 * src/maemo/modest-main-window.c: (on_connection_changed),
3148 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3149 directly, becaue the signal handler does more.
3151 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3153 * src/modest-account-mgr-helpers.c:
3154 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3155 for the case that the account does not exist.
3157 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3158 (equivalent to the modest account name) rather than the tinymail account name
3159 (equivalent to the modest account title - human readable) to get the account data.
3160 Check for null account data to prevent the crash, and add a TODO comment saying that
3161 this needs fixing because it is using the server account name instead of the account name.
3163 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3165 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3166 * src/maemo/modest-account-settings-dialog.c: (show_error),
3168 Use hildon_note_new_information() for informative and error messages,
3169 which seems to be expected for Maemo applications (no documentation that I know of
3170 says this). I am surprised that there is no distinction between info and error
3173 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3175 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3176 it is easy to find where this is used.
3178 * src/maemo/easysetup/modest-easysetup-wizard.c:
3179 (create_page_welcome), (create_page_account_details),
3180 (create_page_user_details), (create_page_complete_easysetup),
3181 (create_page_custom_incoming), (create_page_custom_outgoing),
3182 (create_page_complete_custom):
3183 * src/maemo/modest-account-settings-dialog.c:
3184 (create_page_account_details), (create_page_user_details),
3185 (create_page_incoming), (create_page_outgoing):
3186 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3187 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3188 (modest_connection_specific_smtp_edit_window_init):
3189 * src/maemo/modest-connection-specific-smtp-window.c:
3190 (modest_connection_specific_smtp_window_init):
3191 * src/maemo/modest-signature-editor-dialog.c:
3192 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3193 and scrolling policy as per the Email Application Layout Guide, if I have
3196 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3198 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3199 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3200 which were empty, because these vfuncs have been removed from TnyAccountStore.
3201 This fixes the build.
3203 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3205 * src/maemo/modest-main-window.c:
3206 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3207 showing/hiding it. Added TODO because it probably should not be NULL.
3208 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3209 because unnecessary g_warnings() make degugging difficult.
3211 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/modest-msg-edit-window.c:
3214 (modest_msg_edit_window_select_color),
3215 (modest_msg_edit_window_select_background_color): 2 const corrections and
3216 moving 2 #endifs before closing brackets, to fix the build.
3218 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3220 * src/maemo/easysetup/modest-easysetup-wizard.h:
3221 * src/maemo/easysetup/modest-easysetup-wizard.c:
3222 (modest_easysetup_wizard_dialog_finalize),
3223 (on_button_edit_advanced_settings), (create_page_complete_custom),
3224 (on_response), (create_account):
3225 Implement the Advanced Settings edit button, by saving the account information,
3226 for the Advanded Settings dialog to use directly from gconf, and removing it
3227 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3228 Bug #5533 in the projects.maemo.org bugzilla.
3230 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3232 * src/maemo/modest-msg-view-window.c:
3233 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3234 when opening a message window.
3236 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3238 * src/maemo/easysetup/modest-easysetup-wizard.c:
3239 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3242 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3243 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3244 gconf settings. I probably added more checks than necessary, but that is safer.
3246 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3247 variable to fix the build, but this seems to be used when it is still NULL.
3249 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3251 * src/modest-platform.h:
3252 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3253 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3254 * src/modest-main.c: Implement this function so we can avoid using
3255 maemo-specific API from cross-platform code.
3257 * src/modest-tny-account-store.c:
3258 (get_smtp_specific_transport_account_for_open_connection):
3259 * src/modest-ui-actions.c: (check_for_connection),
3260 (modest_ui_actions_on_item_not_found):
3261 Use modest_platform_connect_and_wait() and put #idefs around other
3262 maemo-specific code, because only maemo currently has a way to
3263 identify connection names.
3265 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3267 * src/modest-tny-account-store.h:
3268 * src/modest-tny-account-store.c:
3269 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3270 the connection-specific SMTP server settings in the configuration.
3272 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3274 * src/maemo/modest-main-window.c: (on_connection_changed),
3276 * src/modest-main.c: (main), (start_ui), (send_mail):
3277 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3278 that is what is intended.
3280 * src/modest-ui-actions.c: (action_send), (action_receive),
3281 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3282 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3283 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3284 SMTP server is used when it is specified.
3286 (modest_ui_actions_on_send_receive):
3287 Check that a connection is open before proceeding.
3288 Receive and then send, instead of vice-versa, as per the specification.
3290 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3292 * src/modest-mail-operation.c:
3293 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3294 though I guess it should be something other than NULL.
3296 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3298 * src/maemo/easysetup/modest-easysetup-wizard.c:
3299 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3300 combo twice, to avoid an g_warning and to make it visible again.
3301 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3302 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3303 (already intended) dereference when detaching, because we then recreate the menu.
3304 But I am not sure why the warning was happening, and it is possible that this is a memory
3307 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3309 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3310 and uri_parse_mailto() utility functions.
3311 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3313 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3315 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3317 * src/dbus_api/modest-dbus-api.h:
3318 * src/dbus_api/modest-dbus-callbacks.c:
3319 Use an idle callback to execute the modest code in the application's own thread.
3320 Remove the helloworld example method.
3321 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3322 parsed, and the open-message method is not implemented because this is not yet implemented in
3324 * libmodest-dbus-client/libmodest-dbus-client.c:
3325 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3326 (libmodest_dbus_client_open_message):
3327 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3329 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3330 body without crashing.
3332 * tests/dbus_api/Makefile.am:
3333 * tests/dbus_api/test_mail_to.c:
3334 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3336 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3338 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3339 Added file to fix the build. Sorry.
3341 * src/dbus_api/Makefile.am:
3342 * src/dbus_api/modest-dbus-api.h:
3343 * src/dbus_api/modest-dbus-callbacks.h:
3344 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3345 (modest_dbus_req_handler):
3346 Put constants in a separate header so it can be reused by the
3347 client library, without duplication
3349 * libmodest-dbus-client/Makefile.am:
3350 * libmodest-dbus-client/libmodest-dbus-client.c:
3351 (libmodest_dbus_client_call_helloworld),
3352 (libmodfest_dbus_client_send_mail),
3353 (libmodfest_dbus_client_mailto),
3354 (libmodfest_dbus_client_open_message):
3355 * libmodest-dbus-client/libmodest-dbus-client.h:
3356 (Partly) Implement a send_mail D-Bus method.
3358 * tests/dbus_api/Makefile.am:
3359 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3360 the send_email D-Bus method.
3362 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3366 * libmodest-dbus-client/Makefile.am:
3367 * libmodest-dbus-client/libmodest-dbus-client.c:
3368 * libmodest-dbus-client/libmodest-dbus-client.h:
3369 * tests/dbus_api/Makefile.am:
3370 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3371 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3373 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3375 * src/maemo/easysetup/modest-easysetup-wizard.c:
3376 (create_page_account_details):
3377 * src/maemo/modest-account-settings-dialog.c:
3378 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3379 widgets, because this might not be the default in future versions of the Maemo GTK+.
3380 However, I can not not get capitalization to work even in a simple test case.
3382 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3384 * src/maemo/easysetup/modest-easysetup-wizard.c:
3385 (create_page_custom_incoming), (create_page_custom_outgoing):
3386 * src/maemo/modest-account-settings-dialog.c:
3387 (create_page_account_details), (create_page_incoming),
3388 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3389 instead of using gtk_check_button_with_label(), so they are aligned like the other
3390 widgets, as per the UI spec.
3392 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3394 * src/maemo/easysetup/modest-easysetup-wizard.c:
3395 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3396 * src/widgets/modest-validating-entry.c:
3397 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3398 Modest prefix instead of an EasySetup prefix.
3400 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3402 * src/widgets/modest-validating-entry.h:
3403 * src/widgets/modest-validating-entry.c: (on_insert_text),
3404 Added easysetup_validating_entry_set_max_func(), used to set a callback
3405 to call when the max number of characters is reached. GtkEntry has a max-length
3406 already but is silent about it.
3408 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3409 (create_page_account_details), (create_page_user_details),
3411 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3412 (create_page_account_details), (create_page_user_details),
3413 (create_page_outgoing):
3414 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3415 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3416 the UI spec, when the user tries to enter more than the max number of characters.
3418 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3420 * src/maemo/easysetup/modest-easysetup-wizard.c:
3421 (create_page_user_details), (create_page_custom_incoming),
3422 (create_page_custom_outgoing):
3423 * src/maemo/modest-account-settings-dialog.c:
3424 (create_page_user_details), (create_page_incoming),
3425 (create_page_outgoing):
3426 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3427 (modest_connection_specific_smtp_edit_window_init):
3428 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3429 not appropriate. Bad Maemo-specific defaults!.
3431 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3433 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3434 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3435 (modest_signature_editor_dialog_set_settings):
3436 Disable the label and textview when the checkbox is disabled, and use the
3437 specified (UI spec) default signature text.
3439 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3441 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3442 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3444 * src/modest-defs.h:
3445 * src/modest-account-mgr-helpers.h:
3446 * src/modest-account-mgr-helpers.c:
3447 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3449 * src/maemo/Makefile.am:
3450 * src/maemo/modest-signature-editor-dialog.c:
3451 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3454 * src/maemo/modest-account-settings-dialog.h:
3455 * src/maemo/modest-account-settings-dialog.c:
3456 (modest_account_settings_dialog_finalize), (on_button_signature),
3457 (save_configuration): Use the new dialog when the Edit button is pressed, and
3458 save the changes if necessary, as per the UI spec.
3460 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3462 * src/maemo/Makefile.am:
3463 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3464 based on maemo-develoers email from Dirk.
3466 * src/maemo/easysetup/modest-easysetup-wizard.c:
3467 (create_page_welcome), (create_page_account_details),
3468 (create_page_user_details), (create_page_complete_easysetup),
3469 (create_page_custom_incoming), (create_page_custom_outgoing),
3470 (create_page_complete_custom),
3471 (modest_easysetup_wizard_dialog_init):
3472 * src/maemo/modest-account-settings-dialog.c:
3473 (create_page_account_details), (create_page_user_details),
3474 (create_page_incoming), (create_page_outgoing),
3475 (modest_account_settings_dialog_init):
3476 * src/maemo/modest-connection-specific-smtp-window.c:
3477 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3479 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3481 * src/maemo/easysetup/modest-easysetup-wizard.c:
3482 (create_page_account_details), (create_page_custom_outgoing),
3483 (create_page_complete_custom):
3484 * src/maemo/modest-account-settings-dialog.c:
3485 (create_page_user_details), (create_page_incoming),
3486 (create_page_outgoing):
3487 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3488 (modest_connection_specific_smtp_edit_window_init):
3489 Use the correct (UI spec) port min/max, and use horizontal separators,
3492 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3494 * src/maemo/easysetup/modest-easysetup-wizard.c:
3495 (set_default_custom_servernames):
3496 * src/maemo/modest-account-settings-dialog.c:
3497 (create_page_incoming), (on_combo_outgoing_security_changed),
3498 (on_combo_incoming_security_changed), (create_page_outgoing),
3499 (modest_account_settings_dialog_set_account_name),
3500 (save_configuration):
3501 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3502 (on_combo_security_changed),
3503 (modest_connection_specific_smtp_edit_window_init),
3504 (modest_connection_specific_smtp_edit_window_set_connection),
3505 (modest_connection_specific_smtp_edit_window_get_settings):
3506 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3509 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3512 * src/maemo/easysetup/modest-easysetup-wizard.c:
3513 (create_page_custom_outgoing), (create_page_complete_custom):
3514 * src/maemo/modest-account-settings-dialog.c:
3515 (create_page_user_details), (create_page_outgoing):
3516 * src/maemo/modest-account-view-window.c: (button_box_new):
3517 Use changed logical IDs as per the most recent UI spec:
3518 mcen_bd_emailsetup_edit -> mcen_bd_edit
3519 mcen_bd_emailsetup_delete -> mcen_bd_delete
3520 mcen_bd_emailsetup_close -> mcen_bd_close
3522 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3526 * src/dbus_api/Makefile.am:
3527 * src/dbus_api/modest-dbus-callbacks.c:
3528 * src/dbus_api/modest-dbus-callbacks.h:
3529 * src/maemo/modest-platform.c: (modest_platform_init):
3530 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3532 * tests/Makefile.am:
3533 * tests/dbus_api/Makefile.am:
3534 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3536 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3538 * src/maemo/modest-account-settings-dialog.c:
3539 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3540 Removed unnecessary includes.
3542 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3544 * src/maemo/easysetup/modest-easysetup-wizard.c:
3545 * src/maemo/modest-account-settings-dialog.c:
3546 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3547 * src/widgets/Makefile.am:
3548 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3549 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3550 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3551 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3552 * src/widgets/modest-secureauth-combo-box.c:
3553 * src/widgets/modest-secureauth-combo-box.h:
3554 * src/widgets/modest-serversecurity-combo-box.c:
3555 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3556 made the GObject names more consistent with the rest of the Modest code.
3558 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3560 * src/maemo/easysetup/Makefile.am:
3561 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3562 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3563 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3564 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3565 * src/maemo/easysetup/modest-easysetup-wizard.c:
3566 * src/maemo/easysetup/modest-validating-entry.c:
3567 * src/maemo/easysetup/modest-validating-entry.h:
3568 * src/maemo/modest-account-settings-dialog.c:
3569 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3570 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3571 widgets/ because they are used outside of easysetup too. After checking in,
3572 svn will allow me to rename them too.
3574 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3576 * src/gnome/modest-msg-edit-window.c:
3577 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3578 linker error, to fix the build on the GNOME platform.
3579 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3580 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3581 ifdefed out to avoid a warning.
3583 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3585 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3586 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3587 some alternative for GTK+ 2.6.
3589 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3591 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3593 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3594 specified for EmailAccountsDialog in UI spec.
3596 * src/maemo/easysetup/modest-easysetup-wizard.c:
3597 * src/maemo/easysetup/modest-easysetup-wizard.h:
3598 * src/maemo/modest-account-settings-dialog.c:
3599 * src/maemo/modest-account-settings-dialog.h:
3600 Reuse a member window widget for the connection-specific SMTP server accounts,
3601 so we can tell it to create/save the accounts only if we actually save changes.
3603 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3604 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3605 (modest_connection_specific_smtp_edit_window_get_settings):
3606 Return a struct instance for temporarily remembering the entered data.
3608 * src/maemo/modest-connection-specific-smtp-window.h:
3609 * src/maemo/modest-connection-specific-smtp-window.c:
3610 (modest_connection_specific_smtp_window_finalize),
3611 (modest_connection_specific_smtp_window_fill_with_connections),
3613 (modest_connection_specific_smtp_window_save_server_accounts),
3614 (update_model_server_names): Do not actually save data until asked,
3615 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3617 (on_selection_changed),
3618 (modest_connection_specific_smtp_window_init): Disable the edit
3619 button when nothing is selected.
3621 * src/modest-account-mgr-helpers.c:
3622 * src/modest-account-mgr-helpers.h:
3623 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3626 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3628 * src/modest-account-mgr-helpers.h:
3629 * src/modest-account-mgr-helpers.c:
3630 (modest_account_mgr_get_unused_account_name),
3631 (modest_account_mgr_get_unused_account_display_name): Added these
3632 utility functions, to avoid code duplication.
3634 * src/maemo/easysetup/modest-easysetup-wizard.c:
3635 (create_page_account_details), (create_account):
3636 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3637 (on_combo_security_changed),
3638 (modest_connection_specific_smtp_edit_window_init),
3639 (modest_connection_specific_smtp_edit_window_save_settings):
3640 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3641 * src/maemo/modest-connection-specific-smtp-window.c:
3642 (modest_connection_specific_smtp_window_finalize),
3643 (modest_connection_specific_smtp_window_fill_with_connections),
3644 (on_button_edit), (modest_connection_specific_smtp_window_init):
3645 * src/maemo/modest-connection-specific-smtp-window.h:
3646 Implementing saving of connection-specific server accounts.
3648 But I need to refactor this so we can save the data for each
3649 possible connection-specific account and only actually create the server accounts
3650 when the easysetup finished, or the OK button is pressed on the account settings
3653 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3655 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3656 (on_combo_security_changed):
3657 (modest_connection_specific_smtp_edit_window_init):
3658 Auto-fill the port number as in the account settings.
3660 (modest_connection_specific_smtp_edit_window_set_connection):
3661 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3662 * src/maemo/modest-connection-specific-smtp-window.c:
3663 (fill_with_connections), (on_button_edit),
3664 (modest_connection_specific_smtp_window_init):
3665 Turn the edit window into a dialog to simplify the code, and
3666 set a WM hint as in a GtkDialog, because only a popup can be on top of
3667 another window in Maemo, and popups usually have no WM decoration.
3669 * src/modest-defs.h:
3670 * src/modest-account-mgr-helpers.c:
3671 (modest_account_mgr_set_connection_specific_smtp),
3672 (modest_account_mgr_remove_connection_specific_smtp),
3673 (modest_account_mgr_get_connection_specific_smtp):
3674 * src/modest-account-mgr-helpers.h: Some functions to write the
3675 connection-specific SMTP server information. Not yet used.
3678 * src/widgets/modest-folder-view.c: (text_cell_data):
3679 Fix a warning about an uninitialized variable.
3680 (on_configuration_key_changed): Put an #ifdef around the use
3681 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3683 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3685 * src/maemo/modest-account-settings-dialog.h:
3686 * src/maemo/modest-account-settings-dialog.c:
3687 Added connect_for_modified() utility function to mark the new modified boolean.
3689 (create_page_account_details), (create_page_user_details),
3690 (create_page_incoming), (create_page_outgoing), (on_response),
3691 (modest_account_settings_dialog_init),
3692 (modest_account_settings_dialog_set_account_name):
3693 Only warn about unsaved changes when there are actually unsaved changes.
3695 * src/modest-account-mgr-helpers.c:
3696 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3697 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3698 to get the data from there in future.
3700 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3702 * src/modest-defs.h:
3704 * src/modest-account-mgr-helpers.h:
3705 * src/modest-account-mgr-helpers.c:
3706 Store the security account setting in a single conf key instead of using
3707 the options list, so that the list is left for just the to-be-removed camel hack,
3708 and because gconf_client_set_list() is failing for some reason.
3710 * src/modest-account-mgr.c:
3711 (modest_account_mgr_add_server_account):
3712 * src/maemo/modest-account-settings-dialog.c:
3713 (modest_account_settings_dialog_set_account_name),
3714 (save_configuration): Use the renamed functions.
3717 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3719 * src/widgets/Makefile.am:
3720 * src/widgets/modest-limit-retrieve-combo-box.c:
3721 * src/widgets/modest-limit-retrieve-combo-box.h:
3722 * src/widgets/modest-retrieve-combo-box.c:
3723 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3724 the account settings dialog.
3726 * src/modest-defs.h:
3727 * src/modest-account-mgr-helpers.h:
3728 * src/modest-account-mgr-helpers.c:
3729 (modest_server_account_get_option_secure_auth),
3730 (modest_server_account_set_option_secure_auth):
3731 * src/modest-account-mgr.c:
3732 (modest_account_mgr_add_server_account):
3733 Use the existing AUTH_MECH conf key for the secure-auth setting,
3734 instead of putting it in the list options, because this was actually used already.
3736 * src/maemo/modest-account-settings-dialog.c:
3737 (create_page_account_details),
3738 (modest_account_settings_dialog_set_account_name),
3739 (save_configuration):
3740 * src/maemo/modest-account-settings-dialog.h:
3741 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3742 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3744 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3747 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3748 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3750 * src/modest-defs.h:
3751 * src/maemo/modest-account-settings-dialog.c:
3752 (create_page_incoming), (on_combo_outgoing_security_changed),
3753 (on_combo_incoming_security_changed), (create_page_outgoing),
3754 (modest_account_settings_dialog_set_account_name),
3755 (save_configuration): Load/Save the port number, and change it when the
3756 security combo changes, to suitable defaults.
3758 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3760 * src/modest-account-mgr.c:
3761 (modest_account_mgr_add_server_account): Set the security and secure-auth
3762 options, and add a comment saying that the other camel-specific options should be
3765 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3767 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3769 * src/modest-tny-account-store.c: (account_list_free),
3770 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3771 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3774 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3776 * src/modest-protocol-info.c:
3777 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3778 is required by our UI spec. Maybe something in our implementation will use this eventually.
3779 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3780 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3781 instead of the previous 0 placeholder.
3783 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3784 secure-auth settings.
3785 * src/modest-account-mgr-helpers.h:
3786 * src/modest-account-mgr-helpers.c:
3787 (modest_server_account_data_get_option_secure_auth),
3788 (modest_server_account_set_option_secure_auth),
3789 (modest_server_account_data_get_option_security),
3790 (modest_server_account_set_option_security): Added this API for getting and setting the security
3791 and secure-auth settings.
3793 * src/maemo/modest-account-settings-dialog.h:
3794 * src/maemo/modest-account-settings-dialog.c:
3795 (modest_account_settings_dialog_finalize), (check_data),
3796 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3797 about changing titles.
3798 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3799 (save_configuration): Save the security and secure-auth settings.
3801 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3802 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3804 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3806 * src/modest-defs.h:
3807 * src/modest-account-mgr.c:
3808 (modest_account_mgr_add_server_account):
3809 Added and used defines for the options key and value pair strings,
3810 that are used so far, though they do not seem to correspond to anything in our
3811 UI specs or ModestProtocol enum.
3813 * src/modest-account-mgr-helpers.h:
3814 * src/modest-account-mgr-helpers.c:
3815 (compare_option_strings_for_name),
3816 (modest_server_account_data_get_option_value),
3817 (modest_server_account_data_get_option_bool),
3818 (modest_account_mgr_get_server_account_option):
3819 Added helper functions for parsing the options GSList.
3821 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3823 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3824 display name is based on the supplied account name.
3825 * src/modest-account-mgr.c:
3826 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3827 with an inefficient, but good-enough, implementation.
3829 * src/maemo/easysetup/modest-easysetup-wizard.c:
3830 (create_page_account_details), (on_before_next), (create_account):
3831 Check for existing display names rather than (non-user-visible) account names, and just
3832 create and set a unique account name at the end.
3834 * src/maemo/modest-account-settings-dialog.c:
3835 (modest_account_settings_dialog_init),
3836 (modest_account_settings_dialog_set_account_name),
3837 (create_page_incoming): Show the display name, instead of the account name.
3838 (on_response): Do some (not all) extra checks, as in the UI spec.
3839 (save_configuration): Save the display name if it was changed.
3841 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3843 * po/en_GB.po: Added needed logical ID and translation.
3844 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3845 (init_view): Made the is-default column clicking work.
3847 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3850 * src/maemo/easysetup/Makefile.am:
3851 * src/maemo/easysetup/modest-easysetup-wizard.c:
3852 (modest_easysetup_wizard_dialog_init):
3853 * src/maemo/easysetup/provider-data-test.keyfile:
3854 * src/maemo/easysetup/provider-data.keyfile:
3855 Moved the provider data file to the new modest-providers-data package and used it from there.
3857 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3859 * src/modest-local-folder-info.c:
3860 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3861 N_() was already used on the static strings, but this just marks it for translation without
3862 using the translation.
3864 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3866 * src/maemo/modest-account-settings-dialog.c:
3867 (create_page_incoming),
3868 (modest_account_settings_dialog_set_account_name):
3869 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3870 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3871 I will do this if nobody else gets there first.
3873 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3875 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3876 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3877 save the security stuff.
3879 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3881 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3882 Set the email address and user fullname, which I now see must be
3885 * src/maemo/modest-account-settings-dialog.h:
3886 * src/maemo/modest-account-settings-dialog.c:
3888 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3889 leave-on-server and authentication.
3890 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3893 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3896 * src/maemo/modest-account-settings-dialog.c:
3897 * src/maemo/modest-account-settings-dialog.h:
3898 Most (but not all) of the widgets are now present as specified by the UI spec.
3899 No changes are yet saved, and some details are not properly shown yet.
3901 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3903 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3905 * src/maemo/Makefile.am:
3906 * src/maemo/modest-account-settings-dialog.c:
3907 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3908 an existing account. Doesn't do much yet.
3910 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3911 Open the accounts settings dialog when Edit is clicked.
3913 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3915 * src/maemo/easysetup/Makefile.am:
3916 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3918 * src/maemo/easysetup/modest-easysetup-wizard.c:
3919 (modest_easysetup_wizard_dialog_init):
3920 Try to get the source directory from the build system,
3921 instead of hard-coding "./" into the source code, when opening our local
3922 copies of the configuration files.
3923 But this still fails when opening the wizard from the Accounts window,
3924 maybe because the working directory seems to change at runtime.
3925 So the wizard will fail the second time unless you copy the files into their
3926 proper locations - see the stdout warnings for the paths.
3928 (create_page_account_details),(on_before_next):
3929 Check for existing non-server accounts instead of server accounts,
3930 so the default account name is useful again, and to prevent trying to
3933 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3934 Show the wizard when New is clicked.
3936 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3937 (init_view): Show the column headers, and show the columns that are
3938 specified in the UI specs. However, something in Maemo's GTK+ prevents
3939 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3940 change the default account. This is despite unsetting the special properties.
3942 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3944 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3945 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3946 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3947 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3948 to make that clearer.
3949 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3951 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3953 * src/maemo/modest-account-view-window.c:
3954 (modest_account_view_window_init),
3955 (modest_account_view_window_new):
3956 Use the same buttons as specified in the
3957 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3958 the existing widgets, which never had a chance of working.
3959 Put the ModestAccountView treeview in a scrolled window.
3960 Do not repeat the initialization in both _init() and _new().
3962 * src/widgets/modest-account-view.c: (update_account_view):
3963 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3964 this widget and window shows no accounts.
3966 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3968 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3970 * src/maemo/easysetup/modest-easysetup-wizard.c:
3971 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3972 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3973 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3976 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3977 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3978 accounts exist yet, as in the UI spec.
3980 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3982 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/Makefile.am:
3985 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3986 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3987 New window for editing connection-specific smtp details.
3988 Not fully implemented.
3990 * src/maemo/modest-connection-specific-smtp-window.c:
3991 (modest_connection_specific_smtp_window_finalize) :
3992 unref the tree model.
3993 (on_button_edit): Show the edit window.
3995 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3997 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4000 * src/maemo/Makefile.am:
4001 * src/maemo/modest-connection-specific-smtp-window.c:
4002 * src/maemo/modest-connection-specific-smtp-window.h:
4003 New window for showing the list of connections, for connection-specific
4004 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4005 * src/maemo/easysetup/modest-easysetup-wizard.c:
4006 (create_page_custom_outgoing): Show the new window when the button is clicked.
4008 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4010 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4011 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4012 * src/maemo/modest-msg-edit-window.c:
4013 (modest_msg_edit_window_insert_image):
4014 * src/modest-conf.c: (modest_conf_key_escape):
4015 * src/modest-mail-operation.c:
4016 (modest_mail_operation_send_new_mail):
4017 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4018 (modest_ui_actions_on_new_account):
4019 * src/widgets/modest-attachment-view.c: (update_filename_request):
4020 * src/widgets/modest-mail-header-view.c:
4021 Corrected warnings that were breaking the build, by commenting out unused variables,
4022 and a function, and by including a header.
4024 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4026 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4027 so we can #ifdef around platform-specific code when necessary.
4028 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4029 to allow this to build for the GNOME platform too.
4031 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4033 * src/maemo/easysetup/modest-easysetup-wizard.c:
4034 Added util_increment_name() and used it in create_page_account_details()
4035 to make sure that the default account name is always a new name.
4037 (modest_easysetup_wizard_dialog_init),
4038 (set_default_custom_servernames): Some minor memory management fixes.
4040 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4044 * src/modest-runtime.c: (init_i18n): Restored the translation
4045 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4046 are defined in config.h, and the translations are installed.
4048 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4049 is defined for translation.
4051 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4053 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4055 * src/maemo/easysetup/modest-easysetup-wizard.c:
4056 (modest_easysetup_wizard_dialog_init):
4057 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4058 Use realistic paths (though they should use $prefix generically) to the
4059 mcc_mapping and provider-data.keyfile files which might work when they
4060 are installed by the future version of the operator-wizard package,
4061 and then fallback to paths in our source code, with an explanatory
4064 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4068 * src/maemo/Makefile.am:
4069 * src/maemo/easysetup/: Added files from the previously-exernal
4070 osso-modest-easysetup.
4071 * src/maemo/modest-main-window-ui.h:
4072 * src/modest-ui-actions.c:
4073 * src/modest-ui-actions.h:
4074 Added modest_ui_actions_on_new_account() as a signal handler for the
4075 New Account menu item. It shows the easysetup wizard.
4076 * po/en_GB.po: Added additional needed logical IDs and translations.