1 2007-07-26 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (recreate_all_accounts):
4 Recreate them even if they were NULL before. I guess something
5 else was already creating them before, or this would never
7 (modest_tny_account_store_get_server_account): Make sure that
8 the tny accounts have been created before trying to find one.
9 This allows libmodest_dbus_client_compose_mail() to work
10 when the UI is not yet visible.
11 This is probably useful in other cases too.
13 (get_password): When the password is wrong after it is entered
14 in the protected password dialog, show an info banner (in an
15 idle handler) before showing the protected password dialog
18 2007-07-26 Murray Cumming <murrayc@murrayc.com>
20 * src/modest-ui-actions.h:
21 * src/modest-ui-actions.c: Added
22 modest_do_refresh_current_folder() containing some code from
23 modest_ui_actions_on_send_receive().
24 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
25 Call modest_do_refresh_current_folder() before refreshing the
26 requested account, as in modest_ui_actions_on_send_receive().
27 This is strange, but seems to be necessary to show new mails.
28 Now new emails are finally visible in the UI when downloaded
29 via the automatic update interval, fixing bug NB#57458.
30 This also works because bug NB#57458 has been fixed somehow.
32 2007-07-26 Murray Cumming <murrayc@murrayc.com>
34 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
35 printf more details when we get unhandled D-Bus methods, because
38 * src/modest-mail-operation.c: (update_account_thread):
39 Comment out the tny_camel_pop_store_account_reconnect(), because this
40 is apparently no longer needed, and it did not work before anyway.
41 See the comment in the code.
43 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
44 by checking the header flags. This fixes projects.maemo.org bug
47 2007-07-25 Murray Cumming <murrayc@murrayc.com>
49 * src/maemo/modest-maemo-utils.h:
50 * src/maemo/modest-maemo-utils.c: Added
51 modest_maemo_show_information_note_in_main_context_and_forget().
52 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
53 Use the new function to show simple error dialogs in the main
54 context, though question dialogs are still in the current context,
55 which is unfortunately usually not the main context. This should
58 2007-07-25 Murray Cumming <murrayc@murrayc.com>
60 * src/modest-tny-account-store.c: (get_password):
61 Never save the entered username and password in gconf,
62 because the UI spec says we should not. This helps
63 slightly with projects.maemo.org bug NB#63671.
65 2007-07-25 Murray Cumming <murrayc@murrayc.com>
67 * src/widgets/modest-msg-edit-window.h:
68 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
69 Moved some code here to make it simpler.
70 (modest_msg_edit_window_attach_file_one): Renamed from
71 modest_msg_edit_window_attach_file_interactive().
72 (modest_msg_edit_window_offer_attach_file): Renamed from
73 modest_msg_edit_window_attach_file() and used
74 modest_msg_edit_window_attach_file_one() instead of
75 copy/pasting the code. The old code for one was not using
76 GnomeVFS. This allows use of smb:// URLs when using send-as
77 from external applications, fixing bug NB#63741.
79 (modest_msg_edit_window_insert_image),
80 (modest_msg_edit_window_add_attachment_clicked):
81 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
82 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
83 Adapted to the new function names.
85 2007-07-25 Murray Cumming <murrayc@murrayc.com>
87 (modest_platform_set_update_interval): Set the alarm recurrence
88 fields so that auto-update does not just happen the first time.
89 This should have fixed projects.maemo.org bug NB#63938.
91 When this happens you can see a printf when the D-Bus method is
93 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
95 However, I do not actually seem to get new POP messages even when
96 clicking the refresh button manually. A restart gets them.
97 This might be a problem in today's tinymail only.
99 2007-07-24 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/modest-maemo-global-settings-dialog.c:
102 (current_connection):
103 Avoid a crash (probably only in scratchbox) when strcmp()ing a
104 NULL when closing the dialog.
106 2007-07-24 Murray Cumming <murrayc@murrayc.com>
108 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
109 Remove the hacky send/receive that didn't work, and instead
110 refilter the treemodel to make the deleted email really vanish from
111 the UI (though the delete-from-menu code does has commented out
112 the code that does that). This fixes projects.maemo.org bug
115 2007-07-24 Murray Cumming <murrayc@murrayc.com>
117 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
118 Try a couple of tricks to force the treeview to update (
119 poke the folder, and do a send/receive refresh), but the deleted
120 email still appears with a strike-through instead of really being
123 2007-07-23 Murray Cumming <murrayc@murrayc.com>
125 * src/dbus_api/modest-dbus-callbacks.c:
126 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
127 because their ID is not human-readable (see the comment about
128 improvements needed to the osso-email-interface API) and
129 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
131 2007-07-23 Murray Cumming <murrayc@murrayc.com>
133 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
134 (add_folders_to_list), (on_dbus_method_get_folders),
135 (modest_dbus_req_filter):
136 * src/maemo/modest-maemo-utils.c:
137 (on_camel_account_get_supported_secure_authentication):
138 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
139 (on_header_view_focus_in):
140 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
141 * src/modest-formatter.c: (modest_formatter_create_body_part):
142 * src/modest-mail-operation.c: (recurse_folders),
143 (update_account_thread), (get_msgs_full_thread),
144 (modest_mail_operation_get_msgs_full),
145 (modest_mail_operation_xfer_msgs):
146 * src/modest-search.c: (search_mime_part_and_child_parts),
147 (modest_search_account), (modest_search_all_accounts):
148 * src/modest-tny-account.c:
149 (modest_tny_account_get_special_folder), (recurse_folders):
150 * src/modest-tny-local-folders-account.c:
151 (modest_tny_local_folders_account_query_passes):
152 * src/modest-tny-msg.c: (copy_mime_part),
153 (modest_tny_msg_find_body_part_from_mime_part):
154 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
155 (modest_tny_send_queue_try_to_send):
156 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
157 (_modest_ui_actions_open), (download_uncached_messages),
158 (reply_forward), (modest_ui_actions_on_copy),
159 (modest_ui_actions_on_details), (has_retrieved_msgs),
160 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
162 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
163 (_selected_msg_marked_as), (_msg_download_completed),
164 (_selected_msg_sent_in_progress):
165 * src/widgets/modest-attachments-view.c:
166 (modest_attachments_view_set_message):
167 * src/widgets/modest-msg-view.c: (find_cid_image):
168 * tests/check_folder-transfer.c: (find_folders):
169 * tests/check_update-account.c: (func):
170 * tests/dbus_api/test_get_folders.c: (main):
171 Checked all uses of tny_iterator_get_current(), making sure
172 that the object is unreferenced (3 or 4 places did not),
173 and adding checks for NULL.
175 2007-07-23 Murray Cumming <murrayc@murrayc.com>
177 * src/dbus_api/modest-dbus-callbacks.c:
178 (on_idle_open_default_inbox): Make sure that the application UI is
180 * src/maemo/easysetup/modest-easysetup-wizard.c:
181 (on_entry_invalid_character): Show the word whitespace instead
182 of (null) in the banner when whitespace was entered.
183 (show_error): Add a comment that this does not work in
184 Maemo Bora, though we do not know why.
186 2007-07-23 Murray Cumming <murrayc@murrayc.com>
188 * src/modest-tny-account.c:
189 (modest_tny_account_get_special_folder): Use an if instead of
190 an assert for when the parent account name is NULL, because this
191 might be causing a crash in projects.maemo.org bug 63192.
192 * src/modest-mail-operation.c:
193 (modest_mail_operation_send_new_mail_cb),
194 (modest_mail_operation_remove_folder): unref the folder that is
195 returned from modest_tny_account_get_special_folder().
197 2007-07-23 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-ui-actions.c:
200 (modest_ui_actions_on_password_requested):
201 Show mail_ib_login_cancelled info banner when the user cancels
202 the protected password dialog, to fix projects.maemo.org
205 2007-07-23 Murray Cumming <murrayc@murrayc.com>
207 * src/maemo/modest-account-settings-dialog.c:
208 (create_page_outgoing): Put this page in a GtkScrolledWindow,
209 matching the UI mock-up in the UI spec, and allowing access
210 to all widgets even when the on-screen keyboard is active.
212 2007-07-23 Murray Cumming <murrayc@murrayc.com>
214 Reverted this previous commit from Johannes,
215 because the scrollbars are always visible and because
216 I think we only need it on onepage of the account
217 settings, not the account wizard.
218 (I wrote the wrong instructions in the bug.)
220 * src/maemo/easysetup/modest-easysetup-wizard.c:
221 Added scrollbars to account wizard dialog.
222 Fixed projects.maemo.org NB #62744
224 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
226 * src/maemo/easysetup/modest-easysetup-wizard.c:
227 (create_page_user_details):
228 Use auto-cap for name (projects.maemo.org NB#63716)
229 * src/widgets/modest-account-view.c: (on_account_busy_changed):
231 2007-07-22 Armin Burgmeier <armin@openismus.com>
233 * src/maemo/modest-ui-actions.c: Use current account instead of
234 default account for creating viewer windows, so that the viewer
235 window knows to which account the viewed message belongs.
237 * src/maemo/modest-msg-view-window.c: Destroy the window when the
238 corresponding account is deleted. This fixes projects.maemo.org bug
241 2007-07-18 Armin Burgmeier <armin@openismus.com>
243 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
244 the dialog close after entering an invalid port number and clicking
245 OK. This fixes projects.maemo.org bug NB#63602.
247 2007-07-18 Armin Burgmeier <armin@openismus.com>
249 * src/modest-tny-account-store.c:
250 (get_server_accounts): Set parent modest account name for each
251 connection-specific transport account so that special folders of such
252 an account can be looked up. This fixes a crash when changing account
253 settings. This might also be related to projects.maemo.org bug
256 2007-07-16 Armin Burgmeier <armin@openismus.com>
258 * src/modest-ui-actions.c: Added a button to create a folder to the
259 move-to dialog. This fixes projects.maemo.org bug NB#.
261 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
263 * src/maemo/easysetup/modest-easysetup-wizard.c:
264 Added scrollbars to account wizard dialog.
265 Fixed projects.maemo.org NB #62744
267 2007-07-16 Murray Cumming <murrayc@murrayc.com>
269 * src/widgets/modest-msg-view.h:
270 * src/widgets/modest-msg-view.c:
271 Added modest_msg_view_get_message_is_empty() but this needs
273 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
274 Check if there is any text in the message yet.
275 But this needs to be implemented properly.
276 (modest_msg_edit_window_toggle_find_toolbar):
277 * src/maemo/modest-msg-view-window.c:
278 (modest_msg_view_window_toggle_find_toolbar):
279 Show a banner warning if there is no text to search, when
280 trying to start a search. This partially fixes
281 projects.maemo.org bug NB#62350.
283 2007-07-13 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-mail-operation.c: (update_account_thread):
286 Initialized num_new_headers to fix the build.
288 2007-07-13 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
291 Ignore modest accounts whose server accounts don't exist in gconf.
292 This prevents us trying to create TnyAccount instances for those
293 server accounts when the server account has been removed from gconf,
294 but the parent modest account has not yet been removed from modest.
295 I don't know why this is only noticeable now. It was probably just
296 a harmeless g_warning() anyway.
298 2007-07-13 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
301 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
303 2007-07-12 Armin Burgmeier <armin@openismus.com>
305 * src/maemo/modest-main-window.c: Make default account appear bold
306 in view, tools/send & receive and toolbar/send & receive SCM menus.
307 This fixes projects.maemo.org bug NB#59010.
309 2007-07-12 Murray Cumming <murrayc@murrayc.com>
311 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
312 Add a short-cut, by checking if the folder store is an account.
313 This ensures that the Sort menu item and toolbar is dimmed for
314 the local-folders account root item, fixing
315 projects.maemo.org bug NB#62545.
317 2007-07-12 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-tny-account-store.c: (get_password):
320 Show the password dialog (via the signal) only in the mainloop, via
321 an idle handler that we wait for. This could theoretically prevent
322 hangs, though I worry that it could introduce some too.
324 2007-07-12 Murray Cumming <murrayc@murrayc.com>
326 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
327 * src/maemo/modest-platform.c:
328 (modest_platform_connect_and_wait):
329 Take a TnyAccount* parameter and try to set it to online
330 (a TnyCamel-only API), because tinymail sets accounts to offline
331 when the user cancels a password dialog, and doesn't ask again until
332 it has been set to online.
333 However, this is commented out because it causes a hang now.
335 (modest_platform_connect_and_wait_if_network_account):
336 * src/modest-mail-operation.c:
337 (modest_mail_operation_update_account):
338 * src/modest-platform.h:
339 * src/modest-ui-actions.c: (_modest_ui_actions_open),
340 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
342 2007-07-12 Armin Burgmeier <armin@openismus.com>
344 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
346 * src/modest-mail-operation.c:
347 * src/modest-ui-actions.c: Check for already existing folder before
348 querying the server, show error message from camel if the request
349 still fails. This fixes projects.maemo.org bug NB#58701.
351 2007-07-12 Murray Cumming <murrayc@murrayc.com>
353 * src/modest-tny-account-store.h:
354 * src/modest-tny-account-store.c:
355 Added modest_tny_account_store_forget_password_in_memory(),
356 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
357 when creating a new account, so that new passwords will be used, instead of
358 us thinking that it's a second request as a result of a failed password again.
360 2007-07-12 Murray Cumming <murrayc@murrayc.com>
362 * src/dbus_api/modest-dbus-callbacks.c:
363 (on_idle_open_message): If the message is in drafts then open it
364 in an edit window instead of a view window. This fixes
365 projects.maemo.org bug NB#63005.
367 2007-07-12 Murray Cumming <murrayc@murrayc.com>
369 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
370 Avoided a harmless g_warning().
372 2007-07-12 Murray Cumming <murrayc@murrayc.com>
374 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
375 Pass the modest account name, not the TnyAccount display name to
376 modest_msg_view_window_new() so that the reply feature works,
377 fixing projects.maemo.org bug NB#62892.
379 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
380 (modest_msg_view_window_new_with_header_model):
381 * src/maemo/modest-msg-view-window.c:
382 (modest_msg_view_window_new_with_header_model),
383 (modest_msg_view_window_new):
384 * src/modest-ui-actions.c: (reply_forward):
385 * src/widgets/modest-msg-view-window.h:
386 * src/widgets/modest-window.c: (modest_window_set_active_account):
387 Rename an account parameter to modest_account_name to make this clearer.
389 2007-07-11 Murray Cumming <murrayc@murrayc.com>
391 * src/modest-ui-actions.h:
392 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
393 modest_do_message_delete().
394 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
395 Call modest_do_message_delete(), hoping that this would cause messages
396 to be really deleted from search instead of just marked with strike through.
397 Does not seem to help.
399 2007-07-11 Armin Burgmeier <armin@openismus.com>
401 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
402 priv->reselect to FALSE prior to calling
403 modest_folder_view_select_first_inbox_or_local() to prevent endless
404 recursion and thus a crash on startup.
406 2007-07-11 Armin Burgmeier <armin@openismus.com>
408 * src/maemo/modest-account-settings-dialog.h: Include
409 <gtk/gtknotebook.h> to fix the build (at least for me).
411 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
412 Use "New FolderN" as default suggested name if "New folder" already
413 exists, with N being the first free number, though never exceed "New
414 folder99" in which case we just fall back to "New Folder" even though
415 it already exists. This fixes projects.maemo.org bug NB#58663.
417 2007-07-11 Murray Cumming <murrayc@murrayc.com>
419 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
420 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
421 projects.maemo.org bug NB#62778.
423 2007-07-11 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
426 Ignore the wrong (for now) secure-smtp setting in the presets -
427 just default to requiring secure authentication for SMTP, because
430 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
432 * src/widgets/modest-folder-view.c: (filter_row)
433 Do not show drafts folder (see UI specs)
435 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
437 * src/modest-ui-actions.c:
438 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
439 place and also not necessary.
441 * src/widgets/modest-folder-view.c: (filter_row)
442 Guess folder type and hide Sent & Outbox if necessary.
443 Fixed project.maemo.org NB#57328
445 2007-07-11 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-ui-actions.h:
448 * src/modest-ui-actions.c:
449 (modest_ui_actions_on_delete_message):
450 Move some code into a new
451 modest_ui_actions_refresh_message_window_after_delete()
452 function so we can use it from elsewhere.
454 * src/dbus_api/modest-dbus-callbacks.c:
455 (on_idle_delete_message), (on_delete_message): Used an idle
456 handler, as we do for the other D-Bus method handlers.
457 Call modest_ui_actions_refresh_message_window_after_delete()
458 if the deleted message was open in a window. This fixed
459 projects.maemo.org bug NB#62862.
461 2007-07-11 Murray Cumming <murrayc@murrayc.com>
463 * src/modest-main.c: (main): Only show the UI at the start if
464 the showui command line option was given. For instance,
465 run-standalone src/modest showui
466 Otherwise, we wait for the top_application D-Bus method to
467 be sent by hildon-desktop when the application is selected
469 This allows us to run without a UI when osso-global-search
470 uses our D-Bus methods.
472 2007-07-11 Murray Cumming <murrayc@murrayc.com>
474 * src/dbus_api/modest-dbus-api.h: Added a define for a
475 top-application D-Bus method.
476 * src/dbus_api/modest-dbus-callbacks.c:
477 (on_top_application),
478 (modest_dbus_req_handler): Handle the top-application D-Bus
479 method, which might be an undocumented D-Bus signal sent by
480 hildon-desktop when it starts the application from the menu.
481 But I am not sure and I need to test it on the device, because
482 my scratchbox does not have the application in the menu now.
483 This method shows the main window, so that it can be invisible
484 when started, for instance, just for email searching from
487 * src/maemo/modest-main-window.c: (restore_settings),
488 (modest_main_window_new): Do not show the window immediately
489 upon creation. We show it later.
490 * src/modest-widget-memory.c: (save_settings_paned):
491 Try (unsuccessfully) to avoid saving the paned position when
492 it is not even visible.
493 (restore_settings_paned): Do not allow a silly paned position.
494 This seems necessary when not showing the window at first.
496 * tests/dbus_api/Makefile.am:
497 * tests/dbus_api/test_top_application.c: (main): Test for the
500 2007-07-10 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-ui-dimming-rules.c:
503 (modest_ui_dimming_rules_on_new_msg),
504 (modest_ui_dimming_rules_on_reply_msg),
505 (modest_ui_dimming_rules_on_delete_msg),
506 (modest_ui_dimming_rules_on_details),
507 (modest_ui_dimming_rules_on_view_window_move_to),
508 (modest_ui_dimming_rules_on_view_previous),
509 (modest_ui_dimming_rules_on_view_next),
510 (_invalid_folder_for_purge): Added checks before
511 casting the window. This looks like an actual
512 logic error in _invalid_folder_for_purge(), because it
513 tries to use a ModestMainWindow as a message window.
515 2007-07-10 Murray Cumming <murrayc@murrayc.com>
517 * src/maemo/modest-account-settings-dialog.c:
518 (show_error): Use the same implementation as in
519 modest-easysetup-wizard.c:
520 (on_entry_invalid_character): The logical ID contains a %s.
521 Guessed what it should be.
522 (on_entry_max), (check_data), (on_response): Adapt to
523 changed show_error().
524 (create_page_account_details): Really call
525 modest_validating_entry_set_func() on the correct widgets.
526 * src/maemo/easysetup/modest-easysetup-wizard.c:
527 (on_entry_invalid_character): Fix the logical ID here too.
528 (create_page_account_details),
529 (create_page_user_details):
531 modest_validating_entry_set_func() on the correct widgets.
533 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
534 Do not try to use the account if it is NULL.
536 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
538 * src/modest-ui-actions.c: (create_move_to_dialog),
539 (modest_ui_actions_on_main_window_move_to),
540 (modest_ui_actions_on_msg_view_window_move_to):
541 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
542 (filter_row), (modest_folder_view_show_non_move_folders):
543 * src/widgets/modest-folder-view.h:
545 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
546 the Sent folder yet as it does not report the correct folder type.
548 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
550 * src/maemo/modest-msg-edit-window.c: (init_window):
553 2007-07-10 Murray Cumming <murrayc@murrayc.com>
555 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
556 Take a parent widget instead of a parent window, and
557 implement this with hildon_banner_show_information() instead.
558 Non-Maemo builds can just ifdef that there.
559 This fixed projects.maemo.org bug NB#62766.
561 (on_entry_invalid_character): Use show_error() again instead
562 of using hildon directly, and use the _CS() macro to use the correct
564 (create_account), (check_for_supported_auth_methods), (on_entry_max):
565 Pass a widget instead od a window to show_error().
567 2007-07-10 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
570 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
571 This allows us to show the server name in the error message, fixing
572 projects.maemo.org bug NB#62904.
573 Also, use the appropriate logical ID message for the account protocol.
575 2007-07-10 Murray Cumming <murrayc@murrayc.com>
577 * src/modest-tny-account-store.c: (on_idle_wrong_password):
578 A compilation fix, though the build wasn't broken for me.
580 2007-07-09 Murray Cumming <murrayc@murrayc.com>
582 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
583 Do not try to unref a NULL folder store, to avoid a runtime warning.
584 This seems to happen sometimes when changing accounts settings.
586 2007-07-09 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-tny-account-store.c:
589 (modest_tny_account_store_instance_init),
590 (modest_tny_account_store_finalize),
591 (on_account_settings_hide), (on_idle_wrong_password):
592 Use a GHashTable to ensure that we only show one account settings
593 dialog per modest account. This avoids us having a dialog open for
594 both the store and transport accounts, or due to repeated get_password()
595 calls that shouldn't happen anyway.
597 2007-07-09 Murray Cumming <murrayc@murrayc.com>
599 * src/maemo/modest-maemo-utils.c: (on_hide),
600 (modest_maemo_show_dialog_and_forget): Handle the response, because
601 the window is not even hidden by default.
603 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
604 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
605 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
606 which seems to prevent some modality problems.
608 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
609 Ignore user cancellation errors.
611 * src/modest-account-mgr-helpers.h:
612 * src/modest-account-mgr-helpers.c:
613 Added modest_server_account_get_password() and
614 modest_server_account_get_has_password() to avoid direct use of
617 * src/maemo/modest-account-settings-dialog.h:
618 * src/maemo/modest-account-settings-dialog.c:
619 (modest_account_settings_dialog_init): Store the notebook so we can
621 Added modest_account_settings_dialog_switch_to_user_info().
623 * src/modest-tny-account-store.c:
624 (get_password): When the password in the account settings is wrong (we think),
625 show the relevant page of the account settings dialog, in the mainloop.
626 However, we currently get many of these at once because cancel does not
628 (forget_password): Do not forget the password
629 from the account settings, because this causes side-effects when
630 tinymail seems to call it at strange time, maybe because of how we
631 are cancelling get_password().
632 (modest_tny_account_store_alert): Ignore user cancellations.
634 2007-07-09 Murray Cumming <murrayc@murrayc.com>
636 * src/maemo/modest-maemo-utils.h:
637 * src/maemo/modest-maemo-utils.c:
638 Added modest_maemo_show_information_note_and_forget() for use instead of
639 gtk_dialog_run() when the response is not needed, to avoid an extra
640 mainloop which could cause a hang.
642 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
643 Use the logical IDs for the error message, though they are not
644 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
645 because gtk_dialog_run() caused a hang here (the window did not close).
646 This fixes projects.maemo.org bug NB#62646.
648 2007-07-09 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-account-mgr-helpers.h:
651 * src/modest-account-mgr-helpers.c:
652 Added modest_account_mgr_get_store_protocol().
654 * src/maemo/modest-account-view-window.c:
655 (on_delete_button_clicked): Show different warning text depending on
656 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
657 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
660 2007-07-09 Murray Cumming <murrayc@murrayc.com>
662 * src/maemo/modest-msg-edit-window.c:
663 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
664 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
666 2007-07-07 Armin Burgmeier <armin@openismus.com>
668 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
669 ckdg_ib_maximum_characters_reached from correct package.
671 * src/modest-ui-actions.c: Show an error message when a folder could
672 not be created. Tinymail does not give us specific error codes about
673 what has gone wrong, so we assume that a folder with that name
674 already exists, though there might be other reasons.
676 2007-07-06 Murray Cumming <murrayc@murrayc.com>
678 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
679 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
680 give a more exact error message that can be partly translated.
682 2007-07-05 Murray Cumming <murrayc@murrayc.com>
684 * src/maemo/modest-address-book.c:
685 (select_email_addrs_for_contact): Specify a default window size for the
686 select-email-address dialog, so that it is probably big enough for the
687 title. This should fix projects.maemo.org bug NB#62277.
689 2007-07-05 Murray Cumming <murrayc@murrayc.com>
691 * src/maemo/easysetup/modest-easysetup-wizard.c:
692 (create_page_complete_easysetup): Use
693 gtk_widget_set_size() request to ensure that the text wraps
696 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
698 * src/maemo/easysetup/modest-easysetup-wizard.c:
699 (on_entry_invalid_character), (create_page_account_details),
700 (create_page_user_details):
701 Use new API of ModestValidatingEntry. But for some reason the banner is
702 not shown. I will have to investigate that further.
704 * src/widgets/modest-validating-entry.c: (on_insert_text),
705 (modest_validating_entry_set_func):
706 * src/widgets/modest-validating-entry.h:
707 Added a new callback function to be able to react to prevented
708 characters whitespaces to e.g show a banner.
710 2007-07-05 Armin Burgmeier <armin@openismus.com>
712 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
713 notification of HildonNumberEditor instead of remembering the port
714 number. Thanks to Johannes for pointing this out.
716 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
718 * src/maemo/easysetup/modest-easysetup-wizard.c:
719 Check if there are any user changes before showing a confirmation
720 dialog (projects.maemo.org NB#60946)
722 2007-07-05 Armin Burgmeier <armin@openismus.com>
724 * src/maemo/modest-account-settings-dialog.c: Remember custom port
725 number at the beginning of the dialog and set the modified flag at the
726 end if the port number has changed. This is necessary because
727 HildonNumberEditor does not support notification when the value has
730 2007-07-05 Murray Cumming <murrayc@murrayc.com>
732 * src/modest-ui-actions.c:
733 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
734 a connection before asking anything else. Correct the check for the destination
735 folder so that it succeeds when online.
736 This fixed projects.maemo.org bug NB#61645.
738 2007-07-05 Murray Cumming <murrayc@murrayc.com>
740 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
741 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
742 to fix projects.maemo.org bug NB#62439.
744 2007-07-05 Murray Cumming <murrayc@murrayc.com>
746 * src/modest-tny-account.c: (on_connection_status_changed):
747 Really do not use tny_device_force_offline() here. See the previous comment.
749 2007-07-04 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-tny-account.c: (on_connection_status_changed):
752 Do not use tny_device_force_offline() when tinymail says that something
753 went wrong with the connection. It seems to report this unnecessarily.
755 2007-07-04 Murray Cumming <murrayc@murrayc.com>
757 * src/maemo/modest-connection-specific-smtp-window.c:
758 (modest_connection_specific_smtp_window_init):
759 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
760 does not seem to have any effect in osso 1.1 (though it works in
761 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
763 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
765 * src/maemo/modest-connection-specific-smtp-window.c:
766 Fix UI specification problems with projects.meamo.org NB#60479
768 2007-07-04 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
771 clue when this has failed, because the error dialog is not always shown
772 (at least in earlier version).
774 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
775 GError message, because the generic error dialog is not helpful.
777 'This message is not currently available (can't let a new connection go online)'
778 when trying to open an IMAP message.
780 (_modest_ui_actions_open): Offer a connection when some messages would
781 have to be downloaded and we are offline.
783 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
785 * src/widgets/modest-folder-view.c:
786 Don't check for MERGE type anymore as we use the correct type
788 NOTE: For the last two changes you need to update your tinymail copy
789 because of API changes!
791 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
793 * src/modest-tny-local-folders-account.c:
794 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
795 (see projects.maemo.org NB#61580)
797 2007-07-04 Murray Cumming <murrayc@murrayc.com>
799 * src/modest-tny-account.c: (on_connection_status_changed):
800 Commented out the call to modest_platform_connect_and_wait() because this
801 seems to always hang, and I would like to know if this is the only thing
802 that causes a hang when showing the connection dialog.
803 It is not very useful anyway.
805 2007-07-04 Murray Cumming <murrayc@murrayc.com>
807 * src/maemo/modest-msg-view-window.c:
808 (modest_msg_view_window_select_next_message):
810 * src/modest-platform.h:
811 * src/maemo/modest-platform.c:
812 Added modest_platform_connect_and_wait(), which calls
813 tny_maemo_conic_device_connect() always in the main thread, by calling it
814 in an idle handler and waiting for the idle handler to run. It should be
815 in the main thread because it uses GTK+ UI code. It just returns TRUE
816 if the device is already online.
818 There is some nasty code to ensure that subsequent calls to
819 modest_platform_connect_and_wait() just wait for the first one to finish,
820 by checking repeatedly in another idle handler. This is necessary,
821 because other threads (or even the main thread, via another idle handler)
822 can call modest_platform_connect_and_wait() while
823 modest_platform_connect_and_wait() is running.
825 (modest_platform_connect_and_wait_if_network_account),
826 (modest_platform_connect_and_wait_if_network_folderstore):
827 Convenience functions that calls modest_platform_connect_and_wait() if
828 the account or folder might want network access.
830 * src/modest-mail-operation.c:
831 (modest_mail_operation_update_account):
832 * src/modest-ui-actions.c: (download_uncached_messages),
833 (modest_ui_actions_on_rename_folder), (delete_folder),
834 (modest_ui_actions_on_main_window_move_to),
835 (modest_ui_actions_on_msg_view_window_move_to):
836 * src/widgets/modest-folder-view.c:
837 (drag_and_drop_from_folder_view):
838 Offer a connection if we are offline.
840 * src/modest-tny-account.c: (on_connection_status_changed):
841 Document this as only handling errors during network operations in progress,
842 and replace the idle code with a simple call to
843 modest_platform_connect_and_wait(), which does this instead.
845 2007-07-03 Murray Cumming <murrayc@murrayc.com>
847 * src/modest-tny-account.c:
848 (modest_tny_account_get_special_folder): (util_on_idle),
849 Handle the GError so we can see when tny_folder_store_get_folders()
850 fails, as it currently does while something else is connecting.
852 Added util_run_in_main_thread_and_wait()
853 which uses an idlen handler and mainloop to ensure that the function
854 is called in the main thread.
855 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
856 to make sure that we call attempt the connection in the mainloop only,
857 which might solve some hangs.
859 2007-07-03 Murray Cumming <murrayc@murrayc.com>
861 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
862 be found by their display name. This is never useful.
863 * src/modest-tny-account-store.c: (on_account_removed): Find the account
864 by its ID, instead of trying to use its ID as its display name.
866 * src/modest-tny-account-store.h:
867 * src/modest-tny-account.c:
868 (modest_tny_account_get_special_folder): Add a g_warning() when
869 tny_folder_store_get_folders() returns an empty list for the maildir.
871 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
872 Add a g_warning() when this returns NULL, because that it not allowed
875 2007-07-02 Armin Burgmeier <armin@openismus.com>
877 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
878 note when trying to cancel the wizard. This fixes projects.maemo.org
881 2007-07-02 Murray Cumming <murrayc@murrayc.com>
883 * src/modest-tny-account.h:
884 * src/modest-tny-account.c:
885 (modest_tny_account_new_from_server_account),
886 (modest_tny_account_new_from_server_account_name),
887 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
888 because this must now be set before setting the proto. This is usd in
889 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
890 warning in camel_session_get_service() caused by
891 tny_camel_transport_account_prepare().
893 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
896 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
898 * src/maemo/modest-connection-specific-smtp-edit-window.c:
900 (modest_connection_specific_smtp_edit_window_init):
902 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
905 2007-06-29 Murray Cumming <murrayc@murrayc.com>
907 * src/modest-tny-account.c:
908 (modest_tny_account_new_from_server_account):
909 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
910 now uses to request a connection when it needs one, and which it uses
911 to tell us that something is wrong with the connection, so we can force
912 the accounts offline to prevent further problems.
915 * src/modest-init.c: (init_default_settings):
916 * src/modest-mail-operation.c:
917 (modest_mail_operation_update_account):
918 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
919 This should not be necessary anymore. Do not set the conf key that
920 determined this (it was always TRUE and not set anywhere else).
922 * src/modest-ui-actions.h: Remove unused and unimplemented
923 modest_ui_actions_on_online_toggle_toggled().
925 2007-06-29 Murray Cumming <murrayc@murrayc.com
927 * src/maemo/modest-main-window.c: (connect_signals):
928 Don't connect to delete_event twice. Maybe this was harmless.
930 2007-06-29 Murray Cumming <murrayc@murrayc.com
932 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
933 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
934 Debug output to give some more clue when a folder move is not allowed.
936 2007-06-28 Murray Cumming <murrayc@murrayc.com
938 * src/modest-tny-account.c: (on_modest_file_system_info),
939 (modest_tny_account_get_mmc_account_name):
940 Always call the callback, without checking whether the name has changed.
941 * src/widgets/modest-folder-view.c: (strings_are_equal),
942 (on_model_foreach_set_name), (on_get_mmc_account_name),
943 (text_cell_data): Compare the name here, and use the name from
944 the account rather than from the
945 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
946 if the name was changed after the account was added to the model.
947 That's a tinymail bug but not one that I want to fix now.
949 This finally fixes projects.maemo.org bug NB#59301.
951 2007-06-27 Armin Burgmeier <armin@openismus.com>
953 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
956 2007-06-27 Murray Cumming <murrayc@murrayc.com
958 * src/modest-tny-account.h:
959 * src/modest-tny-account.c:
960 Added modest_tny_account_get_mmc_account_name(), to set the memory
961 card name asynchronously for the given account and then notify.
962 (modest_tny_account_new_for_local_folders): Use this new function instead
963 of using hildon_file_system_info_async_new() directly.
965 * src/widgets/modest-folder-view.c: (text_cell_data):
966 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
967 gtk_tree_model_row_changed() when it is available.
969 This should fix projects.maemo.org bug NB#59301.
971 2007-06-27 Murray Cumming <murrayc@murrayc.com
973 * src/modest-mail-operation.c: (update_account_thread),
974 (get_msgs_full_thread): Fix typo failures in the revert
977 2007-06-27 Murray Cumming <murrayc@murrayc.com
979 * src/maemo/modest-maemo-global-settings-dialog.c:
980 (idle_select_default_focus):
981 * src/modest-mail-operation.c: (idle_notify_progress),
982 (idle_notify_progress_once), (set_last_updated_idle),
983 (update_account_thread), (get_msgs_full_thread):
984 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
985 * src/widgets/modest-header-view.c:
986 (idle_notify_headers_count_changed_destroy),
987 (idle_notify_headers_count_changed):
988 Reverted the additions of gdk_threads_enter/leave(), in case this
989 helps with a startup hang on the device.
991 2007-06-26 Armin Burgmeier <armin@openismus.com>
993 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
994 for supported secure authentication methods from server by
995 gtk_dialog_run(), saving CPU time and a potential race condition.
997 2007-06-26 Armin Burgmeier <armin@openismus.com>
999 * src/maemo/modest-maemo-utils.h:
1000 * src/maemo/modest-maemo-utils.c: Added a
1001 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1002 only error code to tell the calling code when the user canceled the
1005 * src/maemo/modest-account-settings-dialog.h:
1006 * src/maemo/modest-account-settings-dialog.c:
1007 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1008 message if the retrieval of secure authentication methods was canceled
1009 by the user. Perform the check before saving anything to configuration
1010 to not end up with half-committed configuration changes, do not show
1011 a "Saving to configuration failed" note when authentication methods
1012 could not be retrieved.
1014 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1017 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1019 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1020 Only return the first level of folders under accounts, because the
1021 osso-global-search UI spec doesn't want the rest.
1022 This fixed projects.maemo.org bug NB#61811.
1024 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1026 * src/modest-tny-account-store.c:
1027 * src/modest-tny-account-store.h:
1028 Added modest_tny_account_is_memory_card_account().
1029 * src/maemo/modest-main-window.c: (create_details_widget):
1030 Show the same information items for the memory card as we show for the
1031 local-folders, to fix projects.maemo.org bug NB#59307.
1033 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1035 * src/modest-tny-account-store.c: (get_password):
1036 Added some checks for NULL to maybe prevent crashes, though I think
1037 it was Philip's last commit that actually prevented the crash here
1038 when creating a first new account.
1039 But the new account is still not usable (no messages are shown)
1040 until a restart of the application.
1042 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1044 * src/maemo/modest-maemo-global-settings-dialog.c:
1045 (idle_select_default_focus):
1046 * src/modest-mail-operation.c: (idle_notify_progress),
1047 (idle_notify_progress_once), (idle_notify_update_account_queue),
1048 (set_last_updated_idle), (update_account_thread),
1049 (notify_get_msgs_full), (get_msgs_full_destroyer),
1050 (get_msgs_full_thread):
1051 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1052 * src/widgets/modest-header-view.c:
1053 (idle_notify_headers_count_changed_destroy),
1054 (idle_notify_headers_count_changed):
1055 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1056 all idle handlers, because some other thread could be blocking
1057 the GDK lock, so that it can do GUI stuff.
1059 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1061 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1062 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1063 (on_idle_send_receive), (on_idle_open_default_inbox):
1064 * src/maemo/modest-msg-edit-window.c:
1065 (modest_msg_edit_window_attach_file_noninteractive):
1066 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1067 to prevent a hang. I don't quite understand why these are necessary,
1068 beause we should already be in the main loop. I guess something outside
1069 of the main loop is taking the lock.
1071 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1072 we are really using URIs, and use files that are more likely to exist.
1074 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1076 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1077 necessary because configure.ac now defines different variables.
1079 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1081 * libmodest-dbus-client/libmodest-dbus-client.c:
1082 * libmodest-dbus-client/libmodest-dbus-client.h:
1083 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1084 libmodest_dbus_client_compose_mail() is what things actually use.
1086 * src/dbus_api/modest-dbus-api.h:
1087 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1088 * tests/dbus_api/Makefile.am:
1089 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1092 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-init.c: (modest_init_local_folders):
1095 For memory-card (or other non local-folders) maildir accounts,
1096 always create an Archive folder, so that there is somewhere to put
1097 messages. This should be less confusing, because the user does not need
1098 to guess that the need to create a folder.
1100 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1102 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1103 Fixed icon size by using (50, 50) which is the same as defined by
1106 2007-06-25 Armin Burgmeier <armin@openismus.com>
1108 * src/widgets/modest-window-mgr.c:
1109 * src/modest-init.c:
1110 * configure.ac: Correctly recognize hildon-notify presence and fixed
1111 the build without it being installed.
1113 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1115 * libmodest-dbus-client/libmodest-dbus-client.c:
1116 (libmodest_dbus_client_search): Fix the build. Sorry.
1117 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1118 (reply_forward_cb): Initialize variables to fix the build.
1120 * src/modest-tny-account-store.c:
1121 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1122 comparison (a silly typo) so that email search results can be opened
1123 when there are more than one account.
1125 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1127 * libmodest-dbus-client/libmodest-dbus-client.c:
1128 (libmodest_dbus_client_search),
1129 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1130 instead of 1 second, because the search gets folders and messages from
1131 the server, which can take a long time. When it times out,
1132 osso-global-search will report no results.
1134 We need to specify whether we should search only cached information
1135 (maybe with a user preference), and the osso-email-search-plugin
1136 API should really be improved to allow that option, and to allow results
1137 to be delivered asynchronously in batches.
1139 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1141 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1142 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1143 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1145 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1148 that is an empty string. D-Bus seems to give us these instead of NULL.
1150 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1152 * src/dbus_api/modest-dbus-callbacks.c:
1153 * src/maemo/easysetup/modest-easysetup-wizard.h:
1154 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1155 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1156 (modest_connection_specific_smtp_edit_window_init):
1157 * src/maemo/modest-maemo-global-settings-dialog.c:
1159 * src/maemo/modest-maemo-utils.c:
1160 (modest_maemo_utils_setup_images_filechooser):
1161 * src/maemo/modest-main-window.c: (create_details_widget):
1162 * src/maemo/modest-msg-edit-window.c:
1163 (modest_msg_edit_window_attach_file_noninteractive),
1164 (modest_msg_edit_window_color_button_change),
1165 (modest_msg_edit_window_set_zoom):
1166 * src/modest-mail-operation.c: (update_account_thread):
1167 * src/modest-tny-account-store.c:
1168 * src/modest-tny-account.c:
1169 * src/widgets/modest-global-settings-dialog.c:
1170 * src/widgets/modest-window.h:
1172 Fixed build on bora!
1174 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1176 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1177 * src/modest-search.c: (modest_search_folder),
1178 (modest_search_all_accounts): Actually search only in the specified folder,
1179 doing a simple match on the folder ID.
1180 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1181 and added some documentation.
1183 2007-06-22 Armin Burgmeier <armin@openismus.com>
1185 * src/maemo/modest-maemo-utils.h:
1186 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1187 modest_maemo_utils_get_supported_secure_authentication_methods.
1189 * src/maemo/easysetup/modest-easysetup-wizard.c:
1190 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1191 one occured, not just "Server does not support secure authentication".
1193 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-tny-account-store.c: (get_password):
1196 Restored the call to tny_account_set_user() because Philip seems to have
1197 stopped this from crashing (by not using the freed string). It still does
1198 not work, but now we can test it.
1200 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1202 * src/maemo/modest-msg-edit-window.c: (init_window):
1203 Comment out use of an uninitialzed GtkScrolledWindow variable,
1204 to fix the build and stop a crash. Yet again.
1206 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1208 * src/modest-tny-account-store.c: (get_password):
1209 Remove the call to tny_account_set_user() because this actually crashes.
1210 As mentioned in the last commit, it is known to not work anyway.
1212 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1214 * src/modest-tny-account-store.c: (get_password):
1215 Use tny_account_set_username() to tell tinymail that the username might
1216 have changed too. But tinymail ignores this: see projects.maemo.org
1218 * src/modest-ui-actions.c:
1219 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1220 reset the connection when changing the username, and improve the comments.
1221 Save the changed username to gconf at least, so it is used when Modest is
1224 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1226 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1227 Do not use a query, so that we get all folders, including for POP and
1228 local-folders. They work as search criteria too.
1229 This fixes projects.maemo.org bug NB#57740.
1231 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1234 Comment out the use of hildon_notification_set_sound() because it is
1235 not declared, to fix the build. Warnings are serious, people.
1237 2007-06-21 Armin Burgmeier <armin@openismus.com>
1239 * src/maemo/modest-maemo-utils.h:
1240 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1241 modest_maemo_utils_get_supported_secure_authentication_methods()
1242 to query authentication methods for a specific user. This should fix
1243 projects.maemo.org bug NB#61369.
1245 * src/maemo/easysetup/modest-easysetup-wizard.c:
1246 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1249 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1251 * libmodest-dbus-client/libmodest-dbus-client.h:
1252 * libmodest-dbus-client/libmodest-dbus-client.c:
1253 (modest_dbus_message_iter_get_search_hit),
1254 (libmodest_dbus_client_search):
1255 Reorganised and commented this.
1256 Removed modest_search_hit_free() from the public API because it
1259 Added libmodest_dbus_client_get_folders() and
1260 modest_folder_result_list_free().
1262 * src/dbus_api/modest-dbus-api.h:
1263 * src/dbus_api/modest-dbus-callbacks.c:
1264 (modest_dbus_req_filter): Commented. Moved most code to
1265 on_dbus_method_search() and added on_dbus_method_get_folders().
1267 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1268 of the extra D-Bus handler.
1270 * tests/dbus_api/Makefile.am:
1271 * tests/dbus_api/test_get_folders.c: New test for
1272 libmodest_dbus_client_get_folders(). This seems to return an empty list
1273 at the moment. That could be the same error that causes the message list
1274 to be empty sometimes.
1275 This should help with projects.maemo.org bug NB#57740.
1277 2007-06-21 Armin Burgmeier <armin@openismus.com>
1279 * src/modest-mail-operation.c: Do not call
1280 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1281 notify the operation's end after having set the status to CANCELED for
1282 the operation queue to listen on. This fixes a deadlock when there
1283 were mail operations in the queue during its finalization.
1285 * src/modest-singletons.c: Reordered uninitialization of the account
1286 manager to happen after the mail operation queue was uninitialized
1287 because the mail operation's in the queue might still try to access
1288 the account manager (see modest_mail_operation_notify_end()). This
1289 fixes a potential crash when terminating the application.
1291 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1293 * src/modest-search.c:
1294 (search_mime_part_and_child_parts): Moved some code here so we
1295 can search recursively in child folders.
1296 (modest_search_folder): Search in the message as a mime part, instead
1297 of just its child mime parts.
1298 (read_chunk), (search_mime_part_ogs):
1299 Check how many bytes were read, to prevent an endless loop.
1300 Searching in message bodies now works. This finishes the fix for
1301 projects.maemo.org bug NB#61007.
1303 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1306 Add a g_warning when the item is not a folder.
1308 * src/modest-ui-dimming-rules.c:
1309 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1310 when selected item is not a folder (for instance, an account), because
1311 the UI spec only talks about folders.
1312 I am not sure what the UI spec wants, so this might not totally fix
1313 projects.maemo.org bug NB#60794.
1315 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1317 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1318 (load_from_file): Sort the list. The unsorted list would be more noticeable
1319 in non-English locales.
1321 * src/maemo/modest-msg-edit-window.c:
1322 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1323 warning and fix the build.
1325 * src/maemo/modest-progress-bar-widget.c:
1326 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1327 avoid a g_warning, and probably to avoid a crash.
1329 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1331 * src/modest-search.c: (modest_search_folder): Check for a GError
1332 when calling tny_folder_get_headers(), to show that this is not the cause
1335 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1337 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1338 Actually set the body query instead of the subject query.
1340 * src/modest-search.c: (search_mime_part_ogs),
1341 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1342 which would probably cause it to fail if we got this far.
1344 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1345 to simplify the code.
1346 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1347 be causing search-in-body to fail.
1349 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1351 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1353 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1354 Better debug message when the folder cannot be found.
1355 This should help with fixing projects.maemo.org bug #61287.
1356 * src/modest-search.c: (add_hit): Do not leak the furl string.
1358 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-ui-actions.c:
1361 (modest_ui_actions_on_folder_selection_changed):
1362 Do not special-case TNY_MERGE_FOLDER here, because
1363 modest_tny_folder_get_account() already does that. This fixes
1364 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1365 shown when the Outbox was selected).
1367 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1369 * libmodest-dbus-client/libmodest-dbus-client.c:
1370 (_dbus_iter_get_string_or_null): Initialize the string variable in
1371 case this helps with Dirk's crash.
1373 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1375 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1376 though it is not implemented yet (this function is maybe not even used),
1377 to avoid breaking ABI in future.
1378 * libmodest-dbus-client/libmodest-dbus-client.c:
1379 (get_attachments_string): Moved some code into this generic function.
1380 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1381 sends email. It is maybe not used.
1382 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1383 (on_send_mail): Use attachments.
1385 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1386 * src/maemo/modest-msg-edit-window.c:
1387 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1388 a filename before using it, to fix projects.maemo.org bug NB#58233.
1390 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1392 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1393 Initialize the continue_download variable to fix the build, and probably
1394 to fix randome behaviour.
1396 2007-06-18 Armin Burgmeier <armin@openismus.com>
1398 * src/modest-tny-send-queue.h:
1399 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1400 the queue so we can later show it in the UI. Replaced
1401 modest_tny_send_queue_msg_is_being_sent() by
1402 modest_tny_send_queue_get_msg_status().
1404 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1406 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1407 gpointer. This probably was not harmful, but just to be sure.
1409 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1411 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1412 Fix the build, but leave the function broken on Bora, because
1413 hildon_uri_action_get_service() does not exist.
1414 osso_uri_action_get_service() does not exist either, it seems.
1416 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1418 * src/modest-tny-account.c:
1419 (modest_tny_account_new_from_server_account):
1420 Uncommented the url debug output again, because it is useful for
1421 debugging, as I said in the comment.
1423 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1425 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1427 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1428 for Mameo Bora, to fix the build.
1430 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1433 Fixed build with hildon < 0.99
1435 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1436 Check if the selected account is busy instead of checking all accounts
1438 * src/modest-account-mgr-priv.h:
1439 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1440 (modest_account_mgr_init), (compare_account_name),
1441 (modest_account_mgr_set_account_busy),
1442 (modest_account_mgr_account_is_busy):
1443 * src/modest-account-mgr.h:
1444 Added busy information to the account manager. It possible to
1445 set an account to busy or not busy now.
1447 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1448 (modest_mail_operation_update_account),
1449 (modest_mail_operation_notify_end):
1450 Set the account to busy/not busy depending on the operation state.
1452 * src/widgets/modest-account-view.c:
1453 (modest_account_view_finalize), (get_last_updated_string),
1454 (update_account_view), (on_account_busy_changed), (init_view):
1455 Show string "Refreshing..." if the account is currently busy.
1457 All this fixes projects.maemo.org bug NB#59711
1459 2007-06-14 Armin Burgmeier <armin@openismus.com>
1461 * src/widgets/modest-attachments-view.h:
1462 * src/widgets/modest-attachments-view.c: Added
1463 modest_attachments_view_has_attachments() and fixed coordinate
1464 transformation in get_att_view_at_coords(). This fixes attachment
1467 * src/widgets/modest-msg-view.c: Make use of
1468 modest_attachments_view_has_attachments() to decide whether to show
1469 attachments in the header.
1471 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1473 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1474 (on_change), (on_combo_security_changed),
1475 (modest_connection_specific_smtp_edit_window_init),
1476 (modest_connection_specific_smtp_edit_window_set_connection),
1477 (modest_connection_specific_smtp_edit_window_is_dirty):
1478 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1479 * src/maemo/modest-connection-specific-smtp-window.c:
1482 Show an comfirmation dialog for the smpt-edit-window if there are
1483 unsaved changes and the user hits cancel.
1484 (projects.maemo.org bug NB#60479)
1486 2007-06-14 Armin Burgmeier <armin@openismus.com>
1488 * src/maemo/easysetup/modest-easysetup-wizard.c:
1489 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1490 address" info in banner instead of node, and select all the text as
1491 per UI spec. This fixes projects.maemo.org bug NB#60550.
1493 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1495 reviewed by: <delete if not using a buddy>
1497 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1498 * src/modest-ui-actions.c: (folder_refreshed_cb):
1500 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1502 * src/widgets/modest-folder-view.c: (filter_row):
1503 Explictly filter out the per-account outbox accounts. I don't know why
1504 these only sometimes show up, but now they should never show up in the UI.
1505 This should fix projects.maemo.org bug NB#60160.
1507 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1509 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1510 when the toolbar does not exist yet.
1511 * src/modest-widget-memory.c: (save_settings_header_view):
1512 Added g_warnings() to help us to discover when we are trying to set
1513 an empty columns list in gconf.
1515 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1517 * src/modest-init.h:
1518 * src/modest-init.c:
1519 Added modest_init_get_default_header_view_column_ids().
1521 * src/modest-widget-memory.c: (restore_settings_header_view):
1522 Use the new function to get defaults, if the gconf key is empty,
1523 instead of not creating any columns. This seems to fix the
1524 empty right-hand pane problems.
1526 * src/widgets/modest-header-view.h: Improved documentation.
1528 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1530 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1531 Revert the use of the display name as the account name, because this
1532 is generally wrong and would break the code that follows.
1534 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1536 * src/maemo/easysetup/modest-easysetup-wizard.c:
1537 (check_for_supported_auth_methods), (on_before_next),
1540 More correct fix for projects.maemo.org bug NB# 58991
1541 Do not longer accept AUTH_PASSWORD as secure method and choose
1542 correct method when creating the account.
1544 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1546 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1547 Fixed projects.maemo.org bug NB# 58991
1549 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1551 * src/modest-init.c: (modest_init_init_core),
1552 (modest_init_local_folders): Fixed compilation errors.
1554 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1556 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1557 Remove unnecessary lib/include, though it is good in principle when needed.
1559 * src/modest-init.c: (modest_init_one_local_folder),
1560 (modest_init_local_folders):
1561 * src/modest-init.h: Initialize the .modest library for memory cards,
1562 instead of just doing nothing for them. This should allow us to create
1563 folders there, fixing projects.maemo.org bug NB#59297.
1565 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1567 * libmodest-dbus-client/libmodest-dbus-client.c:
1568 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1569 (libmodest_dbus_client_compose_mail),
1570 (libmodest_dbus_client_open_message),
1571 (libmodest_dbus_client_send_and_receive),
1572 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1574 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1575 (on_idle_open_message), (modest_dbus_req_handler),
1576 (search_result_to_message), (modest_dbus_req_filter):
1577 * src/modest-search.c: (add_hit), (modest_search_folder),
1578 (modest_search_all_accounts): Improved debug messages.
1580 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1582 * src/modest-tny-account-store.c:
1583 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1586 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1589 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1591 * src/modest-tny-account-store.c: (get_server_accounts):
1592 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1593 even when there are no accounts, so that the Outbox folder is always
1594 visible. This fixes projects.maemo.org bug NB#60158.
1596 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/modest-main-window.c: (create_details_widget):
1599 Use the mcen_va_never logical ID.
1601 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1603 * src/dbus_api/modest-dbus-api.h:
1604 * src/dbus_api/modest-dbus-callbacks.c:
1605 (on_idle_open_default_inbox), (on_open_default_inbox),
1606 (modest_dbus_req_handler):
1607 Added a new OpenDefaultInbox method.
1609 * libmodest-dbus-client/libmodest-dbus-client.h:
1610 * libmodest-dbus-client/libmodest-dbus-client.c:
1611 Added libmodest_dbus_client_open_default_inbox() to call the new
1612 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1613 though it should maybe be used by a new osso-email-interface function.
1615 * tests/dbus_api/Makefile.am:
1616 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1619 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1621 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1622 NULL, so that the signals get all the keys. This should not actually
1623 change any behaviour because we currently update everything when anything
1626 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1628 * src/widgets/modest-folder-view.c: (text_cell_data),
1629 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1630 (find_inbox_iter): If tinymail tells us that the folder is
1631 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1632 This causes the inbox to be selected at startup, fixing part of
1633 projects.maemo.org bug NB#56305.
1635 * src/modest-ui-dimming-rules.c:
1636 (modest_ui_dimming_rules_on_tools_smtp_servers):
1637 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1638 the SMTP servers menu item.
1639 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1640 that the SMTP Servers menu item is dimmed when there are no accounts,
1641 as a future version of the UI spec will require. This fixes
1642 projects.maemo.org bug NB#56305.
1644 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1646 * src/maemo/modest-maemo-utils.c:
1647 (modest_maemo_utils_get_supported_secure_authentication_methods):
1648 Added label to dialog instead of unreadable title
1650 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1651 (modest_main_window_new):
1652 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1655 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1656 * src/modest-account-mgr.h:
1657 Added method to avoid code duplication
1659 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1660 (modest_ui_actions_on_send_receive):
1661 Use modest_account_mgr_has_accounts
1663 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1665 * src/maemo/easysetup/modest-presets.c:
1666 (modest_presets_get_info_server_security): Do not report secure auth
1668 * src/modest-protocol-info.c: Use the defines for the gconf key names
1669 for secure authentication. This was not working because we were writing
1670 Password and reading password, and the check was case sensitive.
1671 With this, gmail now works for receiving and sending when created via
1674 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1676 * src/maemo/easysetup/modest-presets.c:
1677 (modest_presets_get_info_server_security): Correct the key name for
1678 SecureSmtp, because it seems to be case-sensitive.
1679 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1680 Do not try to get the 0th notebook page if there are 0 pages, to
1681 avoid a g_warning().
1683 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1686 Prevent use of the new notification feature for now, because it currently
1687 shows one dialog for each new email, which is annoying.
1689 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1691 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1692 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1693 when no country was selected, so that we show the global ones.
1694 * src/maemo/easysetup/modest-presets.c:
1695 (modest_presets_get_providers): Return only the global providers, not
1696 all providers when mmc=0 was requested.
1698 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1700 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1701 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1702 provider ID in the combo.
1704 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1705 Do not show the page numbers, because it would be confusing when we add
1706 the 2 extra pages for the custom setup, when the user chooses the "Other"
1707 provider. This fixes projects.maemo.org bug NB#59028
1709 * src/modest-init.c: (modest_init_init_core),
1710 (modest_init_local_folders):
1711 * src/modest-init.h:
1712 * src/modest-tny-account.c:
1713 (modest_tny_account_new_for_local_folders): Do not create default folders
1714 for the memory card. This should fix projects.maemo.org bug NB#59328.
1716 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1719 Free the changed_conf_keys string items. They are already freed in the
1720 idle handler if that runs first.
1722 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1724 * src/modest-ui-actions.c:
1725 (modest_ui_actions_on_password_requested): Check that the server name
1726 is not NULL, because I just saw a password dialog with (null) as the
1729 * src/modest-tny-folder.[h|c]: Added
1730 modest_tny_folder_is_memory_card_folder().
1731 * src/modest-ui-dimming-rules.c:
1732 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1733 menu item for memory cards, as per the UI spec (section 7.4). This should
1734 fix projects.maemo.org bug NB#59297.
1736 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1738 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1739 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1740 is another problem with the code, see Murray's comment at line 772)
1742 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1744 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1745 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1746 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1747 (load_from_file), (easysetup_country_combo_box_init),
1748 (easysetup_country_combo_box_get_active_country_ids),
1749 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1750 instead of just one ID, to avoid duplicate country names in the UI.
1752 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1753 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1754 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1755 a single ID, avoiding duplicate providers.
1756 * src/maemo/easysetup/modest-easysetup-wizard.c:
1757 (on_combo_account_country): Adapt to use a list.
1759 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1761 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1762 keys changed in the last X seconds.
1764 * src/modest-account-mgr.h:
1765 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1766 (on_key_change), (modest_account_mgr_class_init),
1767 (modest_account_mgr_init), (modest_account_mgr_finalize):
1768 As the keys are changed, save them in a GSList* and signal that GSList*
1769 further every X seconds, to batch changes, to allow us to do just one
1770 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1771 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1773 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1774 changed signal signature.
1776 * src/modest-conf.c: (modest_conf_set_list),
1777 (modest_conf_on_change): Reenable notification.
1779 (modest_conf_maemo_fake_on_change): Comment out the hack that
1780 notified immediately instead of asynchronously.
1782 * src/widgets/modest-account-view.h:
1783 * src/widgets/modest-account-view.c:
1784 (update_account_view): Select the previously-selected account ID,
1785 if possible. This fixes projects.maemo.org bug NB#56933.
1787 (on_account_changed), (on_account_removed),
1788 (modest_account_view_select_account):
1790 Remove the block/unblock functions
1791 because they were not useful.
1793 * src/maemo/modest-account-view-window.c:
1794 (on_delete_button_clicked), (on_edit_button_clicked),
1795 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1797 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1799 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1800 Improve the error dialog to show Incorrect Account Settings, which seems
1801 clearer, and say that the internal error message (to be removed from the
1802 dialog later) is often misleading.
1803 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1805 * src/modest-tny-account.c:
1806 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1807 URL because this is so useful for debugging on the device.
1809 * src/widgets/modest-serversecurity-combo-box.c:
1810 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1812 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-mail-operation.c:
1815 (modest_mail_operation_send_new_mail):
1816 Added a comment about a nasty but apparently harmless message. Details
1817 added to the wiki g_warnings() page.
1819 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1821 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1822 (modest_tny_send_queue_class_init):
1823 Do not use the priv struct because it is empty, to avoid g_warnings
1824 about a non-existant priv struct.
1826 * src/modest-tny-account-store.c:
1827 (modest_tny_account_store_get_server_account),
1828 (modest_tny_account_store_get_transport_account_for_open_connection
1829 ): Do not try to get transport server accounts for local folders,
1830 because they don't have any. This avoids a g_warning().
1832 * src/maemo/modest-main-window.c:
1833 (modest_main_window_notify_send_receive_initied),
1834 (on_configuration_key_changed):
1835 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1836 * src/modest-defs.h:
1837 * src/modest-mail-operation.c:
1838 (modest_mail_operation_update_account):
1839 * src/modest-tny-account-store.h:
1840 * src/modest-tny-account.c:
1841 (modest_tny_account_get_special_folder),
1842 (modest_tny_account_new_for_local_folders),
1843 (modest_tny_account_new_for_per_account_local_outbox_folder):
1844 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1845 * src/modest-tny-local-folders-account.c:
1846 (add_account_folders_to_merged_folder):
1847 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1848 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1849 (modest_ui_actions_on_send):
1850 * src/widgets/modest-folder-view.c: (update_model):
1851 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1852 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1853 modest_tny_account_store_get_tny_account_by_account() to
1854 modest_tny_account_store_get_server_account() to make the code clearer.
1856 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1858 * src/dbus_api/modest-dbus-api.h:
1859 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1860 * src/maemo/modest-msg-edit-window.c:
1861 (modest_msg_edit_window_attach_file_noninteractive):
1862 added g_warning in case the file to be attached does not exist
1863 * tests/dbus_api/test_compose_mail.c: (main):
1864 removed obsolete comment, added generic files as test case
1866 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1868 * src/modest-tny-account-store.c: (get_server_accounts):
1869 Create the local folders account only once, not once for each outbox, and
1870 not only when there are some outboxes.
1872 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1874 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1875 code that is causing a crash at startup. Sergio says that he is fixing this.
1877 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1879 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1880 * src/maemo/modest-account-settings-dialog.c:
1881 (create_page_outgoing),
1882 (modest_account_settings_dialog_set_account_name),
1883 (save_configuration):
1884 - Fixed handling of the "Use secure authentication" toggle to comply with
1885 the ui specification. See also projects.maemo.org bug NB#58400
1887 - Restore the Secure connection setting combo correctly when loading
1890 * src/maemo/modest-maemo-utils.c:
1891 (on_camel_account_get_supported_secure_authentication),
1892 (modest_maemo_utils_get_supported_secure_authentication_methods):
1893 Fixed a crasher if operation is canceled
1895 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1896 (modest_protocol_info_auth_is_secure):
1897 * src/modest-protocol-info.h:
1899 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1900 the sense of the "Use secure authentication" toggle.
1902 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-tny-account-store.h:
1905 * src/modest-tny-account-store.c:
1906 Added modest_tny_account_store_get_local_folders_account().
1908 * src/modest-tny-folder.h:
1909 * src/modest-tny-folder.c:
1910 (modest_tny_folder_get_account):
1911 Added this replacement for tny_folder_get_account() which returns
1912 the local-folders account for TnyMergeFolders, to avoid the
1913 warning about the unimplemented get_account_func() vfunc().
1915 (modest_tny_folder_get_rules),
1916 * src/modest-ui-actions.c:
1917 (modest_ui_actions_on_folder_selection_changed):
1918 * src/modest-mail-operation.c:
1919 (modest_mail_operation_remove_folder),
1920 (modest_mail_operation_xfer_folder),
1921 (modest_mail_operation_rename_folder),
1922 (modest_mail_operation_get_msg),
1923 (modest_mail_operation_get_msgs_full),
1924 (modest_mail_operation_remove_msg),
1925 (modest_mail_operation_xfer_msgs),
1926 (modest_mail_operation_refresh_folder):
1927 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1929 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1931 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1932 (modest_server_account_set_security):
1933 * src/modest-defs.h: Add comments explaining that our
1934 UI spec means TLS when it says Normal, so these do not look like errors.
1936 * src/modest-tny-account.c:
1937 (modest_tny_account_new_from_server_account): Use the new tinymail
1938 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1939 for TLS. This should fix projects.maemo.org bug NB#58460.
1941 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1943 * src/maemo/easysetup/modest-easysetup-wizard.c:
1944 (create_account): Correct the position of the gconf sanity check warning.
1945 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1946 of using the g_idle_add() hack, because this does not seem to be necessary
1947 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1948 caused by something other than maemo's gconf.
1949 This fixes projects.maemo.org bug #59022.
1951 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1953 * src/modest-account-mgr-helpers.c:
1954 (modest_account_mgr_get_default_account): Do not check that the account
1955 exists if there is no default account (NULL), to fix a runtime warning.
1957 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1959 * src/widgets/modest-folder-view.c: (update_model):
1960 Do not unref the treemodel before we have finished with it.
1961 This prevents a valgrind warning and an occasional crash at startup.
1963 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1965 * libmodest-dbus-client/libmodest-dbus-client.h:
1966 added libmodest_dbus_client_compose_mail()
1967 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1969 added functions needed for SendAsMail() functionality
1970 * src/maemo/modest-msg-edit-window.c:
1971 (modest_msg_edit_window_attach_file_noninteractive):
1972 non interactively attaching files to message edit window
1973 * src/widgets/modest-msg-edit-window.h:
1974 * tests/dbus_api/Makefile.am:
1975 added test_compose_mail.c
1976 * tests/dbus_api/test_compose_mail.c: (main):
1978 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1980 * src/modest-account-view.c:
1981 Fixed bug projects.maemo.org bug NB#59307
1983 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1985 * src/maemo/easysetup/modest-easysetup-wizard.c:
1986 (get_serverport_incoming), (on_before_next), (create_account):
1987 * src/maemo/modest-account-settings-dialog.c:
1988 (modest_account_settings_dialog_set_account_name):
1989 * src/maemo/modest-maemo-utils.c:
1990 (on_camel_account_get_supported_secure_authentication_status),
1991 (on_camel_account_get_supported_secure_authentication),
1992 (on_secure_auth_cancel),
1993 (modest_maemo_utils_get_supported_secure_authentication_methods):
1995 Implemented security authentication for settings and easysetup.
1997 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/modest-main-window.c: (create_details_widget):
2000 Show the total size for memory card accounts too, instead of showing
2001 the name again. Fixes bug projects.maemo.org bug NB#59307.
2003 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-tny-simple-folder-store.c:
2007 * src/modest-tny-simple-folder-store.h: Removed.
2009 * src/modest-tny-local-folders-account.h
2010 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2011 for the local-folders maildir, with an extra TnyMergedFolder containing
2012 the folders of the per-account outbox store accounts.
2013 * src/modest-tny-account-store.c: (get_server_accounts):
2014 Add the outboxes to the special local folders account after creating it.
2016 * src/modest-tny-account.c:
2017 (modest_tny_account_new_for_local_folders): Create the derived
2018 account when creating the main local-folders account.
2020 * src/maemo/modest-main-window.c: (create_details_widget),
2021 (modest_main_window_set_contents_style):
2022 Adapted to the use of the derived account instead of the folder store.
2024 * src/modest-ui-actions.c:
2025 (modest_ui_actions_on_folder_selection_changed):
2026 * src/modest-ui-dimming-rules.c:
2027 (modest_ui_dimming_rules_on_new_folder):
2028 * src/widgets/modest-folder-view.c: (text_cell_data),
2029 (icon_cell_data), (filter_row), (update_model),
2030 (get_cmp_rows_type_pos):
2033 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2034 Do not get the priv struct, because no priv struct has been set,
2035 to avoid a runtime warning.
2037 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2038 #ifelse with #else, to fix a warning, to fix the build.
2041 2007-06-05 Christian Kellner <ckellner@openismus.com>
2043 * libmodest-dbus-client/libmodest-dbus-client.c:
2044 Fix small typo in doc (why do you always see them
2045 AFTER committing stuff?)
2048 2007-06-05 Christian Kellner <ckellner@openismus.com>
2050 * libmodest-dbus-client/libmodest-dbus-client.c:
2051 (libmodest_dbus_client_search):
2052 Initialize hit list with NULL. Also set folder list
2053 to "" if NULL was supplied.
2056 2007-06-03 Christian Kellner <ckellner@openismus.com>
2058 * libmodest-dbus-client/libmodest-dbus-client.c:
2059 (modest_search_hit_list_free):
2060 Make it save to call it with NULL.
2062 * src/dbus_api/modest-dbus-callbacks.c:
2063 * src/modest-search.c:
2064 Return full ModestSearchHits as the search result list not TnyHeader
2065 since can't be around withouth the correspoding TnyFolder.
2067 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2069 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2070 Added currently commented code to check for secure auth
2072 * src/maemo/modest-account-settings-dialog.c: (on_response),
2073 (save_configuration), (show_ok):
2074 Fixed projects.maemo.org bugs NB #59248 and #59251
2076 * src/maemo/modest-maemo-utils.c:
2077 (on_camel_account_get_supported_secure_authentication_status),
2078 (on_camel_account_get_supported_secure_authentication),
2079 (modest_maemo_utils_get_supported_secure_authentication_methods):
2080 * src/maemo/modest-maemo-utils.h:
2081 Moved get_supported_secure_authentication() method here to be able
2082 to use it from easysetup wizard.
2084 * src/modest-pair.c: (on_pair_compare_as_string):
2085 Should compare string with first part of pair and not
2086 strcmp pairs which will crash.
2088 * src/modest-protocol-info.c:
2089 (modest_protocol_info_protocol_is_store):
2090 * src/modest-protocol-info.h:
2091 Added modest_protocol_info_get_auth_protocol_name()
2093 2007-06-03 Armin Burgmeier <armin@openismus.com>
2095 * src/modest-mail-operation.c:
2096 (modest_mail_operation_get_msgs_full): Set priv->account also when
2097 only retrieving a single message. This avoids a crash when canceling
2100 (modest_mail_operation_notify_end): Do not explicitely remove the
2101 operation from the queue but only emit the progress_changed signal.
2102 The queue itself listens to that signal to remove the operation when
2103 it is finished. This reduces coupling and removes a potential deadlock
2104 when modest_mail_operation_notify_end() is called from the queue
2105 itself. If that is a problem performance-wise, I would suggest to
2106 implement a status-changed signal or something.
2108 * src/modest-mail-operation-queue.c: Make sure to never call a
2109 function from another file while the queue is locked. This (hopefully)
2110 fixes another deadlock when exiting the application while retrieving
2113 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2115 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2116 Fixed build if libogs is not available
2118 2007-06-03 Christian Kellner <ckellner@openismus.com>
2120 * libmodest-dbus-client/libmodest-dbus-client.h:
2121 * libmodest-dbus-client/libmodest-dbus-client.c:
2122 (libmodest_dbus_client_delete_message):
2123 Implement deletion of messages (Client side).
2125 (modest_search_hit_free),
2126 (modest_search_hit_list_free):
2127 Utility functions to free the result hits.
2129 * src/dbus_api/modest-dbus-api.h:
2130 * src/dbus_api/modest-dbus-callbacks.c:
2131 (on_delete_message),
2132 (modest_dbus_req_handler):
2133 Implement deletion of messages (Server side).
2135 * tests/dbus_api/test_search.c: (main):
2138 * tests/dbus_api/Makefile.am:
2139 * tests/dbus_api/test_delete_message:
2140 Add little test for the message deletion logic
2142 2007-06-03 Armin Burgmeier <armin@openismus.com>
2144 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2145 when the operation queue was not empty. projects.maemo.org bug
2148 2007-06-03 Armin Burgmeier <armin@openismus.com>
2150 * src/widgets/modest-account-view.c
2151 (on_account_default_toggled): Toggle default account column
2152 explicitely instead of waiting for gconf notification (which is
2153 currently ignored). This should fix projects.maemo.org bug NB#56910
2154 for now. It should probably be removed when gconf notifications are
2157 2007-06-03 Christian Kellner <ckellner@openismus.com>
2159 * libmodest-dbus-client/libmodest-dbus-client.c:
2160 Removed debugging spew.
2162 * src/dbus_api/modest-dbus-callbacks.c:
2163 Added debugging info.
2165 * src/modest-search.c:
2166 (modest_search_all_accounts):
2167 Use tny_account_store_get_accounts () on the account store
2168 to get all accounts which is the way to get all accounts.
2170 * tests/dbus_api/test_search.c: (main):
2171 Make it possible to supply the search term on the command line.
2173 2007-06-03 Christian Kellner <ckellner@openismus.com>
2175 * libmodest-dbus-client/libmodest-dbus-client.c:
2176 * libmodest-dbus-client/libmodest-dbus-client.h:
2177 Implement searching for mesages over raw dbus. (Client side)
2179 * src/dbus_api/Makefile.am:
2180 * src/dbus_api/modest-dbus-api.h:
2181 * src/dbus_api/modest-dbus-callbacks.c:
2182 * src/dbus_api/modest-dbus-callbacks.h:
2183 Search framework (Server side). Also implement on_idle_open_message().
2185 * src/maemo/modest-platform.c: (modest_platform_init):
2186 Prepare for raw dbus/osso rpc interaction.
2188 * src/modest-search.h:
2189 Changed minsize from unspecific guint to guint32.
2191 * src/modest-search.c:
2193 Added strange hack which magically made tnymail work.
2195 (modest_search_folder),
2196 (modest_search_account),
2197 (modest_search_all_accounts):
2198 Implement helper functions to search all accounts, specific account
2201 * tests/dbus_api/Makefile.am:
2202 * tests/dbus_api/test_open_message.c:
2203 Read url to open from commandline.
2205 * tests/dbus_api/test_search.c:
2206 Implement small test for dbus search stuff
2208 2007-06-02 Armin Burgmeier <armin@openismus.com>
2210 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2211 include account type and account title. This fixes projects.maemo.org
2214 * src/maemo/modest-account-view-window.c: Set a title for the window.
2216 2007-06-02 Armin Burgmeier <armin@openismus.com>
2218 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2219 incoming and outgoing server name based on email address and server
2220 types as long as the names have not been edited manually. This fixes
2221 projects.maemo.org bug NB#58671.
2223 2007-06-02 Armin Burgmeier <armin@openismus.com>
2225 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2226 server type cannot be changed in future to the incoming details page
2227 when creating an account. This fixes projects.maemo.org bug NB#59029.
2229 2007-06-02 Armin Burgmeier <armin@openismus.com>
2231 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2232 and assigned max width chars so that they wrap instead of being
2233 truncated. Fixes projects.maemo.org bug NB#56126.
2235 2007-06-02 Armin Burgmeier <armin@openismus.com>
2237 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2238 introductory note to the connection specific smtp servers dialog, as
2239 section 8.12 of the email UI specification requires. This fixes
2240 projects.maemo.org bug NB#59212.
2242 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2244 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2245 Check for running mail operations, and offer to cancel them, as per the UI
2246 spec. This fixes projects.maemo.org bug NB#59041 .
2247 However, I suspect that tinymail may still use the network connection
2248 in ways that we cannot detect or cancel. But it should at least adapt to
2249 changes fairly well.
2251 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-tny-account-store.c: (recreate_all_accounts),
2254 (get_cached_accounts), (get_server_accounts): Do more sensible
2255 ref-counting of the temporarily-cached outbox accounts list. This seems
2256 to fix a crash when entering the password when the password was wrong.
2258 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2260 * src/gnome/modest-main-window.c: (connect_signals):
2261 * src/modest-tny-account-store.c: (get_password),
2262 (modest_tny_account_store_alert): Added comments and clues and
2263 commented-out code about how we currently fail to deal with connection
2264 errors and wrong passwords, and how we should.
2266 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2268 * src/widgets/modest-retrieve-combo-box.c:
2269 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2270 This fixes projects.maemo.org bug NB#58472 .
2272 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2274 * src/maemo/easysetup/modest-easysetup-wizard.c:
2275 (create_page_complete_easysetup):
2276 (create_page_complete_custom): Correct the last commit,
2277 putting the correct sentences in the correct pages.
2279 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2281 * src/maemo/easysetup/modest-easysetup-wizard.c:
2282 (create_page_complete_custom): Show the second sentence of text
2283 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2286 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2288 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2289 Set the leave-on-server conf key by default. This fixes
2290 projects.maemo.org bug NB#59258 .
2292 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2294 * src/maemo/modest-account-view-window.c:
2295 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2296 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2299 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2301 * src/maemo/easysetup/modest-easysetup-wizard.c:
2302 (create_caption_new_with_asterisk):
2303 * src/maemo/modest-account-settings-dialog.c:
2304 (create_caption_new_with_asterisk):
2305 Uncomment the code to add the asterisk, because they are no longer in the
2306 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2307 (update_incoming_server_title): Add an asterisk here too.
2309 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/modest-maemo-global-settings-dialog.c:
2312 (current_connection): Check that we are even connected before trying to
2313 get the current connection name, to prevent a warning.
2315 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2316 Change the comments because tny_maemo_conic_device_connect() is now meant to
2318 * src/modest-mail-operation.c:
2319 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2320 make sure we have a connection and fail if we can't connect.
2322 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2324 * src/maemo/modest-main-window.c:
2325 (on_account_store_connecting_finished): Do not try to get the
2326 connection ID if we are not really connected. I am surprised that
2327 this signal handler is called when we are not connected.
2329 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2331 * src/modest-error.h:
2332 * src/modest-ui-actions.c:
2333 (modest_ui_actions_get_msgs_full_error_handler):
2334 Renamed an enum, added comments, added an enum
2335 for retrieve-limit errors.
2337 * src/modest-mail-operation.c: (foreach_add_item),
2338 (internal_folder_observer_update), (update_account_thread),
2339 (modest_mail_operation_get_msgs_full):
2340 (modest_mail_operation_update_account),
2341 Added comments about how this works, and some code that should
2342 (but does not) check the retrieve-limit. See the TODO comment.
2344 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2346 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2347 Initialize help_id to fix the build. Warnings are good.
2349 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2351 * src/widgets/modest-hbox-cell-renderer.c:
2352 (modest_hbox_cell_renderer_append):
2353 * src/widgets/modest-vbox-cell-renderer.c:
2354 (modest_vbox_cell_renderer_append):
2355 Fix the last commit by doing an extra ref.
2357 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2359 * src/widgets/modest-hbox-cell-renderer.c:
2360 (modest_hbox_cell_renderer_append):
2361 * src/widgets/modest-vbox-cell-renderer.c:
2362 (modest_vbox_cell_renderer_append):
2363 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2364 to fix the build with Maemo Bora.
2365 However, there seems to be a remaining crash, probably due to reference
2368 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-tny-account.c:
2371 (modest_tny_account_new_for_local_folders):
2372 Use hildon_file_system_info_async_new() to get a better name for
2373 the memory card account, setting it as the account name.
2374 The timing seems to work, but this is probably
2375 not the best place to do this. See the TODO comment.
2376 * src/maemo/modest-main-window.c: (create_details_widget):
2377 * src/widgets/modest-folder-view.c: (text_cell_data):
2378 Use the tny account name instead of hardcoding a name.
2380 2007-05-30 Christian Kellner <ckellner@openismus.com>
2382 * src/modest-search.c: (modest_search):
2383 Correctly set part_search_func even if we have already parsed
2384 the query and thus a valid OgsTextSearcher object.
2386 2007-05-30 Christian Kellner <ckellner@openismus.com>
2389 Search and check for libogs.
2392 Incooparte the ogs build env.
2394 * src/modest-mime-part-search-stream.c:
2395 * src/modest-mime-part-search-stream.h:
2396 Removed since we do the real searching now in modest-search.c.
2398 * src/modest-search.c:
2399 * src/modest-search.h:
2400 Implement support for ogs. We use that if available and requested
2401 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2402 should now handle the corner case when the search term is spread
2403 across multiple reads.
2404 Also the logic in modest_search () was corrected to search all
2405 requested fields until one is found.
2407 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2409 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2411 * src/modest-init.h:
2412 * src/modest-init.c: Made modest_init_local_folders() take a
2413 path and be public so we can iniitialize maildir folders on
2416 * src/modest-local-folder-info.h:
2417 * src/modest-local-folder-info.c:
2418 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2420 * src/modest-tny-account.c:
2421 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2422 still means the standard local-folders path on the local volume.
2424 * src/modest-tny-account-store.c:
2425 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2426 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2427 all accounts when that happens.
2428 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2429 this too, so it shows up in the treeview.
2431 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2433 * src/maemo/modest-maemo-global-settings-dialog.c:
2434 (current_connection):
2435 * src/widgets/modest-global-settings-dialog.c:
2436 (current_connection_default):
2437 Use the enum values instead of 0, 1 and -1,
2438 to make the code clearer.
2440 * src/modest-account-mgr-helpers.c:
2441 (modest_account_mgr_get_connection_specific_smtp): Make this code
2444 * src/modest-runtime.h:
2445 * src/modest-runtime.c:
2446 Added modest_runtime_remove_all_send_queues().
2447 * src/maemo/modest-main-window.c:
2448 (on_account_store_connecting_finished): Recreate the send queues,
2449 using the appropriate transport accounts for this new connection.
2450 Some futher adapting might be needed if the old send queues are not
2451 automatically stopped at this point.
2453 * src/modest-tny-account-store.c: (get_server_accounts):
2454 Create the connection-specific transport accounts, so that they can
2455 be found later by their ID.
2457 * src/modest-tny-account.h:
2458 * src/modest-tny-account.c:
2459 Added modest_tny_account_new_from_server_account_name().
2460 modest_tny_account_new_from_server_account(): Do not create the
2461 send queues here, because they will be
2462 recreated anyway when the connection changes for the first time.
2464 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2466 * src/modest-local-folder-info.h:
2467 * src/modest-local-folder-info.c:
2468 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2469 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2470 tbox_folder): Take a modest account name instead of a server TnyAccount,
2471 so we can have per-modest-account rather than per-transport-account
2473 We must make sure that we change or recreate the exisitng send queues
2474 when the connection changes for connection-specific transport accounts.
2476 * src/modest-tny-account-store.c:
2477 (create_per_account_local_outbox_folders): Create outboxed per modest
2478 account, not per transport account.
2480 * src/modest-tny-account.h:
2481 * src/modest-tny-account.c:
2482 (modest_tny_account_get_special_folder): For outboxes, get the
2483 parent modest account name. The account is ignored for other folders.
2484 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2485 modest account name rather than a server TnyAccount.
2487 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2489 * src/modest-tny-account.c:
2490 (modest_tny_account_new_from_server_account):
2491 Call modest_runtime_get_send_queue() immediately after creating transport
2492 accounts, so that they start trying to send email from the outbox as soon
2493 as possible at startup. This is probably what we want.
2495 * src/modest-mail-operation.c: (update_account_thread):
2496 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2497 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2498 * src/modest-tny-send-queue.h:
2499 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2500 (modest_ui_actions_on_send):
2501 Added comments about how sending works, though it needs some more work.
2503 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2505 * src/modest-tny-account.c:
2506 (modest_tny_account_get_special_folder): Add TODO because this fails when
2507 the network is busy.
2508 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2509 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2510 Do not try to show this window when there is no active account. The UI
2511 specs does not tell us what to do in this case.
2513 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2517 * src/maemo/Makefile.am:
2518 * src/widgets/Makefile.am: Some dist fixes.
2520 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2522 * src/maemo/modest-connection-specific-smtp-window.c:
2523 (on_button_edit): Make the code clearer, to prevent a double free.
2525 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2527 * src/maemo/modest-account-settings-dialog.c:
2528 (modest_account_settings_dialog_set_account_name),
2529 Check the connection-specific smtp servers checkbox if there are any.
2531 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2532 (modest_connection_specific_smtp_edit_window_init):
2533 Start with a suitable port number.
2535 * src/modest-account-mgr-helpers.h:
2536 * src/modest-account-mgr-helpers.c: Added
2537 modest_account_mgr_get_has_connection_specific_smtp().
2539 (modest_account_mgr_set_connection_specific_smtp),
2540 (modest_account_mgr_remove_connection_specific_smtp),
2541 (modest_account_mgr_get_has_connection_specific_smtp),
2542 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2543 connection-specific smtp server accounts in the account, rather than
2544 the server account conf dir.
2546 This fixes bug projects.maemo.org bug NB#58263 .
2548 * src/modest-tny-account-store.c:
2549 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2550 if there are no server accounts yet, to prevent an infinite loop when there
2551 are no accounts. Document that one must be called before the other.
2553 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2555 * src/modest-account-mgr-helpers.c:
2556 (modest_account_mgr_get_default_account): Make sure that at least
2557 one account is always the default, if there are any enabled accounts.
2558 This is just a sanity check that shouldn't be necessary.
2560 * src/modest-account-mgr-priv.c:
2561 (_modest_account_mgr_account_from_key): Unescape the conf key to
2562 get the real account name. For instance, this is an issue if a space
2563 was in the account name, which can happen because the account name
2564 is generated from the display name.
2565 (_modest_account_mgr_get_account_keyname): Always escape the
2567 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2568 Unescape the conf keys to get the real account names.
2570 For instance, previously the is-default radio button in the accounts
2571 list was not checked for any accounts at first. This fixes that,
2572 and might fix several similar bugs.
2574 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2576 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2577 Removed some debug printfs.
2579 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2581 Modest on-disk outbox directories are now here, for instance:
2582 $HOME/.modest/outboxes/<account-id-1>/outbox
2583 $HOME/.modest/outboxes/<account-id-2>/outbox
2585 $HOME/.modest/local-folders/outbox
2586 so we can have a separate outbox for each account.
2587 But they are shown as one outbox in the GtkTreeView, by using a
2588 TnyMergeFolder in a ModestTnySimpleFolderStore.
2591 * src/modest-tny-simple-folder-store.c:
2592 * src/modest-tny-simple-folder-store.h:
2593 Added ModestTnySimpleFolderStore, used to contain folders from
2594 other folder stores, such as other accounts.
2596 * src/modest-tny-outbox-account.h:
2597 * src/modest-tny-outbox-account.c:
2598 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2599 used for the per-account local outbox folders.
2601 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2602 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2603 only use this (internally) now for the non-outbox local folders.
2605 * src/modest-init.h:
2606 * src/modest-init.c: Added modest_init_one_local_folder(), for
2607 setting up the directory structure for each local folder.
2609 * src/modest-local-folder-info.c:
2610 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2611 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2613 * src/modest-local-folder-info.h:
2614 * src/modest-tny-account-store.c: (on_account_removed),
2615 (on_account_changed), (create_per_account_local_outbox_folders),
2616 (get_server_accounts), (modest_tny_account_store_get_accounts),
2617 (modest_tny_account_store_get_tny_account_by_account),
2618 (modest_tny_folder_store_is_virtual_local_folders):
2620 * src/modest-tny-account.h:
2621 * src/modest-tny-account.c:
2622 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2623 to create an on-disk per-account local outbox folder for each
2625 (create_per_account_local_outbox_folders): Create a local outbox folder
2626 for each transport account.
2627 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2628 for all local folders.
2630 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2631 instead of using g_object_get/set() directly. It is clearer.
2633 (modest_tny_folder_store_get_message_count),
2634 (modest_tny_folder_store_get_local_size
2635 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2636 because we now use these with non-acount folder stores.
2638 (modest_tny_account_get_special_folder),
2639 (modest_tny_account_new_from_server_account),
2640 (modest_tny_account_new_from_account):
2641 (recurse_folders): Adjust to the new outbox system.
2643 * src/modest-tny-folder.h:
2644 * src/modest-tny-folder.c:
2645 (modest_tny_folder_is_local_folder),
2646 (modest_tny_folder_get_local_folder_type),
2647 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2649 * src/widgets/modest-main-window.h:
2650 * src/maemo/modest-main-window.c: (create_details_widget),
2651 (modest_main_window_set_contents_style): Show details for any folder store,
2654 (modest_tny_folder_get_rules):
2655 Remove the const. C does not support constness enough for this.
2657 * src/modest-ui-actions.c:
2658 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2659 make all outboxes appear as one, in the usual local-folders tree node.
2661 (set_active_account_from_tny_account),
2662 (modest_ui_actions_on_folder_selection_changed):
2663 * src/widgets/modest-folder-view.c: (text_cell_data),
2664 (icon_cell_data), (filter_row),
2665 (add_account_folders_to_merged_folder),
2666 (add_account_folders_to_simple_folder_store), (),
2667 (get_cmp_rows_type_pos), (cmp_rows),
2668 (modest_folder_view_set_account_id_of_visible_server_account):
2669 Adjust to the new outbox system, using generic folder stores and folders
2670 in the GtkTreeModel.
2672 2007-05-23 Christian Kellner <ckellner@openismus.com>
2674 * src/modest-mail-operation.c:
2675 (modest_mail_operation_update_account):
2676 Use info->max_size instead of unintialized local var [small
2677 build fix]. (Added TODO to review that change since I don't
2680 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2682 * libmodest-dbus-client/libmodest-dbus-client.c:
2683 (libmodest_dbus_client_compose_mail): function added
2684 * src/dbus_api/modest-dbus-api.h:
2685 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2686 (on_compose_mail): Implementation of the SendAsMail functionality
2688 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2690 * src/modest-account-mgr.c:
2691 (modest_account_mgr_add_server_account): Set the secure-connection
2692 conf key for transport accounts as well as store accounts. I don't know
2693 why the if was there. For instance, this makes sure that we use SSL
2694 for the gmail preset from the easysetup wizard.
2696 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2698 * src/gnome/modest-main-window.c:
2699 (on_account_store_connecting_finished), (connect_signals):
2700 * src/maemo/modest-main-window.c:
2701 (on_account_store_connecting_finished), (connect_signals),
2702 (modest_main_window_new):
2703 Handle TnyAccountStore::connecting-finished instead of
2704 TnyDevice::connection-changed, because we cannot actually perform
2705 operations on accounts until TnyAccountStore has itself responded to
2706 the TnyDevice::connection-changed signal. This prevents a GError from
2708 Do not try to update at startup, because we (at least on scratchbox)
2709 already do an update at startup when the device goes online.
2710 This prevents a GError from tinymail.
2711 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2712 Added TODO about stopping simultaneous operations.
2714 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2716 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2717 * src/modest-mail-operation-queue.c:
2718 (modest_mail_operation_queue_remove):
2719 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2720 about where they happened.
2722 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2724 * src/modest-ui-actions.c:
2725 (modest_ui_actions_on_password_requested): Make sure that the remember
2726 output parameter is always TRUE.
2728 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2730 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2731 Show a OK/Cancel dialog if the error is a question, though we still do not
2732 know anything more about what we are asking the user.
2733 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2734 Fix an uninitialized variable (helper). This is a logic error, however.
2736 2007-05-21 Christian Kellner <ckellner@openismus.com>
2738 * src/modest-search.h:
2739 Correct bit shifting in the ModestSearchFlags enum.
2741 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2743 * src/modest-tny-account.c:
2744 (modest_tny_account_new_from_server_account): Do not use the lsub and
2745 check-all hard-coded IMAP options when using POP.
2747 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2749 * src/modest-tny-account.c:
2750 (modest_tny_account_new_from_server_account):
2751 Use NULL for the secure-auth method for POP when Password auth has been
2752 specified by the user, as we already do for IMAP. "auth=Login" causes
2753 an error from camel or the server.
2755 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2757 * src/maemo/modest-account-settings-dialog.c:
2758 (create_page_account_details),
2759 (modest_account_settings_dialog_set_account_name):
2760 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2761 for the leave-on-server checkbox, rathr than just the checkbox, when
2762 the protocol is not POP.
2764 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2766 * src/widgets/modest-account-view.c:
2767 * src/widgets/modest-account-view.h:
2768 Added modest_account_view_select_account() which will be useful later
2769 to asynchronously re-select the edited account.
2771 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/modest-account-settings-dialog.c:
2774 (modest_account_settings_dialog_set_account_name):
2775 Automatically choose the port numbers based on the secure authentication
2776 methods, if they have not been chosen before.
2777 This fixes projects.maemo.org bug NB#56273 .
2779 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/modest-main-window-ui.h:
2782 * src/modest-ui-actions.c:
2783 * src/modest-ui-actions.h:
2784 Connect the Tools/SMTP Servers menu item to
2785 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2786 SMTP servers dialog, as in the UI specification and saves changes when it
2787 is closed. This fixed projects.maemo.org bug NB#56305 .
2789 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2791 * src/maemo/modest-connection-specific-smtp-window.c:
2792 (modest_connection_specific_smtp_window_init):
2793 Use gtk_window_set_default_size() to make this window big enough, so
2794 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2796 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2798 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2799 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2800 (modest_connection_specific_smtp_edit_window_init),
2801 Do not try to connect to a combobox signal before the combobox exists.
2802 This fixes the cras in projects.maemo.org bug NB#56288 .
2803 (modest_connection_specific_smtp_edit_window_get_settings):
2804 Remove the server_account_name parameter which was being checked for NULL
2805 though it was not used.
2807 * src/maemo/modest-connection-specific-smtp-window.c:
2808 (modest_connection_specific_smtp_window_fill_with_connections),
2809 (on_button_edit), (modest_connection_specific_smtp_window_init):
2810 Correct the number of treemodel columns to prevent a warning.
2811 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2812 libconic does not work.
2814 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2816 * src/modest-tny-account.c:
2817 (modest_tny_account_new_from_server_account):
2818 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2819 SMTP when "None" was chosen by the user. However, with my SMTP server that
2820 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2823 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2825 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2826 to explain the memory management issue with the ID in the ModestPair.
2828 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2829 (add_sending_page), (modest_account_assistant_finalize):
2830 * src/gnome/modest-gnome-global-settings-dialog.c:
2831 (create_updating_page), (create_composing_page):
2832 * src/gnome/modest-msg-edit-window.c: (get_transports),
2833 (init_window), (modest_msg_edit_window_finalize),
2834 (modest_msg_edit_window_get_msg_data):
2835 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2836 * src/gnome/modest-transport-widget.c:
2837 (modest_transport_widget_finalize), (smtp_configuration):
2838 * src/maemo/modest-maemo-global-settings-dialog.c:
2839 (create_updating_page), (create_composing_page):
2840 * src/maemo/modest-msg-edit-window.c: (get_transports),
2841 (init_window), (modest_msg_edit_window_finalize),
2842 (modest_msg_edit_window_get_msg_data),
2843 (modest_msg_edit_window_free_msg_data):
2844 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2845 (modest_store_widget_finalize):
2846 * src/maemo/modest-transport-widget.c:
2847 (modest_transport_widget_finalize), (smtp_configuration):
2848 * src/modest-main.c: (send_mail):
2849 * src/widgets/modest-combo-box.h:
2850 * src/widgets/modest-global-settings-dialog-priv.h:
2851 * src/widgets/modest-global-settings-dialog.c:
2852 (modest_global_settings_dialog_finalize):
2853 * src/widgets/modest-msg-edit-window.h:
2854 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2855 as long as the combo box, to prevent use of freed memory for the ID.
2857 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2859 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2860 get_accounts(), to make this clearer. Do not check for the enabled gconf
2861 key, because we do not use this for server accounts (at least, not yet).
2862 This allows us to send email again.
2864 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/modest-platform.c:
2867 (on_modest_conf_update_interval_changed), (modest_platform_init):
2868 Only respond to this particular key change. All these strcmp()s cannot be
2871 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2873 * src/maemo/modest-maemo-global-settings-dialog.c:
2874 (current_connection): Prevent a crash in scratchbox when
2875 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2876 * src/maemo/modest-platform.c:
2877 (on_modest_conf_update_interval_changed), (modest_platform_init):
2878 Get the update interval from gconf and reset it when the gconf key changes.
2880 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2882 * src/modest-protocol-info.c:
2883 * src/modest-protocol-info.h: Adde enum-specific get functions,
2884 instead of using a ModestProtocolType enum parameter.
2886 * src/gnome/modest-account-assistant.c:
2887 * src/gnome/modest-store-widget.c:
2888 * src/gnome/modest-store-widget.h:
2889 * src/gnome/modest-transport-widget.c:
2890 * src/gnome/modest-transport-widget.h:
2891 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2892 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2893 * src/maemo/easysetup/modest-easysetup-wizard.c:
2894 * src/maemo/modest-account-settings-dialog.c:
2895 * src/maemo/modest-account-settings-dialog.h:
2896 * src/maemo/modest-store-widget.c:
2897 * src/maemo/modest-store-widget.h:
2898 * src/maemo/modest-transport-widget.c:
2899 * src/maemo/modest-transport-widget.h:
2900 * src/modest-account-mgr-helpers.c:
2901 * src/modest-account-mgr-helpers.h:
2902 * src/modest-account-mgr.c:
2903 * src/modest-account-mgr.h:
2904 * src/modest-tny-account.c:
2905 * src/modest-tny-folder.c:
2906 * src/widgets/modest-account-view.c:
2907 * src/widgets/modest-retrieve-combo-box.c:
2908 * src/widgets/modest-retrieve-combo-box.h:
2909 * src/widgets/modest-secureauth-combo-box.c:
2910 * src/widgets/modest-serversecurity-combo-box.c:
2911 * src/widgets/modest-serversecurity-combo-box.h:
2912 * tests/check_account-mgr.c:
2913 Use the specific functions, and use the re-renamed enum values for GNOME too.
2915 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2917 * src/modest-pair.h:
2918 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2919 so we can get the second based on the first.
2921 * src/maemo/modest-account-settings-dialog.h:
2922 * src/maemo/modest-account-settings-dialog.c:
2923 Added get_supported_secure_authentication_methods(), though it is mostly
2924 commented-out for now until the necessary API is committed to tinymail.
2925 (modest_account_settings_dialog_set_account_name),
2926 (save_configuration): Request the supported authentication methods from the
2927 server, so we can choose a working method.
2929 * src/modest-tny-account-store.h:
2930 * src/modest-tny-account-store.c:
2931 (modest_tny_account_store_get_session): Rename from
2932 tny_account_store_get_session().
2934 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2936 * src/modest-protocol-info.h: Split the ModestProtocol enum
2937 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2938 There was no need to have these unrelated values in one enum.
2940 * src/: many files: Adapted to changed enum. This makes the code a bit
2941 clearer, and the compiler could catch some errors.
2943 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2945 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2946 Show the detailed internal camel error message when an error happens
2947 during the configuration, so that our testers can give us more clues.
2948 For instance, in projects.maemo.org bug NB#56910 .
2950 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2952 * src/modest-tny-account.c:
2953 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2954 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2956 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2958 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2959 * src/maemo/modest-account-settings-dialog.c:
2960 (modest_account_settings_dialog_set_account_name),
2961 (save_configuration): For the incoming secure authentication checkbox,
2962 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2963 the UI specification. PLAIN does not seem to be supported for most IMAP
2964 servers anyway, and I am not sure what it would mean.
2965 However, we probably need to discover which of the secure-authentication
2966 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2967 * src/modest-account-mgr-helpers.c:
2968 (modest_account_mgr_get_server_account_data):
2970 * src/modest-tny-account.c:
2971 (modest_tny_account_new_from_server_account):
2972 Use tny_account_set_mech() to set secure-authentication methods,
2973 with some special-casing for IMAP, based on my observations of how
2976 * src/modest-account-mgr-helpers.h:
2977 * src/modest-account-mgr.c:
2978 * src/modest-defs.h: Comment that the URI is only used for local folders.
2980 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2983 parameter const, just to be neat.
2984 * src/modest-text-utils.c: (modest_text_utils_inline):
2985 End g_strconcat() with NULL, as its documentation says. This is almost
2986 certainly the cause of my crash at startup on the device. Interestingly,
2987 valgrind doesn't tell us about these errors.
2989 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2991 * scripts/build-packages: Added more precise comments about how to use
2992 this script, though I still get this error:
2993 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2994 error building tinymail
2996 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2998 * src/maemo/modest-main-window.c: (on_account_update):
2999 Very slight cleanup, hoping to make it simpler to discover what causes
3000 a crash here sometimes.
3002 * src/modest-tny-account.c:
3003 (modest_tny_account_new_from_server_account): Set the port. Added
3004 comments about the options and a TODO comment because I need to find out
3005 how to specify the secure authentication method.
3007 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3009 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3010 changed CFlags paths form modest to libmodest
3012 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3014 * src/modest-account-mgr-helpers.c:
3015 (modest_account_mgr_get_server_account_data),
3016 (modest_account_mgr_free_server_account_data):
3017 * src/modest-account-mgr-helpers.h:
3018 * src/modest-account-mgr.c:
3019 (modest_account_mgr_add_server_account):
3020 * src/modest-defs.h:
3021 * src/modest-tny-account.c:
3022 (modest_tny_account_new_from_server_account):
3023 Determine the options for tny_camel_account_add_option() here,
3024 based on the settings, rather than storing them directly in gconf.
3026 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3028 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3029 Show a more friendly error dialog now that we expect (from the tinymail
3030 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3032 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3034 * src/maemo/modest-main-window.c: (on_account_update): Check that
3035 account_name is not NULL, to prevent a crash at startup that I am
3036 seeing on the N800. I do wonder why it is NULL.
3038 * src/maemo/easysetup/modest-easysetup-wizard.c:
3039 (create_page_user_details):
3040 * src/maemo/modest-account-settings-dialog.c:
3041 (create_page_user_details), (create_page_outgoing):
3042 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3043 (modest_connection_specific_smtp_edit_window_init):
3044 * src/modest-ui-actions.c:
3045 (modest_ui_actions_on_password_requested):
3046 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3047 might do something useful with the on-screen keyboard.
3049 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3051 * src/maemo/modest-main-window.c: (on_account_update):
3052 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3053 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3055 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3057 * src/modest-tny-account-store.c: (on_account_changed):
3058 Correct the signature of this signal handler.
3060 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3062 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3063 Show a HildonNote instead of a GtkDialog for Maemo.
3065 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3067 * src/widgets/modest-account-view.h:
3068 * src/widgets/modest-account-view.c: (on_account_changed),
3069 (on_account_removed). Added a boolean flag, set/unset by
3070 modest_account_view_block_conf_updates(),
3071 modest_account_view_unblock_conf_updates() to prevent unnecessary
3072 updates, but this is not very useful because the gconf notifications are
3073 so delays (maybe only on Maemo Bora).
3074 So auto-updating is turned off, and these functions do an explicit
3075 update when necessary.
3076 However, something else is still doing too much work when adding/removing
3077 accounts, probably in another part of the application.
3079 * src/maemo/modest-account-view-window.c:
3080 (on_delete_button_clicked), (on_edit_button_clicked),
3081 (on_new_button_clicked): Use the new functions.
3083 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3085 * src/modest-account-mgr-helpers.c:
3086 (modest_account_mgr_set_first_account_as_default):
3087 Sort the list of names alphabetically-by-title, so we choose the first one
3089 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3090 alphabetically by the title.
3092 This fixes projects.maemo.org bug NB#56418 .
3094 * src/modest-account-mgr-priv.c:
3095 (_modest_account_mgr_account_from_key):
3096 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3097 avoid a valgrind error, and possible random behaviour.
3099 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3101 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3102 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3103 tinymail documentation to say that this can be expected.
3104 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3105 pretty, and should not happen, but I would prefer to know when it does.
3107 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3109 * configure.ac: When using the older hildon version, probably on Bora,
3110 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3112 * src/widgets/modest-attachment-view.c:
3113 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3116 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3118 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3119 Implemented the prototype. Can be tested with
3120 tests/dbus_api/test_open_message:
3122 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3124 * src/modest-tny-account-store.c:
3125 (modest_tny_account_store_instance_init), (get_password):
3126 * src/modest-ui-actions.c:
3127 (modest_ui_actions_on_password_requested):
3128 Do not store the password in gconf, because this function is called
3129 for non-remembered passwords. Actually use the cached (in the hash map)
3130 password instead of releasing it.
3131 The password will now not be remembered if it is asked via the protected
3132 password dialog, as per the UI spec.
3134 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3136 * src/modest-defs.h:
3137 * src/modest-account-mgr-helpers.h:
3138 * src/modest-account-mgr-helpers.c:
3139 Added modest_server_account_get_username_has_succeeded(),
3140 modest_server_account_set_username_has_succeeded().
3141 (modest_server_account_set_username),
3142 Reset the has-succeeded flag if the username changes.
3144 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3145 * src/maemo/modest-connection-specific-smtp-window.c:
3146 (modest_connection_specific_smtp_window_save_server_accounts):
3147 Use modest_server_account_set_username() instead of using
3148 modest_conf_set_string() directly, so that the has-succeeded flag is always
3151 * src/modest-ui-actions.c:
3152 (modest_ui_actions_on_password_requested): Dim the username entry if
3153 the username has ever worked, as per the UI spec.
3155 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3157 * src/modest-tny-account-store.c: (get_password):
3158 * src/modest-ui-actions.c:
3159 (modest_ui_actions_on_password_requested):
3160 Allow the username to be changed too, though there is more work to
3161 be done on exactly how this behaves.
3163 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3165 * src/modest-account-mgr-helpers.h:
3166 * src/modest-account-mgr-helpers.c:
3167 Added modest_account_mgr_get_display_name(),
3168 modest_server_account_get_username(),
3169 modest_server_account_set_username(),
3170 modest_server_account_set_password(),
3171 modest_server_account_get_hostname() functions so we do not need to
3172 use the conf API directly.
3174 * src/maemo/modest-main-window.c: (connect_signals):
3175 Actually connect ot the ModestAccountStore::request-password signal,
3176 so that we show the dialog when the password is requested by Tinymail,
3177 for isntance if it is empty.
3179 * src/modest-marshal.list:
3180 * src/modest-tny-account-store.c:
3181 (modest_tny_account_store_class_init), (get_password),
3182 (modest_tny_account_store_alert):
3183 * src/modest-tny-account-store.h:
3184 * src/modest-ui-actions.h:
3185 * src/modest-ui-actions.c:
3186 (modest_ui_actions_on_password_requested):
3187 Change the signal parameters, so it is obvious that we are providing
3188 the non human-readable server name, and receiving both the username
3189 and password, though changing of the username is not yet implemented.
3190 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3191 for the GNOME version.
3193 This should fix the projects.maemo.org bug NB#56209, though it does not
3194 work on Bora, because the gconf_client_get() for the password fails
3195 immediately after we save it with gconf_client_set().
3197 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3200 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3201 caused an undefined symbol error:
3202 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3204 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3206 * src/modest-tny-account-store.c:
3207 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3208 using a GError instead of a string message, so we can translate it in
3211 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/modest-address-book.c:
3214 (modest_address_book_check_names):
3215 * src/maemo/modest-msg-view-window.c:
3216 (modest_msg_view_window_clipboard_owner_change):
3217 * src/modest-init.c: (modest_init_init_ui):
3218 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3219 (update_folders_cb), (modest_mail_operation_update_account):
3220 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3221 (modest_ui_actions_on_msg_attachment_clicked),
3222 (modest_ui_actions_on_msg_recpt_activated):
3223 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3224 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3225 (modest_msg_view_search_next):
3226 * src/widgets/modest-recpt-editor.c:
3227 (modest_recpt_editor_on_button_release_event),
3228 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3229 g_message(). At this point we should only be seeing interesting errors on
3230 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3232 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3234 (modest_wizard_dialog_force_title_update):
3235 * src/maemo/easysetup/modest-wizard-dialog.h:
3236 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3237 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3238 can update the title when appropriate. Otherwise the title is wrong if the
3239 pages are added after adding the notebook to the dialog.
3240 This must be a problem in HildonWizardDialog too.
3241 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3243 * src/maemo/easysetup/modest-easysetup-wizard.c:
3244 (create_subsequent_customsetup_pages),
3245 (create_subsequent_easysetup_pages):
3246 Call modest_wizard_dialog_force_title_update() so that the title is
3247 correct even with GTK+ < 2.10.
3248 This fixes projects.maemo.org bug NB#56145 .
3250 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3252 * src/maemo/modest-platform.c:
3253 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3254 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3257 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3259 * src/widgets/modest-window.h:
3260 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3261 and modest_window_save_state(), which invokes it.
3263 * src/widgets/modest-window-mgr.h:
3264 * src/widgets/modest-window-mgr.c:
3265 Added modest_window_mgr_save_state_for_all_windows(), which calls
3266 the save_state vfunc on all registered windows, if implemented.
3268 * src/gnome/modest-msg-edit-window.c:
3269 * src/gnome/modest-msg-view-window.c:
3270 * src/maemo/modest-msg-edit-window.c:
3271 * src/maemo/modest-msg-view-window.c:
3272 * src/maemo/modest-main-window.c:
3273 Specify the existing save_settings functions as implementations of
3274 ModestWindow::save_state_func().
3276 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3277 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3278 enabling hibernation, for instance.
3280 We may need to do the same thing for restoring settings.
3283 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3285 * src/widgets/modest-window-mgr.c:
3286 * src/widgets/modest-window-mgr.h:
3287 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3288 modest_window_mgr_get_hibernation_is_prevented().
3290 * src/maemo/modest-main-window.c:
3291 (on_hildon_program_is_topmost_notify): Prevent hibernation
3292 (possible when the application goes to the background in the WM),
3293 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3295 * src/maemo/easysetup/modest-easysetup-wizard.c:
3296 (modest_easysetup_wizard_dialog_init):
3297 * src/maemo/modest-account-settings-dialog.c:
3298 (modest_account_settings_dialog_init):
3299 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3300 (modest_connection_specific_smtp_edit_window_init):
3301 * src/maemo/modest-connection-specific-smtp-window.c:
3302 (modest_connection_specific_smtp_window_init):
3303 * src/maemo/modest-signature-editor-dialog.c:
3304 (modest_signature_editor_dialog_init):
3305 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3306 prevent hibernation while any of these account settings dialogs are open.
3308 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3310 * src/maemo/Makefile.am:
3311 * src/maemo/modest-osso-state-saving.c:
3312 * src/maemo/modest-osso-state-saving.h: Added
3313 modest_osso_load_state() and modest_osso_save_state() though they do
3314 nothing now. They should iterate through all the open windows and load/save
3316 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3317 save state when closing.
3319 * src/maemo/modest-main-window.c:
3320 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3321 Add a notification handler for the HildonProgram::is-topmost property,
3322 so we can allow hibernation when the application goes into the background.
3323 But we still need to detect when the accounts setup windows are open so
3324 we can stop hibernation when they are open.
3325 To do this, I also added the main window the HildonProgram. This might have
3326 other side-effects/benefits, and should maybe be done for other windows.
3328 * src/maemo/modest-osso-autosave-callbacks.h:
3329 * src/maemo/modest-osso-autosave-callbacks.c:
3330 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3331 though it does not do anything yet, and we might never need this to do
3332 anything. For instance, we already save drafts.
3334 * src/maemo/modest-platform.c: (modest_platform_init):
3335 Specify the libosso auto-save callback.
3337 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3339 * src/maemo/modest-platform.c:
3340 (modest_platform_set_update_interval):
3341 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3342 aparently stays valid between application instances, so we can use this
3343 to remove and reset it later. According to a maemo-developers email from
3346 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3348 * configure.ac: Depend on libalarm for Maemo.
3350 * src/dbus_api/modest-dbus-api.h:
3351 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3352 (on_send_receive), (modest_dbus_req_handler):
3353 Handle a SEND_RECEIVE D-Bus method.
3355 * libmodest-dbus-client/libmodest-dbus-client.c:
3356 (libmodest_dbus_client_send_and_receive):
3357 * libmodest-dbus-client/libmodest-dbus-client.h:
3358 Add C convenience functions for calling the new D-Bus method.
3360 * src/modest-platform.h:
3361 * src/gnome/modest-platform.c:
3362 * src/maemo/modest-platform.c:
3363 Added modest_platform_set_update_interval(), which uses the
3364 alarmd API on Maemo.
3365 (modest_platform_init),
3366 Call modest_platform_set_update_interval(), using a hard-coded
3367 interval for now (until the global settings dialog is implemented),
3368 though I am not sure that this makes sense yet.
3370 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3372 * src/dbus_api/modest-dbus-callbacks.c:
3373 (modest_osso_cb_hw_state_handler):
3374 * src/dbus_api/modest-dbus-callbacks.h:
3375 * src/maemo/modest-platform.c: (modest_platform_init):
3376 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3377 in case this has some effect on the ability for Maemo to ping the
3380 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3382 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3383 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3384 warning. It is probably a logic error, but I need to fix the build.
3386 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3388 * src/modest-account-mgr.h:
3389 * src/modest-account-mgr.c:
3390 (modest_account_mgr_account_names): Add a gboolean enabled_only
3391 parameter, so we can get lists of onlt the enabled accounts.
3393 (modest_account_mgr_add_account),,
3394 (modest_account_mgr_account_with_display_name_exists):
3395 * src/maemo/modest-msg-edit-window.c: (get_transports):
3396 * src/modest-account-mgr-helpers.c:
3397 (modest_account_mgr_set_first_account_as_default):
3398 * src/modest-init.c: (init_default_account_maybe):
3399 * src/modest-tny-account-store.c: (get_accounts):
3400 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3401 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3402 * tests/check_account-mgr.c: (START_TEST):
3403 Provide the extra parameter, as appropriate.
3405 * src/widgets/modest-account-view.c: (update_account_view):
3406 Do not show disabled accounts (meaning that there is no way to
3407 enable/disable accounts in the UI (the feature is not in our UI
3408 specification), so we can use this internally only to mark unfinished
3409 or temporary account data.
3411 * src/maemo/easysetup/modest-easysetup-wizard.c:
3412 (create_account): Add boolean enable parameter, so we can specify FALSE
3413 to create the temporary account.
3414 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3415 (on_before_next): When finishing, when there is a temporary account, just
3417 Also, use a timeout to delay the showing of the dialog until gconf is likely
3418 to return correct information, due to a maemo gconf bug that is fixed in
3419 osso 1.1, but not yet in Bora.
3420 However, the dialog stays on screen after it is destroyed.
3422 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3423 for invalid data when cancelling. Use a hildon note instead of a dialog
3424 to complain about invalid data. Do not show the account-saved note if the
3425 account is disabled (a temporary account that will not really be saved for use
3428 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3430 * src/modest-account-mgr-helpers.h:
3431 * src/modest-account-mgr-helpers.c:
3432 Added modest_account_mgr_unset_default_account(),
3433 Added modest_account_mgr_set_first_account_as_default().
3435 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3436 If it was the default account, unset the default account name.
3438 * src/maemo/modest-account-view-window.c:
3439 (on_delete_button_clicked): If it was the default account,
3440 set the first remaining account as the default instead.
3442 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3443 a NULL account or a NULL default account, to prevent a crash. This should
3444 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3447 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3449 * src/widgets/modest-recpt-editor.c:
3450 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3451 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3452 TODO comment for this. This fixes the build.
3454 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3455 be the best place for it. This will in future update all auto-update accounts,
3456 rather than just the current/default account, when that gconf key exists.
3457 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3458 if there are no accounts, before calling do_send_receive().
3459 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3461 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3462 * src/maemo/modest-main-window-ui.h:
3463 * src/maemo/modest-main-window.c: (on_connection_changed),
3464 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3465 directly, becaue the signal handler does more.
3467 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3469 * src/modest-account-mgr-helpers.c:
3470 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3471 for the case that the account does not exist.
3473 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3474 (equivalent to the modest account name) rather than the tinymail account name
3475 (equivalent to the modest account title - human readable) to get the account data.
3476 Check for null account data to prevent the crash, and add a TODO comment saying that
3477 this needs fixing because it is using the server account name instead of the account name.
3479 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3481 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3482 * src/maemo/modest-account-settings-dialog.c: (show_error),
3484 Use hildon_note_new_information() for informative and error messages,
3485 which seems to be expected for Maemo applications (no documentation that I know of
3486 says this). I am surprised that there is no distinction between info and error
3489 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3492 it is easy to find where this is used.
3494 * src/maemo/easysetup/modest-easysetup-wizard.c:
3495 (create_page_welcome), (create_page_account_details),
3496 (create_page_user_details), (create_page_complete_easysetup),
3497 (create_page_custom_incoming), (create_page_custom_outgoing),
3498 (create_page_complete_custom):
3499 * src/maemo/modest-account-settings-dialog.c:
3500 (create_page_account_details), (create_page_user_details),
3501 (create_page_incoming), (create_page_outgoing):
3502 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3503 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3504 (modest_connection_specific_smtp_edit_window_init):
3505 * src/maemo/modest-connection-specific-smtp-window.c:
3506 (modest_connection_specific_smtp_window_init):
3507 * src/maemo/modest-signature-editor-dialog.c:
3508 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3509 and scrolling policy as per the Email Application Layout Guide, if I have
3512 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3514 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3515 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3516 which were empty, because these vfuncs have been removed from TnyAccountStore.
3517 This fixes the build.
3519 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3521 * src/maemo/modest-main-window.c:
3522 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3523 showing/hiding it. Added TODO because it probably should not be NULL.
3524 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3525 because unnecessary g_warnings() make degugging difficult.
3527 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3529 * src/maemo/modest-msg-edit-window.c:
3530 (modest_msg_edit_window_select_color),
3531 (modest_msg_edit_window_select_background_color): 2 const corrections and
3532 moving 2 #endifs before closing brackets, to fix the build.
3534 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3536 * src/maemo/easysetup/modest-easysetup-wizard.h:
3537 * src/maemo/easysetup/modest-easysetup-wizard.c:
3538 (modest_easysetup_wizard_dialog_finalize),
3539 (on_button_edit_advanced_settings), (create_page_complete_custom),
3540 (on_response), (create_account):
3541 Implement the Advanced Settings edit button, by saving the account information,
3542 for the Advanded Settings dialog to use directly from gconf, and removing it
3543 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3544 Bug #5533 in the projects.maemo.org bugzilla.
3546 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/modest-msg-view-window.c:
3549 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3550 when opening a message window.
3552 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3554 * src/maemo/easysetup/modest-easysetup-wizard.c:
3555 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3558 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3559 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3560 gconf settings. I probably added more checks than necessary, but that is safer.
3562 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3563 variable to fix the build, but this seems to be used when it is still NULL.
3565 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3567 * src/modest-platform.h:
3568 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3569 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3570 * src/modest-main.c: Implement this function so we can avoid using
3571 maemo-specific API from cross-platform code.
3573 * src/modest-tny-account-store.c:
3574 (get_smtp_specific_transport_account_for_open_connection):
3575 * src/modest-ui-actions.c: (check_for_connection),
3576 (modest_ui_actions_on_item_not_found):
3577 Use modest_platform_connect_and_wait() and put #idefs around other
3578 maemo-specific code, because only maemo currently has a way to
3579 identify connection names.
3581 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3583 * src/modest-tny-account-store.h:
3584 * src/modest-tny-account-store.c:
3585 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3586 the connection-specific SMTP server settings in the configuration.
3588 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3590 * src/maemo/modest-main-window.c: (on_connection_changed),
3592 * src/modest-main.c: (main), (start_ui), (send_mail):
3593 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3594 that is what is intended.
3596 * src/modest-ui-actions.c: (action_send), (action_receive),
3597 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3598 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3599 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3600 SMTP server is used when it is specified.
3602 (modest_ui_actions_on_send_receive):
3603 Check that a connection is open before proceeding.
3604 Receive and then send, instead of vice-versa, as per the specification.
3606 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3608 * src/modest-mail-operation.c:
3609 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3610 though I guess it should be something other than NULL.
3612 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3614 * src/maemo/easysetup/modest-easysetup-wizard.c:
3615 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3616 combo twice, to avoid an g_warning and to make it visible again.
3617 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3618 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3619 (already intended) dereference when detaching, because we then recreate the menu.
3620 But I am not sure why the warning was happening, and it is possible that this is a memory
3623 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3625 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3626 and uri_parse_mailto() utility functions.
3627 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3629 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3631 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3633 * src/dbus_api/modest-dbus-api.h:
3634 * src/dbus_api/modest-dbus-callbacks.c:
3635 Use an idle callback to execute the modest code in the application's own thread.
3636 Remove the helloworld example method.
3637 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3638 parsed, and the open-message method is not implemented because this is not yet implemented in
3640 * libmodest-dbus-client/libmodest-dbus-client.c:
3641 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3642 (libmodest_dbus_client_open_message):
3643 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3645 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3646 body without crashing.
3648 * tests/dbus_api/Makefile.am:
3649 * tests/dbus_api/test_mail_to.c:
3650 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3652 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3654 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3655 Added file to fix the build. Sorry.
3657 * src/dbus_api/Makefile.am:
3658 * src/dbus_api/modest-dbus-api.h:
3659 * src/dbus_api/modest-dbus-callbacks.h:
3660 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3661 (modest_dbus_req_handler):
3662 Put constants in a separate header so it can be reused by the
3663 client library, without duplication
3665 * libmodest-dbus-client/Makefile.am:
3666 * libmodest-dbus-client/libmodest-dbus-client.c:
3667 (libmodest_dbus_client_call_helloworld),
3668 (libmodfest_dbus_client_send_mail),
3669 (libmodfest_dbus_client_mailto),
3670 (libmodfest_dbus_client_open_message):
3671 * libmodest-dbus-client/libmodest-dbus-client.h:
3672 (Partly) Implement a send_mail D-Bus method.
3674 * tests/dbus_api/Makefile.am:
3675 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3676 the send_email D-Bus method.
3678 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3682 * libmodest-dbus-client/Makefile.am:
3683 * libmodest-dbus-client/libmodest-dbus-client.c:
3684 * libmodest-dbus-client/libmodest-dbus-client.h:
3685 * tests/dbus_api/Makefile.am:
3686 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3687 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3689 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3691 * src/maemo/easysetup/modest-easysetup-wizard.c:
3692 (create_page_account_details):
3693 * src/maemo/modest-account-settings-dialog.c:
3694 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3695 widgets, because this might not be the default in future versions of the Maemo GTK+.
3696 However, I can not not get capitalization to work even in a simple test case.
3698 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3700 * src/maemo/easysetup/modest-easysetup-wizard.c:
3701 (create_page_custom_incoming), (create_page_custom_outgoing):
3702 * src/maemo/modest-account-settings-dialog.c:
3703 (create_page_account_details), (create_page_incoming),
3704 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3705 instead of using gtk_check_button_with_label(), so they are aligned like the other
3706 widgets, as per the UI spec.
3708 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3710 * src/maemo/easysetup/modest-easysetup-wizard.c:
3711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3712 * src/widgets/modest-validating-entry.c:
3713 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3714 Modest prefix instead of an EasySetup prefix.
3716 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3718 * src/widgets/modest-validating-entry.h:
3719 * src/widgets/modest-validating-entry.c: (on_insert_text),
3720 Added easysetup_validating_entry_set_max_func(), used to set a callback
3721 to call when the max number of characters is reached. GtkEntry has a max-length
3722 already but is silent about it.
3724 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3725 (create_page_account_details), (create_page_user_details),
3727 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3728 (create_page_account_details), (create_page_user_details),
3729 (create_page_outgoing):
3730 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3731 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3732 the UI spec, when the user tries to enter more than the max number of characters.
3734 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3736 * src/maemo/easysetup/modest-easysetup-wizard.c:
3737 (create_page_user_details), (create_page_custom_incoming),
3738 (create_page_custom_outgoing):
3739 * src/maemo/modest-account-settings-dialog.c:
3740 (create_page_user_details), (create_page_incoming),
3741 (create_page_outgoing):
3742 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3743 (modest_connection_specific_smtp_edit_window_init):
3744 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3745 not appropriate. Bad Maemo-specific defaults!.
3747 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3749 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3750 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3751 (modest_signature_editor_dialog_set_settings):
3752 Disable the label and textview when the checkbox is disabled, and use the
3753 specified (UI spec) default signature text.
3755 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3758 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3760 * src/modest-defs.h:
3761 * src/modest-account-mgr-helpers.h:
3762 * src/modest-account-mgr-helpers.c:
3763 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3765 * src/maemo/Makefile.am:
3766 * src/maemo/modest-signature-editor-dialog.c:
3767 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3770 * src/maemo/modest-account-settings-dialog.h:
3771 * src/maemo/modest-account-settings-dialog.c:
3772 (modest_account_settings_dialog_finalize), (on_button_signature),
3773 (save_configuration): Use the new dialog when the Edit button is pressed, and
3774 save the changes if necessary, as per the UI spec.
3776 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3778 * src/maemo/Makefile.am:
3779 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3780 based on maemo-develoers email from Dirk.
3782 * src/maemo/easysetup/modest-easysetup-wizard.c:
3783 (create_page_welcome), (create_page_account_details),
3784 (create_page_user_details), (create_page_complete_easysetup),
3785 (create_page_custom_incoming), (create_page_custom_outgoing),
3786 (create_page_complete_custom),
3787 (modest_easysetup_wizard_dialog_init):
3788 * src/maemo/modest-account-settings-dialog.c:
3789 (create_page_account_details), (create_page_user_details),
3790 (create_page_incoming), (create_page_outgoing),
3791 (modest_account_settings_dialog_init):
3792 * src/maemo/modest-connection-specific-smtp-window.c:
3793 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3795 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3797 * src/maemo/easysetup/modest-easysetup-wizard.c:
3798 (create_page_account_details), (create_page_custom_outgoing),
3799 (create_page_complete_custom):
3800 * src/maemo/modest-account-settings-dialog.c:
3801 (create_page_user_details), (create_page_incoming),
3802 (create_page_outgoing):
3803 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3804 (modest_connection_specific_smtp_edit_window_init):
3805 Use the correct (UI spec) port min/max, and use horizontal separators,
3808 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3810 * src/maemo/easysetup/modest-easysetup-wizard.c:
3811 (set_default_custom_servernames):
3812 * src/maemo/modest-account-settings-dialog.c:
3813 (create_page_incoming), (on_combo_outgoing_security_changed),
3814 (on_combo_incoming_security_changed), (create_page_outgoing),
3815 (modest_account_settings_dialog_set_account_name),
3816 (save_configuration):
3817 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3818 (on_combo_security_changed),
3819 (modest_connection_specific_smtp_edit_window_init),
3820 (modest_connection_specific_smtp_edit_window_set_connection),
3821 (modest_connection_specific_smtp_edit_window_get_settings):
3822 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3825 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3828 * src/maemo/easysetup/modest-easysetup-wizard.c:
3829 (create_page_custom_outgoing), (create_page_complete_custom):
3830 * src/maemo/modest-account-settings-dialog.c:
3831 (create_page_user_details), (create_page_outgoing):
3832 * src/maemo/modest-account-view-window.c: (button_box_new):
3833 Use changed logical IDs as per the most recent UI spec:
3834 mcen_bd_emailsetup_edit -> mcen_bd_edit
3835 mcen_bd_emailsetup_delete -> mcen_bd_delete
3836 mcen_bd_emailsetup_close -> mcen_bd_close
3838 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3842 * src/dbus_api/Makefile.am:
3843 * src/dbus_api/modest-dbus-callbacks.c:
3844 * src/dbus_api/modest-dbus-callbacks.h:
3845 * src/maemo/modest-platform.c: (modest_platform_init):
3846 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3848 * tests/Makefile.am:
3849 * tests/dbus_api/Makefile.am:
3850 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3852 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3854 * src/maemo/modest-account-settings-dialog.c:
3855 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3856 Removed unnecessary includes.
3858 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3860 * src/maemo/easysetup/modest-easysetup-wizard.c:
3861 * src/maemo/modest-account-settings-dialog.c:
3862 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3863 * src/widgets/Makefile.am:
3864 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3865 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3866 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3867 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3868 * src/widgets/modest-secureauth-combo-box.c:
3869 * src/widgets/modest-secureauth-combo-box.h:
3870 * src/widgets/modest-serversecurity-combo-box.c:
3871 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3872 made the GObject names more consistent with the rest of the Modest code.
3874 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3876 * src/maemo/easysetup/Makefile.am:
3877 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3878 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3879 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3880 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3881 * src/maemo/easysetup/modest-easysetup-wizard.c:
3882 * src/maemo/easysetup/modest-validating-entry.c:
3883 * src/maemo/easysetup/modest-validating-entry.h:
3884 * src/maemo/modest-account-settings-dialog.c:
3885 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3886 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3887 widgets/ because they are used outside of easysetup too. After checking in,
3888 svn will allow me to rename them too.
3890 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3892 * src/gnome/modest-msg-edit-window.c:
3893 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3894 linker error, to fix the build on the GNOME platform.
3895 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3896 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3897 ifdefed out to avoid a warning.
3899 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3901 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3902 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3903 some alternative for GTK+ 2.6.
3905 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3907 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3909 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3910 specified for EmailAccountsDialog in UI spec.
3912 * src/maemo/easysetup/modest-easysetup-wizard.c:
3913 * src/maemo/easysetup/modest-easysetup-wizard.h:
3914 * src/maemo/modest-account-settings-dialog.c:
3915 * src/maemo/modest-account-settings-dialog.h:
3916 Reuse a member window widget for the connection-specific SMTP server accounts,
3917 so we can tell it to create/save the accounts only if we actually save changes.
3919 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3920 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3921 (modest_connection_specific_smtp_edit_window_get_settings):
3922 Return a struct instance for temporarily remembering the entered data.
3924 * src/maemo/modest-connection-specific-smtp-window.h:
3925 * src/maemo/modest-connection-specific-smtp-window.c:
3926 (modest_connection_specific_smtp_window_finalize),
3927 (modest_connection_specific_smtp_window_fill_with_connections),
3929 (modest_connection_specific_smtp_window_save_server_accounts),
3930 (update_model_server_names): Do not actually save data until asked,
3931 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3933 (on_selection_changed),
3934 (modest_connection_specific_smtp_window_init): Disable the edit
3935 button when nothing is selected.
3937 * src/modest-account-mgr-helpers.c:
3938 * src/modest-account-mgr-helpers.h:
3939 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3942 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3944 * src/modest-account-mgr-helpers.h:
3945 * src/modest-account-mgr-helpers.c:
3946 (modest_account_mgr_get_unused_account_name),
3947 (modest_account_mgr_get_unused_account_display_name): Added these
3948 utility functions, to avoid code duplication.
3950 * src/maemo/easysetup/modest-easysetup-wizard.c:
3951 (create_page_account_details), (create_account):
3952 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3953 (on_combo_security_changed),
3954 (modest_connection_specific_smtp_edit_window_init),
3955 (modest_connection_specific_smtp_edit_window_save_settings):
3956 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3957 * src/maemo/modest-connection-specific-smtp-window.c:
3958 (modest_connection_specific_smtp_window_finalize),
3959 (modest_connection_specific_smtp_window_fill_with_connections),
3960 (on_button_edit), (modest_connection_specific_smtp_window_init):
3961 * src/maemo/modest-connection-specific-smtp-window.h:
3962 Implementing saving of connection-specific server accounts.
3964 But I need to refactor this so we can save the data for each
3965 possible connection-specific account and only actually create the server accounts
3966 when the easysetup finished, or the OK button is pressed on the account settings
3969 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3971 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3972 (on_combo_security_changed):
3973 (modest_connection_specific_smtp_edit_window_init):
3974 Auto-fill the port number as in the account settings.
3976 (modest_connection_specific_smtp_edit_window_set_connection):
3977 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3978 * src/maemo/modest-connection-specific-smtp-window.c:
3979 (fill_with_connections), (on_button_edit),
3980 (modest_connection_specific_smtp_window_init):
3981 Turn the edit window into a dialog to simplify the code, and
3982 set a WM hint as in a GtkDialog, because only a popup can be on top of
3983 another window in Maemo, and popups usually have no WM decoration.
3985 * src/modest-defs.h:
3986 * src/modest-account-mgr-helpers.c:
3987 (modest_account_mgr_set_connection_specific_smtp),
3988 (modest_account_mgr_remove_connection_specific_smtp),
3989 (modest_account_mgr_get_connection_specific_smtp):
3990 * src/modest-account-mgr-helpers.h: Some functions to write the
3991 connection-specific SMTP server information. Not yet used.
3994 * src/widgets/modest-folder-view.c: (text_cell_data):
3995 Fix a warning about an uninitialized variable.
3996 (on_configuration_key_changed): Put an #ifdef around the use
3997 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3999 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4001 * src/maemo/modest-account-settings-dialog.h:
4002 * src/maemo/modest-account-settings-dialog.c:
4003 Added connect_for_modified() utility function to mark the new modified boolean.
4005 (create_page_account_details), (create_page_user_details),
4006 (create_page_incoming), (create_page_outgoing), (on_response),
4007 (modest_account_settings_dialog_init),
4008 (modest_account_settings_dialog_set_account_name):
4009 Only warn about unsaved changes when there are actually unsaved changes.
4011 * src/modest-account-mgr-helpers.c:
4012 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4013 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4014 to get the data from there in future.
4016 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4018 * src/modest-defs.h:
4020 * src/modest-account-mgr-helpers.h:
4021 * src/modest-account-mgr-helpers.c:
4022 Store the security account setting in a single conf key instead of using
4023 the options list, so that the list is left for just the to-be-removed camel hack,
4024 and because gconf_client_set_list() is failing for some reason.
4026 * src/modest-account-mgr.c:
4027 (modest_account_mgr_add_server_account):
4028 * src/maemo/modest-account-settings-dialog.c:
4029 (modest_account_settings_dialog_set_account_name),
4030 (save_configuration): Use the renamed functions.
4033 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4035 * src/widgets/Makefile.am:
4036 * src/widgets/modest-limit-retrieve-combo-box.c:
4037 * src/widgets/modest-limit-retrieve-combo-box.h:
4038 * src/widgets/modest-retrieve-combo-box.c:
4039 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4040 the account settings dialog.
4042 * src/modest-defs.h:
4043 * src/modest-account-mgr-helpers.h:
4044 * src/modest-account-mgr-helpers.c:
4045 (modest_server_account_get_option_secure_auth),
4046 (modest_server_account_set_option_secure_auth):
4047 * src/modest-account-mgr.c:
4048 (modest_account_mgr_add_server_account):
4049 Use the existing AUTH_MECH conf key for the secure-auth setting,
4050 instead of putting it in the list options, because this was actually used already.
4052 * src/maemo/modest-account-settings-dialog.c:
4053 (create_page_account_details),
4054 (modest_account_settings_dialog_set_account_name),
4055 (save_configuration):
4056 * src/maemo/modest-account-settings-dialog.h:
4057 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4058 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4060 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4062 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4063 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4064 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4066 * src/modest-defs.h:
4067 * src/maemo/modest-account-settings-dialog.c:
4068 (create_page_incoming), (on_combo_outgoing_security_changed),
4069 (on_combo_incoming_security_changed), (create_page_outgoing),
4070 (modest_account_settings_dialog_set_account_name),
4071 (save_configuration): Load/Save the port number, and change it when the
4072 security combo changes, to suitable defaults.
4074 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4076 * src/modest-account-mgr.c:
4077 (modest_account_mgr_add_server_account): Set the security and secure-auth
4078 options, and add a comment saying that the other camel-specific options should be
4081 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4083 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4085 * src/modest-tny-account-store.c: (account_list_free),
4086 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4087 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4090 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4092 * src/modest-protocol-info.c:
4093 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4094 is required by our UI spec. Maybe something in our implementation will use this eventually.
4095 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4096 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4097 instead of the previous 0 placeholder.
4099 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4100 secure-auth settings.
4101 * src/modest-account-mgr-helpers.h:
4102 * src/modest-account-mgr-helpers.c:
4103 (modest_server_account_data_get_option_secure_auth),
4104 (modest_server_account_set_option_secure_auth),
4105 (modest_server_account_data_get_option_security),
4106 (modest_server_account_set_option_security): Added this API for getting and setting the security
4107 and secure-auth settings.
4109 * src/maemo/modest-account-settings-dialog.h:
4110 * src/maemo/modest-account-settings-dialog.c:
4111 (modest_account_settings_dialog_finalize), (check_data),
4112 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4113 about changing titles.
4114 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4115 (save_configuration): Save the security and secure-auth settings.
4117 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4118 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4120 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4122 * src/modest-defs.h:
4123 * src/modest-account-mgr.c:
4124 (modest_account_mgr_add_server_account):
4125 Added and used defines for the options key and value pair strings,
4126 that are used so far, though they do not seem to correspond to anything in our
4127 UI specs or ModestProtocol enum.
4129 * src/modest-account-mgr-helpers.h:
4130 * src/modest-account-mgr-helpers.c:
4131 (compare_option_strings_for_name),
4132 (modest_server_account_data_get_option_value),
4133 (modest_server_account_data_get_option_bool),
4134 (modest_account_mgr_get_server_account_option):
4135 Added helper functions for parsing the options GSList.
4137 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4139 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4140 display name is based on the supplied account name.
4141 * src/modest-account-mgr.c:
4142 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4143 with an inefficient, but good-enough, implementation.
4145 * src/maemo/easysetup/modest-easysetup-wizard.c:
4146 (create_page_account_details), (on_before_next), (create_account):
4147 Check for existing display names rather than (non-user-visible) account names, and just
4148 create and set a unique account name at the end.
4150 * src/maemo/modest-account-settings-dialog.c:
4151 (modest_account_settings_dialog_init),
4152 (modest_account_settings_dialog_set_account_name),
4153 (create_page_incoming): Show the display name, instead of the account name.
4154 (on_response): Do some (not all) extra checks, as in the UI spec.
4155 (save_configuration): Save the display name if it was changed.
4157 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4159 * po/en_GB.po: Added needed logical ID and translation.
4160 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4161 (init_view): Made the is-default column clicking work.
4163 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4166 * src/maemo/easysetup/Makefile.am:
4167 * src/maemo/easysetup/modest-easysetup-wizard.c:
4168 (modest_easysetup_wizard_dialog_init):
4169 * src/maemo/easysetup/provider-data-test.keyfile:
4170 * src/maemo/easysetup/provider-data.keyfile:
4171 Moved the provider data file to the new modest-providers-data package and used it from there.
4173 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4175 * src/modest-local-folder-info.c:
4176 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4177 N_() was already used on the static strings, but this just marks it for translation without
4178 using the translation.
4180 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4182 * src/maemo/modest-account-settings-dialog.c:
4183 (create_page_incoming),
4184 (modest_account_settings_dialog_set_account_name):
4185 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4186 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4187 I will do this if nobody else gets there first.
4189 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4191 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4192 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4193 save the security stuff.
4195 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4197 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4198 Set the email address and user fullname, which I now see must be
4201 * src/maemo/modest-account-settings-dialog.h:
4202 * src/maemo/modest-account-settings-dialog.c:
4204 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4205 leave-on-server and authentication.
4206 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4209 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4212 * src/maemo/modest-account-settings-dialog.c:
4213 * src/maemo/modest-account-settings-dialog.h:
4214 Most (but not all) of the widgets are now present as specified by the UI spec.
4215 No changes are yet saved, and some details are not properly shown yet.
4217 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4219 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4221 * src/maemo/Makefile.am:
4222 * src/maemo/modest-account-settings-dialog.c:
4223 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4224 an existing account. Doesn't do much yet.
4226 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4227 Open the accounts settings dialog when Edit is clicked.
4229 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4231 * src/maemo/easysetup/Makefile.am:
4232 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4234 * src/maemo/easysetup/modest-easysetup-wizard.c:
4235 (modest_easysetup_wizard_dialog_init):
4236 Try to get the source directory from the build system,
4237 instead of hard-coding "./" into the source code, when opening our local
4238 copies of the configuration files.
4239 But this still fails when opening the wizard from the Accounts window,
4240 maybe because the working directory seems to change at runtime.
4241 So the wizard will fail the second time unless you copy the files into their
4242 proper locations - see the stdout warnings for the paths.
4244 (create_page_account_details),(on_before_next):
4245 Check for existing non-server accounts instead of server accounts,
4246 so the default account name is useful again, and to prevent trying to
4249 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4250 Show the wizard when New is clicked.
4252 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4253 (init_view): Show the column headers, and show the columns that are
4254 specified in the UI specs. However, something in Maemo's GTK+ prevents
4255 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4256 change the default account. This is despite unsetting the special properties.
4258 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4260 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4261 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4262 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4263 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4264 to make that clearer.
4265 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4267 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4269 * src/maemo/modest-account-view-window.c:
4270 (modest_account_view_window_init),
4271 (modest_account_view_window_new):
4272 Use the same buttons as specified in the
4273 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4274 the existing widgets, which never had a chance of working.
4275 Put the ModestAccountView treeview in a scrolled window.
4276 Do not repeat the initialization in both _init() and _new().
4278 * src/widgets/modest-account-view.c: (update_account_view):
4279 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4280 this widget and window shows no accounts.
4282 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4284 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4286 * src/maemo/easysetup/modest-easysetup-wizard.c:
4287 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4288 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4289 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4292 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4293 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4294 accounts exist yet, as in the UI spec.
4296 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4298 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4300 * src/maemo/Makefile.am:
4301 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4302 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4303 New window for editing connection-specific smtp details.
4304 Not fully implemented.
4306 * src/maemo/modest-connection-specific-smtp-window.c:
4307 (modest_connection_specific_smtp_window_finalize) :
4308 unref the tree model.
4309 (on_button_edit): Show the edit window.
4311 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4313 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4316 * src/maemo/Makefile.am:
4317 * src/maemo/modest-connection-specific-smtp-window.c:
4318 * src/maemo/modest-connection-specific-smtp-window.h:
4319 New window for showing the list of connections, for connection-specific
4320 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4321 * src/maemo/easysetup/modest-easysetup-wizard.c:
4322 (create_page_custom_outgoing): Show the new window when the button is clicked.
4324 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4326 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4327 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4328 * src/maemo/modest-msg-edit-window.c:
4329 (modest_msg_edit_window_insert_image):
4330 * src/modest-conf.c: (modest_conf_key_escape):
4331 * src/modest-mail-operation.c:
4332 (modest_mail_operation_send_new_mail):
4333 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4334 (modest_ui_actions_on_new_account):
4335 * src/widgets/modest-attachment-view.c: (update_filename_request):
4336 * src/widgets/modest-mail-header-view.c:
4337 Corrected warnings that were breaking the build, by commenting out unused variables,
4338 and a function, and by including a header.
4340 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4342 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4343 so we can #ifdef around platform-specific code when necessary.
4344 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4345 to allow this to build for the GNOME platform too.
4347 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4349 * src/maemo/easysetup/modest-easysetup-wizard.c:
4350 Added util_increment_name() and used it in create_page_account_details()
4351 to make sure that the default account name is always a new name.
4353 (modest_easysetup_wizard_dialog_init),
4354 (set_default_custom_servernames): Some minor memory management fixes.
4356 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4360 * src/modest-runtime.c: (init_i18n): Restored the translation
4361 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4362 are defined in config.h, and the translations are installed.
4364 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4365 is defined for translation.
4367 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4369 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4371 * src/maemo/easysetup/modest-easysetup-wizard.c:
4372 (modest_easysetup_wizard_dialog_init):
4373 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4374 Use realistic paths (though they should use $prefix generically) to the
4375 mcc_mapping and provider-data.keyfile files which might work when they
4376 are installed by the future version of the operator-wizard package,
4377 and then fallback to paths in our source code, with an explanatory
4380 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4384 * src/maemo/Makefile.am:
4385 * src/maemo/easysetup/: Added files from the previously-exernal
4386 osso-modest-easysetup.
4387 * src/maemo/modest-main-window-ui.h:
4388 * src/modest-ui-actions.c:
4389 * src/modest-ui-actions.h:
4390 Added modest_ui_actions_on_new_account() as a signal handler for the
4391 New Account menu item. It shows the easysetup wizard.
4392 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob