1 2007-06-08 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
4 Improve the error dialog to show Incorrect Account Settings, which seems
5 clearer, and say that the internal error message (to be removed from the
6 dialog later) is often misleading.
7 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
9 * src/modest-tny-account.c:
10 (modest_tny_account_new_from_server_account): Uncomment the printf of the
11 URL because this is so useful for debugging on the device.
13 * src/widgets/modest-serversecurity-combo-box.c:
14 (modest_serversecurity_combo_box_fill): Correct a logical ID.
16 2007-06-08 Murray Cumming <murrayc@murrayc.com>
18 * src/modest-mail-operation.c:
19 (modest_mail_operation_send_new_mail):
20 Added a comment about a nasty but apparently harmless message. Details
21 added to the wiki g_warnings() page.
23 2007-06-08 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
26 (modest_tny_send_queue_class_init):
27 Do not use the priv struct because it is empty, to avoid g_warnings
28 about a non-existant priv struct.
30 * src/modest-tny-account-store.c:
31 (modest_tny_account_store_get_server_account),
32 (modest_tny_account_store_get_transport_account_for_open_connection
33 ): Do not try to get transport server accounts for local folders,
34 because they don't have any. This avoids a g_warning().
36 * src/maemo/modest-main-window.c:
37 (modest_main_window_notify_send_receive_initied),
38 (on_configuration_key_changed):
39 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
41 * src/modest-mail-operation.c:
42 (modest_mail_operation_update_account):
43 * src/modest-tny-account-store.h:
44 * src/modest-tny-account.c:
45 (modest_tny_account_get_special_folder),
46 (modest_tny_account_new_for_local_folders),
47 (modest_tny_account_new_for_per_account_local_outbox_folder):
48 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
49 * src/modest-tny-local-folders-account.c:
50 (add_account_folders_to_merged_folder):
51 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
52 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
53 (modest_ui_actions_on_send):
54 * src/widgets/modest-folder-view.c: (update_model):
55 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
56 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
57 modest_tny_account_store_get_tny_account_by_account() to
58 modest_tny_account_store_get_server_account() to make the code clearer.
60 2007-06-07 Marcus Bauer <marcusb@openismus.com>
62 * src/dbus_api/modest-dbus-api.h:
63 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
64 * src/maemo/modest-msg-edit-window.c:
65 (modest_msg_edit_window_attach_file_noninteractive):
66 added g_warning in case the file to be attached does not exist
67 * tests/dbus_api/test_compose_mail.c: (main):
68 removed obsolete comment, added generic files as test case
70 2007-06-07 Murray Cumming <murrayc@murrayc.com>
72 * src/modest-tny-account-store.c: (get_server_accounts):
73 Create the local folders account only once, not once for each outbox, and
74 not only when there are some outboxes.
76 2007-06-07 Murray Cumming <murrayc@murrayc.com>
78 * src/widgets/modest-folder-view.c: (update_model): Comment out some
79 code that is causing a crash at startup. Sergio says that he is fixing this.
81 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
83 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
84 * src/maemo/modest-account-settings-dialog.c:
85 (create_page_outgoing),
86 (modest_account_settings_dialog_set_account_name),
88 - Fixed handling of the "Use secure authentication" toggle to comply with
89 the ui specification. See also projects.maemo.org bug NB#58400
91 - Restore the Secure connection setting combo correctly when loading
94 * src/maemo/modest-maemo-utils.c:
95 (on_camel_account_get_supported_secure_authentication),
96 (modest_maemo_utils_get_supported_secure_authentication_methods):
97 Fixed a crasher if operation is canceled
99 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
100 (modest_protocol_info_auth_is_secure):
101 * src/modest-protocol-info.h:
103 Added two new methods to determine if a protocol/auth method is secure/encrypted in
104 the sense of the "Use secure authentication" toggle.
106 2007-06-07 Murray Cumming <murrayc@murrayc.com>
108 * src/modest-tny-account-store.h:
109 * src/modest-tny-account-store.c:
110 Added modest_tny_account_store_get_local_folders_account().
112 * src/modest-tny-folder.h:
113 * src/modest-tny-folder.c:
114 (modest_tny_folder_get_account):
115 Added this replacement for tny_folder_get_account() which returns
116 the local-folders account for TnyMergeFolders, to avoid the
117 warning about the unimplemented get_account_func() vfunc().
119 (modest_tny_folder_get_rules),
120 * src/modest-ui-actions.c:
121 (modest_ui_actions_on_folder_selection_changed):
122 * src/modest-mail-operation.c:
123 (modest_mail_operation_remove_folder),
124 (modest_mail_operation_xfer_folder),
125 (modest_mail_operation_rename_folder),
126 (modest_mail_operation_get_msg),
127 (modest_mail_operation_get_msgs_full),
128 (modest_mail_operation_remove_msg),
129 (modest_mail_operation_xfer_msgs),
130 (modest_mail_operation_refresh_folder):
131 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
133 2007-06-07 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
136 (modest_server_account_set_security):
137 * src/modest-defs.h: Add comments explaining that our
138 UI spec means TLS when it says Normal, so these do not look like errors.
140 * src/modest-tny-account.c:
141 (modest_tny_account_new_from_server_account): Use the new tinymail
142 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
143 for TLS. This should fix projects.maemo.org bug NB#58460.
145 2007-06-06 Murray Cumming <murrayc@murrayc.com>
147 * src/maemo/easysetup/modest-easysetup-wizard.c:
148 (create_account): Correct the position of the gconf sanity check warning.
149 (on_button_edit_advanced_settings): Show the dialog immediately, instead
150 of using the g_idle_add() hack, because this does not seem to be necessary
151 on osso 1.1. It might even work on Maemo Bora if the problems were actually
152 caused by something other than maemo's gconf.
153 This fixes projects.maemo.org bug #59022.
155 2007-06-06 Murray Cumming <murrayc@murrayc.com>
157 * src/modest-account-mgr-helpers.c:
158 (modest_account_mgr_get_default_account): Do not check that the account
159 exists if there is no default account (NULL), to fix a runtime warning.
161 2007-06-06 Murray Cumming <murrayc@murrayc.com>
163 * src/widgets/modest-folder-view.c: (update_model):
164 Do not unref the treemodel before we have finished with it.
165 This prevents a valgrind warning and an occasional crash at startup.
167 2007-06-06 Marcus Bauer <marcusb@openismus.com>
169 * libmodest-dbus-client/libmodest-dbus-client.h:
170 added libmodest_dbus_client_compose_mail()
171 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
173 added functions needed for SendAsMail() functionality
174 * src/maemo/modest-msg-edit-window.c:
175 (modest_msg_edit_window_attach_file_noninteractive):
176 non interactively attaching files to message edit window
177 * src/widgets/modest-msg-edit-window.h:
178 * tests/dbus_api/Makefile.am:
179 added test_compose_mail.c
180 * tests/dbus_api/test_compose_mail.c: (main):
182 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
184 * src/modest-account-view.c:
185 Fixed bug projects.maemo.org bug NB#59307
187 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
189 * src/maemo/easysetup/modest-easysetup-wizard.c:
190 (get_serverport_incoming), (on_before_next), (create_account):
191 * src/maemo/modest-account-settings-dialog.c:
192 (modest_account_settings_dialog_set_account_name):
193 * src/maemo/modest-maemo-utils.c:
194 (on_camel_account_get_supported_secure_authentication_status),
195 (on_camel_account_get_supported_secure_authentication),
196 (on_secure_auth_cancel),
197 (modest_maemo_utils_get_supported_secure_authentication_methods):
199 Implemented security authentication for settings and easysetup.
201 2007-06-05 Murray Cumming <murrayc@murrayc.com>
203 * src/maemo/modest-main-window.c: (create_details_widget):
204 Show the total size for memory card accounts too, instead of showing
205 the name again. Fixes bug projects.maemo.org bug NB#59307.
207 2007-06-05 Murray Cumming <murrayc@murrayc.com>
210 * src/modest-tny-simple-folder-store.c:
211 * src/modest-tny-simple-folder-store.h: Removed.
213 * src/modest-tny-local-folders-account.h
214 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
215 for the local-folders maildir, with an extra TnyMergedFolder containing
216 the folders of the per-account outbox store accounts.
217 * src/modest-tny-account-store.c: (get_server_accounts):
218 Add the outboxes to the special local folders account after creating it.
220 * src/modest-tny-account.c:
221 (modest_tny_account_new_for_local_folders): Create the derived
222 account when creating the main local-folders account.
224 * src/maemo/modest-main-window.c: (create_details_widget),
225 (modest_main_window_set_contents_style):
226 Adapted to the use of the derived account instead of the folder store.
228 * src/modest-ui-actions.c:
229 (modest_ui_actions_on_folder_selection_changed):
230 * src/modest-ui-dimming-rules.c:
231 (modest_ui_dimming_rules_on_new_folder):
232 * src/widgets/modest-folder-view.c: (text_cell_data),
233 (icon_cell_data), (filter_row), (update_model),
234 (get_cmp_rows_type_pos):
237 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
238 Do not get the priv struct, because no priv struct has been set,
239 to avoid a runtime warning.
241 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
242 #ifelse with #else, to fix a warning, to fix the build.
245 2007-06-05 Christian Kellner <ckellner@openismus.com>
247 * libmodest-dbus-client/libmodest-dbus-client.c:
248 Fix small typo in doc (why do you always see them
249 AFTER committing stuff?)
252 2007-06-05 Christian Kellner <ckellner@openismus.com>
254 * libmodest-dbus-client/libmodest-dbus-client.c:
255 (libmodest_dbus_client_search):
256 Initialize hit list with NULL. Also set folder list
257 to "" if NULL was supplied.
260 2007-06-03 Christian Kellner <ckellner@openismus.com>
262 * libmodest-dbus-client/libmodest-dbus-client.c:
263 (modest_search_hit_list_free):
264 Make it save to call it with NULL.
266 * src/dbus_api/modest-dbus-callbacks.c:
267 * src/modest-search.c:
268 Return full ModestSearchHits as the search result list not TnyHeader
269 since can't be around withouth the correspoding TnyFolder.
271 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
273 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
274 Added currently commented code to check for secure auth
276 * src/maemo/modest-account-settings-dialog.c: (on_response),
277 (save_configuration), (show_ok):
278 Fixed projects.maemo.org bugs NB #59248 and #59251
280 * src/maemo/modest-maemo-utils.c:
281 (on_camel_account_get_supported_secure_authentication_status),
282 (on_camel_account_get_supported_secure_authentication),
283 (modest_maemo_utils_get_supported_secure_authentication_methods):
284 * src/maemo/modest-maemo-utils.h:
285 Moved get_supported_secure_authentication() method here to be able
286 to use it from easysetup wizard.
288 * src/modest-pair.c: (on_pair_compare_as_string):
289 Should compare string with first part of pair and not
290 strcmp pairs which will crash.
292 * src/modest-protocol-info.c:
293 (modest_protocol_info_protocol_is_store):
294 * src/modest-protocol-info.h:
295 Added modest_protocol_info_get_auth_protocol_name()
297 2007-06-03 Armin Burgmeier <armin@openismus.com>
299 * src/modest-mail-operation.c:
300 (modest_mail_operation_get_msgs_full): Set priv->account also when
301 only retrieving a single message. This avoids a crash when canceling
304 (modest_mail_operation_notify_end): Do not explicitely remove the
305 operation from the queue but only emit the progress_changed signal.
306 The queue itself listens to that signal to remove the operation when
307 it is finished. This reduces coupling and removes a potential deadlock
308 when modest_mail_operation_notify_end() is called from the queue
309 itself. If that is a problem performance-wise, I would suggest to
310 implement a status-changed signal or something.
312 * src/modest-mail-operation-queue.c: Make sure to never call a
313 function from another file while the queue is locked. This (hopefully)
314 fixes another deadlock when exiting the application while retrieving
317 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
319 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
320 Fixed build if libogs is not available
322 2007-06-03 Christian Kellner <ckellner@openismus.com>
324 * libmodest-dbus-client/libmodest-dbus-client.h:
325 * libmodest-dbus-client/libmodest-dbus-client.c:
326 (libmodest_dbus_client_delete_message):
327 Implement deletion of messages (Client side).
329 (modest_search_hit_free),
330 (modest_search_hit_list_free):
331 Utility functions to free the result hits.
333 * src/dbus_api/modest-dbus-api.h:
334 * src/dbus_api/modest-dbus-callbacks.c:
336 (modest_dbus_req_handler):
337 Implement deletion of messages (Server side).
339 * tests/dbus_api/test_search.c: (main):
342 * tests/dbus_api/Makefile.am:
343 * tests/dbus_api/test_delete_message:
344 Add little test for the message deletion logic
346 2007-06-03 Armin Burgmeier <armin@openismus.com>
348 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
349 when the operation queue was not empty. projects.maemo.org bug
352 2007-06-03 Armin Burgmeier <armin@openismus.com>
354 * src/widgets/modest-account-view.c
355 (on_account_default_toggled): Toggle default account column
356 explicitely instead of waiting for gconf notification (which is
357 currently ignored). This should fix projects.maemo.org bug NB#56910
358 for now. It should probably be removed when gconf notifications are
361 2007-06-03 Christian Kellner <ckellner@openismus.com>
363 * libmodest-dbus-client/libmodest-dbus-client.c:
364 Removed debugging spew.
366 * src/dbus_api/modest-dbus-callbacks.c:
367 Added debugging info.
369 * src/modest-search.c:
370 (modest_search_all_accounts):
371 Use tny_account_store_get_accounts () on the account store
372 to get all accounts which is the way to get all accounts.
374 * tests/dbus_api/test_search.c: (main):
375 Make it possible to supply the search term on the command line.
377 2007-06-03 Christian Kellner <ckellner@openismus.com>
379 * libmodest-dbus-client/libmodest-dbus-client.c:
380 * libmodest-dbus-client/libmodest-dbus-client.h:
381 Implement searching for mesages over raw dbus. (Client side)
383 * src/dbus_api/Makefile.am:
384 * src/dbus_api/modest-dbus-api.h:
385 * src/dbus_api/modest-dbus-callbacks.c:
386 * src/dbus_api/modest-dbus-callbacks.h:
387 Search framework (Server side). Also implement on_idle_open_message().
389 * src/maemo/modest-platform.c: (modest_platform_init):
390 Prepare for raw dbus/osso rpc interaction.
392 * src/modest-search.h:
393 Changed minsize from unspecific guint to guint32.
395 * src/modest-search.c:
397 Added strange hack which magically made tnymail work.
399 (modest_search_folder),
400 (modest_search_account),
401 (modest_search_all_accounts):
402 Implement helper functions to search all accounts, specific account
405 * tests/dbus_api/Makefile.am:
406 * tests/dbus_api/test_open_message.c:
407 Read url to open from commandline.
409 * tests/dbus_api/test_search.c:
410 Implement small test for dbus search stuff
412 2007-06-02 Armin Burgmeier <armin@openismus.com>
414 * src/maemo/modest-account-settings-dialog.c: Changed window title to
415 include account type and account title. This fixes projects.maemo.org
418 * src/maemo/modest-account-view-window.c: Set a title for the window.
420 2007-06-02 Armin Burgmeier <armin@openismus.com>
422 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
423 incoming and outgoing server name based on email address and server
424 types as long as the names have not been edited manually. This fixes
425 projects.maemo.org bug NB#58671.
427 2007-06-02 Armin Burgmeier <armin@openismus.com>
429 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
430 server type cannot be changed in future to the incoming details page
431 when creating an account. This fixes projects.maemo.org bug NB#59029.
433 2007-06-02 Armin Burgmeier <armin@openismus.com>
435 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
436 and assigned max width chars so that they wrap instead of being
437 truncated. Fixes projects.maemo.org bug NB#56126.
439 2007-06-02 Armin Burgmeier <armin@openismus.com>
441 * src/maemo/modest-connection-specific-smtp-window.c: Add an
442 introductory note to the connection specific smtp servers dialog, as
443 section 8.12 of the email UI specification requires. This fixes
444 projects.maemo.org bug NB#59212.
446 2007-06-01 Murray Cumming <murrayc@murrayc.com>
448 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
449 Check for running mail operations, and offer to cancel them, as per the UI
450 spec. This fixes projects.maemo.org bug NB#59041 .
451 However, I suspect that tinymail may still use the network connection
452 in ways that we cannot detect or cancel. But it should at least adapt to
455 2007-06-01 Murray Cumming <murrayc@murrayc.com>
457 * src/modest-tny-account-store.c: (recreate_all_accounts),
458 (get_cached_accounts), (get_server_accounts): Do more sensible
459 ref-counting of the temporarily-cached outbox accounts list. This seems
460 to fix a crash when entering the password when the password was wrong.
462 2007-06-01 Murray Cumming <murrayc@murrayc.com>
464 * src/gnome/modest-main-window.c: (connect_signals):
465 * src/modest-tny-account-store.c: (get_password),
466 (modest_tny_account_store_alert): Added comments and clues and
467 commented-out code about how we currently fail to deal with connection
468 errors and wrong passwords, and how we should.
470 2007-06-01 Murray Cumming <murrayc@murrayc.com>
472 * src/widgets/modest-retrieve-combo-box.c:
473 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
474 This fixes projects.maemo.org bug NB#58472 .
476 2007-06-01 Murray Cumming <murrayc@murrayc.com>
478 * src/maemo/easysetup/modest-easysetup-wizard.c:
479 (create_page_complete_easysetup):
480 (create_page_complete_custom): Correct the last commit,
481 putting the correct sentences in the correct pages.
483 2007-06-01 Murray Cumming <murrayc@murrayc.com>
485 * src/maemo/easysetup/modest-easysetup-wizard.c:
486 (create_page_complete_custom): Show the second sentence of text
487 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
490 2007-06-01 Murray Cumming <murrayc@murrayc.com>
492 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
493 Set the leave-on-server conf key by default. This fixes
494 projects.maemo.org bug NB#59258 .
496 2007-06-01 Murray Cumming <murrayc@murrayc.com>
498 * src/maemo/modest-account-view-window.c:
499 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
500 logical ID for the confirmation messages. Fixed projects.maemo.org bug
503 2007-06-01 Murray Cumming <murrayc@murrayc.com>
505 * src/maemo/easysetup/modest-easysetup-wizard.c:
506 (create_caption_new_with_asterisk):
507 * src/maemo/modest-account-settings-dialog.c:
508 (create_caption_new_with_asterisk):
509 Uncomment the code to add the asterisk, because they are no longer in the
510 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
511 (update_incoming_server_title): Add an asterisk here too.
513 2007-06-01 Murray Cumming <murrayc@murrayc.com>
515 * src/maemo/modest-maemo-global-settings-dialog.c:
516 (current_connection): Check that we are even connected before trying to
517 get the current connection name, to prevent a warning.
519 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
520 Change the comments because tny_maemo_conic_device_connect() is now meant to
522 * src/modest-mail-operation.c:
523 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
524 make sure we have a connection and fail if we can't connect.
526 2007-05-31 Murray Cumming <murrayc@murrayc.com>
528 * src/maemo/modest-main-window.c:
529 (on_account_store_connecting_finished): Do not try to get the
530 connection ID if we are not really connected. I am surprised that
531 this signal handler is called when we are not connected.
533 2007-05-31 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-error.h:
536 * src/modest-ui-actions.c:
537 (modest_ui_actions_get_msgs_full_error_handler):
538 Renamed an enum, added comments, added an enum
539 for retrieve-limit errors.
541 * src/modest-mail-operation.c: (foreach_add_item),
542 (internal_folder_observer_update), (update_account_thread),
543 (modest_mail_operation_get_msgs_full):
544 (modest_mail_operation_update_account),
545 Added comments about how this works, and some code that should
546 (but does not) check the retrieve-limit. See the TODO comment.
548 2007-05-31 Murray Cumming <murrayc@murrayc.com>
550 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
551 Initialize help_id to fix the build. Warnings are good.
553 2007-05-31 Murray Cumming <murrayc@murrayc.com>
555 * src/widgets/modest-hbox-cell-renderer.c:
556 (modest_hbox_cell_renderer_append):
557 * src/widgets/modest-vbox-cell-renderer.c:
558 (modest_vbox_cell_renderer_append):
559 Fix the last commit by doing an extra ref.
561 2007-05-31 Murray Cumming <murrayc@murrayc.com>
563 * src/widgets/modest-hbox-cell-renderer.c:
564 (modest_hbox_cell_renderer_append):
565 * src/widgets/modest-vbox-cell-renderer.c:
566 (modest_vbox_cell_renderer_append):
567 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
568 to fix the build with Maemo Bora.
569 However, there seems to be a remaining crash, probably due to reference
572 2007-05-30 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-tny-account.c:
575 (modest_tny_account_new_for_local_folders):
576 Use hildon_file_system_info_async_new() to get a better name for
577 the memory card account, setting it as the account name.
578 The timing seems to work, but this is probably
579 not the best place to do this. See the TODO comment.
580 * src/maemo/modest-main-window.c: (create_details_widget):
581 * src/widgets/modest-folder-view.c: (text_cell_data):
582 Use the tny account name instead of hardcoding a name.
584 2007-05-30 Christian Kellner <ckellner@openismus.com>
586 * src/modest-search.c: (modest_search):
587 Correctly set part_search_func even if we have already parsed
588 the query and thus a valid OgsTextSearcher object.
590 2007-05-30 Christian Kellner <ckellner@openismus.com>
593 Search and check for libogs.
596 Incooparte the ogs build env.
598 * src/modest-mime-part-search-stream.c:
599 * src/modest-mime-part-search-stream.h:
600 Removed since we do the real searching now in modest-search.c.
602 * src/modest-search.c:
603 * src/modest-search.h:
604 Implement support for ogs. We use that if available and requested
605 and fall back to modest_text_utils_utf8_strcmp (). The search logic
606 should now handle the corner case when the search term is spread
607 across multiple reads.
608 Also the logic in modest_search () was corrected to search all
609 requested fields until one is found.
611 2007-05-30 Murray Cumming <murrayc@murrayc.com>
613 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
616 * src/modest-init.c: Made modest_init_local_folders() take a
617 path and be public so we can iniitialize maildir folders on
620 * src/modest-local-folder-info.h:
621 * src/modest-local-folder-info.c:
622 (modest_local_folder_info_get_maildir_path): Add a path parameter.
624 * src/modest-tny-account.c:
625 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
626 still means the standard local-folders path on the local volume.
628 * src/modest-tny-account-store.c:
629 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
630 signal so we can detect mount/unmount of the MMC1 card, and do an update of
631 all accounts when that happens.
632 (get_server_accounts): If the MMC1 card is mounted, create a store account for
633 this too, so it shows up in the treeview.
635 2007-05-28 Murray Cumming <murrayc@murrayc.com>
637 * src/maemo/modest-maemo-global-settings-dialog.c:
638 (current_connection):
639 * src/widgets/modest-global-settings-dialog.c:
640 (current_connection_default):
641 Use the enum values instead of 0, 1 and -1,
642 to make the code clearer.
644 * src/modest-account-mgr-helpers.c:
645 (modest_account_mgr_get_connection_specific_smtp): Make this code
648 * src/modest-runtime.h:
649 * src/modest-runtime.c:
650 Added modest_runtime_remove_all_send_queues().
651 * src/maemo/modest-main-window.c:
652 (on_account_store_connecting_finished): Recreate the send queues,
653 using the appropriate transport accounts for this new connection.
654 Some futher adapting might be needed if the old send queues are not
655 automatically stopped at this point.
657 * src/modest-tny-account-store.c: (get_server_accounts):
658 Create the connection-specific transport accounts, so that they can
659 be found later by their ID.
661 * src/modest-tny-account.h:
662 * src/modest-tny-account.c:
663 Added modest_tny_account_new_from_server_account_name().
664 modest_tny_account_new_from_server_account(): Do not create the
665 send queues here, because they will be
666 recreated anyway when the connection changes for the first time.
668 2007-05-28 Murray Cumming <murrayc@murrayc.com>
670 * src/modest-local-folder-info.h:
671 * src/modest-local-folder-info.c:
672 (modest_per_account_local_outbox_folder_info_get_maildir_path),
673 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
674 tbox_folder): Take a modest account name instead of a server TnyAccount,
675 so we can have per-modest-account rather than per-transport-account
677 We must make sure that we change or recreate the exisitng send queues
678 when the connection changes for connection-specific transport accounts.
680 * src/modest-tny-account-store.c:
681 (create_per_account_local_outbox_folders): Create outboxed per modest
682 account, not per transport account.
684 * src/modest-tny-account.h:
685 * src/modest-tny-account.c:
686 (modest_tny_account_get_special_folder): For outboxes, get the
687 parent modest account name. The account is ignored for other folders.
688 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
689 modest account name rather than a server TnyAccount.
691 2007-05-25 Murray Cumming <murrayc@murrayc.com>
693 * src/modest-tny-account.c:
694 (modest_tny_account_new_from_server_account):
695 Call modest_runtime_get_send_queue() immediately after creating transport
696 accounts, so that they start trying to send email from the outbox as soon
697 as possible at startup. This is probably what we want.
699 * src/modest-mail-operation.c: (update_account_thread):
700 * src/modest-runtime.c: (modest_runtime_get_send_queue):
701 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
702 * src/modest-tny-send-queue.h:
703 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
704 (modest_ui_actions_on_send):
705 Added comments about how sending works, though it needs some more work.
707 2007-05-25 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-tny-account.c:
710 (modest_tny_account_get_special_folder): Add TODO because this fails when
712 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
713 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
714 Do not try to show this window when there is no active account. The UI
715 specs does not tell us what to do in this case.
717 2007-05-24 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/Makefile.am:
722 * src/widgets/Makefile.am: Some dist fixes.
724 2007-05-24 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/modest-connection-specific-smtp-window.c:
727 (on_button_edit): Make the code clearer, to prevent a double free.
729 2007-05-24 Murray Cumming <murrayc@murrayc.com>
731 * src/maemo/modest-account-settings-dialog.c:
732 (modest_account_settings_dialog_set_account_name),
733 Check the connection-specific smtp servers checkbox if there are any.
735 * src/maemo/modest-connection-specific-smtp-edit-window.c:
736 (modest_connection_specific_smtp_edit_window_init):
737 Start with a suitable port number.
739 * src/modest-account-mgr-helpers.h:
740 * src/modest-account-mgr-helpers.c: Added
741 modest_account_mgr_get_has_connection_specific_smtp().
743 (modest_account_mgr_set_connection_specific_smtp),
744 (modest_account_mgr_remove_connection_specific_smtp),
745 (modest_account_mgr_get_has_connection_specific_smtp),
746 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
747 connection-specific smtp server accounts in the account, rather than
748 the server account conf dir.
750 This fixes bug projects.maemo.org bug NB#58263 .
752 * src/modest-tny-account-store.c:
753 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
754 if there are no server accounts yet, to prevent an infinite loop when there
755 are no accounts. Document that one must be called before the other.
757 2007-05-24 Murray Cumming <murrayc@murrayc.com>
759 * src/modest-account-mgr-helpers.c:
760 (modest_account_mgr_get_default_account): Make sure that at least
761 one account is always the default, if there are any enabled accounts.
762 This is just a sanity check that shouldn't be necessary.
764 * src/modest-account-mgr-priv.c:
765 (_modest_account_mgr_account_from_key): Unescape the conf key to
766 get the real account name. For instance, this is an issue if a space
767 was in the account name, which can happen because the account name
768 is generated from the display name.
769 (_modest_account_mgr_get_account_keyname): Always escape the
771 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
772 Unescape the conf keys to get the real account names.
774 For instance, previously the is-default radio button in the accounts
775 list was not checked for any accounts at first. This fixes that,
776 and might fix several similar bugs.
778 2007-05-23 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
781 Removed some debug printfs.
783 2007-05-23 Murray Cumming <murrayc@murrayc.com>
785 Modest on-disk outbox directories are now here, for instance:
786 $HOME/.modest/outboxes/<account-id-1>/outbox
787 $HOME/.modest/outboxes/<account-id-2>/outbox
789 $HOME/.modest/local-folders/outbox
790 so we can have a separate outbox for each account.
791 But they are shown as one outbox in the GtkTreeView, by using a
792 TnyMergeFolder in a ModestTnySimpleFolderStore.
795 * src/modest-tny-simple-folder-store.c:
796 * src/modest-tny-simple-folder-store.h:
797 Added ModestTnySimpleFolderStore, used to contain folders from
798 other folder stores, such as other accounts.
800 * src/modest-tny-outbox-account.h:
801 * src/modest-tny-outbox-account.c:
802 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
803 used for the per-account local outbox folders.
805 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
806 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
807 only use this (internally) now for the non-outbox local folders.
810 * src/modest-init.c: Added modest_init_one_local_folder(), for
811 setting up the directory structure for each local folder.
813 * src/modest-local-folder-info.c:
814 (modest_per_account_local_outbox_folder_info_get_maildir_path),
815 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
817 * src/modest-local-folder-info.h:
818 * src/modest-tny-account-store.c: (on_account_removed),
819 (on_account_changed), (create_per_account_local_outbox_folders),
820 (get_server_accounts), (modest_tny_account_store_get_accounts),
821 (modest_tny_account_store_get_tny_account_by_account),
822 (modest_tny_folder_store_is_virtual_local_folders):
824 * src/modest-tny-account.h:
825 * src/modest-tny-account.c:
826 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
827 to create an on-disk per-account local outbox folder for each
829 (create_per_account_local_outbox_folders): Create a local outbox folder
830 for each transport account.
831 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
832 for all local folders.
834 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
835 instead of using g_object_get/set() directly. It is clearer.
837 (modest_tny_folder_store_get_message_count),
838 (modest_tny_folder_store_get_local_size
839 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
840 because we now use these with non-acount folder stores.
842 (modest_tny_account_get_special_folder),
843 (modest_tny_account_new_from_server_account),
844 (modest_tny_account_new_from_account):
845 (recurse_folders): Adjust to the new outbox system.
847 * src/modest-tny-folder.h:
848 * src/modest-tny-folder.c:
849 (modest_tny_folder_is_local_folder),
850 (modest_tny_folder_get_local_folder_type),
851 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
853 * src/widgets/modest-main-window.h:
854 * src/maemo/modest-main-window.c: (create_details_widget),
855 (modest_main_window_set_contents_style): Show details for any folder store,
858 (modest_tny_folder_get_rules):
859 Remove the const. C does not support constness enough for this.
861 * src/modest-ui-actions.c:
862 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
863 make all outboxes appear as one, in the usual local-folders tree node.
865 (set_active_account_from_tny_account),
866 (modest_ui_actions_on_folder_selection_changed):
867 * src/widgets/modest-folder-view.c: (text_cell_data),
868 (icon_cell_data), (filter_row),
869 (add_account_folders_to_merged_folder),
870 (add_account_folders_to_simple_folder_store), (),
871 (get_cmp_rows_type_pos), (cmp_rows),
872 (modest_folder_view_set_account_id_of_visible_server_account):
873 Adjust to the new outbox system, using generic folder stores and folders
876 2007-05-23 Christian Kellner <ckellner@openismus.com>
878 * src/modest-mail-operation.c:
879 (modest_mail_operation_update_account):
880 Use info->max_size instead of unintialized local var [small
881 build fix]. (Added TODO to review that change since I don't
884 2007-05-23 Marcus Bauer <marcusb@openismus.com>
886 * libmodest-dbus-client/libmodest-dbus-client.c:
887 (libmodest_dbus_client_compose_mail): function added
888 * src/dbus_api/modest-dbus-api.h:
889 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
890 (on_compose_mail): Implementation of the SendAsMail functionality
892 2007-05-22 Murray Cumming <murrayc@murrayc.com>
894 * src/modest-account-mgr.c:
895 (modest_account_mgr_add_server_account): Set the secure-connection
896 conf key for transport accounts as well as store accounts. I don't know
897 why the if was there. For instance, this makes sure that we use SSL
898 for the gmail preset from the easysetup wizard.
900 2007-05-22 Murray Cumming <murrayc@murrayc.com>
902 * src/gnome/modest-main-window.c:
903 (on_account_store_connecting_finished), (connect_signals):
904 * src/maemo/modest-main-window.c:
905 (on_account_store_connecting_finished), (connect_signals),
906 (modest_main_window_new):
907 Handle TnyAccountStore::connecting-finished instead of
908 TnyDevice::connection-changed, because we cannot actually perform
909 operations on accounts until TnyAccountStore has itself responded to
910 the TnyDevice::connection-changed signal. This prevents a GError from
912 Do not try to update at startup, because we (at least on scratchbox)
913 already do an update at startup when the device goes online.
914 This prevents a GError from tinymail.
915 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
916 Added TODO about stopping simultaneous operations.
918 2007-05-21 Murray Cumming <murrayc@murrayc.com>
920 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
921 * src/modest-mail-operation-queue.c:
922 (modest_mail_operation_queue_remove):
923 * src/modest-tny-account-store.c: When GErrors happen, give more clues
924 about where they happened.
926 2007-05-21 Murray Cumming <murrayc@murrayc.com>
928 * src/modest-ui-actions.c:
929 (modest_ui_actions_on_password_requested): Make sure that the remember
930 output parameter is always TRUE.
932 2007-05-21 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
935 Show a OK/Cancel dialog if the error is a question, though we still do not
936 know anything more about what we are asking the user.
937 * src/widgets/modest-folder-view.c: (on_drag_data_received):
938 Fix an uninitialized variable (helper). This is a logic error, however.
940 2007-05-21 Christian Kellner <ckellner@openismus.com>
942 * src/modest-search.h:
943 Correct bit shifting in the ModestSearchFlags enum.
945 2007-05-21 Murray Cumming <murrayc@murrayc.com>
947 * src/modest-tny-account.c:
948 (modest_tny_account_new_from_server_account): Do not use the lsub and
949 check-all hard-coded IMAP options when using POP.
951 2007-05-21 Murray Cumming <murrayc@murrayc.com>
953 * src/modest-tny-account.c:
954 (modest_tny_account_new_from_server_account):
955 Use NULL for the secure-auth method for POP when Password auth has been
956 specified by the user, as we already do for IMAP. "auth=Login" causes
957 an error from camel or the server.
959 2007-05-17 Murray Cumming <murrayc@murrayc.com>
961 * src/maemo/modest-account-settings-dialog.c:
962 (create_page_account_details),
963 (modest_account_settings_dialog_set_account_name):
964 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
965 for the leave-on-server checkbox, rathr than just the checkbox, when
966 the protocol is not POP.
968 2007-05-17 Murray Cumming <murrayc@murrayc.com>
970 * src/widgets/modest-account-view.c:
971 * src/widgets/modest-account-view.h:
972 Added modest_account_view_select_account() which will be useful later
973 to asynchronously re-select the edited account.
975 2007-05-17 Murray Cumming <murrayc@murrayc.com>
977 * src/maemo/modest-account-settings-dialog.c:
978 (modest_account_settings_dialog_set_account_name):
979 Automatically choose the port numbers based on the secure authentication
980 methods, if they have not been chosen before.
981 This fixes projects.maemo.org bug NB#56273 .
983 2007-05-17 Murray Cumming <murrayc@murrayc.com>
985 * src/maemo/modest-main-window-ui.h:
986 * src/modest-ui-actions.c:
987 * src/modest-ui-actions.h:
988 Connect the Tools/SMTP Servers menu item to
989 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
990 SMTP servers dialog, as in the UI specification and saves changes when it
991 is closed. This fixed projects.maemo.org bug NB#56305 .
993 2007-05-17 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/modest-connection-specific-smtp-window.c:
996 (modest_connection_specific_smtp_window_init):
997 Use gtk_window_set_default_size() to make this window big enough, so
998 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1000 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1002 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1003 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1004 (modest_connection_specific_smtp_edit_window_init),
1005 Do not try to connect to a combobox signal before the combobox exists.
1006 This fixes the cras in projects.maemo.org bug NB#56288 .
1007 (modest_connection_specific_smtp_edit_window_get_settings):
1008 Remove the server_account_name parameter which was being checked for NULL
1009 though it was not used.
1011 * src/maemo/modest-connection-specific-smtp-window.c:
1012 (modest_connection_specific_smtp_window_fill_with_connections),
1013 (on_button_edit), (modest_connection_specific_smtp_window_init):
1014 Correct the number of treemodel columns to prevent a warning.
1015 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1016 libconic does not work.
1018 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1020 * src/modest-tny-account.c:
1021 (modest_tny_account_new_from_server_account):
1022 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1023 SMTP when "None" was chosen by the user. However, with my SMTP server that
1024 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1027 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1029 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1030 to explain the memory management issue with the ID in the ModestPair.
1032 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1033 (add_sending_page), (modest_account_assistant_finalize):
1034 * src/gnome/modest-gnome-global-settings-dialog.c:
1035 (create_updating_page), (create_composing_page):
1036 * src/gnome/modest-msg-edit-window.c: (get_transports),
1037 (init_window), (modest_msg_edit_window_finalize),
1038 (modest_msg_edit_window_get_msg_data):
1039 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1040 * src/gnome/modest-transport-widget.c:
1041 (modest_transport_widget_finalize), (smtp_configuration):
1042 * src/maemo/modest-maemo-global-settings-dialog.c:
1043 (create_updating_page), (create_composing_page):
1044 * src/maemo/modest-msg-edit-window.c: (get_transports),
1045 (init_window), (modest_msg_edit_window_finalize),
1046 (modest_msg_edit_window_get_msg_data),
1047 (modest_msg_edit_window_free_msg_data):
1048 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1049 (modest_store_widget_finalize):
1050 * src/maemo/modest-transport-widget.c:
1051 (modest_transport_widget_finalize), (smtp_configuration):
1052 * src/modest-main.c: (send_mail):
1053 * src/widgets/modest-combo-box.h:
1054 * src/widgets/modest-global-settings-dialog-priv.h:
1055 * src/widgets/modest-global-settings-dialog.c:
1056 (modest_global_settings_dialog_finalize):
1057 * src/widgets/modest-msg-edit-window.h:
1058 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1059 as long as the combo box, to prevent use of freed memory for the ID.
1061 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1063 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1064 get_accounts(), to make this clearer. Do not check for the enabled gconf
1065 key, because we do not use this for server accounts (at least, not yet).
1066 This allows us to send email again.
1068 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/modest-platform.c:
1071 (on_modest_conf_update_interval_changed), (modest_platform_init):
1072 Only respond to this particular key change. All these strcmp()s cannot be
1075 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1077 * src/maemo/modest-maemo-global-settings-dialog.c:
1078 (current_connection): Prevent a crash in scratchbox when
1079 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1080 * src/maemo/modest-platform.c:
1081 (on_modest_conf_update_interval_changed), (modest_platform_init):
1082 Get the update interval from gconf and reset it when the gconf key changes.
1084 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-protocol-info.c:
1087 * src/modest-protocol-info.h: Adde enum-specific get functions,
1088 instead of using a ModestProtocolType enum parameter.
1090 * src/gnome/modest-account-assistant.c:
1091 * src/gnome/modest-store-widget.c:
1092 * src/gnome/modest-store-widget.h:
1093 * src/gnome/modest-transport-widget.c:
1094 * src/gnome/modest-transport-widget.h:
1095 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1096 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1097 * src/maemo/easysetup/modest-easysetup-wizard.c:
1098 * src/maemo/modest-account-settings-dialog.c:
1099 * src/maemo/modest-account-settings-dialog.h:
1100 * src/maemo/modest-store-widget.c:
1101 * src/maemo/modest-store-widget.h:
1102 * src/maemo/modest-transport-widget.c:
1103 * src/maemo/modest-transport-widget.h:
1104 * src/modest-account-mgr-helpers.c:
1105 * src/modest-account-mgr-helpers.h:
1106 * src/modest-account-mgr.c:
1107 * src/modest-account-mgr.h:
1108 * src/modest-tny-account.c:
1109 * src/modest-tny-folder.c:
1110 * src/widgets/modest-account-view.c:
1111 * src/widgets/modest-retrieve-combo-box.c:
1112 * src/widgets/modest-retrieve-combo-box.h:
1113 * src/widgets/modest-secureauth-combo-box.c:
1114 * src/widgets/modest-serversecurity-combo-box.c:
1115 * src/widgets/modest-serversecurity-combo-box.h:
1116 * tests/check_account-mgr.c:
1117 Use the specific functions, and use the re-renamed enum values for GNOME too.
1119 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1121 * src/modest-pair.h:
1122 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1123 so we can get the second based on the first.
1125 * src/maemo/modest-account-settings-dialog.h:
1126 * src/maemo/modest-account-settings-dialog.c:
1127 Added get_supported_secure_authentication_methods(), though it is mostly
1128 commented-out for now until the necessary API is committed to tinymail.
1129 (modest_account_settings_dialog_set_account_name),
1130 (save_configuration): Request the supported authentication methods from the
1131 server, so we can choose a working method.
1133 * src/modest-tny-account-store.h:
1134 * src/modest-tny-account-store.c:
1135 (modest_tny_account_store_get_session): Rename from
1136 tny_account_store_get_session().
1138 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-protocol-info.h: Split the ModestProtocol enum
1141 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1142 There was no need to have these unrelated values in one enum.
1144 * src/: many files: Adapted to changed enum. This makes the code a bit
1145 clearer, and the compiler could catch some errors.
1147 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1150 Show the detailed internal camel error message when an error happens
1151 during the configuration, so that our testers can give us more clues.
1152 For instance, in projects.maemo.org bug NB#56910 .
1154 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1156 * src/modest-tny-account.c:
1157 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1158 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1160 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1162 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1163 * src/maemo/modest-account-settings-dialog.c:
1164 (modest_account_settings_dialog_set_account_name),
1165 (save_configuration): For the incoming secure authentication checkbox,
1166 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1167 the UI specification. PLAIN does not seem to be supported for most IMAP
1168 servers anyway, and I am not sure what it would mean.
1169 However, we probably need to discover which of the secure-authentication
1170 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1171 * src/modest-account-mgr-helpers.c:
1172 (modest_account_mgr_get_server_account_data):
1174 * src/modest-tny-account.c:
1175 (modest_tny_account_new_from_server_account):
1176 Use tny_account_set_mech() to set secure-authentication methods,
1177 with some special-casing for IMAP, based on my observations of how
1180 * src/modest-account-mgr-helpers.h:
1181 * src/modest-account-mgr.c:
1182 * src/modest-defs.h: Comment that the URI is only used for local folders.
1184 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1187 parameter const, just to be neat.
1188 * src/modest-text-utils.c: (modest_text_utils_inline):
1189 End g_strconcat() with NULL, as its documentation says. This is almost
1190 certainly the cause of my crash at startup on the device. Interestingly,
1191 valgrind doesn't tell us about these errors.
1193 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1195 * scripts/build-packages: Added more precise comments about how to use
1196 this script, though I still get this error:
1197 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1198 error building tinymail
1200 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1202 * src/maemo/modest-main-window.c: (on_account_update):
1203 Very slight cleanup, hoping to make it simpler to discover what causes
1204 a crash here sometimes.
1206 * src/modest-tny-account.c:
1207 (modest_tny_account_new_from_server_account): Set the port. Added
1208 comments about the options and a TODO comment because I need to find out
1209 how to specify the secure authentication method.
1211 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1213 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1214 changed CFlags paths form modest to libmodest
1216 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1218 * src/modest-account-mgr-helpers.c:
1219 (modest_account_mgr_get_server_account_data),
1220 (modest_account_mgr_free_server_account_data):
1221 * src/modest-account-mgr-helpers.h:
1222 * src/modest-account-mgr.c:
1223 (modest_account_mgr_add_server_account):
1224 * src/modest-defs.h:
1225 * src/modest-tny-account.c:
1226 (modest_tny_account_new_from_server_account):
1227 Determine the options for tny_camel_account_add_option() here,
1228 based on the settings, rather than storing them directly in gconf.
1230 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1233 Show a more friendly error dialog now that we expect (from the tinymail
1234 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1236 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1238 * src/maemo/modest-main-window.c: (on_account_update): Check that
1239 account_name is not NULL, to prevent a crash at startup that I am
1240 seeing on the N800. I do wonder why it is NULL.
1242 * src/maemo/easysetup/modest-easysetup-wizard.c:
1243 (create_page_user_details):
1244 * src/maemo/modest-account-settings-dialog.c:
1245 (create_page_user_details), (create_page_outgoing):
1246 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1247 (modest_connection_specific_smtp_edit_window_init):
1248 * src/modest-ui-actions.c:
1249 (modest_ui_actions_on_password_requested):
1250 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1251 might do something useful with the on-screen keyboard.
1253 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/modest-main-window.c: (on_account_update):
1256 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1257 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1259 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1261 * src/modest-tny-account-store.c: (on_account_changed):
1262 Correct the signature of this signal handler.
1264 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1266 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1267 Show a HildonNote instead of a GtkDialog for Maemo.
1269 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1271 * src/widgets/modest-account-view.h:
1272 * src/widgets/modest-account-view.c: (on_account_changed),
1273 (on_account_removed). Added a boolean flag, set/unset by
1274 modest_account_view_block_conf_updates(),
1275 modest_account_view_unblock_conf_updates() to prevent unnecessary
1276 updates, but this is not very useful because the gconf notifications are
1277 so delays (maybe only on Maemo Bora).
1278 So auto-updating is turned off, and these functions do an explicit
1279 update when necessary.
1280 However, something else is still doing too much work when adding/removing
1281 accounts, probably in another part of the application.
1283 * src/maemo/modest-account-view-window.c:
1284 (on_delete_button_clicked), (on_edit_button_clicked),
1285 (on_new_button_clicked): Use the new functions.
1287 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-account-mgr-helpers.c:
1290 (modest_account_mgr_set_first_account_as_default):
1291 Sort the list of names alphabetically-by-title, so we choose the first one
1293 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1294 alphabetically by the title.
1296 This fixes projects.maemo.org bug NB#56418 .
1298 * src/modest-account-mgr-priv.c:
1299 (_modest_account_mgr_account_from_key):
1300 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1301 avoid a valgrind error, and possible random behaviour.
1303 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1306 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1307 tinymail documentation to say that this can be expected.
1308 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1309 pretty, and should not happen, but I would prefer to know when it does.
1311 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1313 * configure.ac: When using the older hildon version, probably on Bora,
1314 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1316 * src/widgets/modest-attachment-view.c:
1317 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1320 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1322 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1323 Implemented the prototype. Can be tested with
1324 tests/dbus_api/test_open_message:
1326 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-tny-account-store.c:
1329 (modest_tny_account_store_instance_init), (get_password):
1330 * src/modest-ui-actions.c:
1331 (modest_ui_actions_on_password_requested):
1332 Do not store the password in gconf, because this function is called
1333 for non-remembered passwords. Actually use the cached (in the hash map)
1334 password instead of releasing it.
1335 The password will now not be remembered if it is asked via the protected
1336 password dialog, as per the UI spec.
1338 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1340 * src/modest-defs.h:
1341 * src/modest-account-mgr-helpers.h:
1342 * src/modest-account-mgr-helpers.c:
1343 Added modest_server_account_get_username_has_succeeded(),
1344 modest_server_account_set_username_has_succeeded().
1345 (modest_server_account_set_username),
1346 Reset the has-succeeded flag if the username changes.
1348 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1349 * src/maemo/modest-connection-specific-smtp-window.c:
1350 (modest_connection_specific_smtp_window_save_server_accounts):
1351 Use modest_server_account_set_username() instead of using
1352 modest_conf_set_string() directly, so that the has-succeeded flag is always
1355 * src/modest-ui-actions.c:
1356 (modest_ui_actions_on_password_requested): Dim the username entry if
1357 the username has ever worked, as per the UI spec.
1359 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-tny-account-store.c: (get_password):
1362 * src/modest-ui-actions.c:
1363 (modest_ui_actions_on_password_requested):
1364 Allow the username to be changed too, though there is more work to
1365 be done on exactly how this behaves.
1367 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1369 * src/modest-account-mgr-helpers.h:
1370 * src/modest-account-mgr-helpers.c:
1371 Added modest_account_mgr_get_display_name(),
1372 modest_server_account_get_username(),
1373 modest_server_account_set_username(),
1374 modest_server_account_set_password(),
1375 modest_server_account_get_hostname() functions so we do not need to
1376 use the conf API directly.
1378 * src/maemo/modest-main-window.c: (connect_signals):
1379 Actually connect ot the ModestAccountStore::request-password signal,
1380 so that we show the dialog when the password is requested by Tinymail,
1381 for isntance if it is empty.
1383 * src/modest-marshal.list:
1384 * src/modest-tny-account-store.c:
1385 (modest_tny_account_store_class_init), (get_password),
1386 (modest_tny_account_store_alert):
1387 * src/modest-tny-account-store.h:
1388 * src/modest-ui-actions.h:
1389 * src/modest-ui-actions.c:
1390 (modest_ui_actions_on_password_requested):
1391 Change the signal parameters, so it is obvious that we are providing
1392 the non human-readable server name, and receiving both the username
1393 and password, though changing of the username is not yet implemented.
1394 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1395 for the GNOME version.
1397 This should fix the projects.maemo.org bug NB#56209, though it does not
1398 work on Bora, because the gconf_client_get() for the password fails
1399 immediately after we save it with gconf_client_set().
1401 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1404 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1405 caused an undefined symbol error:
1406 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1408 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1410 * src/modest-tny-account-store.c:
1411 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1412 using a GError instead of a string message, so we can translate it in
1415 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1417 * src/maemo/modest-address-book.c:
1418 (modest_address_book_check_names):
1419 * src/maemo/modest-msg-view-window.c:
1420 (modest_msg_view_window_clipboard_owner_change):
1421 * src/modest-init.c: (modest_init_init_ui):
1422 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1423 (update_folders_cb), (modest_mail_operation_update_account):
1424 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1425 (modest_ui_actions_on_msg_attachment_clicked),
1426 (modest_ui_actions_on_msg_recpt_activated):
1427 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1428 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1429 (modest_msg_view_search_next):
1430 * src/widgets/modest-recpt-editor.c:
1431 (modest_recpt_editor_on_button_release_event),
1432 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1433 g_message(). At this point we should only be seeing interesting errors on
1434 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1436 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1438 (modest_wizard_dialog_force_title_update):
1439 * src/maemo/easysetup/modest-wizard-dialog.h:
1440 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1441 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1442 can update the title when appropriate. Otherwise the title is wrong if the
1443 pages are added after adding the notebook to the dialog.
1444 This must be a problem in HildonWizardDialog too.
1445 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1447 * src/maemo/easysetup/modest-easysetup-wizard.c:
1448 (create_subsequent_customsetup_pages),
1449 (create_subsequent_easysetup_pages):
1450 Call modest_wizard_dialog_force_title_update() so that the title is
1451 correct even with GTK+ < 2.10.
1452 This fixes projects.maemo.org bug NB#56145 .
1454 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1456 * src/maemo/modest-platform.c:
1457 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1458 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1461 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1463 * src/widgets/modest-window.h:
1464 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1465 and modest_window_save_state(), which invokes it.
1467 * src/widgets/modest-window-mgr.h:
1468 * src/widgets/modest-window-mgr.c:
1469 Added modest_window_mgr_save_state_for_all_windows(), which calls
1470 the save_state vfunc on all registered windows, if implemented.
1472 * src/gnome/modest-msg-edit-window.c:
1473 * src/gnome/modest-msg-view-window.c:
1474 * src/maemo/modest-msg-edit-window.c:
1475 * src/maemo/modest-msg-view-window.c:
1476 * src/maemo/modest-main-window.c:
1477 Specify the existing save_settings functions as implementations of
1478 ModestWindow::save_state_func().
1480 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1481 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1482 enabling hibernation, for instance.
1484 We may need to do the same thing for restoring settings.
1487 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1489 * src/widgets/modest-window-mgr.c:
1490 * src/widgets/modest-window-mgr.h:
1491 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1492 modest_window_mgr_get_hibernation_is_prevented().
1494 * src/maemo/modest-main-window.c:
1495 (on_hildon_program_is_topmost_notify): Prevent hibernation
1496 (possible when the application goes to the background in the WM),
1497 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1499 * src/maemo/easysetup/modest-easysetup-wizard.c:
1500 (modest_easysetup_wizard_dialog_init):
1501 * src/maemo/modest-account-settings-dialog.c:
1502 (modest_account_settings_dialog_init):
1503 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1504 (modest_connection_specific_smtp_edit_window_init):
1505 * src/maemo/modest-connection-specific-smtp-window.c:
1506 (modest_connection_specific_smtp_window_init):
1507 * src/maemo/modest-signature-editor-dialog.c:
1508 (modest_signature_editor_dialog_init):
1509 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1510 prevent hibernation while any of these account settings dialogs are open.
1512 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/Makefile.am:
1515 * src/maemo/modest-osso-state-saving.c:
1516 * src/maemo/modest-osso-state-saving.h: Added
1517 modest_osso_load_state() and modest_osso_save_state() though they do
1518 nothing now. They should iterate through all the open windows and load/save
1520 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1521 save state when closing.
1523 * src/maemo/modest-main-window.c:
1524 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1525 Add a notification handler for the HildonProgram::is-topmost property,
1526 so we can allow hibernation when the application goes into the background.
1527 But we still need to detect when the accounts setup windows are open so
1528 we can stop hibernation when they are open.
1529 To do this, I also added the main window the HildonProgram. This might have
1530 other side-effects/benefits, and should maybe be done for other windows.
1532 * src/maemo/modest-osso-autosave-callbacks.h:
1533 * src/maemo/modest-osso-autosave-callbacks.c:
1534 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1535 though it does not do anything yet, and we might never need this to do
1536 anything. For instance, we already save drafts.
1538 * src/maemo/modest-platform.c: (modest_platform_init):
1539 Specify the libosso auto-save callback.
1541 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1543 * src/maemo/modest-platform.c:
1544 (modest_platform_set_update_interval):
1545 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1546 aparently stays valid between application instances, so we can use this
1547 to remove and reset it later. According to a maemo-developers email from
1550 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1552 * configure.ac: Depend on libalarm for Maemo.
1554 * src/dbus_api/modest-dbus-api.h:
1555 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1556 (on_send_receive), (modest_dbus_req_handler):
1557 Handle a SEND_RECEIVE D-Bus method.
1559 * libmodest-dbus-client/libmodest-dbus-client.c:
1560 (libmodest_dbus_client_send_and_receive):
1561 * libmodest-dbus-client/libmodest-dbus-client.h:
1562 Add C convenience functions for calling the new D-Bus method.
1564 * src/modest-platform.h:
1565 * src/gnome/modest-platform.c:
1566 * src/maemo/modest-platform.c:
1567 Added modest_platform_set_update_interval(), which uses the
1568 alarmd API on Maemo.
1569 (modest_platform_init),
1570 Call modest_platform_set_update_interval(), using a hard-coded
1571 interval for now (until the global settings dialog is implemented),
1572 though I am not sure that this makes sense yet.
1574 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1576 * src/dbus_api/modest-dbus-callbacks.c:
1577 (modest_osso_cb_hw_state_handler):
1578 * src/dbus_api/modest-dbus-callbacks.h:
1579 * src/maemo/modest-platform.c: (modest_platform_init):
1580 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1581 in case this has some effect on the ability for Maemo to ping the
1584 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1587 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1588 warning. It is probably a logic error, but I need to fix the build.
1590 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1592 * src/modest-account-mgr.h:
1593 * src/modest-account-mgr.c:
1594 (modest_account_mgr_account_names): Add a gboolean enabled_only
1595 parameter, so we can get lists of onlt the enabled accounts.
1597 (modest_account_mgr_add_account),,
1598 (modest_account_mgr_account_with_display_name_exists):
1599 * src/maemo/modest-msg-edit-window.c: (get_transports):
1600 * src/modest-account-mgr-helpers.c:
1601 (modest_account_mgr_set_first_account_as_default):
1602 * src/modest-init.c: (init_default_account_maybe):
1603 * src/modest-tny-account-store.c: (get_accounts):
1604 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1605 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1606 * tests/check_account-mgr.c: (START_TEST):
1607 Provide the extra parameter, as appropriate.
1609 * src/widgets/modest-account-view.c: (update_account_view):
1610 Do not show disabled accounts (meaning that there is no way to
1611 enable/disable accounts in the UI (the feature is not in our UI
1612 specification), so we can use this internally only to mark unfinished
1613 or temporary account data.
1615 * src/maemo/easysetup/modest-easysetup-wizard.c:
1616 (create_account): Add boolean enable parameter, so we can specify FALSE
1617 to create the temporary account.
1618 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1619 (on_before_next): When finishing, when there is a temporary account, just
1621 Also, use a timeout to delay the showing of the dialog until gconf is likely
1622 to return correct information, due to a maemo gconf bug that is fixed in
1623 osso 1.1, but not yet in Bora.
1624 However, the dialog stays on screen after it is destroyed.
1626 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1627 for invalid data when cancelling. Use a hildon note instead of a dialog
1628 to complain about invalid data. Do not show the account-saved note if the
1629 account is disabled (a temporary account that will not really be saved for use
1632 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1634 * src/modest-account-mgr-helpers.h:
1635 * src/modest-account-mgr-helpers.c:
1636 Added modest_account_mgr_unset_default_account(),
1637 Added modest_account_mgr_set_first_account_as_default().
1639 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1640 If it was the default account, unset the default account name.
1642 * src/maemo/modest-account-view-window.c:
1643 (on_delete_button_clicked): If it was the default account,
1644 set the first remaining account as the default instead.
1646 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1647 a NULL account or a NULL default account, to prevent a crash. This should
1648 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1651 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1653 * src/widgets/modest-recpt-editor.c:
1654 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1655 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1656 TODO comment for this. This fixes the build.
1658 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1659 be the best place for it. This will in future update all auto-update accounts,
1660 rather than just the current/default account, when that gconf key exists.
1661 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1662 if there are no accounts, before calling do_send_receive().
1663 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1665 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1666 * src/maemo/modest-main-window-ui.h:
1667 * src/maemo/modest-main-window.c: (on_connection_changed),
1668 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1669 directly, becaue the signal handler does more.
1671 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1673 * src/modest-account-mgr-helpers.c:
1674 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1675 for the case that the account does not exist.
1677 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1678 (equivalent to the modest account name) rather than the tinymail account name
1679 (equivalent to the modest account title - human readable) to get the account data.
1680 Check for null account data to prevent the crash, and add a TODO comment saying that
1681 this needs fixing because it is using the server account name instead of the account name.
1683 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1686 * src/maemo/modest-account-settings-dialog.c: (show_error),
1688 Use hildon_note_new_information() for informative and error messages,
1689 which seems to be expected for Maemo applications (no documentation that I know of
1690 says this). I am surprised that there is no distinction between info and error
1693 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1695 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1696 it is easy to find where this is used.
1698 * src/maemo/easysetup/modest-easysetup-wizard.c:
1699 (create_page_welcome), (create_page_account_details),
1700 (create_page_user_details), (create_page_complete_easysetup),
1701 (create_page_custom_incoming), (create_page_custom_outgoing),
1702 (create_page_complete_custom):
1703 * src/maemo/modest-account-settings-dialog.c:
1704 (create_page_account_details), (create_page_user_details),
1705 (create_page_incoming), (create_page_outgoing):
1706 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1707 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1708 (modest_connection_specific_smtp_edit_window_init):
1709 * src/maemo/modest-connection-specific-smtp-window.c:
1710 (modest_connection_specific_smtp_window_init):
1711 * src/maemo/modest-signature-editor-dialog.c:
1712 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1713 and scrolling policy as per the Email Application Layout Guide, if I have
1716 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1719 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1720 which were empty, because these vfuncs have been removed from TnyAccountStore.
1721 This fixes the build.
1723 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1725 * src/maemo/modest-main-window.c:
1726 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1727 showing/hiding it. Added TODO because it probably should not be NULL.
1728 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1729 because unnecessary g_warnings() make degugging difficult.
1731 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1733 * src/maemo/modest-msg-edit-window.c:
1734 (modest_msg_edit_window_select_color),
1735 (modest_msg_edit_window_select_background_color): 2 const corrections and
1736 moving 2 #endifs before closing brackets, to fix the build.
1738 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1740 * src/maemo/easysetup/modest-easysetup-wizard.h:
1741 * src/maemo/easysetup/modest-easysetup-wizard.c:
1742 (modest_easysetup_wizard_dialog_finalize),
1743 (on_button_edit_advanced_settings), (create_page_complete_custom),
1744 (on_response), (create_account):
1745 Implement the Advanced Settings edit button, by saving the account information,
1746 for the Advanded Settings dialog to use directly from gconf, and removing it
1747 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1748 Bug #5533 in the projects.maemo.org bugzilla.
1750 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1752 * src/maemo/modest-msg-view-window.c:
1753 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1754 when opening a message window.
1756 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1758 * src/maemo/easysetup/modest-easysetup-wizard.c:
1759 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1762 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1763 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1764 gconf settings. I probably added more checks than necessary, but that is safer.
1766 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1767 variable to fix the build, but this seems to be used when it is still NULL.
1769 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1771 * src/modest-platform.h:
1772 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1773 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1774 * src/modest-main.c: Implement this function so we can avoid using
1775 maemo-specific API from cross-platform code.
1777 * src/modest-tny-account-store.c:
1778 (get_smtp_specific_transport_account_for_open_connection):
1779 * src/modest-ui-actions.c: (check_for_connection),
1780 (modest_ui_actions_on_item_not_found):
1781 Use modest_platform_connect_and_wait() and put #idefs around other
1782 maemo-specific code, because only maemo currently has a way to
1783 identify connection names.
1785 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1787 * src/modest-tny-account-store.h:
1788 * src/modest-tny-account-store.c:
1789 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1790 the connection-specific SMTP server settings in the configuration.
1792 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1794 * src/maemo/modest-main-window.c: (on_connection_changed),
1796 * src/modest-main.c: (main), (start_ui), (send_mail):
1797 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1798 that is what is intended.
1800 * src/modest-ui-actions.c: (action_send), (action_receive),
1801 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1802 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1803 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1804 SMTP server is used when it is specified.
1806 (modest_ui_actions_on_send_receive):
1807 Check that a connection is open before proceeding.
1808 Receive and then send, instead of vice-versa, as per the specification.
1810 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1812 * src/modest-mail-operation.c:
1813 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1814 though I guess it should be something other than NULL.
1816 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1818 * src/maemo/easysetup/modest-easysetup-wizard.c:
1819 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1820 combo twice, to avoid an g_warning and to make it visible again.
1821 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1822 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1823 (already intended) dereference when detaching, because we then recreate the menu.
1824 But I am not sure why the warning was happening, and it is possible that this is a memory
1827 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1829 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1830 and uri_parse_mailto() utility functions.
1831 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1833 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1835 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1837 * src/dbus_api/modest-dbus-api.h:
1838 * src/dbus_api/modest-dbus-callbacks.c:
1839 Use an idle callback to execute the modest code in the application's own thread.
1840 Remove the helloworld example method.
1841 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1842 parsed, and the open-message method is not implemented because this is not yet implemented in
1844 * libmodest-dbus-client/libmodest-dbus-client.c:
1845 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1846 (libmodest_dbus_client_open_message):
1847 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1849 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1850 body without crashing.
1852 * tests/dbus_api/Makefile.am:
1853 * tests/dbus_api/test_mail_to.c:
1854 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1856 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1858 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1859 Added file to fix the build. Sorry.
1861 * src/dbus_api/Makefile.am:
1862 * src/dbus_api/modest-dbus-api.h:
1863 * src/dbus_api/modest-dbus-callbacks.h:
1864 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1865 (modest_dbus_req_handler):
1866 Put constants in a separate header so it can be reused by the
1867 client library, without duplication
1869 * libmodest-dbus-client/Makefile.am:
1870 * libmodest-dbus-client/libmodest-dbus-client.c:
1871 (libmodest_dbus_client_call_helloworld),
1872 (libmodfest_dbus_client_send_mail),
1873 (libmodfest_dbus_client_mailto),
1874 (libmodfest_dbus_client_open_message):
1875 * libmodest-dbus-client/libmodest-dbus-client.h:
1876 (Partly) Implement a send_mail D-Bus method.
1878 * tests/dbus_api/Makefile.am:
1879 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1880 the send_email D-Bus method.
1882 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1886 * libmodest-dbus-client/Makefile.am:
1887 * libmodest-dbus-client/libmodest-dbus-client.c:
1888 * libmodest-dbus-client/libmodest-dbus-client.h:
1889 * tests/dbus_api/Makefile.am:
1890 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1891 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1893 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1895 * src/maemo/easysetup/modest-easysetup-wizard.c:
1896 (create_page_account_details):
1897 * src/maemo/modest-account-settings-dialog.c:
1898 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1899 widgets, because this might not be the default in future versions of the Maemo GTK+.
1900 However, I can not not get capitalization to work even in a simple test case.
1902 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1904 * src/maemo/easysetup/modest-easysetup-wizard.c:
1905 (create_page_custom_incoming), (create_page_custom_outgoing):
1906 * src/maemo/modest-account-settings-dialog.c:
1907 (create_page_account_details), (create_page_incoming),
1908 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1909 instead of using gtk_check_button_with_label(), so they are aligned like the other
1910 widgets, as per the UI spec.
1912 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1914 * src/maemo/easysetup/modest-easysetup-wizard.c:
1915 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1916 * src/widgets/modest-validating-entry.c:
1917 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1918 Modest prefix instead of an EasySetup prefix.
1920 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1922 * src/widgets/modest-validating-entry.h:
1923 * src/widgets/modest-validating-entry.c: (on_insert_text),
1924 Added easysetup_validating_entry_set_max_func(), used to set a callback
1925 to call when the max number of characters is reached. GtkEntry has a max-length
1926 already but is silent about it.
1928 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1929 (create_page_account_details), (create_page_user_details),
1931 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1932 (create_page_account_details), (create_page_user_details),
1933 (create_page_outgoing):
1934 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1935 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1936 the UI spec, when the user tries to enter more than the max number of characters.
1938 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1940 * src/maemo/easysetup/modest-easysetup-wizard.c:
1941 (create_page_user_details), (create_page_custom_incoming),
1942 (create_page_custom_outgoing):
1943 * src/maemo/modest-account-settings-dialog.c:
1944 (create_page_user_details), (create_page_incoming),
1945 (create_page_outgoing):
1946 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1947 (modest_connection_specific_smtp_edit_window_init):
1948 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1949 not appropriate. Bad Maemo-specific defaults!.
1951 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1954 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1955 (modest_signature_editor_dialog_set_settings):
1956 Disable the label and textview when the checkbox is disabled, and use the
1957 specified (UI spec) default signature text.
1959 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1962 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1964 * src/modest-defs.h:
1965 * src/modest-account-mgr-helpers.h:
1966 * src/modest-account-mgr-helpers.c:
1967 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1969 * src/maemo/Makefile.am:
1970 * src/maemo/modest-signature-editor-dialog.c:
1971 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1974 * src/maemo/modest-account-settings-dialog.h:
1975 * src/maemo/modest-account-settings-dialog.c:
1976 (modest_account_settings_dialog_finalize), (on_button_signature),
1977 (save_configuration): Use the new dialog when the Edit button is pressed, and
1978 save the changes if necessary, as per the UI spec.
1980 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/Makefile.am:
1983 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1984 based on maemo-develoers email from Dirk.
1986 * src/maemo/easysetup/modest-easysetup-wizard.c:
1987 (create_page_welcome), (create_page_account_details),
1988 (create_page_user_details), (create_page_complete_easysetup),
1989 (create_page_custom_incoming), (create_page_custom_outgoing),
1990 (create_page_complete_custom),
1991 (modest_easysetup_wizard_dialog_init):
1992 * src/maemo/modest-account-settings-dialog.c:
1993 (create_page_account_details), (create_page_user_details),
1994 (create_page_incoming), (create_page_outgoing),
1995 (modest_account_settings_dialog_init):
1996 * src/maemo/modest-connection-specific-smtp-window.c:
1997 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1999 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2001 * src/maemo/easysetup/modest-easysetup-wizard.c:
2002 (create_page_account_details), (create_page_custom_outgoing),
2003 (create_page_complete_custom):
2004 * src/maemo/modest-account-settings-dialog.c:
2005 (create_page_user_details), (create_page_incoming),
2006 (create_page_outgoing):
2007 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2008 (modest_connection_specific_smtp_edit_window_init):
2009 Use the correct (UI spec) port min/max, and use horizontal separators,
2012 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/easysetup/modest-easysetup-wizard.c:
2015 (set_default_custom_servernames):
2016 * src/maemo/modest-account-settings-dialog.c:
2017 (create_page_incoming), (on_combo_outgoing_security_changed),
2018 (on_combo_incoming_security_changed), (create_page_outgoing),
2019 (modest_account_settings_dialog_set_account_name),
2020 (save_configuration):
2021 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2022 (on_combo_security_changed),
2023 (modest_connection_specific_smtp_edit_window_init),
2024 (modest_connection_specific_smtp_edit_window_set_connection),
2025 (modest_connection_specific_smtp_edit_window_get_settings):
2026 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2029 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2032 * src/maemo/easysetup/modest-easysetup-wizard.c:
2033 (create_page_custom_outgoing), (create_page_complete_custom):
2034 * src/maemo/modest-account-settings-dialog.c:
2035 (create_page_user_details), (create_page_outgoing):
2036 * src/maemo/modest-account-view-window.c: (button_box_new):
2037 Use changed logical IDs as per the most recent UI spec:
2038 mcen_bd_emailsetup_edit -> mcen_bd_edit
2039 mcen_bd_emailsetup_delete -> mcen_bd_delete
2040 mcen_bd_emailsetup_close -> mcen_bd_close
2042 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2046 * src/dbus_api/Makefile.am:
2047 * src/dbus_api/modest-dbus-callbacks.c:
2048 * src/dbus_api/modest-dbus-callbacks.h:
2049 * src/maemo/modest-platform.c: (modest_platform_init):
2050 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2052 * tests/Makefile.am:
2053 * tests/dbus_api/Makefile.am:
2054 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2056 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2058 * src/maemo/modest-account-settings-dialog.c:
2059 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2060 Removed unnecessary includes.
2062 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/easysetup/modest-easysetup-wizard.c:
2065 * src/maemo/modest-account-settings-dialog.c:
2066 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2067 * src/widgets/Makefile.am:
2068 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2069 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2070 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2071 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2072 * src/widgets/modest-secureauth-combo-box.c:
2073 * src/widgets/modest-secureauth-combo-box.h:
2074 * src/widgets/modest-serversecurity-combo-box.c:
2075 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2076 made the GObject names more consistent with the rest of the Modest code.
2078 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2080 * src/maemo/easysetup/Makefile.am:
2081 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2082 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2083 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2084 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2085 * src/maemo/easysetup/modest-easysetup-wizard.c:
2086 * src/maemo/easysetup/modest-validating-entry.c:
2087 * src/maemo/easysetup/modest-validating-entry.h:
2088 * src/maemo/modest-account-settings-dialog.c:
2089 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2090 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2091 widgets/ because they are used outside of easysetup too. After checking in,
2092 svn will allow me to rename them too.
2094 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2096 * src/gnome/modest-msg-edit-window.c:
2097 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2098 linker error, to fix the build on the GNOME platform.
2099 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2100 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2101 ifdefed out to avoid a warning.
2103 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2105 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2106 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2107 some alternative for GTK+ 2.6.
2109 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2111 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2113 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2114 specified for EmailAccountsDialog in UI spec.
2116 * src/maemo/easysetup/modest-easysetup-wizard.c:
2117 * src/maemo/easysetup/modest-easysetup-wizard.h:
2118 * src/maemo/modest-account-settings-dialog.c:
2119 * src/maemo/modest-account-settings-dialog.h:
2120 Reuse a member window widget for the connection-specific SMTP server accounts,
2121 so we can tell it to create/save the accounts only if we actually save changes.
2123 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2125 (modest_connection_specific_smtp_edit_window_get_settings):
2126 Return a struct instance for temporarily remembering the entered data.
2128 * src/maemo/modest-connection-specific-smtp-window.h:
2129 * src/maemo/modest-connection-specific-smtp-window.c:
2130 (modest_connection_specific_smtp_window_finalize),
2131 (modest_connection_specific_smtp_window_fill_with_connections),
2133 (modest_connection_specific_smtp_window_save_server_accounts),
2134 (update_model_server_names): Do not actually save data until asked,
2135 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2137 (on_selection_changed),
2138 (modest_connection_specific_smtp_window_init): Disable the edit
2139 button when nothing is selected.
2141 * src/modest-account-mgr-helpers.c:
2142 * src/modest-account-mgr-helpers.h:
2143 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2146 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-account-mgr-helpers.h:
2149 * src/modest-account-mgr-helpers.c:
2150 (modest_account_mgr_get_unused_account_name),
2151 (modest_account_mgr_get_unused_account_display_name): Added these
2152 utility functions, to avoid code duplication.
2154 * src/maemo/easysetup/modest-easysetup-wizard.c:
2155 (create_page_account_details), (create_account):
2156 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2157 (on_combo_security_changed),
2158 (modest_connection_specific_smtp_edit_window_init),
2159 (modest_connection_specific_smtp_edit_window_save_settings):
2160 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2161 * src/maemo/modest-connection-specific-smtp-window.c:
2162 (modest_connection_specific_smtp_window_finalize),
2163 (modest_connection_specific_smtp_window_fill_with_connections),
2164 (on_button_edit), (modest_connection_specific_smtp_window_init):
2165 * src/maemo/modest-connection-specific-smtp-window.h:
2166 Implementing saving of connection-specific server accounts.
2168 But I need to refactor this so we can save the data for each
2169 possible connection-specific account and only actually create the server accounts
2170 when the easysetup finished, or the OK button is pressed on the account settings
2173 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2175 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2176 (on_combo_security_changed):
2177 (modest_connection_specific_smtp_edit_window_init):
2178 Auto-fill the port number as in the account settings.
2180 (modest_connection_specific_smtp_edit_window_set_connection):
2181 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2182 * src/maemo/modest-connection-specific-smtp-window.c:
2183 (fill_with_connections), (on_button_edit),
2184 (modest_connection_specific_smtp_window_init):
2185 Turn the edit window into a dialog to simplify the code, and
2186 set a WM hint as in a GtkDialog, because only a popup can be on top of
2187 another window in Maemo, and popups usually have no WM decoration.
2189 * src/modest-defs.h:
2190 * src/modest-account-mgr-helpers.c:
2191 (modest_account_mgr_set_connection_specific_smtp),
2192 (modest_account_mgr_remove_connection_specific_smtp),
2193 (modest_account_mgr_get_connection_specific_smtp):
2194 * src/modest-account-mgr-helpers.h: Some functions to write the
2195 connection-specific SMTP server information. Not yet used.
2198 * src/widgets/modest-folder-view.c: (text_cell_data):
2199 Fix a warning about an uninitialized variable.
2200 (on_configuration_key_changed): Put an #ifdef around the use
2201 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2203 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2205 * src/maemo/modest-account-settings-dialog.h:
2206 * src/maemo/modest-account-settings-dialog.c:
2207 Added connect_for_modified() utility function to mark the new modified boolean.
2209 (create_page_account_details), (create_page_user_details),
2210 (create_page_incoming), (create_page_outgoing), (on_response),
2211 (modest_account_settings_dialog_init),
2212 (modest_account_settings_dialog_set_account_name):
2213 Only warn about unsaved changes when there are actually unsaved changes.
2215 * src/modest-account-mgr-helpers.c:
2216 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2217 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2218 to get the data from there in future.
2220 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2222 * src/modest-defs.h:
2224 * src/modest-account-mgr-helpers.h:
2225 * src/modest-account-mgr-helpers.c:
2226 Store the security account setting in a single conf key instead of using
2227 the options list, so that the list is left for just the to-be-removed camel hack,
2228 and because gconf_client_set_list() is failing for some reason.
2230 * src/modest-account-mgr.c:
2231 (modest_account_mgr_add_server_account):
2232 * src/maemo/modest-account-settings-dialog.c:
2233 (modest_account_settings_dialog_set_account_name),
2234 (save_configuration): Use the renamed functions.
2237 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2239 * src/widgets/Makefile.am:
2240 * src/widgets/modest-limit-retrieve-combo-box.c:
2241 * src/widgets/modest-limit-retrieve-combo-box.h:
2242 * src/widgets/modest-retrieve-combo-box.c:
2243 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2244 the account settings dialog.
2246 * src/modest-defs.h:
2247 * src/modest-account-mgr-helpers.h:
2248 * src/modest-account-mgr-helpers.c:
2249 (modest_server_account_get_option_secure_auth),
2250 (modest_server_account_set_option_secure_auth):
2251 * src/modest-account-mgr.c:
2252 (modest_account_mgr_add_server_account):
2253 Use the existing AUTH_MECH conf key for the secure-auth setting,
2254 instead of putting it in the list options, because this was actually used already.
2256 * src/maemo/modest-account-settings-dialog.c:
2257 (create_page_account_details),
2258 (modest_account_settings_dialog_set_account_name),
2259 (save_configuration):
2260 * src/maemo/modest-account-settings-dialog.h:
2261 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2262 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2264 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2266 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2267 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2268 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2270 * src/modest-defs.h:
2271 * src/maemo/modest-account-settings-dialog.c:
2272 (create_page_incoming), (on_combo_outgoing_security_changed),
2273 (on_combo_incoming_security_changed), (create_page_outgoing),
2274 (modest_account_settings_dialog_set_account_name),
2275 (save_configuration): Load/Save the port number, and change it when the
2276 security combo changes, to suitable defaults.
2278 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-account-mgr.c:
2281 (modest_account_mgr_add_server_account): Set the security and secure-auth
2282 options, and add a comment saying that the other camel-specific options should be
2285 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2289 * src/modest-tny-account-store.c: (account_list_free),
2290 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2291 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2294 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2296 * src/modest-protocol-info.c:
2297 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2298 is required by our UI spec. Maybe something in our implementation will use this eventually.
2299 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2300 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2301 instead of the previous 0 placeholder.
2303 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2304 secure-auth settings.
2305 * src/modest-account-mgr-helpers.h:
2306 * src/modest-account-mgr-helpers.c:
2307 (modest_server_account_data_get_option_secure_auth),
2308 (modest_server_account_set_option_secure_auth),
2309 (modest_server_account_data_get_option_security),
2310 (modest_server_account_set_option_security): Added this API for getting and setting the security
2311 and secure-auth settings.
2313 * src/maemo/modest-account-settings-dialog.h:
2314 * src/maemo/modest-account-settings-dialog.c:
2315 (modest_account_settings_dialog_finalize), (check_data),
2316 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2317 about changing titles.
2318 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2319 (save_configuration): Save the security and secure-auth settings.
2321 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2322 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2324 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2326 * src/modest-defs.h:
2327 * src/modest-account-mgr.c:
2328 (modest_account_mgr_add_server_account):
2329 Added and used defines for the options key and value pair strings,
2330 that are used so far, though they do not seem to correspond to anything in our
2331 UI specs or ModestProtocol enum.
2333 * src/modest-account-mgr-helpers.h:
2334 * src/modest-account-mgr-helpers.c:
2335 (compare_option_strings_for_name),
2336 (modest_server_account_data_get_option_value),
2337 (modest_server_account_data_get_option_bool),
2338 (modest_account_mgr_get_server_account_option):
2339 Added helper functions for parsing the options GSList.
2341 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2343 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2344 display name is based on the supplied account name.
2345 * src/modest-account-mgr.c:
2346 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2347 with an inefficient, but good-enough, implementation.
2349 * src/maemo/easysetup/modest-easysetup-wizard.c:
2350 (create_page_account_details), (on_before_next), (create_account):
2351 Check for existing display names rather than (non-user-visible) account names, and just
2352 create and set a unique account name at the end.
2354 * src/maemo/modest-account-settings-dialog.c:
2355 (modest_account_settings_dialog_init),
2356 (modest_account_settings_dialog_set_account_name),
2357 (create_page_incoming): Show the display name, instead of the account name.
2358 (on_response): Do some (not all) extra checks, as in the UI spec.
2359 (save_configuration): Save the display name if it was changed.
2361 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2363 * po/en_GB.po: Added needed logical ID and translation.
2364 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2365 (init_view): Made the is-default column clicking work.
2367 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2370 * src/maemo/easysetup/Makefile.am:
2371 * src/maemo/easysetup/modest-easysetup-wizard.c:
2372 (modest_easysetup_wizard_dialog_init):
2373 * src/maemo/easysetup/provider-data-test.keyfile:
2374 * src/maemo/easysetup/provider-data.keyfile:
2375 Moved the provider data file to the new modest-providers-data package and used it from there.
2377 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2379 * src/modest-local-folder-info.c:
2380 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2381 N_() was already used on the static strings, but this just marks it for translation without
2382 using the translation.
2384 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/modest-account-settings-dialog.c:
2387 (create_page_incoming),
2388 (modest_account_settings_dialog_set_account_name):
2389 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2390 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2391 I will do this if nobody else gets there first.
2393 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2395 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2396 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2397 save the security stuff.
2399 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2401 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2402 Set the email address and user fullname, which I now see must be
2405 * src/maemo/modest-account-settings-dialog.h:
2406 * src/maemo/modest-account-settings-dialog.c:
2408 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2409 leave-on-server and authentication.
2410 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2413 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2416 * src/maemo/modest-account-settings-dialog.c:
2417 * src/maemo/modest-account-settings-dialog.h:
2418 Most (but not all) of the widgets are now present as specified by the UI spec.
2419 No changes are yet saved, and some details are not properly shown yet.
2421 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2423 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2425 * src/maemo/Makefile.am:
2426 * src/maemo/modest-account-settings-dialog.c:
2427 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2428 an existing account. Doesn't do much yet.
2430 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2431 Open the accounts settings dialog when Edit is clicked.
2433 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2435 * src/maemo/easysetup/Makefile.am:
2436 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2438 * src/maemo/easysetup/modest-easysetup-wizard.c:
2439 (modest_easysetup_wizard_dialog_init):
2440 Try to get the source directory from the build system,
2441 instead of hard-coding "./" into the source code, when opening our local
2442 copies of the configuration files.
2443 But this still fails when opening the wizard from the Accounts window,
2444 maybe because the working directory seems to change at runtime.
2445 So the wizard will fail the second time unless you copy the files into their
2446 proper locations - see the stdout warnings for the paths.
2448 (create_page_account_details),(on_before_next):
2449 Check for existing non-server accounts instead of server accounts,
2450 so the default account name is useful again, and to prevent trying to
2453 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2454 Show the wizard when New is clicked.
2456 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2457 (init_view): Show the column headers, and show the columns that are
2458 specified in the UI specs. However, something in Maemo's GTK+ prevents
2459 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2460 change the default account. This is despite unsetting the special properties.
2462 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2464 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2465 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2466 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2467 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2468 to make that clearer.
2469 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2471 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2473 * src/maemo/modest-account-view-window.c:
2474 (modest_account_view_window_init),
2475 (modest_account_view_window_new):
2476 Use the same buttons as specified in the
2477 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2478 the existing widgets, which never had a chance of working.
2479 Put the ModestAccountView treeview in a scrolled window.
2480 Do not repeat the initialization in both _init() and _new().
2482 * src/widgets/modest-account-view.c: (update_account_view):
2483 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2484 this widget and window shows no accounts.
2486 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2488 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2490 * src/maemo/easysetup/modest-easysetup-wizard.c:
2491 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2492 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2493 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2496 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2497 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2498 accounts exist yet, as in the UI spec.
2500 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2502 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2504 * src/maemo/Makefile.am:
2505 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2506 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2507 New window for editing connection-specific smtp details.
2508 Not fully implemented.
2510 * src/maemo/modest-connection-specific-smtp-window.c:
2511 (modest_connection_specific_smtp_window_finalize) :
2512 unref the tree model.
2513 (on_button_edit): Show the edit window.
2515 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2517 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2520 * src/maemo/Makefile.am:
2521 * src/maemo/modest-connection-specific-smtp-window.c:
2522 * src/maemo/modest-connection-specific-smtp-window.h:
2523 New window for showing the list of connections, for connection-specific
2524 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2525 * src/maemo/easysetup/modest-easysetup-wizard.c:
2526 (create_page_custom_outgoing): Show the new window when the button is clicked.
2528 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2530 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2531 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2532 * src/maemo/modest-msg-edit-window.c:
2533 (modest_msg_edit_window_insert_image):
2534 * src/modest-conf.c: (modest_conf_key_escape):
2535 * src/modest-mail-operation.c:
2536 (modest_mail_operation_send_new_mail):
2537 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2538 (modest_ui_actions_on_new_account):
2539 * src/widgets/modest-attachment-view.c: (update_filename_request):
2540 * src/widgets/modest-mail-header-view.c:
2541 Corrected warnings that were breaking the build, by commenting out unused variables,
2542 and a function, and by including a header.
2544 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2546 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2547 so we can #ifdef around platform-specific code when necessary.
2548 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2549 to allow this to build for the GNOME platform too.
2551 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2553 * src/maemo/easysetup/modest-easysetup-wizard.c:
2554 Added util_increment_name() and used it in create_page_account_details()
2555 to make sure that the default account name is always a new name.
2557 (modest_easysetup_wizard_dialog_init),
2558 (set_default_custom_servernames): Some minor memory management fixes.
2560 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2564 * src/modest-runtime.c: (init_i18n): Restored the translation
2565 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2566 are defined in config.h, and the translations are installed.
2568 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2569 is defined for translation.
2571 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2573 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2575 * src/maemo/easysetup/modest-easysetup-wizard.c:
2576 (modest_easysetup_wizard_dialog_init):
2577 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2578 Use realistic paths (though they should use $prefix generically) to the
2579 mcc_mapping and provider-data.keyfile files which might work when they
2580 are installed by the future version of the operator-wizard package,
2581 and then fallback to paths in our source code, with an explanatory
2584 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2588 * src/maemo/Makefile.am:
2589 * src/maemo/easysetup/: Added files from the previously-exernal
2590 osso-modest-easysetup.
2591 * src/maemo/modest-main-window-ui.h:
2592 * src/modest-ui-actions.c:
2593 * src/modest-ui-actions.h:
2594 Added modest_ui_actions_on_new_account() as a signal handler for the
2595 New Account menu item. It shows the easysetup wizard.
2596 * po/en_GB.po: Added additional needed logical IDs and translations.
2598 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2599 Apparently ChangeLog is not used for some vague Nokia legal reasons.