1 2007-07-09 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-msg-edit-window.c:
4 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
5 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
7 2007-07-07 Armin Burgmeier <armin@openismus.com>
9 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
10 ckdg_ib_maximum_characters_reached from correct package.
12 * src/modest-ui-actions.c: Show an error message when a folder could
13 not be created. Tinymail does not give us specific error codes about
14 what has gone wrong, so we assume that a folder with that name
15 already exists, though there might be other reasons.
17 2007-07-06 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
20 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
21 give a more exact error message that can be partly translated.
23 2007-07-05 Murray Cumming <murrayc@murrayc.com>
25 * src/maemo/modest-address-book.c:
26 (select_email_addrs_for_contact): Specify a default window size for the
27 select-email-address dialog, so that it is probably big enough for the
28 title. This should fix projects.maemo.org bug NB#62277.
30 2007-07-05 Murray Cumming <murrayc@murrayc.com>
32 * src/maemo/easysetup/modest-easysetup-wizard.c:
33 (create_page_complete_easysetup): Use
34 gtk_widget_set_size() request to ensure that the text wraps
37 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
39 * src/maemo/easysetup/modest-easysetup-wizard.c:
40 (on_entry_invalid_character), (create_page_account_details),
41 (create_page_user_details):
42 Use new API of ModestValidatingEntry. But for some reason the banner is
43 not shown. I will have to investigate that further.
45 * src/widgets/modest-validating-entry.c: (on_insert_text),
46 (modest_validating_entry_set_func):
47 * src/widgets/modest-validating-entry.h:
48 Added a new callback function to be able to react to prevented
49 characters whitespaces to e.g show a banner.
51 2007-07-05 Armin Burgmeier <armin@openismus.com>
53 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
54 notification of HildonNumberEditor instead of remembering the port
55 number. Thanks to Johannes for pointing this out.
57 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
59 * src/maemo/easysetup/modest-easysetup-wizard.c:
60 Check if there are any user changes before showing a confirmation
61 dialog (projects.maemo.org NB#60946)
63 2007-07-05 Armin Burgmeier <armin@openismus.com>
65 * src/maemo/modest-account-settings-dialog.c: Remember custom port
66 number at the beginning of the dialog and set the modified flag at the
67 end if the port number has changed. This is necessary because
68 HildonNumberEditor does not support notification when the value has
71 2007-07-05 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-ui-actions.c:
74 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
75 a connection before asking anything else. Correct the check for the destination
76 folder so that it succeeds when online.
77 This fixed projects.maemo.org bug NB#61645.
79 2007-07-05 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
82 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
83 to fix projects.maemo.org bug NB#62439.
85 2007-07-05 Murray Cumming <murrayc@murrayc.com>
87 * src/modest-tny-account.c: (on_connection_status_changed):
88 Really do not use tny_device_force_offline() here. See the previous comment.
90 2007-07-04 Murray Cumming <murrayc@murrayc.com>
92 * src/modest-tny-account.c: (on_connection_status_changed):
93 Do not use tny_device_force_offline() when tinymail says that something
94 went wrong with the connection. It seems to report this unnecessarily.
96 2007-07-04 Murray Cumming <murrayc@murrayc.com>
98 * src/maemo/modest-connection-specific-smtp-window.c:
99 (modest_connection_specific_smtp_window_init):
100 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
101 does not seem to have any effect in osso 1.1 (though it works in
102 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
104 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
106 * src/maemo/modest-connection-specific-smtp-window.c:
107 Fix UI specification problems with projects.meamo.org NB#60479
109 2007-07-04 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
112 clue when this has failed, because the error dialog is not always shown
113 (at least in earlier version).
115 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
116 GError message, because the generic error dialog is not helpful.
118 'This message is not currently available (can't let a new connection go online)'
119 when trying to open an IMAP message.
121 (_modest_ui_actions_open): Offer a connection when some messages would
122 have to be downloaded and we are offline.
124 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
126 * src/widgets/modest-folder-view.c:
127 Don't check for MERGE type anymore as we use the correct type
129 NOTE: For the last two changes you need to update your tinymail copy
130 because of API changes!
132 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
134 * src/modest-tny-local-folders-account.c:
135 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
136 (see projects.maemo.org NB#61580)
138 2007-07-04 Murray Cumming <murrayc@murrayc.com>
140 * src/modest-tny-account.c: (on_connection_status_changed):
141 Commented out the call to modest_platform_connect_and_wait() because this
142 seems to always hang, and I would like to know if this is the only thing
143 that causes a hang when showing the connection dialog.
144 It is not very useful anyway.
146 2007-07-04 Murray Cumming <murrayc@murrayc.com>
148 * src/maemo/modest-msg-view-window.c:
149 (modest_msg_view_window_select_next_message):
151 * src/modest-platform.h:
152 * src/maemo/modest-platform.c:
153 Added modest_platform_connect_and_wait(), which calls
154 tny_maemo_conic_device_connect() always in the main thread, by calling it
155 in an idle handler and waiting for the idle handler to run. It should be
156 in the main thread because it uses GTK+ UI code. It just returns TRUE
157 if the device is already online.
159 There is some nasty code to ensure that subsequent calls to
160 modest_platform_connect_and_wait() just wait for the first one to finish,
161 by checking repeatedly in another idle handler. This is necessary,
162 because other threads (or even the main thread, via another idle handler)
163 can call modest_platform_connect_and_wait() while
164 modest_platform_connect_and_wait() is running.
166 (modest_platform_connect_and_wait_if_network_account),
167 (modest_platform_connect_and_wait_if_network_folderstore):
168 Convenience functions that calls modest_platform_connect_and_wait() if
169 the account or folder might want network access.
171 * src/modest-mail-operation.c:
172 (modest_mail_operation_update_account):
173 * src/modest-ui-actions.c: (download_uncached_messages),
174 (modest_ui_actions_on_rename_folder), (delete_folder),
175 (modest_ui_actions_on_main_window_move_to),
176 (modest_ui_actions_on_msg_view_window_move_to):
177 * src/widgets/modest-folder-view.c:
178 (drag_and_drop_from_folder_view):
179 Offer a connection if we are offline.
181 * src/modest-tny-account.c: (on_connection_status_changed):
182 Document this as only handling errors during network operations in progress,
183 and replace the idle code with a simple call to
184 modest_platform_connect_and_wait(), which does this instead.
186 2007-07-03 Murray Cumming <murrayc@murrayc.com>
188 * src/modest-tny-account.c:
189 (modest_tny_account_get_special_folder): (util_on_idle),
190 Handle the GError so we can see when tny_folder_store_get_folders()
191 fails, as it currently does while something else is connecting.
193 Added util_run_in_main_thread_and_wait()
194 which uses an idlen handler and mainloop to ensure that the function
195 is called in the main thread.
196 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
197 to make sure that we call attempt the connection in the mainloop only,
198 which might solve some hangs.
200 2007-07-03 Murray Cumming <murrayc@murrayc.com>
202 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
203 be found by their display name. This is never useful.
204 * src/modest-tny-account-store.c: (on_account_removed): Find the account
205 by its ID, instead of trying to use its ID as its display name.
207 * src/modest-tny-account-store.h:
208 * src/modest-tny-account.c:
209 (modest_tny_account_get_special_folder): Add a g_warning() when
210 tny_folder_store_get_folders() returns an empty list for the maildir.
212 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
213 Add a g_warning() when this returns NULL, because that it not allowed
216 2007-07-02 Armin Burgmeier <armin@openismus.com>
218 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
219 note when trying to cancel the wizard. This fixes projects.maemo.org
222 2007-07-02 Murray Cumming <murrayc@murrayc.com>
224 * src/modest-tny-account.h:
225 * src/modest-tny-account.c:
226 (modest_tny_account_new_from_server_account),
227 (modest_tny_account_new_from_server_account_name),
228 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
229 because this must now be set before setting the proto. This is usd in
230 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
231 warning in camel_session_get_service() caused by
232 tny_camel_transport_account_prepare().
234 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
237 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
239 * src/maemo/modest-connection-specific-smtp-edit-window.c:
241 (modest_connection_specific_smtp_edit_window_init):
243 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
246 2007-06-29 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-tny-account.c:
249 (modest_tny_account_new_from_server_account):
250 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
251 now uses to request a connection when it needs one, and which it uses
252 to tell us that something is wrong with the connection, so we can force
253 the accounts offline to prevent further problems.
256 * src/modest-init.c: (init_default_settings):
257 * src/modest-mail-operation.c:
258 (modest_mail_operation_update_account):
259 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
260 This should not be necessary anymore. Do not set the conf key that
261 determined this (it was always TRUE and not set anywhere else).
263 * src/modest-ui-actions.h: Remove unused and unimplemented
264 modest_ui_actions_on_online_toggle_toggled().
266 2007-06-29 Murray Cumming <murrayc@murrayc.com
268 * src/maemo/modest-main-window.c: (connect_signals):
269 Don't connect to delete_event twice. Maybe this was harmless.
271 2007-06-29 Murray Cumming <murrayc@murrayc.com
273 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
274 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
275 Debug output to give some more clue when a folder move is not allowed.
277 2007-06-28 Murray Cumming <murrayc@murrayc.com
279 * src/modest-tny-account.c: (on_modest_file_system_info),
280 (modest_tny_account_get_mmc_account_name):
281 Always call the callback, without checking whether the name has changed.
282 * src/widgets/modest-folder-view.c: (strings_are_equal),
283 (on_model_foreach_set_name), (on_get_mmc_account_name),
284 (text_cell_data): Compare the name here, and use the name from
285 the account rather than from the
286 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
287 if the name was changed after the account was added to the model.
288 That's a tinymail bug but not one that I want to fix now.
290 This finally fixes projects.maemo.org bug NB#59301.
292 2007-06-27 Armin Burgmeier <armin@openismus.com>
294 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
297 2007-06-27 Murray Cumming <murrayc@murrayc.com
299 * src/modest-tny-account.h:
300 * src/modest-tny-account.c:
301 Added modest_tny_account_get_mmc_account_name(), to set the memory
302 card name asynchronously for the given account and then notify.
303 (modest_tny_account_new_for_local_folders): Use this new function instead
304 of using hildon_file_system_info_async_new() directly.
306 * src/widgets/modest-folder-view.c: (text_cell_data):
307 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
308 gtk_tree_model_row_changed() when it is available.
310 This should fix projects.maemo.org bug NB#59301.
312 2007-06-27 Murray Cumming <murrayc@murrayc.com
314 * src/modest-mail-operation.c: (update_account_thread),
315 (get_msgs_full_thread): Fix typo failures in the revert
318 2007-06-27 Murray Cumming <murrayc@murrayc.com
320 * src/maemo/modest-maemo-global-settings-dialog.c:
321 (idle_select_default_focus):
322 * src/modest-mail-operation.c: (idle_notify_progress),
323 (idle_notify_progress_once), (set_last_updated_idle),
324 (update_account_thread), (get_msgs_full_thread):
325 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
326 * src/widgets/modest-header-view.c:
327 (idle_notify_headers_count_changed_destroy),
328 (idle_notify_headers_count_changed):
329 Reverted the additions of gdk_threads_enter/leave(), in case this
330 helps with a startup hang on the device.
332 2007-06-26 Armin Burgmeier <armin@openismus.com>
334 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
335 for supported secure authentication methods from server by
336 gtk_dialog_run(), saving CPU time and a potential race condition.
338 2007-06-26 Armin Burgmeier <armin@openismus.com>
340 * src/maemo/modest-maemo-utils.h:
341 * src/maemo/modest-maemo-utils.c: Added a
342 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
343 only error code to tell the calling code when the user canceled the
346 * src/maemo/modest-account-settings-dialog.h:
347 * src/maemo/modest-account-settings-dialog.c:
348 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
349 message if the retrieval of secure authentication methods was canceled
350 by the user. Perform the check before saving anything to configuration
351 to not end up with half-committed configuration changes, do not show
352 a "Saving to configuration failed" note when authentication methods
353 could not be retrieved.
355 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
358 2007-06-26 Murray Cumming <murrayc@murrayc.com>
360 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
361 Only return the first level of folders under accounts, because the
362 osso-global-search UI spec doesn't want the rest.
363 This fixed projects.maemo.org bug NB#61811.
365 2007-06-26 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-tny-account-store.c:
368 * src/modest-tny-account-store.h:
369 Added modest_tny_account_is_memory_card_account().
370 * src/maemo/modest-main-window.c: (create_details_widget):
371 Show the same information items for the memory card as we show for the
372 local-folders, to fix projects.maemo.org bug NB#59307.
374 2007-06-26 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-tny-account-store.c: (get_password):
377 Added some checks for NULL to maybe prevent crashes, though I think
378 it was Philip's last commit that actually prevented the crash here
379 when creating a first new account.
380 But the new account is still not usable (no messages are shown)
381 until a restart of the application.
383 2007-06-26 Murray Cumming <murrayc@murrayc.com>
385 * src/maemo/modest-maemo-global-settings-dialog.c:
386 (idle_select_default_focus):
387 * src/modest-mail-operation.c: (idle_notify_progress),
388 (idle_notify_progress_once), (idle_notify_update_account_queue),
389 (set_last_updated_idle), (update_account_thread),
390 (notify_get_msgs_full), (get_msgs_full_destroyer),
391 (get_msgs_full_thread):
392 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
393 * src/widgets/modest-header-view.c:
394 (idle_notify_headers_count_changed_destroy),
395 (idle_notify_headers_count_changed):
396 Use gdk_threads_enter() and gdk_threads_enter_leave() in
397 all idle handlers, because some other thread could be blocking
398 the GDK lock, so that it can do GUI stuff.
400 2007-06-26 Murray Cumming <murrayc@murrayc.com>
402 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
403 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
404 (on_idle_send_receive), (on_idle_open_default_inbox):
405 * src/maemo/modest-msg-edit-window.c:
406 (modest_msg_edit_window_attach_file_noninteractive):
407 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
408 to prevent a hang. I don't quite understand why these are necessary,
409 beause we should already be in the main loop. I guess something outside
410 of the main loop is taking the lock.
412 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
413 we are really using URIs, and use files that are more likely to exist.
415 2007-06-26 Murray Cumming <murrayc@murrayc.com>
417 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
418 necessary because configure.ac now defines different variables.
420 2007-06-26 Murray Cumming <murrayc@murrayc.com>
422 * libmodest-dbus-client/libmodest-dbus-client.c:
423 * libmodest-dbus-client/libmodest-dbus-client.h:
424 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
425 libmodest_dbus_client_compose_mail() is what things actually use.
427 * src/dbus_api/modest-dbus-api.h:
428 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
429 * tests/dbus_api/Makefile.am:
430 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
433 2007-06-26 Murray Cumming <murrayc@murrayc.com>
435 * src/modest-init.c: (modest_init_local_folders):
436 For memory-card (or other non local-folders) maildir accounts,
437 always create an Archive folder, so that there is somewhere to put
438 messages. This should be less confusing, because the user does not need
439 to guess that the need to create a folder.
441 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
443 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
444 Fixed icon size by using (50, 50) which is the same as defined by
447 2007-06-25 Armin Burgmeier <armin@openismus.com>
449 * src/widgets/modest-window-mgr.c:
451 * configure.ac: Correctly recognize hildon-notify presence and fixed
452 the build without it being installed.
454 2007-06-25 Murray Cumming <murrayc@murrayc.com>
456 * libmodest-dbus-client/libmodest-dbus-client.c:
457 (libmodest_dbus_client_search): Fix the build. Sorry.
458 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
459 (reply_forward_cb): Initialize variables to fix the build.
461 * src/modest-tny-account-store.c:
462 (modest_tny_account_store_get_tny_account_by): Fix the account URI
463 comparison (a silly typo) so that email search results can be opened
464 when there are more than one account.
466 2007-06-25 Murray Cumming <murrayc@murrayc.com>
468 * libmodest-dbus-client/libmodest-dbus-client.c:
469 (libmodest_dbus_client_search),
470 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
471 instead of 1 second, because the search gets folders and messages from
472 the server, which can take a long time. When it times out,
473 osso-global-search will report no results.
475 We need to specify whether we should search only cached information
476 (maybe with a user preference), and the osso-email-search-plugin
477 API should really be improved to allow that option, and to allow results
478 to be delivered asynchronously in batches.
480 2007-06-25 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
483 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
484 GTK_ICON_SIZE_DIALOG is probably the wrong size.
486 2007-06-25 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
489 that is an empty string. D-Bus seems to give us these instead of NULL.
491 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
493 * src/dbus_api/modest-dbus-callbacks.c:
494 * src/maemo/easysetup/modest-easysetup-wizard.h:
495 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
497 (modest_connection_specific_smtp_edit_window_init):
498 * src/maemo/modest-maemo-global-settings-dialog.c:
500 * src/maemo/modest-maemo-utils.c:
501 (modest_maemo_utils_setup_images_filechooser):
502 * src/maemo/modest-main-window.c: (create_details_widget):
503 * src/maemo/modest-msg-edit-window.c:
504 (modest_msg_edit_window_attach_file_noninteractive),
505 (modest_msg_edit_window_color_button_change),
506 (modest_msg_edit_window_set_zoom):
507 * src/modest-mail-operation.c: (update_account_thread):
508 * src/modest-tny-account-store.c:
509 * src/modest-tny-account.c:
510 * src/widgets/modest-global-settings-dialog.c:
511 * src/widgets/modest-window.h:
515 2007-06-25 Murray Cumming <murrayc@murrayc.com>
517 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
518 * src/modest-search.c: (modest_search_folder),
519 (modest_search_all_accounts): Actually search only in the specified folder,
520 doing a simple match on the folder ID.
521 * src/modest-search.h: Added a folder field to the ModestSearch struct,
522 and added some documentation.
524 2007-06-22 Armin Burgmeier <armin@openismus.com>
526 * src/maemo/modest-maemo-utils.h:
527 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
528 modest_maemo_utils_get_supported_secure_authentication_methods.
530 * src/maemo/easysetup/modest-easysetup-wizard.c:
531 * src/maemo/modest-account-settings-dialog.c: Show correct error if
532 one occured, not just "Server does not support secure authentication".
534 2007-06-22 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-tny-account-store.c: (get_password):
537 Restored the call to tny_account_set_user() because Philip seems to have
538 stopped this from crashing (by not using the freed string). It still does
539 not work, but now we can test it.
541 2007-06-22 Murray Cumming <murrayc@murrayc.com>
543 * src/maemo/modest-msg-edit-window.c: (init_window):
544 Comment out use of an uninitialzed GtkScrolledWindow variable,
545 to fix the build and stop a crash. Yet again.
547 2007-06-22 Murray Cumming <murrayc@murrayc.com>
549 * src/modest-tny-account-store.c: (get_password):
550 Remove the call to tny_account_set_user() because this actually crashes.
551 As mentioned in the last commit, it is known to not work anyway.
553 2007-06-22 Murray Cumming <murrayc@murrayc.com>
555 * src/modest-tny-account-store.c: (get_password):
556 Use tny_account_set_username() to tell tinymail that the username might
557 have changed too. But tinymail ignores this: see projects.maemo.org
559 * src/modest-ui-actions.c:
560 (modest_ui_actions_on_password_requested): Remove the useless attempt to
561 reset the connection when changing the username, and improve the comments.
562 Save the changed username to gconf at least, so it is used when Modest is
565 2007-06-21 Murray Cumming <murrayc@murrayc.com>
567 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
568 Do not use a query, so that we get all folders, including for POP and
569 local-folders. They work as search criteria too.
570 This fixes projects.maemo.org bug NB#57740.
572 2007-06-21 Murray Cumming <murrayc@murrayc.com>
574 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
575 Comment out the use of hildon_notification_set_sound() because it is
576 not declared, to fix the build. Warnings are serious, people.
578 2007-06-21 Armin Burgmeier <armin@openismus.com>
580 * src/maemo/modest-maemo-utils.h:
581 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
582 modest_maemo_utils_get_supported_secure_authentication_methods()
583 to query authentication methods for a specific user. This should fix
584 projects.maemo.org bug NB#61369.
586 * src/maemo/easysetup/modest-easysetup-wizard.c:
587 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
590 2007-06-21 Murray Cumming <murrayc@murrayc.com>
592 * libmodest-dbus-client/libmodest-dbus-client.h:
593 * libmodest-dbus-client/libmodest-dbus-client.c:
594 (modest_dbus_message_iter_get_search_hit),
595 (libmodest_dbus_client_search):
596 Reorganised and commented this.
597 Removed modest_search_hit_free() from the public API because it
600 Added libmodest_dbus_client_get_folders() and
601 modest_folder_result_list_free().
603 * src/dbus_api/modest-dbus-api.h:
604 * src/dbus_api/modest-dbus-callbacks.c:
605 (modest_dbus_req_filter): Commented. Moved most code to
606 on_dbus_method_search() and added on_dbus_method_get_folders().
608 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
609 of the extra D-Bus handler.
611 * tests/dbus_api/Makefile.am:
612 * tests/dbus_api/test_get_folders.c: New test for
613 libmodest_dbus_client_get_folders(). This seems to return an empty list
614 at the moment. That could be the same error that causes the message list
615 to be empty sometimes.
616 This should help with projects.maemo.org bug NB#57740.
618 2007-06-21 Armin Burgmeier <armin@openismus.com>
620 * src/modest-mail-operation.c: Do not call
621 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
622 notify the operation's end after having set the status to CANCELED for
623 the operation queue to listen on. This fixes a deadlock when there
624 were mail operations in the queue during its finalization.
626 * src/modest-singletons.c: Reordered uninitialization of the account
627 manager to happen after the mail operation queue was uninitialized
628 because the mail operation's in the queue might still try to access
629 the account manager (see modest_mail_operation_notify_end()). This
630 fixes a potential crash when terminating the application.
632 2007-06-21 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-search.c:
635 (search_mime_part_and_child_parts): Moved some code here so we
636 can search recursively in child folders.
637 (modest_search_folder): Search in the message as a mime part, instead
638 of just its child mime parts.
639 (read_chunk), (search_mime_part_ogs):
640 Check how many bytes were read, to prevent an endless loop.
641 Searching in message bodies now works. This finishes the fix for
642 projects.maemo.org bug NB#61007.
644 2007-06-20 Murray Cumming <murrayc@murrayc.com>
646 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
647 Add a g_warning when the item is not a folder.
649 * src/modest-ui-dimming-rules.c:
650 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
651 when selected item is not a folder (for instance, an account), because
652 the UI spec only talks about folders.
653 I am not sure what the UI spec wants, so this might not totally fix
654 projects.maemo.org bug NB#60794.
656 2007-06-20 Murray Cumming <murrayc@murrayc.com>
658 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
659 (load_from_file): Sort the list. The unsorted list would be more noticeable
660 in non-English locales.
662 * src/maemo/modest-msg-edit-window.c:
663 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
664 warning and fix the build.
666 * src/maemo/modest-progress-bar-widget.c:
667 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
668 avoid a g_warning, and probably to avoid a crash.
670 2007-06-20 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-search.c: (modest_search_folder): Check for a GError
673 when calling tny_folder_get_headers(), to show that this is not the cause
676 2007-06-20 Murray Cumming <murrayc@murrayc.com>
678 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
679 Actually set the body query instead of the subject query.
681 * src/modest-search.c: (search_mime_part_ogs),
682 (search_mime_part_strcmp): Remove extra space from the text/* regex,
683 which would probably cause it to fail if we got this far.
685 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
686 to simplify the code.
687 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
688 be causing search-in-body to fail.
690 2007-06-20 Murray Cumming <murrayc@murrayc.com>
692 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
694 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
695 Better debug message when the folder cannot be found.
696 This should help with fixing projects.maemo.org bug #61287.
697 * src/modest-search.c: (add_hit): Do not leak the furl string.
699 2007-06-20 Murray Cumming <murrayc@murrayc.com>
701 * src/modest-ui-actions.c:
702 (modest_ui_actions_on_folder_selection_changed):
703 Do not special-case TNY_MERGE_FOLDER here, because
704 modest_tny_folder_get_account() already does that. This fixes
705 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
706 shown when the Outbox was selected).
708 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
710 * libmodest-dbus-client/libmodest-dbus-client.c:
711 (_dbus_iter_get_string_or_null): Initialize the string variable in
712 case this helps with Dirk's crash.
714 2007-06-19 Murray Cumming <murrayc@murrayc.com>
716 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
717 though it is not implemented yet (this function is maybe not even used),
718 to avoid breaking ABI in future.
719 * libmodest-dbus-client/libmodest-dbus-client.c:
720 (get_attachments_string): Moved some code into this generic function.
721 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
722 sends email. It is maybe not used.
723 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
724 (on_send_mail): Use attachments.
726 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
727 * src/maemo/modest-msg-edit-window.c:
728 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
729 a filename before using it, to fix projects.maemo.org bug NB#58233.
731 2007-06-19 Murray Cumming <murrayc@murrayc.com>
733 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
734 Initialize the continue_download variable to fix the build, and probably
735 to fix randome behaviour.
737 2007-06-18 Armin Burgmeier <armin@openismus.com>
739 * src/modest-tny-send-queue.h:
740 * src/modest-tny-send-queue.c: Keep track of the status of messages in
741 the queue so we can later show it in the UI. Replaced
742 modest_tny_send_queue_msg_is_being_sent() by
743 modest_tny_send_queue_get_msg_status().
745 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
747 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
748 gpointer. This probably was not harmful, but just to be sure.
750 2007-06-18 Murray Cumming <murrayc@murrayc.com>
752 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
753 Fix the build, but leave the function broken on Bora, because
754 hildon_uri_action_get_service() does not exist.
755 osso_uri_action_get_service() does not exist either, it seems.
757 2007-06-18 Murray Cumming <murrayc@murrayc.com>
759 * src/modest-tny-account.c:
760 (modest_tny_account_new_from_server_account):
761 Uncommented the url debug output again, because it is useful for
762 debugging, as I said in the comment.
764 2007-06-18 Murray Cumming <murrayc@murrayc.com>
766 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
768 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
769 for Mameo Bora, to fix the build.
771 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
774 Fixed build with hildon < 0.99
776 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
777 Check if the selected account is busy instead of checking all accounts
779 * src/modest-account-mgr-priv.h:
780 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
781 (modest_account_mgr_init), (compare_account_name),
782 (modest_account_mgr_set_account_busy),
783 (modest_account_mgr_account_is_busy):
784 * src/modest-account-mgr.h:
785 Added busy information to the account manager. It possible to
786 set an account to busy or not busy now.
788 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
789 (modest_mail_operation_update_account),
790 (modest_mail_operation_notify_end):
791 Set the account to busy/not busy depending on the operation state.
793 * src/widgets/modest-account-view.c:
794 (modest_account_view_finalize), (get_last_updated_string),
795 (update_account_view), (on_account_busy_changed), (init_view):
796 Show string "Refreshing..." if the account is currently busy.
798 All this fixes projects.maemo.org bug NB#59711
800 2007-06-14 Armin Burgmeier <armin@openismus.com>
802 * src/widgets/modest-attachments-view.h:
803 * src/widgets/modest-attachments-view.c: Added
804 modest_attachments_view_has_attachments() and fixed coordinate
805 transformation in get_att_view_at_coords(). This fixes attachment
808 * src/widgets/modest-msg-view.c: Make use of
809 modest_attachments_view_has_attachments() to decide whether to show
810 attachments in the header.
812 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
815 (on_change), (on_combo_security_changed),
816 (modest_connection_specific_smtp_edit_window_init),
817 (modest_connection_specific_smtp_edit_window_set_connection),
818 (modest_connection_specific_smtp_edit_window_is_dirty):
819 * src/maemo/modest-connection-specific-smtp-edit-window.h:
820 * src/maemo/modest-connection-specific-smtp-window.c:
823 Show an comfirmation dialog for the smpt-edit-window if there are
824 unsaved changes and the user hits cancel.
825 (projects.maemo.org bug NB#60479)
827 2007-06-14 Armin Burgmeier <armin@openismus.com>
829 * src/maemo/easysetup/modest-easysetup-wizard.c:
830 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
831 address" info in banner instead of node, and select all the text as
832 per UI spec. This fixes projects.maemo.org bug NB#60550.
834 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
836 reviewed by: <delete if not using a buddy>
838 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
839 * src/modest-ui-actions.c: (folder_refreshed_cb):
841 2007-06-14 Murray Cumming <murrayc@murrayc.com>
843 * src/widgets/modest-folder-view.c: (filter_row):
844 Explictly filter out the per-account outbox accounts. I don't know why
845 these only sometimes show up, but now they should never show up in the UI.
846 This should fix projects.maemo.org bug NB#60160.
848 2007-06-14 Murray Cumming <murrayc@murrayc.com>
850 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
851 when the toolbar does not exist yet.
852 * src/modest-widget-memory.c: (save_settings_header_view):
853 Added g_warnings() to help us to discover when we are trying to set
854 an empty columns list in gconf.
856 2007-06-14 Murray Cumming <murrayc@murrayc.com>
860 Added modest_init_get_default_header_view_column_ids().
862 * src/modest-widget-memory.c: (restore_settings_header_view):
863 Use the new function to get defaults, if the gconf key is empty,
864 instead of not creating any columns. This seems to fix the
865 empty right-hand pane problems.
867 * src/widgets/modest-header-view.h: Improved documentation.
869 2007-06-13 Murray Cumming <murrayc@murrayc.com>
871 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
872 Revert the use of the display name as the account name, because this
873 is generally wrong and would break the code that follows.
875 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
877 * src/maemo/easysetup/modest-easysetup-wizard.c:
878 (check_for_supported_auth_methods), (on_before_next),
881 More correct fix for projects.maemo.org bug NB# 58991
882 Do not longer accept AUTH_PASSWORD as secure method and choose
883 correct method when creating the account.
885 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
887 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
888 Fixed projects.maemo.org bug NB# 58991
890 2007-06-13 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-init.c: (modest_init_init_core),
893 (modest_init_local_folders): Fixed compilation errors.
895 2007-06-13 Murray Cumming <murrayc@murrayc.com>
897 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
898 Remove unnecessary lib/include, though it is good in principle when needed.
900 * src/modest-init.c: (modest_init_one_local_folder),
901 (modest_init_local_folders):
902 * src/modest-init.h: Initialize the .modest library for memory cards,
903 instead of just doing nothing for them. This should allow us to create
904 folders there, fixing projects.maemo.org bug NB#59297.
906 2007-06-13 Murray Cumming <murrayc@murrayc.com>
908 * libmodest-dbus-client/libmodest-dbus-client.c:
909 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
910 (libmodest_dbus_client_compose_mail),
911 (libmodest_dbus_client_open_message),
912 (libmodest_dbus_client_send_and_receive),
913 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
915 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
916 (on_idle_open_message), (modest_dbus_req_handler),
917 (search_result_to_message), (modest_dbus_req_filter):
918 * src/modest-search.c: (add_hit), (modest_search_folder),
919 (modest_search_all_accounts): Improved debug messages.
921 * tests/dbus_api/test_open_message.c: (main): Improved comments.
923 * src/modest-tny-account-store.c:
924 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
927 2007-06-13 Murray Cumming <murrayc@murrayc.com>
930 2007-06-12 Murray Cumming <murrayc@murrayc.com>
932 * src/modest-tny-account-store.c: (get_server_accounts):
933 Call modest_tny_local_folders_account_add_merged_outbox_folders()
934 even when there are no accounts, so that the Outbox folder is always
935 visible. This fixes projects.maemo.org bug NB#60158.
937 2007-06-12 Murray Cumming <murrayc@murrayc.com>
939 * src/maemo/modest-main-window.c: (create_details_widget):
940 Use the mcen_va_never logical ID.
942 2007-06-12 Murray Cumming <murrayc@murrayc.com>
944 * src/dbus_api/modest-dbus-api.h:
945 * src/dbus_api/modest-dbus-callbacks.c:
946 (on_idle_open_default_inbox), (on_open_default_inbox),
947 (modest_dbus_req_handler):
948 Added a new OpenDefaultInbox method.
950 * libmodest-dbus-client/libmodest-dbus-client.h:
951 * libmodest-dbus-client/libmodest-dbus-client.c:
952 Added libmodest_dbus_client_open_default_inbox() to call the new
953 dbus method. This should be useful to projects.maemo.org bug NB#57214,
954 though it should maybe be used by a new osso-email-interface function.
956 * tests/dbus_api/Makefile.am:
957 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
960 2007-06-12 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
963 NULL, so that the signals get all the keys. This should not actually
964 change any behaviour because we currently update everything when anything
967 2007-06-12 Murray Cumming <murrayc@murrayc.com>
969 * src/widgets/modest-folder-view.c: (text_cell_data),
970 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
971 (find_inbox_iter): If tinymail tells us that the folder is
972 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
973 This causes the inbox to be selected at startup, fixing part of
974 projects.maemo.org bug NB#56305.
976 * src/modest-ui-dimming-rules.c:
977 (modest_ui_dimming_rules_on_tools_smtp_servers):
978 * src/modest-ui-dimming-rules.h: Added a callback function to dim
979 the SMTP servers menu item.
980 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
981 that the SMTP Servers menu item is dimmed when there are no accounts,
982 as a future version of the UI spec will require. This fixes
983 projects.maemo.org bug NB#56305.
985 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
987 * src/maemo/modest-maemo-utils.c:
988 (modest_maemo_utils_get_supported_secure_authentication_methods):
989 Added label to dialog instead of unreadable title
991 * src/maemo/modest-main-window.c: (sync_accounts_cb),
992 (modest_main_window_new):
993 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
996 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
997 * src/modest-account-mgr.h:
998 Added method to avoid code duplication
1000 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1001 (modest_ui_actions_on_send_receive):
1002 Use modest_account_mgr_has_accounts
1004 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1006 * src/maemo/easysetup/modest-presets.c:
1007 (modest_presets_get_info_server_security): Do not report secure auth
1009 * src/modest-protocol-info.c: Use the defines for the gconf key names
1010 for secure authentication. This was not working because we were writing
1011 Password and reading password, and the check was case sensitive.
1012 With this, gmail now works for receiving and sending when created via
1015 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1017 * src/maemo/easysetup/modest-presets.c:
1018 (modest_presets_get_info_server_security): Correct the key name for
1019 SecureSmtp, because it seems to be case-sensitive.
1020 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1021 Do not try to get the 0th notebook page if there are 0 pages, to
1022 avoid a g_warning().
1024 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1026 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1027 Prevent use of the new notification feature for now, because it currently
1028 shows one dialog for each new email, which is annoying.
1030 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1032 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1033 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1034 when no country was selected, so that we show the global ones.
1035 * src/maemo/easysetup/modest-presets.c:
1036 (modest_presets_get_providers): Return only the global providers, not
1037 all providers when mmc=0 was requested.
1039 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1041 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1042 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1043 provider ID in the combo.
1045 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1046 Do not show the page numbers, because it would be confusing when we add
1047 the 2 extra pages for the custom setup, when the user chooses the "Other"
1048 provider. This fixes projects.maemo.org bug NB#59028
1050 * src/modest-init.c: (modest_init_init_core),
1051 (modest_init_local_folders):
1052 * src/modest-init.h:
1053 * src/modest-tny-account.c:
1054 (modest_tny_account_new_for_local_folders): Do not create default folders
1055 for the memory card. This should fix projects.maemo.org bug NB#59328.
1057 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1059 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1060 Free the changed_conf_keys string items. They are already freed in the
1061 idle handler if that runs first.
1063 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-ui-actions.c:
1066 (modest_ui_actions_on_password_requested): Check that the server name
1067 is not NULL, because I just saw a password dialog with (null) as the
1070 * src/modest-tny-folder.[h|c]: Added
1071 modest_tny_folder_is_memory_card_folder().
1072 * src/modest-ui-dimming-rules.c:
1073 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1074 menu item for memory cards, as per the UI spec (section 7.4). This should
1075 fix projects.maemo.org bug NB#59297.
1077 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1079 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1080 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1081 is another problem with the code, see Murray's comment at line 772)
1083 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1085 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1086 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1087 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1088 (load_from_file), (easysetup_country_combo_box_init),
1089 (easysetup_country_combo_box_get_active_country_ids),
1090 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1091 instead of just one ID, to avoid duplicate country names in the UI.
1093 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1094 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1095 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1096 a single ID, avoiding duplicate providers.
1097 * src/maemo/easysetup/modest-easysetup-wizard.c:
1098 (on_combo_account_country): Adapt to use a list.
1100 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1102 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1103 keys changed in the last X seconds.
1105 * src/modest-account-mgr.h:
1106 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1107 (on_key_change), (modest_account_mgr_class_init),
1108 (modest_account_mgr_init), (modest_account_mgr_finalize):
1109 As the keys are changed, save them in a GSList* and signal that GSList*
1110 further every X seconds, to batch changes, to allow us to do just one
1111 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1112 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1114 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1115 changed signal signature.
1117 * src/modest-conf.c: (modest_conf_set_list),
1118 (modest_conf_on_change): Reenable notification.
1120 (modest_conf_maemo_fake_on_change): Comment out the hack that
1121 notified immediately instead of asynchronously.
1123 * src/widgets/modest-account-view.h:
1124 * src/widgets/modest-account-view.c:
1125 (update_account_view): Select the previously-selected account ID,
1126 if possible. This fixes projects.maemo.org bug NB#56933.
1128 (on_account_changed), (on_account_removed),
1129 (modest_account_view_select_account):
1131 Remove the block/unblock functions
1132 because they were not useful.
1134 * src/maemo/modest-account-view-window.c:
1135 (on_delete_button_clicked), (on_edit_button_clicked),
1136 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1138 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1141 Improve the error dialog to show Incorrect Account Settings, which seems
1142 clearer, and say that the internal error message (to be removed from the
1143 dialog later) is often misleading.
1144 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1146 * src/modest-tny-account.c:
1147 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1148 URL because this is so useful for debugging on the device.
1150 * src/widgets/modest-serversecurity-combo-box.c:
1151 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1153 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1155 * src/modest-mail-operation.c:
1156 (modest_mail_operation_send_new_mail):
1157 Added a comment about a nasty but apparently harmless message. Details
1158 added to the wiki g_warnings() page.
1160 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1163 (modest_tny_send_queue_class_init):
1164 Do not use the priv struct because it is empty, to avoid g_warnings
1165 about a non-existant priv struct.
1167 * src/modest-tny-account-store.c:
1168 (modest_tny_account_store_get_server_account),
1169 (modest_tny_account_store_get_transport_account_for_open_connection
1170 ): Do not try to get transport server accounts for local folders,
1171 because they don't have any. This avoids a g_warning().
1173 * src/maemo/modest-main-window.c:
1174 (modest_main_window_notify_send_receive_initied),
1175 (on_configuration_key_changed):
1176 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1177 * src/modest-defs.h:
1178 * src/modest-mail-operation.c:
1179 (modest_mail_operation_update_account):
1180 * src/modest-tny-account-store.h:
1181 * src/modest-tny-account.c:
1182 (modest_tny_account_get_special_folder),
1183 (modest_tny_account_new_for_local_folders),
1184 (modest_tny_account_new_for_per_account_local_outbox_folder):
1185 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1186 * src/modest-tny-local-folders-account.c:
1187 (add_account_folders_to_merged_folder):
1188 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1189 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1190 (modest_ui_actions_on_send):
1191 * src/widgets/modest-folder-view.c: (update_model):
1192 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1193 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1194 modest_tny_account_store_get_tny_account_by_account() to
1195 modest_tny_account_store_get_server_account() to make the code clearer.
1197 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1199 * src/dbus_api/modest-dbus-api.h:
1200 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1201 * src/maemo/modest-msg-edit-window.c:
1202 (modest_msg_edit_window_attach_file_noninteractive):
1203 added g_warning in case the file to be attached does not exist
1204 * tests/dbus_api/test_compose_mail.c: (main):
1205 removed obsolete comment, added generic files as test case
1207 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-tny-account-store.c: (get_server_accounts):
1210 Create the local folders account only once, not once for each outbox, and
1211 not only when there are some outboxes.
1213 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1215 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1216 code that is causing a crash at startup. Sergio says that he is fixing this.
1218 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1220 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1221 * src/maemo/modest-account-settings-dialog.c:
1222 (create_page_outgoing),
1223 (modest_account_settings_dialog_set_account_name),
1224 (save_configuration):
1225 - Fixed handling of the "Use secure authentication" toggle to comply with
1226 the ui specification. See also projects.maemo.org bug NB#58400
1228 - Restore the Secure connection setting combo correctly when loading
1231 * src/maemo/modest-maemo-utils.c:
1232 (on_camel_account_get_supported_secure_authentication),
1233 (modest_maemo_utils_get_supported_secure_authentication_methods):
1234 Fixed a crasher if operation is canceled
1236 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1237 (modest_protocol_info_auth_is_secure):
1238 * src/modest-protocol-info.h:
1240 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1241 the sense of the "Use secure authentication" toggle.
1243 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1245 * src/modest-tny-account-store.h:
1246 * src/modest-tny-account-store.c:
1247 Added modest_tny_account_store_get_local_folders_account().
1249 * src/modest-tny-folder.h:
1250 * src/modest-tny-folder.c:
1251 (modest_tny_folder_get_account):
1252 Added this replacement for tny_folder_get_account() which returns
1253 the local-folders account for TnyMergeFolders, to avoid the
1254 warning about the unimplemented get_account_func() vfunc().
1256 (modest_tny_folder_get_rules),
1257 * src/modest-ui-actions.c:
1258 (modest_ui_actions_on_folder_selection_changed):
1259 * src/modest-mail-operation.c:
1260 (modest_mail_operation_remove_folder),
1261 (modest_mail_operation_xfer_folder),
1262 (modest_mail_operation_rename_folder),
1263 (modest_mail_operation_get_msg),
1264 (modest_mail_operation_get_msgs_full),
1265 (modest_mail_operation_remove_msg),
1266 (modest_mail_operation_xfer_msgs),
1267 (modest_mail_operation_refresh_folder):
1268 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1270 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1273 (modest_server_account_set_security):
1274 * src/modest-defs.h: Add comments explaining that our
1275 UI spec means TLS when it says Normal, so these do not look like errors.
1277 * src/modest-tny-account.c:
1278 (modest_tny_account_new_from_server_account): Use the new tinymail
1279 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1280 for TLS. This should fix projects.maemo.org bug NB#58460.
1282 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/easysetup/modest-easysetup-wizard.c:
1285 (create_account): Correct the position of the gconf sanity check warning.
1286 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1287 of using the g_idle_add() hack, because this does not seem to be necessary
1288 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1289 caused by something other than maemo's gconf.
1290 This fixes projects.maemo.org bug #59022.
1292 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-account-mgr-helpers.c:
1295 (modest_account_mgr_get_default_account): Do not check that the account
1296 exists if there is no default account (NULL), to fix a runtime warning.
1298 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1300 * src/widgets/modest-folder-view.c: (update_model):
1301 Do not unref the treemodel before we have finished with it.
1302 This prevents a valgrind warning and an occasional crash at startup.
1304 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1306 * libmodest-dbus-client/libmodest-dbus-client.h:
1307 added libmodest_dbus_client_compose_mail()
1308 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1310 added functions needed for SendAsMail() functionality
1311 * src/maemo/modest-msg-edit-window.c:
1312 (modest_msg_edit_window_attach_file_noninteractive):
1313 non interactively attaching files to message edit window
1314 * src/widgets/modest-msg-edit-window.h:
1315 * tests/dbus_api/Makefile.am:
1316 added test_compose_mail.c
1317 * tests/dbus_api/test_compose_mail.c: (main):
1319 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1321 * src/modest-account-view.c:
1322 Fixed bug projects.maemo.org bug NB#59307
1324 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1326 * src/maemo/easysetup/modest-easysetup-wizard.c:
1327 (get_serverport_incoming), (on_before_next), (create_account):
1328 * src/maemo/modest-account-settings-dialog.c:
1329 (modest_account_settings_dialog_set_account_name):
1330 * src/maemo/modest-maemo-utils.c:
1331 (on_camel_account_get_supported_secure_authentication_status),
1332 (on_camel_account_get_supported_secure_authentication),
1333 (on_secure_auth_cancel),
1334 (modest_maemo_utils_get_supported_secure_authentication_methods):
1336 Implemented security authentication for settings and easysetup.
1338 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1340 * src/maemo/modest-main-window.c: (create_details_widget):
1341 Show the total size for memory card accounts too, instead of showing
1342 the name again. Fixes bug projects.maemo.org bug NB#59307.
1344 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1347 * src/modest-tny-simple-folder-store.c:
1348 * src/modest-tny-simple-folder-store.h: Removed.
1350 * src/modest-tny-local-folders-account.h
1351 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1352 for the local-folders maildir, with an extra TnyMergedFolder containing
1353 the folders of the per-account outbox store accounts.
1354 * src/modest-tny-account-store.c: (get_server_accounts):
1355 Add the outboxes to the special local folders account after creating it.
1357 * src/modest-tny-account.c:
1358 (modest_tny_account_new_for_local_folders): Create the derived
1359 account when creating the main local-folders account.
1361 * src/maemo/modest-main-window.c: (create_details_widget),
1362 (modest_main_window_set_contents_style):
1363 Adapted to the use of the derived account instead of the folder store.
1365 * src/modest-ui-actions.c:
1366 (modest_ui_actions_on_folder_selection_changed):
1367 * src/modest-ui-dimming-rules.c:
1368 (modest_ui_dimming_rules_on_new_folder):
1369 * src/widgets/modest-folder-view.c: (text_cell_data),
1370 (icon_cell_data), (filter_row), (update_model),
1371 (get_cmp_rows_type_pos):
1374 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1375 Do not get the priv struct, because no priv struct has been set,
1376 to avoid a runtime warning.
1378 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1379 #ifelse with #else, to fix a warning, to fix the build.
1382 2007-06-05 Christian Kellner <ckellner@openismus.com>
1384 * libmodest-dbus-client/libmodest-dbus-client.c:
1385 Fix small typo in doc (why do you always see them
1386 AFTER committing stuff?)
1389 2007-06-05 Christian Kellner <ckellner@openismus.com>
1391 * libmodest-dbus-client/libmodest-dbus-client.c:
1392 (libmodest_dbus_client_search):
1393 Initialize hit list with NULL. Also set folder list
1394 to "" if NULL was supplied.
1397 2007-06-03 Christian Kellner <ckellner@openismus.com>
1399 * libmodest-dbus-client/libmodest-dbus-client.c:
1400 (modest_search_hit_list_free):
1401 Make it save to call it with NULL.
1403 * src/dbus_api/modest-dbus-callbacks.c:
1404 * src/modest-search.c:
1405 Return full ModestSearchHits as the search result list not TnyHeader
1406 since can't be around withouth the correspoding TnyFolder.
1408 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1410 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1411 Added currently commented code to check for secure auth
1413 * src/maemo/modest-account-settings-dialog.c: (on_response),
1414 (save_configuration), (show_ok):
1415 Fixed projects.maemo.org bugs NB #59248 and #59251
1417 * src/maemo/modest-maemo-utils.c:
1418 (on_camel_account_get_supported_secure_authentication_status),
1419 (on_camel_account_get_supported_secure_authentication),
1420 (modest_maemo_utils_get_supported_secure_authentication_methods):
1421 * src/maemo/modest-maemo-utils.h:
1422 Moved get_supported_secure_authentication() method here to be able
1423 to use it from easysetup wizard.
1425 * src/modest-pair.c: (on_pair_compare_as_string):
1426 Should compare string with first part of pair and not
1427 strcmp pairs which will crash.
1429 * src/modest-protocol-info.c:
1430 (modest_protocol_info_protocol_is_store):
1431 * src/modest-protocol-info.h:
1432 Added modest_protocol_info_get_auth_protocol_name()
1434 2007-06-03 Armin Burgmeier <armin@openismus.com>
1436 * src/modest-mail-operation.c:
1437 (modest_mail_operation_get_msgs_full): Set priv->account also when
1438 only retrieving a single message. This avoids a crash when canceling
1441 (modest_mail_operation_notify_end): Do not explicitely remove the
1442 operation from the queue but only emit the progress_changed signal.
1443 The queue itself listens to that signal to remove the operation when
1444 it is finished. This reduces coupling and removes a potential deadlock
1445 when modest_mail_operation_notify_end() is called from the queue
1446 itself. If that is a problem performance-wise, I would suggest to
1447 implement a status-changed signal or something.
1449 * src/modest-mail-operation-queue.c: Make sure to never call a
1450 function from another file while the queue is locked. This (hopefully)
1451 fixes another deadlock when exiting the application while retrieving
1454 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1456 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1457 Fixed build if libogs is not available
1459 2007-06-03 Christian Kellner <ckellner@openismus.com>
1461 * libmodest-dbus-client/libmodest-dbus-client.h:
1462 * libmodest-dbus-client/libmodest-dbus-client.c:
1463 (libmodest_dbus_client_delete_message):
1464 Implement deletion of messages (Client side).
1466 (modest_search_hit_free),
1467 (modest_search_hit_list_free):
1468 Utility functions to free the result hits.
1470 * src/dbus_api/modest-dbus-api.h:
1471 * src/dbus_api/modest-dbus-callbacks.c:
1472 (on_delete_message),
1473 (modest_dbus_req_handler):
1474 Implement deletion of messages (Server side).
1476 * tests/dbus_api/test_search.c: (main):
1479 * tests/dbus_api/Makefile.am:
1480 * tests/dbus_api/test_delete_message:
1481 Add little test for the message deletion logic
1483 2007-06-03 Armin Burgmeier <armin@openismus.com>
1485 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1486 when the operation queue was not empty. projects.maemo.org bug
1489 2007-06-03 Armin Burgmeier <armin@openismus.com>
1491 * src/widgets/modest-account-view.c
1492 (on_account_default_toggled): Toggle default account column
1493 explicitely instead of waiting for gconf notification (which is
1494 currently ignored). This should fix projects.maemo.org bug NB#56910
1495 for now. It should probably be removed when gconf notifications are
1498 2007-06-03 Christian Kellner <ckellner@openismus.com>
1500 * libmodest-dbus-client/libmodest-dbus-client.c:
1501 Removed debugging spew.
1503 * src/dbus_api/modest-dbus-callbacks.c:
1504 Added debugging info.
1506 * src/modest-search.c:
1507 (modest_search_all_accounts):
1508 Use tny_account_store_get_accounts () on the account store
1509 to get all accounts which is the way to get all accounts.
1511 * tests/dbus_api/test_search.c: (main):
1512 Make it possible to supply the search term on the command line.
1514 2007-06-03 Christian Kellner <ckellner@openismus.com>
1516 * libmodest-dbus-client/libmodest-dbus-client.c:
1517 * libmodest-dbus-client/libmodest-dbus-client.h:
1518 Implement searching for mesages over raw dbus. (Client side)
1520 * src/dbus_api/Makefile.am:
1521 * src/dbus_api/modest-dbus-api.h:
1522 * src/dbus_api/modest-dbus-callbacks.c:
1523 * src/dbus_api/modest-dbus-callbacks.h:
1524 Search framework (Server side). Also implement on_idle_open_message().
1526 * src/maemo/modest-platform.c: (modest_platform_init):
1527 Prepare for raw dbus/osso rpc interaction.
1529 * src/modest-search.h:
1530 Changed minsize from unspecific guint to guint32.
1532 * src/modest-search.c:
1534 Added strange hack which magically made tnymail work.
1536 (modest_search_folder),
1537 (modest_search_account),
1538 (modest_search_all_accounts):
1539 Implement helper functions to search all accounts, specific account
1542 * tests/dbus_api/Makefile.am:
1543 * tests/dbus_api/test_open_message.c:
1544 Read url to open from commandline.
1546 * tests/dbus_api/test_search.c:
1547 Implement small test for dbus search stuff
1549 2007-06-02 Armin Burgmeier <armin@openismus.com>
1551 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1552 include account type and account title. This fixes projects.maemo.org
1555 * src/maemo/modest-account-view-window.c: Set a title for the window.
1557 2007-06-02 Armin Burgmeier <armin@openismus.com>
1559 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1560 incoming and outgoing server name based on email address and server
1561 types as long as the names have not been edited manually. This fixes
1562 projects.maemo.org bug NB#58671.
1564 2007-06-02 Armin Burgmeier <armin@openismus.com>
1566 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1567 server type cannot be changed in future to the incoming details page
1568 when creating an account. This fixes projects.maemo.org bug NB#59029.
1570 2007-06-02 Armin Burgmeier <armin@openismus.com>
1572 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1573 and assigned max width chars so that they wrap instead of being
1574 truncated. Fixes projects.maemo.org bug NB#56126.
1576 2007-06-02 Armin Burgmeier <armin@openismus.com>
1578 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1579 introductory note to the connection specific smtp servers dialog, as
1580 section 8.12 of the email UI specification requires. This fixes
1581 projects.maemo.org bug NB#59212.
1583 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1585 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1586 Check for running mail operations, and offer to cancel them, as per the UI
1587 spec. This fixes projects.maemo.org bug NB#59041 .
1588 However, I suspect that tinymail may still use the network connection
1589 in ways that we cannot detect or cancel. But it should at least adapt to
1590 changes fairly well.
1592 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1594 * src/modest-tny-account-store.c: (recreate_all_accounts),
1595 (get_cached_accounts), (get_server_accounts): Do more sensible
1596 ref-counting of the temporarily-cached outbox accounts list. This seems
1597 to fix a crash when entering the password when the password was wrong.
1599 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1601 * src/gnome/modest-main-window.c: (connect_signals):
1602 * src/modest-tny-account-store.c: (get_password),
1603 (modest_tny_account_store_alert): Added comments and clues and
1604 commented-out code about how we currently fail to deal with connection
1605 errors and wrong passwords, and how we should.
1607 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1609 * src/widgets/modest-retrieve-combo-box.c:
1610 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1611 This fixes projects.maemo.org bug NB#58472 .
1613 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1615 * src/maemo/easysetup/modest-easysetup-wizard.c:
1616 (create_page_complete_easysetup):
1617 (create_page_complete_custom): Correct the last commit,
1618 putting the correct sentences in the correct pages.
1620 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1622 * src/maemo/easysetup/modest-easysetup-wizard.c:
1623 (create_page_complete_custom): Show the second sentence of text
1624 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1627 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1629 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1630 Set the leave-on-server conf key by default. This fixes
1631 projects.maemo.org bug NB#59258 .
1633 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1635 * src/maemo/modest-account-view-window.c:
1636 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1637 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1640 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1642 * src/maemo/easysetup/modest-easysetup-wizard.c:
1643 (create_caption_new_with_asterisk):
1644 * src/maemo/modest-account-settings-dialog.c:
1645 (create_caption_new_with_asterisk):
1646 Uncomment the code to add the asterisk, because they are no longer in the
1647 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1648 (update_incoming_server_title): Add an asterisk here too.
1650 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1652 * src/maemo/modest-maemo-global-settings-dialog.c:
1653 (current_connection): Check that we are even connected before trying to
1654 get the current connection name, to prevent a warning.
1656 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1657 Change the comments because tny_maemo_conic_device_connect() is now meant to
1659 * src/modest-mail-operation.c:
1660 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1661 make sure we have a connection and fail if we can't connect.
1663 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1665 * src/maemo/modest-main-window.c:
1666 (on_account_store_connecting_finished): Do not try to get the
1667 connection ID if we are not really connected. I am surprised that
1668 this signal handler is called when we are not connected.
1670 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-error.h:
1673 * src/modest-ui-actions.c:
1674 (modest_ui_actions_get_msgs_full_error_handler):
1675 Renamed an enum, added comments, added an enum
1676 for retrieve-limit errors.
1678 * src/modest-mail-operation.c: (foreach_add_item),
1679 (internal_folder_observer_update), (update_account_thread),
1680 (modest_mail_operation_get_msgs_full):
1681 (modest_mail_operation_update_account),
1682 Added comments about how this works, and some code that should
1683 (but does not) check the retrieve-limit. See the TODO comment.
1685 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1687 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1688 Initialize help_id to fix the build. Warnings are good.
1690 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1692 * src/widgets/modest-hbox-cell-renderer.c:
1693 (modest_hbox_cell_renderer_append):
1694 * src/widgets/modest-vbox-cell-renderer.c:
1695 (modest_vbox_cell_renderer_append):
1696 Fix the last commit by doing an extra ref.
1698 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1700 * src/widgets/modest-hbox-cell-renderer.c:
1701 (modest_hbox_cell_renderer_append):
1702 * src/widgets/modest-vbox-cell-renderer.c:
1703 (modest_vbox_cell_renderer_append):
1704 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1705 to fix the build with Maemo Bora.
1706 However, there seems to be a remaining crash, probably due to reference
1709 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1711 * src/modest-tny-account.c:
1712 (modest_tny_account_new_for_local_folders):
1713 Use hildon_file_system_info_async_new() to get a better name for
1714 the memory card account, setting it as the account name.
1715 The timing seems to work, but this is probably
1716 not the best place to do this. See the TODO comment.
1717 * src/maemo/modest-main-window.c: (create_details_widget):
1718 * src/widgets/modest-folder-view.c: (text_cell_data):
1719 Use the tny account name instead of hardcoding a name.
1721 2007-05-30 Christian Kellner <ckellner@openismus.com>
1723 * src/modest-search.c: (modest_search):
1724 Correctly set part_search_func even if we have already parsed
1725 the query and thus a valid OgsTextSearcher object.
1727 2007-05-30 Christian Kellner <ckellner@openismus.com>
1730 Search and check for libogs.
1733 Incooparte the ogs build env.
1735 * src/modest-mime-part-search-stream.c:
1736 * src/modest-mime-part-search-stream.h:
1737 Removed since we do the real searching now in modest-search.c.
1739 * src/modest-search.c:
1740 * src/modest-search.h:
1741 Implement support for ogs. We use that if available and requested
1742 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1743 should now handle the corner case when the search term is spread
1744 across multiple reads.
1745 Also the logic in modest_search () was corrected to search all
1746 requested fields until one is found.
1748 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1750 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1752 * src/modest-init.h:
1753 * src/modest-init.c: Made modest_init_local_folders() take a
1754 path and be public so we can iniitialize maildir folders on
1757 * src/modest-local-folder-info.h:
1758 * src/modest-local-folder-info.c:
1759 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1761 * src/modest-tny-account.c:
1762 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1763 still means the standard local-folders path on the local volume.
1765 * src/modest-tny-account-store.c:
1766 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1767 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1768 all accounts when that happens.
1769 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1770 this too, so it shows up in the treeview.
1772 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1774 * src/maemo/modest-maemo-global-settings-dialog.c:
1775 (current_connection):
1776 * src/widgets/modest-global-settings-dialog.c:
1777 (current_connection_default):
1778 Use the enum values instead of 0, 1 and -1,
1779 to make the code clearer.
1781 * src/modest-account-mgr-helpers.c:
1782 (modest_account_mgr_get_connection_specific_smtp): Make this code
1785 * src/modest-runtime.h:
1786 * src/modest-runtime.c:
1787 Added modest_runtime_remove_all_send_queues().
1788 * src/maemo/modest-main-window.c:
1789 (on_account_store_connecting_finished): Recreate the send queues,
1790 using the appropriate transport accounts for this new connection.
1791 Some futher adapting might be needed if the old send queues are not
1792 automatically stopped at this point.
1794 * src/modest-tny-account-store.c: (get_server_accounts):
1795 Create the connection-specific transport accounts, so that they can
1796 be found later by their ID.
1798 * src/modest-tny-account.h:
1799 * src/modest-tny-account.c:
1800 Added modest_tny_account_new_from_server_account_name().
1801 modest_tny_account_new_from_server_account(): Do not create the
1802 send queues here, because they will be
1803 recreated anyway when the connection changes for the first time.
1805 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1807 * src/modest-local-folder-info.h:
1808 * src/modest-local-folder-info.c:
1809 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1810 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1811 tbox_folder): Take a modest account name instead of a server TnyAccount,
1812 so we can have per-modest-account rather than per-transport-account
1814 We must make sure that we change or recreate the exisitng send queues
1815 when the connection changes for connection-specific transport accounts.
1817 * src/modest-tny-account-store.c:
1818 (create_per_account_local_outbox_folders): Create outboxed per modest
1819 account, not per transport account.
1821 * src/modest-tny-account.h:
1822 * src/modest-tny-account.c:
1823 (modest_tny_account_get_special_folder): For outboxes, get the
1824 parent modest account name. The account is ignored for other folders.
1825 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1826 modest account name rather than a server TnyAccount.
1828 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1830 * src/modest-tny-account.c:
1831 (modest_tny_account_new_from_server_account):
1832 Call modest_runtime_get_send_queue() immediately after creating transport
1833 accounts, so that they start trying to send email from the outbox as soon
1834 as possible at startup. This is probably what we want.
1836 * src/modest-mail-operation.c: (update_account_thread):
1837 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1838 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1839 * src/modest-tny-send-queue.h:
1840 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1841 (modest_ui_actions_on_send):
1842 Added comments about how sending works, though it needs some more work.
1844 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-tny-account.c:
1847 (modest_tny_account_get_special_folder): Add TODO because this fails when
1848 the network is busy.
1849 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1850 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1851 Do not try to show this window when there is no active account. The UI
1852 specs does not tell us what to do in this case.
1854 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1858 * src/maemo/Makefile.am:
1859 * src/widgets/Makefile.am: Some dist fixes.
1861 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1863 * src/maemo/modest-connection-specific-smtp-window.c:
1864 (on_button_edit): Make the code clearer, to prevent a double free.
1866 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1868 * src/maemo/modest-account-settings-dialog.c:
1869 (modest_account_settings_dialog_set_account_name),
1870 Check the connection-specific smtp servers checkbox if there are any.
1872 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1873 (modest_connection_specific_smtp_edit_window_init):
1874 Start with a suitable port number.
1876 * src/modest-account-mgr-helpers.h:
1877 * src/modest-account-mgr-helpers.c: Added
1878 modest_account_mgr_get_has_connection_specific_smtp().
1880 (modest_account_mgr_set_connection_specific_smtp),
1881 (modest_account_mgr_remove_connection_specific_smtp),
1882 (modest_account_mgr_get_has_connection_specific_smtp),
1883 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1884 connection-specific smtp server accounts in the account, rather than
1885 the server account conf dir.
1887 This fixes bug projects.maemo.org bug NB#58263 .
1889 * src/modest-tny-account-store.c:
1890 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1891 if there are no server accounts yet, to prevent an infinite loop when there
1892 are no accounts. Document that one must be called before the other.
1894 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1896 * src/modest-account-mgr-helpers.c:
1897 (modest_account_mgr_get_default_account): Make sure that at least
1898 one account is always the default, if there are any enabled accounts.
1899 This is just a sanity check that shouldn't be necessary.
1901 * src/modest-account-mgr-priv.c:
1902 (_modest_account_mgr_account_from_key): Unescape the conf key to
1903 get the real account name. For instance, this is an issue if a space
1904 was in the account name, which can happen because the account name
1905 is generated from the display name.
1906 (_modest_account_mgr_get_account_keyname): Always escape the
1908 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1909 Unescape the conf keys to get the real account names.
1911 For instance, previously the is-default radio button in the accounts
1912 list was not checked for any accounts at first. This fixes that,
1913 and might fix several similar bugs.
1915 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1917 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1918 Removed some debug printfs.
1920 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1922 Modest on-disk outbox directories are now here, for instance:
1923 $HOME/.modest/outboxes/<account-id-1>/outbox
1924 $HOME/.modest/outboxes/<account-id-2>/outbox
1926 $HOME/.modest/local-folders/outbox
1927 so we can have a separate outbox for each account.
1928 But they are shown as one outbox in the GtkTreeView, by using a
1929 TnyMergeFolder in a ModestTnySimpleFolderStore.
1932 * src/modest-tny-simple-folder-store.c:
1933 * src/modest-tny-simple-folder-store.h:
1934 Added ModestTnySimpleFolderStore, used to contain folders from
1935 other folder stores, such as other accounts.
1937 * src/modest-tny-outbox-account.h:
1938 * src/modest-tny-outbox-account.c:
1939 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1940 used for the per-account local outbox folders.
1942 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1943 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1944 only use this (internally) now for the non-outbox local folders.
1946 * src/modest-init.h:
1947 * src/modest-init.c: Added modest_init_one_local_folder(), for
1948 setting up the directory structure for each local folder.
1950 * src/modest-local-folder-info.c:
1951 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1952 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1954 * src/modest-local-folder-info.h:
1955 * src/modest-tny-account-store.c: (on_account_removed),
1956 (on_account_changed), (create_per_account_local_outbox_folders),
1957 (get_server_accounts), (modest_tny_account_store_get_accounts),
1958 (modest_tny_account_store_get_tny_account_by_account),
1959 (modest_tny_folder_store_is_virtual_local_folders):
1961 * src/modest-tny-account.h:
1962 * src/modest-tny-account.c:
1963 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1964 to create an on-disk per-account local outbox folder for each
1966 (create_per_account_local_outbox_folders): Create a local outbox folder
1967 for each transport account.
1968 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1969 for all local folders.
1971 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1972 instead of using g_object_get/set() directly. It is clearer.
1974 (modest_tny_folder_store_get_message_count),
1975 (modest_tny_folder_store_get_local_size
1976 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1977 because we now use these with non-acount folder stores.
1979 (modest_tny_account_get_special_folder),
1980 (modest_tny_account_new_from_server_account),
1981 (modest_tny_account_new_from_account):
1982 (recurse_folders): Adjust to the new outbox system.
1984 * src/modest-tny-folder.h:
1985 * src/modest-tny-folder.c:
1986 (modest_tny_folder_is_local_folder),
1987 (modest_tny_folder_get_local_folder_type),
1988 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1990 * src/widgets/modest-main-window.h:
1991 * src/maemo/modest-main-window.c: (create_details_widget),
1992 (modest_main_window_set_contents_style): Show details for any folder store,
1995 (modest_tny_folder_get_rules):
1996 Remove the const. C does not support constness enough for this.
1998 * src/modest-ui-actions.c:
1999 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2000 make all outboxes appear as one, in the usual local-folders tree node.
2002 (set_active_account_from_tny_account),
2003 (modest_ui_actions_on_folder_selection_changed):
2004 * src/widgets/modest-folder-view.c: (text_cell_data),
2005 (icon_cell_data), (filter_row),
2006 (add_account_folders_to_merged_folder),
2007 (add_account_folders_to_simple_folder_store), (),
2008 (get_cmp_rows_type_pos), (cmp_rows),
2009 (modest_folder_view_set_account_id_of_visible_server_account):
2010 Adjust to the new outbox system, using generic folder stores and folders
2011 in the GtkTreeModel.
2013 2007-05-23 Christian Kellner <ckellner@openismus.com>
2015 * src/modest-mail-operation.c:
2016 (modest_mail_operation_update_account):
2017 Use info->max_size instead of unintialized local var [small
2018 build fix]. (Added TODO to review that change since I don't
2021 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2023 * libmodest-dbus-client/libmodest-dbus-client.c:
2024 (libmodest_dbus_client_compose_mail): function added
2025 * src/dbus_api/modest-dbus-api.h:
2026 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2027 (on_compose_mail): Implementation of the SendAsMail functionality
2029 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2031 * src/modest-account-mgr.c:
2032 (modest_account_mgr_add_server_account): Set the secure-connection
2033 conf key for transport accounts as well as store accounts. I don't know
2034 why the if was there. For instance, this makes sure that we use SSL
2035 for the gmail preset from the easysetup wizard.
2037 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2039 * src/gnome/modest-main-window.c:
2040 (on_account_store_connecting_finished), (connect_signals):
2041 * src/maemo/modest-main-window.c:
2042 (on_account_store_connecting_finished), (connect_signals),
2043 (modest_main_window_new):
2044 Handle TnyAccountStore::connecting-finished instead of
2045 TnyDevice::connection-changed, because we cannot actually perform
2046 operations on accounts until TnyAccountStore has itself responded to
2047 the TnyDevice::connection-changed signal. This prevents a GError from
2049 Do not try to update at startup, because we (at least on scratchbox)
2050 already do an update at startup when the device goes online.
2051 This prevents a GError from tinymail.
2052 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2053 Added TODO about stopping simultaneous operations.
2055 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2057 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2058 * src/modest-mail-operation-queue.c:
2059 (modest_mail_operation_queue_remove):
2060 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2061 about where they happened.
2063 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2065 * src/modest-ui-actions.c:
2066 (modest_ui_actions_on_password_requested): Make sure that the remember
2067 output parameter is always TRUE.
2069 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2071 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2072 Show a OK/Cancel dialog if the error is a question, though we still do not
2073 know anything more about what we are asking the user.
2074 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2075 Fix an uninitialized variable (helper). This is a logic error, however.
2077 2007-05-21 Christian Kellner <ckellner@openismus.com>
2079 * src/modest-search.h:
2080 Correct bit shifting in the ModestSearchFlags enum.
2082 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2084 * src/modest-tny-account.c:
2085 (modest_tny_account_new_from_server_account): Do not use the lsub and
2086 check-all hard-coded IMAP options when using POP.
2088 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2090 * src/modest-tny-account.c:
2091 (modest_tny_account_new_from_server_account):
2092 Use NULL for the secure-auth method for POP when Password auth has been
2093 specified by the user, as we already do for IMAP. "auth=Login" causes
2094 an error from camel or the server.
2096 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2098 * src/maemo/modest-account-settings-dialog.c:
2099 (create_page_account_details),
2100 (modest_account_settings_dialog_set_account_name):
2101 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2102 for the leave-on-server checkbox, rathr than just the checkbox, when
2103 the protocol is not POP.
2105 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2107 * src/widgets/modest-account-view.c:
2108 * src/widgets/modest-account-view.h:
2109 Added modest_account_view_select_account() which will be useful later
2110 to asynchronously re-select the edited account.
2112 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/modest-account-settings-dialog.c:
2115 (modest_account_settings_dialog_set_account_name):
2116 Automatically choose the port numbers based on the secure authentication
2117 methods, if they have not been chosen before.
2118 This fixes projects.maemo.org bug NB#56273 .
2120 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/modest-main-window-ui.h:
2123 * src/modest-ui-actions.c:
2124 * src/modest-ui-actions.h:
2125 Connect the Tools/SMTP Servers menu item to
2126 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2127 SMTP servers dialog, as in the UI specification and saves changes when it
2128 is closed. This fixed projects.maemo.org bug NB#56305 .
2130 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2132 * src/maemo/modest-connection-specific-smtp-window.c:
2133 (modest_connection_specific_smtp_window_init):
2134 Use gtk_window_set_default_size() to make this window big enough, so
2135 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2137 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2140 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2141 (modest_connection_specific_smtp_edit_window_init),
2142 Do not try to connect to a combobox signal before the combobox exists.
2143 This fixes the cras in projects.maemo.org bug NB#56288 .
2144 (modest_connection_specific_smtp_edit_window_get_settings):
2145 Remove the server_account_name parameter which was being checked for NULL
2146 though it was not used.
2148 * src/maemo/modest-connection-specific-smtp-window.c:
2149 (modest_connection_specific_smtp_window_fill_with_connections),
2150 (on_button_edit), (modest_connection_specific_smtp_window_init):
2151 Correct the number of treemodel columns to prevent a warning.
2152 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2153 libconic does not work.
2155 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2157 * src/modest-tny-account.c:
2158 (modest_tny_account_new_from_server_account):
2159 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2160 SMTP when "None" was chosen by the user. However, with my SMTP server that
2161 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2164 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2167 to explain the memory management issue with the ID in the ModestPair.
2169 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2170 (add_sending_page), (modest_account_assistant_finalize):
2171 * src/gnome/modest-gnome-global-settings-dialog.c:
2172 (create_updating_page), (create_composing_page):
2173 * src/gnome/modest-msg-edit-window.c: (get_transports),
2174 (init_window), (modest_msg_edit_window_finalize),
2175 (modest_msg_edit_window_get_msg_data):
2176 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2177 * src/gnome/modest-transport-widget.c:
2178 (modest_transport_widget_finalize), (smtp_configuration):
2179 * src/maemo/modest-maemo-global-settings-dialog.c:
2180 (create_updating_page), (create_composing_page):
2181 * src/maemo/modest-msg-edit-window.c: (get_transports),
2182 (init_window), (modest_msg_edit_window_finalize),
2183 (modest_msg_edit_window_get_msg_data),
2184 (modest_msg_edit_window_free_msg_data):
2185 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2186 (modest_store_widget_finalize):
2187 * src/maemo/modest-transport-widget.c:
2188 (modest_transport_widget_finalize), (smtp_configuration):
2189 * src/modest-main.c: (send_mail):
2190 * src/widgets/modest-combo-box.h:
2191 * src/widgets/modest-global-settings-dialog-priv.h:
2192 * src/widgets/modest-global-settings-dialog.c:
2193 (modest_global_settings_dialog_finalize):
2194 * src/widgets/modest-msg-edit-window.h:
2195 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2196 as long as the combo box, to prevent use of freed memory for the ID.
2198 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2200 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2201 get_accounts(), to make this clearer. Do not check for the enabled gconf
2202 key, because we do not use this for server accounts (at least, not yet).
2203 This allows us to send email again.
2205 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2207 * src/maemo/modest-platform.c:
2208 (on_modest_conf_update_interval_changed), (modest_platform_init):
2209 Only respond to this particular key change. All these strcmp()s cannot be
2212 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2214 * src/maemo/modest-maemo-global-settings-dialog.c:
2215 (current_connection): Prevent a crash in scratchbox when
2216 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2217 * src/maemo/modest-platform.c:
2218 (on_modest_conf_update_interval_changed), (modest_platform_init):
2219 Get the update interval from gconf and reset it when the gconf key changes.
2221 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2223 * src/modest-protocol-info.c:
2224 * src/modest-protocol-info.h: Adde enum-specific get functions,
2225 instead of using a ModestProtocolType enum parameter.
2227 * src/gnome/modest-account-assistant.c:
2228 * src/gnome/modest-store-widget.c:
2229 * src/gnome/modest-store-widget.h:
2230 * src/gnome/modest-transport-widget.c:
2231 * src/gnome/modest-transport-widget.h:
2232 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2233 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2234 * src/maemo/easysetup/modest-easysetup-wizard.c:
2235 * src/maemo/modest-account-settings-dialog.c:
2236 * src/maemo/modest-account-settings-dialog.h:
2237 * src/maemo/modest-store-widget.c:
2238 * src/maemo/modest-store-widget.h:
2239 * src/maemo/modest-transport-widget.c:
2240 * src/maemo/modest-transport-widget.h:
2241 * src/modest-account-mgr-helpers.c:
2242 * src/modest-account-mgr-helpers.h:
2243 * src/modest-account-mgr.c:
2244 * src/modest-account-mgr.h:
2245 * src/modest-tny-account.c:
2246 * src/modest-tny-folder.c:
2247 * src/widgets/modest-account-view.c:
2248 * src/widgets/modest-retrieve-combo-box.c:
2249 * src/widgets/modest-retrieve-combo-box.h:
2250 * src/widgets/modest-secureauth-combo-box.c:
2251 * src/widgets/modest-serversecurity-combo-box.c:
2252 * src/widgets/modest-serversecurity-combo-box.h:
2253 * tests/check_account-mgr.c:
2254 Use the specific functions, and use the re-renamed enum values for GNOME too.
2256 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2258 * src/modest-pair.h:
2259 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2260 so we can get the second based on the first.
2262 * src/maemo/modest-account-settings-dialog.h:
2263 * src/maemo/modest-account-settings-dialog.c:
2264 Added get_supported_secure_authentication_methods(), though it is mostly
2265 commented-out for now until the necessary API is committed to tinymail.
2266 (modest_account_settings_dialog_set_account_name),
2267 (save_configuration): Request the supported authentication methods from the
2268 server, so we can choose a working method.
2270 * src/modest-tny-account-store.h:
2271 * src/modest-tny-account-store.c:
2272 (modest_tny_account_store_get_session): Rename from
2273 tny_account_store_get_session().
2275 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2277 * src/modest-protocol-info.h: Split the ModestProtocol enum
2278 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2279 There was no need to have these unrelated values in one enum.
2281 * src/: many files: Adapted to changed enum. This makes the code a bit
2282 clearer, and the compiler could catch some errors.
2284 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2286 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2287 Show the detailed internal camel error message when an error happens
2288 during the configuration, so that our testers can give us more clues.
2289 For instance, in projects.maemo.org bug NB#56910 .
2291 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2293 * src/modest-tny-account.c:
2294 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2295 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2297 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2299 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2300 * src/maemo/modest-account-settings-dialog.c:
2301 (modest_account_settings_dialog_set_account_name),
2302 (save_configuration): For the incoming secure authentication checkbox,
2303 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2304 the UI specification. PLAIN does not seem to be supported for most IMAP
2305 servers anyway, and I am not sure what it would mean.
2306 However, we probably need to discover which of the secure-authentication
2307 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2308 * src/modest-account-mgr-helpers.c:
2309 (modest_account_mgr_get_server_account_data):
2311 * src/modest-tny-account.c:
2312 (modest_tny_account_new_from_server_account):
2313 Use tny_account_set_mech() to set secure-authentication methods,
2314 with some special-casing for IMAP, based on my observations of how
2317 * src/modest-account-mgr-helpers.h:
2318 * src/modest-account-mgr.c:
2319 * src/modest-defs.h: Comment that the URI is only used for local folders.
2321 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2323 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2324 parameter const, just to be neat.
2325 * src/modest-text-utils.c: (modest_text_utils_inline):
2326 End g_strconcat() with NULL, as its documentation says. This is almost
2327 certainly the cause of my crash at startup on the device. Interestingly,
2328 valgrind doesn't tell us about these errors.
2330 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2332 * scripts/build-packages: Added more precise comments about how to use
2333 this script, though I still get this error:
2334 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2335 error building tinymail
2337 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2339 * src/maemo/modest-main-window.c: (on_account_update):
2340 Very slight cleanup, hoping to make it simpler to discover what causes
2341 a crash here sometimes.
2343 * src/modest-tny-account.c:
2344 (modest_tny_account_new_from_server_account): Set the port. Added
2345 comments about the options and a TODO comment because I need to find out
2346 how to specify the secure authentication method.
2348 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2350 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2351 changed CFlags paths form modest to libmodest
2353 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2355 * src/modest-account-mgr-helpers.c:
2356 (modest_account_mgr_get_server_account_data),
2357 (modest_account_mgr_free_server_account_data):
2358 * src/modest-account-mgr-helpers.h:
2359 * src/modest-account-mgr.c:
2360 (modest_account_mgr_add_server_account):
2361 * src/modest-defs.h:
2362 * src/modest-tny-account.c:
2363 (modest_tny_account_new_from_server_account):
2364 Determine the options for tny_camel_account_add_option() here,
2365 based on the settings, rather than storing them directly in gconf.
2367 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2369 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2370 Show a more friendly error dialog now that we expect (from the tinymail
2371 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2373 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2375 * src/maemo/modest-main-window.c: (on_account_update): Check that
2376 account_name is not NULL, to prevent a crash at startup that I am
2377 seeing on the N800. I do wonder why it is NULL.
2379 * src/maemo/easysetup/modest-easysetup-wizard.c:
2380 (create_page_user_details):
2381 * src/maemo/modest-account-settings-dialog.c:
2382 (create_page_user_details), (create_page_outgoing):
2383 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2384 (modest_connection_specific_smtp_edit_window_init):
2385 * src/modest-ui-actions.c:
2386 (modest_ui_actions_on_password_requested):
2387 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2388 might do something useful with the on-screen keyboard.
2390 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2392 * src/maemo/modest-main-window.c: (on_account_update):
2393 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2394 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2396 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2398 * src/modest-tny-account-store.c: (on_account_changed):
2399 Correct the signature of this signal handler.
2401 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2404 Show a HildonNote instead of a GtkDialog for Maemo.
2406 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2408 * src/widgets/modest-account-view.h:
2409 * src/widgets/modest-account-view.c: (on_account_changed),
2410 (on_account_removed). Added a boolean flag, set/unset by
2411 modest_account_view_block_conf_updates(),
2412 modest_account_view_unblock_conf_updates() to prevent unnecessary
2413 updates, but this is not very useful because the gconf notifications are
2414 so delays (maybe only on Maemo Bora).
2415 So auto-updating is turned off, and these functions do an explicit
2416 update when necessary.
2417 However, something else is still doing too much work when adding/removing
2418 accounts, probably in another part of the application.
2420 * src/maemo/modest-account-view-window.c:
2421 (on_delete_button_clicked), (on_edit_button_clicked),
2422 (on_new_button_clicked): Use the new functions.
2424 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2426 * src/modest-account-mgr-helpers.c:
2427 (modest_account_mgr_set_first_account_as_default):
2428 Sort the list of names alphabetically-by-title, so we choose the first one
2430 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2431 alphabetically by the title.
2433 This fixes projects.maemo.org bug NB#56418 .
2435 * src/modest-account-mgr-priv.c:
2436 (_modest_account_mgr_account_from_key):
2437 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2438 avoid a valgrind error, and possible random behaviour.
2440 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2442 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2443 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2444 tinymail documentation to say that this can be expected.
2445 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2446 pretty, and should not happen, but I would prefer to know when it does.
2448 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2450 * configure.ac: When using the older hildon version, probably on Bora,
2451 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2453 * src/widgets/modest-attachment-view.c:
2454 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2457 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2459 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2460 Implemented the prototype. Can be tested with
2461 tests/dbus_api/test_open_message:
2463 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2465 * src/modest-tny-account-store.c:
2466 (modest_tny_account_store_instance_init), (get_password):
2467 * src/modest-ui-actions.c:
2468 (modest_ui_actions_on_password_requested):
2469 Do not store the password in gconf, because this function is called
2470 for non-remembered passwords. Actually use the cached (in the hash map)
2471 password instead of releasing it.
2472 The password will now not be remembered if it is asked via the protected
2473 password dialog, as per the UI spec.
2475 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-defs.h:
2478 * src/modest-account-mgr-helpers.h:
2479 * src/modest-account-mgr-helpers.c:
2480 Added modest_server_account_get_username_has_succeeded(),
2481 modest_server_account_set_username_has_succeeded().
2482 (modest_server_account_set_username),
2483 Reset the has-succeeded flag if the username changes.
2485 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2486 * src/maemo/modest-connection-specific-smtp-window.c:
2487 (modest_connection_specific_smtp_window_save_server_accounts):
2488 Use modest_server_account_set_username() instead of using
2489 modest_conf_set_string() directly, so that the has-succeeded flag is always
2492 * src/modest-ui-actions.c:
2493 (modest_ui_actions_on_password_requested): Dim the username entry if
2494 the username has ever worked, as per the UI spec.
2496 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2498 * src/modest-tny-account-store.c: (get_password):
2499 * src/modest-ui-actions.c:
2500 (modest_ui_actions_on_password_requested):
2501 Allow the username to be changed too, though there is more work to
2502 be done on exactly how this behaves.
2504 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2506 * src/modest-account-mgr-helpers.h:
2507 * src/modest-account-mgr-helpers.c:
2508 Added modest_account_mgr_get_display_name(),
2509 modest_server_account_get_username(),
2510 modest_server_account_set_username(),
2511 modest_server_account_set_password(),
2512 modest_server_account_get_hostname() functions so we do not need to
2513 use the conf API directly.
2515 * src/maemo/modest-main-window.c: (connect_signals):
2516 Actually connect ot the ModestAccountStore::request-password signal,
2517 so that we show the dialog when the password is requested by Tinymail,
2518 for isntance if it is empty.
2520 * src/modest-marshal.list:
2521 * src/modest-tny-account-store.c:
2522 (modest_tny_account_store_class_init), (get_password),
2523 (modest_tny_account_store_alert):
2524 * src/modest-tny-account-store.h:
2525 * src/modest-ui-actions.h:
2526 * src/modest-ui-actions.c:
2527 (modest_ui_actions_on_password_requested):
2528 Change the signal parameters, so it is obvious that we are providing
2529 the non human-readable server name, and receiving both the username
2530 and password, though changing of the username is not yet implemented.
2531 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2532 for the GNOME version.
2534 This should fix the projects.maemo.org bug NB#56209, though it does not
2535 work on Bora, because the gconf_client_get() for the password fails
2536 immediately after we save it with gconf_client_set().
2538 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2541 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2542 caused an undefined symbol error:
2543 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2545 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2547 * src/modest-tny-account-store.c:
2548 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2549 using a GError instead of a string message, so we can translate it in
2552 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2554 * src/maemo/modest-address-book.c:
2555 (modest_address_book_check_names):
2556 * src/maemo/modest-msg-view-window.c:
2557 (modest_msg_view_window_clipboard_owner_change):
2558 * src/modest-init.c: (modest_init_init_ui):
2559 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2560 (update_folders_cb), (modest_mail_operation_update_account):
2561 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2562 (modest_ui_actions_on_msg_attachment_clicked),
2563 (modest_ui_actions_on_msg_recpt_activated):
2564 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2565 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2566 (modest_msg_view_search_next):
2567 * src/widgets/modest-recpt-editor.c:
2568 (modest_recpt_editor_on_button_release_event),
2569 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2570 g_message(). At this point we should only be seeing interesting errors on
2571 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2573 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2575 (modest_wizard_dialog_force_title_update):
2576 * src/maemo/easysetup/modest-wizard-dialog.h:
2577 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2578 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2579 can update the title when appropriate. Otherwise the title is wrong if the
2580 pages are added after adding the notebook to the dialog.
2581 This must be a problem in HildonWizardDialog too.
2582 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2584 * src/maemo/easysetup/modest-easysetup-wizard.c:
2585 (create_subsequent_customsetup_pages),
2586 (create_subsequent_easysetup_pages):
2587 Call modest_wizard_dialog_force_title_update() so that the title is
2588 correct even with GTK+ < 2.10.
2589 This fixes projects.maemo.org bug NB#56145 .
2591 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2593 * src/maemo/modest-platform.c:
2594 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2595 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2598 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2600 * src/widgets/modest-window.h:
2601 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2602 and modest_window_save_state(), which invokes it.
2604 * src/widgets/modest-window-mgr.h:
2605 * src/widgets/modest-window-mgr.c:
2606 Added modest_window_mgr_save_state_for_all_windows(), which calls
2607 the save_state vfunc on all registered windows, if implemented.
2609 * src/gnome/modest-msg-edit-window.c:
2610 * src/gnome/modest-msg-view-window.c:
2611 * src/maemo/modest-msg-edit-window.c:
2612 * src/maemo/modest-msg-view-window.c:
2613 * src/maemo/modest-main-window.c:
2614 Specify the existing save_settings functions as implementations of
2615 ModestWindow::save_state_func().
2617 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2618 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2619 enabling hibernation, for instance.
2621 We may need to do the same thing for restoring settings.
2624 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2626 * src/widgets/modest-window-mgr.c:
2627 * src/widgets/modest-window-mgr.h:
2628 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2629 modest_window_mgr_get_hibernation_is_prevented().
2631 * src/maemo/modest-main-window.c:
2632 (on_hildon_program_is_topmost_notify): Prevent hibernation
2633 (possible when the application goes to the background in the WM),
2634 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2636 * src/maemo/easysetup/modest-easysetup-wizard.c:
2637 (modest_easysetup_wizard_dialog_init):
2638 * src/maemo/modest-account-settings-dialog.c:
2639 (modest_account_settings_dialog_init):
2640 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2641 (modest_connection_specific_smtp_edit_window_init):
2642 * src/maemo/modest-connection-specific-smtp-window.c:
2643 (modest_connection_specific_smtp_window_init):
2644 * src/maemo/modest-signature-editor-dialog.c:
2645 (modest_signature_editor_dialog_init):
2646 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2647 prevent hibernation while any of these account settings dialogs are open.
2649 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2651 * src/maemo/Makefile.am:
2652 * src/maemo/modest-osso-state-saving.c:
2653 * src/maemo/modest-osso-state-saving.h: Added
2654 modest_osso_load_state() and modest_osso_save_state() though they do
2655 nothing now. They should iterate through all the open windows and load/save
2657 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2658 save state when closing.
2660 * src/maemo/modest-main-window.c:
2661 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2662 Add a notification handler for the HildonProgram::is-topmost property,
2663 so we can allow hibernation when the application goes into the background.
2664 But we still need to detect when the accounts setup windows are open so
2665 we can stop hibernation when they are open.
2666 To do this, I also added the main window the HildonProgram. This might have
2667 other side-effects/benefits, and should maybe be done for other windows.
2669 * src/maemo/modest-osso-autosave-callbacks.h:
2670 * src/maemo/modest-osso-autosave-callbacks.c:
2671 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2672 though it does not do anything yet, and we might never need this to do
2673 anything. For instance, we already save drafts.
2675 * src/maemo/modest-platform.c: (modest_platform_init):
2676 Specify the libosso auto-save callback.
2678 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2680 * src/maemo/modest-platform.c:
2681 (modest_platform_set_update_interval):
2682 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2683 aparently stays valid between application instances, so we can use this
2684 to remove and reset it later. According to a maemo-developers email from
2687 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2689 * configure.ac: Depend on libalarm for Maemo.
2691 * src/dbus_api/modest-dbus-api.h:
2692 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2693 (on_send_receive), (modest_dbus_req_handler):
2694 Handle a SEND_RECEIVE D-Bus method.
2696 * libmodest-dbus-client/libmodest-dbus-client.c:
2697 (libmodest_dbus_client_send_and_receive):
2698 * libmodest-dbus-client/libmodest-dbus-client.h:
2699 Add C convenience functions for calling the new D-Bus method.
2701 * src/modest-platform.h:
2702 * src/gnome/modest-platform.c:
2703 * src/maemo/modest-platform.c:
2704 Added modest_platform_set_update_interval(), which uses the
2705 alarmd API on Maemo.
2706 (modest_platform_init),
2707 Call modest_platform_set_update_interval(), using a hard-coded
2708 interval for now (until the global settings dialog is implemented),
2709 though I am not sure that this makes sense yet.
2711 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2713 * src/dbus_api/modest-dbus-callbacks.c:
2714 (modest_osso_cb_hw_state_handler):
2715 * src/dbus_api/modest-dbus-callbacks.h:
2716 * src/maemo/modest-platform.c: (modest_platform_init):
2717 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2718 in case this has some effect on the ability for Maemo to ping the
2721 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2723 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2724 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2725 warning. It is probably a logic error, but I need to fix the build.
2727 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2729 * src/modest-account-mgr.h:
2730 * src/modest-account-mgr.c:
2731 (modest_account_mgr_account_names): Add a gboolean enabled_only
2732 parameter, so we can get lists of onlt the enabled accounts.
2734 (modest_account_mgr_add_account),,
2735 (modest_account_mgr_account_with_display_name_exists):
2736 * src/maemo/modest-msg-edit-window.c: (get_transports):
2737 * src/modest-account-mgr-helpers.c:
2738 (modest_account_mgr_set_first_account_as_default):
2739 * src/modest-init.c: (init_default_account_maybe):
2740 * src/modest-tny-account-store.c: (get_accounts):
2741 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2742 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2743 * tests/check_account-mgr.c: (START_TEST):
2744 Provide the extra parameter, as appropriate.
2746 * src/widgets/modest-account-view.c: (update_account_view):
2747 Do not show disabled accounts (meaning that there is no way to
2748 enable/disable accounts in the UI (the feature is not in our UI
2749 specification), so we can use this internally only to mark unfinished
2750 or temporary account data.
2752 * src/maemo/easysetup/modest-easysetup-wizard.c:
2753 (create_account): Add boolean enable parameter, so we can specify FALSE
2754 to create the temporary account.
2755 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2756 (on_before_next): When finishing, when there is a temporary account, just
2758 Also, use a timeout to delay the showing of the dialog until gconf is likely
2759 to return correct information, due to a maemo gconf bug that is fixed in
2760 osso 1.1, but not yet in Bora.
2761 However, the dialog stays on screen after it is destroyed.
2763 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2764 for invalid data when cancelling. Use a hildon note instead of a dialog
2765 to complain about invalid data. Do not show the account-saved note if the
2766 account is disabled (a temporary account that will not really be saved for use
2769 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2771 * src/modest-account-mgr-helpers.h:
2772 * src/modest-account-mgr-helpers.c:
2773 Added modest_account_mgr_unset_default_account(),
2774 Added modest_account_mgr_set_first_account_as_default().
2776 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2777 If it was the default account, unset the default account name.
2779 * src/maemo/modest-account-view-window.c:
2780 (on_delete_button_clicked): If it was the default account,
2781 set the first remaining account as the default instead.
2783 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2784 a NULL account or a NULL default account, to prevent a crash. This should
2785 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2788 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2790 * src/widgets/modest-recpt-editor.c:
2791 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2792 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2793 TODO comment for this. This fixes the build.
2795 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2796 be the best place for it. This will in future update all auto-update accounts,
2797 rather than just the current/default account, when that gconf key exists.
2798 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2799 if there are no accounts, before calling do_send_receive().
2800 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2802 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2803 * src/maemo/modest-main-window-ui.h:
2804 * src/maemo/modest-main-window.c: (on_connection_changed),
2805 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2806 directly, becaue the signal handler does more.
2808 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2810 * src/modest-account-mgr-helpers.c:
2811 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2812 for the case that the account does not exist.
2814 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2815 (equivalent to the modest account name) rather than the tinymail account name
2816 (equivalent to the modest account title - human readable) to get the account data.
2817 Check for null account data to prevent the crash, and add a TODO comment saying that
2818 this needs fixing because it is using the server account name instead of the account name.
2820 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2822 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2823 * src/maemo/modest-account-settings-dialog.c: (show_error),
2825 Use hildon_note_new_information() for informative and error messages,
2826 which seems to be expected for Maemo applications (no documentation that I know of
2827 says this). I am surprised that there is no distinction between info and error
2830 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2832 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2833 it is easy to find where this is used.
2835 * src/maemo/easysetup/modest-easysetup-wizard.c:
2836 (create_page_welcome), (create_page_account_details),
2837 (create_page_user_details), (create_page_complete_easysetup),
2838 (create_page_custom_incoming), (create_page_custom_outgoing),
2839 (create_page_complete_custom):
2840 * src/maemo/modest-account-settings-dialog.c:
2841 (create_page_account_details), (create_page_user_details),
2842 (create_page_incoming), (create_page_outgoing):
2843 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2844 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2845 (modest_connection_specific_smtp_edit_window_init):
2846 * src/maemo/modest-connection-specific-smtp-window.c:
2847 (modest_connection_specific_smtp_window_init):
2848 * src/maemo/modest-signature-editor-dialog.c:
2849 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2850 and scrolling policy as per the Email Application Layout Guide, if I have
2853 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2855 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2856 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2857 which were empty, because these vfuncs have been removed from TnyAccountStore.
2858 This fixes the build.
2860 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2862 * src/maemo/modest-main-window.c:
2863 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2864 showing/hiding it. Added TODO because it probably should not be NULL.
2865 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2866 because unnecessary g_warnings() make degugging difficult.
2868 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2870 * src/maemo/modest-msg-edit-window.c:
2871 (modest_msg_edit_window_select_color),
2872 (modest_msg_edit_window_select_background_color): 2 const corrections and
2873 moving 2 #endifs before closing brackets, to fix the build.
2875 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2877 * src/maemo/easysetup/modest-easysetup-wizard.h:
2878 * src/maemo/easysetup/modest-easysetup-wizard.c:
2879 (modest_easysetup_wizard_dialog_finalize),
2880 (on_button_edit_advanced_settings), (create_page_complete_custom),
2881 (on_response), (create_account):
2882 Implement the Advanced Settings edit button, by saving the account information,
2883 for the Advanded Settings dialog to use directly from gconf, and removing it
2884 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2885 Bug #5533 in the projects.maemo.org bugzilla.
2887 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2889 * src/maemo/modest-msg-view-window.c:
2890 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2891 when opening a message window.
2893 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2895 * src/maemo/easysetup/modest-easysetup-wizard.c:
2896 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2899 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2900 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2901 gconf settings. I probably added more checks than necessary, but that is safer.
2903 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2904 variable to fix the build, but this seems to be used when it is still NULL.
2906 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2908 * src/modest-platform.h:
2909 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2910 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2911 * src/modest-main.c: Implement this function so we can avoid using
2912 maemo-specific API from cross-platform code.
2914 * src/modest-tny-account-store.c:
2915 (get_smtp_specific_transport_account_for_open_connection):
2916 * src/modest-ui-actions.c: (check_for_connection),
2917 (modest_ui_actions_on_item_not_found):
2918 Use modest_platform_connect_and_wait() and put #idefs around other
2919 maemo-specific code, because only maemo currently has a way to
2920 identify connection names.
2922 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2924 * src/modest-tny-account-store.h:
2925 * src/modest-tny-account-store.c:
2926 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2927 the connection-specific SMTP server settings in the configuration.
2929 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2931 * src/maemo/modest-main-window.c: (on_connection_changed),
2933 * src/modest-main.c: (main), (start_ui), (send_mail):
2934 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2935 that is what is intended.
2937 * src/modest-ui-actions.c: (action_send), (action_receive),
2938 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2939 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2940 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2941 SMTP server is used when it is specified.
2943 (modest_ui_actions_on_send_receive):
2944 Check that a connection is open before proceeding.
2945 Receive and then send, instead of vice-versa, as per the specification.
2947 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2949 * src/modest-mail-operation.c:
2950 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2951 though I guess it should be something other than NULL.
2953 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/easysetup/modest-easysetup-wizard.c:
2956 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2957 combo twice, to avoid an g_warning and to make it visible again.
2958 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2959 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2960 (already intended) dereference when detaching, because we then recreate the menu.
2961 But I am not sure why the warning was happening, and it is possible that this is a memory
2964 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2966 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2967 and uri_parse_mailto() utility functions.
2968 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2970 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2972 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2974 * src/dbus_api/modest-dbus-api.h:
2975 * src/dbus_api/modest-dbus-callbacks.c:
2976 Use an idle callback to execute the modest code in the application's own thread.
2977 Remove the helloworld example method.
2978 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2979 parsed, and the open-message method is not implemented because this is not yet implemented in
2981 * libmodest-dbus-client/libmodest-dbus-client.c:
2982 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2983 (libmodest_dbus_client_open_message):
2984 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2986 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2987 body without crashing.
2989 * tests/dbus_api/Makefile.am:
2990 * tests/dbus_api/test_mail_to.c:
2991 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2993 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2995 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2996 Added file to fix the build. Sorry.
2998 * src/dbus_api/Makefile.am:
2999 * src/dbus_api/modest-dbus-api.h:
3000 * src/dbus_api/modest-dbus-callbacks.h:
3001 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3002 (modest_dbus_req_handler):
3003 Put constants in a separate header so it can be reused by the
3004 client library, without duplication
3006 * libmodest-dbus-client/Makefile.am:
3007 * libmodest-dbus-client/libmodest-dbus-client.c:
3008 (libmodest_dbus_client_call_helloworld),
3009 (libmodfest_dbus_client_send_mail),
3010 (libmodfest_dbus_client_mailto),
3011 (libmodfest_dbus_client_open_message):
3012 * libmodest-dbus-client/libmodest-dbus-client.h:
3013 (Partly) Implement a send_mail D-Bus method.
3015 * tests/dbus_api/Makefile.am:
3016 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3017 the send_email D-Bus method.
3019 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3023 * libmodest-dbus-client/Makefile.am:
3024 * libmodest-dbus-client/libmodest-dbus-client.c:
3025 * libmodest-dbus-client/libmodest-dbus-client.h:
3026 * tests/dbus_api/Makefile.am:
3027 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3028 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3030 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3032 * src/maemo/easysetup/modest-easysetup-wizard.c:
3033 (create_page_account_details):
3034 * src/maemo/modest-account-settings-dialog.c:
3035 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3036 widgets, because this might not be the default in future versions of the Maemo GTK+.
3037 However, I can not not get capitalization to work even in a simple test case.
3039 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3041 * src/maemo/easysetup/modest-easysetup-wizard.c:
3042 (create_page_custom_incoming), (create_page_custom_outgoing):
3043 * src/maemo/modest-account-settings-dialog.c:
3044 (create_page_account_details), (create_page_incoming),
3045 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3046 instead of using gtk_check_button_with_label(), so they are aligned like the other
3047 widgets, as per the UI spec.
3049 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3051 * src/maemo/easysetup/modest-easysetup-wizard.c:
3052 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3053 * src/widgets/modest-validating-entry.c:
3054 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3055 Modest prefix instead of an EasySetup prefix.
3057 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3059 * src/widgets/modest-validating-entry.h:
3060 * src/widgets/modest-validating-entry.c: (on_insert_text),
3061 Added easysetup_validating_entry_set_max_func(), used to set a callback
3062 to call when the max number of characters is reached. GtkEntry has a max-length
3063 already but is silent about it.
3065 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3066 (create_page_account_details), (create_page_user_details),
3068 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3069 (create_page_account_details), (create_page_user_details),
3070 (create_page_outgoing):
3071 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3072 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3073 the UI spec, when the user tries to enter more than the max number of characters.
3075 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3077 * src/maemo/easysetup/modest-easysetup-wizard.c:
3078 (create_page_user_details), (create_page_custom_incoming),
3079 (create_page_custom_outgoing):
3080 * src/maemo/modest-account-settings-dialog.c:
3081 (create_page_user_details), (create_page_incoming),
3082 (create_page_outgoing):
3083 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3084 (modest_connection_specific_smtp_edit_window_init):
3085 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3086 not appropriate. Bad Maemo-specific defaults!.
3088 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3090 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3091 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3092 (modest_signature_editor_dialog_set_settings):
3093 Disable the label and textview when the checkbox is disabled, and use the
3094 specified (UI spec) default signature text.
3096 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3098 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3099 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3101 * src/modest-defs.h:
3102 * src/modest-account-mgr-helpers.h:
3103 * src/modest-account-mgr-helpers.c:
3104 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3106 * src/maemo/Makefile.am:
3107 * src/maemo/modest-signature-editor-dialog.c:
3108 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3111 * src/maemo/modest-account-settings-dialog.h:
3112 * src/maemo/modest-account-settings-dialog.c:
3113 (modest_account_settings_dialog_finalize), (on_button_signature),
3114 (save_configuration): Use the new dialog when the Edit button is pressed, and
3115 save the changes if necessary, as per the UI spec.
3117 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3119 * src/maemo/Makefile.am:
3120 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3121 based on maemo-develoers email from Dirk.
3123 * src/maemo/easysetup/modest-easysetup-wizard.c:
3124 (create_page_welcome), (create_page_account_details),
3125 (create_page_user_details), (create_page_complete_easysetup),
3126 (create_page_custom_incoming), (create_page_custom_outgoing),
3127 (create_page_complete_custom),
3128 (modest_easysetup_wizard_dialog_init):
3129 * src/maemo/modest-account-settings-dialog.c:
3130 (create_page_account_details), (create_page_user_details),
3131 (create_page_incoming), (create_page_outgoing),
3132 (modest_account_settings_dialog_init):
3133 * src/maemo/modest-connection-specific-smtp-window.c:
3134 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3136 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3138 * src/maemo/easysetup/modest-easysetup-wizard.c:
3139 (create_page_account_details), (create_page_custom_outgoing),
3140 (create_page_complete_custom):
3141 * src/maemo/modest-account-settings-dialog.c:
3142 (create_page_user_details), (create_page_incoming),
3143 (create_page_outgoing):
3144 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3145 (modest_connection_specific_smtp_edit_window_init):
3146 Use the correct (UI spec) port min/max, and use horizontal separators,
3149 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3151 * src/maemo/easysetup/modest-easysetup-wizard.c:
3152 (set_default_custom_servernames):
3153 * src/maemo/modest-account-settings-dialog.c:
3154 (create_page_incoming), (on_combo_outgoing_security_changed),
3155 (on_combo_incoming_security_changed), (create_page_outgoing),
3156 (modest_account_settings_dialog_set_account_name),
3157 (save_configuration):
3158 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3159 (on_combo_security_changed),
3160 (modest_connection_specific_smtp_edit_window_init),
3161 (modest_connection_specific_smtp_edit_window_set_connection),
3162 (modest_connection_specific_smtp_edit_window_get_settings):
3163 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3166 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3169 * src/maemo/easysetup/modest-easysetup-wizard.c:
3170 (create_page_custom_outgoing), (create_page_complete_custom):
3171 * src/maemo/modest-account-settings-dialog.c:
3172 (create_page_user_details), (create_page_outgoing):
3173 * src/maemo/modest-account-view-window.c: (button_box_new):
3174 Use changed logical IDs as per the most recent UI spec:
3175 mcen_bd_emailsetup_edit -> mcen_bd_edit
3176 mcen_bd_emailsetup_delete -> mcen_bd_delete
3177 mcen_bd_emailsetup_close -> mcen_bd_close
3179 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3183 * src/dbus_api/Makefile.am:
3184 * src/dbus_api/modest-dbus-callbacks.c:
3185 * src/dbus_api/modest-dbus-callbacks.h:
3186 * src/maemo/modest-platform.c: (modest_platform_init):
3187 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3189 * tests/Makefile.am:
3190 * tests/dbus_api/Makefile.am:
3191 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3193 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/modest-account-settings-dialog.c:
3196 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3197 Removed unnecessary includes.
3199 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/easysetup/modest-easysetup-wizard.c:
3202 * src/maemo/modest-account-settings-dialog.c:
3203 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3204 * src/widgets/Makefile.am:
3205 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3206 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3207 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3208 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3209 * src/widgets/modest-secureauth-combo-box.c:
3210 * src/widgets/modest-secureauth-combo-box.h:
3211 * src/widgets/modest-serversecurity-combo-box.c:
3212 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3213 made the GObject names more consistent with the rest of the Modest code.
3215 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3217 * src/maemo/easysetup/Makefile.am:
3218 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3219 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3220 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3221 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3222 * src/maemo/easysetup/modest-easysetup-wizard.c:
3223 * src/maemo/easysetup/modest-validating-entry.c:
3224 * src/maemo/easysetup/modest-validating-entry.h:
3225 * src/maemo/modest-account-settings-dialog.c:
3226 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3227 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3228 widgets/ because they are used outside of easysetup too. After checking in,
3229 svn will allow me to rename them too.
3231 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3233 * src/gnome/modest-msg-edit-window.c:
3234 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3235 linker error, to fix the build on the GNOME platform.
3236 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3237 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3238 ifdefed out to avoid a warning.
3240 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3242 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3243 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3244 some alternative for GTK+ 2.6.
3246 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3248 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3250 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3251 specified for EmailAccountsDialog in UI spec.
3253 * src/maemo/easysetup/modest-easysetup-wizard.c:
3254 * src/maemo/easysetup/modest-easysetup-wizard.h:
3255 * src/maemo/modest-account-settings-dialog.c:
3256 * src/maemo/modest-account-settings-dialog.h:
3257 Reuse a member window widget for the connection-specific SMTP server accounts,
3258 so we can tell it to create/save the accounts only if we actually save changes.
3260 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3261 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3262 (modest_connection_specific_smtp_edit_window_get_settings):
3263 Return a struct instance for temporarily remembering the entered data.
3265 * src/maemo/modest-connection-specific-smtp-window.h:
3266 * src/maemo/modest-connection-specific-smtp-window.c:
3267 (modest_connection_specific_smtp_window_finalize),
3268 (modest_connection_specific_smtp_window_fill_with_connections),
3270 (modest_connection_specific_smtp_window_save_server_accounts),
3271 (update_model_server_names): Do not actually save data until asked,
3272 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3274 (on_selection_changed),
3275 (modest_connection_specific_smtp_window_init): Disable the edit
3276 button when nothing is selected.
3278 * src/modest-account-mgr-helpers.c:
3279 * src/modest-account-mgr-helpers.h:
3280 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3283 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3285 * src/modest-account-mgr-helpers.h:
3286 * src/modest-account-mgr-helpers.c:
3287 (modest_account_mgr_get_unused_account_name),
3288 (modest_account_mgr_get_unused_account_display_name): Added these
3289 utility functions, to avoid code duplication.
3291 * src/maemo/easysetup/modest-easysetup-wizard.c:
3292 (create_page_account_details), (create_account):
3293 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3294 (on_combo_security_changed),
3295 (modest_connection_specific_smtp_edit_window_init),
3296 (modest_connection_specific_smtp_edit_window_save_settings):
3297 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3298 * src/maemo/modest-connection-specific-smtp-window.c:
3299 (modest_connection_specific_smtp_window_finalize),
3300 (modest_connection_specific_smtp_window_fill_with_connections),
3301 (on_button_edit), (modest_connection_specific_smtp_window_init):
3302 * src/maemo/modest-connection-specific-smtp-window.h:
3303 Implementing saving of connection-specific server accounts.
3305 But I need to refactor this so we can save the data for each
3306 possible connection-specific account and only actually create the server accounts
3307 when the easysetup finished, or the OK button is pressed on the account settings
3310 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3312 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3313 (on_combo_security_changed):
3314 (modest_connection_specific_smtp_edit_window_init):
3315 Auto-fill the port number as in the account settings.
3317 (modest_connection_specific_smtp_edit_window_set_connection):
3318 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3319 * src/maemo/modest-connection-specific-smtp-window.c:
3320 (fill_with_connections), (on_button_edit),
3321 (modest_connection_specific_smtp_window_init):
3322 Turn the edit window into a dialog to simplify the code, and
3323 set a WM hint as in a GtkDialog, because only a popup can be on top of
3324 another window in Maemo, and popups usually have no WM decoration.
3326 * src/modest-defs.h:
3327 * src/modest-account-mgr-helpers.c:
3328 (modest_account_mgr_set_connection_specific_smtp),
3329 (modest_account_mgr_remove_connection_specific_smtp),
3330 (modest_account_mgr_get_connection_specific_smtp):
3331 * src/modest-account-mgr-helpers.h: Some functions to write the
3332 connection-specific SMTP server information. Not yet used.
3335 * src/widgets/modest-folder-view.c: (text_cell_data):
3336 Fix a warning about an uninitialized variable.
3337 (on_configuration_key_changed): Put an #ifdef around the use
3338 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3340 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3342 * src/maemo/modest-account-settings-dialog.h:
3343 * src/maemo/modest-account-settings-dialog.c:
3344 Added connect_for_modified() utility function to mark the new modified boolean.
3346 (create_page_account_details), (create_page_user_details),
3347 (create_page_incoming), (create_page_outgoing), (on_response),
3348 (modest_account_settings_dialog_init),
3349 (modest_account_settings_dialog_set_account_name):
3350 Only warn about unsaved changes when there are actually unsaved changes.
3352 * src/modest-account-mgr-helpers.c:
3353 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3354 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3355 to get the data from there in future.
3357 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3359 * src/modest-defs.h:
3361 * src/modest-account-mgr-helpers.h:
3362 * src/modest-account-mgr-helpers.c:
3363 Store the security account setting in a single conf key instead of using
3364 the options list, so that the list is left for just the to-be-removed camel hack,
3365 and because gconf_client_set_list() is failing for some reason.
3367 * src/modest-account-mgr.c:
3368 (modest_account_mgr_add_server_account):
3369 * src/maemo/modest-account-settings-dialog.c:
3370 (modest_account_settings_dialog_set_account_name),
3371 (save_configuration): Use the renamed functions.
3374 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3376 * src/widgets/Makefile.am:
3377 * src/widgets/modest-limit-retrieve-combo-box.c:
3378 * src/widgets/modest-limit-retrieve-combo-box.h:
3379 * src/widgets/modest-retrieve-combo-box.c:
3380 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3381 the account settings dialog.
3383 * src/modest-defs.h:
3384 * src/modest-account-mgr-helpers.h:
3385 * src/modest-account-mgr-helpers.c:
3386 (modest_server_account_get_option_secure_auth),
3387 (modest_server_account_set_option_secure_auth):
3388 * src/modest-account-mgr.c:
3389 (modest_account_mgr_add_server_account):
3390 Use the existing AUTH_MECH conf key for the secure-auth setting,
3391 instead of putting it in the list options, because this was actually used already.
3393 * src/maemo/modest-account-settings-dialog.c:
3394 (create_page_account_details),
3395 (modest_account_settings_dialog_set_account_name),
3396 (save_configuration):
3397 * src/maemo/modest-account-settings-dialog.h:
3398 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3399 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3401 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3403 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3404 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3405 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3407 * src/modest-defs.h:
3408 * src/maemo/modest-account-settings-dialog.c:
3409 (create_page_incoming), (on_combo_outgoing_security_changed),
3410 (on_combo_incoming_security_changed), (create_page_outgoing),
3411 (modest_account_settings_dialog_set_account_name),
3412 (save_configuration): Load/Save the port number, and change it when the
3413 security combo changes, to suitable defaults.
3415 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3417 * src/modest-account-mgr.c:
3418 (modest_account_mgr_add_server_account): Set the security and secure-auth
3419 options, and add a comment saying that the other camel-specific options should be
3422 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3424 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3426 * src/modest-tny-account-store.c: (account_list_free),
3427 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3428 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3431 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3433 * src/modest-protocol-info.c:
3434 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3435 is required by our UI spec. Maybe something in our implementation will use this eventually.
3436 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3437 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3438 instead of the previous 0 placeholder.
3440 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3441 secure-auth settings.
3442 * src/modest-account-mgr-helpers.h:
3443 * src/modest-account-mgr-helpers.c:
3444 (modest_server_account_data_get_option_secure_auth),
3445 (modest_server_account_set_option_secure_auth),
3446 (modest_server_account_data_get_option_security),
3447 (modest_server_account_set_option_security): Added this API for getting and setting the security
3448 and secure-auth settings.
3450 * src/maemo/modest-account-settings-dialog.h:
3451 * src/maemo/modest-account-settings-dialog.c:
3452 (modest_account_settings_dialog_finalize), (check_data),
3453 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3454 about changing titles.
3455 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3456 (save_configuration): Save the security and secure-auth settings.
3458 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3459 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3461 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3463 * src/modest-defs.h:
3464 * src/modest-account-mgr.c:
3465 (modest_account_mgr_add_server_account):
3466 Added and used defines for the options key and value pair strings,
3467 that are used so far, though they do not seem to correspond to anything in our
3468 UI specs or ModestProtocol enum.
3470 * src/modest-account-mgr-helpers.h:
3471 * src/modest-account-mgr-helpers.c:
3472 (compare_option_strings_for_name),
3473 (modest_server_account_data_get_option_value),
3474 (modest_server_account_data_get_option_bool),
3475 (modest_account_mgr_get_server_account_option):
3476 Added helper functions for parsing the options GSList.
3478 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3480 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3481 display name is based on the supplied account name.
3482 * src/modest-account-mgr.c:
3483 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3484 with an inefficient, but good-enough, implementation.
3486 * src/maemo/easysetup/modest-easysetup-wizard.c:
3487 (create_page_account_details), (on_before_next), (create_account):
3488 Check for existing display names rather than (non-user-visible) account names, and just
3489 create and set a unique account name at the end.
3491 * src/maemo/modest-account-settings-dialog.c:
3492 (modest_account_settings_dialog_init),
3493 (modest_account_settings_dialog_set_account_name),
3494 (create_page_incoming): Show the display name, instead of the account name.
3495 (on_response): Do some (not all) extra checks, as in the UI spec.
3496 (save_configuration): Save the display name if it was changed.
3498 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3500 * po/en_GB.po: Added needed logical ID and translation.
3501 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3502 (init_view): Made the is-default column clicking work.
3504 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3507 * src/maemo/easysetup/Makefile.am:
3508 * src/maemo/easysetup/modest-easysetup-wizard.c:
3509 (modest_easysetup_wizard_dialog_init):
3510 * src/maemo/easysetup/provider-data-test.keyfile:
3511 * src/maemo/easysetup/provider-data.keyfile:
3512 Moved the provider data file to the new modest-providers-data package and used it from there.
3514 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3516 * src/modest-local-folder-info.c:
3517 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3518 N_() was already used on the static strings, but this just marks it for translation without
3519 using the translation.
3521 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3523 * src/maemo/modest-account-settings-dialog.c:
3524 (create_page_incoming),
3525 (modest_account_settings_dialog_set_account_name):
3526 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3527 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3528 I will do this if nobody else gets there first.
3530 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3532 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3533 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3534 save the security stuff.
3536 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3538 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3539 Set the email address and user fullname, which I now see must be
3542 * src/maemo/modest-account-settings-dialog.h:
3543 * src/maemo/modest-account-settings-dialog.c:
3545 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3546 leave-on-server and authentication.
3547 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3550 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3553 * src/maemo/modest-account-settings-dialog.c:
3554 * src/maemo/modest-account-settings-dialog.h:
3555 Most (but not all) of the widgets are now present as specified by the UI spec.
3556 No changes are yet saved, and some details are not properly shown yet.
3558 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3560 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3562 * src/maemo/Makefile.am:
3563 * src/maemo/modest-account-settings-dialog.c:
3564 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3565 an existing account. Doesn't do much yet.
3567 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3568 Open the accounts settings dialog when Edit is clicked.
3570 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3572 * src/maemo/easysetup/Makefile.am:
3573 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3575 * src/maemo/easysetup/modest-easysetup-wizard.c:
3576 (modest_easysetup_wizard_dialog_init):
3577 Try to get the source directory from the build system,
3578 instead of hard-coding "./" into the source code, when opening our local
3579 copies of the configuration files.
3580 But this still fails when opening the wizard from the Accounts window,
3581 maybe because the working directory seems to change at runtime.
3582 So the wizard will fail the second time unless you copy the files into their
3583 proper locations - see the stdout warnings for the paths.
3585 (create_page_account_details),(on_before_next):
3586 Check for existing non-server accounts instead of server accounts,
3587 so the default account name is useful again, and to prevent trying to
3590 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3591 Show the wizard when New is clicked.
3593 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3594 (init_view): Show the column headers, and show the columns that are
3595 specified in the UI specs. However, something in Maemo's GTK+ prevents
3596 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3597 change the default account. This is despite unsetting the special properties.
3599 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3601 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3602 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3603 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3604 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3605 to make that clearer.
3606 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3608 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3610 * src/maemo/modest-account-view-window.c:
3611 (modest_account_view_window_init),
3612 (modest_account_view_window_new):
3613 Use the same buttons as specified in the
3614 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3615 the existing widgets, which never had a chance of working.
3616 Put the ModestAccountView treeview in a scrolled window.
3617 Do not repeat the initialization in both _init() and _new().
3619 * src/widgets/modest-account-view.c: (update_account_view):
3620 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3621 this widget and window shows no accounts.
3623 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3625 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3627 * src/maemo/easysetup/modest-easysetup-wizard.c:
3628 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3629 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3630 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3633 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3634 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3635 accounts exist yet, as in the UI spec.
3637 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3639 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3641 * src/maemo/Makefile.am:
3642 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3643 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3644 New window for editing connection-specific smtp details.
3645 Not fully implemented.
3647 * src/maemo/modest-connection-specific-smtp-window.c:
3648 (modest_connection_specific_smtp_window_finalize) :
3649 unref the tree model.
3650 (on_button_edit): Show the edit window.
3652 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3654 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3657 * src/maemo/Makefile.am:
3658 * src/maemo/modest-connection-specific-smtp-window.c:
3659 * src/maemo/modest-connection-specific-smtp-window.h:
3660 New window for showing the list of connections, for connection-specific
3661 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3662 * src/maemo/easysetup/modest-easysetup-wizard.c:
3663 (create_page_custom_outgoing): Show the new window when the button is clicked.
3665 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3668 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3669 * src/maemo/modest-msg-edit-window.c:
3670 (modest_msg_edit_window_insert_image):
3671 * src/modest-conf.c: (modest_conf_key_escape):
3672 * src/modest-mail-operation.c:
3673 (modest_mail_operation_send_new_mail):
3674 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3675 (modest_ui_actions_on_new_account):
3676 * src/widgets/modest-attachment-view.c: (update_filename_request):
3677 * src/widgets/modest-mail-header-view.c:
3678 Corrected warnings that were breaking the build, by commenting out unused variables,
3679 and a function, and by including a header.
3681 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3683 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3684 so we can #ifdef around platform-specific code when necessary.
3685 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3686 to allow this to build for the GNOME platform too.
3688 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3690 * src/maemo/easysetup/modest-easysetup-wizard.c:
3691 Added util_increment_name() and used it in create_page_account_details()
3692 to make sure that the default account name is always a new name.
3694 (modest_easysetup_wizard_dialog_init),
3695 (set_default_custom_servernames): Some minor memory management fixes.
3697 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3701 * src/modest-runtime.c: (init_i18n): Restored the translation
3702 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3703 are defined in config.h, and the translations are installed.
3705 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3706 is defined for translation.
3708 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3710 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3712 * src/maemo/easysetup/modest-easysetup-wizard.c:
3713 (modest_easysetup_wizard_dialog_init):
3714 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3715 Use realistic paths (though they should use $prefix generically) to the
3716 mcc_mapping and provider-data.keyfile files which might work when they
3717 are installed by the future version of the operator-wizard package,
3718 and then fallback to paths in our source code, with an explanatory
3721 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3725 * src/maemo/Makefile.am:
3726 * src/maemo/easysetup/: Added files from the previously-exernal
3727 osso-modest-easysetup.
3728 * src/maemo/modest-main-window-ui.h:
3729 * src/modest-ui-actions.c:
3730 * src/modest-ui-actions.h:
3731 Added modest_ui_actions_on_new_account() as a signal handler for the
3732 New Account menu item. It shows the easysetup wizard.
3733 * po/en_GB.po: Added additional needed logical IDs and translations.