git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/easysetup/modest-easysetup-wizard.c:
   4         * src/maemo/modest-connection-specific-smtp-edit-window.c:
   5         * src/widgets/modest-validating-entry.c:
   6         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
   7         Modest prefix instead of an EasySetup prefix.
   8
   9 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  10
  11         * src/widgets/modest-validating-entry.h:
  12         * src/widgets/modest-validating-entry.c: (on_insert_text),
  13         Added easysetup_validating_entry_set_max_func(), used to set a callback
  14         to call when the max number of characters is reached. GtkEntry has a max-length
  15         already but is silent about it.
  16
  17         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
  18         (create_page_account_details), (create_page_user_details),
  19         (create_account):
  20         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
  21         (create_page_account_details), (create_page_user_details),
  22         (create_page_outgoing):
  23         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
  24         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
  25         the UI spec, when the user tries to enter more than the max number of characters.
  26
  27 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  28
  29         * src/maemo/easysetup/modest-easysetup-wizard.c:
  30         (create_page_user_details), (create_page_custom_incoming),
  31         (create_page_custom_outgoing):
  32         * src/maemo/modest-account-settings-dialog.c:
  33         (create_page_user_details), (create_page_incoming),
  34         (create_page_outgoing):
  35         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  36         (modest_connection_specific_smtp_edit_window_init):
  37         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
  38         not appropriate. Bad Maemo-specific defaults!.
  39
  40 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  41
  42         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
  43         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
  44         (modest_signature_editor_dialog_set_settings):
  45         Disable the label and textview when the checkbox is disabled, and use the
  46         specified (UI spec) default signature text.
  47
  48 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  49
  50         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  51         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
  52
  53         * src/modest-defs.h:
  54         * src/modest-account-mgr-helpers.h:
  55         * src/modest-account-mgr-helpers.c:
  56         Added modest_account_mgr_get/set_signature(), using new gconf keys.
  57
  58         * src/maemo/Makefile.am:
  59         * src/maemo/modest-signature-editor-dialog.c:
  60         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
  61         as per the UI spec.
  62
  63         * src/maemo/modest-account-settings-dialog.h:
  64         * src/maemo/modest-account-settings-dialog.c:
  65         (modest_account_settings_dialog_finalize), (on_button_signature),
  66         (save_configuration): Use the new dialog when the Edit button is pressed, and
  67         save the changes if necessary, as per the UI spec.
  68
  69 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  70
  71         * src/maemo/Makefile.am:
  72         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
  73         based on maemo-develoers email from Dirk.
  74
  75         * src/maemo/easysetup/modest-easysetup-wizard.c:
  76         (create_page_welcome), (create_page_account_details),
  77         (create_page_user_details), (create_page_complete_easysetup),
  78         (create_page_custom_incoming), (create_page_custom_outgoing),
  79         (create_page_complete_custom),
  80         (modest_easysetup_wizard_dialog_init):
  81         * src/maemo/modest-account-settings-dialog.c:
  82         (create_page_account_details), (create_page_user_details),
  83         (create_page_incoming), (create_page_outgoing),
  84         (modest_account_settings_dialog_init):
  85         * src/maemo/modest-connection-specific-smtp-window.c:
  86         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
  87
  88 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  89
  90         * src/maemo/easysetup/modest-easysetup-wizard.c:
  91         (create_page_account_details), (create_page_custom_outgoing),
  92         (create_page_complete_custom):
  93         * src/maemo/modest-account-settings-dialog.c:
  94         (create_page_user_details), (create_page_incoming),
  95         (create_page_outgoing):
  96         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  97         (modest_connection_specific_smtp_edit_window_init):
  98         Use the correct (UI spec) port min/max, and use horizontal separators,
  99         as per the UI spec.
 100
 101 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 102
 103         * src/maemo/easysetup/modest-easysetup-wizard.c:
 104         (set_default_custom_servernames):
 105         * src/maemo/modest-account-settings-dialog.c:
 106         (create_page_incoming), (on_combo_outgoing_security_changed),
 107         (on_combo_incoming_security_changed), (create_page_outgoing),
 108         (modest_account_settings_dialog_set_account_name),
 109         (save_configuration):
 110         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 111         (on_combo_security_changed),
 112         (modest_connection_specific_smtp_edit_window_init),
 113         (modest_connection_specific_smtp_edit_window_set_connection),
 114         (modest_connection_specific_smtp_edit_window_get_settings):
 115         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 116         as per the UI spec.
 117
 118 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 119
 120         * po/en_GB.po:
 121         * src/maemo/easysetup/modest-easysetup-wizard.c:
 122         (create_page_custom_outgoing), (create_page_complete_custom):
 123         * src/maemo/modest-account-settings-dialog.c:
 124         (create_page_user_details), (create_page_outgoing):
 125         * src/maemo/modest-account-view-window.c: (button_box_new):
 126         Use changed logical IDs as per the most recent UI spec:
 127         mcen_bd_emailsetup_edit -> mcen_bd_edit
 128         mcen_bd_emailsetup_delete -> mcen_bd_delete
 129         mcen_bd_emailsetup_close -> mcen_bd_close
 130
 131 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 132
 133         * configure.ac:
 134         * src/Makefile.am:
 135         * src/dbus_api/Makefile.am:
 136         * src/dbus_api/modest-dbus-callbacks.c:
 137         * src/dbus_api/modest-dbus-callbacks.h:
 138         * src/maemo/modest-platform.c: (modest_platform_init):
 139         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 140         method.
 141         * tests/Makefile.am:
 142         * tests/dbus_api/Makefile.am:
 143         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 144
 145 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 146
 147         * src/maemo/modest-account-settings-dialog.c:
 148         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 149         Removed unnecessary includes.
 150
 151 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 152
 153         * src/maemo/easysetup/modest-easysetup-wizard.c:
 154         * src/maemo/modest-account-settings-dialog.c:
 155         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 156         * src/widgets/Makefile.am:
 157         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 158         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 159         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 160         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 161         * src/widgets/modest-secureauth-combo-box.c:
 162         * src/widgets/modest-secureauth-combo-box.h:
 163         * src/widgets/modest-serversecurity-combo-box.c:
 164         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 165         made the GObject names more consistent with the rest of the Modest code.
 166
 167 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 168
 169         * src/maemo/easysetup/Makefile.am:
 170         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 171         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 172         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 173         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 174         * src/maemo/easysetup/modest-easysetup-wizard.c:
 175         * src/maemo/easysetup/modest-validating-entry.c:
 176         * src/maemo/easysetup/modest-validating-entry.h:
 177         * src/maemo/modest-account-settings-dialog.c:
 178         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 179         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 180         widgets/ because they are used outside of easysetup too. After checking in,
 181         svn will allow me to rename them too.
 182
 183 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 184
 185         * src/gnome/modest-msg-edit-window.c:
 186         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 187         linker error, to fix the build on the GNOME platform.
 188         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 189         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 190         ifdefed out to avoid a warning.
 191
 192 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 193
 194         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 195         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 196         some alternative for GTK+ 2.6.
 197
 198 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 199
 200         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 201
 202         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 203         specified for EmailAccountsDialog in UI spec.
 204
 205         * src/maemo/easysetup/modest-easysetup-wizard.c:
 206         * src/maemo/easysetup/modest-easysetup-wizard.h:
 207         * src/maemo/modest-account-settings-dialog.c:
 208         * src/maemo/modest-account-settings-dialog.h:
 209         Reuse a member window widget for the connection-specific SMTP server accounts,
 210         so we can tell it to create/save the accounts only if we actually save changes.
 211
 212         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 213         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 214         (modest_connection_specific_smtp_edit_window_get_settings):
 215         Return a struct instance for temporarily remembering the entered data.
 216
 217         * src/maemo/modest-connection-specific-smtp-window.h:
 218         * src/maemo/modest-connection-specific-smtp-window.c:
 219         (modest_connection_specific_smtp_window_finalize),
 220         (modest_connection_specific_smtp_window_fill_with_connections),
 221         (on_button_edit),
 222         (modest_connection_specific_smtp_window_save_server_accounts),
 223         (update_model_server_names): Do not actually save data until asked,
 224         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 225
 226         (on_selection_changed),
 227         (modest_connection_specific_smtp_window_init): Disable the edit
 228         button when nothing is selected.
 229
 230         * src/modest-account-mgr-helpers.c:
 231         * src/modest-account-mgr-helpers.h:
 232         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 233         elsewhere.
 234
 235 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 236
 237         * src/modest-account-mgr-helpers.h:
 238         * src/modest-account-mgr-helpers.c:
 239         (modest_account_mgr_get_unused_account_name),
 240         (modest_account_mgr_get_unused_account_display_name): Added these
 241         utility functions, to avoid code duplication.
 242
 243         * src/maemo/easysetup/modest-easysetup-wizard.c:
 244         (create_page_account_details), (create_account):
 245         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 246         (on_combo_security_changed),
 247         (modest_connection_specific_smtp_edit_window_init),
 248         (modest_connection_specific_smtp_edit_window_save_settings):
 249         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 250         * src/maemo/modest-connection-specific-smtp-window.c:
 251         (modest_connection_specific_smtp_window_finalize),
 252         (modest_connection_specific_smtp_window_fill_with_connections),
 253         (on_button_edit), (modest_connection_specific_smtp_window_init):
 254         * src/maemo/modest-connection-specific-smtp-window.h:
 255         Implementing saving of connection-specific server accounts.
 256
 257         But I need to refactor this so we can save the data for each
 258         possible connection-specific account and only actually create the server accounts
 259         when the easysetup finished, or the OK button is pressed on the account settings
 260         dialog.
 261
 262 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 263
 264         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 265         (on_combo_security_changed):
 266         (modest_connection_specific_smtp_edit_window_init):
 267         Auto-fill the port number as in the account settings.
 268
 269         (modest_connection_specific_smtp_edit_window_set_connection):
 270         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 271         * src/maemo/modest-connection-specific-smtp-window.c:
 272         (fill_with_connections), (on_button_edit),
 273         (modest_connection_specific_smtp_window_init):
 274         Turn the edit window into a dialog to simplify the code, and
 275         set a WM hint as in a GtkDialog, because only a popup can be on top of
 276         another window in Maemo, and popups usually have no WM decoration.
 277
 278         * src/modest-defs.h:
 279         * src/modest-account-mgr-helpers.c:
 280         (modest_account_mgr_set_connection_specific_smtp),
 281         (modest_account_mgr_remove_connection_specific_smtp),
 282         (modest_account_mgr_get_connection_specific_smtp):
 283         * src/modest-account-mgr-helpers.h: Some functions to write the
 284         connection-specific SMTP server information. Not yet used.
 285
 286
 287         * src/widgets/modest-folder-view.c: (text_cell_data):
 288         Fix a warning about an uninitialized variable.
 289         (on_configuration_key_changed): Put an #ifdef around the use
 290         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 291
 292 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 293
 294         * src/maemo/modest-account-settings-dialog.h:
 295         * src/maemo/modest-account-settings-dialog.c:
 296         Added connect_for_modified() utility function to mark the new modified boolean.
 297
 298         (create_page_account_details), (create_page_user_details),
 299         (create_page_incoming), (create_page_outgoing), (on_response),
 300         (modest_account_settings_dialog_init),
 301         (modest_account_settings_dialog_set_account_name):
 302         Only warn about unsaved changes when there are actually unsaved changes.
 303
 304         * src/modest-account-mgr-helpers.c:
 305         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 306         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 307         to get the data from there in future.
 308
 309 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 310
 311         * src/modest-defs.h:
 312
 313         * src/modest-account-mgr-helpers.h:
 314         * src/modest-account-mgr-helpers.c:
 315         Store the security account setting in a single conf key instead of using
 316         the options list, so that the list is left for just the to-be-removed camel hack,
 317         and because gconf_client_set_list() is failing for some reason.
 318
 319         * src/modest-account-mgr.c:
 320         (modest_account_mgr_add_server_account):
 321         * src/maemo/modest-account-settings-dialog.c:
 322         (modest_account_settings_dialog_set_account_name),
 323         (save_configuration): Use the renamed functions.
 324
 325
 326 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 327
 328         * src/widgets/Makefile.am:
 329         * src/widgets/modest-limit-retrieve-combo-box.c:
 330         * src/widgets/modest-limit-retrieve-combo-box.h:
 331         * src/widgets/modest-retrieve-combo-box.c:
 332         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 333         the account settings dialog.
 334
 335         * src/modest-defs.h:
 336         * src/modest-account-mgr-helpers.h:
 337         * src/modest-account-mgr-helpers.c:
 338         (modest_server_account_get_option_secure_auth),
 339         (modest_server_account_set_option_secure_auth):
 340         * src/modest-account-mgr.c:
 341         (modest_account_mgr_add_server_account):
 342         Use the existing AUTH_MECH conf key for the secure-auth setting,
 343         instead of putting it in the list options, because this was actually used already.
 344
 345         * src/maemo/modest-account-settings-dialog.c:
 346         (create_page_account_details),
 347         (modest_account_settings_dialog_set_account_name),
 348         (save_configuration):
 349         * src/maemo/modest-account-settings-dialog.h:
 350         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 351         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 352
 353 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 354
 355         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 356         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 357         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 358
 359         * src/modest-defs.h:
 360         * src/maemo/modest-account-settings-dialog.c:
 361         (create_page_incoming), (on_combo_outgoing_security_changed),
 362         (on_combo_incoming_security_changed), (create_page_outgoing),
 363         (modest_account_settings_dialog_set_account_name),
 364         (save_configuration): Load/Save the port number, and change it when the
 365         security combo changes, to suitable defaults.
 366
 367 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 368
 369         * src/modest-account-mgr.c:
 370         (modest_account_mgr_add_server_account): Set the security and secure-auth
 371         options, and add a comment saying that the other camel-specific options should be
 372         removed in future.
 373
 374 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 375
 376         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 377         found by valgrind.
 378         * src/modest-tny-account-store.c: (account_list_free),
 379         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 380         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 381         easy to fix.
 382
 383 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 384
 385         * src/modest-protocol-info.c:
 386         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 387         is required by our UI spec. Maybe something in our implementation will use this eventually.
 388         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 389         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 390         instead of the previous 0 placeholder.
 391
 392         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 393         secure-auth settings.
 394         * src/modest-account-mgr-helpers.h:
 395         * src/modest-account-mgr-helpers.c:
 396         (modest_server_account_data_get_option_secure_auth),
 397         (modest_server_account_set_option_secure_auth),
 398         (modest_server_account_data_get_option_security),
 399         (modest_server_account_set_option_security): Added this API for getting and setting the security
 400         and secure-auth settings.
 401
 402         * src/maemo/modest-account-settings-dialog.h:
 403         * src/maemo/modest-account-settings-dialog.c:
 404         (modest_account_settings_dialog_finalize), (check_data),
 405         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 406         about changing titles.
 407         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 408         (save_configuration): Save the security and secure-auth settings.
 409
 410         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 411         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 412
 413 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 414
 415         * src/modest-defs.h:
 416         * src/modest-account-mgr.c:
 417         (modest_account_mgr_add_server_account):
 418         Added and used defines for the options key and value pair strings,
 419         that are used so far, though they do not seem to correspond to anything in our
 420         UI specs or ModestProtocol enum.
 421
 422         * src/modest-account-mgr-helpers.h:
 423         * src/modest-account-mgr-helpers.c:
 424         (compare_option_strings_for_name),
 425         (modest_server_account_data_get_option_value),
 426         (modest_server_account_data_get_option_bool),
 427         (modest_account_mgr_get_server_account_option):
 428         Added helper functions for parsing the options GSList.
 429
 430 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 431
 432         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 433         display name is based on the supplied account name.
 434         * src/modest-account-mgr.c:
 435         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 436         with an inefficient, but good-enough, implementation.
 437
 438         * src/maemo/easysetup/modest-easysetup-wizard.c:
 439         (create_page_account_details), (on_before_next), (create_account):
 440         Check for existing display names rather than (non-user-visible) account names, and just
 441         create and set a unique account name at the end.
 442
 443         * src/maemo/modest-account-settings-dialog.c:
 444         (modest_account_settings_dialog_init),
 445         (modest_account_settings_dialog_set_account_name),
 446         (create_page_incoming): Show the display name, instead of the account name.
 447         (on_response): Do some (not all) extra checks, as in the UI spec.
 448         (save_configuration): Save the display name if it was changed.
 449
 450 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 451
 452         * po/en_GB.po: Added needed logical ID and translation.
 453         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 454         (init_view): Made the is-default column clicking work.
 455
 456 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 457
 458         * configure.ac:
 459         * src/maemo/easysetup/Makefile.am:
 460         * src/maemo/easysetup/modest-easysetup-wizard.c:
 461         (modest_easysetup_wizard_dialog_init):
 462         * src/maemo/easysetup/provider-data-test.keyfile:
 463         * src/maemo/easysetup/provider-data.keyfile:
 464         Moved the provider data file to the new modest-providers-data package and used it from there.
 465
 466 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 467
 468         * src/modest-local-folder-info.c:
 469         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 470         N_() was already used on the static strings, but this just marks it for translation without
 471         using the translation.
 472
 473 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 474
 475         * src/maemo/modest-account-settings-dialog.c:
 476         (create_page_incoming),
 477         (modest_account_settings_dialog_set_account_name):
 478         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 479         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 480         I will do this if nobody else gets there first.
 481
 482 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 483
 484         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 485         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 486         save the security stuff.
 487
 488 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 489
 490         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 491         Set the email address and user fullname, which I now see must be
 492         done separately.
 493
 494         * src/maemo/modest-account-settings-dialog.h:
 495         * src/maemo/modest-account-settings-dialog.c:
 496          (on_response),
 497         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 498         leave-on-server and authentication.
 499         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 500         how to do the rest.
 501
 502 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 503
 504
 505         * src/maemo/modest-account-settings-dialog.c:
 506         * src/maemo/modest-account-settings-dialog.h:
 507         Most (but not all) of the widgets are now present as specified by the UI spec.
 508         No changes are yet saved, and some details are not properly shown yet.
 509
 510         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 511
 512 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 513
 514         * src/maemo/Makefile.am:
 515         * src/maemo/modest-account-settings-dialog.c:
 516         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 517         an existing account. Doesn't do much yet.
 518
 519         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 520         Open the accounts settings dialog when Edit is clicked.
 521
 522 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 523
 524         * src/maemo/easysetup/Makefile.am:
 525         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 526         (load_from_file):
 527         * src/maemo/easysetup/modest-easysetup-wizard.c:
 528         (modest_easysetup_wizard_dialog_init):
 529         Try to get the source directory from the build system,
 530         instead of hard-coding "./" into the source code, when opening our local
 531         copies of the configuration files.
 532         But this still fails when opening the wizard from the Accounts window,
 533         maybe because the working directory seems to change at runtime.
 534         So the wizard will fail the second time unless you copy the files into their
 535         proper locations - see the stdout warnings for the paths.
 536
 537         (create_page_account_details),(on_before_next):
 538         Check for existing non-server accounts instead of server accounts,
 539         so the default account name is useful again, and to prevent trying to
 540         recreate accounts.
 541
 542         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 543         Show the wizard when New is clicked.
 544
 545         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 546         (init_view): Show the column headers, and show the columns that are
 547         specified in the UI specs. However, something in Maemo's GTK+ prevents
 548         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 549         change the default account. This is despite unsetting the special properties.
 550
 551 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 552
 553         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 554         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 555         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 556         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 557         to make that clearer.
 558         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 559
 560 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 561
 562         * src/maemo/modest-account-view-window.c:
 563         (modest_account_view_window_init),
 564         (modest_account_view_window_new):
 565         Use the same buttons as specified in the
 566         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 567         the existing widgets, which never had a chance of working.
 568         Put the ModestAccountView treeview in a scrolled window.
 569         Do not repeat the initialization in both _init() and _new().
 570
 571         * src/widgets/modest-account-view.c: (update_account_view):
 572         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 573         this widget and window shows no accounts.
 574
 575         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 576
 577 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 578
 579         * src/maemo/easysetup/modest-easysetup-wizard.c:
 580         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 581         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 582         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 583         which seems wrong.
 584
 585         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 586         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 587         accounts exist yet, as in the UI spec.
 588
 589         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 590
 591 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 592
 593         * src/maemo/Makefile.am:
 594         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 595         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 596         New window for editing connection-specific smtp details.
 597         Not fully implemented.
 598
 599         * src/maemo/modest-connection-specific-smtp-window.c:
 600         (modest_connection_specific_smtp_window_finalize) :
 601         unref the tree model.
 602         (on_button_edit): Show the edit window.
 603
 604 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 605
 606         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 607         error for me.
 608
 609         * src/maemo/Makefile.am:
 610         * src/maemo/modest-connection-specific-smtp-window.c:
 611         * src/maemo/modest-connection-specific-smtp-window.h:
 612         New window for showing the list of connections, for connection-specific
 613         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 614         * src/maemo/easysetup/modest-easysetup-wizard.c:
 615         (create_page_custom_outgoing): Show the new window when the button is clicked.
 616
 617 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 618
 619         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 620         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 621         * src/maemo/modest-msg-edit-window.c:
 622         (modest_msg_edit_window_insert_image):
 623         * src/modest-conf.c: (modest_conf_key_escape):
 624         * src/modest-mail-operation.c:
 625         (modest_mail_operation_send_new_mail):
 626         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 627         (modest_ui_actions_on_new_account):
 628         * src/widgets/modest-attachment-view.c: (update_filename_request):
 629         * src/widgets/modest-mail-header-view.c:
 630         Corrected warnings that were breaking the build, by commenting out unused variables,
 631         and a function, and by including a header.
 632
 633 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 634
 635         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 636         so we can #ifdef around platform-specific code when necessary.
 637         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 638         to allow this to build for the GNOME platform too.
 639
 640 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 641
 642         * src/maemo/easysetup/modest-easysetup-wizard.c:
 643         Added util_increment_name() and used it in create_page_account_details()
 644         to make sure that the default account name is always a new name.
 645
 646         (modest_easysetup_wizard_dialog_init),
 647         (set_default_custom_servernames): Some minor memory management fixes.
 648
 649 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 650
 651         * Makefile.am:
 652         * configure.ac:
 653         * src/modest-runtime.c: (init_i18n): Restored the translation
 654         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 655         are defined in config.h, and the translations are installed.
 656
 657         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 658         is defined for translation.
 659
 660 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 661
 662         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 663         (load_from_file):
 664         * src/maemo/easysetup/modest-easysetup-wizard.c:
 665         (modest_easysetup_wizard_dialog_init):
 666         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 667         Use realistic paths (though they should use $prefix generically) to the
 668         mcc_mapping and provider-data.keyfile files which might work when they
 669         are installed by the future version of the operator-wizard package,
 670         and then fallback to paths in our source code, with an explanatory
 671         warning.
 672
 673 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 674
 675         * configure.ac:
 676         * src/Makefile.am:
 677         * src/maemo/Makefile.am:
 678         * src/maemo/easysetup/: Added files from the previously-exernal
 679         osso-modest-easysetup.
 680         * src/maemo/modest-main-window-ui.h:
 681         * src/modest-ui-actions.c:
 682         * src/modest-ui-actions.h:
 683         Added modest_ui_actions_on_new_account() as a signal handler for the
 684         New Account menu item. It shows the easysetup wizard.
 685         * po/en_GB.po: Added additional needed logical IDs and translations.
 686
 687 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 688 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 689