1 2007-07-10 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (on_idle_wrong_password):
4 A compilation fix, though the build wasn't broken for me.
6 2007-07-09 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
9 Do not try to unref a NULL folder store, to avoid a runtime warning.
10 This seems to happen sometimes when changing accounts settings.
12 2007-07-09 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-tny-account-store.c:
15 (modest_tny_account_store_instance_init),
16 (modest_tny_account_store_finalize),
17 (on_account_settings_hide), (on_idle_wrong_password):
18 Use a GHashTable to ensure that we only show one account settings
19 dialog per modest account. This avoids us having a dialog open for
20 both the store and transport accounts, or due to repeated get_password()
21 calls that shouldn't happen anyway.
23 2007-07-09 Murray Cumming <murrayc@murrayc.com>
25 * src/maemo/modest-maemo-utils.c: (on_hide),
26 (modest_maemo_show_dialog_and_forget): Handle the response, because
27 the window is not even hidden by default.
29 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
30 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
31 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
32 which seems to prevent some modality problems.
34 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
35 Ignore user cancellation errors.
37 * src/modest-account-mgr-helpers.h:
38 * src/modest-account-mgr-helpers.c:
39 Added modest_server_account_get_password() and
40 modest_server_account_get_has_password() to avoid direct use of
43 * src/maemo/modest-account-settings-dialog.h:
44 * src/maemo/modest-account-settings-dialog.c:
45 (modest_account_settings_dialog_init): Store the notebook so we can
47 Added modest_account_settings_dialog_switch_to_user_info().
49 * src/modest-tny-account-store.c:
50 (get_password): When the password in the account settings is wrong (we think),
51 show the relevant page of the account settings dialog, in the mainloop.
52 However, we currently get many of these at once because cancel does not
54 (forget_password): Do not forget the password
55 from the account settings, because this causes side-effects when
56 tinymail seems to call it at strange time, maybe because of how we
57 are cancelling get_password().
58 (modest_tny_account_store_alert): Ignore user cancellations.
60 2007-07-09 Murray Cumming <murrayc@murrayc.com>
62 * src/maemo/modest-maemo-utils.h:
63 * src/maemo/modest-maemo-utils.c:
64 Added modest_maemo_show_information_note_and_forget() for use instead of
65 gtk_dialog_run() when the response is not needed, to avoid an extra
66 mainloop which could cause a hang.
68 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
69 Use the logical IDs for the error message, though they are not
70 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
71 because gtk_dialog_run() caused a hang here (the window did not close).
72 This fixes projects.maemo.org bug NB#62646.
74 2007-07-09 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-account-mgr-helpers.h:
77 * src/modest-account-mgr-helpers.c:
78 Added modest_account_mgr_get_store_protocol().
80 * src/maemo/modest-account-view-window.c:
81 (on_delete_button_clicked): Show different warning text depending on
82 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
83 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
86 2007-07-09 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/modest-msg-edit-window.c:
89 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
90 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
92 2007-07-07 Armin Burgmeier <armin@openismus.com>
94 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
95 ckdg_ib_maximum_characters_reached from correct package.
97 * src/modest-ui-actions.c: Show an error message when a folder could
98 not be created. Tinymail does not give us specific error codes about
99 what has gone wrong, so we assume that a folder with that name
100 already exists, though there might be other reasons.
102 2007-07-06 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
105 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
106 give a more exact error message that can be partly translated.
108 2007-07-05 Murray Cumming <murrayc@murrayc.com>
110 * src/maemo/modest-address-book.c:
111 (select_email_addrs_for_contact): Specify a default window size for the
112 select-email-address dialog, so that it is probably big enough for the
113 title. This should fix projects.maemo.org bug NB#62277.
115 2007-07-05 Murray Cumming <murrayc@murrayc.com>
117 * src/maemo/easysetup/modest-easysetup-wizard.c:
118 (create_page_complete_easysetup): Use
119 gtk_widget_set_size() request to ensure that the text wraps
122 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
124 * src/maemo/easysetup/modest-easysetup-wizard.c:
125 (on_entry_invalid_character), (create_page_account_details),
126 (create_page_user_details):
127 Use new API of ModestValidatingEntry. But for some reason the banner is
128 not shown. I will have to investigate that further.
130 * src/widgets/modest-validating-entry.c: (on_insert_text),
131 (modest_validating_entry_set_func):
132 * src/widgets/modest-validating-entry.h:
133 Added a new callback function to be able to react to prevented
134 characters whitespaces to e.g show a banner.
136 2007-07-05 Armin Burgmeier <armin@openismus.com>
138 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
139 notification of HildonNumberEditor instead of remembering the port
140 number. Thanks to Johannes for pointing this out.
142 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
144 * src/maemo/easysetup/modest-easysetup-wizard.c:
145 Check if there are any user changes before showing a confirmation
146 dialog (projects.maemo.org NB#60946)
148 2007-07-05 Armin Burgmeier <armin@openismus.com>
150 * src/maemo/modest-account-settings-dialog.c: Remember custom port
151 number at the beginning of the dialog and set the modified flag at the
152 end if the port number has changed. This is necessary because
153 HildonNumberEditor does not support notification when the value has
156 2007-07-05 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-ui-actions.c:
159 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
160 a connection before asking anything else. Correct the check for the destination
161 folder so that it succeeds when online.
162 This fixed projects.maemo.org bug NB#61645.
164 2007-07-05 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
167 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
168 to fix projects.maemo.org bug NB#62439.
170 2007-07-05 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account.c: (on_connection_status_changed):
173 Really do not use tny_device_force_offline() here. See the previous comment.
175 2007-07-04 Murray Cumming <murrayc@murrayc.com>
177 * src/modest-tny-account.c: (on_connection_status_changed):
178 Do not use tny_device_force_offline() when tinymail says that something
179 went wrong with the connection. It seems to report this unnecessarily.
181 2007-07-04 Murray Cumming <murrayc@murrayc.com>
183 * src/maemo/modest-connection-specific-smtp-window.c:
184 (modest_connection_specific_smtp_window_init):
185 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
186 does not seem to have any effect in osso 1.1 (though it works in
187 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
189 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
191 * src/maemo/modest-connection-specific-smtp-window.c:
192 Fix UI specification problems with projects.meamo.org NB#60479
194 2007-07-04 Murray Cumming <murrayc@murrayc.com>
196 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
197 clue when this has failed, because the error dialog is not always shown
198 (at least in earlier version).
200 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
201 GError message, because the generic error dialog is not helpful.
203 'This message is not currently available (can't let a new connection go online)'
204 when trying to open an IMAP message.
206 (_modest_ui_actions_open): Offer a connection when some messages would
207 have to be downloaded and we are offline.
209 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
211 * src/widgets/modest-folder-view.c:
212 Don't check for MERGE type anymore as we use the correct type
214 NOTE: For the last two changes you need to update your tinymail copy
215 because of API changes!
217 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
219 * src/modest-tny-local-folders-account.c:
220 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
221 (see projects.maemo.org NB#61580)
223 2007-07-04 Murray Cumming <murrayc@murrayc.com>
225 * src/modest-tny-account.c: (on_connection_status_changed):
226 Commented out the call to modest_platform_connect_and_wait() because this
227 seems to always hang, and I would like to know if this is the only thing
228 that causes a hang when showing the connection dialog.
229 It is not very useful anyway.
231 2007-07-04 Murray Cumming <murrayc@murrayc.com>
233 * src/maemo/modest-msg-view-window.c:
234 (modest_msg_view_window_select_next_message):
236 * src/modest-platform.h:
237 * src/maemo/modest-platform.c:
238 Added modest_platform_connect_and_wait(), which calls
239 tny_maemo_conic_device_connect() always in the main thread, by calling it
240 in an idle handler and waiting for the idle handler to run. It should be
241 in the main thread because it uses GTK+ UI code. It just returns TRUE
242 if the device is already online.
244 There is some nasty code to ensure that subsequent calls to
245 modest_platform_connect_and_wait() just wait for the first one to finish,
246 by checking repeatedly in another idle handler. This is necessary,
247 because other threads (or even the main thread, via another idle handler)
248 can call modest_platform_connect_and_wait() while
249 modest_platform_connect_and_wait() is running.
251 (modest_platform_connect_and_wait_if_network_account),
252 (modest_platform_connect_and_wait_if_network_folderstore):
253 Convenience functions that calls modest_platform_connect_and_wait() if
254 the account or folder might want network access.
256 * src/modest-mail-operation.c:
257 (modest_mail_operation_update_account):
258 * src/modest-ui-actions.c: (download_uncached_messages),
259 (modest_ui_actions_on_rename_folder), (delete_folder),
260 (modest_ui_actions_on_main_window_move_to),
261 (modest_ui_actions_on_msg_view_window_move_to):
262 * src/widgets/modest-folder-view.c:
263 (drag_and_drop_from_folder_view):
264 Offer a connection if we are offline.
266 * src/modest-tny-account.c: (on_connection_status_changed):
267 Document this as only handling errors during network operations in progress,
268 and replace the idle code with a simple call to
269 modest_platform_connect_and_wait(), which does this instead.
271 2007-07-03 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-account.c:
274 (modest_tny_account_get_special_folder): (util_on_idle),
275 Handle the GError so we can see when tny_folder_store_get_folders()
276 fails, as it currently does while something else is connecting.
278 Added util_run_in_main_thread_and_wait()
279 which uses an idlen handler and mainloop to ensure that the function
280 is called in the main thread.
281 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
282 to make sure that we call attempt the connection in the mainloop only,
283 which might solve some hangs.
285 2007-07-03 Murray Cumming <murrayc@murrayc.com>
287 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
288 be found by their display name. This is never useful.
289 * src/modest-tny-account-store.c: (on_account_removed): Find the account
290 by its ID, instead of trying to use its ID as its display name.
292 * src/modest-tny-account-store.h:
293 * src/modest-tny-account.c:
294 (modest_tny_account_get_special_folder): Add a g_warning() when
295 tny_folder_store_get_folders() returns an empty list for the maildir.
297 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
298 Add a g_warning() when this returns NULL, because that it not allowed
301 2007-07-02 Armin Burgmeier <armin@openismus.com>
303 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
304 note when trying to cancel the wizard. This fixes projects.maemo.org
307 2007-07-02 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-tny-account.h:
310 * src/modest-tny-account.c:
311 (modest_tny_account_new_from_server_account),
312 (modest_tny_account_new_from_server_account_name),
313 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
314 because this must now be set before setting the proto. This is usd in
315 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
316 warning in camel_session_get_service() caused by
317 tny_camel_transport_account_prepare().
319 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
322 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
324 * src/maemo/modest-connection-specific-smtp-edit-window.c:
326 (modest_connection_specific_smtp_edit_window_init):
328 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
331 2007-06-29 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-account.c:
334 (modest_tny_account_new_from_server_account):
335 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
336 now uses to request a connection when it needs one, and which it uses
337 to tell us that something is wrong with the connection, so we can force
338 the accounts offline to prevent further problems.
341 * src/modest-init.c: (init_default_settings):
342 * src/modest-mail-operation.c:
343 (modest_mail_operation_update_account):
344 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
345 This should not be necessary anymore. Do not set the conf key that
346 determined this (it was always TRUE and not set anywhere else).
348 * src/modest-ui-actions.h: Remove unused and unimplemented
349 modest_ui_actions_on_online_toggle_toggled().
351 2007-06-29 Murray Cumming <murrayc@murrayc.com
353 * src/maemo/modest-main-window.c: (connect_signals):
354 Don't connect to delete_event twice. Maybe this was harmless.
356 2007-06-29 Murray Cumming <murrayc@murrayc.com
358 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
359 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
360 Debug output to give some more clue when a folder move is not allowed.
362 2007-06-28 Murray Cumming <murrayc@murrayc.com
364 * src/modest-tny-account.c: (on_modest_file_system_info),
365 (modest_tny_account_get_mmc_account_name):
366 Always call the callback, without checking whether the name has changed.
367 * src/widgets/modest-folder-view.c: (strings_are_equal),
368 (on_model_foreach_set_name), (on_get_mmc_account_name),
369 (text_cell_data): Compare the name here, and use the name from
370 the account rather than from the
371 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
372 if the name was changed after the account was added to the model.
373 That's a tinymail bug but not one that I want to fix now.
375 This finally fixes projects.maemo.org bug NB#59301.
377 2007-06-27 Armin Burgmeier <armin@openismus.com>
379 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
382 2007-06-27 Murray Cumming <murrayc@murrayc.com
384 * src/modest-tny-account.h:
385 * src/modest-tny-account.c:
386 Added modest_tny_account_get_mmc_account_name(), to set the memory
387 card name asynchronously for the given account and then notify.
388 (modest_tny_account_new_for_local_folders): Use this new function instead
389 of using hildon_file_system_info_async_new() directly.
391 * src/widgets/modest-folder-view.c: (text_cell_data):
392 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
393 gtk_tree_model_row_changed() when it is available.
395 This should fix projects.maemo.org bug NB#59301.
397 2007-06-27 Murray Cumming <murrayc@murrayc.com
399 * src/modest-mail-operation.c: (update_account_thread),
400 (get_msgs_full_thread): Fix typo failures in the revert
403 2007-06-27 Murray Cumming <murrayc@murrayc.com
405 * src/maemo/modest-maemo-global-settings-dialog.c:
406 (idle_select_default_focus):
407 * src/modest-mail-operation.c: (idle_notify_progress),
408 (idle_notify_progress_once), (set_last_updated_idle),
409 (update_account_thread), (get_msgs_full_thread):
410 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
411 * src/widgets/modest-header-view.c:
412 (idle_notify_headers_count_changed_destroy),
413 (idle_notify_headers_count_changed):
414 Reverted the additions of gdk_threads_enter/leave(), in case this
415 helps with a startup hang on the device.
417 2007-06-26 Armin Burgmeier <armin@openismus.com>
419 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
420 for supported secure authentication methods from server by
421 gtk_dialog_run(), saving CPU time and a potential race condition.
423 2007-06-26 Armin Burgmeier <armin@openismus.com>
425 * src/maemo/modest-maemo-utils.h:
426 * src/maemo/modest-maemo-utils.c: Added a
427 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
428 only error code to tell the calling code when the user canceled the
431 * src/maemo/modest-account-settings-dialog.h:
432 * src/maemo/modest-account-settings-dialog.c:
433 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
434 message if the retrieval of secure authentication methods was canceled
435 by the user. Perform the check before saving anything to configuration
436 to not end up with half-committed configuration changes, do not show
437 a "Saving to configuration failed" note when authentication methods
438 could not be retrieved.
440 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
443 2007-06-26 Murray Cumming <murrayc@murrayc.com>
445 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
446 Only return the first level of folders under accounts, because the
447 osso-global-search UI spec doesn't want the rest.
448 This fixed projects.maemo.org bug NB#61811.
450 2007-06-26 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-tny-account-store.c:
453 * src/modest-tny-account-store.h:
454 Added modest_tny_account_is_memory_card_account().
455 * src/maemo/modest-main-window.c: (create_details_widget):
456 Show the same information items for the memory card as we show for the
457 local-folders, to fix projects.maemo.org bug NB#59307.
459 2007-06-26 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-tny-account-store.c: (get_password):
462 Added some checks for NULL to maybe prevent crashes, though I think
463 it was Philip's last commit that actually prevented the crash here
464 when creating a first new account.
465 But the new account is still not usable (no messages are shown)
466 until a restart of the application.
468 2007-06-26 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/modest-maemo-global-settings-dialog.c:
471 (idle_select_default_focus):
472 * src/modest-mail-operation.c: (idle_notify_progress),
473 (idle_notify_progress_once), (idle_notify_update_account_queue),
474 (set_last_updated_idle), (update_account_thread),
475 (notify_get_msgs_full), (get_msgs_full_destroyer),
476 (get_msgs_full_thread):
477 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
478 * src/widgets/modest-header-view.c:
479 (idle_notify_headers_count_changed_destroy),
480 (idle_notify_headers_count_changed):
481 Use gdk_threads_enter() and gdk_threads_enter_leave() in
482 all idle handlers, because some other thread could be blocking
483 the GDK lock, so that it can do GUI stuff.
485 2007-06-26 Murray Cumming <murrayc@murrayc.com>
487 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
488 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
489 (on_idle_send_receive), (on_idle_open_default_inbox):
490 * src/maemo/modest-msg-edit-window.c:
491 (modest_msg_edit_window_attach_file_noninteractive):
492 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
493 to prevent a hang. I don't quite understand why these are necessary,
494 beause we should already be in the main loop. I guess something outside
495 of the main loop is taking the lock.
497 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
498 we are really using URIs, and use files that are more likely to exist.
500 2007-06-26 Murray Cumming <murrayc@murrayc.com>
502 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
503 necessary because configure.ac now defines different variables.
505 2007-06-26 Murray Cumming <murrayc@murrayc.com>
507 * libmodest-dbus-client/libmodest-dbus-client.c:
508 * libmodest-dbus-client/libmodest-dbus-client.h:
509 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
510 libmodest_dbus_client_compose_mail() is what things actually use.
512 * src/dbus_api/modest-dbus-api.h:
513 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
514 * tests/dbus_api/Makefile.am:
515 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
518 2007-06-26 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-init.c: (modest_init_local_folders):
521 For memory-card (or other non local-folders) maildir accounts,
522 always create an Archive folder, so that there is somewhere to put
523 messages. This should be less confusing, because the user does not need
524 to guess that the need to create a folder.
526 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
528 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
529 Fixed icon size by using (50, 50) which is the same as defined by
532 2007-06-25 Armin Burgmeier <armin@openismus.com>
534 * src/widgets/modest-window-mgr.c:
536 * configure.ac: Correctly recognize hildon-notify presence and fixed
537 the build without it being installed.
539 2007-06-25 Murray Cumming <murrayc@murrayc.com>
541 * libmodest-dbus-client/libmodest-dbus-client.c:
542 (libmodest_dbus_client_search): Fix the build. Sorry.
543 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
544 (reply_forward_cb): Initialize variables to fix the build.
546 * src/modest-tny-account-store.c:
547 (modest_tny_account_store_get_tny_account_by): Fix the account URI
548 comparison (a silly typo) so that email search results can be opened
549 when there are more than one account.
551 2007-06-25 Murray Cumming <murrayc@murrayc.com>
553 * libmodest-dbus-client/libmodest-dbus-client.c:
554 (libmodest_dbus_client_search),
555 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
556 instead of 1 second, because the search gets folders and messages from
557 the server, which can take a long time. When it times out,
558 osso-global-search will report no results.
560 We need to specify whether we should search only cached information
561 (maybe with a user preference), and the osso-email-search-plugin
562 API should really be improved to allow that option, and to allow results
563 to be delivered asynchronously in batches.
565 2007-06-25 Murray Cumming <murrayc@murrayc.com>
567 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
568 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
569 GTK_ICON_SIZE_DIALOG is probably the wrong size.
571 2007-06-25 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
574 that is an empty string. D-Bus seems to give us these instead of NULL.
576 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
578 * src/dbus_api/modest-dbus-callbacks.c:
579 * src/maemo/easysetup/modest-easysetup-wizard.h:
580 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
581 * src/maemo/modest-connection-specific-smtp-edit-window.c:
582 (modest_connection_specific_smtp_edit_window_init):
583 * src/maemo/modest-maemo-global-settings-dialog.c:
585 * src/maemo/modest-maemo-utils.c:
586 (modest_maemo_utils_setup_images_filechooser):
587 * src/maemo/modest-main-window.c: (create_details_widget):
588 * src/maemo/modest-msg-edit-window.c:
589 (modest_msg_edit_window_attach_file_noninteractive),
590 (modest_msg_edit_window_color_button_change),
591 (modest_msg_edit_window_set_zoom):
592 * src/modest-mail-operation.c: (update_account_thread):
593 * src/modest-tny-account-store.c:
594 * src/modest-tny-account.c:
595 * src/widgets/modest-global-settings-dialog.c:
596 * src/widgets/modest-window.h:
600 2007-06-25 Murray Cumming <murrayc@murrayc.com>
602 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
603 * src/modest-search.c: (modest_search_folder),
604 (modest_search_all_accounts): Actually search only in the specified folder,
605 doing a simple match on the folder ID.
606 * src/modest-search.h: Added a folder field to the ModestSearch struct,
607 and added some documentation.
609 2007-06-22 Armin Burgmeier <armin@openismus.com>
611 * src/maemo/modest-maemo-utils.h:
612 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
613 modest_maemo_utils_get_supported_secure_authentication_methods.
615 * src/maemo/easysetup/modest-easysetup-wizard.c:
616 * src/maemo/modest-account-settings-dialog.c: Show correct error if
617 one occured, not just "Server does not support secure authentication".
619 2007-06-22 Murray Cumming <murrayc@murrayc.com>
621 * src/modest-tny-account-store.c: (get_password):
622 Restored the call to tny_account_set_user() because Philip seems to have
623 stopped this from crashing (by not using the freed string). It still does
624 not work, but now we can test it.
626 2007-06-22 Murray Cumming <murrayc@murrayc.com>
628 * src/maemo/modest-msg-edit-window.c: (init_window):
629 Comment out use of an uninitialzed GtkScrolledWindow variable,
630 to fix the build and stop a crash. Yet again.
632 2007-06-22 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-tny-account-store.c: (get_password):
635 Remove the call to tny_account_set_user() because this actually crashes.
636 As mentioned in the last commit, it is known to not work anyway.
638 2007-06-22 Murray Cumming <murrayc@murrayc.com>
640 * src/modest-tny-account-store.c: (get_password):
641 Use tny_account_set_username() to tell tinymail that the username might
642 have changed too. But tinymail ignores this: see projects.maemo.org
644 * src/modest-ui-actions.c:
645 (modest_ui_actions_on_password_requested): Remove the useless attempt to
646 reset the connection when changing the username, and improve the comments.
647 Save the changed username to gconf at least, so it is used when Modest is
650 2007-06-21 Murray Cumming <murrayc@murrayc.com>
652 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
653 Do not use a query, so that we get all folders, including for POP and
654 local-folders. They work as search criteria too.
655 This fixes projects.maemo.org bug NB#57740.
657 2007-06-21 Murray Cumming <murrayc@murrayc.com>
659 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
660 Comment out the use of hildon_notification_set_sound() because it is
661 not declared, to fix the build. Warnings are serious, people.
663 2007-06-21 Armin Burgmeier <armin@openismus.com>
665 * src/maemo/modest-maemo-utils.h:
666 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
667 modest_maemo_utils_get_supported_secure_authentication_methods()
668 to query authentication methods for a specific user. This should fix
669 projects.maemo.org bug NB#61369.
671 * src/maemo/easysetup/modest-easysetup-wizard.c:
672 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
675 2007-06-21 Murray Cumming <murrayc@murrayc.com>
677 * libmodest-dbus-client/libmodest-dbus-client.h:
678 * libmodest-dbus-client/libmodest-dbus-client.c:
679 (modest_dbus_message_iter_get_search_hit),
680 (libmodest_dbus_client_search):
681 Reorganised and commented this.
682 Removed modest_search_hit_free() from the public API because it
685 Added libmodest_dbus_client_get_folders() and
686 modest_folder_result_list_free().
688 * src/dbus_api/modest-dbus-api.h:
689 * src/dbus_api/modest-dbus-callbacks.c:
690 (modest_dbus_req_filter): Commented. Moved most code to
691 on_dbus_method_search() and added on_dbus_method_get_folders().
693 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
694 of the extra D-Bus handler.
696 * tests/dbus_api/Makefile.am:
697 * tests/dbus_api/test_get_folders.c: New test for
698 libmodest_dbus_client_get_folders(). This seems to return an empty list
699 at the moment. That could be the same error that causes the message list
700 to be empty sometimes.
701 This should help with projects.maemo.org bug NB#57740.
703 2007-06-21 Armin Burgmeier <armin@openismus.com>
705 * src/modest-mail-operation.c: Do not call
706 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
707 notify the operation's end after having set the status to CANCELED for
708 the operation queue to listen on. This fixes a deadlock when there
709 were mail operations in the queue during its finalization.
711 * src/modest-singletons.c: Reordered uninitialization of the account
712 manager to happen after the mail operation queue was uninitialized
713 because the mail operation's in the queue might still try to access
714 the account manager (see modest_mail_operation_notify_end()). This
715 fixes a potential crash when terminating the application.
717 2007-06-21 Murray Cumming <murrayc@murrayc.com>
719 * src/modest-search.c:
720 (search_mime_part_and_child_parts): Moved some code here so we
721 can search recursively in child folders.
722 (modest_search_folder): Search in the message as a mime part, instead
723 of just its child mime parts.
724 (read_chunk), (search_mime_part_ogs):
725 Check how many bytes were read, to prevent an endless loop.
726 Searching in message bodies now works. This finishes the fix for
727 projects.maemo.org bug NB#61007.
729 2007-06-20 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
732 Add a g_warning when the item is not a folder.
734 * src/modest-ui-dimming-rules.c:
735 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
736 when selected item is not a folder (for instance, an account), because
737 the UI spec only talks about folders.
738 I am not sure what the UI spec wants, so this might not totally fix
739 projects.maemo.org bug NB#60794.
741 2007-06-20 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
744 (load_from_file): Sort the list. The unsorted list would be more noticeable
745 in non-English locales.
747 * src/maemo/modest-msg-edit-window.c:
748 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
749 warning and fix the build.
751 * src/maemo/modest-progress-bar-widget.c:
752 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
753 avoid a g_warning, and probably to avoid a crash.
755 2007-06-20 Murray Cumming <murrayc@murrayc.com>
757 * src/modest-search.c: (modest_search_folder): Check for a GError
758 when calling tny_folder_get_headers(), to show that this is not the cause
761 2007-06-20 Murray Cumming <murrayc@murrayc.com>
763 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
764 Actually set the body query instead of the subject query.
766 * src/modest-search.c: (search_mime_part_ogs),
767 (search_mime_part_strcmp): Remove extra space from the text/* regex,
768 which would probably cause it to fail if we got this far.
770 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
771 to simplify the code.
772 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
773 be causing search-in-body to fail.
775 2007-06-20 Murray Cumming <murrayc@murrayc.com>
777 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
779 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
780 Better debug message when the folder cannot be found.
781 This should help with fixing projects.maemo.org bug #61287.
782 * src/modest-search.c: (add_hit): Do not leak the furl string.
784 2007-06-20 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-ui-actions.c:
787 (modest_ui_actions_on_folder_selection_changed):
788 Do not special-case TNY_MERGE_FOLDER here, because
789 modest_tny_folder_get_account() already does that. This fixes
790 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
791 shown when the Outbox was selected).
793 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
795 * libmodest-dbus-client/libmodest-dbus-client.c:
796 (_dbus_iter_get_string_or_null): Initialize the string variable in
797 case this helps with Dirk's crash.
799 2007-06-19 Murray Cumming <murrayc@murrayc.com>
801 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
802 though it is not implemented yet (this function is maybe not even used),
803 to avoid breaking ABI in future.
804 * libmodest-dbus-client/libmodest-dbus-client.c:
805 (get_attachments_string): Moved some code into this generic function.
806 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
807 sends email. It is maybe not used.
808 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
809 (on_send_mail): Use attachments.
811 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
812 * src/maemo/modest-msg-edit-window.c:
813 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
814 a filename before using it, to fix projects.maemo.org bug NB#58233.
816 2007-06-19 Murray Cumming <murrayc@murrayc.com>
818 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
819 Initialize the continue_download variable to fix the build, and probably
820 to fix randome behaviour.
822 2007-06-18 Armin Burgmeier <armin@openismus.com>
824 * src/modest-tny-send-queue.h:
825 * src/modest-tny-send-queue.c: Keep track of the status of messages in
826 the queue so we can later show it in the UI. Replaced
827 modest_tny_send_queue_msg_is_being_sent() by
828 modest_tny_send_queue_get_msg_status().
830 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
832 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
833 gpointer. This probably was not harmful, but just to be sure.
835 2007-06-18 Murray Cumming <murrayc@murrayc.com>
837 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
838 Fix the build, but leave the function broken on Bora, because
839 hildon_uri_action_get_service() does not exist.
840 osso_uri_action_get_service() does not exist either, it seems.
842 2007-06-18 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-tny-account.c:
845 (modest_tny_account_new_from_server_account):
846 Uncommented the url debug output again, because it is useful for
847 debugging, as I said in the comment.
849 2007-06-18 Murray Cumming <murrayc@murrayc.com>
851 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
853 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
854 for Mameo Bora, to fix the build.
856 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
859 Fixed build with hildon < 0.99
861 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
862 Check if the selected account is busy instead of checking all accounts
864 * src/modest-account-mgr-priv.h:
865 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
866 (modest_account_mgr_init), (compare_account_name),
867 (modest_account_mgr_set_account_busy),
868 (modest_account_mgr_account_is_busy):
869 * src/modest-account-mgr.h:
870 Added busy information to the account manager. It possible to
871 set an account to busy or not busy now.
873 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
874 (modest_mail_operation_update_account),
875 (modest_mail_operation_notify_end):
876 Set the account to busy/not busy depending on the operation state.
878 * src/widgets/modest-account-view.c:
879 (modest_account_view_finalize), (get_last_updated_string),
880 (update_account_view), (on_account_busy_changed), (init_view):
881 Show string "Refreshing..." if the account is currently busy.
883 All this fixes projects.maemo.org bug NB#59711
885 2007-06-14 Armin Burgmeier <armin@openismus.com>
887 * src/widgets/modest-attachments-view.h:
888 * src/widgets/modest-attachments-view.c: Added
889 modest_attachments_view_has_attachments() and fixed coordinate
890 transformation in get_att_view_at_coords(). This fixes attachment
893 * src/widgets/modest-msg-view.c: Make use of
894 modest_attachments_view_has_attachments() to decide whether to show
895 attachments in the header.
897 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
899 * src/maemo/modest-connection-specific-smtp-edit-window.c:
900 (on_change), (on_combo_security_changed),
901 (modest_connection_specific_smtp_edit_window_init),
902 (modest_connection_specific_smtp_edit_window_set_connection),
903 (modest_connection_specific_smtp_edit_window_is_dirty):
904 * src/maemo/modest-connection-specific-smtp-edit-window.h:
905 * src/maemo/modest-connection-specific-smtp-window.c:
908 Show an comfirmation dialog for the smpt-edit-window if there are
909 unsaved changes and the user hits cancel.
910 (projects.maemo.org bug NB#60479)
912 2007-06-14 Armin Burgmeier <armin@openismus.com>
914 * src/maemo/easysetup/modest-easysetup-wizard.c:
915 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
916 address" info in banner instead of node, and select all the text as
917 per UI spec. This fixes projects.maemo.org bug NB#60550.
919 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
921 reviewed by: <delete if not using a buddy>
923 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
924 * src/modest-ui-actions.c: (folder_refreshed_cb):
926 2007-06-14 Murray Cumming <murrayc@murrayc.com>
928 * src/widgets/modest-folder-view.c: (filter_row):
929 Explictly filter out the per-account outbox accounts. I don't know why
930 these only sometimes show up, but now they should never show up in the UI.
931 This should fix projects.maemo.org bug NB#60160.
933 2007-06-14 Murray Cumming <murrayc@murrayc.com>
935 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
936 when the toolbar does not exist yet.
937 * src/modest-widget-memory.c: (save_settings_header_view):
938 Added g_warnings() to help us to discover when we are trying to set
939 an empty columns list in gconf.
941 2007-06-14 Murray Cumming <murrayc@murrayc.com>
945 Added modest_init_get_default_header_view_column_ids().
947 * src/modest-widget-memory.c: (restore_settings_header_view):
948 Use the new function to get defaults, if the gconf key is empty,
949 instead of not creating any columns. This seems to fix the
950 empty right-hand pane problems.
952 * src/widgets/modest-header-view.h: Improved documentation.
954 2007-06-13 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
957 Revert the use of the display name as the account name, because this
958 is generally wrong and would break the code that follows.
960 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
962 * src/maemo/easysetup/modest-easysetup-wizard.c:
963 (check_for_supported_auth_methods), (on_before_next),
966 More correct fix for projects.maemo.org bug NB# 58991
967 Do not longer accept AUTH_PASSWORD as secure method and choose
968 correct method when creating the account.
970 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
972 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
973 Fixed projects.maemo.org bug NB# 58991
975 2007-06-13 Murray Cumming <murrayc@murrayc.com>
977 * src/modest-init.c: (modest_init_init_core),
978 (modest_init_local_folders): Fixed compilation errors.
980 2007-06-13 Murray Cumming <murrayc@murrayc.com>
982 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
983 Remove unnecessary lib/include, though it is good in principle when needed.
985 * src/modest-init.c: (modest_init_one_local_folder),
986 (modest_init_local_folders):
987 * src/modest-init.h: Initialize the .modest library for memory cards,
988 instead of just doing nothing for them. This should allow us to create
989 folders there, fixing projects.maemo.org bug NB#59297.
991 2007-06-13 Murray Cumming <murrayc@murrayc.com>
993 * libmodest-dbus-client/libmodest-dbus-client.c:
994 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
995 (libmodest_dbus_client_compose_mail),
996 (libmodest_dbus_client_open_message),
997 (libmodest_dbus_client_send_and_receive),
998 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1000 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1001 (on_idle_open_message), (modest_dbus_req_handler),
1002 (search_result_to_message), (modest_dbus_req_filter):
1003 * src/modest-search.c: (add_hit), (modest_search_folder),
1004 (modest_search_all_accounts): Improved debug messages.
1006 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1008 * src/modest-tny-account-store.c:
1009 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1012 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1015 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-tny-account-store.c: (get_server_accounts):
1018 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1019 even when there are no accounts, so that the Outbox folder is always
1020 visible. This fixes projects.maemo.org bug NB#60158.
1022 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1024 * src/maemo/modest-main-window.c: (create_details_widget):
1025 Use the mcen_va_never logical ID.
1027 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1029 * src/dbus_api/modest-dbus-api.h:
1030 * src/dbus_api/modest-dbus-callbacks.c:
1031 (on_idle_open_default_inbox), (on_open_default_inbox),
1032 (modest_dbus_req_handler):
1033 Added a new OpenDefaultInbox method.
1035 * libmodest-dbus-client/libmodest-dbus-client.h:
1036 * libmodest-dbus-client/libmodest-dbus-client.c:
1037 Added libmodest_dbus_client_open_default_inbox() to call the new
1038 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1039 though it should maybe be used by a new osso-email-interface function.
1041 * tests/dbus_api/Makefile.am:
1042 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1045 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1047 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1048 NULL, so that the signals get all the keys. This should not actually
1049 change any behaviour because we currently update everything when anything
1052 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1054 * src/widgets/modest-folder-view.c: (text_cell_data),
1055 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1056 (find_inbox_iter): If tinymail tells us that the folder is
1057 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1058 This causes the inbox to be selected at startup, fixing part of
1059 projects.maemo.org bug NB#56305.
1061 * src/modest-ui-dimming-rules.c:
1062 (modest_ui_dimming_rules_on_tools_smtp_servers):
1063 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1064 the SMTP servers menu item.
1065 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1066 that the SMTP Servers menu item is dimmed when there are no accounts,
1067 as a future version of the UI spec will require. This fixes
1068 projects.maemo.org bug NB#56305.
1070 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1072 * src/maemo/modest-maemo-utils.c:
1073 (modest_maemo_utils_get_supported_secure_authentication_methods):
1074 Added label to dialog instead of unreadable title
1076 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1077 (modest_main_window_new):
1078 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1081 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1082 * src/modest-account-mgr.h:
1083 Added method to avoid code duplication
1085 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1086 (modest_ui_actions_on_send_receive):
1087 Use modest_account_mgr_has_accounts
1089 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/easysetup/modest-presets.c:
1092 (modest_presets_get_info_server_security): Do not report secure auth
1094 * src/modest-protocol-info.c: Use the defines for the gconf key names
1095 for secure authentication. This was not working because we were writing
1096 Password and reading password, and the check was case sensitive.
1097 With this, gmail now works for receiving and sending when created via
1100 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1102 * src/maemo/easysetup/modest-presets.c:
1103 (modest_presets_get_info_server_security): Correct the key name for
1104 SecureSmtp, because it seems to be case-sensitive.
1105 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1106 Do not try to get the 0th notebook page if there are 0 pages, to
1107 avoid a g_warning().
1109 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1111 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1112 Prevent use of the new notification feature for now, because it currently
1113 shows one dialog for each new email, which is annoying.
1115 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1117 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1118 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1119 when no country was selected, so that we show the global ones.
1120 * src/maemo/easysetup/modest-presets.c:
1121 (modest_presets_get_providers): Return only the global providers, not
1122 all providers when mmc=0 was requested.
1124 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1126 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1127 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1128 provider ID in the combo.
1130 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1131 Do not show the page numbers, because it would be confusing when we add
1132 the 2 extra pages for the custom setup, when the user chooses the "Other"
1133 provider. This fixes projects.maemo.org bug NB#59028
1135 * src/modest-init.c: (modest_init_init_core),
1136 (modest_init_local_folders):
1137 * src/modest-init.h:
1138 * src/modest-tny-account.c:
1139 (modest_tny_account_new_for_local_folders): Do not create default folders
1140 for the memory card. This should fix projects.maemo.org bug NB#59328.
1142 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1144 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1145 Free the changed_conf_keys string items. They are already freed in the
1146 idle handler if that runs first.
1148 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1150 * src/modest-ui-actions.c:
1151 (modest_ui_actions_on_password_requested): Check that the server name
1152 is not NULL, because I just saw a password dialog with (null) as the
1155 * src/modest-tny-folder.[h|c]: Added
1156 modest_tny_folder_is_memory_card_folder().
1157 * src/modest-ui-dimming-rules.c:
1158 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1159 menu item for memory cards, as per the UI spec (section 7.4). This should
1160 fix projects.maemo.org bug NB#59297.
1162 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1164 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1165 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1166 is another problem with the code, see Murray's comment at line 772)
1168 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1170 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1171 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1172 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1173 (load_from_file), (easysetup_country_combo_box_init),
1174 (easysetup_country_combo_box_get_active_country_ids),
1175 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1176 instead of just one ID, to avoid duplicate country names in the UI.
1178 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1179 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1180 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1181 a single ID, avoiding duplicate providers.
1182 * src/maemo/easysetup/modest-easysetup-wizard.c:
1183 (on_combo_account_country): Adapt to use a list.
1185 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1188 keys changed in the last X seconds.
1190 * src/modest-account-mgr.h:
1191 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1192 (on_key_change), (modest_account_mgr_class_init),
1193 (modest_account_mgr_init), (modest_account_mgr_finalize):
1194 As the keys are changed, save them in a GSList* and signal that GSList*
1195 further every X seconds, to batch changes, to allow us to do just one
1196 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1197 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1199 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1200 changed signal signature.
1202 * src/modest-conf.c: (modest_conf_set_list),
1203 (modest_conf_on_change): Reenable notification.
1205 (modest_conf_maemo_fake_on_change): Comment out the hack that
1206 notified immediately instead of asynchronously.
1208 * src/widgets/modest-account-view.h:
1209 * src/widgets/modest-account-view.c:
1210 (update_account_view): Select the previously-selected account ID,
1211 if possible. This fixes projects.maemo.org bug NB#56933.
1213 (on_account_changed), (on_account_removed),
1214 (modest_account_view_select_account):
1216 Remove the block/unblock functions
1217 because they were not useful.
1219 * src/maemo/modest-account-view-window.c:
1220 (on_delete_button_clicked), (on_edit_button_clicked),
1221 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1223 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1226 Improve the error dialog to show Incorrect Account Settings, which seems
1227 clearer, and say that the internal error message (to be removed from the
1228 dialog later) is often misleading.
1229 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1231 * src/modest-tny-account.c:
1232 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1233 URL because this is so useful for debugging on the device.
1235 * src/widgets/modest-serversecurity-combo-box.c:
1236 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1238 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1240 * src/modest-mail-operation.c:
1241 (modest_mail_operation_send_new_mail):
1242 Added a comment about a nasty but apparently harmless message. Details
1243 added to the wiki g_warnings() page.
1245 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1248 (modest_tny_send_queue_class_init):
1249 Do not use the priv struct because it is empty, to avoid g_warnings
1250 about a non-existant priv struct.
1252 * src/modest-tny-account-store.c:
1253 (modest_tny_account_store_get_server_account),
1254 (modest_tny_account_store_get_transport_account_for_open_connection
1255 ): Do not try to get transport server accounts for local folders,
1256 because they don't have any. This avoids a g_warning().
1258 * src/maemo/modest-main-window.c:
1259 (modest_main_window_notify_send_receive_initied),
1260 (on_configuration_key_changed):
1261 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1262 * src/modest-defs.h:
1263 * src/modest-mail-operation.c:
1264 (modest_mail_operation_update_account):
1265 * src/modest-tny-account-store.h:
1266 * src/modest-tny-account.c:
1267 (modest_tny_account_get_special_folder),
1268 (modest_tny_account_new_for_local_folders),
1269 (modest_tny_account_new_for_per_account_local_outbox_folder):
1270 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1271 * src/modest-tny-local-folders-account.c:
1272 (add_account_folders_to_merged_folder):
1273 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1274 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1275 (modest_ui_actions_on_send):
1276 * src/widgets/modest-folder-view.c: (update_model):
1277 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1278 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1279 modest_tny_account_store_get_tny_account_by_account() to
1280 modest_tny_account_store_get_server_account() to make the code clearer.
1282 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1284 * src/dbus_api/modest-dbus-api.h:
1285 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1286 * src/maemo/modest-msg-edit-window.c:
1287 (modest_msg_edit_window_attach_file_noninteractive):
1288 added g_warning in case the file to be attached does not exist
1289 * tests/dbus_api/test_compose_mail.c: (main):
1290 removed obsolete comment, added generic files as test case
1292 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-tny-account-store.c: (get_server_accounts):
1295 Create the local folders account only once, not once for each outbox, and
1296 not only when there are some outboxes.
1298 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1300 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1301 code that is causing a crash at startup. Sergio says that he is fixing this.
1303 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1305 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1306 * src/maemo/modest-account-settings-dialog.c:
1307 (create_page_outgoing),
1308 (modest_account_settings_dialog_set_account_name),
1309 (save_configuration):
1310 - Fixed handling of the "Use secure authentication" toggle to comply with
1311 the ui specification. See also projects.maemo.org bug NB#58400
1313 - Restore the Secure connection setting combo correctly when loading
1316 * src/maemo/modest-maemo-utils.c:
1317 (on_camel_account_get_supported_secure_authentication),
1318 (modest_maemo_utils_get_supported_secure_authentication_methods):
1319 Fixed a crasher if operation is canceled
1321 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1322 (modest_protocol_info_auth_is_secure):
1323 * src/modest-protocol-info.h:
1325 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1326 the sense of the "Use secure authentication" toggle.
1328 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1330 * src/modest-tny-account-store.h:
1331 * src/modest-tny-account-store.c:
1332 Added modest_tny_account_store_get_local_folders_account().
1334 * src/modest-tny-folder.h:
1335 * src/modest-tny-folder.c:
1336 (modest_tny_folder_get_account):
1337 Added this replacement for tny_folder_get_account() which returns
1338 the local-folders account for TnyMergeFolders, to avoid the
1339 warning about the unimplemented get_account_func() vfunc().
1341 (modest_tny_folder_get_rules),
1342 * src/modest-ui-actions.c:
1343 (modest_ui_actions_on_folder_selection_changed):
1344 * src/modest-mail-operation.c:
1345 (modest_mail_operation_remove_folder),
1346 (modest_mail_operation_xfer_folder),
1347 (modest_mail_operation_rename_folder),
1348 (modest_mail_operation_get_msg),
1349 (modest_mail_operation_get_msgs_full),
1350 (modest_mail_operation_remove_msg),
1351 (modest_mail_operation_xfer_msgs),
1352 (modest_mail_operation_refresh_folder):
1353 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1355 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1358 (modest_server_account_set_security):
1359 * src/modest-defs.h: Add comments explaining that our
1360 UI spec means TLS when it says Normal, so these do not look like errors.
1362 * src/modest-tny-account.c:
1363 (modest_tny_account_new_from_server_account): Use the new tinymail
1364 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1365 for TLS. This should fix projects.maemo.org bug NB#58460.
1367 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1369 * src/maemo/easysetup/modest-easysetup-wizard.c:
1370 (create_account): Correct the position of the gconf sanity check warning.
1371 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1372 of using the g_idle_add() hack, because this does not seem to be necessary
1373 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1374 caused by something other than maemo's gconf.
1375 This fixes projects.maemo.org bug #59022.
1377 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1379 * src/modest-account-mgr-helpers.c:
1380 (modest_account_mgr_get_default_account): Do not check that the account
1381 exists if there is no default account (NULL), to fix a runtime warning.
1383 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1385 * src/widgets/modest-folder-view.c: (update_model):
1386 Do not unref the treemodel before we have finished with it.
1387 This prevents a valgrind warning and an occasional crash at startup.
1389 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1391 * libmodest-dbus-client/libmodest-dbus-client.h:
1392 added libmodest_dbus_client_compose_mail()
1393 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1395 added functions needed for SendAsMail() functionality
1396 * src/maemo/modest-msg-edit-window.c:
1397 (modest_msg_edit_window_attach_file_noninteractive):
1398 non interactively attaching files to message edit window
1399 * src/widgets/modest-msg-edit-window.h:
1400 * tests/dbus_api/Makefile.am:
1401 added test_compose_mail.c
1402 * tests/dbus_api/test_compose_mail.c: (main):
1404 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1406 * src/modest-account-view.c:
1407 Fixed bug projects.maemo.org bug NB#59307
1409 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1411 * src/maemo/easysetup/modest-easysetup-wizard.c:
1412 (get_serverport_incoming), (on_before_next), (create_account):
1413 * src/maemo/modest-account-settings-dialog.c:
1414 (modest_account_settings_dialog_set_account_name):
1415 * src/maemo/modest-maemo-utils.c:
1416 (on_camel_account_get_supported_secure_authentication_status),
1417 (on_camel_account_get_supported_secure_authentication),
1418 (on_secure_auth_cancel),
1419 (modest_maemo_utils_get_supported_secure_authentication_methods):
1421 Implemented security authentication for settings and easysetup.
1423 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/modest-main-window.c: (create_details_widget):
1426 Show the total size for memory card accounts too, instead of showing
1427 the name again. Fixes bug projects.maemo.org bug NB#59307.
1429 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1432 * src/modest-tny-simple-folder-store.c:
1433 * src/modest-tny-simple-folder-store.h: Removed.
1435 * src/modest-tny-local-folders-account.h
1436 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1437 for the local-folders maildir, with an extra TnyMergedFolder containing
1438 the folders of the per-account outbox store accounts.
1439 * src/modest-tny-account-store.c: (get_server_accounts):
1440 Add the outboxes to the special local folders account after creating it.
1442 * src/modest-tny-account.c:
1443 (modest_tny_account_new_for_local_folders): Create the derived
1444 account when creating the main local-folders account.
1446 * src/maemo/modest-main-window.c: (create_details_widget),
1447 (modest_main_window_set_contents_style):
1448 Adapted to the use of the derived account instead of the folder store.
1450 * src/modest-ui-actions.c:
1451 (modest_ui_actions_on_folder_selection_changed):
1452 * src/modest-ui-dimming-rules.c:
1453 (modest_ui_dimming_rules_on_new_folder):
1454 * src/widgets/modest-folder-view.c: (text_cell_data),
1455 (icon_cell_data), (filter_row), (update_model),
1456 (get_cmp_rows_type_pos):
1459 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1460 Do not get the priv struct, because no priv struct has been set,
1461 to avoid a runtime warning.
1463 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1464 #ifelse with #else, to fix a warning, to fix the build.
1467 2007-06-05 Christian Kellner <ckellner@openismus.com>
1469 * libmodest-dbus-client/libmodest-dbus-client.c:
1470 Fix small typo in doc (why do you always see them
1471 AFTER committing stuff?)
1474 2007-06-05 Christian Kellner <ckellner@openismus.com>
1476 * libmodest-dbus-client/libmodest-dbus-client.c:
1477 (libmodest_dbus_client_search):
1478 Initialize hit list with NULL. Also set folder list
1479 to "" if NULL was supplied.
1482 2007-06-03 Christian Kellner <ckellner@openismus.com>
1484 * libmodest-dbus-client/libmodest-dbus-client.c:
1485 (modest_search_hit_list_free):
1486 Make it save to call it with NULL.
1488 * src/dbus_api/modest-dbus-callbacks.c:
1489 * src/modest-search.c:
1490 Return full ModestSearchHits as the search result list not TnyHeader
1491 since can't be around withouth the correspoding TnyFolder.
1493 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1495 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1496 Added currently commented code to check for secure auth
1498 * src/maemo/modest-account-settings-dialog.c: (on_response),
1499 (save_configuration), (show_ok):
1500 Fixed projects.maemo.org bugs NB #59248 and #59251
1502 * src/maemo/modest-maemo-utils.c:
1503 (on_camel_account_get_supported_secure_authentication_status),
1504 (on_camel_account_get_supported_secure_authentication),
1505 (modest_maemo_utils_get_supported_secure_authentication_methods):
1506 * src/maemo/modest-maemo-utils.h:
1507 Moved get_supported_secure_authentication() method here to be able
1508 to use it from easysetup wizard.
1510 * src/modest-pair.c: (on_pair_compare_as_string):
1511 Should compare string with first part of pair and not
1512 strcmp pairs which will crash.
1514 * src/modest-protocol-info.c:
1515 (modest_protocol_info_protocol_is_store):
1516 * src/modest-protocol-info.h:
1517 Added modest_protocol_info_get_auth_protocol_name()
1519 2007-06-03 Armin Burgmeier <armin@openismus.com>
1521 * src/modest-mail-operation.c:
1522 (modest_mail_operation_get_msgs_full): Set priv->account also when
1523 only retrieving a single message. This avoids a crash when canceling
1526 (modest_mail_operation_notify_end): Do not explicitely remove the
1527 operation from the queue but only emit the progress_changed signal.
1528 The queue itself listens to that signal to remove the operation when
1529 it is finished. This reduces coupling and removes a potential deadlock
1530 when modest_mail_operation_notify_end() is called from the queue
1531 itself. If that is a problem performance-wise, I would suggest to
1532 implement a status-changed signal or something.
1534 * src/modest-mail-operation-queue.c: Make sure to never call a
1535 function from another file while the queue is locked. This (hopefully)
1536 fixes another deadlock when exiting the application while retrieving
1539 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1541 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1542 Fixed build if libogs is not available
1544 2007-06-03 Christian Kellner <ckellner@openismus.com>
1546 * libmodest-dbus-client/libmodest-dbus-client.h:
1547 * libmodest-dbus-client/libmodest-dbus-client.c:
1548 (libmodest_dbus_client_delete_message):
1549 Implement deletion of messages (Client side).
1551 (modest_search_hit_free),
1552 (modest_search_hit_list_free):
1553 Utility functions to free the result hits.
1555 * src/dbus_api/modest-dbus-api.h:
1556 * src/dbus_api/modest-dbus-callbacks.c:
1557 (on_delete_message),
1558 (modest_dbus_req_handler):
1559 Implement deletion of messages (Server side).
1561 * tests/dbus_api/test_search.c: (main):
1564 * tests/dbus_api/Makefile.am:
1565 * tests/dbus_api/test_delete_message:
1566 Add little test for the message deletion logic
1568 2007-06-03 Armin Burgmeier <armin@openismus.com>
1570 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1571 when the operation queue was not empty. projects.maemo.org bug
1574 2007-06-03 Armin Burgmeier <armin@openismus.com>
1576 * src/widgets/modest-account-view.c
1577 (on_account_default_toggled): Toggle default account column
1578 explicitely instead of waiting for gconf notification (which is
1579 currently ignored). This should fix projects.maemo.org bug NB#56910
1580 for now. It should probably be removed when gconf notifications are
1583 2007-06-03 Christian Kellner <ckellner@openismus.com>
1585 * libmodest-dbus-client/libmodest-dbus-client.c:
1586 Removed debugging spew.
1588 * src/dbus_api/modest-dbus-callbacks.c:
1589 Added debugging info.
1591 * src/modest-search.c:
1592 (modest_search_all_accounts):
1593 Use tny_account_store_get_accounts () on the account store
1594 to get all accounts which is the way to get all accounts.
1596 * tests/dbus_api/test_search.c: (main):
1597 Make it possible to supply the search term on the command line.
1599 2007-06-03 Christian Kellner <ckellner@openismus.com>
1601 * libmodest-dbus-client/libmodest-dbus-client.c:
1602 * libmodest-dbus-client/libmodest-dbus-client.h:
1603 Implement searching for mesages over raw dbus. (Client side)
1605 * src/dbus_api/Makefile.am:
1606 * src/dbus_api/modest-dbus-api.h:
1607 * src/dbus_api/modest-dbus-callbacks.c:
1608 * src/dbus_api/modest-dbus-callbacks.h:
1609 Search framework (Server side). Also implement on_idle_open_message().
1611 * src/maemo/modest-platform.c: (modest_platform_init):
1612 Prepare for raw dbus/osso rpc interaction.
1614 * src/modest-search.h:
1615 Changed minsize from unspecific guint to guint32.
1617 * src/modest-search.c:
1619 Added strange hack which magically made tnymail work.
1621 (modest_search_folder),
1622 (modest_search_account),
1623 (modest_search_all_accounts):
1624 Implement helper functions to search all accounts, specific account
1627 * tests/dbus_api/Makefile.am:
1628 * tests/dbus_api/test_open_message.c:
1629 Read url to open from commandline.
1631 * tests/dbus_api/test_search.c:
1632 Implement small test for dbus search stuff
1634 2007-06-02 Armin Burgmeier <armin@openismus.com>
1636 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1637 include account type and account title. This fixes projects.maemo.org
1640 * src/maemo/modest-account-view-window.c: Set a title for the window.
1642 2007-06-02 Armin Burgmeier <armin@openismus.com>
1644 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1645 incoming and outgoing server name based on email address and server
1646 types as long as the names have not been edited manually. This fixes
1647 projects.maemo.org bug NB#58671.
1649 2007-06-02 Armin Burgmeier <armin@openismus.com>
1651 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1652 server type cannot be changed in future to the incoming details page
1653 when creating an account. This fixes projects.maemo.org bug NB#59029.
1655 2007-06-02 Armin Burgmeier <armin@openismus.com>
1657 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1658 and assigned max width chars so that they wrap instead of being
1659 truncated. Fixes projects.maemo.org bug NB#56126.
1661 2007-06-02 Armin Burgmeier <armin@openismus.com>
1663 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1664 introductory note to the connection specific smtp servers dialog, as
1665 section 8.12 of the email UI specification requires. This fixes
1666 projects.maemo.org bug NB#59212.
1668 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1670 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1671 Check for running mail operations, and offer to cancel them, as per the UI
1672 spec. This fixes projects.maemo.org bug NB#59041 .
1673 However, I suspect that tinymail may still use the network connection
1674 in ways that we cannot detect or cancel. But it should at least adapt to
1675 changes fairly well.
1677 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1679 * src/modest-tny-account-store.c: (recreate_all_accounts),
1680 (get_cached_accounts), (get_server_accounts): Do more sensible
1681 ref-counting of the temporarily-cached outbox accounts list. This seems
1682 to fix a crash when entering the password when the password was wrong.
1684 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1686 * src/gnome/modest-main-window.c: (connect_signals):
1687 * src/modest-tny-account-store.c: (get_password),
1688 (modest_tny_account_store_alert): Added comments and clues and
1689 commented-out code about how we currently fail to deal with connection
1690 errors and wrong passwords, and how we should.
1692 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1694 * src/widgets/modest-retrieve-combo-box.c:
1695 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1696 This fixes projects.maemo.org bug NB#58472 .
1698 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1700 * src/maemo/easysetup/modest-easysetup-wizard.c:
1701 (create_page_complete_easysetup):
1702 (create_page_complete_custom): Correct the last commit,
1703 putting the correct sentences in the correct pages.
1705 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1707 * src/maemo/easysetup/modest-easysetup-wizard.c:
1708 (create_page_complete_custom): Show the second sentence of text
1709 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1712 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1714 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1715 Set the leave-on-server conf key by default. This fixes
1716 projects.maemo.org bug NB#59258 .
1718 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1720 * src/maemo/modest-account-view-window.c:
1721 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1722 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1725 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1727 * src/maemo/easysetup/modest-easysetup-wizard.c:
1728 (create_caption_new_with_asterisk):
1729 * src/maemo/modest-account-settings-dialog.c:
1730 (create_caption_new_with_asterisk):
1731 Uncomment the code to add the asterisk, because they are no longer in the
1732 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1733 (update_incoming_server_title): Add an asterisk here too.
1735 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/modest-maemo-global-settings-dialog.c:
1738 (current_connection): Check that we are even connected before trying to
1739 get the current connection name, to prevent a warning.
1741 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1742 Change the comments because tny_maemo_conic_device_connect() is now meant to
1744 * src/modest-mail-operation.c:
1745 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1746 make sure we have a connection and fail if we can't connect.
1748 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1750 * src/maemo/modest-main-window.c:
1751 (on_account_store_connecting_finished): Do not try to get the
1752 connection ID if we are not really connected. I am surprised that
1753 this signal handler is called when we are not connected.
1755 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-error.h:
1758 * src/modest-ui-actions.c:
1759 (modest_ui_actions_get_msgs_full_error_handler):
1760 Renamed an enum, added comments, added an enum
1761 for retrieve-limit errors.
1763 * src/modest-mail-operation.c: (foreach_add_item),
1764 (internal_folder_observer_update), (update_account_thread),
1765 (modest_mail_operation_get_msgs_full):
1766 (modest_mail_operation_update_account),
1767 Added comments about how this works, and some code that should
1768 (but does not) check the retrieve-limit. See the TODO comment.
1770 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1772 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1773 Initialize help_id to fix the build. Warnings are good.
1775 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1777 * src/widgets/modest-hbox-cell-renderer.c:
1778 (modest_hbox_cell_renderer_append):
1779 * src/widgets/modest-vbox-cell-renderer.c:
1780 (modest_vbox_cell_renderer_append):
1781 Fix the last commit by doing an extra ref.
1783 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1785 * src/widgets/modest-hbox-cell-renderer.c:
1786 (modest_hbox_cell_renderer_append):
1787 * src/widgets/modest-vbox-cell-renderer.c:
1788 (modest_vbox_cell_renderer_append):
1789 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1790 to fix the build with Maemo Bora.
1791 However, there seems to be a remaining crash, probably due to reference
1794 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-tny-account.c:
1797 (modest_tny_account_new_for_local_folders):
1798 Use hildon_file_system_info_async_new() to get a better name for
1799 the memory card account, setting it as the account name.
1800 The timing seems to work, but this is probably
1801 not the best place to do this. See the TODO comment.
1802 * src/maemo/modest-main-window.c: (create_details_widget):
1803 * src/widgets/modest-folder-view.c: (text_cell_data):
1804 Use the tny account name instead of hardcoding a name.
1806 2007-05-30 Christian Kellner <ckellner@openismus.com>
1808 * src/modest-search.c: (modest_search):
1809 Correctly set part_search_func even if we have already parsed
1810 the query and thus a valid OgsTextSearcher object.
1812 2007-05-30 Christian Kellner <ckellner@openismus.com>
1815 Search and check for libogs.
1818 Incooparte the ogs build env.
1820 * src/modest-mime-part-search-stream.c:
1821 * src/modest-mime-part-search-stream.h:
1822 Removed since we do the real searching now in modest-search.c.
1824 * src/modest-search.c:
1825 * src/modest-search.h:
1826 Implement support for ogs. We use that if available and requested
1827 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1828 should now handle the corner case when the search term is spread
1829 across multiple reads.
1830 Also the logic in modest_search () was corrected to search all
1831 requested fields until one is found.
1833 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1837 * src/modest-init.h:
1838 * src/modest-init.c: Made modest_init_local_folders() take a
1839 path and be public so we can iniitialize maildir folders on
1842 * src/modest-local-folder-info.h:
1843 * src/modest-local-folder-info.c:
1844 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1846 * src/modest-tny-account.c:
1847 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1848 still means the standard local-folders path on the local volume.
1850 * src/modest-tny-account-store.c:
1851 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1852 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1853 all accounts when that happens.
1854 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1855 this too, so it shows up in the treeview.
1857 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1859 * src/maemo/modest-maemo-global-settings-dialog.c:
1860 (current_connection):
1861 * src/widgets/modest-global-settings-dialog.c:
1862 (current_connection_default):
1863 Use the enum values instead of 0, 1 and -1,
1864 to make the code clearer.
1866 * src/modest-account-mgr-helpers.c:
1867 (modest_account_mgr_get_connection_specific_smtp): Make this code
1870 * src/modest-runtime.h:
1871 * src/modest-runtime.c:
1872 Added modest_runtime_remove_all_send_queues().
1873 * src/maemo/modest-main-window.c:
1874 (on_account_store_connecting_finished): Recreate the send queues,
1875 using the appropriate transport accounts for this new connection.
1876 Some futher adapting might be needed if the old send queues are not
1877 automatically stopped at this point.
1879 * src/modest-tny-account-store.c: (get_server_accounts):
1880 Create the connection-specific transport accounts, so that they can
1881 be found later by their ID.
1883 * src/modest-tny-account.h:
1884 * src/modest-tny-account.c:
1885 Added modest_tny_account_new_from_server_account_name().
1886 modest_tny_account_new_from_server_account(): Do not create the
1887 send queues here, because they will be
1888 recreated anyway when the connection changes for the first time.
1890 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1892 * src/modest-local-folder-info.h:
1893 * src/modest-local-folder-info.c:
1894 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1895 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1896 tbox_folder): Take a modest account name instead of a server TnyAccount,
1897 so we can have per-modest-account rather than per-transport-account
1899 We must make sure that we change or recreate the exisitng send queues
1900 when the connection changes for connection-specific transport accounts.
1902 * src/modest-tny-account-store.c:
1903 (create_per_account_local_outbox_folders): Create outboxed per modest
1904 account, not per transport account.
1906 * src/modest-tny-account.h:
1907 * src/modest-tny-account.c:
1908 (modest_tny_account_get_special_folder): For outboxes, get the
1909 parent modest account name. The account is ignored for other folders.
1910 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1911 modest account name rather than a server TnyAccount.
1913 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1915 * src/modest-tny-account.c:
1916 (modest_tny_account_new_from_server_account):
1917 Call modest_runtime_get_send_queue() immediately after creating transport
1918 accounts, so that they start trying to send email from the outbox as soon
1919 as possible at startup. This is probably what we want.
1921 * src/modest-mail-operation.c: (update_account_thread):
1922 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1923 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1924 * src/modest-tny-send-queue.h:
1925 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1926 (modest_ui_actions_on_send):
1927 Added comments about how sending works, though it needs some more work.
1929 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1931 * src/modest-tny-account.c:
1932 (modest_tny_account_get_special_folder): Add TODO because this fails when
1933 the network is busy.
1934 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1935 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1936 Do not try to show this window when there is no active account. The UI
1937 specs does not tell us what to do in this case.
1939 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1943 * src/maemo/Makefile.am:
1944 * src/widgets/Makefile.am: Some dist fixes.
1946 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/modest-connection-specific-smtp-window.c:
1949 (on_button_edit): Make the code clearer, to prevent a double free.
1951 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-account-settings-dialog.c:
1954 (modest_account_settings_dialog_set_account_name),
1955 Check the connection-specific smtp servers checkbox if there are any.
1957 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1958 (modest_connection_specific_smtp_edit_window_init):
1959 Start with a suitable port number.
1961 * src/modest-account-mgr-helpers.h:
1962 * src/modest-account-mgr-helpers.c: Added
1963 modest_account_mgr_get_has_connection_specific_smtp().
1965 (modest_account_mgr_set_connection_specific_smtp),
1966 (modest_account_mgr_remove_connection_specific_smtp),
1967 (modest_account_mgr_get_has_connection_specific_smtp),
1968 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1969 connection-specific smtp server accounts in the account, rather than
1970 the server account conf dir.
1972 This fixes bug projects.maemo.org bug NB#58263 .
1974 * src/modest-tny-account-store.c:
1975 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1976 if there are no server accounts yet, to prevent an infinite loop when there
1977 are no accounts. Document that one must be called before the other.
1979 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-account-mgr-helpers.c:
1982 (modest_account_mgr_get_default_account): Make sure that at least
1983 one account is always the default, if there are any enabled accounts.
1984 This is just a sanity check that shouldn't be necessary.
1986 * src/modest-account-mgr-priv.c:
1987 (_modest_account_mgr_account_from_key): Unescape the conf key to
1988 get the real account name. For instance, this is an issue if a space
1989 was in the account name, which can happen because the account name
1990 is generated from the display name.
1991 (_modest_account_mgr_get_account_keyname): Always escape the
1993 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1994 Unescape the conf keys to get the real account names.
1996 For instance, previously the is-default radio button in the accounts
1997 list was not checked for any accounts at first. This fixes that,
1998 and might fix several similar bugs.
2000 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2002 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2003 Removed some debug printfs.
2005 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2007 Modest on-disk outbox directories are now here, for instance:
2008 $HOME/.modest/outboxes/<account-id-1>/outbox
2009 $HOME/.modest/outboxes/<account-id-2>/outbox
2011 $HOME/.modest/local-folders/outbox
2012 so we can have a separate outbox for each account.
2013 But they are shown as one outbox in the GtkTreeView, by using a
2014 TnyMergeFolder in a ModestTnySimpleFolderStore.
2017 * src/modest-tny-simple-folder-store.c:
2018 * src/modest-tny-simple-folder-store.h:
2019 Added ModestTnySimpleFolderStore, used to contain folders from
2020 other folder stores, such as other accounts.
2022 * src/modest-tny-outbox-account.h:
2023 * src/modest-tny-outbox-account.c:
2024 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2025 used for the per-account local outbox folders.
2027 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2028 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2029 only use this (internally) now for the non-outbox local folders.
2031 * src/modest-init.h:
2032 * src/modest-init.c: Added modest_init_one_local_folder(), for
2033 setting up the directory structure for each local folder.
2035 * src/modest-local-folder-info.c:
2036 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2037 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2039 * src/modest-local-folder-info.h:
2040 * src/modest-tny-account-store.c: (on_account_removed),
2041 (on_account_changed), (create_per_account_local_outbox_folders),
2042 (get_server_accounts), (modest_tny_account_store_get_accounts),
2043 (modest_tny_account_store_get_tny_account_by_account),
2044 (modest_tny_folder_store_is_virtual_local_folders):
2046 * src/modest-tny-account.h:
2047 * src/modest-tny-account.c:
2048 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2049 to create an on-disk per-account local outbox folder for each
2051 (create_per_account_local_outbox_folders): Create a local outbox folder
2052 for each transport account.
2053 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2054 for all local folders.
2056 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2057 instead of using g_object_get/set() directly. It is clearer.
2059 (modest_tny_folder_store_get_message_count),
2060 (modest_tny_folder_store_get_local_size
2061 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2062 because we now use these with non-acount folder stores.
2064 (modest_tny_account_get_special_folder),
2065 (modest_tny_account_new_from_server_account),
2066 (modest_tny_account_new_from_account):
2067 (recurse_folders): Adjust to the new outbox system.
2069 * src/modest-tny-folder.h:
2070 * src/modest-tny-folder.c:
2071 (modest_tny_folder_is_local_folder),
2072 (modest_tny_folder_get_local_folder_type),
2073 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2075 * src/widgets/modest-main-window.h:
2076 * src/maemo/modest-main-window.c: (create_details_widget),
2077 (modest_main_window_set_contents_style): Show details for any folder store,
2080 (modest_tny_folder_get_rules):
2081 Remove the const. C does not support constness enough for this.
2083 * src/modest-ui-actions.c:
2084 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2085 make all outboxes appear as one, in the usual local-folders tree node.
2087 (set_active_account_from_tny_account),
2088 (modest_ui_actions_on_folder_selection_changed):
2089 * src/widgets/modest-folder-view.c: (text_cell_data),
2090 (icon_cell_data), (filter_row),
2091 (add_account_folders_to_merged_folder),
2092 (add_account_folders_to_simple_folder_store), (),
2093 (get_cmp_rows_type_pos), (cmp_rows),
2094 (modest_folder_view_set_account_id_of_visible_server_account):
2095 Adjust to the new outbox system, using generic folder stores and folders
2096 in the GtkTreeModel.
2098 2007-05-23 Christian Kellner <ckellner@openismus.com>
2100 * src/modest-mail-operation.c:
2101 (modest_mail_operation_update_account):
2102 Use info->max_size instead of unintialized local var [small
2103 build fix]. (Added TODO to review that change since I don't
2106 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2108 * libmodest-dbus-client/libmodest-dbus-client.c:
2109 (libmodest_dbus_client_compose_mail): function added
2110 * src/dbus_api/modest-dbus-api.h:
2111 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2112 (on_compose_mail): Implementation of the SendAsMail functionality
2114 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-account-mgr.c:
2117 (modest_account_mgr_add_server_account): Set the secure-connection
2118 conf key for transport accounts as well as store accounts. I don't know
2119 why the if was there. For instance, this makes sure that we use SSL
2120 for the gmail preset from the easysetup wizard.
2122 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2124 * src/gnome/modest-main-window.c:
2125 (on_account_store_connecting_finished), (connect_signals):
2126 * src/maemo/modest-main-window.c:
2127 (on_account_store_connecting_finished), (connect_signals),
2128 (modest_main_window_new):
2129 Handle TnyAccountStore::connecting-finished instead of
2130 TnyDevice::connection-changed, because we cannot actually perform
2131 operations on accounts until TnyAccountStore has itself responded to
2132 the TnyDevice::connection-changed signal. This prevents a GError from
2134 Do not try to update at startup, because we (at least on scratchbox)
2135 already do an update at startup when the device goes online.
2136 This prevents a GError from tinymail.
2137 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2138 Added TODO about stopping simultaneous operations.
2140 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2142 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2143 * src/modest-mail-operation-queue.c:
2144 (modest_mail_operation_queue_remove):
2145 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2146 about where they happened.
2148 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-ui-actions.c:
2151 (modest_ui_actions_on_password_requested): Make sure that the remember
2152 output parameter is always TRUE.
2154 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2156 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2157 Show a OK/Cancel dialog if the error is a question, though we still do not
2158 know anything more about what we are asking the user.
2159 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2160 Fix an uninitialized variable (helper). This is a logic error, however.
2162 2007-05-21 Christian Kellner <ckellner@openismus.com>
2164 * src/modest-search.h:
2165 Correct bit shifting in the ModestSearchFlags enum.
2167 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-tny-account.c:
2170 (modest_tny_account_new_from_server_account): Do not use the lsub and
2171 check-all hard-coded IMAP options when using POP.
2173 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2175 * src/modest-tny-account.c:
2176 (modest_tny_account_new_from_server_account):
2177 Use NULL for the secure-auth method for POP when Password auth has been
2178 specified by the user, as we already do for IMAP. "auth=Login" causes
2179 an error from camel or the server.
2181 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2183 * src/maemo/modest-account-settings-dialog.c:
2184 (create_page_account_details),
2185 (modest_account_settings_dialog_set_account_name):
2186 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2187 for the leave-on-server checkbox, rathr than just the checkbox, when
2188 the protocol is not POP.
2190 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2192 * src/widgets/modest-account-view.c:
2193 * src/widgets/modest-account-view.h:
2194 Added modest_account_view_select_account() which will be useful later
2195 to asynchronously re-select the edited account.
2197 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2199 * src/maemo/modest-account-settings-dialog.c:
2200 (modest_account_settings_dialog_set_account_name):
2201 Automatically choose the port numbers based on the secure authentication
2202 methods, if they have not been chosen before.
2203 This fixes projects.maemo.org bug NB#56273 .
2205 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2207 * src/maemo/modest-main-window-ui.h:
2208 * src/modest-ui-actions.c:
2209 * src/modest-ui-actions.h:
2210 Connect the Tools/SMTP Servers menu item to
2211 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2212 SMTP servers dialog, as in the UI specification and saves changes when it
2213 is closed. This fixed projects.maemo.org bug NB#56305 .
2215 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2217 * src/maemo/modest-connection-specific-smtp-window.c:
2218 (modest_connection_specific_smtp_window_init):
2219 Use gtk_window_set_default_size() to make this window big enough, so
2220 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2222 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2224 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2225 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2226 (modest_connection_specific_smtp_edit_window_init),
2227 Do not try to connect to a combobox signal before the combobox exists.
2228 This fixes the cras in projects.maemo.org bug NB#56288 .
2229 (modest_connection_specific_smtp_edit_window_get_settings):
2230 Remove the server_account_name parameter which was being checked for NULL
2231 though it was not used.
2233 * src/maemo/modest-connection-specific-smtp-window.c:
2234 (modest_connection_specific_smtp_window_fill_with_connections),
2235 (on_button_edit), (modest_connection_specific_smtp_window_init):
2236 Correct the number of treemodel columns to prevent a warning.
2237 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2238 libconic does not work.
2240 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2242 * src/modest-tny-account.c:
2243 (modest_tny_account_new_from_server_account):
2244 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2245 SMTP when "None" was chosen by the user. However, with my SMTP server that
2246 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2249 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2251 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2252 to explain the memory management issue with the ID in the ModestPair.
2254 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2255 (add_sending_page), (modest_account_assistant_finalize):
2256 * src/gnome/modest-gnome-global-settings-dialog.c:
2257 (create_updating_page), (create_composing_page):
2258 * src/gnome/modest-msg-edit-window.c: (get_transports),
2259 (init_window), (modest_msg_edit_window_finalize),
2260 (modest_msg_edit_window_get_msg_data):
2261 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2262 * src/gnome/modest-transport-widget.c:
2263 (modest_transport_widget_finalize), (smtp_configuration):
2264 * src/maemo/modest-maemo-global-settings-dialog.c:
2265 (create_updating_page), (create_composing_page):
2266 * src/maemo/modest-msg-edit-window.c: (get_transports),
2267 (init_window), (modest_msg_edit_window_finalize),
2268 (modest_msg_edit_window_get_msg_data),
2269 (modest_msg_edit_window_free_msg_data):
2270 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2271 (modest_store_widget_finalize):
2272 * src/maemo/modest-transport-widget.c:
2273 (modest_transport_widget_finalize), (smtp_configuration):
2274 * src/modest-main.c: (send_mail):
2275 * src/widgets/modest-combo-box.h:
2276 * src/widgets/modest-global-settings-dialog-priv.h:
2277 * src/widgets/modest-global-settings-dialog.c:
2278 (modest_global_settings_dialog_finalize):
2279 * src/widgets/modest-msg-edit-window.h:
2280 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2281 as long as the combo box, to prevent use of freed memory for the ID.
2283 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2285 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2286 get_accounts(), to make this clearer. Do not check for the enabled gconf
2287 key, because we do not use this for server accounts (at least, not yet).
2288 This allows us to send email again.
2290 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/modest-platform.c:
2293 (on_modest_conf_update_interval_changed), (modest_platform_init):
2294 Only respond to this particular key change. All these strcmp()s cannot be
2297 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2299 * src/maemo/modest-maemo-global-settings-dialog.c:
2300 (current_connection): Prevent a crash in scratchbox when
2301 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2302 * src/maemo/modest-platform.c:
2303 (on_modest_conf_update_interval_changed), (modest_platform_init):
2304 Get the update interval from gconf and reset it when the gconf key changes.
2306 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2308 * src/modest-protocol-info.c:
2309 * src/modest-protocol-info.h: Adde enum-specific get functions,
2310 instead of using a ModestProtocolType enum parameter.
2312 * src/gnome/modest-account-assistant.c:
2313 * src/gnome/modest-store-widget.c:
2314 * src/gnome/modest-store-widget.h:
2315 * src/gnome/modest-transport-widget.c:
2316 * src/gnome/modest-transport-widget.h:
2317 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2318 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2319 * src/maemo/easysetup/modest-easysetup-wizard.c:
2320 * src/maemo/modest-account-settings-dialog.c:
2321 * src/maemo/modest-account-settings-dialog.h:
2322 * src/maemo/modest-store-widget.c:
2323 * src/maemo/modest-store-widget.h:
2324 * src/maemo/modest-transport-widget.c:
2325 * src/maemo/modest-transport-widget.h:
2326 * src/modest-account-mgr-helpers.c:
2327 * src/modest-account-mgr-helpers.h:
2328 * src/modest-account-mgr.c:
2329 * src/modest-account-mgr.h:
2330 * src/modest-tny-account.c:
2331 * src/modest-tny-folder.c:
2332 * src/widgets/modest-account-view.c:
2333 * src/widgets/modest-retrieve-combo-box.c:
2334 * src/widgets/modest-retrieve-combo-box.h:
2335 * src/widgets/modest-secureauth-combo-box.c:
2336 * src/widgets/modest-serversecurity-combo-box.c:
2337 * src/widgets/modest-serversecurity-combo-box.h:
2338 * tests/check_account-mgr.c:
2339 Use the specific functions, and use the re-renamed enum values for GNOME too.
2341 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2343 * src/modest-pair.h:
2344 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2345 so we can get the second based on the first.
2347 * src/maemo/modest-account-settings-dialog.h:
2348 * src/maemo/modest-account-settings-dialog.c:
2349 Added get_supported_secure_authentication_methods(), though it is mostly
2350 commented-out for now until the necessary API is committed to tinymail.
2351 (modest_account_settings_dialog_set_account_name),
2352 (save_configuration): Request the supported authentication methods from the
2353 server, so we can choose a working method.
2355 * src/modest-tny-account-store.h:
2356 * src/modest-tny-account-store.c:
2357 (modest_tny_account_store_get_session): Rename from
2358 tny_account_store_get_session().
2360 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2362 * src/modest-protocol-info.h: Split the ModestProtocol enum
2363 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2364 There was no need to have these unrelated values in one enum.
2366 * src/: many files: Adapted to changed enum. This makes the code a bit
2367 clearer, and the compiler could catch some errors.
2369 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2371 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2372 Show the detailed internal camel error message when an error happens
2373 during the configuration, so that our testers can give us more clues.
2374 For instance, in projects.maemo.org bug NB#56910 .
2376 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2378 * src/modest-tny-account.c:
2379 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2380 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2382 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2384 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2385 * src/maemo/modest-account-settings-dialog.c:
2386 (modest_account_settings_dialog_set_account_name),
2387 (save_configuration): For the incoming secure authentication checkbox,
2388 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2389 the UI specification. PLAIN does not seem to be supported for most IMAP
2390 servers anyway, and I am not sure what it would mean.
2391 However, we probably need to discover which of the secure-authentication
2392 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2393 * src/modest-account-mgr-helpers.c:
2394 (modest_account_mgr_get_server_account_data):
2396 * src/modest-tny-account.c:
2397 (modest_tny_account_new_from_server_account):
2398 Use tny_account_set_mech() to set secure-authentication methods,
2399 with some special-casing for IMAP, based on my observations of how
2402 * src/modest-account-mgr-helpers.h:
2403 * src/modest-account-mgr.c:
2404 * src/modest-defs.h: Comment that the URI is only used for local folders.
2406 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2409 parameter const, just to be neat.
2410 * src/modest-text-utils.c: (modest_text_utils_inline):
2411 End g_strconcat() with NULL, as its documentation says. This is almost
2412 certainly the cause of my crash at startup on the device. Interestingly,
2413 valgrind doesn't tell us about these errors.
2415 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2417 * scripts/build-packages: Added more precise comments about how to use
2418 this script, though I still get this error:
2419 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2420 error building tinymail
2422 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2424 * src/maemo/modest-main-window.c: (on_account_update):
2425 Very slight cleanup, hoping to make it simpler to discover what causes
2426 a crash here sometimes.
2428 * src/modest-tny-account.c:
2429 (modest_tny_account_new_from_server_account): Set the port. Added
2430 comments about the options and a TODO comment because I need to find out
2431 how to specify the secure authentication method.
2433 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2435 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2436 changed CFlags paths form modest to libmodest
2438 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2440 * src/modest-account-mgr-helpers.c:
2441 (modest_account_mgr_get_server_account_data),
2442 (modest_account_mgr_free_server_account_data):
2443 * src/modest-account-mgr-helpers.h:
2444 * src/modest-account-mgr.c:
2445 (modest_account_mgr_add_server_account):
2446 * src/modest-defs.h:
2447 * src/modest-tny-account.c:
2448 (modest_tny_account_new_from_server_account):
2449 Determine the options for tny_camel_account_add_option() here,
2450 based on the settings, rather than storing them directly in gconf.
2452 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2454 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2455 Show a more friendly error dialog now that we expect (from the tinymail
2456 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2458 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2460 * src/maemo/modest-main-window.c: (on_account_update): Check that
2461 account_name is not NULL, to prevent a crash at startup that I am
2462 seeing on the N800. I do wonder why it is NULL.
2464 * src/maemo/easysetup/modest-easysetup-wizard.c:
2465 (create_page_user_details):
2466 * src/maemo/modest-account-settings-dialog.c:
2467 (create_page_user_details), (create_page_outgoing):
2468 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2469 (modest_connection_specific_smtp_edit_window_init):
2470 * src/modest-ui-actions.c:
2471 (modest_ui_actions_on_password_requested):
2472 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2473 might do something useful with the on-screen keyboard.
2475 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2477 * src/maemo/modest-main-window.c: (on_account_update):
2478 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2479 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2481 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2483 * src/modest-tny-account-store.c: (on_account_changed):
2484 Correct the signature of this signal handler.
2486 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2488 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2489 Show a HildonNote instead of a GtkDialog for Maemo.
2491 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2493 * src/widgets/modest-account-view.h:
2494 * src/widgets/modest-account-view.c: (on_account_changed),
2495 (on_account_removed). Added a boolean flag, set/unset by
2496 modest_account_view_block_conf_updates(),
2497 modest_account_view_unblock_conf_updates() to prevent unnecessary
2498 updates, but this is not very useful because the gconf notifications are
2499 so delays (maybe only on Maemo Bora).
2500 So auto-updating is turned off, and these functions do an explicit
2501 update when necessary.
2502 However, something else is still doing too much work when adding/removing
2503 accounts, probably in another part of the application.
2505 * src/maemo/modest-account-view-window.c:
2506 (on_delete_button_clicked), (on_edit_button_clicked),
2507 (on_new_button_clicked): Use the new functions.
2509 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2511 * src/modest-account-mgr-helpers.c:
2512 (modest_account_mgr_set_first_account_as_default):
2513 Sort the list of names alphabetically-by-title, so we choose the first one
2515 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2516 alphabetically by the title.
2518 This fixes projects.maemo.org bug NB#56418 .
2520 * src/modest-account-mgr-priv.c:
2521 (_modest_account_mgr_account_from_key):
2522 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2523 avoid a valgrind error, and possible random behaviour.
2525 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2527 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2528 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2529 tinymail documentation to say that this can be expected.
2530 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2531 pretty, and should not happen, but I would prefer to know when it does.
2533 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2535 * configure.ac: When using the older hildon version, probably on Bora,
2536 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2538 * src/widgets/modest-attachment-view.c:
2539 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2542 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2544 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2545 Implemented the prototype. Can be tested with
2546 tests/dbus_api/test_open_message:
2548 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2550 * src/modest-tny-account-store.c:
2551 (modest_tny_account_store_instance_init), (get_password):
2552 * src/modest-ui-actions.c:
2553 (modest_ui_actions_on_password_requested):
2554 Do not store the password in gconf, because this function is called
2555 for non-remembered passwords. Actually use the cached (in the hash map)
2556 password instead of releasing it.
2557 The password will now not be remembered if it is asked via the protected
2558 password dialog, as per the UI spec.
2560 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2562 * src/modest-defs.h:
2563 * src/modest-account-mgr-helpers.h:
2564 * src/modest-account-mgr-helpers.c:
2565 Added modest_server_account_get_username_has_succeeded(),
2566 modest_server_account_set_username_has_succeeded().
2567 (modest_server_account_set_username),
2568 Reset the has-succeeded flag if the username changes.
2570 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2571 * src/maemo/modest-connection-specific-smtp-window.c:
2572 (modest_connection_specific_smtp_window_save_server_accounts):
2573 Use modest_server_account_set_username() instead of using
2574 modest_conf_set_string() directly, so that the has-succeeded flag is always
2577 * src/modest-ui-actions.c:
2578 (modest_ui_actions_on_password_requested): Dim the username entry if
2579 the username has ever worked, as per the UI spec.
2581 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2583 * src/modest-tny-account-store.c: (get_password):
2584 * src/modest-ui-actions.c:
2585 (modest_ui_actions_on_password_requested):
2586 Allow the username to be changed too, though there is more work to
2587 be done on exactly how this behaves.
2589 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2591 * src/modest-account-mgr-helpers.h:
2592 * src/modest-account-mgr-helpers.c:
2593 Added modest_account_mgr_get_display_name(),
2594 modest_server_account_get_username(),
2595 modest_server_account_set_username(),
2596 modest_server_account_set_password(),
2597 modest_server_account_get_hostname() functions so we do not need to
2598 use the conf API directly.
2600 * src/maemo/modest-main-window.c: (connect_signals):
2601 Actually connect ot the ModestAccountStore::request-password signal,
2602 so that we show the dialog when the password is requested by Tinymail,
2603 for isntance if it is empty.
2605 * src/modest-marshal.list:
2606 * src/modest-tny-account-store.c:
2607 (modest_tny_account_store_class_init), (get_password),
2608 (modest_tny_account_store_alert):
2609 * src/modest-tny-account-store.h:
2610 * src/modest-ui-actions.h:
2611 * src/modest-ui-actions.c:
2612 (modest_ui_actions_on_password_requested):
2613 Change the signal parameters, so it is obvious that we are providing
2614 the non human-readable server name, and receiving both the username
2615 and password, though changing of the username is not yet implemented.
2616 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2617 for the GNOME version.
2619 This should fix the projects.maemo.org bug NB#56209, though it does not
2620 work on Bora, because the gconf_client_get() for the password fails
2621 immediately after we save it with gconf_client_set().
2623 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2626 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2627 caused an undefined symbol error:
2628 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2630 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2632 * src/modest-tny-account-store.c:
2633 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2634 using a GError instead of a string message, so we can translate it in
2637 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2639 * src/maemo/modest-address-book.c:
2640 (modest_address_book_check_names):
2641 * src/maemo/modest-msg-view-window.c:
2642 (modest_msg_view_window_clipboard_owner_change):
2643 * src/modest-init.c: (modest_init_init_ui):
2644 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2645 (update_folders_cb), (modest_mail_operation_update_account):
2646 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2647 (modest_ui_actions_on_msg_attachment_clicked),
2648 (modest_ui_actions_on_msg_recpt_activated):
2649 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2650 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2651 (modest_msg_view_search_next):
2652 * src/widgets/modest-recpt-editor.c:
2653 (modest_recpt_editor_on_button_release_event),
2654 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2655 g_message(). At this point we should only be seeing interesting errors on
2656 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2658 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2660 (modest_wizard_dialog_force_title_update):
2661 * src/maemo/easysetup/modest-wizard-dialog.h:
2662 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2663 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2664 can update the title when appropriate. Otherwise the title is wrong if the
2665 pages are added after adding the notebook to the dialog.
2666 This must be a problem in HildonWizardDialog too.
2667 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2669 * src/maemo/easysetup/modest-easysetup-wizard.c:
2670 (create_subsequent_customsetup_pages),
2671 (create_subsequent_easysetup_pages):
2672 Call modest_wizard_dialog_force_title_update() so that the title is
2673 correct even with GTK+ < 2.10.
2674 This fixes projects.maemo.org bug NB#56145 .
2676 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2678 * src/maemo/modest-platform.c:
2679 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2680 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2683 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2685 * src/widgets/modest-window.h:
2686 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2687 and modest_window_save_state(), which invokes it.
2689 * src/widgets/modest-window-mgr.h:
2690 * src/widgets/modest-window-mgr.c:
2691 Added modest_window_mgr_save_state_for_all_windows(), which calls
2692 the save_state vfunc on all registered windows, if implemented.
2694 * src/gnome/modest-msg-edit-window.c:
2695 * src/gnome/modest-msg-view-window.c:
2696 * src/maemo/modest-msg-edit-window.c:
2697 * src/maemo/modest-msg-view-window.c:
2698 * src/maemo/modest-main-window.c:
2699 Specify the existing save_settings functions as implementations of
2700 ModestWindow::save_state_func().
2702 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2703 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2704 enabling hibernation, for instance.
2706 We may need to do the same thing for restoring settings.
2709 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2711 * src/widgets/modest-window-mgr.c:
2712 * src/widgets/modest-window-mgr.h:
2713 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2714 modest_window_mgr_get_hibernation_is_prevented().
2716 * src/maemo/modest-main-window.c:
2717 (on_hildon_program_is_topmost_notify): Prevent hibernation
2718 (possible when the application goes to the background in the WM),
2719 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2721 * src/maemo/easysetup/modest-easysetup-wizard.c:
2722 (modest_easysetup_wizard_dialog_init):
2723 * src/maemo/modest-account-settings-dialog.c:
2724 (modest_account_settings_dialog_init):
2725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2726 (modest_connection_specific_smtp_edit_window_init):
2727 * src/maemo/modest-connection-specific-smtp-window.c:
2728 (modest_connection_specific_smtp_window_init):
2729 * src/maemo/modest-signature-editor-dialog.c:
2730 (modest_signature_editor_dialog_init):
2731 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2732 prevent hibernation while any of these account settings dialogs are open.
2734 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/Makefile.am:
2737 * src/maemo/modest-osso-state-saving.c:
2738 * src/maemo/modest-osso-state-saving.h: Added
2739 modest_osso_load_state() and modest_osso_save_state() though they do
2740 nothing now. They should iterate through all the open windows and load/save
2742 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2743 save state when closing.
2745 * src/maemo/modest-main-window.c:
2746 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2747 Add a notification handler for the HildonProgram::is-topmost property,
2748 so we can allow hibernation when the application goes into the background.
2749 But we still need to detect when the accounts setup windows are open so
2750 we can stop hibernation when they are open.
2751 To do this, I also added the main window the HildonProgram. This might have
2752 other side-effects/benefits, and should maybe be done for other windows.
2754 * src/maemo/modest-osso-autosave-callbacks.h:
2755 * src/maemo/modest-osso-autosave-callbacks.c:
2756 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2757 though it does not do anything yet, and we might never need this to do
2758 anything. For instance, we already save drafts.
2760 * src/maemo/modest-platform.c: (modest_platform_init):
2761 Specify the libosso auto-save callback.
2763 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2765 * src/maemo/modest-platform.c:
2766 (modest_platform_set_update_interval):
2767 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2768 aparently stays valid between application instances, so we can use this
2769 to remove and reset it later. According to a maemo-developers email from
2772 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2774 * configure.ac: Depend on libalarm for Maemo.
2776 * src/dbus_api/modest-dbus-api.h:
2777 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2778 (on_send_receive), (modest_dbus_req_handler):
2779 Handle a SEND_RECEIVE D-Bus method.
2781 * libmodest-dbus-client/libmodest-dbus-client.c:
2782 (libmodest_dbus_client_send_and_receive):
2783 * libmodest-dbus-client/libmodest-dbus-client.h:
2784 Add C convenience functions for calling the new D-Bus method.
2786 * src/modest-platform.h:
2787 * src/gnome/modest-platform.c:
2788 * src/maemo/modest-platform.c:
2789 Added modest_platform_set_update_interval(), which uses the
2790 alarmd API on Maemo.
2791 (modest_platform_init),
2792 Call modest_platform_set_update_interval(), using a hard-coded
2793 interval for now (until the global settings dialog is implemented),
2794 though I am not sure that this makes sense yet.
2796 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2798 * src/dbus_api/modest-dbus-callbacks.c:
2799 (modest_osso_cb_hw_state_handler):
2800 * src/dbus_api/modest-dbus-callbacks.h:
2801 * src/maemo/modest-platform.c: (modest_platform_init):
2802 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2803 in case this has some effect on the ability for Maemo to ping the
2806 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2808 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2809 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2810 warning. It is probably a logic error, but I need to fix the build.
2812 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2814 * src/modest-account-mgr.h:
2815 * src/modest-account-mgr.c:
2816 (modest_account_mgr_account_names): Add a gboolean enabled_only
2817 parameter, so we can get lists of onlt the enabled accounts.
2819 (modest_account_mgr_add_account),,
2820 (modest_account_mgr_account_with_display_name_exists):
2821 * src/maemo/modest-msg-edit-window.c: (get_transports):
2822 * src/modest-account-mgr-helpers.c:
2823 (modest_account_mgr_set_first_account_as_default):
2824 * src/modest-init.c: (init_default_account_maybe):
2825 * src/modest-tny-account-store.c: (get_accounts):
2826 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2827 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2828 * tests/check_account-mgr.c: (START_TEST):
2829 Provide the extra parameter, as appropriate.
2831 * src/widgets/modest-account-view.c: (update_account_view):
2832 Do not show disabled accounts (meaning that there is no way to
2833 enable/disable accounts in the UI (the feature is not in our UI
2834 specification), so we can use this internally only to mark unfinished
2835 or temporary account data.
2837 * src/maemo/easysetup/modest-easysetup-wizard.c:
2838 (create_account): Add boolean enable parameter, so we can specify FALSE
2839 to create the temporary account.
2840 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2841 (on_before_next): When finishing, when there is a temporary account, just
2843 Also, use a timeout to delay the showing of the dialog until gconf is likely
2844 to return correct information, due to a maemo gconf bug that is fixed in
2845 osso 1.1, but not yet in Bora.
2846 However, the dialog stays on screen after it is destroyed.
2848 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2849 for invalid data when cancelling. Use a hildon note instead of a dialog
2850 to complain about invalid data. Do not show the account-saved note if the
2851 account is disabled (a temporary account that will not really be saved for use
2854 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2856 * src/modest-account-mgr-helpers.h:
2857 * src/modest-account-mgr-helpers.c:
2858 Added modest_account_mgr_unset_default_account(),
2859 Added modest_account_mgr_set_first_account_as_default().
2861 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2862 If it was the default account, unset the default account name.
2864 * src/maemo/modest-account-view-window.c:
2865 (on_delete_button_clicked): If it was the default account,
2866 set the first remaining account as the default instead.
2868 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2869 a NULL account or a NULL default account, to prevent a crash. This should
2870 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2873 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2875 * src/widgets/modest-recpt-editor.c:
2876 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2877 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2878 TODO comment for this. This fixes the build.
2880 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2881 be the best place for it. This will in future update all auto-update accounts,
2882 rather than just the current/default account, when that gconf key exists.
2883 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2884 if there are no accounts, before calling do_send_receive().
2885 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2887 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2888 * src/maemo/modest-main-window-ui.h:
2889 * src/maemo/modest-main-window.c: (on_connection_changed),
2890 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2891 directly, becaue the signal handler does more.
2893 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2895 * src/modest-account-mgr-helpers.c:
2896 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2897 for the case that the account does not exist.
2899 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2900 (equivalent to the modest account name) rather than the tinymail account name
2901 (equivalent to the modest account title - human readable) to get the account data.
2902 Check for null account data to prevent the crash, and add a TODO comment saying that
2903 this needs fixing because it is using the server account name instead of the account name.
2905 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2907 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2908 * src/maemo/modest-account-settings-dialog.c: (show_error),
2910 Use hildon_note_new_information() for informative and error messages,
2911 which seems to be expected for Maemo applications (no documentation that I know of
2912 says this). I am surprised that there is no distinction between info and error
2915 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2917 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2918 it is easy to find where this is used.
2920 * src/maemo/easysetup/modest-easysetup-wizard.c:
2921 (create_page_welcome), (create_page_account_details),
2922 (create_page_user_details), (create_page_complete_easysetup),
2923 (create_page_custom_incoming), (create_page_custom_outgoing),
2924 (create_page_complete_custom):
2925 * src/maemo/modest-account-settings-dialog.c:
2926 (create_page_account_details), (create_page_user_details),
2927 (create_page_incoming), (create_page_outgoing):
2928 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2929 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2930 (modest_connection_specific_smtp_edit_window_init):
2931 * src/maemo/modest-connection-specific-smtp-window.c:
2932 (modest_connection_specific_smtp_window_init):
2933 * src/maemo/modest-signature-editor-dialog.c:
2934 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2935 and scrolling policy as per the Email Application Layout Guide, if I have
2938 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2941 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2942 which were empty, because these vfuncs have been removed from TnyAccountStore.
2943 This fixes the build.
2945 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2947 * src/maemo/modest-main-window.c:
2948 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2949 showing/hiding it. Added TODO because it probably should not be NULL.
2950 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2951 because unnecessary g_warnings() make degugging difficult.
2953 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/modest-msg-edit-window.c:
2956 (modest_msg_edit_window_select_color),
2957 (modest_msg_edit_window_select_background_color): 2 const corrections and
2958 moving 2 #endifs before closing brackets, to fix the build.
2960 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2962 * src/maemo/easysetup/modest-easysetup-wizard.h:
2963 * src/maemo/easysetup/modest-easysetup-wizard.c:
2964 (modest_easysetup_wizard_dialog_finalize),
2965 (on_button_edit_advanced_settings), (create_page_complete_custom),
2966 (on_response), (create_account):
2967 Implement the Advanced Settings edit button, by saving the account information,
2968 for the Advanded Settings dialog to use directly from gconf, and removing it
2969 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2970 Bug #5533 in the projects.maemo.org bugzilla.
2972 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/modest-msg-view-window.c:
2975 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2976 when opening a message window.
2978 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2980 * src/maemo/easysetup/modest-easysetup-wizard.c:
2981 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2984 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2985 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2986 gconf settings. I probably added more checks than necessary, but that is safer.
2988 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2989 variable to fix the build, but this seems to be used when it is still NULL.
2991 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2993 * src/modest-platform.h:
2994 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2995 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2996 * src/modest-main.c: Implement this function so we can avoid using
2997 maemo-specific API from cross-platform code.
2999 * src/modest-tny-account-store.c:
3000 (get_smtp_specific_transport_account_for_open_connection):
3001 * src/modest-ui-actions.c: (check_for_connection),
3002 (modest_ui_actions_on_item_not_found):
3003 Use modest_platform_connect_and_wait() and put #idefs around other
3004 maemo-specific code, because only maemo currently has a way to
3005 identify connection names.
3007 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3009 * src/modest-tny-account-store.h:
3010 * src/modest-tny-account-store.c:
3011 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3012 the connection-specific SMTP server settings in the configuration.
3014 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3016 * src/maemo/modest-main-window.c: (on_connection_changed),
3018 * src/modest-main.c: (main), (start_ui), (send_mail):
3019 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3020 that is what is intended.
3022 * src/modest-ui-actions.c: (action_send), (action_receive),
3023 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3024 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3025 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3026 SMTP server is used when it is specified.
3028 (modest_ui_actions_on_send_receive):
3029 Check that a connection is open before proceeding.
3030 Receive and then send, instead of vice-versa, as per the specification.
3032 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3034 * src/modest-mail-operation.c:
3035 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3036 though I guess it should be something other than NULL.
3038 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3040 * src/maemo/easysetup/modest-easysetup-wizard.c:
3041 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3042 combo twice, to avoid an g_warning and to make it visible again.
3043 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3044 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3045 (already intended) dereference when detaching, because we then recreate the menu.
3046 But I am not sure why the warning was happening, and it is possible that this is a memory
3049 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3051 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3052 and uri_parse_mailto() utility functions.
3053 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3055 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3057 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3059 * src/dbus_api/modest-dbus-api.h:
3060 * src/dbus_api/modest-dbus-callbacks.c:
3061 Use an idle callback to execute the modest code in the application's own thread.
3062 Remove the helloworld example method.
3063 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3064 parsed, and the open-message method is not implemented because this is not yet implemented in
3066 * libmodest-dbus-client/libmodest-dbus-client.c:
3067 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3068 (libmodest_dbus_client_open_message):
3069 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3071 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3072 body without crashing.
3074 * tests/dbus_api/Makefile.am:
3075 * tests/dbus_api/test_mail_to.c:
3076 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3078 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3080 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3081 Added file to fix the build. Sorry.
3083 * src/dbus_api/Makefile.am:
3084 * src/dbus_api/modest-dbus-api.h:
3085 * src/dbus_api/modest-dbus-callbacks.h:
3086 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3087 (modest_dbus_req_handler):
3088 Put constants in a separate header so it can be reused by the
3089 client library, without duplication
3091 * libmodest-dbus-client/Makefile.am:
3092 * libmodest-dbus-client/libmodest-dbus-client.c:
3093 (libmodest_dbus_client_call_helloworld),
3094 (libmodfest_dbus_client_send_mail),
3095 (libmodfest_dbus_client_mailto),
3096 (libmodfest_dbus_client_open_message):
3097 * libmodest-dbus-client/libmodest-dbus-client.h:
3098 (Partly) Implement a send_mail D-Bus method.
3100 * tests/dbus_api/Makefile.am:
3101 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3102 the send_email D-Bus method.
3104 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3108 * libmodest-dbus-client/Makefile.am:
3109 * libmodest-dbus-client/libmodest-dbus-client.c:
3110 * libmodest-dbus-client/libmodest-dbus-client.h:
3111 * tests/dbus_api/Makefile.am:
3112 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3113 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3115 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3117 * src/maemo/easysetup/modest-easysetup-wizard.c:
3118 (create_page_account_details):
3119 * src/maemo/modest-account-settings-dialog.c:
3120 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3121 widgets, because this might not be the default in future versions of the Maemo GTK+.
3122 However, I can not not get capitalization to work even in a simple test case.
3124 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3126 * src/maemo/easysetup/modest-easysetup-wizard.c:
3127 (create_page_custom_incoming), (create_page_custom_outgoing):
3128 * src/maemo/modest-account-settings-dialog.c:
3129 (create_page_account_details), (create_page_incoming),
3130 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3131 instead of using gtk_check_button_with_label(), so they are aligned like the other
3132 widgets, as per the UI spec.
3134 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3136 * src/maemo/easysetup/modest-easysetup-wizard.c:
3137 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3138 * src/widgets/modest-validating-entry.c:
3139 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3140 Modest prefix instead of an EasySetup prefix.
3142 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3144 * src/widgets/modest-validating-entry.h:
3145 * src/widgets/modest-validating-entry.c: (on_insert_text),
3146 Added easysetup_validating_entry_set_max_func(), used to set a callback
3147 to call when the max number of characters is reached. GtkEntry has a max-length
3148 already but is silent about it.
3150 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3151 (create_page_account_details), (create_page_user_details),
3153 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3154 (create_page_account_details), (create_page_user_details),
3155 (create_page_outgoing):
3156 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3157 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3158 the UI spec, when the user tries to enter more than the max number of characters.
3160 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3162 * src/maemo/easysetup/modest-easysetup-wizard.c:
3163 (create_page_user_details), (create_page_custom_incoming),
3164 (create_page_custom_outgoing):
3165 * src/maemo/modest-account-settings-dialog.c:
3166 (create_page_user_details), (create_page_incoming),
3167 (create_page_outgoing):
3168 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3169 (modest_connection_specific_smtp_edit_window_init):
3170 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3171 not appropriate. Bad Maemo-specific defaults!.
3173 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3175 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3176 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3177 (modest_signature_editor_dialog_set_settings):
3178 Disable the label and textview when the checkbox is disabled, and use the
3179 specified (UI spec) default signature text.
3181 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3183 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3184 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3186 * src/modest-defs.h:
3187 * src/modest-account-mgr-helpers.h:
3188 * src/modest-account-mgr-helpers.c:
3189 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3191 * src/maemo/Makefile.am:
3192 * src/maemo/modest-signature-editor-dialog.c:
3193 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3196 * src/maemo/modest-account-settings-dialog.h:
3197 * src/maemo/modest-account-settings-dialog.c:
3198 (modest_account_settings_dialog_finalize), (on_button_signature),
3199 (save_configuration): Use the new dialog when the Edit button is pressed, and
3200 save the changes if necessary, as per the UI spec.
3202 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3204 * src/maemo/Makefile.am:
3205 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3206 based on maemo-develoers email from Dirk.
3208 * src/maemo/easysetup/modest-easysetup-wizard.c:
3209 (create_page_welcome), (create_page_account_details),
3210 (create_page_user_details), (create_page_complete_easysetup),
3211 (create_page_custom_incoming), (create_page_custom_outgoing),
3212 (create_page_complete_custom),
3213 (modest_easysetup_wizard_dialog_init):
3214 * src/maemo/modest-account-settings-dialog.c:
3215 (create_page_account_details), (create_page_user_details),
3216 (create_page_incoming), (create_page_outgoing),
3217 (modest_account_settings_dialog_init):
3218 * src/maemo/modest-connection-specific-smtp-window.c:
3219 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3221 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3223 * src/maemo/easysetup/modest-easysetup-wizard.c:
3224 (create_page_account_details), (create_page_custom_outgoing),
3225 (create_page_complete_custom):
3226 * src/maemo/modest-account-settings-dialog.c:
3227 (create_page_user_details), (create_page_incoming),
3228 (create_page_outgoing):
3229 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3230 (modest_connection_specific_smtp_edit_window_init):
3231 Use the correct (UI spec) port min/max, and use horizontal separators,
3234 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3236 * src/maemo/easysetup/modest-easysetup-wizard.c:
3237 (set_default_custom_servernames):
3238 * src/maemo/modest-account-settings-dialog.c:
3239 (create_page_incoming), (on_combo_outgoing_security_changed),
3240 (on_combo_incoming_security_changed), (create_page_outgoing),
3241 (modest_account_settings_dialog_set_account_name),
3242 (save_configuration):
3243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3244 (on_combo_security_changed),
3245 (modest_connection_specific_smtp_edit_window_init),
3246 (modest_connection_specific_smtp_edit_window_set_connection),
3247 (modest_connection_specific_smtp_edit_window_get_settings):
3248 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3251 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3254 * src/maemo/easysetup/modest-easysetup-wizard.c:
3255 (create_page_custom_outgoing), (create_page_complete_custom):
3256 * src/maemo/modest-account-settings-dialog.c:
3257 (create_page_user_details), (create_page_outgoing):
3258 * src/maemo/modest-account-view-window.c: (button_box_new):
3259 Use changed logical IDs as per the most recent UI spec:
3260 mcen_bd_emailsetup_edit -> mcen_bd_edit
3261 mcen_bd_emailsetup_delete -> mcen_bd_delete
3262 mcen_bd_emailsetup_close -> mcen_bd_close
3264 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3268 * src/dbus_api/Makefile.am:
3269 * src/dbus_api/modest-dbus-callbacks.c:
3270 * src/dbus_api/modest-dbus-callbacks.h:
3271 * src/maemo/modest-platform.c: (modest_platform_init):
3272 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3274 * tests/Makefile.am:
3275 * tests/dbus_api/Makefile.am:
3276 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3278 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3280 * src/maemo/modest-account-settings-dialog.c:
3281 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3282 Removed unnecessary includes.
3284 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3286 * src/maemo/easysetup/modest-easysetup-wizard.c:
3287 * src/maemo/modest-account-settings-dialog.c:
3288 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3289 * src/widgets/Makefile.am:
3290 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3291 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3292 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3293 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3294 * src/widgets/modest-secureauth-combo-box.c:
3295 * src/widgets/modest-secureauth-combo-box.h:
3296 * src/widgets/modest-serversecurity-combo-box.c:
3297 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3298 made the GObject names more consistent with the rest of the Modest code.
3300 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3302 * src/maemo/easysetup/Makefile.am:
3303 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3304 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3305 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3306 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3307 * src/maemo/easysetup/modest-easysetup-wizard.c:
3308 * src/maemo/easysetup/modest-validating-entry.c:
3309 * src/maemo/easysetup/modest-validating-entry.h:
3310 * src/maemo/modest-account-settings-dialog.c:
3311 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3312 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3313 widgets/ because they are used outside of easysetup too. After checking in,
3314 svn will allow me to rename them too.
3316 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3318 * src/gnome/modest-msg-edit-window.c:
3319 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3320 linker error, to fix the build on the GNOME platform.
3321 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3322 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3323 ifdefed out to avoid a warning.
3325 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3327 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3328 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3329 some alternative for GTK+ 2.6.
3331 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3333 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3335 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3336 specified for EmailAccountsDialog in UI spec.
3338 * src/maemo/easysetup/modest-easysetup-wizard.c:
3339 * src/maemo/easysetup/modest-easysetup-wizard.h:
3340 * src/maemo/modest-account-settings-dialog.c:
3341 * src/maemo/modest-account-settings-dialog.h:
3342 Reuse a member window widget for the connection-specific SMTP server accounts,
3343 so we can tell it to create/save the accounts only if we actually save changes.
3345 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3346 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3347 (modest_connection_specific_smtp_edit_window_get_settings):
3348 Return a struct instance for temporarily remembering the entered data.
3350 * src/maemo/modest-connection-specific-smtp-window.h:
3351 * src/maemo/modest-connection-specific-smtp-window.c:
3352 (modest_connection_specific_smtp_window_finalize),
3353 (modest_connection_specific_smtp_window_fill_with_connections),
3355 (modest_connection_specific_smtp_window_save_server_accounts),
3356 (update_model_server_names): Do not actually save data until asked,
3357 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3359 (on_selection_changed),
3360 (modest_connection_specific_smtp_window_init): Disable the edit
3361 button when nothing is selected.
3363 * src/modest-account-mgr-helpers.c:
3364 * src/modest-account-mgr-helpers.h:
3365 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3368 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3370 * src/modest-account-mgr-helpers.h:
3371 * src/modest-account-mgr-helpers.c:
3372 (modest_account_mgr_get_unused_account_name),
3373 (modest_account_mgr_get_unused_account_display_name): Added these
3374 utility functions, to avoid code duplication.
3376 * src/maemo/easysetup/modest-easysetup-wizard.c:
3377 (create_page_account_details), (create_account):
3378 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3379 (on_combo_security_changed),
3380 (modest_connection_specific_smtp_edit_window_init),
3381 (modest_connection_specific_smtp_edit_window_save_settings):
3382 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3383 * src/maemo/modest-connection-specific-smtp-window.c:
3384 (modest_connection_specific_smtp_window_finalize),
3385 (modest_connection_specific_smtp_window_fill_with_connections),
3386 (on_button_edit), (modest_connection_specific_smtp_window_init):
3387 * src/maemo/modest-connection-specific-smtp-window.h:
3388 Implementing saving of connection-specific server accounts.
3390 But I need to refactor this so we can save the data for each
3391 possible connection-specific account and only actually create the server accounts
3392 when the easysetup finished, or the OK button is pressed on the account settings
3395 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3397 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3398 (on_combo_security_changed):
3399 (modest_connection_specific_smtp_edit_window_init):
3400 Auto-fill the port number as in the account settings.
3402 (modest_connection_specific_smtp_edit_window_set_connection):
3403 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3404 * src/maemo/modest-connection-specific-smtp-window.c:
3405 (fill_with_connections), (on_button_edit),
3406 (modest_connection_specific_smtp_window_init):
3407 Turn the edit window into a dialog to simplify the code, and
3408 set a WM hint as in a GtkDialog, because only a popup can be on top of
3409 another window in Maemo, and popups usually have no WM decoration.
3411 * src/modest-defs.h:
3412 * src/modest-account-mgr-helpers.c:
3413 (modest_account_mgr_set_connection_specific_smtp),
3414 (modest_account_mgr_remove_connection_specific_smtp),
3415 (modest_account_mgr_get_connection_specific_smtp):
3416 * src/modest-account-mgr-helpers.h: Some functions to write the
3417 connection-specific SMTP server information. Not yet used.
3420 * src/widgets/modest-folder-view.c: (text_cell_data):
3421 Fix a warning about an uninitialized variable.
3422 (on_configuration_key_changed): Put an #ifdef around the use
3423 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3425 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3427 * src/maemo/modest-account-settings-dialog.h:
3428 * src/maemo/modest-account-settings-dialog.c:
3429 Added connect_for_modified() utility function to mark the new modified boolean.
3431 (create_page_account_details), (create_page_user_details),
3432 (create_page_incoming), (create_page_outgoing), (on_response),
3433 (modest_account_settings_dialog_init),
3434 (modest_account_settings_dialog_set_account_name):
3435 Only warn about unsaved changes when there are actually unsaved changes.
3437 * src/modest-account-mgr-helpers.c:
3438 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3439 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3440 to get the data from there in future.
3442 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3444 * src/modest-defs.h:
3446 * src/modest-account-mgr-helpers.h:
3447 * src/modest-account-mgr-helpers.c:
3448 Store the security account setting in a single conf key instead of using
3449 the options list, so that the list is left for just the to-be-removed camel hack,
3450 and because gconf_client_set_list() is failing for some reason.
3452 * src/modest-account-mgr.c:
3453 (modest_account_mgr_add_server_account):
3454 * src/maemo/modest-account-settings-dialog.c:
3455 (modest_account_settings_dialog_set_account_name),
3456 (save_configuration): Use the renamed functions.
3459 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3461 * src/widgets/Makefile.am:
3462 * src/widgets/modest-limit-retrieve-combo-box.c:
3463 * src/widgets/modest-limit-retrieve-combo-box.h:
3464 * src/widgets/modest-retrieve-combo-box.c:
3465 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3466 the account settings dialog.
3468 * src/modest-defs.h:
3469 * src/modest-account-mgr-helpers.h:
3470 * src/modest-account-mgr-helpers.c:
3471 (modest_server_account_get_option_secure_auth),
3472 (modest_server_account_set_option_secure_auth):
3473 * src/modest-account-mgr.c:
3474 (modest_account_mgr_add_server_account):
3475 Use the existing AUTH_MECH conf key for the secure-auth setting,
3476 instead of putting it in the list options, because this was actually used already.
3478 * src/maemo/modest-account-settings-dialog.c:
3479 (create_page_account_details),
3480 (modest_account_settings_dialog_set_account_name),
3481 (save_configuration):
3482 * src/maemo/modest-account-settings-dialog.h:
3483 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3484 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3486 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3488 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3489 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3490 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3492 * src/modest-defs.h:
3493 * src/maemo/modest-account-settings-dialog.c:
3494 (create_page_incoming), (on_combo_outgoing_security_changed),
3495 (on_combo_incoming_security_changed), (create_page_outgoing),
3496 (modest_account_settings_dialog_set_account_name),
3497 (save_configuration): Load/Save the port number, and change it when the
3498 security combo changes, to suitable defaults.
3500 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3502 * src/modest-account-mgr.c:
3503 (modest_account_mgr_add_server_account): Set the security and secure-auth
3504 options, and add a comment saying that the other camel-specific options should be
3507 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3509 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3511 * src/modest-tny-account-store.c: (account_list_free),
3512 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3513 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3516 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3518 * src/modest-protocol-info.c:
3519 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3520 is required by our UI spec. Maybe something in our implementation will use this eventually.
3521 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3522 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3523 instead of the previous 0 placeholder.
3525 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3526 secure-auth settings.
3527 * src/modest-account-mgr-helpers.h:
3528 * src/modest-account-mgr-helpers.c:
3529 (modest_server_account_data_get_option_secure_auth),
3530 (modest_server_account_set_option_secure_auth),
3531 (modest_server_account_data_get_option_security),
3532 (modest_server_account_set_option_security): Added this API for getting and setting the security
3533 and secure-auth settings.
3535 * src/maemo/modest-account-settings-dialog.h:
3536 * src/maemo/modest-account-settings-dialog.c:
3537 (modest_account_settings_dialog_finalize), (check_data),
3538 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3539 about changing titles.
3540 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3541 (save_configuration): Save the security and secure-auth settings.
3543 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3544 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3546 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3548 * src/modest-defs.h:
3549 * src/modest-account-mgr.c:
3550 (modest_account_mgr_add_server_account):
3551 Added and used defines for the options key and value pair strings,
3552 that are used so far, though they do not seem to correspond to anything in our
3553 UI specs or ModestProtocol enum.
3555 * src/modest-account-mgr-helpers.h:
3556 * src/modest-account-mgr-helpers.c:
3557 (compare_option_strings_for_name),
3558 (modest_server_account_data_get_option_value),
3559 (modest_server_account_data_get_option_bool),
3560 (modest_account_mgr_get_server_account_option):
3561 Added helper functions for parsing the options GSList.
3563 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3565 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3566 display name is based on the supplied account name.
3567 * src/modest-account-mgr.c:
3568 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3569 with an inefficient, but good-enough, implementation.
3571 * src/maemo/easysetup/modest-easysetup-wizard.c:
3572 (create_page_account_details), (on_before_next), (create_account):
3573 Check for existing display names rather than (non-user-visible) account names, and just
3574 create and set a unique account name at the end.
3576 * src/maemo/modest-account-settings-dialog.c:
3577 (modest_account_settings_dialog_init),
3578 (modest_account_settings_dialog_set_account_name),
3579 (create_page_incoming): Show the display name, instead of the account name.
3580 (on_response): Do some (not all) extra checks, as in the UI spec.
3581 (save_configuration): Save the display name if it was changed.
3583 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3585 * po/en_GB.po: Added needed logical ID and translation.
3586 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3587 (init_view): Made the is-default column clicking work.
3589 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3592 * src/maemo/easysetup/Makefile.am:
3593 * src/maemo/easysetup/modest-easysetup-wizard.c:
3594 (modest_easysetup_wizard_dialog_init):
3595 * src/maemo/easysetup/provider-data-test.keyfile:
3596 * src/maemo/easysetup/provider-data.keyfile:
3597 Moved the provider data file to the new modest-providers-data package and used it from there.
3599 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3601 * src/modest-local-folder-info.c:
3602 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3603 N_() was already used on the static strings, but this just marks it for translation without
3604 using the translation.
3606 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3608 * src/maemo/modest-account-settings-dialog.c:
3609 (create_page_incoming),
3610 (modest_account_settings_dialog_set_account_name):
3611 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3612 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3613 I will do this if nobody else gets there first.
3615 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3617 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3618 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3619 save the security stuff.
3621 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3623 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3624 Set the email address and user fullname, which I now see must be
3627 * src/maemo/modest-account-settings-dialog.h:
3628 * src/maemo/modest-account-settings-dialog.c:
3630 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3631 leave-on-server and authentication.
3632 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3635 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3638 * src/maemo/modest-account-settings-dialog.c:
3639 * src/maemo/modest-account-settings-dialog.h:
3640 Most (but not all) of the widgets are now present as specified by the UI spec.
3641 No changes are yet saved, and some details are not properly shown yet.
3643 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3645 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3647 * src/maemo/Makefile.am:
3648 * src/maemo/modest-account-settings-dialog.c:
3649 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3650 an existing account. Doesn't do much yet.
3652 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3653 Open the accounts settings dialog when Edit is clicked.
3655 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3657 * src/maemo/easysetup/Makefile.am:
3658 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3660 * src/maemo/easysetup/modest-easysetup-wizard.c:
3661 (modest_easysetup_wizard_dialog_init):
3662 Try to get the source directory from the build system,
3663 instead of hard-coding "./" into the source code, when opening our local
3664 copies of the configuration files.
3665 But this still fails when opening the wizard from the Accounts window,
3666 maybe because the working directory seems to change at runtime.
3667 So the wizard will fail the second time unless you copy the files into their
3668 proper locations - see the stdout warnings for the paths.
3670 (create_page_account_details),(on_before_next):
3671 Check for existing non-server accounts instead of server accounts,
3672 so the default account name is useful again, and to prevent trying to
3675 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3676 Show the wizard when New is clicked.
3678 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3679 (init_view): Show the column headers, and show the columns that are
3680 specified in the UI specs. However, something in Maemo's GTK+ prevents
3681 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3682 change the default account. This is despite unsetting the special properties.
3684 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3686 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3687 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3688 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3689 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3690 to make that clearer.
3691 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3693 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3695 * src/maemo/modest-account-view-window.c:
3696 (modest_account_view_window_init),
3697 (modest_account_view_window_new):
3698 Use the same buttons as specified in the
3699 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3700 the existing widgets, which never had a chance of working.
3701 Put the ModestAccountView treeview in a scrolled window.
3702 Do not repeat the initialization in both _init() and _new().
3704 * src/widgets/modest-account-view.c: (update_account_view):
3705 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3706 this widget and window shows no accounts.
3708 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3710 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3712 * src/maemo/easysetup/modest-easysetup-wizard.c:
3713 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3714 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3715 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3718 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3719 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3720 accounts exist yet, as in the UI spec.
3722 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3724 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3726 * src/maemo/Makefile.am:
3727 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3728 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3729 New window for editing connection-specific smtp details.
3730 Not fully implemented.
3732 * src/maemo/modest-connection-specific-smtp-window.c:
3733 (modest_connection_specific_smtp_window_finalize) :
3734 unref the tree model.
3735 (on_button_edit): Show the edit window.
3737 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3739 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3742 * src/maemo/Makefile.am:
3743 * src/maemo/modest-connection-specific-smtp-window.c:
3744 * src/maemo/modest-connection-specific-smtp-window.h:
3745 New window for showing the list of connections, for connection-specific
3746 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3747 * src/maemo/easysetup/modest-easysetup-wizard.c:
3748 (create_page_custom_outgoing): Show the new window when the button is clicked.
3750 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3752 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3753 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3754 * src/maemo/modest-msg-edit-window.c:
3755 (modest_msg_edit_window_insert_image):
3756 * src/modest-conf.c: (modest_conf_key_escape):
3757 * src/modest-mail-operation.c:
3758 (modest_mail_operation_send_new_mail):
3759 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3760 (modest_ui_actions_on_new_account):
3761 * src/widgets/modest-attachment-view.c: (update_filename_request):
3762 * src/widgets/modest-mail-header-view.c:
3763 Corrected warnings that were breaking the build, by commenting out unused variables,
3764 and a function, and by including a header.
3766 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3768 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3769 so we can #ifdef around platform-specific code when necessary.
3770 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3771 to allow this to build for the GNOME platform too.
3773 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3775 * src/maemo/easysetup/modest-easysetup-wizard.c:
3776 Added util_increment_name() and used it in create_page_account_details()
3777 to make sure that the default account name is always a new name.
3779 (modest_easysetup_wizard_dialog_init),
3780 (set_default_custom_servernames): Some minor memory management fixes.
3782 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3786 * src/modest-runtime.c: (init_i18n): Restored the translation
3787 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3788 are defined in config.h, and the translations are installed.
3790 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3791 is defined for translation.
3793 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3795 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3797 * src/maemo/easysetup/modest-easysetup-wizard.c:
3798 (modest_easysetup_wizard_dialog_init):
3799 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3800 Use realistic paths (though they should use $prefix generically) to the
3801 mcc_mapping and provider-data.keyfile files which might work when they
3802 are installed by the future version of the operator-wizard package,
3803 and then fallback to paths in our source code, with an explanatory
3806 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3810 * src/maemo/Makefile.am:
3811 * src/maemo/easysetup/: Added files from the previously-exernal
3812 osso-modest-easysetup.
3813 * src/maemo/modest-main-window-ui.h:
3814 * src/modest-ui-actions.c:
3815 * src/modest-ui-actions.h:
3816 Added modest_ui_actions_on_new_account() as a signal handler for the
3817 New Account menu item. It shows the easysetup wizard.
3818 * po/en_GB.po: Added additional needed logical IDs and translations.