git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
   4         Comment out an if() that checks a gchar for < 0, causing a build-breaking
   5         warning. It is probably a logic error, but I need to fix the build.
   6
   7 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
   8
   9         * src/modest-account-mgr.h:
  10         * src/modest-account-mgr.c:
  11         (modest_account_mgr_account_names): Add a gboolean enabled_only
  12         parameter, so we can get lists of onlt the enabled accounts.
  13
  14         (modest_account_mgr_add_account),,
  15         (modest_account_mgr_account_with_display_name_exists):
  16         * src/maemo/modest-msg-edit-window.c: (get_transports):
  17         * src/modest-account-mgr-helpers.c:
  18         (modest_account_mgr_set_first_account_as_default):
  19         * src/modest-init.c: (init_default_account_maybe):
  20         * src/modest-tny-account-store.c: (get_accounts):
  21         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
  22         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
  23         * tests/check_account-mgr.c: (START_TEST):
  24         Provide the extra parameter, as appropriate.
  25
  26         * src/widgets/modest-account-view.c: (update_account_view):
  27         Do not show disabled accounts (meaning that there is no way to
  28         enable/disable accounts in the UI (the feature is not in our UI
  29         specification), so we can use this internally only to mark unfinished
  30         or temporary account data.
  31
  32         * src/maemo/easysetup/modest-easysetup-wizard.c:
  33         (create_account): Add boolean enable parameter, so we can specify FALSE
  34         to create the temporary account.
  35         (on_button_edit_advanced_settings): Create the temporary account as disabled.
  36         (on_before_next): When finishing, when there is a temporary account, just
  37         set it as enabled.
  38         Also, use a timeout to delay the showing of the dialog until gconf is likely
  39         to return correct information, due to a maemo gconf bug that is fixed in
  40         osso 1.1, but not yet in Bora.
  41         However, the dialog stays on screen after it is destroyed.
  42
  43         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
  44         for invalid data when cancelling. Use a hildon note instead of a dialog
  45         to complain about invalid data. Do not show the account-saved note if the
  46         account is disabled (a temporary account that will not really be saved for use
  47         until later.)
  48
  49 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  50
  51         * src/modest-account-mgr-helpers.h:
  52         * src/modest-account-mgr-helpers.c:
  53         Added modest_account_mgr_unset_default_account(),
  54         Added modest_account_mgr_set_first_account_as_default().
  55
  56         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
  57         If it was the default account, unset the default account name.
  58
  59         * src/maemo/modest-account-view-window.c:
  60         (on_delete_button_clicked): If it was the default account,
  61         set the first remaining account as the default instead.
  62
  63         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
  64         a NULL account or a NULL default account, to prevent a crash. This should
  65         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
  66
  67
  68 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  69
  70         * src/widgets/modest-recpt-editor.c:
  71         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
  72         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
  73         TODO comment for this. This fixes the build.
  74
  75         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
  76         be the best place for it. This will in future update all auto-update accounts,
  77         rather than just the current/default account, when that gconf key exists.
  78         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
  79         if there are no accounts, before calling do_send_receive().
  80         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
  81
  82         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
  83         * src/maemo/modest-main-window-ui.h:
  84         * src/maemo/modest-main-window.c: (on_connection_changed),
  85         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
  86         directly, becaue the signal handler does more.
  87
  88 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
  89
  90         * src/modest-account-mgr-helpers.c:
  91         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
  92         for the case that the account does not exist.
  93
  94         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
  95         (equivalent to the modest account name) rather than the tinymail account name
  96         (equivalent to the modest account title - human readable) to get the account data.
  97         Check for null account data to prevent the crash, and add a TODO comment saying that
  98         this needs fixing because it is using the server account name instead of the account name.
  99
 100 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 101
 102         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 103         * src/maemo/modest-account-settings-dialog.c: (show_error),
 104         (show_ok):
 105         Use hildon_note_new_information() for informative and error messages,
 106         which seems to be expected for Maemo applications (no documentation that I know of
 107         says this). I am surprised that there is no distinction between info and error
 108         dialogs.
 109
 110 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 111
 112         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 113         it is easy to find where this is used.
 114
 115         * src/maemo/easysetup/modest-easysetup-wizard.c:
 116         (create_page_welcome), (create_page_account_details),
 117         (create_page_user_details), (create_page_complete_easysetup),
 118         (create_page_custom_incoming), (create_page_custom_outgoing),
 119         (create_page_complete_custom):
 120         * src/maemo/modest-account-settings-dialog.c:
 121         (create_page_account_details), (create_page_user_details),
 122         (create_page_incoming), (create_page_outgoing):
 123         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 124         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 125         (modest_connection_specific_smtp_edit_window_init):
 126         * src/maemo/modest-connection-specific-smtp-window.c:
 127         (modest_connection_specific_smtp_window_init):
 128         * src/maemo/modest-signature-editor-dialog.c:
 129         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 130         and scrolling policy as per the Email Application Layout Guide, if I have
 131         understood it.
 132
 133 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 134
 135         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 136         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 137         which were empty, because these vfuncs have been removed from TnyAccountStore.
 138         This fixes the build.
 139
 140 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 141
 142         * src/maemo/modest-main-window.c:
 143         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 144         showing/hiding it. Added TODO because it probably should not be NULL.
 145         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 146         because unnecessary g_warnings() make degugging difficult.
 147
 148 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 149
 150         * src/maemo/modest-msg-edit-window.c:
 151         (modest_msg_edit_window_select_color),
 152         (modest_msg_edit_window_select_background_color): 2 const corrections and
 153         moving 2 #endifs before closing brackets, to fix the build.
 154
 155 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 156
 157         * src/maemo/easysetup/modest-easysetup-wizard.h:
 158         * src/maemo/easysetup/modest-easysetup-wizard.c:
 159         (modest_easysetup_wizard_dialog_finalize),
 160         (on_button_edit_advanced_settings), (create_page_complete_custom),
 161         (on_response), (create_account):
 162         Implement the Advanced Settings edit button, by saving the account information,
 163         for the Advanded Settings dialog to use directly from gconf, and removing it
 164         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 165         Bug #5533 in the projects.maemo.org bugzilla.
 166
 167 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 168
 169         * src/maemo/modest-msg-view-window.c:
 170         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 171         when opening a message window.
 172
 173 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 174
 175         * src/maemo/easysetup/modest-easysetup-wizard.c:
 176         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 177         match the UI spec.
 178
 179         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 180         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 181         gconf settings. I probably added more checks than necessary, but that is safer.
 182
 183         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 184         variable to fix the build, but this seems to be used when it is still NULL.
 185
 186 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 187
 188         * src/modest-platform.h:
 189         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 190         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 191         * src/modest-main.c: Implement this function so we can avoid using
 192         maemo-specific API from cross-platform code.
 193         (main):
 194         * src/modest-tny-account-store.c:
 195         (get_smtp_specific_transport_account_for_open_connection):
 196         * src/modest-ui-actions.c: (check_for_connection),
 197         (modest_ui_actions_on_item_not_found):
 198         Use modest_platform_connect_and_wait() and put #idefs around other
 199         maemo-specific code, because only maemo currently has a way to
 200         identify connection names.
 201
 202 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 203
 204         * src/modest-tny-account-store.h:
 205         * src/modest-tny-account-store.c:
 206         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 207         the connection-specific SMTP server settings in the configuration.
 208
 209         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 210         (on_idle_mail_to):
 211         * src/maemo/modest-main-window.c: (on_connection_changed),
 212         (connect_signals):
 213         * src/modest-main.c: (main), (start_ui), (send_mail):
 214         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 215         that is what is intended.
 216
 217         * src/modest-ui-actions.c: (action_send), (action_receive),
 218         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 219         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 220         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 221         SMTP server is used when it is specified.
 222
 223         (modest_ui_actions_on_send_receive):
 224         Check that a connection is open before proceeding.
 225         Receive and then send, instead of vice-versa, as per the specification.
 226
 227 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 228
 229         * src/modest-mail-operation.c:
 230         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 231         though I guess it should be something other than NULL.
 232
 233 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 234
 235         * src/maemo/easysetup/modest-easysetup-wizard.c:
 236         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 237         combo twice, to avoid an g_warning and to make it visible again.
 238         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 239         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 240         (already intended) dereference when detaching, because we then recreate the menu.
 241         But I am not sure why the warning was happening, and it is possible that this is a memory
 242         leak.
 243
 244 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 245
 246         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 247         and uri_parse_mailto() utility functions.
 248         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 249         the mailto URI.
 250         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 251
 252 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 253
 254         * src/dbus_api/modest-dbus-api.h:
 255         * src/dbus_api/modest-dbus-callbacks.c:
 256         Use an idle callback to execute the modest code in the application's own thread.
 257         Remove the helloworld example method.
 258         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 259         parsed, and the open-message method is not implemented because this is not yet implemented in
 260         modest itself.
 261         * libmodest-dbus-client/libmodest-dbus-client.c:
 262         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 263         (libmodest_dbus_client_open_message):
 264         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 265
 266         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 267         body without crashing.
 268
 269         * tests/dbus_api/Makefile.am:
 270         * tests/dbus_api/test_mail_to.c:
 271         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 272
 273 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 274
 275         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 276         Added file to fix the build. Sorry.
 277
 278         * src/dbus_api/Makefile.am:
 279         * src/dbus_api/modest-dbus-api.h:
 280         * src/dbus_api/modest-dbus-callbacks.h:
 281         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 282         (modest_dbus_req_handler):
 283         Put constants in a separate header so it can be reused by the
 284         client library, without duplication
 285
 286         * libmodest-dbus-client/Makefile.am:
 287         * libmodest-dbus-client/libmodest-dbus-client.c:
 288         (libmodest_dbus_client_call_helloworld),
 289         (libmodfest_dbus_client_send_mail),
 290         (libmodfest_dbus_client_mailto),
 291         (libmodfest_dbus_client_open_message):
 292         * libmodest-dbus-client/libmodest-dbus-client.h:
 293         (Partly) Implement a send_mail D-Bus method.
 294
 295         * tests/dbus_api/Makefile.am:
 296         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 297         the send_email D-Bus method.
 298
 299 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 300
 301         * Makefile.am:
 302         * configure.ac:
 303         * libmodest-dbus-client/Makefile.am:
 304         * libmodest-dbus-client/libmodest-dbus-client.c:
 305         * libmodest-dbus-client/libmodest-dbus-client.h:
 306         * tests/dbus_api/Makefile.am:
 307         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 308         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 309
 310 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 311
 312         * src/maemo/easysetup/modest-easysetup-wizard.c:
 313         (create_page_account_details):
 314         * src/maemo/modest-account-settings-dialog.c:
 315         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 316         widgets, because this might not be the default in future versions of the Maemo GTK+.
 317         However, I can not not get capitalization to work even in a simple test case.
 318
 319 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 320
 321         * src/maemo/easysetup/modest-easysetup-wizard.c:
 322         (create_page_custom_incoming), (create_page_custom_outgoing):
 323         * src/maemo/modest-account-settings-dialog.c:
 324         (create_page_account_details), (create_page_incoming),
 325         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 326         instead of using gtk_check_button_with_label(), so they are aligned like the other
 327         widgets, as per the UI spec.
 328
 329 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 330
 331         * src/maemo/easysetup/modest-easysetup-wizard.c:
 332         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 333         * src/widgets/modest-validating-entry.c:
 334         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 335         Modest prefix instead of an EasySetup prefix.
 336
 337 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 338
 339         * src/widgets/modest-validating-entry.h:
 340         * src/widgets/modest-validating-entry.c: (on_insert_text),
 341         Added easysetup_validating_entry_set_max_func(), used to set a callback
 342         to call when the max number of characters is reached. GtkEntry has a max-length
 343         already but is silent about it.
 344
 345         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 346         (create_page_account_details), (create_page_user_details),
 347         (create_account):
 348         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 349         (create_page_account_details), (create_page_user_details),
 350         (create_page_outgoing):
 351         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 352         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 353         the UI spec, when the user tries to enter more than the max number of characters.
 354
 355 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 356
 357         * src/maemo/easysetup/modest-easysetup-wizard.c:
 358         (create_page_user_details), (create_page_custom_incoming),
 359         (create_page_custom_outgoing):
 360         * src/maemo/modest-account-settings-dialog.c:
 361         (create_page_user_details), (create_page_incoming),
 362         (create_page_outgoing):
 363         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 364         (modest_connection_specific_smtp_edit_window_init):
 365         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 366         not appropriate. Bad Maemo-specific defaults!.
 367
 368 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 369
 370         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 371         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 372         (modest_signature_editor_dialog_set_settings):
 373         Disable the label and textview when the checkbox is disabled, and use the
 374         specified (UI spec) default signature text.
 375
 376 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 377
 378         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 379         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 380
 381         * src/modest-defs.h:
 382         * src/modest-account-mgr-helpers.h:
 383         * src/modest-account-mgr-helpers.c:
 384         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 385
 386         * src/maemo/Makefile.am:
 387         * src/maemo/modest-signature-editor-dialog.c:
 388         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 389         as per the UI spec.
 390
 391         * src/maemo/modest-account-settings-dialog.h:
 392         * src/maemo/modest-account-settings-dialog.c:
 393         (modest_account_settings_dialog_finalize), (on_button_signature),
 394         (save_configuration): Use the new dialog when the Edit button is pressed, and
 395         save the changes if necessary, as per the UI spec.
 396
 397 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 398
 399         * src/maemo/Makefile.am:
 400         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 401         based on maemo-develoers email from Dirk.
 402
 403         * src/maemo/easysetup/modest-easysetup-wizard.c:
 404         (create_page_welcome), (create_page_account_details),
 405         (create_page_user_details), (create_page_complete_easysetup),
 406         (create_page_custom_incoming), (create_page_custom_outgoing),
 407         (create_page_complete_custom),
 408         (modest_easysetup_wizard_dialog_init):
 409         * src/maemo/modest-account-settings-dialog.c:
 410         (create_page_account_details), (create_page_user_details),
 411         (create_page_incoming), (create_page_outgoing),
 412         (modest_account_settings_dialog_init):
 413         * src/maemo/modest-connection-specific-smtp-window.c:
 414         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 415
 416 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 417
 418         * src/maemo/easysetup/modest-easysetup-wizard.c:
 419         (create_page_account_details), (create_page_custom_outgoing),
 420         (create_page_complete_custom):
 421         * src/maemo/modest-account-settings-dialog.c:
 422         (create_page_user_details), (create_page_incoming),
 423         (create_page_outgoing):
 424         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 425         (modest_connection_specific_smtp_edit_window_init):
 426         Use the correct (UI spec) port min/max, and use horizontal separators,
 427         as per the UI spec.
 428
 429 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 430
 431         * src/maemo/easysetup/modest-easysetup-wizard.c:
 432         (set_default_custom_servernames):
 433         * src/maemo/modest-account-settings-dialog.c:
 434         (create_page_incoming), (on_combo_outgoing_security_changed),
 435         (on_combo_incoming_security_changed), (create_page_outgoing),
 436         (modest_account_settings_dialog_set_account_name),
 437         (save_configuration):
 438         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 439         (on_combo_security_changed),
 440         (modest_connection_specific_smtp_edit_window_init),
 441         (modest_connection_specific_smtp_edit_window_set_connection),
 442         (modest_connection_specific_smtp_edit_window_get_settings):
 443         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 444         as per the UI spec.
 445
 446 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 447
 448         * po/en_GB.po:
 449         * src/maemo/easysetup/modest-easysetup-wizard.c:
 450         (create_page_custom_outgoing), (create_page_complete_custom):
 451         * src/maemo/modest-account-settings-dialog.c:
 452         (create_page_user_details), (create_page_outgoing):
 453         * src/maemo/modest-account-view-window.c: (button_box_new):
 454         Use changed logical IDs as per the most recent UI spec:
 455         mcen_bd_emailsetup_edit -> mcen_bd_edit
 456         mcen_bd_emailsetup_delete -> mcen_bd_delete
 457         mcen_bd_emailsetup_close -> mcen_bd_close
 458
 459 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 460
 461         * configure.ac:
 462         * src/Makefile.am:
 463         * src/dbus_api/Makefile.am:
 464         * src/dbus_api/modest-dbus-callbacks.c:
 465         * src/dbus_api/modest-dbus-callbacks.h:
 466         * src/maemo/modest-platform.c: (modest_platform_init):
 467         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 468         method.
 469         * tests/Makefile.am:
 470         * tests/dbus_api/Makefile.am:
 471         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 472
 473 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 474
 475         * src/maemo/modest-account-settings-dialog.c:
 476         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 477         Removed unnecessary includes.
 478
 479 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 480
 481         * src/maemo/easysetup/modest-easysetup-wizard.c:
 482         * src/maemo/modest-account-settings-dialog.c:
 483         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 484         * src/widgets/Makefile.am:
 485         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 486         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 487         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 488         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 489         * src/widgets/modest-secureauth-combo-box.c:
 490         * src/widgets/modest-secureauth-combo-box.h:
 491         * src/widgets/modest-serversecurity-combo-box.c:
 492         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 493         made the GObject names more consistent with the rest of the Modest code.
 494
 495 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 496
 497         * src/maemo/easysetup/Makefile.am:
 498         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 499         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 500         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 501         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 502         * src/maemo/easysetup/modest-easysetup-wizard.c:
 503         * src/maemo/easysetup/modest-validating-entry.c:
 504         * src/maemo/easysetup/modest-validating-entry.h:
 505         * src/maemo/modest-account-settings-dialog.c:
 506         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 507         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 508         widgets/ because they are used outside of easysetup too. After checking in,
 509         svn will allow me to rename them too.
 510
 511 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 512
 513         * src/gnome/modest-msg-edit-window.c:
 514         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 515         linker error, to fix the build on the GNOME platform.
 516         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 517         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 518         ifdefed out to avoid a warning.
 519
 520 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 521
 522         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 523         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 524         some alternative for GTK+ 2.6.
 525
 526 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 527
 528         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 529
 530         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 531         specified for EmailAccountsDialog in UI spec.
 532
 533         * src/maemo/easysetup/modest-easysetup-wizard.c:
 534         * src/maemo/easysetup/modest-easysetup-wizard.h:
 535         * src/maemo/modest-account-settings-dialog.c:
 536         * src/maemo/modest-account-settings-dialog.h:
 537         Reuse a member window widget for the connection-specific SMTP server accounts,
 538         so we can tell it to create/save the accounts only if we actually save changes.
 539
 540         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 541         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 542         (modest_connection_specific_smtp_edit_window_get_settings):
 543         Return a struct instance for temporarily remembering the entered data.
 544
 545         * src/maemo/modest-connection-specific-smtp-window.h:
 546         * src/maemo/modest-connection-specific-smtp-window.c:
 547         (modest_connection_specific_smtp_window_finalize),
 548         (modest_connection_specific_smtp_window_fill_with_connections),
 549         (on_button_edit),
 550         (modest_connection_specific_smtp_window_save_server_accounts),
 551         (update_model_server_names): Do not actually save data until asked,
 552         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 553
 554         (on_selection_changed),
 555         (modest_connection_specific_smtp_window_init): Disable the edit
 556         button when nothing is selected.
 557
 558         * src/modest-account-mgr-helpers.c:
 559         * src/modest-account-mgr-helpers.h:
 560         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 561         elsewhere.
 562
 563 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 564
 565         * src/modest-account-mgr-helpers.h:
 566         * src/modest-account-mgr-helpers.c:
 567         (modest_account_mgr_get_unused_account_name),
 568         (modest_account_mgr_get_unused_account_display_name): Added these
 569         utility functions, to avoid code duplication.
 570
 571         * src/maemo/easysetup/modest-easysetup-wizard.c:
 572         (create_page_account_details), (create_account):
 573         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 574         (on_combo_security_changed),
 575         (modest_connection_specific_smtp_edit_window_init),
 576         (modest_connection_specific_smtp_edit_window_save_settings):
 577         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 578         * src/maemo/modest-connection-specific-smtp-window.c:
 579         (modest_connection_specific_smtp_window_finalize),
 580         (modest_connection_specific_smtp_window_fill_with_connections),
 581         (on_button_edit), (modest_connection_specific_smtp_window_init):
 582         * src/maemo/modest-connection-specific-smtp-window.h:
 583         Implementing saving of connection-specific server accounts.
 584
 585         But I need to refactor this so we can save the data for each
 586         possible connection-specific account and only actually create the server accounts
 587         when the easysetup finished, or the OK button is pressed on the account settings
 588         dialog.
 589
 590 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 591
 592         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 593         (on_combo_security_changed):
 594         (modest_connection_specific_smtp_edit_window_init):
 595         Auto-fill the port number as in the account settings.
 596
 597         (modest_connection_specific_smtp_edit_window_set_connection):
 598         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 599         * src/maemo/modest-connection-specific-smtp-window.c:
 600         (fill_with_connections), (on_button_edit),
 601         (modest_connection_specific_smtp_window_init):
 602         Turn the edit window into a dialog to simplify the code, and
 603         set a WM hint as in a GtkDialog, because only a popup can be on top of
 604         another window in Maemo, and popups usually have no WM decoration.
 605
 606         * src/modest-defs.h:
 607         * src/modest-account-mgr-helpers.c:
 608         (modest_account_mgr_set_connection_specific_smtp),
 609         (modest_account_mgr_remove_connection_specific_smtp),
 610         (modest_account_mgr_get_connection_specific_smtp):
 611         * src/modest-account-mgr-helpers.h: Some functions to write the
 612         connection-specific SMTP server information. Not yet used.
 613
 614
 615         * src/widgets/modest-folder-view.c: (text_cell_data):
 616         Fix a warning about an uninitialized variable.
 617         (on_configuration_key_changed): Put an #ifdef around the use
 618         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 619
 620 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 621
 622         * src/maemo/modest-account-settings-dialog.h:
 623         * src/maemo/modest-account-settings-dialog.c:
 624         Added connect_for_modified() utility function to mark the new modified boolean.
 625
 626         (create_page_account_details), (create_page_user_details),
 627         (create_page_incoming), (create_page_outgoing), (on_response),
 628         (modest_account_settings_dialog_init),
 629         (modest_account_settings_dialog_set_account_name):
 630         Only warn about unsaved changes when there are actually unsaved changes.
 631
 632         * src/modest-account-mgr-helpers.c:
 633         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 634         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 635         to get the data from there in future.
 636
 637 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 638
 639         * src/modest-defs.h:
 640
 641         * src/modest-account-mgr-helpers.h:
 642         * src/modest-account-mgr-helpers.c:
 643         Store the security account setting in a single conf key instead of using
 644         the options list, so that the list is left for just the to-be-removed camel hack,
 645         and because gconf_client_set_list() is failing for some reason.
 646
 647         * src/modest-account-mgr.c:
 648         (modest_account_mgr_add_server_account):
 649         * src/maemo/modest-account-settings-dialog.c:
 650         (modest_account_settings_dialog_set_account_name),
 651         (save_configuration): Use the renamed functions.
 652
 653
 654 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 655
 656         * src/widgets/Makefile.am:
 657         * src/widgets/modest-limit-retrieve-combo-box.c:
 658         * src/widgets/modest-limit-retrieve-combo-box.h:
 659         * src/widgets/modest-retrieve-combo-box.c:
 660         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 661         the account settings dialog.
 662
 663         * src/modest-defs.h:
 664         * src/modest-account-mgr-helpers.h:
 665         * src/modest-account-mgr-helpers.c:
 666         (modest_server_account_get_option_secure_auth),
 667         (modest_server_account_set_option_secure_auth):
 668         * src/modest-account-mgr.c:
 669         (modest_account_mgr_add_server_account):
 670         Use the existing AUTH_MECH conf key for the secure-auth setting,
 671         instead of putting it in the list options, because this was actually used already.
 672
 673         * src/maemo/modest-account-settings-dialog.c:
 674         (create_page_account_details),
 675         (modest_account_settings_dialog_set_account_name),
 676         (save_configuration):
 677         * src/maemo/modest-account-settings-dialog.h:
 678         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 679         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 680
 681 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 682
 683         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 684         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 685         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 686
 687         * src/modest-defs.h:
 688         * src/maemo/modest-account-settings-dialog.c:
 689         (create_page_incoming), (on_combo_outgoing_security_changed),
 690         (on_combo_incoming_security_changed), (create_page_outgoing),
 691         (modest_account_settings_dialog_set_account_name),
 692         (save_configuration): Load/Save the port number, and change it when the
 693         security combo changes, to suitable defaults.
 694
 695 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 696
 697         * src/modest-account-mgr.c:
 698         (modest_account_mgr_add_server_account): Set the security and secure-auth
 699         options, and add a comment saying that the other camel-specific options should be
 700         removed in future.
 701
 702 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 703
 704         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 705         found by valgrind.
 706         * src/modest-tny-account-store.c: (account_list_free),
 707         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 708         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 709         easy to fix.
 710
 711 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 712
 713         * src/modest-protocol-info.c:
 714         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 715         is required by our UI spec. Maybe something in our implementation will use this eventually.
 716         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 717         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 718         instead of the previous 0 placeholder.
 719
 720         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 721         secure-auth settings.
 722         * src/modest-account-mgr-helpers.h:
 723         * src/modest-account-mgr-helpers.c:
 724         (modest_server_account_data_get_option_secure_auth),
 725         (modest_server_account_set_option_secure_auth),
 726         (modest_server_account_data_get_option_security),
 727         (modest_server_account_set_option_security): Added this API for getting and setting the security
 728         and secure-auth settings.
 729
 730         * src/maemo/modest-account-settings-dialog.h:
 731         * src/maemo/modest-account-settings-dialog.c:
 732         (modest_account_settings_dialog_finalize), (check_data),
 733         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 734         about changing titles.
 735         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 736         (save_configuration): Save the security and secure-auth settings.
 737
 738         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 739         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 740
 741 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 742
 743         * src/modest-defs.h:
 744         * src/modest-account-mgr.c:
 745         (modest_account_mgr_add_server_account):
 746         Added and used defines for the options key and value pair strings,
 747         that are used so far, though they do not seem to correspond to anything in our
 748         UI specs or ModestProtocol enum.
 749
 750         * src/modest-account-mgr-helpers.h:
 751         * src/modest-account-mgr-helpers.c:
 752         (compare_option_strings_for_name),
 753         (modest_server_account_data_get_option_value),
 754         (modest_server_account_data_get_option_bool),
 755         (modest_account_mgr_get_server_account_option):
 756         Added helper functions for parsing the options GSList.
 757
 758 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 759
 760         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 761         display name is based on the supplied account name.
 762         * src/modest-account-mgr.c:
 763         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 764         with an inefficient, but good-enough, implementation.
 765
 766         * src/maemo/easysetup/modest-easysetup-wizard.c:
 767         (create_page_account_details), (on_before_next), (create_account):
 768         Check for existing display names rather than (non-user-visible) account names, and just
 769         create and set a unique account name at the end.
 770
 771         * src/maemo/modest-account-settings-dialog.c:
 772         (modest_account_settings_dialog_init),
 773         (modest_account_settings_dialog_set_account_name),
 774         (create_page_incoming): Show the display name, instead of the account name.
 775         (on_response): Do some (not all) extra checks, as in the UI spec.
 776         (save_configuration): Save the display name if it was changed.
 777
 778 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 779
 780         * po/en_GB.po: Added needed logical ID and translation.
 781         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 782         (init_view): Made the is-default column clicking work.
 783
 784 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 785
 786         * configure.ac:
 787         * src/maemo/easysetup/Makefile.am:
 788         * src/maemo/easysetup/modest-easysetup-wizard.c:
 789         (modest_easysetup_wizard_dialog_init):
 790         * src/maemo/easysetup/provider-data-test.keyfile:
 791         * src/maemo/easysetup/provider-data.keyfile:
 792         Moved the provider data file to the new modest-providers-data package and used it from there.
 793
 794 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 795
 796         * src/modest-local-folder-info.c:
 797         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 798         N_() was already used on the static strings, but this just marks it for translation without
 799         using the translation.
 800
 801 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 802
 803         * src/maemo/modest-account-settings-dialog.c:
 804         (create_page_incoming),
 805         (modest_account_settings_dialog_set_account_name):
 806         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 807         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 808         I will do this if nobody else gets there first.
 809
 810 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 811
 812         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 813         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 814         save the security stuff.
 815
 816 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 817
 818         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 819         Set the email address and user fullname, which I now see must be
 820         done separately.
 821
 822         * src/maemo/modest-account-settings-dialog.h:
 823         * src/maemo/modest-account-settings-dialog.c:
 824          (on_response),
 825         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 826         leave-on-server and authentication.
 827         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 828         how to do the rest.
 829
 830 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 831
 832
 833         * src/maemo/modest-account-settings-dialog.c:
 834         * src/maemo/modest-account-settings-dialog.h:
 835         Most (but not all) of the widgets are now present as specified by the UI spec.
 836         No changes are yet saved, and some details are not properly shown yet.
 837
 838         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 839
 840 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 841
 842         * src/maemo/Makefile.am:
 843         * src/maemo/modest-account-settings-dialog.c:
 844         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 845         an existing account. Doesn't do much yet.
 846
 847         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 848         Open the accounts settings dialog when Edit is clicked.
 849
 850 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 851
 852         * src/maemo/easysetup/Makefile.am:
 853         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 854         (load_from_file):
 855         * src/maemo/easysetup/modest-easysetup-wizard.c:
 856         (modest_easysetup_wizard_dialog_init):
 857         Try to get the source directory from the build system,
 858         instead of hard-coding "./" into the source code, when opening our local
 859         copies of the configuration files.
 860         But this still fails when opening the wizard from the Accounts window,
 861         maybe because the working directory seems to change at runtime.
 862         So the wizard will fail the second time unless you copy the files into their
 863         proper locations - see the stdout warnings for the paths.
 864
 865         (create_page_account_details),(on_before_next):
 866         Check for existing non-server accounts instead of server accounts,
 867         so the default account name is useful again, and to prevent trying to
 868         recreate accounts.
 869
 870         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 871         Show the wizard when New is clicked.
 872
 873         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 874         (init_view): Show the column headers, and show the columns that are
 875         specified in the UI specs. However, something in Maemo's GTK+ prevents
 876         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 877         change the default account. This is despite unsetting the special properties.
 878
 879 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 880
 881         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 882         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 883         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 884         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 885         to make that clearer.
 886         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 887
 888 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 889
 890         * src/maemo/modest-account-view-window.c:
 891         (modest_account_view_window_init),
 892         (modest_account_view_window_new):
 893         Use the same buttons as specified in the
 894         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 895         the existing widgets, which never had a chance of working.
 896         Put the ModestAccountView treeview in a scrolled window.
 897         Do not repeat the initialization in both _init() and _new().
 898
 899         * src/widgets/modest-account-view.c: (update_account_view):
 900         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 901         this widget and window shows no accounts.
 902
 903         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 904
 905 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 906
 907         * src/maemo/easysetup/modest-easysetup-wizard.c:
 908         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 909         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 910         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 911         which seems wrong.
 912
 913         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 914         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 915         accounts exist yet, as in the UI spec.
 916
 917         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 918
 919 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 920
 921         * src/maemo/Makefile.am:
 922         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 923         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 924         New window for editing connection-specific smtp details.
 925         Not fully implemented.
 926
 927         * src/maemo/modest-connection-specific-smtp-window.c:
 928         (modest_connection_specific_smtp_window_finalize) :
 929         unref the tree model.
 930         (on_button_edit): Show the edit window.
 931
 932 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 933
 934         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 935         error for me.
 936
 937         * src/maemo/Makefile.am:
 938         * src/maemo/modest-connection-specific-smtp-window.c:
 939         * src/maemo/modest-connection-specific-smtp-window.h:
 940         New window for showing the list of connections, for connection-specific
 941         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 942         * src/maemo/easysetup/modest-easysetup-wizard.c:
 943         (create_page_custom_outgoing): Show the new window when the button is clicked.
 944
 945 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 946
 947         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 948         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 949         * src/maemo/modest-msg-edit-window.c:
 950         (modest_msg_edit_window_insert_image):
 951         * src/modest-conf.c: (modest_conf_key_escape):
 952         * src/modest-mail-operation.c:
 953         (modest_mail_operation_send_new_mail):
 954         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 955         (modest_ui_actions_on_new_account):
 956         * src/widgets/modest-attachment-view.c: (update_filename_request):
 957         * src/widgets/modest-mail-header-view.c:
 958         Corrected warnings that were breaking the build, by commenting out unused variables,
 959         and a function, and by including a header.
 960
 961 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 962
 963         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 964         so we can #ifdef around platform-specific code when necessary.
 965         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 966         to allow this to build for the GNOME platform too.
 967
 968 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 969
 970         * src/maemo/easysetup/modest-easysetup-wizard.c:
 971         Added util_increment_name() and used it in create_page_account_details()
 972         to make sure that the default account name is always a new name.
 973
 974         (modest_easysetup_wizard_dialog_init),
 975         (set_default_custom_servernames): Some minor memory management fixes.
 976
 977 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 978
 979         * Makefile.am:
 980         * configure.ac:
 981         * src/modest-runtime.c: (init_i18n): Restored the translation
 982         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 983         are defined in config.h, and the translations are installed.
 984
 985         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 986         is defined for translation.
 987
 988 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 989
 990         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 991         (load_from_file):
 992         * src/maemo/easysetup/modest-easysetup-wizard.c:
 993         (modest_easysetup_wizard_dialog_init):
 994         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 995         Use realistic paths (though they should use $prefix generically) to the
 996         mcc_mapping and provider-data.keyfile files which might work when they
 997         are installed by the future version of the operator-wizard package,
 998         and then fallback to paths in our source code, with an explanatory
 999         warning.
1000
1001 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1002
1003         * configure.ac:
1004         * src/Makefile.am:
1005         * src/maemo/Makefile.am:
1006         * src/maemo/easysetup/: Added files from the previously-exernal
1007         osso-modest-easysetup.
1008         * src/maemo/modest-main-window-ui.h:
1009         * src/modest-ui-actions.c:
1010         * src/modest-ui-actions.h:
1011         Added modest_ui_actions_on_new_account() as a signal handler for the
1012         New Account menu item. It shows the easysetup wizard.
1013         * po/en_GB.po: Added additional needed logical IDs and translations.
1014
1015 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1016 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1017