1 2007-07-04 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c: (on_connection_status_changed):
4 Do not use tny_device_force_offline() when tinymail says that something
5 went wrong with the connection. It seems to report this unnecessarily.
7 2007-07-04 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/modest-connection-specific-smtp-window.c:
10 (modest_connection_specific_smtp_window_init):
11 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
12 does not seem to have any effect in osso 1.1 (though it works in
13 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
15 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
17 * src/maemo/modest-connection-specific-smtp-window.c:
18 Fix UI specification problems with projects.meamo.org NB#60479
20 2007-07-04 Murray Cumming <murrayc@murrayc.com>
22 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
23 clue when this has failed, because the error dialog is not always shown
24 (at least in earlier version).
26 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
27 GError message, because the generic error dialog is not helpful.
29 'This message is not currently available (can't let a new connection go online)'
30 when trying to open an IMAP message.
32 (_modest_ui_actions_open): Offer a connection when some messages would
33 have to be downloaded and we are offline.
35 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
37 * src/widgets/modest-folder-view.c:
38 Don't check for MERGE type anymore as we use the correct type
40 NOTE: For the last two changes you need to update your tinymail copy
41 because of API changes!
43 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
45 * src/modest-tny-local-folders-account.c:
46 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
47 (see projects.maemo.org NB#61580)
49 2007-07-04 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-tny-account.c: (on_connection_status_changed):
52 Commented out the call to modest_platform_connect_and_wait() because this
53 seems to always hang, and I would like to know if this is the only thing
54 that causes a hang when showing the connection dialog.
55 It is not very useful anyway.
57 2007-07-04 Murray Cumming <murrayc@murrayc.com>
59 * src/maemo/modest-msg-view-window.c:
60 (modest_msg_view_window_select_next_message):
62 * src/modest-platform.h:
63 * src/maemo/modest-platform.c:
64 Added modest_platform_connect_and_wait(), which calls
65 tny_maemo_conic_device_connect() always in the main thread, by calling it
66 in an idle handler and waiting for the idle handler to run. It should be
67 in the main thread because it uses GTK+ UI code. It just returns TRUE
68 if the device is already online.
70 There is some nasty code to ensure that subsequent calls to
71 modest_platform_connect_and_wait() just wait for the first one to finish,
72 by checking repeatedly in another idle handler. This is necessary,
73 because other threads (or even the main thread, via another idle handler)
74 can call modest_platform_connect_and_wait() while
75 modest_platform_connect_and_wait() is running.
77 (modest_platform_connect_and_wait_if_network_account),
78 (modest_platform_connect_and_wait_if_network_folderstore):
79 Convenience functions that calls modest_platform_connect_and_wait() if
80 the account or folder might want network access.
82 * src/modest-mail-operation.c:
83 (modest_mail_operation_update_account):
84 * src/modest-ui-actions.c: (download_uncached_messages),
85 (modest_ui_actions_on_rename_folder), (delete_folder),
86 (modest_ui_actions_on_main_window_move_to),
87 (modest_ui_actions_on_msg_view_window_move_to):
88 * src/widgets/modest-folder-view.c:
89 (drag_and_drop_from_folder_view):
90 Offer a connection if we are offline.
92 * src/modest-tny-account.c: (on_connection_status_changed):
93 Document this as only handling errors during network operations in progress,
94 and replace the idle code with a simple call to
95 modest_platform_connect_and_wait(), which does this instead.
97 2007-07-03 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-tny-account.c:
100 (modest_tny_account_get_special_folder): (util_on_idle),
101 Handle the GError so we can see when tny_folder_store_get_folders()
102 fails, as it currently does while something else is connecting.
104 Added util_run_in_main_thread_and_wait()
105 which uses an idlen handler and mainloop to ensure that the function
106 is called in the main thread.
107 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
108 to make sure that we call attempt the connection in the mainloop only,
109 which might solve some hangs.
111 2007-07-03 Murray Cumming <murrayc@murrayc.com>
113 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
114 be found by their display name. This is never useful.
115 * src/modest-tny-account-store.c: (on_account_removed): Find the account
116 by its ID, instead of trying to use its ID as its display name.
118 * src/modest-tny-account-store.h:
119 * src/modest-tny-account.c:
120 (modest_tny_account_get_special_folder): Add a g_warning() when
121 tny_folder_store_get_folders() returns an empty list for the maildir.
123 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
124 Add a g_warning() when this returns NULL, because that it not allowed
127 2007-07-02 Armin Burgmeier <armin@openismus.com>
129 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
130 note when trying to cancel the wizard. This fixes projects.maemo.org
133 2007-07-02 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-tny-account.h:
136 * src/modest-tny-account.c:
137 (modest_tny_account_new_from_server_account),
138 (modest_tny_account_new_from_server_account_name),
139 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
140 because this must now be set before setting the proto. This is usd in
141 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
142 warning in camel_session_get_service() caused by
143 tny_camel_transport_account_prepare().
145 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
148 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
152 (modest_connection_specific_smtp_edit_window_init):
154 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
157 2007-06-29 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-tny-account.c:
160 (modest_tny_account_new_from_server_account):
161 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
162 now uses to request a connection when it needs one, and which it uses
163 to tell us that something is wrong with the connection, so we can force
164 the accounts offline to prevent further problems.
167 * src/modest-init.c: (init_default_settings):
168 * src/modest-mail-operation.c:
169 (modest_mail_operation_update_account):
170 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
171 This should not be necessary anymore. Do not set the conf key that
172 determined this (it was always TRUE and not set anywhere else).
174 * src/modest-ui-actions.h: Remove unused and unimplemented
175 modest_ui_actions_on_online_toggle_toggled().
177 2007-06-29 Murray Cumming <murrayc@murrayc.com
179 * src/maemo/modest-main-window.c: (connect_signals):
180 Don't connect to delete_event twice. Maybe this was harmless.
182 2007-06-29 Murray Cumming <murrayc@murrayc.com
184 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
185 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
186 Debug output to give some more clue when a folder move is not allowed.
188 2007-06-28 Murray Cumming <murrayc@murrayc.com
190 * src/modest-tny-account.c: (on_modest_file_system_info),
191 (modest_tny_account_get_mmc_account_name):
192 Always call the callback, without checking whether the name has changed.
193 * src/widgets/modest-folder-view.c: (strings_are_equal),
194 (on_model_foreach_set_name), (on_get_mmc_account_name),
195 (text_cell_data): Compare the name here, and use the name from
196 the account rather than from the
197 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
198 if the name was changed after the account was added to the model.
199 That's a tinymail bug but not one that I want to fix now.
201 This finally fixes projects.maemo.org bug NB#59301.
203 2007-06-27 Armin Burgmeier <armin@openismus.com>
205 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
208 2007-06-27 Murray Cumming <murrayc@murrayc.com
210 * src/modest-tny-account.h:
211 * src/modest-tny-account.c:
212 Added modest_tny_account_get_mmc_account_name(), to set the memory
213 card name asynchronously for the given account and then notify.
214 (modest_tny_account_new_for_local_folders): Use this new function instead
215 of using hildon_file_system_info_async_new() directly.
217 * src/widgets/modest-folder-view.c: (text_cell_data):
218 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
219 gtk_tree_model_row_changed() when it is available.
221 This should fix projects.maemo.org bug NB#59301.
223 2007-06-27 Murray Cumming <murrayc@murrayc.com
225 * src/modest-mail-operation.c: (update_account_thread),
226 (get_msgs_full_thread): Fix typo failures in the revert
229 2007-06-27 Murray Cumming <murrayc@murrayc.com
231 * src/maemo/modest-maemo-global-settings-dialog.c:
232 (idle_select_default_focus):
233 * src/modest-mail-operation.c: (idle_notify_progress),
234 (idle_notify_progress_once), (set_last_updated_idle),
235 (update_account_thread), (get_msgs_full_thread):
236 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
237 * src/widgets/modest-header-view.c:
238 (idle_notify_headers_count_changed_destroy),
239 (idle_notify_headers_count_changed):
240 Reverted the additions of gdk_threads_enter/leave(), in case this
241 helps with a startup hang on the device.
243 2007-06-26 Armin Burgmeier <armin@openismus.com>
245 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
246 for supported secure authentication methods from server by
247 gtk_dialog_run(), saving CPU time and a potential race condition.
249 2007-06-26 Armin Burgmeier <armin@openismus.com>
251 * src/maemo/modest-maemo-utils.h:
252 * src/maemo/modest-maemo-utils.c: Added a
253 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
254 only error code to tell the calling code when the user canceled the
257 * src/maemo/modest-account-settings-dialog.h:
258 * src/maemo/modest-account-settings-dialog.c:
259 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
260 message if the retrieval of secure authentication methods was canceled
261 by the user. Perform the check before saving anything to configuration
262 to not end up with half-committed configuration changes, do not show
263 a "Saving to configuration failed" note when authentication methods
264 could not be retrieved.
266 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
269 2007-06-26 Murray Cumming <murrayc@murrayc.com>
271 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
272 Only return the first level of folders under accounts, because the
273 osso-global-search UI spec doesn't want the rest.
274 This fixed projects.maemo.org bug NB#61811.
276 2007-06-26 Murray Cumming <murrayc@murrayc.com>
278 * src/modest-tny-account-store.c:
279 * src/modest-tny-account-store.h:
280 Added modest_tny_account_is_memory_card_account().
281 * src/maemo/modest-main-window.c: (create_details_widget):
282 Show the same information items for the memory card as we show for the
283 local-folders, to fix projects.maemo.org bug NB#59307.
285 2007-06-26 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-tny-account-store.c: (get_password):
288 Added some checks for NULL to maybe prevent crashes, though I think
289 it was Philip's last commit that actually prevented the crash here
290 when creating a first new account.
291 But the new account is still not usable (no messages are shown)
292 until a restart of the application.
294 2007-06-26 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/modest-maemo-global-settings-dialog.c:
297 (idle_select_default_focus):
298 * src/modest-mail-operation.c: (idle_notify_progress),
299 (idle_notify_progress_once), (idle_notify_update_account_queue),
300 (set_last_updated_idle), (update_account_thread),
301 (notify_get_msgs_full), (get_msgs_full_destroyer),
302 (get_msgs_full_thread):
303 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
304 * src/widgets/modest-header-view.c:
305 (idle_notify_headers_count_changed_destroy),
306 (idle_notify_headers_count_changed):
307 Use gdk_threads_enter() and gdk_threads_enter_leave() in
308 all idle handlers, because some other thread could be blocking
309 the GDK lock, so that it can do GUI stuff.
311 2007-06-26 Murray Cumming <murrayc@murrayc.com>
313 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
314 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
315 (on_idle_send_receive), (on_idle_open_default_inbox):
316 * src/maemo/modest-msg-edit-window.c:
317 (modest_msg_edit_window_attach_file_noninteractive):
318 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
319 to prevent a hang. I don't quite understand why these are necessary,
320 beause we should already be in the main loop. I guess something outside
321 of the main loop is taking the lock.
323 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
324 we are really using URIs, and use files that are more likely to exist.
326 2007-06-26 Murray Cumming <murrayc@murrayc.com>
328 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
329 necessary because configure.ac now defines different variables.
331 2007-06-26 Murray Cumming <murrayc@murrayc.com>
333 * libmodest-dbus-client/libmodest-dbus-client.c:
334 * libmodest-dbus-client/libmodest-dbus-client.h:
335 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
336 libmodest_dbus_client_compose_mail() is what things actually use.
338 * src/dbus_api/modest-dbus-api.h:
339 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
340 * tests/dbus_api/Makefile.am:
341 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
344 2007-06-26 Murray Cumming <murrayc@murrayc.com>
346 * src/modest-init.c: (modest_init_local_folders):
347 For memory-card (or other non local-folders) maildir accounts,
348 always create an Archive folder, so that there is somewhere to put
349 messages. This should be less confusing, because the user does not need
350 to guess that the need to create a folder.
352 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
354 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
355 Fixed icon size by using (50, 50) which is the same as defined by
358 2007-06-25 Armin Burgmeier <armin@openismus.com>
360 * src/widgets/modest-window-mgr.c:
362 * configure.ac: Correctly recognize hildon-notify presence and fixed
363 the build without it being installed.
365 2007-06-25 Murray Cumming <murrayc@murrayc.com>
367 * libmodest-dbus-client/libmodest-dbus-client.c:
368 (libmodest_dbus_client_search): Fix the build. Sorry.
369 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
370 (reply_forward_cb): Initialize variables to fix the build.
372 * src/modest-tny-account-store.c:
373 (modest_tny_account_store_get_tny_account_by): Fix the account URI
374 comparison (a silly typo) so that email search results can be opened
375 when there are more than one account.
377 2007-06-25 Murray Cumming <murrayc@murrayc.com>
379 * libmodest-dbus-client/libmodest-dbus-client.c:
380 (libmodest_dbus_client_search),
381 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
382 instead of 1 second, because the search gets folders and messages from
383 the server, which can take a long time. When it times out,
384 osso-global-search will report no results.
386 We need to specify whether we should search only cached information
387 (maybe with a user preference), and the osso-email-search-plugin
388 API should really be improved to allow that option, and to allow results
389 to be delivered asynchronously in batches.
391 2007-06-25 Murray Cumming <murrayc@murrayc.com>
393 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
394 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
395 GTK_ICON_SIZE_DIALOG is probably the wrong size.
397 2007-06-25 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
400 that is an empty string. D-Bus seems to give us these instead of NULL.
402 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
404 * src/dbus_api/modest-dbus-callbacks.c:
405 * src/maemo/easysetup/modest-easysetup-wizard.h:
406 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
407 * src/maemo/modest-connection-specific-smtp-edit-window.c:
408 (modest_connection_specific_smtp_edit_window_init):
409 * src/maemo/modest-maemo-global-settings-dialog.c:
411 * src/maemo/modest-maemo-utils.c:
412 (modest_maemo_utils_setup_images_filechooser):
413 * src/maemo/modest-main-window.c: (create_details_widget):
414 * src/maemo/modest-msg-edit-window.c:
415 (modest_msg_edit_window_attach_file_noninteractive),
416 (modest_msg_edit_window_color_button_change),
417 (modest_msg_edit_window_set_zoom):
418 * src/modest-mail-operation.c: (update_account_thread):
419 * src/modest-tny-account-store.c:
420 * src/modest-tny-account.c:
421 * src/widgets/modest-global-settings-dialog.c:
422 * src/widgets/modest-window.h:
426 2007-06-25 Murray Cumming <murrayc@murrayc.com>
428 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
429 * src/modest-search.c: (modest_search_folder),
430 (modest_search_all_accounts): Actually search only in the specified folder,
431 doing a simple match on the folder ID.
432 * src/modest-search.h: Added a folder field to the ModestSearch struct,
433 and added some documentation.
435 2007-06-22 Armin Burgmeier <armin@openismus.com>
437 * src/maemo/modest-maemo-utils.h:
438 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
439 modest_maemo_utils_get_supported_secure_authentication_methods.
441 * src/maemo/easysetup/modest-easysetup-wizard.c:
442 * src/maemo/modest-account-settings-dialog.c: Show correct error if
443 one occured, not just "Server does not support secure authentication".
445 2007-06-22 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-tny-account-store.c: (get_password):
448 Restored the call to tny_account_set_user() because Philip seems to have
449 stopped this from crashing (by not using the freed string). It still does
450 not work, but now we can test it.
452 2007-06-22 Murray Cumming <murrayc@murrayc.com>
454 * src/maemo/modest-msg-edit-window.c: (init_window):
455 Comment out use of an uninitialzed GtkScrolledWindow variable,
456 to fix the build and stop a crash. Yet again.
458 2007-06-22 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account-store.c: (get_password):
461 Remove the call to tny_account_set_user() because this actually crashes.
462 As mentioned in the last commit, it is known to not work anyway.
464 2007-06-22 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-tny-account-store.c: (get_password):
467 Use tny_account_set_username() to tell tinymail that the username might
468 have changed too. But tinymail ignores this: see projects.maemo.org
470 * src/modest-ui-actions.c:
471 (modest_ui_actions_on_password_requested): Remove the useless attempt to
472 reset the connection when changing the username, and improve the comments.
473 Save the changed username to gconf at least, so it is used when Modest is
476 2007-06-21 Murray Cumming <murrayc@murrayc.com>
478 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
479 Do not use a query, so that we get all folders, including for POP and
480 local-folders. They work as search criteria too.
481 This fixes projects.maemo.org bug NB#57740.
483 2007-06-21 Murray Cumming <murrayc@murrayc.com>
485 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
486 Comment out the use of hildon_notification_set_sound() because it is
487 not declared, to fix the build. Warnings are serious, people.
489 2007-06-21 Armin Burgmeier <armin@openismus.com>
491 * src/maemo/modest-maemo-utils.h:
492 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
493 modest_maemo_utils_get_supported_secure_authentication_methods()
494 to query authentication methods for a specific user. This should fix
495 projects.maemo.org bug NB#61369.
497 * src/maemo/easysetup/modest-easysetup-wizard.c:
498 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
501 2007-06-21 Murray Cumming <murrayc@murrayc.com>
503 * libmodest-dbus-client/libmodest-dbus-client.h:
504 * libmodest-dbus-client/libmodest-dbus-client.c:
505 (modest_dbus_message_iter_get_search_hit),
506 (libmodest_dbus_client_search):
507 Reorganised and commented this.
508 Removed modest_search_hit_free() from the public API because it
511 Added libmodest_dbus_client_get_folders() and
512 modest_folder_result_list_free().
514 * src/dbus_api/modest-dbus-api.h:
515 * src/dbus_api/modest-dbus-callbacks.c:
516 (modest_dbus_req_filter): Commented. Moved most code to
517 on_dbus_method_search() and added on_dbus_method_get_folders().
519 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
520 of the extra D-Bus handler.
522 * tests/dbus_api/Makefile.am:
523 * tests/dbus_api/test_get_folders.c: New test for
524 libmodest_dbus_client_get_folders(). This seems to return an empty list
525 at the moment. That could be the same error that causes the message list
526 to be empty sometimes.
527 This should help with projects.maemo.org bug NB#57740.
529 2007-06-21 Armin Burgmeier <armin@openismus.com>
531 * src/modest-mail-operation.c: Do not call
532 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
533 notify the operation's end after having set the status to CANCELED for
534 the operation queue to listen on. This fixes a deadlock when there
535 were mail operations in the queue during its finalization.
537 * src/modest-singletons.c: Reordered uninitialization of the account
538 manager to happen after the mail operation queue was uninitialized
539 because the mail operation's in the queue might still try to access
540 the account manager (see modest_mail_operation_notify_end()). This
541 fixes a potential crash when terminating the application.
543 2007-06-21 Murray Cumming <murrayc@murrayc.com>
545 * src/modest-search.c:
546 (search_mime_part_and_child_parts): Moved some code here so we
547 can search recursively in child folders.
548 (modest_search_folder): Search in the message as a mime part, instead
549 of just its child mime parts.
550 (read_chunk), (search_mime_part_ogs):
551 Check how many bytes were read, to prevent an endless loop.
552 Searching in message bodies now works. This finishes the fix for
553 projects.maemo.org bug NB#61007.
555 2007-06-20 Murray Cumming <murrayc@murrayc.com>
557 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
558 Add a g_warning when the item is not a folder.
560 * src/modest-ui-dimming-rules.c:
561 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
562 when selected item is not a folder (for instance, an account), because
563 the UI spec only talks about folders.
564 I am not sure what the UI spec wants, so this might not totally fix
565 projects.maemo.org bug NB#60794.
567 2007-06-20 Murray Cumming <murrayc@murrayc.com>
569 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
570 (load_from_file): Sort the list. The unsorted list would be more noticeable
571 in non-English locales.
573 * src/maemo/modest-msg-edit-window.c:
574 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
575 warning and fix the build.
577 * src/maemo/modest-progress-bar-widget.c:
578 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
579 avoid a g_warning, and probably to avoid a crash.
581 2007-06-20 Murray Cumming <murrayc@murrayc.com>
583 * src/modest-search.c: (modest_search_folder): Check for a GError
584 when calling tny_folder_get_headers(), to show that this is not the cause
587 2007-06-20 Murray Cumming <murrayc@murrayc.com>
589 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
590 Actually set the body query instead of the subject query.
592 * src/modest-search.c: (search_mime_part_ogs),
593 (search_mime_part_strcmp): Remove extra space from the text/* regex,
594 which would probably cause it to fail if we got this far.
596 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
597 to simplify the code.
598 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
599 be causing search-in-body to fail.
601 2007-06-20 Murray Cumming <murrayc@murrayc.com>
603 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
605 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
606 Better debug message when the folder cannot be found.
607 This should help with fixing projects.maemo.org bug #61287.
608 * src/modest-search.c: (add_hit): Do not leak the furl string.
610 2007-06-20 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-ui-actions.c:
613 (modest_ui_actions_on_folder_selection_changed):
614 Do not special-case TNY_MERGE_FOLDER here, because
615 modest_tny_folder_get_account() already does that. This fixes
616 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
617 shown when the Outbox was selected).
619 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
621 * libmodest-dbus-client/libmodest-dbus-client.c:
622 (_dbus_iter_get_string_or_null): Initialize the string variable in
623 case this helps with Dirk's crash.
625 2007-06-19 Murray Cumming <murrayc@murrayc.com>
627 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
628 though it is not implemented yet (this function is maybe not even used),
629 to avoid breaking ABI in future.
630 * libmodest-dbus-client/libmodest-dbus-client.c:
631 (get_attachments_string): Moved some code into this generic function.
632 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
633 sends email. It is maybe not used.
634 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
635 (on_send_mail): Use attachments.
637 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
638 * src/maemo/modest-msg-edit-window.c:
639 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
640 a filename before using it, to fix projects.maemo.org bug NB#58233.
642 2007-06-19 Murray Cumming <murrayc@murrayc.com>
644 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
645 Initialize the continue_download variable to fix the build, and probably
646 to fix randome behaviour.
648 2007-06-18 Armin Burgmeier <armin@openismus.com>
650 * src/modest-tny-send-queue.h:
651 * src/modest-tny-send-queue.c: Keep track of the status of messages in
652 the queue so we can later show it in the UI. Replaced
653 modest_tny_send_queue_msg_is_being_sent() by
654 modest_tny_send_queue_get_msg_status().
656 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
658 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
659 gpointer. This probably was not harmful, but just to be sure.
661 2007-06-18 Murray Cumming <murrayc@murrayc.com>
663 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
664 Fix the build, but leave the function broken on Bora, because
665 hildon_uri_action_get_service() does not exist.
666 osso_uri_action_get_service() does not exist either, it seems.
668 2007-06-18 Murray Cumming <murrayc@murrayc.com>
670 * src/modest-tny-account.c:
671 (modest_tny_account_new_from_server_account):
672 Uncommented the url debug output again, because it is useful for
673 debugging, as I said in the comment.
675 2007-06-18 Murray Cumming <murrayc@murrayc.com>
677 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
679 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
680 for Mameo Bora, to fix the build.
682 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
685 Fixed build with hildon < 0.99
687 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
688 Check if the selected account is busy instead of checking all accounts
690 * src/modest-account-mgr-priv.h:
691 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
692 (modest_account_mgr_init), (compare_account_name),
693 (modest_account_mgr_set_account_busy),
694 (modest_account_mgr_account_is_busy):
695 * src/modest-account-mgr.h:
696 Added busy information to the account manager. It possible to
697 set an account to busy or not busy now.
699 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
700 (modest_mail_operation_update_account),
701 (modest_mail_operation_notify_end):
702 Set the account to busy/not busy depending on the operation state.
704 * src/widgets/modest-account-view.c:
705 (modest_account_view_finalize), (get_last_updated_string),
706 (update_account_view), (on_account_busy_changed), (init_view):
707 Show string "Refreshing..." if the account is currently busy.
709 All this fixes projects.maemo.org bug NB#59711
711 2007-06-14 Armin Burgmeier <armin@openismus.com>
713 * src/widgets/modest-attachments-view.h:
714 * src/widgets/modest-attachments-view.c: Added
715 modest_attachments_view_has_attachments() and fixed coordinate
716 transformation in get_att_view_at_coords(). This fixes attachment
719 * src/widgets/modest-msg-view.c: Make use of
720 modest_attachments_view_has_attachments() to decide whether to show
721 attachments in the header.
723 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
726 (on_change), (on_combo_security_changed),
727 (modest_connection_specific_smtp_edit_window_init),
728 (modest_connection_specific_smtp_edit_window_set_connection),
729 (modest_connection_specific_smtp_edit_window_is_dirty):
730 * src/maemo/modest-connection-specific-smtp-edit-window.h:
731 * src/maemo/modest-connection-specific-smtp-window.c:
734 Show an comfirmation dialog for the smpt-edit-window if there are
735 unsaved changes and the user hits cancel.
736 (projects.maemo.org bug NB#60479)
738 2007-06-14 Armin Burgmeier <armin@openismus.com>
740 * src/maemo/easysetup/modest-easysetup-wizard.c:
741 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
742 address" info in banner instead of node, and select all the text as
743 per UI spec. This fixes projects.maemo.org bug NB#60550.
745 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
747 reviewed by: <delete if not using a buddy>
749 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
750 * src/modest-ui-actions.c: (folder_refreshed_cb):
752 2007-06-14 Murray Cumming <murrayc@murrayc.com>
754 * src/widgets/modest-folder-view.c: (filter_row):
755 Explictly filter out the per-account outbox accounts. I don't know why
756 these only sometimes show up, but now they should never show up in the UI.
757 This should fix projects.maemo.org bug NB#60160.
759 2007-06-14 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
762 when the toolbar does not exist yet.
763 * src/modest-widget-memory.c: (save_settings_header_view):
764 Added g_warnings() to help us to discover when we are trying to set
765 an empty columns list in gconf.
767 2007-06-14 Murray Cumming <murrayc@murrayc.com>
771 Added modest_init_get_default_header_view_column_ids().
773 * src/modest-widget-memory.c: (restore_settings_header_view):
774 Use the new function to get defaults, if the gconf key is empty,
775 instead of not creating any columns. This seems to fix the
776 empty right-hand pane problems.
778 * src/widgets/modest-header-view.h: Improved documentation.
780 2007-06-13 Murray Cumming <murrayc@murrayc.com>
782 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
783 Revert the use of the display name as the account name, because this
784 is generally wrong and would break the code that follows.
786 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
788 * src/maemo/easysetup/modest-easysetup-wizard.c:
789 (check_for_supported_auth_methods), (on_before_next),
792 More correct fix for projects.maemo.org bug NB# 58991
793 Do not longer accept AUTH_PASSWORD as secure method and choose
794 correct method when creating the account.
796 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
798 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
799 Fixed projects.maemo.org bug NB# 58991
801 2007-06-13 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-init.c: (modest_init_init_core),
804 (modest_init_local_folders): Fixed compilation errors.
806 2007-06-13 Murray Cumming <murrayc@murrayc.com>
808 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
809 Remove unnecessary lib/include, though it is good in principle when needed.
811 * src/modest-init.c: (modest_init_one_local_folder),
812 (modest_init_local_folders):
813 * src/modest-init.h: Initialize the .modest library for memory cards,
814 instead of just doing nothing for them. This should allow us to create
815 folders there, fixing projects.maemo.org bug NB#59297.
817 2007-06-13 Murray Cumming <murrayc@murrayc.com>
819 * libmodest-dbus-client/libmodest-dbus-client.c:
820 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
821 (libmodest_dbus_client_compose_mail),
822 (libmodest_dbus_client_open_message),
823 (libmodest_dbus_client_send_and_receive),
824 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
826 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
827 (on_idle_open_message), (modest_dbus_req_handler),
828 (search_result_to_message), (modest_dbus_req_filter):
829 * src/modest-search.c: (add_hit), (modest_search_folder),
830 (modest_search_all_accounts): Improved debug messages.
832 * tests/dbus_api/test_open_message.c: (main): Improved comments.
834 * src/modest-tny-account-store.c:
835 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
838 2007-06-13 Murray Cumming <murrayc@murrayc.com>
841 2007-06-12 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-tny-account-store.c: (get_server_accounts):
844 Call modest_tny_local_folders_account_add_merged_outbox_folders()
845 even when there are no accounts, so that the Outbox folder is always
846 visible. This fixes projects.maemo.org bug NB#60158.
848 2007-06-12 Murray Cumming <murrayc@murrayc.com>
850 * src/maemo/modest-main-window.c: (create_details_widget):
851 Use the mcen_va_never logical ID.
853 2007-06-12 Murray Cumming <murrayc@murrayc.com>
855 * src/dbus_api/modest-dbus-api.h:
856 * src/dbus_api/modest-dbus-callbacks.c:
857 (on_idle_open_default_inbox), (on_open_default_inbox),
858 (modest_dbus_req_handler):
859 Added a new OpenDefaultInbox method.
861 * libmodest-dbus-client/libmodest-dbus-client.h:
862 * libmodest-dbus-client/libmodest-dbus-client.c:
863 Added libmodest_dbus_client_open_default_inbox() to call the new
864 dbus method. This should be useful to projects.maemo.org bug NB#57214,
865 though it should maybe be used by a new osso-email-interface function.
867 * tests/dbus_api/Makefile.am:
868 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
871 2007-06-12 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
874 NULL, so that the signals get all the keys. This should not actually
875 change any behaviour because we currently update everything when anything
878 2007-06-12 Murray Cumming <murrayc@murrayc.com>
880 * src/widgets/modest-folder-view.c: (text_cell_data),
881 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
882 (find_inbox_iter): If tinymail tells us that the folder is
883 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
884 This causes the inbox to be selected at startup, fixing part of
885 projects.maemo.org bug NB#56305.
887 * src/modest-ui-dimming-rules.c:
888 (modest_ui_dimming_rules_on_tools_smtp_servers):
889 * src/modest-ui-dimming-rules.h: Added a callback function to dim
890 the SMTP servers menu item.
891 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
892 that the SMTP Servers menu item is dimmed when there are no accounts,
893 as a future version of the UI spec will require. This fixes
894 projects.maemo.org bug NB#56305.
896 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
898 * src/maemo/modest-maemo-utils.c:
899 (modest_maemo_utils_get_supported_secure_authentication_methods):
900 Added label to dialog instead of unreadable title
902 * src/maemo/modest-main-window.c: (sync_accounts_cb),
903 (modest_main_window_new):
904 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
907 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
908 * src/modest-account-mgr.h:
909 Added method to avoid code duplication
911 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
912 (modest_ui_actions_on_send_receive):
913 Use modest_account_mgr_has_accounts
915 2007-06-11 Murray Cumming <murrayc@murrayc.com>
917 * src/maemo/easysetup/modest-presets.c:
918 (modest_presets_get_info_server_security): Do not report secure auth
920 * src/modest-protocol-info.c: Use the defines for the gconf key names
921 for secure authentication. This was not working because we were writing
922 Password and reading password, and the check was case sensitive.
923 With this, gmail now works for receiving and sending when created via
926 2007-06-11 Murray Cumming <murrayc@murrayc.com>
928 * src/maemo/easysetup/modest-presets.c:
929 (modest_presets_get_info_server_security): Correct the key name for
930 SecureSmtp, because it seems to be case-sensitive.
931 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
932 Do not try to get the 0th notebook page if there are 0 pages, to
935 2007-06-11 Murray Cumming <murrayc@murrayc.com>
937 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
938 Prevent use of the new notification feature for now, because it currently
939 shows one dialog for each new email, which is annoying.
941 2007-06-11 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
944 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
945 when no country was selected, so that we show the global ones.
946 * src/maemo/easysetup/modest-presets.c:
947 (modest_presets_get_providers): Return only the global providers, not
948 all providers when mmc=0 was requested.
950 2007-06-11 Murray Cumming <murrayc@murrayc.com>
952 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
953 (easysetup_provider_combo_box_fill): Remove debug code that showed the
954 provider ID in the combo.
956 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
957 Do not show the page numbers, because it would be confusing when we add
958 the 2 extra pages for the custom setup, when the user chooses the "Other"
959 provider. This fixes projects.maemo.org bug NB#59028
961 * src/modest-init.c: (modest_init_init_core),
962 (modest_init_local_folders):
964 * src/modest-tny-account.c:
965 (modest_tny_account_new_for_local_folders): Do not create default folders
966 for the memory card. This should fix projects.maemo.org bug NB#59328.
968 2007-06-11 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
971 Free the changed_conf_keys string items. They are already freed in the
972 idle handler if that runs first.
974 2007-06-11 Murray Cumming <murrayc@murrayc.com>
976 * src/modest-ui-actions.c:
977 (modest_ui_actions_on_password_requested): Check that the server name
978 is not NULL, because I just saw a password dialog with (null) as the
981 * src/modest-tny-folder.[h|c]: Added
982 modest_tny_folder_is_memory_card_folder().
983 * src/modest-ui-dimming-rules.c:
984 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
985 menu item for memory cards, as per the UI spec (section 7.4). This should
986 fix projects.maemo.org bug NB#59297.
988 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
990 * src/maemo/modest-main-window.c: (sync_accounts_cb):
991 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
992 is another problem with the code, see Murray's comment at line 772)
994 2007-06-08 Murray Cumming <murrayc@murrayc.com>
996 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
997 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
998 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
999 (load_from_file), (easysetup_country_combo_box_init),
1000 (easysetup_country_combo_box_get_active_country_ids),
1001 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1002 instead of just one ID, to avoid duplicate country names in the UI.
1004 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1005 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1006 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1007 a single ID, avoiding duplicate providers.
1008 * src/maemo/easysetup/modest-easysetup-wizard.c:
1009 (on_combo_account_country): Adapt to use a list.
1011 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1013 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1014 keys changed in the last X seconds.
1016 * src/modest-account-mgr.h:
1017 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1018 (on_key_change), (modest_account_mgr_class_init),
1019 (modest_account_mgr_init), (modest_account_mgr_finalize):
1020 As the keys are changed, save them in a GSList* and signal that GSList*
1021 further every X seconds, to batch changes, to allow us to do just one
1022 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1023 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1025 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1026 changed signal signature.
1028 * src/modest-conf.c: (modest_conf_set_list),
1029 (modest_conf_on_change): Reenable notification.
1031 (modest_conf_maemo_fake_on_change): Comment out the hack that
1032 notified immediately instead of asynchronously.
1034 * src/widgets/modest-account-view.h:
1035 * src/widgets/modest-account-view.c:
1036 (update_account_view): Select the previously-selected account ID,
1037 if possible. This fixes projects.maemo.org bug NB#56933.
1039 (on_account_changed), (on_account_removed),
1040 (modest_account_view_select_account):
1042 Remove the block/unblock functions
1043 because they were not useful.
1045 * src/maemo/modest-account-view-window.c:
1046 (on_delete_button_clicked), (on_edit_button_clicked),
1047 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1049 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1051 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1052 Improve the error dialog to show Incorrect Account Settings, which seems
1053 clearer, and say that the internal error message (to be removed from the
1054 dialog later) is often misleading.
1055 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1057 * src/modest-tny-account.c:
1058 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1059 URL because this is so useful for debugging on the device.
1061 * src/widgets/modest-serversecurity-combo-box.c:
1062 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1064 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1066 * src/modest-mail-operation.c:
1067 (modest_mail_operation_send_new_mail):
1068 Added a comment about a nasty but apparently harmless message. Details
1069 added to the wiki g_warnings() page.
1071 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1074 (modest_tny_send_queue_class_init):
1075 Do not use the priv struct because it is empty, to avoid g_warnings
1076 about a non-existant priv struct.
1078 * src/modest-tny-account-store.c:
1079 (modest_tny_account_store_get_server_account),
1080 (modest_tny_account_store_get_transport_account_for_open_connection
1081 ): Do not try to get transport server accounts for local folders,
1082 because they don't have any. This avoids a g_warning().
1084 * src/maemo/modest-main-window.c:
1085 (modest_main_window_notify_send_receive_initied),
1086 (on_configuration_key_changed):
1087 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1088 * src/modest-defs.h:
1089 * src/modest-mail-operation.c:
1090 (modest_mail_operation_update_account):
1091 * src/modest-tny-account-store.h:
1092 * src/modest-tny-account.c:
1093 (modest_tny_account_get_special_folder),
1094 (modest_tny_account_new_for_local_folders),
1095 (modest_tny_account_new_for_per_account_local_outbox_folder):
1096 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1097 * src/modest-tny-local-folders-account.c:
1098 (add_account_folders_to_merged_folder):
1099 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1100 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1101 (modest_ui_actions_on_send):
1102 * src/widgets/modest-folder-view.c: (update_model):
1103 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1104 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1105 modest_tny_account_store_get_tny_account_by_account() to
1106 modest_tny_account_store_get_server_account() to make the code clearer.
1108 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1110 * src/dbus_api/modest-dbus-api.h:
1111 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1112 * src/maemo/modest-msg-edit-window.c:
1113 (modest_msg_edit_window_attach_file_noninteractive):
1114 added g_warning in case the file to be attached does not exist
1115 * tests/dbus_api/test_compose_mail.c: (main):
1116 removed obsolete comment, added generic files as test case
1118 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1120 * src/modest-tny-account-store.c: (get_server_accounts):
1121 Create the local folders account only once, not once for each outbox, and
1122 not only when there are some outboxes.
1124 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1126 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1127 code that is causing a crash at startup. Sergio says that he is fixing this.
1129 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1131 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1132 * src/maemo/modest-account-settings-dialog.c:
1133 (create_page_outgoing),
1134 (modest_account_settings_dialog_set_account_name),
1135 (save_configuration):
1136 - Fixed handling of the "Use secure authentication" toggle to comply with
1137 the ui specification. See also projects.maemo.org bug NB#58400
1139 - Restore the Secure connection setting combo correctly when loading
1142 * src/maemo/modest-maemo-utils.c:
1143 (on_camel_account_get_supported_secure_authentication),
1144 (modest_maemo_utils_get_supported_secure_authentication_methods):
1145 Fixed a crasher if operation is canceled
1147 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1148 (modest_protocol_info_auth_is_secure):
1149 * src/modest-protocol-info.h:
1151 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1152 the sense of the "Use secure authentication" toggle.
1154 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1156 * src/modest-tny-account-store.h:
1157 * src/modest-tny-account-store.c:
1158 Added modest_tny_account_store_get_local_folders_account().
1160 * src/modest-tny-folder.h:
1161 * src/modest-tny-folder.c:
1162 (modest_tny_folder_get_account):
1163 Added this replacement for tny_folder_get_account() which returns
1164 the local-folders account for TnyMergeFolders, to avoid the
1165 warning about the unimplemented get_account_func() vfunc().
1167 (modest_tny_folder_get_rules),
1168 * src/modest-ui-actions.c:
1169 (modest_ui_actions_on_folder_selection_changed):
1170 * src/modest-mail-operation.c:
1171 (modest_mail_operation_remove_folder),
1172 (modest_mail_operation_xfer_folder),
1173 (modest_mail_operation_rename_folder),
1174 (modest_mail_operation_get_msg),
1175 (modest_mail_operation_get_msgs_full),
1176 (modest_mail_operation_remove_msg),
1177 (modest_mail_operation_xfer_msgs),
1178 (modest_mail_operation_refresh_folder):
1179 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1181 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1184 (modest_server_account_set_security):
1185 * src/modest-defs.h: Add comments explaining that our
1186 UI spec means TLS when it says Normal, so these do not look like errors.
1188 * src/modest-tny-account.c:
1189 (modest_tny_account_new_from_server_account): Use the new tinymail
1190 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1191 for TLS. This should fix projects.maemo.org bug NB#58460.
1193 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1195 * src/maemo/easysetup/modest-easysetup-wizard.c:
1196 (create_account): Correct the position of the gconf sanity check warning.
1197 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1198 of using the g_idle_add() hack, because this does not seem to be necessary
1199 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1200 caused by something other than maemo's gconf.
1201 This fixes projects.maemo.org bug #59022.
1203 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1205 * src/modest-account-mgr-helpers.c:
1206 (modest_account_mgr_get_default_account): Do not check that the account
1207 exists if there is no default account (NULL), to fix a runtime warning.
1209 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1211 * src/widgets/modest-folder-view.c: (update_model):
1212 Do not unref the treemodel before we have finished with it.
1213 This prevents a valgrind warning and an occasional crash at startup.
1215 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1217 * libmodest-dbus-client/libmodest-dbus-client.h:
1218 added libmodest_dbus_client_compose_mail()
1219 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1221 added functions needed for SendAsMail() functionality
1222 * src/maemo/modest-msg-edit-window.c:
1223 (modest_msg_edit_window_attach_file_noninteractive):
1224 non interactively attaching files to message edit window
1225 * src/widgets/modest-msg-edit-window.h:
1226 * tests/dbus_api/Makefile.am:
1227 added test_compose_mail.c
1228 * tests/dbus_api/test_compose_mail.c: (main):
1230 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1232 * src/modest-account-view.c:
1233 Fixed bug projects.maemo.org bug NB#59307
1235 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1237 * src/maemo/easysetup/modest-easysetup-wizard.c:
1238 (get_serverport_incoming), (on_before_next), (create_account):
1239 * src/maemo/modest-account-settings-dialog.c:
1240 (modest_account_settings_dialog_set_account_name):
1241 * src/maemo/modest-maemo-utils.c:
1242 (on_camel_account_get_supported_secure_authentication_status),
1243 (on_camel_account_get_supported_secure_authentication),
1244 (on_secure_auth_cancel),
1245 (modest_maemo_utils_get_supported_secure_authentication_methods):
1247 Implemented security authentication for settings and easysetup.
1249 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/modest-main-window.c: (create_details_widget):
1252 Show the total size for memory card accounts too, instead of showing
1253 the name again. Fixes bug projects.maemo.org bug NB#59307.
1255 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-tny-simple-folder-store.c:
1259 * src/modest-tny-simple-folder-store.h: Removed.
1261 * src/modest-tny-local-folders-account.h
1262 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1263 for the local-folders maildir, with an extra TnyMergedFolder containing
1264 the folders of the per-account outbox store accounts.
1265 * src/modest-tny-account-store.c: (get_server_accounts):
1266 Add the outboxes to the special local folders account after creating it.
1268 * src/modest-tny-account.c:
1269 (modest_tny_account_new_for_local_folders): Create the derived
1270 account when creating the main local-folders account.
1272 * src/maemo/modest-main-window.c: (create_details_widget),
1273 (modest_main_window_set_contents_style):
1274 Adapted to the use of the derived account instead of the folder store.
1276 * src/modest-ui-actions.c:
1277 (modest_ui_actions_on_folder_selection_changed):
1278 * src/modest-ui-dimming-rules.c:
1279 (modest_ui_dimming_rules_on_new_folder):
1280 * src/widgets/modest-folder-view.c: (text_cell_data),
1281 (icon_cell_data), (filter_row), (update_model),
1282 (get_cmp_rows_type_pos):
1285 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1286 Do not get the priv struct, because no priv struct has been set,
1287 to avoid a runtime warning.
1289 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1290 #ifelse with #else, to fix a warning, to fix the build.
1293 2007-06-05 Christian Kellner <ckellner@openismus.com>
1295 * libmodest-dbus-client/libmodest-dbus-client.c:
1296 Fix small typo in doc (why do you always see them
1297 AFTER committing stuff?)
1300 2007-06-05 Christian Kellner <ckellner@openismus.com>
1302 * libmodest-dbus-client/libmodest-dbus-client.c:
1303 (libmodest_dbus_client_search):
1304 Initialize hit list with NULL. Also set folder list
1305 to "" if NULL was supplied.
1308 2007-06-03 Christian Kellner <ckellner@openismus.com>
1310 * libmodest-dbus-client/libmodest-dbus-client.c:
1311 (modest_search_hit_list_free):
1312 Make it save to call it with NULL.
1314 * src/dbus_api/modest-dbus-callbacks.c:
1315 * src/modest-search.c:
1316 Return full ModestSearchHits as the search result list not TnyHeader
1317 since can't be around withouth the correspoding TnyFolder.
1319 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1321 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1322 Added currently commented code to check for secure auth
1324 * src/maemo/modest-account-settings-dialog.c: (on_response),
1325 (save_configuration), (show_ok):
1326 Fixed projects.maemo.org bugs NB #59248 and #59251
1328 * src/maemo/modest-maemo-utils.c:
1329 (on_camel_account_get_supported_secure_authentication_status),
1330 (on_camel_account_get_supported_secure_authentication),
1331 (modest_maemo_utils_get_supported_secure_authentication_methods):
1332 * src/maemo/modest-maemo-utils.h:
1333 Moved get_supported_secure_authentication() method here to be able
1334 to use it from easysetup wizard.
1336 * src/modest-pair.c: (on_pair_compare_as_string):
1337 Should compare string with first part of pair and not
1338 strcmp pairs which will crash.
1340 * src/modest-protocol-info.c:
1341 (modest_protocol_info_protocol_is_store):
1342 * src/modest-protocol-info.h:
1343 Added modest_protocol_info_get_auth_protocol_name()
1345 2007-06-03 Armin Burgmeier <armin@openismus.com>
1347 * src/modest-mail-operation.c:
1348 (modest_mail_operation_get_msgs_full): Set priv->account also when
1349 only retrieving a single message. This avoids a crash when canceling
1352 (modest_mail_operation_notify_end): Do not explicitely remove the
1353 operation from the queue but only emit the progress_changed signal.
1354 The queue itself listens to that signal to remove the operation when
1355 it is finished. This reduces coupling and removes a potential deadlock
1356 when modest_mail_operation_notify_end() is called from the queue
1357 itself. If that is a problem performance-wise, I would suggest to
1358 implement a status-changed signal or something.
1360 * src/modest-mail-operation-queue.c: Make sure to never call a
1361 function from another file while the queue is locked. This (hopefully)
1362 fixes another deadlock when exiting the application while retrieving
1365 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1367 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1368 Fixed build if libogs is not available
1370 2007-06-03 Christian Kellner <ckellner@openismus.com>
1372 * libmodest-dbus-client/libmodest-dbus-client.h:
1373 * libmodest-dbus-client/libmodest-dbus-client.c:
1374 (libmodest_dbus_client_delete_message):
1375 Implement deletion of messages (Client side).
1377 (modest_search_hit_free),
1378 (modest_search_hit_list_free):
1379 Utility functions to free the result hits.
1381 * src/dbus_api/modest-dbus-api.h:
1382 * src/dbus_api/modest-dbus-callbacks.c:
1383 (on_delete_message),
1384 (modest_dbus_req_handler):
1385 Implement deletion of messages (Server side).
1387 * tests/dbus_api/test_search.c: (main):
1390 * tests/dbus_api/Makefile.am:
1391 * tests/dbus_api/test_delete_message:
1392 Add little test for the message deletion logic
1394 2007-06-03 Armin Burgmeier <armin@openismus.com>
1396 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1397 when the operation queue was not empty. projects.maemo.org bug
1400 2007-06-03 Armin Burgmeier <armin@openismus.com>
1402 * src/widgets/modest-account-view.c
1403 (on_account_default_toggled): Toggle default account column
1404 explicitely instead of waiting for gconf notification (which is
1405 currently ignored). This should fix projects.maemo.org bug NB#56910
1406 for now. It should probably be removed when gconf notifications are
1409 2007-06-03 Christian Kellner <ckellner@openismus.com>
1411 * libmodest-dbus-client/libmodest-dbus-client.c:
1412 Removed debugging spew.
1414 * src/dbus_api/modest-dbus-callbacks.c:
1415 Added debugging info.
1417 * src/modest-search.c:
1418 (modest_search_all_accounts):
1419 Use tny_account_store_get_accounts () on the account store
1420 to get all accounts which is the way to get all accounts.
1422 * tests/dbus_api/test_search.c: (main):
1423 Make it possible to supply the search term on the command line.
1425 2007-06-03 Christian Kellner <ckellner@openismus.com>
1427 * libmodest-dbus-client/libmodest-dbus-client.c:
1428 * libmodest-dbus-client/libmodest-dbus-client.h:
1429 Implement searching for mesages over raw dbus. (Client side)
1431 * src/dbus_api/Makefile.am:
1432 * src/dbus_api/modest-dbus-api.h:
1433 * src/dbus_api/modest-dbus-callbacks.c:
1434 * src/dbus_api/modest-dbus-callbacks.h:
1435 Search framework (Server side). Also implement on_idle_open_message().
1437 * src/maemo/modest-platform.c: (modest_platform_init):
1438 Prepare for raw dbus/osso rpc interaction.
1440 * src/modest-search.h:
1441 Changed minsize from unspecific guint to guint32.
1443 * src/modest-search.c:
1445 Added strange hack which magically made tnymail work.
1447 (modest_search_folder),
1448 (modest_search_account),
1449 (modest_search_all_accounts):
1450 Implement helper functions to search all accounts, specific account
1453 * tests/dbus_api/Makefile.am:
1454 * tests/dbus_api/test_open_message.c:
1455 Read url to open from commandline.
1457 * tests/dbus_api/test_search.c:
1458 Implement small test for dbus search stuff
1460 2007-06-02 Armin Burgmeier <armin@openismus.com>
1462 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1463 include account type and account title. This fixes projects.maemo.org
1466 * src/maemo/modest-account-view-window.c: Set a title for the window.
1468 2007-06-02 Armin Burgmeier <armin@openismus.com>
1470 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1471 incoming and outgoing server name based on email address and server
1472 types as long as the names have not been edited manually. This fixes
1473 projects.maemo.org bug NB#58671.
1475 2007-06-02 Armin Burgmeier <armin@openismus.com>
1477 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1478 server type cannot be changed in future to the incoming details page
1479 when creating an account. This fixes projects.maemo.org bug NB#59029.
1481 2007-06-02 Armin Burgmeier <armin@openismus.com>
1483 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1484 and assigned max width chars so that they wrap instead of being
1485 truncated. Fixes projects.maemo.org bug NB#56126.
1487 2007-06-02 Armin Burgmeier <armin@openismus.com>
1489 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1490 introductory note to the connection specific smtp servers dialog, as
1491 section 8.12 of the email UI specification requires. This fixes
1492 projects.maemo.org bug NB#59212.
1494 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1496 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1497 Check for running mail operations, and offer to cancel them, as per the UI
1498 spec. This fixes projects.maemo.org bug NB#59041 .
1499 However, I suspect that tinymail may still use the network connection
1500 in ways that we cannot detect or cancel. But it should at least adapt to
1501 changes fairly well.
1503 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1505 * src/modest-tny-account-store.c: (recreate_all_accounts),
1506 (get_cached_accounts), (get_server_accounts): Do more sensible
1507 ref-counting of the temporarily-cached outbox accounts list. This seems
1508 to fix a crash when entering the password when the password was wrong.
1510 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1512 * src/gnome/modest-main-window.c: (connect_signals):
1513 * src/modest-tny-account-store.c: (get_password),
1514 (modest_tny_account_store_alert): Added comments and clues and
1515 commented-out code about how we currently fail to deal with connection
1516 errors and wrong passwords, and how we should.
1518 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1520 * src/widgets/modest-retrieve-combo-box.c:
1521 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1522 This fixes projects.maemo.org bug NB#58472 .
1524 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/easysetup/modest-easysetup-wizard.c:
1527 (create_page_complete_easysetup):
1528 (create_page_complete_custom): Correct the last commit,
1529 putting the correct sentences in the correct pages.
1531 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1533 * src/maemo/easysetup/modest-easysetup-wizard.c:
1534 (create_page_complete_custom): Show the second sentence of text
1535 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1538 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1540 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1541 Set the leave-on-server conf key by default. This fixes
1542 projects.maemo.org bug NB#59258 .
1544 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1546 * src/maemo/modest-account-view-window.c:
1547 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1548 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1551 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1553 * src/maemo/easysetup/modest-easysetup-wizard.c:
1554 (create_caption_new_with_asterisk):
1555 * src/maemo/modest-account-settings-dialog.c:
1556 (create_caption_new_with_asterisk):
1557 Uncomment the code to add the asterisk, because they are no longer in the
1558 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1559 (update_incoming_server_title): Add an asterisk here too.
1561 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/modest-maemo-global-settings-dialog.c:
1564 (current_connection): Check that we are even connected before trying to
1565 get the current connection name, to prevent a warning.
1567 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1568 Change the comments because tny_maemo_conic_device_connect() is now meant to
1570 * src/modest-mail-operation.c:
1571 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1572 make sure we have a connection and fail if we can't connect.
1574 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1576 * src/maemo/modest-main-window.c:
1577 (on_account_store_connecting_finished): Do not try to get the
1578 connection ID if we are not really connected. I am surprised that
1579 this signal handler is called when we are not connected.
1581 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1583 * src/modest-error.h:
1584 * src/modest-ui-actions.c:
1585 (modest_ui_actions_get_msgs_full_error_handler):
1586 Renamed an enum, added comments, added an enum
1587 for retrieve-limit errors.
1589 * src/modest-mail-operation.c: (foreach_add_item),
1590 (internal_folder_observer_update), (update_account_thread),
1591 (modest_mail_operation_get_msgs_full):
1592 (modest_mail_operation_update_account),
1593 Added comments about how this works, and some code that should
1594 (but does not) check the retrieve-limit. See the TODO comment.
1596 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1598 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1599 Initialize help_id to fix the build. Warnings are good.
1601 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1603 * src/widgets/modest-hbox-cell-renderer.c:
1604 (modest_hbox_cell_renderer_append):
1605 * src/widgets/modest-vbox-cell-renderer.c:
1606 (modest_vbox_cell_renderer_append):
1607 Fix the last commit by doing an extra ref.
1609 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1611 * src/widgets/modest-hbox-cell-renderer.c:
1612 (modest_hbox_cell_renderer_append):
1613 * src/widgets/modest-vbox-cell-renderer.c:
1614 (modest_vbox_cell_renderer_append):
1615 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1616 to fix the build with Maemo Bora.
1617 However, there seems to be a remaining crash, probably due to reference
1620 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-tny-account.c:
1623 (modest_tny_account_new_for_local_folders):
1624 Use hildon_file_system_info_async_new() to get a better name for
1625 the memory card account, setting it as the account name.
1626 The timing seems to work, but this is probably
1627 not the best place to do this. See the TODO comment.
1628 * src/maemo/modest-main-window.c: (create_details_widget):
1629 * src/widgets/modest-folder-view.c: (text_cell_data):
1630 Use the tny account name instead of hardcoding a name.
1632 2007-05-30 Christian Kellner <ckellner@openismus.com>
1634 * src/modest-search.c: (modest_search):
1635 Correctly set part_search_func even if we have already parsed
1636 the query and thus a valid OgsTextSearcher object.
1638 2007-05-30 Christian Kellner <ckellner@openismus.com>
1641 Search and check for libogs.
1644 Incooparte the ogs build env.
1646 * src/modest-mime-part-search-stream.c:
1647 * src/modest-mime-part-search-stream.h:
1648 Removed since we do the real searching now in modest-search.c.
1650 * src/modest-search.c:
1651 * src/modest-search.h:
1652 Implement support for ogs. We use that if available and requested
1653 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1654 should now handle the corner case when the search term is spread
1655 across multiple reads.
1656 Also the logic in modest_search () was corrected to search all
1657 requested fields until one is found.
1659 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1661 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1663 * src/modest-init.h:
1664 * src/modest-init.c: Made modest_init_local_folders() take a
1665 path and be public so we can iniitialize maildir folders on
1668 * src/modest-local-folder-info.h:
1669 * src/modest-local-folder-info.c:
1670 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1672 * src/modest-tny-account.c:
1673 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1674 still means the standard local-folders path on the local volume.
1676 * src/modest-tny-account-store.c:
1677 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1678 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1679 all accounts when that happens.
1680 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1681 this too, so it shows up in the treeview.
1683 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/modest-maemo-global-settings-dialog.c:
1686 (current_connection):
1687 * src/widgets/modest-global-settings-dialog.c:
1688 (current_connection_default):
1689 Use the enum values instead of 0, 1 and -1,
1690 to make the code clearer.
1692 * src/modest-account-mgr-helpers.c:
1693 (modest_account_mgr_get_connection_specific_smtp): Make this code
1696 * src/modest-runtime.h:
1697 * src/modest-runtime.c:
1698 Added modest_runtime_remove_all_send_queues().
1699 * src/maemo/modest-main-window.c:
1700 (on_account_store_connecting_finished): Recreate the send queues,
1701 using the appropriate transport accounts for this new connection.
1702 Some futher adapting might be needed if the old send queues are not
1703 automatically stopped at this point.
1705 * src/modest-tny-account-store.c: (get_server_accounts):
1706 Create the connection-specific transport accounts, so that they can
1707 be found later by their ID.
1709 * src/modest-tny-account.h:
1710 * src/modest-tny-account.c:
1711 Added modest_tny_account_new_from_server_account_name().
1712 modest_tny_account_new_from_server_account(): Do not create the
1713 send queues here, because they will be
1714 recreated anyway when the connection changes for the first time.
1716 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-local-folder-info.h:
1719 * src/modest-local-folder-info.c:
1720 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1721 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1722 tbox_folder): Take a modest account name instead of a server TnyAccount,
1723 so we can have per-modest-account rather than per-transport-account
1725 We must make sure that we change or recreate the exisitng send queues
1726 when the connection changes for connection-specific transport accounts.
1728 * src/modest-tny-account-store.c:
1729 (create_per_account_local_outbox_folders): Create outboxed per modest
1730 account, not per transport account.
1732 * src/modest-tny-account.h:
1733 * src/modest-tny-account.c:
1734 (modest_tny_account_get_special_folder): For outboxes, get the
1735 parent modest account name. The account is ignored for other folders.
1736 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1737 modest account name rather than a server TnyAccount.
1739 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1741 * src/modest-tny-account.c:
1742 (modest_tny_account_new_from_server_account):
1743 Call modest_runtime_get_send_queue() immediately after creating transport
1744 accounts, so that they start trying to send email from the outbox as soon
1745 as possible at startup. This is probably what we want.
1747 * src/modest-mail-operation.c: (update_account_thread):
1748 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1749 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1750 * src/modest-tny-send-queue.h:
1751 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1752 (modest_ui_actions_on_send):
1753 Added comments about how sending works, though it needs some more work.
1755 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-tny-account.c:
1758 (modest_tny_account_get_special_folder): Add TODO because this fails when
1759 the network is busy.
1760 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1761 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1762 Do not try to show this window when there is no active account. The UI
1763 specs does not tell us what to do in this case.
1765 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1769 * src/maemo/Makefile.am:
1770 * src/widgets/Makefile.am: Some dist fixes.
1772 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1774 * src/maemo/modest-connection-specific-smtp-window.c:
1775 (on_button_edit): Make the code clearer, to prevent a double free.
1777 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1779 * src/maemo/modest-account-settings-dialog.c:
1780 (modest_account_settings_dialog_set_account_name),
1781 Check the connection-specific smtp servers checkbox if there are any.
1783 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1784 (modest_connection_specific_smtp_edit_window_init):
1785 Start with a suitable port number.
1787 * src/modest-account-mgr-helpers.h:
1788 * src/modest-account-mgr-helpers.c: Added
1789 modest_account_mgr_get_has_connection_specific_smtp().
1791 (modest_account_mgr_set_connection_specific_smtp),
1792 (modest_account_mgr_remove_connection_specific_smtp),
1793 (modest_account_mgr_get_has_connection_specific_smtp),
1794 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1795 connection-specific smtp server accounts in the account, rather than
1796 the server account conf dir.
1798 This fixes bug projects.maemo.org bug NB#58263 .
1800 * src/modest-tny-account-store.c:
1801 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1802 if there are no server accounts yet, to prevent an infinite loop when there
1803 are no accounts. Document that one must be called before the other.
1805 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1807 * src/modest-account-mgr-helpers.c:
1808 (modest_account_mgr_get_default_account): Make sure that at least
1809 one account is always the default, if there are any enabled accounts.
1810 This is just a sanity check that shouldn't be necessary.
1812 * src/modest-account-mgr-priv.c:
1813 (_modest_account_mgr_account_from_key): Unescape the conf key to
1814 get the real account name. For instance, this is an issue if a space
1815 was in the account name, which can happen because the account name
1816 is generated from the display name.
1817 (_modest_account_mgr_get_account_keyname): Always escape the
1819 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1820 Unescape the conf keys to get the real account names.
1822 For instance, previously the is-default radio button in the accounts
1823 list was not checked for any accounts at first. This fixes that,
1824 and might fix several similar bugs.
1826 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1828 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1829 Removed some debug printfs.
1831 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1833 Modest on-disk outbox directories are now here, for instance:
1834 $HOME/.modest/outboxes/<account-id-1>/outbox
1835 $HOME/.modest/outboxes/<account-id-2>/outbox
1837 $HOME/.modest/local-folders/outbox
1838 so we can have a separate outbox for each account.
1839 But they are shown as one outbox in the GtkTreeView, by using a
1840 TnyMergeFolder in a ModestTnySimpleFolderStore.
1843 * src/modest-tny-simple-folder-store.c:
1844 * src/modest-tny-simple-folder-store.h:
1845 Added ModestTnySimpleFolderStore, used to contain folders from
1846 other folder stores, such as other accounts.
1848 * src/modest-tny-outbox-account.h:
1849 * src/modest-tny-outbox-account.c:
1850 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1851 used for the per-account local outbox folders.
1853 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1854 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1855 only use this (internally) now for the non-outbox local folders.
1857 * src/modest-init.h:
1858 * src/modest-init.c: Added modest_init_one_local_folder(), for
1859 setting up the directory structure for each local folder.
1861 * src/modest-local-folder-info.c:
1862 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1863 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1865 * src/modest-local-folder-info.h:
1866 * src/modest-tny-account-store.c: (on_account_removed),
1867 (on_account_changed), (create_per_account_local_outbox_folders),
1868 (get_server_accounts), (modest_tny_account_store_get_accounts),
1869 (modest_tny_account_store_get_tny_account_by_account),
1870 (modest_tny_folder_store_is_virtual_local_folders):
1872 * src/modest-tny-account.h:
1873 * src/modest-tny-account.c:
1874 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1875 to create an on-disk per-account local outbox folder for each
1877 (create_per_account_local_outbox_folders): Create a local outbox folder
1878 for each transport account.
1879 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1880 for all local folders.
1882 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1883 instead of using g_object_get/set() directly. It is clearer.
1885 (modest_tny_folder_store_get_message_count),
1886 (modest_tny_folder_store_get_local_size
1887 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1888 because we now use these with non-acount folder stores.
1890 (modest_tny_account_get_special_folder),
1891 (modest_tny_account_new_from_server_account),
1892 (modest_tny_account_new_from_account):
1893 (recurse_folders): Adjust to the new outbox system.
1895 * src/modest-tny-folder.h:
1896 * src/modest-tny-folder.c:
1897 (modest_tny_folder_is_local_folder),
1898 (modest_tny_folder_get_local_folder_type),
1899 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1901 * src/widgets/modest-main-window.h:
1902 * src/maemo/modest-main-window.c: (create_details_widget),
1903 (modest_main_window_set_contents_style): Show details for any folder store,
1906 (modest_tny_folder_get_rules):
1907 Remove the const. C does not support constness enough for this.
1909 * src/modest-ui-actions.c:
1910 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1911 make all outboxes appear as one, in the usual local-folders tree node.
1913 (set_active_account_from_tny_account),
1914 (modest_ui_actions_on_folder_selection_changed):
1915 * src/widgets/modest-folder-view.c: (text_cell_data),
1916 (icon_cell_data), (filter_row),
1917 (add_account_folders_to_merged_folder),
1918 (add_account_folders_to_simple_folder_store), (),
1919 (get_cmp_rows_type_pos), (cmp_rows),
1920 (modest_folder_view_set_account_id_of_visible_server_account):
1921 Adjust to the new outbox system, using generic folder stores and folders
1922 in the GtkTreeModel.
1924 2007-05-23 Christian Kellner <ckellner@openismus.com>
1926 * src/modest-mail-operation.c:
1927 (modest_mail_operation_update_account):
1928 Use info->max_size instead of unintialized local var [small
1929 build fix]. (Added TODO to review that change since I don't
1932 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1934 * libmodest-dbus-client/libmodest-dbus-client.c:
1935 (libmodest_dbus_client_compose_mail): function added
1936 * src/dbus_api/modest-dbus-api.h:
1937 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1938 (on_compose_mail): Implementation of the SendAsMail functionality
1940 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-account-mgr.c:
1943 (modest_account_mgr_add_server_account): Set the secure-connection
1944 conf key for transport accounts as well as store accounts. I don't know
1945 why the if was there. For instance, this makes sure that we use SSL
1946 for the gmail preset from the easysetup wizard.
1948 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1950 * src/gnome/modest-main-window.c:
1951 (on_account_store_connecting_finished), (connect_signals):
1952 * src/maemo/modest-main-window.c:
1953 (on_account_store_connecting_finished), (connect_signals),
1954 (modest_main_window_new):
1955 Handle TnyAccountStore::connecting-finished instead of
1956 TnyDevice::connection-changed, because we cannot actually perform
1957 operations on accounts until TnyAccountStore has itself responded to
1958 the TnyDevice::connection-changed signal. This prevents a GError from
1960 Do not try to update at startup, because we (at least on scratchbox)
1961 already do an update at startup when the device goes online.
1962 This prevents a GError from tinymail.
1963 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1964 Added TODO about stopping simultaneous operations.
1966 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1968 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1969 * src/modest-mail-operation-queue.c:
1970 (modest_mail_operation_queue_remove):
1971 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1972 about where they happened.
1974 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1976 * src/modest-ui-actions.c:
1977 (modest_ui_actions_on_password_requested): Make sure that the remember
1978 output parameter is always TRUE.
1980 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1982 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1983 Show a OK/Cancel dialog if the error is a question, though we still do not
1984 know anything more about what we are asking the user.
1985 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1986 Fix an uninitialized variable (helper). This is a logic error, however.
1988 2007-05-21 Christian Kellner <ckellner@openismus.com>
1990 * src/modest-search.h:
1991 Correct bit shifting in the ModestSearchFlags enum.
1993 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1995 * src/modest-tny-account.c:
1996 (modest_tny_account_new_from_server_account): Do not use the lsub and
1997 check-all hard-coded IMAP options when using POP.
1999 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-tny-account.c:
2002 (modest_tny_account_new_from_server_account):
2003 Use NULL for the secure-auth method for POP when Password auth has been
2004 specified by the user, as we already do for IMAP. "auth=Login" causes
2005 an error from camel or the server.
2007 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2009 * src/maemo/modest-account-settings-dialog.c:
2010 (create_page_account_details),
2011 (modest_account_settings_dialog_set_account_name):
2012 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2013 for the leave-on-server checkbox, rathr than just the checkbox, when
2014 the protocol is not POP.
2016 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2018 * src/widgets/modest-account-view.c:
2019 * src/widgets/modest-account-view.h:
2020 Added modest_account_view_select_account() which will be useful later
2021 to asynchronously re-select the edited account.
2023 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2025 * src/maemo/modest-account-settings-dialog.c:
2026 (modest_account_settings_dialog_set_account_name):
2027 Automatically choose the port numbers based on the secure authentication
2028 methods, if they have not been chosen before.
2029 This fixes projects.maemo.org bug NB#56273 .
2031 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2033 * src/maemo/modest-main-window-ui.h:
2034 * src/modest-ui-actions.c:
2035 * src/modest-ui-actions.h:
2036 Connect the Tools/SMTP Servers menu item to
2037 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2038 SMTP servers dialog, as in the UI specification and saves changes when it
2039 is closed. This fixed projects.maemo.org bug NB#56305 .
2041 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2043 * src/maemo/modest-connection-specific-smtp-window.c:
2044 (modest_connection_specific_smtp_window_init):
2045 Use gtk_window_set_default_size() to make this window big enough, so
2046 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2048 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2050 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2051 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2052 (modest_connection_specific_smtp_edit_window_init),
2053 Do not try to connect to a combobox signal before the combobox exists.
2054 This fixes the cras in projects.maemo.org bug NB#56288 .
2055 (modest_connection_specific_smtp_edit_window_get_settings):
2056 Remove the server_account_name parameter which was being checked for NULL
2057 though it was not used.
2059 * src/maemo/modest-connection-specific-smtp-window.c:
2060 (modest_connection_specific_smtp_window_fill_with_connections),
2061 (on_button_edit), (modest_connection_specific_smtp_window_init):
2062 Correct the number of treemodel columns to prevent a warning.
2063 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2064 libconic does not work.
2066 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-tny-account.c:
2069 (modest_tny_account_new_from_server_account):
2070 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2071 SMTP when "None" was chosen by the user. However, with my SMTP server that
2072 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2075 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2077 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2078 to explain the memory management issue with the ID in the ModestPair.
2080 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2081 (add_sending_page), (modest_account_assistant_finalize):
2082 * src/gnome/modest-gnome-global-settings-dialog.c:
2083 (create_updating_page), (create_composing_page):
2084 * src/gnome/modest-msg-edit-window.c: (get_transports),
2085 (init_window), (modest_msg_edit_window_finalize),
2086 (modest_msg_edit_window_get_msg_data):
2087 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2088 * src/gnome/modest-transport-widget.c:
2089 (modest_transport_widget_finalize), (smtp_configuration):
2090 * src/maemo/modest-maemo-global-settings-dialog.c:
2091 (create_updating_page), (create_composing_page):
2092 * src/maemo/modest-msg-edit-window.c: (get_transports),
2093 (init_window), (modest_msg_edit_window_finalize),
2094 (modest_msg_edit_window_get_msg_data),
2095 (modest_msg_edit_window_free_msg_data):
2096 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2097 (modest_store_widget_finalize):
2098 * src/maemo/modest-transport-widget.c:
2099 (modest_transport_widget_finalize), (smtp_configuration):
2100 * src/modest-main.c: (send_mail):
2101 * src/widgets/modest-combo-box.h:
2102 * src/widgets/modest-global-settings-dialog-priv.h:
2103 * src/widgets/modest-global-settings-dialog.c:
2104 (modest_global_settings_dialog_finalize):
2105 * src/widgets/modest-msg-edit-window.h:
2106 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2107 as long as the combo box, to prevent use of freed memory for the ID.
2109 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2111 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2112 get_accounts(), to make this clearer. Do not check for the enabled gconf
2113 key, because we do not use this for server accounts (at least, not yet).
2114 This allows us to send email again.
2116 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2118 * src/maemo/modest-platform.c:
2119 (on_modest_conf_update_interval_changed), (modest_platform_init):
2120 Only respond to this particular key change. All these strcmp()s cannot be
2123 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2125 * src/maemo/modest-maemo-global-settings-dialog.c:
2126 (current_connection): Prevent a crash in scratchbox when
2127 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2128 * src/maemo/modest-platform.c:
2129 (on_modest_conf_update_interval_changed), (modest_platform_init):
2130 Get the update interval from gconf and reset it when the gconf key changes.
2132 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2134 * src/modest-protocol-info.c:
2135 * src/modest-protocol-info.h: Adde enum-specific get functions,
2136 instead of using a ModestProtocolType enum parameter.
2138 * src/gnome/modest-account-assistant.c:
2139 * src/gnome/modest-store-widget.c:
2140 * src/gnome/modest-store-widget.h:
2141 * src/gnome/modest-transport-widget.c:
2142 * src/gnome/modest-transport-widget.h:
2143 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2144 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2145 * src/maemo/easysetup/modest-easysetup-wizard.c:
2146 * src/maemo/modest-account-settings-dialog.c:
2147 * src/maemo/modest-account-settings-dialog.h:
2148 * src/maemo/modest-store-widget.c:
2149 * src/maemo/modest-store-widget.h:
2150 * src/maemo/modest-transport-widget.c:
2151 * src/maemo/modest-transport-widget.h:
2152 * src/modest-account-mgr-helpers.c:
2153 * src/modest-account-mgr-helpers.h:
2154 * src/modest-account-mgr.c:
2155 * src/modest-account-mgr.h:
2156 * src/modest-tny-account.c:
2157 * src/modest-tny-folder.c:
2158 * src/widgets/modest-account-view.c:
2159 * src/widgets/modest-retrieve-combo-box.c:
2160 * src/widgets/modest-retrieve-combo-box.h:
2161 * src/widgets/modest-secureauth-combo-box.c:
2162 * src/widgets/modest-serversecurity-combo-box.c:
2163 * src/widgets/modest-serversecurity-combo-box.h:
2164 * tests/check_account-mgr.c:
2165 Use the specific functions, and use the re-renamed enum values for GNOME too.
2167 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2169 * src/modest-pair.h:
2170 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2171 so we can get the second based on the first.
2173 * src/maemo/modest-account-settings-dialog.h:
2174 * src/maemo/modest-account-settings-dialog.c:
2175 Added get_supported_secure_authentication_methods(), though it is mostly
2176 commented-out for now until the necessary API is committed to tinymail.
2177 (modest_account_settings_dialog_set_account_name),
2178 (save_configuration): Request the supported authentication methods from the
2179 server, so we can choose a working method.
2181 * src/modest-tny-account-store.h:
2182 * src/modest-tny-account-store.c:
2183 (modest_tny_account_store_get_session): Rename from
2184 tny_account_store_get_session().
2186 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2188 * src/modest-protocol-info.h: Split the ModestProtocol enum
2189 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2190 There was no need to have these unrelated values in one enum.
2192 * src/: many files: Adapted to changed enum. This makes the code a bit
2193 clearer, and the compiler could catch some errors.
2195 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2197 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2198 Show the detailed internal camel error message when an error happens
2199 during the configuration, so that our testers can give us more clues.
2200 For instance, in projects.maemo.org bug NB#56910 .
2202 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2204 * src/modest-tny-account.c:
2205 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2206 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2208 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2211 * src/maemo/modest-account-settings-dialog.c:
2212 (modest_account_settings_dialog_set_account_name),
2213 (save_configuration): For the incoming secure authentication checkbox,
2214 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2215 the UI specification. PLAIN does not seem to be supported for most IMAP
2216 servers anyway, and I am not sure what it would mean.
2217 However, we probably need to discover which of the secure-authentication
2218 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2219 * src/modest-account-mgr-helpers.c:
2220 (modest_account_mgr_get_server_account_data):
2222 * src/modest-tny-account.c:
2223 (modest_tny_account_new_from_server_account):
2224 Use tny_account_set_mech() to set secure-authentication methods,
2225 with some special-casing for IMAP, based on my observations of how
2228 * src/modest-account-mgr-helpers.h:
2229 * src/modest-account-mgr.c:
2230 * src/modest-defs.h: Comment that the URI is only used for local folders.
2232 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2235 parameter const, just to be neat.
2236 * src/modest-text-utils.c: (modest_text_utils_inline):
2237 End g_strconcat() with NULL, as its documentation says. This is almost
2238 certainly the cause of my crash at startup on the device. Interestingly,
2239 valgrind doesn't tell us about these errors.
2241 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2243 * scripts/build-packages: Added more precise comments about how to use
2244 this script, though I still get this error:
2245 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2246 error building tinymail
2248 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2250 * src/maemo/modest-main-window.c: (on_account_update):
2251 Very slight cleanup, hoping to make it simpler to discover what causes
2252 a crash here sometimes.
2254 * src/modest-tny-account.c:
2255 (modest_tny_account_new_from_server_account): Set the port. Added
2256 comments about the options and a TODO comment because I need to find out
2257 how to specify the secure authentication method.
2259 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2261 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2262 changed CFlags paths form modest to libmodest
2264 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2266 * src/modest-account-mgr-helpers.c:
2267 (modest_account_mgr_get_server_account_data),
2268 (modest_account_mgr_free_server_account_data):
2269 * src/modest-account-mgr-helpers.h:
2270 * src/modest-account-mgr.c:
2271 (modest_account_mgr_add_server_account):
2272 * src/modest-defs.h:
2273 * src/modest-tny-account.c:
2274 (modest_tny_account_new_from_server_account):
2275 Determine the options for tny_camel_account_add_option() here,
2276 based on the settings, rather than storing them directly in gconf.
2278 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2281 Show a more friendly error dialog now that we expect (from the tinymail
2282 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2284 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2286 * src/maemo/modest-main-window.c: (on_account_update): Check that
2287 account_name is not NULL, to prevent a crash at startup that I am
2288 seeing on the N800. I do wonder why it is NULL.
2290 * src/maemo/easysetup/modest-easysetup-wizard.c:
2291 (create_page_user_details):
2292 * src/maemo/modest-account-settings-dialog.c:
2293 (create_page_user_details), (create_page_outgoing):
2294 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2295 (modest_connection_specific_smtp_edit_window_init):
2296 * src/modest-ui-actions.c:
2297 (modest_ui_actions_on_password_requested):
2298 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2299 might do something useful with the on-screen keyboard.
2301 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2303 * src/maemo/modest-main-window.c: (on_account_update):
2304 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2305 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2307 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2309 * src/modest-tny-account-store.c: (on_account_changed):
2310 Correct the signature of this signal handler.
2312 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2314 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2315 Show a HildonNote instead of a GtkDialog for Maemo.
2317 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2319 * src/widgets/modest-account-view.h:
2320 * src/widgets/modest-account-view.c: (on_account_changed),
2321 (on_account_removed). Added a boolean flag, set/unset by
2322 modest_account_view_block_conf_updates(),
2323 modest_account_view_unblock_conf_updates() to prevent unnecessary
2324 updates, but this is not very useful because the gconf notifications are
2325 so delays (maybe only on Maemo Bora).
2326 So auto-updating is turned off, and these functions do an explicit
2327 update when necessary.
2328 However, something else is still doing too much work when adding/removing
2329 accounts, probably in another part of the application.
2331 * src/maemo/modest-account-view-window.c:
2332 (on_delete_button_clicked), (on_edit_button_clicked),
2333 (on_new_button_clicked): Use the new functions.
2335 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2337 * src/modest-account-mgr-helpers.c:
2338 (modest_account_mgr_set_first_account_as_default):
2339 Sort the list of names alphabetically-by-title, so we choose the first one
2341 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2342 alphabetically by the title.
2344 This fixes projects.maemo.org bug NB#56418 .
2346 * src/modest-account-mgr-priv.c:
2347 (_modest_account_mgr_account_from_key):
2348 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2349 avoid a valgrind error, and possible random behaviour.
2351 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2354 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2355 tinymail documentation to say that this can be expected.
2356 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2357 pretty, and should not happen, but I would prefer to know when it does.
2359 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2361 * configure.ac: When using the older hildon version, probably on Bora,
2362 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2364 * src/widgets/modest-attachment-view.c:
2365 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2368 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2370 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2371 Implemented the prototype. Can be tested with
2372 tests/dbus_api/test_open_message:
2374 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2376 * src/modest-tny-account-store.c:
2377 (modest_tny_account_store_instance_init), (get_password):
2378 * src/modest-ui-actions.c:
2379 (modest_ui_actions_on_password_requested):
2380 Do not store the password in gconf, because this function is called
2381 for non-remembered passwords. Actually use the cached (in the hash map)
2382 password instead of releasing it.
2383 The password will now not be remembered if it is asked via the protected
2384 password dialog, as per the UI spec.
2386 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2388 * src/modest-defs.h:
2389 * src/modest-account-mgr-helpers.h:
2390 * src/modest-account-mgr-helpers.c:
2391 Added modest_server_account_get_username_has_succeeded(),
2392 modest_server_account_set_username_has_succeeded().
2393 (modest_server_account_set_username),
2394 Reset the has-succeeded flag if the username changes.
2396 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2397 * src/maemo/modest-connection-specific-smtp-window.c:
2398 (modest_connection_specific_smtp_window_save_server_accounts):
2399 Use modest_server_account_set_username() instead of using
2400 modest_conf_set_string() directly, so that the has-succeeded flag is always
2403 * src/modest-ui-actions.c:
2404 (modest_ui_actions_on_password_requested): Dim the username entry if
2405 the username has ever worked, as per the UI spec.
2407 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2409 * src/modest-tny-account-store.c: (get_password):
2410 * src/modest-ui-actions.c:
2411 (modest_ui_actions_on_password_requested):
2412 Allow the username to be changed too, though there is more work to
2413 be done on exactly how this behaves.
2415 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2417 * src/modest-account-mgr-helpers.h:
2418 * src/modest-account-mgr-helpers.c:
2419 Added modest_account_mgr_get_display_name(),
2420 modest_server_account_get_username(),
2421 modest_server_account_set_username(),
2422 modest_server_account_set_password(),
2423 modest_server_account_get_hostname() functions so we do not need to
2424 use the conf API directly.
2426 * src/maemo/modest-main-window.c: (connect_signals):
2427 Actually connect ot the ModestAccountStore::request-password signal,
2428 so that we show the dialog when the password is requested by Tinymail,
2429 for isntance if it is empty.
2431 * src/modest-marshal.list:
2432 * src/modest-tny-account-store.c:
2433 (modest_tny_account_store_class_init), (get_password),
2434 (modest_tny_account_store_alert):
2435 * src/modest-tny-account-store.h:
2436 * src/modest-ui-actions.h:
2437 * src/modest-ui-actions.c:
2438 (modest_ui_actions_on_password_requested):
2439 Change the signal parameters, so it is obvious that we are providing
2440 the non human-readable server name, and receiving both the username
2441 and password, though changing of the username is not yet implemented.
2442 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2443 for the GNOME version.
2445 This should fix the projects.maemo.org bug NB#56209, though it does not
2446 work on Bora, because the gconf_client_get() for the password fails
2447 immediately after we save it with gconf_client_set().
2449 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2452 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2453 caused an undefined symbol error:
2454 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2456 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2458 * src/modest-tny-account-store.c:
2459 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2460 using a GError instead of a string message, so we can translate it in
2463 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/modest-address-book.c:
2466 (modest_address_book_check_names):
2467 * src/maemo/modest-msg-view-window.c:
2468 (modest_msg_view_window_clipboard_owner_change):
2469 * src/modest-init.c: (modest_init_init_ui):
2470 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2471 (update_folders_cb), (modest_mail_operation_update_account):
2472 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2473 (modest_ui_actions_on_msg_attachment_clicked),
2474 (modest_ui_actions_on_msg_recpt_activated):
2475 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2476 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2477 (modest_msg_view_search_next):
2478 * src/widgets/modest-recpt-editor.c:
2479 (modest_recpt_editor_on_button_release_event),
2480 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2481 g_message(). At this point we should only be seeing interesting errors on
2482 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2484 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2486 (modest_wizard_dialog_force_title_update):
2487 * src/maemo/easysetup/modest-wizard-dialog.h:
2488 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2489 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2490 can update the title when appropriate. Otherwise the title is wrong if the
2491 pages are added after adding the notebook to the dialog.
2492 This must be a problem in HildonWizardDialog too.
2493 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2495 * src/maemo/easysetup/modest-easysetup-wizard.c:
2496 (create_subsequent_customsetup_pages),
2497 (create_subsequent_easysetup_pages):
2498 Call modest_wizard_dialog_force_title_update() so that the title is
2499 correct even with GTK+ < 2.10.
2500 This fixes projects.maemo.org bug NB#56145 .
2502 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2504 * src/maemo/modest-platform.c:
2505 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2506 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2509 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2511 * src/widgets/modest-window.h:
2512 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2513 and modest_window_save_state(), which invokes it.
2515 * src/widgets/modest-window-mgr.h:
2516 * src/widgets/modest-window-mgr.c:
2517 Added modest_window_mgr_save_state_for_all_windows(), which calls
2518 the save_state vfunc on all registered windows, if implemented.
2520 * src/gnome/modest-msg-edit-window.c:
2521 * src/gnome/modest-msg-view-window.c:
2522 * src/maemo/modest-msg-edit-window.c:
2523 * src/maemo/modest-msg-view-window.c:
2524 * src/maemo/modest-main-window.c:
2525 Specify the existing save_settings functions as implementations of
2526 ModestWindow::save_state_func().
2528 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2529 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2530 enabling hibernation, for instance.
2532 We may need to do the same thing for restoring settings.
2535 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2537 * src/widgets/modest-window-mgr.c:
2538 * src/widgets/modest-window-mgr.h:
2539 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2540 modest_window_mgr_get_hibernation_is_prevented().
2542 * src/maemo/modest-main-window.c:
2543 (on_hildon_program_is_topmost_notify): Prevent hibernation
2544 (possible when the application goes to the background in the WM),
2545 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2547 * src/maemo/easysetup/modest-easysetup-wizard.c:
2548 (modest_easysetup_wizard_dialog_init):
2549 * src/maemo/modest-account-settings-dialog.c:
2550 (modest_account_settings_dialog_init):
2551 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2552 (modest_connection_specific_smtp_edit_window_init):
2553 * src/maemo/modest-connection-specific-smtp-window.c:
2554 (modest_connection_specific_smtp_window_init):
2555 * src/maemo/modest-signature-editor-dialog.c:
2556 (modest_signature_editor_dialog_init):
2557 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2558 prevent hibernation while any of these account settings dialogs are open.
2560 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2562 * src/maemo/Makefile.am:
2563 * src/maemo/modest-osso-state-saving.c:
2564 * src/maemo/modest-osso-state-saving.h: Added
2565 modest_osso_load_state() and modest_osso_save_state() though they do
2566 nothing now. They should iterate through all the open windows and load/save
2568 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2569 save state when closing.
2571 * src/maemo/modest-main-window.c:
2572 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2573 Add a notification handler for the HildonProgram::is-topmost property,
2574 so we can allow hibernation when the application goes into the background.
2575 But we still need to detect when the accounts setup windows are open so
2576 we can stop hibernation when they are open.
2577 To do this, I also added the main window the HildonProgram. This might have
2578 other side-effects/benefits, and should maybe be done for other windows.
2580 * src/maemo/modest-osso-autosave-callbacks.h:
2581 * src/maemo/modest-osso-autosave-callbacks.c:
2582 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2583 though it does not do anything yet, and we might never need this to do
2584 anything. For instance, we already save drafts.
2586 * src/maemo/modest-platform.c: (modest_platform_init):
2587 Specify the libosso auto-save callback.
2589 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2591 * src/maemo/modest-platform.c:
2592 (modest_platform_set_update_interval):
2593 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2594 aparently stays valid between application instances, so we can use this
2595 to remove and reset it later. According to a maemo-developers email from
2598 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2600 * configure.ac: Depend on libalarm for Maemo.
2602 * src/dbus_api/modest-dbus-api.h:
2603 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2604 (on_send_receive), (modest_dbus_req_handler):
2605 Handle a SEND_RECEIVE D-Bus method.
2607 * libmodest-dbus-client/libmodest-dbus-client.c:
2608 (libmodest_dbus_client_send_and_receive):
2609 * libmodest-dbus-client/libmodest-dbus-client.h:
2610 Add C convenience functions for calling the new D-Bus method.
2612 * src/modest-platform.h:
2613 * src/gnome/modest-platform.c:
2614 * src/maemo/modest-platform.c:
2615 Added modest_platform_set_update_interval(), which uses the
2616 alarmd API on Maemo.
2617 (modest_platform_init),
2618 Call modest_platform_set_update_interval(), using a hard-coded
2619 interval for now (until the global settings dialog is implemented),
2620 though I am not sure that this makes sense yet.
2622 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2624 * src/dbus_api/modest-dbus-callbacks.c:
2625 (modest_osso_cb_hw_state_handler):
2626 * src/dbus_api/modest-dbus-callbacks.h:
2627 * src/maemo/modest-platform.c: (modest_platform_init):
2628 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2629 in case this has some effect on the ability for Maemo to ping the
2632 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2634 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2635 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2636 warning. It is probably a logic error, but I need to fix the build.
2638 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-account-mgr.h:
2641 * src/modest-account-mgr.c:
2642 (modest_account_mgr_account_names): Add a gboolean enabled_only
2643 parameter, so we can get lists of onlt the enabled accounts.
2645 (modest_account_mgr_add_account),,
2646 (modest_account_mgr_account_with_display_name_exists):
2647 * src/maemo/modest-msg-edit-window.c: (get_transports):
2648 * src/modest-account-mgr-helpers.c:
2649 (modest_account_mgr_set_first_account_as_default):
2650 * src/modest-init.c: (init_default_account_maybe):
2651 * src/modest-tny-account-store.c: (get_accounts):
2652 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2653 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2654 * tests/check_account-mgr.c: (START_TEST):
2655 Provide the extra parameter, as appropriate.
2657 * src/widgets/modest-account-view.c: (update_account_view):
2658 Do not show disabled accounts (meaning that there is no way to
2659 enable/disable accounts in the UI (the feature is not in our UI
2660 specification), so we can use this internally only to mark unfinished
2661 or temporary account data.
2663 * src/maemo/easysetup/modest-easysetup-wizard.c:
2664 (create_account): Add boolean enable parameter, so we can specify FALSE
2665 to create the temporary account.
2666 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2667 (on_before_next): When finishing, when there is a temporary account, just
2669 Also, use a timeout to delay the showing of the dialog until gconf is likely
2670 to return correct information, due to a maemo gconf bug that is fixed in
2671 osso 1.1, but not yet in Bora.
2672 However, the dialog stays on screen after it is destroyed.
2674 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2675 for invalid data when cancelling. Use a hildon note instead of a dialog
2676 to complain about invalid data. Do not show the account-saved note if the
2677 account is disabled (a temporary account that will not really be saved for use
2680 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2682 * src/modest-account-mgr-helpers.h:
2683 * src/modest-account-mgr-helpers.c:
2684 Added modest_account_mgr_unset_default_account(),
2685 Added modest_account_mgr_set_first_account_as_default().
2687 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2688 If it was the default account, unset the default account name.
2690 * src/maemo/modest-account-view-window.c:
2691 (on_delete_button_clicked): If it was the default account,
2692 set the first remaining account as the default instead.
2694 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2695 a NULL account or a NULL default account, to prevent a crash. This should
2696 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2699 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2701 * src/widgets/modest-recpt-editor.c:
2702 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2703 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2704 TODO comment for this. This fixes the build.
2706 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2707 be the best place for it. This will in future update all auto-update accounts,
2708 rather than just the current/default account, when that gconf key exists.
2709 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2710 if there are no accounts, before calling do_send_receive().
2711 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2713 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2714 * src/maemo/modest-main-window-ui.h:
2715 * src/maemo/modest-main-window.c: (on_connection_changed),
2716 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2717 directly, becaue the signal handler does more.
2719 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2721 * src/modest-account-mgr-helpers.c:
2722 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2723 for the case that the account does not exist.
2725 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2726 (equivalent to the modest account name) rather than the tinymail account name
2727 (equivalent to the modest account title - human readable) to get the account data.
2728 Check for null account data to prevent the crash, and add a TODO comment saying that
2729 this needs fixing because it is using the server account name instead of the account name.
2731 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2733 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2734 * src/maemo/modest-account-settings-dialog.c: (show_error),
2736 Use hildon_note_new_information() for informative and error messages,
2737 which seems to be expected for Maemo applications (no documentation that I know of
2738 says this). I am surprised that there is no distinction between info and error
2741 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2743 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2744 it is easy to find where this is used.
2746 * src/maemo/easysetup/modest-easysetup-wizard.c:
2747 (create_page_welcome), (create_page_account_details),
2748 (create_page_user_details), (create_page_complete_easysetup),
2749 (create_page_custom_incoming), (create_page_custom_outgoing),
2750 (create_page_complete_custom):
2751 * src/maemo/modest-account-settings-dialog.c:
2752 (create_page_account_details), (create_page_user_details),
2753 (create_page_incoming), (create_page_outgoing):
2754 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2755 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2756 (modest_connection_specific_smtp_edit_window_init):
2757 * src/maemo/modest-connection-specific-smtp-window.c:
2758 (modest_connection_specific_smtp_window_init):
2759 * src/maemo/modest-signature-editor-dialog.c:
2760 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2761 and scrolling policy as per the Email Application Layout Guide, if I have
2764 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2766 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2767 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2768 which were empty, because these vfuncs have been removed from TnyAccountStore.
2769 This fixes the build.
2771 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/modest-main-window.c:
2774 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2775 showing/hiding it. Added TODO because it probably should not be NULL.
2776 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2777 because unnecessary g_warnings() make degugging difficult.
2779 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/modest-msg-edit-window.c:
2782 (modest_msg_edit_window_select_color),
2783 (modest_msg_edit_window_select_background_color): 2 const corrections and
2784 moving 2 #endifs before closing brackets, to fix the build.
2786 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2788 * src/maemo/easysetup/modest-easysetup-wizard.h:
2789 * src/maemo/easysetup/modest-easysetup-wizard.c:
2790 (modest_easysetup_wizard_dialog_finalize),
2791 (on_button_edit_advanced_settings), (create_page_complete_custom),
2792 (on_response), (create_account):
2793 Implement the Advanced Settings edit button, by saving the account information,
2794 for the Advanded Settings dialog to use directly from gconf, and removing it
2795 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2796 Bug #5533 in the projects.maemo.org bugzilla.
2798 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2800 * src/maemo/modest-msg-view-window.c:
2801 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2802 when opening a message window.
2804 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2806 * src/maemo/easysetup/modest-easysetup-wizard.c:
2807 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2810 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2811 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2812 gconf settings. I probably added more checks than necessary, but that is safer.
2814 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2815 variable to fix the build, but this seems to be used when it is still NULL.
2817 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2819 * src/modest-platform.h:
2820 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2821 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2822 * src/modest-main.c: Implement this function so we can avoid using
2823 maemo-specific API from cross-platform code.
2825 * src/modest-tny-account-store.c:
2826 (get_smtp_specific_transport_account_for_open_connection):
2827 * src/modest-ui-actions.c: (check_for_connection),
2828 (modest_ui_actions_on_item_not_found):
2829 Use modest_platform_connect_and_wait() and put #idefs around other
2830 maemo-specific code, because only maemo currently has a way to
2831 identify connection names.
2833 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2835 * src/modest-tny-account-store.h:
2836 * src/modest-tny-account-store.c:
2837 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2838 the connection-specific SMTP server settings in the configuration.
2840 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2842 * src/maemo/modest-main-window.c: (on_connection_changed),
2844 * src/modest-main.c: (main), (start_ui), (send_mail):
2845 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2846 that is what is intended.
2848 * src/modest-ui-actions.c: (action_send), (action_receive),
2849 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2850 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2851 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2852 SMTP server is used when it is specified.
2854 (modest_ui_actions_on_send_receive):
2855 Check that a connection is open before proceeding.
2856 Receive and then send, instead of vice-versa, as per the specification.
2858 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2860 * src/modest-mail-operation.c:
2861 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2862 though I guess it should be something other than NULL.
2864 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/easysetup/modest-easysetup-wizard.c:
2867 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2868 combo twice, to avoid an g_warning and to make it visible again.
2869 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2870 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2871 (already intended) dereference when detaching, because we then recreate the menu.
2872 But I am not sure why the warning was happening, and it is possible that this is a memory
2875 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2877 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2878 and uri_parse_mailto() utility functions.
2879 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2881 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2883 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2885 * src/dbus_api/modest-dbus-api.h:
2886 * src/dbus_api/modest-dbus-callbacks.c:
2887 Use an idle callback to execute the modest code in the application's own thread.
2888 Remove the helloworld example method.
2889 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2890 parsed, and the open-message method is not implemented because this is not yet implemented in
2892 * libmodest-dbus-client/libmodest-dbus-client.c:
2893 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2894 (libmodest_dbus_client_open_message):
2895 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2897 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2898 body without crashing.
2900 * tests/dbus_api/Makefile.am:
2901 * tests/dbus_api/test_mail_to.c:
2902 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2904 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2906 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2907 Added file to fix the build. Sorry.
2909 * src/dbus_api/Makefile.am:
2910 * src/dbus_api/modest-dbus-api.h:
2911 * src/dbus_api/modest-dbus-callbacks.h:
2912 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2913 (modest_dbus_req_handler):
2914 Put constants in a separate header so it can be reused by the
2915 client library, without duplication
2917 * libmodest-dbus-client/Makefile.am:
2918 * libmodest-dbus-client/libmodest-dbus-client.c:
2919 (libmodest_dbus_client_call_helloworld),
2920 (libmodfest_dbus_client_send_mail),
2921 (libmodfest_dbus_client_mailto),
2922 (libmodfest_dbus_client_open_message):
2923 * libmodest-dbus-client/libmodest-dbus-client.h:
2924 (Partly) Implement a send_mail D-Bus method.
2926 * tests/dbus_api/Makefile.am:
2927 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2928 the send_email D-Bus method.
2930 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2934 * libmodest-dbus-client/Makefile.am:
2935 * libmodest-dbus-client/libmodest-dbus-client.c:
2936 * libmodest-dbus-client/libmodest-dbus-client.h:
2937 * tests/dbus_api/Makefile.am:
2938 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2939 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2941 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2943 * src/maemo/easysetup/modest-easysetup-wizard.c:
2944 (create_page_account_details):
2945 * src/maemo/modest-account-settings-dialog.c:
2946 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2947 widgets, because this might not be the default in future versions of the Maemo GTK+.
2948 However, I can not not get capitalization to work even in a simple test case.
2950 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/easysetup/modest-easysetup-wizard.c:
2953 (create_page_custom_incoming), (create_page_custom_outgoing):
2954 * src/maemo/modest-account-settings-dialog.c:
2955 (create_page_account_details), (create_page_incoming),
2956 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2957 instead of using gtk_check_button_with_label(), so they are aligned like the other
2958 widgets, as per the UI spec.
2960 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2962 * src/maemo/easysetup/modest-easysetup-wizard.c:
2963 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2964 * src/widgets/modest-validating-entry.c:
2965 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2966 Modest prefix instead of an EasySetup prefix.
2968 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2970 * src/widgets/modest-validating-entry.h:
2971 * src/widgets/modest-validating-entry.c: (on_insert_text),
2972 Added easysetup_validating_entry_set_max_func(), used to set a callback
2973 to call when the max number of characters is reached. GtkEntry has a max-length
2974 already but is silent about it.
2976 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2977 (create_page_account_details), (create_page_user_details),
2979 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2980 (create_page_account_details), (create_page_user_details),
2981 (create_page_outgoing):
2982 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2983 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2984 the UI spec, when the user tries to enter more than the max number of characters.
2986 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2988 * src/maemo/easysetup/modest-easysetup-wizard.c:
2989 (create_page_user_details), (create_page_custom_incoming),
2990 (create_page_custom_outgoing):
2991 * src/maemo/modest-account-settings-dialog.c:
2992 (create_page_user_details), (create_page_incoming),
2993 (create_page_outgoing):
2994 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2995 (modest_connection_specific_smtp_edit_window_init):
2996 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2997 not appropriate. Bad Maemo-specific defaults!.
2999 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3002 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3003 (modest_signature_editor_dialog_set_settings):
3004 Disable the label and textview when the checkbox is disabled, and use the
3005 specified (UI spec) default signature text.
3007 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3009 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3010 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3012 * src/modest-defs.h:
3013 * src/modest-account-mgr-helpers.h:
3014 * src/modest-account-mgr-helpers.c:
3015 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3017 * src/maemo/Makefile.am:
3018 * src/maemo/modest-signature-editor-dialog.c:
3019 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3022 * src/maemo/modest-account-settings-dialog.h:
3023 * src/maemo/modest-account-settings-dialog.c:
3024 (modest_account_settings_dialog_finalize), (on_button_signature),
3025 (save_configuration): Use the new dialog when the Edit button is pressed, and
3026 save the changes if necessary, as per the UI spec.
3028 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3030 * src/maemo/Makefile.am:
3031 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3032 based on maemo-develoers email from Dirk.
3034 * src/maemo/easysetup/modest-easysetup-wizard.c:
3035 (create_page_welcome), (create_page_account_details),
3036 (create_page_user_details), (create_page_complete_easysetup),
3037 (create_page_custom_incoming), (create_page_custom_outgoing),
3038 (create_page_complete_custom),
3039 (modest_easysetup_wizard_dialog_init):
3040 * src/maemo/modest-account-settings-dialog.c:
3041 (create_page_account_details), (create_page_user_details),
3042 (create_page_incoming), (create_page_outgoing),
3043 (modest_account_settings_dialog_init):
3044 * src/maemo/modest-connection-specific-smtp-window.c:
3045 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3047 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3049 * src/maemo/easysetup/modest-easysetup-wizard.c:
3050 (create_page_account_details), (create_page_custom_outgoing),
3051 (create_page_complete_custom):
3052 * src/maemo/modest-account-settings-dialog.c:
3053 (create_page_user_details), (create_page_incoming),
3054 (create_page_outgoing):
3055 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3056 (modest_connection_specific_smtp_edit_window_init):
3057 Use the correct (UI spec) port min/max, and use horizontal separators,
3060 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3062 * src/maemo/easysetup/modest-easysetup-wizard.c:
3063 (set_default_custom_servernames):
3064 * src/maemo/modest-account-settings-dialog.c:
3065 (create_page_incoming), (on_combo_outgoing_security_changed),
3066 (on_combo_incoming_security_changed), (create_page_outgoing),
3067 (modest_account_settings_dialog_set_account_name),
3068 (save_configuration):
3069 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3070 (on_combo_security_changed),
3071 (modest_connection_specific_smtp_edit_window_init),
3072 (modest_connection_specific_smtp_edit_window_set_connection),
3073 (modest_connection_specific_smtp_edit_window_get_settings):
3074 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3077 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3080 * src/maemo/easysetup/modest-easysetup-wizard.c:
3081 (create_page_custom_outgoing), (create_page_complete_custom):
3082 * src/maemo/modest-account-settings-dialog.c:
3083 (create_page_user_details), (create_page_outgoing):
3084 * src/maemo/modest-account-view-window.c: (button_box_new):
3085 Use changed logical IDs as per the most recent UI spec:
3086 mcen_bd_emailsetup_edit -> mcen_bd_edit
3087 mcen_bd_emailsetup_delete -> mcen_bd_delete
3088 mcen_bd_emailsetup_close -> mcen_bd_close
3090 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3094 * src/dbus_api/Makefile.am:
3095 * src/dbus_api/modest-dbus-callbacks.c:
3096 * src/dbus_api/modest-dbus-callbacks.h:
3097 * src/maemo/modest-platform.c: (modest_platform_init):
3098 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3100 * tests/Makefile.am:
3101 * tests/dbus_api/Makefile.am:
3102 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3104 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3106 * src/maemo/modest-account-settings-dialog.c:
3107 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3108 Removed unnecessary includes.
3110 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3112 * src/maemo/easysetup/modest-easysetup-wizard.c:
3113 * src/maemo/modest-account-settings-dialog.c:
3114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3115 * src/widgets/Makefile.am:
3116 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3117 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3118 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3119 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3120 * src/widgets/modest-secureauth-combo-box.c:
3121 * src/widgets/modest-secureauth-combo-box.h:
3122 * src/widgets/modest-serversecurity-combo-box.c:
3123 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3124 made the GObject names more consistent with the rest of the Modest code.
3126 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3128 * src/maemo/easysetup/Makefile.am:
3129 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3130 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3131 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3132 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3133 * src/maemo/easysetup/modest-easysetup-wizard.c:
3134 * src/maemo/easysetup/modest-validating-entry.c:
3135 * src/maemo/easysetup/modest-validating-entry.h:
3136 * src/maemo/modest-account-settings-dialog.c:
3137 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3138 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3139 widgets/ because they are used outside of easysetup too. After checking in,
3140 svn will allow me to rename them too.
3142 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3144 * src/gnome/modest-msg-edit-window.c:
3145 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3146 linker error, to fix the build on the GNOME platform.
3147 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3148 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3149 ifdefed out to avoid a warning.
3151 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3153 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3154 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3155 some alternative for GTK+ 2.6.
3157 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3159 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3161 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3162 specified for EmailAccountsDialog in UI spec.
3164 * src/maemo/easysetup/modest-easysetup-wizard.c:
3165 * src/maemo/easysetup/modest-easysetup-wizard.h:
3166 * src/maemo/modest-account-settings-dialog.c:
3167 * src/maemo/modest-account-settings-dialog.h:
3168 Reuse a member window widget for the connection-specific SMTP server accounts,
3169 so we can tell it to create/save the accounts only if we actually save changes.
3171 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3172 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3173 (modest_connection_specific_smtp_edit_window_get_settings):
3174 Return a struct instance for temporarily remembering the entered data.
3176 * src/maemo/modest-connection-specific-smtp-window.h:
3177 * src/maemo/modest-connection-specific-smtp-window.c:
3178 (modest_connection_specific_smtp_window_finalize),
3179 (modest_connection_specific_smtp_window_fill_with_connections),
3181 (modest_connection_specific_smtp_window_save_server_accounts),
3182 (update_model_server_names): Do not actually save data until asked,
3183 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3185 (on_selection_changed),
3186 (modest_connection_specific_smtp_window_init): Disable the edit
3187 button when nothing is selected.
3189 * src/modest-account-mgr-helpers.c:
3190 * src/modest-account-mgr-helpers.h:
3191 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3194 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3196 * src/modest-account-mgr-helpers.h:
3197 * src/modest-account-mgr-helpers.c:
3198 (modest_account_mgr_get_unused_account_name),
3199 (modest_account_mgr_get_unused_account_display_name): Added these
3200 utility functions, to avoid code duplication.
3202 * src/maemo/easysetup/modest-easysetup-wizard.c:
3203 (create_page_account_details), (create_account):
3204 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3205 (on_combo_security_changed),
3206 (modest_connection_specific_smtp_edit_window_init),
3207 (modest_connection_specific_smtp_edit_window_save_settings):
3208 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3209 * src/maemo/modest-connection-specific-smtp-window.c:
3210 (modest_connection_specific_smtp_window_finalize),
3211 (modest_connection_specific_smtp_window_fill_with_connections),
3212 (on_button_edit), (modest_connection_specific_smtp_window_init):
3213 * src/maemo/modest-connection-specific-smtp-window.h:
3214 Implementing saving of connection-specific server accounts.
3216 But I need to refactor this so we can save the data for each
3217 possible connection-specific account and only actually create the server accounts
3218 when the easysetup finished, or the OK button is pressed on the account settings
3221 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3224 (on_combo_security_changed):
3225 (modest_connection_specific_smtp_edit_window_init):
3226 Auto-fill the port number as in the account settings.
3228 (modest_connection_specific_smtp_edit_window_set_connection):
3229 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3230 * src/maemo/modest-connection-specific-smtp-window.c:
3231 (fill_with_connections), (on_button_edit),
3232 (modest_connection_specific_smtp_window_init):
3233 Turn the edit window into a dialog to simplify the code, and
3234 set a WM hint as in a GtkDialog, because only a popup can be on top of
3235 another window in Maemo, and popups usually have no WM decoration.
3237 * src/modest-defs.h:
3238 * src/modest-account-mgr-helpers.c:
3239 (modest_account_mgr_set_connection_specific_smtp),
3240 (modest_account_mgr_remove_connection_specific_smtp),
3241 (modest_account_mgr_get_connection_specific_smtp):
3242 * src/modest-account-mgr-helpers.h: Some functions to write the
3243 connection-specific SMTP server information. Not yet used.
3246 * src/widgets/modest-folder-view.c: (text_cell_data):
3247 Fix a warning about an uninitialized variable.
3248 (on_configuration_key_changed): Put an #ifdef around the use
3249 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3251 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3253 * src/maemo/modest-account-settings-dialog.h:
3254 * src/maemo/modest-account-settings-dialog.c:
3255 Added connect_for_modified() utility function to mark the new modified boolean.
3257 (create_page_account_details), (create_page_user_details),
3258 (create_page_incoming), (create_page_outgoing), (on_response),
3259 (modest_account_settings_dialog_init),
3260 (modest_account_settings_dialog_set_account_name):
3261 Only warn about unsaved changes when there are actually unsaved changes.
3263 * src/modest-account-mgr-helpers.c:
3264 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3265 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3266 to get the data from there in future.
3268 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3270 * src/modest-defs.h:
3272 * src/modest-account-mgr-helpers.h:
3273 * src/modest-account-mgr-helpers.c:
3274 Store the security account setting in a single conf key instead of using
3275 the options list, so that the list is left for just the to-be-removed camel hack,
3276 and because gconf_client_set_list() is failing for some reason.
3278 * src/modest-account-mgr.c:
3279 (modest_account_mgr_add_server_account):
3280 * src/maemo/modest-account-settings-dialog.c:
3281 (modest_account_settings_dialog_set_account_name),
3282 (save_configuration): Use the renamed functions.
3285 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3287 * src/widgets/Makefile.am:
3288 * src/widgets/modest-limit-retrieve-combo-box.c:
3289 * src/widgets/modest-limit-retrieve-combo-box.h:
3290 * src/widgets/modest-retrieve-combo-box.c:
3291 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3292 the account settings dialog.
3294 * src/modest-defs.h:
3295 * src/modest-account-mgr-helpers.h:
3296 * src/modest-account-mgr-helpers.c:
3297 (modest_server_account_get_option_secure_auth),
3298 (modest_server_account_set_option_secure_auth):
3299 * src/modest-account-mgr.c:
3300 (modest_account_mgr_add_server_account):
3301 Use the existing AUTH_MECH conf key for the secure-auth setting,
3302 instead of putting it in the list options, because this was actually used already.
3304 * src/maemo/modest-account-settings-dialog.c:
3305 (create_page_account_details),
3306 (modest_account_settings_dialog_set_account_name),
3307 (save_configuration):
3308 * src/maemo/modest-account-settings-dialog.h:
3309 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3310 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3312 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3314 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3315 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3316 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3318 * src/modest-defs.h:
3319 * src/maemo/modest-account-settings-dialog.c:
3320 (create_page_incoming), (on_combo_outgoing_security_changed),
3321 (on_combo_incoming_security_changed), (create_page_outgoing),
3322 (modest_account_settings_dialog_set_account_name),
3323 (save_configuration): Load/Save the port number, and change it when the
3324 security combo changes, to suitable defaults.
3326 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3328 * src/modest-account-mgr.c:
3329 (modest_account_mgr_add_server_account): Set the security and secure-auth
3330 options, and add a comment saying that the other camel-specific options should be
3333 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3335 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3337 * src/modest-tny-account-store.c: (account_list_free),
3338 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3339 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3342 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3344 * src/modest-protocol-info.c:
3345 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3346 is required by our UI spec. Maybe something in our implementation will use this eventually.
3347 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3348 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3349 instead of the previous 0 placeholder.
3351 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3352 secure-auth settings.
3353 * src/modest-account-mgr-helpers.h:
3354 * src/modest-account-mgr-helpers.c:
3355 (modest_server_account_data_get_option_secure_auth),
3356 (modest_server_account_set_option_secure_auth),
3357 (modest_server_account_data_get_option_security),
3358 (modest_server_account_set_option_security): Added this API for getting and setting the security
3359 and secure-auth settings.
3361 * src/maemo/modest-account-settings-dialog.h:
3362 * src/maemo/modest-account-settings-dialog.c:
3363 (modest_account_settings_dialog_finalize), (check_data),
3364 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3365 about changing titles.
3366 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3367 (save_configuration): Save the security and secure-auth settings.
3369 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3370 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3372 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3374 * src/modest-defs.h:
3375 * src/modest-account-mgr.c:
3376 (modest_account_mgr_add_server_account):
3377 Added and used defines for the options key and value pair strings,
3378 that are used so far, though they do not seem to correspond to anything in our
3379 UI specs or ModestProtocol enum.
3381 * src/modest-account-mgr-helpers.h:
3382 * src/modest-account-mgr-helpers.c:
3383 (compare_option_strings_for_name),
3384 (modest_server_account_data_get_option_value),
3385 (modest_server_account_data_get_option_bool),
3386 (modest_account_mgr_get_server_account_option):
3387 Added helper functions for parsing the options GSList.
3389 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3391 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3392 display name is based on the supplied account name.
3393 * src/modest-account-mgr.c:
3394 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3395 with an inefficient, but good-enough, implementation.
3397 * src/maemo/easysetup/modest-easysetup-wizard.c:
3398 (create_page_account_details), (on_before_next), (create_account):
3399 Check for existing display names rather than (non-user-visible) account names, and just
3400 create and set a unique account name at the end.
3402 * src/maemo/modest-account-settings-dialog.c:
3403 (modest_account_settings_dialog_init),
3404 (modest_account_settings_dialog_set_account_name),
3405 (create_page_incoming): Show the display name, instead of the account name.
3406 (on_response): Do some (not all) extra checks, as in the UI spec.
3407 (save_configuration): Save the display name if it was changed.
3409 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3411 * po/en_GB.po: Added needed logical ID and translation.
3412 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3413 (init_view): Made the is-default column clicking work.
3415 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3418 * src/maemo/easysetup/Makefile.am:
3419 * src/maemo/easysetup/modest-easysetup-wizard.c:
3420 (modest_easysetup_wizard_dialog_init):
3421 * src/maemo/easysetup/provider-data-test.keyfile:
3422 * src/maemo/easysetup/provider-data.keyfile:
3423 Moved the provider data file to the new modest-providers-data package and used it from there.
3425 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3427 * src/modest-local-folder-info.c:
3428 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3429 N_() was already used on the static strings, but this just marks it for translation without
3430 using the translation.
3432 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/modest-account-settings-dialog.c:
3435 (create_page_incoming),
3436 (modest_account_settings_dialog_set_account_name):
3437 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3438 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3439 I will do this if nobody else gets there first.
3441 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3443 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3444 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3445 save the security stuff.
3447 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3449 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3450 Set the email address and user fullname, which I now see must be
3453 * src/maemo/modest-account-settings-dialog.h:
3454 * src/maemo/modest-account-settings-dialog.c:
3456 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3457 leave-on-server and authentication.
3458 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3461 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3464 * src/maemo/modest-account-settings-dialog.c:
3465 * src/maemo/modest-account-settings-dialog.h:
3466 Most (but not all) of the widgets are now present as specified by the UI spec.
3467 No changes are yet saved, and some details are not properly shown yet.
3469 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3471 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3473 * src/maemo/Makefile.am:
3474 * src/maemo/modest-account-settings-dialog.c:
3475 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3476 an existing account. Doesn't do much yet.
3478 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3479 Open the accounts settings dialog when Edit is clicked.
3481 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3483 * src/maemo/easysetup/Makefile.am:
3484 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3486 * src/maemo/easysetup/modest-easysetup-wizard.c:
3487 (modest_easysetup_wizard_dialog_init):
3488 Try to get the source directory from the build system,
3489 instead of hard-coding "./" into the source code, when opening our local
3490 copies of the configuration files.
3491 But this still fails when opening the wizard from the Accounts window,
3492 maybe because the working directory seems to change at runtime.
3493 So the wizard will fail the second time unless you copy the files into their
3494 proper locations - see the stdout warnings for the paths.
3496 (create_page_account_details),(on_before_next):
3497 Check for existing non-server accounts instead of server accounts,
3498 so the default account name is useful again, and to prevent trying to
3501 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3502 Show the wizard when New is clicked.
3504 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3505 (init_view): Show the column headers, and show the columns that are
3506 specified in the UI specs. However, something in Maemo's GTK+ prevents
3507 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3508 change the default account. This is despite unsetting the special properties.
3510 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3512 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3513 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3514 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3515 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3516 to make that clearer.
3517 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3519 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3521 * src/maemo/modest-account-view-window.c:
3522 (modest_account_view_window_init),
3523 (modest_account_view_window_new):
3524 Use the same buttons as specified in the
3525 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3526 the existing widgets, which never had a chance of working.
3527 Put the ModestAccountView treeview in a scrolled window.
3528 Do not repeat the initialization in both _init() and _new().
3530 * src/widgets/modest-account-view.c: (update_account_view):
3531 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3532 this widget and window shows no accounts.
3534 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3536 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3538 * src/maemo/easysetup/modest-easysetup-wizard.c:
3539 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3540 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3541 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3544 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3545 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3546 accounts exist yet, as in the UI spec.
3548 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3550 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3552 * src/maemo/Makefile.am:
3553 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3554 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3555 New window for editing connection-specific smtp details.
3556 Not fully implemented.
3558 * src/maemo/modest-connection-specific-smtp-window.c:
3559 (modest_connection_specific_smtp_window_finalize) :
3560 unref the tree model.
3561 (on_button_edit): Show the edit window.
3563 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3565 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3568 * src/maemo/Makefile.am:
3569 * src/maemo/modest-connection-specific-smtp-window.c:
3570 * src/maemo/modest-connection-specific-smtp-window.h:
3571 New window for showing the list of connections, for connection-specific
3572 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3573 * src/maemo/easysetup/modest-easysetup-wizard.c:
3574 (create_page_custom_outgoing): Show the new window when the button is clicked.
3576 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3578 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3579 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3580 * src/maemo/modest-msg-edit-window.c:
3581 (modest_msg_edit_window_insert_image):
3582 * src/modest-conf.c: (modest_conf_key_escape):
3583 * src/modest-mail-operation.c:
3584 (modest_mail_operation_send_new_mail):
3585 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3586 (modest_ui_actions_on_new_account):
3587 * src/widgets/modest-attachment-view.c: (update_filename_request):
3588 * src/widgets/modest-mail-header-view.c:
3589 Corrected warnings that were breaking the build, by commenting out unused variables,
3590 and a function, and by including a header.
3592 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3594 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3595 so we can #ifdef around platform-specific code when necessary.
3596 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3597 to allow this to build for the GNOME platform too.
3599 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3601 * src/maemo/easysetup/modest-easysetup-wizard.c:
3602 Added util_increment_name() and used it in create_page_account_details()
3603 to make sure that the default account name is always a new name.
3605 (modest_easysetup_wizard_dialog_init),
3606 (set_default_custom_servernames): Some minor memory management fixes.
3608 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3612 * src/modest-runtime.c: (init_i18n): Restored the translation
3613 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3614 are defined in config.h, and the translations are installed.
3616 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3617 is defined for translation.
3619 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3621 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3623 * src/maemo/easysetup/modest-easysetup-wizard.c:
3624 (modest_easysetup_wizard_dialog_init):
3625 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3626 Use realistic paths (though they should use $prefix generically) to the
3627 mcc_mapping and provider-data.keyfile files which might work when they
3628 are installed by the future version of the operator-wizard package,
3629 and then fallback to paths in our source code, with an explanatory
3632 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3636 * src/maemo/Makefile.am:
3637 * src/maemo/easysetup/: Added files from the previously-exernal
3638 osso-modest-easysetup.
3639 * src/maemo/modest-main-window-ui.h:
3640 * src/modest-ui-actions.c:
3641 * src/modest-ui-actions.h:
3642 Added modest_ui_actions_on_new_account() as a signal handler for the
3643 New Account menu item. It shows the easysetup wizard.
3644 * po/en_GB.po: Added additional needed logical IDs and translations.