1 2007-05-23 Christian Kellner <ckellner@openismus.com>
3 * src/modest-mail-operation.c:
4 (modest_mail_operation_update_account):
5 Use info->max_size instead of unintialized local var [small
6 build fix]. (Added TODO to review that change since I don't
9 2007-05-23 Marcus Bauer <marcusb@openismus.com>
11 * libmodest-dbus-client/libmodest-dbus-client.c:
12 (libmodest_dbus_client_compose_mail): function added
13 * src/dbus_api/modest-dbus-api.h:
14 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
15 (on_compose_mail): Implementation of the SendAsMail functionality
17 2007-05-22 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-account-mgr.c:
20 (modest_account_mgr_add_server_account): Set the secure-connection
21 conf key for transport accounts as well as store accounts. I don't know
22 why the if was there. For instance, this makes sure that we use SSL
23 for the gmail preset from the easysetup wizard.
25 2007-05-22 Murray Cumming <murrayc@murrayc.com>
27 * src/gnome/modest-main-window.c:
28 (on_account_store_connecting_finished), (connect_signals):
29 * src/maemo/modest-main-window.c:
30 (on_account_store_connecting_finished), (connect_signals),
31 (modest_main_window_new):
32 Handle TnyAccountStore::connecting-finished instead of
33 TnyDevice::connection-changed, because we cannot actually perform
34 operations on accounts until TnyAccountStore has itself responded to
35 the TnyDevice::connection-changed signal. This prevents a GError from
37 Do not try to update at startup, because we (at least on scratchbox)
38 already do an update at startup when the device goes online.
39 This prevents a GError from tinymail.
40 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
41 Added TODO about stopping simultaneous operations.
43 2007-05-21 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
46 * src/modest-mail-operation-queue.c:
47 (modest_mail_operation_queue_remove):
48 * src/modest-tny-account-store.c: When GErrors happen, give more clues
49 about where they happened.
51 2007-05-21 Murray Cumming <murrayc@murrayc.com>
53 * src/modest-ui-actions.c:
54 (modest_ui_actions_on_password_requested): Make sure that the remember
55 output parameter is always TRUE.
57 2007-05-21 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
60 Show a OK/Cancel dialog if the error is a question, though we still do not
61 know anything more about what we are asking the user.
62 * src/widgets/modest-folder-view.c: (on_drag_data_received):
63 Fix an uninitialized variable (helper). This is a logic error, however.
65 2007-05-21 Christian Kellner <ckellner@openismus.com>
67 * src/modest-search.h:
68 Correct bit shifting in the ModestSearchFlags enum.
70 2007-05-21 Murray Cumming <murrayc@murrayc.com>
72 * src/modest-tny-account.c:
73 (modest_tny_account_new_from_server_account): Do not use the lsub and
74 check-all hard-coded IMAP options when using POP.
76 2007-05-21 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-tny-account.c:
79 (modest_tny_account_new_from_server_account):
80 Use NULL for the secure-auth method for POP when Password auth has been
81 specified by the user, as we already do for IMAP. "auth=Login" causes
82 an error from camel or the server.
84 2007-05-17 Murray Cumming <murrayc@murrayc.com>
86 * src/maemo/modest-account-settings-dialog.c:
87 (create_page_account_details),
88 (modest_account_settings_dialog_set_account_name):
89 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
90 for the leave-on-server checkbox, rathr than just the checkbox, when
91 the protocol is not POP.
93 2007-05-17 Murray Cumming <murrayc@murrayc.com>
95 * src/widgets/modest-account-view.c:
96 * src/widgets/modest-account-view.h:
97 Added modest_account_view_select_account() which will be useful later
98 to asynchronously re-select the edited account.
100 2007-05-17 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-account-settings-dialog.c:
103 (modest_account_settings_dialog_set_account_name):
104 Automatically choose the port numbers based on the secure authentication
105 methods, if they have not been chosen before.
106 This fixes projects.maemo.org bug NB#56273 .
108 2007-05-17 Murray Cumming <murrayc@murrayc.com>
110 * src/maemo/modest-main-window-ui.h:
111 * src/modest-ui-actions.c:
112 * src/modest-ui-actions.h:
113 Connect the Tools/SMTP Servers menu item to
114 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
115 SMTP servers dialog, as in the UI specification and saves changes when it
116 is closed. This fixed projects.maemo.org bug NB#56305 .
118 2007-05-17 Murray Cumming <murrayc@murrayc.com>
120 * src/maemo/modest-connection-specific-smtp-window.c:
121 (modest_connection_specific_smtp_window_init):
122 Use gtk_window_set_default_size() to make this window big enough, so
123 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
125 2007-05-17 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/modest-connection-specific-smtp-edit-window.h:
128 * src/maemo/modest-connection-specific-smtp-edit-window.c:
129 (modest_connection_specific_smtp_edit_window_init),
130 Do not try to connect to a combobox signal before the combobox exists.
131 This fixes the cras in projects.maemo.org bug NB#56288 .
132 (modest_connection_specific_smtp_edit_window_get_settings):
133 Remove the server_account_name parameter which was being checked for NULL
134 though it was not used.
136 * src/maemo/modest-connection-specific-smtp-window.c:
137 (modest_connection_specific_smtp_window_fill_with_connections),
138 (on_button_edit), (modest_connection_specific_smtp_window_init):
139 Correct the number of treemodel columns to prevent a warning.
140 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
141 libconic does not work.
143 2007-05-16 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-tny-account.c:
146 (modest_tny_account_new_from_server_account):
147 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
148 SMTP when "None" was chosen by the user. However, with my SMTP server that
149 does not support ANONYMOUS, the emails do not leave the Outbox and I see
152 2007-05-16 Murray Cumming <murrayc@murrayc.com>
154 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
155 to explain the memory management issue with the ID in the ModestPair.
157 * src/gnome/modest-account-assistant.c: (add_receiving_page),
158 (add_sending_page), (modest_account_assistant_finalize):
159 * src/gnome/modest-gnome-global-settings-dialog.c:
160 (create_updating_page), (create_composing_page):
161 * src/gnome/modest-msg-edit-window.c: (get_transports),
162 (init_window), (modest_msg_edit_window_finalize),
163 (modest_msg_edit_window_get_msg_data):
164 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
165 * src/gnome/modest-transport-widget.c:
166 (modest_transport_widget_finalize), (smtp_configuration):
167 * src/maemo/modest-maemo-global-settings-dialog.c:
168 (create_updating_page), (create_composing_page):
169 * src/maemo/modest-msg-edit-window.c: (get_transports),
170 (init_window), (modest_msg_edit_window_finalize),
171 (modest_msg_edit_window_get_msg_data),
172 (modest_msg_edit_window_free_msg_data):
173 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
174 (modest_store_widget_finalize):
175 * src/maemo/modest-transport-widget.c:
176 (modest_transport_widget_finalize), (smtp_configuration):
177 * src/modest-main.c: (send_mail):
178 * src/widgets/modest-combo-box.h:
179 * src/widgets/modest-global-settings-dialog-priv.h:
180 * src/widgets/modest-global-settings-dialog.c:
181 (modest_global_settings_dialog_finalize):
182 * src/widgets/modest-msg-edit-window.h:
183 Whenever using modest_combo_box_new(), keep the ModestPairList alive
184 as long as the combo box, to prevent use of freed memory for the ID.
186 2007-05-15 Murray Cumming <murrayc@murrayc.com>
188 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
189 get_accounts(), to make this clearer. Do not check for the enabled gconf
190 key, because we do not use this for server accounts (at least, not yet).
191 This allows us to send email again.
193 2007-05-15 Murray Cumming <murrayc@murrayc.com>
195 * src/maemo/modest-platform.c:
196 (on_modest_conf_update_interval_changed), (modest_platform_init):
197 Only respond to this particular key change. All these strcmp()s cannot be
200 2007-05-15 Murray Cumming <murrayc@murrayc.com>
202 * src/maemo/modest-maemo-global-settings-dialog.c:
203 (current_connection): Prevent a crash in scratchbox when
204 ny_maemo_conic_device_get_current_iap_id() returns NULL.
205 * src/maemo/modest-platform.c:
206 (on_modest_conf_update_interval_changed), (modest_platform_init):
207 Get the update interval from gconf and reset it when the gconf key changes.
209 2007-05-15 Murray Cumming <murrayc@murrayc.com>
211 * src/modest-protocol-info.c:
212 * src/modest-protocol-info.h: Adde enum-specific get functions,
213 instead of using a ModestProtocolType enum parameter.
215 * src/gnome/modest-account-assistant.c:
216 * src/gnome/modest-store-widget.c:
217 * src/gnome/modest-store-widget.h:
218 * src/gnome/modest-transport-widget.c:
219 * src/gnome/modest-transport-widget.h:
220 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
221 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
222 * src/maemo/easysetup/modest-easysetup-wizard.c:
223 * src/maemo/modest-account-settings-dialog.c:
224 * src/maemo/modest-account-settings-dialog.h:
225 * src/maemo/modest-store-widget.c:
226 * src/maemo/modest-store-widget.h:
227 * src/maemo/modest-transport-widget.c:
228 * src/maemo/modest-transport-widget.h:
229 * src/modest-account-mgr-helpers.c:
230 * src/modest-account-mgr-helpers.h:
231 * src/modest-account-mgr.c:
232 * src/modest-account-mgr.h:
233 * src/modest-tny-account.c:
234 * src/modest-tny-folder.c:
235 * src/widgets/modest-account-view.c:
236 * src/widgets/modest-retrieve-combo-box.c:
237 * src/widgets/modest-retrieve-combo-box.h:
238 * src/widgets/modest-secureauth-combo-box.c:
239 * src/widgets/modest-serversecurity-combo-box.c:
240 * src/widgets/modest-serversecurity-combo-box.h:
241 * tests/check_account-mgr.c:
242 Use the specific functions, and use the re-renamed enum values for GNOME too.
244 2007-05-15 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
248 so we can get the second based on the first.
250 * src/maemo/modest-account-settings-dialog.h:
251 * src/maemo/modest-account-settings-dialog.c:
252 Added get_supported_secure_authentication_methods(), though it is mostly
253 commented-out for now until the necessary API is committed to tinymail.
254 (modest_account_settings_dialog_set_account_name),
255 (save_configuration): Request the supported authentication methods from the
256 server, so we can choose a working method.
258 * src/modest-tny-account-store.h:
259 * src/modest-tny-account-store.c:
260 (modest_tny_account_store_get_session): Rename from
261 tny_account_store_get_session().
263 2007-05-14 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-protocol-info.h: Split the ModestProtocol enum
266 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
267 There was no need to have these unrelated values in one enum.
269 * src/: many files: Adapted to changed enum. This makes the code a bit
270 clearer, and the compiler could catch some errors.
272 2007-05-14 Murray Cumming <murrayc@murrayc.com>
274 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
275 Show the detailed internal camel error message when an error happens
276 during the configuration, so that our testers can give us more clues.
277 For instance, in projects.maemo.org bug NB#56910 .
279 2007-05-14 Murray Cumming <murrayc@murrayc.com>
281 * src/modest-tny-account.c:
282 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
283 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
285 2007-05-14 Murray Cumming <murrayc@murrayc.com>
287 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
288 * src/maemo/modest-account-settings-dialog.c:
289 (modest_account_settings_dialog_set_account_name),
290 (save_configuration): For the incoming secure authentication checkbox,
291 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
292 the UI specification. PLAIN does not seem to be supported for most IMAP
293 servers anyway, and I am not sure what it would mean.
294 However, we probably need to discover which of the secure-authentication
295 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
296 * src/modest-account-mgr-helpers.c:
297 (modest_account_mgr_get_server_account_data):
299 * src/modest-tny-account.c:
300 (modest_tny_account_new_from_server_account):
301 Use tny_account_set_mech() to set secure-authentication methods,
302 with some special-casing for IMAP, based on my observations of how
305 * src/modest-account-mgr-helpers.h:
306 * src/modest-account-mgr.c:
307 * src/modest-defs.h: Comment that the URI is only used for local folders.
309 2007-05-11 Murray Cumming <murrayc@murrayc.com>
311 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
312 parameter const, just to be neat.
313 * src/modest-text-utils.c: (modest_text_utils_inline):
314 End g_strconcat() with NULL, as its documentation says. This is almost
315 certainly the cause of my crash at startup on the device. Interestingly,
316 valgrind doesn't tell us about these errors.
318 2007-05-11 Murray Cumming <murrayc@murrayc.com>
320 * scripts/build-packages: Added more precise comments about how to use
321 this script, though I still get this error:
322 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
323 error building tinymail
325 2007-05-11 Murray Cumming <murrayc@murrayc.com>
327 * src/maemo/modest-main-window.c: (on_account_update):
328 Very slight cleanup, hoping to make it simpler to discover what causes
329 a crash here sometimes.
331 * src/modest-tny-account.c:
332 (modest_tny_account_new_from_server_account): Set the port. Added
333 comments about the options and a TODO comment because I need to find out
334 how to specify the secure authentication method.
336 2007-05-11 Marcus Bauer <marcusb@openismus.com>
338 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
339 changed CFlags paths form modest to libmodest
341 2007-05-10 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-account-mgr-helpers.c:
344 (modest_account_mgr_get_server_account_data),
345 (modest_account_mgr_free_server_account_data):
346 * src/modest-account-mgr-helpers.h:
347 * src/modest-account-mgr.c:
348 (modest_account_mgr_add_server_account):
350 * src/modest-tny-account.c:
351 (modest_tny_account_new_from_server_account):
352 Determine the options for tny_camel_account_add_option() here,
353 based on the settings, rather than storing them directly in gconf.
355 2007-05-10 Murray Cumming <murrayc@murrayc.com>
357 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
358 Show a more friendly error dialog now that we expect (from the tinymail
359 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
361 2007-05-10 Murray Cumming <murrayc@murrayc.com>
363 * src/maemo/modest-main-window.c: (on_account_update): Check that
364 account_name is not NULL, to prevent a crash at startup that I am
365 seeing on the N800. I do wonder why it is NULL.
367 * src/maemo/easysetup/modest-easysetup-wizard.c:
368 (create_page_user_details):
369 * src/maemo/modest-account-settings-dialog.c:
370 (create_page_user_details), (create_page_outgoing):
371 * src/maemo/modest-connection-specific-smtp-edit-window.c:
372 (modest_connection_specific_smtp_edit_window_init):
373 * src/modest-ui-actions.c:
374 (modest_ui_actions_on_password_requested):
375 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
376 might do something useful with the on-screen keyboard.
378 2007-05-10 Murray Cumming <murrayc@murrayc.com>
380 * src/maemo/modest-main-window.c: (on_account_update):
381 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
382 NULL, to avoid lots of warnings. However, it probably should not be NULL.
384 2007-05-09 Murray Cumming <murrayc@murrayc.com>
386 * src/modest-tny-account-store.c: (on_account_changed):
387 Correct the signature of this signal handler.
389 2007-05-09 Murray Cumming <murrayc@murrayc.com>
391 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
392 Show a HildonNote instead of a GtkDialog for Maemo.
394 2007-05-09 Murray Cumming <murrayc@murrayc.com>
396 * src/widgets/modest-account-view.h:
397 * src/widgets/modest-account-view.c: (on_account_changed),
398 (on_account_removed). Added a boolean flag, set/unset by
399 modest_account_view_block_conf_updates(),
400 modest_account_view_unblock_conf_updates() to prevent unnecessary
401 updates, but this is not very useful because the gconf notifications are
402 so delays (maybe only on Maemo Bora).
403 So auto-updating is turned off, and these functions do an explicit
404 update when necessary.
405 However, something else is still doing too much work when adding/removing
406 accounts, probably in another part of the application.
408 * src/maemo/modest-account-view-window.c:
409 (on_delete_button_clicked), (on_edit_button_clicked),
410 (on_new_button_clicked): Use the new functions.
412 2007-05-09 Murray Cumming <murrayc@murrayc.com>
414 * src/modest-account-mgr-helpers.c:
415 (modest_account_mgr_set_first_account_as_default):
416 Sort the list of names alphabetically-by-title, so we choose the first one
418 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
419 alphabetically by the title.
421 This fixes projects.maemo.org bug NB#56418 .
423 * src/modest-account-mgr-priv.c:
424 (_modest_account_mgr_account_from_key):
425 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
426 avoid a valgrind error, and possible random behaviour.
428 2007-05-09 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
431 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
432 tinymail documentation to say that this can be expected.
433 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
434 pretty, and should not happen, but I would prefer to know when it does.
436 2007-05-09 Murray Cumming <murrayc@murrayc.com>
438 * configure.ac: When using the older hildon version, probably on Bora,
439 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
441 * src/widgets/modest-attachment-view.c:
442 (modest_attachment_view_set_part_default): Initialize variables, to fix the
445 2007-05-09 Marcus Bauer <marcusb@openismus.com>
447 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
448 Implemented the prototype. Can be tested with
449 tests/dbus_api/test_open_message:
451 2007-05-08 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-tny-account-store.c:
454 (modest_tny_account_store_instance_init), (get_password):
455 * src/modest-ui-actions.c:
456 (modest_ui_actions_on_password_requested):
457 Do not store the password in gconf, because this function is called
458 for non-remembered passwords. Actually use the cached (in the hash map)
459 password instead of releasing it.
460 The password will now not be remembered if it is asked via the protected
461 password dialog, as per the UI spec.
463 2007-05-08 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-account-mgr-helpers.h:
467 * src/modest-account-mgr-helpers.c:
468 Added modest_server_account_get_username_has_succeeded(),
469 modest_server_account_set_username_has_succeeded().
470 (modest_server_account_set_username),
471 Reset the has-succeeded flag if the username changes.
473 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
474 * src/maemo/modest-connection-specific-smtp-window.c:
475 (modest_connection_specific_smtp_window_save_server_accounts):
476 Use modest_server_account_set_username() instead of using
477 modest_conf_set_string() directly, so that the has-succeeded flag is always
480 * src/modest-ui-actions.c:
481 (modest_ui_actions_on_password_requested): Dim the username entry if
482 the username has ever worked, as per the UI spec.
484 2007-05-08 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-tny-account-store.c: (get_password):
487 * src/modest-ui-actions.c:
488 (modest_ui_actions_on_password_requested):
489 Allow the username to be changed too, though there is more work to
490 be done on exactly how this behaves.
492 2007-05-08 Murray Cumming <murrayc@murrayc.com>
494 * src/modest-account-mgr-helpers.h:
495 * src/modest-account-mgr-helpers.c:
496 Added modest_account_mgr_get_display_name(),
497 modest_server_account_get_username(),
498 modest_server_account_set_username(),
499 modest_server_account_set_password(),
500 modest_server_account_get_hostname() functions so we do not need to
501 use the conf API directly.
503 * src/maemo/modest-main-window.c: (connect_signals):
504 Actually connect ot the ModestAccountStore::request-password signal,
505 so that we show the dialog when the password is requested by Tinymail,
506 for isntance if it is empty.
508 * src/modest-marshal.list:
509 * src/modest-tny-account-store.c:
510 (modest_tny_account_store_class_init), (get_password),
511 (modest_tny_account_store_alert):
512 * src/modest-tny-account-store.h:
513 * src/modest-ui-actions.h:
514 * src/modest-ui-actions.c:
515 (modest_ui_actions_on_password_requested):
516 Change the signal parameters, so it is obvious that we are providing
517 the non human-readable server name, and receiving both the username
518 and password, though changing of the username is not yet implemented.
519 Change the dialog UI to match the Maemo UI specifications, with #idfefing
520 for the GNOME version.
522 This should fix the projects.maemo.org bug NB#56209, though it does not
523 work on Bora, because the gconf_client_get() for the password fails
524 immediately after we save it with gconf_client_set().
526 2007-05-08 Murray Cumming <murrayc@murrayc.com>
529 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
530 caused an undefined symbol error:
531 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
533 2007-05-08 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-tny-account-store.c:
536 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
537 using a GError instead of a string message, so we can translate it in
540 2007-05-08 Murray Cumming <murrayc@murrayc.com>
542 * src/maemo/modest-address-book.c:
543 (modest_address_book_check_names):
544 * src/maemo/modest-msg-view-window.c:
545 (modest_msg_view_window_clipboard_owner_change):
546 * src/modest-init.c: (modest_init_init_ui):
547 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
548 (update_folders_cb), (modest_mail_operation_update_account):
549 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
550 (modest_ui_actions_on_msg_attachment_clicked),
551 (modest_ui_actions_on_msg_recpt_activated):
552 * src/widgets/modest-header-view.c: (drag_data_get_cb):
553 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
554 (modest_msg_view_search_next):
555 * src/widgets/modest-recpt-editor.c:
556 (modest_recpt_editor_on_button_release_event),
557 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
558 g_message(). At this point we should only be seeing interesting errors on
559 stdout. Debugging messages could be #ifdefed-out if they are still useful.
561 2007-05-07 Murray Cumming <murrayc@murrayc.com>
563 (modest_wizard_dialog_force_title_update):
564 * src/maemo/easysetup/modest-wizard-dialog.h:
565 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
566 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
567 can update the title when appropriate. Otherwise the title is wrong if the
568 pages are added after adding the notebook to the dialog.
569 This must be a problem in HildonWizardDialog too.
570 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
572 * src/maemo/easysetup/modest-easysetup-wizard.c:
573 (create_subsequent_customsetup_pages),
574 (create_subsequent_easysetup_pages):
575 Call modest_wizard_dialog_force_title_update() so that the title is
576 correct even with GTK+ < 2.10.
577 This fixes projects.maemo.org bug NB#56145 .
579 2007-05-07 Murray Cumming <murrayc@murrayc.com>
581 * src/maemo/modest-platform.c:
582 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
583 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
586 2007-05-07 Murray Cumming <murrayc@murrayc.com>
588 * src/widgets/modest-window.h:
589 * src/widgets/modest-window.c: Added a save_state_func vfunc,
590 and modest_window_save_state(), which invokes it.
592 * src/widgets/modest-window-mgr.h:
593 * src/widgets/modest-window-mgr.c:
594 Added modest_window_mgr_save_state_for_all_windows(), which calls
595 the save_state vfunc on all registered windows, if implemented.
597 * src/gnome/modest-msg-edit-window.c:
598 * src/gnome/modest-msg-view-window.c:
599 * src/maemo/modest-msg-edit-window.c:
600 * src/maemo/modest-msg-view-window.c:
601 * src/maemo/modest-main-window.c:
602 Specify the existing save_settings functions as implementations of
603 ModestWindow::save_state_func().
605 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
606 Call modest_window_mgr_save_state_for_all_windows(). This happens before
607 enabling hibernation, for instance.
609 We may need to do the same thing for restoring settings.
612 2007-05-07 Murray Cumming <murrayc@murrayc.com>
614 * src/widgets/modest-window-mgr.c:
615 * src/widgets/modest-window-mgr.h:
616 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
617 modest_window_mgr_get_hibernation_is_prevented().
619 * src/maemo/modest-main-window.c:
620 (on_hildon_program_is_topmost_notify): Prevent hibernation
621 (possible when the application goes to the background in the WM),
622 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
624 * src/maemo/easysetup/modest-easysetup-wizard.c:
625 (modest_easysetup_wizard_dialog_init):
626 * src/maemo/modest-account-settings-dialog.c:
627 (modest_account_settings_dialog_init):
628 * src/maemo/modest-connection-specific-smtp-edit-window.c:
629 (modest_connection_specific_smtp_edit_window_init):
630 * src/maemo/modest-connection-specific-smtp-window.c:
631 (modest_connection_specific_smtp_window_init):
632 * src/maemo/modest-signature-editor-dialog.c:
633 (modest_signature_editor_dialog_init):
634 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
635 prevent hibernation while any of these account settings dialogs are open.
637 2007-05-04 Murray Cumming <murrayc@murrayc.com>
639 * src/maemo/Makefile.am:
640 * src/maemo/modest-osso-state-saving.c:
641 * src/maemo/modest-osso-state-saving.h: Added
642 modest_osso_load_state() and modest_osso_save_state() though they do
643 nothing now. They should iterate through all the open windows and load/save
645 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
646 save state when closing.
648 * src/maemo/modest-main-window.c:
649 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
650 Add a notification handler for the HildonProgram::is-topmost property,
651 so we can allow hibernation when the application goes into the background.
652 But we still need to detect when the accounts setup windows are open so
653 we can stop hibernation when they are open.
654 To do this, I also added the main window the HildonProgram. This might have
655 other side-effects/benefits, and should maybe be done for other windows.
657 * src/maemo/modest-osso-autosave-callbacks.h:
658 * src/maemo/modest-osso-autosave-callbacks.c:
659 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
660 though it does not do anything yet, and we might never need this to do
661 anything. For instance, we already save drafts.
663 * src/maemo/modest-platform.c: (modest_platform_init):
664 Specify the libosso auto-save callback.
666 2007-05-03 Murray Cumming <murrayc@murrayc.com>
668 * src/maemo/modest-platform.c:
669 (modest_platform_set_update_interval):
670 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
671 aparently stays valid between application instances, so we can use this
672 to remove and reset it later. According to a maemo-developers email from
675 2007-05-03 Murray Cumming <murrayc@murrayc.com>
677 * configure.ac: Depend on libalarm for Maemo.
679 * src/dbus_api/modest-dbus-api.h:
680 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
681 (on_send_receive), (modest_dbus_req_handler):
682 Handle a SEND_RECEIVE D-Bus method.
684 * libmodest-dbus-client/libmodest-dbus-client.c:
685 (libmodest_dbus_client_send_and_receive):
686 * libmodest-dbus-client/libmodest-dbus-client.h:
687 Add C convenience functions for calling the new D-Bus method.
689 * src/modest-platform.h:
690 * src/gnome/modest-platform.c:
691 * src/maemo/modest-platform.c:
692 Added modest_platform_set_update_interval(), which uses the
694 (modest_platform_init),
695 Call modest_platform_set_update_interval(), using a hard-coded
696 interval for now (until the global settings dialog is implemented),
697 though I am not sure that this makes sense yet.
699 2007-05-02 Murray Cumming <murrayc@murrayc.com>
701 * src/dbus_api/modest-dbus-callbacks.c:
702 (modest_osso_cb_hw_state_handler):
703 * src/dbus_api/modest-dbus-callbacks.h:
704 * src/maemo/modest-platform.c: (modest_platform_init):
705 Registered (empty) callbacks for the osso hardware state D-Bus signals,
706 in case this has some effect on the ability for Maemo to ping the
709 2007-05-02 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
712 Comment out an if() that checks a gchar for < 0, causing a build-breaking
713 warning. It is probably a logic error, but I need to fix the build.
715 2007-05-02 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-account-mgr.h:
718 * src/modest-account-mgr.c:
719 (modest_account_mgr_account_names): Add a gboolean enabled_only
720 parameter, so we can get lists of onlt the enabled accounts.
722 (modest_account_mgr_add_account),,
723 (modest_account_mgr_account_with_display_name_exists):
724 * src/maemo/modest-msg-edit-window.c: (get_transports):
725 * src/modest-account-mgr-helpers.c:
726 (modest_account_mgr_set_first_account_as_default):
727 * src/modest-init.c: (init_default_account_maybe):
728 * src/modest-tny-account-store.c: (get_accounts):
729 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
730 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
731 * tests/check_account-mgr.c: (START_TEST):
732 Provide the extra parameter, as appropriate.
734 * src/widgets/modest-account-view.c: (update_account_view):
735 Do not show disabled accounts (meaning that there is no way to
736 enable/disable accounts in the UI (the feature is not in our UI
737 specification), so we can use this internally only to mark unfinished
738 or temporary account data.
740 * src/maemo/easysetup/modest-easysetup-wizard.c:
741 (create_account): Add boolean enable parameter, so we can specify FALSE
742 to create the temporary account.
743 (on_button_edit_advanced_settings): Create the temporary account as disabled.
744 (on_before_next): When finishing, when there is a temporary account, just
746 Also, use a timeout to delay the showing of the dialog until gconf is likely
747 to return correct information, due to a maemo gconf bug that is fixed in
748 osso 1.1, but not yet in Bora.
749 However, the dialog stays on screen after it is destroyed.
751 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
752 for invalid data when cancelling. Use a hildon note instead of a dialog
753 to complain about invalid data. Do not show the account-saved note if the
754 account is disabled (a temporary account that will not really be saved for use
757 2007-04-30 Murray Cumming <murrayc@murrayc.com>
759 * src/modest-account-mgr-helpers.h:
760 * src/modest-account-mgr-helpers.c:
761 Added modest_account_mgr_unset_default_account(),
762 Added modest_account_mgr_set_first_account_as_default().
764 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
765 If it was the default account, unset the default account name.
767 * src/maemo/modest-account-view-window.c:
768 (on_delete_button_clicked): If it was the default account,
769 set the first remaining account as the default instead.
771 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
772 a NULL account or a NULL default account, to prevent a crash. This should
773 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
776 2007-04-30 Murray Cumming <murrayc@murrayc.com>
778 * src/widgets/modest-recpt-editor.c:
779 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
780 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
781 TODO comment for this. This fixes the build.
783 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
784 be the best place for it. This will in future update all auto-update accounts,
785 rather than just the current/default account, when that gconf key exists.
786 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
787 if there are no accounts, before calling do_send_receive().
788 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
790 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
791 * src/maemo/modest-main-window-ui.h:
792 * src/maemo/modest-main-window.c: (on_connection_changed),
793 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
794 directly, becaue the signal handler does more.
796 2007-04-30 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-account-mgr-helpers.c:
799 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
800 for the case that the account does not exist.
802 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
803 (equivalent to the modest account name) rather than the tinymail account name
804 (equivalent to the modest account title - human readable) to get the account data.
805 Check for null account data to prevent the crash, and add a TODO comment saying that
806 this needs fixing because it is using the server account name instead of the account name.
808 2007-04-29 Murray Cumming <murrayc@murrayc.com>
810 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
811 * src/maemo/modest-account-settings-dialog.c: (show_error),
813 Use hildon_note_new_information() for informative and error messages,
814 which seems to be expected for Maemo applications (no documentation that I know of
815 says this). I am surprised that there is no distinction between info and error
818 2007-04-29 Murray Cumming <murrayc@murrayc.com>
820 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
821 it is easy to find where this is used.
823 * src/maemo/easysetup/modest-easysetup-wizard.c:
824 (create_page_welcome), (create_page_account_details),
825 (create_page_user_details), (create_page_complete_easysetup),
826 (create_page_custom_incoming), (create_page_custom_outgoing),
827 (create_page_complete_custom):
828 * src/maemo/modest-account-settings-dialog.c:
829 (create_page_account_details), (create_page_user_details),
830 (create_page_incoming), (create_page_outgoing):
831 * src/maemo/modest-account-view-window.c: (window_vbox_new):
832 * src/maemo/modest-connection-specific-smtp-edit-window.c:
833 (modest_connection_specific_smtp_edit_window_init):
834 * src/maemo/modest-connection-specific-smtp-window.c:
835 (modest_connection_specific_smtp_window_init):
836 * src/maemo/modest-signature-editor-dialog.c:
837 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
838 and scrolling policy as per the Email Application Layout Guide, if I have
841 2007-04-27 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
844 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
845 which were empty, because these vfuncs have been removed from TnyAccountStore.
846 This fixes the build.
848 2007-04-27 Murray Cumming <murrayc@murrayc.com>
850 * src/maemo/modest-main-window.c:
851 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
852 showing/hiding it. Added TODO because it probably should not be NULL.
853 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
854 because unnecessary g_warnings() make degugging difficult.
856 2007-04-27 Murray Cumming <murrayc@murrayc.com>
858 * src/maemo/modest-msg-edit-window.c:
859 (modest_msg_edit_window_select_color),
860 (modest_msg_edit_window_select_background_color): 2 const corrections and
861 moving 2 #endifs before closing brackets, to fix the build.
863 2007-04-27 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/easysetup/modest-easysetup-wizard.h:
866 * src/maemo/easysetup/modest-easysetup-wizard.c:
867 (modest_easysetup_wizard_dialog_finalize),
868 (on_button_edit_advanced_settings), (create_page_complete_custom),
869 (on_response), (create_account):
870 Implement the Advanced Settings edit button, by saving the account information,
871 for the Advanded Settings dialog to use directly from gconf, and removing it
872 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
873 Bug #5533 in the projects.maemo.org bugzilla.
875 2007-04-27 Murray Cumming <murrayc@murrayc.com>
877 * src/maemo/modest-msg-view-window.c:
878 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
879 when opening a message window.
881 2007-04-27 Murray Cumming <murrayc@murrayc.com>
883 * src/maemo/easysetup/modest-easysetup-wizard.c:
884 (create_page_custom_outgoing): Correct the position of the horizontal separator to
887 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
888 before showing/hiding them, to avoid a crash when clicking on folders when there are no
889 gconf settings. I probably added more checks than necessary, but that is safer.
891 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
892 variable to fix the build, but this seems to be used when it is still NULL.
894 2007-04-27 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-platform.h:
897 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
898 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
899 * src/modest-main.c: Implement this function so we can avoid using
900 maemo-specific API from cross-platform code.
902 * src/modest-tny-account-store.c:
903 (get_smtp_specific_transport_account_for_open_connection):
904 * src/modest-ui-actions.c: (check_for_connection),
905 (modest_ui_actions_on_item_not_found):
906 Use modest_platform_connect_and_wait() and put #idefs around other
907 maemo-specific code, because only maemo currently has a way to
908 identify connection names.
910 2007-04-27 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-tny-account-store.h:
913 * src/modest-tny-account-store.c:
914 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
915 the connection-specific SMTP server settings in the configuration.
917 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
919 * src/maemo/modest-main-window.c: (on_connection_changed),
921 * src/modest-main.c: (main), (start_ui), (send_mail):
922 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
923 that is what is intended.
925 * src/modest-ui-actions.c: (action_send), (action_receive),
926 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
927 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
928 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
929 SMTP server is used when it is specified.
931 (modest_ui_actions_on_send_receive):
932 Check that a connection is open before proceeding.
933 Receive and then send, instead of vice-versa, as per the specification.
935 2007-04-26 Murray Cumming <murrayc@murrayc.com>
937 * src/modest-mail-operation.c:
938 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
939 though I guess it should be something other than NULL.
941 2007-04-26 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/easysetup/modest-easysetup-wizard.c:
944 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
945 combo twice, to avoid an g_warning and to make it visible again.
946 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
947 attached before detaching it, to avoid a g_warning, and add comment about the implicit
948 (already intended) dereference when detaching, because we then recreate the menu.
949 But I am not sure why the warning was happening, and it is possible that this is a memory
952 2007-04-25 Murray Cumming <murrayc@murrayc.com>
954 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
955 and uri_parse_mailto() utility functions.
956 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
958 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
960 2007-04-24 Murray Cumming <murrayc@murrayc.com>
962 * src/dbus_api/modest-dbus-api.h:
963 * src/dbus_api/modest-dbus-callbacks.c:
964 Use an idle callback to execute the modest code in the application's own thread.
965 Remove the helloworld example method.
966 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
967 parsed, and the open-message method is not implemented because this is not yet implemented in
969 * libmodest-dbus-client/libmodest-dbus-client.c:
970 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
971 (libmodest_dbus_client_open_message):
972 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
974 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
975 body without crashing.
977 * tests/dbus_api/Makefile.am:
978 * tests/dbus_api/test_mail_to.c:
979 * tests/dbus_api/test_open_message.c: New tests for the new methods.
981 2007-04-24 Murray Cumming <murrayc@murrayc.com>
983 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
984 Added file to fix the build. Sorry.
986 * src/dbus_api/Makefile.am:
987 * src/dbus_api/modest-dbus-api.h:
988 * src/dbus_api/modest-dbus-callbacks.h:
989 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
990 (modest_dbus_req_handler):
991 Put constants in a separate header so it can be reused by the
992 client library, without duplication
994 * libmodest-dbus-client/Makefile.am:
995 * libmodest-dbus-client/libmodest-dbus-client.c:
996 (libmodest_dbus_client_call_helloworld),
997 (libmodfest_dbus_client_send_mail),
998 (libmodfest_dbus_client_mailto),
999 (libmodfest_dbus_client_open_message):
1000 * libmodest-dbus-client/libmodest-dbus-client.h:
1001 (Partly) Implement a send_mail D-Bus method.
1003 * tests/dbus_api/Makefile.am:
1004 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1005 the send_email D-Bus method.
1007 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1011 * libmodest-dbus-client/Makefile.am:
1012 * libmodest-dbus-client/libmodest-dbus-client.c:
1013 * libmodest-dbus-client/libmodest-dbus-client.h:
1014 * tests/dbus_api/Makefile.am:
1015 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1016 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1018 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1020 * src/maemo/easysetup/modest-easysetup-wizard.c:
1021 (create_page_account_details):
1022 * src/maemo/modest-account-settings-dialog.c:
1023 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1024 widgets, because this might not be the default in future versions of the Maemo GTK+.
1025 However, I can not not get capitalization to work even in a simple test case.
1027 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1029 * src/maemo/easysetup/modest-easysetup-wizard.c:
1030 (create_page_custom_incoming), (create_page_custom_outgoing):
1031 * src/maemo/modest-account-settings-dialog.c:
1032 (create_page_account_details), (create_page_incoming),
1033 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1034 instead of using gtk_check_button_with_label(), so they are aligned like the other
1035 widgets, as per the UI spec.
1037 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1039 * src/maemo/easysetup/modest-easysetup-wizard.c:
1040 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1041 * src/widgets/modest-validating-entry.c:
1042 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1043 Modest prefix instead of an EasySetup prefix.
1045 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1047 * src/widgets/modest-validating-entry.h:
1048 * src/widgets/modest-validating-entry.c: (on_insert_text),
1049 Added easysetup_validating_entry_set_max_func(), used to set a callback
1050 to call when the max number of characters is reached. GtkEntry has a max-length
1051 already but is silent about it.
1053 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1054 (create_page_account_details), (create_page_user_details),
1056 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1057 (create_page_account_details), (create_page_user_details),
1058 (create_page_outgoing):
1059 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1060 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1061 the UI spec, when the user tries to enter more than the max number of characters.
1063 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1065 * src/maemo/easysetup/modest-easysetup-wizard.c:
1066 (create_page_user_details), (create_page_custom_incoming),
1067 (create_page_custom_outgoing):
1068 * src/maemo/modest-account-settings-dialog.c:
1069 (create_page_user_details), (create_page_incoming),
1070 (create_page_outgoing):
1071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1072 (modest_connection_specific_smtp_edit_window_init):
1073 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1074 not appropriate. Bad Maemo-specific defaults!.
1076 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1078 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1079 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1080 (modest_signature_editor_dialog_set_settings):
1081 Disable the label and textview when the checkbox is disabled, and use the
1082 specified (UI spec) default signature text.
1084 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1086 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1087 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1089 * src/modest-defs.h:
1090 * src/modest-account-mgr-helpers.h:
1091 * src/modest-account-mgr-helpers.c:
1092 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1094 * src/maemo/Makefile.am:
1095 * src/maemo/modest-signature-editor-dialog.c:
1096 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1099 * src/maemo/modest-account-settings-dialog.h:
1100 * src/maemo/modest-account-settings-dialog.c:
1101 (modest_account_settings_dialog_finalize), (on_button_signature),
1102 (save_configuration): Use the new dialog when the Edit button is pressed, and
1103 save the changes if necessary, as per the UI spec.
1105 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1107 * src/maemo/Makefile.am:
1108 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1109 based on maemo-develoers email from Dirk.
1111 * src/maemo/easysetup/modest-easysetup-wizard.c:
1112 (create_page_welcome), (create_page_account_details),
1113 (create_page_user_details), (create_page_complete_easysetup),
1114 (create_page_custom_incoming), (create_page_custom_outgoing),
1115 (create_page_complete_custom),
1116 (modest_easysetup_wizard_dialog_init):
1117 * src/maemo/modest-account-settings-dialog.c:
1118 (create_page_account_details), (create_page_user_details),
1119 (create_page_incoming), (create_page_outgoing),
1120 (modest_account_settings_dialog_init):
1121 * src/maemo/modest-connection-specific-smtp-window.c:
1122 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1124 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1126 * src/maemo/easysetup/modest-easysetup-wizard.c:
1127 (create_page_account_details), (create_page_custom_outgoing),
1128 (create_page_complete_custom):
1129 * src/maemo/modest-account-settings-dialog.c:
1130 (create_page_user_details), (create_page_incoming),
1131 (create_page_outgoing):
1132 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1133 (modest_connection_specific_smtp_edit_window_init):
1134 Use the correct (UI spec) port min/max, and use horizontal separators,
1137 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1139 * src/maemo/easysetup/modest-easysetup-wizard.c:
1140 (set_default_custom_servernames):
1141 * src/maemo/modest-account-settings-dialog.c:
1142 (create_page_incoming), (on_combo_outgoing_security_changed),
1143 (on_combo_incoming_security_changed), (create_page_outgoing),
1144 (modest_account_settings_dialog_set_account_name),
1145 (save_configuration):
1146 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1147 (on_combo_security_changed),
1148 (modest_connection_specific_smtp_edit_window_init),
1149 (modest_connection_specific_smtp_edit_window_set_connection),
1150 (modest_connection_specific_smtp_edit_window_get_settings):
1151 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1154 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1157 * src/maemo/easysetup/modest-easysetup-wizard.c:
1158 (create_page_custom_outgoing), (create_page_complete_custom):
1159 * src/maemo/modest-account-settings-dialog.c:
1160 (create_page_user_details), (create_page_outgoing):
1161 * src/maemo/modest-account-view-window.c: (button_box_new):
1162 Use changed logical IDs as per the most recent UI spec:
1163 mcen_bd_emailsetup_edit -> mcen_bd_edit
1164 mcen_bd_emailsetup_delete -> mcen_bd_delete
1165 mcen_bd_emailsetup_close -> mcen_bd_close
1167 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1171 * src/dbus_api/Makefile.am:
1172 * src/dbus_api/modest-dbus-callbacks.c:
1173 * src/dbus_api/modest-dbus-callbacks.h:
1174 * src/maemo/modest-platform.c: (modest_platform_init):
1175 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1177 * tests/Makefile.am:
1178 * tests/dbus_api/Makefile.am:
1179 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1181 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1183 * src/maemo/modest-account-settings-dialog.c:
1184 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1185 Removed unnecessary includes.
1187 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1189 * src/maemo/easysetup/modest-easysetup-wizard.c:
1190 * src/maemo/modest-account-settings-dialog.c:
1191 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1192 * src/widgets/Makefile.am:
1193 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1194 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1195 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1196 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1197 * src/widgets/modest-secureauth-combo-box.c:
1198 * src/widgets/modest-secureauth-combo-box.h:
1199 * src/widgets/modest-serversecurity-combo-box.c:
1200 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1201 made the GObject names more consistent with the rest of the Modest code.
1203 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1205 * src/maemo/easysetup/Makefile.am:
1206 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1207 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1208 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1209 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1210 * src/maemo/easysetup/modest-easysetup-wizard.c:
1211 * src/maemo/easysetup/modest-validating-entry.c:
1212 * src/maemo/easysetup/modest-validating-entry.h:
1213 * src/maemo/modest-account-settings-dialog.c:
1214 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1215 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1216 widgets/ because they are used outside of easysetup too. After checking in,
1217 svn will allow me to rename them too.
1219 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1221 * src/gnome/modest-msg-edit-window.c:
1222 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1223 linker error, to fix the build on the GNOME platform.
1224 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1225 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1226 ifdefed out to avoid a warning.
1228 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1230 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1231 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1232 some alternative for GTK+ 2.6.
1234 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1236 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1238 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1239 specified for EmailAccountsDialog in UI spec.
1241 * src/maemo/easysetup/modest-easysetup-wizard.c:
1242 * src/maemo/easysetup/modest-easysetup-wizard.h:
1243 * src/maemo/modest-account-settings-dialog.c:
1244 * src/maemo/modest-account-settings-dialog.h:
1245 Reuse a member window widget for the connection-specific SMTP server accounts,
1246 so we can tell it to create/save the accounts only if we actually save changes.
1248 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1249 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1250 (modest_connection_specific_smtp_edit_window_get_settings):
1251 Return a struct instance for temporarily remembering the entered data.
1253 * src/maemo/modest-connection-specific-smtp-window.h:
1254 * src/maemo/modest-connection-specific-smtp-window.c:
1255 (modest_connection_specific_smtp_window_finalize),
1256 (modest_connection_specific_smtp_window_fill_with_connections),
1258 (modest_connection_specific_smtp_window_save_server_accounts),
1259 (update_model_server_names): Do not actually save data until asked,
1260 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1262 (on_selection_changed),
1263 (modest_connection_specific_smtp_window_init): Disable the edit
1264 button when nothing is selected.
1266 * src/modest-account-mgr-helpers.c:
1267 * src/modest-account-mgr-helpers.h:
1268 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1271 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-account-mgr-helpers.h:
1274 * src/modest-account-mgr-helpers.c:
1275 (modest_account_mgr_get_unused_account_name),
1276 (modest_account_mgr_get_unused_account_display_name): Added these
1277 utility functions, to avoid code duplication.
1279 * src/maemo/easysetup/modest-easysetup-wizard.c:
1280 (create_page_account_details), (create_account):
1281 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1282 (on_combo_security_changed),
1283 (modest_connection_specific_smtp_edit_window_init),
1284 (modest_connection_specific_smtp_edit_window_save_settings):
1285 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1286 * src/maemo/modest-connection-specific-smtp-window.c:
1287 (modest_connection_specific_smtp_window_finalize),
1288 (modest_connection_specific_smtp_window_fill_with_connections),
1289 (on_button_edit), (modest_connection_specific_smtp_window_init):
1290 * src/maemo/modest-connection-specific-smtp-window.h:
1291 Implementing saving of connection-specific server accounts.
1293 But I need to refactor this so we can save the data for each
1294 possible connection-specific account and only actually create the server accounts
1295 when the easysetup finished, or the OK button is pressed on the account settings
1298 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1300 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1301 (on_combo_security_changed):
1302 (modest_connection_specific_smtp_edit_window_init):
1303 Auto-fill the port number as in the account settings.
1305 (modest_connection_specific_smtp_edit_window_set_connection):
1306 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1307 * src/maemo/modest-connection-specific-smtp-window.c:
1308 (fill_with_connections), (on_button_edit),
1309 (modest_connection_specific_smtp_window_init):
1310 Turn the edit window into a dialog to simplify the code, and
1311 set a WM hint as in a GtkDialog, because only a popup can be on top of
1312 another window in Maemo, and popups usually have no WM decoration.
1314 * src/modest-defs.h:
1315 * src/modest-account-mgr-helpers.c:
1316 (modest_account_mgr_set_connection_specific_smtp),
1317 (modest_account_mgr_remove_connection_specific_smtp),
1318 (modest_account_mgr_get_connection_specific_smtp):
1319 * src/modest-account-mgr-helpers.h: Some functions to write the
1320 connection-specific SMTP server information. Not yet used.
1323 * src/widgets/modest-folder-view.c: (text_cell_data):
1324 Fix a warning about an uninitialized variable.
1325 (on_configuration_key_changed): Put an #ifdef around the use
1326 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1328 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1330 * src/maemo/modest-account-settings-dialog.h:
1331 * src/maemo/modest-account-settings-dialog.c:
1332 Added connect_for_modified() utility function to mark the new modified boolean.
1334 (create_page_account_details), (create_page_user_details),
1335 (create_page_incoming), (create_page_outgoing), (on_response),
1336 (modest_account_settings_dialog_init),
1337 (modest_account_settings_dialog_set_account_name):
1338 Only warn about unsaved changes when there are actually unsaved changes.
1340 * src/modest-account-mgr-helpers.c:
1341 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1342 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1343 to get the data from there in future.
1345 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1347 * src/modest-defs.h:
1349 * src/modest-account-mgr-helpers.h:
1350 * src/modest-account-mgr-helpers.c:
1351 Store the security account setting in a single conf key instead of using
1352 the options list, so that the list is left for just the to-be-removed camel hack,
1353 and because gconf_client_set_list() is failing for some reason.
1355 * src/modest-account-mgr.c:
1356 (modest_account_mgr_add_server_account):
1357 * src/maemo/modest-account-settings-dialog.c:
1358 (modest_account_settings_dialog_set_account_name),
1359 (save_configuration): Use the renamed functions.
1362 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1364 * src/widgets/Makefile.am:
1365 * src/widgets/modest-limit-retrieve-combo-box.c:
1366 * src/widgets/modest-limit-retrieve-combo-box.h:
1367 * src/widgets/modest-retrieve-combo-box.c:
1368 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1369 the account settings dialog.
1371 * src/modest-defs.h:
1372 * src/modest-account-mgr-helpers.h:
1373 * src/modest-account-mgr-helpers.c:
1374 (modest_server_account_get_option_secure_auth),
1375 (modest_server_account_set_option_secure_auth):
1376 * src/modest-account-mgr.c:
1377 (modest_account_mgr_add_server_account):
1378 Use the existing AUTH_MECH conf key for the secure-auth setting,
1379 instead of putting it in the list options, because this was actually used already.
1381 * src/maemo/modest-account-settings-dialog.c:
1382 (create_page_account_details),
1383 (modest_account_settings_dialog_set_account_name),
1384 (save_configuration):
1385 * src/maemo/modest-account-settings-dialog.h:
1386 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1387 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1389 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1391 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1392 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1393 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1395 * src/modest-defs.h:
1396 * src/maemo/modest-account-settings-dialog.c:
1397 (create_page_incoming), (on_combo_outgoing_security_changed),
1398 (on_combo_incoming_security_changed), (create_page_outgoing),
1399 (modest_account_settings_dialog_set_account_name),
1400 (save_configuration): Load/Save the port number, and change it when the
1401 security combo changes, to suitable defaults.
1403 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1405 * src/modest-account-mgr.c:
1406 (modest_account_mgr_add_server_account): Set the security and secure-auth
1407 options, and add a comment saying that the other camel-specific options should be
1410 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1412 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1414 * src/modest-tny-account-store.c: (account_list_free),
1415 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1416 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1419 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-protocol-info.c:
1422 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1423 is required by our UI spec. Maybe something in our implementation will use this eventually.
1424 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1425 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1426 instead of the previous 0 placeholder.
1428 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1429 secure-auth settings.
1430 * src/modest-account-mgr-helpers.h:
1431 * src/modest-account-mgr-helpers.c:
1432 (modest_server_account_data_get_option_secure_auth),
1433 (modest_server_account_set_option_secure_auth),
1434 (modest_server_account_data_get_option_security),
1435 (modest_server_account_set_option_security): Added this API for getting and setting the security
1436 and secure-auth settings.
1438 * src/maemo/modest-account-settings-dialog.h:
1439 * src/maemo/modest-account-settings-dialog.c:
1440 (modest_account_settings_dialog_finalize), (check_data),
1441 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1442 about changing titles.
1443 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1444 (save_configuration): Save the security and secure-auth settings.
1446 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1447 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1449 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1451 * src/modest-defs.h:
1452 * src/modest-account-mgr.c:
1453 (modest_account_mgr_add_server_account):
1454 Added and used defines for the options key and value pair strings,
1455 that are used so far, though they do not seem to correspond to anything in our
1456 UI specs or ModestProtocol enum.
1458 * src/modest-account-mgr-helpers.h:
1459 * src/modest-account-mgr-helpers.c:
1460 (compare_option_strings_for_name),
1461 (modest_server_account_data_get_option_value),
1462 (modest_server_account_data_get_option_bool),
1463 (modest_account_mgr_get_server_account_option):
1464 Added helper functions for parsing the options GSList.
1466 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1468 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1469 display name is based on the supplied account name.
1470 * src/modest-account-mgr.c:
1471 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1472 with an inefficient, but good-enough, implementation.
1474 * src/maemo/easysetup/modest-easysetup-wizard.c:
1475 (create_page_account_details), (on_before_next), (create_account):
1476 Check for existing display names rather than (non-user-visible) account names, and just
1477 create and set a unique account name at the end.
1479 * src/maemo/modest-account-settings-dialog.c:
1480 (modest_account_settings_dialog_init),
1481 (modest_account_settings_dialog_set_account_name),
1482 (create_page_incoming): Show the display name, instead of the account name.
1483 (on_response): Do some (not all) extra checks, as in the UI spec.
1484 (save_configuration): Save the display name if it was changed.
1486 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1488 * po/en_GB.po: Added needed logical ID and translation.
1489 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1490 (init_view): Made the is-default column clicking work.
1492 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1495 * src/maemo/easysetup/Makefile.am:
1496 * src/maemo/easysetup/modest-easysetup-wizard.c:
1497 (modest_easysetup_wizard_dialog_init):
1498 * src/maemo/easysetup/provider-data-test.keyfile:
1499 * src/maemo/easysetup/provider-data.keyfile:
1500 Moved the provider data file to the new modest-providers-data package and used it from there.
1502 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1504 * src/modest-local-folder-info.c:
1505 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1506 N_() was already used on the static strings, but this just marks it for translation without
1507 using the translation.
1509 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1511 * src/maemo/modest-account-settings-dialog.c:
1512 (create_page_incoming),
1513 (modest_account_settings_dialog_set_account_name):
1514 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1515 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1516 I will do this if nobody else gets there first.
1518 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1520 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1521 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1522 save the security stuff.
1524 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1527 Set the email address and user fullname, which I now see must be
1530 * src/maemo/modest-account-settings-dialog.h:
1531 * src/maemo/modest-account-settings-dialog.c:
1533 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1534 leave-on-server and authentication.
1535 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1538 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1541 * src/maemo/modest-account-settings-dialog.c:
1542 * src/maemo/modest-account-settings-dialog.h:
1543 Most (but not all) of the widgets are now present as specified by the UI spec.
1544 No changes are yet saved, and some details are not properly shown yet.
1546 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1548 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/Makefile.am:
1551 * src/maemo/modest-account-settings-dialog.c:
1552 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1553 an existing account. Doesn't do much yet.
1555 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1556 Open the accounts settings dialog when Edit is clicked.
1558 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1560 * src/maemo/easysetup/Makefile.am:
1561 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1563 * src/maemo/easysetup/modest-easysetup-wizard.c:
1564 (modest_easysetup_wizard_dialog_init):
1565 Try to get the source directory from the build system,
1566 instead of hard-coding "./" into the source code, when opening our local
1567 copies of the configuration files.
1568 But this still fails when opening the wizard from the Accounts window,
1569 maybe because the working directory seems to change at runtime.
1570 So the wizard will fail the second time unless you copy the files into their
1571 proper locations - see the stdout warnings for the paths.
1573 (create_page_account_details),(on_before_next):
1574 Check for existing non-server accounts instead of server accounts,
1575 so the default account name is useful again, and to prevent trying to
1578 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1579 Show the wizard when New is clicked.
1581 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1582 (init_view): Show the column headers, and show the columns that are
1583 specified in the UI specs. However, something in Maemo's GTK+ prevents
1584 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1585 change the default account. This is despite unsetting the special properties.
1587 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1589 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1590 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1591 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1592 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1593 to make that clearer.
1594 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1596 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/modest-account-view-window.c:
1599 (modest_account_view_window_init),
1600 (modest_account_view_window_new):
1601 Use the same buttons as specified in the
1602 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1603 the existing widgets, which never had a chance of working.
1604 Put the ModestAccountView treeview in a scrolled window.
1605 Do not repeat the initialization in both _init() and _new().
1607 * src/widgets/modest-account-view.c: (update_account_view):
1608 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1609 this widget and window shows no accounts.
1611 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1613 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1615 * src/maemo/easysetup/modest-easysetup-wizard.c:
1616 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1617 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1618 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1621 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1622 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1623 accounts exist yet, as in the UI spec.
1625 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1627 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1629 * src/maemo/Makefile.am:
1630 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1631 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1632 New window for editing connection-specific smtp details.
1633 Not fully implemented.
1635 * src/maemo/modest-connection-specific-smtp-window.c:
1636 (modest_connection_specific_smtp_window_finalize) :
1637 unref the tree model.
1638 (on_button_edit): Show the edit window.
1640 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1642 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1645 * src/maemo/Makefile.am:
1646 * src/maemo/modest-connection-specific-smtp-window.c:
1647 * src/maemo/modest-connection-specific-smtp-window.h:
1648 New window for showing the list of connections, for connection-specific
1649 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1650 * src/maemo/easysetup/modest-easysetup-wizard.c:
1651 (create_page_custom_outgoing): Show the new window when the button is clicked.
1653 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1655 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1656 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1657 * src/maemo/modest-msg-edit-window.c:
1658 (modest_msg_edit_window_insert_image):
1659 * src/modest-conf.c: (modest_conf_key_escape):
1660 * src/modest-mail-operation.c:
1661 (modest_mail_operation_send_new_mail):
1662 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1663 (modest_ui_actions_on_new_account):
1664 * src/widgets/modest-attachment-view.c: (update_filename_request):
1665 * src/widgets/modest-mail-header-view.c:
1666 Corrected warnings that were breaking the build, by commenting out unused variables,
1667 and a function, and by including a header.
1669 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1671 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1672 so we can #ifdef around platform-specific code when necessary.
1673 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1674 to allow this to build for the GNOME platform too.
1676 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1678 * src/maemo/easysetup/modest-easysetup-wizard.c:
1679 Added util_increment_name() and used it in create_page_account_details()
1680 to make sure that the default account name is always a new name.
1682 (modest_easysetup_wizard_dialog_init),
1683 (set_default_custom_servernames): Some minor memory management fixes.
1685 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1689 * src/modest-runtime.c: (init_i18n): Restored the translation
1690 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1691 are defined in config.h, and the translations are installed.
1693 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1694 is defined for translation.
1696 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1698 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1700 * src/maemo/easysetup/modest-easysetup-wizard.c:
1701 (modest_easysetup_wizard_dialog_init):
1702 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1703 Use realistic paths (though they should use $prefix generically) to the
1704 mcc_mapping and provider-data.keyfile files which might work when they
1705 are installed by the future version of the operator-wizard package,
1706 and then fallback to paths in our source code, with an explanatory
1709 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/Makefile.am:
1714 * src/maemo/easysetup/: Added files from the previously-exernal
1715 osso-modest-easysetup.
1716 * src/maemo/modest-main-window-ui.h:
1717 * src/modest-ui-actions.c:
1718 * src/modest-ui-actions.h:
1719 Added modest_ui_actions_on_new_account() as a signal handler for the
1720 New Account menu item. It shows the easysetup wizard.
1721 * po/en_GB.po: Added additional needed logical IDs and translations.
1723 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1724 Apparently ChangeLog is not used for some vague Nokia legal reasons.