1 2007-08-28 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-search.c: (on_timeout_check_account_is_online):
4 Added some debug output to help me debug a problem on the N800.
5 (check_and_wait_for_account_is_online): Fail immediately if the
7 modest_search_all_accounts(): Try the search even if the account does
8 not seem to be online, because this can work sometimes, and should work
9 with the cache if there is no active libconic connection.
11 2007-08-27 Armin Burgmeier <armin@openismus.com>
13 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
14 observe outbox for added messages to assign them a status. Previously,
15 this was done in modest_tny_send_queue_add(), but the message id might
16 not yet be known at that point. This reduces warnings when sending
17 mail, though I am not sure how this even worked before.
19 2007-08-27 Murray Cumming <murrayc@murrayc.com>
21 * src/maemo/modest-account-settings-dialog.c:
22 (modest_account_settings_dialog_init):
23 * src/maemo/modest-connection-specific-smtp-edit-window.c:
24 (modest_connection_specific_smtp_edit_window_init):
25 * src/maemo/modest-connection-specific-smtp-window.c:
26 (modest_connection_specific_smtp_window_init):
27 * src/maemo/modest-maemo-utils.c:
28 (modest_maemo_utils_get_supported_secure_authentication_methods):
29 * src/maemo/modest-platform.c:
30 (modest_platform_run_folder_name_dialog):
31 * src/maemo/modest-signature-editor-dialog.c:
32 (modest_signature_editor_dialog_init):
33 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
34 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
35 * src/widgets/modest-global-settings-dialog.c:
36 (modest_global_settings_dialog_init):
37 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
39 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
40 GTK_STOCK_EDIT with mcen_bd_edit, and
41 GTK_STOCK_CLOSE with mcen_bd_close,
42 to fix projects.maemo.org bug NB#64995.
43 I strongly believe that Maemo's GTK+ should have the wanted translations
44 instead of duplicating this in each application and complicating the code.
46 2007-08-27 Armin Burgmeier <armin@openismus.com>
48 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
49 recursion when entering text in the subject field.
51 2007-08-27 Murray Cumming <murrayc@murrayc.com>
53 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
54 which checks every second, 10 times, to wait until the account is online
55 so that we can use it, if the account is in the process of going online.
56 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
57 so that searching works even when the application was not yet started before.
58 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
60 2007-08-24 Armin Burgmeier <armin@openismus.com>
62 * src/modest-widget-memory.c: Always show the default account when the
63 application is started, as stated in the UI spec. This fixes
64 projects.maemo.org bug NB#66630.
66 2007-08-24 Armin Burgmeier <armin@openismus.com>
68 * src/maemo/modest-platform.c:
69 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
70 english text for strings in the rename folder dialog, fixing
71 projects.maemo.org bug NB#66338.
73 2007-08-22 Armin Burgmeier <armin@openismus.com>
75 * src/widgets/modest-account-view.c: Fix for bora by using
76 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
77 latter seems not be used anymore.
79 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
82 * src/maemo/modest-main-window.c: Update menu items when the default
83 account changes so that the current default account is always bolded.
84 This fixes maemo.projects.org bug NB#66173.
86 2007-08-17 Murray Cumming <murrayc@murrayc.com>
88 * src/dbus_api/modest-dbus-callbacks.c:
89 (on_dbus_method_get_folders): Avoid trying to get the account name
90 when there are no accounts, to avoid critical g_warnings, fixing
91 projects.maemo.org bug NB#65574.
93 2007-08-17 Murray Cumming <murrayc@murrayc.com>
95 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
96 Use modest_account_mgr_get_signature() instead of accessing gconf
97 directly, to slightly simplify the code.
98 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
99 Append the signature also when opening via other applications,
100 fixing projects.maemo.org bug NB#65828.
102 2007-08-17 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
105 Check for NULLs to prevent a crash when opening an email that is
106 an attachment in another email, fixing projects.maemo.org bug
109 2007-08-17 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-ui-dimming-rules.c:
112 (modest_ui_dimming_rules_on_view_window_move_to):
113 Enable the Move To toolbar button for search results, fixing the
114 last part of projects.maemo.org bug NB#63807.
116 2007-08-17 Murray Cumming <murrayc@murrayc.com>
118 * src/dbus_api/modest-dbus-callbacks.c:
119 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
120 because this is called from idle handlers, to fix hangs afte the
122 (find_message_by_url): Added a TODO comment about a crash that
123 happens when tinymail was built with DBC checks.
125 2007-08-16 Murray Cumming <murrayc@murrayc.com>
127 * src/modest-search.c: (modest_search_folder):
128 * src/modest-search.h: Rename ModestSearch::before to start_date
129 and after to end_date, using the same names as the libogs struct
131 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
132 The start_date and end_date were swapped in the check. This
133 fixes date range searches, fixing projects.maemo.org bug NB#63407.
135 2007-08-16 Murray Cumming <murrayc@murrayc.com>
137 * src/maemo/modest-account-view-window.c:
138 Added (check_for_active_acount).
139 (on_delete_button_clicked), (on_edit_button_clicked):
140 When an account is doing something (such as refreshing),
141 show the same warning for account deletion as for account
142 editing, to fix projects.maemo.org bug NB#64588.
144 2007-08-16 Murray Cumming <murrayc@murrayc.com>
146 * src/widgets/modest-msg-view-window.h:
147 * src/gnome/modest-msg-view-window.c:
148 * src/maemo/modest-msg-view-window.c:
149 Added modest_msg_view_window_construct().
150 (modest_msg_view_window_new_with_header_model),
151 Added modest_msg_view_window_new_for_search_result),
152 Renamed modest_msg_view_window_new() to
153 modest_msg_view_window_new_for_attachment(),
154 and modest_msg_view_window_is_search_result(),
155 so we can explicitly know that the window is for an
156 attachment or a search result or a message from the list.
158 (modest_msg_view_window_view_attachment):
159 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
160 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
161 Use modest_msg_view_window_new_for_search_result().
163 * src/modest-ui-dimming-rules.c:
164 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
165 for search results, fixing projects.maemo.org bug NB#63811.
167 2007-08-16 Armin Burgmeier <armin@openismus.com>
169 * src/modest-ui-actions.c: Show a banner instead of a dialog when
170 renaming a folder fails, to stay consistent with what happens when
171 creating a folder fails.
173 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
174 slightly country loading from the mmc_mappings file, fixed a memory
177 2007-08-16 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-tny-account-store.c: (volume_path_is_mounted):
180 Check the GnomeVFSVolume activation path instead of the device path,
181 so that the memory card is really really shown in the UI.
183 2007-08-16 Murray Cumming <murrayc@murrayc.com>
185 * src/maemo/easysetup/modest-easysetup-wizard.c:
186 (get_entered_account_title), (on_before_next), (entry_is_empty),
188 * src/maemo/modest-account-settings-dialog.c:
189 (get_entered_account_title), (on_button_signature), (check_data),
190 (save_configuration), (entry_is_empty):
191 Strip the account title of whitespace at the start and end before
192 using it or checking it. This means that an all-whitespace title
193 is not allowed, fixing projects.maemo.org bug NB#64977.
195 2007-08-15 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-ui-actions.h:
198 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
199 to modest_run_account_setup_wizard() and made it public.
200 * src/dbus_api/modest-dbus-callbacks.c:
201 (check_and_offer_account_creation), (on_idle_mail_to),
202 (on_idle_compose_mail), (on_idle_open_default_inbox):
203 Offer account creation if necessary, fixing projects.maemo.org
206 2007-08-15 Murray Cumming <murrayc@murrayc.com>
208 * src/modest-ui-actions.c: (run_account_setup_wizard):
209 Return a gboolean to indicate success.
210 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
211 (modest_ui_actions_on_send): When offering account creation, only
212 give up (return) if account creation failed. Otherwise continue
213 with the original request. This fixed projects.maemo.org bug
216 2007-08-15 Murray Cumming <murrayc@murrayc.com>
218 * src/widgets/modest-recpt-editor.c:
219 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
220 to fix projects.maemo.org bug NB#63789.
222 2007-08-15 Murray Cumming <murrayc@murrayc.com>
224 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
225 (modest_tny_account_store_new): Properly detect the memory card at
226 startup, and add an account for it.
228 2007-08-14 Murray Cumming <murrayc@murrayc.com>
230 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
231 Commented out the MMC code again because it mistakenly detects
232 the card even when it isn't inserted.
234 2007-08-14 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
237 Renabled the call to add_mmc_account() because I do not believe
238 it could be the cause of the mentioned hang (in scratchbox, where
239 there is no memory card), and because I have tested that it works
242 2007-08-14 Murray Cumming <murrayc@murrayc.com>
244 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
245 Comment out part of the last commit because it apparently causes
248 2007-08-14 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-tny-account-store.c: Added the add_mmc_account()
251 function to save some copy/pasting.
252 (modest_tny_account_store_new): If the memory card is mounted,
253 create an account for it at the start, instead of waiting for the
254 user to unmount it and mount it.
256 2007-08-13 Murray Cumming <murrayc@murrayc.com>
258 * src/widgets/modest-account-view.c: (on_account_changed):
259 Do not try to use the human-readable TnyAccount name instead of the
260 ID of the modest account to get the transport account. And unref
261 the transport account. This prevents a g_warning(), and a possible
264 2007-08-13 Murray Cumming <murrayc@murrayc.com>
266 * src/maemo/modest-platform.c:
267 (modest_platform_set_update_interval): Handle the new
268 alarmd error to warn when alarmd is not running, as is the case in
269 scratchbox for me now because
270 "Module /usr/lib/alarmd/libretu.so initialization failed"
272 2007-08-13 Murray Cumming <murrayc@murrayc.com>
274 * src/widgets/modest-header-view-render.c:
275 (_modest_header_view_compact_header_cell_data):
276 NULL some strings after freeing them, trying to deal with
277 the double deletion found in projects.maemo.org bug 64183,
278 probably having no effect.
280 2007-08-13 Murray Cumming <murrayc@murrayc.com>
282 * src/maemo/modest-account-settings-dialog.c:
283 (create_page_incoming), (create_page_outgoing): Use a define
284 for the min and max port numbers.
286 (check_hildon_number_editor_and_warn_value_not_in_range),
287 (check_data): Do an extra check for an invalid port number, as needed
288 in projects.maemo.org bug #64275, when the number is cleared, but this
289 does not work due to bugs.maemo.org bug #1806.
291 2007-08-13 Murray Cumming <murrayc@murrayc.com>
293 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
294 Comment out the debug warning about the unexpected D-Bus methods.
295 They are just annoying now.
296 * src/maemo/modest-platform.c:
297 (modest_platform_set_update_interval): Correct the D-Bus path, instead
298 of using a file path, though it did not seem to break things before.
299 It might be needed now:
300 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
301 modest is not already running. This is the behaviour of the old client, and
302 Mox says it is what we should do for modest.
303 This closes projects.maemo.org bug NB#64327.
305 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
307 * src/modest-text-utils.c:
308 Fixed invalid jump due to incorrect string/pointer
310 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
313 2007-08-01 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-account-mgr-helpers.h:
316 * src/modest-account-mgr-helpers.c:
317 Added modest_account_mgr_get_first_account_name(),
318 using code from modest_account_mgr_set_first_account_as_default().
320 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
321 (account_number_changed): Call set_at_least_one_account_visible() so that
322 the first account is visible when first added, without the user having to
324 I do wonder how this worked before.
326 2007-08-01 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-tny-account-store.c: (show_password_warning_only),
329 (show_wrong_password), (request_password_and_wait), (get_password),
330 (modest_tny_account_store_alert): Remove the (incomplete anyway)
331 attempts to show UI only in the main context, which used g_idle_add()
332 and mainloops, because tinymail now guarantees that it only calls these
333 callbacks in the mainloop with the gdk lock. This makes everything much
336 2007-08-01 Murray Cumming <murrayc@murrayc.com>
338 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
339 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
340 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
341 error dialog, instead of ignoring it.
343 2007-08-01 Murray Cumming <murrayc@murrayc.com>
345 * src/maemo/modest-msg-view-window.c:
346 (modest_msg_view_window_get_header),
347 (modest_msg_view_window_last_message_selected):
348 Added comments to explain the use of priv->header_model.
349 * src/modest-ui-dimming-rules.c:
350 (modest_ui_dimming_rules_on_open_msg),
351 (modest_ui_dimming_rules_on_mark_as_read_msg),
352 (modest_ui_dimming_rules_on_mark_as_unread_msg),
353 (modest_ui_dimming_rules_on_remove_attachments),
354 (_invalid_attach_selected), (_selected_msg_marked_as):
355 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
356 and changed the parameter to a ModestMainWindow to make it clearer that
357 it never uses any other kind of window.
358 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
359 instead of the selected message.
360 I notice that much of the dimming code and the ModestMsgViewWindow code
361 hard-codes the assumption that the viewed message is always selected in
362 the header view. This does not seem wise or simple.
364 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
365 examine the actual message instead of whatever might be selected
366 in the header view. This stops the delete toolbar button and menu item
367 from being dimmed when opening a message view the search UI,
368 partially fixing projects.maemo.org bug NB#63811.
370 However, when actually deleting, I now get this warning:
371 "tny_header_set_flags: This is a header instance for a new message.
372 Only priority and attachment flags are supported"
374 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
376 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
378 Show account wizard if no accounts are defined while sending
379 (automatic sending after the account wizard finished does not
380 work because it takes some time until the account manager
381 synchronizes everything. (projects.maemo.org NB#62792)
383 2007-07-30 Murray Cumming <murrayc@murrayc.com>
385 * src/modest-tny-account-store.c: (on_account_removed),
386 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
387 account is removed from the View menu. We have TnyAccountStore
388 and ModestTnyAccountStore signals that seem very similar, but this
389 seems to work for now.
391 * src/maemo/modest-main-window.c:
392 (on_show_account_action_activated): Prevent dereference
393 of a NULL if the accoutn does not really exist, though that
394 should not happen anymore.
396 This fixes projects.maemo.org bug NB#64606.
398 2007-07-30 Murray Cumming <murrayc@murrayc.com>
400 * src/modest-ui-actions.c: (run_account_setup_wizard),
401 (modest_ui_actions_on_accounts): Revert a change that set these
402 to modal dialogs, freezing the UI when they show secondary dialogs.
403 This fixed projects.maemo.org bug NB#64519.
405 2007-07-27 Murray Cumming <murrayc@murrayc.com>
407 * src/widgets/modest-header-view-render.c:
408 (_modest_header_view_compact_header_cell_data):
409 Some checks and initialization to try to deal with a crash,
410 probably ineffective.
412 2007-07-27 Murray Cumming <murrayc@murrayc.com>
414 * src/maemo/modest-maemo-utils.c:
415 (modest_maemo_utils_get_supported_secure_authentication_methods):
416 Make sure that we have a connection, asking the user for one
418 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
419 Check for a connection before showing the wizard, because
420 the wizard needs a connection to check for server capabilities.
422 2007-07-27 Murray Cumming <murrayc@murrayc.com>
424 * src/maemo/modest-account-view-window.c:
425 (on_new_button_clicked): Remember the wizard dialog instance,
426 so we can just present it again if necessary. This prevents
427 multiple windows from appearing if you click again quickly on the
428 New button before the dialog appears, fixing projects.maemo.org
431 2007-07-27 Murray Cumming <murrayc@murrayc.com>
433 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
434 Offer a connection dialog if there is no connection when
435 starting modest. This should fix projects.maemo.org bug NB#61134.
437 2007-07-27 Murray Cumming <murrayc@murrayc.com>
439 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
440 Reverted my last commit. I was able to fix the build by doing
441 apt-get install wpeditor0 (replacing other wpeditor packages) and
442 an explicit apt-get install wpeditor-dev to upgrade the -dev
445 2007-07-27 Murray Cumming <murrayc@murrayc.com>
447 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
448 Commented out the use of wp_text_buffer_replace_image()
449 because it does not exist, to break the build. Added a TODO for it.
451 2007-07-26 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-tny-account-store.c: (recreate_all_accounts):
454 Recreate them even if they were NULL before. I guess something
455 else was already creating them before, or this would never
457 (modest_tny_account_store_get_server_account): Make sure that
458 the tny accounts have been created before trying to find one.
459 This allows libmodest_dbus_client_compose_mail() to work
460 when the UI is not yet visible.
461 This is probably useful in other cases too.
463 (get_password): When the password is wrong after it is entered
464 in the protected password dialog, show an info banner (in an
465 idle handler) before showing the protected password dialog
468 2007-07-26 Murray Cumming <murrayc@murrayc.com>
470 * src/modest-ui-actions.h:
471 * src/modest-ui-actions.c: Added
472 modest_do_refresh_current_folder() containing some code from
473 modest_ui_actions_on_send_receive().
474 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
475 Call modest_do_refresh_current_folder() before refreshing the
476 requested account, as in modest_ui_actions_on_send_receive().
477 This is strange, but seems to be necessary to show new mails.
478 Now new emails are finally visible in the UI when downloaded
479 via the automatic update interval, fixing bug NB#57458.
480 This also works because bug NB#57458 has been fixed somehow.
482 2007-07-26 Murray Cumming <murrayc@murrayc.com>
484 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
485 printf more details when we get unhandled D-Bus methods, because
488 * src/modest-mail-operation.c: (update_account_thread):
489 Comment out the tny_camel_pop_store_account_reconnect(), because this
490 is apparently no longer needed, and it did not work before anyway.
491 See the comment in the code.
493 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
494 by checking the header flags. This fixes projects.maemo.org bug
497 2007-07-25 Murray Cumming <murrayc@murrayc.com>
499 * src/maemo/modest-maemo-utils.h:
500 * src/maemo/modest-maemo-utils.c: Added
501 modest_maemo_show_information_note_in_main_context_and_forget().
502 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
503 Use the new function to show simple error dialogs in the main
504 context, though question dialogs are still in the current context,
505 which is unfortunately usually not the main context. This should
508 2007-07-25 Murray Cumming <murrayc@murrayc.com>
510 * src/modest-tny-account-store.c: (get_password):
511 Never save the entered username and password in gconf,
512 because the UI spec says we should not. This helps
513 slightly with projects.maemo.org bug NB#63671.
515 2007-07-25 Murray Cumming <murrayc@murrayc.com>
517 * src/widgets/modest-msg-edit-window.h:
518 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
519 Moved some code here to make it simpler.
520 (modest_msg_edit_window_attach_file_one): Renamed from
521 modest_msg_edit_window_attach_file_interactive().
522 (modest_msg_edit_window_offer_attach_file): Renamed from
523 modest_msg_edit_window_attach_file() and used
524 modest_msg_edit_window_attach_file_one() instead of
525 copy/pasting the code. The old code for one was not using
526 GnomeVFS. This allows use of smb:// URLs when using send-as
527 from external applications, fixing bug NB#63741.
529 (modest_msg_edit_window_insert_image),
530 (modest_msg_edit_window_add_attachment_clicked):
531 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
532 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
533 Adapted to the new function names.
535 2007-07-25 Murray Cumming <murrayc@murrayc.com>
537 (modest_platform_set_update_interval): Set the alarm recurrence
538 fields so that auto-update does not just happen the first time.
539 This should have fixed projects.maemo.org bug NB#63938.
541 When this happens you can see a printf when the D-Bus method is
543 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
545 However, I do not actually seem to get new POP messages even when
546 clicking the refresh button manually. A restart gets them.
547 This might be a problem in today's tinymail only.
549 2007-07-24 Murray Cumming <murrayc@murrayc.com>
551 * src/maemo/modest-maemo-global-settings-dialog.c:
552 (current_connection):
553 Avoid a crash (probably only in scratchbox) when strcmp()ing a
554 NULL when closing the dialog.
556 2007-07-24 Murray Cumming <murrayc@murrayc.com>
558 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
559 Remove the hacky send/receive that didn't work, and instead
560 refilter the treemodel to make the deleted email really vanish from
561 the UI (though the delete-from-menu code does has commented out
562 the code that does that). This fixes projects.maemo.org bug
565 2007-07-24 Murray Cumming <murrayc@murrayc.com>
567 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
568 Try a couple of tricks to force the treeview to update (
569 poke the folder, and do a send/receive refresh), but the deleted
570 email still appears with a strike-through instead of really being
573 2007-07-23 Murray Cumming <murrayc@murrayc.com>
575 * src/dbus_api/modest-dbus-callbacks.c:
576 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
577 because their ID is not human-readable (see the comment about
578 improvements needed to the osso-email-interface API) and
579 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
581 2007-07-23 Murray Cumming <murrayc@murrayc.com>
583 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
584 (add_folders_to_list), (on_dbus_method_get_folders),
585 (modest_dbus_req_filter):
586 * src/maemo/modest-maemo-utils.c:
587 (on_camel_account_get_supported_secure_authentication):
588 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
589 (on_header_view_focus_in):
590 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
591 * src/modest-formatter.c: (modest_formatter_create_body_part):
592 * src/modest-mail-operation.c: (recurse_folders),
593 (update_account_thread), (get_msgs_full_thread),
594 (modest_mail_operation_get_msgs_full),
595 (modest_mail_operation_xfer_msgs):
596 * src/modest-search.c: (search_mime_part_and_child_parts),
597 (modest_search_account), (modest_search_all_accounts):
598 * src/modest-tny-account.c:
599 (modest_tny_account_get_special_folder), (recurse_folders):
600 * src/modest-tny-local-folders-account.c:
601 (modest_tny_local_folders_account_query_passes):
602 * src/modest-tny-msg.c: (copy_mime_part),
603 (modest_tny_msg_find_body_part_from_mime_part):
604 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
605 (modest_tny_send_queue_try_to_send):
606 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
607 (_modest_ui_actions_open), (download_uncached_messages),
608 (reply_forward), (modest_ui_actions_on_copy),
609 (modest_ui_actions_on_details), (has_retrieved_msgs),
610 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
612 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
613 (_selected_msg_marked_as), (_msg_download_completed),
614 (_selected_msg_sent_in_progress):
615 * src/widgets/modest-attachments-view.c:
616 (modest_attachments_view_set_message):
617 * src/widgets/modest-msg-view.c: (find_cid_image):
618 * tests/check_folder-transfer.c: (find_folders):
619 * tests/check_update-account.c: (func):
620 * tests/dbus_api/test_get_folders.c: (main):
621 Checked all uses of tny_iterator_get_current(), making sure
622 that the object is unreferenced (3 or 4 places did not),
623 and adding checks for NULL.
625 2007-07-23 Murray Cumming <murrayc@murrayc.com>
627 * src/dbus_api/modest-dbus-callbacks.c:
628 (on_idle_open_default_inbox): Make sure that the application UI is
630 * src/maemo/easysetup/modest-easysetup-wizard.c:
631 (on_entry_invalid_character): Show the word whitespace instead
632 of (null) in the banner when whitespace was entered.
633 (show_error): Add a comment that this does not work in
634 Maemo Bora, though we do not know why.
636 2007-07-23 Murray Cumming <murrayc@murrayc.com>
638 * src/modest-tny-account.c:
639 (modest_tny_account_get_special_folder): Use an if instead of
640 an assert for when the parent account name is NULL, because this
641 might be causing a crash in projects.maemo.org bug 63192.
642 * src/modest-mail-operation.c:
643 (modest_mail_operation_send_new_mail_cb),
644 (modest_mail_operation_remove_folder): unref the folder that is
645 returned from modest_tny_account_get_special_folder().
647 2007-07-23 Murray Cumming <murrayc@murrayc.com>
649 * src/modest-ui-actions.c:
650 (modest_ui_actions_on_password_requested):
651 Show mail_ib_login_cancelled info banner when the user cancels
652 the protected password dialog, to fix projects.maemo.org
655 2007-07-23 Murray Cumming <murrayc@murrayc.com>
657 * src/maemo/modest-account-settings-dialog.c:
658 (create_page_outgoing): Put this page in a GtkScrolledWindow,
659 matching the UI mock-up in the UI spec, and allowing access
660 to all widgets even when the on-screen keyboard is active.
662 2007-07-23 Murray Cumming <murrayc@murrayc.com>
664 Reverted this previous commit from Johannes,
665 because the scrollbars are always visible and because
666 I think we only need it on onepage of the account
667 settings, not the account wizard.
668 (I wrote the wrong instructions in the bug.)
670 * src/maemo/easysetup/modest-easysetup-wizard.c:
671 Added scrollbars to account wizard dialog.
672 Fixed projects.maemo.org NB #62744
674 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
676 * src/maemo/easysetup/modest-easysetup-wizard.c:
677 (create_page_user_details):
678 Use auto-cap for name (projects.maemo.org NB#63716)
679 * src/widgets/modest-account-view.c: (on_account_busy_changed):
681 2007-07-22 Armin Burgmeier <armin@openismus.com>
683 * src/maemo/modest-ui-actions.c: Use current account instead of
684 default account for creating viewer windows, so that the viewer
685 window knows to which account the viewed message belongs.
687 * src/maemo/modest-msg-view-window.c: Destroy the window when the
688 corresponding account is deleted. This fixes projects.maemo.org bug
691 2007-07-18 Armin Burgmeier <armin@openismus.com>
693 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
694 the dialog close after entering an invalid port number and clicking
695 OK. This fixes projects.maemo.org bug NB#63602.
697 2007-07-18 Armin Burgmeier <armin@openismus.com>
699 * src/modest-tny-account-store.c:
700 (get_server_accounts): Set parent modest account name for each
701 connection-specific transport account so that special folders of such
702 an account can be looked up. This fixes a crash when changing account
703 settings. This might also be related to projects.maemo.org bug
706 2007-07-16 Armin Burgmeier <armin@openismus.com>
708 * src/modest-ui-actions.c: Added a button to create a folder to the
709 move-to dialog. This fixes projects.maemo.org bug NB#59863.
711 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
713 * src/maemo/easysetup/modest-easysetup-wizard.c:
714 Added scrollbars to account wizard dialog.
715 Fixed projects.maemo.org NB #62744
717 2007-07-16 Murray Cumming <murrayc@murrayc.com>
719 * src/widgets/modest-msg-view.h:
720 * src/widgets/modest-msg-view.c:
721 Added modest_msg_view_get_message_is_empty() but this needs
723 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
724 Check if there is any text in the message yet.
725 But this needs to be implemented properly.
726 (modest_msg_edit_window_toggle_find_toolbar):
727 * src/maemo/modest-msg-view-window.c:
728 (modest_msg_view_window_toggle_find_toolbar):
729 Show a banner warning if there is no text to search, when
730 trying to start a search. This partially fixes
731 projects.maemo.org bug NB#62350.
733 2007-07-13 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-mail-operation.c: (update_account_thread):
736 Initialized num_new_headers to fix the build.
738 2007-07-13 Murray Cumming <murrayc@murrayc.com>
740 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
741 Ignore modest accounts whose server accounts don't exist in gconf.
742 This prevents us trying to create TnyAccount instances for those
743 server accounts when the server account has been removed from gconf,
744 but the parent modest account has not yet been removed from modest.
745 I don't know why this is only noticeable now. It was probably just
746 a harmeless g_warning() anyway.
748 2007-07-13 Murray Cumming <murrayc@murrayc.com>
750 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
751 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
753 2007-07-12 Armin Burgmeier <armin@openismus.com>
755 * src/maemo/modest-main-window.c: Make default account appear bold
756 in view, tools/send & receive and toolbar/send & receive SCM menus.
757 This fixes projects.maemo.org bug NB#59010.
759 2007-07-12 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
762 Add a short-cut, by checking if the folder store is an account.
763 This ensures that the Sort menu item and toolbar is dimmed for
764 the local-folders account root item, fixing
765 projects.maemo.org bug NB#62545.
767 2007-07-12 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-tny-account-store.c: (get_password):
770 Show the password dialog (via the signal) only in the mainloop, via
771 an idle handler that we wait for. This could theoretically prevent
772 hangs, though I worry that it could introduce some too.
774 2007-07-12 Murray Cumming <murrayc@murrayc.com>
776 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
777 * src/maemo/modest-platform.c:
778 (modest_platform_connect_and_wait):
779 Take a TnyAccount* parameter and try to set it to online
780 (a TnyCamel-only API), because tinymail sets accounts to offline
781 when the user cancels a password dialog, and doesn't ask again until
782 it has been set to online.
783 However, this is commented out because it causes a hang now.
785 (modest_platform_connect_and_wait_if_network_account):
786 * src/modest-mail-operation.c:
787 (modest_mail_operation_update_account):
788 * src/modest-platform.h:
789 * src/modest-ui-actions.c: (_modest_ui_actions_open),
790 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
792 2007-07-12 Armin Burgmeier <armin@openismus.com>
794 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
796 * src/modest-mail-operation.c:
797 * src/modest-ui-actions.c: Check for already existing folder before
798 querying the server, show error message from camel if the request
799 still fails. This fixes projects.maemo.org bug NB#58701.
801 2007-07-12 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-tny-account-store.h:
804 * src/modest-tny-account-store.c:
805 Added modest_tny_account_store_forget_password_in_memory(),
806 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
807 when creating a new account, so that new passwords will be used, instead of
808 us thinking that it's a second request as a result of a failed password again.
810 2007-07-12 Murray Cumming <murrayc@murrayc.com>
812 * src/dbus_api/modest-dbus-callbacks.c:
813 (on_idle_open_message): If the message is in drafts then open it
814 in an edit window instead of a view window. This fixes
815 projects.maemo.org bug NB#63005.
817 2007-07-12 Murray Cumming <murrayc@murrayc.com>
819 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
820 Avoided a harmless g_warning().
822 2007-07-12 Murray Cumming <murrayc@murrayc.com>
824 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
825 Pass the modest account name, not the TnyAccount display name to
826 modest_msg_view_window_new() so that the reply feature works,
827 fixing projects.maemo.org bug NB#62892.
829 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
830 (modest_msg_view_window_new_with_header_model):
831 * src/maemo/modest-msg-view-window.c:
832 (modest_msg_view_window_new_with_header_model),
833 (modest_msg_view_window_new):
834 * src/modest-ui-actions.c: (reply_forward):
835 * src/widgets/modest-msg-view-window.h:
836 * src/widgets/modest-window.c: (modest_window_set_active_account):
837 Rename an account parameter to modest_account_name to make this clearer.
839 2007-07-11 Murray Cumming <murrayc@murrayc.com>
841 * src/modest-ui-actions.h:
842 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
843 modest_do_message_delete().
844 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
845 Call modest_do_message_delete(), hoping that this would cause messages
846 to be really deleted from search instead of just marked with strike through.
847 Does not seem to help.
849 2007-07-11 Armin Burgmeier <armin@openismus.com>
851 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
852 priv->reselect to FALSE prior to calling
853 modest_folder_view_select_first_inbox_or_local() to prevent endless
854 recursion and thus a crash on startup.
856 2007-07-11 Armin Burgmeier <armin@openismus.com>
858 * src/maemo/modest-account-settings-dialog.h: Include
859 <gtk/gtknotebook.h> to fix the build (at least for me).
861 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
862 Use "New FolderN" as default suggested name if "New folder" already
863 exists, with N being the first free number, though never exceed "New
864 folder99" in which case we just fall back to "New Folder" even though
865 it already exists. This fixes projects.maemo.org bug NB#58663.
867 2007-07-11 Murray Cumming <murrayc@murrayc.com>
869 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
870 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
871 projects.maemo.org bug NB#62778.
873 2007-07-11 Murray Cumming <murrayc@murrayc.com>
875 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
876 Ignore the wrong (for now) secure-smtp setting in the presets -
877 just default to requiring secure authentication for SMTP, because
880 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
882 * src/widgets/modest-folder-view.c: (filter_row)
883 Do not show drafts folder (see UI specs)
885 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
887 * src/modest-ui-actions.c:
888 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
889 place and also not necessary.
891 * src/widgets/modest-folder-view.c: (filter_row)
892 Guess folder type and hide Sent & Outbox if necessary.
893 Fixed project.maemo.org NB#57328
895 2007-07-11 Murray Cumming <murrayc@murrayc.com>
897 * src/modest-ui-actions.h:
898 * src/modest-ui-actions.c:
899 (modest_ui_actions_on_delete_message):
900 Move some code into a new
901 modest_ui_actions_refresh_message_window_after_delete()
902 function so we can use it from elsewhere.
904 * src/dbus_api/modest-dbus-callbacks.c:
905 (on_idle_delete_message), (on_delete_message): Used an idle
906 handler, as we do for the other D-Bus method handlers.
907 Call modest_ui_actions_refresh_message_window_after_delete()
908 if the deleted message was open in a window. This fixed
909 projects.maemo.org bug NB#62862.
911 2007-07-11 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-main.c: (main): Only show the UI at the start if
914 the showui command line option was given. For instance,
915 run-standalone src/modest showui
916 Otherwise, we wait for the top_application D-Bus method to
917 be sent by hildon-desktop when the application is selected
919 This allows us to run without a UI when osso-global-search
920 uses our D-Bus methods.
922 2007-07-11 Murray Cumming <murrayc@murrayc.com>
924 * src/dbus_api/modest-dbus-api.h: Added a define for a
925 top-application D-Bus method.
926 * src/dbus_api/modest-dbus-callbacks.c:
927 (on_top_application),
928 (modest_dbus_req_handler): Handle the top-application D-Bus
929 method, which might be an undocumented D-Bus signal sent by
930 hildon-desktop when it starts the application from the menu.
931 But I am not sure and I need to test it on the device, because
932 my scratchbox does not have the application in the menu now.
933 This method shows the main window, so that it can be invisible
934 when started, for instance, just for email searching from
937 * src/maemo/modest-main-window.c: (restore_settings),
938 (modest_main_window_new): Do not show the window immediately
939 upon creation. We show it later.
940 * src/modest-widget-memory.c: (save_settings_paned):
941 Try (unsuccessfully) to avoid saving the paned position when
942 it is not even visible.
943 (restore_settings_paned): Do not allow a silly paned position.
944 This seems necessary when not showing the window at first.
946 * tests/dbus_api/Makefile.am:
947 * tests/dbus_api/test_top_application.c: (main): Test for the
950 2007-07-10 Murray Cumming <murrayc@murrayc.com>
952 * src/modest-ui-dimming-rules.c:
953 (modest_ui_dimming_rules_on_new_msg),
954 (modest_ui_dimming_rules_on_reply_msg),
955 (modest_ui_dimming_rules_on_delete_msg),
956 (modest_ui_dimming_rules_on_details),
957 (modest_ui_dimming_rules_on_view_window_move_to),
958 (modest_ui_dimming_rules_on_view_previous),
959 (modest_ui_dimming_rules_on_view_next),
960 (_invalid_folder_for_purge): Added checks before
961 casting the window. This looks like an actual
962 logic error in _invalid_folder_for_purge(), because it
963 tries to use a ModestMainWindow as a message window.
965 2007-07-10 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/modest-account-settings-dialog.c:
968 (show_error): Use the same implementation as in
969 modest-easysetup-wizard.c:
970 (on_entry_invalid_character): The logical ID contains a %s.
971 Guessed what it should be.
972 (on_entry_max), (check_data), (on_response): Adapt to
973 changed show_error().
974 (create_page_account_details): Really call
975 modest_validating_entry_set_func() on the correct widgets.
976 * src/maemo/easysetup/modest-easysetup-wizard.c:
977 (on_entry_invalid_character): Fix the logical ID here too.
978 (create_page_account_details),
979 (create_page_user_details):
981 modest_validating_entry_set_func() on the correct widgets.
983 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
984 Do not try to use the account if it is NULL.
986 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
988 * src/modest-ui-actions.c: (create_move_to_dialog),
989 (modest_ui_actions_on_main_window_move_to),
990 (modest_ui_actions_on_msg_view_window_move_to):
991 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
992 (filter_row), (modest_folder_view_show_non_move_folders):
993 * src/widgets/modest-folder-view.h:
995 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
996 the Sent folder yet as it does not report the correct folder type.
998 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1000 * src/maemo/modest-msg-edit-window.c: (init_window):
1003 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1005 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1006 Take a parent widget instead of a parent window, and
1007 implement this with hildon_banner_show_information() instead.
1008 Non-Maemo builds can just ifdef that there.
1009 This fixed projects.maemo.org bug NB#62766.
1011 (on_entry_invalid_character): Use show_error() again instead
1012 of using hildon directly, and use the _CS() macro to use the correct
1014 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1015 Pass a widget instead od a window to show_error().
1017 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1019 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1020 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1021 This allows us to show the server name in the error message, fixing
1022 projects.maemo.org bug NB#62904.
1023 Also, use the appropriate logical ID message for the account protocol.
1025 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1027 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1028 A compilation fix, though the build wasn't broken for me.
1030 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1033 Do not try to unref a NULL folder store, to avoid a runtime warning.
1034 This seems to happen sometimes when changing accounts settings.
1036 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1038 * src/modest-tny-account-store.c:
1039 (modest_tny_account_store_instance_init),
1040 (modest_tny_account_store_finalize),
1041 (on_account_settings_hide), (on_idle_wrong_password):
1042 Use a GHashTable to ensure that we only show one account settings
1043 dialog per modest account. This avoids us having a dialog open for
1044 both the store and transport accounts, or due to repeated get_password()
1045 calls that shouldn't happen anyway.
1047 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1049 * src/maemo/modest-maemo-utils.c: (on_hide),
1050 (modest_maemo_show_dialog_and_forget): Handle the response, because
1051 the window is not even hidden by default.
1053 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1054 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1055 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1056 which seems to prevent some modality problems.
1058 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1059 Ignore user cancellation errors.
1061 * src/modest-account-mgr-helpers.h:
1062 * src/modest-account-mgr-helpers.c:
1063 Added modest_server_account_get_password() and
1064 modest_server_account_get_has_password() to avoid direct use of
1067 * src/maemo/modest-account-settings-dialog.h:
1068 * src/maemo/modest-account-settings-dialog.c:
1069 (modest_account_settings_dialog_init): Store the notebook so we can
1071 Added modest_account_settings_dialog_switch_to_user_info().
1073 * src/modest-tny-account-store.c:
1074 (get_password): When the password in the account settings is wrong (we think),
1075 show the relevant page of the account settings dialog, in the mainloop.
1076 However, we currently get many of these at once because cancel does not
1078 (forget_password): Do not forget the password
1079 from the account settings, because this causes side-effects when
1080 tinymail seems to call it at strange time, maybe because of how we
1081 are cancelling get_password().
1082 (modest_tny_account_store_alert): Ignore user cancellations.
1084 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1086 * src/maemo/modest-maemo-utils.h:
1087 * src/maemo/modest-maemo-utils.c:
1088 Added modest_maemo_show_information_note_and_forget() for use instead of
1089 gtk_dialog_run() when the response is not needed, to avoid an extra
1090 mainloop which could cause a hang.
1092 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1093 Use the logical IDs for the error message, though they are not
1094 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1095 because gtk_dialog_run() caused a hang here (the window did not close).
1096 This fixes projects.maemo.org bug NB#62646.
1098 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-account-mgr-helpers.h:
1101 * src/modest-account-mgr-helpers.c:
1102 Added modest_account_mgr_get_store_protocol().
1104 * src/maemo/modest-account-view-window.c:
1105 (on_delete_button_clicked): Show different warning text depending on
1106 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1107 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1110 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1112 * src/maemo/modest-msg-edit-window.c:
1113 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1114 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1116 2007-07-07 Armin Burgmeier <armin@openismus.com>
1118 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1119 ckdg_ib_maximum_characters_reached from correct package.
1121 * src/modest-ui-actions.c: Show an error message when a folder could
1122 not be created. Tinymail does not give us specific error codes about
1123 what has gone wrong, so we assume that a folder with that name
1124 already exists, though there might be other reasons.
1126 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1128 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1129 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1130 give a more exact error message that can be partly translated.
1132 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1134 * src/maemo/modest-address-book.c:
1135 (select_email_addrs_for_contact): Specify a default window size for the
1136 select-email-address dialog, so that it is probably big enough for the
1137 title. This should fix projects.maemo.org bug NB#62277.
1139 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1141 * src/maemo/easysetup/modest-easysetup-wizard.c:
1142 (create_page_complete_easysetup): Use
1143 gtk_widget_set_size() request to ensure that the text wraps
1146 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1148 * src/maemo/easysetup/modest-easysetup-wizard.c:
1149 (on_entry_invalid_character), (create_page_account_details),
1150 (create_page_user_details):
1151 Use new API of ModestValidatingEntry. But for some reason the banner is
1152 not shown. I will have to investigate that further.
1154 * src/widgets/modest-validating-entry.c: (on_insert_text),
1155 (modest_validating_entry_set_func):
1156 * src/widgets/modest-validating-entry.h:
1157 Added a new callback function to be able to react to prevented
1158 characters whitespaces to e.g show a banner.
1160 2007-07-05 Armin Burgmeier <armin@openismus.com>
1162 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1163 notification of HildonNumberEditor instead of remembering the port
1164 number. Thanks to Johannes for pointing this out.
1166 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1168 * src/maemo/easysetup/modest-easysetup-wizard.c:
1169 Check if there are any user changes before showing a confirmation
1170 dialog (projects.maemo.org NB#60946)
1172 2007-07-05 Armin Burgmeier <armin@openismus.com>
1174 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1175 number at the beginning of the dialog and set the modified flag at the
1176 end if the port number has changed. This is necessary because
1177 HildonNumberEditor does not support notification when the value has
1180 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-ui-actions.c:
1183 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1184 a connection before asking anything else. Correct the check for the destination
1185 folder so that it succeeds when online.
1186 This fixed projects.maemo.org bug NB#61645.
1188 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1190 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1191 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1192 to fix projects.maemo.org bug NB#62439.
1194 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-tny-account.c: (on_connection_status_changed):
1197 Really do not use tny_device_force_offline() here. See the previous comment.
1199 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-tny-account.c: (on_connection_status_changed):
1202 Do not use tny_device_force_offline() when tinymail says that something
1203 went wrong with the connection. It seems to report this unnecessarily.
1205 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1207 * src/maemo/modest-connection-specific-smtp-window.c:
1208 (modest_connection_specific_smtp_window_init):
1209 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1210 does not seem to have any effect in osso 1.1 (though it works in
1211 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1213 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1215 * src/maemo/modest-connection-specific-smtp-window.c:
1216 Fix UI specification problems with projects.meamo.org NB#60479
1218 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1221 clue when this has failed, because the error dialog is not always shown
1222 (at least in earlier version).
1224 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1225 GError message, because the generic error dialog is not helpful.
1227 'This message is not currently available (can't let a new connection go online)'
1228 when trying to open an IMAP message.
1230 (_modest_ui_actions_open): Offer a connection when some messages would
1231 have to be downloaded and we are offline.
1233 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1235 * src/widgets/modest-folder-view.c:
1236 Don't check for MERGE type anymore as we use the correct type
1238 NOTE: For the last two changes you need to update your tinymail copy
1239 because of API changes!
1241 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1243 * src/modest-tny-local-folders-account.c:
1244 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1245 (see projects.maemo.org NB#61580)
1247 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1249 * src/modest-tny-account.c: (on_connection_status_changed):
1250 Commented out the call to modest_platform_connect_and_wait() because this
1251 seems to always hang, and I would like to know if this is the only thing
1252 that causes a hang when showing the connection dialog.
1253 It is not very useful anyway.
1255 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1257 * src/maemo/modest-msg-view-window.c:
1258 (modest_msg_view_window_select_next_message):
1260 * src/modest-platform.h:
1261 * src/maemo/modest-platform.c:
1262 Added modest_platform_connect_and_wait(), which calls
1263 tny_maemo_conic_device_connect() always in the main thread, by calling it
1264 in an idle handler and waiting for the idle handler to run. It should be
1265 in the main thread because it uses GTK+ UI code. It just returns TRUE
1266 if the device is already online.
1268 There is some nasty code to ensure that subsequent calls to
1269 modest_platform_connect_and_wait() just wait for the first one to finish,
1270 by checking repeatedly in another idle handler. This is necessary,
1271 because other threads (or even the main thread, via another idle handler)
1272 can call modest_platform_connect_and_wait() while
1273 modest_platform_connect_and_wait() is running.
1275 (modest_platform_connect_and_wait_if_network_account),
1276 (modest_platform_connect_and_wait_if_network_folderstore):
1277 Convenience functions that calls modest_platform_connect_and_wait() if
1278 the account or folder might want network access.
1280 * src/modest-mail-operation.c:
1281 (modest_mail_operation_update_account):
1282 * src/modest-ui-actions.c: (download_uncached_messages),
1283 (modest_ui_actions_on_rename_folder), (delete_folder),
1284 (modest_ui_actions_on_main_window_move_to),
1285 (modest_ui_actions_on_msg_view_window_move_to):
1286 * src/widgets/modest-folder-view.c:
1287 (drag_and_drop_from_folder_view):
1288 Offer a connection if we are offline.
1290 * src/modest-tny-account.c: (on_connection_status_changed):
1291 Document this as only handling errors during network operations in progress,
1292 and replace the idle code with a simple call to
1293 modest_platform_connect_and_wait(), which does this instead.
1295 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-tny-account.c:
1298 (modest_tny_account_get_special_folder): (util_on_idle),
1299 Handle the GError so we can see when tny_folder_store_get_folders()
1300 fails, as it currently does while something else is connecting.
1302 Added util_run_in_main_thread_and_wait()
1303 which uses an idlen handler and mainloop to ensure that the function
1304 is called in the main thread.
1305 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1306 to make sure that we call attempt the connection in the mainloop only,
1307 which might solve some hangs.
1309 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1311 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1312 be found by their display name. This is never useful.
1313 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1314 by its ID, instead of trying to use its ID as its display name.
1316 * src/modest-tny-account-store.h:
1317 * src/modest-tny-account.c:
1318 (modest_tny_account_get_special_folder): Add a g_warning() when
1319 tny_folder_store_get_folders() returns an empty list for the maildir.
1321 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1322 Add a g_warning() when this returns NULL, because that it not allowed
1325 2007-07-02 Armin Burgmeier <armin@openismus.com>
1327 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1328 note when trying to cancel the wizard. This fixes projects.maemo.org
1331 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-tny-account.h:
1334 * src/modest-tny-account.c:
1335 (modest_tny_account_new_from_server_account),
1336 (modest_tny_account_new_from_server_account_name),
1337 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1338 because this must now be set before setting the proto. This is usd in
1339 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1340 warning in camel_session_get_service() caused by
1341 tny_camel_transport_account_prepare().
1343 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1346 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1348 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1350 (modest_connection_specific_smtp_edit_window_init):
1352 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1353 of "changed" for now
1355 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-tny-account.c:
1358 (modest_tny_account_new_from_server_account):
1359 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1360 now uses to request a connection when it needs one, and which it uses
1361 to tell us that something is wrong with the connection, so we can force
1362 the accounts offline to prevent further problems.
1364 * src/modest-defs.h:
1365 * src/modest-init.c: (init_default_settings):
1366 * src/modest-mail-operation.c:
1367 (modest_mail_operation_update_account):
1368 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1369 This should not be necessary anymore. Do not set the conf key that
1370 determined this (it was always TRUE and not set anywhere else).
1372 * src/modest-ui-actions.h: Remove unused and unimplemented
1373 modest_ui_actions_on_online_toggle_toggled().
1375 2007-06-29 Murray Cumming <murrayc@murrayc.com
1377 * src/maemo/modest-main-window.c: (connect_signals):
1378 Don't connect to delete_event twice. Maybe this was harmless.
1380 2007-06-29 Murray Cumming <murrayc@murrayc.com
1382 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1383 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1384 Debug output to give some more clue when a folder move is not allowed.
1386 2007-06-28 Murray Cumming <murrayc@murrayc.com
1388 * src/modest-tny-account.c: (on_modest_file_system_info),
1389 (modest_tny_account_get_mmc_account_name):
1390 Always call the callback, without checking whether the name has changed.
1391 * src/widgets/modest-folder-view.c: (strings_are_equal),
1392 (on_model_foreach_set_name), (on_get_mmc_account_name),
1393 (text_cell_data): Compare the name here, and use the name from
1394 the account rather than from the
1395 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1396 if the name was changed after the account was added to the model.
1397 That's a tinymail bug but not one that I want to fix now.
1399 This finally fixes projects.maemo.org bug NB#59301.
1401 2007-06-27 Armin Burgmeier <armin@openismus.com>
1403 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1406 2007-06-27 Murray Cumming <murrayc@murrayc.com
1408 * src/modest-tny-account.h:
1409 * src/modest-tny-account.c:
1410 Added modest_tny_account_get_mmc_account_name(), to set the memory
1411 card name asynchronously for the given account and then notify.
1412 (modest_tny_account_new_for_local_folders): Use this new function instead
1413 of using hildon_file_system_info_async_new() directly.
1415 * src/widgets/modest-folder-view.c: (text_cell_data):
1416 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1417 gtk_tree_model_row_changed() when it is available.
1419 This should fix projects.maemo.org bug NB#59301.
1421 2007-06-27 Murray Cumming <murrayc@murrayc.com
1423 * src/modest-mail-operation.c: (update_account_thread),
1424 (get_msgs_full_thread): Fix typo failures in the revert
1427 2007-06-27 Murray Cumming <murrayc@murrayc.com
1429 * src/maemo/modest-maemo-global-settings-dialog.c:
1430 (idle_select_default_focus):
1431 * src/modest-mail-operation.c: (idle_notify_progress),
1432 (idle_notify_progress_once), (set_last_updated_idle),
1433 (update_account_thread), (get_msgs_full_thread):
1434 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1435 * src/widgets/modest-header-view.c:
1436 (idle_notify_headers_count_changed_destroy),
1437 (idle_notify_headers_count_changed):
1438 Reverted the additions of gdk_threads_enter/leave(), in case this
1439 helps with a startup hang on the device.
1441 2007-06-26 Armin Burgmeier <armin@openismus.com>
1443 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1444 for supported secure authentication methods from server by
1445 gtk_dialog_run(), saving CPU time and a potential race condition.
1447 2007-06-26 Armin Burgmeier <armin@openismus.com>
1449 * src/maemo/modest-maemo-utils.h:
1450 * src/maemo/modest-maemo-utils.c: Added a
1451 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1452 only error code to tell the calling code when the user canceled the
1455 * src/maemo/modest-account-settings-dialog.h:
1456 * src/maemo/modest-account-settings-dialog.c:
1457 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1458 message if the retrieval of secure authentication methods was canceled
1459 by the user. Perform the check before saving anything to configuration
1460 to not end up with half-committed configuration changes, do not show
1461 a "Saving to configuration failed" note when authentication methods
1462 could not be retrieved.
1464 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1467 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1469 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1470 Only return the first level of folders under accounts, because the
1471 osso-global-search UI spec doesn't want the rest.
1472 This fixed projects.maemo.org bug NB#61811.
1474 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1476 * src/modest-tny-account-store.c:
1477 * src/modest-tny-account-store.h:
1478 Added modest_tny_account_is_memory_card_account().
1479 * src/maemo/modest-main-window.c: (create_details_widget):
1480 Show the same information items for the memory card as we show for the
1481 local-folders, to fix projects.maemo.org bug NB#59307.
1483 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-tny-account-store.c: (get_password):
1486 Added some checks for NULL to maybe prevent crashes, though I think
1487 it was Philip's last commit that actually prevented the crash here
1488 when creating a first new account.
1489 But the new account is still not usable (no messages are shown)
1490 until a restart of the application.
1492 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1494 * src/maemo/modest-maemo-global-settings-dialog.c:
1495 (idle_select_default_focus):
1496 * src/modest-mail-operation.c: (idle_notify_progress),
1497 (idle_notify_progress_once), (idle_notify_update_account_queue),
1498 (set_last_updated_idle), (update_account_thread),
1499 (notify_get_msgs_full), (get_msgs_full_destroyer),
1500 (get_msgs_full_thread):
1501 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1502 * src/widgets/modest-header-view.c:
1503 (idle_notify_headers_count_changed_destroy),
1504 (idle_notify_headers_count_changed):
1505 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1506 all idle handlers, because some other thread could be blocking
1507 the GDK lock, so that it can do GUI stuff.
1509 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1511 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1512 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1513 (on_idle_send_receive), (on_idle_open_default_inbox):
1514 * src/maemo/modest-msg-edit-window.c:
1515 (modest_msg_edit_window_attach_file_noninteractive):
1516 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1517 to prevent a hang. I don't quite understand why these are necessary,
1518 beause we should already be in the main loop. I guess something outside
1519 of the main loop is taking the lock.
1521 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1522 we are really using URIs, and use files that are more likely to exist.
1524 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1526 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1527 necessary because configure.ac now defines different variables.
1529 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1531 * libmodest-dbus-client/libmodest-dbus-client.c:
1532 * libmodest-dbus-client/libmodest-dbus-client.h:
1533 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1534 libmodest_dbus_client_compose_mail() is what things actually use.
1536 * src/dbus_api/modest-dbus-api.h:
1537 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1538 * tests/dbus_api/Makefile.am:
1539 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1542 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-init.c: (modest_init_local_folders):
1545 For memory-card (or other non local-folders) maildir accounts,
1546 always create an Archive folder, so that there is somewhere to put
1547 messages. This should be less confusing, because the user does not need
1548 to guess that the need to create a folder.
1550 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1552 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1553 Fixed icon size by using (50, 50) which is the same as defined by
1556 2007-06-25 Armin Burgmeier <armin@openismus.com>
1558 * src/widgets/modest-window-mgr.c:
1559 * src/modest-init.c:
1560 * configure.ac: Correctly recognize hildon-notify presence and fixed
1561 the build without it being installed.
1563 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1565 * libmodest-dbus-client/libmodest-dbus-client.c:
1566 (libmodest_dbus_client_search): Fix the build. Sorry.
1567 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1568 (reply_forward_cb): Initialize variables to fix the build.
1570 * src/modest-tny-account-store.c:
1571 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1572 comparison (a silly typo) so that email search results can be opened
1573 when there are more than one account.
1575 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1577 * libmodest-dbus-client/libmodest-dbus-client.c:
1578 (libmodest_dbus_client_search),
1579 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1580 instead of 1 second, because the search gets folders and messages from
1581 the server, which can take a long time. When it times out,
1582 osso-global-search will report no results.
1584 We need to specify whether we should search only cached information
1585 (maybe with a user preference), and the osso-email-search-plugin
1586 API should really be improved to allow that option, and to allow results
1587 to be delivered asynchronously in batches.
1589 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1591 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1592 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1593 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1595 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1597 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1598 that is an empty string. D-Bus seems to give us these instead of NULL.
1600 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1602 * src/dbus_api/modest-dbus-callbacks.c:
1603 * src/maemo/easysetup/modest-easysetup-wizard.h:
1604 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1605 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1606 (modest_connection_specific_smtp_edit_window_init):
1607 * src/maemo/modest-maemo-global-settings-dialog.c:
1609 * src/maemo/modest-maemo-utils.c:
1610 (modest_maemo_utils_setup_images_filechooser):
1611 * src/maemo/modest-main-window.c: (create_details_widget):
1612 * src/maemo/modest-msg-edit-window.c:
1613 (modest_msg_edit_window_attach_file_noninteractive),
1614 (modest_msg_edit_window_color_button_change),
1615 (modest_msg_edit_window_set_zoom):
1616 * src/modest-mail-operation.c: (update_account_thread):
1617 * src/modest-tny-account-store.c:
1618 * src/modest-tny-account.c:
1619 * src/widgets/modest-global-settings-dialog.c:
1620 * src/widgets/modest-window.h:
1622 Fixed build on bora!
1624 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1626 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1627 * src/modest-search.c: (modest_search_folder),
1628 (modest_search_all_accounts): Actually search only in the specified folder,
1629 doing a simple match on the folder ID.
1630 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1631 and added some documentation.
1633 2007-06-22 Armin Burgmeier <armin@openismus.com>
1635 * src/maemo/modest-maemo-utils.h:
1636 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1637 modest_maemo_utils_get_supported_secure_authentication_methods.
1639 * src/maemo/easysetup/modest-easysetup-wizard.c:
1640 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1641 one occured, not just "Server does not support secure authentication".
1643 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1645 * src/modest-tny-account-store.c: (get_password):
1646 Restored the call to tny_account_set_user() because Philip seems to have
1647 stopped this from crashing (by not using the freed string). It still does
1648 not work, but now we can test it.
1650 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1652 * src/maemo/modest-msg-edit-window.c: (init_window):
1653 Comment out use of an uninitialzed GtkScrolledWindow variable,
1654 to fix the build and stop a crash. Yet again.
1656 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-tny-account-store.c: (get_password):
1659 Remove the call to tny_account_set_user() because this actually crashes.
1660 As mentioned in the last commit, it is known to not work anyway.
1662 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1664 * src/modest-tny-account-store.c: (get_password):
1665 Use tny_account_set_username() to tell tinymail that the username might
1666 have changed too. But tinymail ignores this: see projects.maemo.org
1668 * src/modest-ui-actions.c:
1669 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1670 reset the connection when changing the username, and improve the comments.
1671 Save the changed username to gconf at least, so it is used when Modest is
1674 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1676 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1677 Do not use a query, so that we get all folders, including for POP and
1678 local-folders. They work as search criteria too.
1679 This fixes projects.maemo.org bug NB#57740.
1681 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1683 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1684 Comment out the use of hildon_notification_set_sound() because it is
1685 not declared, to fix the build. Warnings are serious, people.
1687 2007-06-21 Armin Burgmeier <armin@openismus.com>
1689 * src/maemo/modest-maemo-utils.h:
1690 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1691 modest_maemo_utils_get_supported_secure_authentication_methods()
1692 to query authentication methods for a specific user. This should fix
1693 projects.maemo.org bug NB#61369.
1695 * src/maemo/easysetup/modest-easysetup-wizard.c:
1696 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1699 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1701 * libmodest-dbus-client/libmodest-dbus-client.h:
1702 * libmodest-dbus-client/libmodest-dbus-client.c:
1703 (modest_dbus_message_iter_get_search_hit),
1704 (libmodest_dbus_client_search):
1705 Reorganised and commented this.
1706 Removed modest_search_hit_free() from the public API because it
1709 Added libmodest_dbus_client_get_folders() and
1710 modest_folder_result_list_free().
1712 * src/dbus_api/modest-dbus-api.h:
1713 * src/dbus_api/modest-dbus-callbacks.c:
1714 (modest_dbus_req_filter): Commented. Moved most code to
1715 on_dbus_method_search() and added on_dbus_method_get_folders().
1717 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1718 of the extra D-Bus handler.
1720 * tests/dbus_api/Makefile.am:
1721 * tests/dbus_api/test_get_folders.c: New test for
1722 libmodest_dbus_client_get_folders(). This seems to return an empty list
1723 at the moment. That could be the same error that causes the message list
1724 to be empty sometimes.
1725 This should help with projects.maemo.org bug NB#57740.
1727 2007-06-21 Armin Burgmeier <armin@openismus.com>
1729 * src/modest-mail-operation.c: Do not call
1730 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1731 notify the operation's end after having set the status to CANCELED for
1732 the operation queue to listen on. This fixes a deadlock when there
1733 were mail operations in the queue during its finalization.
1735 * src/modest-singletons.c: Reordered uninitialization of the account
1736 manager to happen after the mail operation queue was uninitialized
1737 because the mail operation's in the queue might still try to access
1738 the account manager (see modest_mail_operation_notify_end()). This
1739 fixes a potential crash when terminating the application.
1741 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1743 * src/modest-search.c:
1744 (search_mime_part_and_child_parts): Moved some code here so we
1745 can search recursively in child folders.
1746 (modest_search_folder): Search in the message as a mime part, instead
1747 of just its child mime parts.
1748 (read_chunk), (search_mime_part_ogs):
1749 Check how many bytes were read, to prevent an endless loop.
1750 Searching in message bodies now works. This finishes the fix for
1751 projects.maemo.org bug NB#61007.
1753 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1755 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1756 Add a g_warning when the item is not a folder.
1758 * src/modest-ui-dimming-rules.c:
1759 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1760 when selected item is not a folder (for instance, an account), because
1761 the UI spec only talks about folders.
1762 I am not sure what the UI spec wants, so this might not totally fix
1763 projects.maemo.org bug NB#60794.
1765 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1768 (load_from_file): Sort the list. The unsorted list would be more noticeable
1769 in non-English locales.
1771 * src/maemo/modest-msg-edit-window.c:
1772 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1773 warning and fix the build.
1775 * src/maemo/modest-progress-bar-widget.c:
1776 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1777 avoid a g_warning, and probably to avoid a crash.
1779 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1781 * src/modest-search.c: (modest_search_folder): Check for a GError
1782 when calling tny_folder_get_headers(), to show that this is not the cause
1785 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1787 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1788 Actually set the body query instead of the subject query.
1790 * src/modest-search.c: (search_mime_part_ogs),
1791 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1792 which would probably cause it to fail if we got this far.
1794 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1795 to simplify the code.
1796 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1797 be causing search-in-body to fail.
1799 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1801 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1803 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1804 Better debug message when the folder cannot be found.
1805 This should help with fixing projects.maemo.org bug #61287.
1806 * src/modest-search.c: (add_hit): Do not leak the furl string.
1808 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1810 * src/modest-ui-actions.c:
1811 (modest_ui_actions_on_folder_selection_changed):
1812 Do not special-case TNY_MERGE_FOLDER here, because
1813 modest_tny_folder_get_account() already does that. This fixes
1814 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1815 shown when the Outbox was selected).
1817 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1819 * libmodest-dbus-client/libmodest-dbus-client.c:
1820 (_dbus_iter_get_string_or_null): Initialize the string variable in
1821 case this helps with Dirk's crash.
1823 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1825 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1826 though it is not implemented yet (this function is maybe not even used),
1827 to avoid breaking ABI in future.
1828 * libmodest-dbus-client/libmodest-dbus-client.c:
1829 (get_attachments_string): Moved some code into this generic function.
1830 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1831 sends email. It is maybe not used.
1832 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1833 (on_send_mail): Use attachments.
1835 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1836 * src/maemo/modest-msg-edit-window.c:
1837 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1838 a filename before using it, to fix projects.maemo.org bug NB#58233.
1840 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1842 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1843 Initialize the continue_download variable to fix the build, and probably
1844 to fix randome behaviour.
1846 2007-06-18 Armin Burgmeier <armin@openismus.com>
1848 * src/modest-tny-send-queue.h:
1849 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1850 the queue so we can later show it in the UI. Replaced
1851 modest_tny_send_queue_msg_is_being_sent() by
1852 modest_tny_send_queue_get_msg_status().
1854 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1856 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1857 gpointer. This probably was not harmful, but just to be sure.
1859 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1861 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1862 Fix the build, but leave the function broken on Bora, because
1863 hildon_uri_action_get_service() does not exist.
1864 osso_uri_action_get_service() does not exist either, it seems.
1866 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1868 * src/modest-tny-account.c:
1869 (modest_tny_account_new_from_server_account):
1870 Uncommented the url debug output again, because it is useful for
1871 debugging, as I said in the comment.
1873 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1875 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1877 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1878 for Mameo Bora, to fix the build.
1880 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1883 Fixed build with hildon < 0.99
1885 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1886 Check if the selected account is busy instead of checking all accounts
1888 * src/modest-account-mgr-priv.h:
1889 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1890 (modest_account_mgr_init), (compare_account_name),
1891 (modest_account_mgr_set_account_busy),
1892 (modest_account_mgr_account_is_busy):
1893 * src/modest-account-mgr.h:
1894 Added busy information to the account manager. It possible to
1895 set an account to busy or not busy now.
1897 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1898 (modest_mail_operation_update_account),
1899 (modest_mail_operation_notify_end):
1900 Set the account to busy/not busy depending on the operation state.
1902 * src/widgets/modest-account-view.c:
1903 (modest_account_view_finalize), (get_last_updated_string),
1904 (update_account_view), (on_account_busy_changed), (init_view):
1905 Show string "Refreshing..." if the account is currently busy.
1907 All this fixes projects.maemo.org bug NB#59711
1909 2007-06-14 Armin Burgmeier <armin@openismus.com>
1911 * src/widgets/modest-attachments-view.h:
1912 * src/widgets/modest-attachments-view.c: Added
1913 modest_attachments_view_has_attachments() and fixed coordinate
1914 transformation in get_att_view_at_coords(). This fixes attachment
1917 * src/widgets/modest-msg-view.c: Make use of
1918 modest_attachments_view_has_attachments() to decide whether to show
1919 attachments in the header.
1921 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1923 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1924 (on_change), (on_combo_security_changed),
1925 (modest_connection_specific_smtp_edit_window_init),
1926 (modest_connection_specific_smtp_edit_window_set_connection),
1927 (modest_connection_specific_smtp_edit_window_is_dirty):
1928 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1929 * src/maemo/modest-connection-specific-smtp-window.c:
1932 Show an comfirmation dialog for the smpt-edit-window if there are
1933 unsaved changes and the user hits cancel.
1934 (projects.maemo.org bug NB#60479)
1936 2007-06-14 Armin Burgmeier <armin@openismus.com>
1938 * src/maemo/easysetup/modest-easysetup-wizard.c:
1939 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1940 address" info in banner instead of node, and select all the text as
1941 per UI spec. This fixes projects.maemo.org bug NB#60550.
1943 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1945 reviewed by: <delete if not using a buddy>
1947 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1948 * src/modest-ui-actions.c: (folder_refreshed_cb):
1950 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1952 * src/widgets/modest-folder-view.c: (filter_row):
1953 Explictly filter out the per-account outbox accounts. I don't know why
1954 these only sometimes show up, but now they should never show up in the UI.
1955 This should fix projects.maemo.org bug NB#60160.
1957 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1960 when the toolbar does not exist yet.
1961 * src/modest-widget-memory.c: (save_settings_header_view):
1962 Added g_warnings() to help us to discover when we are trying to set
1963 an empty columns list in gconf.
1965 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-init.h:
1968 * src/modest-init.c:
1969 Added modest_init_get_default_header_view_column_ids().
1971 * src/modest-widget-memory.c: (restore_settings_header_view):
1972 Use the new function to get defaults, if the gconf key is empty,
1973 instead of not creating any columns. This seems to fix the
1974 empty right-hand pane problems.
1976 * src/widgets/modest-header-view.h: Improved documentation.
1978 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1980 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1981 Revert the use of the display name as the account name, because this
1982 is generally wrong and would break the code that follows.
1984 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1986 * src/maemo/easysetup/modest-easysetup-wizard.c:
1987 (check_for_supported_auth_methods), (on_before_next),
1990 More correct fix for projects.maemo.org bug NB# 58991
1991 Do not longer accept AUTH_PASSWORD as secure method and choose
1992 correct method when creating the account.
1994 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1996 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1997 Fixed projects.maemo.org bug NB# 58991
1999 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-init.c: (modest_init_init_core),
2002 (modest_init_local_folders): Fixed compilation errors.
2004 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2006 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2007 Remove unnecessary lib/include, though it is good in principle when needed.
2009 * src/modest-init.c: (modest_init_one_local_folder),
2010 (modest_init_local_folders):
2011 * src/modest-init.h: Initialize the .modest library for memory cards,
2012 instead of just doing nothing for them. This should allow us to create
2013 folders there, fixing projects.maemo.org bug NB#59297.
2015 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2017 * libmodest-dbus-client/libmodest-dbus-client.c:
2018 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2019 (libmodest_dbus_client_compose_mail),
2020 (libmodest_dbus_client_open_message),
2021 (libmodest_dbus_client_send_and_receive),
2022 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2024 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2025 (on_idle_open_message), (modest_dbus_req_handler),
2026 (search_result_to_message), (modest_dbus_req_filter):
2027 * src/modest-search.c: (add_hit), (modest_search_folder),
2028 (modest_search_all_accounts): Improved debug messages.
2030 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2032 * src/modest-tny-account-store.c:
2033 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2036 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2039 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-tny-account-store.c: (get_server_accounts):
2042 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2043 even when there are no accounts, so that the Outbox folder is always
2044 visible. This fixes projects.maemo.org bug NB#60158.
2046 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/modest-main-window.c: (create_details_widget):
2049 Use the mcen_va_never logical ID.
2051 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2053 * src/dbus_api/modest-dbus-api.h:
2054 * src/dbus_api/modest-dbus-callbacks.c:
2055 (on_idle_open_default_inbox), (on_open_default_inbox),
2056 (modest_dbus_req_handler):
2057 Added a new OpenDefaultInbox method.
2059 * libmodest-dbus-client/libmodest-dbus-client.h:
2060 * libmodest-dbus-client/libmodest-dbus-client.c:
2061 Added libmodest_dbus_client_open_default_inbox() to call the new
2062 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2063 though it should maybe be used by a new osso-email-interface function.
2065 * tests/dbus_api/Makefile.am:
2066 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2069 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2071 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2072 NULL, so that the signals get all the keys. This should not actually
2073 change any behaviour because we currently update everything when anything
2076 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2078 * src/widgets/modest-folder-view.c: (text_cell_data),
2079 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2080 (find_inbox_iter): If tinymail tells us that the folder is
2081 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2082 This causes the inbox to be selected at startup, fixing part of
2083 projects.maemo.org bug NB#56305.
2085 * src/modest-ui-dimming-rules.c:
2086 (modest_ui_dimming_rules_on_tools_smtp_servers):
2087 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2088 the SMTP servers menu item.
2089 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2090 that the SMTP Servers menu item is dimmed when there are no accounts,
2091 as a future version of the UI spec will require. This fixes
2092 projects.maemo.org bug NB#56305.
2094 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2096 * src/maemo/modest-maemo-utils.c:
2097 (modest_maemo_utils_get_supported_secure_authentication_methods):
2098 Added label to dialog instead of unreadable title
2100 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2101 (modest_main_window_new):
2102 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2105 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2106 * src/modest-account-mgr.h:
2107 Added method to avoid code duplication
2109 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2110 (modest_ui_actions_on_send_receive):
2111 Use modest_account_mgr_has_accounts
2113 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2115 * src/maemo/easysetup/modest-presets.c:
2116 (modest_presets_get_info_server_security): Do not report secure auth
2118 * src/modest-protocol-info.c: Use the defines for the gconf key names
2119 for secure authentication. This was not working because we were writing
2120 Password and reading password, and the check was case sensitive.
2121 With this, gmail now works for receiving and sending when created via
2124 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2126 * src/maemo/easysetup/modest-presets.c:
2127 (modest_presets_get_info_server_security): Correct the key name for
2128 SecureSmtp, because it seems to be case-sensitive.
2129 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2130 Do not try to get the 0th notebook page if there are 0 pages, to
2131 avoid a g_warning().
2133 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2135 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2136 Prevent use of the new notification feature for now, because it currently
2137 shows one dialog for each new email, which is annoying.
2139 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2141 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2142 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2143 when no country was selected, so that we show the global ones.
2144 * src/maemo/easysetup/modest-presets.c:
2145 (modest_presets_get_providers): Return only the global providers, not
2146 all providers when mmc=0 was requested.
2148 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2150 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2151 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2152 provider ID in the combo.
2154 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2155 Do not show the page numbers, because it would be confusing when we add
2156 the 2 extra pages for the custom setup, when the user chooses the "Other"
2157 provider. This fixes projects.maemo.org bug NB#59028
2159 * src/modest-init.c: (modest_init_init_core),
2160 (modest_init_local_folders):
2161 * src/modest-init.h:
2162 * src/modest-tny-account.c:
2163 (modest_tny_account_new_for_local_folders): Do not create default folders
2164 for the memory card. This should fix projects.maemo.org bug NB#59328.
2166 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2168 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2169 Free the changed_conf_keys string items. They are already freed in the
2170 idle handler if that runs first.
2172 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2174 * src/modest-ui-actions.c:
2175 (modest_ui_actions_on_password_requested): Check that the server name
2176 is not NULL, because I just saw a password dialog with (null) as the
2179 * src/modest-tny-folder.[h|c]: Added
2180 modest_tny_folder_is_memory_card_folder().
2181 * src/modest-ui-dimming-rules.c:
2182 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2183 menu item for memory cards, as per the UI spec (section 7.4). This should
2184 fix projects.maemo.org bug NB#59297.
2186 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2188 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2189 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2190 is another problem with the code, see Murray's comment at line 772)
2192 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2195 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2196 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2197 (load_from_file), (easysetup_country_combo_box_init),
2198 (easysetup_country_combo_box_get_active_country_ids),
2199 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2200 instead of just one ID, to avoid duplicate country names in the UI.
2202 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2203 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2204 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2205 a single ID, avoiding duplicate providers.
2206 * src/maemo/easysetup/modest-easysetup-wizard.c:
2207 (on_combo_account_country): Adapt to use a list.
2209 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2211 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2212 keys changed in the last X seconds.
2214 * src/modest-account-mgr.h:
2215 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2216 (on_key_change), (modest_account_mgr_class_init),
2217 (modest_account_mgr_init), (modest_account_mgr_finalize):
2218 As the keys are changed, save them in a GSList* and signal that GSList*
2219 further every X seconds, to batch changes, to allow us to do just one
2220 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2221 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2223 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2224 changed signal signature.
2226 * src/modest-conf.c: (modest_conf_set_list),
2227 (modest_conf_on_change): Reenable notification.
2229 (modest_conf_maemo_fake_on_change): Comment out the hack that
2230 notified immediately instead of asynchronously.
2232 * src/widgets/modest-account-view.h:
2233 * src/widgets/modest-account-view.c:
2234 (update_account_view): Select the previously-selected account ID,
2235 if possible. This fixes projects.maemo.org bug NB#56933.
2237 (on_account_changed), (on_account_removed),
2238 (modest_account_view_select_account):
2240 Remove the block/unblock functions
2241 because they were not useful.
2243 * src/maemo/modest-account-view-window.c:
2244 (on_delete_button_clicked), (on_edit_button_clicked),
2245 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2247 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2249 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2250 Improve the error dialog to show Incorrect Account Settings, which seems
2251 clearer, and say that the internal error message (to be removed from the
2252 dialog later) is often misleading.
2253 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2255 * src/modest-tny-account.c:
2256 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2257 URL because this is so useful for debugging on the device.
2259 * src/widgets/modest-serversecurity-combo-box.c:
2260 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2262 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2264 * src/modest-mail-operation.c:
2265 (modest_mail_operation_send_new_mail):
2266 Added a comment about a nasty but apparently harmless message. Details
2267 added to the wiki g_warnings() page.
2269 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2271 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2272 (modest_tny_send_queue_class_init):
2273 Do not use the priv struct because it is empty, to avoid g_warnings
2274 about a non-existant priv struct.
2276 * src/modest-tny-account-store.c:
2277 (modest_tny_account_store_get_server_account),
2278 (modest_tny_account_store_get_transport_account_for_open_connection
2279 ): Do not try to get transport server accounts for local folders,
2280 because they don't have any. This avoids a g_warning().
2282 * src/maemo/modest-main-window.c:
2283 (modest_main_window_notify_send_receive_initied),
2284 (on_configuration_key_changed):
2285 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2286 * src/modest-defs.h:
2287 * src/modest-mail-operation.c:
2288 (modest_mail_operation_update_account):
2289 * src/modest-tny-account-store.h:
2290 * src/modest-tny-account.c:
2291 (modest_tny_account_get_special_folder),
2292 (modest_tny_account_new_for_local_folders),
2293 (modest_tny_account_new_for_per_account_local_outbox_folder):
2294 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2295 * src/modest-tny-local-folders-account.c:
2296 (add_account_folders_to_merged_folder):
2297 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2298 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2299 (modest_ui_actions_on_send):
2300 * src/widgets/modest-folder-view.c: (update_model):
2301 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2302 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2303 modest_tny_account_store_get_tny_account_by_account() to
2304 modest_tny_account_store_get_server_account() to make the code clearer.
2306 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2308 * src/dbus_api/modest-dbus-api.h:
2309 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2310 * src/maemo/modest-msg-edit-window.c:
2311 (modest_msg_edit_window_attach_file_noninteractive):
2312 added g_warning in case the file to be attached does not exist
2313 * tests/dbus_api/test_compose_mail.c: (main):
2314 removed obsolete comment, added generic files as test case
2316 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2318 * src/modest-tny-account-store.c: (get_server_accounts):
2319 Create the local folders account only once, not once for each outbox, and
2320 not only when there are some outboxes.
2322 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2324 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2325 code that is causing a crash at startup. Sergio says that he is fixing this.
2327 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2329 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2330 * src/maemo/modest-account-settings-dialog.c:
2331 (create_page_outgoing),
2332 (modest_account_settings_dialog_set_account_name),
2333 (save_configuration):
2334 - Fixed handling of the "Use secure authentication" toggle to comply with
2335 the ui specification. See also projects.maemo.org bug NB#58400
2337 - Restore the Secure connection setting combo correctly when loading
2340 * src/maemo/modest-maemo-utils.c:
2341 (on_camel_account_get_supported_secure_authentication),
2342 (modest_maemo_utils_get_supported_secure_authentication_methods):
2343 Fixed a crasher if operation is canceled
2345 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2346 (modest_protocol_info_auth_is_secure):
2347 * src/modest-protocol-info.h:
2349 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2350 the sense of the "Use secure authentication" toggle.
2352 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2354 * src/modest-tny-account-store.h:
2355 * src/modest-tny-account-store.c:
2356 Added modest_tny_account_store_get_local_folders_account().
2358 * src/modest-tny-folder.h:
2359 * src/modest-tny-folder.c:
2360 (modest_tny_folder_get_account):
2361 Added this replacement for tny_folder_get_account() which returns
2362 the local-folders account for TnyMergeFolders, to avoid the
2363 warning about the unimplemented get_account_func() vfunc().
2365 (modest_tny_folder_get_rules),
2366 * src/modest-ui-actions.c:
2367 (modest_ui_actions_on_folder_selection_changed):
2368 * src/modest-mail-operation.c:
2369 (modest_mail_operation_remove_folder),
2370 (modest_mail_operation_xfer_folder),
2371 (modest_mail_operation_rename_folder),
2372 (modest_mail_operation_get_msg),
2373 (modest_mail_operation_get_msgs_full),
2374 (modest_mail_operation_remove_msg),
2375 (modest_mail_operation_xfer_msgs),
2376 (modest_mail_operation_refresh_folder):
2377 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2379 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2381 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2382 (modest_server_account_set_security):
2383 * src/modest-defs.h: Add comments explaining that our
2384 UI spec means TLS when it says Normal, so these do not look like errors.
2386 * src/modest-tny-account.c:
2387 (modest_tny_account_new_from_server_account): Use the new tinymail
2388 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2389 for TLS. This should fix projects.maemo.org bug NB#58460.
2391 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2393 * src/maemo/easysetup/modest-easysetup-wizard.c:
2394 (create_account): Correct the position of the gconf sanity check warning.
2395 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2396 of using the g_idle_add() hack, because this does not seem to be necessary
2397 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2398 caused by something other than maemo's gconf.
2399 This fixes projects.maemo.org bug #59022.
2401 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-account-mgr-helpers.c:
2404 (modest_account_mgr_get_default_account): Do not check that the account
2405 exists if there is no default account (NULL), to fix a runtime warning.
2407 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2409 * src/widgets/modest-folder-view.c: (update_model):
2410 Do not unref the treemodel before we have finished with it.
2411 This prevents a valgrind warning and an occasional crash at startup.
2413 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2415 * libmodest-dbus-client/libmodest-dbus-client.h:
2416 added libmodest_dbus_client_compose_mail()
2417 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2419 added functions needed for SendAsMail() functionality
2420 * src/maemo/modest-msg-edit-window.c:
2421 (modest_msg_edit_window_attach_file_noninteractive):
2422 non interactively attaching files to message edit window
2423 * src/widgets/modest-msg-edit-window.h:
2424 * tests/dbus_api/Makefile.am:
2425 added test_compose_mail.c
2426 * tests/dbus_api/test_compose_mail.c: (main):
2428 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2430 * src/modest-account-view.c:
2431 Fixed bug projects.maemo.org bug NB#59307
2433 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2435 * src/maemo/easysetup/modest-easysetup-wizard.c:
2436 (get_serverport_incoming), (on_before_next), (create_account):
2437 * src/maemo/modest-account-settings-dialog.c:
2438 (modest_account_settings_dialog_set_account_name):
2439 * src/maemo/modest-maemo-utils.c:
2440 (on_camel_account_get_supported_secure_authentication_status),
2441 (on_camel_account_get_supported_secure_authentication),
2442 (on_secure_auth_cancel),
2443 (modest_maemo_utils_get_supported_secure_authentication_methods):
2445 Implemented security authentication for settings and easysetup.
2447 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2449 * src/maemo/modest-main-window.c: (create_details_widget):
2450 Show the total size for memory card accounts too, instead of showing
2451 the name again. Fixes bug projects.maemo.org bug NB#59307.
2453 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2456 * src/modest-tny-simple-folder-store.c:
2457 * src/modest-tny-simple-folder-store.h: Removed.
2459 * src/modest-tny-local-folders-account.h
2460 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2461 for the local-folders maildir, with an extra TnyMergedFolder containing
2462 the folders of the per-account outbox store accounts.
2463 * src/modest-tny-account-store.c: (get_server_accounts):
2464 Add the outboxes to the special local folders account after creating it.
2466 * src/modest-tny-account.c:
2467 (modest_tny_account_new_for_local_folders): Create the derived
2468 account when creating the main local-folders account.
2470 * src/maemo/modest-main-window.c: (create_details_widget),
2471 (modest_main_window_set_contents_style):
2472 Adapted to the use of the derived account instead of the folder store.
2474 * src/modest-ui-actions.c:
2475 (modest_ui_actions_on_folder_selection_changed):
2476 * src/modest-ui-dimming-rules.c:
2477 (modest_ui_dimming_rules_on_new_folder):
2478 * src/widgets/modest-folder-view.c: (text_cell_data),
2479 (icon_cell_data), (filter_row), (update_model),
2480 (get_cmp_rows_type_pos):
2483 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2484 Do not get the priv struct, because no priv struct has been set,
2485 to avoid a runtime warning.
2487 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2488 #ifelse with #else, to fix a warning, to fix the build.
2491 2007-06-05 Christian Kellner <ckellner@openismus.com>
2493 * libmodest-dbus-client/libmodest-dbus-client.c:
2494 Fix small typo in doc (why do you always see them
2495 AFTER committing stuff?)
2498 2007-06-05 Christian Kellner <ckellner@openismus.com>
2500 * libmodest-dbus-client/libmodest-dbus-client.c:
2501 (libmodest_dbus_client_search):
2502 Initialize hit list with NULL. Also set folder list
2503 to "" if NULL was supplied.
2506 2007-06-03 Christian Kellner <ckellner@openismus.com>
2508 * libmodest-dbus-client/libmodest-dbus-client.c:
2509 (modest_search_hit_list_free):
2510 Make it save to call it with NULL.
2512 * src/dbus_api/modest-dbus-callbacks.c:
2513 * src/modest-search.c:
2514 Return full ModestSearchHits as the search result list not TnyHeader
2515 since can't be around withouth the correspoding TnyFolder.
2517 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2519 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2520 Added currently commented code to check for secure auth
2522 * src/maemo/modest-account-settings-dialog.c: (on_response),
2523 (save_configuration), (show_ok):
2524 Fixed projects.maemo.org bugs NB #59248 and #59251
2526 * src/maemo/modest-maemo-utils.c:
2527 (on_camel_account_get_supported_secure_authentication_status),
2528 (on_camel_account_get_supported_secure_authentication),
2529 (modest_maemo_utils_get_supported_secure_authentication_methods):
2530 * src/maemo/modest-maemo-utils.h:
2531 Moved get_supported_secure_authentication() method here to be able
2532 to use it from easysetup wizard.
2534 * src/modest-pair.c: (on_pair_compare_as_string):
2535 Should compare string with first part of pair and not
2536 strcmp pairs which will crash.
2538 * src/modest-protocol-info.c:
2539 (modest_protocol_info_protocol_is_store):
2540 * src/modest-protocol-info.h:
2541 Added modest_protocol_info_get_auth_protocol_name()
2543 2007-06-03 Armin Burgmeier <armin@openismus.com>
2545 * src/modest-mail-operation.c:
2546 (modest_mail_operation_get_msgs_full): Set priv->account also when
2547 only retrieving a single message. This avoids a crash when canceling
2550 (modest_mail_operation_notify_end): Do not explicitely remove the
2551 operation from the queue but only emit the progress_changed signal.
2552 The queue itself listens to that signal to remove the operation when
2553 it is finished. This reduces coupling and removes a potential deadlock
2554 when modest_mail_operation_notify_end() is called from the queue
2555 itself. If that is a problem performance-wise, I would suggest to
2556 implement a status-changed signal or something.
2558 * src/modest-mail-operation-queue.c: Make sure to never call a
2559 function from another file while the queue is locked. This (hopefully)
2560 fixes another deadlock when exiting the application while retrieving
2563 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2565 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2566 Fixed build if libogs is not available
2568 2007-06-03 Christian Kellner <ckellner@openismus.com>
2570 * libmodest-dbus-client/libmodest-dbus-client.h:
2571 * libmodest-dbus-client/libmodest-dbus-client.c:
2572 (libmodest_dbus_client_delete_message):
2573 Implement deletion of messages (Client side).
2575 (modest_search_hit_free),
2576 (modest_search_hit_list_free):
2577 Utility functions to free the result hits.
2579 * src/dbus_api/modest-dbus-api.h:
2580 * src/dbus_api/modest-dbus-callbacks.c:
2581 (on_delete_message),
2582 (modest_dbus_req_handler):
2583 Implement deletion of messages (Server side).
2585 * tests/dbus_api/test_search.c: (main):
2588 * tests/dbus_api/Makefile.am:
2589 * tests/dbus_api/test_delete_message:
2590 Add little test for the message deletion logic
2592 2007-06-03 Armin Burgmeier <armin@openismus.com>
2594 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2595 when the operation queue was not empty. projects.maemo.org bug
2598 2007-06-03 Armin Burgmeier <armin@openismus.com>
2600 * src/widgets/modest-account-view.c
2601 (on_account_default_toggled): Toggle default account column
2602 explicitely instead of waiting for gconf notification (which is
2603 currently ignored). This should fix projects.maemo.org bug NB#56910
2604 for now. It should probably be removed when gconf notifications are
2607 2007-06-03 Christian Kellner <ckellner@openismus.com>
2609 * libmodest-dbus-client/libmodest-dbus-client.c:
2610 Removed debugging spew.
2612 * src/dbus_api/modest-dbus-callbacks.c:
2613 Added debugging info.
2615 * src/modest-search.c:
2616 (modest_search_all_accounts):
2617 Use tny_account_store_get_accounts () on the account store
2618 to get all accounts which is the way to get all accounts.
2620 * tests/dbus_api/test_search.c: (main):
2621 Make it possible to supply the search term on the command line.
2623 2007-06-03 Christian Kellner <ckellner@openismus.com>
2625 * libmodest-dbus-client/libmodest-dbus-client.c:
2626 * libmodest-dbus-client/libmodest-dbus-client.h:
2627 Implement searching for mesages over raw dbus. (Client side)
2629 * src/dbus_api/Makefile.am:
2630 * src/dbus_api/modest-dbus-api.h:
2631 * src/dbus_api/modest-dbus-callbacks.c:
2632 * src/dbus_api/modest-dbus-callbacks.h:
2633 Search framework (Server side). Also implement on_idle_open_message().
2635 * src/maemo/modest-platform.c: (modest_platform_init):
2636 Prepare for raw dbus/osso rpc interaction.
2638 * src/modest-search.h:
2639 Changed minsize from unspecific guint to guint32.
2641 * src/modest-search.c:
2643 Added strange hack which magically made tnymail work.
2645 (modest_search_folder),
2646 (modest_search_account),
2647 (modest_search_all_accounts):
2648 Implement helper functions to search all accounts, specific account
2651 * tests/dbus_api/Makefile.am:
2652 * tests/dbus_api/test_open_message.c:
2653 Read url to open from commandline.
2655 * tests/dbus_api/test_search.c:
2656 Implement small test for dbus search stuff
2658 2007-06-02 Armin Burgmeier <armin@openismus.com>
2660 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2661 include account type and account title. This fixes projects.maemo.org
2664 * src/maemo/modest-account-view-window.c: Set a title for the window.
2666 2007-06-02 Armin Burgmeier <armin@openismus.com>
2668 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2669 incoming and outgoing server name based on email address and server
2670 types as long as the names have not been edited manually. This fixes
2671 projects.maemo.org bug NB#58671.
2673 2007-06-02 Armin Burgmeier <armin@openismus.com>
2675 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2676 server type cannot be changed in future to the incoming details page
2677 when creating an account. This fixes projects.maemo.org bug NB#59029.
2679 2007-06-02 Armin Burgmeier <armin@openismus.com>
2681 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2682 and assigned max width chars so that they wrap instead of being
2683 truncated. Fixes projects.maemo.org bug NB#56126.
2685 2007-06-02 Armin Burgmeier <armin@openismus.com>
2687 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2688 introductory note to the connection specific smtp servers dialog, as
2689 section 8.12 of the email UI specification requires. This fixes
2690 projects.maemo.org bug NB#59212.
2692 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2694 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2695 Check for running mail operations, and offer to cancel them, as per the UI
2696 spec. This fixes projects.maemo.org bug NB#59041 .
2697 However, I suspect that tinymail may still use the network connection
2698 in ways that we cannot detect or cancel. But it should at least adapt to
2699 changes fairly well.
2701 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2703 * src/modest-tny-account-store.c: (recreate_all_accounts),
2704 (get_cached_accounts), (get_server_accounts): Do more sensible
2705 ref-counting of the temporarily-cached outbox accounts list. This seems
2706 to fix a crash when entering the password when the password was wrong.
2708 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2710 * src/gnome/modest-main-window.c: (connect_signals):
2711 * src/modest-tny-account-store.c: (get_password),
2712 (modest_tny_account_store_alert): Added comments and clues and
2713 commented-out code about how we currently fail to deal with connection
2714 errors and wrong passwords, and how we should.
2716 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2718 * src/widgets/modest-retrieve-combo-box.c:
2719 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2720 This fixes projects.maemo.org bug NB#58472 .
2722 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2724 * src/maemo/easysetup/modest-easysetup-wizard.c:
2725 (create_page_complete_easysetup):
2726 (create_page_complete_custom): Correct the last commit,
2727 putting the correct sentences in the correct pages.
2729 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2731 * src/maemo/easysetup/modest-easysetup-wizard.c:
2732 (create_page_complete_custom): Show the second sentence of text
2733 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2736 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2738 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2739 Set the leave-on-server conf key by default. This fixes
2740 projects.maemo.org bug NB#59258 .
2742 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2744 * src/maemo/modest-account-view-window.c:
2745 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2746 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2749 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2751 * src/maemo/easysetup/modest-easysetup-wizard.c:
2752 (create_caption_new_with_asterisk):
2753 * src/maemo/modest-account-settings-dialog.c:
2754 (create_caption_new_with_asterisk):
2755 Uncomment the code to add the asterisk, because they are no longer in the
2756 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2757 (update_incoming_server_title): Add an asterisk here too.
2759 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2761 * src/maemo/modest-maemo-global-settings-dialog.c:
2762 (current_connection): Check that we are even connected before trying to
2763 get the current connection name, to prevent a warning.
2765 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2766 Change the comments because tny_maemo_conic_device_connect() is now meant to
2768 * src/modest-mail-operation.c:
2769 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2770 make sure we have a connection and fail if we can't connect.
2772 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2774 * src/maemo/modest-main-window.c:
2775 (on_account_store_connecting_finished): Do not try to get the
2776 connection ID if we are not really connected. I am surprised that
2777 this signal handler is called when we are not connected.
2779 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2781 * src/modest-error.h:
2782 * src/modest-ui-actions.c:
2783 (modest_ui_actions_get_msgs_full_error_handler):
2784 Renamed an enum, added comments, added an enum
2785 for retrieve-limit errors.
2787 * src/modest-mail-operation.c: (foreach_add_item),
2788 (internal_folder_observer_update), (update_account_thread),
2789 (modest_mail_operation_get_msgs_full):
2790 (modest_mail_operation_update_account),
2791 Added comments about how this works, and some code that should
2792 (but does not) check the retrieve-limit. See the TODO comment.
2794 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2796 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2797 Initialize help_id to fix the build. Warnings are good.
2799 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2801 * src/widgets/modest-hbox-cell-renderer.c:
2802 (modest_hbox_cell_renderer_append):
2803 * src/widgets/modest-vbox-cell-renderer.c:
2804 (modest_vbox_cell_renderer_append):
2805 Fix the last commit by doing an extra ref.
2807 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2809 * src/widgets/modest-hbox-cell-renderer.c:
2810 (modest_hbox_cell_renderer_append):
2811 * src/widgets/modest-vbox-cell-renderer.c:
2812 (modest_vbox_cell_renderer_append):
2813 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2814 to fix the build with Maemo Bora.
2815 However, there seems to be a remaining crash, probably due to reference
2818 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2820 * src/modest-tny-account.c:
2821 (modest_tny_account_new_for_local_folders):
2822 Use hildon_file_system_info_async_new() to get a better name for
2823 the memory card account, setting it as the account name.
2824 The timing seems to work, but this is probably
2825 not the best place to do this. See the TODO comment.
2826 * src/maemo/modest-main-window.c: (create_details_widget):
2827 * src/widgets/modest-folder-view.c: (text_cell_data):
2828 Use the tny account name instead of hardcoding a name.
2830 2007-05-30 Christian Kellner <ckellner@openismus.com>
2832 * src/modest-search.c: (modest_search):
2833 Correctly set part_search_func even if we have already parsed
2834 the query and thus a valid OgsTextSearcher object.
2836 2007-05-30 Christian Kellner <ckellner@openismus.com>
2839 Search and check for libogs.
2842 Incooparte the ogs build env.
2844 * src/modest-mime-part-search-stream.c:
2845 * src/modest-mime-part-search-stream.h:
2846 Removed since we do the real searching now in modest-search.c.
2848 * src/modest-search.c:
2849 * src/modest-search.h:
2850 Implement support for ogs. We use that if available and requested
2851 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2852 should now handle the corner case when the search term is spread
2853 across multiple reads.
2854 Also the logic in modest_search () was corrected to search all
2855 requested fields until one is found.
2857 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2859 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2861 * src/modest-init.h:
2862 * src/modest-init.c: Made modest_init_local_folders() take a
2863 path and be public so we can iniitialize maildir folders on
2866 * src/modest-local-folder-info.h:
2867 * src/modest-local-folder-info.c:
2868 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2870 * src/modest-tny-account.c:
2871 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2872 still means the standard local-folders path on the local volume.
2874 * src/modest-tny-account-store.c:
2875 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2876 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2877 all accounts when that happens.
2878 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2879 this too, so it shows up in the treeview.
2881 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2883 * src/maemo/modest-maemo-global-settings-dialog.c:
2884 (current_connection):
2885 * src/widgets/modest-global-settings-dialog.c:
2886 (current_connection_default):
2887 Use the enum values instead of 0, 1 and -1,
2888 to make the code clearer.
2890 * src/modest-account-mgr-helpers.c:
2891 (modest_account_mgr_get_connection_specific_smtp): Make this code
2894 * src/modest-runtime.h:
2895 * src/modest-runtime.c:
2896 Added modest_runtime_remove_all_send_queues().
2897 * src/maemo/modest-main-window.c:
2898 (on_account_store_connecting_finished): Recreate the send queues,
2899 using the appropriate transport accounts for this new connection.
2900 Some futher adapting might be needed if the old send queues are not
2901 automatically stopped at this point.
2903 * src/modest-tny-account-store.c: (get_server_accounts):
2904 Create the connection-specific transport accounts, so that they can
2905 be found later by their ID.
2907 * src/modest-tny-account.h:
2908 * src/modest-tny-account.c:
2909 Added modest_tny_account_new_from_server_account_name().
2910 modest_tny_account_new_from_server_account(): Do not create the
2911 send queues here, because they will be
2912 recreated anyway when the connection changes for the first time.
2914 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2916 * src/modest-local-folder-info.h:
2917 * src/modest-local-folder-info.c:
2918 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2919 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2920 tbox_folder): Take a modest account name instead of a server TnyAccount,
2921 so we can have per-modest-account rather than per-transport-account
2923 We must make sure that we change or recreate the exisitng send queues
2924 when the connection changes for connection-specific transport accounts.
2926 * src/modest-tny-account-store.c:
2927 (create_per_account_local_outbox_folders): Create outboxed per modest
2928 account, not per transport account.
2930 * src/modest-tny-account.h:
2931 * src/modest-tny-account.c:
2932 (modest_tny_account_get_special_folder): For outboxes, get the
2933 parent modest account name. The account is ignored for other folders.
2934 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2935 modest account name rather than a server TnyAccount.
2937 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2939 * src/modest-tny-account.c:
2940 (modest_tny_account_new_from_server_account):
2941 Call modest_runtime_get_send_queue() immediately after creating transport
2942 accounts, so that they start trying to send email from the outbox as soon
2943 as possible at startup. This is probably what we want.
2945 * src/modest-mail-operation.c: (update_account_thread):
2946 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2947 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2948 * src/modest-tny-send-queue.h:
2949 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2950 (modest_ui_actions_on_send):
2951 Added comments about how sending works, though it needs some more work.
2953 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2955 * src/modest-tny-account.c:
2956 (modest_tny_account_get_special_folder): Add TODO because this fails when
2957 the network is busy.
2958 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2959 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2960 Do not try to show this window when there is no active account. The UI
2961 specs does not tell us what to do in this case.
2963 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/Makefile.am:
2968 * src/widgets/Makefile.am: Some dist fixes.
2970 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2972 * src/maemo/modest-connection-specific-smtp-window.c:
2973 (on_button_edit): Make the code clearer, to prevent a double free.
2975 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2977 * src/maemo/modest-account-settings-dialog.c:
2978 (modest_account_settings_dialog_set_account_name),
2979 Check the connection-specific smtp servers checkbox if there are any.
2981 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2982 (modest_connection_specific_smtp_edit_window_init):
2983 Start with a suitable port number.
2985 * src/modest-account-mgr-helpers.h:
2986 * src/modest-account-mgr-helpers.c: Added
2987 modest_account_mgr_get_has_connection_specific_smtp().
2989 (modest_account_mgr_set_connection_specific_smtp),
2990 (modest_account_mgr_remove_connection_specific_smtp),
2991 (modest_account_mgr_get_has_connection_specific_smtp),
2992 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2993 connection-specific smtp server accounts in the account, rather than
2994 the server account conf dir.
2996 This fixes bug projects.maemo.org bug NB#58263 .
2998 * src/modest-tny-account-store.c:
2999 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3000 if there are no server accounts yet, to prevent an infinite loop when there
3001 are no accounts. Document that one must be called before the other.
3003 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3005 * src/modest-account-mgr-helpers.c:
3006 (modest_account_mgr_get_default_account): Make sure that at least
3007 one account is always the default, if there are any enabled accounts.
3008 This is just a sanity check that shouldn't be necessary.
3010 * src/modest-account-mgr-priv.c:
3011 (_modest_account_mgr_account_from_key): Unescape the conf key to
3012 get the real account name. For instance, this is an issue if a space
3013 was in the account name, which can happen because the account name
3014 is generated from the display name.
3015 (_modest_account_mgr_get_account_keyname): Always escape the
3017 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3018 Unescape the conf keys to get the real account names.
3020 For instance, previously the is-default radio button in the accounts
3021 list was not checked for any accounts at first. This fixes that,
3022 and might fix several similar bugs.
3024 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3026 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3027 Removed some debug printfs.
3029 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3031 Modest on-disk outbox directories are now here, for instance:
3032 $HOME/.modest/outboxes/<account-id-1>/outbox
3033 $HOME/.modest/outboxes/<account-id-2>/outbox
3035 $HOME/.modest/local-folders/outbox
3036 so we can have a separate outbox for each account.
3037 But they are shown as one outbox in the GtkTreeView, by using a
3038 TnyMergeFolder in a ModestTnySimpleFolderStore.
3041 * src/modest-tny-simple-folder-store.c:
3042 * src/modest-tny-simple-folder-store.h:
3043 Added ModestTnySimpleFolderStore, used to contain folders from
3044 other folder stores, such as other accounts.
3046 * src/modest-tny-outbox-account.h:
3047 * src/modest-tny-outbox-account.c:
3048 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3049 used for the per-account local outbox folders.
3051 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3052 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3053 only use this (internally) now for the non-outbox local folders.
3055 * src/modest-init.h:
3056 * src/modest-init.c: Added modest_init_one_local_folder(), for
3057 setting up the directory structure for each local folder.
3059 * src/modest-local-folder-info.c:
3060 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3061 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3063 * src/modest-local-folder-info.h:
3064 * src/modest-tny-account-store.c: (on_account_removed),
3065 (on_account_changed), (create_per_account_local_outbox_folders),
3066 (get_server_accounts), (modest_tny_account_store_get_accounts),
3067 (modest_tny_account_store_get_tny_account_by_account),
3068 (modest_tny_folder_store_is_virtual_local_folders):
3070 * src/modest-tny-account.h:
3071 * src/modest-tny-account.c:
3072 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3073 to create an on-disk per-account local outbox folder for each
3075 (create_per_account_local_outbox_folders): Create a local outbox folder
3076 for each transport account.
3077 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3078 for all local folders.
3080 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3081 instead of using g_object_get/set() directly. It is clearer.
3083 (modest_tny_folder_store_get_message_count),
3084 (modest_tny_folder_store_get_local_size
3085 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3086 because we now use these with non-acount folder stores.
3088 (modest_tny_account_get_special_folder),
3089 (modest_tny_account_new_from_server_account),
3090 (modest_tny_account_new_from_account):
3091 (recurse_folders): Adjust to the new outbox system.
3093 * src/modest-tny-folder.h:
3094 * src/modest-tny-folder.c:
3095 (modest_tny_folder_is_local_folder),
3096 (modest_tny_folder_get_local_folder_type),
3097 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3099 * src/widgets/modest-main-window.h:
3100 * src/maemo/modest-main-window.c: (create_details_widget),
3101 (modest_main_window_set_contents_style): Show details for any folder store,
3104 (modest_tny_folder_get_rules):
3105 Remove the const. C does not support constness enough for this.
3107 * src/modest-ui-actions.c:
3108 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3109 make all outboxes appear as one, in the usual local-folders tree node.
3111 (set_active_account_from_tny_account),
3112 (modest_ui_actions_on_folder_selection_changed):
3113 * src/widgets/modest-folder-view.c: (text_cell_data),
3114 (icon_cell_data), (filter_row),
3115 (add_account_folders_to_merged_folder),
3116 (add_account_folders_to_simple_folder_store), (),
3117 (get_cmp_rows_type_pos), (cmp_rows),
3118 (modest_folder_view_set_account_id_of_visible_server_account):
3119 Adjust to the new outbox system, using generic folder stores and folders
3120 in the GtkTreeModel.
3122 2007-05-23 Christian Kellner <ckellner@openismus.com>
3124 * src/modest-mail-operation.c:
3125 (modest_mail_operation_update_account):
3126 Use info->max_size instead of unintialized local var [small
3127 build fix]. (Added TODO to review that change since I don't
3130 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3132 * libmodest-dbus-client/libmodest-dbus-client.c:
3133 (libmodest_dbus_client_compose_mail): function added
3134 * src/dbus_api/modest-dbus-api.h:
3135 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3136 (on_compose_mail): Implementation of the SendAsMail functionality
3138 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3140 * src/modest-account-mgr.c:
3141 (modest_account_mgr_add_server_account): Set the secure-connection
3142 conf key for transport accounts as well as store accounts. I don't know
3143 why the if was there. For instance, this makes sure that we use SSL
3144 for the gmail preset from the easysetup wizard.
3146 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3148 * src/gnome/modest-main-window.c:
3149 (on_account_store_connecting_finished), (connect_signals):
3150 * src/maemo/modest-main-window.c:
3151 (on_account_store_connecting_finished), (connect_signals),
3152 (modest_main_window_new):
3153 Handle TnyAccountStore::connecting-finished instead of
3154 TnyDevice::connection-changed, because we cannot actually perform
3155 operations on accounts until TnyAccountStore has itself responded to
3156 the TnyDevice::connection-changed signal. This prevents a GError from
3158 Do not try to update at startup, because we (at least on scratchbox)
3159 already do an update at startup when the device goes online.
3160 This prevents a GError from tinymail.
3161 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3162 Added TODO about stopping simultaneous operations.
3164 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3166 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3167 * src/modest-mail-operation-queue.c:
3168 (modest_mail_operation_queue_remove):
3169 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3170 about where they happened.
3172 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3174 * src/modest-ui-actions.c:
3175 (modest_ui_actions_on_password_requested): Make sure that the remember
3176 output parameter is always TRUE.
3178 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3180 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3181 Show a OK/Cancel dialog if the error is a question, though we still do not
3182 know anything more about what we are asking the user.
3183 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3184 Fix an uninitialized variable (helper). This is a logic error, however.
3186 2007-05-21 Christian Kellner <ckellner@openismus.com>
3188 * src/modest-search.h:
3189 Correct bit shifting in the ModestSearchFlags enum.
3191 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3193 * src/modest-tny-account.c:
3194 (modest_tny_account_new_from_server_account): Do not use the lsub and
3195 check-all hard-coded IMAP options when using POP.
3197 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3199 * src/modest-tny-account.c:
3200 (modest_tny_account_new_from_server_account):
3201 Use NULL for the secure-auth method for POP when Password auth has been
3202 specified by the user, as we already do for IMAP. "auth=Login" causes
3203 an error from camel or the server.
3205 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3207 * src/maemo/modest-account-settings-dialog.c:
3208 (create_page_account_details),
3209 (modest_account_settings_dialog_set_account_name):
3210 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3211 for the leave-on-server checkbox, rathr than just the checkbox, when
3212 the protocol is not POP.
3214 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3216 * src/widgets/modest-account-view.c:
3217 * src/widgets/modest-account-view.h:
3218 Added modest_account_view_select_account() which will be useful later
3219 to asynchronously re-select the edited account.
3221 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3223 * src/maemo/modest-account-settings-dialog.c:
3224 (modest_account_settings_dialog_set_account_name):
3225 Automatically choose the port numbers based on the secure authentication
3226 methods, if they have not been chosen before.
3227 This fixes projects.maemo.org bug NB#56273 .
3229 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/modest-main-window-ui.h:
3232 * src/modest-ui-actions.c:
3233 * src/modest-ui-actions.h:
3234 Connect the Tools/SMTP Servers menu item to
3235 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3236 SMTP servers dialog, as in the UI specification and saves changes when it
3237 is closed. This fixed projects.maemo.org bug NB#56305 .
3239 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3241 * src/maemo/modest-connection-specific-smtp-window.c:
3242 (modest_connection_specific_smtp_window_init):
3243 Use gtk_window_set_default_size() to make this window big enough, so
3244 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3246 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3248 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3249 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3250 (modest_connection_specific_smtp_edit_window_init),
3251 Do not try to connect to a combobox signal before the combobox exists.
3252 This fixes the cras in projects.maemo.org bug NB#56288 .
3253 (modest_connection_specific_smtp_edit_window_get_settings):
3254 Remove the server_account_name parameter which was being checked for NULL
3255 though it was not used.
3257 * src/maemo/modest-connection-specific-smtp-window.c:
3258 (modest_connection_specific_smtp_window_fill_with_connections),
3259 (on_button_edit), (modest_connection_specific_smtp_window_init):
3260 Correct the number of treemodel columns to prevent a warning.
3261 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3262 libconic does not work.
3264 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3266 * src/modest-tny-account.c:
3267 (modest_tny_account_new_from_server_account):
3268 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3269 SMTP when "None" was chosen by the user. However, with my SMTP server that
3270 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3273 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3275 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3276 to explain the memory management issue with the ID in the ModestPair.
3278 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3279 (add_sending_page), (modest_account_assistant_finalize):
3280 * src/gnome/modest-gnome-global-settings-dialog.c:
3281 (create_updating_page), (create_composing_page):
3282 * src/gnome/modest-msg-edit-window.c: (get_transports),
3283 (init_window), (modest_msg_edit_window_finalize),
3284 (modest_msg_edit_window_get_msg_data):
3285 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3286 * src/gnome/modest-transport-widget.c:
3287 (modest_transport_widget_finalize), (smtp_configuration):
3288 * src/maemo/modest-maemo-global-settings-dialog.c:
3289 (create_updating_page), (create_composing_page):
3290 * src/maemo/modest-msg-edit-window.c: (get_transports),
3291 (init_window), (modest_msg_edit_window_finalize),
3292 (modest_msg_edit_window_get_msg_data),
3293 (modest_msg_edit_window_free_msg_data):
3294 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3295 (modest_store_widget_finalize):
3296 * src/maemo/modest-transport-widget.c:
3297 (modest_transport_widget_finalize), (smtp_configuration):
3298 * src/modest-main.c: (send_mail):
3299 * src/widgets/modest-combo-box.h:
3300 * src/widgets/modest-global-settings-dialog-priv.h:
3301 * src/widgets/modest-global-settings-dialog.c:
3302 (modest_global_settings_dialog_finalize):
3303 * src/widgets/modest-msg-edit-window.h:
3304 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3305 as long as the combo box, to prevent use of freed memory for the ID.
3307 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3309 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3310 get_accounts(), to make this clearer. Do not check for the enabled gconf
3311 key, because we do not use this for server accounts (at least, not yet).
3312 This allows us to send email again.
3314 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3316 * src/maemo/modest-platform.c:
3317 (on_modest_conf_update_interval_changed), (modest_platform_init):
3318 Only respond to this particular key change. All these strcmp()s cannot be
3321 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3323 * src/maemo/modest-maemo-global-settings-dialog.c:
3324 (current_connection): Prevent a crash in scratchbox when
3325 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3326 * src/maemo/modest-platform.c:
3327 (on_modest_conf_update_interval_changed), (modest_platform_init):
3328 Get the update interval from gconf and reset it when the gconf key changes.
3330 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3332 * src/modest-protocol-info.c:
3333 * src/modest-protocol-info.h: Adde enum-specific get functions,
3334 instead of using a ModestProtocolType enum parameter.
3336 * src/gnome/modest-account-assistant.c:
3337 * src/gnome/modest-store-widget.c:
3338 * src/gnome/modest-store-widget.h:
3339 * src/gnome/modest-transport-widget.c:
3340 * src/gnome/modest-transport-widget.h:
3341 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3342 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3343 * src/maemo/easysetup/modest-easysetup-wizard.c:
3344 * src/maemo/modest-account-settings-dialog.c:
3345 * src/maemo/modest-account-settings-dialog.h:
3346 * src/maemo/modest-store-widget.c:
3347 * src/maemo/modest-store-widget.h:
3348 * src/maemo/modest-transport-widget.c:
3349 * src/maemo/modest-transport-widget.h:
3350 * src/modest-account-mgr-helpers.c:
3351 * src/modest-account-mgr-helpers.h:
3352 * src/modest-account-mgr.c:
3353 * src/modest-account-mgr.h:
3354 * src/modest-tny-account.c:
3355 * src/modest-tny-folder.c:
3356 * src/widgets/modest-account-view.c:
3357 * src/widgets/modest-retrieve-combo-box.c:
3358 * src/widgets/modest-retrieve-combo-box.h:
3359 * src/widgets/modest-secureauth-combo-box.c:
3360 * src/widgets/modest-serversecurity-combo-box.c:
3361 * src/widgets/modest-serversecurity-combo-box.h:
3362 * tests/check_account-mgr.c:
3363 Use the specific functions, and use the re-renamed enum values for GNOME too.
3365 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3367 * src/modest-pair.h:
3368 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3369 so we can get the second based on the first.
3371 * src/maemo/modest-account-settings-dialog.h:
3372 * src/maemo/modest-account-settings-dialog.c:
3373 Added get_supported_secure_authentication_methods(), though it is mostly
3374 commented-out for now until the necessary API is committed to tinymail.
3375 (modest_account_settings_dialog_set_account_name),
3376 (save_configuration): Request the supported authentication methods from the
3377 server, so we can choose a working method.
3379 * src/modest-tny-account-store.h:
3380 * src/modest-tny-account-store.c:
3381 (modest_tny_account_store_get_session): Rename from
3382 tny_account_store_get_session().
3384 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3386 * src/modest-protocol-info.h: Split the ModestProtocol enum
3387 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3388 There was no need to have these unrelated values in one enum.
3390 * src/: many files: Adapted to changed enum. This makes the code a bit
3391 clearer, and the compiler could catch some errors.
3393 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3395 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3396 Show the detailed internal camel error message when an error happens
3397 during the configuration, so that our testers can give us more clues.
3398 For instance, in projects.maemo.org bug NB#56910 .
3400 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3402 * src/modest-tny-account.c:
3403 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3404 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3406 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3408 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3409 * src/maemo/modest-account-settings-dialog.c:
3410 (modest_account_settings_dialog_set_account_name),
3411 (save_configuration): For the incoming secure authentication checkbox,
3412 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3413 the UI specification. PLAIN does not seem to be supported for most IMAP
3414 servers anyway, and I am not sure what it would mean.
3415 However, we probably need to discover which of the secure-authentication
3416 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3417 * src/modest-account-mgr-helpers.c:
3418 (modest_account_mgr_get_server_account_data):
3420 * src/modest-tny-account.c:
3421 (modest_tny_account_new_from_server_account):
3422 Use tny_account_set_mech() to set secure-authentication methods,
3423 with some special-casing for IMAP, based on my observations of how
3426 * src/modest-account-mgr-helpers.h:
3427 * src/modest-account-mgr.c:
3428 * src/modest-defs.h: Comment that the URI is only used for local folders.
3430 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3432 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3433 parameter const, just to be neat.
3434 * src/modest-text-utils.c: (modest_text_utils_inline):
3435 End g_strconcat() with NULL, as its documentation says. This is almost
3436 certainly the cause of my crash at startup on the device. Interestingly,
3437 valgrind doesn't tell us about these errors.
3439 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3441 * scripts/build-packages: Added more precise comments about how to use
3442 this script, though I still get this error:
3443 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3444 error building tinymail
3446 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3448 * src/maemo/modest-main-window.c: (on_account_update):
3449 Very slight cleanup, hoping to make it simpler to discover what causes
3450 a crash here sometimes.
3452 * src/modest-tny-account.c:
3453 (modest_tny_account_new_from_server_account): Set the port. Added
3454 comments about the options and a TODO comment because I need to find out
3455 how to specify the secure authentication method.
3457 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3459 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3460 changed CFlags paths form modest to libmodest
3462 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3464 * src/modest-account-mgr-helpers.c:
3465 (modest_account_mgr_get_server_account_data),
3466 (modest_account_mgr_free_server_account_data):
3467 * src/modest-account-mgr-helpers.h:
3468 * src/modest-account-mgr.c:
3469 (modest_account_mgr_add_server_account):
3470 * src/modest-defs.h:
3471 * src/modest-tny-account.c:
3472 (modest_tny_account_new_from_server_account):
3473 Determine the options for tny_camel_account_add_option() here,
3474 based on the settings, rather than storing them directly in gconf.
3476 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3478 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3479 Show a more friendly error dialog now that we expect (from the tinymail
3480 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3482 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3484 * src/maemo/modest-main-window.c: (on_account_update): Check that
3485 account_name is not NULL, to prevent a crash at startup that I am
3486 seeing on the N800. I do wonder why it is NULL.
3488 * src/maemo/easysetup/modest-easysetup-wizard.c:
3489 (create_page_user_details):
3490 * src/maemo/modest-account-settings-dialog.c:
3491 (create_page_user_details), (create_page_outgoing):
3492 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3493 (modest_connection_specific_smtp_edit_window_init):
3494 * src/modest-ui-actions.c:
3495 (modest_ui_actions_on_password_requested):
3496 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3497 might do something useful with the on-screen keyboard.
3499 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3501 * src/maemo/modest-main-window.c: (on_account_update):
3502 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3503 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3505 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3507 * src/modest-tny-account-store.c: (on_account_changed):
3508 Correct the signature of this signal handler.
3510 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3512 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3513 Show a HildonNote instead of a GtkDialog for Maemo.
3515 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3517 * src/widgets/modest-account-view.h:
3518 * src/widgets/modest-account-view.c: (on_account_changed),
3519 (on_account_removed). Added a boolean flag, set/unset by
3520 modest_account_view_block_conf_updates(),
3521 modest_account_view_unblock_conf_updates() to prevent unnecessary
3522 updates, but this is not very useful because the gconf notifications are
3523 so delays (maybe only on Maemo Bora).
3524 So auto-updating is turned off, and these functions do an explicit
3525 update when necessary.
3526 However, something else is still doing too much work when adding/removing
3527 accounts, probably in another part of the application.
3529 * src/maemo/modest-account-view-window.c:
3530 (on_delete_button_clicked), (on_edit_button_clicked),
3531 (on_new_button_clicked): Use the new functions.
3533 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3535 * src/modest-account-mgr-helpers.c:
3536 (modest_account_mgr_set_first_account_as_default):
3537 Sort the list of names alphabetically-by-title, so we choose the first one
3539 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3540 alphabetically by the title.
3542 This fixes projects.maemo.org bug NB#56418 .
3544 * src/modest-account-mgr-priv.c:
3545 (_modest_account_mgr_account_from_key):
3546 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3547 avoid a valgrind error, and possible random behaviour.
3549 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3551 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3552 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3553 tinymail documentation to say that this can be expected.
3554 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3555 pretty, and should not happen, but I would prefer to know when it does.
3557 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3559 * configure.ac: When using the older hildon version, probably on Bora,
3560 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3562 * src/widgets/modest-attachment-view.c:
3563 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3566 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3568 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3569 Implemented the prototype. Can be tested with
3570 tests/dbus_api/test_open_message:
3572 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3574 * src/modest-tny-account-store.c:
3575 (modest_tny_account_store_instance_init), (get_password):
3576 * src/modest-ui-actions.c:
3577 (modest_ui_actions_on_password_requested):
3578 Do not store the password in gconf, because this function is called
3579 for non-remembered passwords. Actually use the cached (in the hash map)
3580 password instead of releasing it.
3581 The password will now not be remembered if it is asked via the protected
3582 password dialog, as per the UI spec.
3584 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3586 * src/modest-defs.h:
3587 * src/modest-account-mgr-helpers.h:
3588 * src/modest-account-mgr-helpers.c:
3589 Added modest_server_account_get_username_has_succeeded(),
3590 modest_server_account_set_username_has_succeeded().
3591 (modest_server_account_set_username),
3592 Reset the has-succeeded flag if the username changes.
3594 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3595 * src/maemo/modest-connection-specific-smtp-window.c:
3596 (modest_connection_specific_smtp_window_save_server_accounts):
3597 Use modest_server_account_set_username() instead of using
3598 modest_conf_set_string() directly, so that the has-succeeded flag is always
3601 * src/modest-ui-actions.c:
3602 (modest_ui_actions_on_password_requested): Dim the username entry if
3603 the username has ever worked, as per the UI spec.
3605 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3607 * src/modest-tny-account-store.c: (get_password):
3608 * src/modest-ui-actions.c:
3609 (modest_ui_actions_on_password_requested):
3610 Allow the username to be changed too, though there is more work to
3611 be done on exactly how this behaves.
3613 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3615 * src/modest-account-mgr-helpers.h:
3616 * src/modest-account-mgr-helpers.c:
3617 Added modest_account_mgr_get_display_name(),
3618 modest_server_account_get_username(),
3619 modest_server_account_set_username(),
3620 modest_server_account_set_password(),
3621 modest_server_account_get_hostname() functions so we do not need to
3622 use the conf API directly.
3624 * src/maemo/modest-main-window.c: (connect_signals):
3625 Actually connect ot the ModestAccountStore::request-password signal,
3626 so that we show the dialog when the password is requested by Tinymail,
3627 for isntance if it is empty.
3629 * src/modest-marshal.list:
3630 * src/modest-tny-account-store.c:
3631 (modest_tny_account_store_class_init), (get_password),
3632 (modest_tny_account_store_alert):
3633 * src/modest-tny-account-store.h:
3634 * src/modest-ui-actions.h:
3635 * src/modest-ui-actions.c:
3636 (modest_ui_actions_on_password_requested):
3637 Change the signal parameters, so it is obvious that we are providing
3638 the non human-readable server name, and receiving both the username
3639 and password, though changing of the username is not yet implemented.
3640 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3641 for the GNOME version.
3643 This should fix the projects.maemo.org bug NB#56209, though it does not
3644 work on Bora, because the gconf_client_get() for the password fails
3645 immediately after we save it with gconf_client_set().
3647 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3650 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3651 caused an undefined symbol error:
3652 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3654 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3656 * src/modest-tny-account-store.c:
3657 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3658 using a GError instead of a string message, so we can translate it in
3661 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3663 * src/maemo/modest-address-book.c:
3664 (modest_address_book_check_names):
3665 * src/maemo/modest-msg-view-window.c:
3666 (modest_msg_view_window_clipboard_owner_change):
3667 * src/modest-init.c: (modest_init_init_ui):
3668 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3669 (update_folders_cb), (modest_mail_operation_update_account):
3670 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3671 (modest_ui_actions_on_msg_attachment_clicked),
3672 (modest_ui_actions_on_msg_recpt_activated):
3673 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3674 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3675 (modest_msg_view_search_next):
3676 * src/widgets/modest-recpt-editor.c:
3677 (modest_recpt_editor_on_button_release_event),
3678 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3679 g_message(). At this point we should only be seeing interesting errors on
3680 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3682 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3684 (modest_wizard_dialog_force_title_update):
3685 * src/maemo/easysetup/modest-wizard-dialog.h:
3686 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3687 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3688 can update the title when appropriate. Otherwise the title is wrong if the
3689 pages are added after adding the notebook to the dialog.
3690 This must be a problem in HildonWizardDialog too.
3691 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3693 * src/maemo/easysetup/modest-easysetup-wizard.c:
3694 (create_subsequent_customsetup_pages),
3695 (create_subsequent_easysetup_pages):
3696 Call modest_wizard_dialog_force_title_update() so that the title is
3697 correct even with GTK+ < 2.10.
3698 This fixes projects.maemo.org bug NB#56145 .
3700 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3702 * src/maemo/modest-platform.c:
3703 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3704 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3707 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3709 * src/widgets/modest-window.h:
3710 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3711 and modest_window_save_state(), which invokes it.
3713 * src/widgets/modest-window-mgr.h:
3714 * src/widgets/modest-window-mgr.c:
3715 Added modest_window_mgr_save_state_for_all_windows(), which calls
3716 the save_state vfunc on all registered windows, if implemented.
3718 * src/gnome/modest-msg-edit-window.c:
3719 * src/gnome/modest-msg-view-window.c:
3720 * src/maemo/modest-msg-edit-window.c:
3721 * src/maemo/modest-msg-view-window.c:
3722 * src/maemo/modest-main-window.c:
3723 Specify the existing save_settings functions as implementations of
3724 ModestWindow::save_state_func().
3726 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3727 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3728 enabling hibernation, for instance.
3730 We may need to do the same thing for restoring settings.
3733 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3735 * src/widgets/modest-window-mgr.c:
3736 * src/widgets/modest-window-mgr.h:
3737 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3738 modest_window_mgr_get_hibernation_is_prevented().
3740 * src/maemo/modest-main-window.c:
3741 (on_hildon_program_is_topmost_notify): Prevent hibernation
3742 (possible when the application goes to the background in the WM),
3743 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3745 * src/maemo/easysetup/modest-easysetup-wizard.c:
3746 (modest_easysetup_wizard_dialog_init):
3747 * src/maemo/modest-account-settings-dialog.c:
3748 (modest_account_settings_dialog_init):
3749 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3750 (modest_connection_specific_smtp_edit_window_init):
3751 * src/maemo/modest-connection-specific-smtp-window.c:
3752 (modest_connection_specific_smtp_window_init):
3753 * src/maemo/modest-signature-editor-dialog.c:
3754 (modest_signature_editor_dialog_init):
3755 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3756 prevent hibernation while any of these account settings dialogs are open.
3758 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3760 * src/maemo/Makefile.am:
3761 * src/maemo/modest-osso-state-saving.c:
3762 * src/maemo/modest-osso-state-saving.h: Added
3763 modest_osso_load_state() and modest_osso_save_state() though they do
3764 nothing now. They should iterate through all the open windows and load/save
3766 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3767 save state when closing.
3769 * src/maemo/modest-main-window.c:
3770 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3771 Add a notification handler for the HildonProgram::is-topmost property,
3772 so we can allow hibernation when the application goes into the background.
3773 But we still need to detect when the accounts setup windows are open so
3774 we can stop hibernation when they are open.
3775 To do this, I also added the main window the HildonProgram. This might have
3776 other side-effects/benefits, and should maybe be done for other windows.
3778 * src/maemo/modest-osso-autosave-callbacks.h:
3779 * src/maemo/modest-osso-autosave-callbacks.c:
3780 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3781 though it does not do anything yet, and we might never need this to do
3782 anything. For instance, we already save drafts.
3784 * src/maemo/modest-platform.c: (modest_platform_init):
3785 Specify the libosso auto-save callback.
3787 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3789 * src/maemo/modest-platform.c:
3790 (modest_platform_set_update_interval):
3791 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3792 aparently stays valid between application instances, so we can use this
3793 to remove and reset it later. According to a maemo-developers email from
3796 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3798 * configure.ac: Depend on libalarm for Maemo.
3800 * src/dbus_api/modest-dbus-api.h:
3801 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3802 (on_send_receive), (modest_dbus_req_handler):
3803 Handle a SEND_RECEIVE D-Bus method.
3805 * libmodest-dbus-client/libmodest-dbus-client.c:
3806 (libmodest_dbus_client_send_and_receive):
3807 * libmodest-dbus-client/libmodest-dbus-client.h:
3808 Add C convenience functions for calling the new D-Bus method.
3810 * src/modest-platform.h:
3811 * src/gnome/modest-platform.c:
3812 * src/maemo/modest-platform.c:
3813 Added modest_platform_set_update_interval(), which uses the
3814 alarmd API on Maemo.
3815 (modest_platform_init),
3816 Call modest_platform_set_update_interval(), using a hard-coded
3817 interval for now (until the global settings dialog is implemented),
3818 though I am not sure that this makes sense yet.
3820 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3822 * src/dbus_api/modest-dbus-callbacks.c:
3823 (modest_osso_cb_hw_state_handler):
3824 * src/dbus_api/modest-dbus-callbacks.h:
3825 * src/maemo/modest-platform.c: (modest_platform_init):
3826 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3827 in case this has some effect on the ability for Maemo to ping the
3830 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3832 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3833 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3834 warning. It is probably a logic error, but I need to fix the build.
3836 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3838 * src/modest-account-mgr.h:
3839 * src/modest-account-mgr.c:
3840 (modest_account_mgr_account_names): Add a gboolean enabled_only
3841 parameter, so we can get lists of onlt the enabled accounts.
3843 (modest_account_mgr_add_account),,
3844 (modest_account_mgr_account_with_display_name_exists):
3845 * src/maemo/modest-msg-edit-window.c: (get_transports):
3846 * src/modest-account-mgr-helpers.c:
3847 (modest_account_mgr_set_first_account_as_default):
3848 * src/modest-init.c: (init_default_account_maybe):
3849 * src/modest-tny-account-store.c: (get_accounts):
3850 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3851 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3852 * tests/check_account-mgr.c: (START_TEST):
3853 Provide the extra parameter, as appropriate.
3855 * src/widgets/modest-account-view.c: (update_account_view):
3856 Do not show disabled accounts (meaning that there is no way to
3857 enable/disable accounts in the UI (the feature is not in our UI
3858 specification), so we can use this internally only to mark unfinished
3859 or temporary account data.
3861 * src/maemo/easysetup/modest-easysetup-wizard.c:
3862 (create_account): Add boolean enable parameter, so we can specify FALSE
3863 to create the temporary account.
3864 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3865 (on_before_next): When finishing, when there is a temporary account, just
3867 Also, use a timeout to delay the showing of the dialog until gconf is likely
3868 to return correct information, due to a maemo gconf bug that is fixed in
3869 osso 1.1, but not yet in Bora.
3870 However, the dialog stays on screen after it is destroyed.
3872 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3873 for invalid data when cancelling. Use a hildon note instead of a dialog
3874 to complain about invalid data. Do not show the account-saved note if the
3875 account is disabled (a temporary account that will not really be saved for use
3878 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3880 * src/modest-account-mgr-helpers.h:
3881 * src/modest-account-mgr-helpers.c:
3882 Added modest_account_mgr_unset_default_account(),
3883 Added modest_account_mgr_set_first_account_as_default().
3885 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3886 If it was the default account, unset the default account name.
3888 * src/maemo/modest-account-view-window.c:
3889 (on_delete_button_clicked): If it was the default account,
3890 set the first remaining account as the default instead.
3892 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3893 a NULL account or a NULL default account, to prevent a crash. This should
3894 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3897 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3899 * src/widgets/modest-recpt-editor.c:
3900 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3901 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3902 TODO comment for this. This fixes the build.
3904 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3905 be the best place for it. This will in future update all auto-update accounts,
3906 rather than just the current/default account, when that gconf key exists.
3907 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3908 if there are no accounts, before calling do_send_receive().
3909 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3911 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3912 * src/maemo/modest-main-window-ui.h:
3913 * src/maemo/modest-main-window.c: (on_connection_changed),
3914 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3915 directly, becaue the signal handler does more.
3917 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3919 * src/modest-account-mgr-helpers.c:
3920 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3921 for the case that the account does not exist.
3923 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3924 (equivalent to the modest account name) rather than the tinymail account name
3925 (equivalent to the modest account title - human readable) to get the account data.
3926 Check for null account data to prevent the crash, and add a TODO comment saying that
3927 this needs fixing because it is using the server account name instead of the account name.
3929 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3931 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3932 * src/maemo/modest-account-settings-dialog.c: (show_error),
3934 Use hildon_note_new_information() for informative and error messages,
3935 which seems to be expected for Maemo applications (no documentation that I know of
3936 says this). I am surprised that there is no distinction between info and error
3939 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3941 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3942 it is easy to find where this is used.
3944 * src/maemo/easysetup/modest-easysetup-wizard.c:
3945 (create_page_welcome), (create_page_account_details),
3946 (create_page_user_details), (create_page_complete_easysetup),
3947 (create_page_custom_incoming), (create_page_custom_outgoing),
3948 (create_page_complete_custom):
3949 * src/maemo/modest-account-settings-dialog.c:
3950 (create_page_account_details), (create_page_user_details),
3951 (create_page_incoming), (create_page_outgoing):
3952 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3953 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3954 (modest_connection_specific_smtp_edit_window_init):
3955 * src/maemo/modest-connection-specific-smtp-window.c:
3956 (modest_connection_specific_smtp_window_init):
3957 * src/maemo/modest-signature-editor-dialog.c:
3958 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3959 and scrolling policy as per the Email Application Layout Guide, if I have
3962 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3964 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3965 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3966 which were empty, because these vfuncs have been removed from TnyAccountStore.
3967 This fixes the build.
3969 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3971 * src/maemo/modest-main-window.c:
3972 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3973 showing/hiding it. Added TODO because it probably should not be NULL.
3974 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3975 because unnecessary g_warnings() make degugging difficult.
3977 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3979 * src/maemo/modest-msg-edit-window.c:
3980 (modest_msg_edit_window_select_color),
3981 (modest_msg_edit_window_select_background_color): 2 const corrections and
3982 moving 2 #endifs before closing brackets, to fix the build.
3984 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3986 * src/maemo/easysetup/modest-easysetup-wizard.h:
3987 * src/maemo/easysetup/modest-easysetup-wizard.c:
3988 (modest_easysetup_wizard_dialog_finalize),
3989 (on_button_edit_advanced_settings), (create_page_complete_custom),
3990 (on_response), (create_account):
3991 Implement the Advanced Settings edit button, by saving the account information,
3992 for the Advanded Settings dialog to use directly from gconf, and removing it
3993 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3994 Bug #5533 in the projects.maemo.org bugzilla.
3996 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3998 * src/maemo/modest-msg-view-window.c:
3999 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4000 when opening a message window.
4002 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4004 * src/maemo/easysetup/modest-easysetup-wizard.c:
4005 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4008 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4009 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4010 gconf settings. I probably added more checks than necessary, but that is safer.
4012 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4013 variable to fix the build, but this seems to be used when it is still NULL.
4015 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4017 * src/modest-platform.h:
4018 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4019 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4020 * src/modest-main.c: Implement this function so we can avoid using
4021 maemo-specific API from cross-platform code.
4023 * src/modest-tny-account-store.c:
4024 (get_smtp_specific_transport_account_for_open_connection):
4025 * src/modest-ui-actions.c: (check_for_connection),
4026 (modest_ui_actions_on_item_not_found):
4027 Use modest_platform_connect_and_wait() and put #idefs around other
4028 maemo-specific code, because only maemo currently has a way to
4029 identify connection names.
4031 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4033 * src/modest-tny-account-store.h:
4034 * src/modest-tny-account-store.c:
4035 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4036 the connection-specific SMTP server settings in the configuration.
4038 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4040 * src/maemo/modest-main-window.c: (on_connection_changed),
4042 * src/modest-main.c: (main), (start_ui), (send_mail):
4043 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4044 that is what is intended.
4046 * src/modest-ui-actions.c: (action_send), (action_receive),
4047 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4048 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4049 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4050 SMTP server is used when it is specified.
4052 (modest_ui_actions_on_send_receive):
4053 Check that a connection is open before proceeding.
4054 Receive and then send, instead of vice-versa, as per the specification.
4056 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4058 * src/modest-mail-operation.c:
4059 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4060 though I guess it should be something other than NULL.
4062 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4064 * src/maemo/easysetup/modest-easysetup-wizard.c:
4065 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4066 combo twice, to avoid an g_warning and to make it visible again.
4067 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4068 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4069 (already intended) dereference when detaching, because we then recreate the menu.
4070 But I am not sure why the warning was happening, and it is possible that this is a memory
4073 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4075 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4076 and uri_parse_mailto() utility functions.
4077 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4079 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4081 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4083 * src/dbus_api/modest-dbus-api.h:
4084 * src/dbus_api/modest-dbus-callbacks.c:
4085 Use an idle callback to execute the modest code in the application's own thread.
4086 Remove the helloworld example method.
4087 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4088 parsed, and the open-message method is not implemented because this is not yet implemented in
4090 * libmodest-dbus-client/libmodest-dbus-client.c:
4091 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4092 (libmodest_dbus_client_open_message):
4093 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4095 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4096 body without crashing.
4098 * tests/dbus_api/Makefile.am:
4099 * tests/dbus_api/test_mail_to.c:
4100 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4102 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4104 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4105 Added file to fix the build. Sorry.
4107 * src/dbus_api/Makefile.am:
4108 * src/dbus_api/modest-dbus-api.h:
4109 * src/dbus_api/modest-dbus-callbacks.h:
4110 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4111 (modest_dbus_req_handler):
4112 Put constants in a separate header so it can be reused by the
4113 client library, without duplication
4115 * libmodest-dbus-client/Makefile.am:
4116 * libmodest-dbus-client/libmodest-dbus-client.c:
4117 (libmodest_dbus_client_call_helloworld),
4118 (libmodfest_dbus_client_send_mail),
4119 (libmodfest_dbus_client_mailto),
4120 (libmodfest_dbus_client_open_message):
4121 * libmodest-dbus-client/libmodest-dbus-client.h:
4122 (Partly) Implement a send_mail D-Bus method.
4124 * tests/dbus_api/Makefile.am:
4125 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4126 the send_email D-Bus method.
4128 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4132 * libmodest-dbus-client/Makefile.am:
4133 * libmodest-dbus-client/libmodest-dbus-client.c:
4134 * libmodest-dbus-client/libmodest-dbus-client.h:
4135 * tests/dbus_api/Makefile.am:
4136 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4137 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4139 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4141 * src/maemo/easysetup/modest-easysetup-wizard.c:
4142 (create_page_account_details):
4143 * src/maemo/modest-account-settings-dialog.c:
4144 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4145 widgets, because this might not be the default in future versions of the Maemo GTK+.
4146 However, I can not not get capitalization to work even in a simple test case.
4148 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4150 * src/maemo/easysetup/modest-easysetup-wizard.c:
4151 (create_page_custom_incoming), (create_page_custom_outgoing):
4152 * src/maemo/modest-account-settings-dialog.c:
4153 (create_page_account_details), (create_page_incoming),
4154 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4155 instead of using gtk_check_button_with_label(), so they are aligned like the other
4156 widgets, as per the UI spec.
4158 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4160 * src/maemo/easysetup/modest-easysetup-wizard.c:
4161 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4162 * src/widgets/modest-validating-entry.c:
4163 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4164 Modest prefix instead of an EasySetup prefix.
4166 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4168 * src/widgets/modest-validating-entry.h:
4169 * src/widgets/modest-validating-entry.c: (on_insert_text),
4170 Added easysetup_validating_entry_set_max_func(), used to set a callback
4171 to call when the max number of characters is reached. GtkEntry has a max-length
4172 already but is silent about it.
4174 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4175 (create_page_account_details), (create_page_user_details),
4177 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4178 (create_page_account_details), (create_page_user_details),
4179 (create_page_outgoing):
4180 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4181 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4182 the UI spec, when the user tries to enter more than the max number of characters.
4184 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4186 * src/maemo/easysetup/modest-easysetup-wizard.c:
4187 (create_page_user_details), (create_page_custom_incoming),
4188 (create_page_custom_outgoing):
4189 * src/maemo/modest-account-settings-dialog.c:
4190 (create_page_user_details), (create_page_incoming),
4191 (create_page_outgoing):
4192 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4193 (modest_connection_specific_smtp_edit_window_init):
4194 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4195 not appropriate. Bad Maemo-specific defaults!.
4197 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4199 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4200 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4201 (modest_signature_editor_dialog_set_settings):
4202 Disable the label and textview when the checkbox is disabled, and use the
4203 specified (UI spec) default signature text.
4205 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4207 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4208 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4210 * src/modest-defs.h:
4211 * src/modest-account-mgr-helpers.h:
4212 * src/modest-account-mgr-helpers.c:
4213 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4215 * src/maemo/Makefile.am:
4216 * src/maemo/modest-signature-editor-dialog.c:
4217 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4220 * src/maemo/modest-account-settings-dialog.h:
4221 * src/maemo/modest-account-settings-dialog.c:
4222 (modest_account_settings_dialog_finalize), (on_button_signature),
4223 (save_configuration): Use the new dialog when the Edit button is pressed, and
4224 save the changes if necessary, as per the UI spec.
4226 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4228 * src/maemo/Makefile.am:
4229 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4230 based on maemo-develoers email from Dirk.
4232 * src/maemo/easysetup/modest-easysetup-wizard.c:
4233 (create_page_welcome), (create_page_account_details),
4234 (create_page_user_details), (create_page_complete_easysetup),
4235 (create_page_custom_incoming), (create_page_custom_outgoing),
4236 (create_page_complete_custom),
4237 (modest_easysetup_wizard_dialog_init):
4238 * src/maemo/modest-account-settings-dialog.c:
4239 (create_page_account_details), (create_page_user_details),
4240 (create_page_incoming), (create_page_outgoing),
4241 (modest_account_settings_dialog_init):
4242 * src/maemo/modest-connection-specific-smtp-window.c:
4243 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4245 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4247 * src/maemo/easysetup/modest-easysetup-wizard.c:
4248 (create_page_account_details), (create_page_custom_outgoing),
4249 (create_page_complete_custom):
4250 * src/maemo/modest-account-settings-dialog.c:
4251 (create_page_user_details), (create_page_incoming),
4252 (create_page_outgoing):
4253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4254 (modest_connection_specific_smtp_edit_window_init):
4255 Use the correct (UI spec) port min/max, and use horizontal separators,
4258 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4260 * src/maemo/easysetup/modest-easysetup-wizard.c:
4261 (set_default_custom_servernames):
4262 * src/maemo/modest-account-settings-dialog.c:
4263 (create_page_incoming), (on_combo_outgoing_security_changed),
4264 (on_combo_incoming_security_changed), (create_page_outgoing),
4265 (modest_account_settings_dialog_set_account_name),
4266 (save_configuration):
4267 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4268 (on_combo_security_changed),
4269 (modest_connection_specific_smtp_edit_window_init),
4270 (modest_connection_specific_smtp_edit_window_set_connection),
4271 (modest_connection_specific_smtp_edit_window_get_settings):
4272 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4275 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4278 * src/maemo/easysetup/modest-easysetup-wizard.c:
4279 (create_page_custom_outgoing), (create_page_complete_custom):
4280 * src/maemo/modest-account-settings-dialog.c:
4281 (create_page_user_details), (create_page_outgoing):
4282 * src/maemo/modest-account-view-window.c: (button_box_new):
4283 Use changed logical IDs as per the most recent UI spec:
4284 mcen_bd_emailsetup_edit -> mcen_bd_edit
4285 mcen_bd_emailsetup_delete -> mcen_bd_delete
4286 mcen_bd_emailsetup_close -> mcen_bd_close
4288 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4292 * src/dbus_api/Makefile.am:
4293 * src/dbus_api/modest-dbus-callbacks.c:
4294 * src/dbus_api/modest-dbus-callbacks.h:
4295 * src/maemo/modest-platform.c: (modest_platform_init):
4296 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4298 * tests/Makefile.am:
4299 * tests/dbus_api/Makefile.am:
4300 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4302 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4304 * src/maemo/modest-account-settings-dialog.c:
4305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4306 Removed unnecessary includes.
4308 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4310 * src/maemo/easysetup/modest-easysetup-wizard.c:
4311 * src/maemo/modest-account-settings-dialog.c:
4312 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4313 * src/widgets/Makefile.am:
4314 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4315 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4316 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4317 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4318 * src/widgets/modest-secureauth-combo-box.c:
4319 * src/widgets/modest-secureauth-combo-box.h:
4320 * src/widgets/modest-serversecurity-combo-box.c:
4321 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4322 made the GObject names more consistent with the rest of the Modest code.
4324 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4326 * src/maemo/easysetup/Makefile.am:
4327 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4328 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4329 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4330 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4331 * src/maemo/easysetup/modest-easysetup-wizard.c:
4332 * src/maemo/easysetup/modest-validating-entry.c:
4333 * src/maemo/easysetup/modest-validating-entry.h:
4334 * src/maemo/modest-account-settings-dialog.c:
4335 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4336 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4337 widgets/ because they are used outside of easysetup too. After checking in,
4338 svn will allow me to rename them too.
4340 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4342 * src/gnome/modest-msg-edit-window.c:
4343 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4344 linker error, to fix the build on the GNOME platform.
4345 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4346 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4347 ifdefed out to avoid a warning.
4349 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4351 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4352 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4353 some alternative for GTK+ 2.6.
4355 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4357 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4359 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4360 specified for EmailAccountsDialog in UI spec.
4362 * src/maemo/easysetup/modest-easysetup-wizard.c:
4363 * src/maemo/easysetup/modest-easysetup-wizard.h:
4364 * src/maemo/modest-account-settings-dialog.c:
4365 * src/maemo/modest-account-settings-dialog.h:
4366 Reuse a member window widget for the connection-specific SMTP server accounts,
4367 so we can tell it to create/save the accounts only if we actually save changes.
4369 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4370 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4371 (modest_connection_specific_smtp_edit_window_get_settings):
4372 Return a struct instance for temporarily remembering the entered data.
4374 * src/maemo/modest-connection-specific-smtp-window.h:
4375 * src/maemo/modest-connection-specific-smtp-window.c:
4376 (modest_connection_specific_smtp_window_finalize),
4377 (modest_connection_specific_smtp_window_fill_with_connections),
4379 (modest_connection_specific_smtp_window_save_server_accounts),
4380 (update_model_server_names): Do not actually save data until asked,
4381 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4383 (on_selection_changed),
4384 (modest_connection_specific_smtp_window_init): Disable the edit
4385 button when nothing is selected.
4387 * src/modest-account-mgr-helpers.c:
4388 * src/modest-account-mgr-helpers.h:
4389 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4392 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4394 * src/modest-account-mgr-helpers.h:
4395 * src/modest-account-mgr-helpers.c:
4396 (modest_account_mgr_get_unused_account_name),
4397 (modest_account_mgr_get_unused_account_display_name): Added these
4398 utility functions, to avoid code duplication.
4400 * src/maemo/easysetup/modest-easysetup-wizard.c:
4401 (create_page_account_details), (create_account):
4402 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4403 (on_combo_security_changed),
4404 (modest_connection_specific_smtp_edit_window_init),
4405 (modest_connection_specific_smtp_edit_window_save_settings):
4406 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4407 * src/maemo/modest-connection-specific-smtp-window.c:
4408 (modest_connection_specific_smtp_window_finalize),
4409 (modest_connection_specific_smtp_window_fill_with_connections),
4410 (on_button_edit), (modest_connection_specific_smtp_window_init):
4411 * src/maemo/modest-connection-specific-smtp-window.h:
4412 Implementing saving of connection-specific server accounts.
4414 But I need to refactor this so we can save the data for each
4415 possible connection-specific account and only actually create the server accounts
4416 when the easysetup finished, or the OK button is pressed on the account settings
4419 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4421 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4422 (on_combo_security_changed):
4423 (modest_connection_specific_smtp_edit_window_init):
4424 Auto-fill the port number as in the account settings.
4426 (modest_connection_specific_smtp_edit_window_set_connection):
4427 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4428 * src/maemo/modest-connection-specific-smtp-window.c:
4429 (fill_with_connections), (on_button_edit),
4430 (modest_connection_specific_smtp_window_init):
4431 Turn the edit window into a dialog to simplify the code, and
4432 set a WM hint as in a GtkDialog, because only a popup can be on top of
4433 another window in Maemo, and popups usually have no WM decoration.
4435 * src/modest-defs.h:
4436 * src/modest-account-mgr-helpers.c:
4437 (modest_account_mgr_set_connection_specific_smtp),
4438 (modest_account_mgr_remove_connection_specific_smtp),
4439 (modest_account_mgr_get_connection_specific_smtp):
4440 * src/modest-account-mgr-helpers.h: Some functions to write the
4441 connection-specific SMTP server information. Not yet used.
4444 * src/widgets/modest-folder-view.c: (text_cell_data):
4445 Fix a warning about an uninitialized variable.
4446 (on_configuration_key_changed): Put an #ifdef around the use
4447 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4449 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4451 * src/maemo/modest-account-settings-dialog.h:
4452 * src/maemo/modest-account-settings-dialog.c:
4453 Added connect_for_modified() utility function to mark the new modified boolean.
4455 (create_page_account_details), (create_page_user_details),
4456 (create_page_incoming), (create_page_outgoing), (on_response),
4457 (modest_account_settings_dialog_init),
4458 (modest_account_settings_dialog_set_account_name):
4459 Only warn about unsaved changes when there are actually unsaved changes.
4461 * src/modest-account-mgr-helpers.c:
4462 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4463 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4464 to get the data from there in future.
4466 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4468 * src/modest-defs.h:
4470 * src/modest-account-mgr-helpers.h:
4471 * src/modest-account-mgr-helpers.c:
4472 Store the security account setting in a single conf key instead of using
4473 the options list, so that the list is left for just the to-be-removed camel hack,
4474 and because gconf_client_set_list() is failing for some reason.
4476 * src/modest-account-mgr.c:
4477 (modest_account_mgr_add_server_account):
4478 * src/maemo/modest-account-settings-dialog.c:
4479 (modest_account_settings_dialog_set_account_name),
4480 (save_configuration): Use the renamed functions.
4483 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4485 * src/widgets/Makefile.am:
4486 * src/widgets/modest-limit-retrieve-combo-box.c:
4487 * src/widgets/modest-limit-retrieve-combo-box.h:
4488 * src/widgets/modest-retrieve-combo-box.c:
4489 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4490 the account settings dialog.
4492 * src/modest-defs.h:
4493 * src/modest-account-mgr-helpers.h:
4494 * src/modest-account-mgr-helpers.c:
4495 (modest_server_account_get_option_secure_auth),
4496 (modest_server_account_set_option_secure_auth):
4497 * src/modest-account-mgr.c:
4498 (modest_account_mgr_add_server_account):
4499 Use the existing AUTH_MECH conf key for the secure-auth setting,
4500 instead of putting it in the list options, because this was actually used already.
4502 * src/maemo/modest-account-settings-dialog.c:
4503 (create_page_account_details),
4504 (modest_account_settings_dialog_set_account_name),
4505 (save_configuration):
4506 * src/maemo/modest-account-settings-dialog.h:
4507 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4508 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4510 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4512 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4513 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4514 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4516 * src/modest-defs.h:
4517 * src/maemo/modest-account-settings-dialog.c:
4518 (create_page_incoming), (on_combo_outgoing_security_changed),
4519 (on_combo_incoming_security_changed), (create_page_outgoing),
4520 (modest_account_settings_dialog_set_account_name),
4521 (save_configuration): Load/Save the port number, and change it when the
4522 security combo changes, to suitable defaults.
4524 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4526 * src/modest-account-mgr.c:
4527 (modest_account_mgr_add_server_account): Set the security and secure-auth
4528 options, and add a comment saying that the other camel-specific options should be
4531 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4533 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4535 * src/modest-tny-account-store.c: (account_list_free),
4536 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4537 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4540 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4542 * src/modest-protocol-info.c:
4543 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4544 is required by our UI spec. Maybe something in our implementation will use this eventually.
4545 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4546 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4547 instead of the previous 0 placeholder.
4549 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4550 secure-auth settings.
4551 * src/modest-account-mgr-helpers.h:
4552 * src/modest-account-mgr-helpers.c:
4553 (modest_server_account_data_get_option_secure_auth),
4554 (modest_server_account_set_option_secure_auth),
4555 (modest_server_account_data_get_option_security),
4556 (modest_server_account_set_option_security): Added this API for getting and setting the security
4557 and secure-auth settings.
4559 * src/maemo/modest-account-settings-dialog.h:
4560 * src/maemo/modest-account-settings-dialog.c:
4561 (modest_account_settings_dialog_finalize), (check_data),
4562 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4563 about changing titles.
4564 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4565 (save_configuration): Save the security and secure-auth settings.
4567 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4568 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4570 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4572 * src/modest-defs.h:
4573 * src/modest-account-mgr.c:
4574 (modest_account_mgr_add_server_account):
4575 Added and used defines for the options key and value pair strings,
4576 that are used so far, though they do not seem to correspond to anything in our
4577 UI specs or ModestProtocol enum.
4579 * src/modest-account-mgr-helpers.h:
4580 * src/modest-account-mgr-helpers.c:
4581 (compare_option_strings_for_name),
4582 (modest_server_account_data_get_option_value),
4583 (modest_server_account_data_get_option_bool),
4584 (modest_account_mgr_get_server_account_option):
4585 Added helper functions for parsing the options GSList.
4587 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4589 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4590 display name is based on the supplied account name.
4591 * src/modest-account-mgr.c:
4592 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4593 with an inefficient, but good-enough, implementation.
4595 * src/maemo/easysetup/modest-easysetup-wizard.c:
4596 (create_page_account_details), (on_before_next), (create_account):
4597 Check for existing display names rather than (non-user-visible) account names, and just
4598 create and set a unique account name at the end.
4600 * src/maemo/modest-account-settings-dialog.c:
4601 (modest_account_settings_dialog_init),
4602 (modest_account_settings_dialog_set_account_name),
4603 (create_page_incoming): Show the display name, instead of the account name.
4604 (on_response): Do some (not all) extra checks, as in the UI spec.
4605 (save_configuration): Save the display name if it was changed.
4607 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4609 * po/en_GB.po: Added needed logical ID and translation.
4610 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4611 (init_view): Made the is-default column clicking work.
4613 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4616 * src/maemo/easysetup/Makefile.am:
4617 * src/maemo/easysetup/modest-easysetup-wizard.c:
4618 (modest_easysetup_wizard_dialog_init):
4619 * src/maemo/easysetup/provider-data-test.keyfile:
4620 * src/maemo/easysetup/provider-data.keyfile:
4621 Moved the provider data file to the new modest-providers-data package and used it from there.
4623 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4625 * src/modest-local-folder-info.c:
4626 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4627 N_() was already used on the static strings, but this just marks it for translation without
4628 using the translation.
4630 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4632 * src/maemo/modest-account-settings-dialog.c:
4633 (create_page_incoming),
4634 (modest_account_settings_dialog_set_account_name):
4635 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4636 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4637 I will do this if nobody else gets there first.
4639 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4641 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4642 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4643 save the security stuff.
4645 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4647 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4648 Set the email address and user fullname, which I now see must be
4651 * src/maemo/modest-account-settings-dialog.h:
4652 * src/maemo/modest-account-settings-dialog.c:
4654 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4655 leave-on-server and authentication.
4656 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4659 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4662 * src/maemo/modest-account-settings-dialog.c:
4663 * src/maemo/modest-account-settings-dialog.h:
4664 Most (but not all) of the widgets are now present as specified by the UI spec.
4665 No changes are yet saved, and some details are not properly shown yet.
4667 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4669 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4671 * src/maemo/Makefile.am:
4672 * src/maemo/modest-account-settings-dialog.c:
4673 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4674 an existing account. Doesn't do much yet.
4676 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4677 Open the accounts settings dialog when Edit is clicked.
4679 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4681 * src/maemo/easysetup/Makefile.am:
4682 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4684 * src/maemo/easysetup/modest-easysetup-wizard.c:
4685 (modest_easysetup_wizard_dialog_init):
4686 Try to get the source directory from the build system,
4687 instead of hard-coding "./" into the source code, when opening our local
4688 copies of the configuration files.
4689 But this still fails when opening the wizard from the Accounts window,
4690 maybe because the working directory seems to change at runtime.
4691 So the wizard will fail the second time unless you copy the files into their
4692 proper locations - see the stdout warnings for the paths.
4694 (create_page_account_details),(on_before_next):
4695 Check for existing non-server accounts instead of server accounts,
4696 so the default account name is useful again, and to prevent trying to
4699 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4700 Show the wizard when New is clicked.
4702 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4703 (init_view): Show the column headers, and show the columns that are
4704 specified in the UI specs. However, something in Maemo's GTK+ prevents
4705 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4706 change the default account. This is despite unsetting the special properties.
4708 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4710 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4711 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4712 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4713 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4714 to make that clearer.
4715 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4717 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4719 * src/maemo/modest-account-view-window.c:
4720 (modest_account_view_window_init),
4721 (modest_account_view_window_new):
4722 Use the same buttons as specified in the
4723 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4724 the existing widgets, which never had a chance of working.
4725 Put the ModestAccountView treeview in a scrolled window.
4726 Do not repeat the initialization in both _init() and _new().
4728 * src/widgets/modest-account-view.c: (update_account_view):
4729 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4730 this widget and window shows no accounts.
4732 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4734 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4736 * src/maemo/easysetup/modest-easysetup-wizard.c:
4737 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4738 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4739 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4742 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4743 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4744 accounts exist yet, as in the UI spec.
4746 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4748 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4750 * src/maemo/Makefile.am:
4751 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4752 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4753 New window for editing connection-specific smtp details.
4754 Not fully implemented.
4756 * src/maemo/modest-connection-specific-smtp-window.c:
4757 (modest_connection_specific_smtp_window_finalize) :
4758 unref the tree model.
4759 (on_button_edit): Show the edit window.
4761 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4763 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4766 * src/maemo/Makefile.am:
4767 * src/maemo/modest-connection-specific-smtp-window.c:
4768 * src/maemo/modest-connection-specific-smtp-window.h:
4769 New window for showing the list of connections, for connection-specific
4770 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4771 * src/maemo/easysetup/modest-easysetup-wizard.c:
4772 (create_page_custom_outgoing): Show the new window when the button is clicked.
4774 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4776 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4777 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4778 * src/maemo/modest-msg-edit-window.c:
4779 (modest_msg_edit_window_insert_image):
4780 * src/modest-conf.c: (modest_conf_key_escape):
4781 * src/modest-mail-operation.c:
4782 (modest_mail_operation_send_new_mail):
4783 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4784 (modest_ui_actions_on_new_account):
4785 * src/widgets/modest-attachment-view.c: (update_filename_request):
4786 * src/widgets/modest-mail-header-view.c:
4787 Corrected warnings that were breaking the build, by commenting out unused variables,
4788 and a function, and by including a header.
4790 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4792 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4793 so we can #ifdef around platform-specific code when necessary.
4794 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4795 to allow this to build for the GNOME platform too.
4797 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4799 * src/maemo/easysetup/modest-easysetup-wizard.c:
4800 Added util_increment_name() and used it in create_page_account_details()
4801 to make sure that the default account name is always a new name.
4803 (modest_easysetup_wizard_dialog_init),
4804 (set_default_custom_servernames): Some minor memory management fixes.
4806 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4810 * src/modest-runtime.c: (init_i18n): Restored the translation
4811 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4812 are defined in config.h, and the translations are installed.
4814 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4815 is defined for translation.
4817 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4819 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4821 * src/maemo/easysetup/modest-easysetup-wizard.c:
4822 (modest_easysetup_wizard_dialog_init):
4823 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4824 Use realistic paths (though they should use $prefix generically) to the
4825 mcc_mapping and provider-data.keyfile files which might work when they
4826 are installed by the future version of the operator-wizard package,
4827 and then fallback to paths in our source code, with an explanatory
4830 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4834 * src/maemo/Makefile.am:
4835 * src/maemo/easysetup/: Added files from the previously-exernal
4836 osso-modest-easysetup.
4837 * src/maemo/modest-main-window-ui.h:
4838 * src/modest-ui-actions.c:
4839 * src/modest-ui-actions.h:
4840 Added modest_ui_actions_on_new_account() as a signal handler for the
4841 New Account menu item. It shows the easysetup wizard.
4842 * po/en_GB.po: Added additional needed logical IDs and translations.